Re: weakness of runnable load tracking?

2012-12-05 Thread Preeti U Murthy
Hi Alex, Hi Paul Ingo: In a short word of this issue: burst forking/waking tasks have no time accumulate the load contribute, their runnable load are taken as zero. On performing certain experiments on the way PJT's metric calculates the load,I observed a few things.Based on these

Re: [PATCH V3 RFC 2/2] kvm: Handle yield_to failure return code for potential undercommit case

2012-12-05 Thread Raghavendra K T
On 12/04/2012 01:26 AM, Marcelo Tosatti wrote: On Wed, Nov 28, 2012 at 10:40:56AM +0530, Raghavendra K T wrote: On 11/28/2012 06:42 AM, Marcelo Tosatti wrote: Don't understand the reasoning behind why 3 is a good choice. Here is where I came from. (explaining from scratch for completeness,

Re: Regulator suspend state dt question

2012-12-05 Thread Abhilash Kesavan
Hi Mark, On Thu, Dec 6, 2012 at 11:58 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Dec 06, 2012 at 11:55:11AM +0530, Abhilash Kesavan wrote: As of now there is no support in the regulator core to specify the suspend state (mode, enabled/disabled) using dt. I can add new

Re: [PATCH 3/6] staging/rtl8192u: indent with tabs, not spaces

2012-12-05 Thread Dan Carpenter
On Wed, Dec 05, 2012 at 09:40:20PM +0100, Sebastian Hahn wrote: Converted staging/rtl8187se to use tabs instead of spaces for indentation to fix the checkpatch error code indent should use tabs where possible. Signed-off-by: Sebastian Hahn snseh...@cip.cs.fau.de ---

[PULL] (Was Re: [PATCH 3.7-rc8] lib/Makefile: Fix oid_registry build dependency)

2012-12-05 Thread Rusty Russell
Tim Gardner tim.gard...@canonical.com writes: It is $(obj)/oid_registry.o that is dependent on $(obj)/oid_registry_data.c. The object file cannot be built until $(obj)/oid_registry_data.c has been generated. A periodic and hard to reproduce parallel build failure is due to this incorrect

Re: [PATCH] KVM: MMU: optimize for set_spte

2012-12-05 Thread Gleb Natapov
On Tue, Dec 04, 2012 at 07:17:11AM +0800, Xiao Guangrong wrote: There are two cases we need to adjust page size in set_spte: 1): the one is other vcpu creates new sp in the window between mapping_level() and acquiring mmu-lock. 2): the another case is the new sp is created by itself

Re: [PATCH 3/6 v9] gpio: Add userland device interface to block GPIO

2012-12-05 Thread Wolfgang Grandegger
On 12/05/2012 11:20 PM, Roland Stigge wrote: Hi Wolfgang, On 05/12/12 20:01, Wolfgang Grandegger wrote: + for (i = 0; i block-ngpio; i++) { + status = gpio_request(block-gpio[i], gpioblock dev); You could use the name of the GPIO block. OK. + if (status) +

Re: [PATCH v5 5/8] fat: restructure export_operations

2012-12-05 Thread Namjae Jeon
2012/12/5, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: I can understand what is doing. I'm asking why there is difference. 1) generic_fh_to_dentry() allows (*_PARENT fh_len == 2). 2) fat_fh_to_dentry_nostale() doesn't allows (*_PARENT fh_len == 3).

Re: [PATCH] pwm: i.MX: eliminate build warning

2012-12-05 Thread Sascha Hauer
On Wed, Dec 05, 2012 at 04:34:41PM +0100, Lothar Waßmann wrote: compiling the i.MX pwm driver produces the following warning: |drivers/pwm/pwm-imx.c: In function 'imx_pwm_probe': |drivers/pwm/pwm-imx.c:281:7: warning: assignment discards qualifiers from pointer target type Apply a 'const'

[PATCH 1/2] mtd: mxc_nand: fix unbalanced clk_disable() in error path

2012-12-05 Thread Lothar Waßmann
If nand_scan_ident() or nand_scan_tail() fails, the NAND chip may have been deselected and the clock already disabled. Thus, check 'clk_act' in the error path to decide whether the clock still needs to be disabled. This fixes a: |WARNING: at drivers/clk/clk.c:472 __clk_disable+0x3c/0x78()

[PATCH 2/2] mtd: mxc_nand: reorder part_probes to let cmdline override other sources

2012-12-05 Thread Lothar Waßmann
The cmdline is the easiest to change source of information. Thus let it take precedence over 'RedBoot' and 'ofpart'. This makes the mxc_nand driver to be in sync with all other NAND drivers that support 'cmdlinepart' partition parsing. Also change 'const char *' to 'const char const *' as advised

[RFC] gpiolib: introduce descriptor-based GPIO interface

2012-12-05 Thread Alexandre Courbot
Just a RFC to check if the direction seems good before going onward with more serious work. This patch introduces a set of gpiod_* functions that work like their gpio_* counterparts, but use opaque descriptors instead of integers. The current integer-based GPIO namespace is bad because it allows

[RFC] gpiolib: introduce descriptor-based GPIO interface

2012-12-05 Thread Alexandre Courbot
With the current API, GPIOs are manipulated through an integer which represents their unique number across the system. This poses problems in terms of portability, scalability and flexibility: for instance, the number of valid GPIOs for a given system is fixed at system time, and a large array of

Re: [PATCH 1/2] mtd: mxc_nand: fix unbalanced clk_disable() in error path

2012-12-05 Thread Sascha Hauer
On Thu, Dec 06, 2012 at 08:42:27AM +0100, Lothar Waßmann wrote: If nand_scan_ident() or nand_scan_tail() fails, the NAND chip may have been deselected and the clock already disabled. Thus, check 'clk_act' in the error path to decide whether the clock still needs to be disabled. This fixes

Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-05 Thread Dmitry Torokhov
Hi Benson, On Wed, Dec 05, 2012 at 04:48:19PM -0800, Benson Leung wrote: This patch introduces a driver for Cypress All Points Addressable I2C Trackpad, including the ones in 2012 Samsung Chromebooks. This device is compatible with MT protocol type B, providing identifiable contacts.

[PATCH v2] of: Output devicetree alias names in uevent

2012-12-05 Thread Stepan Moskovchenko
In some situations, userspace may want to resolve a device by function and logical number (ie, serial0) rather than by the base address or full device path. Being able to resolve a device by alias frees userspace from the burden of otherwise having to maintain a mapping between device addresses

Re: [PATCH v5 1/3] input: increase struct ps2dev cmdbuf[] to 8 bytes

2012-12-05 Thread Dmitry Torokhov
Hi Kamal, On Wed, Dec 05, 2012 at 04:16:14PM -0800, Kamal Mostafa wrote: Cypress PS/2 Trackpad (drivers/input/mouse/cypress_ps2.c) needs this larger cmdbuf[] to handle 8-byte packet responses. Signed-off-by: Kamal Mostafa ka...@canonical.com I will apply this patch so you do not need to

Re: [PATCH v5 3/3] input: Cypress PS/2 Trackpad link into psmouse-base

2012-12-05 Thread Dmitry Torokhov
Hi Kamal, On Wed, Dec 05, 2012 at 04:16:16PM -0800, Kamal Mostafa wrote: From: Dudley Du d...@cypress.com Original code contributed by Dudley Du (Cypress Semiconductor Corporation), modified by Kamal Mostafa. BugLink: http://launchpad.net/bugs/978807 Please fold it into the cypress_ps2

Re: [PATCH] pwm: i.MX: eliminate build warning

2012-12-05 Thread Thierry Reding
On Wed, Dec 05, 2012 at 04:34:41PM +0100, Lothar Waßmann wrote: compiling the i.MX pwm driver produces the following warning: |drivers/pwm/pwm-imx.c: In function 'imx_pwm_probe': |drivers/pwm/pwm-imx.c:281:7: warning: assignment discards qualifiers from pointer target type Apply a 'const'

8250 UART doesn't work

2012-12-05 Thread Woody Wu
Hi, list Does anyone here familiar to the serial 8250 driver? I enabled two uart ports in my board definition, but the ports doesn't appear after I loaded the kernel (3.4.19). I discovered, it failed at the UART port auto configuration stage, the exact function is autoconfig(...) in

Re: [PATCH 0/3] pwm: lpc32xx - Various small fixes

2012-12-05 Thread Thierry Reding
On Wed, Nov 14, 2012 at 12:58:12PM +0100, Alban Bedel wrote: A few fixes for the LPC32 PWM driver: * [PATCH 1/3] pwm: lpc32xx - Fix the PWM polarity * [PATCH 2/3] pwm: lpc32xx - Properly disable the clock on device remove * [PATCH 3/3] pwm: lpc32xx - Set the chip base for dynamic allocation

Re: [PATCH v3] drivers: cma: represent physical addresses as phys_addr_t

2012-12-05 Thread Marek Szyprowski
Hello, On 12/5/2012 3:29 PM, Vitaly Andrianov wrote: This commit changes the CMA early initialization code to use phys_addr_t for representing physical addresses instead of unsigned long. Without this change, among other things, dma_declare_contiguous() simply discards any memory regions whose

[PATCH v10 0/2] x86: vmclear vmcss on all cpus when doing kdump if necessary

2012-12-05 Thread Zhang Yanfei
Currently, kdump just makes all the logical processors leave VMX operation by executing VMXOFF instruction, so any VMCSs active on the logical processors may be corrupted. But, sometimes, we need the VMCSs to debug guest images contained in the host vmcore. To prevent the corruption, we should

Re: [PATCH] xen/blkback: do not leak mode property

2012-12-05 Thread Jan Beulich
>>> On 04.12.12 at 19:21, Olaf Hering wrote: > On Tue, Dec 04, Jan Beulich wrote: > >> This looks necessary but insufficient - there's nothing really >> preventing backend_changed() from being called more than once >> for a given device (is simply the handler of xenbus watch). Hence >> I think

Re: [PATCH] memory: of_memory.c: remove unnecessary initialization

2012-12-05 Thread Li, Zhen-Hua
And if you use -O2 as gcc option, you may find it does nothing. They are using the same assemble language. On Wed, Dec 5, 2012 at 3:26 PM, Li, Zhen-Hua wrote: > Infact, your patch does remove an orl operation, but add a new "move" > operation. > > You can test such two functions: > int

[PATCH v10 1/2] x86/kexec: VMCLEAR VMCSs loaded on all cpus if necessary

2012-12-05 Thread Zhang Yanfei
This patch provides a way to VMCLEAR VMCSs related to guests on all cpus before executing the VMXOFF when doing kdump. This is used to ensure the VMCSs in the vmcore updated and non-corrupted. Signed-off-by: Zhang Yanfei --- arch/x86/include/asm/kexec.h |2 ++ arch/x86/kernel/crash.c |

Re: [PATCH v10 2/2] KVM-INTEL: provide the vmclear function and a bitmap to support VMCLEAR in kdump

2012-12-05 Thread Zhang Yanfei
The vmclear function will be assigned to the callback function pointer when loading kvm-intel module. And the bitmap indicates whether we should do VMCLEAR operation in kdump. The bits in the bitmap are set/unset according to different conditions. Signed-off-by: Zhang Yanfei ---

Re: [PATCH] staging: rtl8712: avoid a useless call to memset().

2012-12-05 Thread walter harms
Hi Cyril, you patch is correct ..but being an advocate of defensive programming i would say the original version especially since the number of bytes is small. re, wh Am 05.12.2012 02:22, schrieb Cyril Roelandt: > In r8711_wx_get_wap(), make sure we do not call memcpy() on a memory area that >

Re: [RFC v2 6/8] gpu: drm: tegra: Remove redundant host1x

2012-12-05 Thread Thierry Reding
On Mon, Nov 26, 2012 at 03:19:12PM +0200, Terje Bergstrom wrote: > From: Arto Merilainen > > This patch removes the redundant host1x driver from tegradrm and > makes necessary bindings to the separate host driver. > > This modification introduces a regression: Because there is no > general

[PATCH -next 0/2] tty: Correct tty buffer flush.

2012-12-05 Thread Ilya Zykov
The root of problem is carelessly zeroing pointer(in function __tty_buffer_flush()), when another thread can use it. It can be cause of "NULL pointer dereference". Main idea of the patch, this is never free last (struct tty_buffer) in the active buffer. Only flush the data for

[PATCH -next 1/2] tty: Correct tty buffer flush.

2012-12-05 Thread Ilya Zykov
Revert: tty: hold lock across tty buffer finding and buffer filling Signed-off-by: Ilya Zykov --- drivers/tty/tty_buffer.c | 94 +++--- 1 files changed, 22 insertions(+), 72 deletions(-) diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c

[PATCH -next 2/2] tty: Correct tty buffer flush.

2012-12-05 Thread Ilya Zykov
tty: Correct tty buffer flush. Signed-off-by: Ilya Zykov --- drivers/tty/tty_buffer.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c index 7602df8..8ad 100644 --- a/drivers/tty/tty_buffer.c +++

Re: [PATCH v5 5/8] fat: restructure export_operations

2012-12-05 Thread OGAWA Hirofumi
Namjae Jeon writes: >>> Let me think, if ‘subtree’ checking is enabled then we should check >>> the length condition over here also? Please share if there are any >>> other comments also. >> >> I'm not sure what did you mean. Where is "subtree" check you are >> talking? This is fh_to_dentry(),

Re: [PATCH v5 7/8] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-12-05 Thread OGAWA Hirofumi
Namjae Jeon writes: This became much better than before. However, we have to consolidate the code with fat_search_long() finally. E.g. this version is having the issue already fixed. If there is corruption in fat cluster-chain, it lead to infinite loop.

[PATCH v2] drivers/uio/uio_pdrv_genirq.c: Fix memory freeing issues

2012-12-05 Thread Vitalii Demianets
1. uioinfo was kfreed based on the presence of pdev->dev.of_node, which was obviously wrong and unrelated to the fact if uioinfo was allocated statically or dynamically. This patch introduces new flag which clearly shows if uioinfo was allocated dynamically and kfrees uioinfo based on that flag;

Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-05 Thread Russell King - ARM Linux
On Wed, Dec 05, 2012 at 09:59:07AM +0900, Jingoo Han wrote: > - if (gpio_is_valid(lcd->gpio_backlight_cont)) > - gpio_set_value(lcd->gpio_backlight_cont, cont); > + if (gpio_is_valid(lcd->gpio_backlight_cont)) { > + if (gpio_cansleep(lcd->gpio_backlight_cont)) > +

Re: [PATCH -next 2/2] tty: Correct tty buffer flush.

2012-12-05 Thread Jiri Slaby
On 12/05/2012 09:48 AM, Ilya Zykov wrote: > tty: Correct tty buffer flush. NAK just because of the insufficient commit log. That line does not belong here. Instead, please add here proper description as you have already done before. IOW what is in 0/2 should be here so that we know the reasons.

RE: [PATCH v2] net/macb: Use non-coherent memory for rx buffers

2012-12-05 Thread David Laight
> If I understand well, you mean that the call to: > > dma_sync_single_range_for_device(>pdev->dev, phys, > pg_offset, frag_len, DMA_FROM_DEVICE); > > in the rx path after having copied the data to skb is not needed? > That is also the conclusion that

Re: [PATCH RFC] misc/at24: distinguish between eeprom and fram chips

2012-12-05 Thread Lars Poeschel
I see there where to much "no"s to get anything in, but thank you for your comments and explanations. > > I wanted to use a fm24c04 i2c fram chip with linux. I grepped the source > > and found nothing. I later found that my chip can be handled by at24 > > eeprom driver. It creates a sysfs file

Re: [PATCH 07/14] HID: i2c-hid: fix return paths

2012-12-05 Thread Jean Delvare
On Tue, 4 Dec 2012 16:27:48 +0100, Benjamin Tissoires wrote: > Forwards appropriate return values. > As noone use the error returned by i2c_hid_get_input, let's make it > returning void. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/i2c-hid/i2c-hid.c | 24 >

[PATCH] gpio: twl4030: Correct status reporting when the GPIO is used as output

2012-12-05 Thread Peter Ujfalusi
When the GPIO is configured as output we need to read the GPIODATAOUT* register to get correct information. When the GPIO is output the GPIODATAIN* registers report 0 all the time (no feedback from output path). Signed-off-by: Peter Ujfalusi --- drivers/gpio/gpio-twl4030.c | 8 +++- 1 file

Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source

2012-12-05 Thread Michal Marek
On Wed, Dec 05, 2012 at 08:39:11AM +0100, Takashi Iwai wrote: > At Wed, 05 Dec 2012 10:28:48 +1030, > Rusty Russell wrote: > > > > David Howells writes: > > > > > Michal Marek wrote: > > > > > >> Using the asm .incbin statement in C sources breaks any gcc wrapper which > > >> assumes that

Re: [PATCH 08/14] HID: i2c-hid: fix error messages

2012-12-05 Thread Jean Delvare
On Tue, 4 Dec 2012 16:27:49 +0100, Benjamin Tissoires wrote: > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/i2c-hid/i2c-hid.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c > index

Re: [PATCH 20/52] mm, numa: Implement migrate-on-fault lazy NUMA strategy for regular and THP pages

2012-12-05 Thread Mel Gorman
On Tue, Dec 04, 2012 at 04:55:13PM -0800, David Rientjes wrote: > Commit "mm, numa: Implement migrate-on-fault lazy NUMA strategy for > regular and THP pages" breaks the build because HPAGE_PMD_SHIFT and > HPAGE_PMD_MASK defined to explode without CONFIG_TRANSPARENT_HUGEPAGE: > > mm/migrate.c:

Re: [PATCH 01/14] HID: i2c-hid: change I2C name

2012-12-05 Thread Jiri Kosina
On Tue, 4 Dec 2012, Jean Delvare wrote: > > no I2C driver has "i2c" in its name. It makes more sense to call this > > i2c driver "hid". > > > > Signed-off-by: Benjamin Tissoires > > --- > > drivers/hid/i2c-hid/i2c-hid.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff

Re: [PATCH 03/14] HID: i2c-hid: enhance Kconfig

2012-12-05 Thread Jiri Kosina
On Tue, 4 Dec 2012, Jean Delvare wrote: > > The "comment" part can never be displayed, so we can remove it. > > > > Signed-off-by: Benjamin Tissoires > > --- > > drivers/hid/i2c-hid/Kconfig | 7 ++- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git

Re: [PATCH 04/14] HID: i2c-hid: fix checkpatch.pl warning

2012-12-05 Thread Jiri Kosina
On Tue, 4 Dec 2012, Jean Delvare wrote: > > We should not initialize to 0 static declarations. > > > > Signed-off-by: Benjamin Tissoires > > --- > > drivers/hid/i2c-hid/i2c-hid.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c

Re: [PATCH 05/14] HID: i2c-hid: fix i2c_hid_dbg macro

2012-12-05 Thread Jiri Kosina
On Tue, 4 Dec 2012, Jean Delvare wrote: > > This avoids the problematic case: > > > > if (condition) > > i2c_hid_dbg(ihid, "Blah blah %d\n", i); > > else > > do_something_very_important(); > > > > Which looks correct, however with the previous macro definition, > > this expands to the

Re: [PATCH 09/14] HID: i2c-hid: i2c_hid_get_report may fail

2012-12-05 Thread Jean Delvare
On Tue, 4 Dec 2012 16:27:50 +0100, Benjamin Tissoires wrote: > If i2c_hid_get_report fails, exit i2c_hid_init_report. > The printk log is already called by i2c_hid_get_report, so no need > to add some more printks. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/i2c-hid/i2c-hid.c | 5

Re: [PATCH] tmpfs: fix shared mempolicy leak

2012-12-05 Thread Mel Gorman
On Tue, Dec 04, 2012 at 11:24:30PM -0800, Hugh Dickins wrote: > From: Mel Gorman > > Commit 00442ad04a5e ("mempolicy: fix a memory corruption by refcount > imbalance in alloc_pages_vma()") changed get_vma_policy() to raise the > refcount on a shmem shared mempolicy; whereas shmem_alloc_page()

[PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-05 Thread Olaf Hering
backend_changed might be called multiple times, which will leak be->mode. free the previous value before storing the current mode value. Signed-off-by: Olaf Hering --- !! Not compile tested !! drivers/block/xen-blkback/xenbus.c | 12 +++- 1 file changed, 7 insertions(+), 5

Re: [PATCH 06/14] HID: i2c-hid: remove unused static declarations

2012-12-05 Thread Jiri Kosina
On Tue, 4 Dec 2012, Jean Delvare wrote: > > These definitions are not used here, but are defined by the specification. > > Keeping some of them for documentation purposes. > > > > Signed-off-by: Benjamin Tissoires > > --- > > drivers/hid/i2c-hid/i2c-hid.c | 25 ++--- > > 1

Re: PTRACE_SYSCALL && vsyscall (Was: arch_check_bp_in_kernelspace: fix the range check)

2012-12-05 Thread Jan Kratochvil
On Sun, 02 Dec 2012 20:30:58 +0100, Oleg Nesterov wrote: > Yes, that is why I said this needs the new option. I do not mind new options although personally I do not find them meaningful for an already deprecated ABI compatibility-only issue. > If the tracer does PTRACE_SYSCALL the tracee

Re: [PATCH 07/14] HID: i2c-hid: fix return paths

2012-12-05 Thread Jiri Kosina
On Tue, 4 Dec 2012, Benjamin Tissoires wrote: > Forwards appropriate return values. > As noone use the error returned by i2c_hid_get_input, let's make it > returning void. > > Signed-off-by: Benjamin Tissoires Applied. > --- > drivers/hid/i2c-hid/i2c-hid.c | 24 > 1

Re: [PATCH] memory: of_memory.c: remove unnecessary initialization

2012-12-05 Thread Cong Ding
On Wed, Dec 05, 2012 at 03:26:36PM +0800, Li, Zhen-Hua wrote: > Infact, your patch does remove an orl operation, but add a new "move" > operation. > > You can test such two functions: > int func1(int rm1, int rm2){ > int i = 0; > i |= rm1; > i |= rm2; > } > > and > >

Re: [RFC v2 6/8] gpu: drm: tegra: Remove redundant host1x

2012-12-05 Thread Terje Bergström
On 05.12.2012 10:33, Thierry Reding wrote: > I've been thinking about this some more and came to the conclusion that > since we will already have a tight coupling between host1x and tegra-drm > we may just as well keep the client registration code in host1x. The way > I imagine this to work would

Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source

2012-12-05 Thread Takashi Iwai
At Wed, 5 Dec 2012 10:50:57 +0100, Michal Marek wrote: > > On Wed, Dec 05, 2012 at 08:39:11AM +0100, Takashi Iwai wrote: > > At Wed, 05 Dec 2012 10:28:48 +1030, > > Rusty Russell wrote: > > > > > > David Howells writes: > > > > > > > Michal Marek wrote: > > > > > > > >> Using the asm .incbin

Re: [PATCH 09/14] HID: i2c-hid: i2c_hid_get_report may fail

2012-12-05 Thread Benjamin Tissoires
On Wed, Dec 5, 2012 at 10:59 AM, Jean Delvare wrote: > On Tue, 4 Dec 2012 16:27:50 +0100, Benjamin Tissoires wrote: >> If i2c_hid_get_report fails, exit i2c_hid_init_report. >> The printk log is already called by i2c_hid_get_report, so no need >> to add some more printks. >> >> Signed-off-by:

Re: [PATCH 08/14] HID: i2c-hid: fix error messages

2012-12-05 Thread Jiri Kosina
On Wed, 5 Dec 2012, Jean Delvare wrote: > > Signed-off-by: Benjamin Tissoires > > --- > > drivers/hid/i2c-hid/i2c-hid.c | 11 ++- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c > > index

Re: [PATCH 10/14] HID: i2c-hid: reorder allocation/free of buffers

2012-12-05 Thread Jean Delvare
On Tue, 4 Dec 2012 16:27:51 +0100, Benjamin Tissoires wrote: > Simplifies i2c_hid_alloc_buffers tests, and makes this function > responsible of the assignment of ihid->bufsize. > The condition for the reallocation in i2c_hid_start is then simpler. > > Signed-off-by: Benjamin Tissoires > --- >

Re: [PATCH 02/14] HID: i2c-hid: fix memory corruption due to missing hid declaration

2012-12-05 Thread Benjamin Tissoires
On Tue, Dec 4, 2012 at 10:42 PM, Jean Delvare wrote: > On Tue, 4 Dec 2012 16:27:43 +0100, Benjamin Tissoires wrote: >> HID descriptors contains 4 bytes of reserved field. >> The previous implementation was overriding the next fields in struct i2c_hid. >> >> Signed-off-by: Benjamin Tissoires >>

Re: [PATCH 10/14] HID: i2c-hid: reorder allocation/free of buffers

2012-12-05 Thread Benjamin Tissoires
On Wed, Dec 5, 2012 at 11:10 AM, Jean Delvare wrote: > On Tue, 4 Dec 2012 16:27:51 +0100, Benjamin Tissoires wrote: >> Simplifies i2c_hid_alloc_buffers tests, and makes this function >> responsible of the assignment of ihid->bufsize. >> The condition for the reallocation in i2c_hid_start is then

Re: [PATCH 02/14] HID: i2c-hid: fix memory corruption due to missing hid declaration

2012-12-05 Thread Jiri Kosina
On Wed, 5 Dec 2012, Benjamin Tissoires wrote: > > On Tue, 4 Dec 2012 16:27:43 +0100, Benjamin Tissoires wrote: > >> HID descriptors contains 4 bytes of reserved field. > >> The previous implementation was overriding the next fields in struct > >> i2c_hid. > >> > >> Signed-off-by: Benjamin

Re: [PATCH 11/14] HID: i2c-hid: remove unneeded test in i2c_hid_remove

2012-12-05 Thread Jean Delvare
On Tue, 4 Dec 2012 16:27:52 +0100, Benjamin Tissoires wrote: > ihid can not be null, so there are no reasons to test it. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/i2c-hid/i2c-hid.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-12-05 Thread Namjae Jeon
2012/12/5, Wanpeng Li : > Hi Namjae, > > How about set bdi->dirty_background_bytes according to bdi_thresh? I found > an issue during background flush process when review codes, if over > background > flush threshold, wb_check_background_flush will kick a work to current > per-bdi > flusher, but

Re: [PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-05 Thread Jan Beulich
>>> On 05.12.12 at 11:01, Olaf Hering wrote: > backend_changed might be called multiple times, which will leak > be->mode. free the previous value before storing the current mode value. As said before - this is one possible route to take. But did you consider at all the alternative of preventing

[PATCH 1/1] pinctrl: samsung: Fix a typo in pinctrl-samsung.h

2012-12-05 Thread Sachin Kamat
struct samsung_pin_bank does not have a member called reg_offset. It should be pctl_offset instead. Signed-off-by: Sachin Kamat --- drivers/pinctrl/pinctrl-samsung.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pinctrl/pinctrl-samsung.h

Re: [PATCH 13/14] HID: i2c-hid: also call i2c_hid_free_buffers in i2c_hid_remove

2012-12-05 Thread Jiri Kosina
On Tue, 4 Dec 2012, Benjamin Tissoires wrote: > In the case where the hid driver in charge of handling the hid part > of the device (hid-generic for instance) fails at probe, neither > i2c_hid_start nor i2c_hid_stop are called. > Thus, the buffers allocated in i2c_hid_probe are never freed. > >

Wrong length / buffer overlow by the syslog syscall

2012-12-05 Thread Sylvain Munaut
Hi, I was debugging a segfault in the 'dmesg' utility that I finally traced to the syslog syscall overflowing the buffer. I'm under a 3.6.8 kernel and it has commit e3756477aec028427fec767957c0d4b6cfb87208 present which apparently fixed a similar issue, but I still have some occurence. strace

Re: [PATCH 09/14] HID: i2c-hid: i2c_hid_get_report may fail

2012-12-05 Thread Jiri Kosina
On Tue, 4 Dec 2012, Benjamin Tissoires wrote: > If i2c_hid_get_report fails, exit i2c_hid_init_report. > The printk log is already called by i2c_hid_get_report, so no need > to add some more printks. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/i2c-hid/i2c-hid.c | 5 +++-- > 1

Re: [PATCH 12/14] HID: i2c-hid: remove extra .irq field in struct i2c_hid

2012-12-05 Thread Jean Delvare
On Tue, 4 Dec 2012 16:27:53 +0100, Benjamin Tissoires wrote: > There is no point in keeping the irq in i2c_hid as it's already > there in client. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/i2c-hid/i2c-hid.c | 17 ++--- > 1 file changed, 6 insertions(+), 11

Re: [PATCH 11/14] HID: i2c-hid: remove unneeded test in i2c_hid_remove

2012-12-05 Thread Jiri Kosina
On Wed, 5 Dec 2012, Jean Delvare wrote: > > ihid can not be null, so there are no reasons to test it. > > > > Signed-off-by: Benjamin Tissoires > > --- > > drivers/hid/i2c-hid/i2c-hid.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c

Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source

2012-12-05 Thread David Howells
Takashi Iwai wrote: > +#ifndef SYMBOL_PREFIX This comes via the command line? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source

2012-12-05 Thread James Hogan
On 05/12/12 09:50, Michal Marek wrote: >> How about the revised patch below? > [...] >> diff --git a/kernel/modsign_certificate.S b/kernel/modsign_certificate.S >> new file mode 100644 >> index 000..695d4e3 >> --- /dev/null >> +++ b/kernel/modsign_certificate.S >> @@ -0,0 +1,18 @@ >> +#ifndef

Re: [PATCH 13/14] HID: i2c-hid: also call i2c_hid_free_buffers in i2c_hid_remove

2012-12-05 Thread Jean Delvare
On Tue, 4 Dec 2012 16:27:54 +0100, Benjamin Tissoires wrote: > In the case where the hid driver in charge of handling the hid part > of the device (hid-generic for instance) fails at probe, neither > i2c_hid_start nor i2c_hid_stop are called. > Thus, the buffers allocated in i2c_hid_probe are

Re: [PATCH 3.7-rc8] lib/Makefile: Fix oid_registry build dependency

2012-12-05 Thread David Howells
Tim Gardner wrote: > It is $(obj)/oid_registry.o that is dependent on $(obj)/oid_registry_data.c. > The object file cannot be built until $(obj)/oid_registry_data.c has been > generated. > > A periodic and hard to reproduce parallel build failure is due to > this incorrect lib/Makefile

Re: [PATCH 14/14] HID: i2c-hid: fix i2c_hid_get_raw_report count mismatches

2012-12-05 Thread Benjamin Tissoires
Hi, sorry, but when I re-read it, it seems that I missed a +2 in the call of i2c_hid_get_report. So Jean, Jiri, please ignore this one. I'm really sorry if you already started reviewing it. I'll send a v2 with the missing patches early this afternoon. Cheers, Benjamin On Tue, Dec 4, 2012 at

[PATCH net-next v2 0/3] Multiqueue support in virtio-net

2012-12-05 Thread Jason Wang
Hi all: This series is an update version of multiqueue virtio-net driver based on Krishna Kumar's work to let virtio-net use multiple rx/tx queues to do the packets reception and transmission. Please review and comments. A protype implementation of qemu-kvm support could by found in

[PATCH net-next v2 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-05 Thread Jason Wang
To support multiqueue transmitq/receiveq, the first step is to separate queue related structure from virtnet_info. This patch introduce send_queue and receive_queue structure and use the pointer to them as the parameter in functions handling sending/receiving. Signed-off-by: Krishna Kumar

[PATCH net-next v2 3/3] virtio-net: support changing the number of queue pairs through ethtool

2012-12-05 Thread Jason Wang
This patch implements the ethtool_{set|get}_channels method of virtio-net to allow user to change the number of queues when the device is running on demand. Signed-off-by: Jason Wang --- drivers/net/virtio_net.c | 43 +++ 1 files changed, 43

[PATCH net-next v2 2/3] virtio_net: multiqueue support

2012-12-05 Thread Jason Wang
This patch adds the multiqueue (VIRTIO_NET_F_RFS) support to virtio_net driver. VIRTIO_NET_F_RFS capable device could allow the driver to do packet transmission and reception through multiple queue pairs and does the packet steering to get better performance. By default, one one queue pair is

Re: [PATCH, 3.7-rc7, RESEND] fs: revert commit bbdd6808 to fallocate UAPI

2012-12-05 Thread Martin Steigerwald
Am Montag, 26. November 2012 schrieb Dave Chinner: > On Sun, Nov 25, 2012 at 09:55:20PM -0500, Theodore Ts'o wrote: > > On Mon, Nov 26, 2012 at 11:28:14AM +1100, Dave Chinner wrote: > > > fs: revert commit bbdd6808 to fallocate UAPI > > > > > > From: Dave Chinner > > > > > > Commit bbdd6808

Re: [v2 PATCH 2/8] watchdog/at91sam9_wdt: Convert to use the watchdog framework

2012-12-05 Thread Florian Fainelli
Hello Wenyou, On Wednesday 05 December 2012 09:34:21 Wenyou Yang wrote: > According to the kernel document: convert_drivers_to_kernel_api.txt, > remove the file_operations struct, miscdevice, and obsolete includes > > Since the at91sam watchdog inherent characteristics, add the watchdog >

Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source

2012-12-05 Thread Michal Marek
Dne 5.12.2012 11:30, David Howells napsal(a): > Takashi Iwai wrote: > >> +#ifndef SYMBOL_PREFIX > > This comes via the command line? Yes, see scripts/Makefile.lib: ifdef CONFIG_SYMBOL_PREFIX _sym_flags = -DSYMBOL_PREFIX=$(patsubst "%",%,$(CONFIG_SYMBOL_PREFIX)) _cpp_flags += $(_sym_flags)

Re: [PATCH 1/2] megaraid: fix BUG_ON() from incorrect use of delayed work

2012-12-05 Thread Daniel Vacek
On Tue, Dec 4, 2012 at 4:54 PM, Tejun Heo wrote: > @@ -5190,7 +5188,7 @@ static void > megasas_aen_polling(struct work_struct *work) > { > struct megasas_aen_event *ev = > - container_of(work, struct megasas_aen_event, hotplug_work); > + container_of(work,

[PATCH] ACPI / PM: Fix header of acpi_dev_pm_detach() in acpi.h

2012-12-05 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The header of acpi_dev_pm_detach() in include/linux/acpi.h has an incorrect return type, which should be void. Fix that. Signed-off-by: Rafael J. Wysocki --- include/linux/acpi.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index:

Re: possible regression in kernel 3.6 and 3.7-rc: system hangs during nightly tape backup

2012-12-05 Thread Tilman Schmidt
Problem still exists in kernel 3.7-rc7. During the second backup run after I booted kernel 3.7.0-rc7, once again all disk activity suddenly ceased, dmesg started to report tasks "hung for more than 120 seconds", and everything happening after that was forgotten after a reboot. Can I do anything

Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source

2012-12-05 Thread Michal Marek
Dne 5.12.2012 11:30, James Hogan napsal(a): > However I think it's unfortunate having to stringify from C as it's > pretty much always required to be in string form when used from a C > file, usually in an asm block. Any objection to defining SYMBOL_PREFIX > with the quotes around it for _c_flags

Re: [PATCHv2 1/1] dm-integrity: integrity protection device-mapper target

2012-12-05 Thread Kasatkin, Dmitry
Hello, Any comments? - Dmitry On Mon, Nov 26, 2012 at 4:39 PM, Dmitry Kasatkin wrote: > Device-mapper "integrity" target provides transparent cryptographic integrity > protection of the underlying read-write block device using hash-based message > authentication codes (HMACs). HMACs can be

[PATCH resend 0/7] DMA: DMA unmap fixes for v3.8

2012-12-05 Thread Bartlomiej Zolnierkiewicz
Hi, This is a minimal set of patches from a larger DMA unmap rework (http://lkml.org/lkml/2012/11/5/111). There are no changes from the previous posting (except added Acked-by and Reviewed-by tags). Vinod, could you please apply them to v3.8? Thanks! patches #1-3 add missing DMA unmap on

[PATCH resend 1/7] async_tx: add missing DMA unmap to async_memcpy()

2012-12-05 Thread Bartlomiej Zolnierkiewicz
Do DMA unmap on ->device_prep_dma_memcpy failure. Acked-by: Dan Williams Reviewed-by: Tomasz Figa Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park --- crypto/async_tx/async_memcpy.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/crypto/async_tx/async_memcpy.c

[PATCH resend 2/7] ioat: add missing DMA unmap to ioat_dma_self_test()

2012-12-05 Thread Bartlomiej Zolnierkiewicz
Make ioat_dma_self_test() do DMA unmapping itself and fix handling of failure cases. Acked-by: Dan Williams Reviewed-by: Tomasz Figa Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park --- drivers/dma/ioat/dma.c | 11 +++ 1 file changed, 7 insertions(+), 4

[PATCH resend 4/7] carma-fpga: pass correct flags to ->device_prep_dma_memcpy()

2012-12-05 Thread Bartlomiej Zolnierkiewicz
DMA unmapping is handled by a driver so tell fsldma.c driver (which is the DMA engine driver used by carma-fpga) to skip unmapping destination and source buffers. Acked-by: Ira W. Snyder Acked-by: Dan Williams Reviewed-by: Tomasz Figa Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by:

[PATCH resend 6/7] async_tx: fix build for async_memset

2012-12-05 Thread Bartlomiej Zolnierkiewicz
Add missing include. Acked-by: Dan Williams Reviewed-by: Tomasz Figa Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park --- crypto/async_tx/async_memset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/crypto/async_tx/async_memset.c b/crypto/async_tx/async_memset.c

[PATCH resend 7/7] async_tx: add missing DMA unmap to async_memset()

2012-12-05 Thread Bartlomiej Zolnierkiewicz
Do DMA unmap on ->device_prep_dma_memset failure. Acked-by: Dan Williams Reviewed-by: Tomasz Figa Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park --- crypto/async_tx/async_memset.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/crypto/async_tx/async_memset.c

[PATCH resend 5/7] ioat3: add missing DMA unmap to ioat_xor_val_self_test()

2012-12-05 Thread Bartlomiej Zolnierkiewicz
Make ioat_xor_val_self_test() do DMA unmapping itself and fix handling of failure cases. Acked-by: Dan Williams Reviewed-by: Tomasz Figa Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park --- drivers/dma/ioat/dma_v3.c | 76 --- 1

[PATCH resend 3/7] mtd: fsmc_nand: add missing DMA unmap to dma_xfer()

2012-12-05 Thread Bartlomiej Zolnierkiewicz
Make dma_xfer() do DMA unmapping itself and fix handling of failure cases. Cc: David Woodhouse Cc: Vipin Kumar Acked-by: Dan Williams Reviewed-by: Tomasz Figa Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park --- drivers/mtd/nand/fsmc_nand.c | 22 ++

Re: [RFC v2 6/8] gpu: drm: tegra: Remove redundant host1x

2012-12-05 Thread Thierry Reding
On Wed, Dec 05, 2012 at 12:10:50PM +0200, Terje Bergström wrote: > On 05.12.2012 10:33, Thierry Reding wrote: > > I've been thinking about this some more and came to the conclusion that > > since we will already have a tight coupling between host1x and tegra-drm > > we may just as well keep the

Re: [PATCH 1/2] megaraid: fix BUG_ON() from incorrect use of delayed work

2012-12-05 Thread Daniel Vacek
On Wed, Dec 5, 2012 at 12:02 PM, Daniel Vacek wrote: > On Tue, Dec 4, 2012 at 4:54 PM, Tejun Heo wrote: >> @@ -5190,7 +5188,7 @@ static void >> megasas_aen_polling(struct work_struct *work) >> { >> struct megasas_aen_event *ev = >> - container_of(work, struct

Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source

2012-12-05 Thread James Hogan
On 05/12/12 11:05, Michal Marek wrote: > Dne 5.12.2012 11:30, James Hogan napsal(a): >> However I think it's unfortunate having to stringify from C as it's >> pretty much always required to be in string form when used from a C >> file, usually in an asm block. Any objection to defining

<    1   2   3   4   5   6   7   8   9   10   >