Re: [PATCH 11/24] cfq-iosched: add leaf_weight

2013-01-08 Thread Tejun Heo
Hello, Vivek. On Tue, Jan 08, 2013 at 10:34:48AM -0500, Vivek Goyal wrote: > How does it help to map leaf weight to weight in root group. Old programs > anyway don't know about leaf_weight. So nobody is going to update it. And > if they update it, they better know what does it do. Because what

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Linus Torvalds
On Tue, Jan 8, 2013 at 9:17 AM, Jeff Chua wrote: > > Interesting, but there are 54 lines under the kernel directories that > use "dma_alloc_coherent(NULL," followed by "dma_free_coherent(NULL," As mentioned, it works on some platforms. That doesn't make it right. > So, shouldn't they be fixed

Re: [PATCH UPDATED 15/24] cfq-iosched: enable full blkcg hierarchy support

2013-01-08 Thread Tejun Heo
Hey, Vivek. On Tue, Jan 08, 2013 at 09:42:40AM -0500, Vivek Goyal wrote: > > +A has children and further distributes its 57% among the children and > > +the implicit leaf node. The total active weight at this level is > > +AA:500 + AB:1000 + A-leaf:750 = 2250. > > + > > + A-leaf: ( 750 /

Re: [PATCH] Only reset e820 once, even with multiple memmap=exactmap params

2013-01-08 Thread Yinghai Lu
On Tue, Jan 8, 2013 at 8:47 AM, Thomas Renninger wrote: > On Tuesday, January 08, 2013 04:04:56 AM Yinghai Lu wrote: >> On Mon, Jan 7, 2013 at 4:42 PM, Thomas Renninger wrote: >> > memmap=256M$3584M >> >> may need to change to: >> >> memmap=256M\$\$3584M > The problem is (beside the special char

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Jeff Chua
On Wed, Jan 9, 2013 at 12:39 AM, Linus Torvalds wrote: > On Tue, Jan 8, 2013 at 7:51 AM, Jeff Chua wrote: >> No response so far ... I'm sure someone know this stuff ... Thanks, Jeff. >> >> I'm trying to understand how this oops in the diva driver and it's just a >> simple dma_alloc_coherent()

Re: [PATCHv2 8/9] zswap: add to mm/

2013-01-08 Thread Dave Hansen
On 01/07/2013 12:24 PM, Seth Jennings wrote: > +struct zswap_tree { > + struct rb_root rbroot; > + struct list_head lru; > + spinlock_t lock; > + struct zs_pool *pool; > +}; BTW, I spent some time trying to get this lock contended. You thought the anon_vma locks would dominate

Re: [PATCH v12 0/9] LSM: Multiple concurrent LSMs

2013-01-08 Thread Casey Schaufler
On 1/8/2013 1:12 AM, James Morris wrote: > On Mon, 7 Jan 2013, Casey Schaufler wrote: > >> There has been an amazing amount of development in system security >> over the past three years. Almost none of it has been in the kernel. >> One important reason that it is not getting done in the kernel is

Re: PTRACE_SYSCALL && vsyscall (Was: arch_check_bp_in_kernelspace: fix the range check)

2013-01-08 Thread Pedro Alves
On 12/04/2012 05:59 PM, Oleg Nesterov wrote: > But If we want to allow to trace vsyscall's, hw bp doesn't look very > nice imo. HBP_NUM = 4 and you need to setup 3 bp's to trace them all. Irrespective of the whole syscall tracing issue, allowing HW bkpts in the vsyscall just seems like a bug fix

Re: [PATCH] PCI: Make pci_find_upstream_pcie_bridge() handle non PCIE VFs well

2013-01-08 Thread Don Dutile
On 01/08/2013 09:32 AM, tadeusz.st...@intel.com wrote: pci_find_upstream_pcie_bridge() doesn't handle well non PCIE VFs that are part of a PCIE PF device. Signed-off-by: Tadeusz Struk --- drivers/pci/search.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 18/24] blkcg: s/blkg_rwstat_sum()/blkg_rwstat_total()/

2013-01-08 Thread Vivek Goyal
On Fri, Dec 28, 2012 at 12:35:40PM -0800, Tejun Heo wrote: > Rename blkg_rwstat_sum() to blkg_rwstat_total(). sum will be used for > summing up stats from multiple blkgs. > > Signed-off-by: Tejun Heo Acked-by: Vivek Goyal Vivek > --- > block/blk-cgroup.h | 4 ++-- > block/cfq-iosched.c |

Re: [PATCH 17/24] blkcg: implement blkcg_policy->on/offline_pd_fn() and blkcg_gq->online

2013-01-08 Thread Vivek Goyal
On Fri, Dec 28, 2012 at 12:35:39PM -0800, Tejun Heo wrote: > Add two blkcg_policy methods, ->online_pd_fn() and ->offline_pd_fn(), > which are invoked as the policy_data gets activated and deactivated > while holding both blkcg and q locks. > > Also, add blkcg_gq->online bool, which is set and

[PATCH v3 4/6] PCI/acpiphp: update ACPI hotplug slot information when PCI hotplug happens

2013-01-08 Thread Jiang Liu
Currently the acpiphp driver fails to update hotplug slot information under several conditions, such as: 1) The bridge device is removed through /sys/bus/pci/devices/.../remove 2) The bridge device is added/removed by PCI hotplug driver other than the acpiphp driver itself. For example, if an

[PATCH v3 2/6] PCI: split registration of PCI bus devices into two stages

2013-01-08 Thread Jiang Liu
When handling BUS_NOTIFY_ADD_DEVICE event for a PCI bridge device, the notification handler can't hold reference count to the new PCI bus because the device object for the new bus (pci_dev->subordinate->dev) hasn't been initialized yet. Split the registration of PCI bus device into two stages as

[PATCH v3 0/6] Update PCI notification patchset to latest kernel version

2013-01-08 Thread Jiang Liu
Hi Bjorn, Rafael has developed a patchset targetting 3.9 merging window which outdates the fourth and fifth patches in my previous version, so I have just drop those two patches and updated the others to the latest code from your pci-next branch. Thanks! Jiang Liu (5): PCI:

[PATCH v3 1/6] PCI: make PCI device create/destroy logic symmetric

2013-01-08 Thread Jiang Liu
According to device model documentation, the way to create/destroy PCI devices should be symmetric. /** * device_del - delete device from system. * @dev: device. * * This is the first part of the device unregistration * sequence. This removes the device from the lists we control * from

[PATCH v3 6/6] PCI/AER: update AER configuration when PCI hotplug event happens

2013-01-08 Thread Jiang Liu
From: Yijing Wang The AER driver only configures downstream PCIe devices at driver binding time and all hot-added PCIe devices won't be managed by the AER driver. So hook PCIe device hotplug events to setup AER configuration for hot-added PCIe devices. Signed-off-by: Yijing Wang

[PATCH v3 5/6] PCI/acpiphp: serialize access to the bridge_list list

2013-01-08 Thread Jiang Liu
Serialize access to the bridge_list in the acpiphp driver. Signed-off-by: Jiang Liu Signed-off-by: Yijing Wang --- drivers/pci/hotplug/acpiphp_glue.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c

Re: oops in copy_page_rep()

2013-01-08 Thread Linus Torvalds
On Tue, Jan 8, 2013 at 8:31 AM, Kirill A. Shutemov wrote: >> >> Heh. I was more thinking about why do_huge_pmd_wp_page() needs it, but >> do_huge_pmd_numa_page() does not. > > It does. The check should be moved up. > >> Also, do we actually need it for huge_pmd_set_accessed()? The >> *placement*

[PATCH v3 3/6] ACPI/pci_slot: update PCI slot information when PCI hotplug event happens

2013-01-08 Thread Jiang Liu
Currently the pci_slot driver doesn't update PCI slot information when PCI device hotplug event happens, which may cause memory leak and returning stale information to user. So hook the BUS_NOTIFY_ADD_DEVICE/BUS_NOTIFY_DEL_DEVICE events to update PCI slot information when PCI hotplug event

Re: [PATCH 16/24] blkcg: add blkg_policy_data->plid

2013-01-08 Thread Vivek Goyal
On Fri, Dec 28, 2012 at 12:35:38PM -0800, Tejun Heo wrote: > Add pd->plid so that the policy a pd belongs to can be identified > easily. This will be used to implement hierarchical blkg_[rw]stats. > > Signed-off-by: Tejun Heo Acked-by: Vivek Goyal Vivek > --- > block/blk-cgroup.c | 2 ++ >

Re: [PATCH 29/32] block, aio: Batch completion for bios/kiocbs

2013-01-08 Thread Kent Overstreet
On Tue, Jan 08, 2013 at 11:15:37AM -0500, Jeff Moyer wrote: > Kent Overstreet writes: > > > On Tue, Jan 08, 2013 at 10:33:18AM -0500, Jeff Moyer wrote: > >> Kent Overstreet writes: > >> > >> >> Is the rbtree really faster than a basic (l)list and a sort before > >> >> completing them? Would be

[PATCH] Only reset e820 once, even with multiple memmap=exactmap params

2013-01-08 Thread Thomas Renninger
On Tuesday, January 08, 2013 04:04:56 AM Yinghai Lu wrote: > On Mon, Jan 7, 2013 at 4:42 PM, Thomas Renninger wrote: > > memmap=256M$3584M > > may need to change to: > > memmap=256M\$\$3584M The problem is (beside the special char $) that memmap=exactmap boot param resets all e820 maps every

RE: linux-next: build failure after merge of the staging tree

2013-01-08 Thread H Hartley Sweeten
On Monday, January 07, 2013 9:30 PM, Stephen Rothwell wrote: > On Mon, 7 Jan 2013 20:27:30 -0800 Greg KH wrote: >> On Tue, Jan 08, 2013 at 01:23:52PM +1100, Stephen Rothwell wrote: >>> After merging the staging tree, today's linux-next build (x86_64 >>> allmodconfig) failed like this: >>> >>>

Re: [PATCH 14/24] cfq-iosched: convert cfq_group_slice() to use cfqg->vfraction

2013-01-08 Thread Vivek Goyal
On Fri, Dec 28, 2012 at 12:35:36PM -0800, Tejun Heo wrote: > cfq_group_slice() calculates slice by taking a fraction of > cfq_target_latency according to the ratio of cfqg->weight against > service_tree->total_weight. This currently works only because all > cfqgs are treated to be at the same

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Linus Torvalds
On Tue, Jan 8, 2013 at 7:51 AM, Jeff Chua wrote: > No response so far ... I'm sure someone know this stuff ... Thanks, Jeff. > > I'm trying to understand how this oops in the diva driver and it's just a > simple dma_alloc_coherent() followed by dma_free_coherent(), but it oops. > Why? Umm.

Re: oops in copy_page_rep()

2013-01-08 Thread Kirill A. Shutemov
On Tue, Jan 08, 2013 at 07:37:06AM -0800, Linus Torvalds wrote: > On Tue, Jan 8, 2013 at 5:04 AM, Hillf Danton wrote: > > On Tue, Jan 8, 2013 at 1:34 AM, Linus Torvalds > > wrote: > >> > >> Hmm. Is there some reason we never need to worry about it for the > >> "pmd_numa()" case just above? > >>

Re: [PATCH] pps: hide more configuration symbols behind CONFIG_PPS

2013-01-08 Thread Richard Cochran
On Tue, Jan 08, 2013 at 01:59:22PM +0100, Florian Fainelli wrote: > This patch makes CONFIG_PPS_DEBUG and CONFIG_NTP_PPS be hidden if > CONFIG_PPS is not selected, such that we are not prompted for these > configuration options if CONFIG_PPS is not set. > > Signed-off-by: Florian Fainelli > ---

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Jonathan Corbet
On Tue, 8 Jan 2013 23:51:59 +0800 Jeff Chua wrote: > I'm trying to understand how this oops in the diva driver and it's just a > simple dma_alloc_coherent() followed by dma_free_coherent(), but it oops. > Why? Hmm...from a quick look... > static u32 *clock_data_addr; > static dma_addr_t

Availability issues during kernel load and kernel error handling

2013-01-08 Thread larsson.l...@telia.com
Hi, I send this mail as information/suggestion for improvements of Linux kernel. I have identified and solved the problem below some years ago. I think that it would be great if the changes could be part of generic distributions in the future as the affects availability when using Linux in

Re: dw_dmac patches

2013-01-08 Thread Vinod Koul
On Mon, Jan 07, 2013 at 02:54:54PM +0200, Andy Shevchenko wrote: > Hi, Vinod. > > I noticed you missed the 3.8 merge window and I can't see any of my > recent patches [1] in your next branch. So, what is your plan regarding > to them? Yes i missed quite a few due to my travel, but now am back :)

Re: [PATCH 13/24] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2013-01-08 Thread Vivek Goyal
On Fri, Dec 28, 2012 at 12:35:35PM -0800, Tejun Heo wrote: > Currently, cfqg charges are scaled directly according to cfqg->weight. > Regardless of the number of active cfqgs or the amount of active > weights, a given weight value always scales charge the same way. This > works fine as long as

Re: [PATCH 29/32] block, aio: Batch completion for bios/kiocbs

2013-01-08 Thread Jeff Moyer
Kent Overstreet writes: > On Tue, Jan 08, 2013 at 10:33:18AM -0500, Jeff Moyer wrote: >> Kent Overstreet writes: >> >> >> Is the rbtree really faster than a basic (l)list and a sort before >> >> completing them? Would be simpler. >> > >> > Well, depends. With one or two kioctxs? The list would

Re: [PATCH 1/5] capemgr: Beaglebone DT overlay based cape manager

2013-01-08 Thread Arnd Bergmann
On Tuesday 08 January 2013, Pantelis Antoniou wrote: > On Jan 8, 2013, at 2:12 PM, Arnd Bergmann wrote: > > > On Tuesday 08 January 2013, Lee Jones wrote: > >>> If there is not, there is no way to automatically load the overlays; you > >>> can always > >>> use the kernel command line, or have

Re: [PATCH] dmaengine: imx-dma: Disable use of hw_chain to fix sg_dma transfers.

2013-01-08 Thread Vinod Koul
On Fri, Jan 04, 2013 at 04:37:44PM +0100, javier Martin wrote: > On 30 October 2012 16:58, Javier Martin > wrote: > > HW chaining is currently broken in imx-dma. It can be easily reproduced > > doing > > intensive accesses to a external MMC card and checking how the file system > > is

Re: [PATCH] ath9k_htc: Fix skb leaks

2013-01-08 Thread Larry Finger
On 01/01/2013 11:26 PM, Sujith Manoharan wrote: Larry Finger wrote: My only counter argument is that none of the other paths that get to ath9k_htc_txcompletion_cb() leak the skb. It only happens for the path that goes through htc_connect_service(). Sure, but the TX completion handler would be

Re: [PATCH 29/32] block, aio: Batch completion for bios/kiocbs

2013-01-08 Thread Kent Overstreet
On Tue, Jan 08, 2013 at 10:33:18AM -0500, Jeff Moyer wrote: > Kent Overstreet writes: > > >> Is the rbtree really faster than a basic (l)list and a sort before > >> completing them? Would be simpler. > > > > Well, depends. With one or two kioctxs? The list would definitely be > > faster, but I'm

Re: [PATCH v4] lib: cpu_rmap: avoid flushing all workqueues

2013-01-08 Thread Ben Hutchings
On Thu, 2013-01-03 at 13:58 -0800, Andrew Morton wrote: > On Wed, 2 Jan 2013 23:46:46 + > Ben Hutchings wrote: [...] > > > drivers/net/ethernet/mellanox/mlx4/ appears to be using > > > msix_ctl.pool_lock for exclusion, but I didn't check for coverage. > > > > > >

Re: USB autosuspend vs. URB submission

2013-01-08 Thread Josh Boyer
On Tue, Jan 08, 2013 at 10:51:20AM -0500, Alan Stern wrote: > On Mon, 7 Jan 2013, Josh Boyer wrote: > > > Hi, > > > > We've had a few reports in Fedora of users hitting the WARN_ONCE in > > drivers/usb/core/urb.c that prints a warning about a usb_submit_urb > > being called on an active URB.

Re: [PATCH] dma: mxs-dma: Fix build warnings with W=1

2013-01-08 Thread Vinod Koul
On Mon, Jan 07, 2013 at 11:48:39PM -0200, Fabio Estevam wrote: > From: Fabio Estevam > > Fix the following warnings when building with W=1 option: > > drivers/dma/mxs-dma.c: In function 'mxs_dma_alloc_chan_resources': > drivers/dma/mxs-dma.c:368:25: warning: comparison between signed and

[PATCH v5] pwm: atmel: add Timer Counter Block PWM driver

2013-01-08 Thread Boris BREZILLON
Hi, This patch adds a PWM driver based on Atmel Timer Counter Block. Timer Counter Block is used in Waveform generator mode. A Timer Counter Block provides up to 6 PWM devices grouped by 2: * group 0 = PWM 0 and 1 * group 1 = PWM 2 and 3 * group 2 = PMW 4 and 5 PWM devices in a given group must

Re: 3.2.35 problem with M5A97 PRO ram: bad_page free_pages_prepare mem_init

2013-01-08 Thread Borislav Petkov
On Tue, Jan 08, 2013 at 01:21:26AM +0100, l...@tigusoft.pl wrote: > On 08/01/13 01:13, l...@tigusoft.pl wrote: > > > linux kernel > > 3.2.0-0.bpo.4-rt-amd64 #1 SMP PREEMPT RT Debian 3.2.35-2~bpo60+1 x86_64 > > GNU/Linux > > will post later how it behaves on vanilla 3.2.36 and 3.7.1 Yes, also,

Re: [PATCH 12/24] cfq-iosched: implement cfq_group->nr_active and ->children_weight

2013-01-08 Thread Vivek Goyal
On Fri, Dec 28, 2012 at 12:35:34PM -0800, Tejun Heo wrote: > To prepare for blkcg hierarchy support, add cfqg->nr_active and > ->children_weight. cfqg->nr_active counts the number of active cfqgs > at the cfqg's level and ->children_weight is sum of weights of those > cfqgs. The level covers

Re: USB autosuspend vs. URB submission

2013-01-08 Thread Alan Stern
On Mon, 7 Jan 2013, Josh Boyer wrote: > Hi, > > We've had a few reports in Fedora of users hitting the WARN_ONCE in > drivers/usb/core/urb.c that prints a warning about a usb_submit_urb > being called on an active URB. One of them[1] is from the ums_realtek > driver and the other[2] is from the

[GIT PULL] EDAC fixes for 3.8

2013-01-08 Thread Borislav Petkov
Hi Linus, please pull the 3 fixes below. Thanks. The following changes since commit d1c3ed669a2d452cacfb48c2d171a1f364dae2ed: Linux 3.8-rc2 (2013-01-02 18:13:21 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git tags/edac_fixes_for_3.8

Re: oops in copy_page_rep()

2013-01-08 Thread Linus Torvalds
On Tue, Jan 8, 2013 at 5:04 AM, Hillf Danton wrote: > On Tue, Jan 8, 2013 at 1:34 AM, Linus Torvalds > wrote: >> >> Hmm. Is there some reason we never need to worry about it for the >> "pmd_numa()" case just above? >> >> A comment about this all might be a really good idea. >> > Yes Sir, added.

Re: [PATCH 11/24] cfq-iosched: add leaf_weight

2013-01-08 Thread Vivek Goyal
On Fri, Dec 28, 2012 at 12:35:33PM -0800, Tejun Heo wrote: [..] > + > + /* on root, leaf_weight is mapped to weight */ > + { > + .name = "leaf_weight_device", > + .flags = CFTYPE_ONLY_ON_ROOT, > + .read_seq_string = cfqg_print_weight_device, > +

Re: [PATCH 29/32] block, aio: Batch completion for bios/kiocbs

2013-01-08 Thread Jeff Moyer
Kent Overstreet writes: >> Is the rbtree really faster than a basic (l)list and a sort before >> completing them? Would be simpler. > > Well, depends. With one or two kioctxs? The list would definitely be > faster, but I'm loathe to use an O(n^2) algorithm anywhere where the > input size isn't

[GIT PULL] sound fixes for 3.8-rc3

2013-01-08 Thread Takashi Iwai
Linus, The following changes since commit a49f0d1ea3ec94fc7cf33a7c36a16343b74bd565: Linux 3.8-rc1 (2012-12-21 17:19:00 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/sound-3.8 for you to fetch changes up to

Re: [PATCH v4 RESEND] pwm: atmel: add Timer Counter Block PWM driver

2013-01-08 Thread Boris BREZILLON
On 08/01/2013 08:10, Thierry Reding wrote: > On Thu, Dec 20, 2012 at 10:12:56AM +0100, Boris BREZILLON wrote: >> Hi, >> >> Sorry for resend. The previous version still has alignment issues on >> atmel_tcb_pwm_set_polarity, atmel_tcb_pwm_request and >> atmel_tcb_pwm_config function parameters. >>

Re: Antw: [PATCH 0/5] kfifo cleanup and log based kfifo API

2013-01-08 Thread Yuanhan Liu
On Tue, Jan 08, 2013 at 04:03:17PM +0100, Ulrich Windl wrote: > >>> Yuanhan Liu schrieb am 08.01.2013 um 15:57 > >>> in > Nachricht <1357657073-27352-1-git-send-email-yuanhan@linux.intel.com>: > > [...] > > My proposal is to replace kfifo_init with kfifo_alloc, where it > > allocate buffer

Re: [PATCH v6 0/4] block layer runtime pm

2013-01-08 Thread Alan Stern
On Tue, 8 Jan 2013, Aaron Lu wrote: > So this also reminds me that as long as CONFIG_PM_RUNTIME is selected, > the blk_pm_add/put/peek_request functions will be in the block IO path. > Shall we introduce a new config option to selectively build block > runtime PM functionality? something like

Re: [PATCH v4 RESEND] pwm: atmel: add Timer Counter Block PWM driver

2013-01-08 Thread Russell King - ARM Linux
On Tue, Jan 08, 2013 at 04:21:59PM +0100, Boris BREZILLON wrote: > Do I have to break the error string so that the line does not exceed 80 > characters ? No. > Checkpath script does not complain about it, and the CodingStyle file > specify that visible strings should not be broken... Correct.

Re: ALSA: Conexant CX20585 (thinkpad t510) speaker powersave regression

2013-01-08 Thread Takashi Iwai
At Sat, 22 Dec 2012 14:23:24 -0700, Kevin Fenzi wrote: > > Greetings. > > I've got an issue with sound on my t510. It started in the late 3.4.x > kernels. Sound works on boot and for 5-10min after, then the speakers > stop working at all. > > I posted a while back on the alsa-users list, and

Re: [PATCH v6 3/4] block: implement runtime pm strategy

2013-01-08 Thread Alan Stern
On Tue, 8 Jan 2013, Aaron Lu wrote: > >> --- a/include/linux/blkdev.h > >> +++ b/include/linux/blkdev.h > >> @@ -974,6 +974,40 @@ extern int blk_pre_runtime_suspend(struct > >> request_queue *q); > >> extern void blk_post_runtime_suspend(struct request_queue *q, int err); > >> extern void

Re: [PATCH] nfsd: Remove write permission from file content

2013-01-08 Thread J. Bruce Fields
On Sat, Jan 05, 2013 at 12:29:05PM +0800, Yanchuan Nian wrote: > 2013/1/5 J. Bruce Fields > > > On Fri, Jan 04, 2013 at 07:45:35PM +0800, ycn...@gmail.com wrote: > > > From: Yanchuan Nian > > > > > > The write function doesn't be implemented in file content, and it's > > meaningless > > > to

Antw: [PATCH 0/5] kfifo cleanup and log based kfifo API

2013-01-08 Thread Ulrich Windl
>>> Yuanhan Liu schrieb am 08.01.2013 um 15:57 in Nachricht <1357657073-27352-1-git-send-email-yuanhan@linux.intel.com>: [...] > My proposal is to replace kfifo_init with kfifo_alloc, where it > allocate buffer and maintain fifo size inside kfifo. Then we can > remove buggy kfifo_init. [...]

[PATCH v2] efi, x86: Pass a proper identity mapping in efi_call_phys_prelog

2013-01-08 Thread Nathan Zimmer
Update efi_call_phys_prelog to install an identity mapping of all available memory. This corrects a bug on very large systems with more then 512 GB in which bios would not be able to access addresses above not in the mapping. The result is a crash that looks much like this. BUG: unable to

Re: kernel BUG at kernel/sched_rt.c:493!

2013-01-08 Thread Shawn Bohrer
On Tue, Jan 08, 2013 at 09:36:05AM -0500, Steven Rostedt wrote: > > > > I've also managed to reproduce this on 3.8.0-rc2 so it appears the bug > > is still present in the latest kernel. > > Shawn, > > Can you send me your .config file. I've attached the 3.8.0-rc2 config that I used to

[PATCH 1/5] kfifo: remove unnecessary type check

2013-01-08 Thread Yuanhan Liu
Firstly, this kind of type check doesn't work. It does something similar as following: void * __dummy = NULL; __buf = __dummy; __dummy is defined as void *. Thus it will not trigger warnings as expected. Second, we don't need that kind of check. Since the prototype of __kfifo_out

Re: [PATCH v2 0/5] staging/fwserial: Address reviewer comments

2013-01-08 Thread Peter Hurley
On Mon, 2013-01-07 at 15:22 -0800, Greg Kroah-Hartman wrote: > On Sat, Dec 15, 2012 at 01:03:14AM -0500, Peter Hurley wrote: > > Overdue respin. > > v2 changes: > >Don't use 'card' when referring to firewire node > >Removed lower clamp in link_speed_to_max_payload() > >Ripped out the

[PATCH 2/5] libsrp: replace kfifo_init with kfifo_alloc

2013-01-08 Thread Yuanhan Liu
kfifo_init will use a pre-allocated buffer as fifo buffer; the buffer size is determinted at caller side. While, kfifo will maintain a real kfifo buffer size(rounddown power of 2 aligned). So, the two size may not be equal. So, if max is not power of 2, this code will not work. As it assume the

[PATCH 3/5] libiscsi: replace kfifo_init with kfifo_alloc

2013-01-08 Thread Yuanhan Liu
kfifo_init will use a pre-allocated buffer as fifo buffer; the buffer size is determinted at caller side. While, kfifo will maintain a real kfifo buffer size(rounddown power of 2 aligned). So, the two size may not be equal. So, if max is not power of 2, this code will not work. As it assume the

[PATCH 5/5] kfifo: log based kfifo API

2013-01-08 Thread Yuanhan Liu
The current kfifo API take the kfifo size as input, while it rounds _down_ the size to power of 2 at __kfifo_alloc. This may introduce potential issue. Take the code at drivers/hid/hid-logitech-dj.c as example: if (kfifo_alloc(_dev->notif_fifo,

[PATCH 4/5] kfifo: remove kfifo_init

2013-01-08 Thread Yuanhan Liu
kfifo_init is buggy, we should never use that. Instead, we should use kfifo_alloc. Cc: Stefani Seibold Cc: Andrew Morton Signed-off-by: Yuanhan Liu --- include/linux/kfifo.h | 27 ++- kernel/kfifo.c| 23 --- 2 files changed, 2

[PATCH 0/5] kfifo cleanup and log based kfifo API

2013-01-08 Thread Yuanhan Liu
The current kfifo API take the kfifo size as input, while it rounds _down_ the size to power of 2 at __kfifo_alloc/init. This may introduce several potential issues. First, the kfifo size is not what we want. Say, if we want to allocate a kfifo with size of 127 elements. Then in the end, we can

RE: [patch] bnx2x: NULL dereference on error in debug code

2013-01-08 Thread Ariel Elior
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Dan Carpenter > Sent: Tuesday, January 08, 2013 3:42 PM > To: Eilon Greenstein > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel- > janit...@vger.kernel.org >

Re: [PATCH v4 1/3] videobuf2-dma-contig: user can specify GFP flags

2013-01-08 Thread Federico Vaga
> Ok, then I would simply pass the flags from the driver without any > alternation > in the allocator itself, so drivers can pass 'GFP_KERNEL' or > 'GFP_KERNEL | GFP_DMA' depending on their preference. Please also update > all > the existing clients of vb2_dma_dc allocator. I taked a look at

Re: [Consult] our latest kernel and latest Android under arm Samsung S5PV210 with yaffs2 file system

2013-01-08 Thread Theodore Ts'o
On Tue, Jan 08, 2013 at 06:25:06PM +0800, Chen Gang F T wrote: > use yaffs2 file system for android > it seems yaffs2 is a standard file system for android. > for my android HTC phone is also yaffs2 file system. yaffs2 is not a _standard_ file system for Android. There may be

RE: [patch] bnx2x: NULL dereference on error in debug code

2013-01-08 Thread Ariel Elior
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Dan Carpenter > Sent: Tuesday, January 08, 2013 3:42 PM > To: Eilon Greenstein > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel- > janit...@vger.kernel.org >

Re: [PATCH] sunrpc: verbs: Avoid 1kb stack

2013-01-08 Thread J. Bruce Fields
On Mon, Jan 07, 2013 at 11:41:36AM -0800, Joe Perches wrote: > 16 * 64 is a bit much. > Use kmalloc_array instead. I thought there was some reason we didn't do this. Grepping up through the callers It looks like the result is xprt_rdma_send_request returns -EIO, and as far as I can tell

Re: [PATCH] drivers: i2c: muxes: fix sizeof(ptr)

2013-01-08 Thread Laurent Navet
This is not really a bug as mux->busses is a multilevel pointer, so the result of sizeof(ptr) is the same as sizeof(*ptr). But I think this is more logical and according to CodingStyle rules like this. This is also what is done for mux->states a few lines above. Regards, 2013/1/8, Laurent Navet

Re: [PATCH UPDATED 15/24] cfq-iosched: enable full blkcg hierarchy support

2013-01-08 Thread Vivek Goyal
On Mon, Jan 07, 2013 at 08:34:05AM -0800, Tejun Heo wrote: [..] > +weight leaf_weight > + root : 125125 > + A: 500750 > + B: 250500 > + AA : 500500 > + AB : 1000500 > + > +root never has a parent making its weight is meaningless. For backward >

Re: [alsa-devel] [3.6.9 -> 3.7.1 regression] sound: snd_hda_intel codec probing issue?

2013-01-08 Thread Takashi Iwai
At Tue, 08 Jan 2013 15:32:13 +0100, David Henningsson wrote: > > On 01/08/2013 01:56 PM, Takashi Iwai wrote: > >> I'll test with enable_msi=0 later. > > > > Thanks. > > > > FWIW, below is a patch I'm considering to merge (after testing, of > > course). Could you buys check it? > > > > > >

[PATCH] drivers: i2c: muxes: fix sizeof(ptr)

2013-01-08 Thread Laurent Navet
sizeof when applied to a pointer typed expression gives the size of the pointer The semantic patch that makes this output is available in scripts/coccinelle/misc/noderef.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Laurent Navet ---

Re: "Hangcheck timer elapsed... GPU hung" in 3.8.0-rc2

2013-01-08 Thread J. Bruce Fields
On Sun, Jan 06, 2013 at 07:06:52PM +0100, Daniel Vetter wrote: > On Thu, Jan 03, 2013 at 06:11:23PM -0500, J. Bruce Fields wrote: > > On Thu, Jan 03, 2013 at 04:16:24PM -0500, Josh Boyer wrote: > > > On Thu, Jan 3, 2013 at 3:46 PM, J. Bruce Fields > > > wrote: > > > > I got a crash after a few

Re: kernel BUG at kernel/sched_rt.c:493!

2013-01-08 Thread Steven Rostedt
> > I've also managed to reproduce this on 3.8.0-rc2 so it appears the bug > is still present in the latest kernel. Shawn, Can you send me your .config file. Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[PATCH] PCI: Make pci_find_upstream_pcie_bridge() handle non PCIE VFs well

2013-01-08 Thread tadeusz . struk
pci_find_upstream_pcie_bridge() doesn't handle well non PCIE VFs that are part of a PCIE PF device. Signed-off-by: Tadeusz Struk --- drivers/pci/search.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/pci/search.c b/drivers/pci/search.c index

Re: [alsa-devel] [3.6.9 -> 3.7.1 regression] sound: snd_hda_intel codec probing issue?

2013-01-08 Thread David Henningsson
On 01/08/2013 01:56 PM, Takashi Iwai wrote: I'll test with enable_msi=0 later. Thanks. FWIW, below is a patch I'm considering to merge (after testing, of course). Could you buys check it? Takashi --- From: Takashi Iwai Subject: [PATCH] ALSA: hda - Disable runtime D3 for Intel CPT & co

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-08 Thread Jonathan Corbet
On Tue, 08 Jan 2013 07:50:41 +0100 Marek Szyprowski wrote: > > Couldn't this performance difference be due to the usage of GFP_DMA inside > > the VB2 code, like Federico's new patch series is proposing? > > > > If not, why are there a so large performance penalty? > > Nope, this was caused

Re: [PATCH 02/25] ab8500_charger: don't use [delayed_]work_pending()

2013-01-08 Thread Linus Walleij
On Sat, Dec 22, 2012 at 2:56 AM, Tejun Heo wrote: > There's no need to test whether a (delayed) work item in pending > before queueing, flushing or cancelling it. Most uses are unnecessary > and quite a few of them are buggy. > > Remove unnecessary pending tests from ab8500_charger. Only

Re: [RFC PATCH 5/6] uprobes: add bp_vaddr argument to consumer handler

2013-01-08 Thread Anton Arapov
On Sun, Dec 23, 2012 at 04:49:10PM +0100, Oleg Nesterov wrote: > On 12/22, Oleg Nesterov wrote: > > > > Forgot to ask... > > > > On 12/22, Oleg Nesterov wrote: > > > > > > On 12/21, Anton Arapov wrote: > > > > > > > > struct uprobe_consumer { > > > > - int (*handler)(struct uprobe_consumer

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-08 Thread Alex Shi
On 01/07/2013 02:31 AM, Linus Torvalds wrote: > On Sat, Jan 5, 2013 at 11:54 PM, Alex Shi wrote: >> >> I just looked into the aim9 benchmark, in this case it forks 2000 tasks, >> after all tasks ready, aim9 give a signal than all tasks burst waking up >> and run until all finished. >> Since each

Re: [3.6.9 -> 3.7.1 regression] sound: snd_hda_intel codec probing issue?

2013-01-08 Thread Vincent Blut
Le mardi 08 janvier 2013 à 13:56 +0100, Takashi Iwai a écrit : > At Tue, 08 Jan 2013 13:28:55 +0100, > Vincent Blut wrote: > > > > Le lundi 07 janvier 2013 à 09:32 +0100, Takashi Iwai a écrit : > > > At Sat, 05 Jan 2013 22:24:03 +0100, > > > > > > One more thing to test is whether

[PATCH] tools/perf: let it build from perf-*-src-pkg

2013-01-08 Thread Sebastian Andrzej Siewior
Thanks (mostly) to uapi the package created from perf-*-src-pkg FTBFS: |CC perf.o |In file included from util/../perf.h:8:0, | from util/cache.h:7, | from perf.c:12: |arch/x86/include/asm/unistd.h:4:29: fatal error: uapi/asm/unistd.h: No such file or directory

Re: sched: Consequences of integrating the Per Entity Load Tracking Metric into the Load Balancer

2013-01-08 Thread Vincent Guittot
On 8 January 2013 07:06, Preeti U Murthy wrote: > On 01/07/2013 09:18 PM, Vincent Guittot wrote: >> On 2 January 2013 05:22, Preeti U Murthy wrote: >>> Hi everyone, >>> I have been looking at how different workloads react when the per entity >>> load tracking metric is integrated into the load

Re: [PATCH] perf bench: Flush stdout before starting bench suite

2013-01-08 Thread Hitoshi Mitake
At Tue, 8 Jan 2013 18:39:26 +0900, Namhyung Kim wrote: > > From: Namhyung Kim > > perf bench prints header message for bench suite before starting the > benchmark. However if the stdout is redirected to a file and bench > suite forks child processes this (and possibly other debugging >

Re: [PATCH] HID: i2c-hid: add ACPI support

2013-01-08 Thread Benjamin Tissoires
Hi Mika, On Tue, Jan 8, 2013 at 2:05 PM, Mika Westerberg wrote: > The HID over I2C protocol specification states that when the device is > enumerated from ACPI the HID descriptor address can be obtained by > executing "_DSM" for the device with function 1. Enable this. Hehe, funny thing, I

[patch] bnx2x: NULL dereference on error in debug code

2013-01-08 Thread Dan Carpenter
"vfop" is NULL here. I've changed the debugging to not use it. Signed-off-by: Dan Carpenter --- Only needed in linux-next. diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index 71fcef0..3eef972 100644 ---

[PATCH] fix multiple mark_page_accessed called when sequentially writing a file with blocksize less than PAGE_SIZE ,which might pollute the LRU.

2013-01-08 Thread Qiang Gao
sequential write to a file with blocksize less than PAGE_SIZE will call mark_page_accessed multiple times, if (!pagevec_space(pvec)) __pagevec_lru_add(pvec, lru); it seems this trick fix this problem,but not quite thoroughly. there's a chance that when another page was

[PATCH] omap: Avoid crashes in the case of hwmod misconfiguration

2013-01-08 Thread Pantelis Antoniou
omap hwmod is really sensitive to hwmod misconfiguration. Getting a minor clock wrong always ended up in a crash. Attempt to be more resilient by not assigning variables with error codes and then attempting to use them. Without this patch, missing a clock ends up with something like this:

[PATCH] omap: DT node Timer iteration fix

2013-01-08 Thread Pantelis Antoniou
The iterator correctly handles of_node_put() calls. Remove it before continue'ing the loop. Without this patch you get: ERROR: Bad of_node_put() on /ocp/timer@44e31000! [] (unwind_backtrace+0x0/0xe0) from [] (of_node_release+0x2c/0xa0)! [] (of_node_release+0x2c/0xa0) from []

Re: [PATCH 1/5] capemgr: Beaglebone DT overlay based cape manager

2013-01-08 Thread Pantelis Antoniou
Hi Arnd, On Jan 8, 2013, at 2:12 PM, Arnd Bergmann wrote: > On Tuesday 08 January 2013, Lee Jones wrote: >>> If there is not, there is no way to automatically load the overlays; you >>> can always >>> use the kernel command line, or have the a user space application to >>> request the loading

Re: [PATCH v4 RESEND] pwm: atmel: add Timer Counter Block PWM driver

2013-01-08 Thread Boris BREZILLON
On 08/01/2013 08:10, Thierry Reding wrote: > On Thu, Dec 20, 2012 at 10:12:56AM +0100, Boris BREZILLON wrote: >> Hi, >> >> Sorry for resend. The previous version still has alignment issues on >> atmel_tcb_pwm_set_polarity, atmel_tcb_pwm_request and >> atmel_tcb_pwm_config function parameters. >>

Re: [PATCH v4 RESEND] pwm: atmel: add Timer Counter Block PWM driver

2013-01-08 Thread Thierry Reding
On Tue, Jan 08, 2013 at 01:43:56PM +0100, Boris BREZILLON wrote: > On 08/01/2013 08:10, Thierry Reding wrote: > > On Thu, Dec 20, 2012 at 10:12:56AM +0100, Boris BREZILLON wrote: [...] > >> +static void atmel_tcb_pwm_disable(struct pwm_chip *chip, struct > >> pwm_device *pwm) > >> +{ > > [...] >

Re: [PATCH RFT] regulator: s5m8767: Convert to regulator_[get|set]_voltage_sel_regmap

2013-01-08 Thread Mark Brown
On Tue, Jan 08, 2013 at 08:38:52PM +0800, Axel Lin wrote: > 2013/1/8 Mark Brown > Or do you mean Linus' current tree? ( This looks not a 3.8 material. ) I meant Linus' tree since I was starting a new topic branch (not having seen the fix branch). No need to regenerate. signature.asc

Re: [PATCH 05/11] spi/pxa2xx: make clock rate configurable from platform data

2013-01-08 Thread Mark Brown
On Tue, Jan 08, 2013 at 02:41:53PM +0200, Mika Westerberg wrote: > On Tue, Jan 08, 2013 at 11:02:28AM +, Mark Brown wrote: > > No, the way to do this is to fix x86 to enable the clock API there. The > > x86 maintainers couldn't be bothered when I submitted a patch and > > getting anyone to

[PATCH] clk: remove unreachable code

2013-01-08 Thread Rajagopal Venkat
while reparenting a clock, NULL check is done for clock in consideration and its new parent. So re-check is not required. If done, else part becomes unreachable. Signed-off-by: Rajagopal Venkat --- drivers/clk/clk.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[PATCH] lockdep: Rename print_unlock_inbalance_bug() to print_unlock_imbalance_bug()

2013-01-08 Thread Srivatsa S. Bhat
Fix the typo in the function name (s/inbalance/imbalance) Signed-off-by: Srivatsa S. Bhat --- kernel/lockdep.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/lockdep.c b/kernel/lockdep.c index 7981e5b..5cf12e7 100644 --- a/kernel/lockdep.c +++

Re: [PATCH 2/4] gpiolib: add gpiod_get and gpiod_put functions

2013-01-08 Thread Arnd Bergmann
On Tuesday 08 January 2013, Alexandre Courbot wrote: > > Adds new GPIO allocation functions that work with the opaque descriptor > interface. > > Signed-off-by: Alexandre Courbot I think you need to reorder the patches slightly, since the gpiod_get function introduced here is already being

Re: [PATCH 0/4] gpio: introduce descriptor-based interface

2013-01-08 Thread Arnd Bergmann
On Tuesday 08 January 2013, Alexandre Courbot wrote: > This series introduce a first take at implementing the RFC for the new GPIO > API > that I submitted last month. It proposes a new, opaque descriptor-based GPIO > API > that becomes available when GPIOlib is compiled, and provides a safer,

<    1   2   3   4   5   6   7   8   9   10   >