Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-12 Thread Dave Jones
On Tue, Feb 12, 2013 at 04:26:22PM -0800, Hugh Dickins wrote: > Me too on T420s, except that is blessed with a blinking CapsLk. > > It's so erratic (though I think I see more failures than you do: I'd say > a quick resume never fails, but an overnight resume fails half the time): > I'm

linux-next: manual merge of the ia64 tree with Linus' tree

2013-02-12 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the ia64 tree got a conflict in drivers/firmware/efivars.c between commit 83e68189745a ("efi: Make 'efi_enabled' a function to query EFI facilities") from the tree and commit a93bc0c6e07e ("efi_pstore: Introducing workqueue updating sysfs") from the ia64 tree.

RE: [tip:x86/hyperv] x86, hyperv: HYPERV depends on X86_LOCAL_APIC

2013-02-12 Thread KY Srinivasan
> -Original Message- > From: tip tree robot [mailto:tip...@zytor.com] On Behalf Of tip-bot for H. > Peter > Anvin > Sent: Tuesday, February 12, 2013 8:59 PM > To: linux-tip-comm...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; h...@zytor.com; mi...@kernel.org; KY > Srinivasan;

[tip:x86/hyperv] x86, hyperv: HYPERV depends on X86_LOCAL_APIC

2013-02-12 Thread tip-bot for H. Peter Anvin
Commit-ID: cb20e5f2c8d6ba7440a32f4d70c0755bceb36e78 Gitweb: http://git.kernel.org/tip/cb20e5f2c8d6ba7440a32f4d70c0755bceb36e78 Author: H. Peter Anvin AuthorDate: Tue, 12 Feb 2013 17:46:23 -0800 Committer: H. Peter Anvin CommitDate: Tue, 12 Feb 2013 17:46:23 -0800 x86, hyperv: HYPERV

Re: [PATCH] ACPI / hotplug: Fix concurrency issues and memory leaks

2013-02-12 Thread Yinghai Lu
On Tue, Feb 12, 2013 at 4:19 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > This changeset is aimed at fixing a few different but related > problems in the ACPI hotplug infrastructure. > > First of all, since notify handlers may be run in parallel with > acpi_bus_scan(),

Re: [PATCH] ACPI / PCI: Initialize PCI root drivers after PCI bus enumeration

2013-02-12 Thread Yinghai Lu
On Tue, Feb 12, 2013 at 4:16 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > After commit 1aeae82 (ACPI / PCI: avoid building pci_slot as module) > the pci_slot driver's .add() callback routine, acpi_pci_slot_add(), > is executed from within acpi_pci_root_add() before the PCI devices

Re: [PATCH 0/5] Add ChromeOS Embedded Controller support

2013-02-12 Thread Simon Glass
Hi Samuel, On Tue, Feb 12, 2013 at 4:37 PM, Simon Glass wrote: > Hi Samuel, > > On Wed, Dec 12, 2012 at 1:33 PM, Simon Glass wrote: >> (get_maintainer.pl has produced an enormous list - I hope you are all >> interested.) >> >> The ChromeOS Embedded Controller (EC) is an Open Source EC

[PATCH] regulator: as3711: Fix checking if no platform initialization data

2013-02-12 Thread Axel Lin
To skip registering regulator if no platform initialization data, we should check reg_data rather than ri->desc.name. Signed-off-by: Axel Lin --- drivers/regulator/as3711-regulator.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/as3711-regulator.c

[PATCH 2/2] regulator: s5m8767: Prevent possible NULL pointer dereference

2013-02-12 Thread Axel Lin
s5m8767_pmic_dt_parse_pdata dereferenes pdata, thus check pdata earlier to avoid NULL pointer dereference. Signed-off-by: Axel Lin --- drivers/regulator/s5m8767.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/s5m8767.c

[PATCH 1/2] regulator: s5m8767: Fix dev argument for devm_kzalloc and of_get_regulator_init_data

2013-02-12 Thread Axel Lin
Use >dev rather than iodev->dev for devm_kzalloc() and of_get_regulator_init_data(), this fixes memory leak. Signed-off-by: Axel Lin --- drivers/regulator/s5m8767.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/s5m8767.c

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-12 Thread Namhyung Kim
Hi, On Mon, 11 Feb 2013 10:54:58 +0100, Ingo Molnar wrote: > * Clark Williams wrote: > >> I figured that was coming. :) > > ;-) > >> I'll look at it again and see about pulling the >> autogroup/cgroup stuff into it's own header. After that it's >> probably going to require some serious

Re: [PATCH] usb: musb: fix context save over suspend.

2013-02-12 Thread Kevin Hilman
NeilBrown writes: > On Tue, 12 Feb 2013 13:03:36 -0800 Kevin Hilman wrote: > >> NeilBrown writes: >> [...] >> My patch was fixing a real hang when musb was built-in (or loaded), in >> host-mode (mini-A cable attached) but no devices attached. I just tried >> to reproduce this, and with

Re: [PATCH] usb: musb: fix context save over suspend.

2013-02-12 Thread NeilBrown
On Tue, 12 Feb 2013 13:03:36 -0800 Kevin Hilman wrote: > NeilBrown writes: > > > On Mon, 21 Jan 2013 13:38:59 +0200 Igor Grinberg > > wrote: > > > >> -BEGIN PGP SIGNED MESSAGE- > >> Hash: SHA1 > >> > >> Hi Neil, > >> > >> On 01/21/13 11:28, NeilBrown wrote: > >> > > >> > > >> >

Re: [PATCH 1/1] Drivers: hv: vmbus: Use the new infrastructure for delivering VMBUS interrupts

2013-02-12 Thread H. Peter Anvin
On 02/12/2013 04:50 PM, KY Srinivasan wrote: > > Apply them and I will rebase this patch and send it out. > Pull the -tip tree and you can base it on the x86/hyperv branch. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[tip:x86/hyperv] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts

2013-02-12 Thread tip-bot for K. Y. Srinivasan
Commit-ID: bc2b0331e077f576369a2b6c75d15ed4de4ef91f Gitweb: http://git.kernel.org/tip/bc2b0331e077f576369a2b6c75d15ed4de4ef91f Author: K. Y. Srinivasan AuthorDate: Sun, 3 Feb 2013 17:22:39 -0800 Committer: H. Peter Anvin CommitDate: Tue, 12 Feb 2013 16:27:15 -0800 X86: Handle Hyper-V

[tip:x86/hyperv] X86: Add a check to catch Xen emulation of Hyper-V

2013-02-12 Thread tip-bot for K. Y. Srinivasan
Commit-ID: db34bbb767bdfa1ebed7214b876fe01c5b7ee457 Gitweb: http://git.kernel.org/tip/db34bbb767bdfa1ebed7214b876fe01c5b7ee457 Author: K. Y. Srinivasan AuthorDate: Sun, 3 Feb 2013 17:22:38 -0800 Committer: H. Peter Anvin CommitDate: Tue, 12 Feb 2013 16:27:03 -0800 X86: Add a check to

[tip:x86/hyperv] x86: Hyper-V: register clocksource only if its advertised

2013-02-12 Thread tip-bot for Olaf Hering
Commit-ID: 32068f6527b8f1822a30671dedaf59c567325026 Gitweb: http://git.kernel.org/tip/32068f6527b8f1822a30671dedaf59c567325026 Author: Olaf Hering <[mailto:o...@aepfle.de]> AuthorDate: Sun, 3 Feb 2013 17:22:37 -0800 Committer: H. Peter Anvin CommitDate: Tue, 12 Feb 2013 16:25:48 -0800

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-12 Thread Hugh Dickins
On Tue, 12 Feb 2013, Dave Jones wrote: > On Tue, Feb 12, 2013 at 04:26:22PM -0800, Hugh Dickins wrote: > > On Tue, 12 Feb 2013, Dave Jones wrote: > > > > > My Thinkpad T430s suspend/resumes fine most of the time. But every so > often > > > (like one in ten times or so), as soon as I suspend,

RE: [PATCH 1/1] Drivers: hv: vmbus: Use the new infrastructure for delivering VMBUS interrupts

2013-02-12 Thread KY Srinivasan
> -Original Message- > From: H. Peter Anvin [mailto:h...@zytor.com] > Sent: Tuesday, February 12, 2013 7:46 PM > To: KY Srinivasan > Cc: Greg KH; x...@kernel.org; linux-kernel@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com;

Re: [PATCH] x86: Lock down MSR writing in secure boot

2013-02-12 Thread H. Peter Anvin
On 02/09/2013 07:11 AM, Matthew Garrett wrote: > On Sat, 2013-02-09 at 10:29 +0100, Borislav Petkov wrote: >> On Fri, Feb 08, 2013 at 10:45:35PM -0800, Kees Cook wrote: >>> Also, _reading_ MSRs from userspace arguably has utility that doesn't >>> compromise ring-0. >> >> And to come back to the

Re: [PATCH 1/1] Drivers: hv: vmbus: Use the new infrastructure for delivering VMBUS interrupts

2013-02-12 Thread H. Peter Anvin
On 02/12/2013 04:43 PM, KY Srinivasan wrote: >> >> This does not apply to v3.8-rc7 + the set of three vmbus patches for >> x86. I take it there are additional dependencies -- K.Y., what do I >> need here? > > Do none of the earlier patches apply or just this patch. If none of them > apply, I

Re: MAINTAINERS: Remove Mark M. Hoffman

2013-02-12 Thread Andrew Morton
On Fri, 8 Feb 2013 10:54:37 +0100 Jean Delvare wrote: > Mark M. Hoffman stopped working on the Linux kernel several years > ago, so he should no longer be listed as a driver maintainer. I'm not > even sure if his e-mail address still works. > > I can take over 3 drivers he was responsible for,

RE: [PATCH 1/1] Drivers: hv: vmbus: Use the new infrastructure for delivering VMBUS interrupts

2013-02-12 Thread KY Srinivasan
> -Original Message- > From: H. Peter Anvin [mailto:h...@zytor.com] > Sent: Tuesday, February 12, 2013 7:31 PM > To: Greg KH > Cc: KY Srinivasan; x...@kernel.org; linux-kernel@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com;

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-12 Thread Dave Jones
On Tue, Feb 12, 2013 at 04:26:22PM -0800, Hugh Dickins wrote: > On Tue, 12 Feb 2013, Dave Jones wrote: > > > My Thinkpad T430s suspend/resumes fine most of the time. But every so often > > (like one in ten times or so), as soon as I suspend, I get a black screen, > > and a blinking power

Re: [Bisected][-next-20130204+] [x86/kvm] udevd:[97]: segfault at ffffffffff5fd020 ip 00007fff069e277f sp 00007fff068c9ef8 error d

2013-02-12 Thread H. Peter Anvin
On 02/12/2013 04:26 PM, Peter Hurley wrote: > With -next-20130204+ in ubuntu 12.10 VM (so the 80x25 VGA > device/console): > > [0.666410] udevd[97]: starting version 175 > [0.674043] udevd[97]: udevd:[97]: segfault at ff5fd020 ip > 7fff069e277f sp 7fff068c9ef8 error d >

Re: [PATCH 0/5] Add ChromeOS Embedded Controller support

2013-02-12 Thread Simon Glass
Hi Samuel, On Wed, Dec 12, 2012 at 1:33 PM, Simon Glass wrote: > (get_maintainer.pl has produced an enormous list - I hope you are all > interested.) > > The ChromeOS Embedded Controller (EC) is an Open Source EC implementation > used on ARM and Intel Chromebooks. Current implementations use a

Re: [PATCH 1/1] Drivers: hv: vmbus: Use the new infrastructure for delivering VMBUS interrupts

2013-02-12 Thread H. Peter Anvin
On 02/06/2013 11:13 AM, Greg KH wrote: > On Wed, Feb 06, 2013 at 07:25:59AM -0800, K. Y. Srinivasan wrote: >> Use the infrastructure for delivering VMBUS interrupts using a >> special vector. With this patch, we can now properly handle >> the VMBUS interrupts that can be delivered on any CPU.

Re: [PATCH V3] ia64/mm: fix a bad_page bug when crash kernel booting

2013-02-12 Thread Tony Luck
On Tue, Feb 12, 2013 at 4:19 PM, Andrew Morton wrote: > But, umm, why am I sitting here trying to maintain an ia64 bugfix and > handling bug reports from the ia64 maintainer? Wanna swap? That sounds like a plan. I'll look out for a new version with the missing #include and less silly global

Re: [tip:x86/cpu] x86, AMD: Enable WC+ memory type on family 10 processors

2013-02-12 Thread Borislav Petkov
On Tue, Feb 12, 2013 at 04:21:13PM -0800, H. Peter Anvin wrote: > On 02/12/2013 04:16 PM, Borislav Petkov wrote: > > > >This family check is redundant, we're already in a 0x10 if-branch > >above. Boris had sent a second version which doesn't have that check: >

Re: [PATCH] avr32: atmel_default_console_device depends on CONFIG_SERIAL_ATMEL

2013-02-12 Thread Hans-Christian Egtvedt
Around Tue 12 Feb 2013 15:27:35 +0100 or thereabout, Geert Uytterhoeven wrote: > allnoconfig: > > arch/avr32/mach-at32ap/built-in.o: In function `at32_select_gpio': > (.init.text+0x548): undefined reference to `atmel_default_console_device' Indeed, I guess building without serial support has

[Bisected][-next-20130204+] [x86/kvm] udevd:[97]: segfault at ffffffffff5fd020 ip 00007fff069e277f sp 00007fff068c9ef8 error d

2013-02-12 Thread Peter Hurley
With -next-20130204+ in ubuntu 12.10 VM (so the 80x25 VGA device/console): [0.666410] udevd[97]: starting version 175 [0.674043] udevd[97]: udevd:[97]: segfault at ff5fd020 ip 7fff069e277f sp 7fff068c9ef8 error d and boots to an initramfs prompt. git bisect (log

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-12 Thread Hugh Dickins
On Tue, 12 Feb 2013, Dave Jones wrote: > My Thinkpad T430s suspend/resumes fine most of the time. But every so often > (like one in ten times or so), as soon as I suspend, I get a black screen, > and a blinking power button. > > (Note: Not the capslock lights like when we panic, this laptop

[patch for-3.8] net, sctp: remove CONFIG_EXPERIMENTAL

2013-02-12 Thread David Rientjes
From: Kees Cook This config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it. Acked-by: David S. Miller Acked-by: Vlad Yasevich Signed-off-by: Kees Cook Signed-off-by: David Rientjes --- Ah, look

Re: [tip:x86/cpu] x86, AMD: Enable WC+ memory type on family 10 processors

2013-02-12 Thread H. Peter Anvin
On 02/12/2013 04:16 PM, Borislav Petkov wrote: This family check is redundant, we're already in a 0x10 if-branch above. Boris had sent a second version which doesn't have that check: http://marc.info/?l=linux-kernel=135949774114910 but I don't know how this other version has gotten in. @hpa:

Re: [PATCH V3] ia64/mm: fix a bad_page bug when crash kernel booting

2013-02-12 Thread Andrew Morton
On Tue, 12 Feb 2013 16:11:33 -0800 Tony Luck wrote: > Building linux-next today (tag next-20130212) I get the following errors when > building arch/ia64/configs/{tiger_defconfig, zx1_defconfig, bigsur_defconfig, > sim_defconfig} > > arch/ia64/mm/init.c: In function 'free_init

Re: [PATCH V3] ia64/mm: fix a bad_page bug when crash kernel booting

2013-02-12 Thread Andrew Morton
On Tue, 12 Feb 2013 16:11:33 -0800 Tony Luck wrote: > Building linux-next today (tag next-20130212) I get the following errors when > building arch/ia64/configs/{tiger_defconfig, zx1_defconfig, bigsur_defconfig, > sim_defconfig} > > arch/ia64/mm/init.c: In function 'free_init

Re: [ 109/173] drm/i915: Close race between processing unpin task and queueing the flip

2013-02-12 Thread Ben Hutchings
On Tue, Feb 12, 2013 at 09:02:45PM -0200, Herton Ronaldo Krzesinski wrote: > On Fri, Dec 28, 2012 at 08:05:19PM +0100, Ben Hutchings wrote: > > 3.2-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Chris Wilson > > > > commit

Re: [tip:x86/cpu] x86, AMD: Enable WC+ memory type on family 10 processors

2013-02-12 Thread Borislav Petkov
Two issues I got with this one, see below. On Thu, Jan 31, 2013 at 02:45:06PM -0800, tip-bot for Boris Ostrovsky wrote: > Commit-ID: f0322bd341fd63261527bf84afd3272bcc2e8dd3 > Gitweb: http://git.kernel.org/tip/f0322bd341fd63261527bf84afd3272bcc2e8dd3 > Author: Boris Ostrovsky >

[PATCH] ACPI / hotplug: Fix concurrency issues and memory leaks

2013-02-12 Thread Rafael J. Wysocki
From: Rafael J. Wysocki This changeset is aimed at fixing a few different but related problems in the ACPI hotplug infrastructure. First of all, since notify handlers may be run in parallel with acpi_bus_scan(), acpi_bus_trim() and acpi_bus_hot_remove_device() and some of them are installed for

[tip:x86/asm] x86, head_32: Give the 6 label a real name

2013-02-12 Thread tip-bot for Borislav Petkov
Commit-ID: 5e2a044daf0c6f897eb69de931e3b29020e874a9 Gitweb: http://git.kernel.org/tip/5e2a044daf0c6f897eb69de931e3b29020e874a9 Author: Borislav Petkov AuthorDate: Mon, 11 Feb 2013 15:22:18 +0100 Committer: H. Peter Anvin CommitDate: Tue, 12 Feb 2013 15:48:42 -0800 x86, head_32: Give

[tip:x86/asm] x86, head_32: Remove second CPUID detection from default_entry

2013-02-12 Thread tip-bot for Borislav Petkov
Commit-ID: c3a22a26d07d928e2b74b58e2f9d2436958620f0 Gitweb: http://git.kernel.org/tip/c3a22a26d07d928e2b74b58e2f9d2436958620f0 Author: Borislav Petkov AuthorDate: Mon, 11 Feb 2013 15:22:17 +0100 Committer: H. Peter Anvin CommitDate: Tue, 12 Feb 2013 15:48:42 -0800 x86, head_32: Remove

Re: [PATCH V3] ia64/mm: fix a bad_page bug when crash kernel booting

2013-02-12 Thread Tony Luck
Building linux-next today (tag next-20130212) I get the following errors when building arch/ia64/configs/{tiger_defconfig, zx1_defconfig, bigsur_defconfig, sim_defconfig} arch/ia64/mm/init.c: In function 'free_initrd_mem': arch/ia64/mm/init.c:215: error: 'max_addr' undeclared (first use

[tip:x86/asm] x86: Detect CPUID support early at boot

2013-02-12 Thread tip-bot for Borislav Petkov
Commit-ID: 9efb58de919efa8312861d454be014094f6f0ffc Gitweb: http://git.kernel.org/tip/9efb58de919efa8312861d454be014094f6f0ffc Author: Borislav Petkov AuthorDate: Mon, 11 Feb 2013 15:22:16 +0100 Committer: H. Peter Anvin CommitDate: Tue, 12 Feb 2013 15:48:41 -0800 x86: Detect CPUID

[PATCH] ACPI / PCI: Initialize PCI root drivers after PCI bus enumeration

2013-02-12 Thread Rafael J. Wysocki
From: Rafael J. Wysocki After commit 1aeae82 (ACPI / PCI: avoid building pci_slot as module) the pci_slot driver's .add() callback routine, acpi_pci_slot_add(), is executed from within acpi_pci_root_add() before the PCI devices on the bus are enumerated and that triggers the WARN_ON() in

[tip:x86/asm] x86, head_32: Remove i386 pieces

2013-02-12 Thread tip-bot for Borislav Petkov
Commit-ID: 166df91daf38f619d4ca90b58ff90983de6e40d2 Gitweb: http://git.kernel.org/tip/166df91daf38f619d4ca90b58ff90983de6e40d2 Author: Borislav Petkov AuthorDate: Mon, 11 Feb 2013 15:22:15 +0100 Committer: H. Peter Anvin CommitDate: Tue, 12 Feb 2013 15:48:40 -0800 x86, head_32: Remove

[tip:x86/mm] x86, doc: Clarify the use of asm("%edx") in uaccess.h

2013-02-12 Thread tip-bot for H. Peter Anvin
Commit-ID: ff52c3b02b3f73178bfe0c219cd22abdcb0e46c3 Gitweb: http://git.kernel.org/tip/ff52c3b02b3f73178bfe0c219cd22abdcb0e46c3 Author: H. Peter Anvin AuthorDate: Tue, 12 Feb 2013 15:37:02 -0800 Committer: H. Peter Anvin CommitDate: Tue, 12 Feb 2013 15:37:02 -0800 x86, doc: Clarify the

Re: [PATCH 1/3] nbd: support FLUSH requests

2013-02-12 Thread Alex Bligh
On 12 Feb 2013, at 21:32, Andrew Morton wrote: > > Obviously the changelog was inadequate. Please send along a new one > which fully describes the reasons for this change. To be clear I have no complaints about the rest of the patch being merged. Supporting FLUSH but not FUA is far better

Re: [PATCH 1/3] nbd: support FLUSH requests

2013-02-12 Thread Alex Bligh
Paolo, On 12 Feb 2013, at 18:06, Paolo Bonzini wrote: > Il 12/02/2013 18:37, Alex Bligh ha scritto: >> For my education, why remove the FUA stuff? > > Because I had no way to test it. I think my mods to the official NBD code support FUA (albeit not very efficiently) >> Hmmm... the

Re: [PATCH] Documentation: Add a simple doc for selftests

2013-02-12 Thread Andrew Morton
On Fri, 08 Feb 2013 18:02:44 +0800 Jeremy Kerr wrote: > On 08/02/13 07:13, Andrew Morton wrote: > > > The general ruleset for selftests is: do as much as you can if you're not > > root and don't take too long and don't break the build on any > > architecture and don't cause the top-level "make

Re: [tip:x86/mm] x86, mm: Redesign get_user with a __builtin_choose_expr hack

2013-02-12 Thread H. Peter Anvin
On 02/12/2013 03:49 PM, Linus Torvalds wrote: > On Tue, Feb 12, 2013 at 3:19 PM, H. Peter Anvin wrote: >> >> Yes, but there doesn't seem to be any other way to do this. gcc won't >> even allow "=cd" even if we know the variable is 64 bits, even though >> "=A" is documented to be equivalent to

Re: [PATCH 1/3 v3] selftests: Add tests for efivarfs

2013-02-12 Thread Andrew Morton
On Fri, 08 Feb 2013 10:08:49 + Matt Fleming wrote: > On Fri, 2013-02-08 at 18:05 +0800, Jeremy Kerr wrote: > > However, the tests expose a bug at the moment, so run_tests will fail. > > Matt will have that fixed soon though :) > > In which case, would it make more sense for me to take

Re: [tip:x86/mm] x86, mm: Redesign get_user with a __builtin_choose_expr hack

2013-02-12 Thread Linus Torvalds
On Tue, Feb 12, 2013 at 3:19 PM, H. Peter Anvin wrote: > > Yes, but there doesn't seem to be any other way to do this. gcc won't > even allow "=cd" even if we know the variable is 64 bits, even though > "=A" is documented to be equivalent to "=da". No, "=da" means value "in edx _or_ %eax". Not

Re: [PATCH] net: ethernet: ti: remove redundant NULL check.

2013-02-12 Thread David Miller
From: Cyril Roelandt Date: Tue, 12 Feb 2013 23:54:41 +0100 > Ok, I resent, though I forgot to add "v2". Don't worry about that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/3 v3] selftests: Add tests for efivarfs

2013-02-12 Thread Andrew Morton
On Fri, 08 Feb 2013 18:05:52 +0800 Jeremy Kerr wrote: > > I'll do this for now: > > > > --- > > a/tools/testing/selftests/efivarfs/Makefile~selftests-add-tests-for-efivarfs-fix > > +++ a/tools/testing/selftests/efivarfs/Makefile > > @@ -6,7 +6,7 @@ test_objs = open-unlink > > all:

RE: [PATCH v9 0/3]trace,x86: irq vector tracepoint support

2013-02-12 Thread Seiji Aguchi
Peter, Could you please review this patchset? I have updated it in accordance with Steven's comment. Seiji > -Original Message- > From: Seiji Aguchi > Sent: Monday, February 04, 2013 5:49 PM > To: 'Steven Rostedt'; x...@kernel.org; H. Peter Anvin (h...@zytor.com); >

Re: [tip:x86/mm] x86, mm: Redesign get_user with a __builtin_choose_expr hack

2013-02-12 Thread Russell King - ARM Linux
On Tue, Feb 12, 2013 at 03:06:51PM -0800, Linus Torvalds wrote: > So this looks clean, but I noticed something (that was true even of > the old 64-bit accesses) > > On Tue, Feb 12, 2013 at 12:55 PM, tip-bot for H. Peter Anvin > wrote: > > + register __inttype(*(ptr)) __val_gu asm("%edx");

Re: [tip:x86/mm] x86, mm: Redesign get_user with a __builtin_choose_expr hack

2013-02-12 Thread H. Peter Anvin
On 02/12/2013 03:06 PM, Linus Torvalds wrote: > So this looks clean, but I noticed something (that was true even of > the old 64-bit accesses) > > On Tue, Feb 12, 2013 at 12:55 PM, tip-bot for H. Peter Anvin > wrote: >> + register __inttype(*(ptr)) __val_gu asm("%edx");\ >

Re: [PATCH 2/2] ima: Support appraise_type=imasig_optional

2013-02-12 Thread Mimi Zohar
On Tue, 2013-02-12 at 13:52 -0500, Vivek Goyal wrote: > On Tue, Feb 12, 2013 at 12:14:07PM -0500, Mimi Zohar wrote: > > [..] > > > > > --- a/security/integrity/ima/ima_appraise.c > > > > > +++ b/security/integrity/ima/ima_appraise.c > > > > > @@ -124,19 +124,26 @@ int ima_appraise_measurement(int

Re: [PATCH] kbuild: limit dtc+cpp include path

2013-02-12 Thread Grant Likely
On Tue, 12 Feb 2013 15:03:37 -0700, Stephen Warren wrote: > From: Stephen Warren > > Device tree source files may now include header files. The intent is > that those header files define/name constants used as part of the DT > bindings. Currently this feature is open to abuse, since any kernel

Re: [char-misc-next 01/12 v3] mei: Rename mei_device to mei_host

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, gre...@linuxfoundation.org wrote: > > > > > Please let's find something that makes both hw and Linux happy > > I still believe it makes sense to use mei_device for what we add to the MEI > > bus. I'd be fine with mei_bus_device as well, but that would somehow look > >

[PATCH v3 4/5] of: Create function for counting number of phandles in a property

2013-02-12 Thread Grant Likely
This patch creates of_count_phandle_with_args(), a new function for counting the number of phandle+argument tuples in a given property. This is better than the existing method of parsing each phandle individually until parsing fails which is a horribly slow way to do the count. Tested on ARM

[PATCH v3 3/5] of/base: Clean up exit paths for of_parse_phandle_with_args()

2013-02-12 Thread Grant Likely
Some of the exit paths were not correctly releasing the node. Fix it by creating an 'err' label for collecting the error paths and releasing the node. Cc: Rob Herring Signed-off-by: Grant Likely --- drivers/of/base.c | 26 +++--- 1 file changed, 19 insertions(+), 7

[PATCH v3 0/5] of: Add helper for counting phandle refernces

2013-02-12 Thread Grant Likely
Well, this started as a single patch to get rid of horrible brute-force counting of phandles and ended with fixes to the selftest code and cleanups to the existing phandle parser before actually getting to the new feature. The selftest code is still a little fiddly to execute, but at least it is

[PATCH v3 1/5] of/selftest: Fix GPIOs selftest to cover the 7th case

2013-02-12 Thread Grant Likely
The of_gpio_named_count() self test doesn't hit the out-of-range condition even though it is coded. Fix the bug by increasing the for loop range by one. Reported-by: Andreas Larsson Cc: Rob Herring Signed-off-by: Grant Likely --- drivers/of/selftest.c |2 +- 1 file changed, 1

Re: [tip:x86/mm] x86, mm: Redesign get_user with a __builtin_choose_expr hack

2013-02-12 Thread Linus Torvalds
So this looks clean, but I noticed something (that was true even of the old 64-bit accesses) On Tue, Feb 12, 2013 at 12:55 PM, tip-bot for H. Peter Anvin wrote: > + register __inttype(*(ptr)) __val_gu asm("%edx");\ How does gcc even alllow this? On x86-32, you cannot put

[PATCH v3 2/5] of/selftest: Use selftest() macro throughout

2013-02-12 Thread Grant Likely
Some of the selftests are open-coded. Others use the selftest() macro defined in drivers/of/selftest.c. The macro makes for cleaner selftest code, so refactor the of_parse_phandle_with_args() tests to use it. Cc: Rob Herring Signed-off-by: Grant Likely --- drivers/of/selftest.c | 37

[PATCH v3 5/5] gpio: Make of_count_named_gpios() use new of_count_phandle_with_args()

2013-02-12 Thread Grant Likely
This patch replaces the horribly coded of_count_named_gpios() with a call to of_count_phandle_with_args() which is far more efficient. This also changes the return value of of_gpio_count() & of_gpio_named_count() from 'unsigned int' to 'int' so that it can return an error code. All the users of

Re: [GIT PULL] at91: fixes for 3.9-rc1

2013-02-12 Thread Olof Johansson
On Tue, Feb 12, 2013 at 09:32:42AM +0100, Nicolas Ferre wrote: > On 02/05/2013 11:20 AM, Nicolas Ferre : > > Arnd, Olof, > > > > As I realized reading Linus' email that it was not possible to queue more > > fixes for 3.8, I took my time to send this tiny pull request. But now that > > the merge

Re: [PATCH] net: ethernet: ti: remove redundant NULL check.

2013-02-12 Thread Cyril Roelandt
On 02/12/2013 11:06 PM, David Miller wrote: From: Cyril Roelandt Date: Tue, 12 Feb 2013 22:54:46 +0100 cpdma_chan_destroy() on a NULL pointer is a no-op, so the NULL check in cpdma_ctlr_destroy() can safely be removed. Signed-off-by: Cyril Roelandt ... @@ -450,8 +450,7 @@ int

Re: [ 109/173] drm/i915: Close race between processing unpin task and queueing the flip

2013-02-12 Thread Herton Ronaldo Krzesinski
On Fri, Dec 28, 2012 at 08:05:19PM +0100, Ben Hutchings wrote: > 3.2-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Chris Wilson > > commit e7d841ca03b7ab668620045cd7b428eda9f41601 upstream. > [...] > @@ -7157,6 +7176,10 @@ static int

[PATCH] net: ethernet: ti: remove redundant NULL check.

2013-02-12 Thread Cyril Roelandt
cpdma_chan_destroy() on a NULL pointer is a no-op, so the NULL check in cpdma_ctlr_destroy() can safely be removed. Signed-off-by: Cyril Roelandt --- drivers/net/ethernet/ti/davinci_cpdma.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 2/3] sched: Move idle_balance() to post_schedule

2013-02-12 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" The idle_balance() code is called to do task load balancing just before going to idle. This makes sense as the CPU is about to sleep anyway. But currently it's called in the middle of the scheduler and in a place that must have interrupts disabled. That means,

[PATCH 1/3] sched/rt: Fix push_rt_task() to have the same checks as the caller did

2013-02-12 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Currently, push_rt_task() only pushes the task if it is lower priority than the currently running task. But it can be called for other reasons. Namely, if the current process that is about to be preempted, is a real time task and is also pinned to the CPU. This

[PATCH 0/3] [GIT PULL] sched: clean ups and a minor fix

2013-02-12 Thread Steven Rostedt
Ingo, The first of the patches is a minor fix to when a woken RT task is about to preempt a pinned RT task, push_rt_task() is called to try to migrate the woken task if possible (to avoid preempting a pinned RT task that may be the second highest priority task in the system). But the issue is

[PATCH 3/3] sched: Enable interrupts in idle_balance()

2013-02-12 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Now that the idle_balance is called from the post_schedule of the idle task sched class, it is safe to enable interrupts. This allows for better interaction of tasks waking up and other interrupts that are triggered while the idle balance is in process.

Re: [PATCH] ARM: exynos: move exynos4210-combiner to drivers/irqchip

2013-02-12 Thread Olof Johansson
On Tue, Feb 12, 2013 at 04:04:52PM -0600, Rob Herring wrote: > From: Rob Herring > > Exynos boot is broken with commit 0529e315 (ARM: use common irqchip_init > for GIC init). This commit split the irqchip initialization into 2 calls > to of_irq_init. This does not work because of_irq_init

Re: [PATCH 14/16] intel_idle: remove use and definition of MWAIT_MAX_NUM_CSTATES

2013-02-12 Thread Daniel Lezcano
On 02/12/2013 12:46 AM, Len Brown wrote: > On 02/11/2013 03:53 AM, Daniel Lezcano wrote: >> On 02/09/2013 02:08 AM, Len Brown wrote: > >>> The reason to change is that intel_idle will soon be able >>> to export more than the 8 "major" states supported by MWAIT. >>> When we hit that limit, it is

[PATCH 9/9] block: xd: replace all printks with pr_*

2013-02-12 Thread Linus Walleij
This replaces all the printk() statements with pr_* messages tagged with the apropriate log level. Errors are printed as pr_err() etc. Signed-off-by: Linus Walleij --- drivers/block/xd.c | 97 ++ 1 file changed, 62 insertions(+), 35

[PATCH 4/9] block: xd: some whitespace and #if 0 removal

2013-02-12 Thread Linus Walleij
Structure some whitespace that I personally found very irritating when reading the code, like sole tabs on lines and dangling spaces. (We get very used to our code looking the same these days.) Also delete a few instances of commenting the obvious like heads = 12 /* assign number of heads */ and

[PATCH 6/9] block: xd: avoid some forward declarations

2013-02-12 Thread Linus Walleij
This moves the code around so that we can avoid a dozen forward-declarations, then move the few remaining ones above the table that use them. No semantic changes. Signed-off-by: Linus Walleij --- drivers/block/xd.c | 801 +++-- drivers/block/xd.h

[PATCH 5/9] block: xd: avoid using typedefs

2013-02-12 Thread Linus Walleij
Two of the structs in the driver were using typedef, which we avoid since ages in the kernel. Signed-off-by: Linus Walleij --- drivers/block/xd.c | 12 ++-- drivers/block/xd.h | 10 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/block/xd.c

[PATCH 1/9] block: xd: introduce a delay before every outb operation

2013-02-12 Thread Linus Walleij
When I plug an ISA XT 8bit card into a 16bit compatible EISA slot, the outb() operations seemingly stumble over each other so we need to introduce a small delay after each outb() operation. After this my MFM MiniScribe harddrive is properly detected like this: Detected 1 hard drive (using IRQ5 &

[PATCH 7/9] block: xd: merge header file into driver

2013-02-12 Thread Linus Walleij
This consolidates the XD driver in one single file. No semantic changes. Signed-off-by: Linus Walleij --- drivers/block/xd.c | 84 +++- drivers/block/xd.h | 101 - 2 files changed, 83 insertions(+), 102

[PATCH 8/9] block: xd: remove custom DEBUG print system

2013-02-12 Thread Linus Walleij
The driver used a variant of debug levels, convert this over to using the kernel pr_debug() macro for all instances. Instead of hard-coding function names in debug messages, pass __func__. Signed-off-by: Linus Walleij --- drivers/block/xd.c | 46 +++--- 1

[PATCH 3/9] block: xd: raise timeouts

2013-02-12 Thread Linus Walleij
The timeouts for the XD driver were set pretty low, probably tested out on an error-free disk. When there are bad sectors on the disk, the controller card will autonomously perform a bump of the drive head, a quite slow mechanical operation which takes way more than one second, or even the 8

[PATCH 1/9] block: introduce a delay before every outb operation

2013-02-12 Thread Linus Walleij
When I plug an ISA XT 8bit card into a 16bit compatible EISA slot, the outb() operations seemingly stumble over each other so we need to introduce a small delay after each outb() operation. After this my MFM MiniScribe harddrive is properly detected like this: Detected 1 hard drive (using IRQ5 &

[PATCH 2/9] block: xd: fix up request handler loop

2013-02-12 Thread Linus Walleij
The result (res) variable was set to -EIO in this loop, however since the iteratively retried request execution loop would exit on !res this means that loop is never taken. Instead, assign zero to the res variable, and explicitly set it to -EIO on error. Signed-off-by: Linus Walleij ---

[PATCH 0/9] revive the XD driver a bit

2013-02-12 Thread Linus Walleij
Yes, I use this driver. I have an old PC XT 8088, and the fact that it was in the kernel tree SAVED MY DATA. Of course I couldn't boot Linux on that old machine. But I removed the disk and the controller card and put it into a Pentium MMX. The ROM on the card has to be removed or it will kill the

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Thomas Petazzoni wrote: > > Any driver that requires a > > linear mapping of I/O ports to __iomem pointers must depend > > CONFIG_HAS_IOPORT with the current definition of that symbol (as > > mentioned before, we should really rename that to > > CONFIG_HAS_IOPORT_MAP).

Re: [RFC][PATCH v2] tracing/syscalls: Allow archs to ignore tracing compat syscalls

2013-02-12 Thread H. Peter Anvin
On 02/12/2013 01:42 PM, Steven Rostedt wrote: > On Tue, 2013-02-12 at 13:33 -0800, H. Peter Anvin wrote: >> On 02/12/2013 01:18 PM, Steven Rostedt wrote: >>> [ >>> Peter, how about this patch. Instead of showing garbage, just never >>> trace compat syscalls, if the arch needs to ignore it. >>>

Re: linux-next: manual merge of the acpi tree with the pm tree

2013-02-12 Thread Stephen Rothwell
Hi Len, On Mon, 11 Feb 2013 18:34:06 -0500 Len Brown wrote: > > BTW. Rafael's "pm" tree now carries the ACPI patch stream, > so it is probably a mis-representation to call my tree the "acpi" tree. > My tree is primarily focused on the "idle" part of pm these days. OK, I have renamed your tree

Re: [v2 3/3] ARM: tegra: Unify Device tree board files

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Stephen Warren wrote: > I believe U-Boot enabled -ffunction-sections -fdata-sections or similar > (recently?) to get this kind of behaviour. I wonder why the kernel > didn't need that. Perhaps -O2 is more aggressive (within a file at > least) than I thought.

[Fwd: Re: [PATCH] MAINTAINERS: Remove Jarod Wilson and orphan LIRC drivers]

2013-02-12 Thread Joe Perches
Jerod? Remove you from MAINTAINERS or not? Your wilsonet address is bouncing. https://lkml.org/lkml/2013/2/12/531 cheers, Joe Forwarded Message From: Hans de Goede To: Joe Perches Subject: Re: [PATCH] MAINTAINERS: Remove Jarod Wilson and orphan LIRC drivers Hi On

Re: [PATCH 3/3] nbd: show read-only state in sysfs

2013-02-12 Thread Paul Clements
On Tue, Feb 12, 2013 at 11:06 AM, Paolo Bonzini wrote: > Pass the read-only flag to set_device_ro, so that it will be > visible to the block layer and in sysfs. Looks good > Cc: > Cc: Paul Clements > Cc: Andrew Morton > Signed-off-by: Paolo Bonzini > --- > drivers/block/nbd.c |3 +++ >

Re: [PATCH 2/3] nbd: fsync and kill block device on shutdown

2013-02-12 Thread Paul Clements
On Tue, Feb 12, 2013 at 11:06 AM, Paolo Bonzini wrote: > There are two problems with shutdown in the NBD driver. The first is > that receiving the NBD_DISCONNECT ioctl does not sync the filesystem; > this is useful because BLKFLSBUF is restricted to processes that have > CAP_SYS_ADMIN, and the

Re: compositing broken in -next (idr bug)

2013-02-12 Thread Tejun Heo
Hello, Jiri. On Tue, Feb 12, 2013 at 11:08:41PM +0100, Jiri Slaby wrote: > > Oh my, maybe: return ret < 0 ? ret : 0... Let's try. > > Bull's eye. Aieee > --- a/drivers/gpu/drm/drm_gem.c > +++ b/drivers/gpu/drm/drm_gem.c > @@ -459,6 +459,7 @@ drm_gem_flink_ioctl(struct drm_device *dev, void

Re: [PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value

2013-02-12 Thread Guennadi Liakhovetski
Hi Marek On Tue, 12 Feb 2013, Marek Szyprowski wrote: > Some regulators don't report any voltage values, so checking supported > voltage range results in disabling all SDHCI_CAN_VDD_* flags and > registration failure. This patch finally provides a correct fix for the > registration of SDHCI

Re: [PATCH 1/3] nbd: support FLUSH requests

2013-02-12 Thread Paul Clements
On Tue, Feb 12, 2013 at 11:06 AM, Paolo Bonzini wrote: > From: Alex Bligh > > The NBD device does not support writeback caching, thus it is not safe > against power losses unless the client opens the target with O_DSYNC or > O_SYNC. > > Add support for a new flag that the server can pass. If

Re: compositing broken in -next (idr bug)

2013-02-12 Thread Jiri Slaby
On 02/12/2013 11:03 PM, Jiri Slaby wrote: > On 02/12/2013 10:55 PM, Jiri Slaby wrote: >> --- a/drivers/gpu/drm/drm_gem.c >> +++ b/drivers/gpu/drm/drm_gem.c >> @@ -453,7 +453,8 @@ drm_gem_flink_ioctl(struct drm_device *dev, void *data, >> spin_lock(>object_name_lock); >> if

Re: [PATCH] net: ethernet: ti: remove redundant NULL check.

2013-02-12 Thread David Miller
From: Cyril Roelandt Date: Tue, 12 Feb 2013 22:54:46 +0100 > cpdma_chan_destroy() on a NULL pointer is a no-op, so the NULL check in > cpdma_ctlr_destroy() can safely be removed. > > Signed-off-by: Cyril Roelandt ... > @@ -450,8 +450,7 @@ int cpdma_ctlr_destroy(struct cpdma_ctlr *ctlr) >

<    1   2   3   4   5   6   7   8   9   10   >