Re: [PATCH] cgroup: fix cgroup_path() vs rename() race

2013-02-16 Thread Li Zefan
(sorry for the late reply, just came back from holiday) On 2013/2/9 2:46, Sasha Levin wrote: On 01/25/2013 02:09 AM, Li Zefan wrote: rename() will change dentry-d_name. The result of this race can be worse than seeing partially rewritten name, but we might access a stale pointer because

Re: [ 01/10] Revert: xfs: fix _xfs_buf_find oops on blocks beyond the filesystem end

2013-02-16 Thread Dave Chinner
On Fri, Feb 15, 2013 at 02:56:33PM -0800, Greg Kroah-Hartman wrote: 3.7-stable review patch. If anyone has any objections, please let me know. -- This reverts commit a56040731e5b00081c6d6c26b99e6e257a5d63d7 which was commit eb178619f930fa2ba2348de332a1ff1c66a31424

Re: [-rc7 regression] Buggy commit: mm: use aligned zone start for pfn_to_bitidx calculation

2013-02-16 Thread Ingo Molnar
* Ingo Molnar mi...@kernel.org wrote: Revert attached below - it reverts cleanly and I'll test this today, to see whether this solves the sporadic lockups. Ok, the revert survived a day of hundreds of randconfigs - while it would lock up within 100 randconfigs before. So this commit

Re: [-rc7 regression] Buggy commit: mm: use aligned zone start for pfn_to_bitidx calculation

2013-02-16 Thread Ingo Molnar
* Greg KH g...@kroah.com wrote: On Fri, Feb 15, 2013 at 12:44:26PM +0100, Ingo Molnar wrote: [ Greg: -stable was Cc:-ed for this potentially buggy commit. ] * Yinghai Lu ying...@kernel.org wrote: On Thu, Feb 14, 2013 at 7:08 AM, Ingo Molnar mi...@kernel.org wrote: these

[PATCH 1/4] staging/zache checkpatch ERROR: spaces prohibited around that

2013-02-16 Thread Robert Berger
zbud.c:106: ERROR: spaces prohibited around that ':' (ctx:VxW) zbud.c:107: ERROR: spaces prohibited around that ':' (ctx:VxW) Signed-off-by: Robert Berger rber@reliableembeddedsystems.com --- drivers/staging/zcache/zbud.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 2/4] staging/zache BUILD_MODNAME and checkpatch fixes

2013-02-16 Thread Robert Berger
As per Joe's suggestion: Perhaps it'd be better to use KBUILD_MODNAME all the time instead of adding the prefix. Also, to me mixing ramster: and zcache: for the prefixes is odd. Just using zcache all the time would be simpler, so remove namestr too. checkpatch fixes: zcache-main.c:1987:

[PATCH 4/4] staging/zcache KBUILD_MODNAME instead of ramster:

2013-02-16 Thread Robert Berger
Signed-off-by: Robert Berger rber@reliableembeddedsystems.com --- drivers/staging/zcache/ramster/tcp.c | 36 ++ 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/drivers/staging/zcache/ramster/tcp.c b/drivers/staging/zcache/ramster/tcp.c index

[PATCH 3/4] staging/zache KBUILD_MODNAME and checkpatch fixes

2013-02-16 Thread Robert Berger
KBUILD_MODNAME instead of ramster: checkpatch fixes: ramster.c:474: WARNING: line over 80 characters ramster.c:749: WARNING: quoted string split across lines ramster.c:756: WARNING: quoted string split across lines Signed-off-by: Robert Berger rber@reliableembeddedsystems.com ---

[PATCH 0/4] staging/zache KBUILD_MODNAME, checkpatch fixes

2013-02-16 Thread Robert Berger
1) As per Joe's suggestion: Perhaps it'd be better to use KBUILD_MODNAME all the time instead of adding the prefix. Also, to me mixing ramster: and zcache: for the prefixes is odd. Just using zcache all the time would be simpler, so remove namestr too. 2) Some checkpatch fixes Robert

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-02-16 Thread Ingo Molnar
* Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Fri, 2013-02-15 at 11:46 -0800, Sukadev Bhattiprolu wrote: POWER could use an additional field: mem_deratmiss:1 If you want to make that field more generic make it lvl1_tlb_miss, ie, a miss in the

Re: [PATCH] [Watchdog][Trivial] Added comments to explain watchdog_disabled variable

2013-02-16 Thread Ingo Molnar
* Don Zickus dzic...@redhat.com wrote: + /* +* We shouldn't enable watchdog threads if it is +* disabled.This is done by watchdog_disabled +* variable check in watchdog_*_all_cpus function. It has two grammatic and a stylistic error in it, plus

Re: [PATCH v2] clk: Add axi-clkgen driver

2013-02-16 Thread Lars-Peter Clausen
On 02/16/2013 03:52 AM, Mike Turquette wrote: Quoting Lars-Peter Clausen (2013-01-23 06:04:52) +static const struct of_device_id axi_clkgen_ids[] = { + { .compatible = adi,axi-clkgen-1.00.a }, + { }, +}; +MODULE_DEVICE_TABLE(of, axi_clkgen_ids); This method is deprecated. Can

Re: [PATCH vringh 2/2] caif_virtio: Introduce caif over virtio

2013-02-16 Thread Sjur Brændeland
Sjur Brændeland sjurb...@gmail.com writes: How about supporting struct vringh_kiov and struct kvec as well? I currently get the following complaints with my V2 patch-set: drivers/net/caif/caif_virtio.c:486:2: warning: passing argument 1 of ‘vringh_iov_init’ from incompatible pointer type

Re: [PATCH v4 3/6] mfd: Add ChromeOS EC I2C driver

2013-02-16 Thread Felipe Balbi
On Fri, Feb 15, 2013 at 08:16:09PM -0800, Simon Glass wrote: This uses an I2C bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon

Re: [PATCH v2] rwsem-spinlock: let rwsem write lock stealable

2013-02-16 Thread Yuanhan Liu
Hi Ingo, Ping... On Fri, Feb 01, 2013 at 06:59:16PM +0800, Yuanhan Liu wrote: We(Linux Kernel Performance project) found a regression introduced by commit 5a50508, which just convert all mutex lock to rwsem write lock. The semantics is same, but the results is quite huge in some cases.

[Suggestion] drivers/mfd/twl*: about power_count in twl6040_remove

2013-02-16 Thread Chen Gang
if necessary to treat 'power_count' as a counter when power_count is more than 1, we do not really power off it. this may cause issue: after finish calling twl6040_remove, another modules still use it. suggest to give additional check, or synchronisation for other modules.

Re: [RFC PATCH 2/5] powerpc: Exception hooks for context tracking subsystem

2013-02-16 Thread Li Zhong
On Sun, 2013-02-10 at 15:10 +0100, Frederic Weisbecker wrote: 2013/2/1 Li Zhong zh...@linux.vnet.ibm.com: This is the exception hooks for context tracking subsystem, including data access, program check, single step, instruction breakpoint, machine check, alignment, fp unavailable,

[PATCH 1/5] vfork: don't freezer_count() for in-kernel users of CLONE_VFORK

2013-02-16 Thread Mandeep Singh Baines
We don't need to call freezer_do_not_count() for in-kernel users of CLONE_VFORK since exec will get called in bounded time. We don't want to call freezer_count() for in-kernel users because they may be holding locks. freezer_count() calls try_to_freeze(). We don't want to freeze an in-kernel user

[PATCH 4/5] freezer: clear fake signal on exit from __refrigerator

2013-02-16 Thread Mandeep Singh Baines
In freeze_task, a freeze request is sent as a fake signal. Recalculate signal pending on exit from __refrigerator so that TIF_SIGPENDING doesn't remain incorrectly set. Signed-off-by: Mandeep Singh Baines m...@chromium.org CC: Oleg Nesterov o...@redhat.com CC: Tejun Heo t...@kernel.org CC:

[PATCH 5/5] coredump: ignore non-fatal signals when core dumping to a pipe

2013-02-16 Thread Mandeep Singh Baines
From: Ben Chan benc...@chromium.org Make wait_for_dump_helpers() not abort piping the core dump data when the crashing process has received a non-fatal signal. The abort still occurs in the case of SIGKILL. Testing: localhost ~ # echo |/usr/bin/sleep 1d /proc/sys/kernel/core_pattern localhost

[PATCH 2/5] lockdep: check that no locks held at freeze time

2013-02-16 Thread Mandeep Singh Baines
We shouldn't try_to_freeze if locks are held. Verified that I get no lockdep warnings after applying this patch and vfork: don't freezer_count() for in-kernel users of CLONE_VFORK. Changes since v1: * LKML: 20130215111635.ga26...@gmail.com Ingo Molnar * Added a msg string that gets passed in. *

[PATCH 3/5] coredump: use a freezable_schedule for the coredump_finish wait

2013-02-16 Thread Mandeep Singh Baines
Prevents hung_task detector from panicing the machine. This is also needed to prevent this wait from blocking suspend. (It doesnt' currently block suspend but it would once the next patch in this series is applied.) Changes since v1: * 20130215145323.ga30...@redhat.com Oleg Nesterov * Rebased

[Consult] drivers/mfd/twl*-irq: about clean up twl4030_sih_setup

2013-02-16 Thread Chen Gang
Hello Peter Ujfalusi: is it better to provide a function to reverse twl4030_sih_setup() ? if welcome, I will try. if really I try: excuse me, I am not quite familiar with ARM (including OMAP). so welcome any checks or suggestions before or after I finish implementing.

[Suggestion]drivers/mfd/twl*-irq: calling irq_free_descs when quit, after called irq_alloc_descs

2013-02-16 Thread Chen Gang
Hello Peter Ujfalusi: we do not call irq_free_descs when quit, although called irq_alloc_descs. is it suitable to call irq_free_descs when quit ? it seems need additional analysing, please see drivers/mfd/twl6030-irq.c:441 (after finish calling twl6030_init_irq, the twl6030_irq_base

Re: [RESEND] [PATCH] kernel/res_counter.c: remove useless return statement at res_counter_member()

2013-02-16 Thread Jeff Liu
Hi Andrew and David, On 02/15/2013 07:21 AM, Andrew Morton wrote: On Sat, 02 Feb 2013 13:04:52 +0800 Jeff Liu jeff@oracle.com wrote: The return statement after BUG() is invalid, move BUG() to the default choice of the switch. Signed-off-by: Jie Liu jeff@oracle.com ---

Re: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding

2013-02-16 Thread Russell King - ARM Linux
On Sat, Feb 16, 2013 at 10:07:39AM +, Arnd Bergmann wrote: On Saturday 16 February 2013, Viresh Kumar wrote: On 15 February 2013 23:51, Arnd Bergmann a...@arndb.de wrote: +static bool dw_dma_generic_filter(struct dma_chan *chan, void *param) { + dws-cfg_hi =

Re: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding

2013-02-16 Thread Andy Shevchenko
On Fri, Feb 15, 2013 at 8:21 PM, Arnd Bergmann a...@arndb.de wrote: The original device tree binding for this driver, from Viresh Kumar unfortunately conflicted with the generic DMA binding, and did not allow to completely seperate slave device configuration from the controller. This is an

Re: 3.8.0-rc7, nouveau, possible recursive locking, nouveau_instobj_create_ and nv50_disp_data_ctor

2013-02-16 Thread Marcin Slusarz
On Sat, Feb 16, 2013 at 12:57:07AM +0200, Denys Fedoryshchenko wrote: Hi Booted on Toshiba laptop, x86_64, NVIDIA Corporation GT218 [GeForce 310M], latest rc, and got this. Please let me know if you need additional information. It's harmless and already quieted down in Linus' tree (post

[PATCH 0/2] arm/dts: OMAP3: Add gpmc DT node support

2013-02-16 Thread Anil Kumar
Add gpmc DT node in dtsi file. Add nand DT node and partitions information for devkit8000. This series is based on top of branch “omap-for-v3.9/gpmc” git tree http://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git and patches. Anil Kumar:- ARM: dts: add minimal DT support for

[PATCH 1/2] ARM: dts: omap3: Add gpmc node

2013-02-16 Thread Anil Kumar
Add gpmc DT node. Signed-off-by: Anil Kumar anilk...@gmail.com --- :100644 100644 1acc261... 9f36531... M arch/arm/boot/dts/omap3.dtsi arch/arm/boot/dts/omap3.dtsi | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap3.dtsi

[PATCH 2/2] ARM: dts: omap3-devkit8000: add nand dt node

2013-02-16 Thread Anil Kumar
Add the needed sections to enable nand support on Devkit8000. Add nand partitions information. Signed-off-by: Anil Kumar anilk...@gmail.com --- :100644 100644 6338993... 6c6decf... M arch/arm/boot/dts/omap3-devkit8000.dts arch/arm/boot/dts/omap3-devkit8000.dts | 52

[PATCH] regulator: tps6586x: Having slew rate settings for other than SM0/1 is not fatal

2013-02-16 Thread Axel Lin
Ignore the setting and show Only SM0/SM1 can set slew rate warning is enough, then we can return 0 instead of -EINVAL in tps6586x_regulator_set_slew_rate(). Otherwise, probe() fails. Signed-off-by: Axel Lin axel@ingics.com --- drivers/regulator/tps6586x-regulator.c |2 +- 1 file

[PATCH] [Watchdog][Trivial] Added comments to explain watchdog_disabled variable

2013-02-16 Thread anish kumar
From: anish kumar anish198519851...@gmail.com This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is multifold. Uses are: 1. Check if smpboot_register_percpu_thread function passed. 2. Makes sure that user enables and disables the watchdog in sequence i.e. enable

Re: [PATCH] ia64: rename cache_show to topology_cache_show

2013-02-16 Thread Michal Hocko
On Fri 15-02-13 14:46:29, Andrew Morton wrote: On Fri, 15 Feb 2013 13:38:24 +0100 Michal Hocko mho...@suse.cz wrote: Fenguang Wu has reported the following compile time issue arch/ia64/kernel/topology.c:278:16: error: conflicting types for 'cache_show' include/linux/slab.h:224:5:

Re: [PATCH 1/2] ARM: dts: omap3: Add gpmc node

2013-02-16 Thread Ezequiel Garcia
Hi Anil, On Sat, Feb 16, 2013 at 05:08:27PM +0530, Anil Kumar wrote: Add gpmc DT node. Signed-off-by: Anil Kumar anilk...@gmail.com --- :100644 100644 1acc261... 9f36531... March/arm/boot/dts/omap3.dtsi arch/arm/boot/dts/omap3.dtsi | 11 +++ 1 files changed, 11

Re: [PATCH 1/2] ARM: dts: omap3: Add gpmc node

2013-02-16 Thread Anil Kumar
Hi, On Sat, Feb 16, 2013 at 5:54 PM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: Hi Anil, On Sat, Feb 16, 2013 at 05:08:27PM +0530, Anil Kumar wrote: Add gpmc DT node. Signed-off-by: Anil Kumar anilk...@gmail.com --- :100644 100644 1acc261... 9f36531... M

Re: [PATCH v6 3/3] ARM: mm: use static_vm for managing static mapped areas

2013-02-16 Thread Arnd Bergmann
On Wednesday 06 February 2013, Joonsoo Kim wrote: @@ -859,17 +864,12 @@ static void __init pci_reserve_io(void) { struct vm_struct *vm; unsigned long addr; + struct static_vm *svm; - /* we're still single threaded hence no lock needed here */ - for (vm = vmlist;

Re: [PATCH v6 3/3] ARM: mm: use static_vm for managing static mapped areas

2013-02-16 Thread Russell King - ARM Linux
On Sat, Feb 16, 2013 at 12:49:08PM +, Arnd Bergmann wrote: 8- ARM: mm: remove unused variables in pci_reserve_io Patch ARM: 7646/1: mm: use static_vm for managing static mapped areas removed code from pci_reserve_io but left variable declarations in place that are now unused, as gcc

[PATCH] staging: wlan-ng: hfa384x.h: fix for error reported by smatch

2013-02-16 Thread Kumar Amit Mehta
Add the missing header include for 'struct urb' datatypes to avoid potential build issues. Found using smatch. Signed-off-by: Kumar Amit Mehta gmate.a...@gmail.com --- drivers/staging/wlan-ng/hfa384x.h |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wlan-ng/hfa384x.h

Re: [PATCH v6 3/3] ARM: mm: use static_vm for managing static mapped areas

2013-02-16 Thread Arnd Bergmann
On Saturday 16 February 2013, Russell King - ARM Linux wrote: I already have such a patch in my tree - may not have pushed it out as I've been ill (and am still recovering.) Ok, thanks for the quick confirmation! Get well soon, Arnd -- To unsubscribe from this list: send the line

Re: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding

2013-02-16 Thread Arnd Bergmann
On Saturday 16 February 2013, Russell King - ARM Linux wrote: On Sat, Feb 16, 2013 at 10:07:39AM +, Arnd Bergmann wrote: On Saturday 16 February 2013, Viresh Kumar wrote: On 15 February 2013 23:51, Arnd Bergmann a...@arndb.de wrote: +static bool dw_dma_generic_filter(struct dma_chan

Re: [PATCH v6 3/3] ARM: mm: use static_vm for managing static mapped areas

2013-02-16 Thread Nicolas Pitre
On Sat, 16 Feb 2013, Arnd Bergmann wrote: On Wednesday 06 February 2013, Joonsoo Kim wrote: @@ -859,17 +864,12 @@ static void __init pci_reserve_io(void) { struct vm_struct *vm; unsigned long addr; + struct static_vm *svm; - /* we're still single threaded hence no

Re: [PATCH v6 3/3] ARM: mm: use static_vm for managing static mapped areas

2013-02-16 Thread Nicolas Pitre
On Sat, 16 Feb 2013, Russell King - ARM Linux wrote: On Sat, Feb 16, 2013 at 12:49:08PM +, Arnd Bergmann wrote: 8- ARM: mm: remove unused variables in pci_reserve_io Patch ARM: 7646/1: mm: use static_vm for managing static mapped areas removed code from pci_reserve_io but left

Re: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding

2013-02-16 Thread Arnd Bergmann
On Saturday 16 February 2013, Andy Shevchenko wrote: On Fri, Feb 15, 2013 at 8:21 PM, Arnd Bergmann a...@arndb.de wrote: @@ -168,7 +169,13 @@ static void dwc_initialize(struct dw_dma_chan *dwc) if (dwc-initialized == true) return; - if (dws) { + if

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-02-16 Thread Stephane Eranian
On Sat, Feb 16, 2013 at 3:45 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Fri, 2013-02-15 at 11:46 -0800, Sukadev Bhattiprolu wrote: POWER could use an additional field: mem_deratmiss:1 If you want to make that field more generic make it

Re: [PATCH v4 3/6] mfd: Add ChromeOS EC I2C driver

2013-02-16 Thread Simon Glass
Hi, On Sat, Feb 16, 2013 at 1:06 AM, Felipe Balbi ba...@ti.com wrote: On Fri, Feb 15, 2013 at 08:16:09PM -0800, Simon Glass wrote: This uses an I2C bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version

Stupid user with user-space questions, matrix LED driving with user space code only.

2013-02-16 Thread Jonathan Andrews
I hope this is the correct place, I expect to get abused. I'm trying to do a mostly soft real-time task with a very small hard real time element. I've written some code to drive matrix LED signs using a Raspberry Pi. Source here:

Re: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding

2013-02-16 Thread Andy Shevchenko
On Sat, Feb 16, 2013 at 4:00 PM, Arnd Bergmann a...@arndb.de wrote: On Saturday 16 February 2013, Andy Shevchenko wrote: On Fri, Feb 15, 2013 at 8:21 PM, Arnd Bergmann a...@arndb.de wrote: + if (WARN_ON(fargs.req = 16 || fargs.src = 2 || fargs.dst = 2)) + return NULL;

Re: [PATCH v1] block: partition: optimize memory allocation in check_partition

2013-02-16 Thread Ming Lei
On Sat, Feb 2, 2013 at 6:43 AM, Andrew Morton a...@linux-foundation.org wrote: On Fri, 1 Feb 2013 20:23:12 +0800 I just return from holiday, sorry for the delay, and thanks for the review. Ming Lei ming@canonical.com wrote: Currently, sizeof(struct parsed_partitions) may be 64KB in

[PATCH] x86: memtest: shorten time for tests

2013-02-16 Thread Alexander Holler
By just reversing the order memtest is using the test patterns, an additional round to zero the memory is not necessary. This might save up to a second or even more for setups which are doing tests on every boot. Signed-off-by: Alexander Holler hol...@ahsoftware.de --- arch/x86/mm/memtest.c |

Re: Re: 3.2.38 most of the time has 100% cpu use reported

2013-02-16 Thread Zhenzhong Duan
On Sat, Feb 16, 2013 at 05:18:10AM +, Ben Hutchings wrote: On Fri, 2013-02-15 at 22:23 -0500, tmhik...@gmail.com wrote: On Thu, Feb 14, 2013 at 05:04:07AM +, Ben Hutchings wrote: On Tue, 2013-02-12 at 00:01 -0500, tmhik...@gmail.com wrote: Okay, I finally have located

Re: [RFC] sched: The removal of idle_balance()

2013-02-16 Thread Steven Rostedt
On Fri, 2013-02-15 at 08:26 +0100, Mike Galbraith wrote: On Fri, 2013-02-15 at 01:13 -0500, Steven Rostedt wrote: Think about it some more, just because we go idle isn't enough reason to pull a runable task over. CPUs go idle all the time, and tasks are woken up all the time. There's no

Re: [PATCH 1/2] tty: serial: uartlite: Fix sparse and checkpatch warnings

2013-02-16 Thread Peter Korsgaard
Michal == Michal Simek michal.si...@xilinx.com writes: Michal Clean coding style and sparse warnings. Michal Signed-off-by: Michal Simek michal.si...@xilinx.com Acked-by: Peter Korsgaard jac...@sunsite.dk -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/2] tty: serial: uartlite: Support uartlite on big and little endian systems

2013-02-16 Thread Peter Korsgaard
Michal == Michal Simek michal.si...@xilinx.com writes: Michal Use big and little endian accessors function to reflect system Michal configuration. Detection is done via control register in Michal ulite_request_port. Acked-by: Peter Korsgaard jac...@sunsite.dk -- Bye, Peter Korsgaard -- To

Re: [PATCH EDAC 07/13] edac: add support for raw error reports

2013-02-16 Thread Borislav Petkov
On Fri, Feb 15, 2013 at 04:20:29PM -0200, Mauro Carvalho Chehab wrote: Yeah, pre-allocating a buffer is something that it was on my plans. It seems it is time to do it in a clean way. I prefer to keep this as a separate patch from 07/13, as it has a different rationale, and mixing with 07/13

regmap: Question about devices with unequal register sizes

2013-02-16 Thread Daniel Mack
Hi Mark and everyone, I'm writing a driver for an I2C audio codec which has an unusual register map. The datasheet can be found here: http://www.ti.com/lit/gpn/tas5086 The register layout is described on page 26, and they call their registers 'subaddresses'. Up to sub-address 0x1c, I see no

Re: [PATCH 2/2 wq/for-3.9] workqueue: reimplement is_chained_work() using current_wq_worker()

2013-02-16 Thread Lai Jiangshan
Hi, tj Thank you for adding this one. Would you deffer workqueue: rename cpu_workqueue to pool_workqueue a little? I don't want to rebase my almost-ready work again(not a good reason... but please...) I will answer your other emails soon and sent the patches. Thanks, Lai On 14/02/13

Re: [PATCH 5/5] coredump: abort core dump piping only due to a fatal signal

2013-02-16 Thread Oleg Nesterov
On 02/15, Mandeep Singh Baines wrote: On Fri, Feb 15, 2013 at 7:01 AM, Oleg Nesterov o...@redhat.com wrote: It is not enough and imho not good. Damn, I'll try very much to make the patches on weekend... - while ((pipe-readers 1) (!signal_pending(current))) { + while

Re: [PATCH 1/5] vfork: don't freezer_count() for in-kernel users of CLONE_VFORK

2013-02-16 Thread Oleg Nesterov
On 02/16, Mandeep Singh Baines wrote: We don't need to call freezer_do_not_count() for in-kernel users of CLONE_VFORK since exec will get called in bounded time. We don't want to call freezer_count() for in-kernel users because they may be holding locks. freezer_count() calls

Re: [PATCH 2/5] lockdep: check that no locks held at freeze time

2013-02-16 Thread Oleg Nesterov
Well, this is almost cosmetics, and I am not maintaner, but... On 02/16, Mandeep Singh Baines wrote: static inline bool try_to_freeze(void) { + if (current-flags PF_NOFREEZE) + return false; + debug_check_no_locks_held(current, lock held while trying to freeze); I

Re: [PATCH 4/5] freezer: clear fake signal on exit from __refrigerator

2013-02-16 Thread Oleg Nesterov
On 02/16, Mandeep Singh Baines wrote: --- a/kernel/freezer.c +++ b/kernel/freezer.c @@ -81,6 +81,9 @@ bool __refrigerator(bool check_kthr_stop) */ set_current_state(save); + /* Clear fake signal from freeze_task(). */ + recalc_sigpending(); NACK. We can't do this

Re: [PATCH 5/5] coredump: ignore non-fatal signals when core dumping to a pipe

2013-02-16 Thread Oleg Nesterov
On 02/16, Mandeep Singh Baines wrote: Make wait_for_dump_helpers() not abort piping the core dump data when the crashing process has received a non-fatal signal. The abort still occurs in the case of SIGKILL. Testing: localhost ~ # echo |/usr/bin/sleep 1d /proc/sys/kernel/core_pattern

Re: [PATCH 4/5] freezer: clear fake signal on exit from __refrigerator

2013-02-16 Thread Oleg Nesterov
Forgot to mention... On 02/16, Oleg Nesterov wrote: On 02/16, Mandeep Singh Baines wrote: --- a/kernel/freezer.c +++ b/kernel/freezer.c @@ -81,6 +81,9 @@ bool __refrigerator(bool check_kthr_stop) */ set_current_state(save); + /* Clear fake signal from freeze_task(). */

Re: [PATCH 3/5] coredump: use a freezable_schedule for the coredump_finish wait

2013-02-16 Thread Oleg Nesterov
On 02/16, Mandeep Singh Baines wrote: @@ -483,7 +484,7 @@ static void exit_mm(struct task_struct * tsk) set_task_state(tsk, TASK_UNINTERRUPTIBLE); if (!self.task) /* see coredump_finish() */ break; -

Re: xhci module fails when booting in UEFI mode

2013-02-16 Thread David Härdeman
On Thu, Jan 10, 2013 at 11:15:56AM +, Frederik Himpe wrote: I've got a HP EliteBook 8470p on which I installed Debian Wheezy in UEFI mode. With both the 3.2 kernel from Wheezy, as the 3.7.1 kernel from experimental, xhci fails to initialize and my USB mouse connected to one of these ports

[PATCH] ethernet: neterion: vxge: vxge-traffic.c: fix for a potential NULL pointer dereference

2013-02-16 Thread Kumar Amit Mehta
fix for a potential NULL pointer dereference and removal of a redundant assignment operation. Found using smatch. Signed-off-by: Kumar Amit Mehta gmate.a...@gmail.com --- drivers/net/ethernet/neterion/vxge/vxge-traffic.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff

[PATCH 1/2] dmi_scan: Fix missing check for _DMI_ signature in smbios_present()

2013-02-16 Thread Ben Hutchings
Commit 9f9c9cbb6057 ('drivers/firmware/dmi_scan.c: fetch dmi version from SMBIOS if it exists') hoisted the check for _DMI_ into dmi_scan_machine(), which means that we don't bother to check for _DMI_ at offset 16 in an SMBIOS entry. smbios_present() may also call dmi_present() for an address

[PATCH 2/2] dmi_scan: Refactor dmi_scan_machine(), {smbios,dmi}_present()

2013-02-16 Thread Ben Hutchings
Move the calls to memcpy_fromio() up into the loop in dmi_scan_machine(), and move the signature checks back down into dmi_decode(). We need to check at 16-byte intervals but keep a 32-byte buffer for an SMBIOS entry, so shift the buffer after each iteration. Merge smbios_present() into

[RFC] ARM: sa1100: collie-battery.c: include platform_device.h directly

2013-02-16 Thread Andrea Adami
Initial try to fix compilation error linux/include/linux/mfd/mcp.h:22:16: error: field 'attached_device' has incomplete type linux/include/linux/mfd/mcp.h:48:23: error: field 'drv' has incomplete type linux/include/linux/mfd/ucb1x00.h:137:17: error: field 'dev' has incomplete type

[PATCH] pwm: twl: Use to_twl() instead of container_of()

2013-02-16 Thread Johannes Thumshirn
In twl6030_pwm_disable() use to_twl() instead of container_of() like in the rest of the driver. Signed-off-by: Johannes Thumshirn morbid...@gmail.com --- drivers/pwm/pwm-twl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c

Re: [-rc7 regression] Buggy commit: mm: use aligned zone start for pfn_to_bitidx calculation

2013-02-16 Thread Linus Torvalds
On Fri, Feb 15, 2013 at 3:44 AM, Ingo Molnar mi...@kernel.org wrote: c060f943d092 may be related as you config does not have CONFIG_SPARSEMEM defined. Right, that's the commit causing the x86 regression: c060f943d0929f3e429c5d9522290584f6281d6e is the first bad commit commit

Re: [PATCH] pwm: twl: Use to_twl() instead of container_of()

2013-02-16 Thread Thierry Reding
On Sat, Feb 16, 2013 at 07:20:51PM +0100, Johannes Thumshirn wrote: In twl6030_pwm_disable() use to_twl() instead of container_of() like in the rest of the driver. Signed-off-by: Johannes Thumshirn morbid...@gmail.com --- drivers/pwm/pwm-twl.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-16 Thread Paul E. McKenney
On Fri, Feb 15, 2013 at 10:50:31AM -0800, Linus Torvalds wrote: On Fri, Feb 15, 2013 at 10:35 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Fri, Feb 15, 2013 at 10:34 AM, Linus Torvalds torva...@linux-foundation.org wrote: Something like this ENTIRELY UNTESTED patch. ..

Re: [-rc7 regression] Buggy commit: mm: use aligned zone start for pfn_to_bitidx calculation

2013-02-16 Thread Yinghai Lu
On Sat, Feb 16, 2013 at 10:26 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Fri, Feb 15, 2013 at 3:44 AM, Ingo Molnar mi...@kernel.org wrote: c060f943d092 may be related as you config does not have CONFIG_SPARSEMEM defined. Right, that's the commit causing the x86 regression:

Re: [PATCH] pwm: twl: Use to_twl() instead of container_of()

2013-02-16 Thread Johannes Thumshirn
On Sat, Feb 16, 2013 at 07:56:18PM +0100, Thierry Reding wrote: On Sat, Feb 16, 2013 at 07:20:51PM +0100, Johannes Thumshirn wrote: In twl6030_pwm_disable() use to_twl() instead of container_of() like in the rest of the driver. Signed-off-by: Johannes Thumshirn morbid...@gmail.com ---

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-16 Thread Linus Torvalds
On Sat, Feb 16, 2013 at 11:25 AM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: Sorry for the delay in testing this, but there was a need to upgrade my laptop, and bozo here figured why not go to 64 bits while I am at it? -- and then proceeded to learn the hard way that it is necessary

Re: [PATCH 5/5] coredump: ignore non-fatal signals when core dumping to a pipe

2013-02-16 Thread Oleg Nesterov
On 02/16, Oleg Nesterov wrote: On 02/16, Mandeep Singh Baines wrote: +static int sigkill_pending(struct task_struct *tsk) +{ + return signal_pending(tsk) + (sigismember(tsk-pending.signal, SIGKILL) || +sigismember(tsk-signal-shared_pending.signal, SIGKILL));

Re: [-rc7 regression] Buggy commit: mm: use aligned zone start for pfn_to_bitidx calculation

2013-02-16 Thread Linus Torvalds
On Sat, Feb 16, 2013 at 11:38 AM, Yinghai Lu ying...@kernel.org wrote: but you forgot to update setup_usemap() for SPARSEMEM Heh. I tried desperately to find a config to test my patch in, because I couldn't see how to even disable SPARSEMEM for my normal x86-64 build. But then I *only* tested

[PATCH] pwm: twl: Use to_twl() instead of container_of()

2013-02-16 Thread Johannes Thumshirn
Always use to_twl() for converting into private data instead of container_of() Signed-off-by: Johannes Thumshirn morbid...@gmail.com --- drivers/pwm/pwm-twl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c index

Re: linux-next: build failure after merge of the xen-two tree

2013-02-16 Thread Rafael J. Wysocki
On Saturday, February 16, 2013 01:52:00 AM Stephen Rothwell wrote: Hi Rafael, Hi, On Fri, 15 Feb 2013 15:53:34 +0100 Rafael J. Wysocki r...@sisk.pl wrote: On Saturday, February 16, 2013 12:50:14 AM Stephen Rothwell wrote: On Fri, 15 Feb 2013 08:26:24 -0500 Konrad Rzeszutek Wilk

Re: [PATCH] pwm: twl: Use to_twl() instead of container_of()

2013-02-16 Thread Thierry Reding
On Sat, Feb 16, 2013 at 08:54:32PM +0100, Johannes Thumshirn wrote: Always use to_twl() for converting into private data instead of container_of() Signed-off-by: Johannes Thumshirn morbid...@gmail.com --- drivers/pwm/pwm-twl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-16 Thread Dmitry Torokhov
Hi Simon, On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote: + for (row = 0; row ckdev-rows; row++) { + if (cros_ec_keyb_row_has_ghosting(ckdev, buf, row)) + return true; + } No need for curly braces here. I would not care if not for below.

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-16 Thread Paul E. McKenney
On Wed, Feb 13, 2013 at 03:53:13PM -0500, Dave Jones wrote: On Wed, Feb 13, 2013 at 11:56:25AM -0800, Linus Torvalds wrote: [ . . . ] Which points out something in tree-rcu. Which I don't even have compiled in, because I have CONFIG_PREEMPT set. FWIW, the code in kernel/rcutree.c is shared

Re: thermal governor: does it actually work??

2013-02-16 Thread Alexander Lam
I wrote a patch to fix this: http://lkml.org/lkml/2012/12/30/47 But nobody picked it up and since then I have been too busy to respin the patch for new -rc kernels. On Fri, Feb 15, 2013 at 10:49 AM, Andreas Mohr a...@lisas.de wrote: Hi, On Fri, Feb 15, 2013 at 09:47:07AM +, Zhang, Rui

[PATCH 1/2] tg3: Remove define and single use of GET_CHIP_REV_ID

2013-02-16 Thread Joe Perches
It's the same value as tp-pci_chip_rev_id so use that instead. This makes all CHIPREV_ID_foo tests the same. Signed-off-by: Joe Perches j...@perches.com --- drivers/net/ethernet/broadcom/tg3.c | 10 -- drivers/net/ethernet/broadcom/tg3.h | 4 +--- 2 files changed, 5 insertions(+), 9

Re: [PATCH] I2C: add i2c_master_send_exact() and friends

2013-02-16 Thread Jean Delvare
Hi Dmitry, On Fri, 15 Feb 2013 18:42:35 -0800, Dmitry Torokhov wrote: Many i2c users consider short transfers to be an error and would prefer getting -EIO instead of a positive return value and having to convert it to error code by themselves. So let's add the following new helpers:

Re: [PATCH 14/15] drivers/power,goldfisch battery: add missing GENERIC_HARDIRQS dependency

2013-02-16 Thread Anton Vorontsov
On Wed, Feb 06, 2013 at 05:24:02PM +0100, Heiko Carstens wrote: Fix this link error on s390: ERROR: devm_request_threaded_irq [drivers/power/goldfish_battery.ko] undefined! Cc: Anton Vorontsov c...@mail.ru Cc: David Woodhouse dw...@infradead.org Signed-off-by: Heiko Carstens

Re: [patch] generic-adc-battery: forever loop in gab_remove()

2013-02-16 Thread Anton Vorontsov
On Thu, Feb 14, 2013 at 10:26:43AM +0300, Dan Carpenter wrote: There is a forever loop calling iio_channel_release() because the chan part of the chan ARRAY_SIZE() is missing. This is in both the error handling on probe and also in the remove function. The other thing is that it's

Re: [PATCH] bq27x00_battery: Fix reporting battery temperature

2013-02-16 Thread Anton Vorontsov
On Sat, Feb 09, 2013 at 12:02:15PM +0100, Pali Rohár wrote: On Saturday 09 February 2013 02:57:18 Anton Vorontsov wrote: Hm. The documentation says tenth (1/10) degrees, and you even restate it in the commit message. But the subject, and your example seem to prove that you still report

Re: [PATCH] bq2415x_charger: Add support for offline and 100mA mode

2013-02-16 Thread Anton Vorontsov
On Sun, Feb 10, 2013 at 06:32:18PM +0100, Pali Rohár wrote: * Renamed mode BQ2415X_MODE_NONE to BQ2415X_MODE_OFF because this mode turning chaging completly off * Added new mode BQ2415X_MODE_NONE which enable charging with maximal current limit 100mA (this is minimal safe value for

Re: [PATCH 2/2] power: rx51_battery: Fix reporting correct values

2013-02-16 Thread Anton Vorontsov
On Fri, Feb 15, 2013 at 11:56:50PM +0100, Pali Rohár wrote: Tell twl4030_madc_conversion that this driver needs raw values. Driver twl4030_madc has some hardcoded values and conversation functions which are incorrect for Nokia RX-51 board. This driver rx51_battery expects raw values which

Re: [PATCH 1/2] tg3: Remove define and single use of GET_CHIP_REV_ID

2013-02-16 Thread Michael Chan
On Sat, 2013-02-16 at 13:20 -0800, Joe Perches wrote: It's the same value as tp-pci_chip_rev_id so use that instead. This makes all CHIPREV_ID_foo tests the same. Signed-off-by: Joe Perches j...@perches.com Acked-by: Michael Chan mc...@broadcom.com -- To unsubscribe from this list: send

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-16 Thread Hugh Dickins
On Thu, 14 Feb 2013, Linus Torvalds wrote: On Thu, Feb 14, 2013 at 6:09 PM, Hugh Dickins hu...@google.com wrote: Which won't affect my case since I never enabled it. Well, in theory, you may have the same bug Dave just made it easier to trigger for himself with the forced config option.

Re: thermal governor: does it actually work??

2013-02-16 Thread Borislav Petkov
On Sat, Feb 16, 2013 at 04:08:11PM -0500, Alexander Lam wrote: I wrote a patch to fix this: http://lkml.org/lkml/2012/12/30/47 But nobody picked it up and since then I have been too busy to respin the patch for new -rc kernels. Hmm, that's definitely worth a try - we've been discussing

Re: [PATCH] I2C: add i2c_master_send_exact() and friends

2013-02-16 Thread Dmitry Torokhov
On Sat, Feb 16, 2013 at 10:25:24PM +0100, Jean Delvare wrote: Hi Dmitry, On Fri, 15 Feb 2013 18:42:35 -0800, Dmitry Torokhov wrote: Many i2c users consider short transfers to be an error and would prefer getting -EIO instead of a positive return value and having to convert it to error

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-16 Thread H. Peter Anvin
The syscall generation *should* make files with different names only, but I'll look. Linus Torvalds torva...@linux-foundation.org wrote: On Sat, Feb 16, 2013 at 11:25 AM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: Sorry for the delay in testing this, but there was a need to upgrade

Re: [ 0/4] 3.0.65-stable review

2013-02-16 Thread Shuah Khan
On Fri, Feb 15, 2013 at 3:55 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: This is the start of the stable review cycle for the 3.0.65 release. There are 4 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please

Re: [ 00/10] 3.7.9-stable review

2013-02-16 Thread Shuah Khan
On Fri, Feb 15, 2013 at 3:56 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: This is the start of the stable review cycle for the 3.7.9 release. There are 10 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please

Re: [ 0/8] 3.4.32-stable review

2013-02-16 Thread Shuah Khan
On Fri, Feb 15, 2013 at 3:56 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: This is the start of the stable review cycle for the 3.4.32 release. There are 8 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please

Re: [PATCH 2/2] tg3: Use different macros for pci_chip_rev_id accesses

2013-02-16 Thread Michael Chan
On Sat, 2013-02-16 at 13:20 -0800, Joe Perches wrote: Upper case macros for various chip attributes are slightly difficult to read and are a bit out of characterto the other tg3_foo attribute functions. Convert: GET_ASIC_REV(tp-pci_chip_rev_id) - tg3_asic_rev(tp)

  1   2   3   4   >