[PATCH v4] x86, kdump: Set crashkernel_low automatically

2013-03-18 Thread Yinghai Lu
Current code does not set low range for crashkernel if the user does not specify that. That cause regressions on system that does not support intel_iommu properly. Chao said that his system does work well on 3.8 without extra parameter. even iommu does not work with kdump. Set crashkernel_low

Re: [ 00/75] 3.8.4-stable review

2013-03-18 Thread Shuah Khan
On Mon, Mar 18, 2013 at 6:57 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Mar 18, 2013 at 06:51:37PM -0600, Shuah Khan wrote: On Mon, Mar 18, 2013 at 3:06 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: This is the start of the stable review cycle for the 3.8.4

Re: [PATCH] x86,apic: Blacklist x2APIC on some platforms

2013-03-18 Thread Sergio Correia
Hello, On Sat, Jan 5, 2013 at 10:55 AM, Youquan Song youquan.s...@linux.intel.com wrote: On Tue, Dec 18, 2012 at 09:42:30AM -0800, Yinghai Lu wrote: On Tue, Dec 18, 2012 at 9:33 AM, H. Peter Anvin h...@linux.intel.com wrote: On 12/18/2012 09:07 AM, Youquan Song wrote: Blacklist x2apic when

Re: [PATCH 11/12] rwsem: wake all readers when first waiter is a reader

2013-03-18 Thread Dave Chinner
On Wed, Mar 13, 2013 at 10:00:51PM -0400, Peter Hurley wrote: On Wed, 2013-03-13 at 14:23 +1100, Dave Chinner wrote: We don't care about the ordering between multiple concurrent metadata modifications - what matters is whether the ongoing data IO around them is ordered correctly. Dave,

Re: [ 04/21] target/pscsi: Fix page increment

2013-03-18 Thread Ben Hutchings
On Tue, 2013-03-19 at 08:56 +0800, Asias He wrote: On Mon, Mar 18, 2013 at 11:30:47PM +, Ben Hutchings wrote: On Mon, 2013-03-18 at 14:00 -0700, Nicholas A. Bellinger wrote: On Mon, 2013-03-18 at 13:35 +0800, Asias He wrote: On Sat, Mar 16, 2013 at 02:10:22AM +, Ben Hutchings

Re: [PATCH 1/2] drivers: uio_dmem_genirq: Use of_match_ptr() macro

2013-03-18 Thread Damian Hobson-Garcia
On 2013/03/14 19:22, Sachin Kamat wrote: This eliminates having an #ifdef returning NULL for the case when OF is disabled. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Damian Hobson-Garcia dhobs...@igel.co.jp --- Thank you, Looks fine by me. Acked-by: Damian Hobson-Garcia

Re: [PATCH 2/9] vfs: export do_splice_direct() to modules

2013-03-18 Thread Al Viro
On Mon, Mar 18, 2013 at 11:01:03PM +, Al Viro wrote: I'm looking at the existing callers and I really wonder if we ought to push sb_start_write() from -splice_write()/-aio_write()/etc. into the callers. Something like file_start_write()/file_end_write(), with check for file being

Re: [PATCH] x86/efi: pull NV+BS variables out before we exit boot services

2013-03-18 Thread Matthew Garrett
On Mon, Mar 18, 2013 at 08:40:14AM +, James Bottomley wrote: The object here is to make the NV+BS variables accessible (at least read only) at runtime so we can get a full picture of the state of the EFI variables for debugging and secure boot purposes. I'd really prefer not to do this -

Re: [PATCH v3] target: close target_put_sess_cmd() vs. core_tmr_abort_task() race

2013-03-18 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2013 at 07:34:13PM -0400, Jörn Engel wrote: And because I'm lame and stupid, here's v3. It is possible for one thread to to take se_sess-sess_cmd_lock in core_tmr_abort_task() before taking a reference count on se_cmd-cmd_kref, while another thread in target_put_sess_cmd()

Re: [PATCH] udevadm-info: Don't access sysfs 'resourceN' files

2013-03-18 Thread Robert Hancock
On 03/16/2013 07:03 PM, Greg KH wrote: On Sat, Mar 16, 2013 at 05:50:53PM -0600, Myron Stowe wrote: On Sat, 2013-03-16 at 15:11 -0700, Greg KH wrote: On Sat, Mar 16, 2013 at 03:35:19PM -0600, Myron Stowe wrote: Sysfs includes entries to memory that backs a PCI device's BARs, both I/O Port

Re: [PATCH] clk: add DT test clock consumer driver

2013-03-18 Thread Mike Turquette
Quoting Arnd Bergmann (2013-03-16 07:56:54) On Saturday 16 March 2013, Sebastian Hesselbarth wrote: This driver adds a DT test clock consumer that exposes debugfs files to enable/disable and set/get rate of the attached programmable clock. During development of a i2c-attached clock

Re: [PATCH v5 26/44] tty: Add read-recursive, writer-prioritized rw semaphore

2013-03-18 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2013 at 09:01:19PM -0400, Peter Hurley wrote: On Mon, 2013-03-18 at 16:58 -0700, Greg Kroah-Hartman wrote: On Mon, Mar 11, 2013 at 04:44:46PM -0400, Peter Hurley wrote: 2) TIOCSETD ioctl (change line discipline) expects to return an error if the line discipline cannot

Re: [ 00/75] 3.8.4-stable review

2013-03-18 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2013 at 07:09:11PM -0600, Shuah Khan wrote: On Mon, Mar 18, 2013 at 6:57 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Mar 18, 2013 at 06:51:37PM -0600, Shuah Khan wrote: On Mon, Mar 18, 2013 at 3:06 PM, Greg Kroah-Hartman gre...@linuxfoundation.org

Re: [PATCH] udevadm-info: Don't access sysfs 'resourceN' files

2013-03-18 Thread Greg KH
On Mon, Mar 18, 2013 at 07:54:09PM -0600, Robert Hancock wrote: On 03/16/2013 07:03 PM, Greg KH wrote: On Sat, Mar 16, 2013 at 05:50:53PM -0600, Myron Stowe wrote: On Sat, 2013-03-16 at 15:11 -0700, Greg KH wrote: On Sat, Mar 16, 2013 at 03:35:19PM -0600, Myron Stowe wrote: Sysfs includes

[PATCH 1/2] extcon: max8997: use dev_err() instead of pr_err()

2013-03-18 Thread Jingoo Han
dev_err() is more preferred than pr_err(). Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/extcon/extcon-max8997.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c index 69641bc..20772ad 100644

[PATCH 2/2] extcon: max8997: add missing const

2013-03-18 Thread Jingoo Han
Fixed the checkpatch warning as below: WARNING: static const char * array should probably be static const char * const #163: FILE: drivers/extcon/extcon-max8997.c:163: +static const char *max8997_extcon_cable[] = { Signed-off-by: Jingoo Han jg1@samsung.com ---

RE: [PATCH] pm: print the name of failed suspend function for platform device

2013-03-18 Thread Li, Fei
Print more info when platform device suspend function failed. Without this patch, we can not get the real platform device suspend API info. Example without this patch: pm_op(): platform_pm_suspend+0x0/0x50 returns -11 PM: Device power.0 failed to suspend: error -11 And with this

Re: use after free in sysfs_find_dirent

2013-03-18 Thread Sasha Levin
-25520352 [ 232.824100] release_sysfs_dirent-285 sysfs_dirent use after free: vx855-bind [ 232.825297] Pid: 22751, comm: trinity-child99 Tainted: GW 3.9.0-rc2-next-20130318-sasha-00041-g7b66226-dirty #304 [ 232.827141] Call Trace: [ 232.827566] [812fa0a3] release_sysfs_dirent+0x53

Re: [PATCH 1/2] driver core: remove device_add_attrs() in drivers/base/bus.c

2013-03-18 Thread Wei Yang
On Mon, Mar 18, 2013 at 05:18:22PM -0700, Greg KH wrote: On Thu, Mar 07, 2013 at 10:22:45AM +0800, Wei Yang wrote: Originally, we have two functions named device_add_attrs() in drivers/base/bus.c and drivers/base/core.c. This will cause some confusion when reading the code. Why? It's just

Re: [PATCH] udevadm-info: Don't access sysfs 'resourceN' files

2013-03-18 Thread Robert Hancock
On Mon, Mar 18, 2013 at 8:03 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Mar 18, 2013 at 07:54:09PM -0600, Robert Hancock wrote: On 03/16/2013 07:03 PM, Greg KH wrote: On Sat, Mar 16, 2013 at 05:50:53PM -0600, Myron Stowe wrote: On Sat, 2013-03-16 at 15:11 -0700, Greg KH wrote: On

Re: [PATCH v3] target: close target_put_sess_cmd() vs. core_tmr_abort_task() race

2013-03-18 Thread Nicholas A. Bellinger
On Mon, 2013-03-18 at 19:34 -0400, Jörn Engel wrote: And because I'm lame and stupid, here's v3. It is possible for one thread to to take se_sess-sess_cmd_lock in core_tmr_abort_task() before taking a reference count on se_cmd-cmd_kref, while another thread in target_put_sess_cmd() drops

Re: [PATCH 0/2] Some cleanup in driver core

2013-03-18 Thread Wei Yang
On Mon, Mar 18, 2013 at 05:17:08PM -0700, Greg KH wrote: On Thu, Mar 07, 2013 at 10:22:44AM +0800, Wei Yang wrote: These two patches do some cleanup in the driver core. No they do not. I understand the need to fix code, but please, do so if it is broken. These patches don't help, and in fact,

Re: [GIT PULL] AB8500 Power and MFD related updates

2013-03-18 Thread Anton Vorontsov
On Thu, Mar 07, 2013 at 12:38:59PM +0800, Lee Jones wrote: The following changes since commit 6dbe51c251a327e012439c4772097a13df43c5b8: Linux 3.9-rc1 (2013-03-03 15:11:05 -0800) are available in the git repository at: git://git.linaro.org/people/ljones/linux-3.0-ux500.git

linux-next: manual merge of the workqueues tree with Linus' tree

2013-03-18 Thread Stephen Rothwell
Hi Tejun, Today's linux-next merge of the workqueues tree got a conflict in kernel/workqueue.c between commit e68035fb65de (workqueue: convert to idr_alloc()) from Linus' tree and commit 5bcab3355a55 (workqueue: separate out pool and workqueue locking into wq_mutex) from the workqueues tree. I

Re: [Patch v3 0/4] Add support for tps65090-charger

2013-03-18 Thread Anton Vorontsov
On Tue, Mar 12, 2013 at 06:08:05PM -0400, Rhyland Klein wrote: This patchset adds support for the TPS65090-charger. This charger is registered as a subdevice of the TPS65090 PMIC. This series includes a fix for the tps65090 header file where all the interrupts were shifted by 1. Thanks for

[PATCH v3 00/21] kdump, vmcore: support mmap() on /proc/vmcore

2013-03-18 Thread HATAYAMA Daisuke
Currently, read to /proc/vmcore is done by read_oldmem() that uses ioremap/iounmap per a single page. For example, if memory is 1GB, ioremap/iounmap is called (1GB / 4KB)-times, that is, 262144 times. This causes big performance degradation. In particular, the current main user of this mmap() is

[PATCH v3 01/21] vmcore: reference e_phoff member explicitly to get position of program header table

2013-03-18 Thread HATAYAMA Daisuke
Currently, the code assumes that position of program header table is next to ELF header. But future change can break the assumption on kexec-tools and the 1st kernel. To avoid worst case, reference e_phoff member explicitly to get position of program header table in file-offset. Signed-off-by:

[PATCH v3 03/21] vmcore: rearrange program headers without assuming consequtive PT_NOTE entries

2013-03-18 Thread HATAYAMA Daisuke
Current code assumes all PT_NOTE headers are placed at the beginning of program header table and they are consequtive. But the assumption could be broken by future changes on either kexec-tools or the 1st kernel. This patch removes the assumption and rearranges program headers as the following

[PATCH v3 07/21] vmcore, procfs: introduce a flag to distinguish objects copied in 2nd kernel

2013-03-18 Thread HATAYAMA Daisuke
The part of dump target memory is copied into the 2nd kernel if it doesn't satisfy mmap()'s page-size boundary requirement. To distinguish such copied object from usual old memory, a flag MEM_TYPE_CURRENT_KERNEL is introduced. If this flag is set, the object is considered being copied into buffer

[PATCH v3 10/21] vmcore: clean up read_vmcore()

2013-03-18 Thread HATAYAMA Daisuke
Clean up read_vmcore(). Part for objects in vmcore_list can be written uniformly to part for ELF headers. By this change, duplicate and complicated codes are removed, so it's more clear to see what's done there. Also, by this change, map_offset_to_paddr() is no longer used. Remove it.

[PATCH v3 13/21] kexec: allocate vmcoreinfo note buffer on page-size boundary

2013-03-18 Thread HATAYAMA Daisuke
To satisfy mmap()'s page-size boundary requirement, specify aligned attribute to vmcoreinfo_note objects to allocate it on page-size boundary. Signed-off-by: HATAYAMA Daisuke d.hatay...@jp.fujitsu.com --- include/linux/kexec.h |6 -- kernel/kexec.c|2 +- 2 files changed, 5

[PATCH v3 14/21] kexec, elf: introduce NT_VMCORE_DEBUGINFO note type

2013-03-18 Thread HATAYAMA Daisuke
This patch introduces NT_VMCORE_DEBUGINFO to a unique note type in VMCOREINFO name, which has had no name so far. The name means that it's a kind of note type in vmcoreinfo that contains system kernel's debug information. Signed-off-by: HATAYAMA Daisuke d.hatay...@jp.fujitsu.com ---

[PATCH v3 15/21] elf: introduce NT_VMCORE_PAD type

2013-03-18 Thread HATAYAMA Daisuke
The NT_VMCORE_PAD type is introduced to make both crash_notes buffer and vmcoreinfo_note buffer satisfy mmap()'s page-size boundary requirement by filling them with this note type. The purpose of this type is just to align the buffer in page-size boundary; it has no meaning in contents, which are

[PATCH v3 17/21] vmcore: check NT_VMCORE_PAD as a mark indicating the end of ELF note buffer

2013-03-18 Thread HATAYAMA Daisuke
Modern kernel marks the end of ELF note buffer with NT_VMCORE_PAD type note in order to make the buffer satisfy mmap()'s page-size boundary requirement. This patch makes finishing reading each buffer if the note type now being read is NT_VMCORE_PAD type. Signed-off-by: HATAYAMA Daisuke

[PATCH v3 18/21] vmcore: check if vmcore objects satify mmap()'s page-size boundary requirement

2013-03-18 Thread HATAYAMA Daisuke
If there's some vmcore object that doesn't satisfy page-size boundary requirement, remap_pfn_range() fails to remap it to user-space. Objects that posisbly don't satisfy the requirement are ELF note segments only. The memory chunks corresponding to PT_LOAD entries are guaranteed to satisfy

[PATCH v3 19/21] vmcore: round-up offset of vmcore object in page-size boundary

2013-03-18 Thread HATAYAMA Daisuke
To satisfy mmap()'s page-size bounary requirement, round-up offset of each vmcore objects in page-size boundary; each offset is connected to user-space virtual address through mapping of mmap(). Signed-off-by: HATAYAMA Daisuke d.hatay...@jp.fujitsu.com --- fs/proc/vmcore.c | 18

[PATCH v3 20/21] vmcore: count holes generated by round-up operation for vmcore size

2013-03-18 Thread HATAYAMA Daisuke
The previous patch changed offsets of each vmcore objects by round-up operation. vmcore size must count the holes. Signed-off-by: HATAYAMA Daisuke d.hatay...@jp.fujitsu.com --- fs/proc/vmcore.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH v3 21/21] vmcore: introduce mmap_vmcore()

2013-03-18 Thread HATAYAMA Daisuke
This patch introduces mmap_vmcore(). If flag MEM_TYPE_CURRENT_KERNEL is set, remapped is the buffer on the 2nd kernel. If not set, remapped is some area in old memory. Neither writable nor executable mapping is permitted even with mprotect(). Non-writable mapping is also requirement of

[PATCH v3 16/21] kexec: fill note buffers by NT_VMCORE_PAD notes in page-size boundary

2013-03-18 Thread HATAYAMA Daisuke
Fill both crash_notes and vmcoreinfo_note buffers by NT_VMCORE_PAD note type to make them satisfy mmap()'s page-size boundary requirement. So far, end of note segments has been marked by zero-filled elf header. Instead, this patch writes NT_VMCORE_PAD note in the end of note segments until the

[PATCH v3 12/21] vmcore: allocate per-cpu crash_notes objects on page-size boundary

2013-03-18 Thread HATAYAMA Daisuke
To satisfy mmap()'s page-size boundary requirement, allocate per-cpu crash_notes objects on page-size boundary. /proc/vmcore on the 2nd kernel checks if each note objects is allocated on page-size boundary. If there's some object not satisfying the page-size boundary requirement, /proc/vmcore

tpm_tis driver failed to suspend, error -62

2013-03-18 Thread Aaron Lu
Hi Rajiv, Not sure if I should send this to you, please kindly forward it to the appropriate person if not, thanks. Peter has encountered a problem during suspend, the tpm_tis driver's suspend callback will fail, the relevant message is: [ 192.281757] PM: Syncing filesystems ... done. [

[PATCH] ARM: tegra: fuse: add fuctions to read speedo id and process id

2013-03-18 Thread Danny Huang
Add functions to read the speedo and process id of both cpu and soc. There might be some drivers need the information as well. Signed-off-by: Danny Huang dahu...@nvidia.com --- arch/arm/mach-tegra/fuse.c | 24 include/linux/tegra-soc.h | 6 +- 2 files changed, 29

[PATCH v3 11/21] vmcore: read buffers for vmcore objects copied from old memory

2013-03-18 Thread HATAYAMA Daisuke
If flag MEM_TYPE_CURRENT_KERNEL is set, the object is copied in the buffer on the 2nd kernel, then read_vmcore() reads the buffer. If the flag is not set, read_vmcore() reads old memory as usual. Signed-off-by: HATAYAMA Daisuke d.hatay...@jp.fujitsu.com --- fs/proc/vmcore.c | 15

Re: [PATCH] udevadm-info: Don't access sysfs 'resourceN' files

2013-03-18 Thread Greg KH
On Mon, Mar 18, 2013 at 08:09:22PM -0600, Robert Hancock wrote: Great, that's one possible solution, the other is just not creating the files at all for known problem devices, right? I don't think one can reasonably enumerate all problem devices. There are probably countless devices which

[PATCH v3 06/21] vmcore: round up buffer size of ELF headers by PAGE_SIZE

2013-03-18 Thread HATAYAMA Daisuke
To satisfy mmap() page-size boundary requirement, round up buffer size of ELF headers by PAGE_SIZE. The resulting value becomes offset of ELF note segments and it's assigned in unique PT_NOTE program header entry. Also, some part that assumes past ELF headers' size is replaced by this new

Re: A patch to test_power module

2013-03-18 Thread Anton Vorontsov
On Sun, Feb 03, 2013 at 01:17:16PM +0200, Andrey Gelman wrote: [...] The patch looks good, but it is missing Signed-off-by tag. Plus, you should also Cc: linux-kernel@vger.kernel.org on submissions (I've added it now). Plus, please don't use html in emails. :) [...] Fixed ... I think.

[PATCH v3 02/21] vmcore: clean up by removing unnecessary variable

2013-03-18 Thread HATAYAMA Daisuke
The variable j has int type but it's compared with u64 type. Also, the purpose of the variable j is exactly what the variable real_sz is used for now. Replace the variable j by the variable real_sz and remove the variable j. Signed-off-by: HATAYAMA Daisuke d.hatay...@jp.fujitsu.com ---

[PATCH v3 05/21] vmcore: allocate buffer for ELF headers on page-size alignment

2013-03-18 Thread HATAYAMA Daisuke
Allocate buffer for ELF headers on page-size aligned boudary to satisfy mmap() requirement. For this, __get_free_pages() is used instead of kmalloc(). Also, later patch will decrease actually used buffer size for ELF headers, so it's necessary to keep original buffer size and actually used buffer

[PATCH v3 04/21] vmcore, sysfs: export ELF note segment size instead of vmcoreinfo data size

2013-03-18 Thread HATAYAMA Daisuke
Currently, vmcoreinfo exports data part only, but kexec-tool sets it in p_memsz member as a whole ELF note segment size. Due to this, it would be no problem on the current ELF note segment size, but if it grows in the future, then read possibly doesn't reach ELF note header in larger p_memsz

Re: [PATCH] pm: print the name of failed suspend function for platform device

2013-03-18 Thread Greg KH
On Tue, Mar 19, 2013 at 02:05:02AM +, Li, Fei wrote: Print more info when platform device suspend function failed. Without this patch, we can not get the real platform device suspend API info. Example without this patch: pm_op(): platform_pm_suspend+0x0/0x50 returns -11

Re: [PATCH v3] target: close target_put_sess_cmd() vs. core_tmr_abort_task() race

2013-03-18 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2013 at 07:11:12PM -0700, Nicholas A. Bellinger wrote: On Mon, 2013-03-18 at 19:34 -0400, Jörn Engel wrote: And because I'm lame and stupid, here's v3. It is possible for one thread to to take se_sess-sess_cmd_lock in core_tmr_abort_task() before taking a reference count

Re: [PATCH] x86,apic: Blacklist x2APIC on some platforms

2013-03-18 Thread Youquan Song
I found this patch after some googling and for the record, it makes my W520 boot with VT-d enabled and the discrete NVidia card. Is it still being considered? Yes. I am still in pushing the patch to upstream. The patch is good and reviewed by Yinghai but it depends on Yinghai's patch

[RFC] iowait/idle time accounting hiccups in NOHZ kernels

2013-03-18 Thread Fernando Luis Vázquez Cao
(Moving discussion to LKML) Hi Thomas, Frederic, Tetsuo Handa reported that the iowait time obtained through /proc/stat is not monotonic. The reason is that get_cpu_iowait_time_us() is inherently racy; -idle_entrytime and -iowait_sleeptime can be updated from another CPU (via

Re: [PATCH] iommu: making IOMMU sysfs nodes API public

2013-03-18 Thread Alex Williamson
On Mon, 2013-03-18 at 14:53 +1100, Alexey Kardashevskiy wrote: On 20/02/13 15:33, Alex Williamson wrote: On Wed, 2013-02-20 at 15:20 +1100, Alexey Kardashevskiy wrote: On 20/02/13 14:47, Alex Williamson wrote: On Wed, 2013-02-20 at 13:31 +1100, Alexey Kardashevskiy wrote: On 20/02/13

Re: [RFC PATCH] seq_file: Use seq_puts when seq_printf has only a format with no args

2013-03-18 Thread Joe Perches
On Mon, 2013-03-18 at 13:59 -0700, Andrew Morton wrote: On Sat, 16 Mar 2013 17:54:47 + Al Viro v...@zeniv.linux.org.uk wrote: On Sat, Mar 16, 2013 at 06:50:44AM -0700, Joe Perches wrote: Instead of converting the 800 or so uses of seq_printf with a constant format (without a %

Re: [PATCH] fs: pstore: Replaced calls to kmalloc and memcpy with kmemdup

2013-03-18 Thread Anton Vorontsov
On Sun, Mar 10, 2013 at 04:23:01PM -0700, Kees Cook wrote: On Sat, Mar 9, 2013 at 3:57 AM, Alexandru Gheorghiu gheorghiuan...@gmail.com wrote: Replaced calls to kmalloc and memcpy with a single call to kmemdup. This patch was found using coccicheck. Signed-off-by: Alexandru Gheorghiu

Re: [PATCH v3] target: close target_put_sess_cmd() vs. core_tmr_abort_task() race

2013-03-18 Thread Nicholas A. Bellinger
On Mon, 2013-03-18 at 19:39 -0700, Greg Kroah-Hartman wrote: On Mon, Mar 18, 2013 at 07:11:12PM -0700, Nicholas A. Bellinger wrote: On Mon, 2013-03-18 at 19:34 -0400, Jörn Engel wrote: And because I'm lame and stupid, here's v3. It is possible for one thread to to take

Re: [PATCH] s3c-adc-battery: Fix possible NULL pointer dereference

2013-03-18 Thread Anton Vorontsov
On Mon, Feb 25, 2013 at 04:33:25AM +0530, Syam Sidhardhan wrote: Check for (bat == NULL) has to be done before accessing bat Signed-off-by: Syam Sidhardhan s.s...@samsung.com --- Applied, thanks! drivers/power/s3c_adc_battery.c |7 +-- 1 file changed, 5 insertions(+), 2

Re: [PATCH 38/88] asus-laptop: Do not call HWRS on init

2013-03-18 Thread Ben Hutchings
On Thu, 2013-03-14 at 10:35 +, Luis Henriques wrote: 3.5.7.8 -stable review patch. If anyone has any objections, please let me know. -- From: Ben Hutchings b...@decadent.org.uk commit cb7da022450cdaaebd33078b6b32fb7dd2aaf6db upstream. Since commit 8871e99f89b7

Re: [PATCH 42/88] exec: use -ELOOP for max recursion depth

2013-03-18 Thread Ben Hutchings
On Thu, 2013-03-14 at 10:35 +, Luis Henriques wrote: 3.5.7.8 -stable review patch. If anyone has any objections, please let me know. -- From: Kees Cook keesc...@chromium.org commit d740269867021faf4ce38a449353d2b986c34a67 upstream. To avoid an explosion of

Re: Re: [PATCH -tip ] [BUGFIX] kprobes: Move hash_64() into .text.kprobe section

2013-03-18 Thread Masami Hiramatsu
(2013/03/19 5:57), Timo Juhani Lindfors wrote: Masami Hiramatsu masami.hiramatsu...@hitachi.com writes: Thank you for reporting!! Thanks for fixing these! I spent some time trying to automate the process of finding sensitive functions and eventually resorted into booting a kvm instance with

Re: [PATCH 66/88] hwmon: (sht15) Check return value of regulator_enable()

2013-03-18 Thread Ben Hutchings
On Thu, 2013-03-14 at 10:35 +, Luis Henriques wrote: 3.5.7.8 -stable review patch. If anyone has any objections, please let me know. -- From: Mark Brown broo...@opensource.wolfsonmicro.com commit 3e78080f81481aa8340374d5a37ae033c1cf4272 upstream. Not having

Re: [PATCH 6/6] KVM: MMU: fast zap all shadow pages

2013-03-18 Thread Xiao Guangrong
On 03/19/2013 04:46 AM, Marcelo Tosatti wrote: On Wed, Mar 13, 2013 at 12:59:12PM +0800, Xiao Guangrong wrote: The current kvm_mmu_zap_all is really slow - it is holding mmu-lock to walk and zap all shadow pages one by one, also it need to zap all guest page's rmap and all shadow page's parent

Re: [PATCH 03/10] mm: vmscan: Flatten kswapd priority loop

2013-03-18 Thread Simon Jeons
Hi Mel, On 03/17/2013 09:04 PM, Mel Gorman wrote: kswapd stops raising the scanning priority when at least SWAP_CLUSTER_MAX pages have been reclaimed or the pgdat is considered balanced. It then rechecks if it needs to restart at DEF_PRIORITY and whether high-order reclaim needs to be reset.

Re: [PATCH] udevadm-info: Don't access sysfs 'resourceN' files

2013-03-18 Thread Robert Hancock
On Mon, Mar 18, 2013 at 8:35 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Mar 18, 2013 at 08:09:22PM -0600, Robert Hancock wrote: Great, that's one possible solution, the other is just not creating the files at all for known problem devices, right? I don't think one can reasonably

Re: [ 45/82] USB: EHCI: dont check DMA values in QH overlays

2013-03-18 Thread Ben Hutchings
On Mon, 2013-03-18 at 04:22 +, Ben Hutchings wrote: 3.2-stable review patch. If anyone has any objections, please let me know. -- From: Alan Stern st...@rowland.harvard.edu commit feca7746d5d9e84b105a613b7f3b6ad00d327372 upstream. This patch (as1661) fixes a

[PATCH] checkpatch: Prefer seq_puts to seq_printf

2013-03-18 Thread Joe Perches
Add a check for seq_printf use with a constant format without additional arguments. Suggest seq_puts instead. Suggested-by: Bjorn Helgaas bhelg...@google.com Signed-off-by: Joe Perches j...@perches.com --- scripts/checkpatch.pl | 16 1 file changed, 16 insertions(+) diff --git

Re: [PATCH 5/5] KVM: MMU: fast invalid all mmio sptes

2013-03-18 Thread Xiao Guangrong
On 03/19/2013 06:16 AM, Eric Northup wrote: On Fri, Mar 15, 2013 at 8:29 AM, Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com wrote: This patch tries to introduce a very simple and scale way to invalid all mmio sptes - it need not walk any shadow pages and hold mmu-lock KVM maintains a global

Re: [ 04/21] target/pscsi: Fix page increment

2013-03-18 Thread Nicholas A. Bellinger
On Tue, 2013-03-19 at 01:18 +, Ben Hutchings wrote: On Tue, 2013-03-19 at 08:56 +0800, Asias He wrote: On Mon, Mar 18, 2013 at 11:30:47PM +, Ben Hutchings wrote: On Mon, 2013-03-18 at 14:00 -0700, Nicholas A. Bellinger wrote: On Mon, 2013-03-18 at 13:35 +0800, Asias He wrote:

Re: [PATCH 2/2] extcon: max8997: add missing const

2013-03-18 Thread Sachin Kamat
On 19 March 2013 07:33, Jingoo Han jg1@samsung.com wrote: Fixed the checkpatch warning as below: WARNING: static const char * array should probably be static const char * const #163: FILE: drivers/extcon/extcon-max8997.c:163: +static const char *max8997_extcon_cable[] = {

ext4_block_to_path block max warning.

2013-03-18 Thread Dave Jones
Not sure what I did to trigger this, but it's happened a few times while fuzzing syscalls. Rebooted and fscked, didn't find anything wrong. Dave [ 5084.436288] EXT4-fs warning (device sda1): ext4_block_to_path:105: block 1874853625 max in inode 34 [ 5167.723925] EXT4-fs warning

Re: [PATCH 00/03] gpio: Renesas R-Car GPIO driver update

2013-03-18 Thread Magnus Damm
Hi Laurent, On Thu, Mar 14, 2013 at 10:13 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Magnus, On Thursday 14 March 2013 13:23:46 Magnus Damm wrote: On Wed, Mar 13, 2013 at 9:58 PM, Laurent Pinchart wrote: On Wednesday 13 March 2013 20:32:03 Magnus Damm wrote: gpio:

Re: [PATCH 2/2] extcon: max8997: add missing const

2013-03-18 Thread Jingoo Han
-Original Message- From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: Tuesday, March 19, 2013 12:33 PM To: Jingoo Han Cc: MyungJoo Ham; Chanwoo Choi; linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] extcon: max8997: add missing const On 19 March 2013 07:33, Jingoo

linux-next: manual merge of the akpm tree with the usb-gadget tree

2013-03-18 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm tree got a conflict in drivers/usb/gadget/amd5536udc.c between commit 6c39d90393a2 (usb: gadget: amd5536udc: remove unnecessary initializations) from the tree and commit drivers/usb/gadget/amd5536udc.c: avoid calling dma_pool_create() with NULL dev

Re: use after free in sysfs_find_dirent

2013-03-18 Thread Ming Lei
Hi Sasha, On Tue, Mar 19, 2013 at 10:06 AM, Sasha Levin levinsasha...@gmail.com wrote: [ 232.822703] sysfs_dir_pos-973 sysfs_dirent use after free: vx855(vx855)-bind, 0-25520352 Looks filp-f_pos is changed as zero by llseek(), so may leave filp-private_data point to one refcount-balanced

[PATCH] kernel/range.c: subtract_range: fix the broken phrase issued by printk

2013-03-18 Thread Lin Feng
Also replace deprecated printk(KERN_ERR...) with pr_err() as suggested by Yinghai, attaching the function name to provide plenty info. Cc: Yinghai Lu ying...@kernel.org Signed-off-by: Lin Feng linf...@cn.fujitsu.com --- kernel/range.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [patch] mm: speedup in __early_pfn_to_nid

2013-03-18 Thread David Rientjes
On Mon, 18 Mar 2013, Russ Anderson wrote: When booting on a large memory system, the kernel spends considerable time in memmap_init_zone() setting up memory zones. Analysis shows significant time spent in __early_pfn_to_nid(). The routine memmap_init_zone() checks each PFN to verify the

linux-next: build warning after merge of the workqueues tree

2013-03-18 Thread Stephen Rothwell
Hi Tejun, After merging the workqueues tree, today's linux-next build (powerpc allnoconfig) produced this warning: kernel/workqueue.c:260:13: warning: 'workqueue_freezing' defined but not used [-Wunused-variable] Introduced by commit 699ce097efe8 (workqueue: implement and use

Re: [ 00/75] 3.8.4-stable review

2013-03-18 Thread Shuah Khan
On Mon, Mar 18, 2013 at 8:00 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Mar 18, 2013 at 07:09:11PM -0600, Shuah Khan wrote: On Mon, Mar 18, 2013 at 6:57 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Mar 18, 2013 at 06:51:37PM -0600, Shuah Khan wrote:

Re: [ 00/75] 3.8.4-stable review

2013-03-18 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2013 at 10:00:32PM -0600, Shuah Khan wrote: On Mon, Mar 18, 2013 at 8:00 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Mar 18, 2013 at 07:09:11PM -0600, Shuah Khan wrote: On Mon, Mar 18, 2013 at 6:57 PM, Greg Kroah-Hartman gre...@linuxfoundation.org

RE: [PATCH 5/7] usb: phy: tegra: get ULPI reset GPIO info using DT.

2013-03-18 Thread Venu Byravarasu
-Original Message- From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- ow...@vger.kernel.org] On Behalf Of Sergei Shtylyov Sent: Monday, March 18, 2013 6:32 PM To: Venu Byravarasu Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu; ba...@ti.com;

linux-next: Tree for Mar 19

2013-03-18 Thread Stephen Rothwell
Hi all, Changes since 20130318: The l2-mtd tree gained a conflict against Linus' tree. The char-misc tree still had its build failure so I used the version from next-20130315. The gpio tree still had its build failure for which I reverted a commit. The workqueues tree gained a conflict

[PATCH 1/1] extcon: max77693: Staticize default_init_data

2013-03-18 Thread Sachin Kamat
Commit 0ec83bd246 (extcon: max77693: Initialize register of MUIC device to bring up it without platform data) added this structure but forgot to make it static. Without this patch we get the following warning: drivers/extcon/extcon-max77693.c:41:26: warning: symbol 'default_init_data' was not

Re: [PATCH 01/12] Security: Add CAP_COMPROMISE_KERNEL

2013-03-18 Thread James Morris
On Mon, 18 Mar 2013, Matthew Garrett wrote: This patch introduces CAP_COMPROMISE_KERNEL. I'd like to see this named CAP_MODIFY_KERNEL, which is more accurate and less emotive. Otherwise I think core kernel developers will be scratching their head over where to sprinkle this. Apart from

Re: [PATCH] f2fs: reduce unncessary locking pages during read

2013-03-18 Thread Namjae Jeon
- err = f2fs_readpage(sbi, page, dn.data_blkaddr, READ_SYNC); - if (err) { - f2fs_put_page(page, 1); - return ERR_PTR(err); + if (PageUptodate(page)) { + unlock_page(page); + return page; } - unlock_page(page); Hi

Re: [RFC PATCH] Allow optional module parameters

2013-03-18 Thread Rusty Russell
Andy Lutomirski l...@amacapital.net writes: On Sun, Mar 17, 2013 at 7:24 PM, Rusty Russell ru...@rustcorp.com.au wrote: Andy Lutomirski l...@amacapital.net writes: On Thu, Mar 14, 2013 at 10:03 PM, Rusty Russell ru...@rustcorp.com.au wrote: Err, yes. Don't remove module parameters, they're

[PATCH v4] target: close target_put_sess_cmd() vs. core_tmr_abort_task() race

2013-03-18 Thread Jörn Engel
On Mon, 18 March 2013 18:53:54 -0700, Greg Kroah-Hartman wrote: On Mon, Mar 18, 2013 at 07:34:13PM -0400, Jörn Engel wrote: --- drivers/target/target_core_transport.c | 17 +++-- include/linux/kref.h | 26 ++ 2 files changed, 37

Re: [PATCH V3 0/7] Create sched_select_cpu() and use it for workqueues

2013-03-18 Thread Viresh Kumar
On 18 March 2013 20:53, Viresh Kumar viresh.ku...@linaro.org wrote: In order to save power, it would be useful to schedule light weight work on cpus that aren't IDLE instead of waking up an IDLE one. By idle cpu (from scheduler's perspective) we mean: - Current task is idle task -

[PATCH v2] ARM: mm: clean-up in order to reduce to call kmap_high_get()

2013-03-18 Thread Joonsoo Kim
In kmap_atomic(), kmap_high_get() is invoked for checking already mapped area. In __flush_dcache_page() and dma_cache_maint_page(), we explicitly call kmap_high_get() before kmap_atomic() when cache_is_vipt(), so kmap_high_get() can be invoked twice. This is useless operation, so remove one. v2:

Re: [RFC PATCH] ARM: mm: disable kmap_high_get() for SMP

2013-03-18 Thread Joonsoo Kim
On Thu, Mar 07, 2013 at 07:35:51PM +0900, JoonSoo Kim wrote: 2013/3/7 Nicolas Pitre nicolas.pi...@linaro.org: On Thu, 7 Mar 2013, Joonsoo Kim wrote: Hello, Nicolas. On Tue, Mar 05, 2013 at 05:36:12PM +0800, Nicolas Pitre wrote: On Mon, 4 Mar 2013, Joonsoo Kim wrote: With SMP

Re: [PATCH v4] target: close target_put_sess_cmd() vs. core_tmr_abort_task() race

2013-03-18 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2013 at 11:31:12PM -0400, Jörn Engel wrote: On Mon, 18 March 2013 18:53:54 -0700, Greg Kroah-Hartman wrote: On Mon, Mar 18, 2013 at 07:34:13PM -0400, Jörn Engel wrote: --- drivers/target/target_core_transport.c | 17 +++-- include/linux/kref.h

Re: [PATCH v2 1/3] slub: correct to calculate num of acquired objects in get_partial_node()

2013-03-18 Thread Joonsoo Kim
Hello, Pekka. Could you pick up 1/3, 3/3? These are already acked by Christoph. 2/3 is same effect as Glauber's slub: correctly bootstrap boot caches, so should skip it. Thanks. On Mon, Jan 21, 2013 at 05:01:25PM +0900, Joonsoo Kim wrote: There is a subtle bug when calculating a number of

Re: [PATCH 2/2] perf tests: Add a test case for checking sw clock event frequency

2013-03-18 Thread Namhyung Kim
Hi Arnaldo, On Mon, 18 Mar 2013 11:42:43 -0300, Arnaldo Carvalho de Melo wrote: Em Mon, Mar 18, 2013 at 11:41:47AM +0900, Namhyung Kim escreveu: +static int __test__sw_clock_freq(enum perf_sw_ids clock_id) +{ +int i, err = -1; +volatile int tmp = 0; +u64 total_periods = 0; +

Re: [PATCH 0/8] correct load_balance()

2013-03-18 Thread Joonsoo Kim
On Mon, Feb 25, 2013 at 01:56:59PM +0900, Joonsoo Kim wrote: On Thu, Feb 14, 2013 at 02:48:33PM +0900, Joonsoo Kim wrote: Commit 88b8dac0 makes load_balance() consider other cpus in its group. But, there are some missing parts for this feature to work properly. This patchset correct these

Re: [PATCH V3 1/7] sched: Create sched_select_cpu() to give preferred CPU for power saving

2013-03-18 Thread Viresh Kumar
On 18 March 2013 21:27, Frederic Weisbecker fweis...@gmail.com wrote: 2013/3/18 Viresh Kumar viresh.ku...@linaro.org: It would be nice to have some more precise naming. sched_select_busy_cpu() ? You are correct that name can be improved but busy may give it a different meaning. Maybe

Re: [PATCH V3 3/7] workqueue: Add helpers to schedule work on any cpu

2013-03-18 Thread Viresh Kumar
On 18 March 2013 20:53, Viresh Kumar viresh.ku...@linaro.org wrote: queue_work() queues work on current cpu. This may wake up an idle CPU, which is actually not required. Some of these works can be processed by any CPU and so we must select a non-idle CPU here. The initial idea was to

[PATCH 2/3] mm, nobootmem: clean-up of free_low_memory_core_early()

2013-03-18 Thread Joonsoo Kim
Remove unused argument and make function static, because there is no user outside of nobootmem.c Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com diff --git a/include/linux/bootmem.h b/include/linux/bootmem.h index cdc3bab..5f0b0e1 100644 --- a/include/linux/bootmem.h +++

[PATCH 1/3] mm, nobootmem: fix wrong usage of max_low_pfn

2013-03-18 Thread Joonsoo Kim
max_low_pfn reflect the number of _pages_ in the system, not the maximum PFN. You can easily find that fact in init_bootmem(). So fix it. Additionally, if 'start_pfn == end_pfn', we don't need to go futher, so change range check. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com diff --git

[PATCH 3/3] mm, nobootmem: do memset() after memblock_reserve()

2013-03-18 Thread Joonsoo Kim
Currently, we do memset() before reserving the area. This may not cause any problem, but it is somewhat weird. So change execution order. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com diff --git a/mm/nobootmem.c b/mm/nobootmem.c index 589c673..f11ec1c 100644 --- a/mm/nobootmem.c +++

Re: [PATCH] f2fs: should check the node page was truncated first

2013-03-18 Thread Namjae Jeon
2013/3/18, Jaegeuk Kim jaegeuk@samsung.com: Currently, f2fs doesn't reclaim any node pages. However, if we found that a node page was truncated by checking its block address with zero during f2fs_write_node_page, we should not skip that node page and return zero to reclaim it.

<    4   5   6   7   8   9   10   11   12   13   >