[PATCH v2] checkpatch.pl: Check for functions without a real prototype

2013-11-22 Thread Elena Ufimtseva
Based on Richard Weinberger patch https://lkml.org/lkml/2012/3/16/510 Functions like this one are evil: void foo() { ... } Signed-off-by: Elena Ufimtseva --- Changes since v1: - added white space in regular expression between (), based on comments from Joe Perches.

Re: [PATCH] PCI: Init NumVFs register to zero in sriov_init()

2013-11-22 Thread Bjorn Helgaas
On Wed, Nov 6, 2013 at 7:49 AM, ethan.zhao wrote: > Though no specification about NumVFs register initial value after POST, to > void the confusion > lspci output as following before VF was enabled, we should clear the NumVFs > value left by BIOS > to zero: > > $lspci -vvv -s 03:00.0 > Ethernet

Re: [PATCH tty-next 1/5] tty: Always handle NULL flag ptr

2013-11-22 Thread Dmitry Torokhov
Hi Peter, On Fri, Nov 22, 2013 at 12:09:54PM -0500, Peter Hurley wrote: > Most line disciplines already handle the undocumented NULL flag > ptr in their .receive_buf method; however, several don't. > > Document the NULL flag ptr, and correct handling in the > N_MOUSE, N_GSM0710 and N_R394 line

Re: 3.10.16 cgroup_mutex deadlock

2013-11-22 Thread Tejun Heo
On Fri, Nov 22, 2013 at 09:59:37PM +0100, William Dauchy wrote: > Hugh, Tejun, > > Do we have some news about this patch? I'm also hitting this bug on a 3.10.x Just applied to cgroup/for-3.13-fixes w/ stable cc'd. Will push to Linus next week. Thanks. -- tejun -- To unsubscribe from this

[PATCH cgroup/for-3.13-fixes] cgroup: use a dedicated workqueue for cgroup destruction

2013-11-22 Thread Tejun Heo
Hello, Hugh. I applied the following patch to cgroup/for-3.13-fixes. For longer term, I think it'd be better to pull workqueue init before cgroup one but this one should be easier to backport for now. Thanks! - >8 - >From e5fca243abae1445afbfceebda5f08462ef869d3 Mon Sep 17 00:00:00

Re: [RFC PATCH] double free in decompressor.c

2013-11-22 Thread Geyslan Gregório Bem
2013/11/22 Richard Weinberger : > On Fri, Nov 22, 2013 at 10:50 PM, Geyslan Gregório Bem > wrote: >> Coverity caught double free possibility (CID 1130962). > > Just wondering, where can one find/verify such CIDs? > > -- > Thanks, > //richard Anyone can sign in (https://scan.coverity.com/) and

[PATCH] mm/zswap: reverse zswap_entry tree/refcount relationship

2013-11-22 Thread Dan Streetman
Currently, zswap_entry_put removes the entry from its tree if the resulting refcount is 0. Several places in code put an entry's initial reference, but they also must remove the entry from its tree first, which makes the tree removal in zswap_entry_put redundant. I believe this has the refcount

[PATCH v3] mm/zswap: change zswap to writethrough cache

2013-11-22 Thread Dan Streetman
Currently, zswap is writeback cache; stored pages are not sent to swap disk, and when zswap wants to evict old pages it must first write them back to swap cache/disk manually. This avoids swap out disk I/O up front, but only moves that disk I/O to the writeback case (for pages that are evicted),

Re: [PATCH] doc: fix generation of device-drivers

2013-11-22 Thread Randy Dunlap
On 11/20/13 00:50, Nicolas Dichtel wrote: > Since commit 7a6354e241d8 ("sched: Move wait.c into kernel/sched/"), the path > of this file has changed. This is a fatal kernel-doc error. Please merge quickly/soon. Thanks. > CC: Peter Zijlstra > CC: Ingo Molnar > Signed-off-by: Nicolas Dichtel

Re: [PATCH v3 2/2] tracing: Fix Oops from NULL pointer dereference from __assign_str

2013-11-22 Thread Rafael J. Wysocki
On Friday, November 22, 2013 10:54:29 AM Shuah Khan wrote: > Tracing infrastructure routine __assign_str doesn't handle null strings. > As a result when an trace event passes in a null string, kernel panics > when skip_spaces() is invoked on the string. The following oops occurred > when a null

Re: [RFC PATCH] double free in decompressor.c

2013-11-22 Thread Richard Weinberger
On Fri, Nov 22, 2013 at 10:50 PM, Geyslan Gregório Bem wrote: > Coverity caught double free possibility (CID 1130962). Just wondering, where can one find/verify such CIDs? -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[PATCH 2/2] rtc: add hym8563 rtc-driver

2013-11-22 Thread Heiko Stübner
The Haoyu Microelectronics HYM8563 provides rtc- and alarm functions as well as a clock output of up to 32kHz. Signed-off-by: Heiko Stuebner --- drivers/rtc/Kconfig | 11 + drivers/rtc/Makefile |1 + drivers/rtc/rtc-hym8563.c | 619 +

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

2013-11-22 Thread Rafael J. Wysocki
On Friday, November 22, 2013 10:36:23 PM Francis Moreau wrote: > On 11/22/2013 01:54 PM, Rafael J. Wysocki wrote: > > On Friday, November 22, 2013 10:57:25 AM Francis Moreau wrote: > >> Le 22/11/2013 08:43, Francis Moreau a écrit : > >>> Le 21/11/2013 12:17, Jingoo Han a écrit : > >>> [...] >

[PATCH 1/2] dt-bindings: add hym8563 binding

2013-11-22 Thread Heiko Stübner
Add binding documentation for the hym8563 rtc chip. Signed-off-by: Heiko Stuebner --- .../devicetree/bindings/rtc/haoyu,hym8563.txt | 29 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt diff --git

[PATCH 0/2] Add support for hym8563 rtcs

2013-11-22 Thread Heiko Stübner
This series adds support for the Haoyu Microelectronics HYM8563 rtc. This chip is often used in designs around the Cortex-A9 SoCs from Rockchip to provide rtc functionality and the 32kHz suspend clock the SoC needs. Heiko Stuebner (2): Documentation: dt: Add dt hym8563 binding rtc: add

[RFC PATCH] double free in decompressor.c

2013-11-22 Thread Geyslan Gregório Bem
Coverity caught double free possibility (CID 1130962). I can patch this, but I have to know if is correct to free comp_opts in the function squashfs_decompressor_create() or it had to be done in the caller. My bet is the caller. 128void *squashfs_decompressor_setup(struct super_block *sb,

Re: [PATCH] cpufreq: Make sure CPU is running on a freq from freq-table

2013-11-22 Thread Nishanth Menon
On 11/22/2013 01:03 AM, viresh kumar wrote: > On Thursday 21 November 2013 12:39 PM, Viresh Kumar wrote: [...] > Copying another mail from Nishant here to get my cc'list back.. > > On Friday 22 November 2013 05:12 AM, Nishanth Menon wrote: >> I gave this a quick run on my 3.12 kernel: >>

Re: [PATCH] dt-bindings: add ARMv8 PMU binding

2013-11-22 Thread Rob Herring
On 11/22/2013 03:38 PM, Kumar Gala wrote: > > On Nov 22, 2013, at 3:17 PM, Rob Herring wrote: > >> From: Rob Herring >> >> Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU. >> >> Signed-off-by: Rob Herring >> Cc: Will Deacon >> Cc: Pawel Moll >> Cc: Mark Rutland >> Cc: Ian

Re: [PATCH] dt-bindings: add ARMv8 PMU binding

2013-11-22 Thread Kumar Gala
On Nov 22, 2013, at 3:17 PM, Rob Herring wrote: > From: Rob Herring > > Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU. > > Signed-off-by: Rob Herring > Cc: Will Deacon > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Ian Campbell > --- >

Re: [PATCH] dt-bindings: add GIC-400 binding

2013-11-22 Thread Kumar Gala
On Nov 22, 2013, at 3:17 PM, Rob Herring wrote: > From: Rob Herring > > Add "arm,gic-400" compatible property for ARM GIC-400 IP. > > Signed-off-by: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Ian Campbell > --- > Documentation/devicetree/bindings/arm/gic.txt | 1 + > 1 file

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

2013-11-22 Thread Francis Moreau
On 11/22/2013 01:54 PM, Rafael J. Wysocki wrote: > On Friday, November 22, 2013 10:57:25 AM Francis Moreau wrote: >> Le 22/11/2013 08:43, Francis Moreau a écrit : >>> Le 21/11/2013 12:17, Jingoo Han a écrit : >>> [...] > >> Also I took a look at the changes between v3.11 and v3.12 in this

Re: BUG: mm, numa: test segfaults, only when NUMA balancing is on

2013-11-22 Thread Alex Thorlton
> If the warning added by that patch does *not* trigger than can you also > test this patch? It removes the barriers which should not be necessary > and takes a reference tot he page before waiting on the lock. The > previous version did not take the reference because otherwise the > WARN_ON could

Re: [PATCH -tip v3 13/23] x86/trap: Use NOKPROBE_SYMBOL macro in trap.c

2013-11-22 Thread Andi Kleen
On Wed, Nov 20, 2013 at 04:22:21AM +, Masami Hiramatsu wrote: > Use NOKPROBE_SYMBOL macro to protect functions from kprobes > instead of __kprobes annotation in trap.c. > This also applies __always_inline annotation for some cases, > because NOKPROBE_SYMBOL() will inhibit inlining by referring

Re: [PATCH] x86: enable DMA CMA with swiotlb

2013-11-22 Thread Andi Kleen
"H. Peter Anvin" writes: > > If you have a real iotlb, why would you need contiguous memory? iotlb is often slow. Another use case is allocating 1GB pages at runtime. -Andi -- a...@linux.intel.com -- Speaking for myself only -- To unsubscribe from this list: send the line "unsubscribe

[PATCH] Prevent infinite loop if unwind fails

2013-11-22 Thread Francis Giraldeau
Unwind may loop forever if sample is incomplete or bogus. Bound the number of unw_step() that yield the same IP to prevent infinite loop. Signed-off-by: Francis Giraldeau --- tools/perf/util/unwind.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH] dt-bindings: add GIC-400 binding

2013-11-22 Thread Rob Herring
From: Rob Herring Add "arm,gic-400" compatible property for ARM GIC-400 IP. Signed-off-by: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell --- Documentation/devicetree/bindings/arm/gic.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] dt-bindings: add ARMv8 PMU binding

2013-11-22 Thread Rob Herring
From: Rob Herring Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU. Signed-off-by: Rob Herring Cc: Will Deacon Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell --- Documentation/devicetree/bindings/arm/pmu.txt | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 2/5] net: MOXA ART: connect to PHY and add ethtool support

2013-11-22 Thread Florian Fainelli
Hello Jonas, > + if (!priv->phy_dev) > + return -ENODEV; This should not be required since you will fail probing the interface if you cannot connect to the PHY device. > + > + return phy_ethtool_gset(priv->phy_dev, cmd); > +} > + > +static int

Re: [PATCH v7 1/4] qrwlock: A queue read/write lock implementation

2013-11-22 Thread Linus Torvalds
On Fri, Nov 22, 2013 at 12:35 PM, Waiman Long wrote: > > Yes, the extra latency of the fair lock in earlier patch is due to the need > to do a second cmpxchg(). That can be avoided by doing a read first, but > that is not good for good cache. So I optimized it for the default unfair > lock. By

Re: [PATCH 2/2] memory: ti-aemif: add bindings for AEMIF driver

2013-11-22 Thread Kumar Gala
On Nov 20, 2013, at 1:03 PM, ivan.khoronzhuk wrote: > On 11/20/2013 08:21 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: >>> + the chip select signal. >>> + Minimum value is 1 (0 treated as 1). >>> + >>> +- ti,cs-wsetup:write setup

[ANNOUNCE] 3.12.1-rt4

2013-11-22 Thread Sebastian Andrzej Siewior
Dear RT folks! I'm pleased to announce the v3.12.1-rt4 patch set. Changes since v3.12.0-rt2 - rtmutex: the patch with the conversion to raw_spinlock_irq() of the waiter lock has been replaced by a trylock attempt this keeps the change a lot smaller. Initially suggested by Matt Cowell.

Re: recursive locking (coredump/vfs_write)

2013-11-22 Thread Jan Kara
Hi, On Wed 13-11-13 16:11:47, Dave Jones wrote: > here's another one.. > > > = > [ INFO: possible recursive locking detected ] > 3.12.0+ #2 Not tainted > - > trinity-child3/13302 is trying to acquire lock:

Re: [PATCH 2/5] net: MOXA ART: connect to PHY and add ethtool support

2013-11-22 Thread Florian Fainelli
2013/11/22 Jonas Jensen : > On 22 November 2013 15:57, Jonas Jensen wrote: >> drivers/net/ethernet/moxa/moxart_ether.c | 179 >> ++- >> drivers/net/ethernet/moxa/moxart_ether.h | 1 + >> 2 files changed, 179 insertions(+), 1 deletion(-) > > I see now I forgot to

Re: [PATCH 2/2] memory: ti-aemif: add bindings for AEMIF driver

2013-11-22 Thread Kumar Gala
On Nov 20, 2013, at 9:46 AM, Ivan Khoronzhuk wrote: > Add bindings for AEMIF controller drivers/memory/ti-aemif.c > Binding shouldn’t normally refer to code. Just saying something like: Adding binging for TI Async External Memory Interface (AEMIF) controller. > Signed-off-by: Ivan

Re: Why is O_DSYNC on linux so slow / what's wrong with my SSD?

2013-11-22 Thread Stefan Priebe
Hi Ric, Am 22.11.2013 21:37, schrieb Ric Wheeler: On 11/22/2013 03:01 PM, Stefan Priebe wrote: Hi Christoph, Am 21.11.2013 11:11, schrieb Christoph Hellwig: 2. Some drives may implement CMD_FLUSH to return immediately i.e. no guarantee the data is actually on disk. In which case they

Re: [PATCH v2 3/7] net: rfkill: gpio: remove gpio conversion support

2013-11-22 Thread Stephen Warren
On 11/22/2013 01:56 PM, Heikki Krogerus wrote: > On Fri, Nov 22, 2013 at 11:40:32AM -0700, Stephen Warren wrote: >> On 11/22/2013 05:14 AM, Mika Westerberg wrote: >>> From: Heikki Krogerus >>> >>> All platforms using this driver are now converted to the new >>> descriptor-based GPIO interface. >>

Re: [PATCH 2/4] check_unsafe_exec: kill the dead -EAGAIN and clear_in_exec logic

2013-11-22 Thread KOSAKI Motohiro
>> I have found no problem in this patch. However, I have a very basic question. >> Why do we need to keep fs->in_exec? > > To ensure that a sub-thread can't create a new process with the same > ->fs while we are doing exec without LSM_UNSAFE_SHARE, I guess. This > is only for security/ code.

Re: 3.10.16 cgroup_mutex deadlock

2013-11-22 Thread William Dauchy
On Mon, Nov 18, 2013 at 3:17 AM, Hugh Dickins wrote: > Sorry for the delay: I was on the point of reporting success last > night, when I tried a debug kernel: and that didn't work so well > (got spinlock bad magic report in pwd_adjust_max_active(), and > tests wouldn't run at all). > > Even the

Re: [PATCH v2 3/7] net: rfkill: gpio: remove gpio conversion support

2013-11-22 Thread Heikki Krogerus
On Fri, Nov 22, 2013 at 11:40:32AM -0700, Stephen Warren wrote: > On 11/22/2013 05:14 AM, Mika Westerberg wrote: > > From: Heikki Krogerus > > > > All platforms using this driver are now converted to the new > > descriptor-based GPIO interface. > > Don't you want to remove the fields from the

Re: [PATCH 2/4] check_unsafe_exec: kill the dead -EAGAIN and clear_in_exec logic

2013-11-22 Thread Oleg Nesterov
On 11/22, KOSAKI Motohiro wrote: > > (11/22/2013 12:54 PM), Oleg Nesterov wrote: > > fs_struct->in_exec == T means that this ->fs is used by a single > > process (thread group), and one of the treads does do_execve(). > > > > To avoid the mt-exec races this code has the following complications: >

Re: [PATCH 4/6] kexec: A new system call, kexec_file_load, for in kernel kexec

2013-11-22 Thread Jiri Kosina
On Wed, 20 Nov 2013, Vivek Goyal wrote: > This patch implements the in kernel kexec functionality. It implements a > new system call kexec_file_load. I think parameter list of this system > call will change as I have not done the kernel image signature handling > yet. I have been told that I

Re: Why is O_DSYNC on linux so slow / what's wrong with my SSD?

2013-11-22 Thread Ric Wheeler
On 11/22/2013 03:01 PM, Stefan Priebe wrote: Hi Christoph, Am 21.11.2013 11:11, schrieb Christoph Hellwig: 2. Some drives may implement CMD_FLUSH to return immediately i.e. no guarantee the data is actually on disk. In which case they aren't spec complicant. While I've seen countless data

Linux 3.13-rc1 is out

2013-11-22 Thread Linus Torvalds
So you had an extra week to prepare your pull requests, and if you were planning on sending it in the last two days thinking I'd close the merge window on Sunday as usual, I can only laugh derisively in your general direction, and call you bad names. Because I'm not interested in your excuses. I

Re: [uml-devel] fuzz tested 32 bit user mode linux image hangs in radix_tree_next_chunk()

2013-11-22 Thread Toralf Förster
On 11/06/2013 10:31 PM, Richard Weinberger wrote: > Can you please ask gdb for the value of offset? With this diff against latest Linus tree v3.12-11355-g57498f9 : diff --git a/lib/radix-tree.c b/lib/radix-tree.c index 7811ed3..54d9802 100644 --- a/lib/radix-tree.c +++ b/lib/radix-tree.c @@

Re: [PATCH v7 1/4] qrwlock: A queue read/write lock implementation

2013-11-22 Thread Waiman Long
On 11/22/2013 02:14 PM, Linus Torvalds wrote: On Fri, Nov 22, 2013 at 11:04 AM, Waiman Long wrote: In term of single-thread performance (no contention), a 256K lock/unlock loop was run on a 2.4GHz and 2.93Ghz Westmere x86-64 CPUs. The following table shows the average time (in ns) for a single

Re: [PATCH v2 4/4] kill task_struct->did_exec

2013-11-22 Thread KOSAKI Motohiro
(11/22/2013 3:33 PM), Oleg Nesterov wrote: > On 11/22, KOSAKI Motohiro wrote: >> >> (11/22/2013 12:54 PM), Oleg Nesterov wrote: >>> We can kill either task->did_exec or PF_FORKNOEXEC, they are >>> mutually exclusive. The patch kill ->did_exec because it has >>> a single user. >> >> It's ok. >> >>

Re: [PATCH 1/4] check_unsafe_exec: use while_each_thread() rather than next_thread()

2013-11-22 Thread KOSAKI Motohiro
(11/22/2013 3:24 PM), Oleg Nesterov wrote: > On 11/22, KOSAKI Motohiro wrote: >> >> (11/22/2013 12:54 PM), Oleg Nesterov wrote: >>> next_thread() should be avoided, change check_unsafe_exec() >>> to use while_each_thread(). This also saves 32 bytes. >> >> Just curious. >> Why it should be avoided?

[PATCH v2 4/4] kill task_struct->did_exec

2013-11-22 Thread Oleg Nesterov
On 11/22, KOSAKI Motohiro wrote: > > (11/22/2013 12:54 PM), Oleg Nesterov wrote: > > We can kill either task->did_exec or PF_FORKNOEXEC, they are > > mutually exclusive. The patch kill ->did_exec because it has > > a single user. > > It's ok. > > but, > > > - * Auch. Had to add the 'did_exec' flag

Re: [PATCH 3/4] exec: move the final allow_write_access/fput into free_bprm()

2013-11-22 Thread KOSAKI Motohiro
(11/22/2013 12:54 PM), Oleg Nesterov wrote: > Both success/failure paths cleanup bprm->file, we can move this > code into free_bprm() to simlify and cleanup this logic. > > Signed-off-by: Oleg Nesterov Acked-by: KOSAKI Motohiro -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 2/4] check_unsafe_exec: kill the dead -EAGAIN and clear_in_exec logic

2013-11-22 Thread KOSAKI Motohiro
(11/22/2013 12:54 PM), Oleg Nesterov wrote: > fs_struct->in_exec == T means that this ->fs is used by a single > process (thread group), and one of the treads does do_execve(). > > To avoid the mt-exec races this code has the following complications: > > 1. check_unsafe_exec() returns

Re: [GIT] Security subsystem updates for 3.13

2013-11-22 Thread David Howells
Linus Torvalds wrote: > So for future cases: if there are big independent overhauls of core > subsystems, I'd really like to see them kept separate, ok? Since the trusted and encrypted keys that Mimi and Dmitry deal with are also more akin to the keyring stuff, should they go through the

Re: [PATCH 1/4] check_unsafe_exec: use while_each_thread() rather than next_thread()

2013-11-22 Thread Oleg Nesterov
On 11/22, KOSAKI Motohiro wrote: > > (11/22/2013 12:54 PM), Oleg Nesterov wrote: > > next_thread() should be avoided, change check_unsafe_exec() > > to use while_each_thread(). This also saves 32 bytes. > > Just curious. > Why it should be avoided? Just for cleaner code? Nobody except

Re: [PATCH 3/3] signals: change do_signal_stop/do_sigaction to use while_each_thread()

2013-11-22 Thread Sameer Nanda
On Fri, Nov 22, 2013 at 11:18 AM, Oleg Nesterov wrote: > Change do_signal_stop() and do_sigaction() to avoid next_thread() > and use while_each_thread() instead. > > Signed-off-by: Oleg Nesterov Reviewed-by: Sameer Nanda > --- > kernel/signal.c |7 +++ > 1 files changed, 3

Re: [PATCH 2/3] k_getrusage() can use while_each_thread()

2013-11-22 Thread Sameer Nanda
On Fri, Nov 22, 2013 at 11:18 AM, Oleg Nesterov wrote: > Change k_getrusage() to use while_each_thread(), no changes in > the compiled code. > > Signed-off-by: Oleg Nesterov Reviewed-by: Sameer Nanda > --- > kernel/sys.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff

Re: [PATCH 1/3] proc: change do_task_stat() to use while_each_thread()

2013-11-22 Thread Sameer Nanda
On Fri, Nov 22, 2013 at 11:18 AM, Oleg Nesterov wrote: > do_task_stat() can use while_each_thread(), no changes in > the compiled code. > > Signed-off-by: Oleg Nesterov Reviewed-by: Sameer Nanda > --- > fs/proc/array.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff

[tip:timers/urgent] time: Fix 1ns/tick drift w/ GENERIC_TIME_VSYSCALL_OLD

2013-11-22 Thread tip-bot for Martin Schwidefsky
Commit-ID: 4be77398ac9d948773116b6be4a3c91b3d6ea18c Gitweb: http://git.kernel.org/tip/4be77398ac9d948773116b6be4a3c91b3d6ea18c Author: Martin Schwidefsky AuthorDate: Fri, 22 Nov 2013 11:44:51 -0800 Committer: Thomas Gleixner CommitDate: Fri, 22 Nov 2013 21:08:11 +0100 time: Fix

Re: [PATCH 3/8] perf symbol: Save vmlinux or kallsyms path loaded

2013-11-22 Thread David Ahern
On 11/22/13, 12:40 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Nov 22, 2013 at 12:13:52PM -0700, David Ahern escreveu: On 11/22/13, 11:44 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Nov 18, 2013 at 01:32:46PM -0700, David Ahern escreveu: Save vmlinux or kallsyms path loaded using embedded

Re: Why is O_DSYNC on linux so slow / what's wrong with my SSD?

2013-11-22 Thread Stefan Priebe
Hi Christoph, Am 21.11.2013 11:11, schrieb Christoph Hellwig: 2. Some drives may implement CMD_FLUSH to return immediately i.e. no guarantee the data is actually on disk. In which case they aren't spec complicant. While I've seen countless data integrity bugs on lower end ATA SSDs I've not

Re: [PATCH 5/8] ARM: OMAP2+: timer: Introduce OF-friendly clocksource/clockevent system timers

2013-11-22 Thread Rob Herring
On Fri, Nov 22, 2013 at 10:42 AM, Joel Fernandes wrote: > On 11/22/2013 09:58 AM, Rob Herring wrote: >> On Thu, Nov 21, 2013 at 7:56 PM, Joel Fernandes wrote: >>> This work is a migration effort of OMAP system timers to the >>> clocksource/clockevent framework. Consider this as a first-pass in

Re: Why is O_DSYNC on linux so slow / what's wrong with my SSD?

2013-11-22 Thread Stefan Priebe
Am 20.11.2013 16:55, schrieb J. Bruce Fields: On Wed, Nov 20, 2013 at 10:37:03AM -0500, Theodore Ts'o wrote: On Wed, Nov 20, 2013 at 08:52:36PM +0530, Chinmay V S wrote: If you have confirmed the performance numbers, then it indicates that the Intel 530 controller is more advanced and makes

Re: 3.12 Regression: dcache: Translating dentry into pathname without taking rename_lock 232d2d60

2013-11-22 Thread Greg KH
On Thu, Nov 21, 2013 at 03:16:13PM -0800, Michael Marineau wrote: > On Thu, Nov 21, 2013 at 3:01 PM, Greg KH wrote: > > On Wed, Nov 13, 2013 at 02:51:59PM -0800, Michael Marineau wrote: > >> On Wed, Nov 13, 2013 at 4:39 AM, Al Viro wrote: > >> > On Wed, Nov 13, 2013 at 03:34:13AM -0800, Michael

Re: Why is O_DSYNC on linux so slow / what's wrong with my SSD?

2013-11-22 Thread Stefan Priebe
Am 20.11.2013 16:22, schrieb Chinmay V S: Hi Stefan, thanks for your great and detailed reply. I'm just wondering why an intel 520 ssd degrades the speed just by 2% in case of O_SYNC. intel 530 the newer model and replacement for the 520 degrades speed by 75% like the crucial m4. The Intel DC

Re: [PATCH 1/4] check_unsafe_exec: use while_each_thread() rather than next_thread()

2013-11-22 Thread KOSAKI Motohiro
(11/22/2013 12:54 PM), Oleg Nesterov wrote: > next_thread() should be avoided, change check_unsafe_exec() > to use while_each_thread(). This also saves 32 bytes. Just curious. Why it should be avoided? Just for cleaner code? Or is there serious issue? -- To unsubscribe from this list: send the

Re: [PATCH 0/6] kexec: A new system call to allow in kernel loading

2013-11-22 Thread Greg KH
On Fri, Nov 22, 2013 at 09:19:46AM -0500, Vivek Goyal wrote: > On Fri, Nov 22, 2013 at 05:34:03AM -0800, Eric W. Biederman wrote: > > [..] > > > Why ELF case is so interesting. I have not use kexec to boot ELF > > > images in years and have not seen others using it too. In fact bzImage > > >

Re: [PATCH 4/4] kill task_struct->did_exec

2013-11-22 Thread KOSAKI Motohiro
(11/22/2013 12:54 PM), Oleg Nesterov wrote: > We can kill either task->did_exec or PF_FORKNOEXEC, they are > mutually exclusive. The patch kill ->did_exec because it has > a single user. It's ok. but, > - * Auch. Had to add the 'did_exec' flag to conform completely to POSIX. > - * LBT 04.03.94

Re: [PATCH V2 2/2] cpufreq: Change freq before suspending governors

2013-11-22 Thread Stephen Warren
On 11/22/2013 05:52 AM, Viresh Kumar wrote: > On 22 November 2013 18:07, Rafael J. Wysocki wrote: >> On Friday, November 22, 2013 04:59:49 PM Viresh Kumar wrote: >>> Some platforms might want to change frequency before suspending governors. >>> Like: >>> - Some platform which want to set freq to

[PATCH] time: Fix 1ns/tick drift w/ GENERIC_TIME_VSYSCALL_OLD

2013-11-22 Thread John Stultz
From: Martin Schwidefsky Since commit 1e75fa8be9f (time: Condense timekeeper.xtime into xtime_sec - merged in v3.6), there has been an problem with the error accounting in the timekeeping code, such that when truncating to nanoseconds, we round up to the next nsec, but the balancing adjustment

Re: 3.12 Regression: dcache: Translating dentry into pathname without taking rename_lock 232d2d60

2013-11-22 Thread Greg KH
On Thu, Nov 21, 2013 at 11:22:42PM +, Al Viro wrote: > On Thu, Nov 21, 2013 at 03:01:07PM -0800, Greg KH wrote: > > > Al, did this fix end up in Linus's tree yet? I'd like to pull it into > > the next 3.12-stable release, but will wait until Linus has it of > > course. > > Yes - ede4ce.

Re: [PATCH 3/8] perf symbol: Save vmlinux or kallsyms path loaded

2013-11-22 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 22, 2013 at 12:13:52PM -0700, David Ahern escreveu: > On 11/22/13, 11:44 AM, Arnaldo Carvalho de Melo wrote: > >Em Mon, Nov 18, 2013 at 01:32:46PM -0700, David Ahern escreveu: > >>Save vmlinux or kallsyms path loaded using embedded default lookup (ie., > >>not a user specified path).

Re: [PATCH] ARM: unwinder: Handle Stackoverflow in unwind_exec_insn

2013-11-22 Thread Dave Martin
On Sat, Nov 09, 2013 at 12:28:57PM +0530, Anurag Aggarwal wrote: > Thanks for your input Dave, > > I think there is another way to avoid the stack overflow and reduce > the number of checks also, > > Stack overflow will cause a problem only when we are backtracking the > last set of registers. >

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-22 Thread Feng Kan
>> set_handle_irq(gic_handle_irq); >> >> + gic->bypass_flag = (bypass_val & 0xf) << 4; >Beware, the top 2 bits are reserved on GICv1, and shouldn't be messed with. The only time those bits are touched are when the dts is modified with the bypass flag. Otherwise those bits remain

Re: [PATCH RFC 5/5] net: macb: Adjust tx_clk when link speed changes

2013-11-22 Thread Sören Brinkmann
Hi Nicolas, On Tue, Oct 15, 2013 at 09:54:21AM +0200, Nicolas Ferre wrote: > On 15/10/2013 01:59, Soren Brinkmann : > >Adjust the ethernet clock according to the negotiated link speed. > > > >Signed-off-by: Soren Brinkmann > > I will need more time to study this one. > > Moreover, I will have

[PATCH v3 RFC tip/core/locking 1/3] Documentation/memory-barriers.txt: Add needed ACCESS_ONCE() calls to memory-barriers.txt

2013-11-22 Thread Paul E. McKenney
From: "Paul E. McKenney" The Documentation/memory-barriers.txt file was written before the need for ACCESS_ONCE() was fully appreciated. It therefore contains no ACCESS_ONCE() calls, which can be a problem when people lift examples from it. This commit therefore adds ACCESS_ONCE() calls.

[PATCH v3 tip/core/locking 0/3] Memory-barrier documentation updates

2013-11-22 Thread Paul E. McKenney
Hello! This series applies some long-needed updates to memory-barriers.txt: 1. Add ACCESS_ONCE() calls where needed to ensure their inclusion in code copy-and-pasted from this file. 2. Add long atomic examples alongside the existing atomics. 3. Prohibit architectures

[PATCH v3 RFC tip/core/locking 2/3] Documentation/memory-barriers.txt: Add long atomic examples to memory-barriers.txt

2013-11-22 Thread Paul E. McKenney
From: "Paul E. McKenney" Although the atomic_long_t functions are quite useful, they are a bit obscure. This commit therefore adds the common ones alongside their atomic_t counterparts in Documentation/memory-barriers.txt. Signed-off-by: Paul E. McKenney Cc: David Howells ---

Re: [PATCH] net: sctp: set chunk->tsn_gap_acked at the end of cycle

2013-11-22 Thread Chang
On 11/22/2013 03:27 PM, Vlad Yasevich wrote: On 11/22/2013 02:49 AM, Chang Xiangzhong wrote: tsn_gap_acked is an important state flag in chunk, which indicates if the chunk has been acked in gap reports before. Actually, this bit indicates simply that the chunk has been acked. It doesn't

Re: linux-next: Tree for Nov 21 (nouveau)

2013-11-22 Thread Randy Dunlap
On 11/22/13 03:37, Adrian Pop wrote: > Hello! > >> on x86_64: >> >> CONFIG_HWMON is not enabled. >> >> drivers/gpu/drm/nouveau/nouveau_hwmon.c: In function 'nouveau_hwmon_init': >> drivers/gpu/drm/nouveau/nouveau_hwmon.c:633:2: error: 'hwmon' undeclared >> (first use in this function) > > I've

Re: [PATCH] clocksource: Do not drop unheld reference on device node

2013-11-22 Thread Uwe Kleine-König
On Fri, Nov 22, 2013 at 05:31:46PM +0100, Daniel Lezcano wrote: > On 11/22/2013 05:16 PM, Thierry Reding wrote: > >On Sat, Oct 19, 2013 at 12:49:48AM +0200, Thierry Reding wrote: > >>When booting a recent kernel on ARM with OF_DYNAMIC enabled, the kernel > >>warns about the following: > >> > >>

[PATCH 2/3] k_getrusage() can use while_each_thread()

2013-11-22 Thread Oleg Nesterov
Change k_getrusage() to use while_each_thread(), no changes in the compiled code. Signed-off-by: Oleg Nesterov --- kernel/sys.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/kernel/sys.c b/kernel/sys.c index 1d9a218..70d56d6 100644 --- a/kernel/sys.c +++

[PATCH 3/3] signals: change do_signal_stop/do_sigaction to use while_each_thread()

2013-11-22 Thread Oleg Nesterov
Change do_signal_stop() and do_sigaction() to avoid next_thread() and use while_each_thread() instead. Signed-off-by: Oleg Nesterov --- kernel/signal.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/kernel/signal.c b/kernel/signal.c index ded28b9..086071d 100644

[PATCH 0/3] more next_thread/while_each_thread changes

2013-11-22 Thread Oleg Nesterov
Trivial, change the remaining next_thread (ab)users to use while_each_thread(). The last user which should be changed is next_tid(), but we can't do this now. __exit_signal() and complete_signal() are fine, they actually need next_thread() logic. Oleg. fs/proc/array.c |3 +--

[PATCH 1/3] proc: change do_task_stat() to use while_each_thread()

2013-11-22 Thread Oleg Nesterov
do_task_stat() can use while_each_thread(), no changes in the compiled code. Signed-off-by: Oleg Nesterov --- fs/proc/array.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/proc/array.c b/fs/proc/array.c index c995807..c59e74f 100644 --- a/fs/proc/array.c +++

Re: [PATCH v3 07/15] KVM: MMU: introduce nulls desc

2013-11-22 Thread Marcelo Tosatti
On Wed, Oct 23, 2013 at 09:29:25PM +0800, Xiao Guangrong wrote: > It likes nulls list and we use the pte-list as the nulls which can help us to > detect whether the "desc" is moved to anther rmap then we can re-walk the rmap > if that happened > > kvm->slots_lock is held when we do lockless

Re: Clock drift with GENERIC_TIME_VSYSCALL_OLD

2013-11-22 Thread John Stultz
On 11/22/2013 07:38 AM, Martin Schwidefsky wrote: > Greetings, > > I just hunted down a time related bug which caused the Linux internal > xtime to drift away from the precise hardware clock provided by the > TOD clock found in the s390 architecture. > > After a long search I came along this

Re: [PATCH 3/8] perf symbol: Save vmlinux or kallsyms path loaded

2013-11-22 Thread David Ahern
On 11/22/13, 11:44 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Nov 18, 2013 at 01:32:46PM -0700, David Ahern escreveu: Save vmlinux or kallsyms path loaded using embedded default lookup (ie., not a user specified path). Upcoming perf sched timehist command requires kernel symbols for properly

Re: [PATCH v7 1/4] qrwlock: A queue read/write lock implementation

2013-11-22 Thread Linus Torvalds
On Fri, Nov 22, 2013 at 11:04 AM, Waiman Long wrote: > > In term of single-thread performance (no contention), a 256K > lock/unlock loop was run on a 2.4GHz and 2.93Ghz Westmere x86-64 > CPUs. The following table shows the average time (in ns) for a single > lock/unlock sequence (including the

[PATCH v7 3/4] qrwlock: Use the mcs_spinlock helper functions for MCS queuing

2013-11-22 Thread Waiman Long
There is a pending MCS lock patch series that adds generic MCS lock helper functions to do MCS-style locking. This patch will enable the queue rwlock to use that generic MCS lock/unlock primitives for internal queuing. This patch should only be merged after the merging of that generic MCS locking

[PATCH v7 1/4] qrwlock: A queue read/write lock implementation

2013-11-22 Thread Waiman Long
This patch introduces a new read/write lock implementation that put waiting readers and writers into a queue instead of actively contending the lock like the current read/write lock implementation. This will improve performance in highly contended situation by reducing the cache line bouncing

[PATCH v7 2/4] qrwlock x86: Enable x86 to use queue read/write lock

2013-11-22 Thread Waiman Long
This patch makes the necessary changes at the x86 architecture specific layer to enable the presence of the CONFIG_QUEUE_RWLOCK kernel option to replace the read/write lock by the queue read/write lock. It also enables the CONFIG_QUEUE_RWLOCK option by default for x86 which will force the use of

[PATCH v7 4/4] qrwlock: Use smp_store_release() in write_unlock()

2013-11-22 Thread Waiman Long
This patch modifies the queue_write_unlock() function to use the new smp_store_release() function in another pending patch. This patch should only be merged if the other patch was merged. Signed-off-by: Waiman Long --- include/asm-generic/qrwlock.h |4 +--- 1 files changed, 1 insertions(+),

[PATCH v7 0/4] qrwlock: Introducing a queue read/write lock implementation

2013-11-22 Thread Waiman Long
v6->v7: - Remove support for unfair lock, so only fair qrwlock will be provided. - Move qrwlock.c to the kernel/locking directory. v5->v6: - Modify queue_read_can_lock() to avoid false positive result. - Move the two slowpath functions' performance tuning change from patch 4 to patch 1. -

Re: [PATCH] PM / Clocks: fix pm_clk_resume/suspend if CONFIG_PM_RUNTIME is set

2013-11-22 Thread Santosh Shilimkar
On Friday 22 November 2013 01:43 PM, Kevin Hilman wrote: > Santosh Shilimkar writes: > > [...] > It looks like even if you just remove the locks here, the PM core is free to call this function with irqs disabled if pm_runtime_irq_safe() has been called on the device. Perhaps

Re: [PATCH 4/6] kexec: A new system call, kexec_file_load, for in kernel kexec

2013-11-22 Thread Vivek Goyal
On Thu, Nov 21, 2013 at 07:19:07PM +, Matthew Garrett wrote: > On Thu, Nov 21, 2013 at 02:13:05PM -0500, Vivek Goyal wrote: > > On Thu, Nov 21, 2013 at 07:06:20PM +, Matthew Garrett wrote: > > > That would require a certain degree of massaging from userspace if we > > > want to be able to

Re: [PATCH v2 RFC 1/3] documentation: Add needed ACCESS_ONCE() calls to memory-barriers.txt

2013-11-22 Thread Paul E. McKenney
On Fri, Nov 22, 2013 at 12:17:23PM +0100, Peter Zijlstra wrote: > On Thu, Nov 21, 2013 at 02:32:30PM -0800, Paul E. McKenney wrote: > > > > > We could, but at the moment I would prefer the decrease in readability > > > > to the copy-and-paste bugs that omit needed ACCESS_ONCE() calls. > > > > >

Re: [PATCH RFC v2 12/29] PCI/MSI: Introduce pcim_enable_msi*() family helpers

2013-11-22 Thread Alexander Gordeev
On Fri, Nov 22, 2013 at 01:44:47PM -0500, Tejun Heo wrote: > +int pcim_enable_msi_range(struct pci_dev *dev, struct msix_entry *entries, > + unsigned int nvec, unsigned int minvec) > + > +This variation on pci_enable_msi_block() call allows a device driver to > +request any

[PATCH] tracing: Allow instances to have independent trace flags/trace options.

2013-11-22 Thread Bharath Ravi
Currently, the trace options are global, and shared among all instances. This change divides the set of trace options into global options and instance specific options. Instance specific options may be set independently by an instance without affecting either the global tracer or other instances.

Re: [PATCH 2/2] memory: ti-aemif: add bindings for AEMIF driver

2013-11-22 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:03 Wed 20 Nov , ivan.khoronzhuk wrote: > On 11/20/2013 08:21 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > >> + the chip select signal. > >> + Minimum value is 1 (0 treated as 1). > >> + > >> +- ti,cs-wsetup: write setup width,

Re: [PATCH RFC v2 12/29] PCI/MSI: Introduce pcim_enable_msi*() family helpers

2013-11-22 Thread Tejun Heo
On Fri, Nov 22, 2013 at 07:44:30PM +0100, Alexander Gordeev wrote: > On Wed, Nov 20, 2013 at 12:15:26PM -0500, Tejun Heo wrote: > > The use of @nvec and @maxvec is a bit inconsistent. Maybe it'd be > > better to make them uniform? > > With @maxvec I tried to stress an implication there could be

Re: [PATCH 3/8] perf symbol: Save vmlinux or kallsyms path loaded

2013-11-22 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 18, 2013 at 01:32:46PM -0700, David Ahern escreveu: > Save vmlinux or kallsyms path loaded using embedded default lookup (ie., > not a user specified path). Upcoming perf sched timehist command requires > kernel symbols for properly computing idle times and prints a warning > if the

Re: [PATCH] PM / Clocks: fix pm_clk_resume/suspend if CONFIG_PM_RUNTIME is set

2013-11-22 Thread Kevin Hilman
Santosh Shilimkar writes: [...] >>> It looks like even if you just remove the locks here, the PM core is >>> free to call this function with irqs disabled if pm_runtime_irq_safe() >>> has been called on the device. Perhaps runtime PM can only do the >>> clk_enable()/clk_disable() part and the

<    1   2   3   4   5   6   7   8   9   10   >