[PATCH] rbtree: fix typo in comment of __rb_insert()

2014-07-22 Thread Wei Yang
In case 1, it passes down the BLACK color from G to p and u, and maintains the color of n. By doing so, it maintains the black height of the sub-tree. While in the comment, it marks the color of n to BLACK. This is a typo and not consistents with the code. This patch fixs this typo in comment.

Re: [PATCH 0/3] clk : Fix SOCFPGA clk crash and some clean up

2014-07-22 Thread Steffen Trumtrar
Hi! As you touch clk.c, you should Cc Mike Turquette mturque...@linaro.org He is the maintainer for that code. Regards, Steffen -- Pengutronix e.K. | Steffen Trumtrar| Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner

intel-gtt.c:fix me

2014-07-22 Thread Nick Krause
#if IS_ENABLED(CONFIG_AGP_INTEL) 652 global_cache_flush(); /* FIXME: ? */ 653 #endif I am wondering what to do about this fix me? Cheers Nick -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] drm/i915: fix freeze with blank screen booting highmem

2014-07-22 Thread Daniel Vetter
On Mon, Jul 21, 2014 at 09:34:30PM -0700, Hugh Dickins wrote: x86_64 boots and displays fine, but booting x86_32 with CONFIG_HIGHMEM has frozen with a blank screen throughout 3.16-rc on this ThinkPad T420s, with i915 generation 6 graphics. Fix 9d0a6fa6c5e6 (drm/i915: add render state

Re: [RESEND PATCH] thermal: samsung: Add TMU support for Exynos3250 SoC

2014-07-22 Thread amit daniel kachhap
On Mon, Jul 21, 2014 at 11:34 AM, Zhang Rui rui.zh...@intel.com wrote: On Fri, 2014-07-18 at 09:00 +0900, Chanwoo Choi wrote: This patch adds the registers, bit fields and compatible strings required to support for the 1 TMU channels on Exynos3250. Signed-off-by: Chanwoo Choi

Re: Random panic in load_balance() with 3.16-rc

2014-07-22 Thread Michel Dänzer
On 18.07.2014 18:29, Michel Dänzer wrote: On 17.07.2014 16:58, Peter Zijlstra wrote: On Thu, Jul 17, 2014 at 04:31:04PM +0900, Michel Dänzer wrote: I've been running into the panic captured in the attached picture (hope it's legible) randomly while running 3.16-rc4 and -rc5. I haven't

Re: [PATCH] powerpc: Revert removing of _INIT_GLOBAL(), _STATIC() and _INIT_STATIC()

2014-07-22 Thread Benjamin Herrenschmidt
On Mon, 2014-07-21 at 14:56 -0400, Steven Rostedt wrote: Weird ... what are your gcc and binutils versions ? Smells like a toolchain issue to me but I need to dig a bit more. Doesn't hit any of my test configs here. Can you test the attached config with this toolchain and see if you

drbd_worker.c: Remove lines

2014-07-22 Thread Nick Krause
There seems to be two fix mes in function in wait_for_work. I was wondering can we remove these spinlocks? Cheers Nick -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH] sched: update last_balance only when actually balanced

2014-07-22 Thread Rik van Riel
Currently rebalance_domains will happily update sd-last_balance even if should_we_balance() decides that this CPU should not do any load balancing for the sd. This can prevent the CPU that should load balance for the sd from doing load balancing, which can delay active balancing essentially

Re: [PATCH 1/7] arm: dts: omap3-gta04: Add nand support

2014-07-22 Thread Tony Lindgren
* Marek Belisko ma...@goldelico.com [140721 14:08]: Can you please add the descriptions to all the patches? Other than that looks OK to me. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH] s390: Fix me in dasd_eer.c

2014-07-22 Thread Nicholas Krause
This patch changes return type to EMEDUIMTYPE in function, dasd_eer_enable for when checking if the medium has no errors according to this function. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/s390/block/dasd_eer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2] drm/panel: add support for InnoLux N156BGE-L21 panel

2014-07-22 Thread Alban Bedel
This panel is used by the Medcom Wide and supported by the simple-panel driver. Signed-off-by: Alban Bedel alban.be...@avionic-design.de --- v2: * Added the v/hsync pulses for correctness (the panel doesn't really needs them) * Fixed the size to report the physical size in mm ---

Re: [PATCH v2] gpiolib: Export gpiochip_request_own_desc and gpiochip_free_own_desc

2014-07-22 Thread Mika Westerberg
On Mon, Jul 21, 2014 at 10:18:25PM -0700, Guenter Roeck wrote: Both functions were introduced to let gpio drivers request their own gpio pins. Without exporting the functions, this can however only be used by gpio drivers built into the kernel. The reason why these are private to drivers is

Re: [PATCH v2] gpiolib: Export gpiochip_request_own_desc and gpiochip_free_own_desc

2014-07-22 Thread Alexandre Courbot
On Tue, Jul 22, 2014 at 3:43 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Mon, Jul 21, 2014 at 10:18:25PM -0700, Guenter Roeck wrote: Both functions were introduced to let gpio drivers request their own gpio pins. Without exporting the functions, this can however only be used

linux-next: no release today

2014-07-22 Thread Stephen Rothwell
Hi all, Hopefully normal service will resume tomorrow. -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature

Re: Global signal cleanup, take 4

2014-07-22 Thread Richard Weinberger
Stephen, Am 22.07.2014 06:47, schrieb Stephen Rothwell: Hi Richard, On Mon, 21 Jul 2014 16:02:46 +0200 Richard Weinberger rich...@sigma-star.at wrote: The whole series can also be found at: git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc.git signal_v4 Andrew, can you please

Re: [PATCH v2] gpiolib: Export gpiochip_request_own_desc and gpiochip_free_own_desc

2014-07-22 Thread Guenter Roeck
On 07/21/2014 11:43 PM, Mika Westerberg wrote: On Mon, Jul 21, 2014 at 10:18:25PM -0700, Guenter Roeck wrote: Both functions were introduced to let gpio drivers request their own gpio pins. Without exporting the functions, this can however only be used by gpio drivers built into the kernel.

Re: [PATCH v2 2/2] firmware_class: perform new LSM checks

2014-07-22 Thread Takashi Iwai
At Mon, 21 Jul 2014 12:06:41 -0700, Kees Cook wrote: This attaches LSM hooks to the existing firmware loading interfaces: filesystem-found firmware and demand-loaded blobs. Signed-off-by: Kees Cook keesc...@chromium.org Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org ---

Re: [RFC] perf to ctf converter

2014-07-22 Thread Sebastian Andrzej Siewior
On 07/21/2014 08:35 PM, Jiri Olsa wrote: On Mon, Jul 21, 2014 at 07:11:51PM +0200, Sebastian Andrzej Siewior wrote: heya, I've got following build error: CC util/data-bt.o util/data-bt.c: In function ‘add_event_tracepoint_value’: util/data-bt.c:293:3: error: implicit declaration

Re: [PATCH] x86_32, entry: store badsys error code in %eax

2014-07-22 Thread Sven Wegener
On Mon, 21 Jul 2014, Andy Lutomirski wrote: On Sun, Jul 20, 2014 at 2:33 PM, Sven Wegener sven.wege...@stealer.net wrote: Commit 554086d (x86_32, entry: Do syscall exit work on badsys (CVE-2014-4508)) introduced a subtle regression in the x86_32 syscall entry code, resulting in syscall()

RE: [PATCH 2/6] ARM: imx: clk-vf610: add USBPHY clocks

2014-07-22 Thread Jingchang Lu
-Original Message- From: Shawn Guo [mailto:shawn@freescale.com] Sent: Tuesday, July 22, 2014 10:32 AM To: Stefan Agner; Lu Jingchang-B35083 Cc: Chen Peter-B29397; s.ha...@pengutronix.de; linux-arm- ker...@lists.infradead.org; linux-...@vger.kernel.org; linux- ker...@vger.kernel.org

[PATCH] Staging: gdm724x: gdm_lte.c: Fix warning of prefer ether_addr_copy()

2014-07-22 Thread Kiran Padwal
This patch fixes the following checkpatch.pl warnings: WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2). Signed-off-by: Kiran Padwal kiran.padwa...@gmail.com --- drivers/staging/gdm724x/gdm_lte.c | 10 +- 1 file changed, 5 insertions(+), 5

Re: [PATCH v2] gpiolib: Export gpiochip_request_own_desc and gpiochip_free_own_desc

2014-07-22 Thread Mika Westerberg
On Mon, Jul 21, 2014 at 11:53:27PM -0700, Guenter Roeck wrote: On 07/21/2014 11:43 PM, Mika Westerberg wrote: On Mon, Jul 21, 2014 at 10:18:25PM -0700, Guenter Roeck wrote: Both functions were introduced to let gpio drivers request their own gpio pins. Without exporting the functions, this can

Re: [PATCH] gpio: Add support for GPIOF_ACTIVE_LOW to gpio_request_one

2014-07-22 Thread Alexandre Courbot
On Tue, Jul 22, 2014 at 2:16 PM, Guenter Roeck li...@roeck-us.net wrote: On 07/21/2014 09:30 PM, Alexandre Courbot wrote: On Thu, Jul 17, 2014 at 11:34 PM, Guenter Roeck li...@roeck-us.net wrote: On 07/17/2014 12:26 AM, Alexandre Courbot wrote: On Thu, Jul 17, 2014 at 3:37 PM, Guenter

Re: [PATCH] powerpc: Revert removing of _INIT_GLOBAL(), _STATIC() and _INIT_STATIC()

2014-07-22 Thread Michael Ellerman
On Tue, 2014-07-22 at 16:13 +1000, Benjamin Herrenschmidt wrote: On Mon, 2014-07-21 at 14:56 -0400, Steven Rostedt wrote: Weird ... what are your gcc and binutils versions ? Smells like a toolchain issue to me but I need to dig a bit more. Doesn't hit any of my test configs here.

Re: [PATCH] checkpatch: Fix false positive MISSING_BREAK warnings with --file

2014-07-22 Thread Lee Jones
On Mon, 21 Jul 2014, Joe Perches wrote: Using --file mode can give false positives with MISSING_BREAK fall-through warnings on simple but long multiple consecutive case statements. Look for all lines before a case statement for a switch or a statement when using --file mode. Fix a

[PATCH] Staging: gdm724x: gdm_usb.c: fix missing blank line after variable declaration

2014-07-22 Thread Kiran Padwal
Checkpatch fix - Add missing blank line after variable declaration Signed-off-by: Kiran Padwal kiran.padwa...@gmail.com --- drivers/staging/gdm724x/gdm_usb.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c index

[PATCH] sched: fix llc shared map unreleased during cpu hotplug

2014-07-22 Thread Wanpeng Li
[ 220.262093] BUG: unable to handle kernel NULL pointer dereference at 0004 [ 220.262104] IP: [810e7ac9] find_busiest_group+0x2b9/0xa30 [ 220.262111] PGD 5a9d5067 PUD 13067 PMD 0 [ 220.262117] Oops: [#3] SMP [...] [ 220.262245] Call Trace: [ 220.262252]

[PATCH] mmc: core: Remove fixed voltage regulator logic

2014-07-22 Thread Tim Kryger
There is no need for regulator consumers to include special logic for fixed voltage regulators as they support regulator_set_voltage() just like their non-fixed regulator counterparts. Signed-off-by: Tim Kryger tim.kry...@gmail.com --- Since this eliminates logic that was concealing a bug in how

[PATCH 2/5] gpio: simplify gpiochip_export()

2014-07-22 Thread Alexandre Courbot
For some reason gpiochip_export() would invalidate all the descriptors of a chip if exporting it to sysfs failed. This does not appear as necessary. Remove that part of the code. While we are at it, add a note about the non-safety of temporarily releasing a spinlock in the middle of the loop that

[PATCH 3/5] gpio: make gpiochip_get_desc() gpiolib-private

2014-07-22 Thread Alexandre Courbot
As GPIO descriptors are not going to remain unique anymore, having this function public is not safe. Restrain its use to gpiolib since we have no user outside of it. Signed-off-by: Alexandre Courbot acour...@nvidia.com --- drivers/gpio/gpiolib-of.c | 2 +- drivers/gpio/gpiolib.c | 1 -

[PATCH 4/5] gpio: remove gpiod_lock/unlock_as_irq()

2014-07-22 Thread Alexandre Courbot
gpio_lock/unlock_as_irq() are working with (chip, offset) arguments and are thus not using the old integer namespace. Therefore, there is no reason to have gpiod variants of these functions working with descriptors, especially since the (chip, offset) tuple is more suitable to the users of these

[PATCH 5/5] gpio: move gpio_ensure_requested() into legacy C file

2014-07-22 Thread Alexandre Courbot
gpio_ensure_requested() only makes sense when using the integer-based GPIO API, so make sure it is called from there instead of the gpiod API which we know cannot be called with a non-requested GPIO anyway. The uses of gpio_ensure_requested() in the gpiod API were kind of out-of-place anyway, so

[PATCH 0/5] gpio: a few cleanup patches

2014-07-22 Thread Alexandre Courbot
Still in order to prepare for the ability to share one GPIO between several consumers, this series of mostly unrelated patches fixes a few minor issues. Most of the patches should be no-brainers ; maybe patch 2 should be looked more closely in order to understand why this code was there in the

[PATCH 1/5] gpio: remove export of private of_get_named_gpio_flags()

2014-07-22 Thread Alexandre Courbot
of_get_named_gpio_flags() has been made gpiolib-private by commit f01d907582, but its EXPORT statement has not been removed. Fix this. Signed-off-by: Alexandre Courbot acour...@nvidia.com --- drivers/gpio/gpiolib-of.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpio/gpiolib-of.c

Re: [PATCH] Staging: gdm724x: gdm_lte.c: Fix warning of prefer ether_addr_copy()

2014-07-22 Thread Greg KH
On Tue, Jul 22, 2014 at 12:26:42PM +0530, Kiran Padwal wrote: This patch fixes the following checkpatch.pl warnings: WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2). Is that true here? Have you tested this on the hardware to ensure it works

Re: [PATCH v3 0/5] phy: miphy365x: Introduce support for MiPHY365x

2014-07-22 Thread Kishon Vijay Abraham I
Hi, On Monday 21 July 2014 01:09 PM, Lee Jones wrote: Hi Kishon, This patchset is based on the two core patches you sent to the list which facilitate creating PHYs residing on multi-channel controllers. The changes since the last submission centre around dynamic PHY creation based solely

Re: [PATCH v2 00/25] AMDKFD kernel driver

2014-07-22 Thread Daniel Vetter
On Mon, Jul 21, 2014 at 10:23:43PM +0300, Oded Gabbay wrote: But Jerome, the core problem still remains in effect, even with your suggestion. If an application, either via userspace queue or via ioctl, submits a long-running kernel, than the CPU in general can't stop the GPU from running it.

Re: [STLinux Kernel] [PATCH v3 0/5] phy: miphy365x: Introduce support for MiPHY365x

2014-07-22 Thread Maxime Coquelin
On 07/22/2014 09:23 AM, Kishon Vijay Abraham I wrote: Hi, On Monday 21 July 2014 01:09 PM, Lee Jones wrote: Hi Kishon, This patchset is based on the two core patches you sent to the list which facilitate creating PHYs residing on multi-channel controllers. The changes since the last

Re: [PATCH v2 00/25] AMDKFD kernel driver

2014-07-22 Thread Daniel Vetter
On Mon, Jul 21, 2014 at 03:03:07PM -0400, Jerome Glisse wrote: On Mon, Jul 21, 2014 at 09:41:29PM +0300, Oded Gabbay wrote: On 21/07/14 21:22, Daniel Vetter wrote: On Mon, Jul 21, 2014 at 7:28 PM, Oded Gabbay oded.gab...@amd.com wrote: I'm not sure whether we can do the same trick with

Re: [PATCH v8 02/11] power: reset: Add reboot driver for brcmstb

2014-07-22 Thread Arnd Bergmann
On Monday 21 July 2014 14:07:57 Brian Norris wrote: diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig index 0073633e7699..9782e8d80647 100644 --- a/arch/arm/mach-bcm/Kconfig +++ b/arch/arm/mach-bcm/Kconfig @@ -94,6 +94,7 @@ config ARCH_BRCMSTB select MIGHT_HAVE_PCI

Re: [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area

2014-07-22 Thread Peter Zijlstra
On Tue, Jul 22, 2014 at 02:18:47PM +0900, Gioh Kim wrote: Hello, This patch try to solve problem that a long-lasting page cache of ext4 superblock disturbs page migration. I've been testing CMA feature on my ARM-based platform and found some pages for page caches cannot be migrated. Some

Re: [RFC PATCH 0/5] futex: introduce an optimistic spinning futex

2014-07-22 Thread Peter Zijlstra
On Mon, Jul 21, 2014 at 05:32:55PM -0700, Davidlohr Bueso wrote: On Mon, 2014-07-21 at 14:31 -0700, Andy Lutomirski wrote: On Mon, Jul 21, 2014 at 2:27 PM, Peter Zijlstra pet...@infradead.org wrote: All this is predicated on the fact that syscalls are 'expensive'. Weren't syscalls only

Re: [PATCH v8 00/11] ARM: brcmstb: Add Broadcom STB SoC support

2014-07-22 Thread Arnd Bergmann
On Monday 21 July 2014 14:07:55 Brian Norris wrote: I'm taking over the latest resubmission of this patch series. There are a few moderate changes for v8 (noted below), but we are waiting mostly for an Ack for the reboot driver. This patchset contains the board support package for the

Re: [PATCH v2 00/25] AMDKFD kernel driver

2014-07-22 Thread Daniel Vetter
On Tue, Jul 22, 2014 at 09:28:51AM +0200, Daniel Vetter wrote: On Mon, Jul 21, 2014 at 03:03:07PM -0400, Jerome Glisse wrote: On Mon, Jul 21, 2014 at 09:41:29PM +0300, Oded Gabbay wrote: On 21/07/14 21:22, Daniel Vetter wrote: On Mon, Jul 21, 2014 at 7:28 PM, Oded Gabbay

[RESEND PATCH v3 1/6] charger: max14577: Add support for MAX77836 charger

2014-07-22 Thread Krzysztof Kozlowski
Add support for MAX77836 charger to the max14577 driver. The MAX77836 charger is almost the same as 14577 model except: - No dead-battery detection; - Support for special charger (like in MAX77693); - Support for DX over-voltage protection (like in MAX77693); - Lower values of charging current

[RESEND PATCH v3 4/6] power: max17040: Add ID for MAX77836 Fuel Gauge block

2014-07-22 Thread Krzysztof Kozlowski
MAX77836 has the same Fuel Gauge as MAX17040/17048. The max17040 driver can be safely re-used. The patch adds MAX77836 ID to array of i2c_device_id. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Anton Vorontsov an...@enomsg.org Cc:

[RESEND PATCH v3 3/6] charger: max14577: Configure battery-dependent settings from DTS and sysfs

2014-07-22 Thread Krzysztof Kozlowski
Remove hard-coded values for: - Fast Charge current, - End Of Charge current, - Fast Charge timer, - Overvoltage Protection Threshold, - Battery Constant Voltage, and use DTS or sysfs to configure them. This allows using the max14577 charger driver with different batteries. Now the charger

[RESEND PATCH v3 2/6] regulator/mfd: max14577: Export symbols for calculating charger current

2014-07-22 Thread Krzysztof Kozlowski
This patch prepares for changing the max14577 charger driver to allow configuring battery-dependent settings from DTS. The patch moves from regulator driver to MFD core driver and exports: - function for calculating register value for charger's current; - table of limits for chargers (MAX14577,

[RESEND PATCH v3 6/6] Documentation: charger: max14577: Document exported sysfs entry

2014-07-22 Thread Krzysztof Kozlowski
Document the 'fast charge timer' setting exported by max14577 driver through sysfs entry. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Documentation/ABI/testing/sysfs-class-power | 14 ++ 1 file changed, 14 insertions(+) diff --git

[RESEND PATCH v3 5/6] devicetree: mfd: max14577: Add device tree bindings document

2014-07-22 Thread Krzysztof Kozlowski
Add document describing device tree bindings for MAX14577 MFD drivers: MFD core, extcon, regulator and charger. Both MAX14577 and MAX77836 chipsets are documented. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Tomasz Figa

[PATCH RESEND] spin_lock_*(): Always evaluate second argument

2014-07-22 Thread Bart Van Assche
Evaluating a macro argument only if certain configuration options have been selected is confusing and error-prone. Hence always evaluate the second argument of spin_lock_nested() and spin_lock_nest_lock(). An intentional side effect of this patch is that it avoids that the following warning is

[RESEND PATCH v3 0/6] charger/mfd: max14577: Add support for MAX77836

2014-07-22 Thread Krzysztof Kozlowski
Hi, This is a resend of third version of patches adding support for MAX77836 device to the max14577 drivers. This patchset was already reviewed by some of the maintainers during previous submissions. I only need acks from power tree (patches: 1, 3, 4, 6). The patches 1, 2 and 3 depend on each

Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality

2014-07-22 Thread Dan Carpenter
On Mon, Jul 21, 2014 at 11:01:56PM +0300, Julian Anastasov wrote: @@ -2333,13 +2339,12 @@ do_ip_vs_set_ctl(struct sock *sk, int cmd, void __user *user, unsigned int len) struct ip_vs_dest_user_kern udest; struct netns_ipvs *ipvs = net_ipvs(net); + BUILD_BUG_ON(sizeof(arg)

Re: [RFC PATCH 0/5] futex: introduce an optimistic spinning futex

2014-07-22 Thread Peter Zijlstra
On Mon, Jul 21, 2014 at 09:34:57PM -0400, Steven Rostedt wrote: I just want to point out that I was having a very nice conversation with Robert Haas (Cc'd) in Napa Valley at Linux Collaboration about this very topic. Robert is a PostgeSQL developer who told me that they implement their spin

Re: [PATCH 4/5] kernel/debug/kdb/kdb_bp.c: drop negativity check on unsigned value

2014-07-22 Thread Dan Carpenter
On Fri, Jul 18, 2014 at 06:34:52PM +0300, Andrey Utkin wrote: static char *kdb_bptype(kdb_bp_t *bp) { - if (bp-bp_type 0 || bp-bp_type 4) + if (bp-bp_type 4) return ; With Smatch, I ignore negative checks in this format. It's obvious what the intent is and they

Re: [PATCH 9/9] usb: musb: musb_am335x: reinstate module loading/unloading support

2014-07-22 Thread Lothar Waßmann
Hi, Felipe Balbi wrote: On Fri, Jul 18, 2014 at 11:31:30AM +0200, Lothar Waßmann wrote: There is no need to throw the baby out with the bath due to a bad failure analysis. The commit: 7adb5c876e9c usb: musb: Fix panic upon musb_am335x module removal came to a wrong conclusion about the

Re: [PATCH] sched: fix llc shared map unreleased during cpu hotplug

2014-07-22 Thread Peter Zijlstra
On Tue, Jul 22, 2014 at 03:16:31PM +0800, Wanpeng Li wrote: [ 220.262093] BUG: unable to handle kernel NULL pointer dereference at 0004 [ 220.262104] IP: [810e7ac9] find_busiest_group+0x2b9/0xa30 [ 220.262111] PGD 5a9d5067 PUD 13067 PMD 0 [ 220.262117] Oops: [#3]

Re: [PATCH 1/2] perf tools: Fix incorrect fd error comparison

2014-07-22 Thread Jiri Olsa
On Thu, Jul 17, 2014 at 11:43:09AM +0300, Adrian Hunter wrote: Zero is a valid fd. Error comparison should check for negative fd. Signed-off-by: Adrian Hunter adrian.hun...@intel.com Acked-by: Jiri Olsa jo...@kernel.org thanks, jirka -- To unsubscribe from this list: send the line

Re: [PATCH] kernel/debug/kdb/kdb_bp.c: fix argument range check

2014-07-22 Thread Dan Carpenter
On Fri, Jul 18, 2014 at 08:40:24PM +0300, Andrey Utkin wrote: Dropped negativity check; enhanced upper limit check as proposed by Walter Harms wha...@bfs.de Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80591 Reported-by: David Binderman dcb...@hotmail.com Signed-off-by: Andrey

Re: [PATCH V3] perf tools: Record whether a dso has data

2014-07-22 Thread Jiri Olsa
On Thu, Jul 17, 2014 at 11:58:30AM +0300, Adrian Hunter wrote: Add 'data_status' to record whether a dso has data (i.e. an object file) I might have seen it in your last patsent, but forgot.. what is this data_status going to be used for? SNIP diff --git a/tools/perf/util/dso.h

Re: [PATCH] x86, TSC: Add a software TSC offset

2014-07-22 Thread Peter Zijlstra
On Mon, Jul 21, 2014 at 02:56:49PM -0700, Andy Lutomirski wrote: Remember, this is only attempting to be a hardware workaround for a smallish number of systems out there. Most of current machines should have stable and synched TSCs. I actually own one of these systems. It's a Sandy

Re: [PATCH 1/4] mfd: imanager2: Add defines support for IT8516/18/28

2014-07-22 Thread Lee Jones
This patch needs a commit log. In fact, it can be squashed into the first commit which uses these defines. Signed-off-by: Wei-Chun Pan weichun@advantech.com.tw --- include/linux/mfd/imanager2_ec.h | 358 +++ 1 file changed, 358 insertions(+)

Re: [PATCH] x86, TSC: Add a software TSC offset

2014-07-22 Thread Peter Zijlstra
On Mon, Jul 21, 2014 at 03:13:33PM -0700, Andy Lutomirski wrote: I actually own one of these systems. It's a Sandy Bridge Core-i7 Extreme or something like that. Ha, cool, so I've got my tester! :-) Ha. Ha ha. Muahaha. Because IIRC this box is synced until the first time it

[PATCH v2] x86, hotplug: fix llc shared map unreleased during cpu hotplug

2014-07-22 Thread Wanpeng Li
[ 220.262093] BUG: unable to handle kernel NULL pointer dereference at 0004 [ 220.262104] IP: [810e7ac9] find_busiest_group+0x2b9/0xa30 [ 220.262111] PGD 5a9d5067 PUD 13067 PMD 0 [ 220.262117] Oops: [#3] SMP [...] [ 220.262245] Call Trace: [ 220.262252]

Re: [PATCH v2 00/25] AMDKFD kernel driver

2014-07-22 Thread Oded Gabbay
On 22/07/14 02:05, Jerome Glisse wrote: On Tue, Jul 22, 2014 at 12:56:13AM +0300, Oded Gabbay wrote: On 21/07/14 22:28, Jerome Glisse wrote: On Mon, Jul 21, 2014 at 10:23:43PM +0300, Oded Gabbay wrote: On 21/07/14 21:59, Jerome Glisse wrote: On Mon, Jul 21, 2014 at 09:36:44PM +0300, Oded

Re: [PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown()

2014-07-22 Thread Lothar Waßmann
Hi, Felipe Balbi wrote: Hi,, On Mon, Jul 21, 2014 at 10:03:07AM +0200, Lothar Waßmann wrote: Hi, On Fri, Jul 18, 2014 at 11:31:29AM +0200, Lothar Waßmann wrote: This patch makes it possible to use the musb driver with HW that requires external regulators or clocks. can

Re: [PATCH 0/2] shmem: fix faulting into a hole while it's punched, take 3

2014-07-22 Thread Hugh Dickins
On Mon, 21 Jul 2014, Sasha Levin wrote: On 07/19/2014 07:44 PM, Hugh Dickins wrote: Otherwise, I've been unable to reproduce the shmem_fallocate hang. Great. Andrew, I think we can say that it's now safe to send 1/2 shmem: fix faulting into a hole, not taking i_mutex 2/2 shmem: fix

Re: [PATCH 2/7] KVM: x86: Function for determining exception type

2014-07-22 Thread Paolo Bonzini
Il 21/07/2014 23:30, Nadav Amit ha scritto: Few comments to see we are on the same page: On 7/21/14, 3:18 PM, Paolo Bonzini wrote: Il 21/07/2014 13:37, Nadav Amit ha scritto: +int kvm_exception_type(unsigned int nr) The manual calls this the exception class. Yes, but it also calls it

Re: ZAC target (Was: Re: dm-multipath: Accept failed paths for multipath maps)

2014-07-22 Thread Matias Bjorling
On 07/22/2014 07:46 AM, Hannes Reinecke wrote: On 07/21/2014 09:28 PM, Kent Overstreet wrote: On Mon, Jul 21, 2014 at 04:23:41PM +0200, Hannes Reinecke wrote: On 07/18/2014 07:04 PM, John Utz wrote: On 07/18/2014 05:31 AM, John Utz wrote: Thankyou very much for the exhaustive answer! I

[PATCH v3 3/9] perf, x86: use the PEBS auto reload mechanism when possible

2014-07-22 Thread Yan, Zheng
When a fixed period is specified, this patch make perf use the PEBS auto reload mechanism. This makes normal profiling faster, because it avoids one costly MSR write in the PMI handler. Signef-off-by: Yan, Zheng zheng.z@intel.com --- arch/x86/kernel/cpu/perf_event.c | 15

[PATCH v2] ipv4: Make IP_MULTICAST_ALL and IP_MSFILTER work on raw sockets

2014-07-22 Thread Quentin Armitage
Currently, although IP_MULTICAST_ALL and IP_MSFILTER ioctl calls succeed on raw sockets, there is no code to implement the functionality on received packets; it is only implemented for UDP sockets. The raw(7) man page states: In addition, all ip(7) IPPROTO_IP socket options valid for datagram

Re: drbd_worker.c: Remove lines

2014-07-22 Thread Mike Galbraith
On Tue, 2014-07-22 at 02:17 -0400, Nick Krause wrote: There seems to be two fix mes in function in wait_for_work. I was wondering can we remove these spinlocks? Rather than ask someone else this question, take a look to see what the lock protects and from whom. If protected thingy cannot

Re: RE: [PATCH] lib : lz4 using put_unaligned_le16 instead of put_unaligned

2014-07-22 Thread Eunbong Song
Hello. Can you check if this patch fix your problem also? Unfortunately your patch does not fix my problem. My test logs are as follow. I did the same test with lzo compression algorithm and with my patch, and these work well. debug_shell:/user echo 1 /sys/block/zram0/reset debug_shell:/user

[PATCH v3 8/9] perf, x86: enlarge PEBS buffer

2014-07-22 Thread Yan, Zheng
Currently the PEBS buffer size is 4k, it only can hold about 21 PEBS records. This patch enlarges the PEBS buffer size to 64k (the same as BTS buffer), 64k memory can hold about 330 PEBS records. This will significantly the reduce number of PMI when large PEBS interrupt threshold is used.

Re: [PATCH v2 00/25] AMDKFD kernel driver

2014-07-22 Thread Oded Gabbay
On 22/07/14 10:23, Daniel Vetter wrote: On Mon, Jul 21, 2014 at 10:23:43PM +0300, Oded Gabbay wrote: But Jerome, the core problem still remains in effect, even with your suggestion. If an application, either via userspace queue or via ioctl, submits a long-running kernel, than the CPU in

[PATCH v3 6/9] perf, x86: handle multiple records in PEBS buffer

2014-07-22 Thread Yan, Zheng
When PEBS interrupt threshold is larger than one, the PEBS buffer may include mutiple records for each PEBS event. This patch makes the code first count how many records each PEBS event has, then output the samples in batch. One corner case needs to mention is that the PEBS hardware doesn't deal

[PATCH v3 9/9] tools, perf: Allow the user to disable time stamps

2014-07-22 Thread Yan, Zheng
From: Andi Kleen a...@linux.intel.com Time stamps are always implicitely enabled for record currently. The old --time/-T option is a nop. Allow the user to disable timestamps by using --no-time This can cause some minor misaccounting (by missing mmaps), but significantly lowers the size of

[PATCH v3 2/9] perf, x86: use context switch callback to flush LBR stack

2014-07-22 Thread Yan, Zheng
Previous commit introduces context switch callback, its function overlaps with the flush branch stack callback. So we can use the context switch callback to flush LBR stack. This patch adds code that uses the flush branch callback to flush the LBR stack when task is being scheduled in. The

[PATCH v3 4/9] perf, x86: introduce setup_pebs_sample_data()

2014-07-22 Thread Yan, Zheng
move codes that setup PEBS sample data to separate function Signed-off-by: Yan, Zheng zheng.z@intel.com --- arch/x86/kernel/cpu/perf_event_intel_ds.c | 63 ++- 1 file changed, 36 insertions(+), 27 deletions(-) diff --git

[PATCH v3 5/9] perf, x86: large PEBS interrupt threshold

2014-07-22 Thread Yan, Zheng
PEBS always had the capability to log samples to its buffers without an interrupt. Traditionally perf has not used this but always set the PEBS threshold to one. For frequently occuring events (like cycles or branches or load/stores) this in term requires using a relatively high sampling period

[PATCH v3 7/9] perf, x86: drain PEBS buffer during context switch

2014-07-22 Thread Yan, Zheng
Flush the PEBS buffer during context switch if PEBS interrupt threshold is larger than one. This allows perf to supply TID for sample outputs. Signed-off-by: Yan, Zheng zheng.z@intel.com --- arch/x86/kernel/cpu/perf_event.h | 3 +++ arch/x86/kernel/cpu/perf_event_intel.c | 11

[PATCH v3 0/7] perf, x86: large PEBS interrupt threshold

2014-07-22 Thread Yan, Zheng
This patch series implements large PEBS interrupt threshold. For some limited cases, it can significantly reduce the sample overhead. Please read patch 6's commit message for more information. changes since v1: - drop patch 'perf, core: Add all PMUs to pmu_idr' - add comments for case that

Re: [PATCH v2] drm/panel: add support for InnoLux N156BGE-L21 panel

2014-07-22 Thread Thierry Reding
On Tue, Jul 22, 2014 at 08:38:55AM +0200, Alban Bedel wrote: This panel is used by the Medcom Wide and supported by the simple-panel driver. Signed-off-by: Alban Bedel alban.be...@avionic-design.de --- v2: * Added the v/hsync pulses for correctness (the panel doesn't really needs

[PATCH v3 1/9] perf, core: introduce pmu context switch callback

2014-07-22 Thread Yan, Zheng
The callback is invoked when process is scheduled in or out. It provides mechanism for later patches to save/store the LBR stack. For the schedule in case, the callback is invoked at the same place that flush branch stack callback is invoked. So it also can replace the flush branch stack callback.

Re: [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area

2014-07-22 Thread Theodore Ts'o
On Tue, Jul 22, 2014 at 09:30:05AM +0200, Peter Zijlstra wrote: I introduce a new API for allocating page from non-movable area. It is useful for ext4 and others that want to hold page cache for a long time. There's no word on why you can't teach ext4 to still migrate that page. For all

[RESEND PATCH] mfd: max14577: Don't pass IRQ domain to mfd_add_devices

2014-07-22 Thread Krzysztof Kozlowski
The max14577 MFD cells do not have any resources so the IRQ domain passed to mfd_add_devices is not used. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/max14577.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mfd/max14577.c

3.16-rc6+: r8169 fresh new irq lock inversion

2014-07-22 Thread Borislav Petkov
Hi all, I got this new lockdep splat after booting rc6 + tip/master this morning. I haven't seen it before so it must be new in rc6 which should be easy to pinpoint... or maybe there's already a fix queued somewhere. :) [ 10.033876] NET: Registered protocol family 10 [ 11.510454] r8169

Re: [PATCH v2 00/25] AMDKFD kernel driver

2014-07-22 Thread Oded Gabbay
On 22/07/14 10:28, Daniel Vetter wrote: On Mon, Jul 21, 2014 at 03:03:07PM -0400, Jerome Glisse wrote: On Mon, Jul 21, 2014 at 09:41:29PM +0300, Oded Gabbay wrote: On 21/07/14 21:22, Daniel Vetter wrote: On Mon, Jul 21, 2014 at 7:28 PM, Oded Gabbay oded.gab...@amd.com wrote: I'm not sure

Re: [PATCH v2 00/25] AMDKFD kernel driver

2014-07-22 Thread Oded Gabbay
On 22/07/14 10:40, Daniel Vetter wrote: On Tue, Jul 22, 2014 at 09:28:51AM +0200, Daniel Vetter wrote: On Mon, Jul 21, 2014 at 03:03:07PM -0400, Jerome Glisse wrote: On Mon, Jul 21, 2014 at 09:41:29PM +0300, Oded Gabbay wrote: On 21/07/14 21:22, Daniel Vetter wrote: On Mon, Jul 21, 2014 at

Re: [PATCH] blk-mq: bitmap tag: fix potential unwakeable sleep in bt_get()

2014-07-22 Thread Alexander Gordeev
On Mon, Jul 21, 2014 at 11:11:44AM +0200, Alexander Gordeev wrote: My bad, was looking at the wrong sources. What is the race? If the clear and wakeup come in after the prepare_to_wait() but before the io_schedule(), the io_schedule() will be a no-op and it wont actually sleep. Your commit

[PATCH] kfree followed by a TRACE_RET before ref should be ok

2014-07-22 Thread Nicholas Mc Guire
kfree.cocci currently triggers on constructs like drivers/staging/rts5208/spi.c: 596if (retval 0) { 597kfree(buf); 598rtsx_clear_spi_error(chip); 599spi_set_err_code(chip, SPI_HW_ERR); 600TRACE_RET(chip, STATUS_FAIL); 601} 602 603

[PATCH] x86_32, entry: store badsys error code in %eax

2014-07-22 Thread Sven Wegener
Commit 554086d (x86_32, entry: Do syscall exit work on badsys (CVE-2014-4508)) introduced a regression in the x86_32 syscall entry code, resulting in syscall() not returning proper errors for undefined syscalls on CPUs supporting the sysenter feature. The following code: int result =

Re: [PATCH 5/5] gpio: move gpio_ensure_requested() into legacy C file

2014-07-22 Thread Varka Bhadram
On 07/22/2014 12:47 PM, Alexandre Courbot wrote: (...) + if (WARN(test_and_set_bit(FLAG_REQUESTED, desc-flags) == 0, + autorequest GPIO-%d\n, desc_to_gpio(desc))) { + if (!try_module_get(chip-owner)) { + gpiod_err(desc, %s: module

Re: [PATCH 2/2] mtd: nand: add ONFI timing mode to nand_timings converter

2014-07-22 Thread Boris BREZILLON
Hi Brian, On Mon, 21 Jul 2014 19:39:47 -0700 Brian Norris computersforpe...@gmail.com wrote: On Fri, Jul 11, 2014 at 09:49:42AM +0200, Boris BREZILLON wrote: --- /dev/null +++ b/drivers/mtd/nand/nand_timings.c @@ -0,0 +1,250 @@ +/* + * Copyright (C) 2014 Free Electrons + * + *

Re: [PATCH 2/4] mfd: imanager2: Add Advantech EC APIs support for IT8516/18/28

2014-07-22 Thread Lee Jones
On Mon, 14 Jul 2014, Wei-Chun Pan wrote: You have to write a commit log here. What is this? Why is it needed? What problem does it solve? What happens if it's not provided? How is it implemented? Etc etc. Signed-off-by: Wei-Chun Pan weichun@advantech.com.tw ---

Re: [RFC PATCH 0/5] futex: introduce an optimistic spinning futex

2014-07-22 Thread Thomas Gleixner
On Tue, 22 Jul 2014, Peter Zijlstra wrote: Anyway, there is one big fail in the entire futex stack that we 'need' to sort some day and that is NUMA. Some people (again database people) explicitly do not use futexes and instead use sysvsem because of this. The problem with numa futexes is

Re: [PATCH 2/2] iio: adc: exynos_adc: Add support for S3C24xx ADC

2014-07-22 Thread Arnd Bergmann
On Tuesday 22 July 2014 11:11:14 Chanwoo Choi wrote: This patch add support for s3c2410/s3c2416/s3c2440/s3c2443 ADC. The s3c24xx is alomost same as ADCv1. But, There are a little difference as following: - ADCMUX register address to select channel - ADCDAT mask (10bit or 12bit ADC resolution

Re: [PATCH 09/17] drm/radeon: use common fence implementation for fences

2014-07-22 Thread Christian König
Am 22.07.2014 06:05, schrieb Dave Airlie: On 9 July 2014 22:29, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- drivers/gpu/drm/radeon/radeon.h| 15 +- drivers/gpu/drm/radeon/radeon_device.c | 60

Re: Fix me in netx-regs.h

2014-07-22 Thread Arnd Bergmann
On Tuesday 22 July 2014 00:16:26 Nick Krause wrote: Hey Russell, I did give thought to our previous conversations and I will still do fix mes but am going to be more careful with I submit them. Furthermore it seems #define NETX_GPIO_COUNTER_CTRL_GPIO_RE is not defined correctly. As the

  1   2   3   4   5   6   7   8   9   10   >