Re: [PATCH v2] checkpatch.pl: New instances of ENOSYS are errors

2014-08-22 Thread Joe Perches
On Fri, 2014-08-22 at 09:26 -0700, Andy Lutomirski wrote: ENOSYS means that a nonexistent system call was called. We have a bad habit of using it for things like invalid operations on otherwise valid syscalls. We should avoid this in new code. [] diff --git a/scripts/checkpatch.pl

[PATCH] Staging: netlogic: xlr_net.c Fixed code-style warnings

2014-08-22 Thread Chaitanya Hazarey
Fixed the following warning generated by checkpatch.pl: WARNING: Missing a blank line after declarations Signed-off-by: Chaitanya Hazarey c...@24.io --- drivers/staging/netlogic/xlr_net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/netlogic/xlr_net.c

Re: [PATCH v2 1/5] ARM: dts: remove old USB2 PHY node hook for Arndale

2014-08-22 Thread Andreas Färber
Am 22.08.2014 18:59, schrieb Bartlomiej Zolnierkiewicz: drivers/usb/phy/phy-samsung-usb2 driver got replaced by drivers/phy/phy-samsung-usb2 one. Remove the leftover hook from Arndale dts file. Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Kyungmin Park

Re: [PATCH] ACPI / scan: Allow ACPI drivers to bind to PNP device objects

2014-08-22 Thread Rafael J. Wysocki
On Friday, August 22, 2014 10:00:31 AM Zhang Rui wrote: On Thu, 2014-08-21 at 19:10 +0200, Rafael J. Wysocki wrote: On Thursday, August 21, 2014 08:08:54 PM Zhang Rui wrote: Hi, Rafael, On Thu, 2014-08-21 at 06:04 +0200, Rafael J. Wysocki wrote: From: Rafael J. Wysocki

Re: [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups

2014-08-22 Thread Amit Shah
On (Fri) 22 Aug 2014 [22:44:05], Amit Shah wrote: Hm, found it: The stall happens in do_initcalls(). pm_sysrq_init() is the function that causes the hang. When I #if 0 the line register_sysrq_key('o', sysrq_poweroff_op); in pm_sysrq_init(), the boot proceeds normally. Now

Re: [PATCH 1/2] leds: usb: Add LED trigger for USB gadget activity

2014-08-22 Thread Bryan Wu
On Fri, Aug 22, 2014 at 4:53 AM, Michal Sojka so...@merica.cz wrote: With this patch, USB gadget activity can be signaled by blinking a LED. Since there is no generic code where to put the trigger for all USB controllers, each USB controller needs to call the trigger individually. This patch

Re: Trace with v3.17-rc1 while trying to enable power saving for pci device

2014-08-22 Thread Julian Wollrath
Hi, I just tried out the current git master (commit 5317821c08) and got the following trace: [ 25.637181] [ cut here ] [ 25.637191] WARNING: CPU: 0 PID: 756 at fs/proc/generic.c:521 remove_proc_entry+0x170/0x180() [ 25.637194] remove_proc_entry: removing

i915: Regression: +4W in idle power use on Macbook Pro 15 (late 2013)

2014-08-22 Thread Eric Rannaud
Hi, Between 3.15.4 and 3.15.8, there was an increase in idle power consumption on Apple Macbook Pro 15 (late 2013) on a freshly booted system (no wifi driver loaded; brightness set to 4/100; X running; no desktop environment, except Awesome), from 6.5W to about 10.5W, as reported by powertop. In

i915 (possibly): Suspend regression Macbook Pro 15 (late 2013)

2014-08-22 Thread Eric Rannaud
Hi, Between 3.13.5 and 3.15.4, suspend became partially broken on Macbook Pro 15 (late 2013): a few minutes after wakeup from the *second* suspend following a fresh boot, the screen will randomly turn itself off at shorter and shorter time intervals, and turn itself back on after a few seconds

Re: percpu: Define this_cpu_cpumask_var_t_ptr

2014-08-22 Thread Christoph Lameter
On Fri, 22 Aug 2014, Tejun Heo wrote: On Thu, Aug 21, 2014 at 08:03:25PM -0500, Christoph Lameter wrote: Its a pretty simple function (actually more a name substituion) so I did not think it worth creating an inline function. Unless there are specific reasons like multi-type arg or

Re: [PATCH 19/35] [PATCH 19/36] arm: Replace __this_cpu_ptr with raw_cpu_ptr

2014-08-22 Thread Will Deacon
On Sun, Aug 17, 2014 at 06:30:42PM +0100, Christoph Lameter wrote: __this_cpu_ptr is being phased out. So replace with raw_cpu_ptr. Cc: Russell King li...@arm.linux.org.uk Cc: Catalin Marinas catalin.mari...@arm.com CC: Will Deacon will.dea...@arm.com Signed-off-by: Christoph Lameter

Re: [PATCH] fs/block_dev.c: Use hd_part to find block inodes

2014-08-22 Thread Christoph Hellwig
On Fri, Aug 22, 2014 at 10:28:16AM -0600, Keith Busch wrote: When using the GENHD_FL_EXT_DEVT disk flags, a newly added device may be assigned the same major/minor as one that was previously removed but opened, and the pesky userspace refuses to close it! Which means life time rules for those

[PATCH] i2c: rk3x: Remove unlikely() annotations

2014-08-22 Thread Doug Anderson
Having a transfer more than 32 bits is not all that unlikely. Remove the annotation. The unlikely in the IRQ handler can't gain us much. It's not in a loop, so at most it would save 1 instruction per IRQ, which isn't much. In fact on the compiler I tested it produced the exact same code.

Re: [Xen-devel] [PATCH RFC 1/3] x86: Make page cache mode a real type

2014-08-22 Thread Toshi Kani
On Fri, 2014-08-22 at 10:24 +0100, Jan Beulich wrote: On 21.08.14 at 11:30, jgr...@suse.com wrote: On 08/20/2014 09:26 PM, Toshi Kani wrote: On Tue, 2014-08-19 at 15:25 +0200, jgr...@suse.com wrote: --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -27,6 +27,35 @@ #include

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-22 Thread Javier Martinez Canillas
Hello Mark, On 08/22/2014 04:45 PM, Mark Brown wrote: On Fri, Aug 22, 2014 at 02:15:46PM +0200, Javier Martinez Canillas wrote: Mark, any opinions on how this should be solved will be highly appreciated. If someone could tell me what this is that'd help... Sorry for not being clear on

Re: [PATCH v2] net: ipv6: fib: don't sleep inside atomic lock

2014-08-22 Thread David Miller
From: Benjamin Block b...@mageta.org Date: Thu, 21 Aug 2014 19:37:48 +0200 The function fib6_commit_metrics() allocates a piece of memory in mode GFP_KERNEL while holding an atomic lock from higher up in the stack, in the function __ip6_ins_rt(). This produces the following BUG: ... Fixing

[PATCH] drivers: staging: rtl8723au: Fix space prohibited before that close parenthesis ')' errors

2014-08-22 Thread Greg Donald
Fix checkpatch.pl space prohibited before that close parenthesis ')' errors Signed-off-by: Greg Donald gdon...@gmail.com --- drivers/staging/rtl8723au/core/rtw_efuse.c| 2 +- drivers/staging/rtl8723au/include/osdep_service.h | 2 +- drivers/staging/rtl8723au/include/rtl8723a_spec.h | 6

Re: [PATCH] ACPI: Run fixed button devices' notify callback in the process context

2014-08-22 Thread Benjamin Block
On 08/22/2014 07:33 PM, Rafael J. Wysocki wrote: On Friday, August 22, 2014 03:37:55 PM Lan Tianyu wrote: Currently fixed button devices' notify callbacks are running in the interrupt context. It's not necessary and prevent calling functions with mutex lock(E,G evaluating ACPI method).

Re: [Xen-devel] [V0 PATCH 1/2] AMD-PVH: set EFER.NX and EFER.SCE for the boot vcpu

2014-08-22 Thread Konrad Rzeszutek Wilk
On Thu, Aug 21, 2014 at 07:46:56PM -0700, Mukesh Rathor wrote: On Thu, 21 Aug 2014 21:39:04 -0400 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Wed, Aug 20, 2014 at 07:16:39PM -0700, Mukesh Rathor wrote: On AMD, NX feature must be enabled in the efer for NX to be honored in

[PATCH v4] i2c: rk3x: fix bug that cause transfer fails in master receive mode

2014-08-22 Thread Addy Ke
In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data in one chunk, so the size of data to be write/read to/from TXDATAx/RXDATAx must be less than or equal 32 bytes at a time. Tested on rk3288-pinky board, elan receive 158 bytes data. Suggested-by: Dmitry Torokhov

[PATCH v3] checkpatch.pl: New instances of ENOSYS are errors

2014-08-22 Thread Andy Lutomirski
ENOSYS means that a nonexistent system call was called. We have a bad habit of using it for things like invalid operations on otherwise valid syscalls. We should avoid this in new code. Signed-off-by: Andy Lutomirski l...@amacapital.net --- Pervasive incorrect usage of ENOSYS came up at the

Re: [PATCH] drivers: staging: rtl8723au: Fix (foo*) should be (foo *) errors

2014-08-22 Thread Joe Perches
On Fri, 2014-08-22 at 12:20 -0500, Greg Donald wrote: Fix checkpatch.pl (foo*) should be (foo *) errors Hello Greg. diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c [] @@ -599,7 +599,7 @@ void update_sta_info23a_apmode23a(struct rtw_adapter

Re: [fuse-devel] [PATCH 6/6] fuse: add mount option to disable synchronous release

2014-08-22 Thread Anand Avati
On 8/22/14, 7:09 AM, Miklos Szeredi wrote: On Thu, Aug 21, 2014 at 6:09 PM, Maxim Patlasov mpatla...@parallels.com wrote: Synchronous release ensures that kernel fuse reports to userspace exactly last fput(). However, nothing guarantees that last fput() will happen in the context of close(2).

Re: [PATCH] [v3] warn on performance-impacting configs aka. TAINT_PERFORMANCE

2014-08-22 Thread Tim Chen
On Fri, 2014-08-22 at 09:45 -0700, Dave Hansen wrote: On 08/22/2014 09:32 AM, Tim Chen wrote: +#ifdef CONFIG_DEBUG_OBJECTS_FREE +DEBUG_OBJECTS_FREE, +#endif +#ifdef CONFIG_DEBUG_KMEMLEAK +DEBUG_KMEMLEAK, +#endif +#ifdef CONFIG_DEBUG_PAGEALLOC +

Re: [PATCH v3] checkpatch.pl: New instances of ENOSYS are errors

2014-08-22 Thread Joe Perches
On Fri, 2014-08-22 at 11:05 -0700, Andy Lutomirski wrote: ENOSYS means that a nonexistent system call was called. We have a bad habit of using it for things like invalid operations on otherwise valid syscalls. We should avoid this in new code. Seems sensible thanks for persisting. Andrew

Re: Kernel 3.16.0 USB crash

2014-08-22 Thread Hans de Goede
Hi, On 08/15/2014 09:44 AM, Claudio Bizzarri wrote: On Thu, Aug 14, 2014 at 11:46:33AM +0200, Hans de Goede wrote: Hi, ... Can you collect lsusb -v output for the drive in question when connected through an usb-3 port (the uas module does not need to be loaded). Here lsusb output, full

Re: [PATCH 1/1] IIO: Added write function in iio_buffer_fileops

2014-08-22 Thread Jonathan Cameron
On 16/08/14 15:44, Aniroop Mathur wrote: On Thu, Aug 14, 2014 at 8:08 PM, Jonathan Cameron ji...@kernel.org mailto:ji...@kernel.org wrote: On 14/08/14 10:41, Lars-Peter Clausen wrote: On 08/13/2014 06:33 PM, Aniroop Mathur wrote: On Wed, Aug 13, 2014 at 8:18 PM,

Re: [PATCH] net: ethernet: broadcom: bnx2x: Remove redundant #ifdef

2014-08-22 Thread David Miller
From: Rasmus Villemoes li...@rasmusvillemoes.dk Date: Fri, 22 Aug 2014 09:33:07 +0200 David Miller da...@davemloft.net writes: From: Rasmus Villemoes li...@rasmusvillemoes.dk Date: Wed, 20 Aug 2014 15:14:49 +0200 Nothing defines _ASM_GENERIC_INT_L64_H, it is a weird way to check for 64

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-22 Thread Mark Brown
On Fri, Aug 22, 2014 at 07:53:19PM +0200, Javier Martinez Canillas wrote: On 08/22/2014 04:45 PM, Mark Brown wrote: On Fri, Aug 22, 2014 at 02:15:46PM +0200, Javier Martinez Canillas wrote: Mark, any opinions on how this should be solved will be highly appreciated. If someone could tell

Re: [PATCH] drivers: isdn: eicon: xdi_msg.h: Fix typo in #ifndef

2014-08-22 Thread David Miller
From: Rasmus Villemoes li...@rasmusvillemoes.dk Date: Fri, 22 Aug 2014 18:39:14 +0200 Test for definedness of the macro which is actually defined (the change is hard to see: it is s/SSS/SSA/). Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk Applied. -- To unsubscribe from this

Re: [PATCH v4] i2c: rk3x: fix bug that cause transfer fails in master receive mode

2014-08-22 Thread Doug Anderson
Addy, On Fri, Aug 22, 2014 at 11:00 AM, Addy Ke addy...@rock-chips.com wrote: In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data in one chunk, so the size of data to be write/read to/from TXDATAx/RXDATAx must be less than or equal 32 bytes at a time. Tested on

Re: [PATCH] sound: soc: da732x.h: Fix typo in include guard

2014-08-22 Thread Mark Brown
On Fri, Aug 22, 2014 at 11:25:13AM +0200, Rasmus Villemoes wrote: Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk Applied, but please use subject lines matching the style for the subsystem - if your commit log looks different to others for the same files try to avoid that.

Re: [PATCH] sound: tegra: tegra_asoc_utils.h: Fix typo in include guard

2014-08-22 Thread Mark Brown
On Fri, Aug 22, 2014 at 11:27:07AM +0200, Rasmus Villemoes wrote: Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk Applied, thanks - again please try to follow the subject line style. signature.asc Description: Digital signature

[PATCH 3/5] kexec: Add bit definitions for kimage entry flags

2014-08-22 Thread Geoff Levand
Define new kexec preprocessor macros IND_*_BIT that define the bit position of the kimage entry flags. Change the existing IND_* flag macros to be defined as bit shifts of the corresponding IND_*_BIT macros. Also wrap all C language code in kexec.h with #if !defined(__ASSEMBLY__) so assembly

[PATCH 2/5] kexec: Simplify conditional

2014-08-22 Thread Geoff Levand
Simplify the code around one of the conditionals in the kexec_load syscall routine. The original code was confusing with a redundant check on KEXEC_ON_CRASH and comments outside of the conditional block. This change switches the order of the conditional check, and cleans up the comments for the

[PATCH 1/5] kexec: Fix make headers_check

2014-08-22 Thread Geoff Levand
Remove the unneded declaration for a kexec_load() routine. Fixes errors like these when running 'make headers_check': include/uapi/linux/kexec.h: userspace cannot reference function or variable defined in the kernel Signed-off-by: Geoff Levand ge...@infradead.org ---

[PATCH 4/5] kexec: Add IND_FLAGS macro

2014-08-22 Thread Geoff Levand
Add a new kexec preprocessor macro IND_FLAGS, which is the bitwise OR of all the possible kexec IND_ kimage_entry indirection flags. Having this macro allows for simplified code in the prosessing of the kexec kimage_entry items. Signed-off-by: Geoff Levand ge...@infradead.org ---

[PATCH 5/5] powerpc/kexec: Use global IND_FLAGS macro

2014-08-22 Thread Geoff Levand
linux/kexec.h now defines an IND_FLAGS macro. Remove the local powerpc definition and use the generic one. Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/kernel/machine_kexec_64.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/kernel/machine_kexec_64.c

[PATCH 0/5] kexec: minor fixups and enhancements

2014-08-22 Thread Geoff Levand
Hi, Here are a few minor fixups and enhancements for kexec support. Patch 3 and 4 that add preprocessor macros for the kimage list flags are ones that I use in the arm64 kexec support I am working on, so it would be nice for those to go in. Please consider. -Geoff The following changes

[GIT PULL] Networking

2014-08-22 Thread David Miller
Here are some bug fixes that have piled up during ksummit/linuxcon. 1) Fix endian problems in ibmveth, from Anton Blanchard. 2) IPV6 routing code does GFP_KERNEL allocation in atomic, fix from Benjamin Block. 3) SCTP association fixes from Daniel Borkmann. 4) When multiple VLAN headers are

Re: [PATCH v4 3/4] zram: zram memory size limitation

2014-08-22 Thread Dan Streetman
On Fri, Aug 22, 2014 at 6:55 AM, David Horner ds2hor...@gmail.com wrote: On Thu, Aug 21, 2014 at 8:42 PM, Minchan Kim minc...@kernel.org wrote: Since zram has no control feature to limit memory usage, it makes hard to manage system memrory. This patch adds new knob mem_limit via sysfs to set

Re: Revert aio: fix aio request leak when events are reaped by user space

2014-08-22 Thread Dan Aloni
On Fri, Aug 22, 2014 at 12:26:30PM -0400, Benjamin LaHaise wrote: On Fri, Aug 22, 2014 at 07:15:02PM +0300, Dan Aloni wrote: Sorry, I was waiting for a new patch from your direction, I should have replied earlier. What bothered me about the patch you sent is that completed_events is added

BUG: spinlock recursion on CPU#0, rngd/1219

2014-08-22 Thread Toralf Förster
While fuzzying a 22 bit UML guest (stable Gentoo x86 Linux) with trinity I do sometimes get from the UML guest this : Aug 22 19:59:40 trinity kernel: BUG: spinlock recursion on CPU#0, rngd/1219 Aug 22 19:59:40 trinity kernel: lock: 0x86f1548, .magic: dead4ead, .owner: rngd/1219, .owner_cpu: 0

Re: [PATCH v4] i2c: rk3x: fix bug that cause transfer fails in master receive mode

2014-08-22 Thread addy ke
Addy, On Fri, Aug 22, 2014 at 11:00 AM, Addy Ke addy...@rock-chips.com wrote: In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data in one chunk, so the size of data to be write/read to/from TXDATAx/RXDATAx must be less than or equal 32 bytes at a time. Tested on

[PATCH v2] tps65910: Work around silicon erratum SWCZ010

2014-08-22 Thread Arnout Vandecappelle (Essensium/Mind)
From http://www.ti.com/lit/pdf/SWCZ010 : Glitch on SDA-SCL not managed correctly by the I2C IP Impact: The standard specifies that the I2C transfer should restart on a start event in all cases. The current design does not support two consecutive Start conditions. This can cause the first real

Re: linux-next: build failure after merge of the mfd tree

2014-08-22 Thread Lee Jones
the mfd tree from next-20140822 for today. I fixed this at 10 o'clock this morning? When did you pull? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

Re: [Xen-devel] [V0 PATCH 1/2] AMD-PVH: set EFER.NX and EFER.SCE for the boot vcpu

2014-08-22 Thread Mukesh Rathor
On Fri, 22 Aug 2014 06:41:40 +0200 Borislav Petkov b...@alien8.de wrote: On Thu, Aug 21, 2014 at 07:46:56PM -0700, Mukesh Rathor wrote: Intel doesn't have EFER.NX bit. Of course it does. Right, it does. Some code/comment is misleading... Anyways, reading intel SDMs, if I understand the

[PATCH v2] carl9170: Remove redundant protection check

2014-08-22 Thread Andreea-Cristina Bernat
The carl9170_op_ampdu_action() function is used only by the mac80211 framework. Since the mac80211 already takes care of checks and properly serializing calls to the driver's function there is no need for the driver to do the same thing. Signed-off-by: Andreea-Cristina Bernat bernat@gmail.com

Re: [V0 PATCH 0/2] AMD PVH domU support

2014-08-22 Thread Mukesh Rathor
On Fri, 22 Aug 2014 14:55:21 +0100 David Vrabel david.vra...@citrix.com wrote: On 22/08/14 14:52, David Vrabel wrote: On 21/08/14 03:16, Mukesh Rathor wrote: Hi, Here's first stab at AMD PVH domU support. Pretty much the only thing needed is EFER bits set. Please review. I'm not

Re: [PATCH v4 0/4] zram memory control enhance

2014-08-22 Thread Dan Streetman
On Thu, Aug 21, 2014 at 8:42 PM, Minchan Kim minc...@kernel.org wrote: Currently, zram has no feature to limit memory so theoretically zram can deplete system memory. Users have asked for a limit several times as even without exhaustion zram makes it hard to control memory usage of the

Re: + prctl-pr_set_mm-introduce-pr_set_mm_map-operation-v3.patch added to -mm tree

2014-08-22 Thread Oleg Nesterov
Hi Cyrill, I think the patch is fine but I can't understand the usage of mmap_sem and alloc_lock, + stack_vma = find_vma(mm, (unsigned long)prctl_map-start_stack); OK, find_vma() needs mmap_sem. But otherwise, why this should be called under down_read(mm-mmap_sem) ? What this lock tries to

Re: [PATCH] arm: tegra: apalis/colibri t30: fix on-module 5v0 supplies

2014-08-22 Thread Stephen Warren
On 08/22/2014 09:06 AM, Marcel Ziswiler wrote: Working on Gigabit/PCIe support in U-Boot for Apalis T30 I realised that the current device tree source includes for our modules only happen to work due to referencing the on-carrier 5v0 supply from USB which is not at all available on-module. The

Re: [PATCH net-next,v3] hyperv: Increase the buffer length for netvsc_channel_cb()

2014-08-22 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Fri, 15 Aug 2014 19:18:19 + When the buffer is too small for a packet from VMBus, a bigger buffer will be allocated in netvsc_channel_cb() and retry reading the packet from VMBus. Increasing this buffer size will reduce the retry overhead.

Re: [PATCH] isdn/bas_gigaset: use USB API functions rather than constants

2014-08-22 Thread David Miller
From: Himangi Saraogi himangi...@gmail.com Date: Sun, 17 Aug 2014 06:01:20 +0530 This patch introduces the use of the function usb_endpoint_num. The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ - (epd-bEndpointAddress

Re: [PATCH] isdn/gigaset: use USB API functions rather than constants

2014-08-22 Thread David Miller
From: Himangi Saraogi himangi...@gmail.com Date: Fri, 15 Aug 2014 21:54:12 +0530 This patch introduces the use of the function usb_endpoint_num. The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ - (epd-bEndpointAddress

Re: [PATCH] net/openvswitch/flow.c: Replace rcu_dereference() with rcu_access_pointer()

2014-08-22 Thread David Miller
From: Andreea-Cristina Bernat bernat@gmail.com Date: Sun, 17 Aug 2014 16:29:43 +0300 The rcu_dereference() call is used directly in a condition. Since its return value is never dereferenced it is recommended to use rcu_access_pointer() instead of rcu_dereference(). Therefore, this patch

Re: [PATCH] net/ipv4/igmp.c: Replace rcu_dereference() with rcu_access_pointer()

2014-08-22 Thread David Miller
From: Andreea-Cristina Bernat bernat@gmail.com Date: Sun, 17 Aug 2014 15:49:41 +0300 The rcu_dereference() call is used directly in a condition. Since its return value is never dereferenced it is recommended to use rcu_access_pointer() instead of rcu_dereference(). Therefore, this patch

Re: [PATCH v2] cnic: Replace rcu_dereference() with rcu_access_pointer()

2014-08-22 Thread David Miller
From: Andreea-Cristina Bernat bernat@gmail.com Date: Sun, 17 Aug 2014 13:12:09 +0300 The rcu_dereference() calls are used directly in conditions. Since their return values are never dereferenced it is recommended to use rcu_access_pointer() instead of rcu_dereference(). Therefore, this

Re: [PATCH v2] bonding: Replace rcu_dereference() with rcu_access_pointer()

2014-08-22 Thread David Miller
From: Andreea-Cristina Bernat bernat@gmail.com Date: Sun, 17 Aug 2014 13:21:45 +0300 This rcu_dereference() call is used directly in a condition. Since its return value is never dereferenced it is recommended to use rcu_access_pointer() instead of rcu_dereference(). Therefore, this patch

Re: [PATCH] decnet: Use time_after_eq

2014-08-22 Thread David Miller
From: Himangi Saraogi himangi...@gmail.com Date: Wed, 20 Aug 2014 23:20:09 +0530 The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. A simplified version of the Coccinelle semantic patch making this change is

Re: [PATCH] br_multicast: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

2014-08-22 Thread David Miller
From: Andreea-Cristina Bernat bernat@gmail.com Date: Fri, 22 Aug 2014 16:06:09 +0300 The use of rcu_assign_pointer() is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment: 1. This use of RCU_INIT_POINTER() is NULLing out the pointer it is better to use it instead

Re: [PATCH] af_decnet: Use time_after_eq

2014-08-22 Thread David Miller
From: Himangi Saraogi himangi...@gmail.com Date: Wed, 20 Aug 2014 23:24:40 +0530 The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. A simplified version of the Coccinelle semantic patch making this change is

Re: [PATCH] dn_dev: Use time_before

2014-08-22 Thread David Miller
From: Himangi Saraogi himangi...@gmail.com Date: Wed, 20 Aug 2014 23:13:07 +0530 The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. A simplified version of the Coccinelle semantic patch making this change is

Re: [PATCH] ipconfig: Use time_before

2014-08-22 Thread David Miller
From: Himangi Saraogi himangi...@gmail.com Date: Wed, 20 Aug 2014 23:14:10 +0530 The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. A simplified version of the Coccinelle semantic patch making this change is

Re: [PATCH v7 3/8] cpufreq: kirkwood: Remove use of the clk provider API

2014-08-22 Thread Mike Turquette
Quoting Andrew Lunn (2014-08-21 06:38:25) On Thu, Aug 21, 2014 at 09:53:43AM +0200, Tomeu Vizoso wrote: On 08/21/2014 12:55 AM, Mike Turquette wrote: Quoting Tomeu Vizoso (2014-08-18 08:30:29) Signed-off-by: Tomeu Vizoso tomeu.viz...@collabora.com ---

Re: [PATCH] stmmac: simple cleanups

2014-08-22 Thread David Miller
From: Pavel Machek pa...@ucw.cz Date: Tue, 19 Aug 2014 12:56:46 +0200 This adds simple cleanups for stmmac, removing test we know is always true, fixing whitespace, and moving code out of if(). Signed-off-by: Pavel Machek pa...@denx.de This does not apply cleanly to the current net-next

[GIT PULL] pwm: Fixes for v3.17-rc2

2014-08-22 Thread Thierry Reding
Hi Linus, The following changes since commit 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9: Linux 3.17-rc1 (2014-08-16 10:40:26 -0600) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git tags/pwm/for-3.17-rc2 for you to fetch

Re: [PATCH net-next v2] r8169:add support for RTL8168H and RTL8107E

2014-08-22 Thread David Miller
From: Chun-Hao Lin h...@realtek.com Date: Wed, 20 Aug 2014 01:54:04 +0800 RTL8168H is Realtek PCIe Gigabit Ethernet controller. RTL8107E is Realtek PCIe Fast Ethernet controller. This patch add support for these two chips. Signed-off-by: Chun-Hao Lin h...@realtek.com Applied. -- To

Re: [PATCH] net: stmmac: add fix_mac_speed support for socfpga

2014-08-22 Thread David Miller
From: Ley Foon Tan lf...@altera.com Date: Wed, 20 Aug 2014 14:33:33 +0800 This patch adds fix_mac_speed() support for Altera socfpga Ethernet controller. Emac splitter is a soft IP core in FPGA system that converts GMII interface from Synopsys mac to RGMII/SGMII interface. This splitter core

Re: [PATCH v2 0/3] net: Add Keystone NetCP ethernet driver support

2014-08-22 Thread Santosh Shilimkar
Hi David, On Thursday 21 August 2014 07:36 PM, David Miller wrote: From: Santosh Shilimkar santosh.shilim...@ti.com Date: Fri, 15 Aug 2014 11:12:39 -0400 Update version after incorporating David Miller's comment from earlier posting [1]. I would like to get these merged for upcoming 3.18

Re: [PATCH 3.12 000/104] 3.12.27-stable review

2014-08-22 Thread Shuah Khan
On 08/20/2014 05:43 AM, Jiri Slaby wrote: This is the start of the stable review cycle for the 3.12.27 release. There are 104 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by

[PATCH 3/3] perf tools: Add support to new style format of kernel PMU event

2014-08-22 Thread kan . liang
From: Kan Liang kan.li...@intel.com Add new rules for kernel PMU event. event_pmu: PE_KERNEL_PMU_EVENT | PE_PMU_EVENT_PRE '-' PE_PMU_EVENT_SUF PE_KERNEL_PMU_EVENT token is for cycles-ct/cycles-t/mem-loads/mem-stores. The prefix cycles is mixed up with cpu-cycles. loads and stores are mixed up

[PATCH 2/3] perf tools: parse the pmu event prefix and surfix

2014-08-22 Thread kan . liang
From: Kan Liang kan.li...@intel.com There are two types of event formats for PMU events. E.g. el-abort OR cpu/el-abort/. However, the lexer mistakenly recognizes the simple style format as two events. The newly introduced function uses bsearch to search the name in known pmu event list. It can

[PATCH 1/3] Revert perf tools: Default to cpu// for events v5

2014-08-22 Thread kan . liang
From: Kan Liang kan.li...@intel.com This reverts commit 50e200f07948 (perf tools: Default to cpu// for events v5) The fixup cannot handle the case that new style format(which without //) mixed with other different formats. For example, group events with new style format: {mem-stores,mem-loads}

Re: [PATCH v2 2/3] net: Add Keystone NetCP ethernet driver

2014-08-22 Thread Santosh Shilimkar
On Thursday 21 August 2014 10:48 PM, Stephen Hemminger wrote: On Fri, 15 Aug 2014 11:12:41 -0400 Santosh Shilimkar santosh.shilim...@ti.com wrote: NetCP driver has a plug-in module architecture where each of the NetCP sub-modules exist as a loadable kernel module which plug in to the netcp

Re: [PATCH] fs/block_dev.c: Use hd_part to find block inodes

2014-08-22 Thread Keith Busch
On Fri, 22 Aug 2014, Christoph Hellwig wrote: On Fri, Aug 22, 2014 at 10:28:16AM -0600, Keith Busch wrote: When using the GENHD_FL_EXT_DEVT disk flags, a newly added device may be assigned the same major/minor as one that was previously removed but opened, and the pesky userspace refuses to

WARNING: CPU: 0 PID: 197 at fs/proc/generic.c:521 remove_proc_entry+0x142/0x159()

2014-08-22 Thread Thomas Glanzmann
Hello everyone, after I compiled a new kernel 2 days ago and also with current Linus tip I get: [0.00] Initializing cgroup subsys cpuset [0.00] Initializing cgroup subsys cpu [0.00] Initializing cgroup subsys cpuacct [0.00] Linux version 3.17.0-rc1+ (sithglan@mini)

linux-next: manual merge of the usb-gadget tree with the usb-gadget-fixes tree

2014-08-22 Thread Stephen Rothwell
Hi Felipe, Today's linux-next merge of the usb-gadget tree got a conflict in drivers/usb/phy/phy-samsung-usb.h between commit bbc66e140bab (usb: phy: samsung: Fix wrong bit mask for PHYPARAM1_PCS_TXDEEMPH) from the usb-gadget-fixes tree and commit 0dafc3d94596 (usb: phy: samsung: Remove

Re: [RFC PATCH -logging 00/10] scsi/constants: Output continuous error messages on trace

2014-08-22 Thread Douglas Gilbert
On 14-08-12 11:13 PM, Yoshihiro YUNOMAE wrote: Hi Douglas, Thank you for your comment. (2014/08/08 22:07), Douglas Gilbert wrote: On 14-08-08 01:50 PM, Yoshihiro YUNOMAE wrote: Hi All, This patch set introduces new traceevents in order to output continuous error messages. Current SCSI

Re: [PATCH v4] i2c: rk3x: fix bug that cause transfer fails in master receive mode

2014-08-22 Thread Doug Anderson
Addy, On Fri, Aug 22, 2014 at 11:47 AM, addy ke addy...@rock-chips.com wrote: Addy, On Fri, Aug 22, 2014 at 11:00 AM, Addy Ke addy...@rock-chips.com wrote: In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data in one chunk, so the size of data to be write/read to/from

Re: [PATCH] trivial: fs/btrfs/tree-log.c: Fix closing brace followed by if

2014-08-22 Thread Rasmus Villemoes
Josef Bacik jba...@fb.com writes: On 06/20/2014 12:51 PM, Rasmus Villemoes wrote: Maybe else if was meant, but because of the goto out_unlock, it doesn't make a difference. Anyway, I chose the only whitespace fix. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk ---

[PATCH] socklnd: Remove static initialization to NULL or 0

2014-08-22 Thread Marco Cyriacks
This patch fixes the following coding style issue: ERROR: do not initialise statics to 0 or NULL Signed-off-by: Marco Cyriacks ma...@cyriacks.net --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH] socklnd: Code style fix (eudyptula challenge task 10)

2014-08-22 Thread Marco Cyriacks
Hi, I'm currently working on the eudyptula challenge and this is my first kernel contribution to pass task 10 of the challenge. The task was to fix one coding style error of a file in the drivers staging area. This patch was prepared on top of next-20140822. Please consider it for inclusion

Re: [PATCH v2 3/4] Documentation/scheduler/sched-deadline.txt: improve and clarify AC bits

2014-08-22 Thread Luca Abeni
Hi, On Fri, 22 Aug 2014 10:31:11 +0200 Ingo Molnar mi...@kernel.org wrote: [...] + execution time is guaranteed for non real-time tasks, which risk to be + starved by real-time tasks. The last part doesn't really parse as correct English for me - maybe also split this

[PATCH 2/2] HID: logitech-dj: break out testing of validity of dj_device

2014-08-22 Thread Benjamin Tissoires
We can do once the test of the validity of the dj_device, which removes some duplicated code in various functions. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/hid-logitech-dj.c | 35 +++ 1 file changed, 11 insertions(+), 24

Re: + prctl-pr_set_mm-introduce-pr_set_mm_map-operation-v3.patch added to -mm tree

2014-08-22 Thread Cyrill Gorcunov
On Fri, Aug 22, 2014 at 09:22:41PM +0200, Oleg Nesterov wrote: Hi Cyrill, I think the patch is fine but I can't understand the usage of mmap_sem and alloc_lock, + stack_vma = find_vma(mm, (unsigned long)prctl_map-start_stack); OK, find_vma() needs mmap_sem. But otherwise, why this

[PATCH 1/2] HID: logitech-dj: prevent false errors to be shown

2014-08-22 Thread Benjamin Tissoires
Commit HID: logitech: perform bounds checking on device_id early enough unfortunately leaks some errors to dmesg which are not real ones: - if the report is not a DJ one, then there is not point in checking the device_id - the receiver (index 0) can also receive some notifications which can be

Re: [PATCH v7 3/8] cpufreq: kirkwood: Remove use of the clk provider API

2014-08-22 Thread Andrew Lunn
Thanks for reviewing. I think my patch is equivalent to the old way of doing things, with one exception that I will address later below. struct cpufreq_frequency_table kirkwood_freq_table has clock rates initialized to zero, so there is no regression compared to my unsigned long

Re: [PATCH 2/3] perf tools: parse the pmu event prefix and surfix

2014-08-22 Thread Andi Kleen
+/* The contents of the pmu_events should be in ascending sorted by symbol*/ +static struct pmu_event_symbol pmu_events[] = { + { abort, false}, + { capacity, false}, + { commit, false}, + { conflict, false}, + { el, true}, + { start, false}, + { tx, true},

Re: [PATCH] tpm_tis: Verify ACPI-specified interrupt

2014-08-22 Thread Scot Doyle
On Fri, 22 Aug 2014, Jason Gunthorpe wrote: On Fri, Aug 22, 2014 at 12:58:41AM +, Scot Doyle wrote: Some machines, such as the Acer C720 and Toshiba CB35, have TPMs that do not use interrupts while also having an ACPI TPM entry How do these machines work in Windows? I don't know. Since

[PATCH][SCSI] scsi-mq: fix requests that use a separate CDB buffer

2014-08-22 Thread Tony Battersby
This patch fixes code such as the following with scsi-mq enabled: rq = blk_get_request(...); blk_rq_set_block_pc(rq); rq-cmd = my_cmd_buffer; /* separate CDB buffer */ blk_execute_rq_nowait(...); Code like this appears in e.g. sg_start_req() in drivers/scsi/sg.c (for large CDBs

[PATCH][SCSI] fix regression in SCSI_IOCTL_SEND_COMMAND

2014-08-22 Thread Tony Battersby
blk_rq_set_block_pc() memsets rq-cmd to 0, so it should come immediately after blk_get_request() to avoid overwriting the user-supplied CDB. Also check for failure to allocate rq. Fixes: f27b087b81b7 (block: add blk_rq_set_block_pc()) Cc: sta...@vger.kernel.org # 3.16.x Signed-off-by: Tony

Re: [PATCH] tpm_tis: Verify ACPI-specified interrupt

2014-08-22 Thread Jason Gunthorpe
On Fri, Aug 22, 2014 at 08:17:27PM +, Scot Doyle wrote: On Fri, 22 Aug 2014, Jason Gunthorpe wrote: On Fri, Aug 22, 2014 at 12:58:41AM +, Scot Doyle wrote: Some machines, such as the Acer C720 and Toshiba CB35, have TPMs that do not use interrupts while also having an ACPI TPM entry

Re: [PATCH] fs/block_dev.c: Use hd_part to find block inodes

2014-08-22 Thread Keith Busch
On Fri, 22 Aug 2014, Keith Busch wrote: On Fri, 22 Aug 2014, Christoph Hellwig wrote: On Fri, Aug 22, 2014 at 10:28:16AM -0600, Keith Busch wrote: When using the GENHD_FL_EXT_DEVT disk flags, a newly added device may be assigned the same major/minor as one that was previously removed but

Re: [PATCH v7 3/8] cpufreq: kirkwood: Remove use of the clk provider API

2014-08-22 Thread Andrew Lunn
It was clearer in earlier versions of the driver, but code has been refactored into the cpufreq core. The core should call kirkwood_cpufreq_get_cpu_frequency() in order to get the current frequency, and only perform a change if the requested frequency is different. In the current code,

Re: [PATCH v2] carl9170: Remove redundant protection check

2014-08-22 Thread Christian Lamparter
On Friday, August 22, 2014 10:14:31 PM Andreea-Cristina Bernat wrote: The carl9170_op_ampdu_action() function is used only by the mac80211 framework. Since the mac80211 already takes care of checks and properly serializing calls to the driver's function there is no need for the driver to do

Re: [patch 4/4] prctl: PR_SET_MM -- Introduce PR_SET_MM_MAP operation, v3

2014-08-22 Thread Cyrill Gorcunov
On Thu, Aug 21, 2014 at 11:49:12PM -0700, Andrew Morton wrote: But it's a bit hacky. Can anyone think of anything smarter? Looks good to me and not that hacky actually. Hacky :( I guess it's pretty safe because this is a userspace-visible structure so we'll never be changing it.

Re: [PATCHv2 1/5] rtc: s3c: Define s3c_rtc structure to remove global variables.

2014-08-22 Thread Andrew Morton
On Tue, 12 Aug 2014 11:01:07 +0900 y...@samsung.com wrote: This patch define s3c_rtc structure including necessary variables for S3C RTC device instead of global variables. This patch improves the readability by removing global variables. Below is the v1-v2 delta. Why were all those tests of

Re: [patch 4/4] prctl: PR_SET_MM -- Introduce PR_SET_MM_MAP operation, v3

2014-08-22 Thread Andrew Morton
On Sat, 23 Aug 2014 00:38:09 +0400 Cyrill Gorcunov gorcu...@gmail.com wrote: Or will we? What happens if we later decide that some additional field needs to be added? Do we version the interface? Add a new prctl() mode? Let's cook up a plan for that and at least add to changelog?

Re: [PATCH] target: target_core_transport.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-08-22 Thread Nicholas A. Bellinger
Hi Rickard, On Sun, 2014-08-03 at 23:50 +0200, Rickard Strandqvist wrote: Ensures that the string is null-terminate in connection with the use of strncpy. Optimized code by replacing unnecessary sprintf with strlcat and more, and simultaneously guarantees that the string does not get bigger

<    1   2   3   4   5   6   7   8   9   10   >