[PATCH 1/3] x86_64: remove KERNEL_STACK_OFFSET from THREAD_INFO macro

2015-01-17 Thread Alexander van Heukelum
In the macro THREAD_INFO(reg,offset), the offset is relative to KERNEL_STACK_OFFSET. Change the macro and all its uses so that offset is given as the current top of stack in the pt_regs frame. The generated code is identical. Signed-off-by: Alexander van Heukelum --- arch/x86/ia32/ia32entry.S

[PATCH v2] staging: rtl8188eu: core: rtw_wlan_util: Remove unused functions

2015-01-17 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: CAM_empty_entry() get_bsstype() rtw_get_oper_choffset() rtw_get_oper_bw() is_ap_in_wep() should_forbid_n_rate() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist ---

[PATCH 3/3] x86_64, entry: Create IRET-compatible stack frame at syscall entry

2015-01-17 Thread Alexander van Heukelum
Create an IRET-compatible top of stack at syscall entry and use this information to return to user mode in the sysret path. This removes the need for the FIXUP_TOP_OF_STACK and RESTORE_TOP_OF_STACK macros. Signed-off-by: Alexander van Heukelum --- arch/x86/kernel/entry_64.S | 77

Re: [PATCH] device: Change dev_ logging functions to return void

2015-01-17 Thread Greg Kroah-Hartman
On Sat, Jan 17, 2015 at 04:56:20PM -0800, Joe Perches wrote: > On Thu, 2014-12-25 at 15:07 -0800, Joe Perches wrote: > > No caller or macro uses the return value so make all > > the functions return void. > > Ping? It's in my queue, just starting to dig out from under it, give me a few more days

Re: Intel GCM: __driver-gcm-aes-aesni setkey missing

2015-01-17 Thread Tadeusz Struk
Hi Stephan, On 01/17/2015 10:23 AM, Stephan Mueller wrote: > during testing of my algif_aead patch with the different GCM implementations > I > am able to trigger a kernel crash from user space using __driver-gcm-aes- > aesni. > > As I hope that algif_aead is going to be included, unprivileged

[PATCH] video: mx3fb: fix up wait_for_completion_timeout return handling

2015-01-17 Thread Nicholas Mc Guire
Signed-off-by: Nicholas Mc Guire --- return type of wait_for_completion_timeout is unsigned long as ret is used only for checking wait_for_completion_timeout here the type was changed to unsigned long, wait_for_completion_timeout return >= 0 only so the checks for negative return canbe dropped.

Re: [PATCH] sysfs: group: allow is_visible to drop permissions

2015-01-17 Thread Guenter Roeck
On 01/17/2015 02:09 PM, Vivien Didelot wrote: Hi Guenter, Greg, [ .. ] BTW Guenter, does this patch make sense to you? It does make sense to me to only use the return value from is_visible for the mode. As for which bits to use, I am not entirely sure. I think it would be more important

Re: [PATCH] hostfs: Use noop_fsync for directories

2015-01-17 Thread Daniel Gröber
From: Richard Weinberger Subject: Re: [PATCH] hostfs: Use noop_fsync for directories Date: Wed, 14 Jan 2015 09:43:53 +0100 > Daniel, are you interested in a small kernel project? Sure, I'm just pretty busy with university right now, I'll probably pick this back up after exams are finished in a

[PATCH] mmc: vub300: remove unreachable return value handling

2015-01-17 Thread Nicholas Mc Guire
Signed-off-by: Nicholas Mc Guire --- The return value of wait_for_completion_timeout is unsigned long, as it is used here for wait_for_completion_timeout only the type of commretval was changed to unsigned long. As wait_for_completion_timeout does not return negative values the commretval < 0

[PATCH 1/4] staging: vt6655: correcting function declaration sparse error

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c drivers/staging/vt6655/device_main.c:1672:5: warning: symbol 'vnt_init' was not declared. Should it be static? CC

[PATCH 0/4] staging: vt6655: fixing various sparse problems

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier >From a v3.19-rc4 baseline sparse finds the following errors: LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces)

[PATCH 4/4] staging: vt6655: correcting parameter related sparse error

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces)

[PATCH 3/4] staging: vt6655: fix wrong parameter as reported by sparse

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c CC [M] drivers/staging/vt6655/device_main.o CHECK drivers/staging/vt6655/card.c CC [M]

[PATCH 2/4] staging: vt6655: removing dead function as reported by sparse

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ CHECK drivers/staging/vt6655/mac.c drivers/staging/vt6655/mac.c:162:6: warning: symbol 'MACvGetShortRetryLimit' was not declared. Should it be static? CC [M] drivers/staging/vt6655/mac.o Commit:

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Hi, On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. Inline comments removed; > > chanptr > > comment is implied by the first argument being the channel. No parent bus > >

Re: [PATCH 2/4] dt-bindings: Add root properties for Raspberry Pi B and B+

2015-01-17 Thread Stephen Warren
On 01/16/2015 09:48 AM, Stefan Wahren wrote: > This patch adds root compatible properties for the following boards: > - Raspberry Pi Model B > - Raspberry Pi Model B+ We may as well add all the models while at it. I think the following is a complete list so far: "model-b-i2c0": early model B

Re: [PATCH 4/4] ARM: bcm2835: Use pinctrl header

2015-01-17 Thread Stephen Warren
On 01/16/2015 09:49 AM, Stefan Wahren wrote: > This patch converts all bcm2835 dts files to use the pinctrl > header file. Aside from the one comment I made, the series, Acked-by: Stephen Warren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Hi again, On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. Inline comments removed; > > chanptr > > comment is implied by the first argument being the channel. No parent

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Greg KH
On Sat, Jan 17, 2015 at 07:01:41PM -0800, Andrew Milkovich wrote: > Hi, > > On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: > > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > > > Fixed coding style errors per checkpatch.pl. Inline comments removed; > > > chanptr > >

[PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich --- drivers/staging/unisys/virtpci/virtpci.c | 24

Re: [PATCH] sysfs: group: allow is_visible to drop permissions

2015-01-17 Thread Greg Kroah-Hartman
On Sat, Jan 17, 2015 at 05:45:15PM -0800, Guenter Roeck wrote: > On 01/17/2015 02:09 PM, Vivien Didelot wrote: > >Hi Guenter, Greg, > > > [ .. ] > > > > >BTW Guenter, does this patch make sense to you? > > > > It does make sense to me to only use the return value from is_visible > for the mode.

[PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich --- drivers/staging/unisys/virtpci/virtpci.c | 24

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Joe Perches
On Sat, 2015-01-17 at 19:30 -0800, Andrew Milkovich wrote: > Fixed coding style errors per checkpatch.pl. which ones? As far as I can tell, none of the checkpatch warnings on this file are actually addressed by this patch. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
On Sat, Jan 17, 2015 at 08:01:52PM -0800, Joe Perches wrote: > On Sat, 2015-01-17 at 19:30 -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. > > which ones? > > As far as I can tell, none of the checkpatch > warnings on this file are actually addressed > by this

[PATCH] Staging: dgnc: fixed some coding style errors

2015-01-17 Thread Andrew Milkovich
This patch fixes the following checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses Outer parentheses were added to macro definitions. Signed-off-by: Andrew Milkovich --- drivers/staging/dgnc/digi.h | 60 ++--- 1 file

Re: [PATCH] Staging: dgnc: fixed some coding style errors

2015-01-17 Thread Andrew Milkovich
On Sat, Jan 17, 2015 at 09:09:08PM -0800, Andrew Milkovich wrote: > This patch fixes the following checkpatch.pl error: > ERROR: Macros with complex values should be enclosed in parentheses > Outer parentheses were added to macro definitions. > > Signed-off-by: Andrew Milkovich > --- >

Re: [PATCH 2/2] Drivers: Isdn: sc: Fixed coding style & spelling mistakes.

2015-01-17 Thread David Miller
From: Akash Shende Date: Fri, 16 Jan 2015 19:12:42 +0530 > Fix some spelling mistakes, coding style and don't assign value to static var. > > Signed-off-by: Akash Shende Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [net-next PATCH v3 1/1] atm: remove deprecated use of pci api

2015-01-17 Thread David Miller
From: chas williams - CONTRACTOR Date: Fri, 16 Jan 2015 08:57:21 -0500 > Signed-off-by: Chas Williams - CONTRACTOR Applied, thanks Chas. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v7 07/17] ARM64 / ACPI: Disable ACPI if FADT revision is less than 5.1

2015-01-17 Thread Hanjun Guo
On 2015年01月16日 22:33, Lorenzo Pieralisi wrote: On Wed, Jan 14, 2015 at 03:04:55PM +, Hanjun Guo wrote: FADT Major.Minor version was introduced in ACPI 5.1, it is the same as ACPI version. In ACPI 5.1, some major gaps are fixed for ARM, such as updates in MADT table for GIC and SMP init,

[GIT PULL] ARM: SoC fixes

2015-01-17 Thread Olof Johansson
Hi Linus, The following changes since commit eaa27f34e91a14cdceed26ed6c6793ec1d186115: linux 3.19-rc4 (2015-01-11 12:44:53 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git tags/armsoc-for-linus for you to fetch changes up to

3.18 regression: Error while assigning device slot ID, USB3 devices not detected

2015-01-17 Thread Robert Hancock
I've got an Intel Haswell-based system with a Gigabyte Z87X-D3H motherboard under Fedora 21. After updating to the 3.18.2-200 Fedora kernel, I noticed some errors in dmesg and at least some of my USB3 ports don't recognize any USB3 devices plugged into them: [0.560838] xhci_hcd

Re: [PATCH v7 06/17] ARM64 / ACPI: Make PCI optional for ACPI on ARM64

2015-01-17 Thread Hanjun Guo
On 2015年01月16日 17:49, Catalin Marinas wrote: On Wed, Jan 14, 2015 at 03:04:54PM +, Hanjun Guo wrote: Since PCI is not required in ACPI spec and ARM can run without it, introduce some stub functions to make PCI optional for ACPI, and make ACPI core run without CONFIG_PCI on ARM64. When PCI

Re: [RFC 1/3] i2c: Enhancement of i2c API to address circular lock dependency problem

2015-01-17 Thread Tomasz Figa
Hi, [CCing more people] 2015-01-16 23:39 GMT+09:00 Paul Osmialowski : > This enhancement of i2c API is designed to address following problem > caused by circular lock dependency: > > -> #1 (prepare_lock){+.+.+.}: > [2.730502][] __lock_acquire+0x3c0/0x8a4 > [2.735970][]

Re: [PATCH v7 06/17] ARM64 / ACPI: Make PCI optional for ACPI on ARM64

2015-01-17 Thread Jon Masters
Hi Folks, Sorry for top posting from bed. The mainstream servers will all likely do PCIe but there are several that may not. They should not be excluded. That said, if we booted a previously built kernel on a system without an MCFG and got no ECAM/root then things would probably still work. I

Re: [PATCH v7 00/17] Introduce ACPI for ARM64 based on ACPI 5.1

2015-01-17 Thread Hanjun Guo
On 2015年01月16日 18:10, Catalin Marinas wrote: On Thu, Jan 15, 2015 at 08:04:37PM +, Jason Cooper wrote: On Thu, Jan 15, 2015 at 07:02:20PM +, Mark Brown wrote: On Thu, Jan 15, 2015 at 06:23:47PM +, Catalin Marinas wrote: On Thu, Jan 15, 2015 at 04:26:20PM +, Grant Likely wrote:

Re: [PATCH v3] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2015-01-17 Thread Tristan Lelong
Hi Greg, On Sat, Jan 17, 2015 at 03:28:27PM -0800, Greg KH wrote: > > I took your v2 version, please send me the difference as this is a > mess... Not sure I understand what you meant here. Do you want me to submit a new patch that contains only the differences between v2 and v3? Thanks,

[PATCH 0/2] Added pci_mapping_error() call and related clean up

2015-01-17 Thread Tina Johnson
Replaced null test on dma handle with pci_dma_mapping_error() and cleaned up the error handling code. Tina Johnson (2): drivers: scsi: mpt2sas: Added pci_dma_mapping_error() call drivers: scsi: mpt2sas: Clean up error handling for calls to pci_map_single

[PATCH 2/2] drivers: scsi: mpt2sas: Clean up error handling for calls to pci_map_single

2015-01-17 Thread Tina Johnson
*Currently, the error handling code is organized to free dma_addr_out, dma_addr_in and then pci_addr_out, pci_addr_in. Since dma_addr_out and pci_addr_out are allocated first and then dma_addr_in and pci_addr_in, the error handling code is reorganized to free the in variables first and then

[PATCH 1/2] drivers: scsi: mpt2sas: Added pci_dma_mapping_error() call

2015-01-17 Thread Tina Johnson
Replaced null test on dma handle with pci_dma_mapping_error() o check for mapping errors. Coccinelle was used to find cases that do not check for dma mapping errors: @rule1@ statement S; identifier x; @@ *x = pci_map_single(...); if (!x) S Signed-off-by: Tina Johnson Acked-by: Julia Lawall

Re: [PATCH v7 06/17] ARM64 / ACPI: Make PCI optional for ACPI on ARM64

2015-01-17 Thread Hanjun Guo
On 2015年01月18日 14:31, Jon Masters wrote: Hi Folks, Sorry for top posting from bed. The mainstream servers will all likely do > PCIe but there are several that may not. They should not be excluded. That said, >if we booted a previously built kernel on a system without an MCFG and > got no

Re: [PATCH v3] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2015-01-17 Thread Greg KH
On Sat, Jan 17, 2015 at 10:41:44PM -0800, Tristan Lelong wrote: > Hi Greg, > > On Sat, Jan 17, 2015 at 03:28:27PM -0800, Greg KH wrote: > > > > I took your v2 version, please send me the difference as this is a > > mess... > > Not sure I understand what you meant here. > Do you want me to

Re: 3.18 regression: Error while assigning device slot ID, USB3 devices not detected

2015-01-17 Thread Greg KH
On Sun, Jan 18, 2015 at 12:08:18AM -0600, Robert Hancock wrote: > I've got an Intel Haswell-based system with a Gigabyte Z87X-D3H motherboard > under Fedora 21. After updating to the 3.18.2-200 Fedora kernel, I noticed > some errors in dmesg and at least some of my USB3 ports don't recognize any >

[PATCH] staging: wlan-ng: hfa384x_usb: fix sparse endianness warnings

2015-01-17 Thread Asaf Vertz
Fixed the following warnings (reported by sparse): drivers/staging/wlan-ng/hfa384x_usb.c:3828:36: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3229:16: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3430:18: warning: cast to restricted

[PATCH] MAINTAINERS: add Android driver entries

2015-01-17 Thread Greg KH
Put down me, Arve, and Riley as maintainers for the android drivers. Cc: Arve Hjønnevåg Cc: Riley Andrews Signed-off-by: Greg Kroah-Hartman diff --git a/MAINTAINERS b/MAINTAINERS index 3589d67437f8..95fd5c66ba09 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -708,6 +708,16 @@ X:

[PATCH] staging: lustre: remove kmalloc from fld_proc_hash_seq_write

2015-01-17 Thread Tristan Lelong
This patch simplifies the fld_proc_hash_seq_write function by removing the dynamic memory allocation. The longest fh_name used so far in lustre is 4 characters. We use a 8 bytes variable to be on the safe side. Signed-off-by: Tristan Lelong --- Hi Greg, This patch is a rework of "staging:

[PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-01-17 Thread Shirish Gajera
This patch fixes the checkpatch.pl warning: WARNING: line over 80 characters All line over 80 characters in driver/staging/speakup/* are fixed Signed-off-by: Shirish Gajera --- drivers/staging/speakup/main.c | 12 drivers/staging/speakup/serialio.h | 3 ++-

<    1   2   3   4   5