On 07/05/2015 at 14:38:39 +0100, Lee Jones wrote :
> Initial submission adding support for this IP only included Watchdog and
> the Real-Time Clock. Now the third (and final) device is enabled this
> trivial patch is required to update the comment in the RTC driver to
> encompass Clocksource.
>
On 5/9/2015 8:50 AM, Fengguang Wu wrote:
Hi Chris,
FYI, we noticed the below changes on
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
commit 952c8813073ed240a610f8b44ecea9bdd60b62b4 ("watchdog: add watchdog_cpumask
sysctl to assist nohz")
[...]
[0.079378] BUG:
Hi Peter,
On Fri, May 08, 2015 at 04:46:20PM +0200, Peter Zijlstra wrote:
> On Wed, Apr 29, 2015 at 08:58:22PM +0900, Namhyung Kim wrote:
> > > It would be nice if this thing could support 'perf record -s' which
> > > enables perf_event_attr::inherit_stat, which in turn results in
> > >
Hello, Vladimir
On Fri, May 08, 2015 at 12:56:04PM +0300, Vladimir Davydov wrote:
> On Mon, May 04, 2015 at 07:54:59PM +0900, Minchan Kim wrote:
> > So, I guess once below compiler optimization happens in
> > __page_set_anon_rmap,
> > it could be corrupt in page_refernced.
> >
> >
> From: Wu, Fengguang
> Sent: Saturday, May 09, 2015 5:31 AM
> To: Hansen, Dave
> Just in case this information will help: this patch adds one more warning
> message.
>
> https://github.com/hansendc/linux.git github-mpx
>
> commit 3701f7533ba43e0aec12bf2dffd49855499fa524
> [3.058044]
The 'perf record -s' and 'perf report -T' should be used together to see
per-thread event counts. Document the relation of these commands.
Signed-off-by: Namhyung Kim
---
tools/perf/Documentation/perf-record.txt | 3 ++-
tools/perf/Documentation/perf-report.txt | 3 ++-
2 files changed, 4
The -T/--thread option is supported only on --stdio mode (at least for
now). So enforce the tty output if the option was requested.
Signed-off-by: Namhyung Kim
---
tools/perf/builtin-report.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-report.c
It seems there's no reason to suppress per-thread event stat by -T
option when -s or -p option is used. Make it work with those options.
Signed-off-by: Namhyung Kim
---
tools/perf/builtin-report.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git
> Here is another warning bisected to the same commit.
>
> https://github.com/hansendc/linux.git github-mpx commit
> 4d90fc49c73730c09d7afd515f9c4e08d30229bd ("x86/xsaves: Define and use
> user_xstate_size for xstate size in signal context")
> [6.210858] WARNING: CPU: 3 PID: 168 at
> From: Wu, Fengguang
> Sent: Saturday, May 09, 2015 5:29 AM
> To: Hansen, Dave
> 0day kernel testing robot got the below dmesg and the first bad commit is
>
> https://github.com/hansendc/linux.git github-mpx
>
> commit 4d90fc49c73730c09d7afd515f9c4e08d30229bd
> [1.096425] Kernel panic - not
Since the ISA irqs are in a single block, use ISA_IRQ_VECTOR(irq)
instead of individual macros.
Signed-off-by: Brian Gerst
---
arch/x86/include/asm/irq_vectors.h | 18 +-
arch/x86/kernel/apic/io_apic.c | 4 ++--
arch/x86/kernel/apic/vector.c | 2 +-
The following are a few simple cleanups to the x86 IRQ code.
arch/x86/include/asm/hw_irq.h | 35 ---
arch/x86/include/asm/irq_vectors.h | 21 +
arch/x86/kernel/apic/io_apic.c | 4 ++--
arch/x86/kernel/apic/vector.c | 2 +-
Use IA32_SYSCALL_VECTOR for both compat and native.
Signed-off-by: Brian Gerst
---
arch/x86/include/asm/irq_vectors.h | 3 ---
arch/x86/kernel/traps.c| 4 ++--
arch/x86/lguest/boot.c | 4 ++--
3 files changed, 4 insertions(+), 7 deletions(-)
diff --git
The invalidate_interrupt* functions no longer exist.
Signed-off-by: Brian Gerst
---
arch/x86/include/asm/hw_irq.h | 35 ---
1 file changed, 35 deletions(-)
diff --git a/arch/x86/include/asm/hw_irq.h b/arch/x86/include/asm/hw_irq.h
index e9571dd..014c638 100644
Move irq_regs and irq_stat definitions to irq.c.
Signed-off-by: Brian Gerst
---
arch/x86/kernel/irq.c| 6 ++
arch/x86/kernel/irq_32.c | 6 --
arch/x86/kernel/irq_64.c | 6 --
3 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/arch/x86/kernel/irq.c
Hi!
> SANITIZE_FREED_PAGES feature relies on having all pages going through
> the free_pages_prepare path in order to be cleared before being used. In
> the hibernate use case, pages will automagically appear in the system
> without being cleared.
>
> This patch will make sure free pages are
This patch fix spelling typo in printk within nv10.c
Signed-off-by: Masanari Iida
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/nv10.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/nv10.c
Ingo Molnar writes:
> * Rik van Riel wrote:
>
>> On 05/08/2015 11:54 AM, Linus Torvalds wrote:
>> > On Fri, May 8, 2015 at 7:40 AM, John Stoffel wrote:
>> >>
>> >> Now go and look at your /home or /data/ or /work areas, where the
>> >> endusers are actually keeping their day to day work.
Hi,
On 06-05-15 11:31, Jens Kuske wrote:
Hi everyone,
This patch series introduces basic kernel support for Allwinner's H3 SoC,
mainly basic clocks and pinctrl. It also adds interrupts, timers,
watchdog, RTC, dmaengine, MMC and UARTs, which are mostly compatible to
those in earlier SoCs like
On Wed, Apr 22, 2015 at 04:26:50PM +0200, Matias Bj??rling wrote:
> LightNVM integrates on both sides of the block layer. The lower layer
> implements mapping of logical to physical addressing, while the layer
> above can string together multiple LightNVM devices and expose them as a
> single
This patch fix spelling typo in intel_runtime_pm.c
Signed-off-by: Masanari Iida
---
drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
b/drivers/gpu/drm/i915/intel_runtime_pm.c
index
On Wed, Apr 22, 2015 at 04:26:51PM +0200, Matias Bj??rling wrote:
> In preparation for Open-Channel SSDs. We introduce a special request for
> open-channel ssd targets that must perform garbage collection.
>
> Requests are divided into two types. The user and target specific. User
> IOs are from
From: Fabio Estevam
Bool initializations should use true and false. Bool tests don't need
comparisons. Based on contributions from Joe Perches, Rusty Russell
and Bruce W Allan.
The semantic patch that makes this change is available
in scripts/coccinelle/misc/boolinit.cocci.
More information
On 5/9/15 1:14 AM, Xi Wang wrote:
Extend the testcase to catch a signedness bug in the arm64 JIT:
test_bpf: #58 load 64-bit immediate jited:1 ret -1 != 1 FAIL (1 times)
This is useful to ensure other JITs won't have a similar bug.
Link: https://lkml.org/lkml/2015/5/8/458
Cc: Alexei
On 5/9/15 9:19 AM, Namhyung Kim wrote:
diff --git a/tools/perf/Documentation/perf-report.txt
b/tools/perf/Documentation/perf-report.txt
index 896672badba3..610e1e2cd035 100644
--- a/tools/perf/Documentation/perf-report.txt
+++ b/tools/perf/Documentation/perf-report.txt
@@ -34,7 +34,8 @@ OPTIONS
On Mon, May 04, 2015 at 03:11:18PM +0200, Peter Senna Tschudin wrote:
> As the first argument of gf_write64() was of type unsigned long, and as
> some calls to gf_write64() were casting the first argument from void *
> to u64 the compiler and/or sparse were printing warnings for casts of
> wrong
On Fri, May 01, 2015 at 11:08:35AM -0500, Felipe Balbi wrote:
> Hi Greg,
>
> Here's first pull request for this -rc series. Patches have been tested with
> platforms I have access to and have also been cooking in linux-next for
> a couple days.
>
> cheers
>
> The following changes since commit
On Sat, 09 May 2015 05:59:40 -0500 Dan Carpenter
wrote
> On Fri, May 08, 2015 at 06:29:24PM -0500, Jaime Arrocha wrote:
> > >From TODO list: remove test for host endian
> > Included header to gather information about host endianness.
> > Please let me know if the code
Vinod Koul writes:
> On Fri, May 08, 2015 at 02:28:37PM +0200, Robert Jarzmik wrote:
>> Sorry I don't get this comment, would you care to explain me please ?
> Right now you are using very genric names which can conflict with others, so
> makese sense to add PXA_DCMD_LENGTH with me lesser prone
On Sat, 09 May 2015 12:22:43 +0200
Mason wrote:
> Hello everyone,
>
> I'm writing a device driver for a serial-ish kind of device.
> I'm interested in the TX side of the problem. (I'm working on
> an ARM Cortex A9 system by the way.)
>
> There's a 16-byte TX FIFO. Data is queued to the FIFO by
I've had the same issue as described in commit
c68929f75dfcb6354918862b91b5778585de1fa5
Except my touchscreen's ID is
ID 04f3:0125 Elan Microelectronics Corp.
Signed-off-by: Logan Gunthorpe
---
drivers/usb/core/quirks.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
On Saturday, May 09, 2015 11:19:16 AM Preeti U Murthy wrote:
> Hi Rafael,
>
> On 05/08/2015 07:48 PM, Rafael J. Wysocki wrote:
> >> +/*
> >> + * find_tick_valid_state - select a state where tick does not stop
> >> + * @dev: cpuidle device for this cpu
> >> + * @drv: cpuidle driver for this cpu
>
On Saturday, May 09, 2015 08:46:20 PM Rafael J. Wysocki wrote:
> On Saturday, May 09, 2015 11:19:16 AM Preeti U Murthy wrote:
> > Hi Rafael,
> >
> > On 05/08/2015 07:48 PM, Rafael J. Wysocki wrote:
> > >> +/*
> > >> + * find_tick_valid_state - select a state where tick does not stop
> > >> + *
On Sat, May 9, 2015 at 1:45 AM, Ingo Molnar wrote:
>
> * Rik van Riel wrote:
>
>> On 05/08/2015 11:54 AM, Linus Torvalds wrote:
>> > On Fri, May 8, 2015 at 7:40 AM, John Stoffel wrote:
>> >>
>> >> Now go and look at your /home or /data/ or /work areas, where the
>> >> endusers are actually
The related warnings:
CALLscripts/checksyscalls.sh
:1238:2: warning: #warning syscall seccomp not implemented [-Wcpp]
:1241:2: warning: #warning syscall getrandom not implemented [-Wcpp]
:1244:2: warning: #warning syscall memfd_create not implemented [-Wcpp]
:1247:2: warning:
On Saturday 02 May 2015 14:30:57 Gabriele Mazzotta wrote:
> This driver adds the initial support for the ACPI Ambient Light Sensor
> as defined in Section 9.2 of the ACPI specification (Revision 5.0) [1].
>
> Sensors complying with the standard are exposed as ACPI devices with
> ACPI0008 as
On Sat, May 9, 2015 at 9:45 PM, Gabriele Mazzotta
wrote:
> On Saturday 02 May 2015 14:30:57 Gabriele Mazzotta wrote:
>> This driver adds the initial support for the ACPI Ambient Light Sensor
>> as defined in Section 9.2 of the ACPI specification (Revision 5.0) [1].
>>
>> Sensors complying with
* Vlastimil Babka (vba...@suse.cz) wrote:
> On 05/07/2015 08:09 PM, Dave Hansen wrote:
> >On 05/07/2015 10:57 AM, Ingo Molnar wrote:
> There are two new instructions (RDPKRU/WRPKRU) for reading and
> writing to the new register. The feature is only available in
> 64-bit mode, even
Signed-off-by: Gabriele Mazzotta
---
This patch fixes the issues of:
[PATCH v9] iio: acpi: Add support for ACPI0008 Ambient Light Sensor
Link:
http://lkml.kernel.org/g/1430569857-31386-1-git-send-email-gabriele@gmail.com
drivers/iio/light/Kconfig| 1 +
drivers/iio/light/acpi-als.c | 3
On Saturday, May 09, 2015 11:19:16 AM Preeti U Murthy wrote:
> Hi Rafael,
>
> On 05/08/2015 07:48 PM, Rafael J. Wysocki wrote:
[cut]
> >>
> >> + /* Take note of the planned idle state. */
> >> + idle_set_state(smp_processor_id(), target_state);
> >
> > And I wouldn't do this either.
> >
>
From: Markus Stenberg
Date: Tue, 5 May 2015 13:36:59 +0300
> If there are only IPv6 source specific default routes present, the
> host gets -ENETUNREACH on e.g. connect() because ip6_dst_lookup_tail
> calls ip6_route_output first, and given source address any, it fails,
> and ip6_route_get_saddr
On Fri, 8 May 2015, Rafael J. Wysocki wrote:
> My current view on that is that whether or not to do a sync() before
> suspending
> ultimately is a policy decision and should belong to user space as such
> (modulo
> the autosleep situation when user space may not know when the suspend is going
>
Linus,
please pull the latest timers-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
timers-urgent-for-linus
A simple fix to actually shut down a detached device instead of
letting it active.
Thanks,
tglx
-->
Viresh Kumar
Linus,
please pull the latest irq-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
irq-urgent-for-linus
Two patches from the irq departement:
- A simple fix to make dummy_irq_chip usable for wakeup scenarios
- Removal of the gic arch_extn
From: Sowmini Varadhan
Date: Tue, 5 May 2015 15:20:50 -0400
>
> This patch-set contains bug fixes for state-recovery at the RDS
> layer when the underlying transport is TCP and the TCP state at one
> of the endpoints is reset
>
> V2 changes: DaveM comments to reduce memory footprint, follow
From: Nathan Sullivan
Date: Tue, 5 May 2015 15:00:25 -0500
> The same hardware issue the at91 must work around applies to at least the
> Zynq ethernet, and possibly more devices. The driver also needs to handle
> the RXUBR interrupt since it turns it on with MACB_RX_INT_FLAGS anyway.
>
>
The irq chip functions use the irq chipdata directly as the base register
address of the controller, so this should be passed in instead of a pointer
to the array address holding the base address.
This fixes Tegra20 CPUidle as now the un-/masking of IRQs at the LIC level
works again, but more
On Saturday, May 09, 2015 10:11:41 PM Rafael J. Wysocki wrote:
> On Saturday, May 09, 2015 11:19:16 AM Preeti U Murthy wrote:
> > Hi Rafael,
> >
> > On 05/08/2015 07:48 PM, Rafael J. Wysocki wrote:
>
> [cut]
>
> > >>
> > >> +/* Take note of the planned idle state. */
> > >> +
Since the function auth_parse returns a u16, and
struct rtllib_authentication.status is defined as an __le16, it seems
that
return cpu_to_le16(a->status);
should be
return le16_to_cpu(a->status);
This change silences the following sparse warnings:
On Sat, 09 May 2015, Alan Stern wrote:
> On Fri, 8 May 2015, Rafael J. Wysocki wrote:
> > My current view on that is that whether or not to do a sync() before
> > suspending
> > ultimately is a policy decision and should belong to user space as such
> > (modulo
> > the autosleep situation when
Since the function auth_parse returns a u16, and
struct rtllib_authentication.status is defined as an __le16, it seems
that
return cpu_to_le16(a->status);
should be
return le16_to_cpu(a->status);
This change silences the following sparse warnings:
This adds the helper irq_domain_set_info() in a non-domain hierarchy
variant. This allows to use the helper for generic chip since not
all chips using generic chip support domain hierarchy.
Signed-off-by: Stefan Agner
---
include/linux/irqdomain.h | 8
kernel/irq/irqdomain.c| 21
Vybrids has 112 peripherial interrupts which can be routed to the
Cortex-M4's NVIC interrupt controller.
Signed-off-by: Stefan Agner
---
arch/arm/mm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
index 3937af0..527ea03 100644
---
This adds an initial device tree to run Linux on the Cortex-M4 on
the Vybrid based Colibri VF61 module.
Signed-off-by: Stefan Agner
---
arch/arm/boot/dts/Makefile| 1 +
arch/arm/boot/dts/vf610m4-colibri.dts | 99 +++
arch/arm/boot/dts/vf610m4.dtsi
Add defconfig for Linux on Vybrid (vf610) on the secondary Cortex-
M4 CPU. The use of a XIP image has been tested which needs to be
loaded (e.g. using the custom m4boot loader) to the end of the
available RAM at address 0x8f00. The Cortex-M4 has a code-alias
which makes sure that the
This patch allows to build the Kernel for Vybrid (VF6xx) SoC
when ARMv7-M CPU is selected. The resulting image runs on the
secondary Cortex-M4 core. This core has equally access to all
peripherals as the main Cortex-A5 core. However, there is no
resource control mechanism, hence when both cores
Use the new config symbol ARM_SINGLE_ARMV7M which groups config
symbols used by modern ARMv7-M platforms. It also support multiple
ARMv7-M platforms in one kernel image. However, this only works if
the combined platforms share the same (main) memory layout.
Signed-off-by: Stefan Agner
---
Add support for hierarchy irq domains. This is required to stack
the MSCM interrupt router and the NVIC controller found in Vybrid
SoC.
Signed-off-by: Stefan Agner
---
drivers/irqchip/Kconfig| 1 +
drivers/irqchip/irq-nvic.c | 28 +++-
2 files changed, 28
This introduces a new top level config symbol ARM_SINGLE_ARMV7M
for non-MMU, ARMv7-M platforms. It also support multiple ARMv7-M
platforms in one kernel image since the cores share the same
basic memory layout and interrupt controller. However, this works
only if the combined platforms also have a
Remove the needless differences between MMU/!MMU addruart calls.
This allows to use the same addruart macro on SoC level. Useful
for SoC consisting of multiple CPUs with and without MMU such as
Freescale Vybrid.
Signed-off-by: Stefan Agner
---
arch/arm/include/debug/efm32.S | 2 +-
Add the minimal dependencies required to use the Vybrid PIT
clocksource driver. Those are not part of the SoC dependencies.
Acked-by: Daniel Lezcano
Signed-off-by: Stefan Agner
---
drivers/clocksource/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clocksource/Kconfig
Use the new helper function irq_domain_set_info to make sure the
function irq_domain_set_hwirq_and_chip is being called, which is
crucial to save irqdomain specific data to irq_data.
Signed-off-by: Stefan Agner
---
kernel/irq/generic-chip.c | 5 ++---
1 file changed, 2 insertions(+), 3
It took me a bit longer than expected to come up with the 6th
revision of the patchset. Support for irq domain hierarchy
for generic chip turned out to be not as easy as thought, the
changes lead to build errors when building without domain
hierarchy, sorry about that Jason.
However, in this
The following changes since commit 5ebe6afaf0057ac3eaeb98defd5456894b446d22:
Linux 4.1-rc2 (2015-05-03 19:22:23 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git
tags/fixes-for-linus
for you to fetch changes up to
Support the NVIC interrupt controller as node parent of the MSCM
interrupt router. On the dual-core variants of Vybird (VF6xx), the
NVIC interrupt controller is used by the Cortex-M4. To support
running Linux on this core too, MSCM needs NVIC parent support too.
Signed-off-by: Stefan Agner
---
From: Tony Camuso
Date: Wed, 6 May 2015 09:09:18 -0400
> This patch should have been part of the previous patch having the
> same summary. See http://marc.info/?l=linux-kernel=143039470103795=2
> Unfortunately, I didn't check to see where else this lock was used before
> submitting that patch.
One Thousand Gnomes wrote:
> Mason wrote:
>
>> I'm writing a device driver for a serial-ish kind of device.
>> I'm interested in the TX side of the problem. (I'm working on
>> an ARM Cortex A9 system by the way.)
>>
>> There's a 16-byte TX FIFO. Data is queued to the FIFO by writing
>> {1,2,4}
This enables the ethtool's "-d" and "--register-dump"
options for fec devices.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet/freescale/fec_main.c | 24
1 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
According to the imx27 documentation, fec has a 1 Kbyte
memory space map, spitted in two regions of 512 bytes.
The first one for control/status registers, and the
second one for event/statistic registers. So, we don't
need to map 16 Kbyte for registers, 1 Kbyte is enough.
Signed-off-by: Philippe
The related warnings:
CALLscripts/checksyscalls.sh
:1229:2: warning: #warning syscall sched_setattr not implemented
[-Wcpp]
:1232:2: warning: #warning syscall sched_getattr not implemented
[-Wcpp]
:1235:2: warning: #warning syscall renameat2 not implemented [-Wcpp]
:1238:2:
On 05/09/2015 10:14 AM, Xi Wang wrote:
Extend the testcase to catch a signedness bug in the arm64 JIT:
test_bpf: #58 load 64-bit immediate jited:1 ret -1 != 1 FAIL (1 times)
This is useful to ensure other JITs won't have a similar bug.
Link: https://lkml.org/lkml/2015/5/8/458
Cc: Alexei
On Sat, May 09, 2015 at 02:17:39AM -0700, Andi Kleen wrote:
> On Sat, May 09, 2015 at 12:45:01AM +0200, Rasmus Villemoes wrote:
> > attribute((cold)) causes gcc to optimize the function for size rather
> > than speed. But since __init functions will be discarded anyway, I
> > don't see why memory
On Sat, May 09, 2015 at 10:52:08PM +0200, Philippe Reynes wrote:
> +static void fec_enet_get_regs(struct net_device *ndev,
> + struct ethtool_regs *regs, void *regbuf)
> +{
> + struct fec_enet_private *fep = netdev_priv(ndev);
> +
> + memcpy_fromio(regbuf,
This series applies some of review comments by Dan (thanks!) as well as does
further cleanups.
Further series will probably focus more on changing driver architecture into
something that may get accepted into -wireless.
This series should apply cleanly to staging-testing(7192a5dd5)
branches.
One
Use pr_debug() instead.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_module.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
Remove the following private variables:
- force_mic_error - changes force_mic_error that is not used
- radio - changes sw_radio_on that is not used
- adhoc_peer_list - unimplemented
- firm_ver - unimplemented
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c |
Replace all RTLLIB_DEBUG(RTLLIB_DL_ERR, *) calls with netdev_err()
for errors that really should be reported to user.
Use netdev_warn() for the rest.
Rephrase some of the messages to make them more readable/compact.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_BAProc.c
Take out MIFE_TYPE_HT_CAP processing into separate function -
rtllib_parse_mfie_ht_cap()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 49 +---
1 file changed, 29 insertions(+), 20 deletions(-)
diff --git
This header is not used - remove it to make driver code smaller.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_crypto.h | 382 -
1 file changed, 382 deletions(-)
delete mode 100644 drivers/staging/rtl8192e/rtl8192e/rtl_crypto.h
diff --git
Improve readability and make checkpatch happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b/drivers/staging/rtl8192e/rtllib_rx.c
index 2b337c4..5a08935
Reindent lines to make checkpatch happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 83 +++---
drivers/staging/rtl8192e/rtllib_rx.c | 18 ---
2 files changed, 65 insertions(+), 36 deletions(-)
diff --git
WOL capability was reported in an awkward way - print it nicely.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_pm.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_pm.c
This function never supported checking of MAC block.
Instead of printing several warnings - print it once and exit.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git
Remove alloc failed messages where not needed to make checkpatch.pl happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c
- Pass extra argument (rtllib_device) to rtllib_parse_qos_info_param_IE()
and update_network()
- Replace RTLLIB_DEBUG_QOS() with netdev_dbg()
- Remove RTLLIB_DEBUG_QOS()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_rx.c |
- Use netdev_* with log level depending on how serious error is
- Rework some messages to be more readable
- Pass net_device where needed for pretty prints
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 24 +++--
This messages are not needed, as failure is reported earlier in code.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 1 -
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 1 -
2 files changed, 2 deletions(-)
diff --git
Fix most of remaining PREFER_PR_LEVEL warnings in rtllib.
Replace printk() with netdev_* if possible, pr_* in other cases.
All pr_* use __func__ to easily trace message back to rtllib
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-
Warninig is printed if precision is lost - it can't happen at moment as
all get_key implementations return either -1 or small buffers.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_wx.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
Replace :? with min_t for readability. Remove check that is always false.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_softmac_wx.c | 8 +---
drivers/staging/rtl8192e/rtllib_wx.c | 3 +--
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git
Fix most of simple LONG_LINE warnings. None of the changes should affect
behaviour of code, so several modifications are included in this patch:
- Code is reindented where needed
- Local variable names are compacted (priv -> p)
- Unnecessary casts are removed
- Nested ifs are replaced with logical
Add __aligned(2) into ethernet addresses allocated on stack or in non-packed
structures. Use ETH_ALEN as array length in places where it was hardcoded to 6.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 ++-
Use netdev_dbg() instead.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 6
drivers/staging/rtl8192e/rtllib_rx.c | 58
drivers/staging/rtl8192e/rtllib_tx.c | 5 ++--
3 files changed, 35 insertions(+), 34 deletions(-)
Assert macro printed warning message (and was used once).
Remove it, and add netdev_warn() in place where it was called.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 5 +++--
drivers/staging/rtl8192e/rtllib_debug.h | 8
2 files changed, 3
Remove rest of rtllib "debug" system - it is no longer used -
proper netdev_* functions are used in most cases.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 45 --
drivers/staging/rtl8192e/rtllib_module.c | 55
Use print_hex_dump_bytes() if VERBOSE_DEBUG is enabled.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 20
drivers/staging/rtl8192e/rtl819x_HTProc.c | 7 +--
drivers/staging/rtl8192e/rtllib.h | 11 ---
- Use netdev_dbg() instead of RTLLIB_DEBUG_MGMT()
- Remove RTLLIB_DEBUG_MGMT()
- Pass net_device to auth_parse(), auth_rq_parse() and assoc_rq_parse()
- Remove duplicated messages
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h | 2 -
- Use netdev_dbg or netdev_vdbg instead of RTLLIB_DEBUG()
- Reformat some messages for better readability
- Remove RTLLIB_DEBUG messages that make no sense
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 35 +
Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
Code was not altered significantly, therefore in some places it generates
LONG_LINE checkpatch.pl warnings.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 364
Use netdev_dbg() instead, remove duplicated logs.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_rx.c | 101 ---
drivers/staging/rtl8192e/rtllib_wx.c | 12 +++--
3 files changed, 54
301 - 400 of 444 matches
Mail list logo