Re: [PATCH] timer: Lazily wakup nohz CPU when adding new timer.

On Mon, 28 Sep 2015, Yunhong Jiang wrote: > static void internal_add_timer(struct tvec_base *base, struct timer_list > *timer) > { > + bool kick_nohz = false; > + > /* Advance base->jiffies, if the base is empty */ > if (!base->all_timers++) > base->timer_jiffies =

Re: [RFC PATCH 0/2] VFIO no-iommu

On Sun, 2015-10-11 at 17:29 +, Varun Sethi wrote: > Hi Alex, > Thanks for the patch Alex. This would also require support in Qemu to expose > the physical address to the VM. Are you looking at that part as well? Quoting from below: It should be obvious, but I always feel obligated

Re: [RFC PATCH 0/2] VFIO no-iommu

On Fri, Oct 09, 2015 at 12:40:56PM -0600, Alex Williamson wrote: > Recent patches for UIO have been attempting to add MSI/X support, > which unfortunately implies DMA support, which users have been > enabling anyway, but was never intended for UIO. VFIO on the other > hand expects an IOMMU to

Re: [RFC PATCH 0/2] VFIO no-iommu

On Sun, Oct 11, 2015 at 09:28:09PM +0300, Michael S. Tsirkin wrote: > On Fri, Oct 09, 2015 at 12:40:56PM -0600, Alex Williamson wrote: > > Recent patches for UIO have been attempting to add MSI/X support, > > which unfortunately implies DMA support, which users have been > > enabling anyway, but

Re: [RFC] nohz: no update idle entry time on get_cpu_idle/iowait_time_us()

On Mon, 28 Sep 2015, Yunhong Jiang wrote: > Currently the get_cpu_idle/iowait_time_us() updates the idle_entrytime. > When it's invoked from another CPU and the target CPU has been on idle > already, it will update the idle_entrytime to now, which is incorrect. > > However, the

Linux 4.3-rc5

The 4.3 release cycle continues to be fairly smooth - knock wood. There's nothing particularly worrying here: we had some annoying fallout from the new strscpy stuff (it's not actually *used* anywhere yet, but we had build failures on some architectures), and a vfs layer change uncovered an

Re: [PATCH 1/3] sched: select_task_rq() should check cpu_active() like select_fallback_rq()

On Sun, 11 Oct 2015, Oleg Nesterov wrote: > On 10/10, Oleg Nesterov wrote: > > > > I do not understand the cpu_active() check in select_fallback_rq(). > > x86 doesn't need it, and the recent commit dd9d3843755d "sched: Fix > > cpu_active_mask/cpu_online_mask race" documents the fact that on any >

Re: [PATCH 1/6] mmput: use notifier chain to call subsystem exit handler.

On Tue, 2014-07-08 at 13:03 -0400, Jerome Glisse wrote: > > Now regarding the device side, if we were to cleanup inside the file release > callback than we would be broken in front of fork. Imagine the following : > - process A open device file and mirror its address space (hmm or kfd) >

Re: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

On Sun, 11 Oct, at 02:28:30PM, Kweh Hock Leong wrote: > > -Original Message- > > From: Matt Fleming [mailto:m...@console-pimps.org] > > Sent: Sunday, October 11, 2015 6:02 AM > > > > I agree that it makes sense to fold this patch into your PATCH 2, because > > then > > we know why we

[tip:x86/platform] x86/intel-mid: Make intel_mid_ops static

Commit-ID: d1f0f6c72c14af8a27a6549e0623f7cd61805e83 Gitweb: http://git.kernel.org/tip/d1f0f6c72c14af8a27a6549e0623f7cd61805e83 Author: Andy Shevchenko AuthorDate: Fri, 9 Oct 2015 17:25:41 +0300 Committer: Thomas Gleixner CommitDate: Sun, 11 Oct 2015 21:03:12 +0200 x86/intel-mid: Make

[tip:x86/cpufeature] x86/cpu/intel: Enable X86_FEATURE_NONSTOP_TSC_S3 for Merrifield

Commit-ID: 1cc0166752d598a69f6bb99381d828cbfb5fa9a5 Gitweb: http://git.kernel.org/tip/1cc0166752d598a69f6bb99381d828cbfb5fa9a5 Author: Andy Shevchenko AuthorDate: Thu, 8 Oct 2015 18:56:26 +0300 Committer: Thomas Gleixner CommitDate: Sun, 11 Oct 2015 21:07:26 +0200 x86/cpu/intel:

[tip:x86/apic] x86/io_apic: Make eoi_ioapic_pin() static

Commit-ID: 4faefda97bc1be6ca909ba0fd0927ea78f37f67e Gitweb: http://git.kernel.org/tip/4faefda97bc1be6ca909ba0fd0927ea78f37f67e Author: Andy Shevchenko AuthorDate: Fri, 9 Oct 2015 17:24:45 +0300 Committer: Thomas Gleixner CommitDate: Sun, 11 Oct 2015 21:10:31 +0200 x86/io_apic: Make

Re: [PATCH v4] scsi: ufs: add ioctl interface for query request

On Sunday 11 October 2015 14:22:12 Yaniv Gardi wrote: > * @cookie: cookie data > @@ -5106,6 +5308,10 @@ static struct scsi_host_template > ufshcd_driver_template = { > .eh_device_reset_handler = ufshcd_eh_device_reset_handler, > .eh_host_reset_handler =

Re: [PATCH v3] scsi: ufs: add ioctl interface for query request

On Sunday 11 October 2015 11:02:34 yga...@codeaurora.org wrote: > > > > no need for the #ifdef here. > > in include\scsi\scsi_host.h > the hook - compat_ioctl is defined inside #ifdef CONFIG_COMPAT > > #ifdef CONFIG_COMPAT > int (* compat_ioctl)(struct scsi_device *dev, int cmd, void

Re: [PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG

On 5 October 2015 at 10:22, Daniel Thompson wrote: > On 4 October 2015 at 11:32, Linus Walleij wrote: >> On Sat, Oct 3, 2015 at 10:35 PM, Daniel Thompson >> 3. I took out the datasheet for Nomadik STn8820 and it seems that >> the hardware is very similar to what this driver is trying to drive.

Re: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for IO

Andy, On Fri, 9 Oct 2015, Andy Shevchenko wrote: > #ifdef CONFIG_PCI > static void mem32_serial_out(unsigned long addr, int offset, int value) > { > - u32 *vaddr = (u32 *)addr; > + void __iomem *vaddr = (void __iomem *)addr; > /* shift implied by pointer type */ >

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Felipe Balbi wrote: > Clemens Ladisch writes: >> Felipe Tonello wrote: >>> req->actual == req->length means that there is no data left to enqueue, >> >> This condition is not checked in the patch. >> >>> so free the request. >>> >>> Signed-off-by: Felipe F. Tonello >>> --- >>>

Re: [PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG

On 5 October 2015 at 10:22, Daniel Thompson wrote: > On 4 October 2015 at 11:32, Linus Walleij wrote: >> On Sat, Oct 3, 2015 at 10:35 PM, Daniel Thompson >> wrote: >> Then this construct: >> >>> +static int stm32_rng_read(struct hwrng *rng, void *data, size_t max, bool >>> wait) >>> +{ >>

Re: [RFC PATCH 0/2] VFIO no-iommu

On Sun, 2015-10-11 at 21:29 +0300, Michael S. Tsirkin wrote: > On Sun, Oct 11, 2015 at 09:28:09PM +0300, Michael S. Tsirkin wrote: > > On Fri, Oct 09, 2015 at 12:40:56PM -0600, Alex Williamson wrote: > > > Recent patches for UIO have been attempting to add MSI/X support, > > > which unfortunately

Re: [PATCH] x86: Fix thermal throttling reporting after kexec

Andi, On Fri, 2 Oct 2015, Thomas Gleixner wrote: > On Thu, 1 Oct 2015, Andi Kleen wrote: > > On Thu, Oct 01, 2015 at 11:50:00PM +0200, Andi Kleen wrote: > > > > I see it under the correctness aspect. Mop up before you shut down. > > > > > > Ok. I suspect if you want to clean up all registers

Re: [patch] sched: disable task group re-weighting on the desktop

Dear Mike, Did you check whether setting min_- and max_interval e.g. as per https://lkml.org/lkml/2015/10/11/34 would help with your issue (instead of your "horrible gs destroying" patch)? Cheers, Paul Paul Szabo p...@maths.usyd.edu.au http://www.maths.usyd.edu.au/u/psz/ School of

Re: [PATCH V15 00/11] x86: Intel Cache Allocation Technology Support

Fenghua, On Thu, 1 Oct 2015, Fenghua Yu wrote: +Cc: Marcelo > This series has some preparatory patches and Intel cache allocation > support. > Changes in v15: > - Add a global IPI to update the closid on CPUs for current tasks. > - Other minor changes where I remove the updating of

Re: [PATCH V2 0/5] x86: Intel Code Data Prioritization Support

On Thu, 1 Oct 2015, Fenghua Yu wrote: > This patch set supports Intel code data prioritization which is an > extension of cache allocation and allows to allocate code and data cache > seperately. It also includes cgroup interface for the user as seperate > patches. The cgroup interface for cache

Re: [PATCH] kref: prefer atomic_inc_not_zero to atomic_add_unless

Reviewed-by: Thomas Hellstrom On 10/10/2015 12:56 PM, Jason A. Donenfeld wrote: > On most platforms, there exists this ifdef: > > #define atomic_inc_not_zero(v) atomic_add_unless((v), 1, 0) > > This makes this patch functionally useless. However, on PPC, there is > actually an explicit

Re: [PATCH v3 1/5] mtd: mtdpart: add debug prints to partition parser.

On Tue, Aug 18, 2015 at 03:34:07PM -, Michal Suchanek wrote: > The probe of a mtd device can fail when a partition parser returns > error. The failure due to partition parsing can be quite mysterious when > multiple partitioning schemes are comiled in and any of them can fail > the probe. > >

Re: [PATCH v4 1/5] mtd: nand: Create a BBT flag to access bad block markers in raw mode

Hi Boris, On Fri, Oct 02, 2015 at 08:27:38AM +0200, Boris Brezillon wrote: > Brian, Archit, > > On Thu, 1 Oct 2015 19:44:34 -0700 > Brian Norris wrote: > > > On Wed, Aug 19, 2015 at 10:19:02AM +0530, Archit Taneja wrote: > > > Some controllers can access the factory bad block marker from OOB

Re: [PATCH v3 2/5] mtd: mtdpart: Do not fail mtd probe when parsing partitions fails.

Hi Michal, Sorry for the very long waits here. Unfortunately, I've been saying that a lot lately, as I haven't had a lot of time and have generated a lot of backlog. I really like that you've been working on this though, since there are definitely problems here. On Tue, Aug 18, 2015 at

Re: [PATCH v3 3/5] mtd: ofpart: update devicetree binding specification

Hi DT maintainers, It's a bit hypocritical of me, since I've been a slow reviewer as well, but... can we get some review on this one? Usually, I'm comfortable taking driver DT bindings without your review, but this one is a bit more generic and is more far-reaching than the average driver. I'm

Re: [PATCH v3 4/5] mtd: ofpart: document the lock flag.

On Tue, Aug 18, 2015 at 03:34:08PM -, Michal Suchanek wrote: > The lock flag of ofpart is undocumented. Add to binding doc. Good catch. There are a lot of small corners of very old code that never really got reviewed properly, I expect... (And the flag looks very odd. Why exactly is it in

Re: [PATCH v4 00/26] ARM: pxa: magician: Rework HTC Magician support

Robert Jarzmik writes: > Petr Cvek writes: > >>> Thanks (a pozdrav :-), >>> >>> Pavel > Hi Petr, > > I'll start applying part of this serie today evening (my evening). > All Philipp's acked patches for a start. > > For the minor

Re: [RFC v6 00/25] Re-use nvram module

On 23/08/2015 12:41, Finn Thain wrote: > The generic NVRAM module, drivers/char/generic_nvram, implements a > /dev/nvram misc device. It is used only by 32-bit PowerPC platforms and > isn't generic enough to be more widely used. > > The RTC NVRAM module, drivers/char/nvram, also implements a

[tip:timers/core] clock: Remove return statement from void functions

Commit-ID: 784e452870c028a03e42af3bd437ec45a88dfe6d Gitweb: http://git.kernel.org/tip/784e452870c028a03e42af3bd437ec45a88dfe6d Author: Guillaume Gomez AuthorDate: Wed, 23 Sep 2015 13:19:19 +0200 Committer: Thomas Gleixner CommitDate: Sun, 11 Oct 2015 22:07:23 +0200 clock: Remove

[tip:timers/core] timers: Use __fls in apply_slack()

Commit-ID: 3e17510cbc3e75cae0c96fa38ca469ffe754aedf Gitweb: http://git.kernel.org/tip/3e17510cbc3e75cae0c96fa38ca469ffe754aedf Author: Rasmus Villemoes AuthorDate: Fri, 2 Oct 2015 09:45:30 +0200 Committer: Thomas Gleixner CommitDate: Sun, 11 Oct 2015 22:07:23 +0200 timers: Use __fls

Re: [PATCH] clock: Remove unneeded return statement from void

On Wed, 23 Sep 2015, Guillaume Gomez wrote: FYI, the proper subsystem is clocksource not clock > Signed-off-by: Guillaume Gomez > --- > kernel/time/clocksource.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c

[tip:timers/core] clocksource: Remove return statement from void functions

Commit-ID: cfed432d7f4114e16e0163bcfe65e96f0c304493 Gitweb: http://git.kernel.org/tip/cfed432d7f4114e16e0163bcfe65e96f0c304493 Author: Guillaume Gomez AuthorDate: Wed, 23 Sep 2015 13:19:19 +0200 Committer: Thomas Gleixner CommitDate: Sun, 11 Oct 2015 22:13:46 +0200 clocksource: Remove

[tip:timers/core] timers: Use __fls in apply_slack()

Commit-ID: 9fc4468d546b6eb55b0aa5b04b0c36238ebf57e7 Gitweb: http://git.kernel.org/tip/9fc4468d546b6eb55b0aa5b04b0c36238ebf57e7 Author: Rasmus Villemoes AuthorDate: Fri, 2 Oct 2015 09:45:30 +0200 Committer: Thomas Gleixner CommitDate: Sun, 11 Oct 2015 22:13:46 +0200 timers: Use __fls

Re: [PATCH, resend 1/1] x86/kernel: re-use %*ph specifier

On Fri, 2 Oct 2015, Andy Shevchenko wrote: > %*ph specifier allows to dump data in hex format using the poiter to a buffer. > This is suitable to use here. > > Signed-off-by: Andy Shevchenko > --- > arch/x86/kernel/jump_label.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

[PATCH] powerpc/numa: Use of_get_next_parent to simplify code

of_get_next_parent can be used to simplify the while() loop and avoid the need of a temp variable. Signed-off-by: Christophe JAILLET --- arch/powerpc/mm/numa.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index

[PATCH] powerpc/mpc5xxx: Use of_get_next_parent to simplify code

of_get_next_parent can be used to simplify the while() loop and avoid the need of a temp variable. Signed-off-by: Christophe JAILLET --- arch/powerpc/sysdev/mpc5xxx_clocks.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/powerpc/sysdev/mpc5xxx_clocks.c

Re: [PATCH] sched_clock: add data pointer argument to read callback

Mans, On Fri, 9 Oct 2015, Mans Rullgard wrote: > This passes a data pointer specified in the sched_clock_register() > call to the read callback allowing simpler implementations thereof. > > In this patch, existing uses of this interface are simply updated > with a null pointer. I can't see any

Re: [PATCH] powerpc/mpc5xxx: Use of_get_next_parent to simplify code

On Sun, 11 Oct 2015, Christophe JAILLET wrote: > of_get_next_parent can be used to simplify the while() loop and > avoid the need of a temp variable. Can you do something with the loop in __of_translate_address, in drivers/of/address.c? Is there not an iterator for this? julia > >

[PATCH net-next] RDS: Invoke ->laddr_check() in rds_bind() for explicitly bound transports.

The IP address passed to rds_bind() should be vetted by the transport's ->laddr_check() for a previously bound transport. This needs to be done to avoid cases where, for example, the application has asked for an IB transport, but the IP address passed to bind is only usable on ethernet

[PATCH net-next] RDS-TCP: Reset tcp callbacks if re-using an outgoing socket in rds_tcp_accept_one()

Consider the following "duelling syn" sequence between two peers A and B: A B SYN1 --> <-- SYN2 SYN2ACK --> Note that the SYN/ACK has already been sent out by TCP before rds_tcp_accept_one() gets

Re: CFS scheduler unfairly prefers pinned tasks

I wrote: The Linux CFS scheduler prefers pinned tasks and unfairly gives more CPU time to tasks that have set CPU affinity. ... I believe I have now solved the problem, simply by setting: for n in /proc/sys/kernel/sched_domain/cpu*/domain0/min_interval; do echo 0 > $n; done for n

Re: [PATCH 00/16] Divorcing irqdomain and device_node

On Tue, 6 Oct 2015, Marc Zyngier wrote: > [This patch series used to be called "Making the generic ACPI GSI > layer irqdomain aware", but as I've radically changed my approach to > this problem, I've decided to reset the counters...] > > The irqdomain code is not entierely ACPI friendly, as it

[PATCH v4 2/2] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO

Add a device tree binding for Freescale MPC512x LocalPlus Bus FIFO and introduce the document describing that binding. Signed-off-by: Alexander Popov --- .../bindings/powerpc/fsl/mpc512x_lpbfifo.txt| 21 + arch/powerpc/boot/dts/mpc5121.dtsi | 11

[PATCH v4 0/2] powerpc/512x: add LocalPlus Bus FIFO device driver

This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC in the Reference Manual) allows Direct Memory Access transfers between RAM and peripheral devices on LocalPlus Bus. Changes in v3: - resource usage in probe() is fixed; - driver methods are made safe against remove(); -

[PATCH v4 1/2] powerpc/512x: add LocalPlus Bus FIFO device driver

This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC in the Reference Manual) allows Direct Memory Access transfers between RAM and peripheral devices on LocalPlus Bus. Signed-off-by: Alexander Popov --- arch/powerpc/configs/mpc512x_defconfig| 1 +

Re: [PATCH v2] misc: mic: replace kfree with put_device

On Sun, Oct 04 2015 at 05:33:47 PM, Geliang Tang wrote: > Handle a failed device_register(), replace kfree() with put_device(), > which will call mbus_release_dev() or scif_release_dev(). Could you add the same change to cosm_bus.c too in the same path and resubmit the patch. Thanks. -- To

Re: [RFC PATCH 2/2] vfio: Include no-iommu mode

On Sun, 2015-10-11 at 11:12 +0300, Avi Kivity wrote: > > On 10/09/2015 09:41 PM, Alex Williamson wrote: > > There is really no way to safely give a user full access to a PCI > > without an IOMMU to protect the host from errant DMA. There is also > > no way to provide DMA translation, for use

[PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values

Sending ICMP packets with raw sockets ends up in the SNMP counters logging the type as the first byte of the IPv4 header rather than the ICMP header (in nearly all cases this is seen as "OutType69". This is fixed by adding the IP Header Length to the casting into a icmphdr struct. Signed-off-by:

Re: [PATCH] Documentation/email-clients.txt: remove trailing whitespace

On Tue, 29 Sep 2015 14:15:33 +0100 Luis de Bethencourt wrote: > While reading Documentation/email-clients.txt to configure my email > client for Linux kernel development I noticed one of the recent changes > in the Thunderbird section has a trailing whitespace. Applied to the docs tree, thanks.

Re: [PATCH] Doc:kvm: Fix typo in Doc/virtual/kvm

On Sun, 4 Oct 2015 00:46:21 +0900 Masanari Iida wrote: > This patch fix spelling typos in Documentation/virtual/kvm. Applied to the docs tree, thanks. jon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] Typo correction for description in gpio document.

On Tue, 6 Oct 2015 23:54:55 +0530 Sachin Pandhare wrote: > Corrected Documentation/gpio/sysfs.txt for typos and wording. > typos: syfs -> sysfs, manges -> manages > wording: entry -> entries Applied to the docs tree, thanks. jon -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] doc: Clarify that nmi_watchdog param is for hardlockups

On Sat, 10 Oct 2015 15:40:42 -0400 Pranith Kumar wrote: > The kernel NMI watchdog acts as both a hardlockup and softlockup detector. > However, the kernel parameter nmi_watchdog can only enable or disable the > hardlockup detector. Clarify that in the documentation. Applied to the docs tree,

[PATCH net-next 2/4] net: dsa: mv88e6xxx: do not support per-port FID

Since we configure a switch chip through a Linux bridge, and a bridge is implemented as a VLAN, there is no need for per-port FID anymore. This patch gets rid of this and simplifies the driver code since we can now directly map all 4095 FIDs available to all VLANs. Signed-off-by: Vivien Didelot

[PATCH net-next 1/4] net: dsa: mv88e6xxx: bridges do not need an FID

With 88E6352 and similar switch chips, each port has a map to restrict which output port this input port can egress frames to. The current driver code implements hardware bridging using this feature, and assigns to a bridge group the FID of its first member. Now that 802.1Q is fully implemented

[PATCH net-next 4/4] net: dsa: mv88e6xxx: fix hardware bridging

Playing with the VLAN map of every port to implement "hardware bridging" in the 88E6352 driver was a hack until full 802.1Q was supported. Indeed with 802.1Q port mode "Disabled" or "Fallback", this feature is used to restrict which output ports an input port can egress frames to. A Linux bridge

[PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging

DSA and its drivers currently hook the NETDEV_CHANGEUPPER net_device event in order to configure the VLAN map of every port. This VLAN map is a feature of these switch chips to hardcode and restrict which output ports a given input port can egress frames to. A Linux bridge is a simple untagged

[PATCH net-next 3/4] net: dsa: do not warn unsupported bridge ops

A DSA driver may not provide the port_join_bridge and port_leave_bridge functions, so don't warn in such case. Signed-off-by: Vivien Didelot --- net/dsa/slave.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index bb2bd3b..43d7342 100644

Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values

On Sun, 2015-10-11 at 20:55 +, Ben Cartwright-Cox wrote: > Sending ICMP packets with raw sockets ends up in the SNMP counters > logging the type as the first byte of the IPv4 header rather than > the ICMP header (in nearly all cases this is seen as "OutType69". > This is fixed by adding the IP

Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values

Forgive me for possibly being a little stupid here (This is my first patch to Linux so I am slightly over my head) Is this issue not addressed above the file where the following check is done? if (iphlen > length) goto error_free; On Sun, Oct 11, 2015 at 11:10 PM, Eric Dumazet wrote: >

Re: Updated scalable urandom patchkit

On Sun, Oct 11, 2015 at 12:35:46AM -0400, George Spelvin wrote: > > One is the final write back of add_ptr on the last line of > _mix_pool_bytes. It actually writes i, which includes the per-cpu nonce, > and will have it jumping all over without the steady progression that > the mixing

Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values

On Sun, 2015-10-11 at 23:17 +0100, Ben Cox wrote: > Forgive me for possibly being a little stupid here (This is my first > patch to Linux so I am slightly over my head) > > Is this issue not addressed above the file where the following check is done? > > if (iphlen > length) > goto

Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values

On Sun, 2015-10-11 at 15:43 -0700, Eric Dumazet wrote: > But your code reads 21th byte. BTW, nice catch ! Your patch only need a small addition. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2] HID: multitouch: Fetch feature reports on demand for Win8 devices

On Wed, 7 Oct 2015, Mika Westerberg wrote: > Some newer Intel Skylake based Dell laptops with Win8 precision touchpad > fail when initial feature reports are fetched from it. Below is an example > output with some additional debug included: > > i2c_hid i2c-DLL0704:01: Fetching the HID

[PATCH v10 00/46] Richacls

From: Andreas Gruenbacher Here is another update of the richacl patch queue. I would like to ask for feedback so that the core and local filesystem code (patches 1-24) can be merged in the 4.4 merge window. Changes since the last posting (https://lwn.net/Articles/659350/): * Support for xfs;

[PATCH v10 11/46] vfs: Add get_richacl and set_richacl inode operations

From: Andreas Gruenbacher These operations are similar to the get_acl and set_acl operations for POSIX ACLs. The distinction between access and default ACLs doesn't exist for richacls. Signed-off-by: Andreas Gruenbacher --- include/linux/fs.h | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH v10 14/46] richacl: Check if an acl is equivalent to a file mode

From: Andreas Gruenbacher ACLs are considered equivalent to file modes if they only consist of owner@, group@, and everyone@ entries, the owner@ permissions do not depend on whether the owner is a member in the owning group, and no inheritance flags are set. This test is used to avoid storing

[PATCH v10 15/46] richacl: Create-time inheritance

From: Andreas Gruenbacher When a new file is created, it can inherit an acl from its parent directory; this is similar to how default acls work in POSIX (draft) ACLs. As with POSIX ACLs, if a file inherits an acl from its parent directory, the intersection between the create mode and the

[PATCH v10 13/46] richacl: Update the file masks in chmod()

From: Andreas Gruenbacher Doing a chmod() sets the file mode, which includes the file permission bits. When a file has a richacl, the permissions that the richacl grants need to be limited to what the new file permission bits allow. This is done by setting the file masks in the richacl to what

[PATCH v10 17/46] richacl: xattr mapping functions

From: Andreas Gruenbacher Map between "system.richacl" xattrs and the in-kernel representation. Signed-off-by: Andreas Gruenbacher --- fs/Makefile | 2 +- fs/richacl_xattr.c| 220 ++ fs/xattr.c| 34

[PATCH v10 20/46] ext4: Add richacl support

From: "Aneesh Kumar K.V" Support the richacl permission model in ext4. The richacls are stored in "system.richacl" xattrs. Richacls need to be enabled by tune2fs or at file system create time. Signed-off-by: Aneesh Kumar K.V Signed-off-by: Andreas Gruenbacher --- fs/ext4/Kconfig | 11

[PATCH v10 18/46] richacl: Add richacl xattr handler

From: Andreas Gruenbacher Add richacl xattr handler implementing the xattr operations based on the get_richacl and set_richacl inode operations. Signed-off-by: Andreas Gruenbacher --- fs/richacl_xattr.c| 78 +++ include/linux/richacl_xattr.h

[PATCH v10 19/46] vfs: Add richacl permission checking

From: Andreas Gruenbacher Hook the richacl permission checking function into the vfs. Signed-off-by: Andreas Gruenbacher --- fs/namei.c | 51 +-- fs/posix_acl.c | 6 +++--- 2 files changed, 52 insertions(+), 5 deletions(-) diff --git

[PATCH v10 21/46] ext4: Add richacl feature flag

From: "Aneesh Kumar K.V" This feature flag selects richacl instead of posix acl support on the file system. In addition, the "acl" mount option is needed for enabling either of the two kinds of acls. Signed-off-by: Aneesh Kumar K.V Signed-off-by: Andreas Gruenbacher --- fs/ext4/ext4.h | 6

[PATCH v10 25/46] richacl: acl editing helper functions

From: Andreas Gruenbacher The file masks in richacls make chmod and creating new files more efficient than having to apply file permission bits to the acl directly. They also allow us to regain permissions from an acl even after a restrictive chmod, because the permissions in the acl itself are

[PATCH v10 24/46] xfs: Add richacl support

From: Andreas Gruenbacher The richacl feature flag (mkfs.xfs -m richacl=1) determines whether an xfs filesystem supports posix acls or richacls. Richacls are stored in "system.richacl" xattrs. If richacls are not compiled into the kernel, mounting richacl filesystems will fail. Signed-off-by:

[PATCH v10 23/46] xfs: Make xfs_set_mode non-static

From: Andreas Gruenbacher Make xfs_set_mode non-static and move it from xfs_acl.c into xfs_inode.c. Signed-off-by: Andreas Gruenbacher --- fs/xfs/xfs_acl.c | 18 -- fs/xfs/xfs_inode.c | 18 ++ fs/xfs/xfs_inode.h | 2 ++ 3 files changed, 20 insertions(+), 18

[PATCH v10 22/46] xfs: Fix error path in xfs_get_acl

From: Andreas Gruenbacher Error codes from xfs_attr_get other than -ENOATTR were not properly reported. Fix that, and clean the code up somewhat. In addition, the declaration of struct xfs_inode in xfs_acl.h isn't needed. Signed-off-by: Andreas Gruenbacher --- fs/xfs/xfs_acl.c | 19

[PATCH v10 27/46] richacl: Propagate everyone@ permissions to other aces

From: Andreas Gruenbacher The trailing everyone@ allow ace can grant permissions to all file classes including the owner and group class. Before we can apply the other mask to this entry to turn it into an "other class" entry, we need to ensure that members of the owner or group class will not

[PATCH v10 31/46] richacl: Apply the file masks to a richacl

From: Andreas Gruenbacher Put all the pieces of the acl transformation puzzle together for computing a richacl which has the file masks "applied" so that the standard nfsv4 access check algorithm can be used on the richacl. Signed-off-by: Andreas Gruenbacher Reviewed-by: J. Bruce Fields ---

[PATCH v10 33/46] nfsd: Keep list of acls to dispose of in compoundargs

From: Andreas Gruenbacher We will decode acls in requests into richacls. Even if unlikely, there can be more than one acl in a single request; those richacls need to be richacl_put() at the end of the request instead of kfree()d, so keep a list of acls in compoundargs for that. Signed-off-by:

[PATCH v10 30/46] richacl: Isolate the owner and group classes

From: Andreas Gruenbacher When applying the file masks to an acl, we need to ensure that no process gets more permissions than allowed by its file mask. This may require inserting an owner@ deny ace to ensure this if the owner mask contains fewer permissions than the group or other mask. For

[PATCH v10 32/46] richacl: Create richacl from mode values

From: Andreas Gruenbacher A file can have "no acl" in the sense that only the file mode permission bits determine access. In that case, the getxattr system call fails with errno == ENODATA (No such attribute). Over the NFSv4 protocol, a file always has an acl, and we convert the file mode

[PATCH v10 26/46] richacl: Move everyone@ aces down the acl

From: Andreas Gruenbacher The POSIX standard puts processes which are not the owner or a member in the owning group or which match any ace other then everyone@ on the other file class. We only know if a process is in the other class after processing the entire acl. Move all everyone@ aces in

[PATCH v10 28/46] richacl: Set the owner permissions to the owner mask

From: Andreas Gruenbacher In the write-through case, change the acl so that owner@ is granted the permissions set in the owner mask (to match what the permission check algorithm grants the owner). Signed-off-by: Andreas Gruenbacher Reviewed-by: J. Bruce Fields --- fs/richacl_compat.c | 46

[PATCH v10 29/46] richacl: Set the other permissions to the other mask

From: Andreas Gruenbacher Change the acl so that everyone@ is granted the permissions set in the other mask. Signed-off-by: Andreas Gruenbacher Reviewed-by: J. Bruce Fields --- fs/richacl_compat.c | 41 + 1 file changed, 41 insertions(+) diff --git

[PATCH v10 35/46] nfsd: Add richacl support

From: Andreas Gruenbacher On file systems with richacls enabled, get and set richacls directly instead of converting from / to posix acls. Signed-off-by: Andreas Gruenbacher Acked-by: J. Bruce Fields --- fs/nfsd/acl.h | 3 +- fs/nfsd/nfs4acl.c | 124

[PATCH v10 36/46] nfsd: Add support for the v4.1 dacl attribute

From: Andreas Gruenbacher Richacls support the Automatic Inheritance permission propagation mechanism as specified in NFSv4.1. Over NFS, this requires support for the dacl attribute: compared to the acl attribute, the dacl attribute has an additional flags field which indicates when Automatic

[PATCH v10 38/46] richacl: Add support for unmapped identifiers

From: Andreas Gruenbacher Some remote file systems like nfs may return user or group identifiers that cannot be mapped to local uids / gids. Allow to represent such unmapped identifiers in richacls. (We still cannot represent unmapped owners and owning groups, however.) In the in-memory

[PATCH 3/7] drivers/staging: make android tegra_ion.c properly tristate

The Kconfig currently controlling compilation of this code is: drivers/staging/android/ion/Kconfig:config ION_TEGRA drivers/staging/android/ion/Kconfig:tristate "Ion for Tegra" ...which led me to incorrectly conclude this file was built modular earlier. However the above CONFIG is just used

[PATCH v10 44/46] nfs: Add richacl support

From: Andreas Gruenbacher Add support for the "system.richacl" xattr in nfs. The existing "system.nfs4_acl" xattr on nfs doesn't map user and group names to uids and gids; the "system.richacl" xattr does, and only keeps the on-the-wire names when there is no mapping. This allows to copy

[PATCH v10 41/46] sunrpc: Add xdr_init_encode_pages

From: Andreas Gruenbacher Initialize xdr_stream and xdr_buf from a pages array, for encoding into the pages. Signed-off-by: Andreas Gruenbacher --- include/linux/sunrpc/xdr.h | 2 ++ net/sunrpc/xdr.c | 25 + 2 files changed, 27 insertions(+) diff --git

[PATCH v10 43/46] nfs: Remove unused xdr page offsets in getacl/setacl arguments

From: Andreas Gruenbacher The arguments passed around for getacl and setacl xdr encoding, struct nfs_setaclargs and struct nfs_getaclargs, both contain an array of pages, an offset into the first page, and the length of the page data. The offset is unused as it is always zero; remove it.

[PATCH v10 42/46] nfs: Fix GETATTR bitmap verification

From: Andreas Gruenbacher When decoding GETATTR replies, the client checks the attribute bitmap for which attributes the server has sent. It misses bits at the word boundaries, though; fix that. Signed-off-by: Andreas Gruenbacher --- fs/nfs/nfs4xdr.c | 23 +++ 1 file

[PATCH 0/7] staging: make non-modular code explicitly non-modular

[resending; forgot to add lkml to Cc: -- sorry for those who get this 2x] In a previous merge window, we made changes to allow better delineation between modular and non-modular code in commit 0fd972a7d91d6e15393c449492a04d94c0b89351 ("module: relocate module_init from init.h to module.h"). This

[PATCH v10 37/46] nfsd: Add support for the MAY_CREATE_{FILE,DIR} permissions

From: Andreas Gruenbacher For local file systems, the vfs performs the necessary permission checks for operations like creating files and directories. NFSd duplicates several of those checks. The vfs checks have been extended to check for additional permissions like MAY_CREATE_FILE and

[PATCH 4/7] drivers/staging: make android sw_sync.c explicitly non-modular

The Kconfig currently controlling compilation of this code is: staging/android/Kconfig:config SW_SYNC staging/android/Kconfig:bool "Software synchronization objects" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially

[PATCH v10 46/46] richacl: uapi header split

From: Andreas Gruenbacher Signed-off-by: Andreas Gruenbacher --- include/linux/richacl.h| 119 + include/linux/richacl_xattr.h | 17 +- include/uapi/linux/Kbuild | 2 + include/uapi/linux/richacl.h | 111

<    1   2   3   4   5   6   7   >