Re: [PATCH] checkpatch: Add a --strict test for macro argument reuse and precedence

On Sat, 2016-09-03 at 15:20 -0700, Joe Perches wrote: > Add a test for reuse of macro arguments to highlight any possible > side-effects from this reuse. > > Avoid this check on token name pasting and when the > argument is used in a typeof or a __builtin. > > Add a test for macro arguents that

Re: [PATCH] checkpatch: Add a --strict test for macro argument reuse and precedence

On Sat, 2016-09-03 at 15:20 -0700, Joe Perches wrote: > Add a test for reuse of macro arguments to highlight any possible > side-effects from this reuse. > > Avoid this check on token name pasting and when the > argument is used in a typeof or a __builtin. > > Add a test for macro arguents that

Re: [PATCH v4 2/3] mfd: add support for Allwinner SoCs ADC

On 01/09/16 15:05, Quentin Schulz wrote: > The Allwinner SoCs all have an ADC that can also act as a touchscreen > controller and a thermal sensor. For now, only the ADC and the thermal > sensor drivers are probed by the MFD, the touchscreen controller support > will be added later. > >

Re: [PATCH v4 2/3] mfd: add support for Allwinner SoCs ADC

On 01/09/16 15:05, Quentin Schulz wrote: > The Allwinner SoCs all have an ADC that can also act as a touchscreen > controller and a thermal sensor. For now, only the ADC and the thermal > sensor drivers are probed by the MFD, the touchscreen controller support > will be added later. > >

Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

On 01/09/16 15:05, Quentin Schulz wrote: > The Allwinner SoCs all have an ADC that can also act as a touchscreen > controller and a thermal sensor. This patch adds the ADC driver which is > based on the MFD for the same SoCs ADC. > > This also registers the thermal adc channel in the iio map

Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

On 01/09/16 15:05, Quentin Schulz wrote: > The Allwinner SoCs all have an ADC that can also act as a touchscreen > controller and a thermal sensor. This patch adds the ADC driver which is > based on the MFD for the same SoCs ADC. > > This also registers the thermal adc channel in the iio map

Re: fs: GPF in bd_mount

On Sun, Sep 04, 2016 at 03:06:06PM +0100, Al Viro wrote: > Said that, I'm not sure why mount_pseudo() would be returning any errors; > rejection should happen in the caller (due to MS_NOUSER in the flags), but > I don't understand what would trigger it on mount_pseudo() level... I see what's

Re: fs: GPF in bd_mount

On Sun, Sep 04, 2016 at 03:06:06PM +0100, Al Viro wrote: > Said that, I'm not sure why mount_pseudo() would be returning any errors; > rejection should happen in the caller (due to MS_NOUSER in the flags), but > I don't understand what would trigger it on mount_pseudo() level... I see what's

Re: [PATCH] vxlan: Update tx_errors statistics if vxlan_build_skb return err.

On Sun, 4 Sep 2016 18:52:51 +0800, Haishuang Yan wrote: > If vxlan_build_skb return err < 0, tx_errors should be also increased. > > Signed-off-by: Haishuang Yan > --- > drivers/net/vxlan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH] vxlan: Update tx_errors statistics if vxlan_build_skb return err.

On Sun, 4 Sep 2016 18:52:51 +0800, Haishuang Yan wrote: > If vxlan_build_skb return err < 0, tx_errors should be also increased. > > Signed-off-by: Haishuang Yan > --- > drivers/net/vxlan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c >

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

ord what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303 reprod

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

ord what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303 reprod

Re: fs: GPF in bd_mount

On Sun, Sep 04, 2016 at 12:43:28PM +0200, Dmitry Vyukov wrote: > Hello, > > The following program triggers GPF in bd_mount: > > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include > #include > #include > #include > #include > > int main() > { >

Re: fs: GPF in bd_mount

On Sun, Sep 04, 2016 at 12:43:28PM +0200, Dmitry Vyukov wrote: > Hello, > > The following program triggers GPF in bd_mount: > > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include > #include > #include > #include > #include > > int main() > { >

Re: Clarification for source code formatting around jump labels

>> I am just curious on how much further software development "fun" the recent >> update >> by a topic like "CodingStyle: Clarify and complete chapter 7" will trigger. > > I don't want to drag this thread onwards for (way) too long, but clearly "it > is > advised to indent labels with a single

Re: Clarification for source code formatting around jump labels

>> I am just curious on how much further software development "fun" the recent >> update >> by a topic like "CodingStyle: Clarify and complete chapter 7" will trigger. > > I don't want to drag this thread onwards for (way) too long, but clearly "it > is > advised to indent labels with a single

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303 > config: i386-allmodconfig (attached as .config) > compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > # save the attached .c

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

ub.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303 > config: i386-allmodconfig (attached as .config) > compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > # save the attached .config to linux b

Re: [PATCH] RDS: Simplify code

On Sat, Sep 03, 2016 at 07:33:29AM +0200, Christophe JAILLET wrote: > Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to > 'list_splice_init'. It is not 100% accurate list_splice(y, z) INIT_LIST_HEAD(y) ==> if (!list_empty(y)) __list_splice(y, z, z>next);

Re: [PATCH] RDS: Simplify code

On Sat, Sep 03, 2016 at 07:33:29AM +0200, Christophe JAILLET wrote: > Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to > 'list_splice_init'. It is not 100% accurate list_splice(y, z) INIT_LIST_HEAD(y) ==> if (!list_empty(y)) __list_splice(y, z, z>next);

fs/xfs/xfs_ondisk.h:96:2: error: call to '__compiletime_assert_96' declared with attribute error: XFS: sizeof(xfs_dir2_sf_entry_t) is wrong, expected 3

Hi Dave, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 28e68154c5e2793123b248d38cf17b34dcb16d87 commit: ab9d1e4f7b0217948a3b35a64178602ab30ff45d Merge branch 'xfs-misc-fixes-4.6-3' into for-next date: 6 months

fs/xfs/xfs_ondisk.h:96:2: error: call to '__compiletime_assert_96' declared with attribute error: XFS: sizeof(xfs_dir2_sf_entry_t) is wrong, expected 3

Hi Dave, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 28e68154c5e2793123b248d38cf17b34dcb16d87 commit: ab9d1e4f7b0217948a3b35a64178602ab30ff45d Merge branch 'xfs-misc-fixes-4.6-3' into for-next date: 6 months

Re: [PATCH 4/4] ARM: dts: use definition in rockchip pinctrl header to describe gpios on Popmetal-RK3288

ord what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Andy-Yan/One-fix-and-some-improvements-for-RK3288-Popmetal-board/20160904-164007 base: ht

Re: [PATCH 4/4] ARM: dts: use definition in rockchip pinctrl header to describe gpios on Popmetal-RK3288

ord what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Andy-Yan/One-fix-and-some-improvements-for-RK3288-Popmetal-board/20160904-164007 base: ht

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

ord what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303 config: i

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

ord what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303 config: i

RE: [PATCH v5 4/8] char: rpmb: provide a user space interface

> On Thu, Sep 01, 2016 at 08:05:26PM +, Winkler, Tomas wrote: > > > > > > > > On Sun, Aug 07, 2016 at 09:44:03AM +, Winkler, Tomas wrote: > > > > > > > > > > On Mon 2016-07-18 23:27:49, Tomas Winkler wrote: > > > > > > The user space API is achieved via two synchronous IOCTL. > > > > > >

RE: [PATCH v5 4/8] char: rpmb: provide a user space interface

> On Thu, Sep 01, 2016 at 08:05:26PM +, Winkler, Tomas wrote: > > > > > > > > On Sun, Aug 07, 2016 at 09:44:03AM +, Winkler, Tomas wrote: > > > > > > > > > > On Mon 2016-07-18 23:27:49, Tomas Winkler wrote: > > > > > > The user space API is achieved via two synchronous IOCTL. > > > > > >

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

ord what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303 con

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

ord what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303 con

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

ord what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303 con

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

ord what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303 con

[PATCH v3 03/17] ARM: dts: exynos: Use common macros for pinctrl configuration

From: Krzysztof Kozlowski Replace duplicated macros in each DTSI file with a common macro coming from header. Include the header in each pinctrl DTSI so further changes could use it. Although PIN_FUNC_SPC_2 does not bring much information about the function itself, it

[PATCH v3 03/17] ARM: dts: exynos: Use common macros for pinctrl configuration

From: Krzysztof Kozlowski Replace duplicated macros in each DTSI file with a common macro coming from header. Include the header in each pinctrl DTSI so further changes could use it. Although PIN_FUNC_SPC_2 does not bring much information about the function itself, it still is more descriptive

[PATCH v3 17/17] ARM: dts: s3c64xx: Use macros for pinctrl configuration

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by:

[PATCH v3 08/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5250

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by:

[PATCH v3 17/17] ARM: dts: s3c64xx: Use macros for pinctrl configuration

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 08/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5250

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 06/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4x12

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by:

[PATCH v3 12/17] ARM: dts: exynos: Fix mismatched value for SD4 pull up/down configuration on exynos4210

From: Krzysztof Kozlowski The pinctrl pull up/down register on exynos4210 is 2-bit wide for each pin and it accepts only values of 0, 1 and 3. The pins sd4-bus-width8 were configured with value of 4. The driver does not validate the value so this overflow effectively

[PATCH v3 16/17] ARM: dts: s3c2416: Use macros for pinctrl configuration

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by:

[PATCH v3 06/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4x12

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 12/17] ARM: dts: exynos: Fix mismatched value for SD4 pull up/down configuration on exynos4210

From: Krzysztof Kozlowski The pinctrl pull up/down register on exynos4210 is 2-bit wide for each pin and it accepts only values of 0, 1 and 3. The pins sd4-bus-width8 were configured with value of 4. The driver does not validate the value so this overflow effectively set a bit 1 in adjacent

[PATCH v3 16/17] ARM: dts: s3c2416: Use macros for pinctrl configuration

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 10/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5410

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by:

[PATCH v3 14/17] ARM: dts: s3c64xx: Use common macros for pinctrl configuration

From: Krzysztof Kozlowski Replace duplicated macros in each DTSI file with a common macro coming from header. Include the header in each pinctrl DTSI so further changes could use it. Although PIN_FUNC_SPC_2 does not bring much information about the function itself, it

[PATCH v3 13/17] ARM: dts: exynos: Fix mismatched values of SD drive strengh configuration on exynos4415

From: Krzysztof Kozlowski The pinctrl drive strength register on exynos4415 is 2-bit wide for each pin. The pins for SD2 were configured with value of 4. The driver does not validate the value so this overflow effectively set a bit 1 in adjacent pins thus configuring

[PATCH v3 15/17] ARM: dts: s5pv210: Use macros for pinctrl configuration

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by:

[PATCH v3 07/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4415

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by:

[PATCH v3 10/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5410

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 14/17] ARM: dts: s3c64xx: Use common macros for pinctrl configuration

From: Krzysztof Kozlowski Replace duplicated macros in each DTSI file with a common macro coming from header. Include the header in each pinctrl DTSI so further changes could use it. Although PIN_FUNC_SPC_2 does not bring much information about the function itself, it still is more descriptive

[PATCH v3 13/17] ARM: dts: exynos: Fix mismatched values of SD drive strengh configuration on exynos4415

From: Krzysztof Kozlowski The pinctrl drive strength register on exynos4415 is 2-bit wide for each pin. The pins for SD2 were configured with value of 4. The driver does not validate the value so this overflow effectively set a bit 1 in adjacent pins thus configuring them to drive strength 2x.

[PATCH v3 15/17] ARM: dts: s5pv210: Use macros for pinctrl configuration

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 07/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4415

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 09/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5260

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by:

[PATCH v3 04/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos3250

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by:

[PATCH v3 05/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4210

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by:

[PATCH v3 11/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos542x/exynos5800

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by:

[PATCH v3 09/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5260

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 04/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos3250

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 05/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4210

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 11/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos542x/exynos5800

From: Krzysztof Kozlowski Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 01/17] pinctrl: dt-bindings: samsung: Add header with values used for configuration

From: Krzysztof Kozlowski Hard-coded pinctrl configuration values are scattered through DTS files. The numbers are difficult to decode by human, especially without the datasheet. Additionally the drive strength differs between S3C64xx, S5PV210 and Exynos SoC families

[PATCH v3 02/17] pinctrl: dt-bindings: samsung: Update documentation with new macros

From: Krzysztof Kozlowski Update examples in Samsung pinctrl dt-bindings with new macros coming from header file. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- Changes since v1: 1. Add

[PATCH v3 01/17] pinctrl: dt-bindings: samsung: Add header with values used for configuration

From: Krzysztof Kozlowski Hard-coded pinctrl configuration values are scattered through DTS files. The numbers are difficult to decode by human, especially without the datasheet. Additionally the drive strength differs between S3C64xx, S5PV210 and Exynos SoC families increasing the confusion.

[PATCH v3 02/17] pinctrl: dt-bindings: samsung: Update documentation with new macros

From: Krzysztof Kozlowski Update examples in Samsung pinctrl dt-bindings with new macros coming from header file. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- Changes since v1: 1. Add Javier's reviewed-by. 2. Include necessary header in example (pointed by

[PATCH v3 00/17] pinctrl: exynos/samsung: Add header with values used for configuration

Hi, Changes since v2 1. Combine separate patchsets into one. Previously I sent separately the fixes and changes for S3C platforms. 2. Fix issues pointed during review. 3. Add review tags. Changes since v1 1. Follow Arnd's suggestion about moving the macros

[PATCH v3 00/17] pinctrl: exynos/samsung: Add header with values used for configuration

Hi, Changes since v2 1. Combine separate patchsets into one. Previously I sent separately the fixes and changes for S3C platforms. 2. Fix issues pointed during review. 3. Add review tags. Changes since v1 1. Follow Arnd's suggestion about moving the macros

[PATCH v2 1/1] drivers: staging: rtl8723au: hal: Remove pointless test

This patch removes the pointless `else if` test. Signed-off-by: Matthias Beyer Reported-by: David Binderman --- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 1/1] drivers: staging: rtl8723au: hal: Remove pointless test

This patch removes the pointless `else if` test. Signed-off-by: Matthias Beyer Reported-by: David Binderman --- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c

[PATCH v2 0/1] Remove pointless test

Re-sending as On 01-09-2016 17:54:47, Greg KH wrote: > There is no patch here :( 8< As reported by David Binderman, this test is useless as of if (a < 3) { /* ... */ } else if (a >= 3) { /* ... */ } so this patch removes the second check. Matthias Beyer

[PATCH v2 0/1] Remove pointless test

Re-sending as On 01-09-2016 17:54:47, Greg KH wrote: > There is no patch here :( 8< As reported by David Binderman, this test is useless as of if (a < 3) { /* ... */ } else if (a >= 3) { /* ... */ } so this patch removes the second check. Matthias Beyer

[PATCH] vxlan: Update tx_errors statistics if vxlan_build_skb return err.

If vxlan_build_skb return err < 0, tx_errors should be also increased. Signed-off-by: Haishuang Yan --- drivers/net/vxlan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index f605a36..2c72dcd 100644 ---

[PATCH] vxlan: Update tx_errors statistics if vxlan_build_skb return err.

If vxlan_build_skb return err < 0, tx_errors should be also increased. Signed-off-by: Haishuang Yan --- drivers/net/vxlan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index f605a36..2c72dcd 100644 --- a/drivers/net/vxlan.c +++

fs: GPF in bd_mount

Hello, The following program triggers GPF in bd_mount: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include #include #include int main() { int fd; unshare(CLONE_NEWUSER); unshare(CLONE_NEWNS); mkdir("./bus",

fs: GPF in bd_mount

Hello, The following program triggers GPF in bd_mount: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include #include #include int main() { int fd; unshare(CLONE_NEWUSER); unshare(CLONE_NEWNS); mkdir("./bus",

RE: [PATCH] Fix chance of sign extension to nsec after its msb is set during calculation.

On Sun, 4 Sep 2016, Liav Rehana wrote: > >> The root of the problem is that in case the multiplication of delta > >> and > >> tkr->mult in the line that I've changed is too big that the MSB of the > >> result is set, then the shift will cause an unwanted sign extension. > > > I completely

RE: [PATCH] Fix chance of sign extension to nsec after its msb is set during calculation.

On Sun, 4 Sep 2016, Liav Rehana wrote: > >> The root of the problem is that in case the multiplication of delta > >> and > >> tkr->mult in the line that I've changed is too big that the MSB of the > >> result is set, then the shift will cause an unwanted sign extension. > > > I completely

Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.

I will be send individual patches. I was try, make M=drivers/staging/comedi/ No issue generated, Is there have any other option to test these changes? Amit G On Sun, Sep 4, 2016 at 2:05 PM, Greg KH wrote: > On Sun, Sep 04, 2016 at 01:41:03AM +0530, Amit Ghadge

Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.

I will be send individual patches. I was try, make M=drivers/staging/comedi/ No issue generated, Is there have any other option to test these changes? Amit G On Sun, Sep 4, 2016 at 2:05 PM, Greg KH wrote: > On Sun, Sep 04, 2016 at 01:41:03AM +0530, Amit Ghadge wrote: >> Fixes checkpatch

Re: Possible code defects: macros and precedence

On Sat, 3 Sep 2016, Joe Perches wrote: > There are many nominally incorrect macro definitions > in linux-kernel source where parentheses are not used > for various macros arguments with calculations. > > Does coccinelle or smatch have the ability to detect > potential macro misuse where

Re: Possible code defects: macros and precedence

On Sat, 3 Sep 2016, Joe Perches wrote: > There are many nominally incorrect macro definitions > in linux-kernel source where parentheses are not used > for various macros arguments with calculations. > > Does coccinelle or smatch have the ability to detect > potential macro misuse where

Re: [PATCH] IB/rxe: fix GFP_KERNEL in spinlock context

On Fri, Sep 2, 2016 at 11:46 PM, Alexey Khoroshilov wrote: > There is skb_clone(skb, GFP_KERNEL) in spinlock context > in rxe_rcv_mcast_pkt(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov >

Re: [PATCH] IB/rxe: fix GFP_KERNEL in spinlock context

On Fri, Sep 2, 2016 at 11:46 PM, Alexey Khoroshilov wrote: > There is skb_clone(skb, GFP_KERNEL) in spinlock context > in rxe_rcv_mcast_pkt(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov > --- > drivers/infiniband/sw/rxe/rxe_recv.c |

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

On Sun, Sep 4, 2016 at 3:12 PM, Giedrius Statkevičius wrote: > On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge wrote: >> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: >> WARNING: Block comments use * on subsequent lines >>

Re: [RFC v5 21/23] clockevents: initial support for mono to raw time conversion

Nicolai Stange writes: > +static u32 __clockevents_calc_adjust_freq(u32 mult_ce_raw, u32 mult_cs_mono, > + u32 mult_cs_raw) > +{ > + u64 adj; > + int sign; > + > + if (mult_cs_raw >= mult_cs_mono) { > + sign = 0; >

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

On Sun, Sep 4, 2016 at 3:12 PM, Giedrius Statkevičius wrote: > On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge wrote: >> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: >> WARNING: Block comments use * on subsequent lines >> >> Signed-off-by: Amit Ghadge >> --- > [...] > > Why

Re: [RFC v5 21/23] clockevents: initial support for mono to raw time conversion

Nicolai Stange writes: > +static u32 __clockevents_calc_adjust_freq(u32 mult_ce_raw, u32 mult_cs_mono, > + u32 mult_cs_raw) > +{ > + u64 adj; > + int sign; > + > + if (mult_cs_raw >= mult_cs_mono) { > + sign = 0; > + adj =

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

On 09/04/2016 09:20 AM, SF Markus Elfring wrote: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51 [ + Jonathan for above commit in linux-next ] You seem to lack understanding of the difference

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

On 09/04/2016 09:20 AM, SF Markus Elfring wrote: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51 [ + Jonathan for above commit in linux-next ] You seem to lack understanding of the difference

Re: [list] 8052ce2d97: WARNING: CPU: 0 PID: 1 at lib/list_debug.c:60 __list_del_entry+0x4d/0x71

On Sun, Sep 04, 2016 at 08:35:40AM +0800, kernel test robot wrote: > > FYI, we noticed the following commit: > > https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > dev.2016.08.19a > commit 8052ce2d9771ab5a818307f3abbaf33bba82a631 ("list: Split list_add() > debug checking

Re: [list] 8052ce2d97: WARNING: CPU: 0 PID: 1 at lib/list_debug.c:60 __list_del_entry+0x4d/0x71

On Sun, Sep 04, 2016 at 08:35:40AM +0800, kernel test robot wrote: > > FYI, we noticed the following commit: > > https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > dev.2016.08.19a > commit 8052ce2d9771ab5a818307f3abbaf33bba82a631 ("list: Split list_add() > debug checking

[PATCH] sctp: Remove some redundant code

In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was hidden in 'sctp_skb_list_tail()' Now, the code around it looks redundant. The '_init()' part of 'skb_queue_splice_tail_init()' should alreday do

[PATCH] sctp: Remove some redundant code

In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was hidden in 'sctp_skb_list_tail()' Now, the code around it looks redundant. The '_init()' part of 'skb_queue_splice_tail_init()' should alreday do

[PATCH] x86/microcode/AMD: Fix loading of builtin microcode with CONFIG_RANDOMIZE_MEMORY

Hi guys, here's one more fix for builtin microcode with CONFIG_RANDOMIZE_MEMORY for tip/x86/urgent. In the builtin case, we don't need to add the randomization offset because the builtin address gets relocated automatically. I know Ingo is not a big fan of all that adding of offsets and

[PATCH] x86/microcode/AMD: Fix loading of builtin microcode with CONFIG_RANDOMIZE_MEMORY

Hi guys, here's one more fix for builtin microcode with CONFIG_RANDOMIZE_MEMORY for tip/x86/urgent. In the builtin case, we don't need to add the randomization offset because the builtin address gets relocated automatically. I know Ingo is not a big fan of all that adding of offsets and

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge wrote: > This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: > WARNING: Block comments use * on subsequent lines > > Signed-off-by: Amit Ghadge > --- [...] Why are you sending so many copies

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge wrote: > This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: > WARNING: Block comments use * on subsequent lines > > Signed-off-by: Amit Ghadge > --- [...] Why are you sending so many copies of the same patch?

[GIT pull] timer fixes for 4.8

Linus, please pull the latest timers-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers-urgent-for-linus Two fixlet from the timers departement: - A fix for scheduler stalls in the tick idle code affecting NOHZ_FULL kernels - A

[GIT pull] timer fixes for 4.8

Linus, please pull the latest timers-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers-urgent-for-linus Two fixlet from the timers departement: - A fix for scheduler stalls in the tick idle code affecting NOHZ_FULL kernels - A

<    1   2   3   4   5   6   >