Re: [RFC][PATCH 1/3] drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be reused internally

2016-11-22 Thread John Stultz
On Tue, Nov 22, 2016 at 9:38 AM, Laurent Pinchart wrote: > Hi John, > > On Tuesday 22 Nov 2016 09:25:22 John Stultz wrote: >> On Tue, Nov 22, 2016 at 12:14 AM, Laurent Pinchart wrote: >> > On Monday 21 Nov 2016 16:37:30 John Stultz wrote: >> @@ -545,24 +554,13 @@ static int adv7511_get_modes(stru

[patch 5/6] hwmon/coretemp: Use proper error codes in cpu online callback

2016-11-22 Thread Thomas Gleixner
The cpu online callback returns success unconditionally even when the device has no support, micro code mismatches or device allocation fails. Only if CPU_HOTPLUG is disabled, the init function checks whether the device list is empty and removes the driver. This does not make sense. If CPU HOTPLUG

[patch 3/6] hwmon/coretemp: Avoid redundant lookups

2016-11-22 Thread Thomas Gleixner
No point in looking up the same thing over and over. Signed-off-by: Thomas Gleixner --- drivers/hwmon/coretemp.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) --- a/drivers/hwmon/coretemp.c +++ b/drivers/hwmon/coretemp.c @@ -533,21 +533,14 @@ static int create_cor

[patch 1/6] hwmon/coretemp: Fixup target cpu for package when cpu is offlined

2016-11-22 Thread Thomas Gleixner
When a CPU is offlined nothing checks whether it is the target CPU for the package temperature sysfs interface. As a consequence all future readouts of the package temperature return crap: # cat temp1_input 9 which is Tjmax of that package. Check whether the outgoing CPU is the target for t

[patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2016-11-22 Thread Thomas Gleixner
After the first attempt to convert the coretemp driver to the hotplug state machine failed, we had a deeper look and went a bit farther. The driver has quite some interesting concepts vs. the package, core and sysfs file management and a bug in the package temperature sysfs interface vs. cpu hotpl

Re: [PATCH 2/2] PCI: iproc: avoid maybe-uninitialized warning

2016-11-22 Thread Ray Jui
Hi Arnd, On 11/22/2016 6:17 AM, Arnd Bergmann wrote: > gcc notices that calling iproc_pcie_setup_ib with ib->nr_regions==0 > would result in an uninitialized return value: > > drivers/pci/host/pcie-iproc.c: In function 'iproc_pcie_setup_ib': > drivers/pci/host/pcie-iproc.c:894:6: error: 'ret' may

[patch 2/6] hwmon/coretemp: Simplify sibling management

2016-11-22 Thread Thomas Gleixner
The coretemp driver provides a sysfs interface per physical core. If hyperthreading is enabled and one of the siblings goes offline the sysfs interface is removed and then immeditately created again for the sibling. The only difference of them is the target cpu for the rdmsr_on_cpu() in the sysfs s

[patch 4/6] [PREEMPT-RT] hwmon/coretemp: Convert to hotplug state machine

2016-11-22 Thread Thomas Gleixner
Install the callbacks via the state machine. Setup and teardown are handled by the hotplug core. Signed-off-by: Sebastian Andrzej Siewior Cc: linux-hw...@vger.kernel.org Cc: Fenghua Yu Cc: Jean Delvare Cc: r...@linuxtronix.de Cc: Guenter Roeck Link: http://lkml.kernel.org/r/20161117183541.8588

[patch 6/6] hwmon/coretemp: Simplify package management

2016-11-22 Thread Thomas Gleixner
Keeping track of the per package platform devices requires an extra object, which is held in a linked list. The maximum number of packages is known at init() time. So the extra object and linked list management can be replaced by an array of platform device pointers in which the per package device

Re: Linux 4.4.34

2016-11-22 Thread Eric Dumazet
. > > I was wondering if we shouldn't just cap all cases? > > It seems like this could potentially return a value greater than skb- >>len in the "good" case since things like IP header length isn't > validated other then making sure it meets the minimum value, and if > there isn't a recognized L4 h

Re: [RFC][PATCH 2/3] drm/bridge: adv7511: Add 200ms delay on power-on

2016-11-22 Thread John Stultz
On Tue, Nov 22, 2016 at 12:25 AM, Laurent Pinchart wrote: > On Monday 21 Nov 2016 16:37:31 John Stultz wrote: >> Secton 4.1 of the adv7511 programming guide advises one waits >> 200ms after powering on the chip before trying to communicate >> with it via i2c. Not doing so can cause reliability iss

Re: [PATCH] misc: sram: remove useless #ifdef

2016-11-22 Thread Vladimir Zapolskiy
Hi Arnd, On 11/22/2016 04:30 PM, Arnd Bergmann wrote: A recent patch added a new function that is now unused whenever CONFIG_OF is disabled: drivers/misc/sram.c:342:12: error: 'atmel_securam_wait' defined but not used [-Werror=unused-function] There is actually no reason for the #ifdef, becau

Re: [PATCH] clk: bcm: Fix unmet Kconfig dependencies for CLK_BCM_63XX

2016-11-22 Thread Ray Jui
Hi Florian, On 11/22/2016 9:43 AM, Florian Fainelli wrote: > With commit f4e871509959 ("clk: iproc: Make clocks visible options"), > COMMON_CLK_IPROC gained a dependency on ARCH_BCM_IPROC, yet CLK_BCM_63XX > also selects that option, this causes the following Kconfig warning: > > warning: (CLK_BC

Re: linux-next: manual merge of the userns tree with Linus' tree

2016-11-22 Thread Eric W. Biederman
Stephen Rothwell writes: > Hi Eric, > > Today's linux-next merge of the userns tree got conflicts in: > > arch/alpha/kernel/ptrace.c > arch/blackfin/kernel/ptrace.c > arch/cris/arch-v32/kernel/ptrace.c > arch/ia64/kernel/ptrace.c > arch/mips/kernel/ptrace32.c > arch/powerpc/kernel/ptr

Re: [PATCH 2/2] virtio_ring: fix complaint by sparse

2016-11-22 Thread Cornelia Huck
On Tue, 22 Nov 2016 13:51:50 +0800 Gonglei wrote: > # make C=2 CF="-D__CHECK_ENDIAN__" ./drivers/virtio/ > > drivers/virtio/virtio_ring.c:423:19: warning: incorrect type in assignment > (different base types) > drivers/virtio/virtio_ring.c:423:19:expected unsigned int [unsigned] > [assign

[PATCH] proc: save decrement during lookup/readdir in /proc/$PID

2016-11-22 Thread Alexey Dobriyan
Comparison for "<" works equally well as comparison for "<=" but one SUB/LEA is saved (no, it is not optimised away, at least here). Signed-off-by: Alexey Dobriyan --- fs/proc/base.c |8 1 file changed, 4 insertions(+), 4 deletions(-) --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-11-22 Thread Bjørn Mork
Wim Osterholt writes: > On Mon, Nov 21, 2016 at 02:19:32PM +0100, Oliver Neukum wrote: >> On Thu, 2016-11-17 at 17:11 +0100, Wim Osterholt wrote: >> >> > Nov 17 15:07:51 localhost kernel: Check point 10 >> > Nov 17 15:07:51 localhost kernel: BUG: unable to handle kernel NULL >> > pointer deref

[PATCH 2/6] MIPS: xilfpga: Use Xilinx Interrupt Controller

2016-11-22 Thread Zubair Lutfullah Kakakhel
IRQs from peripherals such as i2c/uart/ethernet come via the AXI Interrupt controller. Select it in Kconfig for xilfpga and add the DT node Signed-off-by: Zubair Lutfullah Kakakhel --- arch/mips/Kconfig| 1 + arch/mips/boot/dts/xilfpga/nexys4ddr.dts | 12 2

[PATCH 4/6] MIPS: xilfpga: Add DT node for AXI I2C

2016-11-22 Thread Zubair Lutfullah Kakakhel
The xilfpga platform has an AXI I2C Bus master with a temperature sensor connected to it. Add the device tree node to use them. Signed-off-by: Zubair Lutfullah Kakakhel --- arch/mips/boot/dts/xilfpga/nexys4ddr.dts | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/

[PATCH 0/6] MIPS: xilfpga: Use irq-xilinx-intc

2016-11-22 Thread Zubair Lutfullah Kakakhel
Hi, The interrupt controller driver was in arch/microblaze. The patches to move the driver out from arch/microblaze to drivers/irqchip/irq-xilinx-intc.c have now been accepted [1] Hence, xilfpga can make use of the driver in v4.10. These patches do the following: - Use the irqchip driver - Add D

[PATCH 6/6] MIPS: xilfpga: Update defconfig

2016-11-22 Thread Zubair Lutfullah Kakakhel
Update defconfig to enable emaclite, i2c and temp sensor on the xilfpga platform Signed-off-by: Zubair Lutfullah Kakakhel --- arch/mips/configs/xilfpga_defconfig | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/arch/mips/configs/xilfpga_de

Re: Linux 4.4.34

2016-11-22 Thread Andre Noll
On Tue, Nov 22, 09:46, Eric Dumazet wrote > This is an aliasing problem. > Tom code is hard to read and understand. > > Andre, could you try : > > diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c > index 69e4463a4b1b..b045980faaea 100644 > --- a/net/core/flow_dissector.c > +++ b

[PATCH 3/6] MIPS: xilfpga: Update DT node and specify uart irq

2016-11-22 Thread Zubair Lutfullah Kakakhel
Update the DT node with the UART irq Signed-off-by: Zubair Lutfullah Kakakhel --- arch/mips/boot/dts/xilfpga/nexys4ddr.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/mips/boot/dts/xilfpga/nexys4ddr.dts b/arch/mips/boot/dts/xilfpga/nexys4ddr.dts index 8db660b..d285c8d 100644 ---

[PATCH 1/6] MIPS: xilfpga: Use irqchip instead of the legacy way

2016-11-22 Thread Zubair Lutfullah Kakakhel
This prepares the code to use the Xilinx Interrupt Controller driver in drivers/irqchip/irq-xilinx-intc.c Signed-off-by: Zubair Lutfullah Kakakhel --- arch/mips/xilfpga/intc.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/mips/xilfpga/intc.c b/arch/mips/xilfpga/

[PATCH 5/6] MIPS: xilfpga: Add DT node for AXI emaclite

2016-11-22 Thread Zubair Lutfullah Kakakhel
The xilfpga platform has a Xilinx AXI emaclite block. Add the DT node to use it. Signed-off-by: Zubair Lutfullah Kakakhel --- arch/mips/boot/dts/xilfpga/nexys4ddr.dts | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/mips/boot/dts/xilfpga/nexys4ddr.dts b/arch

Re: [PATCH 0/6 v6] sched: reflect sched_entity move into task_group's load

2016-11-22 Thread Andres Oportus
On Tue, Nov 22, 2016 at 9:52 AM, Andres Oportus wrote: > > I have back-ported these patches into Android with 4.4 kernel and tested > them on a Hikey device [1]. Back-ported patches used are enclosed. > I see equal or better performance across all tests. > > PELT below refers to https://android.g

[PATCH] proc: calculate /proc/* and /proc/*/task/* nlink at init time

2016-11-22 Thread Alexey Dobriyan
Runtime nlink calculation works but meh. I don't know how to do it at compile time, but I know how to do it at init time. Shift "2+" part into init time as a bonus. Signed-off-by: Alexey Dobriyan --- fs/proc/base.c | 19 +-- fs/proc/internal.h |1 + fs/proc/root.c

Re: Kernel BUG_ON in stable 4.8

2016-11-22 Thread Eric Dumazet
On Tue, Nov 22, 2016 at 9:44 AM, Mathieu Desnoyers wrote: > - On Nov 22, 2016, at 12:01 PM, Francis Deslauriers > francis.deslauri...@efficios.com wrote: > >> Hi Mathieu, >> >> Here is a description of the kernel BUG_ON I have encountered. This bug was >> triggered by our continuous integrati

Re: [PATCH] misc: sram: remove useless #ifdef

2016-11-22 Thread Alexandre Belloni
Hi, On 22/11/2016 at 19:47:52 +0200, Vladimir Zapolskiy wrote : > Hi Arnd, > > On 11/22/2016 04:30 PM, Arnd Bergmann wrote: > > A recent patch added a new function that is now unused whenever > > CONFIG_OF is disabled: > > > > drivers/misc/sram.c:342:12: error: 'atmel_securam_wait' defined but n

Re: Linux 4.4.34

2016-11-22 Thread Andre Noll
On Tue, Nov 22, 09:14, Eric Dumazet wrote > We definitely want to fix the real bug, not working around it. > > Seems an aliasing problem, key_control and key_basic might point to > adjacent memory > and a barrier() would solve the issue as well. This was also my first idea. I added some printk st

[patch V2 01/12] thermal/x86_pkg_temp: Cleanup thermal interrupt handling

2016-11-22 Thread Thomas Gleixner
Wenn a package is removed nothing restores the thermal interrupt MSR so the content will be stale when a CPU of that package becomes online again. Aside of that the work function reenables interrupts before acknowledging the current one, which is the wrong order to begin with. Signed-off-by: Thom

[PATCH] gpio: Add Tegra186 support

2016-11-22 Thread Thierry Reding
From: Thierry Reding Tegra186 has two GPIO controllers that are largely register compatible between one another but are completely different from the controller found on earlier generations. Signed-off-by: Thierry Reding --- drivers/gpio/Kconfig | 8 + drivers/gpio/Makefile|

[patch V2 05/12] thermal/x86_pkg_temp: Get rid of ref counting

2016-11-22 Thread Thomas Gleixner
There is no point in the whole package data refcounting dance because topology_core_cpumask tells us whether this is the last cpu in the package. If yes, then the package can go, if not it stays. It's already serialized via the hotplug code. While at it rename the first_cpu member of the package s

[patch V2 12/12] thermal/x86 pkg temp: Convert to hotplug state machine

2016-11-22 Thread Thomas Gleixner
From: Sebastian Andrzej Siewior Install the callbacks via the state machine and let the core invoke the callbacks on the already online CPUs. Replace the wrmsr/rdmrs_on_cpu() calls in the hotplug callbacks as they are guaranteed to be invoked on the incoming/outgoing cpu. Signed-off-by: Sebasti

[patch V2 02/12] thermal/x86_pkg_temp: Remove redundant package search

2016-11-22 Thread Thomas Gleixner
In pkg_temp_thermal_device_remove() the package device is searched at the beginning of the function. When the device refcount becomes zero another search for the same device is conducted. Remove the pointless loop and use the device pointer which was retrieved at the beginning of the function. Sig

[patch V2 11/12] thermal/x86_pkg_temp: Sanitize package management

2016-11-22 Thread Thomas Gleixner
Packages are kept in a list, which must be searched over and over. We can be smarter than that and just store the package pointers in an array which is allocated at init time. Sizing of the array is determined from the topology information. That makes the package search a simple array lookup. Sig

[patch V2 09/12] thermal/x86_pkg_temp: Move work scheduled flag into package struct

2016-11-22 Thread Thomas Gleixner
Storage for a boolean information whether work is scheduled for a package is kept in separate allocated storage, which is resized when the number of detected packages grows. With the proper locking in place this is a completely pointless exercise because we can simply stick it into the per package

[patch V2 10/12] thermal/x86_pkg_temp: Move work into package struct

2016-11-22 Thread Thomas Gleixner
Delayed work structs are held in a static percpu storage, which makes no sense at all because work is strictly per package and we never schedule more than one work per package. Aside of that the work cancelation in the hotplug is broken when the work is queued on the outgoing cpu and canceled. Not

[patch V2 04/12] thermal/x86_pkg_temp: Sanitize callback (de)initialization

2016-11-22 Thread Thomas Gleixner
The threshold callbacks are installed before the initialization of the online cpus has succeeded and removed after the teardown has been done. That's both wrong as callbacks might be invoked into a half initialized or torn down state. Move them to the proper places: Last in init() and first in exi

[patch V2 07/12] thermal/x86_pkg_temp: Cleanup code some more

2016-11-22 Thread Thomas Gleixner
Coding style fixups and replacement of overly complex constructs and random error codes instead of returning the real ones. This mess makes the eyes bleeding. Signed-off-by: Thomas Gleixner --- drivers/thermal/x86_pkg_temp_thermal.c | 81 - 1 file changed, 30

[patch V2 08/12] thermal/x86_pkg_temp: Sanitize locking

2016-11-22 Thread Thomas Gleixner
The work cancellation code, the thermal zone unregistering, the work code and the interrupt notification function are racy against each other and against cpu hotplug and module exit. The random locking sprinkeled all over the place does not help anything and probably exists to make people feel good

[patch V2 00/12] thermal/x86_pkg_temp: Sanitize hotplug and locking

2016-11-22 Thread Thomas Gleixner
Changes vs. V1: Fix the package removal wreckage reported by Srinivas We solely intended to convert that driver to the hotplug state machine and stumbled over a large pile of insanities, which are all interwoven with the package management: - The work cancelation code, the thermal zone unregiste

Re: Linux 4.4.34

2016-11-22 Thread Andre Noll
On Tue, Nov 22, 18:06, Greg KH wrote > On Tue, Nov 22, 2016 at 05:59:12PM +0100, Andre Noll wrote: > > On Mon, Nov 21, 10:28, Greg KH wrote > > > I'm announcing the release of the 4.4.34 kernel. > > > > > > All users of the 4.4 kernel series must upgrade. > > > > This update broke PXE boot on our

[patch V2 06/12] thermal/x86_pkg_temp: Cleanup namespace

2016-11-22 Thread Thomas Gleixner
Any randomly chosen struct name is more descriptive than phy_dev_entry. Rename the whole thing to struct pkg_device, which describes the content reasonably well and use the same variable name throughout the code so it gets readable. Rename the msr struct members as well. No functional change. S

Re: Linux 4.4.34

2016-11-22 Thread Eric Dumazet
On Tue, Nov 22, 2016 at 9:55 AM, Andre Noll wrote: > On Tue, Nov 22, 09:46, Eric Dumazet wrote >> This is an aliasing problem. >> Tom code is hard to read and understand. >> >> Andre, could you try : >> >> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c >> index 69e4463a4b1b..b0

[patch V2 03/12] thermal/x86_pkg_temp: Replace open coded cpu search

2016-11-22 Thread Thomas Gleixner
find_next_sibling() iterates over the online cpus and searches for a cpu with the same package id as the current cpu. This is a pointless exercise as topology_core_cpumask() allows a simple cpumask search for an online cpu on the same package. Signed-off-by: Thomas Gleixner --- drivers/thermal/

Re: wl1251 & mac address & calibration data

2016-11-22 Thread Pali Rohár
On Tuesday 22 November 2016 17:14:28 Michal Kazior wrote: > On 22 November 2016 at 16:31, Pali Rohár wrote: > > On Tuesday 22 November 2016 16:22:57 Michal Kazior wrote: > >> On 21 November 2016 at 16:51, Pali Rohár > >> wrote: > >> > On Friday 11 November 2016 18:20:50 Pali Rohár wrote: > >> >>

Re: [PATCH v2] tools lib traceevent: Add retrieval of preempt count and latency flags

2016-11-22 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 22, 2016 at 11:31:58AM -0500, Steven Rostedt escreveu: > > Add a way to retrieve the preempt count as well as the latency flags from a > pevent_record. > > int pevent_data_preempt_count(pevent, record); > > returns the preempt count of a record. > > int pevent_data_flags(pevent, r

Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-22 Thread Ville Syrjälä
On Tue, Nov 22, 2016 at 12:35:53PM -0500, Rob Clark wrote: > On Tue, Nov 22, 2016 at 12:31 PM, Ville Syrjälä > wrote: > > On Tue, Nov 22, 2016 at 12:23:59PM -0500, Rob Clark wrote: > >> On Tue, Nov 22, 2016 at 11:50 AM, Ville Syrjälä > >> wrote: > >> > On Tue, Nov 22, 2016 at 04:41:06PM +, Li

Re: Linux 4.4.34

2016-11-22 Thread Duyck, Alexander H
On Tue, 2016-11-22 at 09:56 -0800, Eric Dumazet wrote: > On Tue, Nov 22, 2016 at 9:55 AM, Andre Noll wrote: > > > > On Tue, Nov 22, 09:46, Eric Dumazet wrote > > > > > > This is an aliasing problem. > > > Tom code is hard to read and understand. > > > > > > Andre, could you try : > > > > > > d

[PATCH] powernv: Clear SPRN_PSSCR when a POWER9 CPU comes online

2016-11-22 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" Ensure that PSSCR is set to a safe value corresponding to no state-loss each time a POWER9 CPU comes online. Signed-off-by: Gautham R. Shenoy --- arch/powerpc/kernel/cpu_setup_power.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/kernel/cpu_setup_

Re: Linux 4.4.34

2016-11-22 Thread Andre Noll
On Tue, Nov 22, 09:56, Eric Dumazet wrote > >> @@ -157,6 +157,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb, > >> memcpy(key_eth_addrs, ð->h_dest, > >> sizeof(*key_eth_addrs)); > >> } > >> > >> + barrier(); > >> again: > >> switch (proto) { > >>

Re: Linux 4.4.34

2016-11-22 Thread Duyck, Alexander H
On Tue, 2016-11-22 at 19:06 +0100, Andre Noll wrote: > On Tue, Nov 22, 09:56, Eric Dumazet wrote > > > > > > > > > > > > > @@ -157,6 +157,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb, > > > > memcpy(key_eth_addrs, ð->h_dest, > > > > sizeof(*key_eth_addrs)); > > > >

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-11-22 Thread Bjørn Mork
Wim Osterholt writes: > On Mon, Nov 21, 2016 at 02:19:32PM +0100, Oliver Neukum wrote: > >> I don't understand it, bit please test the attached patch >> with dynamic debugging for cdc-acm and the kernel log level >> at maximum. > >> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc

Re: [alsa-devel] [PATCH 2/9] ALSA: ac97: add an ac97 bus

2016-11-22 Thread Mark Brown
On Thu, Nov 10, 2016 at 12:38:40PM +0100, Lars-Peter Clausen wrote: > On 11/09/2016 10:27 PM, Robert Jarzmik wrote: > > here, ie. that the rescan is a bug, or if it's more an "Occam's razor" > > discussion ? > Maybe we can just leave the rescanning out for now and think about how to > best handle

Re: [PATCH 07/10] mm: warn about vfree from atomic context

2016-11-22 Thread Andrey Ryabinin
On 11/18/2016 04:03 PM, Christoph Hellwig wrote: > We can't handle vfree itself from atomic context, but callers > can explicitly use vfree_atomic instead, which defers the actual > vfree to a workqueue. Unfortunately in_atomic does not work > on non-preemptible kernels, so we can't just do the ri

Re: net/icmp: null-ptr-deref in icmp6_send

2016-11-22 Thread Cong Wang
On Tue, Nov 22, 2016 at 2:23 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > It seems that skb_dst(skb) may end up being NULL. > > As far as I can see the bug was introduced in commit 5d41ce29e ("net: > icmp6_send should use ds

Re: Linux 4.4.34

2016-11-22 Thread Andre Noll
On Mon, Nov 21, 10:28, Greg KH wrote > I'm announcing the release of the 4.4.34 kernel. > > All users of the 4.4 kernel series must upgrade. This update broke PXE boot on our 4-way AMD boxes. The kernel panics in eth_type_trans(), presumably during kernel-level IP autoconfiguration, see [1]. Bise

Re: Enabling peer to peer device transactions for PCIe devices

2016-11-22 Thread Dan Williams
On Mon, Nov 21, 2016 at 12:36 PM, Deucher, Alexander wrote: > This is certainly not the first time this has been brought up, but I'd like > to try and get some consensus on the best way to move this forward. Allowing > devices to talk directly improves performance and reduces latency by avoidin

Re: [PATCH 1/2] PM / Domains: Introduce domain-performance-state binding

2016-11-22 Thread Kevin Hilman
Viresh Kumar writes: > On 21-11-16, 09:07, Rob Herring wrote: >> On Fri, Nov 18, 2016 at 02:53:12PM +0530, Viresh Kumar wrote: >> > Some platforms have the capability to configure the performance state of >> > their Power Domains. The performance levels are represented by positive >> > integer va

Re: [RFC][PATCH 2/3] drm/bridge: adv7511: Add 200ms delay on power-on

2016-11-22 Thread John Stultz
On Tue, Nov 22, 2016 at 9:38 AM, John Stultz wrote: > > Interestingly, without the msleep added in this patch, removing the > wait_event_interruptible_timeout() method in adv7511_wait_for_edid() > and using the polling loop seems to make things just as reliable. So > maybe something is off with th

Re: Linux 4.4.34

2016-11-22 Thread Eric Dumazet
On Tue, Nov 22, 2016 at 10:08 AM, Duyck, Alexander H wrote: > Okay I think I have figured it out, but I am not sure what a good > solution is. > > I think the problem is the fact that the keys may not be initialized > until init_default_flow_dissectors is called and I am not sure that is > happen

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-22 Thread Frank Rowand
On 11/21/16 22:25, Sekhar Nori wrote: > Hi Frank, > > On Tuesday 22 November 2016 07:13 AM, Frank Rowand wrote: >> On 11/21/16 08:33, Sekhar Nori wrote: >>> On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: +static int da8xx_ddrctl_probe(struct platform_device *pdev) +{

[PATCH/RFC -next] net: phy: Fix double free in phy_detach()

2016-11-22 Thread Geert Uytterhoeven
During "poweroff" on sh73a0/kzm9g: WARNING: CPU: 0 PID: 1271 at drivers/base/devres.c:889 phy_detach+0x44/0x60 Modules linked in: CPU: 0 PID: 1271 Comm: halt Not tainted 4.9.0-rc6-kzm9g-05637-gb090128865050239 #823 Hardware name: Generic SH73A0 (Flattened Device Tree) [] (unwi

Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-22 Thread Sean Paul
On Tue, Nov 22, 2016 at 1:06 PM, Ville Syrjälä wrote: > On Tue, Nov 22, 2016 at 12:35:53PM -0500, Rob Clark wrote: >> On Tue, Nov 22, 2016 at 12:31 PM, Ville Syrjälä >> wrote: >> > On Tue, Nov 22, 2016 at 12:23:59PM -0500, Rob Clark wrote: >> >> On Tue, Nov 22, 2016 at 11:50 AM, Ville Syrjälä >>

Re: [RFC][PATCH 2/3] drm/bridge: adv7511: Add 200ms delay on power-on

2016-11-22 Thread Laurent Pinchart
Hi John, (CC'ing Daniel) On Tuesday 22 Nov 2016 10:07:53 John Stultz wrote: > On Tue, Nov 22, 2016 at 9:38 AM, John Stultz wrote: > > Interestingly, without the msleep added in this patch, removing the > > wait_event_interruptible_timeout() method in adv7511_wait_for_edid() > > and using the pol

Re: Linux 4.4.34

2016-11-22 Thread Andre Noll
On Tue, Nov 22, 18:08, Duyck, Alexander H wrote > Okay I think I have figured it out, but I am not sure what a good > solution is. > > I think the problem is the fact that the keys may not be initialized > until init_default_flow_dissectors is called and I am not sure that is > happening before th

Re: [PATCH v2] iio: adc: New driver for TI ADS7950 chips

2016-11-22 Thread David Lechner
On 11/22/2016 01:23 AM, Jonathan Cameron wrote: On 21 November 2016 22:54:24 GMT+00:00, Peter Meerwald-Stadler wrote: +static int ti_ads7950_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int *val, int *va

Re: [PATCH] clocksource: nps: avoid maybe-uninitialized warning

2016-11-22 Thread Vineet Gupta
On 11/22/2016 06:34 AM, Arnd Bergmann wrote: > We get a harmless false-positive warning with the newly added nps > clocksource driver: > > drivers/clocksource/timer-nps.c: In function 'nps_setup_clocksource': > drivers/clocksource/timer-nps.c:102:6: error: 'nps_timer1_freq' may be used > uninitial

Re: [RFC PATCH 0/3] PM / Domains: Add support for devices that require multiple domains

2016-11-22 Thread Kevin Hilman
Jon Hunter writes: > On 16/11/16 12:53, Rafael J. Wysocki wrote: >> On Wed, Nov 16, 2016 at 11:48 AM, Jon Hunter wrote: >>> Hi Kevin, Ulf, >>> >>> On 03/11/16 14:20, Jon Hunter wrote: On 11/10/16 10:15, Jon Hunter wrote: ... Second, another way of seeing this is

Re: [PATCH v2 7/8] perf sched timehist: Add -V/--cpu-visual option

2016-11-22 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 16, 2016 at 03:06:33PM +0900, Namhyung Kim escreveu: > From: David Ahern > > The -V option provides a visual aid for sched switches by cpu: > > $ perf sched timehist -V > timecpu 0123456789abc task name b/n time sch > delay run time >

[PATCH 1/2] pinctrl: sx150x: various spelling fixes and some white-space cleanup

2016-11-22 Thread Peter Rosin
Signed-off-by: Peter Rosin --- drivers/pinctrl/pinctrl-sx150x.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c index 63778058eec7..ef4ef88e0ee9 100644 --- a/drivers/pinctrl/pinctrl-sx150x.c +++

Re: [RFC PATCH 0/3] PM / Domains: Add support for devices that require multiple domains

2016-11-22 Thread Jon Hunter
On 22/11/16 18:26, Kevin Hilman wrote: > Jon Hunter writes: > >> On 16/11/16 12:53, Rafael J. Wysocki wrote: >>> On Wed, Nov 16, 2016 at 11:48 AM, Jon Hunter wrote: Hi Kevin, Ulf, On 03/11/16 14:20, Jon Hunter wrote: > > On 11/10/16 10:15, Jon Hunter wrote: > > ..

Re: [PATCH 1/2] PM / Domains: Introduce domain-performance-state binding

2016-11-22 Thread Vincent Guittot
On 22 November 2016 at 19:12, Kevin Hilman wrote: > Viresh Kumar writes: > >> On 21-11-16, 09:07, Rob Herring wrote: >>> On Fri, Nov 18, 2016 at 02:53:12PM +0530, Viresh Kumar wrote: >>> > Some platforms have the capability to configure the performance state of >>> > their Power Domains. The perf

Re: [PATCH] proc: calculate /proc/* and /proc/*/task/* nlink at init time

2016-11-22 Thread Vegard Nossum
On 22 November 2016 at 20:55, Alexey Dobriyan wrote: > Runtime nlink calculation works but meh. I don't know how to do it > at compile time, but I know how to do it at init time. > > Shift "2+" part into init time as a bonus. Couple of small suggestions: - rename set_proc_pid_nlink() to proc_pid

Re: [PATCH V3 0/9] PM / OPP: Multiple regulator support

2016-11-22 Thread Mark Brown
On Tue, Nov 22, 2016 at 09:19:22AM +0530, Viresh Kumar wrote: > So the LAST remaining question is: > "How do we know (from the DT) the order in which entries for multiple > regulators > are present in the OPP table?" > > And I am not sure if we can do that without having a property like: > > +

Re: [RESEND PATCH v5 2/5] mtd: ubi: use 'max_bad_blocks' to compute bad_peb_limit if available

2016-11-22 Thread Brian Norris
On Mon, Nov 21, 2016 at 01:51:36PM -0600, Zach Brown wrote: > From: Jeff Westfahl > > Use the MTD function 'max_bad_blocks' to compute the UBI bad_peb_limit, > if the function is implemented for an MTD and doesn't return an error. I'm not exactly a UBI expert here, but it seems reasonable that w

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-22 Thread Frank Rowand
Hi Rob, On 11/18/16 12:00, Frank Rowand wrote: > On 11/18/16 06:46, Rob Herring wrote: >> On Thu, Nov 17, 2016 at 03:32:54PM +, Sudeep Holla wrote: >>> Currently platforms/drivers needing to get the machine model name are >>> replicating the same snippet of code. In some case, the OF reference

Re: [RESEND PATCH v5 1/5] mtd: introduce function max_bad_blocks

2016-11-22 Thread Brian Norris
A few small comments. On Mon, Nov 21, 2016 at 01:51:35PM -0600, Zach Brown wrote: > From: Jeff Westfahl > > If implemented, 'max_bad_blocks' returns the maximum number of bad > blocks to reserve for an MTD. An implementation for NAND is coming soon. > > Signed-off-by: Jeff Westfahl > Signed-of

Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-22 Thread Liviu Dudau
On Tue, Nov 22, 2016 at 12:23:59PM -0500, Rob Clark wrote: > On Tue, Nov 22, 2016 at 11:50 AM, Ville Syrjälä > wrote: > > On Tue, Nov 22, 2016 at 04:41:06PM +, Liviu Dudau wrote: > >> drm_get_format_name() de-references the buf parameter without checking > >> if the pointer was not NULL. Given

Re: [PATCH 0/6 v6] sched: reflect sched_entity move into task_group's load

2016-11-22 Thread Andres Oportus
Tested-by: Andres Oportus On Tue, Nov 22, 2016 at 9:55 AM, Andres Oportus wrote: > > On Tue, Nov 22, 2016 at 9:52 AM, Andres Oportus > wrote: > > > > I have back-ported these patches into Android with 4.4 kernel and tested > > them on a Hikey device [1]. Back-ported patches used are enclosed.

Re: [RESEND PATCH v5 2/5] mtd: ubi: use 'max_bad_blocks' to compute bad_peb_limit if available

2016-11-22 Thread Brian Norris
On Mon, Nov 21, 2016 at 01:51:36PM -0600, Zach Brown wrote: > From: Jeff Westfahl > > Use the MTD function 'max_bad_blocks' to compute the UBI bad_peb_limit, > if the function is implemented for an MTD and doesn't return an error. > > Signed-off-by: Jeff Westfahl > Signed-off-by: Zach Brown >

Re: [Qemu-devel] [PATCH] drm: update MAINTAINERS for qemu drivers (bochs, cirrus, qxl, virtio-gpu)

2016-11-22 Thread Eric Blake
On 11/22/2016 04:50 AM, Thomas Huth wrote: > On 22.11.2016 10:58, Gerd Hoffmann wrote: >> Changes: >> * add myself as maintainer, so patches land in my inbox. >> * add qemu-devel mailing list. >> * add drm-qemu git repo. >> * flip bochs and qxl status to "Maintained". >> >> Signed-off-by: Gerd

Re: [RFC][PATCH 2/3] drm/bridge: adv7511: Add 200ms delay on power-on

2016-11-22 Thread John Stultz
On Tue, Nov 22, 2016 at 10:23 AM, Laurent Pinchart wrote: > On Tuesday 22 Nov 2016 10:07:53 John Stultz wrote: >> On Tue, Nov 22, 2016 at 9:38 AM, John Stultz wrote: >> > Interestingly, without the msleep added in this patch, removing the >> > wait_event_interruptible_timeout() method in adv7511_

Re: [PATCH] x86: fix kaslr and memmap collision

2016-11-22 Thread Kees Cook
On Tue, Nov 22, 2016 at 9:26 AM, Dan Williams wrote: > [ replying for Dave since he's offline today and tomorrow ] > > On Tue, Nov 22, 2016 at 12:47 AM, Ingo Molnar wrote: >> >> * Dave Jiang wrote: >> >>> CONFIG_RANDOMIZE_BASE relocates the kernel to a random base address. >>> However it does no

Re: [RESEND PATCH v5 4/5] mtd: nand: implement 'max_bad_blocks' mtd function

2016-11-22 Thread Brian Norris
On Mon, Nov 21, 2016 at 01:51:38PM -0600, Zach Brown wrote: > Implement the new mtd function 'max_bad_blocks'. Using the chip's > max_bb_per_die and blocks_per_die fields to determine the maximum bad > blocks to reserve for an MTD. > > Signed-off-by: Jeff Westfahl > Signed-off-by: Zach Brown > A

Re: [RFC PATCH v3 20/20] x86: Add support to make use of Secure Memory Encryption

2016-11-22 Thread Borislav Petkov
On Wed, Nov 09, 2016 at 06:38:38PM -0600, Tom Lendacky wrote: > This patch adds the support to check if SME has been enabled and if the > mem_encrypt=on command line option is set. If both of these conditions > are true, then the encryption mask is set and the kernel is encrypted > "in place." Som

Re: [RESEND PATCH v5 0/5] mtd: use ONFI bad blocks per LUN to calculate UBI bad PEB limit

2016-11-22 Thread Brian Norris
On Mon, Nov 21, 2016 at 01:51:34PM -0600, Zach Brown wrote: > For ONFI-compliant NAND devices, the ONFI parameters report the maximum number > of bad blocks per LUN that will be encountered over the lifetime of the > device, > so we can use that information to get a more accurate (and smaller) val

Re: [PATCH v2 perf/core] perf script: fix a use after free crash.

2016-11-22 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 10, 2016 at 04:40:46PM -0800, Krister Johansen escreveu: > On Wed, Oct 26, 2016 at 11:44:53AM -0200, Arnaldo Carvalho de Melo wrote: > > Em Tue, Oct 25, 2016 at 05:20:10PM -0700, Krister Johansen escreveu: > > > On Tue, Oct 11, 2016 at 02:28:39AM -0700, Krister Johansen wrote: > > > > I

Re: [PATCH] x86: fix kaslr and memmap collision

2016-11-22 Thread Dan Williams
On Tue, Nov 22, 2016 at 10:54 AM, Kees Cook wrote: > On Tue, Nov 22, 2016 at 9:26 AM, Dan Williams > wrote: >> [ replying for Dave since he's offline today and tomorrow ] >> >> On Tue, Nov 22, 2016 at 12:47 AM, Ingo Molnar wrote: >>> >>> * Dave Jiang wrote: >>> CONFIG_RANDOMIZE_BASE reloc

Re: [BUG] msr-trace.h:42 suspicious rcu_dereference_check() usage!

2016-11-22 Thread Andi Kleen
On Tue, Nov 22, 2016 at 09:39:45AM -0500, Steven Rostedt wrote: > On Mon, 21 Nov 2016 10:37:00 -0800 > Andi Kleen wrote: > > > > Here is it again untruncated: > > > > http://halobates.de/tracepoint-trace > > BTW, what tool did you use to generate this? perf and Intel PT, with the disassembler

Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-22 Thread Liviu Dudau
On Tue, Nov 22, 2016 at 01:15:08PM -0500, Sean Paul wrote: > On Tue, Nov 22, 2016 at 1:06 PM, Ville Syrjälä > wrote: > > On Tue, Nov 22, 2016 at 12:35:53PM -0500, Rob Clark wrote: > >> On Tue, Nov 22, 2016 at 12:31 PM, Ville Syrjälä > >> wrote: > >> > On Tue, Nov 22, 2016 at 12:23:59PM -0500, Rob

Re: net/icmp: null-ptr-deref in icmp6_send

2016-11-22 Thread David Ahern
Sent from my iPhone > On Nov 22, 2016, at 1:11 PM, Cong Wang wrote: > >> On Tue, Nov 22, 2016 at 2:23 AM, Andrey Konovalov >> wrote: >> Hi, >> >> I've got the following error report while fuzzing the kernel with syzkaller. >> >> It seems that skb_dst(skb) may end up being NULL. >> >> As f

Re: [PATCH] drivers: staging: media: davinci_vpfe: dm365_resizer: fixed some spelling mistakes

2016-11-22 Thread Laurent Pinchart
Hi Saatvik, Thank you for the patch, and sorry for the late reply. On Wednesday 03 Feb 2016 07:56:42 Saatvik Arya wrote: > fixed spelling mistakes which reffered to OUTPUT as OUPUT > > Signed-off-by: Saatvik Arya I've picked the patch up and applied it to my tree. I will send a pull request t

[PATCH net] flow_dissect: call init_default_flow_dissectors() earlier

2016-11-22 Thread Eric Dumazet
From: Eric Dumazet Andre Noll reported panics after my recent fix (commit 34fad54c2537 "net: __skb_flow_dissect() must cap its return value") After some more headaches, Alexander root caused the problem to init_default_flow_dissectors() being called too late, in case a network driver like IGB is

[PATCH] i2c: i2c-mux-gpio: update mux with gpiod_set_array_value_cansleep

2016-11-22 Thread Peter Rosin
If the gpio controller supports it and the gpio lines are concentrated to one gpio chip, the mux controller pins will get updated simultaneously. Signed-off-by: Peter Rosin --- drivers/i2c/muxes/i2c-mux-gpio.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/d

[PATCH] KVM: x86: fix out-of-bounds access in lapic

2016-11-22 Thread Radim Krčmář
Cluster xAPIC delivery incorrectly assumed that dest_id <= 0xff. With enabled KVM_X2APIC_API_USE_32BIT_IDS in KVM_CAP_X2APIC_API, a userspace can send an interrupt with dest_id that results in out-of-bounds access. Found by syzkaller: BUG: KASAN: slab-out-of-bounds in kvm_irq_delivery_to_apic_f

[PATCH] KVM: x86: restore IP after all far jump failures

2016-11-22 Thread Radim Krčmář
em_jmp_far and em_ret_far assumed that setting IP can only fail in 64 bit mode, but syzkaller proved otherwise (and SDM agrees). Code segment was restored upon failure, but it was left uninitialized outside of long mode, which could lead to a leak of host kernel stack. Found by syzkaller: WARNI

Re: [PATCH] mtd: maps: add missing iounmap() in error path

2016-11-22 Thread Brian Norris
On Wed, Nov 16, 2016 at 10:50:16PM +, Luis Henriques wrote: > This patch was triggered by the following Coccinelle error: > > ./drivers/mtd/maps/sc520cdp.c:246:3-9: \ > ERROR: missing iounmap; ioremap on line 242 \ > and execution via conditional on line 244 > > Signed-off-by: Lui

Re: Kernel BUG_ON in stable 4.8

2016-11-22 Thread Eric Dumazet
On Tue, Nov 22, 2016 at 9:57 AM, Eric Dumazet wrote: > On Tue, Nov 22, 2016 at 9:44 AM, Mathieu Desnoyers > wrote: >> - On Nov 22, 2016, at 12:01 PM, Francis Deslauriers >> francis.deslauri...@efficios.com wrote: >> >>> Hi Mathieu, >>> >>> Here is a description of the kernel BUG_ON I have en

<    1   2   3   4   5   6   7   8   9   10   >