Re: [RFC PATCH 0/4] fs: introduce new writeback error tracking infrastructure and convert ext4 to use it

On Mon, 2017-04-03 at 11:40 -0700, Jeremy Allison wrote: > On Mon, Apr 03, 2017 at 11:36:48AM -0700, Jeremy Allison wrote: > > On Mon, Apr 03, 2017 at 02:18:44PM -0400, Jeff Layton wrote: > > > On Mon, 2017-04-03 at 11:09 -0700, Jeremy Allison wrote: > > > > > > > > CIFS has a way to reserve

Re: [RFC PATCH 0/4] fs: introduce new writeback error tracking infrastructure and convert ext4 to use it

On Mon, 2017-04-03 at 11:40 -0700, Jeremy Allison wrote: > On Mon, Apr 03, 2017 at 11:36:48AM -0700, Jeremy Allison wrote: > > On Mon, Apr 03, 2017 at 02:18:44PM -0400, Jeff Layton wrote: > > > On Mon, 2017-04-03 at 11:09 -0700, Jeremy Allison wrote: > > > > > > > > CIFS has a way to reserve

Re: [PATCH v2] input: cros_ec_keyb: Report wakeup events

On Sun, Apr 02, 2017 at 08:07:39AM +0800, Jeffy Chen wrote: > Report wakeup events when process events. > > Signed-off-by: Jeffy Chen > --- > > Changes in v2: > Remove unneeded dts changes. > > drivers/input/keyboard/cros_ec_keyb.c | 9 + > 1 file changed, 9

Re: [PATCH v2] input: cros_ec_keyb: Report wakeup events

On Sun, Apr 02, 2017 at 08:07:39AM +0800, Jeffy Chen wrote: > Report wakeup events when process events. > > Signed-off-by: Jeffy Chen > --- > > Changes in v2: > Remove unneeded dts changes. > > drivers/input/keyboard/cros_ec_keyb.c | 9 + > 1 file changed, 9 insertions(+) > > diff

Re: [RFC PATCH 0/4] fs: introduce new writeback error tracking infrastructure and convert ext4 to use it

On Mon, Apr 03, 2017 at 11:36:48AM -0700, Jeremy Allison wrote: > On Mon, Apr 03, 2017 at 02:18:44PM -0400, Jeff Layton wrote: > > On Mon, 2017-04-03 at 11:09 -0700, Jeremy Allison wrote: > > > > > > CIFS has a way to reserve space. Look into "allocation size" on create. > > > > That won't help

Re: [RFC PATCH 0/4] fs: introduce new writeback error tracking infrastructure and convert ext4 to use it

On Mon, Apr 03, 2017 at 11:36:48AM -0700, Jeremy Allison wrote: > On Mon, Apr 03, 2017 at 02:18:44PM -0400, Jeff Layton wrote: > > On Mon, 2017-04-03 at 11:09 -0700, Jeremy Allison wrote: > > > > > > CIFS has a way to reserve space. Look into "allocation size" on create. > > > > That won't help

Re: [PATCH] usb: misc: add missing continue and refactor code

On Mon, 3 Apr 2017, Greg Kroah-Hartman wrote: > On Mon, Apr 03, 2017 at 09:39:53AM -0500, Gustavo A. R. Silva wrote: > > -Code refactoring to make the flow easier to follow. > > -Add missing 'continue' for case USB_ENDPOINT_XFER_INT. > > Don't do multiple things in the same patch, please make

Re: [PATCH] usb: misc: add missing continue and refactor code

On Mon, 3 Apr 2017, Greg Kroah-Hartman wrote: > On Mon, Apr 03, 2017 at 09:39:53AM -0500, Gustavo A. R. Silva wrote: > > -Code refactoring to make the flow easier to follow. > > -Add missing 'continue' for case USB_ENDPOINT_XFER_INT. > > Don't do multiple things in the same patch, please make

Re: [RFC][PATCH] exec: Don't wait for ptraced threads to be reaped.

Eric, I see another series from you, but I simply failed to force myself to read it carefully. Because at first glance it makes me really sad, I do dislike it even if it is correct. Yes, yes, sure, I can be wrong. Will try tomorrow. On 04/02, Eric W. Biederman wrote: > > Oleg Nesterov

Re: [RFC][PATCH] exec: Don't wait for ptraced threads to be reaped.

Eric, I see another series from you, but I simply failed to force myself to read it carefully. Because at first glance it makes me really sad, I do dislike it even if it is correct. Yes, yes, sure, I can be wrong. Will try tomorrow. On 04/02, Eric W. Biederman wrote: > > Oleg Nesterov writes: >

Re: [RFC PATCH 0/4] fs: introduce new writeback error tracking infrastructure and convert ext4 to use it

On Mon, Apr 03, 2017 at 02:18:44PM -0400, Jeff Layton wrote: > On Mon, 2017-04-03 at 11:09 -0700, Jeremy Allison wrote: > > On Mon, Apr 03, 2017 at 01:47:37PM -0400, Jeff Layton wrote: > > > On Mon, 2017-04-03 at 07:32 -0700, Matthew Wilcox wrote: > > > > On Mon, Apr 03, 2017 at 06:28:38AM -0400,

Re: [RFC PATCH 0/4] fs: introduce new writeback error tracking infrastructure and convert ext4 to use it

On Mon, Apr 03, 2017 at 02:18:44PM -0400, Jeff Layton wrote: > On Mon, 2017-04-03 at 11:09 -0700, Jeremy Allison wrote: > > On Mon, Apr 03, 2017 at 01:47:37PM -0400, Jeff Layton wrote: > > > On Mon, 2017-04-03 at 07:32 -0700, Matthew Wilcox wrote: > > > > On Mon, Apr 03, 2017 at 06:28:38AM -0400,

[PATCH v2] staging: bcm2835-audio: remove unnecessary log messages

Remove unnecessary log messages in the driver which are just tracking function entry and exits. Signed-off-by: Aishwarya Pant --- Changes in v2: Patch v1 introduced a compile error; remove it by deleting the log continuation. .../vc04_services/bcm2835-audio/bcm2835-ctl.c

[PATCH v2] staging: bcm2835-audio: remove unnecessary log messages

Remove unnecessary log messages in the driver which are just tracking function entry and exits. Signed-off-by: Aishwarya Pant --- Changes in v2: Patch v1 introduced a compile error; remove it by deleting the log continuation. .../vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 --

Re: [RFC 03/10] [media] vb2: add in-fence support to QBUF

Hello Gustavo, On 03/13/2017 04:20 PM, Gustavo Padovan wrote: [snip] > > int vb2_qbuf(struct vb2_queue *q, struct v4l2_buffer *b) > { > + struct dma_fence *fence = NULL; > int ret; > > if (vb2_fileio_is_active(q)) { > @@ -565,7 +567,17 @@ int vb2_qbuf(struct vb2_queue *q,

Re: [RFC 03/10] [media] vb2: add in-fence support to QBUF

Hello Gustavo, On 03/13/2017 04:20 PM, Gustavo Padovan wrote: [snip] > > int vb2_qbuf(struct vb2_queue *q, struct v4l2_buffer *b) > { > + struct dma_fence *fence = NULL; > int ret; > > if (vb2_fileio_is_active(q)) { > @@ -565,7 +567,17 @@ int vb2_qbuf(struct vb2_queue *q,

Re: [PATCH 3/5] iommu/omap: Set dev->archdata.iommu = NULL in omap_iommu_remove_device

Hi Joerg, On 03/31/2017 07:10 AM, Joerg Roedel wrote: > From: Joerg Roedel > > Don't leave a stale pointer in case the device continues to > exist for some more time. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu/omap-iommu.c | 1 + > 1 file changed,

Re: [PATCH 3/5] iommu/omap: Set dev->archdata.iommu = NULL in omap_iommu_remove_device

Hi Joerg, On 03/31/2017 07:10 AM, Joerg Roedel wrote: > From: Joerg Roedel > > Don't leave a stale pointer in case the device continues to > exist for some more time. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu/omap-iommu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH] Input: rmi4 - remove the need for artificial IRQ in case of HID

Hi Benjamin, On Mon, Apr 03, 2017 at 06:18:21PM +0200, Benjamin Tissoires wrote: > The IRQ from rmi4 may interfere with the one we currently use on i2c-hid. > Given that there is already a need for an external API from rmi4 to > forward the attention data, we can, in this particular case rely on

Re: [PATCH] Input: rmi4 - remove the need for artificial IRQ in case of HID

Hi Benjamin, On Mon, Apr 03, 2017 at 06:18:21PM +0200, Benjamin Tissoires wrote: > The IRQ from rmi4 may interfere with the one we currently use on i2c-hid. > Given that there is already a need for an external API from rmi4 to > forward the attention data, we can, in this particular case rely on

Re: [PATCH 1/2] leds: Add driver for Qualcomm LPG

On Sun 02 Apr 05:54 PDT 2017, Jacek Anaszewski wrote: > On 03/31/2017 11:28 AM, Jacek Anaszewski wrote: > > Hi Bjorn and Pavel, > > > > On 03/30/2017 09:43 AM, Pavel Machek wrote: [..] > > In both RGB and pattern approaches we should assess > > if it is acceptable to provide a pattern for

Re: [PATCH 1/2] leds: Add driver for Qualcomm LPG

On Sun 02 Apr 05:54 PDT 2017, Jacek Anaszewski wrote: > On 03/31/2017 11:28 AM, Jacek Anaszewski wrote: > > Hi Bjorn and Pavel, > > > > On 03/30/2017 09:43 AM, Pavel Machek wrote: [..] > > In both RGB and pattern approaches we should assess > > if it is acceptable to provide a pattern for

Re: [PATCH] KEYS: encrypted: avoid encrypting/decrypting stack buffers

On Mon, Apr 03, 2017 at 11:55:42AM -0400, Mimi Zohar wrote: > > This patch removes calculating the "padlen".  Will this change break > other use cases? > No, the number of bytes being encrypted is still 'encrypted_datalen' which is passed to skcipher_request_set_crypt(). It's okay if the input

Re: [PATCH] KEYS: encrypted: avoid encrypting/decrypting stack buffers

On Mon, Apr 03, 2017 at 11:55:42AM -0400, Mimi Zohar wrote: > > This patch removes calculating the "padlen".  Will this change break > other use cases? > No, the number of bytes being encrypted is still 'encrypted_datalen' which is passed to skcipher_request_set_crypt(). It's okay if the input

Re: v4.10-rc8 (-rc6) boot regression on Intel desktop, does not boot after cold boots, boots after reboot

> > > > > ...1d.7: PCI fixup... pass 2 > > > > > ...1d.7: PCI fixup... pass 3 > > > > > ...1d.7: PCI fixup... pass 3 done > > > > > > > > > > ...followed by hang. So yes, it looks USB related. > > > > > > > > > > (Sometimes it hangs with some kind backtrace involving secondary CPU > > > > >

Re: v4.10-rc8 (-rc6) boot regression on Intel desktop, does not boot after cold boots, boots after reboot

> > > > > ...1d.7: PCI fixup... pass 2 > > > > > ...1d.7: PCI fixup... pass 3 > > > > > ...1d.7: PCI fixup... pass 3 done > > > > > > > > > > ...followed by hang. So yes, it looks USB related. > > > > > > > > > > (Sometimes it hangs with some kind backtrace involving secondary CPU > > > > >

Re: [RFC PATCH 0/4] fs: introduce new writeback error tracking infrastructure and convert ext4 to use it

On Mon, 2017-04-03 at 11:09 -0700, Jeremy Allison wrote: > On Mon, Apr 03, 2017 at 01:47:37PM -0400, Jeff Layton wrote: > > On Mon, 2017-04-03 at 07:32 -0700, Matthew Wilcox wrote: > > > On Mon, Apr 03, 2017 at 06:28:38AM -0400, Jeff Layton wrote: > > > > On Mon, 2017-04-03 at 14:25 +1000,

Re: [RFC PATCH 0/4] fs: introduce new writeback error tracking infrastructure and convert ext4 to use it

On Mon, 2017-04-03 at 11:09 -0700, Jeremy Allison wrote: > On Mon, Apr 03, 2017 at 01:47:37PM -0400, Jeff Layton wrote: > > On Mon, 2017-04-03 at 07:32 -0700, Matthew Wilcox wrote: > > > On Mon, Apr 03, 2017 at 06:28:38AM -0400, Jeff Layton wrote: > > > > On Mon, 2017-04-03 at 14:25 +1000,

Re: [PATCH v2 0/5] minitty: a minimal TTY layer alternative for embedded systems

On Mon, Apr 3, 2017 at 12:44 AM, Stuart Longland wrote: > On 03/04/17 07:41, Nicolas Pitre wrote: >>> No PTYs seems like a big limitation. This means no sshd? >> Again, my ultimate system target is in the sub-megabyte of RAM. I >> really doubt you'll be able to fit an

Re: [PATCH v2 0/5] minitty: a minimal TTY layer alternative for embedded systems

On Mon, Apr 3, 2017 at 12:44 AM, Stuart Longland wrote: > On 03/04/17 07:41, Nicolas Pitre wrote: >>> No PTYs seems like a big limitation. This means no sshd? >> Again, my ultimate system target is in the sub-megabyte of RAM. I >> really doubt you'll be able to fit an SSH server in there even if

Re: [RFC][PATCH 2/2] exec: If possible don't wait for ptraced threads to be reaped

On 04/02, Eric W. Biederman wrote: > > Oleg Nesterov writes: > > > And btw zap_other_threads(may_hang == 0) is racy. Either you need tasklist > > or > > exit_notify() should set tsk->exit_state under siglock, otherwise zap() can > > return the wrong count. > >

Re: [RFC][PATCH 2/2] exec: If possible don't wait for ptraced threads to be reaped

On 04/02, Eric W. Biederman wrote: > > Oleg Nesterov writes: > > > And btw zap_other_threads(may_hang == 0) is racy. Either you need tasklist > > or > > exit_notify() should set tsk->exit_state under siglock, otherwise zap() can > > return the wrong count. > > zap_other_thread(tsk, 0) only gets

Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues")

On Mon, Apr 03, 2017 at 07:56:32PM +0200, Mike Galbraith wrote: > On Mon, 2017-04-03 at 16:18 +0200, Christoph Hellwig wrote: > > Mike, > > > > can you try the patch below? > > No more spinning kworker woes, but I still have a warning on hibernate, > threadirqs invariant. I'm also seeing

Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues")

On Mon, Apr 03, 2017 at 07:56:32PM +0200, Mike Galbraith wrote: > On Mon, 2017-04-03 at 16:18 +0200, Christoph Hellwig wrote: > > Mike, > > > > can you try the patch below? > > No more spinning kworker woes, but I still have a warning on hibernate, > threadirqs invariant. I'm also seeing

Re: [RFC PATCH 0/4] fs: introduce new writeback error tracking infrastructure and convert ext4 to use it

On Mon, Apr 03, 2017 at 01:47:37PM -0400, Jeff Layton wrote: > On Mon, 2017-04-03 at 07:32 -0700, Matthew Wilcox wrote: > > On Mon, Apr 03, 2017 at 06:28:38AM -0400, Jeff Layton wrote: > > > On Mon, 2017-04-03 at 14:25 +1000, NeilBrown wrote: > > > > Also I think that EIO should always over-ride

Re: [RFC PATCH 0/4] fs: introduce new writeback error tracking infrastructure and convert ext4 to use it

On Mon, Apr 03, 2017 at 01:47:37PM -0400, Jeff Layton wrote: > On Mon, 2017-04-03 at 07:32 -0700, Matthew Wilcox wrote: > > On Mon, Apr 03, 2017 at 06:28:38AM -0400, Jeff Layton wrote: > > > On Mon, 2017-04-03 at 14:25 +1000, NeilBrown wrote: > > > > Also I think that EIO should always over-ride

[PATCH] virtio_pci: request irq error handling

On failure to request msix vectors virtio frees the vector map but fails to reset it. It will then attempt to use that map in vp_remove_vqs on device removal and hybernation, resulting in memory corruption manifesting as warnings in PCI core, hangs etc. Reported-by: Mike Galbraith

[PATCH] virtio_pci: request irq error handling

On failure to request msix vectors virtio frees the vector map but fails to reset it. It will then attempt to use that map in vp_remove_vqs on device removal and hybernation, resulting in memory corruption manifesting as warnings in PCI core, hangs etc. Reported-by: Mike Galbraith Fixes:

Re: [RFC PATCH] binder: Don't require the binder lock when killed in binder_thread_read()

Hi, On Mon, Apr 3, 2017 at 6:25 AM, Greg KH wrote: > On Sat, Apr 01, 2017 at 07:34:53PM -0700, Doug Anderson wrote: >> Hi, >> >> On Fri, Mar 31, 2017 at 11:48 PM, Greg KH wrote: >> > On Fri, Mar 31, 2017 at 02:00:13PM -0700, Doug Anderson

Re: [RFC PATCH] binder: Don't require the binder lock when killed in binder_thread_read()

Hi, On Mon, Apr 3, 2017 at 6:25 AM, Greg KH wrote: > On Sat, Apr 01, 2017 at 07:34:53PM -0700, Doug Anderson wrote: >> Hi, >> >> On Fri, Mar 31, 2017 at 11:48 PM, Greg KH wrote: >> > On Fri, Mar 31, 2017 at 02:00:13PM -0700, Doug Anderson wrote: >> >> On Fri, Mar 31, 2017 at 12:29 PM, Greg KH

Re: [PATCH v2 0/5] minitty: a minimal TTY layer alternative for embedded systems

> evertheless very convenient to be able to use a standard > shell  > with it. A standard shell will work over things other than a tty device. It really doesn't care so long as it gets a stream of data punctuated by end of statement symbols. It'll work over pipes, sockets, from files. > I beg to

Re: [PATCH v2 0/5] minitty: a minimal TTY layer alternative for embedded systems

> evertheless very convenient to be able to use a standard > shell  > with it. A standard shell will work over things other than a tty device. It really doesn't care so long as it gets a stream of data punctuated by end of statement symbols. It'll work over pipes, sockets, from files. > I beg to

Re: [PATCH] KEYS: fix dereferencing NULL payload with nonzero length

On Mon, Apr 03, 2017 at 04:46:42PM +0100, David Howells wrote: > Eric Biggers wrote: > > > - if (_payload) { > > + if (plen) { > > "if (_payload && plen)" would be better. > > David No, that doesn't solve the problem. The problem is that userspace can pass in a NULL

Re: [PATCH] KEYS: fix dereferencing NULL payload with nonzero length

On Mon, Apr 03, 2017 at 04:46:42PM +0100, David Howells wrote: > Eric Biggers wrote: > > > - if (_payload) { > > + if (plen) { > > "if (_payload && plen)" would be better. > > David No, that doesn't solve the problem. The problem is that userspace can pass in a NULL payload with nonzero

Re: [PATCH] usb: misc: add missing continue and refactor code

On Mon, Apr 03, 2017 at 09:39:53AM -0500, Gustavo A. R. Silva wrote: > -Code refactoring to make the flow easier to follow. > -Add missing 'continue' for case USB_ENDPOINT_XFER_INT. Don't do multiple things in the same patch, please make these multiple patches. And do the "add missing continue"

Re: [PATCH] usb: misc: add missing continue and refactor code

On Mon, Apr 03, 2017 at 09:39:53AM -0500, Gustavo A. R. Silva wrote: > -Code refactoring to make the flow easier to follow. > -Add missing 'continue' for case USB_ENDPOINT_XFER_INT. Don't do multiple things in the same patch, please make these multiple patches. And do the "add missing continue"

Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues")

On Mon, 2017-04-03 at 16:18 +0200, Christoph Hellwig wrote: > Mike, > > can you try the patch below? No more spinning kworker woes, but I still have a warning on hibernate, threadirqs invariant. I'm also seeing intermittent post hibernate hang funnies in virgin source +- this patch, and without

Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues")

On Mon, 2017-04-03 at 16:18 +0200, Christoph Hellwig wrote: > Mike, > > can you try the patch below? No more spinning kworker woes, but I still have a warning on hibernate, threadirqs invariant. I'm also seeing intermittent post hibernate hang funnies in virgin source +- this patch, and without

Re: [PATCH 8/9] iio: gyro: mpu3050: stop double error reporting

On Mon, Apr 3, 2017 at 10:38 AM, Peter Rosin wrote: > i2c_mux_add_adapter already logs a message on failure. > > Signed-off-by: Peter Rosin Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 8/9] iio: gyro: mpu3050: stop double error reporting

On Mon, Apr 3, 2017 at 10:38 AM, Peter Rosin wrote: > i2c_mux_add_adapter already logs a message on failure. > > Signed-off-by: Peter Rosin Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 2/2] staging: sm750fb: removed line continuations in quoted strings

On Mon, Apr 03, 2017 at 10:03:34PM +0530, Prasant Jalan wrote: > On Sat, Apr 1, 2017 at 12:40 AM, Prasant Jalan > wrote: > A gentle reminder for my patches. > Any comments or updates will be helpful! 2 days, over a weekend, for a coding style change is pretty fast,

Re: [PATCH 2/2] staging: sm750fb: removed line continuations in quoted strings

On Mon, Apr 03, 2017 at 10:03:34PM +0530, Prasant Jalan wrote: > On Sat, Apr 1, 2017 at 12:40 AM, Prasant Jalan > wrote: > A gentle reminder for my patches. > Any comments or updates will be helpful! 2 days, over a weekend, for a coding style change is pretty fast, don't you agree? I will

Re: [PATCH v2 2/2] regulator: hi655x: Bump parent pmic module use count

On Mon, Apr 03, 2017 at 12:28:43AM -0500, Jeremy Linton wrote: > The hi655x-regulator driver depends on the parent pmic/mfc > device driver but doesn't increase its use count. This results > in system crashes if the parent module is unloaded while the > regulators are still in use. Add explicit

Re: [PATCH v2 2/2] regulator: hi655x: Bump parent pmic module use count

On Mon, Apr 03, 2017 at 12:28:43AM -0500, Jeremy Linton wrote: > The hi655x-regulator driver depends on the parent pmic/mfc > device driver but doesn't increase its use count. This results > in system crashes if the parent module is unloaded while the > regulators are still in use. Add explicit

Re: [PATCH 0/2] Make cppc acpi driver aware of pcc subspace ids

Hi George, On Mon, Apr 3, 2017 at 9:44 AM, Prakash, Prashanth wrote: > Hi George, > > On 3/31/2017 12:24 AM, George Cherian wrote: >> The current cppc acpi driver works with only one pcc subspace id. >> It maintains and registers only one pcc channel even if the acpi

Re: [PATCH 0/2] Make cppc acpi driver aware of pcc subspace ids

Hi George, On Mon, Apr 3, 2017 at 9:44 AM, Prakash, Prashanth wrote: > Hi George, > > On 3/31/2017 12:24 AM, George Cherian wrote: >> The current cppc acpi driver works with only one pcc subspace id. >> It maintains and registers only one pcc channel even if the acpi table has >> different pcc

Re: [PATCH] iommu/arm-smmu: Fix 16bit ASID configuration

On Mon, Apr 03, 2017 at 11:16:33PM +0530, Sunil Kovvuri wrote: > On Tue, Mar 28, 2017 at 4:11 PM, wrote: > > From: Sunil Goutham > > > > 16bit ASID should be enabled before initializing TTBR0/1, > > otherwise only LSB 8bit ASID will be considered.

Re: [PATCH] iommu/arm-smmu: Fix 16bit ASID configuration

On Mon, Apr 03, 2017 at 11:16:33PM +0530, Sunil Kovvuri wrote: > On Tue, Mar 28, 2017 at 4:11 PM, wrote: > > From: Sunil Goutham > > > > 16bit ASID should be enabled before initializing TTBR0/1, > > otherwise only LSB 8bit ASID will be considered. Hence > > moving configuration of TTBCR

Re: [PATCH] KEYS: put keyring if install_session_keyring_to_cred() fails

Hi David, On Mon, Apr 03, 2017 at 04:42:05PM +0100, David Howells wrote: > Eric Biggers wrote: > > > +error3: > > + key_put(keyring); > > error2: > > mutex_unlock(_session_mutex); > > I would prefer the put to be outside of the locked section. How about the >

Re: [PATCH] KEYS: put keyring if install_session_keyring_to_cred() fails

Hi David, On Mon, Apr 03, 2017 at 04:42:05PM +0100, David Howells wrote: > Eric Biggers wrote: > > > +error3: > > + key_put(keyring); > > error2: > > mutex_unlock(_session_mutex); > > I would prefer the put to be outside of the locked section. How about the > attached instead? [...]

Re: [RFC PATCH 0/4] fs: introduce new writeback error tracking infrastructure and convert ext4 to use it

On Mon, 2017-04-03 at 07:32 -0700, Matthew Wilcox wrote: > On Mon, Apr 03, 2017 at 06:28:38AM -0400, Jeff Layton wrote: > > On Mon, 2017-04-03 at 14:25 +1000, NeilBrown wrote: > > > Also I think that EIO should always over-ride ENOSPC as the possible > > > responses are different. That probably

Re: [RFC PATCH 0/4] fs: introduce new writeback error tracking infrastructure and convert ext4 to use it

On Mon, 2017-04-03 at 07:32 -0700, Matthew Wilcox wrote: > On Mon, Apr 03, 2017 at 06:28:38AM -0400, Jeff Layton wrote: > > On Mon, 2017-04-03 at 14:25 +1000, NeilBrown wrote: > > > Also I think that EIO should always over-ride ENOSPC as the possible > > > responses are different. That probably

Re: [PATCH] iommu/arm-smmu: Fix 16bit ASID configuration

On Tue, Mar 28, 2017 at 4:11 PM, wrote: > From: Sunil Goutham > > 16bit ASID should be enabled before initializing TTBR0/1, > otherwise only LSB 8bit ASID will be considered. Hence > moving configuration of TTBCR register ahead of TTBR0/1 > while

Re: [PATCH] iommu/arm-smmu: Fix 16bit ASID configuration

On Tue, Mar 28, 2017 at 4:11 PM, wrote: > From: Sunil Goutham > > 16bit ASID should be enabled before initializing TTBR0/1, > otherwise only LSB 8bit ASID will be considered. Hence > moving configuration of TTBCR register ahead of TTBR0/1 > while initializing context bank. > > Signed-off-by:

Re: Bad page state splats on arm64, v4.11-rc{3,4}

On Mon, Apr 03, 2017 at 12:37:51PM +0100, Will Deacon wrote: > On Mon, Apr 03, 2017 at 11:56:29AM +0100, Mark Rutland wrote: > > On Fri, Mar 31, 2017 at 06:58:45PM +0100, Mark Rutland wrote: > > > Hi, > > > > > > I'm seeing intermittent bad page state splats on arm64 with 4.11-rc3 and > > >

Re: Bad page state splats on arm64, v4.11-rc{3,4}

On Mon, Apr 03, 2017 at 12:37:51PM +0100, Will Deacon wrote: > On Mon, Apr 03, 2017 at 11:56:29AM +0100, Mark Rutland wrote: > > On Fri, Mar 31, 2017 at 06:58:45PM +0100, Mark Rutland wrote: > > > Hi, > > > > > > I'm seeing intermittent bad page state splats on arm64 with 4.11-rc3 and > > >

Re: [PATCH 3/3] f2fs: prevent waiter encountering incorrect discard states

On 04/01, Chao Yu wrote: > Ping, > > Any problem here? > > Thanks, > > On 2017/3/28 9:17, Chao Yu wrote: > > On 2017/3/28 7:56, Jaegeuk Kim wrote: > >> On 03/27, Chao Yu wrote: > >>> In f2fs_submit_discard_endio, we will wake up waiter before setting > >>> discard command states, so waiter may

Re: [PATCH 3/3] f2fs: prevent waiter encountering incorrect discard states

On 04/01, Chao Yu wrote: > Ping, > > Any problem here? > > Thanks, > > On 2017/3/28 9:17, Chao Yu wrote: > > On 2017/3/28 7:56, Jaegeuk Kim wrote: > >> On 03/27, Chao Yu wrote: > >>> In f2fs_submit_discard_endio, we will wake up waiter before setting > >>> discard command states, so waiter may

Re: [PATCH 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

(adding Prashanth to c/c) Hi George, On Fri, Mar 31, 2017 at 06:24:02AM +, George Cherian wrote: > Based on Section 14.1 of ACPI specification, it is possible to have a > maximum of 256 PCC subspace ids. Add support of multiple PCC subspace id > instead of using a single global pcc_data

Re: [PATCH 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

(adding Prashanth to c/c) Hi George, On Fri, Mar 31, 2017 at 06:24:02AM +, George Cherian wrote: > Based on Section 14.1 of ACPI specification, it is possible to have a > maximum of 256 PCC subspace ids. Add support of multiple PCC subspace id > instead of using a single global pcc_data

[PATCH] usb: misc: add missing continue and refactor code

-Code refactoring to make the flow easier to follow. -Add missing 'continue' for case USB_ENDPOINT_XFER_INT. Addresses-Coverity-ID: 1248733 Cc: Alan Stern Signed-off-by: Gustavo A. R. Silva --- drivers/usb/misc/usbtest.c | 68

[PATCH] usb: misc: add missing continue and refactor code

-Code refactoring to make the flow easier to follow. -Add missing 'continue' for case USB_ENDPOINT_XFER_INT. Addresses-Coverity-ID: 1248733 Cc: Alan Stern Signed-off-by: Gustavo A. R. Silva --- drivers/usb/misc/usbtest.c | 68 +- 1 file changed, 31

Re: skb_over_panic using UDP and 6lowpan / fakelb

(Cc'ing netdev and maintainers) On Mon, Mar 27, 2017 at 2:16 AM, David Palma wrote: > > Hi, > > Sending a simple UDP packet (39 bytes long), over a 6lowpan interface > (using fakelb), creates a kernel panic (skb_over_panic). > > Steps to reproduce, and more details, can be

Re: skb_over_panic using UDP and 6lowpan / fakelb

(Cc'ing netdev and maintainers) On Mon, Mar 27, 2017 at 2:16 AM, David Palma wrote: > > Hi, > > Sending a simple UDP packet (39 bytes long), over a 6lowpan interface > (using fakelb), creates a kernel panic (skb_over_panic). > > Steps to reproduce, and more details, can be found in: >

Re: [PATCH] ACPICA: use designated initializers

On Fri, Mar 31, 2017 at 5:45 PM, Moore, Robert wrote: > Acpica is built with many compilers, even very old ones. It runs on at least > 12 known operating systems, and very probably more. > > I'm sorry, but no, we are not going to start adding compiler-specific >

Re: [PATCH] ACPICA: use designated initializers

On Fri, Mar 31, 2017 at 5:45 PM, Moore, Robert wrote: > Acpica is built with many compilers, even very old ones. It runs on at least > 12 known operating systems, and very probably more. > > I'm sorry, but no, we are not going to start adding compiler-specific > ifdefs/code in the base ACPICA

Re: [PATCH v2 0/5] minitty: a minimal TTY layer alternative for embedded systems

On Mon, 3 Apr 2017, Andi Kleen wrote: > I like the idea of mintty (if it supported ptys). In fact PTYs could probably be implemented like another UART driver for the master side. But that may come later. > Except for that (and possibly VT) it is unlikely that people really > rely on the

Re: [PATCH v2 0/5] minitty: a minimal TTY layer alternative for embedded systems

On Mon, 3 Apr 2017, Andi Kleen wrote: > I like the idea of mintty (if it supported ptys). In fact PTYs could probably be implemented like another UART driver for the master side. But that may come later. > Except for that (and possibly VT) it is unlikely that people really > rely on the

Re: [PATCH v2] nfc: don't be making arch specific unaligned decisions at driver level.

[Re: [PATCH v2] nfc: don't be making arch specific unaligned decisions at driver level.] On 02/04/2017 (Sun 00:22) Samuel Ortiz wrote: > Hi Paul, > > On Mon, Jan 09, 2017 at 12:52:22PM -0500, Paul Gortmaker wrote: > > Currently ia64 fails building allmodconfig with variations of: > > [...] >

Re: [PATCH v2] nfc: don't be making arch specific unaligned decisions at driver level.

[Re: [PATCH v2] nfc: don't be making arch specific unaligned decisions at driver level.] On 02/04/2017 (Sun 00:22) Samuel Ortiz wrote: > Hi Paul, > > On Mon, Jan 09, 2017 at 12:52:22PM -0500, Paul Gortmaker wrote: > > Currently ia64 fails building allmodconfig with variations of: > > [...] >

Re: linux-next: build failure after merge of the drm-misc tree

Thanks for this. This and "drm/vmwgfx: merge fixup for set_config API change": Reviewed-by: Sinclair Yeh On Mon, Apr 03, 2017 at 01:31:29PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed

Re: linux-next: build failure after merge of the drm-misc tree

Thanks for this. This and "drm/vmwgfx: merge fixup for set_config API change": Reviewed-by: Sinclair Yeh On Mon, Apr 03, 2017 at 01:31:29PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > >

Re: [PATCH v4] ASoC: Add support for Maxim Integrated MAX98927 Amplifier

On Mon, Apr 3, 2017 at 9:30 AM, Rob Herring wrote: > On Fri, Mar 31, 2017 at 10:16:34AM +0900, Ryan Lee wrote: >> Signed-off-by: Ryan Lee >> --- >> >> Changes since v4: >> * Removed support for SND_SOC_DAIFMT_CBS_CFM. >> * Fixed coding

Re: [PATCH v4] ASoC: Add support for Maxim Integrated MAX98927 Amplifier

On Mon, Apr 3, 2017 at 9:30 AM, Rob Herring wrote: > On Fri, Mar 31, 2017 at 10:16:34AM +0900, Ryan Lee wrote: >> Signed-off-by: Ryan Lee >> --- >> >> Changes since v4: >> * Removed support for SND_SOC_DAIFMT_CBS_CFM. >> * Fixed coding style for indention. >> * Removed

[PATCH v5] ASoC: Add support for Maxim Integrated MAX98927 Amplifier

Signed-off-by: Ryan Lee --- Changes since v5 * Changed mode to 644. Changes since v4: * Removed support for SND_SOC_DAIFMT_CBS_CFM. * Fixed coding style for indention. * Removed variables if it has only one user. * Assigned

[PATCH v5] ASoC: Add support for Maxim Integrated MAX98927 Amplifier

Signed-off-by: Ryan Lee --- Changes since v5 * Changed mode to 644. Changes since v4: * Removed support for SND_SOC_DAIFMT_CBS_CFM. * Fixed coding style for indention. * Removed variables if it has only one user. * Assigned ch_size directly. *

Re: [PATCH 1/5] iommu/omap: Move data structures to omap-iommu.h

On 03/31/2017 07:10 AM, Joerg Roedel wrote: > From: Joerg Roedel > > The internal data-structures are scattered over various > header and C files. Consolidate them in omap-iommu.h. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu/omap-iommu.c

Re: [PATCH 1/5] iommu/omap: Move data structures to omap-iommu.h

On 03/31/2017 07:10 AM, Joerg Roedel wrote: > From: Joerg Roedel > > The internal data-structures are scattered over various > header and C files. Consolidate them in omap-iommu.h. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu/omap-iommu.c | 16 >

Re: linux-next: Tree for Apr 3 (scsi/lpfc)

On 04/03/17 01:13, Stephen Rothwell wrote: > Hi all, > > Changes since 20170331: > on i386: when SCSI_LPFC=y and CONFIG_NVME_CORE=m CONFIG_BLK_DEV_NVME=m CONFIG_BLK_DEV_NVME_SCSI=y CONFIG_NVME_FABRICS=m CONFIG_NVME_FC=m CONFIG_NVME_TARGET=m drivers/built-in.o: In function

Re: linux-next: Tree for Apr 3 (scsi/lpfc)

On 04/03/17 01:13, Stephen Rothwell wrote: > Hi all, > > Changes since 20170331: > on i386: when SCSI_LPFC=y and CONFIG_NVME_CORE=m CONFIG_BLK_DEV_NVME=m CONFIG_BLK_DEV_NVME_SCSI=y CONFIG_NVME_FABRICS=m CONFIG_NVME_FC=m CONFIG_NVME_TARGET=m drivers/built-in.o: In function

Re: [PATCH v3] xfs: Honor FALLOC_FL_KEEP_SIZE when punching ends of files

On Mon, Apr 03, 2017 at 10:15:31AM -0700, Darrick J. Wong wrote: > On Thu, Mar 30, 2017 at 09:18:00PM -0700, Calvin Owens wrote: > > When punching past EOF on XFS, fallocate(mode=PUNCH_HOLE|KEEP_SIZE) will > > round the file size up to the nearest multiple of PAGE_SIZE: > > > >

Re: [PATCH v3] xfs: Honor FALLOC_FL_KEEP_SIZE when punching ends of files

On Mon, Apr 03, 2017 at 10:15:31AM -0700, Darrick J. Wong wrote: > On Thu, Mar 30, 2017 at 09:18:00PM -0700, Calvin Owens wrote: > > When punching past EOF on XFS, fallocate(mode=PUNCH_HOLE|KEEP_SIZE) will > > round the file size up to the nearest multiple of PAGE_SIZE: > > > >

Re: [PATCH v3] xfs: Honor FALLOC_FL_KEEP_SIZE when punching ends of files

On Thu, Mar 30, 2017 at 09:18:00PM -0700, Calvin Owens wrote: > When punching past EOF on XFS, fallocate(mode=PUNCH_HOLE|KEEP_SIZE) will > round the file size up to the nearest multiple of PAGE_SIZE: > > calvinow@vm-disks/generic-xfs-1 ~$ dd if=/dev/urandom of=test bs=2048 > count=1 >

Re: [PATCH v3] xfs: Honor FALLOC_FL_KEEP_SIZE when punching ends of files

On Thu, Mar 30, 2017 at 09:18:00PM -0700, Calvin Owens wrote: > When punching past EOF on XFS, fallocate(mode=PUNCH_HOLE|KEEP_SIZE) will > round the file size up to the nearest multiple of PAGE_SIZE: > > calvinow@vm-disks/generic-xfs-1 ~$ dd if=/dev/urandom of=test bs=2048 > count=1 >

Re: [PATCH 0/5] iommu/omap: Add support for iommu-groups and 'struct iommu_device'

Hi Joerg, On 03/31/2017 07:10 AM, Joerg Roedel wrote: > Hi, > > here is a small patch-set for the omap-iommu driver to make > it use new features of the iommu-core. Please review. Thanks for the patches - this has been on my TODO list but you beat me in getting there first :). Are these for

Re: [PATCH 0/5] iommu/omap: Add support for iommu-groups and 'struct iommu_device'

Hi Joerg, On 03/31/2017 07:10 AM, Joerg Roedel wrote: > Hi, > > here is a small patch-set for the omap-iommu driver to make > it use new features of the iommu-core. Please review. Thanks for the patches - this has been on my TODO list but you beat me in getting there first :). Are these for

Re: [PATCH v7 06/13] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Rob, On 2017/4/4 0:19, Rob Herring wrote: > -- > On Thu, Mar 30, 2017 at 05:22:58PM +0200, Gregory CLEMENT wrote: >> From: Hu Ziji >> >> Marvell Xenon SDHC can support eMMC/SD/SDIO. >> Add Xenon-specific

Re: [PATCH v7 06/13] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Rob, On 2017/4/4 0:19, Rob Herring wrote: > -- > On Thu, Mar 30, 2017 at 05:22:58PM +0200, Gregory CLEMENT wrote: >> From: Hu Ziji >> >> Marvell Xenon SDHC can support eMMC/SD/SDIO. >> Add Xenon-specific properties. >> Also

Re: [B.A.T.M.A.N.] [PATCH] net: batman-adv: use new api ethtool_{get|set}_link_ksettings

On Samstag, 1. April 2017 08:40:54 CEST Sven Eckelmann wrote: [...] > Btw. the code you are modifying will most likely be dropped. Your patch will > get rejected because of this. But thanks for submitting the api conversion > patch (even when it will be rejected). The patch was now marked as

Re: [B.A.T.M.A.N.] [PATCH] net: batman-adv: use new api ethtool_{get|set}_link_ksettings

On Samstag, 1. April 2017 08:40:54 CEST Sven Eckelmann wrote: [...] > Btw. the code you are modifying will most likely be dropped. Your patch will > get rejected because of this. But thanks for submitting the api conversion > patch (even when it will be rejected). The patch was now marked as

<    1   2   3   4   5   6   7   8   9   10   >