Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11

On Wed, Apr 19, 2017 at 8:10 PM, Jens Axboe wrote: > On Wed, Apr 19 2017, Andy Lutomirski wrote: >> Sorry for waiting so long for this. I was waiting for feedback from >> Samsung, but they haven't root-caused the issue yet, and I should >> have just done this from the beginning.

Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11

On Wed, Apr 19, 2017 at 8:10 PM, Jens Axboe wrote: > On Wed, Apr 19 2017, Andy Lutomirski wrote: >> Sorry for waiting so long for this. I was waiting for feedback from >> Samsung, but they haven't root-caused the issue yet, and I should >> have just done this from the beginning. >> >> This

Re: [PATCH] xen/9pfs: select CONFIG_XEN_XENBUS_FRONTEND

On 20/04/17 01:10, Stefano Stabellini wrote: > Juergen, I have committed this patch to for-linus-4.12 and linux-next, I > hope that's OK. Sure. Juergen > > Og Wed, 19 Apr 2017, Stefano Stabellini wrote: >> On Wed, 19 Apr 2017, Arnd Bergmann wrote: >>> All Xen frontends need to select this

Re: [PATCH] xen/9pfs: select CONFIG_XEN_XENBUS_FRONTEND

On 20/04/17 01:10, Stefano Stabellini wrote: > Juergen, I have committed this patch to for-linus-4.12 and linux-next, I > hope that's OK. Sure. Juergen > > Og Wed, 19 Apr 2017, Stefano Stabellini wrote: >> On Wed, 19 Apr 2017, Arnd Bergmann wrote: >>> All Xen frontends need to select this

Re: [PATCH] fs: Preventing READ_IMPLIES_EXEC Propagation

On 2017/4/19 18:33, Catalin Marinas wrote: > On Tue, Apr 18, 2017 at 09:01:52PM +0100, Peter Maydell wrote: >> On 18 April 2017 at 18:01, Catalin Marinas wrote: >>> On Thu, Apr 13, 2017 at 08:33:52PM +0800, dongbo (E) wrote: From: Dong Bo

Re: [PATCH] fs: Preventing READ_IMPLIES_EXEC Propagation

On 2017/4/19 18:33, Catalin Marinas wrote: > On Tue, Apr 18, 2017 at 09:01:52PM +0100, Peter Maydell wrote: >> On 18 April 2017 at 18:01, Catalin Marinas wrote: >>> On Thu, Apr 13, 2017 at 08:33:52PM +0800, dongbo (E) wrote: From: Dong Bo In load_elf_binary(), once the

Re: [PATCH 4/5] nvme: Adjust the Samsung APST quirk

On Wed, Apr 19, 2017 at 8:07 PM, Jens Axboe wrote: > On Wed, Apr 19 2017, Andy Lutomirski wrote: >> I got a couple more reports: the Samsung APST issues appears to >> affect multiple 950-series devices in Dell XPS 15 9550 and Precision >> 5510 laptops. Change the quirk: rather

Re: [PATCH 4/5] nvme: Adjust the Samsung APST quirk

On Wed, Apr 19, 2017 at 8:07 PM, Jens Axboe wrote: > On Wed, Apr 19 2017, Andy Lutomirski wrote: >> I got a couple more reports: the Samsung APST issues appears to >> affect multiple 950-series devices in Dell XPS 15 9550 and Precision >> 5510 laptops. Change the quirk: rather than blacklisting

powerpc KVM build break in linux-next (was Re: [PATCH tip/core/rcu 40/40] srcu: Parallelize callback handling)

"Paul E. McKenney" writes: > diff --git a/include/linux/srcutree.h b/include/linux/srcutree.h > index f2b3bd6c6bc2..0400e211aa44 100644 > --- a/include/linux/srcutree.h > +++ b/include/linux/srcutree.h > @@ -24,25 +24,75 @@ ... > +/* > + * Per-SRCU-domain structure,

powerpc KVM build break in linux-next (was Re: [PATCH tip/core/rcu 40/40] srcu: Parallelize callback handling)

"Paul E. McKenney" writes: > diff --git a/include/linux/srcutree.h b/include/linux/srcutree.h > index f2b3bd6c6bc2..0400e211aa44 100644 > --- a/include/linux/srcutree.h > +++ b/include/linux/srcutree.h > @@ -24,25 +24,75 @@ ... > +/* > + * Per-SRCU-domain structure, similar in function to

[PATCH] lib/mpi: fix build with clang

Use just @ to denote comments which works with gcc and clang. Otherwise clang reports an escape sequence error: error: invalid % escape in inline assembly string Use %0-%3 as operand references, this avoids: error: invalid operand in inline asm: 'umull ${1:r}, ${0:r}, ${2:r}, ${3:r}' Also

[PATCH] lib/mpi: fix build with clang

Use just @ to denote comments which works with gcc and clang. Otherwise clang reports an escape sequence error: error: invalid % escape in inline assembly string Use %0-%3 as operand references, this avoids: error: invalid operand in inline asm: 'umull ${1:r}, ${0:r}, ${2:r}, ${3:r}' Also

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

On Tue, Apr 18, 2017 at 12:54 PM, Michal Hocko wrote: > On Tue 18-04-17 09:42:57, Dan Williams wrote: >> On Tue, Apr 18, 2017 at 12:14 AM, Michal Hocko wrote: >> > On Mon 17-04-17 14:51:12, Dan Williams wrote: >> >> On Tue, Apr 11, 2017 at 10:03 AM, Michal

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

On Tue, Apr 18, 2017 at 12:54 PM, Michal Hocko wrote: > On Tue 18-04-17 09:42:57, Dan Williams wrote: >> On Tue, Apr 18, 2017 at 12:14 AM, Michal Hocko wrote: >> > On Mon 17-04-17 14:51:12, Dan Williams wrote: >> >> On Tue, Apr 11, 2017 at 10:03 AM, Michal Hocko wrote: >> >> > All the reported

linux-next: manual merge of the kvm-ppc tree with the kvm-arm tree

Hi all, Today's linux-next merge of the kvm-ppc tree got a conflict in: include/uapi/linux/kvm.h between commit: 3fe17e682616 ("KVM: arm/arm64: Add ARM user space interrupt signaling ABI") from the kvm-arm tree and commit: 4898d3f49b5b ("KVM: PPC: Reserve KVM_CAP_SPAPR_TCE_VFIO

linux-next: manual merge of the kvm-ppc tree with the kvm-arm tree

Hi all, Today's linux-next merge of the kvm-ppc tree got a conflict in: include/uapi/linux/kvm.h between commit: 3fe17e682616 ("KVM: arm/arm64: Add ARM user space interrupt signaling ABI") from the kvm-arm tree and commit: 4898d3f49b5b ("KVM: PPC: Reserve KVM_CAP_SPAPR_TCE_VFIO

Re: [PATCH v5 1/4] printk/nmi: generic solution for safe printk in NMI

Hello Steven, On (04/19/17 13:13), Steven Rostedt wrote: > > printk() takes some locks and could not be used a safe way in NMI context. > > I just found a problem with this solution. It kills ftrace dumps from > NMI context :-( > > [ 1295.168495]<...>-67423 10dNh1 38217us :

Re: [PATCH v5 1/4] printk/nmi: generic solution for safe printk in NMI

Hello Steven, On (04/19/17 13:13), Steven Rostedt wrote: > > printk() takes some locks and could not be used a safe way in NMI context. > > I just found a problem with this solution. It kills ftrace dumps from > NMI context :-( > > [ 1295.168495]<...>-67423 10dNh1 38217us :

Re: [PATCH v3] dcssblk: add dax_operations support

Hi Dan, [auto build test ERROR on linus/master] [also build test ERROR on v4.11-rc7 next-20170419] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dan-Williams/dcssblk-add-dax_operations-support

Re: [PATCH v3] dcssblk: add dax_operations support

Hi Dan, [auto build test ERROR on linus/master] [also build test ERROR on v4.11-rc7 next-20170419] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dan-Williams/dcssblk-add-dax_operations-support

[no subject]

sup http://www.wulfrunfasteners.co.uk/cartpage.php?force=a2584gat5nazydp Will

[no subject]

sup http://www.wulfrunfasteners.co.uk/cartpage.php?force=a2584gat5nazydp Will

Re: [PATCH v3] axon_ram: add dax_operations support

On Wed, Apr 19, 2017 at 8:01 PM, kbuild test robot <l...@intel.com> wrote: > Hi Dan, > > [auto build test ERROR on powerpc/next] > [also build test ERROR on v4.11-rc7 next-20170419] > [if your patch is applied to the wrong git tree, please drop us a note to > help impro

Re: [PATCH v3] axon_ram: add dax_operations support

On Wed, Apr 19, 2017 at 8:01 PM, kbuild test robot wrote: > Hi Dan, > > [auto build test ERROR on powerpc/next] > [also build test ERROR on v4.11-rc7 next-20170419] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] >

Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11

On Wed, Apr 19 2017, Andy Lutomirski wrote: > Sorry for waiting so long for this. I was waiting for feedback from > Samsung, but they haven't root-caused the issue yet, and I should > have just done this from the beginning. > > This series makes APST more debuggable and updates the quirk list. >

Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11

On Wed, Apr 19 2017, Andy Lutomirski wrote: > Sorry for waiting so long for this. I was waiting for feedback from > Samsung, but they haven't root-caused the issue yet, and I should > have just done this from the beginning. > > This series makes APST more debuggable and updates the quirk list. >

Re: [PATCH 4/5] nvme: Adjust the Samsung APST quirk

On Wed, Apr 19 2017, Andy Lutomirski wrote: > I got a couple more reports: the Samsung APST issues appears to > affect multiple 950-series devices in Dell XPS 15 9550 and Precision > 5510 laptops. Change the quirk: rather than blacklisting the > firmware on the first problematic SSD that was

Re: [PATCH 4/5] nvme: Adjust the Samsung APST quirk

On Wed, Apr 19 2017, Andy Lutomirski wrote: > I got a couple more reports: the Samsung APST issues appears to > affect multiple 950-series devices in Dell XPS 15 9550 and Precision > 5510 laptops. Change the quirk: rather than blacklisting the > firmware on the first problematic SSD that was

Re: [PATCH 6/6] ima: Support appended signatures for appraisal

Hi Thiago, [auto build test ERROR on security/next] [also build test ERROR on v4.11-rc7 next-20170419] [cannot apply to integrity/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Thiago

Re: [PATCH 6/6] ima: Support appended signatures for appraisal

Hi Thiago, [auto build test ERROR on security/next] [also build test ERROR on v4.11-rc7 next-20170419] [cannot apply to integrity/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Thiago

[PATCH 2/5] nvme: Display raw APST configuration via DYNAMIC_DEBUG

Debugging APST is currently a bit of a pain. This gives optional simple log messages that describe the APST state. The easiest way to use this is probably with the nvme_core.dyndbg=+p module parameter. Signed-off-by: Andy Lutomirski --- drivers/nvme/host/core.c | 16

[PATCH 2/5] nvme: Display raw APST configuration via DYNAMIC_DEBUG

Debugging APST is currently a bit of a pain. This gives optional simple log messages that describe the APST state. The easiest way to use this is probably with the nvme_core.dyndbg=+p module parameter. Signed-off-by: Andy Lutomirski --- drivers/nvme/host/core.c | 16 1 file

[PATCH 5/5] nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA"

There's a report that it malfunctions with APST on. See https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678184 Cc: Kai-Heng Feng Signed-off-by: Andy Lutomirski --- drivers/nvme/host/core.c | 9 + 1 file changed, 9 insertions(+) diff

[PATCH 3/5] nvme: Add nvme_core.force_apst to ignore the NO_APST quirk

We're probably going to be stuck quirking APST off on an over-broad range of devices for 4.11. Let's make it easy to override the quirk for testing. Signed-off-by: Andy Lutomirski --- drivers/nvme/host/core.c | 15 ++- 1 file changed, 14 insertions(+), 1

Re: [PATCH v3] axon_ram: add dax_operations support

Hi Dan, [auto build test ERROR on powerpc/next] [also build test ERROR on v4.11-rc7 next-20170419] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dan-Williams/axon_ram-add-dax_operations

[PATCH 3/5] nvme: Add nvme_core.force_apst to ignore the NO_APST quirk

We're probably going to be stuck quirking APST off on an over-broad range of devices for 4.11. Let's make it easy to override the quirk for testing. Signed-off-by: Andy Lutomirski --- drivers/nvme/host/core.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v3] axon_ram: add dax_operations support

Hi Dan, [auto build test ERROR on powerpc/next] [also build test ERROR on v4.11-rc7 next-20170419] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dan-Williams/axon_ram-add-dax_operations

[PATCH 5/5] nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA"

There's a report that it malfunctions with APST on. See https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678184 Cc: Kai-Heng Feng Signed-off-by: Andy Lutomirski --- drivers/nvme/host/core.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/nvme/host/core.c

[PATCH 1/5] nvme: Fix APST comment

There was a typo in the description of the timeout heuristic. Signed-off-by: Andy Lutomirski --- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 9583a5f58a1d..4fc58866640e

[PATCH 4/5] nvme: Adjust the Samsung APST quirk

I got a couple more reports: the Samsung APST issues appears to affect multiple 950-series devices in Dell XPS 15 9550 and Precision 5510 laptops. Change the quirk: rather than blacklisting the firmware on the first problematic SSD that was reported, disable APST on all 144d:a802 devices if

[PATCH 1/5] nvme: Fix APST comment

There was a typo in the description of the timeout heuristic. Signed-off-by: Andy Lutomirski --- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 9583a5f58a1d..4fc58866640e 100644 ---

[PATCH 4/5] nvme: Adjust the Samsung APST quirk

I got a couple more reports: the Samsung APST issues appears to affect multiple 950-series devices in Dell XPS 15 9550 and Precision 5510 laptops. Change the quirk: rather than blacklisting the firmware on the first problematic SSD that was reported, disable APST on all 144d:a802 devices if

[PATCH 0/5] nvme APST fixes/improvements for 4.11

Sorry for waiting so long for this. I was waiting for feedback from Samsung, but they haven't root-caused the issue yet, and I should have just done this from the beginning. This series makes APST more debuggable and updates the quirk list. The quirks I'm aware of are: - Samsung 950 series

[PATCH 0/5] nvme APST fixes/improvements for 4.11

Sorry for waiting so long for this. I was waiting for feedback from Samsung, but they haven't root-caused the issue yet, and I should have just done this from the beginning. This series makes APST more debuggable and updates the quirk list. The quirks I'm aware of are: - Samsung 950 series

process_vm_readv/writev: partial transfer of a single iov?

The manpage for process_vm_readv/writev says that "Partial transfers apply at the granularity of iovec elements. These system calls won't perform a partial transfer that splits a single iovec element." However, it seems like this isn't actually true in current kernels (tested on ubuntu 4.4.0-66,

process_vm_readv/writev: partial transfer of a single iov?

The manpage for process_vm_readv/writev says that "Partial transfers apply at the granularity of iovec elements. These system calls won't perform a partial transfer that splits a single iovec element." However, it seems like this isn't actually true in current kernels (tested on ubuntu 4.4.0-66,

Re: [PATCH 8/9] bio: add bvec_iter rewind API

Dmitry Monakhov writes: Dmitry, > Some ->bi_end_io handlers (for example: pi_verify or decrypt handlers) > need to know original data vector, but after bio traverse io-stack it > may be advanced, splited and relocated many times so it is hard to > guess original iterator.

Re: [PATCH 8/9] bio: add bvec_iter rewind API

Dmitry Monakhov writes: Dmitry, > Some ->bi_end_io handlers (for example: pi_verify or decrypt handlers) > need to know original data vector, but after bio traverse io-stack it > may be advanced, splited and relocated many times so it is hard to > guess original iterator. Let's add 'bi_done'

Re: [PATCH 6/9] T10: Move opencoded contants to common header

Dmitry Monakhov writes: Dmitry, > diff --git a/include/linux/t10-pi.h b/include/linux/t10-pi.h > index 9fba9dd..f892442 100644 > --- a/include/linux/t10-pi.h > +++ b/include/linux/t10-pi.h > @@ -33,6 +33,8 @@ struct t10_pi_tuple { > __be32 ref_tag; /* Target

Re: [PATCH 6/9] T10: Move opencoded contants to common header

Dmitry Monakhov writes: Dmitry, > diff --git a/include/linux/t10-pi.h b/include/linux/t10-pi.h > index 9fba9dd..f892442 100644 > --- a/include/linux/t10-pi.h > +++ b/include/linux/t10-pi.h > @@ -33,6 +33,8 @@ struct t10_pi_tuple { > __be32 ref_tag; /* Target LBA or indirect LBA */

Re: [PATCH v3 2/2] modules:capabilities: add a per-task modules autoload restriction

On Wed, Apr 19, 2017 at 4:43 PM, Kees Cook wrote: > On Wed, Apr 19, 2017 at 4:15 PM, Andy Lutomirski wrote: >> On Wed, Apr 19, 2017 at 3:20 PM, Djalal Harouni wrote: >>> +/* Sets task's modules_autoload */ >>> +static inline int

Re: [PATCH v3 2/2] modules:capabilities: add a per-task modules autoload restriction

On Wed, Apr 19, 2017 at 4:43 PM, Kees Cook wrote: > On Wed, Apr 19, 2017 at 4:15 PM, Andy Lutomirski wrote: >> On Wed, Apr 19, 2017 at 3:20 PM, Djalal Harouni wrote: >>> +/* Sets task's modules_autoload */ >>> +static inline int task_set_modules_autoload(struct task_struct *task, >>> +

Re: [PATCH 5/9] bio-integrity: fold bio_integrity_enabled to bio_integrity_prep

Dmitry Monakhov writes: > Currently all integrity prep hooks are open-coded, and if prepare > fails we ignore it's code and fail bio with EIO. Let's return real > error to upper layer, so later caller may react accordingly. > > In fact no one want to use

Re: [PATCH 5/9] bio-integrity: fold bio_integrity_enabled to bio_integrity_prep

Dmitry Monakhov writes: > Currently all integrity prep hooks are open-coded, and if prepare > fails we ignore it's code and fail bio with EIO. Let's return real > error to upper layer, so later caller may react accordingly. > > In fact no one want to use bio_integrity_prep() w/o >

Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2

Dmitry Monakhov writes: > bio_integrity_trim inherent it's interface from bio_trim and accept > offset and size, but this API is error prone because data offset must > always be insync with bio's data offset. That is why we have integrity > update hook in bio_advance() > >

Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2

Dmitry Monakhov writes: > bio_integrity_trim inherent it's interface from bio_trim and accept > offset and size, but this API is error prone because data offset must > always be insync with bio's data offset. That is why we have integrity > update hook in bio_advance() > > So only meaningful

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

On 04/19/17 11:45, Tyrel Datwyler wrote: > On 04/18/2017 07:49 PM, Steven Rostedt wrote: >> On Tue, 18 Apr 2017 18:42:32 -0700 >> Frank Rowand wrote: >> >>> And of course the other issue with using tracepoints is the extra space >>> required to hold the tracepoint info.

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

On 04/19/17 11:45, Tyrel Datwyler wrote: > On 04/18/2017 07:49 PM, Steven Rostedt wrote: >> On Tue, 18 Apr 2017 18:42:32 -0700 >> Frank Rowand wrote: >> >>> And of course the other issue with using tracepoints is the extra space >>> required to hold the tracepoint info. With the pr_debug()

Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

Dmitry Monakhov writes: > SCSI drivers do care about bip_seed so we must update it accordingly. > + bip->bip_iter.bi_sector += bytes_done >> 9; This needs to count protection intervals. Otherwise things will break for block sizes different from 512 bytes. -- Martin

Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

Dmitry Monakhov writes: > SCSI drivers do care about bip_seed so we must update it accordingly. > + bip->bip_iter.bi_sector += bytes_done >> 9; This needs to count protection intervals. Otherwise things will break for block sizes different from 512 bytes. -- Martin K. Petersen

Re: [PATCH 1/9] bio-integrity: Do not allocate integrity context for bio w/o data

Dmitry Monakhov writes: > If bio has no data, such as ones from blkdev_issue_flush(), > then we have nothing to protect. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/9] bio-integrity: Do not allocate integrity context for bio w/o data

Dmitry Monakhov writes: > If bio has no data, such as ones from blkdev_issue_flush(), > then we have nothing to protect. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/9] bio-integrity: bio_trim should truncate integrity vector accordingly

Dmitry Monakhov writes: Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/9] bio-integrity: bio_trim should truncate integrity vector accordingly

Dmitry Monakhov writes: Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

On Wed, 19 Apr 2017 16:27:10 -0700 Tyrel Datwyler wrote: > # echo stacktrace > /sys/kernel/debug/tracing/trace_options > # cat trace | grep -A6 "/pci@8002018" Just to let you know that there is now stacktrace event triggers, where you don't need to

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

On Wed, 19 Apr 2017 16:27:10 -0700 Tyrel Datwyler wrote: > # echo stacktrace > /sys/kernel/debug/tracing/trace_options > # cat trace | grep -A6 "/pci@8002018" Just to let you know that there is now stacktrace event triggers, where you don't need to stacktrace all events, you can pick

Re: [PATCH V2] scsi: mpt3sas: remove redundant wmb

Sinan Kaya writes: > Due to relaxed ordering requirements on multiple architectures, > drivers are required to use wmb/rmb/mb combinations when they need to > guarantee observability between the memory and the HW. > > The mpt3sas driver is already using wmb() for this

Re: [PATCH V2] scsi: mpt3sas: remove redundant wmb

Sinan Kaya writes: > Due to relaxed ordering requirements on multiple architectures, > drivers are required to use wmb/rmb/mb combinations when they need to > guarantee observability between the memory and the HW. > > The mpt3sas driver is already using wmb() for this purpose. However, > it

[PATCH 3/9] platform/x86: hp-wmi: Standardize enum usage for constants

From: "Darren Hart (VMware)" Use enums consistently throughout the hp-wmi driver for groups of related constants. Use hex and align the assignment within groups. Move the *QUERY constants into an enum, create a new enum defining the READ, WRITE, and ODM constants and use

[PATCH 5/9] platform/x86: hp-wmi: Cleanup wireless get_(hw|sw)state functions

From: "Darren Hart (VMware)" Use the new hp_wmi_read_int() function and add a WARN_ONCE() to the TBD regarding passing the error through. These are used in a null return function unfortunately. Signed-off-by: Darren Hart (VMware) ---

[PATCH 3/9] platform/x86: hp-wmi: Standardize enum usage for constants

From: "Darren Hart (VMware)" Use enums consistently throughout the hp-wmi driver for groups of related constants. Use hex and align the assignment within groups. Move the *QUERY constants into an enum, create a new enum defining the READ, WRITE, and ODM constants and use them instead of 0 and 1

[PATCH 5/9] platform/x86: hp-wmi: Cleanup wireless get_(hw|sw)state functions

From: "Darren Hart (VMware)" Use the new hp_wmi_read_int() function and add a WARN_ONCE() to the TBD regarding passing the error through. These are used in a null return function unfortunately. Signed-off-by: Darren Hart (VMware) --- drivers/platform/x86/hp-wmi.c | 24

[PATCH 2/9] platform/x86: hp-wmi: Add bios_args initializer

From: "Darren Hart (VMware)" Cleanup the hp_wmi_perform_query function some by providing a bios_args initializer. No functional changes. Signed-off-by: Darren Hart (VMware) --- drivers/platform/x86/hp-wmi.c | 21 +++-- 1 file

[PATCH 2/9] platform/x86: hp-wmi: Add bios_args initializer

From: "Darren Hart (VMware)" Cleanup the hp_wmi_perform_query function some by providing a bios_args initializer. No functional changes. Signed-off-by: Darren Hart (VMware) --- drivers/platform/x86/hp-wmi.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff

[PATCH 1/9] platform/x86: hp-wmi: Cleanup local variable declarations

From: "Darren Hart (VMware)" Declare like types on one line. Order declarations in decreasing length where possible. Signed-off-by: Darren Hart (VMware) --- drivers/platform/x86/hp-wmi.c | 29 + 1 file changed, 13

[PATCH 1/9] platform/x86: hp-wmi: Cleanup local variable declarations

From: "Darren Hart (VMware)" Declare like types on one line. Order declarations in decreasing length where possible. Signed-off-by: Darren Hart (VMware) --- drivers/platform/x86/hp-wmi.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git

[PATCH 6/9] platform/x86: hp-wmi: Refactor dock and tablet state fetchers

From: "Darren Hart (VMware)" Both dock and tablet use the HPWMI_HARDWARE_QUERY, but require different masks. Rather than using two functions with magic masks, define the masks, and use a common accessor. Signed-off-by: Darren Hart (VMware) ---

[PATCH 7/9] platform/x86: hp-wmi: Use DEVICE_ATTR_(RO|RW) helper macros

From: "Darren Hart (VMware)" Use the DEVICE_ATTR_(RO|RW) macros, ranaming the show and store functions accordingly. Signed-off-by: Darren Hart (VMware) --- drivers/platform/x86/hp-wmi.c | 36 ++-- 1 file changed, 18

[PATCH 6/9] platform/x86: hp-wmi: Refactor dock and tablet state fetchers

From: "Darren Hart (VMware)" Both dock and tablet use the HPWMI_HARDWARE_QUERY, but require different masks. Rather than using two functions with magic masks, define the masks, and use a common accessor. Signed-off-by: Darren Hart (VMware) --- drivers/platform/x86/hp-wmi.c | 33

[PATCH 7/9] platform/x86: hp-wmi: Use DEVICE_ATTR_(RO|RW) helper macros

From: "Darren Hart (VMware)" Use the DEVICE_ATTR_(RO|RW) macros, ranaming the show and store functions accordingly. Signed-off-by: Darren Hart (VMware) --- drivers/platform/x86/hp-wmi.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git

[PATCH 9/9] platform/x86: hp-wmi: Cleanup exit paths

From: "Darren Hart (VMware)" Several exit paths were more complex than they needed to be. Remove superfluous conditionals, use labels common cleanup, do not shadow negative error codes. Signed-off-by: Darren Hart (VMware) ---

[PATCH 8/9] platform/x86: hp-wmi: Do not shadow errors in sysfs show functions

From: "Darren Hart (VMware)" The new hp_wmi_read_int function returns a negative value in case of error, pass this on directly rather than always replacing it with -EINVAL. Signed-off-by: Darren Hart (VMware) --- drivers/platform/x86/hp-wmi.c | 12

[PATCH 9/9] platform/x86: hp-wmi: Cleanup exit paths

From: "Darren Hart (VMware)" Several exit paths were more complex than they needed to be. Remove superfluous conditionals, use labels common cleanup, do not shadow negative error codes. Signed-off-by: Darren Hart (VMware) --- drivers/platform/x86/hp-wmi.c | 63

[PATCH 8/9] platform/x86: hp-wmi: Do not shadow errors in sysfs show functions

From: "Darren Hart (VMware)" The new hp_wmi_read_int function returns a negative value in case of error, pass this on directly rather than always replacing it with -EINVAL. Signed-off-by: Darren Hart (VMware) --- drivers/platform/x86/hp-wmi.c | 12 ++-- 1 file changed, 6

[PATCH 4/9] platform/x86: hp-wmi: Refactor redundant HPWMI_READ functions

From: "Darren Hart (VMware)" Several functions perform the same WMI read int with different query arguments. Refactor this into a single hp_wmi_read_int function. Signed-off-by: Darren Hart (VMware) --- drivers/platform/x86/hp-wmi.c | 82

[PATCH 4/9] platform/x86: hp-wmi: Refactor redundant HPWMI_READ functions

From: "Darren Hart (VMware)" Several functions perform the same WMI read int with different query arguments. Refactor this into a single hp_wmi_read_int function. Signed-off-by: Darren Hart (VMware) --- drivers/platform/x86/hp-wmi.c | 82 +-- 1 file

[PATCH v1 0/9] platform/x86: hp-wmi: Driver refactoring and cleanups

From: "Darren Hart (VMware)" This series factors out some redundant code, cleans up a number of style issues, modernizes the sysfs usage, and cleans up the return paths. All told, the driver is reduced in size by 37 lines (3.6%). I do not have an HP laptop, so I'm hoping

[PATCH v1 0/9] platform/x86: hp-wmi: Driver refactoring and cleanups

From: "Darren Hart (VMware)" This series factors out some redundant code, cleans up a number of style issues, modernizes the sysfs usage, and cleans up the return paths. All told, the driver is reduced in size by 37 lines (3.6%). I do not have an HP laptop, so I'm hoping Carlo can help out with

Re: [PATCH v3 1/2] modules:capabilities: automatic module loading restriction

On Thu, 2017-04-20 at 00:20 +0200, Djalal Harouni wrote: [...]  > +modules_autoload: > + > +A sysctl to control if modules auto-load feature is allowed or not. > +This sysctl complements "modules_disabled" which is for all module > +operations where this flag applies only to automatic module

Re: [PATCH v3 1/2] modules:capabilities: automatic module loading restriction

On Thu, 2017-04-20 at 00:20 +0200, Djalal Harouni wrote: [...]  > +modules_autoload: > + > +A sysctl to control if modules auto-load feature is allowed or not. > +This sysctl complements "modules_disabled" which is for all module > +operations where this flag applies only to automatic module

Re: [PATCH] [SCSI] aic7xxx: fix order of arguments in function prototype

Colin King writes: > The vendor/device and subvendor/subdevice arguments to the function > prototype ahc_9005_subdevinfo_valid are in the wrong order and need to > be swapped to fix this. Detected with PVS-Studio studio. Applied to 4.12/scsi-queue. -- Martin K.

Re: [PATCH] [SCSI] aic7xxx: fix order of arguments in function prototype

Colin King writes: > The vendor/device and subvendor/subdevice arguments to the function > prototype ahc_9005_subdevinfo_valid are in the wrong order and need to > be swapped to fix this. Detected with PVS-Studio studio. Applied to 4.12/scsi-queue. -- Martin K. Petersen Oracle Linux

Re: linux-next: manual merge of the akpm-current tree with the tip tree

On Wed, Apr 12 2017, Vlastimil Babka wrote: > On 12.4.2017 8:46, Stephen Rothwell wrote: >> Hi Andrew, >> >> Today's linux-next merge of the akpm-current tree got conflicts in: >> >> drivers/block/nbd.c >> drivers/scsi/iscsi_tcp.c >> net/core/dev.c >> net/core/sock.c >> >> between

Re: linux-next: manual merge of the akpm-current tree with the tip tree

On Wed, Apr 12 2017, Vlastimil Babka wrote: > On 12.4.2017 8:46, Stephen Rothwell wrote: >> Hi Andrew, >> >> Today's linux-next merge of the akpm-current tree got conflicts in: >> >> drivers/block/nbd.c >> drivers/scsi/iscsi_tcp.c >> net/core/dev.c >> net/core/sock.c >> >> between

Re: [PATCH] scsi: qedi,qedf: Use designated initializers

Kees, > Prepare to mark sensitive kernel structures for randomization by > making sure they're using designated initializers. These were > identified during allyesconfig builds of x86, arm, and arm64, with > most initializer fixes extracted from grsecurity. > > For these cases, terminate the

Re: [PATCH] scsi: qedi,qedf: Use designated initializers

Kees, > Prepare to mark sensitive kernel structures for randomization by > making sure they're using designated initializers. These were > identified during allyesconfig builds of x86, arm, and arm64, with > most initializer fixes extracted from grsecurity. > > For these cases, terminate the

Re: [PATCH v3 2/2] modules:capabilities: add a per-task modules autoload restriction

Hi Djalal, [auto build test ERROR on security/next] [also build test ERROR on next-20170419] [cannot apply to linus/master v4.11-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Djalal

Re: [PATCH v3 2/2] modules:capabilities: add a per-task modules autoload restriction

Hi Djalal, [auto build test ERROR on security/next] [also build test ERROR on next-20170419] [cannot apply to linus/master v4.11-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Djalal

Re: [PATCH v7 1/4] mtd: spi-nor: introduce SPI 1-2-2 and SPI 1-4-4 protocols

On 04/20/2017 01:17 AM, Cyrille Pitchen wrote: > Le 19/04/2017 à 23:31, Marek Vasut a écrit : >> On 04/19/2017 10:12 PM, Cyrille Pitchen wrote: >>> Le 19/04/2017 à 01:02, Marek Vasut a écrit : On 04/19/2017 12:51 AM, Cyrille Pitchen wrote: > This patch changes the prototype of

Re: [PATCH v7 1/4] mtd: spi-nor: introduce SPI 1-2-2 and SPI 1-4-4 protocols

On 04/20/2017 01:17 AM, Cyrille Pitchen wrote: > Le 19/04/2017 à 23:31, Marek Vasut a écrit : >> On 04/19/2017 10:12 PM, Cyrille Pitchen wrote: >>> Le 19/04/2017 à 01:02, Marek Vasut a écrit : On 04/19/2017 12:51 AM, Cyrille Pitchen wrote: > This patch changes the prototype of

<    1   2   3   4   5   6   7   8   9   10   >