[PATCH] liquidio: lio_vf_main: remove unnecessary static in setup_io_queues()

2017-07-18 Thread Gustavo A. R. Silva
Remove unnecessary static on local variables cpu_id_modulus and cpu_id. Such variables are initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the

[PATCH] liquidio: lio_vf_main: remove unnecessary static in setup_io_queues()

2017-07-18 Thread Gustavo A. R. Silva
Remove unnecessary static on local variables cpu_id_modulus and cpu_id. Such variables are initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the

[PATCH] net: ethernet: mediatek: remove useless code in mtk_poll_tx()

2017-07-18 Thread Gustavo A. R. Silva
Remove useless local variable _condition_ and the code related. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c

[PATCH] net: ethernet: mediatek: remove useless code in mtk_poll_tx()

2017-07-18 Thread Gustavo A. R. Silva
Remove useless local variable _condition_ and the code related. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c

Re: [RFC PATCH v12 3/4] Linux Random Number Generator

2017-07-18 Thread Theodore Ts'o
On Tue, Jul 18, 2017 at 04:37:11PM +0200, Stephan Müller wrote: > > > > > I have stated the core concerns I have with random.c in [1]. To remedy > > > these core concerns, major changes to random.c are needed. With the past > > > experience, I would doubt that I get the changes into random.c. > >

Re: [RFC PATCH v12 3/4] Linux Random Number Generator

2017-07-18 Thread Theodore Ts'o
On Tue, Jul 18, 2017 at 04:37:11PM +0200, Stephan Müller wrote: > > > > > I have stated the core concerns I have with random.c in [1]. To remedy > > > these core concerns, major changes to random.c are needed. With the past > > > experience, I would doubt that I get the changes into random.c. > >

[PATCH] net: tulip: remove useless code in tulip_init_one()

2017-07-18 Thread Gustavo A. R. Silva
Remove useless local variable multiport_cnt and the code related. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/dec/tulip/tulip_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c

[PATCH] net: tulip: remove useless code in tulip_init_one()

2017-07-18 Thread Gustavo A. R. Silva
Remove useless local variable multiport_cnt and the code related. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/dec/tulip/tulip_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c

Re: [PATCH] cgroup: Show control files in cgroup2 root after mount

2017-07-18 Thread Tejun Heo
On Tue, Jul 18, 2017 at 04:50:10PM -0400, Tejun Heo wrote: > Heh, I'm really confused. If I do the same thing, I get the following > result which makes sense as the files would be activated in > cgroup_apply_cftypes() when the debug controller is registered during > boot. > > # mkdir /cgroup2 >

Re: [PATCH] cgroup: Show control files in cgroup2 root after mount

2017-07-18 Thread Tejun Heo
On Tue, Jul 18, 2017 at 04:50:10PM -0400, Tejun Heo wrote: > Heh, I'm really confused. If I do the same thing, I get the following > result which makes sense as the files would be activated in > cgroup_apply_cftypes() when the debug controller is registered during > boot. > > # mkdir /cgroup2 >

[PATCH v5 5/6] dt-bindings: Document the Raspberry Pi Touchscreen nodes.

2017-07-18 Thread Eric Anholt
This doesn't yet cover input, but the driver does get the display working when the firmware is disabled from talking to our I2C lines. Signed-off-by: Eric Anholt Acked-by: Rob Herring --- .../panel/raspberrypi,7inch-touchscreen.txt| 49

[PATCH v5 5/6] dt-bindings: Document the Raspberry Pi Touchscreen nodes.

2017-07-18 Thread Eric Anholt
This doesn't yet cover input, but the driver does get the display working when the firmware is disabled from talking to our I2C lines. Signed-off-by: Eric Anholt Acked-by: Rob Herring --- .../panel/raspberrypi,7inch-touchscreen.txt| 49 ++ 1 file changed, 49

[PATCH v5 4/6] drm: Allow DSI devices to be registered before the host registers.

2017-07-18 Thread Eric Anholt
When a mipi_dsi_host is registered, the DT is walked to find any child nodes with compatible strings. Those get registered as DSI devices, and most DSI panel drivers are mipi_dsi_drivers that attach to those nodes. There is one special case currently, the adv7533 bridge, where the bridge probes

[PATCH v5 4/6] drm: Allow DSI devices to be registered before the host registers.

2017-07-18 Thread Eric Anholt
When a mipi_dsi_host is registered, the DT is walked to find any child nodes with compatible strings. Those get registered as DSI devices, and most DSI panel drivers are mipi_dsi_drivers that attach to those nodes. There is one special case currently, the adv7533 bridge, where the bridge probes

Re: [PATCH] liquidio: lio_main: remove unnecessary static in setup_io_queues()

2017-07-18 Thread Felix Manlunas
On Tue, Jul 18, 2017 at 03:53:48PM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary static on local variables cpu_id_modulus and cpu_id. > Such variables are initialized before being used, on every execution > path throughout the function. The static has no benefit and, removing > it reduces

Re: [PATCH] liquidio: lio_main: remove unnecessary static in setup_io_queues()

2017-07-18 Thread Felix Manlunas
On Tue, Jul 18, 2017 at 03:53:48PM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary static on local variables cpu_id_modulus and cpu_id. > Such variables are initialized before being used, on every execution > path throughout the function. The static has no benefit and, removing > it reduces

[PATCH v5 2/6] drm/bridge: Add a devm_ allocator for panel bridge.

2017-07-18 Thread Eric Anholt
This will let drivers reduce the error cleanup they need, in particular the "is_panel_bridge" flag. v2: Slight cleanup of remove function by Andrzej Signed-off-by: Eric Anholt Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/panel.c | 30

[PATCH v5 2/6] drm/bridge: Add a devm_ allocator for panel bridge.

2017-07-18 Thread Eric Anholt
This will let drivers reduce the error cleanup they need, in particular the "is_panel_bridge" flag. v2: Slight cleanup of remove function by Andrzej Signed-off-by: Eric Anholt Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/panel.c | 30 ++

[PATCH v5 6/6] drm/panel: Add support for the Raspberry Pi 7" Touchscreen.

2017-07-18 Thread Eric Anholt
This driver communicates with the Atmel microcontroller for sequencing the poweron of the TC358762 DSI-DPI bridge and controlling the backlight PWM. v2: Set the same default orientation as the closed source firmware used, which is the best for viewing angle. v3: Rewrite as an i2c client

[PATCH v5 6/6] drm/panel: Add support for the Raspberry Pi 7" Touchscreen.

2017-07-18 Thread Eric Anholt
This driver communicates with the Atmel microcontroller for sequencing the poweron of the TC358762 DSI-DPI bridge and controlling the backlight PWM. v2: Set the same default orientation as the closed source firmware used, which is the best for viewing angle. v3: Rewrite as an i2c client

[PATCH v5 1/6] drm/vc4: Avoid using vrefresh==0 mode in DSI htotal math.

2017-07-18 Thread Eric Anholt
The incoming mode might have a missing vrefresh field if it came from drmModeSetCrtc(), which the kernel is supposed to calculate using drm_mode_vrefresh(). We could either use that or the adjusted_mode's original vrefresh value. However, we can maintain a more exact vrefresh value (not just the

[PATCH v5 3/6] drm/vc4: Delay DSI host registration until the panel has probed.

2017-07-18 Thread Eric Anholt
The vc4 driver was unusual in that it was delaying the panel lookup until the attach step, while most DSI hosts will -EPROBE_DEFER until they get a panel. v2: Drop a debug message that slipped in. Signed-off-by: Eric Anholt Reviewed-by: Andrzej Hajda (v1)

[PATCH v5 1/6] drm/vc4: Avoid using vrefresh==0 mode in DSI htotal math.

2017-07-18 Thread Eric Anholt
The incoming mode might have a missing vrefresh field if it came from drmModeSetCrtc(), which the kernel is supposed to calculate using drm_mode_vrefresh(). We could either use that or the adjusted_mode's original vrefresh value. However, we can maintain a more exact vrefresh value (not just the

[PATCH v5 3/6] drm/vc4: Delay DSI host registration until the panel has probed.

2017-07-18 Thread Eric Anholt
The vc4 driver was unusual in that it was delaying the panel lookup until the attach step, while most DSI hosts will -EPROBE_DEFER until they get a panel. v2: Drop a debug message that slipped in. Signed-off-by: Eric Anholt Reviewed-by: Andrzej Hajda (v1) --- drivers/gpu/drm/vc4/vc4_dsi.c |

Re: [PATCH] liquidio: lio_vf_main: remove unnecessary static in setup_io_queues()

2017-07-18 Thread Felix Manlunas
On Tue, Jul 18, 2017 at 03:50:15PM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary static on local variables cpu_id_modulus and cpu_id. > Such variables are initialized before being used, on every execution > path throughout the function. The static has no benefit and, removing > it reduces

Re: [PATCH] liquidio: lio_vf_main: remove unnecessary static in setup_io_queues()

2017-07-18 Thread Felix Manlunas
On Tue, Jul 18, 2017 at 03:50:15PM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary static on local variables cpu_id_modulus and cpu_id. > Such variables are initialized before being used, on every execution > path throughout the function. The static has no benefit and, removing > it reduces

[PATCH] rtlwifi: remove useless code

2017-07-18 Thread Gustavo A. R. Silva
Remove useless local variables last_read_point and last_txw_point and the code related. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH] rtlwifi: remove useless code

2017-07-18 Thread Gustavo A. R. Silva
Remove useless local variables last_read_point and last_txw_point and the code related. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c

[PATCH] wireless: airo: remove unnecessary static in writerids()

2017-07-18 Thread Gustavo A. R. Silva
Remove unnecessary static on local function pointer _writer_. Such pointer is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the following

[PATCH] wireless: airo: remove unnecessary static in writerids()

2017-07-18 Thread Gustavo A. R. Silva
Remove unnecessary static on local function pointer _writer_. Such pointer is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the following

4.12.0: igb: transmit queue 7 timed out

2017-07-18 Thread Justin Piszcz
Hello, Kernel: 4.12.0 Arch: x86_64 What causes this issue? [199141.434449] NETDEV WATCHDOG: eth1 (igb): transmit queue 7 timed out [199141.434501] [ cut here ] [199141.434515] WARNING: CPU: 10 PID: 0 at net/sched/sch_generic.c:316 dev_watchdog+0x212/0x220 [199141.434528]

4.12.0: igb: transmit queue 7 timed out

2017-07-18 Thread Justin Piszcz
Hello, Kernel: 4.12.0 Arch: x86_64 What causes this issue? [199141.434449] NETDEV WATCHDOG: eth1 (igb): transmit queue 7 timed out [199141.434501] [ cut here ] [199141.434515] WARNING: CPU: 10 PID: 0 at net/sched/sch_generic.c:316 dev_watchdog+0x212/0x220 [199141.434528]

Re: [PATCH] ASoC: sgtl5000: add AVC configuration controls

2017-07-18 Thread Richard Leitner
On 07/18/2017 03:55 PM, Mark Brown wrote: On Tue, Jun 06, 2017 at 02:04:22PM +0200, Richard Leitner wrote: For the configuration of the automatic volume control block (AVC), which reduces loud signals and amplifies low level signals for easier listening, following controls are added: This

Re: [PATCH] oom_reaper: close race without using oom_lock

2017-07-18 Thread Tetsuo Handa
Michal Hocko wrote: > On Tue 18-07-17 23:06:50, Tetsuo Handa wrote: > > Commit e2fe14564d3316d1 ("oom_reaper: close race with exiting task") > > guarded whole OOM reaping operations using oom_lock. But there was no > > need to guard whole operations. We needed to guard only setting of > >

Re: [PATCH] ASoC: sgtl5000: add AVC configuration controls

2017-07-18 Thread Richard Leitner
On 07/18/2017 03:55 PM, Mark Brown wrote: On Tue, Jun 06, 2017 at 02:04:22PM +0200, Richard Leitner wrote: For the configuration of the automatic volume control block (AVC), which reduces loud signals and amplifies low level signals for easier listening, following controls are added: This

Re: [PATCH] oom_reaper: close race without using oom_lock

2017-07-18 Thread Tetsuo Handa
Michal Hocko wrote: > On Tue 18-07-17 23:06:50, Tetsuo Handa wrote: > > Commit e2fe14564d3316d1 ("oom_reaper: close race with exiting task") > > guarded whole OOM reaping operations using oom_lock. But there was no > > need to guard whole operations. We needed to guard only setting of > >

Re: [PATCH] cgroup: Show control files in cgroup2 root after mount

2017-07-18 Thread Tejun Heo
Hello, On Tue, Jul 18, 2017 at 04:29:40PM -0400, Waiman Long wrote: > I think the kernfs_activate() call is for the cgroup1 mount of debug kernfs_activate() there is for any files which are created while a controller moves between hierarchies, so, yeah, during boot, this is where the root files

Re: [PATCH] cgroup: Show control files in cgroup2 root after mount

2017-07-18 Thread Tejun Heo
Hello, On Tue, Jul 18, 2017 at 04:29:40PM -0400, Waiman Long wrote: > I think the kernfs_activate() call is for the cgroup1 mount of debug kernfs_activate() there is for any files which are created while a controller moves between hierarchies, so, yeah, during boot, this is where the root files

Re: [PATCH v2] drm/i915: Consistently use enum pipe for PCH transcoders

2017-07-18 Thread Matthias Kaehlcke
Hi Daniel, El Tue, Jul 18, 2017 at 08:39:50AM +0200 Daniel Vetter ha dit: > On Mon, Jul 17, 2017 at 11:14:03AM -0700, Matthias Kaehlcke wrote: > > The current code uses in some instances enum transcoder for PCH > > transcoders and enum pipe in others. This is error prone and clang > > raises

Re: [PATCH v2] drm/i915: Consistently use enum pipe for PCH transcoders

2017-07-18 Thread Matthias Kaehlcke
Hi Daniel, El Tue, Jul 18, 2017 at 08:39:50AM +0200 Daniel Vetter ha dit: > On Mon, Jul 17, 2017 at 11:14:03AM -0700, Matthias Kaehlcke wrote: > > The current code uses in some instances enum transcoder for PCH > > transcoders and enum pipe in others. This is error prone and clang > > raises

[PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw()

2017-07-18 Thread Gustavo A. R. Silva
Remove unnecessary static on local variable fw_dump_ops. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the following semantic

[PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw()

2017-07-18 Thread Gustavo A. R. Silva
Remove unnecessary static on local variable fw_dump_ops. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the following semantic

Re: [PATCH] efifb: allow user to disable write combined mapping.

2017-07-18 Thread Dave Airlie
On 19 July 2017 at 05:57, Linus Torvalds wrote: > On Tue, Jul 18, 2017 at 7:34 AM, Peter Jones wrote: >> >> Well, that's kind of amazing, given 3c004b4f7eab239e switched us /to/ >> using ioremap_wc() for the exact same reason. I'm not against

Re: [PATCH] efifb: allow user to disable write combined mapping.

2017-07-18 Thread Dave Airlie
On 19 July 2017 at 05:57, Linus Torvalds wrote: > On Tue, Jul 18, 2017 at 7:34 AM, Peter Jones wrote: >> >> Well, that's kind of amazing, given 3c004b4f7eab239e switched us /to/ >> using ioremap_wc() for the exact same reason. I'm not against letting >> the user force one way or the other if it

Re: [PATCH] cgroup: Show control files in cgroup2 root after mount

2017-07-18 Thread Waiman Long
On 07/18/2017 04:12 PM, Tejun Heo wrote: > Hello, > > On Tue, Jul 18, 2017 at 04:00:45PM -0400, Waiman Long wrote: >> From my own debugging, the controller files (e.g. the debug controller) >> were indirectly populated by the rebind_subsystems() call. >> >> [1.628103] css_populate_dir: init

Re: [PATCH] cgroup: Show control files in cgroup2 root after mount

2017-07-18 Thread Waiman Long
On 07/18/2017 04:12 PM, Tejun Heo wrote: > Hello, > > On Tue, Jul 18, 2017 at 04:00:45PM -0400, Waiman Long wrote: >> From my own debugging, the controller files (e.g. the debug controller) >> were indirectly populated by the rebind_subsystems() call. >> >> [1.628103] css_populate_dir: init

[PATCH net-next] net: dsa: unexport dsa_is_port_initialized

2017-07-18 Thread Vivien Didelot
The dsa_is_port_initialized helper is only used by dsa_switch_resume and dsa_switch_suspend, if CONFIG_PM_SLEEP is enabled. Make it static to dsa.c. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 5 - net/dsa/dsa.c | 5 + 2 files changed,

[PATCH net-next] net: dsa: unexport dsa_is_port_initialized

2017-07-18 Thread Vivien Didelot
The dsa_is_port_initialized helper is only used by dsa_switch_resume and dsa_switch_suspend, if CONFIG_PM_SLEEP is enabled. Make it static to dsa.c. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 5 - net/dsa/dsa.c | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff

Re: [PATCH] lib/strscpy: avoid KASAN false positive

2017-07-18 Thread Linus Torvalds
On Tue, Jul 18, 2017 at 1:15 PM, Andrey Ryabinin wrote: > > No, it does warn about valid users. The report that Dave posted wasn't about > wrong strscpy() usage > it was about reading 8-bytes from 5-bytes source string. It wasn't about > buggy 'count' at all. > So KASAN

Re: [PATCH] lib/strscpy: avoid KASAN false positive

2017-07-18 Thread Linus Torvalds
On Tue, Jul 18, 2017 at 1:15 PM, Andrey Ryabinin wrote: > > No, it does warn about valid users. The report that Dave posted wasn't about > wrong strscpy() usage > it was about reading 8-bytes from 5-bytes source string. It wasn't about > buggy 'count' at all. > So KASAN will warn for perfectly

Re: [PATCH 2/2] sysfs: add devm_sysfs_create_group() and friends

2017-07-18 Thread Dmitry Torokhov
On Tue, Jul 18, 2017 at 10:03:36PM +0200, Greg Kroah-Hartman wrote: > On Tue, Jul 18, 2017 at 12:30:58PM -0700, Dmitry Torokhov wrote: > > --- a/include/linux/sysfs.h > > +++ b/include/linux/sysfs.h > > @@ -282,6 +282,16 @@ int __compat_only_sysfs_link_entry_to_kobj(struct > > kobject *kobj, > >

Re: [PATCH 2/2] sysfs: add devm_sysfs_create_group() and friends

2017-07-18 Thread Dmitry Torokhov
On Tue, Jul 18, 2017 at 10:03:36PM +0200, Greg Kroah-Hartman wrote: > On Tue, Jul 18, 2017 at 12:30:58PM -0700, Dmitry Torokhov wrote: > > --- a/include/linux/sysfs.h > > +++ b/include/linux/sysfs.h > > @@ -282,6 +282,16 @@ int __compat_only_sysfs_link_entry_to_kobj(struct > > kobject *kobj, > >

Re: [PATCH 07/14] proc/kcore: hide a harmless warning

2017-07-18 Thread Arnd Bergmann
On Tue, Jul 18, 2017 at 10:07 PM, Ard Biesheuvel wrote: > On 18 July 2017 at 21:01, Arnd Bergmann wrote: >> On Tue, Jul 18, 2017 at 9:55 PM, Ard Biesheuvel > > Ah, now it makes sense. I was a bit surprised that > -Wtautological-compare complains about

Re: [PATCH 07/14] proc/kcore: hide a harmless warning

2017-07-18 Thread Arnd Bergmann
On Tue, Jul 18, 2017 at 10:07 PM, Ard Biesheuvel wrote: > On 18 July 2017 at 21:01, Arnd Bergmann wrote: >> On Tue, Jul 18, 2017 at 9:55 PM, Ard Biesheuvel > > Ah, now it makes sense. I was a bit surprised that > -Wtautological-compare complains about symbolic constants that resolve > to the

Re: [PATCH v2 1/2] livepatch: introduce shadow variable API

2017-07-18 Thread Joe Lawrence
On Mon, Jul 17, 2017 at 05:29:41PM +0200, Miroslav Benes wrote: > > On Wed, 28 Jun 2017, Joe Lawrence wrote: > > > +Brief API summary > > +- > > + [ ... snip ...] > > +* klp_shadow_detach() - detach and free all <*, num> shadow variables > > + - find and remove any <*, num>

Re: [PATCH v2 1/2] livepatch: introduce shadow variable API

2017-07-18 Thread Joe Lawrence
On Mon, Jul 17, 2017 at 05:29:41PM +0200, Miroslav Benes wrote: > > On Wed, 28 Jun 2017, Joe Lawrence wrote: > > > +Brief API summary > > +- > > + [ ... snip ...] > > +* klp_shadow_detach() - detach and free all <*, num> shadow variables > > + - find and remove any <*, num>

Re: [PATCH v6 3/3] clk: stm32h7: Add stm32h743 clock driver

2017-07-18 Thread Vladimir Zapolskiy
Hello Gabriel, On 07/18/2017 10:53 AM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch enables clocks for STM32H743 boards. > > Signed-off-by: Gabriel Fernandez > > for MFD changes: > Acked-by: Lee Jones

Re: [PATCH v6 3/3] clk: stm32h7: Add stm32h743 clock driver

2017-07-18 Thread Vladimir Zapolskiy
Hello Gabriel, On 07/18/2017 10:53 AM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch enables clocks for STM32H743 boards. > > Signed-off-by: Gabriel Fernandez > > for MFD changes: > Acked-by: Lee Jones > > for DT-Bindings > Acked-by: Rob Herring > --- >

Re: [PATCH 1/3] ACPI / blacklist: add acpi_match_oemlist() interface

2017-07-18 Thread Kani, Toshimitsu
On Tue, 2017-07-18 at 21:32 +0200, Borislav Petkov wrote: > On Tue, Jul 18, 2017 at 06:49:51PM +, Kani, Toshimitsu wrote: > > ghes_edac uses this structure as a while-list, so the term backlist > > is misleading. > > So this matching function gets both blacklists and whitelists. No > wonder

Re: [PATCH 1/3] ACPI / blacklist: add acpi_match_oemlist() interface

2017-07-18 Thread Kani, Toshimitsu
On Tue, 2017-07-18 at 21:32 +0200, Borislav Petkov wrote: > On Tue, Jul 18, 2017 at 06:49:51PM +, Kani, Toshimitsu wrote: > > ghes_edac uses this structure as a while-list, so the term backlist > > is misleading. > > So this matching function gets both blacklists and whitelists. No > wonder

Re: [PATCH] lib/strscpy: avoid KASAN false positive

2017-07-18 Thread Andrey Ryabinin
On 07/18/2017 08:22 PM, Linus Torvalds wrote: > On Tue, Jul 18, 2017 at 10:15 AM, Andrey Ryabinin > wrote: >> >> + /* >> +* KASAN won't be happy about word-at-a-time >> +* optimistic reads, so let's avoid them. >> +*/ >> + if

Re: [PATCH] lib/strscpy: avoid KASAN false positive

2017-07-18 Thread Andrey Ryabinin
On 07/18/2017 08:22 PM, Linus Torvalds wrote: > On Tue, Jul 18, 2017 at 10:15 AM, Andrey Ryabinin > wrote: >> >> + /* >> +* KASAN won't be happy about word-at-a-time >> +* optimistic reads, so let's avoid them. >> +*/ >> + if (IS_ENABLED(CONFIG_KASAN)) >> +

Re: [PATCH net-next 0/5] refine virtio-net XDP

2017-07-18 Thread Michael S. Tsirkin
On Mon, Jul 17, 2017 at 08:43:56PM +0800, Jason Wang wrote: > Hi: > > This series brings two optimizations for virtio-net XDP: > > - avoid reset during XDP set > - turn off offloads on demand I'm glad to see this take shape - this can be extended to optimize virtnet_get_headroom so we don't

Re: [PATCH net-next 0/5] refine virtio-net XDP

2017-07-18 Thread Michael S. Tsirkin
On Mon, Jul 17, 2017 at 08:43:56PM +0800, Jason Wang wrote: > Hi: > > This series brings two optimizations for virtio-net XDP: > > - avoid reset during XDP set > - turn off offloads on demand I'm glad to see this take shape - this can be extended to optimize virtnet_get_headroom so we don't

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

2017-07-18 Thread Eric Anholt
Archit Taneja writes: > On 07/15/2017 04:28 AM, Eric Anholt wrote: >> Archit Taneja writes: >> >>> On 06/28/2017 01:28 AM, Eric Anholt wrote: When a mipi_dsi_host is registered, the DT is walked to find any child nodes with compatible

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

2017-07-18 Thread Eric Anholt
Archit Taneja writes: > On 07/15/2017 04:28 AM, Eric Anholt wrote: >> Archit Taneja writes: >> >>> On 06/28/2017 01:28 AM, Eric Anholt wrote: When a mipi_dsi_host is registered, the DT is walked to find any child nodes with compatible strings. Those get registered as DSI devices,

Re: [PATCH] cgroup: Show control files in cgroup2 root after mount

2017-07-18 Thread Tejun Heo
Hello, On Tue, Jul 18, 2017 at 04:00:45PM -0400, Waiman Long wrote: > From my own debugging, the controller files (e.g. the debug controller) > were indirectly populated by the rebind_subsystems() call. > > [1.628103] css_populate_dir: init subsystem debug ... > [1.654975]

Re: [PATCH] cgroup: Show control files in cgroup2 root after mount

2017-07-18 Thread Tejun Heo
Hello, On Tue, Jul 18, 2017 at 04:00:45PM -0400, Waiman Long wrote: > From my own debugging, the controller files (e.g. the debug controller) > were indirectly populated by the rebind_subsystems() call. > > [1.628103] css_populate_dir: init subsystem debug ... > [1.654975]

Re: bug? dwc2: insufficient fifo memory

2017-07-18 Thread John Stultz
On Mon, Jun 5, 2017 at 10:50 AM, John Youn wrote: > On 6/5/2017 5:32 AM, Minas Harutyunyan wrote: >> On 6/2/2017 10:20 PM, John Stultz wrote: >>> On Mon, Apr 17, 2017 at 3:36 PM, John Stultz wrote: On Fri, Feb 24, 2017 at 2:46 PM, John Stultz

Re: bug? dwc2: insufficient fifo memory

2017-07-18 Thread John Stultz
On Mon, Jun 5, 2017 at 10:50 AM, John Youn wrote: > On 6/5/2017 5:32 AM, Minas Harutyunyan wrote: >> On 6/2/2017 10:20 PM, John Stultz wrote: >>> On Mon, Apr 17, 2017 at 3:36 PM, John Stultz wrote: On Fri, Feb 24, 2017 at 2:46 PM, John Stultz wrote: > Hey John, > So after

[tip:irq/urgent] irqchip/digicolor: Drop unnecessary static

2017-07-18 Thread tip-bot for Julia Lawall
Commit-ID: acc80c39929b9f2ff8b45fcfe103385a3e45c1a7 Gitweb: http://git.kernel.org/tip/acc80c39929b9f2ff8b45fcfe103385a3e45c1a7 Author: Julia Lawall AuthorDate: Sat, 15 Jul 2017 22:07:45 +0200 Committer: Thomas Gleixner CommitDate: Tue, 18 Jul

[tip:irq/urgent] irqchip/digicolor: Drop unnecessary static

2017-07-18 Thread tip-bot for Julia Lawall
Commit-ID: acc80c39929b9f2ff8b45fcfe103385a3e45c1a7 Gitweb: http://git.kernel.org/tip/acc80c39929b9f2ff8b45fcfe103385a3e45c1a7 Author: Julia Lawall AuthorDate: Sat, 15 Jul 2017 22:07:45 +0200 Committer: Thomas Gleixner CommitDate: Tue, 18 Jul 2017 21:59:23 +0200 irqchip/digicolor:

Re: [PATCH v5 2/5] tick: Add freeze timer events

2017-07-18 Thread dbasehore .
On Mon, Jul 17, 2017 at 11:40 PM, Thomas Gleixner wrote: > On Mon, 17 Jul 2017, dbasehore . wrote: >> On Mon, Jul 17, 2017 at 6:33 PM, Rafael J. Wysocki wrote: >> I could make a patch to try it out. I would probably add a flag to rtc >> timers to indicate

Re: [PATCH v5 2/5] tick: Add freeze timer events

2017-07-18 Thread dbasehore .
On Mon, Jul 17, 2017 at 11:40 PM, Thomas Gleixner wrote: > On Mon, 17 Jul 2017, dbasehore . wrote: >> On Mon, Jul 17, 2017 at 6:33 PM, Rafael J. Wysocki wrote: >> I could make a patch to try it out. I would probably add a flag to rtc >> timers to indicate whether it wakes the system (default

[tip:irq/urgent] irqchip/mips-cpu: Drop unnecessary static

2017-07-18 Thread tip-bot for Julia Lawall
Commit-ID: 82faeffa7e130e2ae43aa681a34c02d56dabd177 Gitweb: http://git.kernel.org/tip/82faeffa7e130e2ae43aa681a34c02d56dabd177 Author: Julia Lawall AuthorDate: Sat, 15 Jul 2017 22:07:41 +0200 Committer: Thomas Gleixner CommitDate: Tue, 18 Jul

[tip:irq/urgent] irqchip/mips-cpu: Drop unnecessary static

2017-07-18 Thread tip-bot for Julia Lawall
Commit-ID: 82faeffa7e130e2ae43aa681a34c02d56dabd177 Gitweb: http://git.kernel.org/tip/82faeffa7e130e2ae43aa681a34c02d56dabd177 Author: Julia Lawall AuthorDate: Sat, 15 Jul 2017 22:07:41 +0200 Committer: Thomas Gleixner CommitDate: Tue, 18 Jul 2017 21:59:22 +0200 irqchip/mips-cpu: Drop

[tip:irq/urgent] irqchip/gic/realview: Drop unnecessary static

2017-07-18 Thread tip-bot for Julia Lawall
Commit-ID: 512f9e790897e84d5b802436768508ee4628fc16 Gitweb: http://git.kernel.org/tip/512f9e790897e84d5b802436768508ee4628fc16 Author: Julia Lawall AuthorDate: Sat, 15 Jul 2017 22:07:40 +0200 Committer: Thomas Gleixner CommitDate: Tue, 18 Jul

[tip:irq/urgent] irqchip/gic/realview: Drop unnecessary static

2017-07-18 Thread tip-bot for Julia Lawall
Commit-ID: 512f9e790897e84d5b802436768508ee4628fc16 Gitweb: http://git.kernel.org/tip/512f9e790897e84d5b802436768508ee4628fc16 Author: Julia Lawall AuthorDate: Sat, 15 Jul 2017 22:07:40 +0200 Committer: Thomas Gleixner CommitDate: Tue, 18 Jul 2017 21:59:22 +0200 irqchip/gic/realview:

Re: [PATCH 1/4] rtc-lib: Add rtc_show_time(const char *prefix_msg)

2017-07-18 Thread Mark Salyzyn
On 07/18/2017 01:00 PM, Mark Salyzyn wrote: On 07/18/2017 10:52 AM, Alexandre Belloni wrote: Hi, On 18/07/2017 at 10:25:23 -0700, Mark Salyzyn wrote: . . . Apart from using rtc_time_to_tm (and you should probably use rtc_time64_to_tm), none of this is actually related to the RTC subsystem. I

Re: [PATCH 1/4] rtc-lib: Add rtc_show_time(const char *prefix_msg)

2017-07-18 Thread Mark Salyzyn
On 07/18/2017 01:00 PM, Mark Salyzyn wrote: On 07/18/2017 10:52 AM, Alexandre Belloni wrote: Hi, On 18/07/2017 at 10:25:23 -0700, Mark Salyzyn wrote: . . . Apart from using rtc_time_to_tm (and you should probably use rtc_time64_to_tm), none of this is actually related to the RTC subsystem. I

Re: [PATCH net-next 5/5] virtio-net: switch off offloads on demand if possible on XDP set

2017-07-18 Thread Michael S. Tsirkin
On Mon, Jul 17, 2017 at 08:44:01PM +0800, Jason Wang wrote: > Current XDP implementation want guest offloads feature to be disabled s/want/wants/ > on qemu cli. on the device. > This is inconvenient and means guest can't benefit from > offloads if XDP is not used. This patch tries to address

Re: [PATCH net-next 5/5] virtio-net: switch off offloads on demand if possible on XDP set

2017-07-18 Thread Michael S. Tsirkin
On Mon, Jul 17, 2017 at 08:44:01PM +0800, Jason Wang wrote: > Current XDP implementation want guest offloads feature to be disabled s/want/wants/ > on qemu cli. on the device. > This is inconvenient and means guest can't benefit from > offloads if XDP is not used. This patch tries to address

Re: [PATCH 07/14] proc/kcore: hide a harmless warning

2017-07-18 Thread Ard Biesheuvel
On 18 July 2017 at 21:01, Arnd Bergmann wrote: > On Tue, Jul 18, 2017 at 9:55 PM, Ard Biesheuvel > wrote: >> On 18 July 2017 at 20:53, Arnd Bergmann wrote: >>> On Fri, Jul 14, 2017 at 2:28 PM, Ard Biesheuvel >>>

Re: [PATCH 07/14] proc/kcore: hide a harmless warning

2017-07-18 Thread Ard Biesheuvel
On 18 July 2017 at 21:01, Arnd Bergmann wrote: > On Tue, Jul 18, 2017 at 9:55 PM, Ard Biesheuvel > wrote: >> On 18 July 2017 at 20:53, Arnd Bergmann wrote: >>> On Fri, Jul 14, 2017 at 2:28 PM, Ard Biesheuvel >>> wrote: On 14 July 2017 at 10:25, Arnd Bergmann wrote: > gcc warns when

Re: [PATCH 0/2] New bind/unbingd uevents

2017-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2017 at 12:30:56PM -0700, Dmitry Torokhov wrote: > Hi Greg, > > I am resending the bind/unbind and devm_sysfs_create_group() patches, > as you requested. The new bind/unbind will allow triggering firmware > update through udev, and the new sysfs API will cut down on some >

Re: [PATCH 0/2] New bind/unbingd uevents

2017-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2017 at 12:30:56PM -0700, Dmitry Torokhov wrote: > Hi Greg, > > I am resending the bind/unbind and devm_sysfs_create_group() patches, > as you requested. The new bind/unbind will allow triggering firmware > update through udev, and the new sysfs API will cut down on some >

Re: [PATCH 1/1] mm/slub.c: add a naive detection of double free or corruption

2017-07-18 Thread Kees Cook
On Tue, Jul 18, 2017 at 12:56 PM, Alexander Popov wrote: > On 17.07.2017 22:11, Kees Cook wrote: >> On Mon, Jul 17, 2017 at 12:01 PM, Alexander Popov >> wrote: >>> Hello Christopher, >>> >>> Thanks for your reply. >>> >>> On 17.07.2017 21:04,

Re: [PATCH 1/1] mm/slub.c: add a naive detection of double free or corruption

2017-07-18 Thread Kees Cook
On Tue, Jul 18, 2017 at 12:56 PM, Alexander Popov wrote: > On 17.07.2017 22:11, Kees Cook wrote: >> On Mon, Jul 17, 2017 at 12:01 PM, Alexander Popov >> wrote: >>> Hello Christopher, >>> >>> Thanks for your reply. >>> >>> On 17.07.2017 21:04, Christopher Lameter wrote: On Mon, 17 Jul 2017,

Re: [PATCH 2/2] sysfs: add devm_sysfs_create_group() and friends

2017-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2017 at 12:30:58PM -0700, Dmitry Torokhov wrote: > --- a/include/linux/sysfs.h > +++ b/include/linux/sysfs.h > @@ -282,6 +282,16 @@ int __compat_only_sysfs_link_entry_to_kobj(struct > kobject *kobj, > struct kobject *target_kobj, >

Re: [PATCH 2/2] sysfs: add devm_sysfs_create_group() and friends

2017-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2017 at 12:30:58PM -0700, Dmitry Torokhov wrote: > --- a/include/linux/sysfs.h > +++ b/include/linux/sysfs.h > @@ -282,6 +282,16 @@ int __compat_only_sysfs_link_entry_to_kobj(struct > kobject *kobj, > struct kobject *target_kobj, >

Re: [PATCH 07/14] proc/kcore: hide a harmless warning

2017-07-18 Thread Arnd Bergmann
On Tue, Jul 18, 2017 at 9:55 PM, Ard Biesheuvel wrote: > On 18 July 2017 at 20:53, Arnd Bergmann wrote: >> On Fri, Jul 14, 2017 at 2:28 PM, Ard Biesheuvel >> wrote: >>> On 14 July 2017 at 10:25, Arnd Bergmann

Re: [PATCH 07/14] proc/kcore: hide a harmless warning

2017-07-18 Thread Arnd Bergmann
On Tue, Jul 18, 2017 at 9:55 PM, Ard Biesheuvel wrote: > On 18 July 2017 at 20:53, Arnd Bergmann wrote: >> On Fri, Jul 14, 2017 at 2:28 PM, Ard Biesheuvel >> wrote: >>> On 14 July 2017 at 10:25, Arnd Bergmann wrote: gcc warns when MODULES_VADDR/END is defined to the same value as

Re: [PATCH] cgroup: Show control files in cgroup2 root after mount

2017-07-18 Thread Waiman Long
On 07/18/2017 03:51 PM, Tejun Heo wrote: > Hello, Waiman. > > On Tue, Jul 18, 2017 at 03:32:16PM -0400, Waiman Long wrote: >> It was found that when a cgroup2 filesystem was mounted, control >> files other than the base cgroup.* ones were not shown in the root >> directory. They were shown only

Re: [PATCH] cgroup: Show control files in cgroup2 root after mount

2017-07-18 Thread Waiman Long
On 07/18/2017 03:51 PM, Tejun Heo wrote: > Hello, Waiman. > > On Tue, Jul 18, 2017 at 03:32:16PM -0400, Waiman Long wrote: >> It was found that when a cgroup2 filesystem was mounted, control >> files other than the base cgroup.* ones were not shown in the root >> directory. They were shown only

Re: [PATCH 1/4] rtc-lib: Add rtc_show_time(const char *prefix_msg)

2017-07-18 Thread Mark Salyzyn
On 07/18/2017 10:52 AM, Alexandre Belloni wrote: Hi, On 18/07/2017 at 10:25:23 -0700, Mark Salyzyn wrote: . . . Apart from using rtc_time_to_tm (and you should probably use rtc_time64_to_tm), none of this is actually related to the RTC subsystem. I feel like you should find another place to

Re: [PATCH 1/4] rtc-lib: Add rtc_show_time(const char *prefix_msg)

2017-07-18 Thread Mark Salyzyn
On 07/18/2017 10:52 AM, Alexandre Belloni wrote: Hi, On 18/07/2017 at 10:25:23 -0700, Mark Salyzyn wrote: . . . Apart from using rtc_time_to_tm (and you should probably use rtc_time64_to_tm), none of this is actually related to the RTC subsystem. I feel like you should find another place to

Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops

2017-07-18 Thread Andrew Lunn
> I know this looks boring, I do not particularly enjoy it myself, but I > think this is also important. I don't mind fixing the poking function as > well in the near future. It would be great if you do. It could be as simple as using phy_ethtool_get_eee() and phy_ethtool_set_eee(). Andrew

Re: [PATCH 3/3] ghes_edac: add platform check to enable ghes_edac

2017-07-18 Thread Kani, Toshimitsu
On Tue, 2017-07-18 at 08:00 +0200, Borislav Petkov wrote: > On Mon, Jul 17, 2017 at 03:59:12PM -0600, Toshi Kani wrote: > > The ghes_edac driver was introduced in 2013 [1], but it has not > > been enabled by any distro yet.  This driver obtains error info > > from firmware interfaces, which are

Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops

2017-07-18 Thread Andrew Lunn
> I know this looks boring, I do not particularly enjoy it myself, but I > think this is also important. I don't mind fixing the poking function as > well in the near future. It would be great if you do. It could be as simple as using phy_ethtool_get_eee() and phy_ethtool_set_eee(). Andrew

Re: [PATCH 3/3] ghes_edac: add platform check to enable ghes_edac

2017-07-18 Thread Kani, Toshimitsu
On Tue, 2017-07-18 at 08:00 +0200, Borislav Petkov wrote: > On Mon, Jul 17, 2017 at 03:59:12PM -0600, Toshi Kani wrote: > > The ghes_edac driver was introduced in 2013 [1], but it has not > > been enabled by any distro yet.  This driver obtains error info > > from firmware interfaces, which are

<    3   4   5   6   7   8   9   10   11   12   >