[PATCH 07/12] blkcg: replace with

2017-10-08 Thread Masahiro Yamada
This header requires the definition of struct radix_tree_root, but does not need to know anything about other radix tree stuff. Include instead of to reduce the header dependency. Signed-off-by: Masahiro Yamada --- include/linux/blk-cgroup.h | 2 +- 1 file

[PATCH 11/12] net/mlx5: replace with

2017-10-08 Thread Masahiro Yamada
The header include/linux/mlx5/driver.h requires the definition of struct radix_tree_root, but does not need to know anything about other radix tree stuff. Include instead of to reduce the number of included header files. Also, add to include/linux/mlx5/gp.h where radix tree accessors are

[PATCH 00/12] radix-tree: split out struct radix_tree_root out to

2017-10-08 Thread Masahiro Yamada
The motivation of this series is to cut down unnecessary header dependency in terms of radix tree. Sub-systems or drivers that use radix-tree for data management typically embed struct radix_tree_root in their data structures, like this: struct foo { ... struct radix_tree_root

[PATCH 10/12] net/mlx4: replace with

2017-10-08 Thread Masahiro Yamada
The headers - include/linux/mlx4/device.h - drivers/net/ethernet/mellanox/mlx4/mlx4.h require the definition of struct radix_tree_root, but do not need to know anything about other radix tree stuff. Include instead of to reduce the header dependency. While we are here, let's add missing

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-08 Thread David Miller
From: Masahiro Yamada Date: Mon, 9 Oct 2017 01:10:11 +0900 > The headers > - include/linux/mlx4/device.h > - drivers/net/ethernet/mellanox/mlx4/mlx4.h > require the definition of struct radix_tree_root, but do not need to > know anything about other radix tree

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-08 Thread Joe Perches
On Mon, 2017-10-09 at 02:29 +0900, Masahiro Yamada wrote: > The idea is simple; include necessary headers explicitly. Try that for kernel.h There's a reason aggregation of #includes is useful.

Re: [PATCH] MAINTAINERS: Add entry for the PEAQ WMI hotkeys driver

2017-10-08 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 5:31 PM, Hans de Goede wrote: > Add an entry to make myself the maintainer of the PEAQ WMI hotkeys driver. Pushed to my review queue, thanks! > > Signed-off-by: Hans de Goede > --- > MAINTAINERS | 6 ++ > 1 file changed, 6

Re: [PATCH v5 09/14] platform/x86: dell-smbios: Introduce dispatcher for SMM calls

2017-10-08 Thread Andy Shevchenko
On Sun, Oct 8, 2017 at 6:48 PM, Andy Shevchenko wrote: > On Sat, Oct 7, 2017 at 7:59 AM, Mario Limonciello > wrote: >> This splits up the dell-smbios driver into two drivers: >> * dell-smbios >> * dell-smbios-smm >> >> dell-smbios can

Re: Building older mips kernels with different versions of binutils; possible patch for 3.2 and 3.4

2017-10-08 Thread Ben Hutchings
On Sun, 2016-05-15 at 19:56 -0700, Guenter Roeck wrote: [...] > For 3.4 and 3.2 kernels to build with binutils v2.24, it would be necessary to > apply patch c02263063362 ("MIPS: Refactor 'clear_page' and 'copy_page' > functions"). > It applies cleanly to 3.4, but has a Makefile conflict in 3.2.

Re: Linux 4.14: Reported regressions as of Sunday, 2017-10-08

2017-10-08 Thread Adam Borowski
On Sun, Oct 08, 2017 at 02:37:41PM +0200, Thorsten Leemhuis wrote: > Hi! Find below my second regression report for Linux 4.14. It lists 8 > regressions I'm currently aware of. One regression was fixed since last > weeks report. One was in there that shouldn't have been there. > > == Current

Re: [PATCH 00/12] radix-tree: split out struct radix_tree_root out to

2017-10-08 Thread Leon Romanovsky
On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote: <...> > > By splitting out the radix_tree_root definition, > we can reduce the header file dependency. > > Reducing the header dependency will help for speeding the kernel > build, suppressing unnecessary recompile of objects during

Re: [RFC v5 1/8] platform/x86: intel_pmc_ipc: Use spin_lock to protect GCR updates

2017-10-08 Thread Kuppuswamy, Sathyanarayanan
Hi Andy, On 10/8/2017 11:38 AM, Andy Shevchenko wrote: On Sun, Oct 8, 2017 at 1:19 AM, wrote: From: Kuppuswamy Sathyanarayanan Currently, update_no_reboot_bit() function implemented in this driver uses

Re: [RFC] workqueue: Fix irq inversion deadlock in manage_workers()

2017-10-08 Thread Tejun Heo
Hello, Boqun. On Sun, Oct 08, 2017 at 05:02:23PM +0800, Boqun Feng wrote: > Josef reported a HARDIRQ-safe -> HARDIRQ-unsafe lock order detected by > lockdep: > > | [ 1270.472259] WARNING: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected > | [ 1270.472783] 4.14.0-rc1-xfstests-12888-g76833e8

[PATCH] net/core: Fix BUG to BUG_ON conditionals.

2017-10-08 Thread Tim Hansen
Fix BUG() calls to use BUG_ON(conditional) macros. This was found using make coccicheck M=net/core on linux next tag next-20170929. Signed-off-by: Tim Hansen --- net/core/skbuff.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git

[BUG] haswell: A possible sleep-in-atomic bug in hsw_irq_thread

2017-10-08 Thread Jia-Ju Bai
According to sst-haswell-ipc.c, the driver may sleep under a spinlock, and the function call path is: hsw_irq_thread (acquire the spinlock) hsw_process_notification hsw_log_message mutex_lock --> may sleep This bug is found by my static analysis tool and my code review. Thanks,

[BUG] stmmac: A possible sleep-in-atomic bug in stmmac_suspend

2017-10-08 Thread Jia-Ju Bai
According to stmmac_main.c, the driver may sleep under a spinlock, and the function call path is: stmmac_suspend (acquire the spinlock) stmmac_disable_all_queues napi_disable might_sleep --> may sleep msleep --> may sleep This bug is found by my static analysis tool and my code

Re: [PATCH net-next RFC 8/9] net: dsa: mv88e6xxx: add rx/tx timestamping support

2017-10-08 Thread Richard Cochran
On Thu, Sep 28, 2017 at 10:25:40AM -0500, Brandon Streiff wrote: > +void mv88e6xxx_port_txtstamp(struct dsa_switch *ds, int port, > + struct sk_buff *clone, unsigned int type) > +{ > + struct mv88e6xxx_chip *chip = ds->priv; > + struct mv88e6xxx_port_hwtstamp *ps =

Re: [PATCH net-next RFC 0/9] net: dsa: PTP timestamping for mv88e6xxx

2017-10-08 Thread Richard Cochran
On Fri, Sep 29, 2017 at 05:43:23AM -0400, Richard Cochran wrote: > I happy to see this series. I just finished porting an out-of-tree > PHC driver for the Marvell mv88e635x, and I want to mainline it, but I > also have a few uglies. This series looks really good. I won't even post my mine, as

Re: [PATCH] platform/x86: intel_pmc_core: Add Package C-states residency info

2017-10-08 Thread Andy Shevchenko
On Sat, Aug 19, 2017 at 2:23 AM, Rajat Jain wrote: > On Fri, Aug 18, 2017 at 10:47 AM, Rajneesh Bhardwaj > wrote: >> On Fri, Aug 18, 2017 at 08:17:32PM +0300, Andy Shevchenko wrote: >>> On Fri, Aug 18, 2017 at 5:58 PM, Rajneesh Bhardwaj >>>

Re: [RFC v5 1/8] platform/x86: intel_pmc_ipc: Use spin_lock to protect GCR updates

2017-10-08 Thread Andy Shevchenko
On Sun, Oct 8, 2017 at 1:19 AM, wrote: > From: Kuppuswamy Sathyanarayanan > > Currently, update_no_reboot_bit() function implemented in this driver > uses mutex_lock() to protect its register updates. But

Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-08 Thread Steven Rostedt
On Sun, 8 Oct 2017 01:42:15 -0700 Joel Fernandes wrote: > Hi Steve, > > > "Joel Fernandes (Google)" wrote: > [..] > > Also could you let me know what is the correct behavior of the filters > > after a module being traced is unloaded, are the filters

Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-08 Thread Joel Fernandes
Hi Steve, On Sun, Oct 8, 2017 at 11:42 AM, Steven Rostedt wrote: > On Sun, 8 Oct 2017 01:42:15 -0700 [..] >> > "Joel Fernandes (Google)" wrote: >> [..] >> > Also could you let me know what is the correct behavior of the filters >> > after a module

Re: [PATCH 3.2 00/46] 3.2.81-rc1 review

2017-10-08 Thread Ben Hutchings
On Tue, 2016-06-14 at 23:35 +0100, Sudip Mukherjee wrote: > On Tuesday 14 June 2016 11:16 PM, Ben Hutchings wrote: > > On Tue, 2016-06-14 at 22:56 +0100, Sudip Mukherjee wrote: > > > On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote: > > > > This is the start of the stable review cycle for the

[PATCH] leds: tca6507: Remove unnecessary reg check

2017-10-08 Thread Christos Gkekas
Variable reg is unsigned so checking whether it is less than zero is not necessary. Signed-off-by: Christos Gkekas --- drivers/leds/leds-tca6507.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-08 Thread Leon Romanovsky
On Mon, Oct 09, 2017 at 02:29:15AM +0900, Masahiro Yamada wrote: > 2017-10-09 2:00 GMT+09:00 David Miller : > > From: Masahiro Yamada > > Date: Mon, 9 Oct 2017 01:10:11 +0900 > > > >> The headers > >> - include/linux/mlx4/device.h > >> -

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

2017-10-08 Thread Krzysztof Kozlowski
On Sun, Oct 08, 2017 at 06:06:19PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 6 October 2017 at 12:08, Krzysztof Kozlowski wrote: > > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: > >> update the usbdrd link control and phy contol clks. > > > >

Re: [BUG] fs/super: a possible sleep-in-atomic bug in put_super

2017-10-08 Thread Vladimir Davydov
On Sun, Oct 08, 2017 at 03:03:32AM +0100, Al Viro wrote: > On Sun, Oct 08, 2017 at 01:56:08AM +0100, Al Viro wrote: > > > What's more, we need to be careful about resize vs. drain. Right now it's > > on list_lrus_mutex, but if we drop that around actual resize of an > > individual > > list_lru,

[no subject]

2017-10-08 Thread Artur Lorincz
Hello, Thanks for checking the patch. I missed the #else part of he CONFIG_OF #ifdef previously. I made the code properly depend on CONFIG_OF now. I am not familiar with this code base. When time allows I would like to contribute by refactoring code in this area. Let me know if you have

[PATCH] Added default implementation for of_find_all_nodes(). This function is used by board.c from the board module (drivers/staging/board).

2017-10-08 Thread Artur Lorincz
Signed-off-by: Artur Lorincz --- include/linux/of.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/of.h b/include/linux/of.h index cfc34117fc92..250ab4d55fac 100644 --- a/include/linux/of.h +++ b/include/linux/of.h @@ -538,6 +538,11 @@ const char

[PATCH 6/6] kconfig: Regenerate parser

2017-10-08 Thread Ulf Magnusson
After the parsing memory leak fixes. Signed-off-by: Ulf Magnusson --- scripts/kconfig/zconf.tab.c_shipped | 562 +++- 1 file changed, 294 insertions(+), 268 deletions(-) diff --git a/scripts/kconfig/zconf.tab.c_shipped

[PATCH 3/6] kconfig: Don't leak 'option' arguments during parsing

2017-10-08 Thread Ulf Magnusson
The following strings would leak before this change: - option env="LEAKED" - option defconfig_list="LEAKED" These come in the form of T_WORD tokens and are always allocated on the heap in zconf.l. Free them. Summary from Valgrind on 'menuconfig' (ARCH=x86) before the fix:

[PATCH 5/6] kconfig: Don't leak help strings during parsing

2017-10-08 Thread Ulf Magnusson
This is just for completeness to get rid of the last memory leak currently generated during parsing for ARCH=x86. The symbol DVB_NETUP_UNIDVB in drivers/media/pci/netup_unidvb/Kconfig currently has two help strings, and we leak the first one. Summary from Valgrind on 'menuconfig' (ARCH=x86)

[PATCH 0/6] kconfig: Fix memory leaks during parsing

2017-10-08 Thread Ulf Magnusson
Hello, This patchset plugs all memory leaks that occur in the parser (zconf.y) while parsing the x86 Kconfigs (and likely the other ARCHes too). I noticed that Kconfig is pretty leaky while working on the fix for 'm' before MODULES (http://www.spinics.net/lists/linux-kbuild/msg15606.html). The

Re: [PATCH net-next,0/3] hv_netvsc: support changing TCP hash level

2017-10-08 Thread David Miller
From: Haiyang Zhang Date: Fri, 6 Oct 2017 08:33:56 -0700 > From: Haiyang Zhang > > The patch set simplifies the existing hash level switching code for > UDP. It also adds the support for changing TCP hash level. So users > can switch

[PATCH 3/3] kconfig: Fix choice symbol expression leak

2017-10-08 Thread Ulf Magnusson
When propagating dependencies from parents after parsing, an expression node is allocated if the parent symbol is a 'choice'. This node was never freed. Outline of leak: if (sym && sym_is_choice(sym)) { ... *Allocate (in this case only)*

[PATCH 0/3] kconfig: Fix expression memory leaks

2017-10-08 Thread Ulf Magnusson
Hello, This patchset plugs all memory leaks that are due to expressions not being freed, when parsing the x86 Kconfigs (and likely the other ARCHes too). 336 KB are leaked in total. Together with the memory leaks plugged in the parser in https://lkml.org/lkml/2017/10/8/126, this plugs all memory

[PATCH 2/3] kconfig: Fix expr_free() E_NOT leak

2017-10-08 Thread Ulf Magnusson
Only the E_NOT operand and not the E_NOT node itself was freed, due to accidentally returning too early in expr_free(). Outline of leak: switch (e->type) { ... case E_NOT: expr_free(e->left.expr); return; ... } *Never

[PATCH 1/3] kconfig: Fix automatic menu creation mem leak

2017-10-08 Thread Ulf Magnusson
expr_trans_compare() always allocates and returns a new expression, giving the following leak outline: ... *Allocate* basedep = expr_trans_compare(basedep, E_UNEQUAL, _no); ... for (menu = parent->next; menu; menu = menu->next) { ...

[PATCH] ASoC: cygnus: Remove unnecessary active_slots check

2017-10-08 Thread Christos Gkekas
Variable active_slots is unsigned so checking whether it is less than zero is not necessary. Signed-off-by: Christos Gkekas --- sound/soc/bcm/cygnus-ssp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/bcm/cygnus-ssp.c

Re: Building older mips kernels with different versions of binutils; possible patch for 3.2 and 3.4

2017-10-08 Thread Guenter Roeck
On 10/08/2017 11:12 AM, Ben Hutchings wrote: On Sun, 2016-05-15 at 19:56 -0700, Guenter Roeck wrote: [...] For 3.4 and 3.2 kernels to build with binutils v2.24, it would be necessary to apply patch c02263063362 ("MIPS: Refactor 'clear_page' and 'copy_page' functions"). It applies cleanly to

Re: Building older mips kernels with different versions of binutils; possible patch for 3.2 and 3.4

2017-10-08 Thread Guenter Roeck
On 10/08/2017 11:49 AM, Guenter Roeck wrote: On 10/08/2017 11:12 AM, Ben Hutchings wrote: On Sun, 2016-05-15 at 19:56 -0700, Guenter Roeck wrote: [...] For 3.4 and 3.2 kernels to build with binutils v2.24, it would be necessary to apply patch c02263063362 ("MIPS: Refactor 'clear_page' and

[PATCH] net: ethernet: stmmac: Clean up dead code

2017-10-08 Thread Christos Gkekas
Many macros in dwmac-ipq806x are unused and should be removed. Moreover gmac->id is an unsigned variable and therefore checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 14

[PATCH 01/12] radix-tree: replace with

2017-10-08 Thread Masahiro Yamada
This header contains references to spinlock_t and lockdep_is_held(), both of which are defined in Include instead of to reduce the header dependency. Signed-off-by: Masahiro Yamada --- include/linux/radix-tree.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 02/12] radix-tree: split struct radix_tree_root to

2017-10-08 Thread Masahiro Yamada
The idea is similar to the separation of and . The users of radix tree typically embed struct radix_tree_root in their data structures, but those headers do not need to know anything about the other radix tree stuff like radix_tree_node, accessors. Including pulls in lots of bloat while struct

[PATCH 05/12] iocontext.h: replace with

2017-10-08 Thread Masahiro Yamada
This header requires the definition of struct radix_tree_root, but does not need to know anything about other radix tree stuff. Include instead of to reduce the header dependency. Signed-off-by: Masahiro Yamada --- include/linux/iocontext.h | 2 +- 1 file

[PATCH 09/12] sh: intc: replace with

2017-10-08 Thread Masahiro Yamada
This header requires the definition of struct radix_tree_root, but does not need to know anything about other radix tree stuff. Include instead of to reduce the header dependency. Signed-off-by: Masahiro Yamada --- drivers/sh/intc/internals.h | 2 +- 1 file

[PATCH 1/6] kconfig: Don't leak symbol names during parsing

2017-10-08 Thread Ulf Magnusson
Prior to this fix, zconf.y did not free symbol names from zconf.l in these contexts: - After T_CONFIG ('config LEAKED') - After T_MENUCONFIG ('menuconfig LEAKED') - After T_SELECT ('select LEAKED') - After T_IMPLY ('imply LEAKED') - After T_DEFAULT in a

[PATCH 4/6] Kconfig: Don't leak main menus during parsing

2017-10-08 Thread Ulf Magnusson
If a 'mainmenu' entry appeared in the Kconfig files, two things would leak: - The 'struct property' allocated for the default "Linux Kernel Configuration" prompt. - The string for the T_WORD/T_WORD_QUOTE prompt after the T_MAINMENU token, allocated on the heap

[PATCH 2/6] kconfig: Don't leak 'source' filenames during parsing

2017-10-08 Thread Ulf Magnusson
The 'source_stmt' nonterminal takes a 'prompt', which consists of either a T_WORD or a T_WORD_QUOTE, both of which are always allocated on the heap in zconf.l and need to have their associated strings freed. Free them. The existing code already makes sure to always copy the string, but add a

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-08 Thread Masahiro Yamada
2017-10-09 2:00 GMT+09:00 David Miller : > From: Masahiro Yamada > Date: Mon, 9 Oct 2017 01:10:11 +0900 > >> The headers >> - include/linux/mlx4/device.h >> - drivers/net/ethernet/mellanox/mlx4/mlx4.h >> require the definition of struct

[PATCH] kconfig: Document automatic submenu creation code

2017-10-08 Thread Ulf Magnusson
It's tricky to figure out what it does (and how) without staring at the code for a long time. Document it to make it more transparent. No functional changes. Only comments added. Signed-off-by: Ulf Magnusson --- scripts/kconfig/menu.c | 38

[PATCH] Input: atmel_mxt_ts - Remove unnecessary byte_offset check

2017-10-08 Thread Christos Gkekas
Variable byte_offset is unsigned so checking whether it is greater or equal to zero is redundant. Signed-off-by: Christos Gkekas --- drivers/input/touchscreen/atmel_mxt_ts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] Added default implementation for of_find_all_nodes(). This function is used by board.c from the board module (drivers/staging/board).

2017-10-08 Thread kbuild test robot
Hi Artur, [auto build test ERROR on v4.14-rc3] [also build test ERROR on next-20170929] [cannot apply to glikely/devicetree/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 2/2] scripts: coccinelle: api: detect identical chip data arrays

2017-10-08 Thread Julia Lawall
This semantic patch detects duplicate arrays declared using BQ27XXX_DATA within a single structure. It is currently specific to the file drivers/power/supply/bq27xxx_battery.c. Nevertheless, having the script in the kernel will allow others to check their code if the data structures change in

[PATCH 0/2] detect identical chip data arrays

2017-10-08 Thread Julia Lawall
Rename battery.cocci as check_bq27xxx_data.cocci and adjust the warning messages to indicate that some structures are the same, in response to feedback from Liam Breck. Although check_bq27xxx_data.cocci says is requires Coccinelle 1.0.7, which is not yet released, it actually works with the

[PATCH 1/2] scripts: coccinelle: api: drop battery.cocci

2017-10-08 Thread Julia Lawall
Drop bettery.cocci as a more specific filename was preferred. Signed-off-by: Julia Lawall --- scripts/coccinelle/api/battery.cocci | 161 --- 1 file changed, 161 deletions(-) diff --git a/scripts/coccinelle/api/battery.cocci

Re: [RFC PATCH] mm: shm: round up tmpfs size to huge page size when huge=always

2017-10-08 Thread Yang Shi
On 10/8/17 5:56 AM, Kirill A. Shutemov wrote: On Sat, Oct 07, 2017 at 04:22:10AM +0800, Yang Shi wrote: When passing "huge=always" option for mounting tmpfs, THP is supposed to be allocated all the time when it can fit, but when the available space is smaller than the size of THP (2MB on

[PATCH -mmotm] mm: slab: exclude slabinfo dump for slob

2017-10-08 Thread Yang Shi
CONFIG_SLABINFO is removed, but slabinfo dump is not applicable to slob, protect slbinfo stats from !CONFIG_SLOB to avoid the below compile error reported by 0-DAY kernel test: mm/slab_common.o: In function `dump_unreclaimable_slab': >> mm/slab_common.c:1298: undefined reference to

Re: [PATCH] Input: atmel_mxt_ts - Remove unnecessary byte_offset check

2017-10-08 Thread Nick Dyer
On Sun, Oct 08, 2017 at 07:44:18PM +0100, Christos Gkekas wrote: > Variable byte_offset is unsigned so checking whether it is greater or > equal to zero is redundant. > > Signed-off-by: Christos Gkekas Yep - looks sensible to me. Signed-off-by: Nick Dyer

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

2017-10-08 Thread Tim Hansen
Mistakenly sent the patch previously with a missing semicolon. Apologies. Fix BUG() calls to use BUG_ON(conditional) macros. This was found using make coccicheck M=net/core on linux next tag next-20170929 Signed-off-by: Tim Hansen --- net/core/skbuff.c | 15

Re: [PATCH 0/2] detect identical chip data arrays

2017-10-08 Thread Julia Lawall
On Sun, 8 Oct 2017, Sebastian Reichel wrote: > Hi, > > On Sun, Oct 08, 2017 at 09:18:39PM +0200, Julia Lawall wrote: > > Rename battery.cocci as check_bq27xxx_data.cocci and adjust the warning > > messages to indicate that some structures are the same, in response to > > feedback from Liam

[PATCH] chacha20-ssse3/avx2: satisfy stack validation 2.0

2017-10-08 Thread Jason A. Donenfeld
The new stack validator in objdump doesn't like directly assigning r11 to rsp, warning with something like: warning: objtool: chacha20_4block_xor_ssse3()+0xa: unsupported stack pointer realignment warning: objtool: chacha20_8block_xor_avx2()+0x6: unsupported stack pointer realignment This

Re: [Part2 PATCH v5.1 12.2/31] crypto: ccp: Define SEV userspace ioctl and command id

2017-10-08 Thread Brijesh Singh
On 10/7/17 9:20 AM, Borislav Petkov wrote: > On Fri, Oct 06, 2017 at 08:06:00PM -0500, Brijesh Singh wrote: >> Add a include file which defines the ioctl and command id used for >> issuing SEV platform management specific commands. >> >> Cc: Paolo Bonzini >> Cc: "Radim

Re: [PATCH 0/2] detect identical chip data arrays

2017-10-08 Thread Sebastian Reichel
Hi, On Sun, Oct 08, 2017 at 10:44:50PM +0200, Julia Lawall wrote: > On Sun, 8 Oct 2017, Sebastian Reichel wrote: > > Hi, > > > > On Sun, Oct 08, 2017 at 09:18:39PM +0200, Julia Lawall wrote: > > > Rename battery.cocci as check_bq27xxx_data.cocci and adjust the warning > > > messages to indicate

[PATCH RFC] ftrace: Clear hashes of saved init functions

2017-10-08 Thread Joel Fernandes
Filters are supposed to be saved for init functions, however module init memory is freed after module init which also frees the ftrace dyn records. However, the filters are still left as is, this patch uses the mod_map infrastructure added by Steven to clear the hashes of the saved init functions

[PATCH v2] kconfig: Remove menu_end_entry()

2017-10-08 Thread Ulf Magnusson
menu_end_entry() is empty and completely unused as far as I can tell: $ git log -G menu_end_entry --oneline a02f057 [PATCH] kconfig: improve error handling in the parser 1da177e Linux-2.6.12-rc2 Last one is the initial Git commit, where menu_end_entry() is empty as well.

[PATCH] Input: synaptics-rmi4: Clean up redundant check

2017-10-08 Thread Christos Gkekas
Variable size_presence_reg·is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/input/rmi4/rmi_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/rmi4/rmi_driver.c

Re: [PATCH v4 05/15] perf report: create real callchain entries for inlined frames

2017-10-08 Thread Milian Wolff
On Donnerstag, 5. Oktober 2017 05:35:29 CEST Namhyung Kim wrote: > On Sun, Oct 01, 2017 at 04:30:50PM +0200, Milian Wolff wrote: > > The inline_node structs are maintained by the new dso->inlines > > tree. This in turn keeps ownership of the fake symbols and > > srcline string representing an

Re: [PATCH v4 12/15] perf report: cache failed lookups of inlined frames

2017-10-08 Thread Milian Wolff
On Donnerstag, 5. Oktober 2017 05:43:38 CEST Namhyung Kim wrote: > On Sun, Oct 01, 2017 at 04:30:57PM +0200, Milian Wolff wrote: > > When no inlined frames could be found for a given address, > > we did not store this information anywhere. That means we > > potentially do the costly inliner lookup

Re: [PATCH 0/2] detect identical chip data arrays

2017-10-08 Thread Sebastian Reichel
Hi, On Sun, Oct 08, 2017 at 09:18:39PM +0200, Julia Lawall wrote: > Rename battery.cocci as check_bq27xxx_data.cocci and adjust the warning > messages to indicate that some structures are the same, in response to > feedback from Liam Breck. > > Although check_bq27xxx_data.cocci says is requires

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

2017-10-08 Thread Anand Moon
Hi Krzysztof, On 8 October 2017 at 21:20, Krzysztof Kozlowski wrote: > On Sun, Oct 08, 2017 at 06:11:12PM +0530, Anand Moon wrote: >> Hi Krzysztof, >> >> On 6 October 2017 at 12:12, Krzysztof Kozlowski wrote: >> > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon

Re: [Part2 PATCH v5 11/31] crypto: ccp: Define SEV key management command id

2017-10-08 Thread Brijesh Singh
On 10/5/17 3:56 PM, Borislav Petkov wrote: > On Wed, Oct 04, 2017 at 08:13:52AM -0500, Brijesh Singh wrote: >> Define Secure Encrypted Virtualization (SEV) key management command id >> and structure. The command definition is available in SEV KM [1] spec >> 0.14. >> >> [1]

Re: [BUG] fs/super: a possible sleep-in-atomic bug in put_super

2017-10-08 Thread Al Viro
On Sun, Oct 08, 2017 at 06:47:46PM +0300, Vladimir Davydov wrote: > On Sun, Oct 08, 2017 at 03:03:32AM +0100, Al Viro wrote: > > On Sun, Oct 08, 2017 at 01:56:08AM +0100, Al Viro wrote: > > > > > What's more, we need to be careful about resize vs. drain. Right now it's > > > on list_lrus_mutex,

RE: [PATCH v5 09/14] platform/x86: dell-smbios: Introduce dispatcher for SMM calls

2017-10-08 Thread Mario.Limonciello
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Sunday, October 8, 2017 1:13 PM > To: Limonciello, Mario > Cc: dvh...@infradead.org; LKML ; Platform Driver >

[PATCH] scsi: eata: Remove unnecessary cpp_index check

2017-10-08 Thread Christos Gkekas
Variable spp->cpp_index is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/scsi/eata.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/eata.c b/drivers/scsi/eata.c index

Re: [PATCH] ext2/super: Fix a possible sleep-in-atomic bug in parse_options

2017-10-08 Thread Dave Chinner
On Sat, Oct 07, 2017 at 09:20:46AM +0800, Jia-Ju Bai wrote: > The kernel may sleep under a spinlock, and the function call path is: > ext2_remount > parse_options > match_int > match_number (lib/parser.c) > kmalloc(GFP_KERNEL) --> may sleep > > To fix it, GFP_KERNEL is

Re: [PATCH] chacha20-ssse3/avx2: satisfy stack validation 2.0

2017-10-08 Thread Jason A. Donenfeld
s/objdump/objtool/g obviously.

[PATCH v2 0/7] Fix i.MX7D OCOTP write support

2017-10-08 Thread Bryan O'Donoghue
V2: - Added Reviewed-by and Acked-by as indicated by Philipp - octp_params -> ocotp_params Philipp Zabel - Added whitespace to aggregate initaliser - Philipp Zabel - Dropped (void*) cast to data - Philipp Zabel - Made use of of_device_get_match_data - Philipp Zabel - Got rid of params->banked -

[PATCH v2 5/7] nvmem: imx-ocotp: Add i.MX7D timing write clock setup support

2017-10-08 Thread Bryan O'Donoghue
This patch adds logic to correctly setup the write timing parameters when blowing an OTP fuse for the i.MX7S/D. Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support") Signed-off-by: Bryan O'Donoghue --- drivers/nvmem/imx-ocotp.c | 65

[PATCH] ath10k: spectral: Simplify error checking

2017-10-08 Thread Christos Gkekas
Variable val is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/wireless/ath/ath10k/spectral.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/spectral.c

Re: [PATCH v4 03/15] perf util: refactor inline_list to operate on symbols

2017-10-08 Thread Milian Wolff
On Donnerstag, 5. Oktober 2017 03:56:13 CEST Namhyung Kim wrote: > Hi Milian, > > On Sun, Oct 01, 2017 at 04:30:48PM +0200, Milian Wolff wrote: > > This is a requirement to create real callchain entries for inlined > > frames. > > > > Since the list of inlines usually contains the target symbol

Re: Building older mips kernels with different versions of binutils; possible patch for 3.2 and 3.4

2017-10-08 Thread Ben Hutchings
On Sun, 2017-10-08 at 12:01 -0700, Guenter Roeck wrote: > On 10/08/2017 11:49 AM, Guenter Roeck wrote: > > On 10/08/2017 11:12 AM, Ben Hutchings wrote: > > > On Sun, 2016-05-15 at 19:56 -0700, Guenter Roeck wrote: > > > [...] > > > > For 3.4 and 3.2 kernels to build with binutils v2.24, it would

Re: [PATCH v2 1/2] uio: dt-bindings: document binding for uio-pdrv-genirq

2017-10-08 Thread Chris Packham
Hi Rob, Greg, On 04/10/17 10:38, Rob Herring wrote: > On Fri, Sep 22, 2017 at 03:48:13AM +1200, Chris Packham wrote: >> Document the device tree bindings for the uio-prv-genirq driver. Provide >> some examples on how it can be used. >> >> Signed-off-by: Chris Packham

Re: [PATCH v2 0/5] Switch arm64 over to qrwlock

2017-10-08 Thread Yury Norov
On Fri, Oct 06, 2017 at 02:34:37PM +0100, Will Deacon wrote: > Hi all, > > This is version two of the patches I posted yesterday: > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2017-October/534666.html > > I'd normally leave it longer before posting again, but Peter had a good >

[PATCH] skd: Use kmem_cache_free

2017-10-08 Thread Himanshu Jha
Use kmem_cache_free instead of kfree for freeing the memory previously allocated with kmem_cache_zalloc/kmem_cache_alloc/kmem_cache_node. Signed-off-by: Himanshu Jha --- drivers/block/skd_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] cklight: tps65217_bl: Remove unnecessary default brightness check

2017-10-08 Thread Christos Gkekas
Variable val holds the default brightness and is unsigned, therefore checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/video/backlight/tps65217_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH 2/2] KVM: X86: XCR0 should be set to the fixed value on vCPU reset

2017-10-08 Thread Jim Mattson
Reviewed-by: Jim Mattson On Sat, Oct 7, 2017 at 7:35 PM, Wanpeng Li wrote: > From: Wanpeng Li > > SDM section 2.6 mentioned: > > After reset, all bits (except bit 0) in XCR0 are cleared to zero; XCR0[0] is > set to 1. > > This

Re: [PATCH] input: atmel_mxt_ts: detect touchpad from devicetree

2017-10-08 Thread Nick Dyer
On Wed, Oct 04, 2017 at 09:35:31PM +0200, Emil Renner Berthing wrote: > The Samsung Chromebook Plus (rk3399-gru-kevin) has two of > these controllers. One for the touchscreen and one for > the touchpad. However the touchpad doesn't have any > associated gpio buttons, so it shows up as another >

$850.000.00 Donation.

2017-10-08 Thread Mark J. Shapiro
David & Maureen picked you for $850.000.00 Donation, Kindly reply for details and claim.

[PATCH v1 1/1] platform/x86: intel_pmc_ipc: Use spin_lock to protect GCR updates

2017-10-08 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Currently, update_no_reboot_bit() function implemented in this driver uses mutex_lock() to protect its register updates. But this function is called with in atomic context in iTCO_wdt_start() and iTCO_wdt_stop()

Re: [PATCH] Update MIPS email addresses

2017-10-08 Thread Maciej W. Rozycki
On Fri, 6 Oct 2017, Paul Burton wrote: > From: Paul Burton > > MIPS will soon not be a part of Imagination Technologies, and as such > many @imgtec.com email addresses will no longer be valid. This patch > updates the addresses for all those who: > > - Have 10 or more

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

2017-10-08 Thread Anand Moon
Hi Krzysztof, On 8 October 2017 at 21:17, Krzysztof Kozlowski wrote: > On Sun, Oct 08, 2017 at 06:06:19PM +0530, Anand Moon wrote: >> Hi Krzysztof, >> >> On 6 October 2017 at 12:08, Krzysztof Kozlowski wrote: >> > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon

[PATCH] ath9k: debug: Simplify error checking

2017-10-08 Thread Christos Gkekas
Variable val is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/wireless/ath/ath9k/debug.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/debug.c

Re: [PATCH] vfs: hard-ban creating files with control characters in the name

2017-10-08 Thread Dave Chinner
On Fri, Oct 06, 2017 at 07:57:01AM -0700, Matthew Wilcox wrote: > On Fri, Oct 06, 2017 at 01:09:42PM +1100, Dave Chinner wrote: > > On Thu, Oct 05, 2017 at 12:16:19PM -0400, J. Bruce Fields wrote: > > > This kind of restriction sounds more like a permanent feature of the > > >

Re: [PATCH 6/6] kconfig: Regenerate parser

2017-10-08 Thread Ulf Magnusson
On Sun, Oct 8, 2017 at 7:11 PM, Ulf Magnusson wrote: > After the parsing memory leak fixes. > > Signed-off-by: Ulf Magnusson > --- > scripts/kconfig/zconf.tab.c_shipped | 562 > +++- > 1 file changed, 294 insertions(+),

[PATCH] iommu/vt-d: Delete unnecessary check

2017-10-08 Thread Christos Gkekas
Variable did_old is unsigned so checking whether it is greater or equal to zero is not necessary. Signed-off-by: Christos Gkekas --- drivers/iommu/intel-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel-iommu.c

Re: [PATCH 1/2] KVM: VMX: Don't expose unrestricted_guest is enabled if ept is disabled

2017-10-08 Thread Jim Mattson
If it were me, I'd apply De Morgan to that expression, but the logic looks fine. Reviewed-by: Jim Mattson On Sat, Oct 7, 2017 at 7:35 PM, Wanpeng Li wrote: > From: Wanpeng Li > > SDM mentioned: > > "If either the “unrestricted

[PATCH v2 2/7] nvmem: imx-ocotp: Pass parameters via a struct

2017-10-08 Thread Bryan O'Donoghue
It will be useful in later patches to know the register access mode and bit-shift to apply to a given input offset. Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support") Signed-off-by: Bryan O'Donoghue --- drivers/nvmem/imx-ocotp.c | 32

[PATCH v2 4/7] nvmem: imx-ocotp: Move i.MX6 write clock setup to dedicated function

2017-10-08 Thread Bryan O'Donoghue
The i.MX7S/D has a different set of timing requirements, as a pre-cursor to adding the i.MX7 timing parameters, move the i.MX6 stuff to a dedicated function. Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support") Signed-off-by: Bryan O'Donoghue Reviewed-by:

[PATCH v2 3/7] nvmem: imx-ocotp: Add support for banked OTP addressing

2017-10-08 Thread Bryan O'Donoghue
The i.MX7S/D takes the bank address in the CTRLn.ADDR field and the data value in one of the DATAx {0, 1, 2, 3} register fields. The current write routine is based on writing the CTRLn.ADDR field and writing a single DATA register only. Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support")

<    1   2   3   4   5   6   >