Re: [PATCH v5 00/13] gpio: Tight IRQ chip integration

2017-10-23 Thread Jon Hunter
Hi Linus, On 16/10/17 19:09, Jon Hunter wrote: > Hi Linus, > > On 13/10/17 16:49, Thierry Reding wrote: >> From: Thierry Reding >> >> Hi Linus, >> >> here's the latest series of patches that implement the tighter IRQ chip >> integration. I've dropped the banked

Re: um: Use common error handling code in port_listen_fd()

2017-10-23 Thread SF Markus Elfring
> This business of moving the error code to the bottom of the function > just makes the code less readable. I got an other software development opinion on this aspect. Could you become used to the proposed control flow structure in the affected function? > I know you never listen to anyone, My

Re: [PATCH 13/13] staging: iio: tsl2x7x: add goto for TSL2X7X_LUX_CALC_OVER_FLOW

2017-10-23 Thread Dan Carpenter
On Thu, Oct 19, 2017 at 04:06:32PM -0400, Brian Masney wrote: > This patch adds a return_max label for the two cases that need to set > the lux to TSL2X7X_LUX_CALC_OVER_FLOW and return. > > Signed-off-by: Brian Masney > --- > drivers/staging/iio/light/tsl2x7x.c | 9

RE: [PATCH] PCI: dwc: designware: don't sleep in atomic context

2017-10-23 Thread David Laight
From: Bjorn Helgaas > Sent: 20 October 2017 19:19 > On Fri, Oct 13, 2017 at 09:10:38AM +0530, Pankaj Dubey wrote: > > > > > > On 10/12/2017 04:09 PM, David Laight wrote: > > >From: Pankaj Dubey > > >>Sent: 12 October 2017 08:55 > > >>In pcie-designware.c many places we are calling "usleep_range"

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

2017-10-23 Thread Minas Harutyunyan
On 10/20/2017 3:57 PM, Minas Harutyunyan wrote: > On 10/20/2017 12:20 AM, John Stultz wrote: >> On Wed, Oct 18, 2017 at 11:46 PM, Minas Harutyunyan >> wrote: >>> Could you please apply this patch. Please not apply your patch series >>> "[PATCH 0/3] dwc2 fixes for

Re: [Part2 PATCH v6 13/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-23 Thread Borislav Petkov
On Thu, Oct 19, 2017 at 09:33:48PM -0500, Brijesh Singh wrote: > +static int __sev_platform_init(struct sev_data_init *data, int *error) > +{ > + int rc = 0; > + > + mutex_lock(_init_mutex); > + > + if (!fw_init_count) { I still don't like global semaphores. Can you get the status and

Re: [PATCH] Documentation: leds: Update 00-INDEX file

2017-10-23 Thread Pavel Machek
On Mon 2017-10-09 21:10:03, Jacek Anaszewski wrote: > Add missing entries for the following documentation files: > > - leds-class-flash.txt > - leds-lm3556.txt > - leds-mlxcpld.txt > - ledtrig-usbport.txt > - uleds.txt > > Signed-off-by: Jacek Anaszewski Acked-by:

Re: 4.14-rc2 on thinkpad x220: out of memory when inserting mmc card

2017-10-23 Thread Pavel Machek
Hi! > >> Did you use bounce buffers? Those were improving performance on > >> some laptops with TI or Ricoh host controllers and nothing else was > >> ever really using it (as can be seen from the commit). > > > > Thinkpad X220... how do I tell if I was using them? I believe so, > > because I

[PATCH 1/1] futex: do not fail on invalid op

2017-10-23 Thread Jiri Slaby
In 30d6e0a4190d ("futex: Remove duplicated code and fix undefined behaviour"), I let FUTEX_WAKE_OP to fail on invalid op. Namely when op should be considered as shift and the shift is out of range (< 0 or > 31). But strace's test suite does this madness: futex(0x7fabd78bcffc, 0x5, 0xfacefeed,

Applied "ASoC: rt5651: Convert rt5651 micbias1 to a supply widget" to the asoc tree

2017-10-23 Thread Mark Brown
The patch ASoC: rt5651: Convert rt5651 micbias1 to a supply widget has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours)

[tip:perf/core] lkdtm, kprobes: Convert from jprobes to kprobes

2017-10-23 Thread tip-bot for Kees Cook
Commit-ID: 8776fe75dc0e263ed2056ea9896c2267599dc447 Gitweb: https://git.kernel.org/tip/8776fe75dc0e263ed2056ea9896c2267599dc447 Author: Kees Cook AuthorDate: Fri, 20 Oct 2017 06:31:27 -0700 Committer: Ingo Molnar CommitDate: Mon, 23 Oct 2017

[tip:sched/urgent] sched/swait: Document it clearly that the swait facilities are special and shouldn't be used

2017-10-23 Thread tip-bot for Davidlohr Bueso
Commit-ID: 88796e7e5c457cae72833196cb98e6895dd107e2 Gitweb: https://git.kernel.org/tip/88796e7e5c457cae72833196cb98e6895dd107e2 Author: Davidlohr Bueso AuthorDate: Fri, 20 Oct 2017 10:13:46 -0700 Committer: Ingo Molnar CommitDate: Mon, 23 Oct 2017

Re: [RFC PATCH 1/2] security, capabilities: Add CAP_SYS_MOUNT

2017-10-23 Thread Stephen Smalley
On Sat, 2017-10-21 at 15:43 +0200, Nicolas Belouin wrote: > With CAP_SYS_ADMIN being bloated and inapropriate for actions such > as mounting/unmounting filesystems, the creation of a new capability > is needed. > CAP_SYS_MOUNT is meant to give a process the ability to call for > mount, > umount

Re: [PATCH 1/2] module: export module signature enforcement status

2017-10-23 Thread Mimi Zohar
On Fri, 2017-10-20 at 17:19 -0200, Bruno E. O. Meneguele wrote: > A static variable sig_enforce is used as status var to indicate the real > value of CONFIG_MODULE_SIG_FORCE, once this one is set the var will hold > true, but if the CONFIG is not set the status var will hold whatever > value is

Re: [PATCH 2/2] ima: check signature enforcement against cmdline param instead of CONFIG

2017-10-23 Thread Mimi Zohar
On Fri, 2017-10-20 at 17:19 -0200, Bruno E. O. Meneguele wrote: > When the user requests MODULE_CHECK policy and its kernel is compiled > with CONFIG_MODULE_SIG_FORCE not set, all modules would not load, just > those loaded in initram time. One option the user would have would be > set a kernel

Re: [PATCH v3 05/13] irqchip: add initial support for ompic

2017-10-23 Thread Stafford Horne
On Mon, Oct 23, 2017 at 09:00:09AM +0100, Marc Zyngier wrote: > On Sun, Oct 22 2017 at 12:15:52 pm BST, Stafford Horne > wrote: > > From: Stefan Kristiansson > > [...] > > + > > + ret = setup_irq(irq, _ipi_irqaction); > > + if (ret) > >

[PATCH] Fix isocpus's param handling when CPUMASK_OFFSTACK=n.

2017-10-23 Thread Rakib Mullick
> On Mon, Oct 23, 2017 at 5:50 PM, Ingo Molnar wrote: > >> * Rakib Mullick wrote: >> +/** >> + * cpumask_last - get the last cpu in a cpumask > > Please capitalize 'CPU' properly in documentation. > OK. >> + int ret, lastcpu; >> >>

Re: [PATCH] of: Devices with pci_epf_bus_type require DMA configuration

2017-10-23 Thread Robin Murphy
On 23/10/17 06:43, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 11 October 2017 10:15 PM, Robin Murphy wrote: >> On 11/10/17 09:00, Kishon Vijay Abraham I wrote: >>> pci-epc-core.c invokes of_dma_configure in order to configure >>> the coherent_dma_mask/dma_mask of endpoint function

[PATCH] checkpatch: avoid false positive closing bracket with initializers

2017-10-23 Thread Carlo Marcelo Arenas Belón
when multiple closing brackets are being used for an universal zero intializer as in (for example): struct timespec tv[10] = {{0}}; Signed-off-by: Carlo Marcelo Arenas Belón --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [GIT PULL] Documentation: Add a file explaining the requested Linux kernel license enforcement policy

2017-10-23 Thread Pavel Nikulin
>If you don't agree with this, that's great, don't sign onto the >agreement. But as you don't seem to be part of our community in the >first place, I don't really understand your concern here at all. My last patch submitted to kernel was over a decade ago, yes I have not much say here. My worry

Re: [PATCH V8 00/14] mmc: Add Command Queue support

2017-10-23 Thread Adrian Hunter
On 20/10/17 15:30, Adrian Hunter wrote: > On 19/10/17 14:44, Adrian Hunter wrote: >> On 18/10/17 09:16, Adrian Hunter wrote: >>> On 11/10/17 16:58, Ulf Hansson wrote: On 11 October 2017 at 14:58, Adrian Hunter wrote: > On 11/10/17 15:13, Ulf Hansson wrote: >>

Re: [PATCH 1/3] dt-bindings: iio: adc: stm32: add support for diff channels

2017-10-23 Thread Jonathan Cameron
On Mon, 23 Oct 2017 10:06:27 +0200 Fabrice Gasnier wrote: > On 10/21/2017 09:23 PM, Jonathan Cameron wrote: > > On Sat, 21 Oct 2017 18:54:01 +0100 > > Jonathan Cameron wrote: > > > >> On Tue, 17 Oct 2017 15:15:43 +0200 > >> Fabrice Gasnier

Re: [PATCH] refcount: provide same memory ordering guarantees as in atomic_t

2017-10-23 Thread Peter Zijlstra
On Mon, Oct 23, 2017 at 02:09:44PM +0300, Elena Reshetova wrote: > Currently arch. independent implementation of refcount_t in > lib/refcount.c provides weak memory ordering guarantees > compare to its analog atomic_t implementations. > While it should not be a problem for most of the actual >

Re: [PATCH 07/14] regmap: Add SoundWire bus support

2017-10-23 Thread Mark Brown
On Mon, Oct 23, 2017 at 12:56:27PM +0100, Alan Cox wrote: > On Sat, 2017-10-21 at 10:34 +0100, Mark Brown wrote: > > On Thu, Oct 19, 2017 at 08:33:23AM +0530, Vinod Koul wrote: > > > +EXPORT_SYMBOL(__regmap_init_sdw); > > ...this is just an obvious attempt to allow non-GPL code to directly > >

Re: [PATCH 3/4] char/tpm: Improve a size determination in nine functions

2017-10-23 Thread Dan Carpenter
On Thu, Oct 19, 2017 at 04:58:23PM +, alexander.stef...@infineon.com wrote: > > On Tue, Oct 17, 2017 at 11:50:05AM +, alexander.stef...@infineon.com > > wrote: > > > > > Replace the specification of data structures by pointer dereferences > > > > > as the parameter for the operator

[PATCH v2 1/2] futex: futex_wake_op, do not fail on invalid op

2017-10-23 Thread Jiri Slaby
In 30d6e0a4190d ("futex: Remove duplicated code and fix undefined behaviour"), I let FUTEX_WAKE_OP to fail on invalid op. Namely when op should be considered as shift and the shift is out of range (< 0 or > 31). But strace's test suite does this madness: futex(0x7fabd78bcffc, 0x5, 0xfacefeed,

Re: PROBLEM: Remapping hugepages mappings causes kernel to return EINVAL

2017-10-23 Thread Michal Hocko
On Fri 20-10-17 15:42:25, Mike Kravetz wrote: > On 10/19/2017 12:34 AM, C.Wehrmeyer wrote: [...] > > As for the specific use case: I've written my own allocator that is > > not bound on the same limitations that usual malloc/realloc/free > > allocators are bound. As such I want to be able to

Re: [PATCH] ARM: Fix zImage file size not aligned with CONFIG_EFI_STUB enabled

2017-10-23 Thread Russell King - ARM Linux
On Mon, Oct 23, 2017 at 11:50:46AM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 23, 2017 at 06:24:12PM +0800, jeffy wrote: > > Hi Russell, > > > > Thanks for your reply. > > > > On 10/23/2017 04:50 PM, Russell King - ARM Linux wrote: > > >>> > > >>>hmm, right, didn't notice the data is

Re: [PATCH] arch64: optimize __memcpy_fromio, __memcpy_toio and __memset_io

2017-10-23 Thread Robin Murphy
Hi Mark, On 20/10/17 21:22, Mark Salyzyn wrote: > __memcpy_fromio and __memcpy_toio functions do not deal well with > harmonically unaligned addresses unless they can ultimately be > copied as quads (u64) to and from the destination. Without a > harmonically aligned relationship, they perform

Re: [RESEND v12 0/6] cgroup-aware OOM killer

2017-10-23 Thread Michal Hocko
On Sun 22-10-17 17:24:51, David Rientjes wrote: > On Thu, 19 Oct 2017, Johannes Weiner wrote: > > > David would have really liked for this patchset to include knobs to > > influence how the algorithm picks cgroup victims. The rest of us > > agreed that this is beyond the scope of these patches,

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

2017-10-23 Thread Alan Cox
> > I quick grep on Dual license users looks like we already have this > > in kernel > > code. See drivers/ntb/hw/intel/ntb_hw_intel.c > > Just because someone did something wrong in the past, doesn't mean > they > should keep doing more wrong things in the future :) What makes you think it's

Re: [PATCH 0/6] Boot-time switching between 4- and 5-level paging for 4.15, Part 1

2017-10-23 Thread Ingo Molnar
* Kirill A. Shutemov wrote: > > Or, could we keep MAX_PHYSMEM_BITS constant, and introduce a _different_ > > constant > > that is dynamic, and which could be used in the cases where the 5-level > > paging > > config causes too much memory footprint in the common

Re: [PATCH 07/14] regmap: Add SoundWire bus support

2017-10-23 Thread Alan Cox
On Sat, 2017-10-21 at 10:34 +0100, Mark Brown wrote: > On Thu, Oct 19, 2017 at 08:33:23AM +0530, Vinod Koul wrote: > > > + *  BSD LICENSE > > + * > > + *  Copyright(c) 2015-17 Intel Corporation. > > + * > > + *  Redistribution and use in source and binary forms, with or > > without > > + *  

Re: [PATCH v1] mm: broken deferred calculation

2017-10-23 Thread Michal Hocko
On Fri 20-10-17 21:17:07, Pavel Tatashin wrote: > In reset_deferred_meminit we determine number of pages that must not be > deferred. We initialize pages for at least 2G of memory, but also pages for > reserved memory in this node. > > The reserved memory is determined in this function: >

Re: [PATCH] ext4: Log inode exhaustion to dmesg

2017-10-23 Thread Theodore Ts'o
Hi, The Signed-off-by needs to contain your real name (sorry, no pseudonyms or anonymous contributions.) That's because it has a formal legal meaning. See Section 11: "Sign your work - the Developer’s Certificate of Origin" of the Submitting Patches docuementation:

Re: [GIT PULL] Introduce housekeeping subsystem v4

2017-10-23 Thread Ingo Molnar
* Frederic Weisbecker wrote: > In fact, CPU affinity is the only high level concept I found to gather all > these > housekeeping elements. > > Perhaps I should use "cpu_isolation" instead of "housekeeping" naming. The problem with names based on that, like

Re: [Part2 PATCH v6 16/38] crypto: ccp: Implement SEV_PEK_GEN ioctl command

2017-10-23 Thread Brijesh Singh
On 10/23/17 4:32 AM, Borislav Petkov wrote: ... >> +static int sev_ioctl_do_pek_pdh_gen(int cmd, struct sev_issue_cmd *argp) >> +{ >> +int ret, err; >> + >> +ret = sev_platform_init(NULL, >error); >> +if (ret) >> +return ret; >> + >> +ret = sev_do_cmd(cmd, 0, >error);

Re: 4.14-rc2 on thinkpad x220: out of memory when inserting mmc card

2017-10-23 Thread Linus Walleij
On Mon, Oct 23, 2017 at 11:31 AM, Pavel Machek wrote: >> > Thinkpad X220... how do I tell if I was using them? I believe so, >> > because I uncovered bug in them before. >> >> You are certainly using bounce buffers. What does lspci -knn show? > > Here is the output: > 0d:00.0

Re: [PATCH] staging: wilc1000: replace redundant computations with 0

2017-10-23 Thread Dan Carpenter
On Tue, Oct 10, 2017 at 03:05:48PM +0100, Colin King wrote: > From: Colin Ian King > > Shifting and masking strHostIfSetMulti->enabled is redundant since > enabled is a bool and so all the shifted and masked values will be > zero. Replace them with zero to simplify the

Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-10-23 Thread Mika Westerberg
On Sun, Oct 15, 2017 at 09:38:57PM +0800, Bin Meng wrote: > > Also, the 'depends on EXPERT' statement looks misplaced, > > enabling EXPERT should only be there to allow you to turn > > extra things *off*, not to hide device drivers. > > > > I will leave this to Mika to comment the "EXPERT" usage.

Re: PROBLEM: Remapping hugepages mappings causes kernel to return EINVAL

2017-10-23 Thread C.Wehrmeyer
On 2017-10-23 13:42, Michal Hocko wrote: I do not remember any such a request either. I can see some merit in the described use case. It is not specific on why hugetlb pages are used for the allocator memory because that comes with it own issues. That is yet for the user to specify. As of now

[PATCH] locking/spinlock/debug: snapshot lock fields

2017-10-23 Thread Mark Rutland
Currently, the lock debug code doesn't use {READ,WRITE}_ONCE() to access lock fields, and thus may observe torn values given a suitably unhelpful compiler. These could result in false positives and/or false negatives for some sanity checks. Further, as we don't snapshot the values of various

[PATCH] ARM: dts: imx28-tx28: fix interrupt flags

2017-10-23 Thread Lothar Waßmann
Some interrupts properties are given '0' as the flags argument. Change them to use the appropriate interrupt flags. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx28-tx28.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] ARM: dts: imx28-tx28: fix interrupt flags

2017-10-23 Thread Lothar Waßmann
Some interrupts properties are given '0' as the flags argument. Change them to use the appropriate interrupt flags. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx28-tx28.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Part2 PATCH v6 17/38] crypto: ccp: Implement SEV_PDH_GEN ioctl command

2017-10-23 Thread Borislav Petkov
On Thu, Oct 19, 2017 at 09:33:52PM -0500, Brijesh Singh wrote: > The SEV_PDH_GEN command is used to re-generate the Platform > Diffie-Hellman (PDH) key. The command is defined in SEV spec section > 5.6. > > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > Cc:

[PATCH] perf/x86/intel/bts: Fix exclusive event reference leak

2017-10-23 Thread Alexander Shishkin
Commit d2878d642a4ed ("perf/x86/intel/bts: Disallow use by unprivileged users on paranoid systems") adds a privilege check in the exactly wrong place in the event init path: after the 'LBR exclusive' reference has been taken, and doesn't release it in the case of insuffucient privileges. After

[PATCH] tpm: remove chip_num parameter from in-kernel API

2017-10-23 Thread Jarkko Sakkinen
The reasoning is simple and obvious. Since every call site passes the value TPM_ANY_NUM (0x) the parameter does not have right to exist. Refined the documentation of the corresponding functions. Signed-off-by: Jarkko Sakkinen ---

Re: [PATCH 0/6] Boot-time switching between 4- and 5-level paging for 4.15, Part 1

2017-10-23 Thread Ingo Molnar
* Kirill A. Shutemov wrote: > > Making a variable that 'looks' like a constant macro dynamic in a rare > > Kconfig > > scenario is asking for trouble. > > We expect boot-time page mode switching to be enabled in kernel of next > generation enterprise distros. It

[tip:x86/asm] x86/asm: Don't use the confusing '.ifeq' directive

2017-10-23 Thread tip-bot for Josh Poimboeuf
Commit-ID: 82c62fa0c49aa305104013cee4468772799bb391 Gitweb: https://git.kernel.org/tip/82c62fa0c49aa305104013cee4468772799bb391 Author: Josh Poimboeuf AuthorDate: Fri, 20 Oct 2017 11:21:35 -0500 Committer: Ingo Molnar CommitDate: Mon, 23 Oct 2017

[tip:x86/asm] x86/unwind: Show function name+offset in ORC error messages

2017-10-23 Thread tip-bot for Josh Poimboeuf
Commit-ID: 58c3862b521ead4f69a24ef009a679cb3c519620 Gitweb: https://git.kernel.org/tip/58c3862b521ead4f69a24ef009a679cb3c519620 Author: Josh Poimboeuf AuthorDate: Fri, 20 Oct 2017 11:21:34 -0500 Committer: Ingo Molnar CommitDate: Mon, 23 Oct 2017

Re: [Part2 PATCH v6 18/38] crypto: ccp: Implement SEV_PEK_CSR ioctl command

2017-10-23 Thread Borislav Petkov
On Thu, Oct 19, 2017 at 09:33:53PM -0500, Brijesh Singh wrote: > The SEV_PEK_CSR command can be used to generate a PEK certificate > signing request. The command is defined in SEV spec section 5.7. > > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > Cc:

Re: [PATCH 02/14] soundwire: Add SoundWire bus type

2017-10-23 Thread Alan Cox
> > > And why dual license something that will only ever work on Linux? > > > > We have non Linux users (mostly RTOS folks) which we would like to > > support > > with as much as common code. > > Note, you need to be VERY CAREFUL about doing this.  You need to have > all sorts of infrastructure

Re: [PATCH V3 0/6] event synthesization multithreading for perf record

2017-10-23 Thread Ingo Molnar
* kan.li...@intel.com wrote: > The latency is the time cost of __machine__synthesize_threads or > its multithreading replacement, record__multithread_synthesize. > > Original: original single thread synthesize > With patch(not merge): multithread synthesize

Re: [PATCH] Fix isocpus's param handling when CPUMASK_OFFSTACK=n.

2017-10-23 Thread Ingo Molnar
* Rakib Mullick wrote: > > *On Fri, Oct 20, 2017 at 2:49 PM, Ingo Molnar wrote: > > > >> Rakib Mullick wrote: > >> include/linux/cpumask.h | 16 > >> kernel/sched/topology.c | 8 +--- > >> 2 files

[PATCH v5 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-10-23 Thread Zhi Mao
Add support to MT2712 and MT7622. Due to register offset address of pwm7 for MT2712 is not fixed 0x40, add mtk_pwm_reg_offset array for pwm register offset. Add NULL pointer checking for "pc->data". Signed-off-by: Zhi Mao --- drivers/pwm/pwm-mediatek.c | 53

Re: [f2fs-dev] [PATCH] f2fs: limit # of inmemory pages

2017-10-23 Thread Chao Yu
On 2017/10/19 10:15, Jaegeuk Kim wrote: > If some abnormal users try lots of atomic write operations, f2fs is able to > produce pinned pages in the main memory which affects system performance. > This patch limits that as 20% over total memory size, and if f2fs reaches > to the limit, it will drop

Re: um: Use common error handling code in port_listen_fd()

2017-10-23 Thread SF Markus Elfring
> He just keeps sending these crap patches without listening to anybody, I am listening. - But this does not automatically mean that we come to the same thoughts and conclusions on some topics. > thereby wasting valuable developer time. There are also contributors who respond in a positive way

Re: [PATCH 0/3] s390 refcount conversions

2017-10-23 Thread Julian Wiedmann
On 10/20/2017 09:47 AM, Elena Reshetova wrote: > This series, for S390, replaces atomic_t reference > counters with the new refcount_t type and API (see include/linux/refcount.h). > By doing this we prevent intentional or accidental > underflows or overflows that can led to use-after-free

Re: 4.14-rc2 on thinkpad x220: out of memory when inserting mmc card

2017-10-23 Thread Adrian Hunter
On 23/10/17 12:31, Pavel Machek wrote: > Hi! > Did you use bounce buffers? Those were improving performance on some laptops with TI or Ricoh host controllers and nothing else was ever really using it (as can be seen from the commit). >>> >>> Thinkpad X220... how do I tell if I was

Re: [PATCH 0/6] Boot-time switching between 4- and 5-level paging for 4.15, Part 1

2017-10-23 Thread Kirill A. Shutemov
On Mon, Oct 23, 2017 at 01:56:58PM +0200, Ingo Molnar wrote: > > * Kirill A. Shutemov wrote: > > > > Or, could we keep MAX_PHYSMEM_BITS constant, and introduce a _different_ > > > constant > > > that is dynamic, and which could be used in the cases where the 5-level > >

Re: [PATCH 1/2 v4] user namespace: use union in {g,u}idmap struct

2017-10-23 Thread Christian Brauner
On Mon, Oct 23, 2017 at 09:45:34AM +0300, Nikolay Borisov wrote: > > > On 23.10.2017 09:39, Nikolay Borisov wrote: > > > > > > On 19.10.2017 22:11, Christian Brauner wrote: > >> - Add a struct containing two pointer to extents and wrap both the static > >> extent > >> array and the struct

Re: [Part2 PATCH v6 16/38] crypto: ccp: Implement SEV_PEK_GEN ioctl command

2017-10-23 Thread Borislav Petkov
On Mon, Oct 23, 2017 at 07:15:30AM -0500, Brijesh Singh wrote: > I am not sure if I am able to understand your feedback. The > sev_platform_shutdown() is called unconditionally. How's that: If sev_do_cmd() fails and sev_do_cmd(SEV_CMD_SHUTDOWN, ...) in sev_platform_shutdown() fails, then the

[PATCH] ARM: dts: imx28-tx28: fix interrupt flags

2017-10-23 Thread Lothar Waßmann
Some interrupts properties are given '0' as the flags argument. Change them to use the appropriate interrupt flags. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx28-tx28.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 2/2 v5] user namespaces: bump idmap limits to 340

2017-10-23 Thread Christian Brauner
On Mon, Oct 23, 2017 at 10:02:23AM +0200, Tycho Andersen wrote: > On Sun, Oct 22, 2017 at 08:40:36PM +0200, Christian Brauner wrote: > > +/** > > + * insert_extent - Safely insert a new idmap extent into struct > > uid_gid_map. > > + * Takes care to allocate a 4K block of memory if the number of

Re: [PATCH 0/2] KVM: fixes for the kernel-hardening tree

2017-10-23 Thread Cornelia Huck
On Mon, 23 Oct 2017 11:52:51 +0200 David Hildenbrand wrote: > On 21.10.2017 01:25, Paolo Bonzini wrote: > > Two KVM ioctls (KVM_GET/SET_CPUID2) directly access the cpuid_entries > > field of struct kvm_vcpu_arch. Therefore, the new usercopy hardening > > work in linux-next,

[PATCH 2/2] pinctrl: intel: Add Intel Cedar Fork PCH pin controller support

2017-10-23 Thread Mika Westerberg
Intel Cedar Fork PCH is the successor of Intel Denverton PCH but it is based on the newer GPIO/pinctrl hardware block. Add a new pinctrl/GPIO driver to support it. Signed-off-by: Mika Westerberg --- drivers/pinctrl/intel/Kconfig | 8 +

[PATCH 1/2] pinctrl: intel: Make offset to interrupt status register configurable

2017-10-23 Thread Mika Westerberg
Some GPIO blocks have the interrupt status (GPI_IS) offset different than it normally is, so make it configurable. If no offset is specified we use the default. While there remove two unused constants from the core driver. Signed-off-by: Mika Westerberg ---

Re: PROBLEM: Remapping hugepages mappings causes kernel to return EINVAL

2017-10-23 Thread Michal Hocko
On Mon 23-10-17 14:22:30, C.Wehrmeyer wrote: > On 2017-10-23 13:42, Michal Hocko wrote: > > I do not remember any such a request either. I can see some merit in the > > described use case. It is not specific on why hugetlb pages are used for > > the allocator memory because that comes with it own

[tip:x86/asm] x86/entry: Fix idtentry unwind hint

2017-10-23 Thread tip-bot for Josh Poimboeuf
Commit-ID: 98990a33b77dda9babf91cb235654f6729e5702e Gitweb: https://git.kernel.org/tip/98990a33b77dda9babf91cb235654f6729e5702e Author: Josh Poimboeuf AuthorDate: Fri, 20 Oct 2017 11:21:33 -0500 Committer: Ingo Molnar CommitDate: Mon, 23 Oct 2017

Re: [PATCH 0/6] Boot-time switching between 4- and 5-level paging for 4.15, Part 1

2017-10-23 Thread Kirill A. Shutemov
On Mon, Oct 23, 2017 at 02:40:14PM +0200, Ingo Molnar wrote: > > * Kirill A. Shutemov wrote: > > > > Making a variable that 'looks' like a constant macro dynamic in a rare > > > Kconfig > > > scenario is asking for trouble. > > > > We expect boot-time page mode

[PATCH net 1/3] net: mvpp2: fix TSO headers allocation and management

2017-10-23 Thread Antoine Tenart
From: Yan Markman TSO headers are managed with txq index and therefore should be aligned with the txq size, not with the aggregated txq size. Fixes: 186cd4d4e414 ("net: mvpp2: software tso support") Reported-by: Marc Zyngier Signed-off-by: Yan

[PATCH net 2/3] net: mvpp2: do not unmap TSO headers buffers

2017-10-23 Thread Antoine Tenart
The TSO header buffers are coming from a per cpu pool and should not be unmapped as they are reused. The PPv2 driver was unmapping all descriptors buffers unconditionally. This patch fixes this by checking the buffers dma addresses before unmapping them, and by not unmapping those who are located

[PATCH net 3/3] net: mvpp2: do not call txq_done from the Tx path when Tx irqs are used

2017-10-23 Thread Antoine Tenart
When Tx IRQs are used, txq_bufs_free() can be called from both the Tx path and from NAPI poll(). This led to CPU stalls as if these two tasks (Tx and Poll) are scheduled on two CPUs at the same time, DMA unmapping operations are done on the same txq buffers. This patch adds a check not to call

Re: [PATCH v4 1/4] tpm: move wait_for_tpm_stat() to respective driver files

2017-10-23 Thread Nayna Jain
On 10/20/2017 02:26 PM, Jarkko Sakkinen wrote: On Thu, Oct 19, 2017 at 05:00:29PM +, alexander.stef...@infineon.com wrote: On Tue, Oct 17, 2017 at 04:32:29PM -0400, Nayna Jain wrote: The function wait_for_tpm_stat() is currently defined in tpm-interface file. It is a hardware specific

Re: [Part2 PATCH v6 16/38] crypto: ccp: Implement SEV_PEK_GEN ioctl command

2017-10-23 Thread Brijesh Singh
On 10/23/17 7:32 AM, Borislav Petkov wrote: > On Mon, Oct 23, 2017 at 07:15:30AM -0500, Brijesh Singh wrote: >> I am not sure if I am able to understand your feedback. The >> sev_platform_shutdown() is called unconditionally. > How's that: > > If sev_do_cmd() fails and

Re: [1/2] pmbus: added tps544c20 driver with trimming support

2017-10-23 Thread Romain Porte
On 21/10/2017 18:20, Guenter Roeck wrote: This should be part of device programming in manufacturing, just like, say, current calibration. It should not be user programmable, even less so runtime programmable. On top of that, we definitely don't want to make STORE_USER_ALL available to user

Re: [PATCH] mfd: lpc_ich: Avoton/Rangeley uses SPI_BYT method

2017-10-23 Thread Lee Jones
On Wed, 11 Oct 2017, Joakim Tjernlund wrote: > Avoton/Rangeley are based on Silvermount micro-architecture, like > Bay Trail, and uses the INTEL_SPI_BYT method to drive SPI. > > Signed-off-by: Joakim Tjernlund > --- > drivers/mfd/lpc_ich.c | 1 + > 1 file

Re: [PATCH] tpm_i2c_nuvoton: Use common error handling code in i2c_nuvoton_send()

2017-10-23 Thread Jarkko Sakkinen
On Sat, Oct 21, 2017 at 10:11:36PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 21 Oct 2017 22:07:39 +0200 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was

[GIT PULL] pin control fixes for v4.14

2017-10-23 Thread Linus Walleij
Hi Linus, two last minute fixes for pin controllers, both regressions in specific drivers. Nothing special about this, please pull them in! Yours, Linus Walleij The following changes since commit 33d930e59a98fa10a0db9f56c7fa2f21a4aef9b9: Linux 4.14-rc5 (2017-10-15 21:01:12 -0400) are

Re: [PATCHv3 1/1] [tools/selftests]: android/ion: userspace test utility for ion buffer sharing

2017-10-23 Thread Pintu Kumar
On Sat, Oct 21, 2017 at 12:51 AM, Shuah Khan wrote: > On 10/20/2017 09:18 AM, Pintu Kumar wrote: >> On Fri, Oct 20, 2017 at 8:10 PM, Shuah Khan wrote: >>> On 10/18/2017 04:38 AM, Pintu Kumar wrote: On Wed, Oct 18, 2017 at 2:28 AM, Shuah Khan

Re: [PATCH 0/2] Xen vTPM frontend: Fine-tuning for vtpm_send()

2017-10-23 Thread Jarkko Sakkinen
On Sun, Oct 22, 2017 at 01:28:14PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 22 Oct 2017 13:23:45 +0200 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Use common error

Re: [PATCH 0/5] xfs refcount conversions

2017-10-23 Thread Peter Zijlstra
On Sat, Oct 21, 2017 at 10:21:11AM +1100, Dave Chinner wrote: > On Fri, Oct 20, 2017 at 02:07:53PM +0300, Elena Reshetova wrote: > > Note: our previous thread didn't finish in any conclusion, so > > I am resending this now (rebased at latest linux-next) to revive > > the discussion. refcount_t is

Re: [PATCH 1/2] xen-tpmfront: Use common error handling code in vtpm_send()

2017-10-23 Thread Jarkko Sakkinen
On Sun, Oct 22, 2017 at 01:29:33PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 22 Oct 2017 12:56:42 +0200 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was

Re: [PATCH] tpm_tis_core: Use common error handling code in tpm_tis_send_data()

2017-10-23 Thread Jarkko Sakkinen
On Sun, Oct 22, 2017 at 12:16:19PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 22 Oct 2017 11:41:09 +0200 > > Add a jump target so that a specific error code assignment for timeout > conditions will be in the implementation only at the end

Re: [PATCH 2/2] xen-tpmfront: Combine two condition checks into one statement in vtpm_send()

2017-10-23 Thread Jarkko Sakkinen
On Sun, Oct 22, 2017 at 01:30:46PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 22 Oct 2017 13:15:16 +0200 > > A return was performed with the same error code after two condition checks. > Thus use a single statement instead. > >

RE: [PATCH V3 0/6] event synthesization multithreading for perf record

2017-10-23 Thread Liang, Kan
> * kan.li...@intel.com wrote: > > > The latency is the time cost of __machine__synthesize_threads or its > > multithreading replacement, record__multithread_synthesize. > > > > Original: original single thread synthesize > > With patch(not merge): multithread

[PATCH V3 0/2] pseries/nodes: Fix issues with memoryless nodes

2017-10-23 Thread Michael Bringmann
pseries/nodes: Ensure enough nodes avail for operations pseries/initnodes: Ensure nodes initialized for hotplug Signed-off-by: Michael Bringmann Michael Bringmann (2): pseries/nodes: Ensure enough nodes avail for operations pseries/initnodes: Ensure nodes

[PATCH V3 2/2] pseries/initnodes: Ensure nodes initialized for hotplug

2017-10-23 Thread Michael Bringmann
To: linuxppc-...@lists.ozlabs.org To: linux-kernel@vger.kernel.org Cc: Michael Ellerman Cc: Michael Bringmann Cc: John Allen Cc: Nathan Fontenot Subject: [PATCH V3 2/2] pseries/initnodes: Ensure

[PATCH V3 1/2] pseries/nodes: Ensure enough nodes avail for operations

2017-10-23 Thread Michael Bringmann
pseries/nodes: On pseries systems which allow 'hot-add' of CPU or memory resources, it may occur that the new resources are to be inserted into nodes that were not used for these resources at bootup. In the kernel, any node that is used must be defined and initialized. This patch ensures that

Re: [PATCH] locking/spinlock/debug: snapshot lock fields

2017-10-23 Thread Peter Zijlstra
On Mon, Oct 23, 2017 at 01:29:10PM +0100, Mark Rutland wrote: > Currently, the lock debug code doesn't use {READ,WRITE}_ONCE() to access > lock fields, and thus may observe torn values given a suitably unhelpful > compiler. These could result in false positives and/or false negatives > for some

Re: [PATCH] tpm_i2c_nuvoton: Use common error handling code in i2c_nuvoton_send()

2017-10-23 Thread SF Markus Elfring
>> @@ -457,12 +455,15 @@ static int i2c_nuvoton_send(struct tpm_chip *chip, u8 >> *buf, size_t len) >> >read_queue); >> if (rc) { >> dev_err(dev, "%s() timeout command duration\n", __func__); >> -i2c_nuvoton_ready(chip); >> -

[PATCH] paravirt/locks: avoid modifying static key before jump_label_init()

2017-10-23 Thread Juergen Gross
Don't try to set the static virt_spin_lock_key to a value before jump_label_init() has been called, as this will result in a WARN(). Solve the problem by introducing a new lock_init() hook called after jump_label_init() instead of doing the call inside of smp_prepare_boot_cpu(). Signed-off-by:

Re: Atom/GMA500

2017-10-23 Thread Alan Cox
On Sat, 21 Oct 2017 17:31:10 +0200 Benoit Vaillant wrote: > Hello, > > This is my first post here so please do point me to other places if > this is not the mailing list to follow. I've tried IRC #debian and > #linux which pointed to ask here. So here I am. Welcome

Re: [PATCH] tpm_tis_core: Use common error handling code in tpm_tis_send_data()

2017-10-23 Thread SF Markus Elfring
>> @@ -315,6 +311,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, >> const u8 *buf, size_t len) >> >> return 0; >> >> +report_timeout: >> +rc = -ETIME; >> out_err: >> tpm_tis_ready(chip); >> return rc; >> -- >> 2.14.2 >> > > NAK. wait_for_tpm_stat() should give

Re: [PATCH 1/2] xen-tpmfront: Use common error handling code in vtpm_send()

2017-10-23 Thread SF Markus Elfring
>> @@ -108,11 +106,14 @@ static int vtpm_send(struct tpm_chip *chip, u8 *buf, >> size_t count) >> if (wait_for_tpm_stat(chip, VTPM_STATUS_IDLE, duration, >> >read_queue, true) < 0) { >> /* got a signal or timeout, try to cancel */ >> -

Re: [PATCH] Revert "kprobes: Warn if optprobe handler tries to change execution path"

2017-10-23 Thread Naveen N. Rao
On 2017/10/19 09:38PM, Masami Hiramatsu wrote: > On Tue, 17 Oct 2017 13:48:34 +0530 > "Naveen N. Rao" wrote: > > > This reverts commit e863d539614641 ("kprobes: Warn if optprobe handler > > tries to change execution path"). > > > > On powerpc, we place a probe

Re: PROBLEM: Remapping hugepages mappings causes kernel to return EINVAL

2017-10-23 Thread C.Wehrmeyer
On 2017-10-23 14:41, Michal Hocko wrote: On Mon 23-10-17 14:22:30, C.Wehrmeyer wrote: On 2017-10-23 13:42, Michal Hocko wrote: I do not remember any such a request either. I can see some merit in the described use case. It is not specific on why hugetlb pages are used for the allocator memory

Re: [PATCH v2] dwc: dra7xx: Print link state to console for debug

2017-10-23 Thread Bjorn Helgaas
On Mon, Oct 23, 2017 at 03:59:49PM +0530, Faiz Abbas wrote: > On Saturday 21 October 2017 04:39 AM, Bjorn Helgaas wrote: > > On Thu, Oct 19, 2017 at 06:13:29PM +0530, Faiz Abbas wrote: > >> Enable support for printing the LTSSM link state for debugging PCI > >> when link is down. > >> > >>

Re: [Question] null pointer risk of kernel workqueue

2017-10-23 Thread Tejun Heo
Hello, On Mon, Oct 23, 2017 at 09:34:11AM +0800, Li Bin wrote: > > > on 2017/10/21 23:35, Tejun Heo wrote: > > On Fri, Oct 20, 2017 at 02:57:18PM +0800, tanxiaofei wrote: > >> Hi Tejun, > >> > >> Any comments about this? > > > > I think you're confused, or at least can't understand what you're

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

2017-10-23 Thread Stefan Berger
On 10/23/2017 08:38 AM, Jarkko Sakkinen wrote: The reasoning is simple and obvious. Since every call site passes the value TPM_ANY_NUM (0x) the parameter does not have right to exist. Refined the documentation of the corresponding functions. Signed-off-by: Jarkko Sakkinen

<    1   2   3   4   5   6   7   8   9   10   >