RE: [PATCH v7 2/5] irqchip/irq-goldfish-pic: Add Goldfish PIC driver

2017-11-03 Thread Aleksandar Markovic
> From: Joe Perches [j...@perches.com] > ... >On Thu, 2017-11-02 at 17:21 +0100, Aleksandar Markovic wrote: > ... > > > Signed-off-by: Miodrag Dinic > > Signed-off-by: Goran Ferenc > > Signed-off-by: Aleksandar Markovic

Re: [PATCH 07/14] x86: Use lockdep to assert IRQs are disabled/enabled

2017-11-03 Thread Frederic Weisbecker
2017-10-22 11:20 UTC+02:00, Peter Zijlstra : > On Fri, Oct 20, 2017 at 02:56:04AM +0200, Frederic Weisbecker wrote: >> diff --git a/arch/x86/entry/common.c b/arch/x86/entry/common.c >> index 03505ff..b4f3a55 100644 >> --- a/arch/x86/entry/common.c >> +++

[PATCH 5/8] serdev: ttyport: fix tty locking in close

2017-11-03 Thread Johan Hovold
Make sure to hold the tty lock as required when calling tty-driver close() (e.g. to avoid racing with hangup()). Note that the serport active flag is currently set under the lock at controller open, but really isn't protected by it. Fixes: cd6484e1830b ("serdev: Introduce new bus for serial

Re: [PATCH v9 8/8] perf: ARM DynamIQ Shared Unit PMU support

2017-11-03 Thread Suzuki K Poulose
On 03/11/17 12:20, Mark Rutland wrote: Hi Suzuki, This looks good, but there are a couple of edge cases I think that we need to handle, as noted below. On Tue, Oct 31, 2017 at 05:23:18PM +, Suzuki K Poulose wrote: Changes since V8: - Fill in the "module" field for the PMU to prevent

Re: [PATCH] crypto: qat: qat_common: qat_uclo - mark expected switch fall-throughs

2017-11-03 Thread Gustavo A. R. Silva
Quoting Herbert Xu : On Thu, Oct 12, 2017 at 05:55:29PM -0500, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva

[PATCH 3/8] serdev: document driver callbacks

2017-11-03 Thread Johan Hovold
Amend the driver-callback kerneldoc with calling context and expected return values. Note that this is based on the requirements and characteristics of the tty-port controller implementation which receives data in workqueue context and whose write_wakeup callback must not sleep. Also note that

[PATCH v4 14/20] firmware: arm_scmi: add per-protocol channels support using idr objects

2017-11-03 Thread Sudeep Holla
In order to maintain the channel information per protocol, we need some sort of list or hashtable to hold all this information. IDR provides sparse array mapping of small integer ID numbers onto arbitrary pointers. In this case the arbitrary pointers can be pointers to the channel information.

[PATCH v4 11/20] firmware: arm_scmi: add support for polling based SCMI transfers

2017-11-03 Thread Sudeep Holla
It would be useful to have options to perform some SCMI transfers atomically by polling for the completion flag instead of interrupt driven. The SCMI specification has option to disable the interrupt and poll for the completion flag in the shared memory. This patch adds support for polling based

[PATCH v4 12/20] firmware: arm_scmi: add option for polling based performance domain operations

2017-11-03 Thread Sudeep Holla
In order to implement fast CPU DVFS switching, we need to perform all DVFS operations atomically. Since SCMI transfer already provide option to choose between pooling vs interrupt driven(default), we can opt for polling based transfers for set,get performance domain operations. This patch adds

Re: [PATCH v2 2/5] perf/x86: add PERF_SAMPLE_SKID_IP support for X86 PEBS

2017-11-03 Thread Jiri Olsa
On Thu, Nov 02, 2017 at 11:15:56AM -0700, Stephane Eranian wrote: > From: Stephane Eranian > > This atch adds support for SKID_IP to Intel x86 processors in PEBS > mode. s/atch/patch/ > > Signed-off-by: Stephane Eranian > --- >

Re: [PATCH 3/3] nvme: fix eui_show() print format

2017-11-03 Thread Keith Busch
On Fri, Nov 03, 2017 at 01:55:16PM +0100, Christoph Hellwig wrote: > On Fri, Nov 03, 2017 at 11:02:50AM +0100, Javier González wrote: > > Signed-off-by: Javier González > > --- > > drivers/nvme/host/core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >

Re: [PATCH RFC 00/10] Intel EPT-Based Sub-page Write Protection Support.

2017-11-03 Thread Yi Zhang
On 2017-10-14 at 07:11:28 +0800, Zhang Yi wrote: > From: Zhang Yi Z > > Hi All, > > Here is a patch-series which adding EPT-Based Sub-page Write Protection > Support. You can get It's software developer manuals from: > >

Re: [PATCH 2/3] nvme: compare NQN string with right size

2017-11-03 Thread Javier González
> On 3 Nov 2017, at 13.54, Christoph Hellwig wrote: > > On Fri, Nov 03, 2017 at 11:02:49AM +0100, Javier González wrote: >> Compare subnqns using NVMF_NQN_SIZE as it is < 256 >> >> Signed-off-by: Javier González >> --- >> drivers/nvme/host/core.c | 2 +- >> 1

Re: [PATCH v5 2/6] perf record: Get the first sample time and last sample time

2017-11-03 Thread Jin, Yao
On 10/24/2017 3:16 PM, Jiri Olsa wrote: On Tue, Oct 24, 2017 at 10:03:05AM +0800, Jin, Yao wrote: SNIP hum, could you still unset the sample if there's no time given? and keep the speed in this case.. jirka Hi Jiri, I check this question again. The '--time' option is for perf report

[PATCH V13 00/10] mmc: Add Command Queue support

2017-11-03 Thread Adrian Hunter
Hi Here is V13 of the hardware command queue patches without the software command queue patches, now using blk-mq and now with blk-mq support for non-CQE I/O. HW CMDQ offers 25% - 50% better random multi-threaded I/O. I see a slight 2% drop in sequential read speed but no change to sequential

[PATCH V13 01/10] mmc: core: Add parameter use_blk_mq

2017-11-03 Thread Adrian Hunter
Until mmc has blk-mq support fully implemented and tested, add a parameter use_blk_mq, default to false unless config option MMC_MQ_DEFAULT is selected. Signed-off-by: Adrian Hunter --- drivers/mmc/Kconfig | 11 +++ drivers/mmc/core/core.c | 7 +++

Re: Manual unbind of ATA devices causes use-after-free

2017-11-03 Thread Tejun Heo
Hello, On Wed, Nov 01, 2017 at 04:24:47PM -0700, Taras Kondratiuk wrote: > Manual unbind/remove unconditionally invokes devres_release_all which > calls ata_host_release() and frees ata_host/ata_port memory while it is > still being referenced (e.g as a parent of SCSI host). > > Is there a

[PATCH v3] cpufreq: schedutil: Examine the correct CPU when we update util

2017-11-03 Thread Chris Redpath
After 674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks") We stopped always reading utilization for the cpu we are running the governor on, and instead read it for the cpu which we've been told has updated utilization. This is stored in sugov_cpu->cpu. The value is set in

[PATCH v4 09/17] PCI: dwc: dra7xx: Help compiler to remove unused code

2017-11-03 Thread Niklas Cassel
The dra7xx driver supports both host and ep mode. When enabling support for only one of the modes, help the compiler to remove code for the mode that we have not enabled in the driver. By adding if (!IS_ENABLED(CONFIG_PCI_DRA7XX_HOST)) return -ENODEV; anything after that statement will get

[PATCH v4 14/17] PCI: dwc: artpec6: Add support for endpoint mode

2017-11-03 Thread Niklas Cassel
The PCIe controller integrated in ARTPEC-6 SoCs is capable of operating in endpoint mode. Add endpoint mode support to the artpec6 driver. Signed-off-by: Niklas Cassel --- drivers/pci/dwc/Kconfig| 23 +-- drivers/pci/dwc/pcie-artpec6.c | 152

[PATCH v4 11/17] PCI: dwc: artpec6: Use BIT and GENMASK macros

2017-11-03 Thread Niklas Cassel
Use BIT and GENMASK macros to improve readability. Signed-off-by: Niklas Cassel --- drivers/pci/dwc/pcie-artpec6.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/pci/dwc/pcie-artpec6.c

[PATCH v4 15/17] PCI: dwc: Make cpu_addr_fixup take struct dw_pcie as argument

2017-11-03 Thread Niklas Cassel
There is no need to hard code the cpu to bus address fixup mask. The PCIe controller has a global address on the AXI bus, however, from the perspective of the PCIe controller, its base starts at 0x0, so the local address is 0x0. To get the bus address, simply subtract the global address from the

[PATCH v4 12/17] PCI: dwc: artpec6: Split artpec6_pcie_establish_link() into smaller functions

2017-11-03 Thread Niklas Cassel
Split artpec6_pcie_establish_link() into smaller functions to better match other drivers such as dra7xx and imx6. This is also done to prepare for endpoint mode support. Signed-off-by: Niklas Cassel --- drivers/pci/dwc/pcie-artpec6.c | 53

[PATCH v4 07/17] PCI: dwc: dra7xx: Refactor Kconfig and Makefile handling for host/ep mode

2017-11-03 Thread Niklas Cassel
Refactor the Kconfig and Makefile handling for host/ep mode, since the previous handling was a bit unorthodox and would have been a bit bloated once more DWC based controllers added support for ep mode. Signed-off-by: Niklas Cassel Acked-by: Kishon Vijay Abraham I

[PATCH v4 17/17] PCI: dwc: artpec6: Add support for the ARTPEC-7 SoC

2017-11-03 Thread Niklas Cassel
Add support for the ARTPEC-7 SoC in the artpec6 driver. The ARTPEC-6 SoC and the ARTPEC-7 SoC are very similar. Unfortunately, some fields in the PCIECFG and PCIESTAT register have changed. Signed-off-by: Niklas Cassel --- drivers/pci/dwc/pcie-artpec6.c | 162

[PATCH v4 16/17] bindings: PCI: artpec: Add support for the ARTPEC-7 SoC

2017-11-03 Thread Niklas Cassel
Add support for the ARTPEC-7 SoC in the artpec6 driver. The ARTPEC-6 SoC and the ARTPEC-7 SoC are very similar. Unfortunately, some fields in the PCIECFG and PCIESTAT register have changed. Signed-off-by: Niklas Cassel Acked-by: Rob Herring ---

[PATCH] selftests: add required kernel config for intel_pstate

2017-11-03 Thread Lei Yang
intel_pstate depends on CONFIG_X86_INTEL_PSTATE, so add it to the config. Signed-off-by: Lei Yang --- tools/testing/selftests/intel_pstate/config | 1 + 1 file changed, 1 insertion(+) create mode 100644 tools/testing/selftests/intel_pstate/config diff --git

Re: [PATCH v2] arm64: support __int128 on gcc 5+

2017-11-03 Thread Ard Biesheuvel
> On 3 Nov 2017, at 13:42, Will Deacon wrote: > > Hi Jason, > > [+Ard] > >> On Thu, Nov 02, 2017 at 06:43:22PM +0100, Jason A. Donenfeld wrote: >> Versions of gcc prior to gcc 5 emitted a __multi3 function call when >> dealing with TI types, resulting in failures when

Re: [PATCH v2 0/2] KVM: MMU: fix kvm_is_mmio_pfn()

2017-11-03 Thread Mikulas Patocka
On Tue, 31 Oct 2017, Haozhong Zhang wrote: > [I just copy the commit message from patch 2] > > Some reserved pages, such as those from NVDIMM DAX devices, are > not for MMIO, and can be mapped with cached memory type for better > performance. However, the above check misconceives those pages

Re: [PATCH v7 1/6] x86/tsc: remove tsc_disabled flag

2017-11-03 Thread Pavel Tatashin
Hi Dou, Sure, I can remove the warning, but I think we should print something that is indicating that notsc is not a good parameter anymore: i.e tsc=unstable is better. Perhaps something like: "Kernel parameter \'notsc\' is deprecated, please use \'tsc=unstable\' instead" ? Pasha On Thu, Nov

[tip:perf/core] perf callchain: Fix double mapping al->addr for children without self period

2017-11-03 Thread tip-bot for Namhyung Kim
Commit-ID: d6332a176b869df1839abb26c8f80026a66d21d6 Gitweb: https://git.kernel.org/tip/d6332a176b869df1839abb26c8f80026a66d21d6 Author: Namhyung Kim AuthorDate: Fri, 20 Oct 2017 14:15:33 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 31

Re: [PATCH] crypto: cavium: clean up clang warning on unread variable offset

2017-11-03 Thread Herbert Xu
On Thu, Oct 12, 2017 at 05:44:06PM +0100, Colin King wrote: > From: Colin Ian King > > The variable offset is being assigned and not being used; it should > be passed as the 2nd argument to call to function nitrox_write_csr > but has been omitted. Fix this. > > Cleans

Re: [PATCH] crypto: ccp: remove unused variable qim

2017-11-03 Thread Herbert Xu
On Thu, Oct 12, 2017 at 05:55:41PM +0100, Colin King wrote: > From: Colin Ian King > > Variable qim is assigned but never read, it is redundant and can > be removed. > > Cleans up clang warning: Value stored to 'qim' is never read > > Fixes: 4b394a232df7 ("crypto: ccp

[PATCH v3] lib/dlock-list: Scale dlock_lists_empty()

2017-11-03 Thread Davidlohr Bueso
Instead of the current O(N) implementation, at the cost of adding an atomic counter, we can convert the call to an atomic_read(). The counter only serves for accounting empty to non-empty transitions, and vice versa; therefore only modified twice for each of the lists during the lifetime of the

[PATCH 0/3] objtool: sync warning fix and cleanups

2017-11-03 Thread Josh Poimboeuf
Patch 1 fixes the "x86 instruction decoder differs from kernel" warning. Patches 2-3 improve the sync checking so that future warnings will be more useful. Josh Poimboeuf (3): objtool: Resync objtool's instruction decoder with the kernel's objtool: Move synced files to their original

[PATCH 2/3] objtool: Move synced files to their original relative locations

2017-11-03 Thread Josh Poimboeuf
This will enable more straightforward comparisons, and it also allows the files to be 100% identical. Suggested-by: Ingo Molnar Signed-off-by: Josh Poimboeuf --- tools/objtool/.gitignore | 2 +- tools/objtool/Makefile

[PATCH 1/3] objtool: Resync objtool's instruction decoder with the kernel's

2017-11-03 Thread Josh Poimboeuf
This fixes the following warning: warning: objtool: x86 instruction decoder differs from kernel Reported-by: Stephen Rothwell Signed-off-by: Josh Poimboeuf --- tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH 2/3] printk: Add /sys/consoles/ interface

2017-11-03 Thread Kroah-Hartman
On Fri, Nov 03, 2017 at 03:21:14PM +0100, Petr Mladek wrote: > On Thu 2017-09-28 17:43:56, Calvin Owens wrote: > > This adds a new sysfs interface that contains a directory for each > > console registered on the system. Each directory contains a single > > "loglevel" file for reading and setting

Re: next-20171103 build: 3 failures 22 warnings (next-20171103)

2017-11-03 Thread Arnd Bergmann
On Fri, Nov 3, 2017 at 1:44 PM, Build bot for Mark Brown wrote: > > Errors summary: 4 > 2 ../include/linux/kernel.h:931:18: error: invalid type argument of > unary '*' (have 'int') > 2 ../include/linux/kernel.h:930:32: error: invalid type argument of >

usb/sound/usx2y: WARNING in usb_stream_start

2017-11-03 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 3a99df9a3d14cd866b5516f8cba515a3bfd554ab (4.14-rc7+). Looks like there's no check for the actual endpoint types. usb 1-1: BOGUS urb xfer, pipe 0 != type 3 [ cut here ] WARNING: CPU: 0

usb/media/pvrusb2: WARNING in pvr2_i2c_core_done/sysfs_remove_group

2017-11-03 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 3a99df9a3d14cd866b5516f8cba515a3bfd554ab (4.14-rc7+). pvrusb2: Hardware description: OnAir Creator Hybrid USB tuner pvrusb2: Invalid write control endpoint ... pvrusb2: Invalid write control endpoint pvrusb2:

Re: watchdog: f71808e_wdt: mark expected switch fall-throughs

2017-11-03 Thread Gustavo A. R. Silva
Quoting Guenter Roeck : On Thu, Nov 02, 2017 at 02:28:17PM -0500, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I replaced "Fall" with a proper

[PATCH v4 06/20] firmware: arm_scmi: add initial support for performance protocol

2017-11-03 Thread Sudeep Holla
The performance protocol is intended for the performance management of group(s) of device(s) that run in the same performance domain. It includes even the CPUs. A performance domain is defined by a set of devices that always have to run at the same performance level. For example, a set of CPUs

[PATCH v4 09/20] firmware: arm_scmi: add initial support for sensor protocol

2017-11-03 Thread Sudeep Holla
The sensor protocol provides functions to manage platform sensors, and provides the commands to describe the protocol version and the various attribute flags. It also provides commands to discover various sensors implemented and managed by the platform, read any sensor synchronously or

[PATCH] watchdog: pcwd_pci: mark expected switch fall-through

2017-11-03 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I replaced "Fall" with a proper "fall through" comment, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva

[PATCH v4 13/20] firmware: arm_scmi: refactor in preparation to support per-protocol channels

2017-11-03 Thread Sudeep Holla
In order to support per-protocol channels if available, we need to factor out all the mailbox channel information(Tx/Rx payload and channel handle) out of the main SCMI instance information structure. This patch refactors the existing channel information into a separate chan_info structure. Cc:

[PATCH v4 07/20] firmware: arm_scmi: add initial support for clock protocol

2017-11-03 Thread Sudeep Holla
The clock protocol is intended for management of clocks. It is used to enable or disable clocks, and to set and get the clock rates. This protocol provides commands to describe the protocol version, discover various implementation specific attributes, describe a clock, enable and disable a clock

[PATCH v4 08/20] firmware: arm_scmi: add initial support for power protocol

2017-11-03 Thread Sudeep Holla
The power protocol is intended for management of power states of various power domains. The power domain management protocol provides commands to describe the protocol version, discover the implementation specific attributes, set and get the power state of a domain. This patch adds support for

[PATCH 0/2] ACPI / PMIC: make some structures and function argument as const

2017-11-03 Thread Bhumika Goyal
Make some structures and the argument of the function intel_pmic_install_opregion_handler as const. After this change, make the structures of type intel_pmic_opregion_data as const. Bhumika Goyal (2): ACPI / PMIC: Make some pointers, structure field and function argument as const

[PATCH 1/2] ACPI / PMIC: Make some pointers, structure field and function argument as const

2017-11-03 Thread Bhumika Goyal
Make some pointers of type intel_pmic_opregion_data as const as they do not modify the fields of the structure they point too. After this change, make the data field of intel_pmic_opregion structure const as this data field is used for initializing the above pointers that are now const. Finally,

Re: [PATCH v2 5/5] perf/script: add support for skid ip

2017-11-03 Thread Jiri Olsa
On Thu, Nov 02, 2017 at 11:15:59AM -0700, Stephane Eranian wrote: > From: Stephane Eranian > > This patch adds a skid_ip field to perf script > to dump the raw value of the PERF_SAMPLE_SKID_IP > field in each sample. > > $ perf script -F +ip,+skid_ip .. > >

Re: sched/fair: Hard lockup from idle_balance()/task_numa_migrate() race

2017-11-03 Thread Linus Torvalds
I suspect that you'd get more responses if it was an upstream kernel (and preferably newer), or even a distro one. If you run the grsec patches, you need to go to grsec to get support. We don't even know what they are doing, since they're hiding their patches and not breaking them out.

[PATCH 2/2] ACPI / PMIC: make intel_pmic_opregion_data structures const

2017-11-03 Thread Bhumika Goyal
Make these structures as const as they are only passed to the function intel_pmic_install_opregion_handler having the argument as const. Signed-off-by: Bhumika Goyal --- drivers/acpi/pmic/intel_pmic_bxtwc.c | 2 +- drivers/acpi/pmic/intel_pmic_chtwc.c | 2 +-

Re: [PATCH v2 0/3] Call GetEventLog before ExitBootServices

2017-11-03 Thread Jarkko Sakkinen
On Mon, Sep 11, 2017 at 12:00:19PM +0200, Thiebaud Weksteen wrote: > With TPM 1.2, the ACPI table ("TCPA") has two fields to recover the Event Log > Area (LAML and LASA). These logs are useful to understand and rebuild the > final values of PCRs. > > With TPM 2.0, the ACPI table ("TPM2") does not

Re: [PATCH 1/2] scsi: megaraid: Remove redundant code in megasas_alloc_cmds

2017-11-03 Thread Martin K. Petersen
Yisheng, > megasas_alloc_cmds is to alloc cmd_list of instance instead of fusion, > and fusion is useless in this function. Just remove it. Applied to 4.15/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/4] Timer reduction function

2017-11-03 Thread David Howells
David Howells wrote: > I suspect this is of use in other places too - AF_RXRPC possibly, though there > since we usually want an exact timeout and usually further in the future, I'm > not sure whether it's faster to always modify the timer or whether it's faster > to take

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

2017-11-03 Thread Laurentiu Tudor
Hi Greg, On 11/03/2017 05:17 PM, Greg KH wrote: > On Thu, Aug 31, 2017 at 06:04:30PM +0200, Greg KH wrote: >> On Mon, Aug 28, 2017 at 01:54:05PM +0300, laurentiu.tu...@nxp.com wrote: >>> From: Stuart Yoder >>> >>> Move the source files out of staging into their final

Re: [PATCH 2/3] nvme: compare NQN string with right size

2017-11-03 Thread Christoph Hellwig
On Fri, Nov 03, 2017 at 11:02:49AM +0100, Javier González wrote: > Compare subnqns using NVMF_NQN_SIZE as it is < 256 > > Signed-off-by: Javier González > --- > drivers/nvme/host/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH 3/3] nvme: fix eui_show() print format

2017-11-03 Thread Christoph Hellwig
On Fri, Nov 03, 2017 at 11:02:50AM +0100, Javier González wrote: > Signed-off-by: Javier González > --- > drivers/nvme/host/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index

Re: [PATCH] soc: qcom: remove unused label

2017-11-03 Thread Alex Elder
On 10/18/2017 03:30 AM, Arnd Bergmann wrote: > The newly added driver comes with a harmless warning: > > drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe': > drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but > not used [-Werror=unused-label] > > This

Re: [RFC v4 17/17] [media] v4l: Document explicit synchronization behaviour

2017-11-03 Thread Gustavo Padovan
Hi Hans, 2017-11-03 Hans Verkuil : > On 10/20/2017 11:50 PM, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Add section to VIDIOC_QBUF about it > > > > v3: > > - make the out_fence refer to the current buffer (Hans) > > -

Re: watchdog: alim1535_wdt: mark expected switch fall-through

2017-11-03 Thread Guenter Roeck
On Thu, Nov 02, 2017 at 02:25:09PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I replaced "Fall" with a proper > "fall through" comment, which is what GCC

Re: [PATCH v2] arm64: support __int128 on gcc 5+

2017-11-03 Thread Will Deacon
Hi Jason, [+Ard] On Thu, Nov 02, 2017 at 06:43:22PM +0100, Jason A. Donenfeld wrote: > Versions of gcc prior to gcc 5 emitted a __multi3 function call when > dealing with TI types, resulting in failures when trying to link to > libgcc, and more generally, bad performance. However, since gcc 5, >

Re: [PATCH v2 1/2] kprobes: propagate error from arm_kprobe_ftrace()

2017-11-03 Thread Steven Rostedt
On Thu, 2 Nov 2017 17:33:33 +0100 Jessica Yu wrote: > Improve error handling when arming ftrace-based kprobes. Specifically, if > we fail to arm a ftrace-based kprobe, register_kprobe()/enable_kprobe() > should report an error instead of success. Previously, this has lead to >

Re: [PATCH] staging: comedi: usbduxfast: Improve unlocking of a mutex in usbduxfast_ai_insn_read()

2017-11-03 Thread Ian Abbott
On 02/11/17 19:40, SF Markus Elfring wrote: From: Markus Elfring Date: Thu, 2 Nov 2017 20:30:31 +0100 * Add a jump target so that a call of the function "mutex_unlock" is stored only twice in this function implementation. * Replace five calls by goto

Re: [PATCH] staging: comedi: usbduxfast: Improve unlocking of a mutex in usbduxfast_ai_insn_read()

2017-11-03 Thread Greg Kroah-Hartman
On Fri, Nov 03, 2017 at 02:00:18PM +, Ian Abbott wrote: > On 02/11/17 19:40, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Thu, 2 Nov 2017 20:30:31 +0100 > > > > * Add a jump target so that a call of the function "mutex_unlock" is stored > >

Re: [PATCH v2] arm64: support __int128 on gcc 5+

2017-11-03 Thread Jason A. Donenfeld
On Fri, Nov 3, 2017 at 2:42 PM, Will Deacon wrote: > We used to link against libgcc way back when, but that dependency was > removed in commit d67703a8a69e ("arm64: kill off the libgcc dependency") > and I'm really not keen to add it back. I also think that there might > be

Re: [PATCH] firewire-ohci: work around oversized DMA reads on JMicron controllers

2017-11-03 Thread Clemens Ladisch
Hector Martin wrote: > At least some JMicron controllers issue buggy oversized DMA reads when > fetching context descriptors, always fetching 0x20 bytes at once for > descriptors which are only 0x10 bytes long. This is often harmless, but > can cause page faults on modern systems with IOMMUs: > >

Re: [PATCH 2/3] printk: Add /sys/consoles/ interface

2017-11-03 Thread Petr Mladek
On Thu 2017-09-28 17:43:56, Calvin Owens wrote: > This adds a new sysfs interface that contains a directory for each > console registered on the system. Each directory contains a single > "loglevel" file for reading and setting the per-console loglevel. > > We can let kobject destruction race

Re: [PATCH] MAINTAINERS: update TPM driver infrastructure changes

2017-11-03 Thread Jarkko Sakkinen
On Tue, Oct 31, 2017 at 01:41:42AM +0100, Peter Huewe wrote: > Hi, > > Am Freitag, 29. September 2017 22:23:13 CEST schrieb Jarkko Sakkinen: > > On Fri, Sep 29, 2017 at 08:29:09AM +, peter.hu...@infineon.com wrote: > > > > ... > > > Spinics is archiving us at > > >

[tip:perf/core] perf trace beauty prctl: Generate 'option' string table from kernel headers

2017-11-03 Thread tip-bot for Arnaldo Carvalho de Melo
Commit-ID: d688d0376c6eb452565c16c95b26cd2c95aa8a82 Gitweb: https://git.kernel.org/tip/d688d0376c6eb452565c16c95b26cd2c95aa8a82 Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 26 Oct 2017 15:19:35 -0300 Committer: Arnaldo Carvalho de Melo CommitDate:

Re: [PATCH v4] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks

2017-11-03 Thread Niklas Cassel
dra7xx_pcie_shutdown should be static. This patch introduces a new sparse warning. On Wed, Oct 11, 2017 at 9:32 PM, Bjorn Helgaas wrote: > On Wed, Sep 20, 2017 at 10:54:15AM +0530, Keerthy wrote: >> Add shutdown handler to cleanly turn off clocks. This will help >> in cases

Re: [PATCH v7 6/6] x86/tsc: use tsc early

2017-11-03 Thread Pavel Tatashin
Hi Dou, Thank you for testing it! I will rebase this series of the 'tip' tree for the next iteration. Thank you, Pasha

net/media/em28xx: use-after-free in v4l2_fh_init

2017-11-03 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 3a99df9a3d14cd866b5516f8cba515a3bfd554ab (4.14-rc7+). em28xx 1-1:0.0: analog set to bulk mode. em28xx 1-1:0.0: Registering V4L2 extension usb 1-1: USB disconnect, device number 39 em28xx 1-1:0.0: Disconnecting

usb/media/dw2102: null-ptr-deref in dvb_usb_adapter_frontend_init/tt_s2_4600_frontend_attach

2017-11-03 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 3a99df9a3d14cd866b5516f8cba515a3bfd554ab (4.14-rc7+). The report is a little confusing, as the top stack frame is not actually present. As far as my debugging showed, the NULL pointer that's being executed

Re: [PATCH v10 20/38] x86, mpparse: Use memremap to map the mpf and mpc data

2017-11-03 Thread Tomeu Vizoso
On 17 July 2017 at 23:10, Tom Lendacky wrote: > The SMP MP-table is built by UEFI and placed in memory in a decrypted > state. These tables are accessed using a mix of early_memremap(), > early_memunmap(), phys_to_virt() and virt_to_phys(). Change all accesses > to use

Re: [PATCH v2] scsi: be2iscsi: Use kasprintf

2017-11-03 Thread Martin K. Petersen
Himanshu, > Just a reminder, is my patch in our queue ? It is not. It needs a review/ack from the driver maintainers. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 2/3] usb: phy: remove phy-msm-usb.c

2017-11-03 Thread Alex Elder
On 11/02/2017 07:02 PM, Jack Pham wrote: > Hi Alex, > > On Tue, Oct 31, 2017 at 08:11:30AM -0500, Alex Elder wrote: >> No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support >> any more, so remove the code. >> >> Suggested-by: Stephen Boyd >> Signed-off-by:

[PATCH] staging: fbtft: remove redundant initialization of buf

2017-11-03 Thread Colin King
From: Colin Ian King The pointer buf is being set on each iteration of a for-loop and so the initialization of buf at declaration time is redundant and can be removed. Cleans up clang warning: drivers/staging/fbtft/fb_uc1701.c:130:6: warning: Value stored to 'buf'

Re: [PATCH v2 0/3] Sony-laptop: Adjustments for sony_nc_setup_rfkill()

2017-11-03 Thread SF Markus Elfring
> I have applied first two, Thanks for another change acceptance. > the last one is subject to discuss a necessity of it. I can offer another bit of information for this software development discussion. The following build settings were active in my “Makefile” for this Linux test case. …

Re: watchdog: advantechwdt: mark expected switch fall-through

2017-11-03 Thread Guenter Roeck
On Thu, Nov 02, 2017 at 02:21:36PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I replaced "Fall" with a proper > "fall through" comment, which is what GCC

[PATCH] orinoco_usb: remove redundant pointer dev

2017-11-03 Thread Colin King
From: Colin Ian King The pointer dev is assigned but never read, hence it is redundant and can be removed. Cleans up clang warning: drivers/net/wireless/intersil/orinoco/orinoco_usb.c:1468:2: warning: Value stored to 'dev' is never read Signed-off-by: Colin Ian King

[PATCH 1/4] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 00h-0fh) Processors

2017-11-03 Thread Christian König
Just add the extra PCI-ID to the existing fixup. Signed-off-by: Christian König --- arch/x86/pci/fixup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c index 7b6bd76..1d2238d 100644 ---

[PATCH 4/4] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 70h-7fh) Processors

2017-11-03 Thread Christian König
Just add the extra PCI-ID to the existing fixup. Signed-off-by: Christian König --- arch/x86/pci/fixup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c index 3eebb0e..894d73d 100644 ---

[PATCH 3/4] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 60h-6fh) Processors

2017-11-03 Thread Christian König
Just add the extra PCI-ID to the existing fixup. Signed-off-by: Christian König --- arch/x86/pci/fixup.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c index aa8b20e..3eebb0e 100644 ---

[PATCH 2/4] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 10h-1fh) Processors

2017-11-03 Thread Christian König
Just add the extra PCI-ID to the existing fixup. Signed-off-by: Christian König --- arch/x86/pci/fixup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c index 1d2238d..aa8b20e 100644 ---

[PATCH 09/19] perf tools: Rename struct perf_data_file to perf_data

2017-11-03 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Rename struct perf_data_file to perf_data, because we will add the possibility to have multiple files under perf.data, so the 'perf_data' name fits better. Signed-off-by: Jiri Olsa Cc: Andi Kleen Cc: Changbin Du

[PATCH 1/4] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 00h-0fh) Processors

2017-11-03 Thread Christian König
From: Christian König Just add the extra PCI-ID to the existing fixup. Signed-off-by: Christian König --- arch/x86/pci/fixup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c

Re: linux-next: build failure after merge of the workqueues tree

2017-11-03 Thread Tejun Heo
On Thu, Nov 02, 2017 at 02:34:40PM +1100, Stephen Rothwell wrote: > Hi Tejun, > > After merging the workqueues tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > kernel/workqueue.c: In function 'workqueue_init_early': > kernel/workqueue.c:5561:56: error:

[PATCH 11/19] perf tools: Add perf_data_file__write function

2017-11-03 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Adding perf_data_file__write function to provide single file write operation. Signed-off-by: Jiri Olsa Cc: Andi Kleen Cc: Changbin Du Cc: David Ahern Cc: Jin Yao

[PATCH] spi: sh-msiof: remove redundant pointer dev

2017-11-03 Thread Colin King
From: Colin Ian King The pointer dev is assigned but never read, hence it is redundant and can be removed. Cleans up clang warning: drivers/spi/spi-sh-msiof.c:1198:2: warning: Value stored to 'dev' is never read Signed-off-by: Colin Ian King

[tip:perf/core] perf script: Use pr_debug where appropriate

2017-11-03 Thread tip-bot for Arnaldo Carvalho de Melo
Commit-ID: 5ce2c5b4e484a87a8af48649775796fb349684db Gitweb: https://git.kernel.org/tip/5ce2c5b4e484a87a8af48649775796fb349684db Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 26 Oct 2017 09:55:22 -0300 Committer: Arnaldo Carvalho de Melo CommitDate:

[tip:perf/core] tools include uapi: Grab a copy of linux/prctl.h

2017-11-03 Thread tip-bot for Arnaldo Carvalho de Melo
Commit-ID: 433727948904301b01f1d5ebf39893c96cd4bab7 Gitweb: https://git.kernel.org/tip/433727948904301b01f1d5ebf39893c96cd4bab7 Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 26 Oct 2017 14:41:01 -0300 Committer: Arnaldo Carvalho de Melo CommitDate:

[tip:perf/core] tools include uapi: Grab a copy of linux/kcmp.h

2017-11-03 Thread tip-bot for Arnaldo Carvalho de Melo
Commit-ID: 735e215e95e53b857000aaabe1b4707878b10f43 Gitweb: https://git.kernel.org/tip/735e215e95e53b857000aaabe1b4707878b10f43 Author: Arnaldo Carvalho de Melo AuthorDate: Tue, 31 Oct 2017 10:04:11 -0300 Committer: Arnaldo Carvalho de Melo CommitDate:

[tip:perf/core] perf tools: Add struct perf_data_file

2017-11-03 Thread tip-bot for Jiri Olsa
Commit-ID: eae8ad8042d82775da1ddf3faa915b32854d9cf4 Gitweb: https://git.kernel.org/tip/eae8ad8042d82775da1ddf3faa915b32854d9cf4 Author: Jiri Olsa AuthorDate: Mon, 23 Jan 2017 22:25:41 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 30 Oct

Re: [PATCH] crypto: qat: qat_common: qat_uclo - mark expected switch fall-throughs

2017-11-03 Thread Herbert Xu
On Thu, Oct 12, 2017 at 05:55:29PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Patch applied. Thanks. -- Email: Herbert Xu

Re: [PATCH] crypto: qat: remove unused and redundant pointer vf_info

2017-11-03 Thread Herbert Xu
On Thu, Oct 12, 2017 at 06:04:56PM +0100, Colin King wrote: > From: Colin Ian King > > The pointer vf_info is being assigned but never read, it is redundant > and therefore can be removed. > > Cleans up clang warning: Value stored to 'vf_info' is never read > > Fixes:

Re: [PATCH] MAINTAINERS: update caam crypto driver maintainers list

2017-11-03 Thread Herbert Xu
On Fri, Oct 13, 2017 at 03:01:23PM +0300, Horia Geantă wrote: > Dan steps down as caam maintainer, being replaced by Aymen. > > Signed-off-by: Horia Geantă Patch applied. Thanks. -- Email: Herbert Xu Home Page:

[PATCH 0/8] serdev: receive_buf and locking fixes

2017-11-03 Thread Johan Hovold
This series addresses a few issues with the serdev code, including potential information leaks due to missing sanity checks in the receive path, a NULL-deref in write_wakeup() due to missing reference handling, and missing tty locking in close(). Johan Johan Hovold (8): serdev: ttyport: add

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

2017-11-03 Thread Josef Bacik
On Fri, Nov 03, 2017 at 12:12:13AM +0100, Daniel Borkmann wrote: > Hi Josef, > > one more issue I just noticed, see comment below: > > On 11/02/2017 03:37 PM, Josef Bacik wrote: > [...] > > diff --git a/include/linux/filter.h b/include/linux/filter.h > > index cdd78a7beaae..dfa44fd74bae 100644 >

<    1   2   3   4   5   6   7   8   9   10   >