Re: [PATCH v2] eeprom: at24: fix I2C device selection for runtime PM

2017-12-03 Thread Bartosz Golaszewski
2017-12-02 15:48 GMT+01:00 Sakari Ailus : > Hi, > > On Fri, Dec 01, 2017 at 01:37:12PM -0500, Sven Van Asbroeck wrote: >> From: Sakari Ailus >> >> The at24 driver creates dummy I2C devices to access offsets in the chip >> that are

Re: [PATCH v2] eeprom: at24: fix I2C device selection for runtime PM

2017-12-03 Thread Bartosz Golaszewski
2017-12-02 15:48 GMT+01:00 Sakari Ailus : > Hi, > > On Fri, Dec 01, 2017 at 01:37:12PM -0500, Sven Van Asbroeck wrote: >> From: Sakari Ailus >> >> The at24 driver creates dummy I2C devices to access offsets in the chip >> that are outside the area supported using a single I2C address. It is not

Re: [PATCH] ARM: da850: Fix LEGO EV3 battery voltage gpio

2017-12-03 Thread David Lechner
On 12/03/2017 01:29 PM, David Lechner wrote: This fixes the battery voltage monitoring gpio-hog settings. When the gpio is low, it turns off the battery voltage to the ADC chip. However, this needs to be on all of the time so that we can monitor battery voltage. Signed-off-by: David Lechner

Re: [PATCH] ARM: da850: Fix LEGO EV3 battery voltage gpio

2017-12-03 Thread David Lechner
On 12/03/2017 01:29 PM, David Lechner wrote: This fixes the battery voltage monitoring gpio-hog settings. When the gpio is low, it turns off the battery voltage to the ADC chip. However, this needs to be on all of the time so that we can monitor battery voltage. Signed-off-by: David Lechner

Re: [PATCH v6 0/9] i2c: document DMA handling and add helpers for it

2017-12-03 Thread Wolfram Sang
> > > We pretty much assume everything is DMA safe already, the majority of > > > transfers go to/from kmalloc()ed scratch buffers so actually are DMA > > > safe but for bulk transfers we use the caller buffer and there might be > > > some problem users. > > > So, pretty much the situation I2C

Re: [PATCH v6 0/9] i2c: document DMA handling and add helpers for it

2017-12-03 Thread Wolfram Sang
> > > We pretty much assume everything is DMA safe already, the majority of > > > transfers go to/from kmalloc()ed scratch buffers so actually are DMA > > > safe but for bulk transfers we use the caller buffer and there might be > > > some problem users. > > > So, pretty much the situation I2C

Re: [PATCH v2] NTB: ntb_pp: Add full multi-port NTB API support

2017-12-03 Thread kbuild test robot
Hi Serge, I love your patch! Yet something to improve: [auto build test ERROR on v4.15-rc1] [cannot apply to ntb/ntb-next next-20171201] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2] NTB: ntb_pp: Add full multi-port NTB API support

2017-12-03 Thread kbuild test robot
Hi Serge, I love your patch! Yet something to improve: [auto build test ERROR on v4.15-rc1] [cannot apply to ntb/ntb-next next-20171201] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] ARM: da850: Fix LEGO EV3 battery voltage gpio

2017-12-03 Thread David Lechner
This fixes the battery voltage monitoring gpio-hog settings. When the gpio is low, it turns off the battery voltage to the ADC chip. However, this needs to be on all of the time so that we can monitor battery voltage. Signed-off-by: David Lechner ---

[PATCH] ARM: da850: Fix LEGO EV3 battery voltage gpio

2017-12-03 Thread David Lechner
This fixes the battery voltage monitoring gpio-hog settings. When the gpio is low, it turns off the battery voltage to the ADC chip. However, this needs to be on all of the time so that we can monitor battery voltage. Signed-off-by: David Lechner --- arch/arm/boot/dts/da850-lego-ev3.dts | 2 +-

Re: [Intel-gfx] [PATCH V3 09/29] drm/i915: deprecate pci_get_bus_and_slot()

2017-12-03 Thread Sinan Kaya
On 11/28/2017 11:29 AM, Sinan Kaya wrote: > On 11/28/2017 10:30 AM, Ville Syrjälä wrote: >>> + dev_priv->bridge_dev = >>> + pci_get_domain_bus_and_slot(domain, 0, PCI_DEVFN(0, 0)); >> Maybe just pci_get_slot(pdev->bus, PCI_DEVFN(0, 0)) ? >> >> I guess if we want to be pedantic we could

Re: [Intel-gfx] [PATCH V3 09/29] drm/i915: deprecate pci_get_bus_and_slot()

2017-12-03 Thread Sinan Kaya
On 11/28/2017 11:29 AM, Sinan Kaya wrote: > On 11/28/2017 10:30 AM, Ville Syrjälä wrote: >>> + dev_priv->bridge_dev = >>> + pci_get_domain_bus_and_slot(domain, 0, PCI_DEVFN(0, 0)); >> Maybe just pci_get_slot(pdev->bus, PCI_DEVFN(0, 0)) ? >> >> I guess if we want to be pedantic we could

Re: BUG: unable to handle kernel NULL pointer dereference

2017-12-03 Thread Eric Biggers
On Sun, Dec 03, 2017 at 04:37:01AM -0800, syzbot wrote: > BUG: KASAN: use-after-free in skcipher_request_set_tfm > include/crypto/skcipher.h:499 [inline] > BUG: KASAN: use-after-free in crypto_aead_copy_sgl crypto/algif_aead.c:85 > [inline] > BUG: KASAN: use-after-free in _aead_recvmsg

Re: BUG: unable to handle kernel NULL pointer dereference

2017-12-03 Thread Eric Biggers
On Sun, Dec 03, 2017 at 04:37:01AM -0800, syzbot wrote: > BUG: KASAN: use-after-free in skcipher_request_set_tfm > include/crypto/skcipher.h:499 [inline] > BUG: KASAN: use-after-free in crypto_aead_copy_sgl crypto/algif_aead.c:85 > [inline] > BUG: KASAN: use-after-free in _aead_recvmsg

Re: [PATCH] bluetooth: hci_ll: remove \n from kernel messages

2017-12-03 Thread Marcel Holtmann
Hi David, > The bt_* printk macros include a \n already, so we don't need extra ones > here. > > Signed-off-by: David Lechner > --- > drivers/bluetooth/hci_ll.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree.

Re: [PATCH] bluetooth: serdev: hci_ll: Wait for CTS instead of using msleep

2017-12-03 Thread Marcel Holtmann
Hi David, > When a TI Bluetooth chip is reset, it takes about 100ms for the RTS line of > the chip to deassert. For my use case with a TI CC2560A chip, this delay > was not long enough and caused the local UART to never transmit at all (TI > AM1808 SoC UART2). > > We can wait for the CTS signal

Re: [PATCH] bluetooth: hci_ll: remove \n from kernel messages

2017-12-03 Thread Marcel Holtmann
Hi David, > The bt_* printk macros include a \n already, so we don't need extra ones > here. > > Signed-off-by: David Lechner > --- > drivers/bluetooth/hci_ll.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] bluetooth: serdev: hci_ll: Wait for CTS instead of using msleep

2017-12-03 Thread Marcel Holtmann
Hi David, > When a TI Bluetooth chip is reset, it takes about 100ms for the RTS line of > the chip to deassert. For my use case with a TI CC2560A chip, this delay > was not long enough and caused the local UART to never transmit at all (TI > AM1808 SoC UART2). > > We can wait for the CTS signal

[PATCH v2 01/15] NTB: Rename NTB messaging API methods

2017-12-03 Thread Serge Semin
There is a common methods signature form used over all the NTB API like functions naming scheme, arguments names and order, etc. Recently added NTB messaging API IO callbacks were named a bit different so should be renamed to be in compliance with the rest of the API. The changes are made in a way

[PATCH v2 01/15] NTB: Rename NTB messaging API methods

2017-12-03 Thread Serge Semin
There is a common methods signature form used over all the NTB API like functions naming scheme, arguments names and order, etc. Recently added NTB messaging API IO callbacks were named a bit different so should be renamed to be in compliance with the rest of the API. The changes are made in a way

[PATCH v2 00/15] NTB: Add full multi-port API support to the test drivers

2017-12-03 Thread Serge Semin
The multi-port NTB API was introduced in kernel 4.13 as well as the first driver for the true multi-port devices of IDT PCIe-switches series. But the test drivers still were left almost unchanged. Yes, they didn't fail being used with new NTB API, but they only worked with two-ports NTB devices.

[PATCH v2 05/15] NTB: ntb_tool: Add full multi-port NTB API support

2017-12-03 Thread Serge Semin
NTB API has been updated to support multi-port devices like IDT 89HPESx series or Microsemi Switchtec. Message registers functionality has also been added to new API. In order to keep the new hardware and corresponding capabilities well tested, NTB tool driver is accordingly altered.

[PATCH v2 00/15] NTB: Add full multi-port API support to the test drivers

2017-12-03 Thread Serge Semin
The multi-port NTB API was introduced in kernel 4.13 as well as the first driver for the true multi-port devices of IDT PCIe-switches series. But the test drivers still were left almost unchanged. Yes, they didn't fail being used with new NTB API, but they only worked with two-ports NTB devices.

[PATCH v2 05/15] NTB: ntb_tool: Add full multi-port NTB API support

2017-12-03 Thread Serge Semin
NTB API has been updated to support multi-port devices like IDT 89HPESx series or Microsemi Switchtec. Message registers functionality has also been added to new API. In order to keep the new hardware and corresponding capabilities well tested, NTB tool driver is accordingly altered.

[PATCH v2 08/15] NTB: ntb_test: Add ntb_tool port tests

2017-12-03 Thread Serge Semin
Multi-port interface is now available in ntb_tool driver. According to the new NTB API, there might be more than two devices connected over NTB. It means that each device can have multiple freely enumerated ports. Each port got index assigned by the NTB hardware driver. This test is performed to

[PATCH v2 08/15] NTB: ntb_test: Add ntb_tool port tests

2017-12-03 Thread Serge Semin
Multi-port interface is now available in ntb_tool driver. According to the new NTB API, there might be more than two devices connected over NTB. It means that each device can have multiple freely enumerated ports. Each port got index assigned by the NTB hardware driver. This test is performed to

[PATCH v2 02/15] NTB: Set dma mask and dma coherent mask to NTB devices

2017-12-03 Thread Serge Semin
The dma_mask and dma_coherent_mask fields of the NTB struct device weren't initialized in hardware drivers. In fact it should be done instead of PCIe interface usage, since NTB clients are supposed to use NTB API only and left unaware of real hardware implementation. In addition to that

[PATCH v2 02/15] NTB: Set dma mask and dma coherent mask to NTB devices

2017-12-03 Thread Serge Semin
The dma_mask and dma_coherent_mask fields of the NTB struct device weren't initialized in hardware drivers. In fact it should be done instead of PCIe interface usage, since NTB clients are supposed to use NTB API only and left unaware of real hardware implementation. In addition to that

[PATCH v2 12/15] NTB: ntb_test: Add ntb_tool Message tests

2017-12-03 Thread Serge Semin
Messages NTB API is now available. ntb_tool driver has been altered to perform messages send and receive operations. The test of messages read/write to/from peer device has been added to the script. Signed-off-by: Serge Semin --- tools/testing/selftests/ntb/ntb_test.sh

[PATCH v2 06/15] NTB: ntb_perf: Add full multi-port NTB API support

2017-12-03 Thread Serge Semin
NTB API has been updated to support multi-port devices like IDT 89HPESx series or Microsemi Switchtec. Message registers functionality has also been added to new API. In order to keep the new hardware and corresponding capabilities well tested, NTB performance driver is accordingly altered.

[PATCH v2 12/15] NTB: ntb_test: Add ntb_tool Message tests

2017-12-03 Thread Serge Semin
Messages NTB API is now available. ntb_tool driver has been altered to perform messages send and receive operations. The test of messages read/write to/from peer device has been added to the script. Signed-off-by: Serge Semin --- tools/testing/selftests/ntb/ntb_test.sh | 37

[PATCH v2 06/15] NTB: ntb_perf: Add full multi-port NTB API support

2017-12-03 Thread Serge Semin
NTB API has been updated to support multi-port devices like IDT 89HPESx series or Microsemi Switchtec. Message registers functionality has also been added to new API. In order to keep the new hardware and corresponding capabilities well tested, NTB performance driver is accordingly altered.

[PATCH v2 11/15] NTB: ntb_test: Update ntb_tool Scratchpad tests

2017-12-03 Thread Serge Semin
Scratchpad NTB API has been changed so has the ntb_tool driver. Outbound Scratchpad DebugFS files have been moved to peer specific directories. Each scratchpad is now available via separate file. The test code has been accordingly altered. Signed-off-by: Serge Semin ---

[PATCH v2 11/15] NTB: ntb_test: Update ntb_tool Scratchpad tests

2017-12-03 Thread Serge Semin
Scratchpad NTB API has been changed so has the ntb_tool driver. Outbound Scratchpad DebugFS files have been moved to peer specific directories. Each scratchpad is now available via separate file. The test code has been accordingly altered. Signed-off-by: Serge Semin ---

[PATCH v2 15/15] NTB: ntb_hw_idt: Set NTB_TOPO_SWITCH topology

2017-12-03 Thread Serge Semin
Since Switchtec patch there has been a new topology added to the NTB API. It's called NTB_TOPO_SWITCH and dedicated for in general multi-port PCIe switch chips. Even though topo field isn't used within the IDT driver much, lets set it for the sake of unification. Signed-off-by: Serge Semin

[PATCH v2 15/15] NTB: ntb_hw_idt: Set NTB_TOPO_SWITCH topology

2017-12-03 Thread Serge Semin
Since Switchtec patch there has been a new topology added to the NTB API. It's called NTB_TOPO_SWITCH and dedicated for in general multi-port PCIe switch chips. Even though topo field isn't used within the IDT driver much, lets set it for the sake of unification. Signed-off-by: Serge Semin ---

[PATCH v2 09/15] NTB: ntb_test: Update ntb_tool link tests

2017-12-03 Thread Serge Semin
Link Up and Down methods are used to change NTB link settings on local side only for multi-port devices. Link is considered up only if both sides local and peer set it up. Intel/AMD hardware acts a bit different by assigning the Primary and Secondary roles, so Primary device only is able to change

[PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-03 Thread Serge Semin
DB interface of ntb_tool driver hasn't been changed much, but db_valid_mask DebugFS file has still been added to new ntb_tool driver. In this case it's much better to test all valid DB bits instead of using the predefined mask, which may be incorrect in general. Signed-off-by: Serge Semin

[PATCH v2 13/15] NTB: ntb_test: Update ntb_tool MW tests

2017-12-03 Thread Serge Semin
There are devices (like IDT PCIe switches), which outbound MWs xlat address is setup on peer side. In this case local side is supposed to allocate a memory buffer and somehow deliver the xlat DMA address to peer so one could set the outbound MW up. The MW test is altered so to support both

[PATCH v2 09/15] NTB: ntb_test: Update ntb_tool link tests

2017-12-03 Thread Serge Semin
Link Up and Down methods are used to change NTB link settings on local side only for multi-port devices. Link is considered up only if both sides local and peer set it up. Intel/AMD hardware acts a bit different by assigning the Primary and Secondary roles, so Primary device only is able to change

[PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-03 Thread Serge Semin
DB interface of ntb_tool driver hasn't been changed much, but db_valid_mask DebugFS file has still been added to new ntb_tool driver. In this case it's much better to test all valid DB bits instead of using the predefined mask, which may be incorrect in general. Signed-off-by: Serge Semin ---

[PATCH v2 13/15] NTB: ntb_test: Update ntb_tool MW tests

2017-12-03 Thread Serge Semin
There are devices (like IDT PCIe switches), which outbound MWs xlat address is setup on peer side. In this case local side is supposed to allocate a memory buffer and somehow deliver the xlat DMA address to peer so one could set the outbound MW up. The MW test is altered so to support both

[PATCH v2 14/15] NTB: ntb_test: Update ntb_perf tests

2017-12-03 Thread Serge Semin
ntb_perf driver has been also updated so to have the multi-port interface support. User now must specify what peer port is going to be used to perform the test. Signed-off-by: Serge Semin --- tools/testing/selftests/ntb/ntb_test.sh | 13 +++-- 1 file changed, 7

[PATCH v2 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

2017-12-03 Thread Serge Semin
Simple (1 << pidx) operation causes undefined behaviour when pidx >= 32. It must be casted to u64 to match the actual return value of ntb_link_is_up() method, so to have all the possible peer indexes covered and to get rid of undefined behaviour. Additionally there are special macros in

[PATCH v2 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

2017-12-03 Thread Serge Semin
Simple (1 << pidx) operation causes undefined behaviour when pidx >= 32. It must be casted to u64 to match the actual return value of ntb_link_is_up() method, so to have all the possible peer indexes covered and to get rid of undefined behaviour. Additionally there are special macros in

[PATCH v2 14/15] NTB: ntb_test: Update ntb_perf tests

2017-12-03 Thread Serge Semin
ntb_perf driver has been also updated so to have the multi-port interface support. User now must specify what peer port is going to be used to perform the test. Signed-off-by: Serge Semin --- tools/testing/selftests/ntb/ntb_test.sh | 13 +++-- 1 file changed, 7 insertions(+), 6

[PATCH v2 04/15] NTB: ntb_pp: Add full multi-port NTB API support

2017-12-03 Thread Serge Semin
NTB API has been updated to support multi-port devices like IDT 89HPESx series or Microsemi Switchtec. Message registers functionality has also been added to new API. In order to keep the new hardware and corresponding capabilities well tested, NTB pingpong driver is accordingly altered.

[PATCH v2 04/15] NTB: ntb_pp: Add full multi-port NTB API support

2017-12-03 Thread Serge Semin
NTB API has been updated to support multi-port devices like IDT 89HPESx series or Microsemi Switchtec. Message registers functionality has also been added to new API. In order to keep the new hardware and corresponding capabilities well tested, NTB pingpong driver is accordingly altered.

[PATCH v2 07/15] NTB: ntb_test: Safely use paths with whitespace

2017-12-03 Thread Serge Semin
If some of the variables like LOC/REM or LOCAL_*/REMOTE_* got whitespaces, the script may fail with syntax error. Signed-off-by: Serge Semin Acked-by: Logan Gunthorpe Fixes: a9c59ef77458 ("ntb_test: Add a selftest script for the NTB subsystem") ---

[PATCH v2 07/15] NTB: ntb_test: Safely use paths with whitespace

2017-12-03 Thread Serge Semin
If some of the variables like LOC/REM or LOCAL_*/REMOTE_* got whitespaces, the script may fail with syntax error. Signed-off-by: Serge Semin Acked-by: Logan Gunthorpe Fixes: a9c59ef77458 ("ntb_test: Add a selftest script for the NTB subsystem") --- tools/testing/selftests/ntb/ntb_test.sh | 62

Re: BUG: unable to handle kernel paging request in crypto_chacha20_crypt

2017-12-03 Thread Eric Biggers
On Sun, Dec 03, 2017 at 06:24:02AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > dbf9f9124937139e6fcd3f6c64154a699408b481 > git://git.cmpxchg.org/linux-mmots.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. > >

Re: BUG: unable to handle kernel paging request in crypto_chacha20_crypt

2017-12-03 Thread Eric Biggers
On Sun, Dec 03, 2017 at 06:24:02AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > dbf9f9124937139e6fcd3f6c64154a699408b481 > git://git.cmpxchg.org/linux-mmots.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. > >

Re: [v2,2/3] hwmon: (aspeed-pwm-tacho) Deassert reset in probe

2017-12-03 Thread Guenter Roeck
On Thu, Nov 02, 2017 at 02:53:48PM +1100, Joel wrote: > The ASPEED SoC must deassert a reset in order to use the PWM/tach > peripheral. > > Signed-off-by: Joel Stanley I have not heard from anyone objecting to this change, so I am going to accept it. See below for a list of

Re: [v2,2/3] hwmon: (aspeed-pwm-tacho) Deassert reset in probe

2017-12-03 Thread Guenter Roeck
On Thu, Nov 02, 2017 at 02:53:48PM +1100, Joel wrote: > The ASPEED SoC must deassert a reset in order to use the PWM/tach > peripheral. > > Signed-off-by: Joel Stanley I have not heard from anyone objecting to this change, so I am going to accept it. See below for a list of changes required to

kernel/trace/trace_irqsoff.c:855:2: error: implicit declaration of function 'trace_preempt_enable_rcuidle'; did you mean 'trace_irq_enable_rcuidle'?

2017-12-03 Thread kbuild test robot
Hi Joel, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: ae64f9bd1d3621b5e60d7363bc20afb46aede215 commit: d59158162e032917a428704160a2063a02405ec6 tracing: Add support for preempt and irq enable/disable events

kernel/trace/trace_irqsoff.c:855:2: error: implicit declaration of function 'trace_preempt_enable_rcuidle'; did you mean 'trace_irq_enable_rcuidle'?

2017-12-03 Thread kbuild test robot
Hi Joel, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: ae64f9bd1d3621b5e60d7363bc20afb46aede215 commit: d59158162e032917a428704160a2063a02405ec6 tracing: Add support for preempt and irq enable/disable events

Re: [PATCH v2] ipc, mqueue: lazy call kern_mount_data in new namespaces

2017-12-03 Thread kbuild test robot
/linux/commits/Giuseppe-Scrivano/ipc-mqueue-lazy-call-kern_mount_data-in-new-namespaces/20171203-201041 config: i386-randconfig-c0-12032036 (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: # save the attached .config to linux build tree make ARCH=i386

Re: [PATCH v2] ipc, mqueue: lazy call kern_mount_data in new namespaces

2017-12-03 Thread kbuild test robot
/linux/commits/Giuseppe-Scrivano/ipc-mqueue-lazy-call-kern_mount_data-in-new-namespaces/20171203-201041 config: i386-randconfig-c0-12032036 (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: # save the attached .config to linux build tree make ARCH=i386

[PATCH] Make ANDROID a menuconfig to ease disabling it all

2017-12-03 Thread Vincent Legoll
No need to get into the submenu to disable all ANDROID-related config entries Signed-off-by: Vincent Legoll --- drivers/android/Kconfig | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig index

[PATCH] Make ANDROID a menuconfig to ease disabling it all

2017-12-03 Thread Vincent Legoll
No need to get into the submenu to disable all ANDROID-related config entries Signed-off-by: Vincent Legoll --- drivers/android/Kconfig | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig index 7dce3795b887..e9434777acba

Re: [PATCH v4 06/12] [media] cxd2880: Add integration layer for the driver

2017-12-03 Thread Sean Young
On Fri, Oct 13, 2017 at 03:08:34PM +0900, yasunari.takigu...@sony.com wrote: > From: Yasunari Takiguchi > > These functions monitor the driver and watch for task completion. > This is part of the Sony CXD2880 DVB-T2/T tuner + demodulator driver. > > Signed-off-by:

Re: [PATCH v4 06/12] [media] cxd2880: Add integration layer for the driver

2017-12-03 Thread Sean Young
On Fri, Oct 13, 2017 at 03:08:34PM +0900, yasunari.takigu...@sony.com wrote: > From: Yasunari Takiguchi > > These functions monitor the driver and watch for task completion. > This is part of the Sony CXD2880 DVB-T2/T tuner + demodulator driver. > > Signed-off-by: Yasunari Takiguchi >

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-12-03 Thread SF Markus Elfring
> How many times have I told you to include the reason for your patches > in your proposed commit message? Will it be useful to look again at the involved circumstances? > Too often. Did I answer any concerns partly? > Many people do not know that a generic kmalloc does a dump_stack() on

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-12-03 Thread SF Markus Elfring
> How many times have I told you to include the reason for your patches > in your proposed commit message? Will it be useful to look again at the involved circumstances? > Too often. Did I answer any concerns partly? > Many people do not know that a generic kmalloc does a dump_stack() on

[GIT] Networking

2017-12-03 Thread David Miller
1) Various TCP control block fixes, including one that crashes with SELINUX, from David Ahern and Eric Dumazet. 2) Fix ACK generation in rxrpc, from David Howells. 3) ipvlan doesn't set the mark properly in the ipv4 route lookup key, from Gao Feng. 4) SIT configuration doesn't take on

[GIT] Networking

2017-12-03 Thread David Miller
1) Various TCP control block fixes, including one that crashes with SELINUX, from David Ahern and Eric Dumazet. 2) Fix ACK generation in rxrpc, from David Howells. 3) ipvlan doesn't set the mark properly in the ipv4 route lookup key, from Gao Feng. 4) SIT configuration doesn't take on

Re: [PATCH v2 3/3] i2c: at91: added slave mode support

2017-12-03 Thread Ludovic Desroches
Hi Juergen, On Thu, Nov 09, 2017 at 06:22:29PM +0100, Juergen Fitschen wrote: > Slave mode driver is based on the concept of i2c-designware driver. > Sorry to be so long to answer you. I would like to test it before acking it. Unfortunately, I didn't have the time to perform all the tests I

Re: [PATCH v2 3/3] i2c: at91: added slave mode support

2017-12-03 Thread Ludovic Desroches
Hi Juergen, On Thu, Nov 09, 2017 at 06:22:29PM +0100, Juergen Fitschen wrote: > Slave mode driver is based on the concept of i2c-designware driver. > Sorry to be so long to answer you. I would like to test it before acking it. Unfortunately, I didn't have the time to perform all the tests I

Re: [PATCH v2] NTB: ntb_perf: Add full multi-port NTB API support

2017-12-03 Thread kbuild test robot
Hi Serge, I love your patch! Perhaps something to improve: [auto build test WARNING on v4.15-rc1] [cannot apply to ntb/ntb-next next-20171201] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2] NTB: ntb_perf: Add full multi-port NTB API support

2017-12-03 Thread kbuild test robot
Hi Serge, I love your patch! Perhaps something to improve: [auto build test WARNING on v4.15-rc1] [cannot apply to ntb/ntb-next next-20171201] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2] NTB: ntb_perf: Add full multi-port NTB API support

2017-12-03 Thread kbuild test robot
Hi Serge, I love your patch! Yet something to improve: [auto build test ERROR on v4.15-rc1] [cannot apply to ntb/ntb-next next-20171201] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2] NTB: ntb_perf: Add full multi-port NTB API support

2017-12-03 Thread kbuild test robot
Hi Serge, I love your patch! Yet something to improve: [auto build test ERROR on v4.15-rc1] [cannot apply to ntb/ntb-next next-20171201] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/5] bpf: correct broken uapi for BPF_PROG_TYPE_PERF_EVENT program type

2017-12-03 Thread Alexei Starovoitov
On Fri, Dec 01, 2017 at 03:19:04PM +0100, Hendrik Brueckner wrote: > Commit 0515e5999a466dfe ("bpf: introduce BPF_PROG_TYPE_PERF_EVENT > program type") introduced the bpf_perf_event_data structure which > exports the pt_regs structure. This is OK for multiple architectures > but fail for s390 and

Re: [PATCH 1/5] bpf: correct broken uapi for BPF_PROG_TYPE_PERF_EVENT program type

2017-12-03 Thread Alexei Starovoitov
On Fri, Dec 01, 2017 at 03:19:04PM +0100, Hendrik Brueckner wrote: > Commit 0515e5999a466dfe ("bpf: introduce BPF_PROG_TYPE_PERF_EVENT > program type") introduced the bpf_perf_event_data structure which > exports the pt_regs structure. This is OK for multiple architectures > but fail for s390 and

Re: [PATCH 1/2] KVM: x86: fix APIC page invalidation

2017-12-03 Thread Andrea Arcangeli
On Thu, Nov 30, 2017 at 07:05:45PM +0100, Radim Krčmář wrote: > Implementation of the unpinned APIC page didn't update the VMCS address > cache when invalidation was done through range mmu notifiers. > This became a problem when the page notifier was removed. > > Re-introduce the arch-specific

Re: [PATCH] refcount_t: documentation for memory ordering differences

2017-12-03 Thread Randy Dunlap
On 12/02/2017 10:20 PM, Andrea Parri wrote: > On Fri, Dec 01, 2017 at 12:34:23PM -0800, Randy Dunlap wrote: >> On 11/29/2017 04:36 AM, Elena Reshetova wrote: >>> Some functions from refcount_t API provide different >>> memory ordering guarantees that their atomic counterparts. >>> This adds a

Re: [PATCH 1/2] KVM: x86: fix APIC page invalidation

2017-12-03 Thread Andrea Arcangeli
On Thu, Nov 30, 2017 at 07:05:45PM +0100, Radim Krčmář wrote: > Implementation of the unpinned APIC page didn't update the VMCS address > cache when invalidation was done through range mmu notifiers. > This became a problem when the page notifier was removed. > > Re-introduce the arch-specific

Re: [PATCH] refcount_t: documentation for memory ordering differences

2017-12-03 Thread Randy Dunlap
On 12/02/2017 10:20 PM, Andrea Parri wrote: > On Fri, Dec 01, 2017 at 12:34:23PM -0800, Randy Dunlap wrote: >> On 11/29/2017 04:36 AM, Elena Reshetova wrote: >>> Some functions from refcount_t API provide different >>> memory ordering guarantees that their atomic counterparts. >>> This adds a

Re: [PATCH 2/2] TESTING! KVM: x86: add invalidate_range mmu notifier

2017-12-03 Thread Andrea Arcangeli
On Fri, Dec 01, 2017 at 04:15:37PM +0100, Paolo Bonzini wrote: > On 30/11/2017 19:05, Radim Krčmář wrote: > > Does roughly what kvm_mmu_notifier_invalidate_page did before. > > > > I am not certain why this would be needed. It might mean that we have > > another bug with start/end or just that I

Re: [PATCH 2/2] TESTING! KVM: x86: add invalidate_range mmu notifier

2017-12-03 Thread Andrea Arcangeli
On Fri, Dec 01, 2017 at 04:15:37PM +0100, Paolo Bonzini wrote: > On 30/11/2017 19:05, Radim Krčmář wrote: > > Does roughly what kvm_mmu_notifier_invalidate_page did before. > > > > I am not certain why this would be needed. It might mean that we have > > another bug with start/end or just that I

Use-after-free with deferred driver probing and __initconst

2017-12-03 Thread Dan Aloni
Hi all, [[ CC'ed: folks relating to the original __*_refok family of attributes, deferred probing, Open Firmware maintainer, drivers/base/ maintainer, kernel harderning, LKML ]] It seems that it is possible to cause a use-after-free in the base driver platform code using a set of combined

Use-after-free with deferred driver probing and __initconst

2017-12-03 Thread Dan Aloni
Hi all, [[ CC'ed: folks relating to the original __*_refok family of attributes, deferred probing, Open Firmware maintainer, drivers/base/ maintainer, kernel harderning, LKML ]] It seems that it is possible to cause a use-after-free in the base driver platform code using a set of combined

Re: [alsa-devel] [PATCH v4 00/15] soundwire: Add a new SoundWire subsystem

2017-12-03 Thread Vinod Koul
On Fri, Dec 01, 2017 at 06:24:10PM -0600, Pierre-Louis Bossart wrote: > On 12/1/17 3:56 AM, Vinod Koul wrote: > >This patch series adds a new SoundWire subsystem which implements a > >new MIPI bus protocol 'SoundWire'. > > Sorry for the late feedback Vinod and team. > > Overall the code looks

Re: [alsa-devel] [PATCH v4 00/15] soundwire: Add a new SoundWire subsystem

2017-12-03 Thread Vinod Koul
On Fri, Dec 01, 2017 at 06:24:10PM -0600, Pierre-Louis Bossart wrote: > On 12/1/17 3:56 AM, Vinod Koul wrote: > >This patch series adds a new SoundWire subsystem which implements a > >new MIPI bus protocol 'SoundWire'. > > Sorry for the late feedback Vinod and team. > > Overall the code looks

Re: [alsa-devel] [PATCH v4 09/15] soundwire: Add slave status handling

2017-12-03 Thread Vinod Koul
On Fri, Dec 01, 2017 at 05:52:03PM -0600, Pierre-Louis Bossart wrote: > >+status = sdw_read(slave, SDW_DP0_INT); > >+if (status < 0) { > >+dev_err(slave->bus->dev, > >+"SDW_DP0_INT read failed:%d", status); > >+

Re: [alsa-devel] [PATCH v4 09/15] soundwire: Add slave status handling

2017-12-03 Thread Vinod Koul
On Fri, Dec 01, 2017 at 05:52:03PM -0600, Pierre-Louis Bossart wrote: > >+status = sdw_read(slave, SDW_DP0_INT); > >+if (status < 0) { > >+dev_err(slave->bus->dev, > >+"SDW_DP0_INT read failed:%d", status); > >+

Re: [alsa-devel] [PATCH v4 12/15] soundwire: cdns: Add sdw_master_ops and IO transfer support

2017-12-03 Thread Vinod Koul
On Fri, Dec 01, 2017 at 06:02:24PM -0600, Pierre-Louis Bossart wrote: > > > struct sdw_cdns { > > struct device *dev; > > struct sdw_bus bus; > > unsigned int instance; > >+u32 response_buf[0x80]; > > last nit-pick: use a #define for the size. okay last one huh :) yeah will

Re: [alsa-devel] [PATCH v4 12/15] soundwire: cdns: Add sdw_master_ops and IO transfer support

2017-12-03 Thread Vinod Koul
On Fri, Dec 01, 2017 at 06:02:24PM -0600, Pierre-Louis Bossart wrote: > > > struct sdw_cdns { > > struct device *dev; > > struct sdw_bus bus; > > unsigned int instance; > >+u32 response_buf[0x80]; > > last nit-pick: use a #define for the size. okay last one huh :) yeah will

Re: [alsa-devel] [PATCH v4 08/15] soundwire: Add Slave status handling helpers

2017-12-03 Thread Vinod Koul
On Fri, Dec 01, 2017 at 05:36:47PM -0600, Pierre-Louis Bossart wrote: > >+/* called with bus_lock held */ > >+static int sdw_get_device_num(struct sdw_slave *slave) > >+{ > >+int bit; > >+ > >+bit = find_first_zero_bit(slave->bus->assigned, SDW_MAX_DEVICES); > >+if (bit ==

Re: [alsa-devel] [PATCH v4 08/15] soundwire: Add Slave status handling helpers

2017-12-03 Thread Vinod Koul
On Fri, Dec 01, 2017 at 05:36:47PM -0600, Pierre-Louis Bossart wrote: > >+/* called with bus_lock held */ > >+static int sdw_get_device_num(struct sdw_slave *slave) > >+{ > >+int bit; > >+ > >+bit = find_first_zero_bit(slave->bus->assigned, SDW_MAX_DEVICES); > >+if (bit ==

Re: [PATCH v3 1/6] perf: prepare perf_event.h for new types perf_kprobe and perf_uprobe

2017-12-03 Thread Alexei Starovoitov
On Thu, Nov 30, 2017 at 03:50:18PM -0800, Song Liu wrote: > Two new perf types, perf_kprobe and perf_uprobe, will be added to allow > creating [k,u]probe with perf_event_open. These [k,u]probe are associated > with the file decriptor created by perf_event_open, thus are easy to > clean when the

Re: [PATCH v3 1/6] perf: prepare perf_event.h for new types perf_kprobe and perf_uprobe

2017-12-03 Thread Alexei Starovoitov
On Thu, Nov 30, 2017 at 03:50:18PM -0800, Song Liu wrote: > Two new perf types, perf_kprobe and perf_uprobe, will be added to allow > creating [k,u]probe with perf_event_open. These [k,u]probe are associated > with the file decriptor created by perf_event_open, thus are easy to > clean when the

Re: [alsa-devel] [PATCH v4 06/15] soundwire: Add IO transfer

2017-12-03 Thread Vinod Koul
On Fri, Dec 01, 2017 at 05:27:31PM -0600, Pierre-Louis Bossart wrote: > >+static inline int find_response_code(enum sdw_command_response resp) > >+{ > >+switch (resp) { > >+case SDW_CMD_OK: > >+return 0; > >+ > >+case SDW_CMD_IGNORED: > >+return -ENODATA; > >+

Re: [alsa-devel] [PATCH v4 06/15] soundwire: Add IO transfer

2017-12-03 Thread Vinod Koul
On Fri, Dec 01, 2017 at 05:27:31PM -0600, Pierre-Louis Bossart wrote: > >+static inline int find_response_code(enum sdw_command_response resp) > >+{ > >+switch (resp) { > >+case SDW_CMD_OK: > >+return 0; > >+ > >+case SDW_CMD_IGNORED: > >+return -ENODATA; > >+

[PATCH][next] x86/mm: make function clear_non_loaded_ctxs static

2017-12-03 Thread Colin King
From: Colin Ian King The function clear_non_loaded_ctxs is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: arch/x86/mm/tlb.c:37:6: warning: symbol 'clear_non_loaded_ctxs' was not declared. Should it be static?

[PATCH][next] x86/mm: make function clear_non_loaded_ctxs static

2017-12-03 Thread Colin King
From: Colin Ian King The function clear_non_loaded_ctxs is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: arch/x86/mm/tlb.c:37:6: warning: symbol 'clear_non_loaded_ctxs' was not declared. Should it be static? Signed-off-by: Colin Ian

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-03 Thread Marcus Wolf
Am 03.12.2017 um 17:17 schrieb Simon Sandström: Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström ---

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-03 Thread Marcus Wolf
Am 03.12.2017 um 17:17 schrieb Simon Sandström: Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 34

Re: [alsa-devel] [PATCH v4 04/15] soundwire: Add MIPI DisCo property helpers

2017-12-03 Thread Vinod Koul
On Fri, Dec 01, 2017 at 04:49:01PM -0600, Pierre-Louis Bossart wrote: > >+int sdw_master_read_prop(struct sdw_bus *bus) > >+{ > >+struct sdw_master_prop *prop = >prop; > >+struct fwnode_handle *link; > >+unsigned int count = 0; > >+char name[32]; > >+int nval, i; > >+ > >+

Re: [alsa-devel] [PATCH v4 04/15] soundwire: Add MIPI DisCo property helpers

2017-12-03 Thread Vinod Koul
On Fri, Dec 01, 2017 at 04:49:01PM -0600, Pierre-Louis Bossart wrote: > >+int sdw_master_read_prop(struct sdw_bus *bus) > >+{ > >+struct sdw_master_prop *prop = >prop; > >+struct fwnode_handle *link; > >+unsigned int count = 0; > >+char name[32]; > >+int nval, i; > >+ > >+

<    1   2   3   4   5   6   7   >