Re: [kernel-hardening][PATCH v3 0/3] arm: Makes ptdump resuable and add WX page checking

2017-12-05 Thread Laura Abbott
On 12/04/2017 06:24 AM, Jinbum Park wrote: Hi, Page table dumping code for arm64-x86 is reusable, and they have function for WX page checking. But arm doesn't have that. This path series are to makes ptdump reusable, and add WX page checking for arm. This is heavily based on arm64 version. v2

Re: [kernel-hardening][PATCH v3 0/3] arm: Makes ptdump resuable and add WX page checking

2017-12-05 Thread Laura Abbott
On 12/04/2017 06:24 AM, Jinbum Park wrote: Hi, Page table dumping code for arm64-x86 is reusable, and they have function for WX page checking. But arm doesn't have that. This path series are to makes ptdump reusable, and add WX page checking for arm. This is heavily based on arm64 version. v2

Re: [PATCH v2 0/6] bpf: correct broken uapi for BPF_PROG_TYPE_PERF_EVENT program type

2017-12-05 Thread Daniel Borkmann
On 12/05/2017 04:53 PM, Daniel Borkmann wrote: > On 12/04/2017 10:56 AM, Hendrik Brueckner wrote: >> Perf tool bpf selftests revealed a broken uapi for s390 and arm64. >> With the BPF_PROG_TYPE_PERF_EVENT program type the bpf_perf_event >> structure exports the pt_regs structure for all

Re: [PATCH v2 0/6] bpf: correct broken uapi for BPF_PROG_TYPE_PERF_EVENT program type

2017-12-05 Thread Daniel Borkmann
On 12/05/2017 04:53 PM, Daniel Borkmann wrote: > On 12/04/2017 10:56 AM, Hendrik Brueckner wrote: >> Perf tool bpf selftests revealed a broken uapi for s390 and arm64. >> With the BPF_PROG_TYPE_PERF_EVENT program type the bpf_perf_event >> structure exports the pt_regs structure for all

Re: [kernel-hardening][PATCH v3 3/3] arm: mm: dump: add checking for writable and executable pages

2017-12-05 Thread Laura Abbott
On 12/04/2017 06:27 AM, Jinbum Park wrote: Page mappings with full RWX permissions are a security risk. x86, arm64 has an option to walk the page tables and dump any bad pages. (1404d6f13e47 ("arm64: dump: Add checking for writable and exectuable pages")) Add a similar implementation for arm.

Re: [kernel-hardening][PATCH v3 3/3] arm: mm: dump: add checking for writable and executable pages

2017-12-05 Thread Laura Abbott
On 12/04/2017 06:27 AM, Jinbum Park wrote: Page mappings with full RWX permissions are a security risk. x86, arm64 has an option to walk the page tables and dump any bad pages. (1404d6f13e47 ("arm64: dump: Add checking for writable and exectuable pages")) Add a similar implementation for arm.

[PATCH] netfilter: xt_osf: Add missing permission checks

2017-12-05 Thread Kevin Cernekee
The capability check in nfnetlink_rcv() verifies that the caller has CAP_NET_ADMIN in the namespace that "owns" the netlink socket. However, xt_osf_fingers is shared by all net namespaces on the system. An unprivileged user can create user and net namespaces in which he holds CAP_NET_ADMIN to

[PATCH] netfilter: xt_osf: Add missing permission checks

2017-12-05 Thread Kevin Cernekee
The capability check in nfnetlink_rcv() verifies that the caller has CAP_NET_ADMIN in the namespace that "owns" the netlink socket. However, xt_osf_fingers is shared by all net namespaces on the system. An unprivileged user can create user and net namespaces in which he holds CAP_NET_ADMIN to

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Paul E. McKenney
On Wed, Dec 06, 2017 at 12:09:36AM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 10:57:00PM +0100, Peter Zijlstra wrote: > > On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > > > READ_ONCE is really all over the place (some code literally replaced all > > > memory

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Paul E. McKenney
On Wed, Dec 06, 2017 at 12:09:36AM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 10:57:00PM +0100, Peter Zijlstra wrote: > > On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > > > READ_ONCE is really all over the place (some code literally replaced all > > > memory

Re: [PATCH v3 02/15] NTB: Set dma mask and dma coherent mask to NTB devices

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 03:39 PM, Serge Semin wrote: The dma_mask and dma_coherent_mask fields of the NTB struct device weren't initialized in hardware drivers. In fact it should be done instead of PCIe interface usage, since NTB clients are supposed to use NTB API and left unaware of real hardware

Re: [PATCH v3 02/15] NTB: Set dma mask and dma coherent mask to NTB devices

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 03:39 PM, Serge Semin wrote: The dma_mask and dma_coherent_mask fields of the NTB struct device weren't initialized in hardware drivers. In fact it should be done instead of PCIe interface usage, since NTB clients are supposed to use NTB API and left unaware of real hardware

Re: [PATCH v3 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 03:39 PM, Serge Semin wrote: Simple (1 << pidx) operation causes undefined behaviour when pidx >= 32. It must be casted to u64 to match the actual return value of ntb_link_is_up() method, so to have all the possible peer indexes covered and to get rid of undefined behaviour.

Re: [PATCH v3 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 03:39 PM, Serge Semin wrote: Simple (1 << pidx) operation causes undefined behaviour when pidx >= 32. It must be casted to u64 to match the actual return value of ntb_link_is_up() method, so to have all the possible peer indexes covered and to get rid of undefined behaviour.

Re: Timer refuses to expire

2017-12-05 Thread Paul E. McKenney
On Mon, Dec 04, 2017 at 09:42:08AM -0800, Paul E. McKenney wrote: > On Fri, Dec 01, 2017 at 10:25:29AM -0800, Paul E. McKenney wrote: > > Hello, Anna-Maria, > > > > It turned out that one set of problems was due to NO_HZ_FULL issues, > > which are addressed with a pair of patches. However, there

Re: Timer refuses to expire

2017-12-05 Thread Paul E. McKenney
On Mon, Dec 04, 2017 at 09:42:08AM -0800, Paul E. McKenney wrote: > On Fri, Dec 01, 2017 at 10:25:29AM -0800, Paul E. McKenney wrote: > > Hello, Anna-Maria, > > > > It turned out that one set of problems was due to NO_HZ_FULL issues, > > which are addressed with a pair of patches. However, there

Re: [PATCH v3 00/15] NTB: Add full multi-port API support to the test drivers

2017-12-05 Thread Logan Gunthorpe
Please be kind to your reviewers and list all your changes in the cover letter. Also, your sergey.se...@t-platforms.ru email which was CC'd doesn't seem to work for me so I've dropped it from my responses. Thanks, Logan On 05/12/17 03:39 PM, Serge Semin wrote: The multi-port NTB API was

Re: [PATCH v3 00/15] NTB: Add full multi-port API support to the test drivers

2017-12-05 Thread Logan Gunthorpe
Please be kind to your reviewers and list all your changes in the cover letter. Also, your sergey.se...@t-platforms.ru email which was CC'd doesn't seem to work for me so I've dropped it from my responses. Thanks, Logan On 05/12/17 03:39 PM, Serge Semin wrote: The multi-port NTB API was

Re: [PATCH v3 01/15] NTB: Rename NTB messaging API methods

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 03:39 PM, Serge Semin wrote: There is a common methods signature form used over all the NTB API like functions naming scheme, arguments names and order, etc. Recently added NTB messaging API IO callbacks were named a bit different so should be renamed to be in compliance with the

Re: [PATCH v3 01/15] NTB: Rename NTB messaging API methods

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 03:39 PM, Serge Semin wrote: There is a common methods signature form used over all the NTB API like functions naming scheme, arguments names and order, etc. Recently added NTB messaging API IO callbacks were named a bit different so should be renamed to be in compliance with the

Re: [PATCH V11 3/5] printk: hash addresses printed with %p

2017-12-05 Thread Linus Torvalds
On Tue, Dec 5, 2017 at 2:57 PM, Geert Uytterhoeven wrote: > Lowest 3 is good enough for all natural types, up to long long. > We may still receive complaints from people who care about seeing if > a pointer is cacheline-aligned or not. Fixing that may need up to 7 bits, I'm

Re: linux-next: build failure after merge of the mfd tree

2017-12-05 Thread Stephen Rothwell
Hi Lee, On Mon, 4 Dec 2017 09:39:53 + Lee Jones wrote: > > > I added the following fix patch: > > > > From: Stephen Rothwell > > Date: Mon, 4 Dec 2017 14:10:34 +1100 > > Subject: [PATCH] misc: rtsx: fix symbol clashes > > > > Signed-off-by:

[PATCH v9 8/8] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

2017-12-05 Thread Logan Gunthorpe
Clean up the ifdefs which conditionally defined the io{read|write}64 functions in favour of the new common io-64-nonatomic-lo-hi header. Signed-off-by: Logan Gunthorpe Cc: Jon Mason --- drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 30

Re: [PATCH V11 3/5] printk: hash addresses printed with %p

2017-12-05 Thread Linus Torvalds
On Tue, Dec 5, 2017 at 2:57 PM, Geert Uytterhoeven wrote: > Lowest 3 is good enough for all natural types, up to long long. > We may still receive complaints from people who care about seeing if > a pointer is cacheline-aligned or not. Fixing that may need up to 7 bits, I'm > afraid, which is a

Re: linux-next: build failure after merge of the mfd tree

2017-12-05 Thread Stephen Rothwell
Hi Lee, On Mon, 4 Dec 2017 09:39:53 + Lee Jones wrote: > > > I added the following fix patch: > > > > From: Stephen Rothwell > > Date: Mon, 4 Dec 2017 14:10:34 +1100 > > Subject: [PATCH] misc: rtsx: fix symbol clashes > > > > Signed-off-by: Stephen Rothwell > > Although I'm not sure

[PATCH v9 8/8] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

2017-12-05 Thread Logan Gunthorpe
Clean up the ifdefs which conditionally defined the io{read|write}64 functions in favour of the new common io-64-nonatomic-lo-hi header. Signed-off-by: Logan Gunthorpe Cc: Jon Mason --- drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 30 +- 1 file changed, 1 insertion(+),

[PATCH v9 2/8] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs

2017-12-05 Thread Logan Gunthorpe
Subsequent patches in this series makes use of the readq and writeq defines in iomap.h. However, as is, they get missed on the powerpc platform seeing the include comes before the define. This patch moves the include down to fix this. Signed-off-by: Logan Gunthorpe Acked-by:

[PATCH v9 2/8] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs

2017-12-05 Thread Logan Gunthorpe
Subsequent patches in this series makes use of the readq and writeq defines in iomap.h. However, as is, they get missed on the powerpc platform seeing the include comes before the define. This patch moves the include down to fix this. Signed-off-by: Logan Gunthorpe Acked-by: Michael Ellerman

[PATCH v9 0/8] Add io{read|write}64 to io-64-atomic headers

2017-12-05 Thread Logan Gunthorpe
This is v9 of my cleanup series to push a number of instances of people defining their own io{read|write}64 functions when they don't exist in non-64bit systems. This series adds inline functions to the io-64-nonatomic headers and then cleans up the drivers that defined their own. Changes since

[PATCH v9 0/8] Add io{read|write}64 to io-64-atomic headers

2017-12-05 Thread Logan Gunthorpe
This is v9 of my cleanup series to push a number of instances of people defining their own io{read|write}64 functions when they don't exist in non-64bit systems. This series adds inline functions to the io-64-nonatomic headers and then cleans up the drivers that defined their own. Changes since

[PATCH v9 3/8] powerpc: iomap.c: introduce io{read|write}64_{lo_hi|hi_lo}

2017-12-05 Thread Logan Gunthorpe
These functions will be introduced into the generic iomap.c so they can deal with PIO accesses in hi-lo/lo-hi variants. Thus, the powerpc version of iomap.c will need to provide the same functions even though, in this arch, they are identical to the regular io{read|write}64 functions.

[PATCH v9 4/8] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

2017-12-05 Thread Logan Gunthorpe
In order to provide non-atomic functions for io{read|write}64 that will use readq and writeq when appropriate. We define a number of variants of these functions in the generic iomap that will do non-atomic operations on pio but atomic operations on mmio. These functions are only defined if readq

[PATCH v9 3/8] powerpc: iomap.c: introduce io{read|write}64_{lo_hi|hi_lo}

2017-12-05 Thread Logan Gunthorpe
These functions will be introduced into the generic iomap.c so they can deal with PIO accesses in hi-lo/lo-hi variants. Thus, the powerpc version of iomap.c will need to provide the same functions even though, in this arch, they are identical to the regular io{read|write}64 functions.

[PATCH v9 4/8] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

2017-12-05 Thread Logan Gunthorpe
In order to provide non-atomic functions for io{read|write}64 that will use readq and writeq when appropriate. We define a number of variants of these functions in the generic iomap that will do non-atomic operations on pio but atomic operations on mmio. These functions are only defined if readq

[PATCH v9 7/8] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

2017-12-05 Thread Logan Gunthorpe
Clean up the extra ifdefs which defined the wr_reg64 and rd_reg64 functions in non-64bit cases in favour of the new common io-64-nonatomic-lo-hi header. Signed-off-by: Logan Gunthorpe Cc: Andy Shevchenko Cc: Horia Geantă Cc:

[PATCH v9 6/8] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

2017-12-05 Thread Logan Gunthorpe
Now that ioread64 and iowrite64 are available in io-64-nonatomic, we can remove the hack at the top of ntb_hw_intel.c and replace it with an include. Signed-off-by: Logan Gunthorpe Reviewed-by: Andy Shevchenko Acked-by: Dave Jiang

[PATCH v9 1/8] drm/tilcdc: ensure nonatomic iowrite64 is not used

2017-12-05 Thread Logan Gunthorpe
Add a check to ensure iowrite64 is only used if it is atomic. It was decided in [1] that the tilcdc driver should not be using an atomic operation (so it was left out of this patchset). However, it turns out that through the drm code, a nonatomic header is actually included:

[PATCH v9 5/8] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros

2017-12-05 Thread Logan Gunthorpe
This patch adds generic io{read|write}64[be]{_lo_hi|_hi_lo} macros if they are not already defined by the architecture. (As they are provided by the generic iomap library). The patch also points io{read|write}64[be] to the variant specified by the header name. This is because new drivers are

[PATCH v9 6/8] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

2017-12-05 Thread Logan Gunthorpe
Now that ioread64 and iowrite64 are available in io-64-nonatomic, we can remove the hack at the top of ntb_hw_intel.c and replace it with an include. Signed-off-by: Logan Gunthorpe Reviewed-by: Andy Shevchenko Acked-by: Dave Jiang Acked-by: Allen Hubbe Acked-by: Jon Mason # Please enter the

[PATCH v9 1/8] drm/tilcdc: ensure nonatomic iowrite64 is not used

2017-12-05 Thread Logan Gunthorpe
Add a check to ensure iowrite64 is only used if it is atomic. It was decided in [1] that the tilcdc driver should not be using an atomic operation (so it was left out of this patchset). However, it turns out that through the drm code, a nonatomic header is actually included:

[PATCH v9 5/8] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros

2017-12-05 Thread Logan Gunthorpe
This patch adds generic io{read|write}64[be]{_lo_hi|_hi_lo} macros if they are not already defined by the architecture. (As they are provided by the generic iomap library). The patch also points io{read|write}64[be] to the variant specified by the header name. This is because new drivers are

[PATCH v9 7/8] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

2017-12-05 Thread Logan Gunthorpe
Clean up the extra ifdefs which defined the wr_reg64 and rd_reg64 functions in non-64bit cases in favour of the new common io-64-nonatomic-lo-hi header. Signed-off-by: Logan Gunthorpe Cc: Andy Shevchenko Cc: Horia Geantă Cc: Dan Douglass Cc: Herbert Xu Cc: "David S. Miller" ---

Re: [PATCH] clk: fix a panic error caused by accessing NULL pointer

2017-12-05 Thread Stephen Boyd
On 11/21, Chunyan Zhang wrote: > On 21 November 2017 at 16:57, Chunyan Zhang wrote: > > On 21 November 2017 at 03:12, Stephen Boyd wrote: > >> On 11/20, Chunyan Zhang wrote: > >>> From: Cai Li > >>> > >>> In some cases the clock

Re: [PATCH V2] clk: fix a panic error caused by accessing NULL pointer

2017-12-05 Thread Stephen Boyd
On 11/21, Chunyan Zhang wrote: > From: Cai Li > > In some cases the clock parent would be set NULL when doing re-parent, > it will cause a NULL pointer accessing if clk_set trace event is > enabled. > > This patch sets the parent as "none" if the input parameter is NULL.

Re: [PATCH] clk: fix a panic error caused by accessing NULL pointer

2017-12-05 Thread Stephen Boyd
On 11/21, Chunyan Zhang wrote: > On 21 November 2017 at 16:57, Chunyan Zhang wrote: > > On 21 November 2017 at 03:12, Stephen Boyd wrote: > >> On 11/20, Chunyan Zhang wrote: > >>> From: Cai Li > >>> > >>> In some cases the clock parent would be set NULL when doing re-parent, > >>> it will cause

Re: [PATCH V2] clk: fix a panic error caused by accessing NULL pointer

2017-12-05 Thread Stephen Boyd
On 11/21, Chunyan Zhang wrote: > From: Cai Li > > In some cases the clock parent would be set NULL when doing re-parent, > it will cause a NULL pointer accessing if clk_set trace event is > enabled. > > This patch sets the parent as "none" if the input parameter is NULL. > > Fixes:

Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups.

2017-12-05 Thread Matthew Wilcox
On Tue, Dec 05, 2017 at 09:03:02PM -0200, Thiago Rafael Becker wrote: > On Tue, 5 Dec 2017, Matthew Wilcox wrote: > > It must be relatively common to sort an already-sorted array. I wonder > > if something like this patch would be worthwhile? > > The bug happens when two threads enter

Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups.

2017-12-05 Thread Matthew Wilcox
On Tue, Dec 05, 2017 at 09:03:02PM -0200, Thiago Rafael Becker wrote: > On Tue, 5 Dec 2017, Matthew Wilcox wrote: > > It must be relatively common to sort an already-sorted array. I wonder > > if something like this patch would be worthwhile? > > The bug happens when two threads enter

Re: [PATCH v4 02/10] pinctrl: axp209: add pinctrl features

2017-12-05 Thread kbuild test robot
Hi Quentin, Thank you for the patch! Yet something to improve: [auto build test ERROR on pinctrl/devel] [also build test ERROR on v4.15-rc2 next-20171205] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH v4 02/10] pinctrl: axp209: add pinctrl features

2017-12-05 Thread kbuild test robot
Hi Quentin, Thank you for the patch! Yet something to improve: [auto build test ERROR on pinctrl/devel] [also build test ERROR on v4.15-rc2 next-20171205] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [patch 00/60] x86/kpti: Kernel Page Table Isolation (was KAISER)

2017-12-05 Thread Andy Lutomirski
On Tue, Dec 5, 2017 at 1:57 PM, Dave Hansen wrote: > On 12/05/2017 01:49 PM, Andy Lutomirski wrote: >> Random thought for the future: KPTI will make it possible to avoid >> global IPI broadcasts on kernel flushes as we discussed, incorrectly, >> two years ago at LPC. This

Re: [patch 00/60] x86/kpti: Kernel Page Table Isolation (was KAISER)

2017-12-05 Thread Andy Lutomirski
On Tue, Dec 5, 2017 at 1:57 PM, Dave Hansen wrote: > On 12/05/2017 01:49 PM, Andy Lutomirski wrote: >> Random thought for the future: KPTI will make it possible to avoid >> global IPI broadcasts on kernel flushes as we discussed, incorrectly, >> two years ago at LPC. This could be nice. > > I'm

Re: [Intel-gfx] [PATCH v3 4/9] drm: Add some HDCP related #defines

2017-12-05 Thread Chris Wilson
Quoting Sean Paul (2017-12-05 05:15:03) > In preparation for implementing HDCP in i915, add some HDCP related > register offsets and defines. The dpcd register offsets will go in > drm_dp_helper.h whereas the ddc offsets along with generic HDCP stuff > will get stuffed in drm_hdcp.h, which is new.

Re: [Intel-gfx] [PATCH v3 4/9] drm: Add some HDCP related #defines

2017-12-05 Thread Chris Wilson
Quoting Sean Paul (2017-12-05 05:15:03) > In preparation for implementing HDCP in i915, add some HDCP related > register offsets and defines. The dpcd register offsets will go in > drm_dp_helper.h whereas the ddc offsets along with generic HDCP stuff > will get stuffed in drm_hdcp.h, which is new.

Re: [Intel-gfx] [PATCH v3 2/9] drm/i915: Add more control to wait_for routines

2017-12-05 Thread Chris Wilson
Quoting Sean Paul (2017-12-05 05:15:01) > This patch adds a little more control to a couple wait_for routines such > that we can avoid open-coding read/wait/timeout patterns which: > - need the value of the register after the wait_for > - run arbitrary operation for the read portion > > This

Re: [Intel-gfx] [PATCH v3 2/9] drm/i915: Add more control to wait_for routines

2017-12-05 Thread Chris Wilson
Quoting Sean Paul (2017-12-05 05:15:01) > This patch adds a little more control to a couple wait_for routines such > that we can avoid open-coding read/wait/timeout patterns which: > - need the value of the register after the wait_for > - run arbitrary operation for the read portion > > This

Re: [PATCH 5/9] x86/uv: Use the right tlbflush API

2017-12-05 Thread Andrew Banman
On 12/5/17 3:27 PM, Peter Zijlstra wrote: On Tue, Dec 05, 2017 at 03:09:48PM -0600, Andrew Banman wrote: On 12/5/17 6:34 AM, Peter Zijlstra wrote: Since uv_flush_tlb_others() implements flush_tlb_others() which is about flushing user mappings, we should use __flush_tlb_single(), which too is

Re: [PATCH 5/9] x86/uv: Use the right tlbflush API

2017-12-05 Thread Andrew Banman
On 12/5/17 3:27 PM, Peter Zijlstra wrote: On Tue, Dec 05, 2017 at 03:09:48PM -0600, Andrew Banman wrote: On 12/5/17 6:34 AM, Peter Zijlstra wrote: Since uv_flush_tlb_others() implements flush_tlb_others() which is about flushing user mappings, we should use __flush_tlb_single(), which too is

Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups.

2017-12-05 Thread Thiago Rafael Becker
On Tue, 5 Dec 2017, Matthew Wilcox wrote: On Tue, Dec 05, 2017 at 07:11:00AM +1100, NeilBrown wrote: As we don't seem to be pursuing this possibility is probably isn't very important, but I'd like to point out that the original fix isn't a true fix. It just sorts a shared group_info early.

Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups.

2017-12-05 Thread Thiago Rafael Becker
On Tue, 5 Dec 2017, Matthew Wilcox wrote: On Tue, Dec 05, 2017 at 07:11:00AM +1100, NeilBrown wrote: As we don't seem to be pursuing this possibility is probably isn't very important, but I'd like to point out that the original fix isn't a true fix. It just sorts a shared group_info early.

Re: [PATCH net-next v2 0/5] net: dsa: use per-port upstream port

2017-12-05 Thread David Miller
From: Vivien Didelot Date: Tue, 5 Dec 2017 15:34:08 -0500 > An upstream port is a local switch port used to reach a CPU port. > > DSA still considers a unique CPU port in the whole switch fabric and > thus return a unique upstream port for a given switch.

Re: [PATCH net-next v2 0/5] net: dsa: use per-port upstream port

2017-12-05 Thread David Miller
From: Vivien Didelot Date: Tue, 5 Dec 2017 15:34:08 -0500 > An upstream port is a local switch port used to reach a CPU port. > > DSA still considers a unique CPU port in the whole switch fabric and > thus return a unique upstream port for a given switch. This is wrong in > a multiple CPU

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-12-05 Thread Laura Abbott
On 12/02/2017 07:53 AM, Greg KH wrote: This is one of the item in the TODO list before been able to unstage ION which is my real need. Why does it matter where in the tree this code is? Don't go adding new things to it that are not needed. Who needs this? What userspace code wants this type

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-12-05 Thread Laura Abbott
On 12/02/2017 07:53 AM, Greg KH wrote: This is one of the item in the TODO list before been able to unstage ION which is my real need. Why does it matter where in the tree this code is? Don't go adding new things to it that are not needed. Who needs this? What userspace code wants this type

Re: [PATCH 1/2] net: macb: reduce scope of rx_fs_lock-protected regions

2017-12-05 Thread David Miller
From: Julia Cartwright Date: Tue, 5 Dec 2017 14:17:11 -0600 > While Julia Lawall's cocci-generated patch fixes the problem, the right > solution is to obviate the problem altogether. I already applied Julia's patch. And I hope that if you generated this against current net-next

Re: [PATCH 1/2] net: macb: reduce scope of rx_fs_lock-protected regions

2017-12-05 Thread David Miller
From: Julia Cartwright Date: Tue, 5 Dec 2017 14:17:11 -0600 > While Julia Lawall's cocci-generated patch fixes the problem, the right > solution is to obviate the problem altogether. I already applied Julia's patch. And I hope that if you generated this against current net-next you would have

[RFC PATCH] cpuidle/coupled: Handle broadcast enter failures

2017-12-05 Thread James Hogan
From: James Hogan If the hrtimer based broadcast tick device is in use, the enabling of broadcast ticks by cpuidle may fail when the next broadcast event is brought forward to match the next event due on the local tick device, This is because setting the next event may migrate

[RFC PATCH] cpuidle/coupled: Handle broadcast enter failures

2017-12-05 Thread James Hogan
From: James Hogan If the hrtimer based broadcast tick device is in use, the enabling of broadcast ticks by cpuidle may fail when the next broadcast event is brought forward to match the next event due on the local tick device, This is because setting the next event may migrate the hrtimer based

Re: [PATCH V11 3/5] printk: hash addresses printed with %p

2017-12-05 Thread Geert Uytterhoeven
Hi Tobin, On Tue, Dec 5, 2017 at 9:44 PM, Tobin C. Harding wrote: > On Tue, Dec 05, 2017 at 09:20:57PM +0100, Geert Uytterhoeven wrote: >> On Wed, Nov 29, 2017 at 3:05 AM, Tobin C. Harding wrote: >> > Currently there exist approximately 14 000 places in the kernel

Re: [PATCH V11 3/5] printk: hash addresses printed with %p

2017-12-05 Thread Geert Uytterhoeven
Hi Tobin, On Tue, Dec 5, 2017 at 9:44 PM, Tobin C. Harding wrote: > On Tue, Dec 05, 2017 at 09:20:57PM +0100, Geert Uytterhoeven wrote: >> On Wed, Nov 29, 2017 at 3:05 AM, Tobin C. Harding wrote: >> > Currently there exist approximately 14 000 places in the kernel where >> > addresses are being

Re: [RFC 0/3] Safe, dynamically (un)loadable LSMs

2017-12-05 Thread Casey Schaufler
On 12/5/2017 2:02 AM, Sargun Dhillon wrote: > On Wed, Nov 29, 2017 at 6:28 PM, Casey Schaufler > wrote: >> On 11/26/2017 2:15 PM, Sargun Dhillon wrote: >>> This patchset introduces safe dynamic LSM support. It does this via >>> SRCU-protected security hooks. It also

Re: [RFC 0/3] Safe, dynamically (un)loadable LSMs

2017-12-05 Thread Casey Schaufler
On 12/5/2017 2:02 AM, Sargun Dhillon wrote: > On Wed, Nov 29, 2017 at 6:28 PM, Casey Schaufler > wrote: >> On 11/26/2017 2:15 PM, Sargun Dhillon wrote: >>> This patchset introduces safe dynamic LSM support. It does this via >>> SRCU-protected security hooks. It also EXPORT_SYMBOL_GPLs the

[PATCH] netlink: Add netns check on taps

2017-12-05 Thread Kevin Cernekee
Currently, a nlmon link inside a child namespace can observe systemwide netlink activity. Filter the traffic so that in a non-init netns, nlmon can only sniff netlink messages from its own netns. Test case: vpnns -- bash -c "ip link add nlmon0 type nlmon; \ ip link set

[PATCH] netlink: Add netns check on taps

2017-12-05 Thread Kevin Cernekee
Currently, a nlmon link inside a child namespace can observe systemwide netlink activity. Filter the traffic so that in a non-init netns, nlmon can only sniff netlink messages from its own netns. Test case: vpnns -- bash -c "ip link add nlmon0 type nlmon; \ ip link set

Re: linux-next: build warnings after merge of the gpio tree

2017-12-05 Thread Stephen Rothwell
Hi Rob, On Wed, 15 Nov 2017 17:12:00 -0600 Rob Herring wrote: > > On Wed, Nov 15, 2017 at 4:42 PM, Stephen Rothwell > wrote: > > Hi all, > > > > On Thu, 9 Nov 2017 08:37:00 -0600 Rob Herring wrote: > >> > >> On Thu, Nov 9, 2017 at

Re: linux-next: build warnings after merge of the gpio tree

2017-12-05 Thread Stephen Rothwell
Hi Rob, On Wed, 15 Nov 2017 17:12:00 -0600 Rob Herring wrote: > > On Wed, Nov 15, 2017 at 4:42 PM, Stephen Rothwell > wrote: > > Hi all, > > > > On Thu, 9 Nov 2017 08:37:00 -0600 Rob Herring wrote: > >> > >> On Thu, Nov 9, 2017 at 1:42 AM, Linus Walleij > >> wrote: > >> > On Thu, Nov 9,

Re: [PATCH] w1: w1-gpio: Convert to use GPIO descriptors

2017-12-05 Thread Evgeniy Polyakov
Hi Linus Sorry for late reply 20.11.2017, 11:47, "Linus Walleij" : > The w1 master driver includes a complete open drain emulation > reimplementation among other things. > > This converts the driver and all board files using it to use > GPIO descriptors associated with

Re: [PATCH] w1: w1-gpio: Convert to use GPIO descriptors

2017-12-05 Thread Evgeniy Polyakov
Hi Linus Sorry for late reply 20.11.2017, 11:47, "Linus Walleij" : > The w1 master driver includes a complete open drain emulation > reimplementation among other things. > > This converts the driver and all board files using it to use > GPIO descriptors associated with the device to look up the

Re: [PATCH v2 1/2] of: overlay: Fix memory leak in of_overlay_apply() error path

2017-12-05 Thread Frank Rowand
On 12/05/17 08:58, Geert Uytterhoeven wrote: > Hi Frank, > > On Tue, Dec 5, 2017 at 2:45 PM, Frank Rowand wrote: >> On 12/05/17 03:01, Geert Uytterhoeven wrote: >>> On Tue, Dec 5, 2017 at 3:07 AM, Frank Rowand wrote: Also, the previous

Re: [PATCH v2 1/2] of: overlay: Fix memory leak in of_overlay_apply() error path

2017-12-05 Thread Frank Rowand
On 12/05/17 08:58, Geert Uytterhoeven wrote: > Hi Frank, > > On Tue, Dec 5, 2017 at 2:45 PM, Frank Rowand wrote: >> On 12/05/17 03:01, Geert Uytterhoeven wrote: >>> On Tue, Dec 5, 2017 at 3:07 AM, Frank Rowand wrote: Also, the previous version of the patch, and the discussion around the

[PATCH v3 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

2017-12-05 Thread Serge Semin
Simple (1 << pidx) operation causes undefined behaviour when pidx >= 32. It must be casted to u64 to match the actual return value of ntb_link_is_up() method, so to have all the possible peer indexes covered and to get rid of undefined behaviour. Additionally there are special macros in

[PATCH v3 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

2017-12-05 Thread Serge Semin
Simple (1 << pidx) operation causes undefined behaviour when pidx >= 32. It must be casted to u64 to match the actual return value of ntb_link_is_up() method, so to have all the possible peer indexes covered and to get rid of undefined behaviour. Additionally there are special macros in

[PATCH v3 01/15] NTB: Rename NTB messaging API methods

2017-12-05 Thread Serge Semin
There is a common methods signature form used over all the NTB API like functions naming scheme, arguments names and order, etc. Recently added NTB messaging API IO callbacks were named a bit different so should be renamed to be in compliance with the rest of the API. Signed-off-by: Serge Semin

[PATCH v3 01/15] NTB: Rename NTB messaging API methods

2017-12-05 Thread Serge Semin
There is a common methods signature form used over all the NTB API like functions naming scheme, arguments names and order, etc. Recently added NTB messaging API IO callbacks were named a bit different so should be renamed to be in compliance with the rest of the API. Signed-off-by: Serge Semin

[PATCH v3 07/15] NTB: ntb_test: Safely use paths with whitespace

2017-12-05 Thread Serge Semin
If some of variables like LOC/REM or LOCAL_*/REMOTE_* got whitespaces, the script may fail with syntax error. Signed-off-by: Serge Semin --- tools/testing/selftests/ntb/ntb_test.sh | 62 - 1 file changed, 31 insertions(+), 31 deletions(-)

[PATCH v3 07/15] NTB: ntb_test: Safely use paths with whitespace

2017-12-05 Thread Serge Semin
If some of variables like LOC/REM or LOCAL_*/REMOTE_* got whitespaces, the script may fail with syntax error. Signed-off-by: Serge Semin --- tools/testing/selftests/ntb/ntb_test.sh | 62 - 1 file changed, 31 insertions(+), 31 deletions(-) diff --git

[PATCH v3 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-05 Thread Serge Semin
DB interface of ntb_tool driver hasn't been changed much, but db_valid_mask DebugFS file has still been added. In this case it's much better to test all valid DB bits instead of using the predefined mask, which may be incorrect in general. Signed-off-by: Serge Semin ---

[PATCH v3 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-05 Thread Serge Semin
DB interface of ntb_tool driver hasn't been changed much, but db_valid_mask DebugFS file has still been added. In this case it's much better to test all valid DB bits instead of using the predefined mask, which may be incorrect in general. Signed-off-by: Serge Semin ---

[PATCH v3 08/15] NTB: ntb_test: Add ntb_tool port tests

2017-12-05 Thread Serge Semin
Multi-port interface is now available in ntb_tool driver. According to the new NTB API, there might be more than two devices connected over NTB. It means each device can have multiple freely enumerated ports. Each port got index assigned by NTB hardware driver. This test is performed to determine

[PATCH v3 11/15] NTB: ntb_test: Update ntb_tool Scratchpad tests

2017-12-05 Thread Serge Semin
Scratchpad NTB API has changed so has the ntb_tool driver. Outbound Scratchpad DebugFS files have been moved to peer specific directories. Each scratchpad is now available via separate file. The test code has been accordingly altered. Signed-off-by: Serge Semin ---

[PATCH v3 08/15] NTB: ntb_test: Add ntb_tool port tests

2017-12-05 Thread Serge Semin
Multi-port interface is now available in ntb_tool driver. According to the new NTB API, there might be more than two devices connected over NTB. It means each device can have multiple freely enumerated ports. Each port got index assigned by NTB hardware driver. This test is performed to determine

[PATCH v3 11/15] NTB: ntb_test: Update ntb_tool Scratchpad tests

2017-12-05 Thread Serge Semin
Scratchpad NTB API has changed so has the ntb_tool driver. Outbound Scratchpad DebugFS files have been moved to peer specific directories. Each scratchpad is now available via separate file. The test code has been accordingly altered. Signed-off-by: Serge Semin ---

[PATCH v3 06/15] NTB: ntb_perf: Add full multi-port NTB API support

2017-12-05 Thread Serge Semin
Former NTB Performance driver could only work with NTB devices, which got Scratchpads available and had just two ports. Since there are devices, which don't have Scratchpads and got more than two peer ports, the performance measuring tool needs to be rewritten. This patch adds the ability to test

[PATCH v3 05/15] NTB: ntb_tool: Add full multi-port NTB API support

2017-12-05 Thread Serge Semin
Former NTB Debugging tool driver supported only the limited functionality of the recently updated NTB API, which is now available to work with the truly NTB multi-port devices and devices, which got NTB Message registers instead of Scratchpads. This patch fully rewrites the driver so one would

[PATCH v3 06/15] NTB: ntb_perf: Add full multi-port NTB API support

2017-12-05 Thread Serge Semin
Former NTB Performance driver could only work with NTB devices, which got Scratchpads available and had just two ports. Since there are devices, which don't have Scratchpads and got more than two peer ports, the performance measuring tool needs to be rewritten. This patch adds the ability to test

[PATCH v3 05/15] NTB: ntb_tool: Add full multi-port NTB API support

2017-12-05 Thread Serge Semin
Former NTB Debugging tool driver supported only the limited functionality of the recently updated NTB API, which is now available to work with the truly NTB multi-port devices and devices, which got NTB Message registers instead of Scratchpads. This patch fully rewrites the driver so one would

[PATCH v3 12/15] NTB: ntb_test: Add ntb_tool Message tests

2017-12-05 Thread Serge Semin
Messages NTB API is now available. ntb_tool driver has been altered to perform messages send and receive operation. The test of messages read/write to/from peer device has been added to the script. Signed-off-by: Serge Semin --- tools/testing/selftests/ntb/ntb_test.sh |

[PATCH v3 12/15] NTB: ntb_test: Add ntb_tool Message tests

2017-12-05 Thread Serge Semin
Messages NTB API is now available. ntb_tool driver has been altered to perform messages send and receive operation. The test of messages read/write to/from peer device has been added to the script. Signed-off-by: Serge Semin --- tools/testing/selftests/ntb/ntb_test.sh | 37

[PATCH 0/5] perf top overwrite mode

2017-12-05 Thread kan . liang
From: Kan Liang perf_top__mmap_read has severe performance issue in Knights Landing/Mill, when monitoring in heavy load system. It costs several minutes to finish, which is unacceptable. Currently, perf top is non overwrite mode. For non overwrite mode, it tries to read

[PATCH 1/5] perf tools: remove stale perf evlist mmap read for backward

2017-12-05 Thread kan . liang
From: Kan Liang perf_evlist__mmap_read_catchup and perf_evlist__mmap_read_backward are only for overwrite mode. But they read the evlist->mmap buffer which is for non-overwrite mode. It did not bring any serious problem yet, because there is no one use it. Remove the

<    1   2   3   4   5   6   7   8   9   10   >