Re: [PATCH v20 0/7] Virtio-balloon Enhancement

2017-12-19 Thread Matthew Wilcox
On Tue, Dec 19, 2017 at 11:05:11PM +0900, Tetsuo Handa wrote: > Removing exceptional path made this patch easier to read. > But what I meant is > > Can you eliminate exception path and fold all xbitmap patches into one, and > post only one xbitmap patch without virtio-balloon changes? > > .

Re: [Xen-devel] [PATCH v2] xen/balloon: Mark unallocated host memory as UNUSABLE

2017-12-19 Thread Jan Beulich
>>> On 19.12.17 at 15:25, wrote: > On 12/19/2017 03:23 AM, Jan Beulich wrote: > On 18.12.17 at 23:22, wrote: >>> + if (!xen_e820_table) >>> + return; >> Not saying "out of memory" here is certainly fine, but shouldn't >> there nevertheless be a warning, as failure to go through th

Re: [PATCH 13/13] ocxl: add MAINTAINERS entry

2017-12-19 Thread Frederic Barrat
Le 18/12/2017 à 17:04, Joe Perches a écrit : +OCXL (Open Coherent Accelerator Processor Interface OpenCAPI) DRIVER +M: Frederic Barrat +M: Andrew Donnellan +L: linuxppc-...@lists.ozlabs.org +S: Supported +F: arch/powerpc/platforms/powernv/ocxl.c +F: arch/powerpc/include/

Re: [PATCH V2 3/9] ARM: stm32: prepare stm32 family to welcome armv7 architecture

2017-12-19 Thread Alexandre Torgue
On 12/18/2017 09:24 PM, Arnd Bergmann wrote: On Mon, Dec 18, 2017 at 4:17 PM, Ludovic Barre wrote: From: Ludovic Barre This patch prepares the STM32 machine for the integration of Cortex-A based microprocessor (MPU), on top of the existing Cortex-M microcontroller family (MCU). Since both M

[RFC PATCH net-next] tools/bpf: fix build with binutils >= 2.28

2017-12-19 Thread Roman Gushchin
Bpftool build is broken with binutils version 2.28 and later. The cause is commit 003ca0fd2286 ("Refactor disassembler selection") in the binutils repo, which changed the disassembler() function signature. Fix this by checking binutils version and use an appropriate disassembler() signature. Sign

Re: [PATCH v2] Adjustments: lock/unlock task in context_switch

2017-12-19 Thread Peter Zijlstra
On Tue, Dec 19, 2017 at 12:23:57PM -0200, Rodrigo Siqueira wrote: > In the original patch, I called this function as release_lock_task, > because the release_task was already declared as extern in > include/linux/sched/task.h. I believe there is a function name conflict > here, is that correct? Ba

Re: [PATCH v4 1/2] DTS: GTA04: improve panel compatibility string

2017-12-19 Thread Tony Lindgren
* Tomi Valkeinen [171219 10:51]: > On 11/12/17 17:22, Tony Lindgren wrote: > > * H. Nikolaus Schaller [171201 07:44]: > > > Official vendor string is now "tpo" and not "toppoly". > > > > > > Requires patch "omapdrm: panel: fix compatible vendor string for > > > td028ttec1" > > > so that the dri

Re: [PATCH 0/2] platform/x86/thinkpad_acpi: Adjustments for four function implementations

2017-12-19 Thread Andy Shevchenko
On Mon, Dec 18, 2017 at 11:26 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 18 Dec 2017 22:23:45 +0100 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Delete an error message for a failed memory allocation in th

RE: [PATCH] crypto: x86/twofish-3way - Fix %rbp usage

2017-12-19 Thread David Laight
From: Juergen Gross > Sent: 19 December 2017 08:05 .. > > Exchanging 2 registers can be done without memory access via: > > xor reg1, reg2 > xor reg2, reg1 > xor reg1, reg2 That'll generate horrid data dependencies. ISTR that there are some optimisations for the stack, so even 'push reg1', 'mov

Re: [PATCH 4.14 000/178] 4.14.8-stable review

2017-12-19 Thread Guenter Roeck
On 12/18/2017 07:47 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.8 release. There are 178 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be m

Re: [PATCH 4.9 000/177] 4.9.71-stable review

2017-12-19 Thread Guenter Roeck
On 12/18/2017 07:47 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.71 release. There are 177 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be m

Re: [PATCH 4.4 000/115] 4.4.107-stable review

2017-12-19 Thread Guenter Roeck
On 12/18/2017 07:47 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.4.107 release. There are 115 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4/5] sched/isolation: Residual 1Hz scheduler tick offload

2017-12-19 Thread Luiz Capitulino
On Tue, 19 Dec 2017 10:19:11 +0100 Peter Zijlstra wrote: > On Tue, Dec 19, 2017 at 04:23:57AM +0100, Frederic Weisbecker wrote: > > When a CPU runs in full dynticks mode, a 1Hz tick remains in order to > > keep the scheduler stats alive. However this residual tick is a burden > > for Real-Time ta

Re: [PATCH 3.18 00/69] 3.18.89-stable review

2017-12-19 Thread Guenter Roeck
On 12/18/2017 07:47 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 3.18.89 release. There are 69 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be m

[PATCH] swiotlb: suppress warning when __GFP_NOWARN is set.

2017-12-19 Thread Christian König
TTM tries to allocate coherent memory in chunks of 2MB first to improve TLB efficiency and falls back to allocating 4K pages if that fails. Suppress the warning when the 2MB allocations fails since there is a valid fall back path. Signed-off-by: Christian König --- lib/swiotlb.c | 8 +--- 1

Re: [RFC][PATCHv6 00/12] printk: introduce printing kernel thread

2017-12-19 Thread Michal Hocko
On Tue 19-12-17 10:24:55, Sergey Senozhatsky wrote: > On (12/18/17 20:08), Steven Rostedt wrote: > > > ... do you guys read my emails? which part of the traces I have provided > > > suggests that there is any improvement? > > > > The traces I've seen from you were from non-realistic scenarios. > >

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-19 Thread Fabio Estevam
On Tue, Dec 19, 2017 at 11:43 AM, Sakari Ailus wrote: > Both seem to exist. See e.g. c3a3d1d6b8b363a02234e5564692db3647f183e6 . This patch fixes .h files to use /* SPDX style comment, which is the recommendation. .c files should use // SPDX style.

[RFC PATCH] Staging: rtl8723bs: initinterrupt8723bsdio() can be static

2017-12-19 Thread kbuild test robot
Fixes: 8642fab9ea22 ("Staging: rtl8723bs: Change names to conform to the kernel code") Signed-off-by: Fengguang Wu --- sdio_ops.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c i

[PATCH v1] platform/x86: pmc_atom: introduce DEFINE_SHOW_ATTRIBUTE() macro

2017-12-19 Thread Andy Shevchenko
This macro deduplicates a lot of similar code in the pmc_atom.c module. Targeting to be moved to seq_file.h eventually. Signed-off-by: Andy Shevchenko --- drivers/platform/x86/pmc_atom.c | 56 +++-- 1 file changed, 20 insertions(+), 36 deletions(-) diff --git

Re: BUG: workqueue lockup (2)

2017-12-19 Thread Tetsuo Handa
syzbot wrote: > > syzkaller has found reproducer for the following crash on > f3b5ad89de16f5d42e8ad36fbdf85f705c1ae051 "BUG: workqueue lockup" is not a crash. > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached >

Re: [Xen-devel] [PATCH v2] xen/balloon: Mark unallocated host memory as UNUSABLE

2017-12-19 Thread Boris Ostrovsky
On 12/19/2017 03:23 AM, Jan Beulich wrote: On 18.12.17 at 23:22, wrote: + + xen_e820_table = kzalloc(sizeof(*xen_e820_table), GFP_KERNEL); > Wouldn't kmalloc() suffice here? Yes. > >> +if (!xen_e820_table) >> +return; > Not saying "out of memory" here is cert

Re: [PATCH v2] Adjustments: lock/unlock task in context_switch

2017-12-19 Thread Rodrigo Siqueira
Thanks for the review :) Below I just have a small comment in the changed version of the patch > Thanks; I've slightly changed it, find below. I'll queue it for the next > merge window. > > --- > Subject: sched: Rework / clarify prepare_lock_switch() > From: rodrigosiqueira > Date: Fri, 15 Dec

Re: [PATCH V4 13/26] bnx2x: deprecate pci_get_bus_and_slot()

2017-12-19 Thread David Miller
From: Sinan Kaya Date: Tue, 19 Dec 2017 00:37:49 -0500 > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Getting ready to remove pci_get_bus_and_slot() function

Re: [PATCH V4 20/26] openprom: deprecate pci_get_bus_and_slot()

2017-12-19 Thread David Miller
From: Sinan Kaya Date: Tue, 19 Dec 2017 00:37:56 -0500 > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Getting ready to remove pci_get_bus_and_slot() function

Re: [PATCH] Staging: Pi433: Bugfix for wrong argument for sizeof() in TX thread

2017-12-19 Thread Greg KH
On Mon, Dec 18, 2017 at 07:27:58PM +0200, Marcus Wolf wrote: > sizeof(array) != sizeof(pointer to array) > Fixes: "staging: pi433: reduce stack size in tx thread" > > Signed-off-by: Marcus Wolf This should be listed as: Fixes: 62f39d49d168 ("staging: pi433: reduce stack size in tx thread") righ

Re: [PATCH V4 10/26] Drivers: ide: deprecate pci_get_bus_and_slot()

2017-12-19 Thread David Miller
From: Sinan Kaya Date: Tue, 19 Dec 2017 00:37:46 -0500 > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Getting ready to remove pci_get_bus_and_slot() function

Re: [PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

2017-12-19 Thread David Miller
From: Sinan Kaya Date: Tue, 19 Dec 2017 00:37:50 -0500 > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Getting ready to remove pci_get_bus_and_slot() function

Re: BUG: bad usercopy in memdup_user

2017-12-19 Thread Dmitry Vyukov
On Tue, Dec 19, 2017 at 3:08 PM, Tetsuo Handa wrote: > Dmitry Vyukov wrote: >> On Tue, Dec 19, 2017 at 2:22 PM, Matthew Wilcox wrote: >> >> > >> This BUG is reporting >> >> > >> >> >> > >> [ 26.089789] usercopy: kernel memory overwrite attempt detected to >> >> > >> 22a5b430 (kmalloc-1

Re: [PATCH 6/8 v4] staging: pi433: remove unused function

2017-12-19 Thread Greg Kroah-Hartman
On Thu, Dec 14, 2017 at 04:20:20PM +0100, Valentin Vidic wrote: > As it turns out rf69_get_lna_gain is not used at all. > > Signed-off-by: Valentin Vidic > --- > v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE > - move shifting to the header file > v3: - drop auto case > - use CURRE

Re: [RFC PATCH v2 03/13] bootsplash: Flush framebuffer after drawing

2017-12-19 Thread Oliver Neukum
Am Dienstag, den 19.12.2017, 14:57 +0100 schrieb Daniel Vetter: > > Would you like me to extend the FB API or not? > > Yes. Well for real I'd like you to do kms, so maybe you need to explain > why exactly you absolutely have to use fbdev (aka which driver isn't > supported by drm that you want to

Re: [PATCH v5 01/18] PCI: dwc: Use the DMA-API to get the MSI address

2017-12-19 Thread Lorenzo Pieralisi
On Tue, Dec 19, 2017 at 12:45:30PM +, Gustavo Pimentel wrote: >Tested-By: Gustavo Pimentel >Using an arc board with USB and SATA end points with a root complex PCIe >IP core version 5.00, I ran the the following tests: > - I checked that all end points were listed correctly; >

Re: BUG: bad usercopy in memdup_user

2017-12-19 Thread Tetsuo Handa
Dmitry Vyukov wrote: > On Tue, Dec 19, 2017 at 2:22 PM, Matthew Wilcox wrote: > >> > >> This BUG is reporting > >> > >> > >> > >> [ 26.089789] usercopy: kernel memory overwrite attempt detected to > >> > >> 22a5b430 (kmalloc-1024) (1024 bytes) > >> > >> > >> > >> line. But isn't 000

Re: [PATCH v20 0/7] Virtio-balloon Enhancement

2017-12-19 Thread Tetsuo Handa
Wei Wang wrote: > ChangeLog: > v19->v20: > 1) patch 1: xbitmap > - add __rcu to "void **slot"; > - remove the exceptional path. > 2) patch 3: xbitmap > - DeveloperNotes: add an item to comment that the current bit range > related APIs operating on extremely large ranges (e

Re: [PATCH v3] staging: comedi: ni_*: Fix style warnings.

2017-12-19 Thread Greg Kroah-Hartman
On Thu, Dec 14, 2017 at 01:31:05AM -0600, Aniruddha Shastri wrote: > Two of these warnings are now line-too-long warnings. I think these > warnings are preferable to the ones listed below. The longest line is > only 85 chars wide, which is reasonable. > > Warnings fixed: > ni_atmio.c:239: WARNING

Re: [PATCH v9 7/7] intel_sgx: in-kernel launch enclave

2017-12-19 Thread Jarkko Sakkinen
On Sat, Dec 16, 2017 at 06:19:54PM +0200, Jarkko Sakkinen wrote: > The Launch Enclave (LE) generates cryptographic launch tokens for user > enclaves. A launch token is used by EINIT to check whether the enclave > is authorized to launch or not. By having its own launch enclave, Linux > has full con

Re: [PATCH V2 1/2] bdisp: Fix a possible sleep-in-atomic bug in bdisp_hw_reset

2017-12-19 Thread Jia-Ju Bai
On 2017/12/19 18:43, Fabien DESSENNE wrote: Hi, On 16/12/17 12:54, Jia-Ju Bai wrote: The driver may sleep under a spinlock. The function call path is: bdisp_device_run (acquire the spinlock) bdisp_hw_reset msleep --> may sleep To fix it, readl_poll_timeout_atomic is used to replace

Re: [PATCH RFC] stat.2: Document that stat can fail with EINTR

2017-12-19 Thread Michael Kerrisk (man-pages)
Hi Keno, On 12/04/2017 10:03 PM, Keno Fischer wrote: > Hi Michael, > > I was hoping to get a clear statement one way or another from the kernel > maintainers as to whether an EINTR from stat() is supposed to be allowed > kernel behavior (hence the RFC in the subject). If it's not, then I don't

Re: [RFC PATCH v2 03/13] bootsplash: Flush framebuffer after drawing

2017-12-19 Thread Daniel Vetter
On Tue, Dec 19, 2017 at 02:34:22PM +0100, Max Staudt wrote: > On 12/19/2017 01:23 PM, Daniel Vetter wrote: > > On Thu, Dec 14, 2017 at 04:36:49PM +0100, Max Staudt wrote: > >> 2) We need to go out of the way when a graphical application starts, and > >> come back when it's done. fbcon already has t

Re: [PATCH v6 1/3] lib: Add strongly typed 64bit int_sqrt

2017-12-19 Thread Crt Mori
On 19 December 2017 at 14:25, Peter Zijlstra wrote: > On Tue, Dec 19, 2017 at 10:31:18AM +0100, Crt Mori wrote: >> IIO kernel does not have the recent version in, so thanks for heads > > IIO? > Industrial Input / Output Subsytem tree >> up. It does not change much for my function. > > The commen

Re: BUG: unable to handle kernel NULL pointer dereference in __list_del_entry_valid

2017-12-19 Thread Dmitry Vyukov
On Tue, Dec 19, 2017 at 2:42 PM, Michal Hocko wrote: > On Tue 19-12-17 14:38:35, Dmitry Vyukov wrote: >> On Tue, Dec 19, 2017 at 2:22 PM, Michal Hocko wrote: >> > On Tue 19-12-17 14:12:38, Dmitry Vyukov wrote: >> >> On Tue, Dec 19, 2017 at 2:03 PM, Michal Hocko wrote: >> >> > Can we silence this

[PATCH V3 1/2] bdisp: Fix a possible sleep-in-atomic bug in bdisp_hw_reset

2017-12-19 Thread Jia-Ju Bai
The driver may sleep under a spinlock. The function call path is: bdisp_device_run (acquire the spinlock) bdisp_hw_reset msleep --> may sleep To fix it, readl_poll_timeout_atomic is used to replace msleep. This bug is found by my static analysis tool(DSAC) and checked by my code review. Si

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-12-19 Thread Laurent Pinchart
Hi Sakari, On Tuesday, 19 December 2017 15:28:55 EET Sakari Ailus wrote: > On Tue, Dec 19, 2017 at 03:07:41PM +0200, Laurent Pinchart wrote: > > On Tuesday, 19 December 2017 13:57:42 EET jacopo mondi wrote: [snip] > >> Ok, actually parse_dt() and parse_platform_data() behaves differently. > >> T

Re: [PATCH v3 4/5] ARM: davinci: convert to common clock framework

2017-12-19 Thread Sekhar Nori
Hi David, On Saturday 09 December 2017 07:45 AM, David Lechner wrote: > This converts the clocks in mach-davinci to the common clock framework. > > Most of the patch just involves renaming struct clk to struct davinci_clk. > There is also a struct clk_hw added to provide the bridge between the >

[PATCH] mtd: spi-nor: Added ISSI is25lp080d support

2017-12-19 Thread Romain Porte
This patch adds support for a new ISSI 1MB SPI NOR chip that was tested in our lab. Datasheet is available at: http://www.issi.com/WW/pdf/25LP-WP080D.pdf Tested-by: Pascal Fabreges Reviewed-by: Alexander Sverdlin --- drivers/mtd/spi-nor/spi-nor.c | 1 + 1 file changed, 1 insertion(+) diff --gi

Re: nouveau. swiotlb: coherent allocation failed for device 0000:01:00.0 size=2097152

2017-12-19 Thread Christian König
Am 19.12.2017 um 11:39 schrieb Michel Dänzer: On 2017-12-19 11:37 AM, Michel Dänzer wrote: On 2017-12-18 08:01 PM, Tobias Klausmann wrote: On 12/18/17 7:06 PM, Mike Galbraith wrote: Greetings, Kernel bound workloads seem to trigger the below for whatever reason.   I only see this when beatin

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-19 Thread Sakari Ailus
On Tue, Dec 19, 2017 at 11:19:06AM -0200, Fabio Estevam wrote: > Hi Sakari, > > On Tue, Dec 19, 2017 at 11:05 AM, Sakari Ailus wrote: > > > I guess it depends on who do you ask and when. Looking at what has been > > recently merged to media tree master, the latter is preferred. > > Just did 'gi

Re: PROBLEM: NULL pointer dereference in kernel 4.14.6

2017-12-19 Thread Tejun Heo
On Sun, Dec 17, 2017 at 03:24:48PM -0800, vcap...@pengaru.com wrote: > On Sun, Dec 17, 2017 at 05:49:44PM +, Bronek Kozicki wrote: > > I just upgraded to 4.14.7 and tried to reproduce this error, this time > > under strace. As you can see this happens when systemctl tries to read a > > specif

Re: BUG: unable to handle kernel NULL pointer dereference in __list_del_entry_valid

2017-12-19 Thread Michal Hocko
On Tue 19-12-17 14:38:35, Dmitry Vyukov wrote: > On Tue, Dec 19, 2017 at 2:22 PM, Michal Hocko wrote: > > On Tue 19-12-17 14:12:38, Dmitry Vyukov wrote: > >> On Tue, Dec 19, 2017 at 2:03 PM, Michal Hocko wrote: > >> > Can we silence this duplicates [1] please? > >> > > >> > [1] http://lkml.kernel

Re: BUG: bad usercopy in memdup_user

2017-12-19 Thread Dmitry Vyukov
On Tue, Dec 19, 2017 at 2:22 PM, Matthew Wilcox wrote: >> > >> This BUG is reporting >> > >> >> > >> [ 26.089789] usercopy: kernel memory overwrite attempt detected to >> > >> 22a5b430 (kmalloc-1024) (1024 bytes) >> > >> >> > >> line. But isn't 22a5b430 strange for kmalloc(1024,

Re: [PATCH] cgroup: Fix deadlock in cpu hotplug path

2017-12-19 Thread Tejun Heo
On Tue, Dec 19, 2017 at 12:56:57PM +0530, Prateek Sood wrote: > Deadlock during cgroup migration from cpu hotplug path when a task T is > being moved from source to destination cgroup. ... > Task T inserted a work item in the worklist of cpu0 low priority > worker pool. It is waiting for expedited

Re: BUG: unable to handle kernel NULL pointer dereference in __list_del_entry_valid

2017-12-19 Thread Dmitry Vyukov
On Tue, Dec 19, 2017 at 2:22 PM, Michal Hocko wrote: > On Tue 19-12-17 14:12:38, Dmitry Vyukov wrote: >> On Tue, Dec 19, 2017 at 2:03 PM, Michal Hocko wrote: >> > Can we silence this duplicates [1] please? >> > >> > [1] http://lkml.kernel.org/r/001a1140f57806ebef05608b2...@google.com >> >> Hi Mic

Re: [RFC PATCH v2 03/13] bootsplash: Flush framebuffer after drawing

2017-12-19 Thread Max Staudt
On 12/19/2017 01:23 PM, Daniel Vetter wrote: > On Thu, Dec 14, 2017 at 04:36:49PM +0100, Max Staudt wrote: >> 2) We need to go out of the way when a graphical application starts, and >> come back when it's done. fbcon already has the logic for this, and >> fbcon is also the thing we're trying to hi

Re: [kernel-hardening] [PATCH] Kconfig: Make STRICT_DEVMEM default-y on x86 and arm64

2017-12-19 Thread Ard Biesheuvel
On 1 December 2017 at 20:10, Kees Cook wrote: > Distros have been shipping with CONFIG_STRICT_DEVMEM=y for years now. It > is probably time to flip this default for x86 and arm64. > > Signed-off-by: Kees Cook Acked-by: Ard Biesheuvel > --- > lib/Kconfig.debug | 2 +- > 1 file changed, 1 inser

Re: [PATCH v2] writeback: synchronize sync(2) against cgroup writeback membership switches

2017-12-19 Thread Tejun Heo
On Tue, Dec 19, 2017 at 02:04:54PM +0100, Jan Kara wrote: > After some thinking about this I don't have a better solution. So you can > add: > > Acked-by: Jan Kara Thanks, Jan. Jens, can you please route this through block tree? Thanks. -- tejun

[PATCH 2/2] VFS: handle register_shrinker failure in sget_userns

2017-12-19 Thread Michal Hocko
From: Michal Hocko Syzbot caught an oops at unregister_shrinker() because combination of commit 1d3d4437eae1bb29 ("vmscan: per-node deferred work") and fault injection made register_shrinker() fail and the caller of register_shrinker() did not check for failure. -- [ 554.881422] FAULT_I

[PATCH 1/2] mm,vmscan: Make unregister_shrinker() no-op if register_shrinker() failed.

2017-12-19 Thread Michal Hocko
From: Tetsuo Handa Since allowing register_shrinker() callers to call unregister_shrinker() when register_shrinker() failed can simplify error recovery path, this patch makes unregister_shrinker() no-op when register_shrinker() failed. Let's also make sure that double unregister_shrinker doesn't

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-12-19 Thread Sakari Ailus
Heippa! On Tue, Dec 19, 2017 at 03:07:41PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > (CC'ing Sakari) > > On Tuesday, 19 December 2017 13:57:42 EET jacopo mondi wrote: > > On Mon, Dec 11, 2017 at 06:15:23PM +0200, Laurent Pinchart wrote: > > > Hi Jacopo, > > > > > > Thank you for the patch

[resend PATCH 0/2] fix VFS register_shrinker fixup

2017-12-19 Thread Michal Hocko
Hi Andrew, Tetsuo has posted patch 1 already [1]. I had some minor concenrs about the changelog but the approach was already OK. Aliaksei came with an alternative patch [2] which also handles double unregistration. I have updated the changelog and moved the syzbot report to the 2nd patch because it

Re: [PATCH v4.1 2/2] livepatch: force transition to finish

2017-12-19 Thread Petr Mladek
On Mon 2017-12-18 14:23:40, Miroslav Benes wrote: > On Fri, 15 Dec 2017, Jason Baron wrote: > > > On 11/22/2017 05:29 AM, Miroslav Benes wrote: > > > If a task sleeps in a set of patched functions uninterruptedly, it could > > > block the whole transition indefinitely. Thus it may be useful to cl

Re: [PATCH v6 1/3] lib: Add strongly typed 64bit int_sqrt

2017-12-19 Thread Peter Zijlstra
On Tue, Dec 19, 2017 at 10:31:18AM +0100, Crt Mori wrote: > IIO kernel does not have the recent version in, so thanks for heads IIO? > up. It does not change much for my function. The comment says: * Computes: floor(sqrt(x)) floor(sqrt(2^64-1)) == 2^32-1

Re: [PATCH v4 2/2] misc: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver

2017-12-19 Thread Michal Simek
On 18.12.2017 15:05, Arnd Bergmann wrote: > On Mon, Dec 18, 2017 at 2:13 PM, Michal Simek wrote: >> On 15.12.2017 14:26, Arnd Bergmann wrote: >>> In Fri, Dec 15, 2017 at 8:24 AM, Dhaval Shah wrote: Xilinx ZYNQMP logicoreIP Init driver is based on the new LogiCoreIP design created. This

Re: [PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

2017-12-19 Thread Andy Shevchenko
On Tue, 2017-12-19 at 07:17 -0500, Sinan Kaya wrote: > On 12/19/2017 5:45 AM, Andy Shevchenko wrote: > > On Tue, 2017-12-19 at 00:37 -0500, Sinan Kaya wrote: > > > > > pci_get_bus_and_slot() still might be useful for the wired devices > > in > > SoC where we know for sure that domain == 0. > > >

[PATCH] soc: xilinx: Create folder structure for soc specific drivers

2017-12-19 Thread Michal Simek
Create directory structure with Makefile/Kconfig for adding xilinx soc specific drivers. Signed-off-by: Michal Simek --- This patch is done based on discussion ended here https://lkml.org/lkml/2017/12/18/565 --- drivers/soc/Kconfig | 1 + drivers/soc/Makefile| 1 + drivers/soc/

Re: BUG: bad usercopy in memdup_user

2017-12-19 Thread Matthew Wilcox
On Tue, Dec 19, 2017 at 07:37:46PM +1100, Tobin C. Harding wrote: > On Tue, Dec 19, 2017 at 09:12:58AM +0100, Dmitry Vyukov wrote: > > On Tue, Dec 19, 2017 at 1:57 AM, Kees Cook wrote: > > > On Mon, Dec 18, 2017 at 6:22 AM, Tetsuo Handa > > >> This BUG is reporting > > >> > > >> [ 26.089789] use

Re: BUG: unable to handle kernel NULL pointer dereference in __list_del_entry_valid

2017-12-19 Thread Michal Hocko
On Tue 19-12-17 14:12:38, Dmitry Vyukov wrote: > On Tue, Dec 19, 2017 at 2:03 PM, Michal Hocko wrote: > > Can we silence this duplicates [1] please? > > > > [1] http://lkml.kernel.org/r/001a1140f57806ebef05608b2...@google.com > > Hi Michal, > > What exactly do you mean? > > These 2 are the same

Re: [PATCH 17/25] hrtimer: Implementation of softirq hrtimer handling

2017-12-19 Thread Peter Zijlstra
On Tue, Dec 19, 2017 at 09:58:44AM +0100, Sebastian Andrzej Siewior wrote: > this is late I know… > > On 2017-09-27 18:40:26 [+0200], Peter Zijlstra wrote: > > - removed superfluous local_bh_disable(), since local_irq_disable() > >already implies much the same. > > it is not superfluous. >

Re: [PATCH RFC 0/7] KVM: nVMX: enlightened VMCS initial implementation

2017-12-19 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 18/12/2017 18:17, Vitaly Kuznetsov wrote: >> The original author of these patches does no longer work at Red Hat, I >> agreed to take this over and send upstream. Here is his original >> description: >> >> "Makes KVM implement the enlightened VMCS feature per Hyper-V T

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-19 Thread Fabio Estevam
Hi Sakari, On Tue, Dec 19, 2017 at 11:05 AM, Sakari Ailus wrote: > I guess it depends on who do you ask and when. Looking at what has been > recently merged to media tree master, the latter is preferred. Just did 'git grep SPDX drivers/media' and it consistently shows // SPDX style for C files

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread James Ettle
I'm OK with that. Do you need any more info on the specifics of the machine I'm using? (Note: I'm not currently aware of any BIOS updates for it. If this is ultimately a BIOS problem I wouldn't know what sort of report to file, or how to file it anyway...) Thanks, James On 19/12/17 13:00, Jar

Re: [PATCH 3/4] PM / core: Direct DPM_FLAG_SMART_SUSPEND optimization

2017-12-19 Thread Ulf Hansson
On 19 December 2017 at 12:19, Rafael J. Wysocki wrote: > On Tue, Dec 19, 2017 at 12:13 PM, Rafael J. Wysocki wrote: >> On Tue, Dec 19, 2017 at 8:38 AM, Ulf Hansson wrote: >>> On 10 December 2017 at 01:00, Rafael J. Wysocki wrote: From: Rafael J. Wysocki > > [cut] > >> >>> Moreover, w

Re: Regression: unable to boot after commit bd9240a18edf ("x86/apic: Add TSC_DEADLINE quirk due to errata") - Surface Pro 4 SKL

2017-12-19 Thread Peter Zijlstra
On Tue, Dec 19, 2017 at 06:48:24PM +0800, Zhang Rui wrote: > On Mon, 2017-12-18 at 21:28 +0100, Peter Zijlstra wrote: > > Hi, can you see if this makes you Surface boot? > > > No, it does not boot. Bah, staring at the lapic calibrate now, that is a bit of a mess.. > > I tested it on my IVB by ma

Re: BUG: unable to handle kernel NULL pointer dereference in __list_del_entry_valid

2017-12-19 Thread Dmitry Vyukov
On Tue, Dec 19, 2017 at 2:03 PM, Michal Hocko wrote: > Can we silence this duplicates [1] please? > > [1] http://lkml.kernel.org/r/001a1140f57806ebef05608b2...@google.com Hi Michal, What exactly do you mean? These 2 are the same email with the same Message-ID just on different mailing lists. I

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Javier Martinez Canillas
On 12/19/2017 02:10 PM, Jarkko Sakkinen wrote: > On Tue, Dec 19, 2017 at 12:34:46AM +0100, Javier Martinez Canillas wrote: >> Hello Jason, >> >> On 12/18/2017 09:19 PM, Jason Gunthorpe wrote: >>> On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: >>> > IIUC, if CLKRUN_EN is enabled,

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Javier Martinez Canillas
Hello Jarkko, On 12/19/2017 01:59 PM, Jarkko Sakkinen wrote: > James, Javier, thank you for sorting this out. I'll just have couple of > minor comments on the patch. > > On Mon, Dec 18, 2017 at 01:22:28PM +0100, Javier Martinez Canillas wrote: >> +u32 vendor, intfcaps, intmask, clkrun_val; >

Re: [PATCH 3/4] PM / core: Direct DPM_FLAG_SMART_SUSPEND optimization

2017-12-19 Thread Ulf Hansson
On 19 December 2017 at 12:13, Rafael J. Wysocki wrote: > On Tue, Dec 19, 2017 at 8:38 AM, Ulf Hansson wrote: >> On 10 December 2017 at 01:00, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> Make the PM core avoid invoking the "late" and "noirq" system-wide >>> suspend (or analogous

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
On Tue, Dec 19, 2017 at 12:34:46AM +0100, Javier Martinez Canillas wrote: > Hello Jason, > > On 12/18/2017 09:19 PM, Jason Gunthorpe wrote: > > On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: > > > >>> IIUC, if CLKRUN_EN is enabled, then all the devices attached to the > >>> LPC bu

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-19 Thread Mauro Carvalho Chehab
Em Sun, 17 Dec 2017 16:28:44 -0800 Joe Perches escreveu: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work > properly for these

Re: powerpc64 kernel panic if you disable CONFIG_PPC_TRANSACTIONAL_MEM?

2017-12-19 Thread Michael Ellerman
Rob Landley writes: > I just added a ppc64 target to https://github.com/landley/mkroot which > means I built 4.14 with the attached miniconfig and ran it with the > attached qemu command line, and it works fine as is but if you remove > the transactional mem line from the config the kernel panics

Re: [PATCH v2] writeback: synchronize sync(2) against cgroup writeback membership switches

2017-12-19 Thread Jan Kara
On Wed 13-12-17 07:39:30, Tejun Heo wrote: > Hello, > > On Wed, Dec 13, 2017 at 12:00:04PM +0100, Jan Kara wrote: > > OK, but this effectively prevents writeback from sync_inodes_sb() to ever > > make inode switch wbs. Cannot that be abused in some way like making sure > > writeback of our memcg i

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-12-19 Thread Laurent Pinchart
Hi Jacopo, (CC'ing Sakari) On Tuesday, 19 December 2017 13:57:42 EET jacopo mondi wrote: > On Mon, Dec 11, 2017 at 06:15:23PM +0200, Laurent Pinchart wrote: > > Hi Jacopo, > > > > Thank you for the patch. > > > > [snip] > > > >> +static int ceu_sensor_bound(struct v4l2_async_notifier *notifier

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-19 Thread Sakari Ailus
On Tue, Dec 19, 2017 at 10:50:44AM -0200, Fabio Estevam wrote: > Hi Sakari, > > On Tue, Dec 19, 2017 at 7:22 AM, Sakari Ailus wrote: > > On Mon, Dec 11, 2017 at 09:31:46AM +0800, Wenyou Yang wrote: > >> The ov7740 (color) image sensor is a high performance VGA CMOS > >> image snesor, which suppor

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
On Mon, Dec 18, 2017 at 01:19:02PM -0700, Jason Gunthorpe wrote: > On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: > > > >IIUC, if CLKRUN_EN is enabled, then all the devices attached to the > > >LPC bus have to support the CLKRUN protocol. My guess is that on > > >some Braswell syst

Re: BUG: unable to handle kernel NULL pointer dereference in __list_del_entry_valid

2017-12-19 Thread Michal Hocko
Can we silence this duplicates [1] please? [1] http://lkml.kernel.org/r/001a1140f57806ebef05608b2...@google.com On Tue 19-12-17 04:47:01, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/nex

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
On Mon, Dec 18, 2017 at 10:55:02AM -0700, Jason Gunthorpe wrote: > On Mon, Dec 18, 2017 at 01:29:01PM +0100, Javier Martinez Canillas wrote: > > On 12/18/2017 01:22 PM, Javier Martinez Canillas wrote: > > > > [snip] > > > > > > > > James, > > > > > > Can you please test the following (untested)

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
On Mon, Dec 18, 2017 at 06:26:35PM +, James Ettle wrote: > The keyboard and touchpad work OK with the patch quoted below and the earlier > two applied, i.e. the three patches with signatures: > > 667dcc75be864ff4c17cf58891853b7393bba3e2 > db3248e8a036c39141c8f7e9f1cf5c5ae6815f76 > 370d45a34dc

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
James, Javier, thank you for sorting this out. I'll just have couple of minor comments on the patch. On Mon, Dec 18, 2017 at 01:22:28PM +0100, Javier Martinez Canillas wrote: > + u32 vendor, intfcaps, intmask, clkrun_val; Could these split into four lines (one declaration per line)? >

Re: [PATCH v4 6/6] [media] cxusb: add analog mode support for Medion MD95700

2017-12-19 Thread Mauro Carvalho Chehab
Em Sun, 17 Dec 2017 19:47:25 +0100 "Maciej S. Szmigiero" escreveu: > This patch adds support for analog part of Medion 95700 in the cxusb > driver. > > What works: > * Video capture at various sizes with sequential fields, > * Input switching (TV Tuner, Composite, S-Video), > * TV and radio tuni

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-19 Thread Fabio Estevam
Hi Sakari, On Tue, Dec 19, 2017 at 7:22 AM, Sakari Ailus wrote: > On Mon, Dec 11, 2017 at 09:31:46AM +0800, Wenyou Yang wrote: >> The ov7740 (color) image sensor is a high performance VGA CMOS >> image snesor, which supports for output formats: RAW RGB and YUV >> and image sizes: VGA, and QVGA, C

Re: [RFC PATCH] mm: memcontrol: memory+swap accounting for cgroup-v2

2017-12-19 Thread Michal Hocko
On Mon 18-12-17 16:01:31, Shakeel Butt wrote: > The memory controller in cgroup v1 provides the memory+swap (memsw) > interface to account to the combined usage of memory and swap of the > jobs. The memsw interface allows the users to limit or view the > consistent memory usage of their jobs irresp

Re: INFO: task hung in bpf_exit_net

2017-12-19 Thread Dmitry Vyukov
On Tue, Dec 19, 2017 at 1:36 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 7ceb97a071e80f1b5e4cd5a36de135612a836388 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is

Re: INFO: task hung in cleanup_net

2017-12-19 Thread Dmitry Vyukov
On Tue, Dec 19, 2017 at 1:33 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > e40fd8d6b4d9f59b160faa1736f78fc07533ff37 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is

Re: [PATCH v2 0/2] mm: introduce MAP_FIXED_SAFE

2017-12-19 Thread Michal Hocko
On Tue 19-12-17 12:40:16, David Laight wrote: > From: Edward Napierala > > Sent: 14 December 2017 14:55 > > > > On 1214T1415, Michal Hocko wrote: > > > On Thu 14-12-17 12:44:17, Edward Napierala wrote: > > > > Regarding the name - how about adopting MAP_EXCL? It was introduced in > > > > FreeBSD,

Re: [PATCH v2 5/5] mm: Rename zone_statistics() to numa_statistics()

2017-12-19 Thread Michal Hocko
On Tue 19-12-17 14:39:26, Kemi Wang wrote: > Since the functionality of zone_statistics() updates numa counters, but > numa statistics has been separated from zone statistics framework. Thus, > the function name makes people confused. So, change the name to > numa_statistics() as well as its call s

Re: [PATCH 2/9] ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies

2017-12-19 Thread Pierre-Louis Bossart
- depends on SND_DMA_SGBUF + depends on SND_DMA_SGBUF && ACPI depends on DMADEVICES Perhaps depends on DMADEVICES && ACPI to be in align with below? config SND_SOC_INTEL_BAYTRAIL tristate "Intel ASoC SST driver for Baytrail (legacy)" - depends on DMADEV

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-19 Thread Michal Hocko
On Tue 19-12-17 14:39:25, Kemi Wang wrote: > To avoid deviation, this patch uses node_page_state_snapshot instead of > node_page_state for node page stats query. > e.g. cat /proc/zoneinfo > cat /sys/devices/system/node/node*/vmstat > cat /sys/devices/system/node/node*/numastat > > As it

Re: [PATCH] NFS: allow name_to_handle_at() to work for Amazon EFS.

2017-12-19 Thread Jan Kara
On Fri 08-12-17 13:17:31, NeilBrown wrote: > On Thu, Dec 07 2017, Amir Goldstein wrote: > > > On Thu, Dec 7, 2017 at 5:20 AM, NeilBrown wrote: > >> On Wed, Dec 06 2017, Linus Torvalds wrote: > >> > >>> On Thu, Nov 30, 2017 at 12:56 PM, NeilBrown wrote: > > -/* limit the handle size to

Re: [PATCH RFC 0/7] KVM: nVMX: enlightened VMCS initial implementation

2017-12-19 Thread Paolo Bonzini
On 18/12/2017 18:17, Vitaly Kuznetsov wrote: > The original author of these patches does no longer work at Red Hat, I > agreed to take this over and send upstream. Here is his original > description: > > "Makes KVM implement the enlightened VMCS feature per Hyper-V TLFS 5.0b. > I've measured about

Re: [PATCH v2 3/5] mm: enlarge NUMA counters threshold size

2017-12-19 Thread Michal Hocko
On Tue 19-12-17 14:39:24, Kemi Wang wrote: > We have seen significant overhead in cache bouncing caused by NUMA counters > update in multi-threaded page allocation. See 'commit 1d90ca897cb0 ("mm: > update NUMA counter threshold size")' for more details. > > This patch updates NUMA counters to a fi

RE: [PATCH v2 0/2] mm: introduce MAP_FIXED_SAFE

2017-12-19 Thread David Laight
From: Edward Napierala > Sent: 14 December 2017 14:55 > > On 1214T1415, Michal Hocko wrote: > > On Thu 14-12-17 12:44:17, Edward Napierala wrote: > > > Regarding the name - how about adopting MAP_EXCL? It was introduced in > > > FreeBSD, > > > and seems to do exactly this; quoting mmap(2): > > > >

Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Jean Delvare
On Tue, 19 Dec 2017 11:12:57 +0100, Arnd Bergmann wrote: > A built-in SMB file system cannot link against a modular > infiniband core module: > > fs/cifs/smbdirect.o: In function `smbd_destroy_rdma_work': > smbdirect.c:(.text+0x28e3): undefined reference to `ib_drain_qp' > smbdirect.c:(.text+0x291

<    4   5   6   7   8   9   10   11   12   >