Re: [RFC PATCH v2 6/6] x86/entry/pti: don't switch PGD on when pti_disable is set

2018-01-11 Thread Dave Hansen
On 01/11/2018 09:02 AM, Andy Lutomirski wrote: >> But, the stack gets really fun because of NMIs. >> >> I'm sure Andy Lutomirski has some ideas too. > I was thinking that maybe we should add a new field or two to pt_regs. > They could store CR2 and maybe CR3 as well. I'd also like to expose > the

[PATCH 0/2] crypto: Implement generic crypto statistics

2018-01-11 Thread Corentin Labbe
Hello This patch is a try to implement a generic crypto driver statistics. The goal is to have an "ifconfig" for crypto device. Some driver tried to implement this via a debugfs interface. This serie do it directly in the crypto API and give access to stats via the crypto_user(netlink) API. Then

Re: objtool segfault with ORC unwinder enabled

2018-01-11 Thread Markus
On Thursday, 11 January 2018 20:38:10 CET Josh Poimboeuf wrote: > On Thu, Jan 11, 2018 at 07:52:00PM +0100, Markus wrote: > > On Thursday, 11 January 2018 19:20:57 CET Josh Poimboeuf wrote: > > > On Thu, Jan 11, 2018 at 07:11:03PM +0100, Markus wrote: > > > > On Thursday, 11 January 2018 05:25:51 C

Re: [PATCH v1 2/8] x86/entry/clearregs: Add infrastructure to clear registers

2018-01-11 Thread Konrad Rzeszutek Wilk
On Tue, Jan 09, 2018 at 05:03:22PM -0800, Andi Kleen wrote: > From: Andi Kleen > > Add 64bit assembler macros to clear registers on kernel entry. > Used in followon patches. > > Signed-off-by: Andi Kleen > --- > arch/x86/entry/calling.h | 28 > 1 file changed, 28 i

[PATCH 2/2] crypto: tools: Add cryptostat userspace

2018-01-11 Thread Corentin Labbe
Signed-off-by: Corentin Labbe --- tools/crypto/getstat.c | 283 + 1 file changed, 283 insertions(+) create mode 100644 tools/crypto/getstat.c diff --git a/tools/crypto/getstat.c b/tools/crypto/getstat.c new file mode 100644 index ..e73

[PATCH 1/2] crypto: Implement a generic crypto statistics

2018-01-11 Thread Corentin Labbe
This patch implement a generic way to get statistics about all crypto usages. Signed-off-by: Corentin Labbe --- crypto/Kconfig | 11 crypto/ablkcipher.c | 9 +++ crypto/acompress.c | 9 +++ crypto/aead.c | 10

Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context

2018-01-11 Thread Linus Torvalds
On Thu, Jan 11, 2018 at 11:48 AM, Eric Dumazet wrote: > That was the purpose on the last patch : As soon as ksoftirqd is scheduled > (by some kind of jitter in the 99,000 pps workload, or antagonist wakeup), > we then switch to a mode where process scheduler can make decisions > based on threads p

Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks

2018-01-11 Thread David Lechner
On 01/11/2018 12:50 PM, Adam Ford wrote: On Thu, Jan 11, 2018 at 12:29 PM, David Lechner wrote: If removing the "clk_ignore_unused" option causes the board to not boot, then we still have problems that need to be fixed, so please also test without this option. Without this option, it still do

Re: [PATCH v2 0/3] ARM: mvebu: dts: updates to enable EDAC

2018-01-11 Thread Chris Packham
On 11/01/18 22:14, Gregory CLEMENT wrote: > Hi Chris, > > On jeu., janv. 11 2018, Chris Packham > wrote: > >> I've split this off from my earlier series[1] this is just the dts changes >> that >> will enable support for the EDAC series when it lands. >> >> The Armada 38x as well as the 98d

Re: [PATCH v1 2/8] x86/entry/clearregs: Add infrastructure to clear registers

2018-01-11 Thread Andi Kleen
> > + .macro CLEAR_ALL_REGS > > + CLEAR_R8_TO_R15 > > + xorl %eax, %eax > > + xorl %ebx, %ebx > > How come you use xorl vs xorq? 64bit always zero extends 32->64, and xorl is one byte shorter because it doesn't need a REX prefix. -Andi

Re: [PATCH 4.4 00/37] 4.4.110-stable review

2018-01-11 Thread Greg Kroah-Hartman
On Thu, Jan 11, 2018 at 01:36:50PM -0500, Pavel Tatashin wrote: > I have root caused the memory corruption panics/hangs that I've been > experiencing during boot with the latest 4.4.110 kernel. The problem > as was suspected by Andy Lutomirski is with interaction between PTI > and EFI. It may affec

Re: perf: perf_fuzzer quickly locks up on 4.15-rc7

2018-01-11 Thread Vince Weaver
Not sure if this info helps, but if I make perf_fuzzer *not* create AUX mmap() buffers, I'm unable to reproduce the hangs both on core2 and haswell. Vince

Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context

2018-01-11 Thread Eric Dumazet
On Thu, Jan 11, 2018 at 12:03 PM, Linus Torvalds wrote: > On Thu, Jan 11, 2018 at 11:48 AM, Eric Dumazet wrote: >> That was the purpose on the last patch : As soon as ksoftirqd is scheduled >> (by some kind of jitter in the 99,000 pps workload, or antagonist wakeup), >> we then switch to a mode w

Re: [PATCH 4.4 00/37] 4.4.110-stable review

2018-01-11 Thread Linus Torvalds
On Thu, Jan 11, 2018 at 12:10 PM, Greg Kroah-Hartman wrote: > > Nice, but why does this not show up in 4.9 and 4.14 and Linus's tree as > well on this hardware? Nor on the SLES12 SP3 kernel? > > What is different there that 4.4 requires? That worries me more than > your fix (which looks good to

Re: objtool segfault with ORC unwinder enabled

2018-01-11 Thread Josh Poimboeuf
On Thu, Jan 11, 2018 at 09:00:33PM +0100, Markus wrote: > On Thursday, 11 January 2018 20:38:10 CET Josh Poimboeuf wrote: > > On Thu, Jan 11, 2018 at 07:52:00PM +0100, Markus wrote: > > > On Thursday, 11 January 2018 19:20:57 CET Josh Poimboeuf wrote: > > > > On Thu, Jan 11, 2018 at 07:11:03PM +010

Re: [PATCH 4.4 00/37] 4.4.110-stable review

2018-01-11 Thread Pavel Tatashin
On 01/11/2018 03:10 PM, Greg Kroah-Hartman wrote: On Thu, Jan 11, 2018 at 01:36:50PM -0500, Pavel Tatashin wrote: I have root caused the memory corruption panics/hangs that I've been experiencing during boot with the latest 4.4.110 kernel. The problem as was suspected by Andy Lutomirski is wit

Re: [PATCH v7 7/8] dt-bindings: can: m_can: Document new can transceiver binding

2018-01-11 Thread Rob Herring
On Wed, Jan 10, 2018 at 4:55 AM, Faiz Abbas wrote: > From: Franklin S Cooper Jr > > Add information regarding can-transceiver binding. This is especially > important for MCAN since the IP allows CAN FD mode to run significantly > faster than what most transceivers are capable of. > > Signed-off-b

Re: [PATCH 0/3] SGI-XPC: Adjustments for some function implementations

2018-01-11 Thread Greg Kroah-Hartman
On Thu, Jan 11, 2018 at 12:19:37PM -0600, Robin Holt wrote: > If you need to resubmit, please consider re-ordering the changes to > due the comparison to NULL changes in your first patch, followed by the > other two in either order. I think it will clear up some of the inconsistency > in your firs

Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context

2018-01-11 Thread Linus Torvalds
On Thu, Jan 11, 2018 at 12:16 PM, Eric Dumazet wrote: > > Note that when I implemented TCP Small queues, I did experiments between > using a work queue or a tasklet, and workqueues added unacceptable P99 > latencies, when many user threads are competing with kernel threads. Yes. So I think one s

Re: [PATCH] scsi: sd: Use warn for logs about no caching info

2018-01-11 Thread Jeremy Cline
On Wed, Jan 03, 2018 at 10:50:29PM -0500, Martin K. Petersen wrote: > > Hi Jeremy, > > > When no caching mode information can be found for a disk, use the > > warning log level rather than error. It is common for this to occur > > with cheap USB sticks. > > Just because something is common occur

Re: ASPM powersupersave change NVMe SSD Samsung 960 PRO capacity to 0 and read-only

2018-01-11 Thread Rajat Jain
On Thu, Jan 11, 2018 at 9:59 AM, Keith Busch wrote: > On Thu, Jan 11, 2018 at 06:50:40PM +0100, Maik Broemme wrote: >> I've re-run the test with 4.15rc7.r111.g5f615b97cdea and the following >> patches from Keith: >> >> [PATCH 1/4] PCI/AER: Return approrpiate value when AER is not supported >> [PAT

Re: [PATCH 3/7] pinctrl: sunxi: add support for the Allwinner H6 main pin controller

2018-01-11 Thread Rob Herring
On Sat, Jan 06, 2018 at 12:23:22PM +0800, Icenowy Zheng wrote: > The Allwinner H6 SoC has two pin controllers, one main controller > (called CPUX-PORT in user manual) and one controller in CPUs power > domain (called CPUS-PORT in user manual). > > This commit introduces support for the main pin co

Re: [PATCH v5 00/19] fs: rework and optimize i_version handling in filesystems

2018-01-11 Thread Liu Bo
On Tue, Jan 09, 2018 at 09:10:40AM -0500, Jeff Layton wrote: > From: Jeff Layton > > v5: > - don't corrupt refcounts stashed in i_version of ext4 xattr inodes > - add raw variants of inc and cmp functions, and have nfs use them > > v4: > - fix SB_LAZYTIME handling in generic_update_time > - add

Re: [PATCH 5/7] clk: sunxi-ng: add support for the Allwinner H6 CCU

2018-01-11 Thread Rob Herring
On Sat, Jan 06, 2018 at 12:49:16PM +0800, Icenowy Zheng wrote: > The Allwinner H6 SoC has a CCU which has been largely rearranged. > > Add support for it in the sunxi-ng CCU framework. > > Signed-off-by: Icenowy Zheng > --- > .../devicetree/bindings/clock/sunxi-ccu.txt|1 + > driver

Re: [PATCH] net: phy: Fix phy_modify() semantic difference fallout

2018-01-11 Thread Florian Fainelli
On 01/11/2018 07:48 AM, David Miller wrote: > From: Geert Uytterhoeven > Date: Tue, 9 Jan 2018 12:11:21 +0100 > >> In case of success, the return values of (__)phy_write() and >> (__)phy_modify() are not compatible: (__)phy_write() returns 0, while >> (__)phy_modify() returns the old PHY registe

RE: [RFC PATCH 0/2] drivers: clk: Add ZynqMP clock driver support

2018-01-11 Thread Jolly Shah
Hi Sudeep, There are 3 things: 1> IPI mailbox transport - series is already posted https://patchwork.kernel.org/patch/10145795/ 2> EEMI - Posted by me below https://patchwork.kernel.org/patch/10150665/ 3> EEMI Users Currently posted as RFC as they are dependent on #2. #2 doesn’t use mailbox so i

Re: Backport of KPTI to 2.6.32 available

2018-01-11 Thread Greg KH
On Thu, Jan 11, 2018 at 11:42:38AM -0600, Corey Minyard wrote: > I've completed a backport of KPTI from linux-stable-3.2.y to 2.6.32.71, in > case anyone is interested and wants to avoid all the work I went through. > It's available at: > > https://github.com/MontaVista-OpenSourceTechnology/linux-

Re: [PATCH v2] leds: ledtrig-transient: Add SPDX license identifiers

2018-01-11 Thread Jacek Anaszewski
Hi Shuah, Thanks for the update. On 01/10/2018 11:42 PM, Shuah Khan wrote: > Replace GPL license statements with SPDX GPL-2.0 license identifiers > and and correct the module license to GPLv2. > > Signed-off-by: Shuah Khan > --- > Changes since v1: > - Changed comment format and updated the ent

[PATCH] cris: Mark end of BUG() implementation as unreachable

2018-01-11 Thread Kees Cook
When building the cris v10 architecture, the compiler doesn't realize that BUG() doesn't return, so it will complain about functions using BUG() that are marked with the noreturn attribute: mm/usercopy.c: In function 'usercopy_abort': >> mm/usercopy.c:86:1: warning: 'noreturn' function does ret

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

2018-01-11 Thread Jae Hyun Yoo
On 1/11/2018 1:02 AM, Benjamin Herrenschmidt wrote: On Wed, 2018-01-10 at 11:18 +0100, Greg KH wrote: On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for Aspeed PECI. Also adds generic peci.h and peci_ioctl.h files to provide compatibility to

Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context

2018-01-11 Thread Dmitry Safonov
On Thu, 2018-01-11 at 12:22 -0800, Linus Torvalds wrote: > On Thu, Jan 11, 2018 at 12:16 PM, Eric Dumazet > wrote: > > > > Note that when I implemented TCP Small queues, I did experiments > > between > > using a work queue or a tasklet, and workqueues added unacceptable > > P99 > > latencies, whe

Re: [PATCH v7 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

2018-01-11 Thread Rob Herring
On Sat, Jan 06, 2018 at 05:51:14PM +0800, Li Wei wrote: > add ufs node document for Hisilicon. > > Signed-off-by: Li Wei > --- > Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 43 > ++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bi

Re: [PATCH v2 0/7] pipe: buffer limits fixes and cleanups

2018-01-11 Thread Kees Cook
On Wed, Jan 10, 2018 at 9:28 PM, Eric Biggers wrote: > This series simplifies the sysctl handler for pipe-max-size and fixes > another set of bugs related to the pipe buffer limits: > > - The root user wasn't allowed to exceed the limits when creating new > pipes. > > - There was an off-by-one e

Re: [PATCH] PCI: iproc: Fix NULL pointer dereference for BCMA

2018-01-11 Thread Ray Jui
Hi Lorenzo, On 1/11/2018 9:15 AM, Lorenzo Pieralisi wrote: On Tue, Jan 09, 2018 at 11:45:40AM -0800, Ray Jui wrote: With the inbound DMA mapping supported added, the iProc PCIe driver parses DT property "dma-ranges" through call to "of_pci_dma_range_parser_init". In the case of BCMA, this resul

[PATCH v2] PCI: iproc: Fix NULL pointer dereference for BCMA

2018-01-11 Thread Ray Jui
With the inbound DMA mapping supported added, the iProc PCIe driver parses DT property "dma-ranges" through call to "of_pci_dma_range_parser_init". In the case of BCMA, this results in a NULL pointer deference due to a missing of_node. Fix this by adding a guard in pcie-iproc-platform.c to only en

Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context

2018-01-11 Thread Eric Dumazet
On Thu, Jan 11, 2018 at 12:34 PM, Dmitry Safonov wrote: > On Thu, 2018-01-11 at 12:22 -0800, Linus Torvalds wrote: >> On Thu, Jan 11, 2018 at 12:16 PM, Eric Dumazet >> wrote: >> > >> > Note that when I implemented TCP Small queues, I did experiments >> > between >> > using a work queue or a taskl

Re: [PATCH 4.4 00/37] 4.4.110-stable review

2018-01-11 Thread Thomas Gleixner
On Thu, 11 Jan 2018, Linus Torvalds wrote: > [ Patch to make sure the EFI trampoline_pgd is properly aligned and > has the double pgd that KPTI requires ] > > On Thu, Jan 11, 2018 at 10:40 AM, Pavel Tatashin > wrote: > > If it is better to resubmit this patch via git send-email, please let me >

Re: [PATCH v2] libfdt: remove unnecessary include directive from

2018-01-11 Thread Rob Herring
On Sun, Jan 07, 2018 at 12:02:16PM +0900, Masahiro Yamada wrote: > is a wrapper of scripts/dtc/libfdt/libfdt.h > It should not do more than its job. In fact, libfdt.h depends > on fdt.h, and scripts/dtc/libfdt/libfdt.h includes fdt.h already. > Trust the work in the upstream DTC project. > > Sig

Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context

2018-01-11 Thread Linus Torvalds
On Thu, Jan 11, 2018 at 12:34 PM, Dmitry Safonov wrote: > > I could try to write a PoC for that.. > What should be the trigger to fall into workqueue? > How to tell if there're too many softirqs of the kind? I suspect it would have to be time-based, probably using the scheduler clock. Most softi

Re: perf: perf_fuzzer quickly locks up on 4.15-rc7

2018-01-11 Thread Vince Weaver
On Thu, 11 Jan 2018, Vince Weaver wrote: > Not sure if this info helps, but if I make perf_fuzzer *not* create AUX > mmap() buffers, I'm unable to reproduce the hangs both on core2 and > haswell. Confirmed, I can crash the system without the fuzzer, just by doing perf record --per-thre

Re: perf: perf_fuzzer quickly locks up on 4.15-rc7

2018-01-11 Thread Peter Zijlstra
On Thu, Jan 11, 2018 at 03:15:16PM -0500, Vince Weaver wrote: > > Not sure if this info helps, but if I make perf_fuzzer *not* create AUX > mmap() buffers, I'm unable to reproduce the hangs both on core2 and > haswell. That certainly reduces the amount of code to stare at. Will do so tomorrow.

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

2018-01-11 Thread Jae Hyun Yoo
On 1/11/2018 1:06 AM, Benjamin Herrenschmidt wrote: On Tue, 2018-01-09 at 14:31 -0800, Jae Hyun Yoo wrote: +struct peci_rd_ia_msr_msg { + unsigned char target; + unsigned char thread_id; + unsigned short address; + unsigned long value; +}; Those types are representing m

Re: perf: perf_fuzzer quickly locks up on 4.15-rc7

2018-01-11 Thread Vince Weaver
On Thu, 11 Jan 2018, Vince Weaver wrote: > On Thu, 11 Jan 2018, Peter Zijlstra wrote: > > > On Thu, Jan 11, 2018 at 01:21:12PM -0600, Josh Poimboeuf wrote: > > > Yuck. This time it was stack recursion on the entry stack. In the > > > previous error, recursion was detected on the IRQ stack. Oth

Re: [PATCH] media: v4l2-core: v4l2-mc: Add SPDX license identifier

2018-01-11 Thread Shuah Khan
On 01/11/2018 11:42 AM, Laurent Pinchart wrote: > Hi Shuah, > > On Thursday, 11 January 2018 17:45:15 EET Shuah Khan wrote: >> On 01/11/2018 05:55 AM, Laurent Pinchart wrote: >>> On Wednesday, 10 January 2018 18:35:36 EET Shuah Khan wrote: Replace GPL license statement with SPDX GPL-2.0 licen

Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context

2018-01-11 Thread Dmitry Safonov
On Thu, 2018-01-11 at 12:40 -0800, Linus Torvalds wrote: > On Thu, Jan 11, 2018 at 12:34 PM, Dmitry Safonov > wrote: > > > > I could try to write a PoC for that.. > > What should be the trigger to fall into workqueue? > > How to tell if there're too many softirqs of the kind? > > I suspect it wo

Re: [PATCH 4.4 00/37] 4.4.110-stable review

2018-01-11 Thread Linus Torvalds
On Thu, Jan 11, 2018 at 12:37 PM, Thomas Gleixner wrote: > > 67a9108ed431 ("x86/efi: Build our own page table structures") > > got rid of EFI depending on real_mode_header->trampoline_pgd So I think it only got rid of by default - the codepath is still there, the allocation is still there, it's j

Re: [PATCH linux dev-4.10 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

2018-01-11 Thread Jae Hyun Yoo
On 1/11/2018 5:22 AM, Arnd Bergmann wrote: On Thu, Jan 11, 2018 at 12:45 AM, Jae Hyun Yoo wrote: On 1/10/2018 4:29 AM, Arnd Bergmann wrote: On Tue, Jan 9, 2018 at 11:31 PM, Jae Hyun Yoo wrote: This commit adds driver implementation for a generic PECI hwmon. Signed-off-by: Jae Hyun Yoo

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-11 Thread Benjamin Herrenschmidt
On Thu, 2018-01-11 at 10:59 +0100, Greg KH wrote: > And, if you use it in a device, it's still totally unsupported and > insecure. Seriously, does no one actually pay attention to the patches > I merge in the stable trees anymore? Yeah not sure why we aren't picking an LTC here, it could be that

Re: linux-next: manual merge of the kspp tree with the net tree

2018-01-11 Thread Kees Cook
On Wed, Jan 10, 2018 at 8:40 PM, Stephen Rothwell wrote: > Hi Kees, > > Today's linux-next merge of the kspp tree got a conflict in: > > net/sctp/socket.c > > between commit: > > c76f97c99ae6 ("sctp: make use of pre-calculated len") > > from the net tree and commit: > > 3511d716f5a8 ("sctp:

Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context

2018-01-11 Thread Eric Dumazet
On Thu, Jan 11, 2018 at 12:46 PM, Dmitry Safonov wrote: > On Thu, 2018-01-11 at 12:40 -0800, Linus Torvalds wrote: >> On Thu, Jan 11, 2018 at 12:34 PM, Dmitry Safonov >> wrote: >> > >> > I could try to write a PoC for that.. >> > What should be the trigger to fall into workqueue? >> > How to tell

checkpatch: exclude drivers/staging from if with unnecessary parentheses test

2018-01-11 Thread Joe Perches
Greg KH doesn't like this test so exclude the staging directory from the implied --strict only test unless --strict is actually used on the command-line. Signed-off-by: Joe Perches --- scripts/checkpatch.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch

Re: perf: perf_fuzzer quickly locks up on 4.15-rc7

2018-01-11 Thread Peter Zijlstra
On Thu, Jan 11, 2018 at 03:40:44PM -0500, Vince Weaver wrote: > On Thu, 11 Jan 2018, Vince Weaver wrote: > > > Not sure if this info helps, but if I make perf_fuzzer *not* create AUX > > mmap() buffers, I'm unable to reproduce the hangs both on core2 and > > haswell. > > Confirmed, I can crash

Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks

2018-01-11 Thread Adam Ford
On Thu, Jan 11, 2018 at 2:04 PM, David Lechner wrote: > On 01/11/2018 12:50 PM, Adam Ford wrote: >> >> On Thu, Jan 11, 2018 at 12:29 PM, David Lechner >> wrote: >>> >>> If removing the "clk_ignore_unused" option causes the board to not boot, >>> then we still have problems that need to be fixed,

checkpatch: Avoid some false positives for TABSTOP declaration test

2018-01-11 Thread Joe Perches
Using an open bracket after what seems to be a declaration can also be a function definition and declaration argument line continuation so remove the open bracket from the possible declaration/definition matching. e.g.: int foobar(int a; int *b[]); Signed-off-by: Joe Pe

Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks

2018-01-11 Thread David Lechner
On 01/11/2018 02:58 PM, Adam Ford wrote: On Thu, Jan 11, 2018 at 2:04 PM, David Lechner wrote: On 01/11/2018 12:50 PM, Adam Ford wrote: On Thu, Jan 11, 2018 at 12:29 PM, David Lechner wrote: If removing the "clk_ignore_unused" option causes the board to not boot, then we still have problem

Re: [PATCH v3 2/5] x86/enter: Create macros to set/clear IBRS

2018-01-11 Thread Tim Chen
On 01/11/2018 08:04 AM, Thomas Gleixner wrote: > On Tue, 9 Jan 2018, Tim Chen wrote: >> + >> +.macro WRMSR_ASM msr_nr:req edx_val:req eax_val:req >> +movl\msr_nr, %ecx >> +movl\edx_val, %edx >> +movl\eax_val, %eax >> +.endm > > This is the most brilliant piece of useless co

Re: [PATCH v3 08/16] iommu: introduce device fault data

2018-01-11 Thread Jacob Pan
On Wed, 10 Jan 2018 11:41:58 + Jean-Philippe Brucker wrote: > Hi Jacob, > > On 17/11/17 18:55, Jacob Pan wrote: > [...] > > +/** > > + * struct iommu_fault_event - Generic per device fault data > > + * > > + * - PCI and non-PCI devices > > + * - Recoverable faults (e.g. page request), inform

[PATCH] hwrng: imx-rngc: simplify the power management definitions

2018-01-11 Thread Martin Kaiser
Use the SIMPLE_DEV_PM_OPS() macro instead of populating a struct dev_pm_ops directly. The suspend and resume functions will now be used for both hibernation and suspend to ram. If power management is disabled, SIMPLE_DEV_PM_OPS() evaluates to nothing, The two functions won't be used and won't be i

Re: Backport of KPTI to 2.6.32 available

2018-01-11 Thread Corey Minyard
On 01/11/2018 02:32 PM, Greg KH wrote: On Thu, Jan 11, 2018 at 11:42:38AM -0600, Corey Minyard wrote: I've completed a backport of KPTI from linux-stable-3.2.y to 2.6.32.71, in case anyone is interested and wants to avoid all the work I went through. It's available at: https://github.com/MontaV

Re: [PATCH 00/10] perf tools: Add support for CoreSight trace decoding

2018-01-11 Thread Mathieu Poirier
On 11 January 2018 at 10:28, Kim Phillips wrote: > On Thu, 11 Jan 2018 08:45:21 -0700 > Mathieu Poirier wrote: > >> On 11 January 2018 at 05:23, Mark Brown wrote: >> > On Wed, Jan 10, 2018 at 06:08:21PM -0600, Kim Phillips wrote: >> >> Mathieu Poirier wrote: >> > >> >> > Instructions on how to

Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context

2018-01-11 Thread Dmitry Safonov
On Thu, 2018-01-11 at 12:53 -0800, Eric Dumazet wrote: > On Thu, Jan 11, 2018 at 12:46 PM, Dmitry Safonov > wrote: > > On Thu, 2018-01-11 at 12:40 -0800, Linus Torvalds wrote: > > > On Thu, Jan 11, 2018 at 12:34 PM, Dmitry Safonov > > > > > > wrote: > > > > > > > > I could try to write a PoC for

Re: [PATCH v5 09/44] dt-bindings: clock: New bindings for TI Davinci PSC

2018-01-11 Thread Rob Herring
On Sun, Jan 07, 2018 at 08:17:08PM -0600, David Lechner wrote: > This adds a new binding for the Power Sleep Controller (PSC) for the > mach-davinci family of processors. > > Note: Although TI Keystone has a very similar PSC, we are not using the > existing bindings. Keystone is using a legacy one

linux-next: manual merge of the arm64 tree with Linus' tree

2018-01-11 Thread Stephen Rothwell
Hi Catalin, Today's linux-next merge of the arm64 tree got a conflict in: arch/arm64/kernel/cpufeature.c between commit: 3fab39997a98 ("arm64/sve: Report SVE to userspace via CPUID only if supported") from Linus' tree and commits: 179a56f6f9fb ("arm64: Take into account ID_AA64PFR0_EL1

Re: [RFC PATCH v2 6/6] x86/entry/pti: don't switch PGD on when pti_disable is set

2018-01-11 Thread Willy Tarreau
On Thu, Jan 11, 2018 at 07:34:31PM +, Alan Cox wrote: > On Thu, 11 Jan 2018 13:26:01 -0600 > Josh Poimboeuf wrote: > > > On Thu, Jan 11, 2018 at 08:19:35PM +0100, Olivier Galibert wrote: > > > Wouldn't the time taken by an easy syscall like getuid be a clear > > > indicator? > > > > I thi

Re: [PATCH v3 2/5] x86/enter: Create macros to set/clear IBRS

2018-01-11 Thread Tim Chen
On 01/11/2018 01:05 PM, Tim Chen wrote: > On 01/11/2018 08:04 AM, Thomas Gleixner wrote: >> On Tue, 9 Jan 2018, Tim Chen wrote: >>> + >>> +.macro WRMSR_ASM msr_nr:req edx_val:req eax_val:req >>> + movl\msr_nr, %ecx >>> + movl\edx_val, %edx >>> + movl\eax_val, %eax >>> +.endm >> >>

RE: [PATCH V3 02/12] perf mmap: factor out function to find ringbuffer position

2018-01-11 Thread Liang, Kan
> On Thu, Dec 21, 2017 at 10:08:44AM -0800, kan.li...@intel.com wrote: > > SNIP > > > +/* > > + * Report the start and end of the available data in ringbuffer > > + */ > > +int perf_mmap__read_init(struct perf_mmap *map, bool overwrite, > > +u64 *start, u64 *end) > > { > >

RE: [PATCH V3 03/12] perf mmap: discard 'prev' in perf_mmap__read

2018-01-11 Thread Liang, Kan
> On Thu, Dec 21, 2017 at 10:08:45AM -0800, kan.li...@intel.com wrote: > > From: Kan Liang > > > > 'start' and 'prev' are duplicate in perf_mmap__read() > > > > Use 'map->prev' to replace 'start' in perf_mmap__read_*(). > > > > Suggested-by: Wang Nan > > Signed-off-by: Kan Liang > > --- > > too

RE: [PATCH V3 04/12] perf mmap: introduce perf_mmap__read_done

2018-01-11 Thread Liang, Kan
> On Thu, Dec 21, 2017 at 10:08:46AM -0800, kan.li...@intel.com wrote: > > From: Kan Liang > > > > The direction of overwrite mode is backward. The last mmap__read_event > > will set tail to map->prev. Need to correct the map->prev to head which > > is the end of next read. > > > > It will be used

RE: [PATCH V3 07/12] perf mmap: discard legacy interface for mmap read

2018-01-11 Thread Liang, Kan
> On Thu, Dec 21, 2017 at 10:08:49AM -0800, kan.li...@intel.com wrote: > > From: Kan Liang > > > > Discards perf_mmap__read_backward and perf_mmap__read_catchup. > No tools > > use them. > > > > There are tools still use perf_mmap__read_forward. Keep it, but add > > comments to point to the new in

RE: [PATCH V3 08/12] perf top: check per event overwrite term

2018-01-11 Thread Liang, Kan
> On Thu, Dec 21, 2017 at 10:08:50AM -0800, kan.li...@intel.com wrote: > > From: Kan Liang > > > > Per event overwrite term is not forbidden in perf top, which can bring > > problems. Because perf top only support non-overwrite mode. > > > > Check and forbid inconsistent per event overwrite term i

RE: [PATCH V3 10/12] perf top: add overwrite fall back

2018-01-11 Thread Liang, Kan
> On Thu, Dec 21, 2017 at 10:08:52AM -0800, kan.li...@intel.com wrote: > > From: Kan Liang > > > > Switch to non-overwrite mode if kernel doesnot support overwrite > > ringbuffer. > > > > It's only effect when overwrite mode is supported. > > No change to current behavior. > > > > Signed-off-by: K

RE: [PATCH V3 11/12] perf top: switch default mode to overwrite mode

2018-01-11 Thread Liang, Kan
> SNIP > > > .max_stack = sysctl_perf_event_max_stack, > > .sym_pcnt_filter = 5, > > diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c > > index 68146f4..56023e4 100644 > > --- a/tools/perf/ui/browsers/hists.c > > +++ b/tools/perf

RE: [PATCH V3 11/12] perf top: switch default mode to overwrite mode

2018-01-11 Thread Liang, Kan
> On Thu, Dec 21, 2017 at 10:08:53AM -0800, kan.li...@intel.com wrote: > > SNIP > > > .max_stack = sysctl_perf_event_max_stack, > > .sym_pcnt_filter = 5, > > diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c > > index 68146f4..560

Re: [PATCH] drm/panel: lvds: Handle the optional regulator case properly

2018-01-11 Thread Laurent Pinchart
Hi Jani, On Thursday, 11 January 2018 16:31:59 EET Jani Nikula wrote: > On Thu, 11 Jan 2018, Laurent Pinchart wrote: > > My preference, however, would be for devm_regulator_get_optional() to > > return NULL when no regulator is present. The current implementation > > returns -ENODEV in multiple ca

Re: [PATCH 4.4 00/37] 4.4.110-stable review

2018-01-11 Thread Thomas Gleixner
On Thu, 11 Jan 2018, Linus Torvalds wrote: > On Thu, Jan 11, 2018 at 12:37 PM, Thomas Gleixner wrote: > > > > 67a9108ed431 ("x86/efi: Build our own page table structures") > > > > got rid of EFI depending on real_mode_header->trampoline_pgd > > So I think it only got rid of by default - the code

Re: [PATCH] media: v4l2-core: v4l2-mc: Add SPDX license identifier

2018-01-11 Thread Laurent Pinchart
Hi Shuah, On Thursday, 11 January 2018 22:44:08 EET Shuah Khan wrote: > On 01/11/2018 11:42 AM, Laurent Pinchart wrote: > > On Thursday, 11 January 2018 17:45:15 EET Shuah Khan wrote: > >> On 01/11/2018 05:55 AM, Laurent Pinchart wrote: > >>> On Wednesday, 10 January 2018 18:35:36 EET Shuah Khan w

Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks

2018-01-11 Thread Adam Ford
On Thu, Jan 11, 2018 at 3:04 PM, David Lechner wrote: > On 01/11/2018 02:58 PM, Adam Ford wrote: >> >> On Thu, Jan 11, 2018 at 2:04 PM, David Lechner >> wrote: >>> >>> On 01/11/2018 12:50 PM, Adam Ford wrote: On Thu, Jan 11, 2018 at 12:29 PM, David Lechner wrote: > >

Re: [PATCH 4.4 00/37] 4.4.110-stable review

2018-01-11 Thread Steven Sistare
On 1/11/2018 3:46 PM, Linus Torvalds wrote: > On Thu, Jan 11, 2018 at 12:37 PM, Thomas Gleixner wrote: >> >> 67a9108ed431 ("x86/efi: Build our own page table structures") >> >> got rid of EFI depending on real_mode_header->trampoline_pgd > > So I think it only got rid of by default - the codepath

Re: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

2018-01-11 Thread Guenter Roeck
On Thu, Jan 11, 2018 at 11:47:01AM -0800, Jae Hyun Yoo wrote: > On 1/10/2018 1:47 PM, Guenter Roeck wrote: > >On Tue, Jan 09, 2018 at 02:31:26PM -0800, Jae Hyun Yoo wrote: > >>This commit adds driver implementation for a generic PECI hwmon. > >> > >>Signed-off-by: Jae Hyun Yoo [ ... ] > >>+ > >>

Re: [PATCH v2 0/7] pipe: buffer limits fixes and cleanups

2018-01-11 Thread Joe Lawrence
On 01/11/2018 12:28 AM, Eric Biggers wrote: > This series simplifies the sysctl handler for pipe-max-size and fixes > another set of bugs related to the pipe buffer limits: > > - The root user wasn't allowed to exceed the limits when creating new > pipes. > > - There was an off-by-one error whe

Re: [PATCH 4.4 00/37] 4.4.110-stable review

2018-01-11 Thread Thomas Gleixner
On Thu, 11 Jan 2018, Steven Sistare wrote: > On 1/11/2018 3:46 PM, Linus Torvalds wrote: > > On Thu, Jan 11, 2018 at 12:37 PM, Thomas Gleixner > > wrote: > >> > >> 67a9108ed431 ("x86/efi: Build our own page table structures") > >> > >> got rid of EFI depending on real_mode_header->trampoline_pgd

Re: [PATCH v5 17/44] dt-bindings: clock: Add bindings for DA8XX CFGCHIP gate clocks

2018-01-11 Thread Rob Herring
On Sun, Jan 07, 2018 at 08:17:16PM -0600, David Lechner wrote: > This adds a new binding for the gate clocks present in the CFGCHIP syscon > registers in TI DA8XX SoCs. There are actually other gate clocks in this > block that could be added in the future, but TBCLK is currently the only > one bein

Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks

2018-01-11 Thread David Lechner
On 01/11/2018 03:34 PM, Adam Ford wrote: On Thu, Jan 11, 2018 at 3:04 PM, David Lechner wrote: On 01/11/2018 02:58 PM, Adam Ford wrote: On Thu, Jan 11, 2018 at 2:04 PM, David Lechner wrote: On 01/11/2018 12:50 PM, Adam Ford wrote: On Thu, Jan 11, 2018 at 12:29 PM, David Lechner wrote:

[PATCH v8 01/12] objtool: Detect jumps to retpoline thunks

2018-01-11 Thread David Woodhouse
From: Josh Poimboeuf A direct jump to a retpoline thunk is really an indirect jump in disguise. Change the objtool instruction type accordingly. Objtool needs to know where indirect branches are so it can detect switch statement jump tables. This fixes a bunch of warnings with CONFIG_RETPOLINE

Re: [PATCH 4/6] dt-bindings: tegra: Add documentation for nvidia,tegra194-pmc

2018-01-11 Thread Rob Herring
On Mon, Jan 08, 2018 at 06:54:36AM +0200, Mikko Perttunen wrote: > The Tegra194 power management controller has one additional register > aperture to be specified in the device tree node. > > Signed-off-by: Mikko Perttunen > --- > Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.t

[PATCH v8 03/12] x86/retpoline: Add initial retpoline support

2018-01-11 Thread David Woodhouse
Enable the use of -mindirect-branch=thunk-extern in newer GCC, and provide the corresponding thunks. Provide assembler macros for invoking the thunks in the same way that GCC does, from native and inline assembler. This adds X86_FEATURE_RETPOLINE and sets it by default on all CPUs. In some circums

[PATCH v8 12/12] x86/retpoline: Fill return stack buffer on vmexit

2018-01-11 Thread David Woodhouse
In accordance with the Intel and AMD documentation, we need to overwrite all entries in the RSB on exiting a guest, to prevent malicious branch target predictions from affecting the host kernel. This is needed both for retpoline and for IBRS. Signed-off-by: David Woodhouse Tested-by: Peter Zijlst

[PATCH v8 09/12] x86/retpoline/xen: Convert Xen hypercall indirect jumps

2018-01-11 Thread David Woodhouse
Convert indirect call in Xen hypercall to use non-speculative sequence, when CONFIG_RETPOLINE is enabled. Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner Reviewed-by: Juergen Gross Acked-by: Arjan van de Ven Acked-by: Ingo Molnar Cc: gno...@lxorguk.ukuu.org.uk Cc: Rik van Riel

[PATCH v8 06/12] x86/retpoline/entry: Convert entry assembler indirect jumps

2018-01-11 Thread David Woodhouse
Convert indirect jumps in core 32/64bit entry assembler code to use non-speculative sequences when CONFIG_RETPOLINE is enabled. Don't use CALL_NOSPEC in entry_SYSCALL_64_fastpath because the return address after the 'call' instruction must be *precisely* at the .Lentry_SYSCALL_64_after_fastpath la

[PATCH v8 10/12] x86/retpoline/checksum32: Convert assembler indirect jumps

2018-01-11 Thread David Woodhouse
Convert all indirect jumps in 32bit checksum assembler code to use non-speculative sequences when CONFIG_RETPOLINE is enabled. Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner Acked-by: Arjan van de Ven Acked-by: Ingo Molnar Cc: gno...@lxorguk.ukuu.org.uk Cc: Rik van Riel Cc: And

[PATCH v8 07/12] x86/retpoline/ftrace: Convert ftrace assembler indirect jumps

2018-01-11 Thread David Woodhouse
Convert all indirect jumps in ftrace assembler code to use non-speculative sequences when CONFIG_RETPOLINE is enabled. Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner Acked-by: Arjan van de Ven Acked-by: Ingo Molnar Cc: gno...@lxorguk.ukuu.org.uk Cc: Rik van Riel Cc: Andi Kleen

[PATCH v8 11/12] x86/retpoline/irq32: Convert assembler indirect jumps

2018-01-11 Thread David Woodhouse
From: Andi Kleen Convert all indirect jumps in 32bit irq inline asm code to use non speculative sequences. Signed-off-by: Andi Kleen Signed-off-by: Thomas Gleixner Acked-by: Arjan van de Ven Acked-by: Ingo Molnar Cc: gno...@lxorguk.ukuu.org.uk Cc: Rik van Riel Cc: Peter Zijlstra Cc: Linus

[PATCH v8 08/12] x86/retpoline/hyperv: Convert assembler indirect jumps

2018-01-11 Thread David Woodhouse
Convert all indirect jumps in hyperv inline asm code to use non-speculative sequences when CONFIG_RETPOLINE is enabled. Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner Acked-by: Arjan van de Ven Acked-by: Ingo Molnar Cc: gno...@lxorguk.ukuu.org.uk Cc: Rik van Riel Cc: Andi Kleen

[PATCH v8 00/12] Retpoline: Avoid speculative indirect calls in kernel

2018-01-11 Thread David Woodhouse
This is a mitigation for the 'variant 2' attack described in https://googleprojectzero.blogspot.com/2018/01/reading-privileged-memory-with-side.html Using GCC patches available from the hjl/indirect/gcc-7-branch/master branch of https://github.com/hjl-tools/gcc/commits/hjl and by manually patching

[PATCH v8 05/12] x86/retpoline/crypto: Convert crypto assembler indirect jumps

2018-01-11 Thread David Woodhouse
Convert all indirect jumps in crypto assembler code to use non-speculative sequences when CONFIG_RETPOLINE is enabled. Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner Acked-by: Arjan van de Ven Acked-by: Ingo Molnar Cc: gno...@lxorguk.ukuu.org.uk Cc: Rik van Riel Cc: Andi Kleen

Re: [PATCH 00/10] perf tools: Add support for CoreSight trace decoding

2018-01-11 Thread Kim Phillips
On Thu, 11 Jan 2018 14:11:00 -0700 Mathieu Poirier wrote: > On 11 January 2018 at 10:28, Kim Phillips wrote: > > On Thu, 11 Jan 2018 08:45:21 -0700 > > Mathieu Poirier wrote: > > > >> On 11 January 2018 at 05:23, Mark Brown wrote: > >> > On Wed, Jan 10, 2018 at 06:08:21PM -0600, Kim Phillips w

[PATCH v8 02/12] objtool: Allow alternatives to be ignored

2018-01-11 Thread David Woodhouse
Getting objtool to understand retpolines is going to be a bit of a challenge. For now, take advantage of the fact that retpolines are patched in with alternatives. Just read the original (sane) non-alternative instruction, and ignore the patched-in retpoline. This allows objtool to understand th

Re: [RFC PATCH v2 6/6] x86/entry/pti: don't switch PGD on when pti_disable is set

2018-01-11 Thread Willy Tarreau
On Thu, Jan 11, 2018 at 10:35:57AM -0800, Dave Hansen wrote: > On 01/11/2018 07:44 AM, Willy Tarreau wrote: > >> 4. Cleared on setuid() and friends > > This one causes me a problem : some daemons already take care of dropping > > privileges after the initial fork() for the sake of security. Haproxy

[PATCH v8 04/12] x86/spectre: Add boot time option to select Spectre v2 mitigation

2018-01-11 Thread David Woodhouse
Add a spectre_v2= option to select the mitigation used for the indirect branch speculation vulnerability. Currently, the only option available is retpoline, in its various forms. This will be expanded to cover the new IBRS/IBPB microcode features. The RETPOLINE_AMD feature relies on a serializing

Re: [PATCH v5 17/44] dt-bindings: clock: Add bindings for DA8XX CFGCHIP gate clocks

2018-01-11 Thread David Lechner
On 01/11/2018 03:45 PM, Rob Herring wrote: On Sun, Jan 07, 2018 at 08:17:16PM -0600, David Lechner wrote: This adds a new binding for the gate clocks present in the CFGCHIP syscon registers in TI DA8XX SoCs. There are actually other gate clocks in this block that could be added in the future, bu

<    2   3   4   5   6   7   8   9   10   >