> +extern struct __kernel_old_timeval ns_to_kernel_old_timeval(const s64 nsec);
Generally there's no need to mark arguments with arithmethic types as const, as
they are never modified in the calling scope.
> + * legacy timeval structure, only embedded in structures that
> + * traditionally used
On Thu, Mar 8, 2018 at 11:00 PM, Chen-Yu Tsai wrote:
> Hi,
>
> This series is a bit of cleanup and improvement for the new
> multi-cluster SMP code for Allwinner A80 and A83T (soon) SoCs.
>
> The first patch is just a typo fix.
>
> The second and third patch add the use of the "enable-method" cpu
* Masami Hiramatsu wrote:
> Since kprobes pre_handler doesn't need to recover preemption
> even if it modifies regs->ip anymore, this fixes to remove
> the preempt_enable_no_resched() from pre_handler.
>
> Signed-off-by: Masami Hiramatsu
> ---
> kernel/fail_function.c |1 -
> 1 file chang
* Masami Hiramatsu wrote:
> Hello,
>
> Since we decided to remove jprobe from kernel last year,
> its APIs are disabled and we worked on moving in-kernel
> jprobe users to kprobes or trace-events. And now no jprobe
> users are here anymore.
>
> I think it is good time to get rid of jprobe impl
Add new function tpm2_validate_command to tpm2-space.c
that wraps up open coded functionality from tpm_validate_command.
Signed-off-by: Tomas Winkler
---
drivers/char/tpm/tpm-interface.c | 31 ++-
drivers/char/tpm/tpm.h | 1 +
drivers/char/tpm/tpm2-cmd.c
tpm manual startup is used only from within tpm1 or tpm2
code, hence remove tpm_startup function from tpm-interface.c
and add two static functions implementations tpm1_startup
and tpm2_startup into to tpm1-cmd.c and tpm2-cmd.c respectively.
Signed-off-by: Tomas Winkler
---
drivers/char/tpm/tpm-i
Move tpm1_pcr_extend to tpm1-cmd.c and remove
unused pcrextend_header structure.
Signed-off-by: Tomas Winkler
---
drivers/char/tpm/tpm-interface.c | 28
drivers/char/tpm/tpm.h | 2 ++
drivers/char/tpm/tpm1-cmd.c | 23 +++
3 files c
Move the tmp1 selftest code functions to tpm1-cmd.c
and adjust callers to use the new function names.
1. tpm_pcr_read_dev to tpm1_pcr_read_dev
2. tpm_continue_selftest to tpm1_continue_selftest
3. tpm_do_selftest to tpm1_do_selftest
Signed-off-by: Tomas Winkler
---
drivers/char/tpm/st33zp24/s
Factor out tpm1 suspend flow from tpm-interface.c into a new function
tpm1_pm_suspend in tpm1-cmd.c
Signed-off-by: Tomas Winkler
---
drivers/char/tpm/tpm-interface.c | 55
drivers/char/tpm/tpm.h | 1 +
drivers/char/tpm/tpm1-cmd.c | 54
1. Move tpm_getcap to tpm1-cmd. Rename the function to tpm1_getcap.
2. Remove unused tpm_getcap_header with unused constant
as this functionality is already implemented using tpm_buf construct.
Signed-off-by: Tomas Winkler
---
drivers/char/tpm/tpm-interface.c | 47 +--
Add tpm2_pcr_extend function to tpm2-cmd.c with signature required
by tpm-interface.c. It wraps the original open code
implementation. The original original tpm2_pcr_extend function
is renamed and made static, called only from new tpm2_pcr_extend.
Signed-off-by: Tomas Winkler
---
drivers/char/tp
Move TPM1 implementation from tpm-interface.c to tpm1-cmd.c
similarly to tpm2-cmd.c, as well as move TPM2 open code flows
into new functions to tpm2-cmd.c
The functions in tpm-interface.c should now be in form:
int tpm_func(struct tpm_chip *chip)
{
if (chip->flags & TPM_CHIP_FLAG_TPM2)
Factor out get random implementation from tpm-interface.c
into tpm1_get_random function in tpm1-cmd.c.
No functional changes.
Signed-off-by: Tomas Winkler
---
drivers/char/tpm/tpm-interface.c | 56
drivers/char/tpm/tpm.h | 2 ++
drivers/char/tp
On Sat, 10 Mar 2018 09:40:44 +0200
Andreas Christoforou wrote:
> diff --git a/net/ipv6/xfrm6_state.c b/net/ipv6/xfrm6_state.c
> index b15075a..270a53a 100644
> --- a/net/ipv6/xfrm6_state.c
> +++ b/net/ipv6/xfrm6_state.c
> @@ -62,7 +62,7 @@ __xfrm6_sort(void **dst, void **src, int n, int (*cmp)(vo
For fine-grained debugging and usercopy protection.
Signed-off-by: Alexey Dobriyan
---
fs/seq_file.c| 12 ++--
include/linux/seq_file.h |1 +
init/main.c |1 +
3 files changed, 12 insertions(+), 2 deletions(-)
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@
All it takes to open a file and read 1 byte from it.
seq_file will be allocated along with any private allocations,
and more importantly seq file buffer which is 1 page by default.
Signed-off-by: Alexey Dobriyan
---
fs/seq_file.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
On Saturday, March 10, 2018 8:41:39 AM CET Doug Smythies wrote:
> On 2018.03.09 07:19 Rik van Riel wrote:
> > On Fri, 2018-03-09 at 10:34 +0100, Rafael J. Wysocki wrote:
> >> Hi All,
> >>
> >> Thanks a lot for the discussion and testing so far!
> >>
> >> This is a total respin of the whole series
On Saturday, March 10, 2018 6:01:31 AM CET Mike Galbraith wrote:
> On Fri, 2018-03-09 at 10:34 +0100, Rafael J. Wysocki wrote:
> > Hi All,
> >
> > Thanks a lot for the discussion and testing so far!
> >
> > This is a total respin of the whole series, so please look at it afresh.
> > Patches 2 and
Commit-ID: c2cda2a5bda9f1369c9d1ab54a20571c13cf2743
Gitweb: https://git.kernel.org/tip/c2cda2a5bda9f1369c9d1ab54a20571c13cf2743
Author: Miroslav Lichvar
AuthorDate: Fri, 9 Mar 2018 10:42:47 -0800
Committer: Ingo Molnar
CommitDate: Sat, 10 Mar 2018 09:12:41 +0100
timekeeping/ntp: Don't
Commit-ID: 78b98e3c5a66d569a53b8f57b6a698f912794a43
Gitweb: https://git.kernel.org/tip/78b98e3c5a66d569a53b8f57b6a698f912794a43
Author: Miroslav Lichvar
AuthorDate: Fri, 9 Mar 2018 10:42:48 -0800
Committer: Ingo Molnar
CommitDate: Sat, 10 Mar 2018 09:12:41 +0100
timekeeping/ntp: Determ
On Sat, Mar 10, 2018 at 01:34:45AM +0100, Maciej S. Szmigiero wrote:
> Currently, it is very easy to make the AMD microcode update driver crash
> or spin on a malformed microcode file since it does very little
> consistency checking on data loaded from such file.
Sorry but if one has enough permis
Commit-ID: d095c12c53c7b941ad4ea96dc229a08296b37d2e
Gitweb: https://git.kernel.org/tip/d095c12c53c7b941ad4ea96dc229a08296b37d2e
Author: Paul E. McKenney
AuthorDate: Wed, 7 Mar 2018 09:27:38 -0800
Committer: Ingo Molnar
CommitDate: Sat, 10 Mar 2018 10:22:23 +0100
tools/memory-model: Rem
Commit-ID: f28f0868feb1e79b460131bac37230e303a5f6a4
Gitweb: https://git.kernel.org/tip/f28f0868feb1e79b460131bac37230e303a5f6a4
Author: Paul E. McKenney
AuthorDate: Wed, 7 Mar 2018 09:27:37 -0800
Committer: Ingo Molnar
CommitDate: Sat, 10 Mar 2018 10:22:22 +0100
locking/memory-barriers
Commit-ID: ff1fe5e079730f138c98b268ce2e8482a1d954b4
Gitweb: https://git.kernel.org/tip/ff1fe5e079730f138c98b268ce2e8482a1d954b4
Author: Paul E. McKenney
AuthorDate: Wed, 7 Mar 2018 09:27:39 -0800
Committer: Ingo Molnar
CommitDate: Sat, 10 Mar 2018 10:22:23 +0100
tools/memory-model: Add
Commit-ID: bd5c0ba2cd78a4c116726ead84f8f37dc92d043e
Gitweb: https://git.kernel.org/tip/bd5c0ba2cd78a4c116726ead84f8f37dc92d043e
Author: Alan Stern
AuthorDate: Wed, 7 Mar 2018 09:27:40 -0800
Committer: Ingo Molnar
CommitDate: Sat, 10 Mar 2018 10:22:23 +0100
tools/memory-model: Finish th
> +int dax_set_page_dirty(struct page *page)
> +{
> + /*
> + * Unlike __set_page_dirty_no_writeback that handles dirty page
> + * tracking in the page object, dax does all dirty tracking in
> + * the inode address_space in response to mkwrite faults. In the
> + * dax case we
>
> +int
> +xfs_break_layouts(
> + struct inode*inode,
> + uint*iolock,
> + unsigned long flags)
> +{
> + struct xfs_inode*ip = XFS_I(inode);
> + uintiolock_assert = 0;
> + int ret =
Hi Jiri,
On Fri, Mar 09, 2018 at 09:56:00PM +0100, Jiri Olsa wrote:
> On Fri, Mar 09, 2018 at 02:05:23PM +0800, Leo Yan wrote:
> > On Hikey arm64 octa A53 platform, when use command './perf report -v
> > -k vmlinux --stdio' it outputs below error info, and it skips to load
> > kernel symbol and do
> +static int xfs_wait_dax_page(
> + atomic_t*count,
> + unsigned intmode)
> +{
Normal XFS style would be:
static int
xfs_wait_dax_page(
atomic_t*count,
unsigned intmode)
{
> + struct page
Make some of the macro names according to the names
given in the datasheet of the adis16209 driver and
have slight indentation in field definitions to make
them clearly different from the register addresses.
Signed-off-by: Shreeya Patel
---
Changes in v5
-Re-send the corrected patch.
drivers
On Wed, 7 Mar 2018 18:43:42 -0500
Paul Moore wrote:
> ... and I just realized that linux-audit isn't on the To/CC line,
> adding them now.
>
> Link to the patch is below.
>
> * https://marc.info/?t=15204188763&r=1&w=2
Yes...I wished I was in on the beginning of this discussion. Here's the
p
Move the adis16209 driver out of staging directory and merge to the
mainline IIO subsystem.
Signed-off-by: Shreeya Patel
---
Changes in v2
-Re-send the patch after having some cleanups in the
file included in this patch.
drivers/iio/accel/Kconfig | 12 ++
drivers/iio/accel/Makef
On Friday 09 March 2018 09:59:39 mario.limoncie...@dell.com wrote:
> > > Pali is your concern that this code for matching vendor/subsystem is
> > > running
> > > on non-Dell too? The only other recommendation I think that can be to
> > > restrict
> > > to matching Dell OEM strings in SMBIOS tabl
On Saturday 10 March 2018 07:50:39 Lukas Wunner wrote:
> Pretty much all modern Nvidia GPUs do have an integrated HDA
> controller, however it's possible to hide it by clearing a bit
> at offset 0x488 in the GPU's config space. Some BIOSes hide
> the HDA if no external display is attached.
>
> I
On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote:
> On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote:
> > Thanks a lot for trying out the patch!
> >
> > Please don't modify your install at this stage, I think we are hitting a
> > firmware bug and that would be awesome if we can
Hi Linus,
Please pull the watchdog fixes for the v4.16 release cycle.
This series contains:
* f71808e_wdt: Fix magic close handling
* sbsa: 32-bit read fix for WCV
* hpwdt: Remove legacy NMI sourcing
The output from git request-pull:
--
Many of the variable names in scripts/kconfig/symbol.c are
far too terse to the point of not at all identifying _what_
they are actually used for (`p` and `l` as a couple examples),
and overall there is a large amount of code that could use
some cleaning up.
Give more explicit names to these varia
The Pyra-Handheld originally used the tca6424 but recently we have
replaced it by the pin and package compatible pcal6524. So let's
add this to the bindings and the driver.
And while we are at it, the pcal9555a does not have a compatible entry
either but is already supported by the device id table
This extends spk_io_ops with a synth_out_unicode which takes a u16 character
instead of just a byte, and extends spk_ttyio to implement it to emit
utf-8. spk_do_catch_up_unicode can then be introduced to benefit from
synth_out_unicode, and speakup_dummy made to use spk_do_catch_up_unicode instead
o
This patch adds DT bindings documentation for Maxim MAX9759
speaker amplifier.
Reviewed-by: Rob Herring
Signed-off-by: Neil Armstrong
---
.../devicetree/bindings/sound/maxim,max9759.txt| 18 ++
1 file changed, 18 insertions(+)
create mode 100644 Documentation/devicetree
The MAX9759 is a gpio controlled speaker amplifier, this patchset
add the DT Bindings and the corresponding ASoC component driver.
Changes with resend :
- Add rob ack on bindings
Neil Armstrong (2):
ASoC: Add DT bindings documentation for max9759 amplifier
ASoC: max9759: Add Amplifier Driver
From: Ondrej Jirman
Currently the exclusivity is enabled when the rate is set by
the mode setting functions. These functions are called by
mode_set_nofb callback of drm_crc_helper. Then exclusivity
is disabled when tcon is disabled by atomic_disable
callback.
What happens is that mode_set_nofb c
The max9759 is a gpio controlled amplifier.
Tested on a Variscite Dart MX6 SoM based custom board.
Signed-off-by: Neil Armstrong
---
sound/soc/codecs/Kconfig | 5 ++
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/max9759.c | 207 +
3 files ch
On Fri, Mar 09, 2018 at 10:41:20AM -0700, Jonathan Corbet wrote:
> On Fri, 9 Mar 2018 00:40:16 +0100
> Jonathan Neuschäfer wrote:
>
> > The aim of this patchset is to move the GPIO subsystem's documentation
> > under Documentation/driver-api/gpio/ such that it is picked up by Sphinx
> > and comp
On 03/10/2018 12:01 AM, Pavel Machek wrote:
[...]
>> What file are you opening to cause this?
>
> Strace says:
>
> openat(7, "in_intensity_both_thresh_rising_en",
>>> O_RDONLY|O_LARGEFILE|O_NOFOLLOW) = 3
> fstat64(3, {st_mode=S_IFREG|0644, st_size=4096, ...}) = 0
> ioctl(3, SNDCTL_TMR_TIMEBASE or
2018-03-10 8:01 GMT+09:00 Pavel Machek :
> Hi!
>
>> > Hmm. Looks like there's a lot of fun to be had with sysfs.
>> >
>> >
>> > pavel@n900:~$ uname -a
>> > Linux n900 4.16.0-rc4-59690-g7f84626-dirty #543 Thu Mar 8 19:53:30 CET
>> > 2018 armv7l GNU/Linux
>> >
>> > [ 306.402496] bq2415x: command Tim
On Tue, 2018-03-06 at 15:19 +, Winkler, Tomas wrote:
> > On Tue, 2018-03-06 at 11:25 +0200, Tomas Winkler wrote:
> > > TPM2_CC_Create(0x153) and TPM2_CC_CreatePrimary (0x131) involve
> > > generation of crypto keys which can be a computationally intensive task.
> > > The timeout is set to 3min.
Hi!
> >>> Well, there certainly seems to be an obvious bug wherein
> >>> isp_detach_iommu() just releases the mapping directly without calling
> >>> arm_iommu_detach_device() to balance the equivalent attach. That can't
> >>> be helping.
> >>
> >> Indeed, I have been able to reproduce the same war
On 09/03/18 22:04, Kieran Bingham wrote:
> VSPD and VSP-DL devices can provide extended display lists supporting
> extended command display list objects.
>
> These extended commands require their own dma memory areas for a header
> and body specific to the command type.
>
> Implement a command po
On Sat, 10 Mar 2018 03:23:18 +,
peng hao wrote:
> >> For emulation devices just like vga, keeping coherent dcache between
> >> guest and host timely is needed.
> >> Now the display of vnc-viewer will not update continuously and the
> >> patch can fix up.
> >>
> >> Signed-off-by: Peng Hao
> >
On Fri, Mar 9, 2018 at 12:40 AM, Jonathan Neuschäfer
wrote:
> The aim of this patchset is to move the GPIO subsystem's documentation
> under Documentation/driver-api/gpio/ such that it is picked up by Sphinx
> and compiled into HTML.
Awesome!
> I moved everything except for sysfs.txt, because
>
On Thu, Mar 8, 2018 at 9:36 PM, Alex Lemberg wrote:
> On 3/2/18 4:53 AM, Linus Walleij wrote:
>> What we need to do is make the "special partitions" part of the
>> main block device and stop spawning these special block
>> devices for each boot partions or general partitions. In addition,
>> each
Hi!
On Sat 2018-03-10 12:19:29, Lars-Peter Clausen wrote:
> On 03/10/2018 12:01 AM, Pavel Machek wrote:
> [...]
> >> What file are you opening to cause this?
> >
> > Strace says:
> >
> > openat(7, "in_intensity_both_thresh_rising_en",
> >>> O_RDONLY|O_LARGEFILE|O_NOFOLLOW) = 3
> > fstat64(3, {st
On Fri, 09 Mar 2018 21:36:12 +,
Christoffer Dall wrote:
>
> On Thu, Mar 08, 2018 at 05:28:44PM +, Marc Zyngier wrote:
> > I'd be more confident if we did forbid P+A for such interrupts
> > altogether, as they really feel like another kind of HW interrupt.
>
> How about a slightly bigger h
On 10.03.2018 10:18, Borislav Petkov wrote:
> On Sat, Mar 10, 2018 at 01:34:45AM +0100, Maciej S. Szmigiero wrote:
>> Currently, it is very easy to make the AMD microcode update driver crash
>> or spin on a malformed microcode file since it does very little
>> consistency checking on data loaded fr
On Tue, 2018-03-06 at 13:36 -0500, Mimi Zohar wrote:
> I've heard that some maintainers are moving away from cover letters,
> since they are not include in the git repo and are lost. I've seen
> Andrew Morton cut and paste the cover letter in the first patch
> description of the patch set.
When I
On Wed, 2018-03-07 at 08:54 -0700, Jonathan Corbet wrote:
> On Tue, 06 Mar 2018 13:36:36 -0500
> Mimi Zohar wrote:
>
> > I've heard that some maintainers are moving away from cover letters,
> > since they are not include in the git repo and are lost.
>
> If I get a patch series with a cover lett
On Wed, 2018-03-07 at 11:35 -0500, Mimi Zohar wrote:
> On Wed, 2018-03-07 at 08:54 -0700, Jonathan Corbet wrote:
> > On Tue, 06 Mar 2018 13:36:36 -0500
> > Mimi Zohar wrote:
> >
> > > I've heard that some maintainers are moving away from cover letters,
> > > since they are not include in the git
On Fri, 9 Mar 2018 10:56:07 -0800, Alex Hung wrote:
> On Fri, Mar 9, 2018 at 5:33 AM, Jean Delvare wrote:
> > However it doesn't make sense to commit this change unless there will
> > be at least one user of it. What is the status of the piece of code
> > which was supposed to use this new feature
On Thu, 2018-03-08 at 13:47 -0800, J Freyensee wrote:
> Looks better :-).
>
>
> Acked-by: Jay Freyensee
Thank you.
/Jarkko
On Sat, Mar 10, 2018 at 01:26:00PM +0100, Maciej S. Szmigiero wrote:
> Without them, it is easy to crash the driver when just playing with
> microcode files
You're not supposed to play with the microcode files. If you do and
something breaks, you get to keep the pieces.
If the official microcode
Hi Andrew,
Thank you very much for taking care of this.
Please find my answers to your remarks below.
On Fri, 9 Mar 2018 14:12:52 -0800
Andrew Morton wrote:
> On Fri, 09 Mar 2018 21:41:38 +0100 Greg Kurz wrote:
>
> > If it was interrupted by a signal, the 9p client may need to send some
> >
On Sat, Mar 10, 2018 at 03:58:04PM +0800, Xin Long wrote:
> On Sat, Mar 10, 2018 at 6:08 AM, Neil Horman wrote:
> > On Fri, Mar 09, 2018 at 12:59:06PM -0800, syzbot wrote:
> >> Hello,
> >>
> >> syzbot hit the following crash on net-next commit
> >> fd372a7a9e5e9d8011a0222d10edd3523abcd3b1 (Thu Mar
On 9.3.2018 20:05, Rob Herring wrote:
> On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M. wrote:
>> Hi,
>>
>> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
>> makes microblaze unbootable.
>>
>> I'm sorry I can't provide any console output, as nothing appears at all,
>> even wh
Hi!
> > Ok, I've just tested linux-next, and it works ok for me on thinkpad
> > x60. (But that's probably rather different configuration from the
> > macbook).
> >
> > Unfortunately, I could not deduce anything useful from the
> > backtraces. Andrew, could you try v4.15 with KPTI disabled ?
> >
>
On Fri, Mar 09, 2018 at 06:06:29PM -0500, Waiman Long wrote:
> So you are talking about sched_relax_domain_level and
That one I wouldn't be sad to see the back of.
> sched_load_balance.
This one, that's critical. And this is the perfect time to try and fix
the whole isolcpus issue.
The primary
According to Documentation/process/license-rules.rst, move the SPDX
License Identifier to the very top of the file. I used C++ comment
style not only for the SPDX line but for the entire block because
this seems Linus' preference [1]. I also dropped the parentheses to
follow the examples in that
According to Documentation/process/license-rules.rst, move the SPDX
License Identifier to the very top of the file. I used C++ comment
style not only for the SPDX line but for the entire block because
this seems Linus' preference [1]. I also dropped the parentheses to
follow the examples in that
On 10.03.2018 14:12, Borislav Petkov wrote:
> On Sat, Mar 10, 2018 at 01:26:00PM +0100, Maciej S. Szmigiero wrote:
>> Without them, it is easy to crash the driver when just playing with
>> microcode files
>
> You're not supposed to play with the microcode files. If you do and
> something breaks, y
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: cdb06e9d8f520c969676e7d6778cffe5894f079f
commit: 101110f6271ce956a049250c907bc960030577f8 Kbuild: always define
endianess in kconfig.h
date: 2 weeks ago
config: h8300-h8300h-sim_defconfig (attached as .con
On Sat, Mar 10, 2018 at 12:50:46PM +0100, Linus Walleij wrote:
> On Fri, Mar 9, 2018 at 12:40 AM, Jonathan Neuschäfer
> wrote:
>
> > The aim of this patchset is to move the GPIO subsystem's documentation
> > under Documentation/driver-api/gpio/ such that it is picked up by Sphinx
> > and compiled
Hi Bart,
On Fri, 9 Mar 2018 22:47:12 +, Bart Van Assche
wrote:
> On Fri, 2018-03-09 at 23:33 +0100, Stephen Kitt wrote:
> > +/*
> > + * SCSI command sizes are as follows, in bytes, for fixed size commands,
> > per
> > + * group: 6, 10, 10, 12, 16, 12, 10, 10. The top three bits of an opcode
>
Hi Linus,
Please pull more Kbuild fixes for v4.16.
The following changes since commit 661e50bc853209e41a5c14a290ca4decc43cbfd1:
Linux 4.16-rc4 (2018-03-04 14:54:11 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git
tags
Hi Bart,
On Fri, 9 Mar 2018 22:48:10 +, Bart Van Assche
wrote:
> On Fri, 2018-03-09 at 23:32 +0100, Stephen Kitt wrote:
> > In preparation to enabling -Wvla, remove VLAs and replace them with
> > fixed-length arrays instead.
> >
> > scsi_dh_{alua,emc,rdac} use variable-length array declarati
On Fri, 9 Mar 2018 18:54:02 -0500
Steven Rostedt wrote:
> On Fri, 9 Mar 2018 21:35:17 +0900
> Masami Hiramatsu wrote:
>
> > Hello,
> >
> > Since we decided to remove jprobe from kernel last year,
> > its APIs are disabled and we worked on moving in-kernel
> > jprobe users to kprobes or trace-
Hi Tim,
On Mon, Mar 5, 2018 at 7:02 PM, Tim Harvey wrote:
> +
> + hwmon@1 { /* A1: Input Voltage */
> + type = <1>;
> + reg = <0x02>;
Unit address (@1) does not match the 'reg' value.
If someone build this exampl
On Fri, Mar 09, 2018 at 09:02:18PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wvla, remove VLA and replace it
> with a fixed-length array instead.
>
> Fixed as part of the directive to remove all VLAs from
> the kernel: https://lkml.org/lkml/2018/3/7/621
>
> Signed-off-by: Gu
On Fri, Mar 09, 2018 at 06:34:18PM -0800, Alexei Starovoitov wrote:
> On 3/9/18 11:38 AM, Linus Torvalds wrote:
> > On Fri, Mar 9, 2018 at 11:12 AM, Linus Torvalds
> > wrote:
> > >
> > > How are you going to handle five processes doing the same setup
> > > concurrently?
Let's keep in mind we don
*Poke*
Luis
On Wed, Nov 29, 2017 at 6:36 PM, Luis R. Rodriguez wrote:
> Debugging ineractions with userspace can often be a bit of pain, specially
> when trying to figure out who is at fault for an issue. Having the kernel
> process aliases when debugging can help us much faster find who is th
Greg,
Here's a respin of what I have queued up for v4.17 for the firmware API. It
combines the cleanup I've been working on and the addition of the new API call
request_firmware_cache() for fixing a corner case suspend issue on some type of
cards with an optimization in place where the firmware is
This will make it much easier to manage as we manage to
keep trimming componnents down into their own files to more
easily manage and maintain this codebase.
Suggested-by: Kees Cook
Signed-off-by: Luis R. Rodriguez
---
MAINTAINERS | 2 +-
dr
request_firmware_cache() will ensure the firmware is available on resume
from suspend if on reboot the device retains the firmware.
This optimization is in place given otherwise on reboot we have to
reload the firmware, the opmization saves us about max 1s, minimum 10ms.
Cantabile has reported ba
Some devices have an optimization in place to enable the firmware to
be retaineed during a system reboot, so after reboot the device can skip
requesting and loading the firmware. This can save up to 1s in load
time. The mt7601u 802.11 device happens to be such a device.
When these devices retain t
Since we now have knobs to twiddle what used to be set on kernel
configurations we can build one base kernel configuration and modify
behaviour to mimic such kernel configurations to test them.
Provided you build a kernel with:
CONFIG_TEST_FIRMWARE=y
CONFIG_FW_LOADER=y
CONFIG_FW_LOADER_USER_HELPE
request_firmware_into_buf() explicitly disables the firmware cache,
meanwhile the firmware cache cannot be used when request_firmware_nowait()
is used without the uevent. Enforce a sanity check for this to avoid future
issues undocumented behaviours should misuses of the firmware cache
happen later
This expands our library with as many things we could find which
both scripts we use share.
Signed-off-by: Luis R. Rodriguez
---
tools/testing/selftests/firmware/fw_fallback.sh | 31 +++---
tools/testing/selftests/firmware/fw_filesystem.sh | 41 +++---
tools/testing/selftes
Add a helper to check if the firmware cache is already setup for a device.
This will be used later.
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_loader/main.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/base/firmware_loader/main.c
b/
Users of the custom firmware fallback interface is are not supposed to
use the firmware cache interface, this can happen if for instance the
one of the APIs which use the firmware cache is used first with one
firmware file and then the request_firmware_nowait(uevent=false) API
is used with the same
Currently fw_add_devm_name() returns 1 if the firmware cache
was already set. This makes it complicated for us to check for
correctness. It is actually non-fatal if the firmware cache
is already setup, so just return 0, and simplify the checkers.
fw_add_devm_name() adds device's name onto the devr
This reflects much clearer what is being done.
While at it, kdoc'ify it.
Signed-off-by: Luis R. Rodriguez
---
Documentation/driver-api/firmware/fallback-mechanisms.rst | 2 +-
drivers/base/firmware_loader/fallback.c | 13 ++---
2 files changed, 11 insertions(+), 4 dele
You currently need four different kernel builds to test the firmware
API fully. By adding a proc knob to force disable the fallback mechanism
completely we are able to reduce the amount of kernels you need built
to test the firmware API down to two.
Acked-by: Kees Cook
Signed-off-by: Luis R. Rodr
Currently one requires to test four kernel configurations to test the
firmware API completely:
0)
CONFIG_FW_LOADER=y
1)
o CONFIG_FW_LOADER=y
o CONFIG_FW_LOADER_USER_HELPER=y
2)
o CONFIG_FW_LOADER=y
o CONFIG_FW_LOADER_USER_HELPER=y
o CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y
3) When CO
On Fri, Mar 09, 2018 at 04:21:37PM -0800, Daniel Lustig wrote:
> On 3/9/2018 2:57 PM, Palmer Dabbelt wrote:
> > On Fri, 09 Mar 2018 13:30:08 PST (-0800), parri.and...@gmail.com wrote:
> >> On Fri, Mar 09, 2018 at 10:54:27AM -0800, Palmer Dabbelt wrote:
> >>> On Fri, 09 Mar 2018 10:36:44 PST (-0800)
On Fri, Mar 9, 2018 at 2:12 PM, Andres Rodriguez wrote:
> Hi Everyone,
>
> Wanted to inquire your opinions about the following matter.
>
> We are experiencing some end user confusion regarding the following messages
> being printed to dmesg:
>
> [0.571324] amdgpu :01:00.0: Direct firmware
The firmware fallback code is optional. Split that code out to help
distinguish the fallback functionlity from othere core firmware loader
features. This should make it easier to maintain and review code
changes.
The reason for keeping the configuration onto a table which is built-in
if you enable
All CONFIG_FW_LOADER_USER_HELPER_FALLBACK really is, is just a bool,
initailized at build time. Define it as such. This simplifies the
logic even further, removing now all explicit #ifdefs around the code.
Acked-by: Kees Cook
Signed-off-by: Luis R. Rodriguez
---
drivers/base/firmware_loader.c |
We only use the timeout for the firmware fallback mechanism
except for trying to set the timeout during the cache setup
for resume/suspend. For those cases, setting the timeout should
be a no-op, so just reflect this in code by adding helpers for it.
This change introduces no functional changes.
The timeout is a fallback construct, so we can just stuff the
timeout configuration under struct firmware_fallback_config.
While at it, add a few helpers which vets the use of getting or
setting the timeout as an int. The main use of the timeout is
to set a timeout for completion, and that is used
We'll expland on this later, for now just add basic module checker.
While at it, move this all to use /bin/bash as we'll have much more
flexibility with it.
Signed-off-by: Luis R. Rodriguez
---
tools/testing/selftests/firmware/fw_fallback.sh | 7 ++--
tools/testing/selftests/firmware/fw_files
The firmware loader code has grown quite a bit over the years.
The practice of stuffing everything we need into one file makes
the code hard to follow.
In order to split the firmware loader code into different components
we must pick a module name and a first object target file. We must
keep the f
1 - 100 of 343 matches
Mail list logo
