Re: [PATCH] arm64: dts: qcom: rename qcom,pcie devices to pcie

2018-03-13 Thread Bjorn Andersson
On Tue 13 Mar 05:13 PDT 2018, Arnd Bergmann wrote: > The node name for a PCIe host bridge must be "pcie" as required by > the binging. dtc now warns about it: > "binding", I presume... > arch/arm64/boot/dts/qcom/apq8096-db820c.dtb: Warning (pci_bridge): > /soc/agnoc@0/qcom,pcie@61: node

RE: [PATCH v3 6/6] PCI: hv: fix 2 hang issues in hv_compose_msi_msg()

2018-03-13 Thread Dexuan Cui
> From: Dexuan Cui > Sent: Wednesday, March 7, 2018 13:40 > To: Lorenzo Pieralisi > Cc: bhelg...@google.com; linux-...@vger.kernel.org; KY Srinivasan > ; Stephen Hemminger ; > o...@aepfle.de; a...@canonical.com;

[bug, bisected] pfifo_fast causes packet reordering

2018-03-13 Thread Jakob Unterwurzacher
During stress-testing our "ucan" USB/CAN adapter SocketCAN driver on Linux v4.16-rc4-383-ged58d66f60b3 we observed that a small fraction of packets are delivered out-of-order. We have tracked the problem down to the driver interface level, and it seems that the driver's

Re: [PATCH 18/31] perf vendor events arm64: Add armv8-recommended.json

2018-03-13 Thread Arnaldo Carvalho de Melo
9-9-git-send-email-john.ga...@huawei.com > > Signed-off-by: John Garry <john.ga...@huawei.com> > > Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com> > That's not a valid SOB chain, author != first-Signed-off-by. I removed that cset for now, can you please check if the perf-core-for-mingo-4.17-20180313-2 tag is allright? - Arnaldo

Re: [PATCH v4 09/24] fpga: dfl-pci: add enumeration for feature devices

2018-03-13 Thread Alan Tull
On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: Hi Hao, Thanks again for splitting the pci part of the code from enumeration and everything else. One thing that may need to be fixed below, so with that fixed, adding my ack. > The Device Feature List (DFL) is implemented in

Re: [PATCH v3 6/6] PCI: hv: fix 2 hang issues in hv_compose_msi_msg()

2018-03-13 Thread Lorenzo Pieralisi
On Tue, Mar 13, 2018 at 06:23:39PM +, Dexuan Cui wrote: > > From: Dexuan Cui > > Sent: Wednesday, March 7, 2018 13:40 > > To: Lorenzo Pieralisi > > Cc: bhelg...@google.com; linux-...@vger.kernel.org; KY Srinivasan > > ; Stephen Hemminger

[PATCH RFC 8/8] powerpc/64: barrier_nospec: Add commandline trigger

2018-03-13 Thread Michal Suchanek
Copypasta from rfi implementation Signed-off-by: Michal Suchanek --- arch/powerpc/kernel/setup_64.c | 8 1 file changed, 8 insertions(+) diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c index 4b67b7b877d9..257f0e6be107 100644 ---

[PATCH RFC 7/8] powerpc/64s: barrier_nospec: Add hcall triggerr

2018-03-13 Thread Michal Suchanek
Copypasta from rfi implementation Signed-off-by: Michal Suchanek --- arch/powerpc/platforms/pseries/setup.c | 38 ++ 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/arch/powerpc/platforms/pseries/setup.c

[PATCH v4] dmaengine: pl330: flush before wait, and add dev burst support.

2018-03-13 Thread Frank Mori Hess
Do DMAFLUSHP _before_ the first DMAWFP to ensure controller and peripheral are in agreement about dma request state before first transfer. Add support for burst transfers to/from peripherals. In the new scheme, the controller does as many burst transfers as it can then transfers the remaining

[PATCH RFC 3/8] powerpc/64: Use barrier_nospec in syscall entry

2018-03-13 Thread Michal Suchanek
Signed-off-by: Michal Suchanek --- arch/powerpc/kernel/entry_64.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S index 2cb5109a7ea3..7bfc4cf48af2 100644 --- a/arch/powerpc/kernel/entry_64.S +++

[PATCH RFC 6/8] powerpc/64: barrier_nospec: Add debugfs trigger

2018-03-13 Thread Michal Suchanek
Copypasta from rfi implementation Signed-off-by: Michal Suchanek --- arch/powerpc/kernel/setup_64.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c index

[PATCH RFC 0/8] powerpc barrier_nospec

2018-03-13 Thread Michal Suchanek
Hello, this is patchset adding barrier_nospec on powerpc. It is based on the out-of-tree gmb() patch and the existing rfi patches. I do not have the tests for the Spectre/Meltdown issues available so this is untested. Feedback on the general approach as well as actual effectivity is welcome.

Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct

2018-03-13 Thread Julia Lawall
On Tue, 13 Mar 2018, Matthew Wilcox wrote: > On Tue, Mar 13, 2018 at 06:19:51PM +0100, Julia Lawall wrote: > > On Thu, 8 Mar 2018, Matthew Wilcox wrote: > > > On Thu, Mar 08, 2018 at 07:24:47AM +0100, Julia Lawall wrote: > > > > Thanks. So it's OK to replace kmalloc and kzalloc, even though

[PATCH] spi: bcm-qspi: fIX some error handling paths

2018-03-13 Thread Christophe JAILLET
For some reason, commit c0368e4db4a3 ("spi: bcm-qspi: Fix use after free in bcm_qspi_probe() in error path") has updated some gotos, but not all of them. This looks spurious, so fix it. Fixes: fa236a7ef240 ("spi: bcm-qspi: Add Broadcom MSPI driver") Signed-off-by: Christophe JAILLET

Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct

2018-03-13 Thread Matthew Wilcox
On Tue, Mar 13, 2018 at 06:19:51PM +0100, Julia Lawall wrote: > On Thu, 8 Mar 2018, Matthew Wilcox wrote: > > On Thu, Mar 08, 2018 at 07:24:47AM +0100, Julia Lawall wrote: > > > Thanks. So it's OK to replace kmalloc and kzalloc, even though they > > > didn't previously consider vmalloc and even

[PATCH v3 0/3] Bluetooth: hci_qca: Add serdev support

2018-03-13 Thread Thierry Escande
Hi, This patchset enables the Qualcomm BT controller QCA6174 node in the device tree of the db820c board. This allows the bluetooth chipset to be probed and registered against the hci layer by using the serdev framework. This patchset also contains the documentation for the compatible string

[PATCH v3 3/3] Bluetooth: hci_qca: Add serdev support

2018-03-13 Thread Thierry Escande
Add support for Qualcomm serial slave devices. Probe the serial device, retrieve its maximum speed and register a new hci uart device. Signed-off-by: Thierry Escande --- v3: - Remove redundant call to gpiod_set_value() after devm_gpiod_get() - Check returned values

RE: [PATCH 2/3] dt-bindings: clock: Add bindings for ZynqMP clock driver

2018-03-13 Thread Jolly Shah
Hi Rob, > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Wednesday, March 07, 2018 5:20 PM > To: Jolly Shah > Cc: mturque...@baylibre.com; sb...@codeaurora.org; > michal.si...@xilinx.com; mark.rutl...@arm.com; linux-...@vger.kernel.org; >

[PATCH v3 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth

2018-03-13 Thread Thierry Escande
Add binding document for serial bluetooth chips using Qualcomm protocol. Signed-off-by: Thierry Escande --- .../devicetree/bindings/net/qualcomm-bluetooth.txt | 34 ++ 1 file changed, 34 insertions(+) create mode 100644

Re: [PATCH v4 4/6] ipc: Clamp msgmni and shmmni to the real IPCMNI limit

2018-03-13 Thread Waiman Long
On 03/13/2018 02:17 PM, Eric W. Biederman wrote: > Waiman Long writes: > >> A user can write arbitrary integer values to msgmni and shmmni sysctl >> parameters without getting error, but the actual limit is really >> IPCMNI (32k). This can mislead users as they think they can

[RT PATCH 1/2] Revert "block: blk-mq: Use swait"

2018-03-13 Thread Sebastian Andrzej Siewior
This reverts commit "block: blk-mq: Use swait". The issue remains but will be fixed differently. Signed-off-by: Sebastian Andrzej Siewior --- block/blk-core.c | 6 +++--- block/blk-mq.c | 8 include/linux/blkdev.h | 2 +- 3 files changed, 8

Re: [PATCH v3 01/11] PCI/P2PDMA: Support peer-to-peer memory

2018-03-13 Thread Logan Gunthorpe
On 12/03/18 09:28 PM, Sinan Kaya wrote: Maybe, dev parameter should also be struct pci_dev so that you can get rid of all to_pci_dev() calls in this code including find_parent_pci_dev() function. No, this was mentioned in v2. find_parent_pci_dev is necessary because the calling drivers

Re: [GIT PULL] bcm2835-dt-next-2018-03-13

2018-03-13 Thread Florian Fainelli
On 03/13/2018 10:30 AM, Eric Anholt wrote: > Hi Florian, > > The following changes since commit bcc76c4014dce4e3834dbd5b7f6593cbcfbfebe0: > > ARM: dts: bcm2835-rpi-zero-w: Enable OTG mode (2018-02-26 15:02:23 -0800) > > are available in the Git repository at: > >

Re: [PATCH v3 01/11] PCI/P2PDMA: Support peer-to-peer memory

2018-03-13 Thread Logan Gunthorpe
On 13/03/18 11:49 AM, Sinan Kaya wrote: And there's also the ACS problem which means if you want to use P2P on the root ports you'll have to disable ACS on the entire system. (Or preferably, the IOMMU groups need to get more sophisticated to allow for dynamic changes). Do you think you

Re: [PATCH v3 3/3] arm64: dts: renesas: Add LVDS decoder to R-Car V3M Eagle

2018-03-13 Thread Simon Horman
On Tue, Mar 13, 2018 at 03:30:25PM +0100, Jacopo Mondi wrote: > The R-Car V3M Eagle board includes a transparent THC63LVD1024 LVDS > decoder, connected to the on-chip LVDS encoder output on one side > and to HDMI encoder ADV7511w on the other one. > > As the decoder does not need any

Re: [3/3] irqchip/gic-v3: Bounds check redistributor accesses

2018-03-13 Thread Nishanth Menon
Marc, On Tue, Mar 13, 2018 at 9:21 AM, Marc Zyngier wrote: > Hi Lokesh, > > On 13/03/18 13:38, Lokesh Vutla wrote: >> Hi All, >> >> On Wednesday 11 October 2017 03:11 PM, Punit Agrawal wrote: >>> The kernel crashes while iterating over a redistributor that is >>>

Re: [PATCH v2 1/5] iommu/amd - Add debugfs support

2018-03-13 Thread Gary R Hook
On 03/13/2018 12:16 PM, Andy Shevchenko wrote: On Fri, Mar 9, 2018 at 2:50 AM, Gary R Hook wrote: + default n Redundant Roger that. +#include +#include +#include Keep in order? What order would that be? These few needed files are listed in the same order

Re: [PATCH v2 5/5] iommu/amd - Add a debugfs entry to specify a IOMMU device table entry

2018-03-13 Thread Gary R Hook
On 03/13/2018 12:20 PM, Andy Shevchenko wrote: + oboff += OSCNPRINTF("%02x:%02x:%x (%u / %04x)\n", + PCI_BUS_NUM(amd_iommu_devid), + PCI_SLOT(amd_iommu_devid), +

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

2018-03-13 Thread Jae Hyun Yoo
Hi Stef, Thanks for sharing your time to test it. That is expected result in v2. Previously in v1, it used delayed creation on core temperature group so it was okay if hwmon driver is registered when client CPU is powered down, but in v2, the driver should check resolved cores at probing

Re: [PATCH v4 4/6] ipc: Clamp msgmni and shmmni to the real IPCMNI limit

2018-03-13 Thread Eric W. Biederman
Waiman Long writes: > A user can write arbitrary integer values to msgmni and shmmni sysctl > parameters without getting error, but the actual limit is really > IPCMNI (32k). This can mislead users as they think they can get a > value that is not real. > > Enforcing the limit

Re: [RFC PATCH linux-next] evm: evm_hmac can be static

2018-03-13 Thread Mimi Zohar
On Wed, 2018-03-14 at 01:42 +0800, kbuild test robot wrote: > Fixes: c49fc264be98 ("evm: Move evm_hmac and evm_hash from evm_main.c to > evm_crypto.c") > Signed-off-by: Fengguang Wu Thanks! > --- > evm_crypto.c |4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH 3/3] Bluetooth: hci_qca: Add serdev support

2018-03-13 Thread Loic Poulain
On 13 March 2018 at 17:03, Thierry Escande wrote: > From: Thierry Escande > > Add support for Qualcomm serial slave devices. Probe the serial device, > retrieve its maximum speed and register a new hci uart device. > > Signed-off-by:

Re: [PATCH v2 1/3] KVM: X86: Provides userspace with a capability to not intercept MWAIT

2018-03-13 Thread Jim Mattson
Is there a need for a new API for yielding MONITOR/MWAIT to the guest? Why not just tie this to the guest CPUID.01H:ECX[MWAIT] being set? On Mon, Mar 12, 2018 at 4:53 AM, Wanpeng Li wrote: > From: Wanpeng Li > > Allowing a guest to execute MWAIT

Re: [PATCH v4 2/2] ARM: ftrace: Add MODULE_PLTS support

2018-03-13 Thread Alexander Sverdlin
Hi! On 13/03/18 18:51, Ard Biesheuvel wrote: >>> if (IS_ENABLED(CONFIG_ARM_MODULE_PLTS)) >>> module_plt_alloc_fixed(); >> Do you consider this a legal C code if without module-plts.o the function >> would not exist at all? >> That's too much relying on optimizer I think... >> > Yes, we rely

[v6 1/2] mm: disable interrupts while initializing deferred pages

2018-03-13 Thread Pavel Tatashin
Vlastimil Babka reported about a window issue during which when deferred pages are initialized, and the current version of on-demand initialization is finished, allocations may fail. While this is highly unlikely scenario, since this kind of allocation request must be large, and must come from

[v6 0/2] initialize pages on demand during boot

2018-03-13 Thread Pavel Tatashin
Change log: v5 - v6 - Fixed issues found by Andrew Morton: replaced cond_resched() with touch_nmi_watchdog(), instead of simply deleting it. - Removed useless pgdata_resize_lock_irq(), as regular pgdata_resize_lock() does exactly what is needed.

[v6 2/2] mm: initialize pages on demand during boot

2018-03-13 Thread Pavel Tatashin
Deferred page initialization allows the boot cpu to initialize a small subset of the system's pages early in boot, with other cpus doing the rest later on. It is, however, problematic to know how many pages the kernel needs during boot. Different modules and kernel parameters may change the

Re: [PATCH v4 2/2] ARM: ftrace: Add MODULE_PLTS support

2018-03-13 Thread Ard Biesheuvel
On 13 March 2018 at 18:24, Alexander Sverdlin wrote: > Hi! > > On 13/03/18 18:51, Ard Biesheuvel wrote: if (IS_ENABLED(CONFIG_ARM_MODULE_PLTS)) module_plt_alloc_fixed(); >>> Do you consider this a legal C code if without module-plts.o the function >>>

Re: [PATCH v4 2/2] ARM: ftrace: Add MODULE_PLTS support

2018-03-13 Thread Alexander Sverdlin
Hi! On 13/03/18 18:39, Ard Biesheuvel wrote: >> u32 get_module_plt(struct module *mod, unsigned long loc, Elf32_Addr >> val) >> { >> struct mod_plt_sec *pltsec = !in_init(mod, loc) ? >> >arch.core : >>

Re: [PATCH] debugobjects: avoid another unused variable warning.

2018-03-13 Thread Yang Shi
On 3/13/18 6:18 AM, Arnd Bergmann wrote: debug_objects_maxchecked is only updated in __debug_check_no_obj_freed(), and only read in debug_objects_maxchecked, unfortunately both of these are optional and depend on different Kconfig symbols. When both CONFIG_DEBUG_OBJECTS_FREE and

Re: [PATCH 0/3] irqchip: GIC kexec/kdump improvement and workarounds

2018-03-13 Thread Marc Zyngier
On 13/03/18 17:51, Mark Rutland wrote: > On Tue, Mar 13, 2018 at 05:21:00PM +, Marc Zyngier wrote: >> As kexec and kdump are getting used a bit more intensively, I've been >> made aware of a number of shortcomings. >> >> The main gripe is from folks trying to launch a kdump kernel from >>

Re: [bug, bisected] pfifo_fast causes packet reordering

2018-03-13 Thread Dave Taht
On Tue, Mar 13, 2018 at 11:24 AM, Jakob Unterwurzacher wrote: > During stress-testing our "ucan" USB/CAN adapter SocketCAN driver on Linux > v4.16-rc4-383-ged58d66f60b3 we observed that a small fraction of packets are > delivered out-of-order. > > We

[PATCH RFC 4/8] powerpc/64s: Add support for ori barrier_nospec

2018-03-13 Thread Michal Suchanek
Copypasta from rfi implementation Signed-off-by: Michal Suchanek --- arch/powerpc/include/asm/barrier.h| 4 ++-- arch/powerpc/include/asm/feature-fixups.h | 9 + arch/powerpc/include/asm/setup.h | 8 arch/powerpc/kernel/setup_64.c

[PATCH RFC 5/8] powerpc/64: Patch barrier_nospec in modules

2018-03-13 Thread Michal Suchanek
Copypasta from lwsync patching. Note that unlike RFI which is patched only in kernel the nospec state reflects settings at the time the module was loaded. Iterating all modules and re-patching every time the settings change is not implemented. Signed-off-by: Michal Suchanek

Re: [PATCH 00/11] RISC-V: Resolve the issue of loadable module on 64-bit

2018-03-13 Thread Palmer Dabbelt
On Tue, 13 Mar 2018 01:35:05 PDT (-0700), z...@andestech.com wrote: These patches resolve the some issues of loadable module. - symbol out of ranges - unknown relocation types The reference of external variable and function symbols cannot exceed 32-bit offset ranges in kernel module. The

[PATCH RFC 1/8] powerpc: Add barrier_nospec

2018-03-13 Thread Michal Suchanek
Copypasta from original gmb() and rfi implementation Signed-off-by: Michal Suchanek --- arch/powerpc/include/asm/barrier.h | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/powerpc/include/asm/barrier.h b/arch/powerpc/include/asm/barrier.h index

[PATCH RFC 2/8] powerpc: Use barrier_nospec in copy_from_user

2018-03-13 Thread Michal Suchanek
Coopypasta from x86. Signed-off-by: Michal Suchanek --- arch/powerpc/include/asm/uaccess.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/include/asm/uaccess.h b/arch/powerpc/include/asm/uaccess.h index 51bfeb8777f0..af9b0e731f46

[PATCH v3 1/3] arm64: dts: apq8096-db820c: enable bluetooth node

2018-03-13 Thread Thierry Escande
Add a new serial node for the Qualcomm BT controller QCA6174. This allows automatic probing and hci registration through the serdev framework instead of relying on the userspace helpers. Signed-off-by: Thierry Escande ---

[RT PATCH 2/2] block: blk-mq: move blk_queue_usage_counter_release() into process context

2018-03-13 Thread Sebastian Andrzej Siewior
| BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:914 | in_atomic(): 1, irqs_disabled(): 0, pid: 255, name: kworker/u257:6 | 5 locks held by kworker/u257:6/255: | #0: ("events_unbound"){.+.+.+}, at: [] process_one_work+0x171/0x5e0 | #1: ((>work)){+.+.+.}, at:

[GIT PULL] auxdisplay for v4.16-rc6

2018-03-13 Thread Miguel Ojeda
Hi Linus, Please pull these small changes to silence a few warnings in auxdisplay. This is my first pull request, so if there is anything wrong, please let me know! Also, note that for the moment my PGP/GPG key is only signed by 2 other kernel maintainers and that we did it over email/Skype. I

Re: [PATCH v4 1/6] sysctl: Add flags to support min/max range clamping

2018-03-13 Thread Waiman Long
On 03/13/2018 01:46 PM, Eric W. Biederman wrote: > Waiman Long writes: > >> When minimum/maximum values are specified for a sysctl parameter in >> the ctl_table structure with proc_dointvec_minmax() handler, update >> to that parameter will fail with error if the given value

[PATCH V2] perf/x86/intel/uncore: Querying number of CHAs from CAPID6 register

2018-03-13 Thread kan . liang
From: Kan Liang The number of CHAs is miscalculated on multi PCI domain systems on Skylake server. (From Kroening, Gary: For systems with a single PCI segment, it is sufficient to look for the bus number to change in order to determine that all of the CHa's have been

Re: [v5 1/2] mm: disable interrupts while initializing deferred pages

2018-03-13 Thread Andrew Morton
On Tue, 13 Mar 2018 12:04:30 -0400 Pavel Tatashin wrote: > > > > > --- a/mm/page_alloc.c > > > +++ b/mm/page_alloc.c > > > @@ -1506,7 +1506,6 @@ static void __init deferred_free_pages(int nid, int > > > zid, unsigned long pfn, > > > } else if (!(pfn &

RE: [PATCH v5 1/4] dt-bindings: firmware: Add bindings for ZynqMP firmware

2018-03-13 Thread Jolly Shah
> -Original Message- > From: Sudeep Holla [mailto:sudeep.ho...@arm.com] > Sent: Tuesday, March 13, 2018 3:16 AM > To: Jolly Shah > Cc: Sudeep Holla ; gre...@linuxfoundation.org; > m...@codeblueprint.co.uk; hkallwe...@gmail.com;

Re: [PATCH 2/2] hwmon: (ucd9000) Add debugfs attributes to provide mfr_status

2018-03-13 Thread Eddie James
On 03/10/2018 10:50 AM, Guenter Roeck wrote: On 03/09/2018 11:19 AM, Eddie James wrote: From: Christopher Bostic Expose the gpiN_fault fields of mfr_status as individual debugfs attributes. This provides a way for users to be easily notified of gpi faults. Also

[PATCH] hv_netvsc: Make sure out channel is fully opened on send

2018-03-13 Thread Mohammed Gamal
Dring high network traffic changes to network interface parameters such as number of channels or MTU can cause a kernel panic with a NULL pointer dereference. This is due to netvsc_device_remove() being called and deallocating the channel ring buffers, which can then be accessed by

Re: [PATCH v3 01/11] PCI/P2PDMA: Support peer-to-peer memory

2018-03-13 Thread Sinan Kaya
On 3/13/2018 2:44 PM, Logan Gunthorpe wrote: >> Do you think you can keep a pointer to the parent bridge instead of querying >> it >> via get_upstream_bridge_port() here so that we can reuse your >> pci_p2pdma_disable_acs() in the future. > > Keep a pointer where? pci_p2pdma_disable_acs() and

[PATCH net 2/2] vmxnet3: use correct flag to indicate LRO feature

2018-03-13 Thread Ronak Doshi
'Commit 45dac1d6ea04 ("vmxnet3: Changes for vmxnet3 adapter version 2 (fwd)")' introduced a flag "lro" in structure vmxnet3_adapter which is used to indicate whether LRO is enabled or not. However, the patch did not set the flag and hence it was never exercised. So, when LRO is enabled, it

[PATCH] iio/adc/nau7802: Improve unlocking of a mutex in nau7802_read_raw()

2018-03-13 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 13 Mar 2018 20:52:26 +0100 * Add a jump target so that a call of the function "mutex_unlock" is stored only once in this function implementation. * Replace two calls by goto statements. This issue was detected by using the

Re: [PATCH 2/2] hwmon: (ucd9000) Add debugfs attributes to provide mfr_status

2018-03-13 Thread Eddie James
On 03/13/2018 02:29 PM, Guenter Roeck wrote: On Tue, Mar 13, 2018 at 02:01:51PM -0500, Eddie James wrote: On 03/10/2018 10:50 AM, Guenter Roeck wrote: On 03/09/2018 11:19 AM, Eddie James wrote: From: Christopher Bostic Expose the gpiN_fault fields of

Re: [tip:locking/core 9/11] include/asm-generic/atomic-instrumented.h:288:24: sparse: cast truncates bits from constant value (100 becomes 0)

2018-03-13 Thread Luc Van Oostenryck
On Tue, Mar 13, 2018 at 07:08:06PM +0100, Peter Zijlstra wrote: > On Tue, Mar 13, 2018 at 07:00:17PM +0100, Luc Van Oostenryck wrote: > > The issue here is that sparse has a whole class of warnings that are > > given very early (here at expansion of constant expressions), before > > eliminating

Re: [PATCH RFC 1/8] powerpc: Add barrier_nospec

2018-03-13 Thread Peter Zijlstra
On Tue, Mar 13, 2018 at 07:32:59PM +0100, Michal Suchanek wrote: > Copypasta from original gmb() and rfi implementation Actual real changelogs would be very welcome. Seeing as I've not seen these mythical RFI patches, this leaves one quite puzzled :-)

[PATCH] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-13 Thread Peter Seiderer
Signed-off-by: Peter Seiderer --- drivers/staging/media/imx/imx-media-csi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index 5a195f80a24d..3a6a645b9dce 100644 ---

Re: [PATCH] net: dsa: drop some VLAs in switch.c

2018-03-13 Thread Florian Fainelli
On 03/13/2018 12:58 PM, Vivien Didelot wrote: > Hi Salvatore, > > Salvatore Mesoraca writes: > >> dsa_switch's num_ports is currently fixed to DSA_MAX_PORTS. So we avoid >> 2 VLAs[1] by using DSA_MAX_PORTS instead of ds->num_ports. >> >> [1]

Re: [PATCH] net: dsa: drop some VLAs in switch.c

2018-03-13 Thread Vivien Didelot
Hi Salvatore, Salvatore Mesoraca writes: > dsa_switch's num_ports is currently fixed to DSA_MAX_PORTS. So we avoid > 2 VLAs[1] by using DSA_MAX_PORTS instead of ds->num_ports. > > [1] https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Salvatore Mesoraca

Re: [RESEND PATCH] rsi: Remove stack VLA usage

2018-03-13 Thread Tobin C. Harding
On Sun, Mar 11, 2018 at 09:06:10PM -0500, Larry Finger wrote: > On 03/11/2018 08:43 PM, Tobin C. Harding wrote: > >The kernel would like to have all stack VLA usage removed[1]. rsi uses > >a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > >is defined using a magic number.

Re: perf-core build fails on powerpc

2018-03-13 Thread Sukadev Bhattiprolu
John Garry [john.ga...@huawei.com] wrote: > On 13/03/2018 19:17, Sukadev Bhattiprolu wrote: > > > > > > Building perf on Powerpc seems broken when using Arnaldo's perf/core branch > > with HEAD as: > > > > 1b442ed ("perf test: Fix exit code for record+probe_libc_inet_pton.sh") > > > > It

Re: linux-next: Tree for Mar 13

2018-03-13 Thread Stephen Rothwell
Hi Mike, On Tue, 13 Mar 2018 11:57:40 -0400 Mike Snitzer wrote: > > I had to revert the following commits to get this kernel to build > (otherwise I got macro expansion errors, using RHEL7 > gcc-4.8.5-28.el7.x86_64): Yeah, I reported that earlier (216 of my 244 builds failed

Re: [Intel-gfx] [PATCH] [v2] drm/i915/pmu: avoid -Wmaybe-uninitialized warning

2018-03-13 Thread Arnd Bergmann
On Tue, Mar 13, 2018 at 6:46 PM, Tvrtko Ursulin wrote: > > On 13/03/2018 16:19, Arnd Bergmann wrote: >> >> The conditional spinlock confuses gcc into thinking the 'flags' value >> might contain uninitialized data: >> >> drivers/gpu/drm/i915/i915_pmu.c: In function

Re: [RT PATCH 2/2] block: blk-mq: move blk_queue_usage_counter_release() into process context

2018-03-13 Thread Peter Zijlstra
On Tue, Mar 13, 2018 at 07:42:41PM +0100, Sebastian Andrzej Siewior wrote: > +static void blk_queue_usage_counter_release_swork(struct swork_event *sev) > +{ > + struct request_queue *q = > + container_of(sev, struct request_queue, mq_pcpu_wake); > + > +

Re: [v5 1/2] mm: disable interrupts while initializing deferred pages

2018-03-13 Thread Andrew Morton
On Tue, 13 Mar 2018 15:45:46 -0400 Pavel Tatashin wrote: > > > > > > We must remove cond_resched() because we can't sleep anymore. They were > > > added to fight NMI timeouts, so I will replace them with > > > touch_nmi_watchdog() in a follow-up fix. > > > > This

Re: [PATCH v2] usb: musb: Fix external abort in musb_remove on omap2430

2018-03-13 Thread Bin Liu
Hi, On Mon, Mar 12, 2018 at 11:30:39PM +0100, Merlijn Wajer wrote: > Hi Bin, > > On 09/03/18 15:11, Bin Liu wrote: > > Hi, > > > > On Thu, Mar 08, 2018 at 11:19:48PM +0100, Merlijn Wajer wrote: > >> This fixes an oops on unbind / module unload (on the musb omap2430 > >> platform). > >> > >>

Re: [RESEND] rsi: Remove stack VLA usage

2018-03-13 Thread tcharding
On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: > tcharding wrote: > > > The kernel would like to have all stack VLA usage removed[1]. rsi uses > > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > > is defined using a magic number. We can

[PATCH] crypto: arm,arm64 - Fix random regeneration of S_shipped

2018-03-13 Thread Leonard Crestez
The decision to rebuild .S_shipped is made based on the relative timestamps of .S_shipped and .pl files but git makes this essentially random. This means that the perl script might run anyway (usually at most once per checkout), defeating the whole purpose of _shipped. Fix by skipping the rule

Re: [3/3] irqchip/gic-v3: Bounds check redistributor accesses

2018-03-13 Thread Marc Zyngier
On Tue, 13 Mar 2018 18:49:44 +, Nishanth Menon wrote: > > Marc, > > On Tue, Mar 13, 2018 at 9:21 AM, Marc Zyngier wrote: > > Hi Lokesh, > > > > On 13/03/18 13:38, Lokesh Vutla wrote: > >> Hi All, > >> > >> On Wednesday 11 October 2017 03:11 PM, Punit Agrawal wrote: >

Re: [PATCH 3/8] gpio: pci-idio-16: Implement get_multiple callback

2018-03-13 Thread William Breathitt Gray
On Tue, Mar 13, 2018 at 06:04:33PM +0200, Andy Shevchenko wrote: >On Mon, Mar 12, 2018 at 10:49 PM, William Breathitt Gray > wrote: > >> +static int idio_16_gpio_get_multiple(struct gpio_chip *chip, >> + unsigned long *mask, unsigned long *bits) >> +{ > > >> +

Re: [2/3] mwifiex: support sysfs initiated device coredump

2018-03-13 Thread Marcel Holtmann
Hi Arend, > Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") > it is possible to initiate a device coredump from user-space. This > patch adds support for it adding the .coredump() driver callback. > As there is no longer a need to initiate it through debugfs

Re: [2/3] mwifiex: support sysfs initiated device coredump

2018-03-13 Thread Arend van Spriel
On 3/13/2018 9:19 PM, Marcel Holtmann wrote: Hi Arend, Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a device coredump from user-space. This patch adds support for it adding the .coredump() driver callback. As there is no longer a need to

Re: [PATCH v2 1/5] iommu/amd - Add debugfs support

2018-03-13 Thread Andy Shevchenko
On Tue, Mar 13, 2018 at 8:54 PM, Gary R Hook wrote: > On 03/13/2018 12:16 PM, Andy Shevchenko wrote: >> On Fri, Mar 9, 2018 at 2:50 AM, Gary R Hook wrote: >>> +#include >>> +#include >>> +#include >> >> >> Keep in order? > What order would that be?

Re: [PATCH ghak21 V2 3/4] audit: add refused symlink to audit_names

2018-03-13 Thread Paul Moore
On Tue, Mar 13, 2018 at 6:52 AM, Richard Guy Briggs wrote: > On 2018-03-13 11:38, Steve Grubb wrote: >> On Tue, 13 Mar 2018 06:11:08 -0400 >> Richard Guy Briggs wrote: >> >> > On 2018-03-13 09:35, Steve Grubb wrote: >> > > On Mon, 12 Mar 2018 11:52:56 -0400 >> >

RE: [PATCH V2] perf/x86/intel/uncore: Querying number of CHAs from CAPID6 register

2018-03-13 Thread Kroening, Gary
I've tested this patch on the same set of hubless (single-segment) and scalable (segment-per-socket) configurations as for Kan's version 1. As far as we can tell this will also work for Cascade Lake, but will need revisiting for Ice Lake. Thanks. Gary > -Original Message- > From:

Re: [PATCH V2] perf/x86/intel/uncore: Querying number of CHAs from CAPID6 register

2018-03-13 Thread Andy Shevchenko
On Tue, Mar 13, 2018 at 8:51 PM, wrote: > From: Kan Liang > > The number of CHAs is miscalculated on multi PCI domain systems on > Skylake server. > > (From Kroening, Gary: > > For systems with a single PCI segment, it is sufficient to look

Re: [PATCH v2] workqueue: use put_device() instead of kfree()

2018-03-13 Thread Tejun Heo
On Tue, Mar 06, 2018 at 03:35:43PM +0530, Arvind Yadav wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized in this function instead. > > Signed-off-by: Arvind Yadav

Re: linux-next: build warning after merge of the net-next tree

2018-03-13 Thread Gustavo A. R. Silva
On 03/13/2018 10:33 AM, David Miller wrote: From: "Gustavo A. R. Silva" Date: Tue, 13 Mar 2018 06:46:24 -0500 Hi Stephen, On 03/13/2018 01:11 AM, Stephen Rothwell wrote: Hi all, After merging the net-next tree, today's linux-next build (sparc defconfig) produced

Re: [PATCH v4 4/6] ipc: Clamp msgmni and shmmni to the real IPCMNI limit

2018-03-13 Thread Eric W. Biederman
Waiman Long writes: > On 03/13/2018 02:17 PM, Eric W. Biederman wrote: >> Waiman Long writes: >> >>> A user can write arbitrary integer values to msgmni and shmmni sysctl >>> parameters without getting error, but the actual limit is really >>> IPCMNI

Re: [PATCH] libata: add refcounting to ata_host

2018-03-13 Thread Tejun Heo
On Fri, Mar 09, 2018 at 08:34:41AM +, Taras Kondratiuk wrote: > After commit 9a6d6a2ddabb ("ata: make ata port as parent device of scsi > host") manual driver unbind/remove causes use-after-free. > > Unbind unconditionally invokes devres_release_all() which calls > ata_host_release() and

[PATCH] regulator: gpio: Fix some error handling paths in 'gpio_regulator_probe()'

2018-03-13 Thread Christophe JAILLET
Re-order error handling code and gotos to avoid leaks in error handling paths. Fixes: 9f946099fe19 ("regulator: gpio: fix parsing of gpio list") Signed-off-by: Christophe JAILLET --- drivers/regulator/gpio-regulator.c | 16 +++- 1 file changed, 7

Re: [PATCH 1/8] Uprobe: Export vaddr <-> offset conversion functions

2018-03-13 Thread Jerome Glisse
On Tue, Mar 13, 2018 at 06:25:56PM +0530, Ravi Bangoria wrote: > No functionality changes. > > Signed-off-by: Ravi Bangoria Reviewed-by: Jérôme Glisse > --- > include/linux/mm.h | 12 > kernel/events/uprobes.c | 10

[PATCH] clk: rockchip: Add 1.6GHz PLL rate

2018-03-13 Thread Derek Basehore
We need this rate to generate 100, 200, and 228.57MHz from the same PLL. 228.57MHz is useful for a pixel clock when the VPLL is used for and external display. Signed-off-by: Derek Basehore --- drivers/clk/rockchip/clk-rk3399.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH 2/8] mm: Prefix vma_ to vaddr_to_offset() and offset_to_vaddr()

2018-03-13 Thread Jerome Glisse
On Tue, Mar 13, 2018 at 06:25:57PM +0530, Ravi Bangoria wrote: > No functionality changes. > > Signed-off-by: Ravi Bangoria Doing this with coccinelle would have been nicer but this is small enough to review without too much fatigue :) Reviewed-by: Jérôme

Re: [PATCH 3/8] Uprobe: Rename map_info to uprobe_map_info

2018-03-13 Thread Jerome Glisse
On Tue, Mar 13, 2018 at 06:25:58PM +0530, Ravi Bangoria wrote: > map_info is very generic name, rename it to uprobe_map_info. > Renaming will help to export this structure outside of the > file. > > Also rename free_map_info() to uprobe_free_map_info() and > build_map_info() to

Re: [PATCH 4/8] Uprobe: Export uprobe_map_info along with uprobe_{build/free}_map_info()

2018-03-13 Thread Jerome Glisse
On Tue, Mar 13, 2018 at 06:25:59PM +0530, Ravi Bangoria wrote: > These exported data structure and functions will be used by other > files in later patches. > > No functionality changes. > > Signed-off-by: Ravi Bangoria Reviewed-by: Jérôme Glisse

Re: [v5 1/2] mm: disable interrupts while initializing deferred pages

2018-03-13 Thread Pavel Tatashin
> Soft lockup: kernel has run for too long without rescheduling > Hard lockup: kernel has run for too long with interrupts disabled > > Both of these are detected by the NMI watchdog handler. > > 9b6e63cbf85b89b2d fixes a soft lockup by adding a manual rescheduling > point. Replacing that with

Re: [PATCH v3 01/11] PCI/P2PDMA: Support peer-to-peer memory

2018-03-13 Thread Logan Gunthorpe
On 13/03/18 01:53 PM, Sinan Kaya wrote: > I agree disabling globally would be bad. Somebody can always say I have > ten switches on my system. I want to do peer-to-peer on one switch only. Now, > this change weakened security for the other switches that I had no intention > with doing P2P. > >

Re: dcache: remove trylock loops (was Re: [BUG] lock_parent() breakage when used from shrink_dentry_list())

2018-03-13 Thread John Ogness
On 2018-03-12, Al Viro wrote: >> If someone else has grabbed a reference, it shouldn't be added to the >> lru list. Only decremented. >> >> if (entry->d_lockref.count == 1) > > Nah, better handle that in retain_dentry() itself. See updated > #work.dcache. > > + if

Re: [RESEND RFC] translate_pid API

2018-03-13 Thread Jann Horn
On Mon, Mar 12, 2018 at 10:18 AM, wrote: > Resending the RFC with participants of previous discussions > in the list. > > Following patch which is a variation of a solution discussed > in https://lwn.net/Articles/736330/ provides the users of > pid namespace,

Re: linux-next: Tree for Mar 13

2018-03-13 Thread Stephen Rothwell
Hi Dominik, On Tue, 13 Mar 2018 18:52:05 +0100 Dominik Brodowski wrote: > > would it be possible to have > >https://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux.git > syscalls-next > > added to -next? This will probably only be for one or two release

Re: [PATCH V2] perf/x86/intel/uncore: Querying number of CHAs from CAPID6 register

2018-03-13 Thread Liang, Kan
On 3/13/2018 4:24 PM, Kroening, Gary wrote: I've tested this patch on the same set of hubless (single-segment) and scalable (segment-per-socket) configurations as for Kan's version 1. As far as we can tell this will also work for Cascade Lake, but will need revisiting for Ice Lake. For

[PATCH v3 2/2] kbuild: Don't mess with the .cache.mk when root

2018-03-13 Thread Douglas Anderson
As pointed out by Masahiro Yamada people often run "sudo make install" or "sudo make modules_install". In theory, that could cause a cache file (or the directory containing it) to be created by root. After doing this then subsequent invocations to make would yell with a whole bunch of warnings

RE: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-13 Thread Mario.Limonciello
> -Original Message- > From: Dominik Brodowski [mailto:li...@dominikbrodowski.net] > Sent: Tuesday, March 13, 2018 1:51 PM > To: Limonciello, Mario > Cc: dvh...@infradead.org; platform-driver-...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re:

  1   2   3   4   5   6   7   8   9   10   >