Re: [RFC PATCH v3 1/3] ima: extend clone() with IMA namespace support

2018-04-18 Thread Eric W. Biederman
Mimi Zohar writes: > On Wed, 2018-04-18 at 09:09 -0700, John Johansen wrote: >> On 04/13/2018 09:25 AM, Mimi Zohar wrote: >> > [Cc'ing John Johansen] >> > >> > On Tue, 2018-03-27 at 18:01 -0500, Eric W. Biederman wrote: >> > [...] >> >> As such I expect the best way to

Re: [PATCH 2/2] selftests/filesystems: remove Makefile warning

2018-04-18 Thread Anders Roxell
On 18 April 2018 at 16:54, Shuah Khan wrote: > On 04/18/2018 01:52 AM, Anders Roxell wrote: >> When overriding the 'clean' target make throws up warnings: >> Makefile:9: warning: overriding recipe for target 'clean' >> ../lib.mk:98: warning: ignoring old recipe for target

Re: WARNING: suspicious RCU usage in fib6_info_alloc

2018-04-18 Thread David Ahern
On 4/18/18 3:02 PM, syzbot wrote: > stack backtrace: > CPU: 1 PID: 25 Comm: kworker/1:1 Not tainted 4.16.0+ #5 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS > Google 01/01/2011 > Workqueue: ipv6_addrconf addrconf_dad_work > Call Trace: >  __dump_stack

Re: WARNING: suspicious RCU usage in fib6_info_alloc

2018-04-18 Thread Eric Dumazet
On 04/18/2018 02:04 PM, David Ahern wrote: > On 4/18/18 3:02 PM, syzbot wrote: >> stack backtrace: >> CPU: 1 PID: 25 Comm: kworker/1:1 Not tainted 4.16.0+ #5 >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS >> Google 01/01/2011 >> Workqueue: ipv6_addrconf

Re: [PATCH v4 2/3] dt-bindings: power: supply: qcom_bms: Add bindings

2018-04-18 Thread Rob Herring
On Sun, Apr 15, 2018 at 7:55 AM, Craig Tatlor wrote: > On Fri, Apr 13, 2018 at 11:35:27AM -0500, Rob Herring wrote: >> On Sat, Apr 07, 2018 at 06:57:45PM +0100, Craig Tatlor wrote: >> > Add bindings for the Qualcomm Battery Monitoring system. >> > >> > Signed-off-by: Craig

Re: [v2,2/2] regulator: add QCOM RPMh regulator driver

2018-04-18 Thread David Collins
On 04/17/2018 12:47 PM, Matthias Kaehlcke wrote: > On Tue, Apr 17, 2018 at 12:15:18PM -0700, David Collins wrote: >> On 04/17/2018 11:23 AM, Matthias Kaehlcke wrote: >>> On Fri, Apr 13, 2018 at 07:50:35PM -0700, David Collins wrote: [...] +static const u32

Re: [RFC PATCH v3 1/3] ima: extend clone() with IMA namespace support

2018-04-18 Thread John Johansen
On 04/18/2018 01:12 PM, Eric W. Biederman wrote: > Mimi Zohar writes: > >> On Wed, 2018-04-18 at 09:09 -0700, John Johansen wrote: >>> On 04/13/2018 09:25 AM, Mimi Zohar wrote: [Cc'ing John Johansen] On Tue, 2018-03-27 at 18:01 -0500, Eric W. Biederman

Re: [PATCH net-next 2/2] netns: isolate seqnums to use per-netns locks

2018-04-18 Thread Christian Brauner
On Wed, Apr 18, 2018 at 11:55:52AM -0500, Eric W. Biederman wrote: > Christian Brauner writes: > > > Now that it's possible to have a different set of uevents in different > > network namespaces, per-network namespace uevent sequence numbers are > > introduced. This

Re: [PATCH v3 0/2] IB/hfi1: Cleanup PCIe link configuration

2018-04-18 Thread Dennis Dalessandro
On 4/17/2018 10:32 AM, Bjorn Helgaas wrote: [+cc Bartlomiej, who recently changed do_pcie_gen3_transition(), LKML] On Mon, Apr 16, 2018 at 11:53:43PM -0700, Christoph Hellwig wrote: On Mon, Apr 16, 2018 at 07:28:23PM -0500, Frederick Lawler wrote: The IB/hfi1 driver uses custom macros to

Re: [PATCH v2 1/4] MIPS: memset.S: Fix clobber of v1 in last_fixup

2018-04-18 Thread James Hogan
On Tue, Apr 17, 2018 at 04:40:00PM +0100, Matt Redfearn wrote: > The label .Llast_fixup\@ is jumped to on page fault within the final > byte set loop of memset (on < MIPSR6 architectures). For some reason, in > this fault handler, the v1 register is randomly set to a2 & STORMASK. > This clobbers

Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

2018-04-18 Thread Jae Hyun Yoo
On 4/18/2018 7:32 AM, Rob Herring wrote: On Tue, Apr 17, 2018 at 3:40 PM, Jae Hyun Yoo wrote: On 4/16/2018 4:51 PM, Jae Hyun Yoo wrote: On 4/16/2018 4:22 PM, Jae Hyun Yoo wrote: On 4/16/2018 11:14 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:32:09AM

Re: [RFC PATCH v3 1/3] ima: extend clone() with IMA namespace support

2018-04-18 Thread Mimi Zohar
On Wed, 2018-04-18 at 15:12 -0500, Eric W. Biederman wrote: > Mimi Zohar writes: > > > On Wed, 2018-04-18 at 09:09 -0700, John Johansen wrote: > >> On 04/13/2018 09:25 AM, Mimi Zohar wrote: > >> > [Cc'ing John Johansen] > >> > > >> > On Tue, 2018-03-27 at 18:01 -0500,

Re: [PATCH] net: don't use kvzalloc for DMA memory

2018-04-18 Thread Eric Dumazet
On 04/18/2018 10:55 AM, Michael S. Tsirkin wrote: > Imagine you want to pass some data to card. > Natural thing is to just put it in a variable and start DMA. > However DMA API disallows stack access nowdays, > so it's natural to put this within struct device. > > See e.g. > > commit

Re: [PATCH 09/13] imx274: get rid of mode_index

2018-04-18 Thread kbuild test robot
Hi Luca, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc1 next-20180418] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH 1/2] MIPS: BCM47XX: Add support for Netgear WNR1000 V3

2018-04-18 Thread James Hogan
On Sun, Apr 08, 2018 at 10:57:32PM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > This adds support for detecting this model board and registers some LEDs > and buttons. > > There are two uncommon things regarding this device: > 1) It can use two different "board_id" ID

Screen brightness behaves _very_ differently across different machines

2018-04-18 Thread Pavel Machek
Hi! I tried to run auto brightness settings tuned for Nokia N900 on Droid 4, and results were not nice. So I tried matching brightness between Nokia N900 and Droid 4, and I have a reason: Brightness 1 on n900 corresponds to brightness _50_ on droid 4. | n900 | d4 | |1 | 50 | |2 | 70

Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

2018-04-18 Thread Rob Herring
On Wed, Apr 18, 2018 at 3:28 PM, Jae Hyun Yoo wrote: > On 4/18/2018 7:32 AM, Rob Herring wrote: >> >> On Tue, Apr 17, 2018 at 3:40 PM, Jae Hyun Yoo >> wrote: >>> >>> On 4/16/2018 4:51 PM, Jae Hyun Yoo wrote: On 4/16/2018

Re: [PATCH v2 1/6] MIPS: perf: More robustly probe for the presence of per-tc counters

2018-04-18 Thread James Hogan
On Thu, Apr 12, 2018 at 10:36:21AM +0100, Matt Redfearn wrote: > Processors implementing the MIPS MT ASE may have performance counters > implemented per core or per TC. Processors implemented by MIPS > Technologies signify presence per TC through a bit in the implementation > specific Config7

RE: linux-next: build warning after merge of the scsi tree

2018-04-18 Thread Long Li
> Subject: linux-next: build warning after merge of the scsi tree > > Hi James, > > After merging the scsi tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > drivers/scsi/storvsc_drv.c: In function 'storvsc_do_io': > drivers/scsi/storvsc_drv.c:1402:1: warning: the

Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

2018-04-18 Thread Jae Hyun Yoo
On 4/18/2018 2:28 PM, Rob Herring wrote: On Wed, Apr 18, 2018 at 3:28 PM, Jae Hyun Yoo wrote: On 4/18/2018 7:32 AM, Rob Herring wrote: On Tue, Apr 17, 2018 at 3:40 PM, Jae Hyun Yoo wrote: On 4/16/2018 4:51 PM, Jae Hyun Yoo wrote:

Re: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

2018-04-18 Thread Mehta, Sohil
On Wed, 2018-04-18 at 08:31 +, Yang, Shunyong wrote: > Maybe the original design is to call debugfs_initialized() before > calling debugfs_create_xxx()? I am unaware of the original design. Someone else would probably have more context. However, looking at other places in the kernel where

Re: [RFC PATCH] fs: introduce ST_HUGE flag and set it to tmpfs and hugetlbfs

2018-04-18 Thread Mike Kravetz
On 04/17/2018 02:08 PM, Yang Shi wrote: > And, set the flag for hugetlbfs as well to keep the consistency, and the > applications don't have to know what filesystem is used to use huge > page, just need to check ST_HUGE flag. For hugetlbfs, setting such a flag would be for consistency only.

Re: [do_execve] attempted to set unsupported pgprot

2018-04-18 Thread Dave Hansen
On 04/18/2018 12:59 PM, Andrew Morton wrote: >> [ 12.348499] [ cut here ] >> [ 12.349193] attempted to set unsupported pgprot: 8025 bits: >> 8000 supported: 7fff >> [ 12.350792] WARNING: CPU: 0 PID: 1 at

Re: [PATCH driver-core 1/2] test_firmware: Install all scripts

2018-04-18 Thread Luis R. Rodriguez
On Wed, Apr 04, 2018 at 10:37:13PM +0200, Ben Hutchings wrote: > List all the scripts invoked by fw_run_tests.sh, so that > "make TARGETS=firmware install" keeps working. > > Fixes: 29a1c00ce1df8 ("test_firmware: add simple firmware firmware test ...") > Fixes: b3cf21fae1fe0 ("test_firmware: test

Re: [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try

2018-04-18 Thread Luis R. Rodriguez
On Wed, Apr 04, 2018 at 10:38:49PM +0200, Ben Hutchings wrote: > Commit 65c79230576 tried to clear the custom firmware path on exit by > writing a single space to the firmware_class.path parameter. This > doesn't work because nothing strips this space from the value stored > and

Re: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

2018-04-18 Thread Hook, Gary
On 4/18/2018 4:16 PM, Mehta, Sohil wrote: On Wed, 2018-04-18 at 08:31 +, Yang, Shunyong wrote: Maybe the original design is to call debugfs_initialized() before calling debugfs_create_xxx()? I am unaware of the original design. Someone else would probably have more context. However,

Re: [RFC PATCH] fs: introduce ST_HUGE flag and set it to tmpfs and hugetlbfs

2018-04-18 Thread Yang Shi
On 4/18/18 1:26 PM, Mike Kravetz wrote: On 04/17/2018 02:08 PM, Yang Shi wrote: And, set the flag for hugetlbfs as well to keep the consistency, and the applications don't have to know what filesystem is used to use huge page, just need to check ST_HUGE flag. For hugetlbfs, setting such a

Adding modules-linus branch to linux-next

2018-04-18 Thread Jessica Yu
Hi Stephen, Could you please add the modules-linus branch at: git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux.git modules-linus to linux-next? The branch will contain rc fixes intended for the current release. A good name for it might be modules-current. Thanks! Jessica

WARNING: suspicious RCU usage in fib6_info_alloc

2018-04-18 Thread syzbot
Hello, syzbot hit the following crash on net-next commit 0565de29cbd65b378147d36f9642f93a046240dc (Wed Apr 18 03:41:18 2018 +) Merge branch 'ipv6-Separate-data-structures-for-FIB-and-data-path' syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=2add39b05179b31f912f So far

RE: issues with suspend on Dell XPS 13 2-in-1

2018-04-18 Thread Mario.Limonciello
> -Original Message- > From: Pandruvada, Srinivas [mailto:srinivas.pandruv...@intel.com] > Sent: Tuesday, April 17, 2018 6:00 PM > To: linux-a...@vger.kernel.org; linux-kernel@vger.kernel.org; > dgilm...@redhat.com; Limonciello, Mario > Subject: Re: issues with suspend on Dell XPS 13

Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-18 Thread Andrew Morton
On Wed, 18 Apr 2018 10:26:36 +0900 Minchan Kim wrote: > Hi Andrew, > > On Tue, Apr 17, 2018 at 02:59:21PM -0700, Andrew Morton wrote: > > On Mon, 16 Apr 2018 18:09:46 +0900 Minchan Kim wrote: > > > > > zRam as swap is useful for small memory device.

Re: [PATCH v3 1/6] ilog2: create truly constant version for sparse

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 1:12 AM, Martin Wilck wrote: > > No, it doesn't (gcc 7.3.0). -> https://paste.opensuse.org/27471594 > It doesn't even warn on an expression like this: > > #define SIZE (1<<10) > static int foo[ilog2(SIZE)]; Ok, I think this is the "random gcc versions

Re: [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-04-18 Thread David Collins
On 04/17/2018 01:06 PM, Doug Anderson wrote: > [...] >> +- qcom,regulator-initial-voltage > > nit: regulator framework tends to include "microvolt" in the name to > make it really obvious in the device tree what the units are. Can you > do that too? Sure, I'll change the name to be:

Re: [PATCH] net: don't use kvzalloc for DMA memory

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 09:05:54AM -0700, Eric Dumazet wrote: > > > On 04/18/2018 07:34 AM, Mikulas Patocka wrote: > > The patch 74d332c13b21 changes alloc_netdev_mqs to use vzalloc if kzalloc > > fails (later patches change it to kvzalloc). > > > > The problem with this is that if the vzalloc

Re: [PATCH v3] module: Fix display of wrong module .text address

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 6:21 AM, Jessica Yu wrote: > > Otherwise I can take this up my tree. Take it through your tree. It's not some recent thing that stops people from testing other stuff (which is when I tend to try to take it directly just to short-circuit any delays), so

Re: [PATCH v2] docs: kernel-parameters.txt: Fix whitespace

2018-04-18 Thread Thymo van Beers
On Mon, Apr 16, 2018 at 03:03:47PM -0700, Randy Dunlap wrote: > On 04/16/18 14:49, Thymo van Beers wrote: > > Some lines used spaces instead of tabs at line start. > > This can cause mangled lines in editors due to inconsistency. > > > > Replace spaces for tabs where appropriate. > > > >

RE: [Patch v3 2/6] cifs: Allocate validate negotiation request through kmalloc

2018-04-18 Thread Long Li
> Subject: Re: [Patch v3 2/6] cifs: Allocate validate negotiation request > through > kmalloc > > On 4/18/2018 1:11 PM, Long Li wrote: > >> Subject: Re: [Patch v3 2/6] cifs: Allocate validate negotiation > >> request through kmalloc > >> > >> On 4/18/2018 9:08 AM, David Laight wrote: > >>> From:

[PATCH 0/6] arm64: untag user pointers passed to the kernel

2018-04-18 Thread Andrey Konovalov
Hi! arm64 has a feature called Top Byte Ignore, which allows to embed pointer tags into the top byte of each pointer. Userspace programs (such as HWASan, a memory debugging tool [1]) might use this feature and pass tagged user pointers to the kernel through syscalls or other interfaces. This

[PATCH 2/6] uaccess: add untagged_addr definition for other arches

2018-04-18 Thread Andrey Konovalov
To allow arm64 syscalls accept tagged pointers from userspace, we must untag them when they are passed to the kernel. Since untagging is done in generic parts of the kernel (like the mm subsystem), the untagged_addr macro should be defined for all architectures. Define it as a noop for other

[PATCH 3/6] arm64: untag user addresses in copy_from_user and others

2018-04-18 Thread Andrey Konovalov
copy_from_user (and a few other similar functions) are used to copy data from user memory into the kernel memory or vice versa. Since a user can provided a tagged pointer to one of the syscalls that use copy_from_user, we need to correctly handle such pointers. Do this by untagging user pointers

[PATCH 6/6] arm64: update Documentation/arm64/tagged-pointers.txt

2018-04-18 Thread Andrey Konovalov
Add a note that work on passing tagged user pointers to the kernel via syscalls has started, but might not be complete yet. Signed-off-by: Andrey Konovalov --- Documentation/arm64/tagged-pointers.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [patch v2] mm, oom: fix concurrent munlock and oom reaper unmap

2018-04-18 Thread David Rientjes
On Wed, 18 Apr 2018, Michal Hocko wrote: > > Since exit_mmap() is done without the protection of mm->mmap_sem, it is > > possible for the oom reaper to concurrently operate on an mm until > > MMF_OOM_SKIP is set. > > > > This allows munlock_vma_pages_all() to concurrently run while the oom > >

Re: [PATCH v5 02/10] dt-bindings: introduce RPMH RSC bindings for Qualcomm SoCs

2018-04-18 Thread Lina Iyer
On Mon, Apr 16 2018 at 00:01 -0600, Stephen Boyd wrote: Quoting Lina Iyer (2018-04-16 09:08:18) On Fri, Apr 13 2018 at 16:40 -0600, Stephen Boyd wrote: >Well it seems like an RSC contains many DRVs and those DRVs contain many >TCSes. This is what I get after talking with Bjorn on IRC. > >

[PATCH net] vmxnet3: fix incorrect dereference when rxvlan is disabled

2018-04-18 Thread Ronak Doshi
vmxnet3_get_hdr_len() is used to calculate the header length which in turn is used to calculate the gso_size for skb. When rxvlan offload is disabled, vlan tag is present in the header and the function references ip header from sizeof(ethhdr) and leads to incorrect pointer reference. This patch

Re: [PATCH 2/2] selftests: sparc64: char: Selftest for privileged ADI driver

2018-04-18 Thread Shuah Khan
Hi Tom, On 04/18/2018 10:29 AM, Tom Hromatka wrote: > Add a selftest for the sparc64 privileged ADI driver. These > tests verify the read(), pread(), write(), pwrite(), and seek() > functionality of the driver. The tests also report simple > performance statistics: > > Syscall Call

Re: [do_execve] attempted to set unsupported pgprot

2018-04-18 Thread Andrew Morton
On Wed, 18 Apr 2018 21:59:33 +0800 Fengguang Wu wrote: > Hello, > > FYI this happens in mainline kernel 4.17.0-rc1. > It looks like a new regression. > > It occurs in 4 out of 4 boots. > > [ 12.345562] Write protecting the kernel text: 14376k > [ 12.346649] Write

Re: [PATCH 2/2] selftests: sparc64: char: Selftest for privileged ADI driver

2018-04-18 Thread Tom Hromatka
On 04/18/2018 01:58 PM, Shuah Khan wrote: Hi Tom, On 04/18/2018 10:29 AM, Tom Hromatka wrote: Add a selftest for the sparc64 privileged ADI driver. These tests verify the read(), pread(), write(), pwrite(), and seek() functionality of the driver. The tests also report simple performance

Re: [RFC PATCH v2 3/4] acpi: apei: Do not panic() when correctable errors are marked as fatal.

2018-04-18 Thread Borislav Petkov
On Mon, Apr 16, 2018 at 04:59:02PM -0500, Alexandru Gagniuc wrote: > Firmware is evil: > - ACPI was created to "try and make the 'ACPI' extensions somehow > Windows specific" in order to "work well with NT and not the others > even if they are open" > - EFI was created to hide "secret"

Re: [RFC PATCH v2 4/4] acpi: apei: Warn when GHES marks correctable errors as "fatal"

2018-04-18 Thread Borislav Petkov
On Mon, Apr 16, 2018 at 04:59:03PM -0500, Alexandru Gagniuc wrote: > There seems to be a culture amongst BIOS teams to want to crash the > OS when an error can't be handled in firmware. Marking GHES errors as > "fatal" is a very common way to do this. > > However, a number of errors reported by

Re: [PATCH] net: don't use kvzalloc for DMA memory

2018-04-18 Thread Mikulas Patocka
On Wed, 18 Apr 2018, David Miller wrote: > From: Eric Dumazet > Date: Wed, 18 Apr 2018 09:51:25 -0700 > > > I suggest that virtio_net clearly identifies which part needs a specific > > allocation > > and does its itself, instead of abusing the netdev_priv storage. > >

Re: [PATCH v2] vmw_balloon: fixing double free when batching mode is off

2018-04-18 Thread Nadav Amit
Oleksandr Natalenko wrote: > Hello. > > On Fri, Mar 23, 2018 at 9:42 AM, Oleksandr Natalenko > wrote: >>> Actually, rechecking the bug description, I might have rushed. The bug that >>> I encountered is related to the vunmap() but it is only caused

Re: linux-next: build failure after merge of the arm-current tree

2018-04-18 Thread Russell King
On Wed, Apr 18, 2018 at 01:31:55PM +1000, Stephen Rothwell wrote: > Hi Russell, > > After merging the arm-current tree, today's linux-next build > (lots of configs) failed like this: > > /bin/sh: 1: arithmetic expression: expecting primary: " " > (lots of these) > > Caused by commit > >

Re: [RFC PATCH] fs: introduce ST_HUGE flag and set it to tmpfs and hugetlbfs

2018-04-18 Thread Yang Shi
On 4/18/18 3:27 AM, Christoph Hellwig wrote: On Wed, Apr 18, 2018 at 05:08:13AM +0800, Yang Shi wrote: Since tmpfs THP was supported in 4.8, hugetlbfs is not the only filesystem with huge page support anymore. tmpfs can use huge page via THP when mounting by "huge=" mount option. When

Re: [PATCH v3] tracing/x86: Update syscall trace events to handle new prefixed syscall func names

2018-04-18 Thread Steven Rostedt
On Wed, 18 Apr 2018 20:17:29 +0200 Dominik Brodowski wrote: > Acked-by: Dominik Brodowski Thanks! Ingo, Thomas, Peter, I can take this in my tree, as I have a couple of patches that need to go mainline as well. OK with you if I do? --

Re: [PATCH v11 2/6] x86/entry: Add STACKLEAK erasing the kernel stack at the end of syscalls

2018-04-18 Thread Laura Abbott
On 04/16/2018 11:29 AM, Kees Cook wrote: On Fri, Apr 6, 2018 at 7:22 AM, Alexander Popov wrote: This commit introduces the architecture-specific code filling the used part of the kernel stack with a poison value before returning to the userspace. Full STACKLEAK feature

Re: syzbot dashboard

2018-04-18 Thread Dmitry Vyukov
On Mon, Apr 16, 2018 at 5:55 PM, Randy Dunlap wrote: > On 04/16/2018 04:15 AM, Dmitry Vyukov wrote: >> On Sat, Apr 14, 2018 at 8:25 PM, Linus Torvalds >> wrote: >>> Coming back to this now that the merge window is almost over ] >>> >>> On

Re: [cfs_trace_lock_tcd] BUG: KASAN: null-ptr-deref in cfs_trace_lock_tcd+0x25/0xeb

2018-04-18 Thread Linus Torvalds
Ugh, that lustre code is disgusting. I thought we were getting rid of it. Anyway, I started looking at why the stack trace is such an incredible mess, with lots of stale entries. The reason (well, _one_ reason) seems to be "ksocknal_startup". It has a 500-byte stack frame for some

Re: [PATCH 0/3] USB: musb: dsps: phy fix and DT-topology support

2018-04-18 Thread Johan Hovold
On Wed, Apr 18, 2018 at 11:20:15AM -0500, Bin Liu wrote: > Johan, > > On Fri, Apr 13, 2018 at 05:15:02PM +0200, Johan Hovold wrote: > > I've been carrying a patch out-of-tree since my work on improving the > > USB device-tree support which is needed to be able to describe USB > > topologies for

Re: [PATCH v11 2/6] x86/entry: Add STACKLEAK erasing the kernel stack at the end of syscalls

2018-04-18 Thread Dave Hansen
On 04/16/2018 11:29 AM, Kees Cook wrote: > Dave, Ingo, Linus: how does this look? With the assembly rewritten > into C, the entry changes are very small: The assembly looks very nice to me now. It is as minimally invasive as it can get. Definitely no objections from me on that part.

Re: [PATCH] SLUB: Do not fallback to mininum order if __GFP_NORETRY is set

2018-04-18 Thread David Rientjes
On Wed, 18 Apr 2018, Mikulas Patocka wrote: > > Mikulas Patoka wants to ensure that no fallback to lower order happens. I > > think __GFP_NORETRY should work correctly in that case too and not fall > > back. > > > > > > > > Allocating at a smaller order is a retry operation and should not > >

Re: [PATCH] mm:memcg: add __GFP_NOWARN in __memcg_schedule_kmem_cache_create

2018-04-18 Thread David Rientjes
On Wed, 18 Apr 2018, Michal Hocko wrote: > > Okay, no problem. However, I don't feel we need ratelimit at this moment. > > We can do when we got real report. Let's add just one line warning. > > However, I have no talent to write a poem to express with one line. > > Could you help me? > > What

Re: [PATCH] mm:memcg: add __GFP_NOWARN in __memcg_schedule_kmem_cache_create

2018-04-18 Thread Johannes Weiner
On Wed, Apr 18, 2018 at 11:29:12AM +0900, Minchan Kim wrote: > If there are heavy memory pressure, page allocation with __GFP_NOWAIT > fails easily although it's order-0 request. > I got below warning 9 times for normal boot. > > [ 17.072747] c0 0 : page allocation failure: order:0, >

[PATCH] kvm: Change return type to vm_fault_t

2018-04-18 Thread Souptick Joarder
Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. commit 1c8f422059ae ("mm: change return type to vm_fault_t")

Re: [PATCH 2/2] hfsplus: fix potential refcnt problem of nls module

2018-04-18 Thread Andrew Morton
On Tue, 17 Apr 2018 15:05:33 +0800 Chengguang Xu wrote: > When specifying nls option multiple times in a mount, > current option parsing will cause inaccurate refcount of nls > module. Hence, call unload_nls for previous one in this case. > > --- a/fs/hfsplus/options.c > +++

Re: [PATCH 1/2] hfs: fix potential refcnt problem of nls module

2018-04-18 Thread Andrew Morton
On Tue, 17 Apr 2018 15:05:32 +0800 Chengguang Xu wrote: > When specifying iocharset/codepage multiple times in a mount, > current option parsing will cause inaccurate refcount of nls > module. Hence, call unload_nls for previous one in this case. > > ... > > ---

Re: [PATCH] prctl: fix compat handling for prctl

2018-04-18 Thread kbuild test robot
Hi Li, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc1 next-20180418] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH] Revert mm/vmstat.c: fix vmstat_update() preemption BUG

2018-04-18 Thread Andrew Morton
On Wed, 18 Apr 2018 17:44:36 +0200 Sebastian Andrzej Siewior wrote: > On 2018-04-11 21:07:29 [+0200], To Tejun Heo wrote: > > On 2018-04-11 16:42:21 [+0200], To Tejun Heo wrote: > > > > > So is this perhaps related to the cpu hotplug that [1] mentions? e.g. > > > > > is

Re: [PATCH] fasync: Fix deadlock between task-context and interrupt-context kill_fasync()

2018-04-18 Thread Jeff Layton
On Tue, 2018-04-17 at 17:15 +0300, Kirill Tkhai wrote: > On 17.04.2018 17:01, Matthew Wilcox wrote: > > On Thu, Apr 05, 2018 at 02:58:06PM +0300, Kirill Tkhai wrote: > > > I observed the following deadlock between them: > > > > > > [task 1] [task 2]

Re: [PATCH] net: don't use kvzalloc for DMA memory

2018-04-18 Thread Mikulas Patocka
On Wed, 18 Apr 2018, Eric Dumazet wrote: > > > On 04/18/2018 09:44 AM, Mikulas Patocka wrote: > > > > > > On Wed, 18 Apr 2018, Eric Dumazet wrote: > > > >> > >> > >> On 04/18/2018 07:34 AM, Mikulas Patocka wrote: > >>> The patch 74d332c13b21 changes alloc_netdev_mqs to use vzalloc if

Re: [RFC PATCH v2 2/4] acpi: apei: Split GHES handlers outside of ghes_do_proc

2018-04-18 Thread Borislav Petkov
On Mon, Apr 16, 2018 at 04:59:01PM -0500, Alexandru Gagniuc wrote: > static void ghes_do_proc(struct ghes *ghes, >const struct acpi_hest_generic_status *estatus) > { > int sev, sec_sev; > struct acpi_hest_generic_data *gdata; > + const struct ghes_handler

Re: [PATCH] net: don't use kvzalloc for DMA memory

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 01:47:21PM -0400, David Miller wrote: > From: Eric Dumazet > Date: Wed, 18 Apr 2018 09:51:25 -0700 > > > I suggest that virtio_net clearly identifies which part needs a specific > > allocation > > and does its itself, instead of abusing the

Re: [RFC PATCH 0/3] Dealing with the aliases of SI_USER

2018-04-18 Thread Eric W. Biederman
Linus Torvalds writes: > ( > > On Sun, Apr 15, 2018 at 8:56 AM, Eric W. Biederman > wrote: [snip bit about wanting what is effectively force_sig_fault instead of clear_siginfo everywhere] > The other thing we should do is to get rid of the

Re: [v4 PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct

2018-04-18 Thread Yang Shi
On 4/18/18 2:40 AM, Cyrill Gorcunov wrote: On Wed, Apr 18, 2018 at 11:03:14AM +0200, Michal Hocko wrote: What about something like the following? " arg_lock protects concurent updates but we still need mmap_sem for read to exclude races with do_brk. " Acked-by: Michal Hocko

Re: [PATCH v3 2/3] Documentation/i2c: sync docs with current state of i2c-tools

2018-04-18 Thread Sam Hansen
On Wed, Apr 18, 2018 at 1:21 AM, Wolfram Sang wrote: > >> +The above functions are made available by linking against the libi2c >> library, >> +which is provided by the i2c-tools project. See: >> +https://git.kernel.org/pub/scm/utils/i2c-tools/i2c-tools.git/. > > In the

Re: [PATCH] arm64: dts: correct SATA addresses for Stingray

2018-04-18 Thread Florian Fainelli
On Wed, 18 Apr 2018 14:11:29 +0530, Srinath Mannam wrote: > Correct all SATA ahci and phy controller register > addresses and interrupt lines to proper values. > > Fixes: 344a2e514182 ("arm64: dts: Add SATA DT nodes for Stingray SoC") > > Signed-off-by: Srinath

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-18 Thread Joe Perches
On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > Hi julia, > > On 2018-04-15 05:19 AM, Julia Lawall wrote: > > On Wed, 11 Apr 2018, Joe Perches wrote: > > > > > On Thu, 2018-04-12 at 08:22 +0200, Julia Lawall wrote: > > > > On Wed, 11 Apr 2018, Joe Perches wrote: > > > > > On

Re: [RFC PATCH V1 01/12] audit: add container id

2018-04-18 Thread Stefan Berger
On 03/15/2018 11:58 PM, Richard Guy Briggs wrote: On 2018-03-15 16:27, Stefan Berger wrote: On 03/01/2018 02:41 PM, Richard Guy Briggs wrote: Implement the proc fs write to set the audit container ID of a process, emitting an AUDIT_CONTAINER record to document the event. This is a write from

[PATCH v3] videobuf: Change return type to vm_fault_t

2018-04-18 Thread Souptick Joarder
Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t")

Re: [v4 PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct

2018-04-18 Thread Yang Shi
On 4/18/18 3:11 AM, Kirill Tkhai wrote: On 14.04.2018 21:24, Yang Shi wrote: mmap_sem is on the hot path of kernel, and it very contended, but it is abused too. It is used to protect arg_start|end and evn_start|end when reading /proc/$PID/cmdline and /proc/$PID/environ, but it doesn't make

RE: [Patch v3 2/6] cifs: Allocate validate negotiation request through kmalloc

2018-04-18 Thread Long Li
> Subject: Re: [Patch v3 2/6] cifs: Allocate validate negotiation request > through > kmalloc > > On 4/18/2018 1:16 PM, Long Li wrote: > >> Subject: Re: [Patch v3 2/6] cifs: Allocate validate negotiation > >> request through kmalloc > >> > >> Two comments. > >> > >> On 4/17/2018 8:33 PM, Long Li

[PATCH 4/6] mm, arm64: untag user addresses in mm/gup.c

2018-04-18 Thread Andrey Konovalov
mm/gup.c provides a kernel interface that accepts user addresses and manipulates user pages directly (for example get_user_pages, that is used by the futex syscall). Here we also need to handle the case of tagged user pointers. Untag addresses passed to this interface. Signed-off-by: Andrey

[PATCH 5/6] lib, arm64: untag addrs passed to strncpy_from_user and strnlen_user

2018-04-18 Thread Andrey Konovalov
strncpy_from_user and strnlen_user accept user addresses as arguments, and do not go through the same path as copy_from_user and others, so here we need to separately handle the case of tagged user addresses as well. Untag user pointers passed to these functions. Signed-off-by: Andrey Konovalov

[PATCH 1/6] arm64: add type casts to untagged_addr macro

2018-04-18 Thread Andrey Konovalov
This patch makes the untagged_addr macro accept all kinds of address types (void *, unsigned long, etc.) and allows not to specify type casts in each place where it is used. This is done by using __typeof__. Signed-off-by: Andrey Konovalov ---

Re: [PATCH 0/3] USB: musb: dsps: phy fix and DT-topology support

2018-04-18 Thread Bin Liu
On Wed, Apr 18, 2018 at 08:46:40PM +0200, Johan Hovold wrote: > On Wed, Apr 18, 2018 at 11:20:15AM -0500, Bin Liu wrote: > > Johan, > > > > On Fri, Apr 13, 2018 at 05:15:02PM +0200, Johan Hovold wrote: > > > I've been carrying a patch out-of-tree since my work on improving the > > > USB

[PATCH -mmotm] prctl: add comment about mmap_sem and arg_lock

2018-04-18 Thread Yang Shi
Add comment to elaborate why mmap_sem for is used by prctl. Signed-off-by: Yang Shi --- akpm: this patch can be foled into: mm-introduce-arg_lock-to-protect-arg_startend-and-env_startend-in-mm_struct.patch kernel/sys.c | 4 1 file changed, 4 insertions(+) diff

Re: [PATCH 0/3] USB: musb: dsps: phy fix and DT-topology support

2018-04-18 Thread Martin Blumenstingl
Hi Johan, On Fri, Apr 13, 2018 at 5:15 PM, Johan Hovold wrote: > I've been carrying a patch out-of-tree since my work on improving the > USB device-tree support which is needed to be able to describe USB > topologies for musb based controllers. > > This patch, which associates

Re: [PATCH v2 09/14] staging: iio: ad7746: Add remove()

2018-04-18 Thread Hernán Gonzalez
On Sun, Apr 15, 2018 at 12:31 PM, Jonathan Cameron wrote: > On Fri, 13 Apr 2018 13:36:46 -0300 > Hernán Gonzalez wrote: > >> This allows the driver to be probed and removed as a module powering it >> down on remove(). >> >> Signed-off-by: Hernán

Re: [RFC PATCH V1 01/12] audit: add container id

2018-04-18 Thread Stefan Berger
On 04/18/2018 03:23 PM, Richard Guy Briggs wrote: On 2018-04-18 14:45, Stefan Berger wrote: On 03/15/2018 11:58 PM, Richard Guy Briggs wrote: On 2018-03-15 16:27, Stefan Berger wrote: On 03/01/2018 02:41 PM, Richard Guy Briggs wrote: Implement the proc fs write to set the audit container ID

Re: [PATCH v2] fork: Unconditionally clear stack on fork

2018-04-18 Thread Andrew Morton
On Wed, 18 Apr 2018 09:38:07 -0700 Kees Cook wrote: > >> So some quite careful quantitative testing is needed here, methinks. > > > > Well, I did some more with perf and cycle counts on running 100,000 > > execs of /bin/true. > > > > before: > > Cycles: 218858861551

Re: [RFC PATCH V1 01/12] audit: add container id

2018-04-18 Thread Richard Guy Briggs
On 2018-04-18 15:39, Stefan Berger wrote: > On 04/18/2018 03:23 PM, Richard Guy Briggs wrote: > > On 2018-04-18 14:45, Stefan Berger wrote: > > > On 03/15/2018 11:58 PM, Richard Guy Briggs wrote: > > > > On 2018-03-15 16:27, Stefan Berger wrote: > > > > > On 03/01/2018 02:41 PM, Richard Guy Briggs

Re: [PATCH v2 0/3] perf: Fixes for callchain ip handling on powerpc

2018-04-18 Thread Arnaldo Carvalho de Melo
Em Wed, Apr 18, 2018 at 04:28:57PM +0530, Sandipan Das escreveu: > The first patch fixes the callchain ip filtering mechanism for powerpc > from skipping entries in case the LR value is still valid and yet to > be written to the stack frame. This was previously posted as an RFC > here:

Re: [PATCH] net: don't use kvzalloc for DMA memory

2018-04-18 Thread Mikulas Patocka
On Wed, 18 Apr 2018, David Miller wrote: > From: Mikulas Patocka > Date: Wed, 18 Apr 2018 12:44:25 -0400 (EDT) > > > The structure net_device is followed by arbitrary driver-specific data > > (accessible with the function netdev_priv). And for virtio-net, these > >

Re: [PATCH v4 1/2] Documentation: Documentation for qcom, llcc

2018-04-18 Thread Channa
On 2018-04-18 07:52, Rob Herring wrote: On Tue, Apr 17, 2018 at 5:12 PM, wrote: On 2018-04-17 10:43, risha...@codeaurora.org wrote: On 2018-04-16 07:59, Rob Herring wrote: On Tue, Apr 10, 2018 at 01:08:12PM -0700, Rishabh Bhatnagar wrote: Documentation for last

Re: [PATCH] ARC: Improve cmpxchng syscall implementation

2018-04-18 Thread Vineet Gupta
On 03/21/2018 04:54 AM, Alexey Brodkin wrote: /* * This is only for old cores lacking LLOCK/SCOND, which by defintion @@ -60,23 +62,48 @@ SYSCALL_DEFINE3(arc_usr_cmpxchg, int *, uaddr, int, expected, int, new) /* Z indicates to userspace if operation succeded */

[PATCH v2] media: v4l2-core: videobuf-dma-sg: Change return type to vm_fault_t

2018-04-18 Thread Souptick Joarder
Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t")

Re: linux-next: build failure after merge of the arm-current tree

2018-04-18 Thread Russell King
On Wed, Apr 18, 2018 at 06:54:42PM +0100, Russell King wrote: > On Wed, Apr 18, 2018 at 01:31:55PM +1000, Stephen Rothwell wrote: > > Hi Russell, > > > > After merging the arm-current tree, today's linux-next build > > (lots of configs) failed like this: > > > > /bin/sh: 1: arithmetic

Re: [PATCH v3] tracing/x86: Update syscall trace events to handle new prefixed syscall func names

2018-04-18 Thread Dominik Brodowski
On Wed, Apr 18, 2018 at 11:45:09AM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Arnaldo noticed that the latest kernel is missing the syscall event system > directory in x86. I bisected it down to d5a00528b58c ("syscalls/core, > syscalls/x86: Rename

Re: [PATCH v2] docs: kernel-parameters.txt: Fix whitespace

2018-04-18 Thread Randy Dunlap
On 04/18/18 11:16, Thymo van Beers wrote: > On Mon, Apr 16, 2018 at 03:03:47PM -0700, Randy Dunlap wrote: >> On 04/16/18 14:49, Thymo van Beers wrote: >>> Some lines used spaces instead of tabs at line start. >>> This can cause mangled lines in editors due to inconsistency. >>> >>> Replace spaces

Re: [PATCH v2] media: v4l2-core: videobuf-dma-sg: Change return type to vm_fault_t

2018-04-18 Thread Matthew Wilcox
On Wed, Apr 18, 2018 at 11:49:19PM +0530, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct type. >

[PATCH v3] docs: kernel-parameters.txt: Fix whitespace

2018-04-18 Thread Thymo van Beers
Some lines used spaces instead of tabs at line start. This can cause mangled lines in editors due to inconsistency. Replace spaces for tabs where appropriate. Signed-off-by: Thymo van Beers --- Changes in v3: - Change indentation in intel_pstate to reduce overrunning

<    1   2   3   4   5   6   7   8   9   10   >