Re: [PATCH 4.4 110/268] nvme-pci: Fix nvme queue cleanup if IRQ setup fails

2018-06-13 Thread Keith Busch
On Wed, Jun 13, 2018 at 05:37:35PM +0100, Ben Hutchings wrote: > On Wed, 2018-06-13 at 10:30 -0600, Keith Busch wrote: > > Thank you very much the catching that. This particular patch is indeed > > not correct without the following: > > > >   161b8be2bd6ab ("nvme-pci: initialize queue memory

[PATCH v2 2/2] arm64: dts: qcom: sdm845: Enable debug UART and I2C10 on sdm845-mtp

2018-06-13 Thread Douglas Anderson
The debug UART is very useful to have. I2C10 is enabled as an example of a I2C port we can talk on for now. Eventually we'll want to put peripherals under it. Signed-off-by: Douglas Anderson Reviewed-by: Bjorn Andersson Tested-by: Bjorn Andersson --- Changes in v2: - Got rid of all sleep

[PATCH v2 1/2] arm64: dts: qcom: sdm845: Add I2C, SPI, and UART9 nodes

2018-06-13 Thread Douglas Anderson
This adds nodes to SDM845-dtsi for all the I2C ports, all the SPI ports, and UART9. Note that I2C / SPI / UART are a bit strange on sdm845 because each "serial engine" has 4 pins associated with it and depending on which firmware has been loaded into the serial engine (loaded by the BIOS) the

[PATCH v2] staging: rts5208: add check on NULL before dereference

2018-06-13 Thread Anton Vasilyev
If rtsx_probe() fails to allocate dev->chip, then NULL pointer dereference occurs at release_everything()->rtsx_release_resources(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton Vasilyev --- v2: Add error handling into rtsx_probe based on Dan Carpenter's

Re: [PATCH 3/4] serial: 8250: Handle case port doesn't have TEMT interrupt using em485.

2018-06-13 Thread Alan Cox
> + } else { > + while ((lsr & BOTH_EMPTY) != BOTH_EMPTY) { > + lsr = serial_in(p, UART_LSR); > + cpu_relax(); > + } > + } This still needs a timeout in case some kind of

Re: [PATCH v2] staging: rts5208: add check on NULL before dereference

2018-06-13 Thread Andy Shevchenko
On Wed, Jun 13, 2018 at 7:55 PM, Anton Vasilyev wrote: > If rtsx_probe() fails to allocate dev->chip, then NULL pointer > dereference occurs at release_everything()->rtsx_release_resources(). > > Found by Linux Driver Verification project (linuxtesting.org). > You forgot to adjust subject and

Re: WARNING: bad unlock balance in ucma_event_handler

2018-06-13 Thread Jason Gunthorpe
On Wed, Jun 13, 2018 at 06:47:02AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:73fcb1a370c7 Merge branch 'akpm' (patches from Andrew) > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=16d7082780 > kernel

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Suzuki K Poulose
Hi Matt, On 13/06/18 16:47, Matt Sealey wrote: Hi Suzuki, Why not use “unit”? I believe we had this discussion years ago about numbering serial ports and sdhci (i.e. how do you know it’s UART0 or UART1 from just the address? Some SoC’s don’t address sequentially *or* in a forward direction)

Re: [PATCH 4.4 110/268] nvme-pci: Fix nvme queue cleanup if IRQ setup fails

2018-06-13 Thread Greg Kroah-Hartman
On Wed, Jun 13, 2018 at 10:56:32AM -0600, Keith Busch wrote: > On Wed, Jun 13, 2018 at 05:37:35PM +0100, Ben Hutchings wrote: > > On Wed, 2018-06-13 at 10:30 -0600, Keith Busch wrote: > > > Thank you very much the catching that. This particular patch is indeed > > > not correct without the

Re: REGRESSION: "wlcore: sdio: allow pm to handle sdio power" breaks wifi on HiKey960

2018-06-13 Thread John Stultz
On Wed, Jun 13, 2018 at 7:42 AM, Valentin Schneider wrote: > On 13/06/18 05:13, Tony Lindgren wrote: >> * John Stultz [180612 22:15]: >>> Hey Folks, >>> I noticed with linus/master wifi wasn't coming up on HiKey960. I >>> bisected it down and it seems to be due to: >>> >>> 60f36637bbbd

[GIT PULL] kselftest update 2 for Linux 4.18-rc1

2018-06-13 Thread Shuah Khan
Hi Linus, Please pull the following Kselftest update 2 for 4.18-rc1 This second Kselftest update for Linux 4.18-rc1: - fixes a signedness bug in cgroups test - adds ppc support for kprobe args tests diff is attached. thanks, -- Shuah

[PATCH v5] staging: comedi: Improved readability of function comedi_nsamples_left.

2018-06-13 Thread Chris Opperman
Improve readability of comedi_nsamples_left: a) Reduce nesting by using more return statements. b) Declare variables scans_left and samples_left at start of function. c) Change type of scans_Left to unsigned long long to avoid cast. Signed-off-by: Chris Opperman --- Changes v5: a) Moved

Re: [PATCH] selftests: sparc64: delete RUN_TESTS and EMIT_TESTS overrides

2018-06-13 Thread Tom Hromatka
Thanks for the clean up, Shuah.  Looks good to me. Tom On 06/12/2018 05:24 PM, Shuah Khan (Samsung OSG) wrote: Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in lib.mk. Common defines work just fine and there is no need to define custom overrides. Signed-off-by: Shuah Khan

[PATCH v3] lib/test_printf.c: accept "ptrval" as valid result for plain 'p' tests

2018-06-13 Thread Thierry Escande
If the test_printf module is loaded before the crng is initialized, the plain 'p' tests will fail because the printed address will not be hashed and the buffer will contain "(ptrval)" or "(ptrval)" instead (64-bit vs 32-bit). Since we cannot wait for the crng to be initialized for an

Re: [PATCH] selftests: sparc64: Fix to do nothing on non-sparc64

2018-06-13 Thread Tom Hromatka
Thanks, Shuah! Tom On 06/12/2018 05:23 PM, Shuah Khan (Samsung OSG) wrote: sparc64 test fails with the following errors on non-sparc64 systems. Fix the Makefile to do nothing on non-sparc64 systems to suppress the errors: make run_tests adi-test.c: Assembler messages: adi-test.c:302: Error:

[PATCH] PCI: xilinx: add missing of_node_put()

2018-06-13 Thread Nicholas Mc Guire
blem found by an experimental cocinelle script Patch was compile tested with: multi_v7_defconfig + ARCH_ZYNQ=y, COMPILE_TEST=y, PCIE_XILINX=y (with one sparse warning though not related to the change proposed) Patch is against 4.17.0 (localversion-next is next-20180613) drivers/pci/controller/pcie-xilinx.

Re: [PATCH v4 2/2] gpio: davinci: Do not assume continuous IRQ numbering

2018-06-13 Thread Grygorii Strashko
On 06/12/2018 10:40 PM, Keerthy wrote: Currently the driver assumes that the interrupts are continuous and does platform_get_irq only once and assumes the rest are continuous, instead call platform_get_irq for all the interrupts and store them in an array for later use. Signed-off-by:

Re: [PATCH v7 3/4] arm64: dts: sdm845: Add serial console support

2018-06-13 Thread Doug Anderson
Hi, On Tue, Jun 12, 2018 at 10:09 AM, Karthikeyan Ramasubramanian wrote: > From: Rajendra Nayak > > Add the qup uart node and geni se instance needed to > support the serial console on the MTP. > > Signed-off-by: Rajendra Nayak > Signed-off-by: Karthikeyan Ramasubramanian > --- >

Re: [GIT PULL] Kbuild updates for 4.18 (2nd round)

2018-06-13 Thread Masahiro Yamada
Hi Linus, 2018-06-14 1:03 GMT+09:00 Linus Torvalds : > On Wed, Jun 13, 2018 at 8:55 AM Linus Torvalds > wrote: >> >> On Wed, Jun 13, 2018 at 7:47 AM Masahiro Yamada >> wrote: >> > >> > Please pull more Kbuild updates. >> >> Pulled. However, I notice a few oddities. > > Oh, and one actual bug:

Re: [PATCH v7 4/4] arm64: dts: sdm845: Add support for an instance of I2C controller

2018-06-13 Thread Doug Anderson
Hi, On Tue, Jun 12, 2018 at 10:09 AM, Karthikeyan Ramasubramanian wrote: > Add one instance of GENI based I2C master controller to enable testing > I2C driver using EEPROM slave. > > Signed-off-by: Karthikeyan Ramasubramanian > Reviewed-by: Douglas Anderson > --- >

Re: [PATCH v3 1/2] IDR: Expose the XArray lock

2018-06-13 Thread Jason Gunthorpe
On Wed, Jun 13, 2018 at 05:34:02AM -0700, Matthew Wilcox wrote: > Allow users of the IDR to use the XArray lock for their own > synchronisation purposes. The IDR continues to rely on the caller to > handle locking, but this lets the caller use the lock embedded in the > IDR data structure instead

[no subject]

2018-06-13 Thread Anton Vasilyev
Subject: [PATCH v3] staging: rts5208: add error handling into rtsx_probe If rtsx_probe() fails to allocate dev->chip, then release_everything() will crash on uninitialized dev->cmnd_ready complete. Patch adds error handling into rtsx_probe. Found by Linux Driver Verification project

Re: [PATCH v4] staging: comedi: Improved readability of function comedi_nsamples_left.

2018-06-13 Thread Ian Abbott
On 13/06/18 19:26, Chris Opperman wrote: Hi Dan/Ian, Noted your comments regarding additional text, thanks! Just curious whether the "scissors" format given at the link below is valid? https://kernelnewbies.org/PatchTipsAndTricks It is given as an alternative to placing additional text below

Re: [PATCH] arm64: dts: hikey: Define wl1835 power capabilities

2018-06-13 Thread Valentin Schneider
Hi, On 13/06/18 16:13, Ryan Grachek wrote: > These properties are required for compatibility with runtime PM. > Without these properties, MMC host controller will not be aware > of power capabilities. When the wlcore driver attempts to power > on the device, it will erroneously fail with -EACCES.

[PATCH v3] staging: rts5208: add error handling into rtsx_probe

2018-06-13 Thread Anton Vasilyev
If rtsx_probe() fails to allocate dev->chip, then release_everything() will crash on uninitialized dev->cmnd_ready complete. Patch adds error handling into rtsx_probe. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton Vasilyev --- v3: fix subject and commit

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-13 Thread Punit Agrawal
Punit Agrawal writes: [...] > > CONFIG_HAVE_MEMORYLESS node is not enabled on arm64 which means we end > up returning the original node in the fallback path. > > Xie, does the below patch help? I can submit a proper patch if this > fixes the issue for you. > > -- >8 -- > Subject: [PATCH]

Re: [PATCH 3.18 00/21] 3.18.113-stable review

2018-06-13 Thread Guenter Roeck
On Wed, Jun 13, 2018 at 04:58:15PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 13, 2018 at 04:09:57PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Jun 13, 2018 at 06:48:05AM -0700, Guenter Roeck wrote: > > > On 06/12/2018 09:51 AM, Greg Kroah-Hartman wrote: > > > > This is the start of the

Re: [PATCH v5] staging: comedi: Improved readability of function comedi_nsamples_left.

2018-06-13 Thread Ian Abbott
On 13/06/18 18:14, Chris Opperman wrote: Improve readability of comedi_nsamples_left: a) Reduce nesting by using more return statements. b) Declare variables scans_left and samples_left at start of function. c) Change type of scans_Left to unsigned long long to avoid cast. Signed-off-by: Chris

Re: [PATCH v4 1/9] Makefile: Prepare for using macros for inline asm

2018-06-13 Thread Masahiro Yamada
Hi. 2018-06-12 20:50 GMT+09:00 Nadav Amit : > Using macros for inline assembly improves both readability and > compilation decisions that are distorted by big assembly blocks that use > alternative sections. Compile macros.S and use it to assemble all C > files. Currently, only x86 will use it.

Re: [PATCHv3 01/17] mm: Do no merge VMAs with different encryption KeyIDs

2018-06-13 Thread Dave Hansen
On 06/12/2018 07:38 AM, Kirill A. Shutemov wrote: > VMAs with different KeyID do not mix together. Only VMAs with the same > KeyID are compatible. > > Signed-off-by: Kirill A. Shutemov > --- > include/linux/mm.h | 7 +++ > mm/mmap.c | 3 ++- > 2 files changed, 9 insertions(+), 1

Re: [GIT PULL] Kbuild updates for 4.18 (2nd round)

2018-06-13 Thread Linus Torvalds
On Wed, Jun 13, 2018 at 10:29 AM Masahiro Yamada wrote: > > I cannot come up with a name better than CC_STACKPROTECTOR_STRONG. How about just calling it STACKPROTETOR_STRONG and leaving it at that? Make the "CC_HAVE_xyz" model for compiler feature tests, but when actually picking an actual

[PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c

2018-06-13 Thread Douglas Anderson
In an early version of the I2C patch that was posted to the list the default I2C frequency (if none was specified) was 400 kHz. There was debate on the list and we decided that it would be more consistent with the rest of i2c if we defaulted to 100 kHz. ...but we never updated the bindings.

Re: [PATCHv3 02/17] mm/khugepaged: Do not collapse pages in encrypted VMAs

2018-06-13 Thread Dave Hansen
On 06/12/2018 07:39 AM, Kirill A. Shutemov wrote: > Pages for encrypted VMAs have to be allocated in a special way: > we would need to propagate down not only desired NUMA node but also > whether the page is encrypted. > > It complicates not-so-trivial routine of huge page allocation in >

Re: [PATCHv3 03/17] mm/ksm: Do not merge pages with different KeyIDs

2018-06-13 Thread Dave Hansen
On 06/12/2018 07:39 AM, Kirill A. Shutemov wrote: > Pages encrypted with different encryption keys are not subject to KSM > merge. Otherwise it would cross security boundary. This needs a much stronger explanation. Which KeyID would be used for access in the new direct mappings? What actually

Re: [PATCH v3 2/2] tpm: add support for nonblocking operation

2018-06-13 Thread J Freyensee
On 6/12/18 10:58 AM, Tadeusz Struk wrote: Currently the TPM driver only supports blocking calls, which doesn't allow asynchronous IO operations to the TPM hardware. This patch changes it and adds support for nonblocking write and a new poll function to enable applications, which want to take

[PATCH] arm64: dts: hikey960: Define wl1837 power capabilities

2018-06-13 Thread Ryan Grachek
These properties are required for compatibility with runtime PM. Without these properties, MMC host controller will not be aware of power capabilities. When the wlcore driver attempts to power on the device, it will erroneously fail with -EACCES. This fixes a regression found here:

Re: [PATCH v3 2/2] tpm: add support for nonblocking operation

2018-06-13 Thread Tadeusz Struk
On 06/13/2018 10:55 AM, J Freyensee wrote: >> +    /* >> + * If in nonblocking mode schedule an async job to send >> + * the command return the size. >> + * In case of error the err code will be returned in >> + * the subsequent read call. >> + */ >> +    if (file->f_flags &

Re: [PATCHv3 04/17] mm/page_alloc: Handle allocation for encrypted memory

2018-06-13 Thread Dave Hansen
On 06/12/2018 07:39 AM, Kirill A. Shutemov wrote: > For encrypted memory, we need to allocated pages for a specific > encryption KeyID. "allocate" ^ > There are two cases when we need to allocate a page for encryption: > > - Allocation for an encrypted VMA; > > -

Re: [PATCHv3 07/17] x86/mm: Preserve KeyID on pte_modify() and pgprot_modify()

2018-06-13 Thread Dave Hansen
On 06/12/2018 07:39 AM, Kirill A. Shutemov wrote: > Encrypted VMA will have KeyID stored in vma->vm_page_prot. This way we "An encrypted VMA..." > don't need to do anything special to setup encrypted page table entries > and don't need to reserve space for KeyID in a VMA. > > This patch changes

Re: [PATCH v4 1/2] dt-bindings: cpufreq: Introduce QCOM CPUFREQ FW bindings

2018-06-13 Thread Taniya Das
Hello Sudeep, Thanks for review comments. On 6/13/2018 4:56 PM, Sudeep Holla wrote: On 12/06/18 12:02, Taniya Das wrote: Add QCOM cpufreq firmware device bindings for Qualcomm Technology Inc's SoCs. This is required for managing the cpu frequency transitions which are controlled by

Re: [GIT PULL] Kbuild updates for 4.18 (2nd round)

2018-06-13 Thread Masahiro Yamada
Hi Linus, 2018-06-14 2:49 GMT+09:00 Linus Torvalds : > On Wed, Jun 13, 2018 at 10:29 AM Masahiro Yamada > wrote: >> >> I cannot come up with a name better than CC_STACKPROTECTOR_STRONG. > > How about just calling it STACKPROTETOR_STRONG and leaving it at that? Good idea! > Make the

Re: [PATCHv3 08/17] x86/mm: Implement vma_is_encrypted() and vma_keyid()

2018-06-13 Thread Dave Hansen
On 06/12/2018 07:39 AM, Kirill A. Shutemov wrote: > +bool vma_is_encrypted(struct vm_area_struct *vma) > +{ > + return pgprot_val(vma->vm_page_prot) & mktme_keyid_mask; > +} > + > +int vma_keyid(struct vm_area_struct *vma) > +{ > + pgprotval_t prot; > + > + if (!vma_is_anonymous(vma))

[PATCH 1/7] vmw_balloon: update copyright message

2018-06-13 Thread Nadav Amit
Removing the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice according to checkpatch request. In addition, updating the year and adding a license tag. Reviewed-by: Xavier Deguillard Signed-off-by: Nadav Amit --- drivers/misc/vmw_balloon.c |

[PATCH 6/7] vmw_balloon: fix VMCI use when balloon built into kernel

2018-06-13 Thread Nadav Amit
Currently, when all modules, including VMCI and VMware balloon are built into the kernel, the initialization of the balloon happens before the VMCI is probed. As a result, the balloon fails to initialize the VMCI doorbell, which it uses to get asynchronous requests for balloon size changes. The

[PATCH 0/7] vmw_balloon: addressing bugs and issues

2018-06-13 Thread Nadav Amit
This patch-set addresses minor issues and bugs in the VMware balloon driver. Patches 3-7 address bugs that were not reported by customers, but we would like to get them to 4.18 if possible. We will send separately later a patch-set with new features to be set on top of this set. Nadav Amit (7):

[PATCH 3/7] vmw_balloon: fix inflation of 64-bit GFNs

2018-06-13 Thread Nadav Amit
When balloon batching is not supported by the hypervisor, the guest frame number (GFN) must fit in 32-bit. However, due to a bug, this check was mistakenly ignored. In practice, when total RAM is greater than 16TB, the balloon does not work currently, making this bug unlikely to happen. Fixes:

[PATCH 5/7] vmw_balloon: VMCI_DOORBELL_SET does not check status

2018-06-13 Thread Nadav Amit
When vmballoon_vmci_init() sets a doorbell using VMCI_DOORBELL_SET, for some reason it does not consider the status and looks at the result. However, the hypervisor does not update the result - it updates the status. Fixes: 48e3d668b790 ("VMware balloon: Enable notification via VMCI")

[PATCH 4/7] vmw_balloon: do not use 2MB without batching

2018-06-13 Thread Nadav Amit
If the hypervisor sets 2MB batching is on, while batching is cleared, the balloon code breaks. In this case the legacy mechanism is used with 2MB page. The VM would report a 2MB page is ballooned, and the hypervisor would only take the first 4KB. While the hypervisor should not report such

Re: [PATCHv3 09/17] x86/mm: Implement page_keyid() using page_ext

2018-06-13 Thread Dave Hansen
> +int page_keyid(const struct page *page) > +{ > + if (mktme_status != MKTME_ENABLED) > + return 0; > + > + return lookup_page_ext(page)->keyid; > +} > +EXPORT_SYMBOL(page_keyid); Please start using a proper X86_FEATURE_* flag for this. It will give you all the fancy static

[PATCH 2/7] vmw_balloon: update maintainers list

2018-06-13 Thread Nadav Amit
Philip Moltman is no longer a maintainer of the VMware balloon. Setting Nadav Amit as one instead. Reviewed-by: Xavier Deguillard Signed-off-by: Nadav Amit --- MAINTAINERS| 2 +- drivers/misc/vmw_balloon.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] arm64: dts: hikey: Define wl1835 power capabilities

2018-06-13 Thread Ryan Grachek
Hi Valentin, On Wed, Jun 13, 2018 at 12:34 PM, Valentin Schneider wrote: > Hi, > > On 13/06/18 16:13, Ryan Grachek wrote: >> These properties are required for compatibility with runtime PM. >> Without these properties, MMC host controller will not be aware >> of power capabilities. When the

[PATCH 7/7] vmw_balloon: remove inflation rate limiting

2018-06-13 Thread Nadav Amit
Since commit 33d268ed0019 ("VMware balloon: Do not limit the amount of frees and allocations in non-sleep mode."), the allocations are not increased, and therefore balloon inflation rate limiting is in practice broken. While we can restore rate limiting, in practice we see that it can result in

Re: [PATCH 1/7] vmw_balloon: update copyright message

2018-06-13 Thread Greg Kroah-Hartman
On Wed, Jun 13, 2018 at 04:03:53AM -0700, Nadav Amit wrote: > Removing the paragraph about writing to the Free Software Foundation's > mailing address from the sample GPL notice according to checkpatch > request. > > In addition, updating the year and adding a license tag. > > Reviewed-by:

Re: [PATCH 3/7] vmw_balloon: fix inflation of 64-bit GFNs

2018-06-13 Thread Greg Kroah-Hartman
On Wed, Jun 13, 2018 at 04:03:55AM -0700, Nadav Amit wrote: > When balloon batching is not supported by the hypervisor, the guest > frame number (GFN) must fit in 32-bit. However, due to a bug, this check > was mistakenly ignored. In practice, when total RAM is greater than > 16TB, the balloon

Re: [PATCH 1/7] vmw_balloon: update copyright message

2018-06-13 Thread Nadav Amit
at 11:20 AM, Greg Kroah-Hartman wrote: > On Wed, Jun 13, 2018 at 04:03:53AM -0700, Nadav Amit wrote: >> Removing the paragraph about writing to the Free Software Foundation's >> mailing address from the sample GPL notice according to checkpatch >> request. >> >> In addition, updating the year

Re: [PATCHv3 10/17] x86/mm: Implement prep_encrypted_page() and arch_free_page()

2018-06-13 Thread Dave Hansen
On 06/12/2018 07:39 AM, Kirill A. Shutemov wrote: > prep_encrypted_page() also takes care about zeroing the page. We have to > do this after KeyID is set for the page. This is an implementation detail that has gone unmentioned until now but has impacted at least half a dozen locations in previous

Re: [PATCH 3/7] vmw_balloon: fix inflation of 64-bit GFNs

2018-06-13 Thread Nadav Amit
at 11:21 AM, Greg Kroah-Hartman wrote: > On Wed, Jun 13, 2018 at 04:03:55AM -0700, Nadav Amit wrote: >> When balloon batching is not supported by the hypervisor, the guest >> frame number (GFN) must fit in 32-bit. However, due to a bug, this check >> was mistakenly ignored. In practice, when

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-06-13 Thread Lina Iyer
On Fri, May 25 2018 at 19:08 -0600, David Collins wrote: Hello Rajendra, On 05/25/2018 03:01 AM, Rajendra Nayak wrote: + + to_active_sleep(pd, pd->corner, _corner, _sleep_corner); + + if (peer && peer->enabled) + to_active_sleep(peer, peer->corner, _corner, +

Re: [PATCHv3 12/17] x86/mm: Allow to disable MKTME after enumeration

2018-06-13 Thread Dave Hansen
On 06/12/2018 07:39 AM, Kirill A. Shutemov wrote: > Separate MKTME enumaration from enabling. We need to postpone enabling > until initialization is complete. ^ enumeration > The new helper mktme_disable() allows to disable MKTME even if it's s/to disable/disabling/ >

Re: [PATCH] arm64: dts: hikey: Define wl1835 power capabilities

2018-06-13 Thread John Stultz
On Wed, Jun 13, 2018 at 8:13 AM, Ryan Grachek wrote: > These properties are required for compatibility with runtime PM. > Without these properties, MMC host controller will not be aware > of power capabilities. When the wlcore driver attempts to power > on the device, it will erroneously fail

Re: [PATCHv3 14/17] x86/mm: Introduce direct_mapping_size

2018-06-13 Thread Dave Hansen
On 06/12/2018 07:39 AM, Kirill A. Shutemov wrote: > Kernel need to have a way to access encrypted memory. We are going to "The kernel needs"... > use per-KeyID direct mapping to facilitate the access with minimal > overhead. What are the security implications of this approach? > Direct mapping

Re: [PATCHv3 15/17] x86/mm: Implement sync_direct_mapping()

2018-06-13 Thread Dave Hansen
On 06/12/2018 07:39 AM, Kirill A. Shutemov wrote: > arch/x86/include/asm/mktme.h | 6 + > arch/x86/mm/init_64.c| 6 + > arch/x86/mm/mktme.c | 444 +++ > 3 files changed, 456 insertions(+) Can we not do any better than 400 lines of new

Re: [PATCHv3 16/17] x86/mm: Handle encrypted memory in page_to_virt() and __pa()

2018-06-13 Thread Dave Hansen
> diff --git a/arch/x86/include/asm/mktme.h b/arch/x86/include/asm/mktme.h > index efc0d4bb3b35..d6edcabacfc7 100644 > --- a/arch/x86/include/asm/mktme.h > +++ b/arch/x86/include/asm/mktme.h > @@ -43,6 +43,9 @@ void mktme_disable(void); > void setup_direct_mapping_size(void); > int

[PATCH] proc: Make inline name size calculation automatic

2018-06-13 Thread David Howells
Make calculation of the size of the inline name in struct proc_dir_entry automatic, rather than having to manually encode the numbers and failing to allow for lockdep. Require a minimum inline name size of 33+1 to allow for names that look like two hex numbers with a dash between. Reported-by:

[PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation

2018-06-13 Thread Suravee Suthikulpanit
The current logic incorrectly calculates the LLC ID from the APIC ID. Unless specified otherwise, the LLC ID should be calculated from the count order of the number of threads sharing cache. Fixes: 68091ee7ac3c ("Calculate last level cache ID from number of sharing threads") Signed-off-by:

Re: [PATCH v7 4/4] vsprintf: Add command line option debug_boot_weak_hash

2018-06-13 Thread Steven Rostedt
On Tue, 12 Jun 2018 10:39:14 +1000 "Tobin C. Harding" wrote: > +/* Make pointers available for printing early in the boot sequence. */ > +static int debug_boot_weak_hash __ro_after_init; > +EXPORT_SYMBOL(debug_boot_weak_hash); > + > +static int __init debug_boot_weak_hash_enable(char *str) > +{

[PATCH 1/2] IDR: Expose the XArray lock

2018-06-13 Thread Matthew Wilcox
Allow users of the IDR to use the XArray lock for their own synchronisation purposes. The IDR continues to rely on the caller to handle locking, but this lets the caller use the lock embedded in the IDR data structure instead of allocating their own lock. Signed-off-by: Matthew Wilcox ---

Re: [PATCHv3 17/17] x86: Introduce CONFIG_X86_INTEL_MKTME

2018-06-13 Thread Dave Hansen
On 06/12/2018 07:39 AM, Kirill A. Shutemov wrote: > Add new config option to enabled/disable Multi-Key Total Memory > Encryption support. > > MKTME uses MEMORY_PHYSICAL_PADDING to reserve enough space in per-KeyID > direct mappings for memory hotplug. Isn't it really *the* direct mapping

Re: [PATCH v3 1/2] IDR: Expose the XArray lock

2018-06-13 Thread Matthew Wilcox
On Wed, Jun 13, 2018 at 11:30:57AM -0600, Jason Gunthorpe wrote: > Hmm, what do I need to apply this? > > drivers/infiniband/core/mad.c: In function ‘ib_register_mad_agent’: > drivers/infiniband/core/mad.c:387:34: error: ‘struct idr’ has no member named > ‘idr_xa’; did you mean ‘idr_rt’? >

Re: [PATCH 4.4 119/268] xen/pirq: fix error path cleanup when binding MSIs

2018-06-13 Thread Ben Hutchings
On Wed, 2018-02-28 at 09:19 +, Roger Pau Monne wrote: > From: Roger Pau Monne > > [ Upstream commit 910f8befdf5bccf25287d9f1743e3e546bcb7ce0 ] > > Current cleanup in the error path of xen_bind_pirq_msi_to_irq is > wrong. First of all there's an off-by-one in the cleanup loop, which > can

[PATCH] Staging: comedi: ssv_dnp: fixed style line length warning

2018-06-13 Thread Javier Martinez
Fixed style line length warning detected by checkpatch.pl in the file ssv_dnp.c. Signed-off-by: Javier Martinez --- drivers/staging/comedi/drivers/ssv_dnp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c

Re: [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex

2018-06-13 Thread Robert Jarzmik
Rob Herring writes: > On Mon, Jun 11, 2018 at 10:22:10PM +0200, Robert Jarzmik wrote: >> This adds a binding for the Marvell PXA audio complex, available in >> pxa2xx and pxa3xx variants. >> +Required properties: >> + - compatible: "marvell,pxa2xx-ac97" > > Don't use wildcards in compatible

[PATCH] Staging: comedi: ssv_dnp: fixed style line length warning

2018-06-13 Thread Javier Martinez
Fixed style line length warning detected by checkpatch.pl in the file ssv_dnp.c. Signed-off-by: Javier Martinez --- drivers/staging/comedi/drivers/ssv_dnp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c

Re: [PATCH v7 4/4] vsprintf: Add command line option debug_boot_weak_hash

2018-06-13 Thread Steven Rostedt
On Tue, 12 Jun 2018 10:39:14 +1000 "Tobin C. Harding" wrote: > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > index c445f9f28760..6d2479eb7c2b 100644 > --- a/lib/vsprintf.c > +++ b/lib/vsprintf.c > @@ -1651,6 +1651,18 @@ char *device_node_string(char *buf, char *end, struct > device_node *dn,

Re: [PATCH v4] staging: comedi: Improved readability of function comedi_nsamples_left.

2018-06-13 Thread Dan Carpenter
On Wed, Jun 13, 2018 at 08:26:43PM +0200, Chris Opperman wrote: > Hi Dan/Ian, > > Noted your comments regarding additional text, thanks! Just curious whether > the "scissors" format given at the link below is valid? > > https://kernelnewbies.org/PatchTipsAndTricks > > It is given as an

Re: [GIT PULL] overflow updates (part 2) for v4.18-rc1

2018-06-13 Thread Kees Cook
On Tue, Jun 12, 2018 at 6:44 PM, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 4:36 PM Kees Cook wrote: >> >> - Treewide conversions of allocators to use either 2-factor argument >> variant when available, or array_size() and array3_size() as needed (Kees) > > Ok, some of this smells just a

Re: [PATCH v4 2/2] iio: add ISL29033 Ultra-Low Lux ambient-light-sensor

2018-06-13 Thread kbuild test robot
Hi Borys, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on iio/togreg] [also build test WARNING on v4.17 next-20180613] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[GIT PULL] UML updates for 4.18-rc1

2018-06-13 Thread Richard Weinberger
Linus, The following changes since commit 29dcea88779c856c7dc92040a0c01233263101d4: Linux 4.17 (2018-06-03 14:15:21 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git for-linus-4.18-rc1 for you to fetch changes up to

Re: [PATCH] arm64: dts: stingray: use NUM_SATA to configure number of sata ports

2018-06-13 Thread Florian Fainelli
On 06/12/2018 03:54 PM, Rob Herring wrote: > On Thu, Jun 7, 2018 at 12:53 PM, Scott Branden > wrote: >> Hi Rob, >> >> Could you please kindly comment on change below. >> >> It allows board variants to be added easily via a simple define for >> different number of SATA ports. >> >> >> >> On

[PATCH v10 7/7] i2c: fsi: Add bus recovery

2018-06-13 Thread Eddie James
Bus recovery should reset the engine and force clock the bus 9 times to recover most situations. Signed-off-by: Eddie James --- drivers/i2c/busses/i2c-fsi.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c index

[PATCH v10 6/7] i2c: fsi: Add I2C master locking

2018-06-13 Thread Eddie James
Since there are many ports per master, each with it's own adapter and chardev, we need some locking to prevent transfers from changing the master state while other transfers are in progress. Signed-off-by: Eddie James --- drivers/i2c/busses/i2c-fsi.c | 16 1 file changed, 12

[PATCH v10 2/7] i2c: Add FSI-attached I2C master algorithm

2018-06-13 Thread Eddie James
Add register definitions for FSI-attached I2C master and functions to access those registers over FSI. Add an FSI driver so that our I2C bus is probed up during an FSI scan. Signed-off-by: Eddie James --- drivers/i2c/busses/Kconfig | 11 ++ drivers/i2c/busses/Makefile | 1 +

[PATCH v10 5/7] i2c: fsi: Add transfer implementation

2018-06-13 Thread Eddie James
Execute I2C transfers from the FSI-attached I2C master. Use polling instead of interrupts as we have no hardware IRQ over FSI. Signed-off-by: Eddie James --- drivers/i2c/busses/i2c-fsi.c | 195 ++- 1 file changed, 193 insertions(+), 2 deletions(-) diff

[PATCH v10 1/7] dt-bindings: i2c: Add FSI-attached I2C master dt binding documentation

2018-06-13 Thread Eddie James
Document the bindings. Signed-off-by: Eddie James > Acked-by: Rob Herring --- Documentation/devicetree/bindings/i2c/i2c-fsi.txt | 40 +++ 1 file changed, 40 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/i2c-fsi.txt diff --git

[PATCH v10 4/7] i2c: fsi: Add abort and hardware reset procedures

2018-06-13 Thread Eddie James
Add abort procedure for failed transfers. Add engine and bus reset procedures to recover from as many faults as possible. Signed-off-by: Eddie James --- drivers/i2c/busses/i2c-fsi.c | 179 +++ 1 file changed, 179 insertions(+) diff --git

[PATCH v10 0/7] i2c: Add FSI-attached I2C master algorithm

2018-06-13 Thread Eddie James
This series adds an algorithm for an I2C master physically located on an FSI slave device. The I2C master has multiple ports, each of which may be connected to an I2C slave. Access to the I2C master registers is achieved over FSI bus. Due to the multi-port nature of the I2C master, the driver

[PATCH v10 3/7] i2c: fsi: Add port structures

2018-06-13 Thread Eddie James
Add and initialize I2C adapters for each port on the FSI-attached I2C master. Ports for each master are defined in the devicetree. Signed-off-by: Eddie James --- drivers/i2c/busses/i2c-fsi.c | 90 1 file changed, 90 insertions(+) diff --git

Re: OOPSes in mem_cgroup_protected

2018-06-13 Thread John Stultz
On Tue, Jun 12, 2018 at 9:33 PM, Roman Gushchin wrote: > On Tue, Jun 12, 2018 at 09:08:27PM -0700, John Stultz wrote: >> On Tue, Jun 12, 2018 at 6:02 PM, John Stultz wrote: >> > Hey Tejun, >> > With the current linus/master, I'm able to fairly regularly trip >> > OOPSes (two examples below) in

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Mathieu Poirier
On 13 June 2018 at 11:07, Suzuki K Poulose wrote: > Hi Matt, > > On 13/06/18 16:47, Matt Sealey wrote: >> >> Hi Suzuki, >> Why not use “unit”? I believe we had this discussion years ago about numbering serial ports and sdhci (i.e. how do you know it’s UART0 or UART1 from just

Re: [PATCH] mm, page_alloc: actually ignore mempolicies for high priority allocations

2018-06-13 Thread David Rientjes
On Tue, 12 Jun 2018, Vlastimil Babka wrote: > The __alloc_pages_slowpath() function has for a long time contained code to > ignore node restrictions from memory policies for high priority allocations. > The current code that resets the zonelist iterator however does effectively > nothing after

[PATCH] nds32: Fix build error caused by incomplete configuration flag rename

2018-06-13 Thread Guenter Roeck
GENERIC_ASHLDI3, GENERIC_ASHRDI3, and GENERIC_LSHRDI3 were renamed to GENERIC_LIB_ASHLDI3, GENERIC_LIB_ASHRDI3, and GENERIC_LIB_LSHRDI3 without making the matching changes in arch/nds32. This results in the following build errors. nds32le-linux-ld: kernel/time/timekeeping.o: in function

Re: [PATCH 1/5] ARM: dts: cygnus: Fix I2C controller interrupt type

2018-06-13 Thread Florian Fainelli
On 06/12/2018 01:21 PM, Ray Jui wrote: > Fix I2C controller interrupt to use IRQ_TYPE_LEVEL_HIGH for Broadcom > Cygnus SoC > > Fixes: b51c05a331ff ("ARM: dts: add I2C device nodes for Broadcom Cygnus") This appears to be the only one that is truly needed here, the two others below probably just

Re: [PATCH 2/5] ARM: dts: cygnus: Fix PCIe controller interrupt type

2018-06-13 Thread Florian Fainelli
On 06/12/2018 01:21 PM, Ray Jui wrote: > Fix PCIe controller interrupt to use IRQ_TYPE_LEVEL_HIGH for Broadcom > Cygnus SoC > > Fixes: cd590b50a936 ("ARM: dts: enable PCIe support for Cygnus") This one is valid > Fixes: 0f0b21a83ad2 ("ARM: dts: Move all Cygnus peripherals into axi > bus") >

Re: OOPSes in mem_cgroup_protected

2018-06-13 Thread Roman Gushchin
On Wed, Jun 13, 2018 at 12:40:23PM -0700, John Stultz wrote: > On Tue, Jun 12, 2018 at 9:33 PM, Roman Gushchin wrote: > > On Tue, Jun 12, 2018 at 09:08:27PM -0700, John Stultz wrote: > >> On Tue, Jun 12, 2018 at 6:02 PM, John Stultz > >> wrote: > >> > Hey Tejun, > >> > With the current

Re: OpenAFS module libafs.ko uses GPL-only symbol '__put_devmap_managed_page'

2018-06-13 Thread Dan Williams
[ adding Andrew, Christoph, and linux-mm ] On Wed, Jun 13, 2018 at 12:33 PM, Joe Gorse wrote: > Greetings, > > Please CC answers & comments to this email. Thanks! =) > > Our build is breaking as of > commit e7638488434415aa478e78435cac8f0365737638 > Author: Dan Williams > Date: Wed May 16

Re: Restartable Sequences system call merged into Linux

2018-06-13 Thread Mathieu Desnoyers
- On Jun 13, 2018, at 12:14 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - On Jun 13, 2018, at 7:48 AM, heiko carstens heiko.carst...@de.ibm.com > wrote: [...] >> >> Is there any documentation available of what is the exact semantics of the >> functions that have to be

Re: [PATCH 1/2] perf record: Support s390 random socket_id assignment

2018-06-13 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 11, 2018 at 09:31:52AM +0200, Thomas Richter escreveu: > On s390 the socket identifier assigned to a CPU identifier is > random and (depending on the configuration of the LPAR) may be higher > than the CPU identifier. This is currently not supported. > > Fix this by allowing arbitrary

Re: [PATCH] perf report powerpc: Fix crash if callchain is empty

2018-06-13 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 12, 2018 at 09:28:09AM +0530, Ravi Bangoria escreveu: > On 06/11/2018 04:10 PM, Sandipan Das wrote: > > For some cases, the callchain provided by the kernel may be > > empty. So, the callchain ip filtering code will cause a crash > > if we do not check whether the struct ip_callchain

Re: [PATCH V6] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-13 Thread Daniel Lezcano
On 13/06/2018 17:54, Pandruvada, Srinivas wrote: > On Tue, 2018-06-12 at 14:00 +0200, Daniel Lezcano wrote: >> Initially, the cpu_cooling device for ARM was changed by adding a new >> policy inserting idle cycles. The intel_powerclamp driver does a >> similar action. >> >> Instead of implementing

Re: [PATCH 2/2] perf tests: Add valid callback for parse-events test

2018-06-13 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 11, 2018 at 11:34:22AM +0200, Jiri Olsa escreveu: > Adding optional 'valid' callback for events tests in > parse-events object, so we don't try to parse PMUs, > which are not supported. > > Following line is displayed for skipped test: > > running test 52 'intel_pt//u'... SKIP

<    4   5   6   7   8   9   10   11   >