Re: [PATCH v4 4/5] mtd: rawnand: denali_dt: add more clocks based on IP datasheet

2018-06-22 Thread Boris Brezillon
On Sat, 23 Jun 2018 01:06:37 +0900 Masahiro Yamada wrote: > Currently, denali_dt.c requires a single anonymous clock, but > the Denali User's Guide requires three clocks for this IP: > > - clk: controller core clock > > - clk_x: bus interface clock > > - ecc_clk: clock at which ECC

Re: [PATCH] soc: qcom: geni: Make version macros simpler

2018-06-22 Thread Bjorn Andersson
On Fri 18 May 15:47 PDT 2018, Stephen Boyd wrote: > This macro doesn't work, because it hides a local variable inside of the > macro to hold the version and that variable name is called 'ver' and > 'version' sometimes. > > Let's change this to be more explicit. Introduce three macros for the >

Re: [PATCH] soc: qcom: geni: Make version macros simpler

2018-06-22 Thread Bjorn Andersson
On Fri 18 May 15:47 PDT 2018, Stephen Boyd wrote: > This macro doesn't work, because it hides a local variable inside of the > macro to hold the version and that variable name is called 'ver' and > 'version' sometimes. > > Let's change this to be more explicit. Introduce three macros for the >

Re: [PATCH v4 3/5] dt-binding: mtd: denali_dt: document clock property

2018-06-22 Thread Boris Brezillon
On Sat, 23 Jun 2018 01:06:36 +0900 Masahiro Yamada wrote: > Commit 30f9f2fb7ba0 ("mtd: denali: add a DT driver") supported the > clock enablement, but did not document it in the DT binding. > > In addition to the existing clock, this commit adds more clocks based > on the IP specification. > >

Re: [PATCH v4 3/5] dt-binding: mtd: denali_dt: document clock property

2018-06-22 Thread Boris Brezillon
On Sat, 23 Jun 2018 01:06:36 +0900 Masahiro Yamada wrote: > Commit 30f9f2fb7ba0 ("mtd: denali: add a DT driver") supported the > clock enablement, but did not document it in the DT binding. > > In addition to the existing clock, this commit adds more clocks based > on the IP specification. > >

Re: [PATCH v7 03/10] docs: Add Generic Counter interface documentation

2018-06-22 Thread Jonathan Cameron
On Thu, 21 Jun 2018 17:07:30 -0400 William Breathitt Gray wrote: > This patch adds high-level documentation about the Generic Counter > interface. > > Signed-off-by: William Breathitt Gray Reviewed-by: Jonathan Cameron > --- > Documentation/driver-api/generic-counter.rst | 342

Re: [PATCH v7 03/10] docs: Add Generic Counter interface documentation

2018-06-22 Thread Jonathan Cameron
On Thu, 21 Jun 2018 17:07:30 -0400 William Breathitt Gray wrote: > This patch adds high-level documentation about the Generic Counter > interface. > > Signed-off-by: William Breathitt Gray Reviewed-by: Jonathan Cameron > --- > Documentation/driver-api/generic-counter.rst | 342

Re: [PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c

2018-06-22 Thread Bjorn Andersson
On Wed 13 Jun 10:50 PDT 2018, Douglas Anderson wrote: > In an early version of the I2C patch that was posted to the list the > default I2C frequency (if none was specified) was 400 kHz. There was > debate on the list and we decided that it would be more consistent > with the rest of i2c if we

Re: [PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c

2018-06-22 Thread Bjorn Andersson
On Wed 13 Jun 10:50 PDT 2018, Douglas Anderson wrote: > In an early version of the I2C patch that was posted to the list the > default I2C frequency (if none was specified) was 400 kHz. There was > debate on the list and we decided that it would be more consistent > with the rest of i2c if we

Re: [PATCH REBASED RESEND] x86/cpu: Move early cpu initialization into a separate translation unit

2018-06-22 Thread Thomas Gleixner
On Fri, 22 Jun 2018, Peter Zijlstra wrote: > On Fri, Jun 22, 2018 at 06:16:05PM +0200, Thomas Gleixner wrote: > > On Fri, 22 Jun 2018, Kirill A. Shutemov wrote: > > > On Fri, Jun 22, 2018 at 03:35:18PM +, Thomas Gleixner wrote: > > > > > How is that supposed to work correctly? > > > > > > >

Re: [PATCH REBASED RESEND] x86/cpu: Move early cpu initialization into a separate translation unit

2018-06-22 Thread Thomas Gleixner
On Fri, 22 Jun 2018, Peter Zijlstra wrote: > On Fri, Jun 22, 2018 at 06:16:05PM +0200, Thomas Gleixner wrote: > > On Fri, 22 Jun 2018, Kirill A. Shutemov wrote: > > > On Fri, Jun 22, 2018 at 03:35:18PM +, Thomas Gleixner wrote: > > > > > How is that supposed to work correctly? > > > > > > >

Re: [PATCH v4 1/5] mtd: rawnand: denali_dt: set clk_x_rate to 200 MHz unconditionally

2018-06-22 Thread Boris Brezillon
On Sat, 23 Jun 2018 01:06:34 +0900 Masahiro Yamada wrote: > Since commit 1bb88666775e ("mtd: nand: denali: handle timing parameters > by setup_data_interface()"), denali_dt.c gets the clock rate from the > clock driver. The driver expects the frequency of the bus interface > clock, whereas the

Re: [PATCH v4 1/5] mtd: rawnand: denali_dt: set clk_x_rate to 200 MHz unconditionally

2018-06-22 Thread Boris Brezillon
On Sat, 23 Jun 2018 01:06:34 +0900 Masahiro Yamada wrote: > Since commit 1bb88666775e ("mtd: nand: denali: handle timing parameters > by setup_data_interface()"), denali_dt.c gets the clock rate from the > clock driver. The driver expects the frequency of the bus interface > clock, whereas the

[PATCH v3 1/4] tpm: rename tpm_chip_find_get() to tpm_get_ops()

2018-06-22 Thread Stefan Berger
Rename tpm_chip_find_get() to tpm_get_ops(). This now matches the name of its counter part tpm_put_ops() better. Signed-off-by: Stefan Berger --- drivers/char/tpm/tpm-chip.c | 4 ++-- drivers/char/tpm/tpm-interface.c | 14 +++--- drivers/char/tpm/tpm.h | 2 +- 3 files

[PATCH v3 1/4] tpm: rename tpm_chip_find_get() to tpm_get_ops()

2018-06-22 Thread Stefan Berger
Rename tpm_chip_find_get() to tpm_get_ops(). This now matches the name of its counter part tpm_put_ops() better. Signed-off-by: Stefan Berger --- drivers/char/tpm/tpm-chip.c | 4 ++-- drivers/char/tpm/tpm-interface.c | 14 +++--- drivers/char/tpm/tpm.h | 2 +- 3 files

[PATCH v3 2/4] tpm: Implement tpm_chip_find() for other subsystems to find a TPM chip

2018-06-22 Thread Stefan Berger
Implement tpm_chip_find() for other subsystems to find a TPM chip and get a reference to that chip. Signed-off-by: Stefan Berger --- drivers/char/tpm/tpm-chip.c | 27 +++ include/linux/tpm.h | 5 + 2 files changed, 32 insertions(+) diff --git

[PATCH v3 2/4] tpm: Implement tpm_chip_find() for other subsystems to find a TPM chip

2018-06-22 Thread Stefan Berger
Implement tpm_chip_find() for other subsystems to find a TPM chip and get a reference to that chip. Signed-off-by: Stefan Berger --- drivers/char/tpm/tpm-chip.c | 27 +++ include/linux/tpm.h | 5 + 2 files changed, 32 insertions(+) diff --git

[PATCH v3 3/4] ima: Use tpm_chip_find() and call TPM functions with a tpm_chip

2018-06-22 Thread Stefan Berger
Rather than accessing the TPM functions by passing a NULL pointer for the tpm_chip, which causes a lookup for a suitable chip every time, get a hold of a tpm_chip and access the TPM functions using it. Signed-off-by: Stefan Berger --- security/integrity/ima/ima.h| 1 +

[PATCH v3 0/4] Have IMA find and use a tpm_chip until system shutdown

2018-06-22 Thread Stefan Berger
This series of patches converts IMA's usage of the tpm_chip to find a TPM chip initially and use it until the machine is shut down. To do this we need to introduce a kref for the tpm_chip that IMA and all other users of a tpm_chip hold onto until they don't need the TPM chip anymore. Stefan

[PATCH v3 3/4] ima: Use tpm_chip_find() and call TPM functions with a tpm_chip

2018-06-22 Thread Stefan Berger
Rather than accessing the TPM functions by passing a NULL pointer for the tpm_chip, which causes a lookup for a suitable chip every time, get a hold of a tpm_chip and access the TPM functions using it. Signed-off-by: Stefan Berger --- security/integrity/ima/ima.h| 1 +

[PATCH v3 0/4] Have IMA find and use a tpm_chip until system shutdown

2018-06-22 Thread Stefan Berger
This series of patches converts IMA's usage of the tpm_chip to find a TPM chip initially and use it until the machine is shut down. To do this we need to introduce a kref for the tpm_chip that IMA and all other users of a tpm_chip hold onto until they don't need the TPM chip anymore. Stefan

[PATCH v3 4/4] ima: Get rid of ima_used_chip and use ima_tpm_chip != NULL instead

2018-06-22 Thread Stefan Berger
Get rid of ima_used_chip and use ima_tpm_chip variable instead for determining whether to use the TPM chip. Signed-off-by: Stefan Berger --- security/integrity/ima/ima.h| 1 - security/integrity/ima/ima_crypto.c | 2 +- security/integrity/ima/ima_init.c | 7 ++-

[PATCH v3 4/4] ima: Get rid of ima_used_chip and use ima_tpm_chip != NULL instead

2018-06-22 Thread Stefan Berger
Get rid of ima_used_chip and use ima_tpm_chip variable instead for determining whether to use the TPM chip. Signed-off-by: Stefan Berger --- security/integrity/ima/ima.h| 1 - security/integrity/ima/ima_crypto.c | 2 +- security/integrity/ima/ima_init.c | 7 ++-

Re: [v2 PATCH 1/2] mm: thp: register mm for khugepaged when merging vma for shmem

2018-06-22 Thread Yang Shi
On 6/22/18 9:19 AM, Kirill A. Shutemov wrote: On Fri, Jun 22, 2018 at 04:04:12PM +, yang@linux.alibaba.com wrote: On 6/22/18 12:59 AM, Kirill A. Shutemov wrote: On Thu, Jun 21, 2018 at 11:15:48PM +, yang@linux.alibaba.com wrote: When merging anonymous page vma, if the size

Re: [v2 PATCH 1/2] mm: thp: register mm for khugepaged when merging vma for shmem

2018-06-22 Thread Yang Shi
On 6/22/18 9:19 AM, Kirill A. Shutemov wrote: On Fri, Jun 22, 2018 at 04:04:12PM +, yang@linux.alibaba.com wrote: On 6/22/18 12:59 AM, Kirill A. Shutemov wrote: On Thu, Jun 21, 2018 at 11:15:48PM +, yang@linux.alibaba.com wrote: When merging anonymous page vma, if the size

Re: [RFC][PATCH 0/6] Use printk_safe context for TTY and UART port locks

2018-06-22 Thread Peter Zijlstra
On Fri, Jun 22, 2018 at 05:21:00PM +0100, Alan Cox wrote: > Really that's all that you need - log the message to whichever console > targets you can currently safely do so. If it's none well there was > always the proposed morse code keyboard light driver 8) Only if your keyboard still has blinky

Re: [PATCH v5 3/5] PCI/AER: Add sysfs attributes to provide breakdown of AERs

2018-06-22 Thread Tyler Baicar
On 6/21/2018 5:25 PM, Rajat Jain wrote: On Thu, Jun 21, 2018 at 11:48 AM, Bjorn Helgaas wrote: [+cc Tyler for AER dmesg decoding] - Tyler posted a patch [1] to update those dmesg strings so they match the way lspci decodes them. I really liked that update, but we never quite finished

Re: [RFC][PATCH 0/6] Use printk_safe context for TTY and UART port locks

2018-06-22 Thread Peter Zijlstra
On Fri, Jun 22, 2018 at 05:21:00PM +0100, Alan Cox wrote: > Really that's all that you need - log the message to whichever console > targets you can currently safely do so. If it's none well there was > always the proposed morse code keyboard light driver 8) Only if your keyboard still has blinky

Re: [PATCH v5 3/5] PCI/AER: Add sysfs attributes to provide breakdown of AERs

2018-06-22 Thread Tyler Baicar
On 6/21/2018 5:25 PM, Rajat Jain wrote: On Thu, Jun 21, 2018 at 11:48 AM, Bjorn Helgaas wrote: [+cc Tyler for AER dmesg decoding] - Tyler posted a patch [1] to update those dmesg strings so they match the way lspci decodes them. I really liked that update, but we never quite finished

Re: [PATCH 2/2] tools/memory-model: Add write ordering by release-acquire and by locks

2018-06-22 Thread Paul E. McKenney
On Fri, Jun 22, 2018 at 12:31:29PM +0200, Peter Zijlstra wrote: > On Fri, Jun 22, 2018 at 10:55:47AM +0100, Will Deacon wrote: > > On Fri, Jun 22, 2018 at 09:09:28AM +0100, Will Deacon wrote: > > > On Thu, Jun 21, 2018 at 01:27:12PM -0400, Alan Stern wrote: > > > > More than one kernel developer

Re: [PATCH 2/2] tools/memory-model: Add write ordering by release-acquire and by locks

2018-06-22 Thread Paul E. McKenney
On Fri, Jun 22, 2018 at 12:31:29PM +0200, Peter Zijlstra wrote: > On Fri, Jun 22, 2018 at 10:55:47AM +0100, Will Deacon wrote: > > On Fri, Jun 22, 2018 at 09:09:28AM +0100, Will Deacon wrote: > > > On Thu, Jun 21, 2018 at 01:27:12PM -0400, Alan Stern wrote: > > > > More than one kernel developer

Re: [PATCH REBASED RESEND] x86/cpu: Move early cpu initialization into a separate translation unit

2018-06-22 Thread Peter Zijlstra
On Fri, Jun 22, 2018 at 06:16:05PM +0200, Thomas Gleixner wrote: > On Fri, 22 Jun 2018, Kirill A. Shutemov wrote: > > On Fri, Jun 22, 2018 at 03:35:18PM +, Thomas Gleixner wrote: > > > How is that supposed to work correctly? > > > > > > start_kernel() > > > > > > trap_init() > > >

Re: [PATCH REBASED RESEND] x86/cpu: Move early cpu initialization into a separate translation unit

2018-06-22 Thread Peter Zijlstra
On Fri, Jun 22, 2018 at 06:16:05PM +0200, Thomas Gleixner wrote: > On Fri, 22 Jun 2018, Kirill A. Shutemov wrote: > > On Fri, Jun 22, 2018 at 03:35:18PM +, Thomas Gleixner wrote: > > > How is that supposed to work correctly? > > > > > > start_kernel() > > > > > > trap_init() > > >

RE: [PATCH 6/7] irqchip/gic-v3-its: Honor hypervisor enforced LPI range

2018-06-22 Thread Shameerali Kolothum Thodi
Hi Marc, > -Original Message- > From: Marc Zyngier [mailto:marc.zyng...@arm.com] > Sent: 20 June 2018 14:53 > To: linux-kernel@vger.kernel.org > Cc: Thomas Gleixner ; Ard Biesheuvel > ; Shanker Donthineni > ; Shameerali Kolothum Thodi > ; MaJun ; > Laurentiu Tudor ; Lei Zhang > >

RE: [PATCH 6/7] irqchip/gic-v3-its: Honor hypervisor enforced LPI range

2018-06-22 Thread Shameerali Kolothum Thodi
Hi Marc, > -Original Message- > From: Marc Zyngier [mailto:marc.zyng...@arm.com] > Sent: 20 June 2018 14:53 > To: linux-kernel@vger.kernel.org > Cc: Thomas Gleixner ; Ard Biesheuvel > ; Shanker Donthineni > ; Shameerali Kolothum Thodi > ; MaJun ; > Laurentiu Tudor ; Lei Zhang > >

[PATCH] mm: drop VM_BUG_ON from __get_free_pages

2018-06-22 Thread Michal Hocko
From: Michal Hocko There is no real reason to blow up just because the caller doesn't know that __get_free_pages cannot return highmem pages. Simply fix that up silently. Even if we have some confused users such a fixup will not be harmful. Signed-off-by: Michal Hocko --- Hi Andrew, previously

[PATCH] mm: drop VM_BUG_ON from __get_free_pages

2018-06-22 Thread Michal Hocko
From: Michal Hocko There is no real reason to blow up just because the caller doesn't know that __get_free_pages cannot return highmem pages. Simply fix that up silently. Even if we have some confused users such a fixup will not be harmful. Signed-off-by: Michal Hocko --- Hi Andrew, previously

Re: [PATCH v2 0/4] have the vt console preserve unicode characters

2018-06-22 Thread Nicolas Pitre
On Fri, 22 Jun 2018, Alan Cox wrote: > > The other point is a quite pointless assumption that existing scrollback is > > "optimized". Even vgacon mostly uses software scrollback these days, as the > > amount of VGA display memory is really small. > > All of our console driver code is horribly

Re: [PATCH v2 0/4] have the vt console preserve unicode characters

2018-06-22 Thread Nicolas Pitre
On Fri, 22 Jun 2018, Alan Cox wrote: > > The other point is a quite pointless assumption that existing scrollback is > > "optimized". Even vgacon mostly uses software scrollback these days, as the > > amount of VGA display memory is really small. > > All of our console driver code is horribly

[PATCH] i2c-hid: Fix "incomplete report" noise

2018-06-22 Thread Jason Andryuk
Commit ac75a041048b ("HID: i2c-hid: fix size check and type usage") started writing messages when the ret_size is <= 2 from i2c_master_recv. However, my device i2c-DLL07D1 returns 2 for a short period of time (~0.5s) after I stop moving the pointing stick or touchpad. It varies, but you get ~50

[PATCH] i2c-hid: Fix "incomplete report" noise

2018-06-22 Thread Jason Andryuk
Commit ac75a041048b ("HID: i2c-hid: fix size check and type usage") started writing messages when the ret_size is <= 2 from i2c_master_recv. However, my device i2c-DLL07D1 returns 2 for a short period of time (~0.5s) after I stop moving the pointing stick or touchpad. It varies, but you get ~50

Re: [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-06-22 Thread Jerome Glisse
On Fri, Jun 22, 2018 at 04:36:49PM +0100, Chris Wilson wrote: > Quoting Michal Hocko (2018-06-22 16:02:42) > > Hi, > > this is an RFC and not tested at all. I am not very familiar with the > > mmu notifiers semantics very much so this is a crude attempt to achieve > > what I need basically. It

Re: [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-06-22 Thread Jerome Glisse
On Fri, Jun 22, 2018 at 04:36:49PM +0100, Chris Wilson wrote: > Quoting Michal Hocko (2018-06-22 16:02:42) > > Hi, > > this is an RFC and not tested at all. I am not very familiar with the > > mmu notifiers semantics very much so this is a crude attempt to achieve > > what I need basically. It

Re: [PATCH v4 1/4] seccomp: add a return code to trap to userspace

2018-06-22 Thread Jann Horn
On Fri, Jun 22, 2018 at 5:15 PM Tycho Andersen wrote: > > Hi Jann, > > On Fri, Jun 22, 2018 at 04:40:20PM +0200, Jann Horn wrote: > > On Fri, Jun 22, 2018 at 12:05 AM Tycho Andersen wrote: > > > This patch introduces a means for syscalls matched in seccomp to notify > > > some other task that a

Re: [PATCH v4 1/4] seccomp: add a return code to trap to userspace

2018-06-22 Thread Jann Horn
On Fri, Jun 22, 2018 at 5:15 PM Tycho Andersen wrote: > > Hi Jann, > > On Fri, Jun 22, 2018 at 04:40:20PM +0200, Jann Horn wrote: > > On Fri, Jun 22, 2018 at 12:05 AM Tycho Andersen wrote: > > > This patch introduces a means for syscalls matched in seccomp to notify > > > some other task that a

Re: [PATCH v4 4/4] seccomp: add support for passing fds via USER_NOTIF

2018-06-22 Thread Jann Horn
On Fri, Jun 22, 2018 at 12:05 AM Tycho Andersen wrote: > > The idea here is that the userspace handler should be able to pass an fd > back to the trapped task, for example so it can be returned from socket(). > > I've proposed one API here, but I'm open to other options. In particular, > this

Re: [PATCH v4 4/4] seccomp: add support for passing fds via USER_NOTIF

2018-06-22 Thread Jann Horn
On Fri, Jun 22, 2018 at 12:05 AM Tycho Andersen wrote: > > The idea here is that the userspace handler should be able to pass an fd > back to the trapped task, for example so it can be returned from socket(). > > I've proposed one API here, but I'm open to other options. In particular, > this

Re: [RFC][PATCH 0/6] Use printk_safe context for TTY and UART port locks

2018-06-22 Thread Alan Cox
On Wed, 20 Jun 2018 11:44:13 +0900 Linus Torvalds wrote: > On Wed, Jun 20, 2018 at 11:34 AM Steven Rostedt wrote: > > > > Perhaps we should do an audit of the console drivers and remove all > > printk, pr_* , WARN*, BUG* from them. > > Only the actual _printing_ parts. No because they are

Re: [RFC][PATCH 0/6] Use printk_safe context for TTY and UART port locks

2018-06-22 Thread Alan Cox
On Wed, 20 Jun 2018 11:44:13 +0900 Linus Torvalds wrote: > On Wed, Jun 20, 2018 at 11:34 AM Steven Rostedt wrote: > > > > Perhaps we should do an audit of the console drivers and remove all > > printk, pr_* , WARN*, BUG* from them. > > Only the actual _printing_ parts. No because they are

Re: [PATCH v9 4/4] vsprintf: Add command line option debug_boot_weak_hash

2018-06-22 Thread Randy Dunlap
On 06/21/2018 04:15 PM, Tobin C. Harding wrote: > Currently printing [hashed] pointers requires enough entropy to be > available. Early in the boot sequence this may not be the case > resulting in a dummy string '(ptrval)' being printed. This > makes debugging the early boot sequence

Re: [PATCH v9 4/4] vsprintf: Add command line option debug_boot_weak_hash

2018-06-22 Thread Randy Dunlap
On 06/21/2018 04:15 PM, Tobin C. Harding wrote: > Currently printing [hashed] pointers requires enough entropy to be > available. Early in the boot sequence this may not be the case > resulting in a dummy string '(ptrval)' being printed. This > makes debugging the early boot sequence

Re: [PATCH v4 7/7] x86/vdso: Move out the CPU number store

2018-06-22 Thread Thomas Gleixner
On Fri, 22 Jun 2018, Andy Lutomirski wrote: > > On Jun 22, 2018, at 8:18 AM, Thomas Gleixner wrote: > > > >> On Wed, 20 Jun 2018, Chang S. Bae wrote: > >> > >> +#ifdef CONFIG_X86_64 > >> +static void setup_cpu_number(int cpu) > > > > This function name is really misleading.

Re: [PATCH v4 7/7] x86/vdso: Move out the CPU number store

2018-06-22 Thread Thomas Gleixner
On Fri, 22 Jun 2018, Andy Lutomirski wrote: > > On Jun 22, 2018, at 8:18 AM, Thomas Gleixner wrote: > > > >> On Wed, 20 Jun 2018, Chang S. Bae wrote: > >> > >> +#ifdef CONFIG_X86_64 > >> +static void setup_cpu_number(int cpu) > > > > This function name is really misleading.

Re: [v2 PATCH 1/2] mm: thp: register mm for khugepaged when merging vma for shmem

2018-06-22 Thread Kirill A. Shutemov
On Fri, Jun 22, 2018 at 04:04:12PM +, yang@linux.alibaba.com wrote: > > > On 6/22/18 12:59 AM, Kirill A. Shutemov wrote: > > On Thu, Jun 21, 2018 at 11:15:48PM +, yang@linux.alibaba.com wrote: > > > When merging anonymous page vma, if the size of vma can fit in at least > > > one

Re: [v2 PATCH 1/2] mm: thp: register mm for khugepaged when merging vma for shmem

2018-06-22 Thread Kirill A. Shutemov
On Fri, Jun 22, 2018 at 04:04:12PM +, yang@linux.alibaba.com wrote: > > > On 6/22/18 12:59 AM, Kirill A. Shutemov wrote: > > On Thu, Jun 21, 2018 at 11:15:48PM +, yang@linux.alibaba.com wrote: > > > When merging anonymous page vma, if the size of vma can fit in at least > > > one

Re: [PATCH REBASED RESEND] x86/cpu: Move early cpu initialization into a separate translation unit

2018-06-22 Thread Thomas Gleixner
On Fri, 22 Jun 2018, Kirill A. Shutemov wrote: > On Fri, Jun 22, 2018 at 03:35:18PM +, Thomas Gleixner wrote: > > > > Second thoughts. > > > > > > > > The only place where __pgtable_l5_enabled() is used in common.c is in > > > > early_identify_cpu() which is marked __init. So how is that

Re: [PATCH REBASED RESEND] x86/cpu: Move early cpu initialization into a separate translation unit

2018-06-22 Thread Thomas Gleixner
On Fri, 22 Jun 2018, Kirill A. Shutemov wrote: > On Fri, Jun 22, 2018 at 03:35:18PM +, Thomas Gleixner wrote: > > > > Second thoughts. > > > > > > > > The only place where __pgtable_l5_enabled() is used in common.c is in > > > > early_identify_cpu() which is marked __init. So how is that

Re: [PATCH v4 7/7] x86/vdso: Move out the CPU number store

2018-06-22 Thread Andy Lutomirski
> On Jun 22, 2018, at 8:18 AM, Thomas Gleixner wrote: > >> On Wed, 20 Jun 2018, Chang S. Bae wrote: >> >> +#ifdef CONFIG_X86_64 >> +static void setup_cpu_number(int cpu) > > This function name is really misleading. vdso_setup_cpu_and_node() or > something like that clearly tells what this is

Re: [PATCH v4 7/7] x86/vdso: Move out the CPU number store

2018-06-22 Thread Andy Lutomirski
> On Jun 22, 2018, at 8:18 AM, Thomas Gleixner wrote: > >> On Wed, 20 Jun 2018, Chang S. Bae wrote: >> >> +#ifdef CONFIG_X86_64 >> +static void setup_cpu_number(int cpu) > > This function name is really misleading. vdso_setup_cpu_and_node() or > something like that clearly tells what this is

Re: [RFC 2/2] rcu: Remove ->dynticks_nmi_nesting from struct rcu_dynticks

2018-06-22 Thread Paul E. McKenney
On Fri, Jun 22, 2018 at 07:19:13AM -0700, Andy Lutomirski wrote: > On Fri, Jun 22, 2018 at 6:26 AM Paul E. McKenney > wrote: > > > > On Thu, Jun 21, 2018 at 10:56:59PM -0700, Joel Fernandes wrote: > > > Hi Paul, > > > > > > On Wed, Jun 20, 2018 at 09:49:02AM -0700, Paul E. McKenney wrote: > > > >

Re: [RFC 2/2] rcu: Remove ->dynticks_nmi_nesting from struct rcu_dynticks

2018-06-22 Thread Paul E. McKenney
On Fri, Jun 22, 2018 at 07:19:13AM -0700, Andy Lutomirski wrote: > On Fri, Jun 22, 2018 at 6:26 AM Paul E. McKenney > wrote: > > > > On Thu, Jun 21, 2018 at 10:56:59PM -0700, Joel Fernandes wrote: > > > Hi Paul, > > > > > > On Wed, Jun 20, 2018 at 09:49:02AM -0700, Paul E. McKenney wrote: > > > >

Re: [PATCH] kasan: depend on CONFIG_SLUB_DEBUG

2018-06-22 Thread Shakeel Butt
On Fri, Jun 22, 2018 at 8:46 AM Jason A. Donenfeld wrote: > > KASAN depends on having access to some of the accounting that SLUB_DEBUG > does; without it, there are immediate crashes [1]. So, the natural thing > to do is to make KASAN select SLUB_DEBUG. > > [1] >

Re: [PATCH] kasan: depend on CONFIG_SLUB_DEBUG

2018-06-22 Thread Shakeel Butt
On Fri, Jun 22, 2018 at 8:46 AM Jason A. Donenfeld wrote: > > KASAN depends on having access to some of the accounting that SLUB_DEBUG > does; without it, there are immediate crashes [1]. So, the natural thing > to do is to make KASAN select SLUB_DEBUG. > > [1] >

[PATCH v4 5/5] mtd: rawnand: denali: optimize timing parameters for data interface

2018-06-22 Thread Masahiro Yamada
This commit improves the ->setup_data_interface() hook. The denali_setup_data_interface() needs the frequency of clk_x and the ratio of clk_x / clk. The latter is currently hardcoded in the driver, like this: #define DENALI_CLK_X_MULT 6 The IP datasheet requires that clk_x / clk be 4,

[PATCH v4 1/5] mtd: rawnand: denali_dt: set clk_x_rate to 200 MHz unconditionally

2018-06-22 Thread Masahiro Yamada
Since commit 1bb88666775e ("mtd: nand: denali: handle timing parameters by setup_data_interface()"), denali_dt.c gets the clock rate from the clock driver. The driver expects the frequency of the bus interface clock, whereas the clock driver of SOCFPGA provides the core clock. Thus, the

[PATCH v4 5/5] mtd: rawnand: denali: optimize timing parameters for data interface

2018-06-22 Thread Masahiro Yamada
This commit improves the ->setup_data_interface() hook. The denali_setup_data_interface() needs the frequency of clk_x and the ratio of clk_x / clk. The latter is currently hardcoded in the driver, like this: #define DENALI_CLK_X_MULT 6 The IP datasheet requires that clk_x / clk be 4,

[PATCH v4 1/5] mtd: rawnand: denali_dt: set clk_x_rate to 200 MHz unconditionally

2018-06-22 Thread Masahiro Yamada
Since commit 1bb88666775e ("mtd: nand: denali: handle timing parameters by setup_data_interface()"), denali_dt.c gets the clock rate from the clock driver. The driver expects the frequency of the bus interface clock, whereas the clock driver of SOCFPGA provides the core clock. Thus, the

[PATCH v4 3/5] dt-binding: mtd: denali_dt: document clock property

2018-06-22 Thread Masahiro Yamada
Commit 30f9f2fb7ba0 ("mtd: denali: add a DT driver") supported the clock enablement, but did not document it in the DT binding. In addition to the existing clock, this commit adds more clocks based on the IP specification. According to the Denali User's Guide, this IP needs three clocks: -

[PATCH v4 3/5] dt-binding: mtd: denali_dt: document clock property

2018-06-22 Thread Masahiro Yamada
Commit 30f9f2fb7ba0 ("mtd: denali: add a DT driver") supported the clock enablement, but did not document it in the DT binding. In addition to the existing clock, this commit adds more clocks based on the IP specification. According to the Denali User's Guide, this IP needs three clocks: -

Re: [PATCH v4 1/7] x86/fsgsbase/64: Introduce FS/GS base helper functions

2018-06-22 Thread Andy Lutomirski
> On Jun 22, 2018, at 8:39 AM, Thomas Gleixner wrote: > >> On Fri, 22 Jun 2018, Andy Lutomirski wrote: >> On Fri, Jun 22, 2018 at 7:28 AM Thomas Gleixner wrote: +unsigned long read_task_fsbase(struct task_struct *task) +{ + unsigned long fsbase; + + if (task

Re: [PATCH v4 1/7] x86/fsgsbase/64: Introduce FS/GS base helper functions

2018-06-22 Thread Andy Lutomirski
> On Jun 22, 2018, at 8:39 AM, Thomas Gleixner wrote: > >> On Fri, 22 Jun 2018, Andy Lutomirski wrote: >> On Fri, Jun 22, 2018 at 7:28 AM Thomas Gleixner wrote: +unsigned long read_task_fsbase(struct task_struct *task) +{ + unsigned long fsbase; + + if (task

[PATCH v4 0/5] mtd: rawnand: denali: add new clocks and improve setup_data_interface

2018-06-22 Thread Masahiro Yamada
The ->setup_data_interface() hook needs to know the clock frequency. In fact, this IP needs three clocks, but the current driver does not represent it. Thus, it is hard to understand what is the correct clock frequency. (at least, clock property is not described in the DT-binding at all.) This

Re: [lkp-robot] [fs] 3deb642f0d: will-it-scale.per_process_ops -8.8% regression

2018-06-22 Thread Christoph Hellwig
On Fri, Jun 22, 2018 at 05:28:50PM +0200, Christoph Hellwig wrote: > On Fri, Jun 22, 2018 at 04:14:09PM +0100, Al Viro wrote: > > > > > > http://git.infradead.org/users/hch/vfs.git/shortlog/refs/heads/remove-get-poll-head > > > > See objections upthread re "fs,net: move poll busy loop

[PATCH v4 2/5] mtd: rawnand: denali_dt: use dev as a shorthand of >dev

2018-06-22 Thread Masahiro Yamada
The probe function references >dev many times, and I will add more soon. Add 'dev' as a shorthand. Signed-off-by: Masahiro Yamada Acked-by: Miquel Raynal Reviewed-by: Richard Weinberger Tested-by: Richard Weinberger Reviewed-by: Boris Brezillon --- Changes in v4: None Changes in v3: None

[PATCH v4 0/5] mtd: rawnand: denali: add new clocks and improve setup_data_interface

2018-06-22 Thread Masahiro Yamada
The ->setup_data_interface() hook needs to know the clock frequency. In fact, this IP needs three clocks, but the current driver does not represent it. Thus, it is hard to understand what is the correct clock frequency. (at least, clock property is not described in the DT-binding at all.) This

Re: [lkp-robot] [fs] 3deb642f0d: will-it-scale.per_process_ops -8.8% regression

2018-06-22 Thread Christoph Hellwig
On Fri, Jun 22, 2018 at 05:28:50PM +0200, Christoph Hellwig wrote: > On Fri, Jun 22, 2018 at 04:14:09PM +0100, Al Viro wrote: > > > > > > http://git.infradead.org/users/hch/vfs.git/shortlog/refs/heads/remove-get-poll-head > > > > See objections upthread re "fs,net: move poll busy loop

[PATCH v4 2/5] mtd: rawnand: denali_dt: use dev as a shorthand of >dev

2018-06-22 Thread Masahiro Yamada
The probe function references >dev many times, and I will add more soon. Add 'dev' as a shorthand. Signed-off-by: Masahiro Yamada Acked-by: Miquel Raynal Reviewed-by: Richard Weinberger Tested-by: Richard Weinberger Reviewed-by: Boris Brezillon --- Changes in v4: None Changes in v3: None

[PATCH v4 4/5] mtd: rawnand: denali_dt: add more clocks based on IP datasheet

2018-06-22 Thread Masahiro Yamada
Currently, denali_dt.c requires a single anonymous clock, but the Denali User's Guide requires three clocks for this IP: - clk: controller core clock - clk_x: bus interface clock - ecc_clk: clock at which ECC circuitry is run This commit supports these named clocks to represent the real

[PATCH v4 4/5] mtd: rawnand: denali_dt: add more clocks based on IP datasheet

2018-06-22 Thread Masahiro Yamada
Currently, denali_dt.c requires a single anonymous clock, but the Denali User's Guide requires three clocks for this IP: - clk: controller core clock - clk_x: bus interface clock - ecc_clk: clock at which ECC circuitry is run This commit supports these named clocks to represent the real

Re: [v2 PATCH 1/2] mm: thp: register mm for khugepaged when merging vma for shmem

2018-06-22 Thread Yang Shi
On 6/22/18 12:59 AM, Kirill A. Shutemov wrote: On Thu, Jun 21, 2018 at 11:15:48PM +, yang@linux.alibaba.com wrote: When merging anonymous page vma, if the size of vma can fit in at least one hugepage, the mm will be registered for khugepaged for collapsing THP in the future. But, it

Re: [v2 PATCH 1/2] mm: thp: register mm for khugepaged when merging vma for shmem

2018-06-22 Thread Yang Shi
On 6/22/18 12:59 AM, Kirill A. Shutemov wrote: On Thu, Jun 21, 2018 at 11:15:48PM +, yang@linux.alibaba.com wrote: When merging anonymous page vma, if the size of vma can fit in at least one hugepage, the mm will be registered for khugepaged for collapsing THP in the future. But, it

Re: [PATCH 1/2] IB/hfi1: Try slot reset before secondary bus reset

2018-06-22 Thread Sinan Kaya
On 6/22/2018 10:01 AM, Bjorn Helgaas wrote: >> Since Oza's DPC/AER patch to refactor fatal error handling, both >> hotplug driver and AER/DPC driver will try removing devices and >> perform enumeration on link events/AER events. >> >> Perfect environment for race condition without a change. >

Re: [PATCH 1/2] IB/hfi1: Try slot reset before secondary bus reset

2018-06-22 Thread Sinan Kaya
On 6/22/2018 10:01 AM, Bjorn Helgaas wrote: >> Since Oza's DPC/AER patch to refactor fatal error handling, both >> hotplug driver and AER/DPC driver will try removing devices and >> perform enumeration on link events/AER events. >> >> Perfect environment for race condition without a change. >

Re: KVM guest sometimes failed to boot because of kernel stack overflow if KPTI is enabled on a hisilicon ARM64 platform.

2018-06-22 Thread Wei Xu
Hi Will, Mark, On 2018/6/22 23:41, Will Deacon wrote: On Fri, Jun 22, 2018 at 11:28:21PM +0800, Wei Xu wrote: On 2018/6/22 22:28, Mark Rutland wrote: On Fri, Jun 22, 2018 at 09:18:27PM +0800, Wei Xu wrote: [0.227507] Mem abort info: [0.230390] ESR = 0x9606 [

Re: KVM guest sometimes failed to boot because of kernel stack overflow if KPTI is enabled on a hisilicon ARM64 platform.

2018-06-22 Thread Wei Xu
Hi Will, Mark, On 2018/6/22 23:41, Will Deacon wrote: On Fri, Jun 22, 2018 at 11:28:21PM +0800, Wei Xu wrote: On 2018/6/22 22:28, Mark Rutland wrote: On Fri, Jun 22, 2018 at 09:18:27PM +0800, Wei Xu wrote: [0.227507] Mem abort info: [0.230390] ESR = 0x9606 [

Re: [PATCH 7/7] x86,idle: do not leave mm in idle state

2018-06-22 Thread Andy Lutomirski
Hmm, fair enough. I think a better heuristic would be if the estimated idle duration is more than, say, 10ms. I *think* the code has been cleaned up enough that this is easy now. (Using time instead of C6 will make it a lot less dependent on which idle driver is in use.) On Fri, Jun 22, 2018 at

Re: [PATCH 7/7] x86,idle: do not leave mm in idle state

2018-06-22 Thread Andy Lutomirski
Hmm, fair enough. I think a better heuristic would be if the estimated idle duration is more than, say, 10ms. I *think* the code has been cleaned up enough that this is easy now. (Using time instead of C6 will make it a lot less dependent on which idle driver is in use.) On Fri, Jun 22, 2018 at

Re: [RFC 2/2] rcu: Remove ->dynticks_nmi_nesting from struct rcu_dynticks

2018-06-22 Thread Steven Rostedt
On Fri, 22 Jun 2018 06:28:43 -0700 "Paul E. McKenney" wrote: > It has been some years since I traced the code flow, but what happened > back then is that it switches itself from an interrupt handler to not > without actually returning from the interrupt. This can only happen when > interrupting

Re: [RFC 2/2] rcu: Remove ->dynticks_nmi_nesting from struct rcu_dynticks

2018-06-22 Thread Steven Rostedt
On Fri, 22 Jun 2018 06:28:43 -0700 "Paul E. McKenney" wrote: > It has been some years since I traced the code flow, but what happened > back then is that it switches itself from an interrupt handler to not > without actually returning from the interrupt. This can only happen when > interrupting

[tip:x86/urgent] MAINTAINERS: Add file patterns for x86 device tree bindings

2018-06-22 Thread tip-bot for Geert Uytterhoeven
Commit-ID: 48e315618dc4dc8904182cd221e3d395d5d97005 Gitweb: https://git.kernel.org/tip/48e315618dc4dc8904182cd221e3d395d5d97005 Author: Geert Uytterhoeven AuthorDate: Fri, 22 Jun 2018 12:08:20 +0200 Committer: Thomas Gleixner CommitDate: Fri, 22 Jun 2018 17:58:32 +0200 MAINTAINERS:

[tip:x86/urgent] MAINTAINERS: Add file patterns for x86 device tree bindings

2018-06-22 Thread tip-bot for Geert Uytterhoeven
Commit-ID: 48e315618dc4dc8904182cd221e3d395d5d97005 Gitweb: https://git.kernel.org/tip/48e315618dc4dc8904182cd221e3d395d5d97005 Author: Geert Uytterhoeven AuthorDate: Fri, 22 Jun 2018 12:08:20 +0200 Committer: Thomas Gleixner CommitDate: Fri, 22 Jun 2018 17:58:32 +0200 MAINTAINERS:

Re: [PATCH v2 0/4] have the vt console preserve unicode characters

2018-06-22 Thread Alan Cox
> The other point is a quite pointless assumption that existing scrollback is > "optimized". Even vgacon mostly uses software scrollback these days, as the > amount of VGA display memory is really small. All of our console driver code is horribly unoptimized for most of todays hardware. Long ago

Re: [PATCH v2 0/4] have the vt console preserve unicode characters

2018-06-22 Thread Alan Cox
> The other point is a quite pointless assumption that existing scrollback is > "optimized". Even vgacon mostly uses software scrollback these days, as the > amount of VGA display memory is really small. All of our console driver code is horribly unoptimized for most of todays hardware. Long ago

Re: [PATCH] kasan: depend on CONFIG_SLUB_DEBUG

2018-06-22 Thread Michal Hocko
On Fri 22-06-18 17:46:23, Jason A. Donenfeld wrote: > KASAN depends on having access to some of the accounting that SLUB_DEBUG > does; without it, there are immediate crashes [1]. So, the natural thing > to do is to make KASAN select SLUB_DEBUG. > > [1] >

Re: [PATCH] arm: dts: socfpga: denali needs nand_x_clk too

2018-06-22 Thread Richard Weinberger
Masahiro, Am Freitag, 22. Juni 2018, 16:37:21 CEST schrieb Masahiro Yamada: > Hi Richard, > > > 2018-06-19 21:07 GMT+09:00 Richard Weinberger : > > The denali NAND flash controller needs at least two clocks to operate, > > nand_clk and nand_x_clk. > > Since 1bb88666775e ("mtd: nand: denali:

Re: [PATCH REBASED RESEND] x86/cpu: Move early cpu initialization into a separate translation unit

2018-06-22 Thread Kirill A. Shutemov
On Fri, Jun 22, 2018 at 03:35:18PM +, Thomas Gleixner wrote: > On Fri, 22 Jun 2018, Kirill A. Shutemov wrote: > > On Fri, Jun 22, 2018 at 02:05:47PM +, Thomas Gleixner wrote: > > > On Tue, 12 Jun 2018, Kirill A. Shutemov wrote: > > > > > > > __pgtable_l5_enabled shouldn't be needed after

Re: [PATCH] kasan: depend on CONFIG_SLUB_DEBUG

2018-06-22 Thread Michal Hocko
On Fri 22-06-18 17:46:23, Jason A. Donenfeld wrote: > KASAN depends on having access to some of the accounting that SLUB_DEBUG > does; without it, there are immediate crashes [1]. So, the natural thing > to do is to make KASAN select SLUB_DEBUG. > > [1] >

Re: [PATCH] arm: dts: socfpga: denali needs nand_x_clk too

2018-06-22 Thread Richard Weinberger
Masahiro, Am Freitag, 22. Juni 2018, 16:37:21 CEST schrieb Masahiro Yamada: > Hi Richard, > > > 2018-06-19 21:07 GMT+09:00 Richard Weinberger : > > The denali NAND flash controller needs at least two clocks to operate, > > nand_clk and nand_x_clk. > > Since 1bb88666775e ("mtd: nand: denali:

Re: [PATCH REBASED RESEND] x86/cpu: Move early cpu initialization into a separate translation unit

2018-06-22 Thread Kirill A. Shutemov
On Fri, Jun 22, 2018 at 03:35:18PM +, Thomas Gleixner wrote: > On Fri, 22 Jun 2018, Kirill A. Shutemov wrote: > > On Fri, Jun 22, 2018 at 02:05:47PM +, Thomas Gleixner wrote: > > > On Tue, 12 Jun 2018, Kirill A. Shutemov wrote: > > > > > > > __pgtable_l5_enabled shouldn't be needed after

Re: [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-06-22 Thread Michal Hocko
On Fri 22-06-18 16:36:49, Chris Wilson wrote: > Quoting Michal Hocko (2018-06-22 16:02:42) > > Hi, > > this is an RFC and not tested at all. I am not very familiar with the > > mmu notifiers semantics very much so this is a crude attempt to achieve > > what I need basically. It might be completely

<    1   2   3   4   5   6   7   8   9   10   >