Re: [RFC v3 PATCH 5/5] x86: check VM_DEAD flag in page fault

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 10:24:27, Yang Shi wrote: > > > On 7/2/18 6:37 AM, Michal Hocko wrote: > > On Mon 02-07-18 15:33:11, Laurent Dufour wrote: > > > > > > On 02/07/2018 14:45, Michal Hocko wrote: > > > > On Mon 02-07-18 14:26:09, Laurent Dufour wrote: > > > > > On 02/07/2018 14:15, Michal Hocko

[PATCH] /dev/mem: Mark expected switch fall-through

2018-07-02 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/char/mem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/mem.c b/drivers/char/mem.c index ffeb60d..4b00d6a 100644 ---

Re: [PATCH] ARC: prevent showing irrelevant exception info in signal message

2018-07-02 Thread Vineet Gupta
+CC Al On 06/29/2018 12:39 PM, Eugeniy Paltsev wrote: > We process signals in the end of syscall/exception handler. > It the signal is fatal we print register's content using > show_regs function. show_regs() also prints information about > last exception happened. > > In case of multicore system

Re: [RFC v3 PATCH 3/5] mm: refactor do_munmap() to extract the common part

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 09:59:06, Yang Shi wrote: > > > On 7/2/18 6:42 AM, Michal Hocko wrote: > > On Sat 30-06-18 06:39:43, Yang Shi wrote: > > > Introduces two new helper functions: > > >* munmap_addr_sanity() > > >* munmap_lookup_vma() > > > > > > They will be used by do_munmap() and the new

[PATCH v2 3/8] arm64/kernel: jump_label: switch to relative references

2018-07-02 Thread Ard Biesheuvel
On a randomly chosen distro kernel build for arm64, vmlinux.o shows the following sections, containing jump label entries, and the associated RELA relocation records, respectively: ... [38088] __jump_table PROGBITS 00e19f30 0002ea10

Re: [PATCH v10 4/7] i2c: fsi: Add abort and hardware reset procedures

2018-07-02 Thread Wolfram Sang
Hi Eddie, > > I think this is a way too aggressive recovery. Your are doing the 9 > > pulse toggles basically on any error while this is only when the device > > keeps SDA low and you want to recover from that. If SDA is not stuck > > low, sending a STOP should do. Or do you have a known case

[PATCH v2 1/8] kernel/jump_label: abstract jump_entry member accessors

2018-07-02 Thread Ard Biesheuvel
In preparation of allowing architectures to use relative references in jump_label entries [which can dramatically reduce the memory footprint], introduce abstractions for references to the 'code', 'target' and 'key' members of struct jump_entry. Signed-off-by: Ard Biesheuvel ---

Re: [PATCH 1/2] Revert "UBIFS: Fix potential integer overflow in allocation"

2018-07-02 Thread Kees Cook
On Mon, Jul 2, 2018 at 10:50 AM, Richard Weinberger wrote: > Am Montag, 2. Juli 2018, 18:00:05 CEST schrieb Kees Cook: >> On Sun, Jul 1, 2018 at 2:20 PM, Richard Weinberger wrote: >> > This reverts commit 353748a359f1821ee934afc579cf04572406b420. >> > It bypassed the linux-mtd review process and

Re: [PATCH v4 2/6] dt: qcom: 8996: thermal: Move to DT initialisation

2018-07-02 Thread Bjorn Andersson
On Mon 02 Jul 05:44 PDT 2018, Amit Kucheria wrote: > We also split up the regmap address space into two, one for the TM > registers, the other for the SROT registers. This was required to deal with > different address offsets for the TM and SROT registers across different > SoC families. > >

[PATCH] Drivers: hv: hv_kvp: Mark expected switch fall-through

2018-07-02 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/hv/hv_kvp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hv/hv_kvp.c b/drivers/hv/hv_kvp.c index 5eed1e7..9b1adcb 100644 ---

Re: [RFC PATCH for 4.18 1/2] rseq: validate rseq_cs fields are < TASK_SIZE

2018-07-02 Thread Mathieu Desnoyers
- On Jul 2, 2018, at 1:11 PM, Andy Lutomirski l...@amacapital.net wrote: > > But I think that the limited solution of changing > instruction_pointer_set() really is a sufficient > architecture-dependent change to fully solve your problem. So let me recap with the changes I gather for 4.18

[PATCH] staging: rtl8188eu: remove rtw_mp_phy_regdef.h

2018-07-02 Thread Michael Straube
The header rtw_mp_phy_regdef.h is not used anywhere. 'git grep rtw_mp_phy_regdef.h' returns nothing, remove the file. Signed-off-by: Michael Straube --- .../rtl8188eu/include/rtw_mp_phy_regdef.h | 1078 - 1 file changed, 1078 deletions(-) delete mode 100644

Re: [v7,07/10] dt-bindings: counter: Document stm32 quadrature encoder

2018-07-02 Thread David Lechner
On 06/21/2018 04:08 PM, William Breathitt Gray wrote: From: Benjamin Gaignard Add bindings for STM32 Timer quadrature encoder. It is a sub-node of STM32 Timer which implement the quadratic encoder part of the hardware. quadradic? or quadrature? Cc: Rob Herring Cc: Mark Rutland

[PATCH v5] add param that allows bootline control of hardened usercopy

2018-07-02 Thread Chris von Recklinghausen
From: Chris von Recklinghausen Enabling HARDENED_USERCOPY causes measurable regressions in networking performance, up to 8% under UDP flood. I'm running an a small packet UDP flood using pktgen vs. a host b2b connected. On the receiver side the UDP packets are processed by a simple user space

Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig

2018-07-02 Thread Randy Dunlap
On 07/02/18 13:03, Randy Dunlap wrote: > On 07/02/18 07:47, Christoph Hellwig wrote: >> Instead of duplicating the source statements in every architecture just >> do it once in the toplevel Kconfig file. >> >> Signed-off-by: Christoph Hellwig >> --- >> Kconfig | 22

Re: [PATCH v4] ata: Remove depends on HAS_DMA in case of platform dependency

2018-07-02 Thread Tejun Heo
On Fri, Jun 22, 2018 at 01:03:07PM +0200, Geert Uytterhoeven wrote: > Remove dependencies on HAS_DMA where a Kconfig symbol depends on another > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". > In most cases this other symbol is an architecture or platform specific > symbol,

[PATCH v2 3/7] tracing: Generalize hist trigger onmax and save action

2018-07-02 Thread Tom Zanussi
From: Tom Zanussi The action refactor code allowed actions and handlers to be separated, but the existing onmax handler and save action code is still not flexible enough to handle arbitrary coupling. This change generalizes them and in the process makes additional handlers and actions easier to

[PATCH v2 1/7] tracing: Refactor hist trigger action code

2018-07-02 Thread Tom Zanussi
From: Tom Zanussi The hist trigger action code currently implements two essentially hard-coded pairs of 'actions' - onmax(), which tracks a variable and saves some event fields when a max is hit, and onmatch(), which is hard-coded to generate a synthetic event. These hardcoded pairs (track

Re: [PATCH] leds: max8997: use mode when calling max8997_led_set_mode

2018-07-02 Thread Jacek Anaszewski
Hi Colin, Thank you for the patch. On 07/02/2018 06:50 PM, Colin King wrote: From: Colin Ian King Variable mode is assigned to pdata->led_pdata->mode[led->id] and yet is not being used when calling function max8997_led_set_mode. Fix this by using mode when calling max8997_led_set_mode.

Re: [PATCH] security: CONFIG_HARDENED_USERCOPY does not need to select BUG

2018-07-02 Thread Kees Cook
Hi Kamal, On Mon, Jul 2, 2018 at 1:14 PM, Kamal Mostafa wrote: > On Fri, Jun 29, 2018 at 01:27:08PM -0700, Kees Cook wrote: >> Do the lkdtm tests for usercopy correctly halt the kernel thread if >> CONFIG_BUG is removed? > > Yes, they do... Perfect, thanks for double-checking! I'll apply this

Re: [PATCH v2 2/2] arm64: dts: qcom: pm8998: Add pm8998 thermal zone

2018-07-02 Thread Matthias Kaehlcke
On Mon, Jul 02, 2018 at 12:53:44PM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jul 2, 2018 at 11:10 AM, Matthias Kaehlcke wrote: > > The thermal zone uses spmi-temp-alarm as sensor. If the sensor is > > configured without an IIO input it always reports 37°C for temperatures > > below the first

Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig

2018-07-02 Thread Randy Dunlap
On 07/02/18 13:41, Randy Dunlap wrote: > --- linux-next-20180702.orig/init/Kconfig > +++ linux-next-20180702/init/Kconfig > @@ -1717,6 +1717,12 @@ config PROFILING > config TRACEPOINTS > bool > > +# Note: arch/$(SRCARCH)/Kconfig needs to be before arch/Kconfig &g

Re: [PATCH] ima: Use tpm_default_chip() and call TPM functions with a tpm_chip

2018-07-02 Thread Mimi Zohar
On Mon, 2018-07-02 at 11:24 -0400, Stefan Berger wrote: > Rather than accessing the TPM functions by passing a NULL pointer for > the tpm_chip, which causes a lookup for a suitable chip every time, get a > hold of a tpm_chip and access the TPM functions using it. Also get rid of > the

Re: [PATCH 2/2] PCI: imx: Initial imx7d pm support

2018-07-02 Thread Leonard Crestez
On Fri, 2018-06-08 at 16:33 +0200, Lucas Stach wrote: > Am Dienstag, den 29.05.2018, 22:39 +0300 schrieb Leonard Crestez: > > On imx7d the phy is turned off in suspend and must be reset on resume. > > Right now lspci -v fails after a suspend/resume cycle, fix this by > > adding minimal

Re: [GIT PULL] tee driver for v4.18

2018-07-02 Thread Olof Johansson
Hi Jens, On Mon, Jul 2, 2018 at 5:10 AM, Jens Wiklander wrote: > Hello arm-soc maintainers, > > Please pull these small tee driver enhancements. There's a new config > option for the OP-TEE driver, OPTEE_SHM_NUM_PRIV_PAGES. Also the OP-TEE > driver reads current time with ktime_get_real_ts64()

Re: iwlwifi problem with iommu/intel-iommu: Enable CONFIG_DMA_DIRECT_OPS=y and clean up intel_{alloc,free}_coherent()

2018-07-02 Thread Fabio Coatti
On Monday 2 July 2018 15:19:51 CEST Christoph Hellwig wrote: > > By reverting this commit the card works again, tested in 4.17.3 . I've > > noticed that the corresponding amd commit ( > > b468620f2a1dfdcfddfd6fa54367b8bcc1b51248) has been reverted in linus tree > >

Re: [PATCH] mm/sparse: Make sparse_init_one_section void and remove check

2018-07-02 Thread Pavel Tatashin
On Mon, Jul 2, 2018 at 11:43 AM wrote: > > From: Oscar Salvador > > sparse_init_one_section() is being called from two sites: > sparse_init() and sparse_add_one_section(). > The former calls it from a for_each_present_section_nr() loop, > and the latter marks the section as present before

Re: [PATCH] arm64: Clear the stack

2018-07-02 Thread Laura Abbott
On 07/02/2018 06:02 AM, Alexander Popov wrote: Hello Laura, Thanks for your work! Please see my comments below. On 29.06.2018 22:05, Laura Abbott wrote: Implementation of stackleak based heavily on the x86 version Signed-off-by: Laura Abbott --- Changes since last time: - Minor name change

Re: [GIT PULL] x86 fixes

2018-07-02 Thread Andy Lutomirski
On Sat, Jun 30, 2018 at 12:01 PM, Linus Torvalds wrote: > On Sat, Jun 30, 2018 at 1:49 AM Ingo Molnar wrote: >> >> --- a/arch/x86/entry/entry_32.S >> +++ b/arch/x86/entry/entry_32.S >> @@ -477,7 +477,7 @@ ENTRY(entry_SYSENTER_32) >> * whereas POPF does not.) >> */ >>

Re: [PATCH v3] add param that allows bootline control of hardened usercopy

2018-07-02 Thread Christoph von Recklinghausen
On 07/02/2018 02:43 PM, Kees Cook wrote: > On Sat, Jun 30, 2018 at 1:43 PM, Christoph von Recklinghausen > wrote: >> The last issue I'm chasing is build failures on ARCH=m68k. The error is >> atomic_read and friends needed by the jump label code not being found. >> The config has

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-07-02 Thread Bjorn Andersson
On Thu 28 Jun 10:14 PDT 2018, Stephen Boyd wrote: > Quoting Linus Walleij (2018-06-28 07:25:46) > > On Fri, Jun 22, 2018 at 8:29 PM Bjorn Andersson > > wrote: > > > On Fri 22 Jun 10:58 PDT 2018, Bjorn Andersson wrote: > > > > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > > > > > > > > > We

Re: [PATCH 12/15] arm: dts: highbank: Add missing OPP properties for CPUs

2018-07-02 Thread Rob Herring
On Fri, May 25, 2018 at 4:32 AM Viresh Kumar wrote: > > The OPP properties, like "operating-points", should either be present > for all the CPUs of a cluster or none. If these are present only for a > subset of CPUs of a cluster then things will start falling apart as soon > as the CPUs are

[RFC PATCH for 4.18 2/2] rseq: validate rseq->rseq_cs padding to be zero

2018-07-02 Thread Mathieu Desnoyers
On 32-bit kernels, the rseq->rseq_cs_padding field is never read by the kernel. However, 64-bit kernels dealing with 32-bit compat tasks read the full 64-bit in its entirety, and terminates the offending process with a segmentation fault if the upper 32 bits are set due to failure of

[RFC PATCH for 4.18 1/2] rseq: use __u64 for rseq_cs fields, validate abort_ip < TASK_SIZE

2018-07-02 Thread Mathieu Desnoyers
Change the rseq ABI so rseq_cs start_ip, post_commit_offset and abort_ip fields are seen as 64-bit fields by both 32-bit and 64-bit kernels rather that ignoring the 32 upper bits on 32-bit kernels. This ensures we have a consistent behavior for a 32-bit binary executed on 32-bit kernels and in

Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig

2018-07-02 Thread Randy Dunlap
t;security/Kconfig" > + > +source "crypto/Kconfig" > + > +source "lib/Kconfig" FWIW, I prefer this modification, but it's not a deal breaker. --- From: Randy Dunlap Present "General setup" before "Processor type and features". This

Re: [PATCH] mmc: dw_mmc: fix card threshold control configuration

2018-07-02 Thread Doug Anderson
Hi, On Mon, Jun 11, 2018 at 7:17 AM, Shawn Lin wrote: > On 2018/6/11 20:20, Ulf Hansson wrote: >> >> + Shawn Lin, Evgeniy Didin, Doug Andersson >> >> On 29 May 2018 at 12:38, Qing Xia wrote: >>> >>> From: x00270170 >>> >>> Card write threshold control is supposed to be set since controller >>>

Re: [RFC PATCH for 4.18 1/2] rseq: validate rseq_cs fields are < TASK_SIZE

2018-07-02 Thread Andy Lutomirski
On Mon, Jul 2, 2018 at 7:32 AM Mathieu Desnoyers wrote: > > - On Jun 29, 2018, at 4:39 PM, Andy Lutomirski l...@amacapital.net wrote: > > > On Fri, Jun 29, 2018 at 12:48 PM, Mathieu Desnoyers > > wrote: > >> There are two aspects I'm concerned about here: > >> > >> 1) security: we don't want

Re: [RFC v3 PATCH 4/5] mm: mmap: zap pages with read mmap_sem for large mapping

2018-07-02 Thread Yang Shi
On 7/2/18 5:33 AM, Kirill A. Shutemov wrote: On Sat, Jun 30, 2018 at 06:39:44AM +0800, Yang Shi wrote: When running some mmap/munmap scalability tests with large memory (i.e. 300GB), the below hung task issue may happen occasionally. INFO: task ps:14018 blocked for more than 120 seconds.

Re: [PATCH bpf-next 2/3] bpf: btf: add btf json print functionality

2018-07-02 Thread Jakub Kicinski
On Sun, 1 Jul 2018 11:31:47 +0100, Okash Khawaja wrote: > On Wed, Jun 27, 2018 at 02:56:49PM +0200, Daniel Borkmann wrote: > > On 06/27/2018 01:47 PM, Okash Khawaja wrote: > > > On Wed, Jun 27, 2018 at 12:34:35PM +0200, Daniel Borkmann wrote: > > >> On 06/27/2018 12:35 AM, Jakub Kicinski

[PATCH] iscsi_ibft: Mark expected switch fall-through

2018-07-02 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/firmware/iscsi_ibft.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c

[PATCH] liquidio: make timeout HZ independent and readable

2018-07-02 Thread Nicholas Mc Guire
t requests on device removal is reasonable. Patch was compile tested with: x86_64_defconfig (implies CONFIG_NET_VENDOR_CAVIUM=y) (with a large number of sparse warnings though unrelated to the proposed change) Patch is against 4.18-rc2 (localversion-next is -next-20180702) drivers/net/ether

Re: [PATCH v10 7/7] i2c: fsi: Add bus recovery

2018-07-02 Thread Wolfram Sang
> > This all won't have any effect since you never call i2c_recover_bus > > which calls back into i2c_bus_recovery_info callbacks. > > Ah, I thought there would be some use of this in the core or in client > drivers, or some ioctl interface. Would there be any outside users of these > callbacks

Re: [RFC PATCH for 4.18 1/2] rseq: validate rseq_cs fields are < TASK_SIZE

2018-07-02 Thread Linus Torvalds
On Mon, Jul 2, 2018 at 12:02 PM Andy Lutomirski wrote: > > Works for me. Linus, any objection? I think the 4.19 stage may be overkill, but I don't hate it, so no real objections. If the main reason for this is that we silently clear the upper bits when returning to compat mode, I actually

Re: [PATCH v3 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-02 Thread Pavel Tatashin
On 07/02/2018 03:47 PM, Dave Hansen wrote: > On 07/01/2018 07:04 PM, Pavel Tatashin wrote: >> +for_each_present_section_nr(pnum_begin + 1, pnum_end) { >> +int nid = sparse_early_nid(__nr_to_section(pnum_end)); >> >> +if (nid == nid_begin) { >> +

Re: [PATCH v3 1/2] mm/sparse: add sparse_init_nid()

2018-07-02 Thread Dave Hansen
> @@ -2651,6 +2651,14 @@ void sparse_mem_maps_populate_node(struct page > **map_map, > unsigned long pnum_end, > unsigned long map_count, > int nodeid); > +struct page *

Re: [PATCH v3 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-02 Thread Dave Hansen
On 07/02/2018 12:54 PM, Pavel Tatashin wrote: > > > On 07/02/2018 03:47 PM, Dave Hansen wrote: >> On 07/01/2018 07:04 PM, Pavel Tatashin wrote: >>> + for_each_present_section_nr(pnum_begin + 1, pnum_end) { >>> + int nid = sparse_early_nid(__nr_to_section(pnum_end)); >>> >>> +

Re: [PATCH v3 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-02 Thread Pavel Tatashin
On Mon, Jul 2, 2018 at 4:00 PM Dave Hansen wrote: > > On 07/02/2018 12:54 PM, Pavel Tatashin wrote: > > > > > > On 07/02/2018 03:47 PM, Dave Hansen wrote: > >> On 07/01/2018 07:04 PM, Pavel Tatashin wrote: > >>> + for_each_present_section_nr(pnum_begin + 1, pnum_end) { > >>> + int nid

Re: [RFC PATCH for 4.18 1/2] rseq: validate rseq_cs fields are < TASK_SIZE

2018-07-02 Thread Andy Lutomirski
On Mon, Jul 2, 2018 at 12:31 PM, Linus Torvalds wrote: > On Mon, Jul 2, 2018 at 12:02 PM Andy Lutomirski wrote: >> >> Works for me. Linus, any objection? > > I think the 4.19 stage may be overkill, but I don't hate it, so no > real objections. > > If the main reason for this is that we silently

Re: [PATCH v2 1/2] arm64: dts: qcom: pm8998: Add spmi-temp-alarm node

2018-07-02 Thread Doug Anderson
Hi, On Mon, Jul 2, 2018 at 11:10 AM, Matthias Kaehlcke wrote: > This adds the spmi-temp-alarm node to pm8998 based on the examples in the > bindings. > > Signed-off-by: Matthias Kaehlcke > --- > Changes in v2: > - none > > arch/arm64/boot/dts/qcom/pm8998.dtsi | 7 +++ > 1 file changed, 7

Re: [PATCH V4 4/7] PCI: Unify try slot and bus reset API

2018-07-02 Thread Sinan Kaya
On 6/29/2018 5:43 PM, Andy Shevchenko wrote: >> +int pci_try_reset_bus(struct pci_dev *pdev) >> +{ >> + bool slot = false; >> + >> + if (!pci_probe_reset_slot(pdev->slot)) >> + slot = true; >> + >> + return slot ? __pci_try_reset_slot(pdev->slot) : >> +

Re: [PATCH v4 0/6] thermal: tsens: Refactoring for TSENSv2 IP

2018-07-02 Thread Eduardo Valentin
On Mon, Jul 02, 2018 at 06:14:03PM +0530, Amit Kucheria wrote: > This series is a mixed bag: > - Some code moves to allow code sharing between various v2.x.y versions of > the TSENS IP, > - new qcom,tsens-v2.4.0 DT property for SDM845 and a generic qcom,tsens-v2 > property as a fallback

[PATCH v2 2/2] arm64: dts: qcom: pm8998: Add pm8998 thermal zone

2018-07-02 Thread Matthias Kaehlcke
The thermal zone uses spmi-temp-alarm as sensor. If the sensor is configured without an IIO input it always reports 37°C for temperatures below the first hardware trip point at 105°C. This hardware trip point is configured as critical trip point, to initiate a system shutdown before the

[PATCH] drbd: mark expected switch fall-throughs

2018-07-02 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 2 was used in this case: -Wimplicit-fallthrough=2 Signed-off-by: Gustavo A. R. Silva --- drivers/block/drbd/drbd_receiver.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [RFC v3 PATCH 5/5] x86: check VM_DEAD flag in page fault

2018-07-02 Thread Yang Shi
On 7/2/18 10:57 AM, Michal Hocko wrote: On Mon 02-07-18 10:24:27, Yang Shi wrote: On 7/2/18 6:37 AM, Michal Hocko wrote: On Mon 02-07-18 15:33:11, Laurent Dufour wrote: On 02/07/2018 14:45, Michal Hocko wrote: On Mon 02-07-18 14:26:09, Laurent Dufour wrote: On 02/07/2018 14:15, Michal

[PATCH v2 1/2] arm64: dts: qcom: pm8998: Add spmi-temp-alarm node

2018-07-02 Thread Matthias Kaehlcke
This adds the spmi-temp-alarm node to pm8998 based on the examples in the bindings. Signed-off-by: Matthias Kaehlcke --- Changes in v2: - none arch/arm64/boot/dts/qcom/pm8998.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi

Re: [PATCH v3] add param that allows bootline control of hardened usercopy

2018-07-02 Thread Kees Cook
On Sat, Jun 30, 2018 at 1:43 PM, Christoph von Recklinghausen wrote: > The last issue I'm chasing is build failures on ARCH=m68k. The error is > atomic_read and friends needed by the jump label code not being found. > The config has CONFIG_BROKEN_ON_SMP=y, so the jump label calls I added > will

Re: [PATCH 0/2] tools/memory-model: remove ACCESS_ONCE()

2018-07-02 Thread Paul E. McKenney
On Thu, Jun 28, 2018 at 06:51:11PM +0200, Andrea Parri wrote: > > 1bc179880fba docs: atomic_ops: Describe atomic_set as a write operation > > > > The above patches need at least one additional Acked-by > > or Reviewed-by. If any of you gets a chance, please do > > look them over. >

Re: [PATCH v2] mm: teach dump_page() to correctly output poisoned struct pages

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 14:05:36, Pavel Tatashin wrote: [...] > void __dump_page(struct page *page, const char *reason) > { > + bool page_poisoned = PagePoisoned(page); > + int mapcount; > + > + /* > + * If struct page is poisoned don't access Page*() functions as that > + * leads

Re: [v7, 02/10] counter: Documentation: Add Generic Counter sysfs documentation

2018-07-02 Thread David Lechner
On 06/21/2018 04:07 PM, William Breathitt Gray wrote: This patch adds standard documentation for the userspace sysfs attributes of the Generic Counter interface. Reviewed-by: Jonathan Cameron Signed-off-by: William Breathitt Gray --- Documentation/ABI/testing/sysfs-bus-counter | 230

Re: [PATCH 2/2] drivers: core: Remove glue dirs from sysfs earlier

2018-07-02 Thread Linus Torvalds
On Mon, Jul 2, 2018 at 3:23 AM Benjamin Herrenschmidt wrote: > > Let me try one last ditch attempt to convince you using maybe a > different perspective: this is how sysfs is intended to work and how > the device model already does everywhere else except the gluedirs. So don't get me wrong. I

Re: hrtimer become inaccurate with RT patch

2018-07-02 Thread John Stultz
On Mon, Jul 2, 2018 at 2:34 AM, gengdongjiu wrote: > Hi Thomas/Anna/John, > > Recently I found that the hrtimer become inaccurate when there is a RT > process runs on the same cpu core, and the kernel has applied preempt_rt > patch. > The Linux kernel version is v4.1.46, and the preempt_rt

Re: [PATCH v3 0/8] gnss: add new GNSS subsystem

2018-07-02 Thread Pavel Machek
On Fri 2018-06-29 14:09:14, Johan Hovold wrote: > On Fri, Jun 29, 2018 at 02:05:54PM +0200, Pavel Machek wrote: > > On Fri 2018-06-29 13:46:46, Johan Hovold wrote: > > > On Fri, Jun 29, 2018 at 11:46:07AM +0200, Pavel Machek wrote: > > > > > > > > > > Finally, note that documentation (including

Re: hrtimer become inaccurate with RT patch

2018-07-02 Thread Sebastian Andrzej Siewior
On 2018-07-02 19:19:07 [+0800], gengdongjiu wrote: > Hi Sebastian , Hi gengdongjiu, > > the 4.1 series is no longer supported (neither RT wise nor non-RT, > > https://www.kernel.org/category/releases.html). I suggest to move away. > > If you notice this problem now it is hardly a long running

[PATCH] fixup! firmware: raspberrypi: Remove VLA usage

2018-07-02 Thread Eric Anholt
Kees - with this fix to your patch, the kernel boots again (otherwise, the FW would try to parse the uninitialized bits of stack and throw errors). If you're good with me squashing this in, I'll do so and send it to -next. Signed-off-by: Eric Anholt --- drivers/firmware/raspberrypi.c | 2 +- 1

Re: [PATCH v2] mm: teach dump_page() to correctly output poisoned struct pages

2018-07-02 Thread Andrew Morton
On Mon, 2 Jul 2018 14:05:36 -0400 Pavel Tatashin wrote: > If struct page is poisoned, and uninitialized access is detected via > PF_POISONED_CHECK(page) dump_page() is called to output the page. But, > the dump_page() itself accesses struct page to determine how to print > it, and therefore

Re: [PATCH v4] ata: Remove depends on HAS_DMA in case of platform dependency

2018-07-02 Thread Geert Uytterhoeven
Hi Tejun, On Mon, Jul 2, 2018 at 6:12 PM Tejun Heo wrote: > On Fri, Jun 22, 2018 at 01:03:07PM +0200, Geert Uytterhoeven wrote: > > Remove dependencies on HAS_DMA where a Kconfig symbol depends on another > > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". > > In most cases

Re: [PATCH v3] x86/e820: put !E820_TYPE_RAM regions into memblock.reserved

2018-07-02 Thread Pavel Tatashin
> So I expect this patch needs a cc:stable, which I'll add. > > The optimiation patch seems less important and I'd like to hold that > off for 4.19-rc1? Hi Andrew, Should I resend the optimization patch [1] once 4.18 is released, or will you include it, and I do not need to do anything? [1]

Re: [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern standby platform

2018-07-02 Thread Tejun Heo
On Mon, Jul 02, 2018 at 12:08:45PM -0700, Srinivas Pandruvada wrote: > From: Srinivas > > One of the requirement for modern x86 system to enter lowest power mode > (SLP_S0) is SATA IP block to be off. This is true even during when > platform is suspended to idle and not only in opportunistic

[PATCH v2 2/7] tracing: Split up onmatch action data

2018-07-02 Thread Tom Zanussi
From: Tom Zanussi Currently, the onmatch action data binds the onmatch action to data related to synthetic event generation. Since we want to allow the onmatch handler to potentially invoke a different action, and because we expect other handlers to generate synthetic events, we need to

Re: [PATCH v2 5/6] mm: track gup pages with page->dma_pinned_* fields

2018-07-02 Thread John Hubbard
On 07/02/2018 02:53 AM, Jan Kara wrote: > On Sun 01-07-18 17:56:53, john.hubb...@gmail.com wrote: >> From: John Hubbard >> > ... > >> @@ -904,12 +907,24 @@ static inline void get_page(struct page *page) >> */ >> VM_BUG_ON_PAGE(page_ref_count(page) <= 0, page); >>

Re: [RFC v3 PATCH 4/5] mm: mmap: zap pages with read mmap_sem for large mapping

2018-07-02 Thread Andrew Morton
On Mon, 2 Jul 2018 16:05:02 +0200 Michal Hocko wrote: > On Fri 29-06-18 20:15:47, Andrew Morton wrote: > [...] > > Would one of your earlier designs have addressed all usecases? I > > expect the dumb unmap-a-little-bit-at-a-time approach would have? > > It has been already pointed out that

Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-02 Thread Andy Lutomirski
> On Jul 2, 2018, at 4:22 PM, Mathieu Desnoyers > wrote: > > - On Jul 2, 2018, at 7:16 PM, Mathieu Desnoyers > mathieu.desnoy...@efficios.com wrote: > >> - On Jul 2, 2018, at 7:06 PM, Linus Torvalds >> torva...@linux-foundation.org >> wrote: >> >>> On Mon, Jul 2, 2018 at 4:00 PM

Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-02 Thread Christopher Lameter
On Mon, 2 Jul 2018, Mathieu Desnoyers wrote: > > > > Platforms with 32 bit word size only guarantee atomicity of a 32 bit > > write or RMV instruction. > > > > Special instructions may exist on a platform to perform 64 bit atomic > > updates. We use cmpxchg64 f.e. on Intel 32 bit platforms to

Re: Build regressions/improvements in v4.18-rc3

2018-07-02 Thread Michael Ellerman
Helge Deller writes: > On 02.07.2018 16:09, Geert Uytterhoeven wrote: >> On Mon, Jul 2, 2018 at 4:01 PM Geert Uytterhoeven >> wrote: >>> JFYI, when comparing v4.18-rc3[1] to v4.18-rc2[3], the summaries are: >> ... > > Both of the following are simply happening because of old compiler which is

Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-02 Thread Mathieu Desnoyers
- On Jul 2, 2018, at 8:35 PM, Chris Lameter c...@linux.com wrote: > On Mon, 2 Jul 2018, Mathieu Desnoyers wrote: > >> > >> > Platforms with 32 bit word size only guarantee atomicity of a 32 bit >> > write or RMV instruction. >> > >> > Special instructions may exist on a platform to perform

[PATCH 2/2] x86/build/vdso: simplify cmd_vdso2c

2018-07-02 Thread Masahiro Yamada
No reason to use 'define' directive here. Just use the = operator. Signed-off-by: Masahiro Yamada --- arch/x86/entry/vdso/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile index 261802b..b9ed1aa 100644

[PATCH 0/2] x86/build/vdso: a little more Makefile cleanups

2018-07-02 Thread Masahiro Yamada
At first, I sent the first patch to UML ML, but they did not pick it up. Instead, I was able to get Acked-by from Richard, one of the UML maintainers. https://patchwork.kernel.org/patch/10399787/ I am resending it to x86 ML. Masahiro Yamada (2): x86/build/vdso: remove unused vdso-syms.lds

[PATCH 4/6] x86/efi: Free existing memory map before installing new memory map

2018-07-02 Thread Sai Praneeth Prakhya
From: Sai Praneeth efi_memmap_install(), unmaps the existing memory map and installs a new memory map but doesn't free the memory allocated to the existing memory map. Fortunately, the details about the existing memory map (like the physical address, number of entries and type of memory) are

[PATCH 1/2] x86/build/vdso: remove unused vdso-syms.lds

2018-07-02 Thread Masahiro Yamada
This file contains symbol values, and was originally linked into vmlinux, but I have no idea what it was actually used for. Since commit 827880ec260b ("x86/um: thin archives build fix"), it is not even linked. Now it is completely orphan, and no problem has been reported. It is a proof that

Re: [PATCH v9 0/6] optimize memblock_next_valid_pfn and early_pfn_valid on arm and arm64

2018-07-02 Thread Jia He
On 7/2/2018 7:40 PM, Michal Hocko Wrote: > On Fri 29-06-18 10:29:17, Jia He wrote: >> Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns >> where possible") tried to optimize the loop in memmap_init_zone(). But >> there is still some room for improvement. > > It would be

RE: [PATCH V2] mmc: core: cd_label must be last entry of mmc_gpio struct

2018-07-02 Thread Anson Huang
Hi, Linus Anson Huang Best Regards! > -Original Message- > From: Linus Walleij [mailto:linus.wall...@linaro.org] > Sent: Monday, July 2, 2018 7:42 PM > To: Anson Huang > Cc: Ulf Hansson ; Masahiro Yamada > ; Adrian Hunter > ; evgr...@chromium.org; Shawn Lin > ; Fabio Estevam ; >

Re: [PATCH 0/2] serial: 8250_dw: add fractional divisor support

2018-07-02 Thread Jisheng Zhang
Hi, On Mon, 2 Jul 2018 14:51:03 +0300 Andy Shevchenko wrote: > On Mon, 2018-07-02 at 13:18 +0300, Andy Shevchenko wrote: > > On Mon, 2018-07-02 at 18:04 +0800, Jisheng Zhang wrote: > > > For Synopsys DesignWare 8250 uart which version >= 4.00a, there's a > > > valid divisor latch fraction

Re: [PATCH] gcc-plugins: remove unused GCC_PLUGIN_SUBDIR

2018-07-02 Thread Masahiro Yamada
Hi Kees, 2018-07-03 11:18 GMT+09:00 Kees Cook : > On Mon, Jul 2, 2018 at 5:39 PM, Masahiro Yamada > wrote: >> GCC_PLUGIN_SUBDIR has never been used. If you really need this in >> the future, please re-add it then. >> >> For now, the code is unused. Remove. >> >> 'export HOSTLIBS' is not

Re: [PATCH V2] mmc: core: cd_label must be last entry of mmc_gpio struct

2018-07-02 Thread Fabio Estevam
On Mon, Jul 2, 2018 at 11:13 PM, Anson Huang wrote: > I think either way is OK, since flexible array is used in kernel code quite > commonly, > so I prefer to make code change as small as possible, the original patch can > also prevent > similar bug in future. And like below commit Fabio

Re: [PATCH] gcc-plugins: remove unused GCC_PLUGIN_SUBDIR

2018-07-02 Thread Kees Cook
On Mon, Jul 2, 2018 at 7:23 PM, Masahiro Yamada wrote: > Hi Kees, > > 2018-07-03 11:18 GMT+09:00 Kees Cook : >> On Mon, Jul 2, 2018 at 5:39 PM, Masahiro Yamada >> wrote: >>> GCC_PLUGIN_SUBDIR has never been used. If you really need this in >>> the future, please re-add it then. >>> >>> For now,

Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-02 Thread Mathieu Desnoyers
- On Jul 2, 2018, at 10:18 PM, Linus Torvalds torva...@linux-foundation.org wrote: > On Mon, Jul 2, 2018 at 7:01 PM Mathieu Desnoyers > wrote: >> >> One thing to consider is how we will implement the load of that pointer >> on the kernel side. > > Use "get_user()". It works for 64-bit

Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-02 Thread Linus Torvalds
On Mon, Jul 2, 2018 at 7:30 PM Mathieu Desnoyers wrote: > > > Is it really ? Last time we had this discussion, not all architectures > guaranteed that reading a 64-bit integer would happen in two atomic > 32-bit sub-parts. All architectures that matter do. Please don't overdesign this, or try

[lkp-robot] ee410f15b1 BUG: kernel hang in boot stage

2018-07-02 Thread kernel test robot
Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit ee410f15b1418f2f4428e79980674c979081bcb7 Author: Thierry Escande AuthorDate: Thu Jun 14 15:28:15 2018 -0700 Commit:

Re: [PATCH 0/2] serial: 8250_dw: add fractional divisor support

2018-07-02 Thread Jisheng Zhang
On Tue, 3 Jul 2018 10:22:57 +0800 Jisheng Zhang wrote: > Hi, > > On Mon, 2 Jul 2018 14:51:03 +0300 Andy Shevchenko wrote: > > > On Mon, 2018-07-02 at 13:18 +0300, Andy Shevchenko wrote: > > > On Mon, 2018-07-02 at 18:04 +0800, Jisheng Zhang wrote: > > > > For Synopsys DesignWare 8250 uart

Re: [PATCH V2 02/19] csky: defconfig

2018-07-02 Thread Rob Herring
On Sun, Jul 1, 2018 at 11:34 AM Guo Ren wrote: > Needs a commit msg. Perhaps some overview of what's in each config. > Signed-off-by: Guo Ren > --- > arch/csky/configs/gx66xx_defconfig | 549 > + > arch/csky/configs/qemu_ck807_defconfig | 541

Re: Linux 3.18.111

2018-07-02 Thread Seung-Woo Kim
Hello, On 2018년 05월 30일 16:32, Greg KH wrote: > I'm announcing the release of the 3.18.111 kernel. > > All users of the 3.18 kernel series must upgrade. > > The updated 3.18.y git tree can be found at: > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git > linux-3.18.y

Re: [PATCH V2 01/19] csky: Build infrastructure

2018-07-02 Thread Rob Herring
On Sun, Jul 1, 2018 at 11:36 AM Guo Ren wrote: > > Signed-off-by: Guo Ren > --- [...] > +config CSKY_BUILTIN_DTB > + bool "Use kernel builtin dtb" > + > +config CSKY_BUILTIN_DTB_NAME > + string "kernel builtin dtb name" > + depends on CSKY_BUILTIN_DTB > +endmenu These

Re: [PATCH] tick: prefer a lower rating device only if it's CPU local device

2018-07-02 Thread Kevin Hilman
Hi Sudeep, On Wed, May 9, 2018 at 9:02 AM Sudeep Holla wrote: > > Checking the equality of cpumask for both new and old tick device doesn't > ensure that it's CPU local device. This will cause issue if a low rating > clockevent tick device is registered first followed by the registration > of

Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-02 Thread Christopher Lameter
On Mon, 2 Jul 2018, Mathieu Desnoyers wrote: > Are there any kind of guarantees that a __u64 update on a 32-bit architecture > won't be torn into something daft like byte-per-byte stores when performed > from C code ? > > I don't worry whether the upper bits get updated or how, but I really care

Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-02 Thread Mathieu Desnoyers
- On Jul 2, 2018, at 8:19 PM, Chris Lameter c...@linux.com wrote: > On Mon, 2 Jul 2018, Mathieu Desnoyers wrote: > >> Are there any kind of guarantees that a __u64 update on a 32-bit architecture >> won't be torn into something daft like byte-per-byte stores when performed >> from C code ?

RE: [PATCH] bindings: add clocks optional binding for imx gpio

2018-07-02 Thread Anson Huang
Hi, Linus Anson Huang Best Regards! > -Original Message- > From: Linus Walleij [mailto:linus.wall...@linaro.org] > Sent: Monday, July 2, 2018 9:46 PM > To: Anson Huang ; Fabio Estevam > > Cc: Rob Herring ; Mark Rutland > ; open list:GPIO SUBSYSTEM > ; open list:OPEN FIRMWARE AND

Re: [RFC PATCH for 4.18] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-02 Thread Mathieu Desnoyers
- On Jul 2, 2018, at 7:37 PM, Andy Lutomirski l...@amacapital.net wrote: >> On Jul 2, 2018, at 4:22 PM, Mathieu Desnoyers >> >> wrote: >> >> - On Jul 2, 2018, at 7:16 PM, Mathieu Desnoyers >> mathieu.desnoy...@efficios.com wrote: >> >>> - On Jul 2, 2018, at 7:06 PM, Linus Torvalds

Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-02 Thread Ian Kent
On Mon, 2018-07-02 at 14:15 +0200, Dmitry Vyukov wrote: > On Mon, Jul 2, 2018 at 1:55 PM, tomas wrote: > > Yes, thanks. Please use my full name, Tomas Bortoli. > > > Please also include: > > Reported-by: syzbot+60c837b428dc84e83...@syzkaller.appspotmail.com Done. > > from the original bug

Re: [PATCH 02/15] arm: dts: ls1021a: Add missing cooling device properties for CPUs

2018-07-02 Thread Shawn Guo
On Fri, May 25, 2018 at 04:01:48PM +0530, Viresh Kumar wrote: > The cooling device properties, like "#cooling-cells" and > "dynamic-power-coefficient", should either be present for all the CPUs > of a cluster or none. If these are present only for a subset of CPUs of > a cluster then things will

Re: [RFC PATCH 0/4] x86/boot/KASLR: Parse ACPI table and limit kaslr in immovable memory.

2018-07-02 Thread Chao Fan
On Mon, Jul 02, 2018 at 08:18:55PM +0800, Baoquan He wrote: >Hi Chao, > >On 06/12/18 at 04:10pm, Chao Fan wrote: >> *** Issues need be discussed >> There are several issues I am not quite sure, please help review and >> give suggestions: >> >> 1) In PATCH 1, I copy the structures and functions

<    1   2   3   4   5   6   7   8   9   10   >