[PATCH 05/20] platform: goldfish: pipe: Update the comment for GFP_ATOMIC

2018-08-27 Thread rkir
From: Roman Kiryanov Provide an explanation why GFP_ATOMIC is needed to prevent changing it to other values. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH 09/20] platform: goldfish: pipe: Add blank lines to separate struct members

2018-08-27 Thread rkir
From: Roman Kiryanov To improve readability and to be consistent with other struct members. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 03/20] platform: goldfish: pipe: Move an opening brace to the next line

2018-08-27 Thread rkir
From: Roman Kiryanov checkpatch: Function's opening brace has to be at the beginning of the next line. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 03/20] platform: goldfish: pipe: Move an opening brace to the next line

2018-08-27 Thread rkir
From: Roman Kiryanov checkpatch: Function's opening brace has to be at the beginning of the next line. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 01/20] platform: goldfish: pipe: Fix comments to fit 80 columns

2018-08-27 Thread rkir
From: Roman Kiryanov Some comment lines are longer than 80 symbols. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 01/20] platform: goldfish: pipe: Fix comments to fit 80 columns

2018-08-27 Thread rkir
From: Roman Kiryanov Some comment lines are longer than 80 symbols. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 08/20] platform: goldfish: pipe: Replace pr_ with dev_ for logging

2018-08-27 Thread rkir
From: Roman Kiryanov dev_ is preferred if struct device is available. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 08/20] platform: goldfish: pipe: Replace pr_ with dev_ for logging

2018-08-27 Thread rkir
From: Roman Kiryanov dev_ is preferred if struct device is available. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 10/20] platform: goldfish: pipe: Remove a redundant variable

2018-08-27 Thread rkir
From: Roman Kiryanov The variable was not very useful. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 10/20] platform: goldfish: pipe: Remove a redundant variable

2018-08-27 Thread rkir
From: Roman Kiryanov The variable was not very useful. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 15/20] platform: goldfish: pipe: Remove reduntant casting to (void)

2018-08-27 Thread rkir
From: Roman Kiryanov Casting to (void) is no-op. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c index

[PATCH 13/20] platform: goldfish: pipe: Remove a blank line before '}'

2018-08-27 Thread rkir
From: Roman Kiryanov checkpatch: Blank lines aren't necessary before a close brace '}' Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 18/20] platform: goldfish: pipe: Fix alignment to match parenthesis

2018-08-27 Thread rkir
From: Roman Kiryanov checkpatch: Alignment should match open parenthesis. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 83 +-- 1 file changed, 48 insertions(+), 35 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 20/20] platform: goldfish: pipe: Replace "x==NULL" to "!x"

2018-08-27 Thread rkir
From: Roman Kiryanov checkpatch: Comparison to NULL could be written "!x" Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 19/20] platform: goldfish: pipe: Move logical ops to the end of the prev line

2018-08-27 Thread rkir
From: Roman Kiryanov checkpatch: Logical continuations should be on the previous line Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 12/20] platform: goldfish: pipe: Remove reduntant casting

2018-08-27 Thread rkir
From: Roman Kiryanov Casting to u32 is not required here. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 17/20] platform: goldfish: pipe: Fix lines to not end an opening bracket

2018-08-27 Thread rkir
From: Roman Kiryanov checkpatch: Lines should not end with a '(' or '[' Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 16/20] platform: goldfish: pipe: Rename goldfish_x to goldfish_pipe_x

2018-08-27 Thread rkir
From: Roman Kiryanov Add "pipe" to the pipe related function names. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 11/20] platform: goldfish: pipe: Replace two code blocks with a function call

2018-08-27 Thread rkir
From: Roman Kiryanov Two function calls look cleaner because the function introduces takes case of all bit shifting and casting. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 35 --- 1 file changed, 19 insertions(+), 16 deletions(-) diff

[PATCH 14/20] platform: goldfish: pipe: Rename 'wakeBit' to 'wake_bit'

2018-08-27 Thread rkir
From: Roman Kiryanov checkpatch: Avoid CamelCase Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c index

[PATCH 18/20] platform: goldfish: pipe: Fix alignment to match parenthesis

2018-08-27 Thread rkir
From: Roman Kiryanov checkpatch: Alignment should match open parenthesis. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 83 +-- 1 file changed, 48 insertions(+), 35 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 20/20] platform: goldfish: pipe: Replace "x==NULL" to "!x"

2018-08-27 Thread rkir
From: Roman Kiryanov checkpatch: Comparison to NULL could be written "!x" Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 19/20] platform: goldfish: pipe: Move logical ops to the end of the prev line

2018-08-27 Thread rkir
From: Roman Kiryanov checkpatch: Logical continuations should be on the previous line Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 12/20] platform: goldfish: pipe: Remove reduntant casting

2018-08-27 Thread rkir
From: Roman Kiryanov Casting to u32 is not required here. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 17/20] platform: goldfish: pipe: Fix lines to not end an opening bracket

2018-08-27 Thread rkir
From: Roman Kiryanov checkpatch: Lines should not end with a '(' or '[' Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 16/20] platform: goldfish: pipe: Rename goldfish_x to goldfish_pipe_x

2018-08-27 Thread rkir
From: Roman Kiryanov Add "pipe" to the pipe related function names. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 11/20] platform: goldfish: pipe: Replace two code blocks with a function call

2018-08-27 Thread rkir
From: Roman Kiryanov Two function calls look cleaner because the function introduces takes case of all bit shifting and casting. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 35 --- 1 file changed, 19 insertions(+), 16 deletions(-) diff

[PATCH 14/20] platform: goldfish: pipe: Rename 'wakeBit' to 'wake_bit'

2018-08-27 Thread rkir
From: Roman Kiryanov checkpatch: Avoid CamelCase Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c index

[PATCH 15/20] platform: goldfish: pipe: Remove reduntant casting to (void)

2018-08-27 Thread rkir
From: Roman Kiryanov Casting to (void) is no-op. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c index

[PATCH 13/20] platform: goldfish: pipe: Remove a blank line before '}'

2018-08-27 Thread rkir
From: Roman Kiryanov checkpatch: Blank lines aren't necessary before a close brace '}' Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 02/20] platform: goldfish: pipe: Update license

2018-08-27 Thread rkir
From: Roman Kiryanov goldfish_pipe is distributed under GPL v2. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 04/20] platform: goldfish: pipe: Separate the host interface to a separate header

2018-08-27 Thread rkir
From: Roman Kiryanov These are several enums that must kept in sync with the host side. This change explicitly separates them into a dedicated header file. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 69 +--

[PATCH 02/20] platform: goldfish: pipe: Update license

2018-08-27 Thread rkir
From: Roman Kiryanov goldfish_pipe is distributed under GPL v2. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 04/20] platform: goldfish: pipe: Separate the host interface to a separate header

2018-08-27 Thread rkir
From: Roman Kiryanov These are several enums that must kept in sync with the host side. This change explicitly separates them into a dedicated header file. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 69 +--

Re: possible deadlock in seq_read

2018-08-27 Thread Kees Cook
On Tue, Dec 12, 2017 at 2:06 PM, Eric Biggers wrote: > On Fri, Dec 01, 2017 at 03:29:01AM -0800, syzbot wrote: >> Hello, >> >> syzkaller hit the following crash on >> df8ba95c572a187ed2aa7403e97a7a7f58c01f00 >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master >> compiler:

Re: possible deadlock in seq_read

2018-08-27 Thread Kees Cook
On Tue, Dec 12, 2017 at 2:06 PM, Eric Biggers wrote: > On Fri, Dec 01, 2017 at 03:29:01AM -0800, syzbot wrote: >> Hello, >> >> syzkaller hit the following crash on >> df8ba95c572a187ed2aa7403e97a7a7f58c01f00 >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master >> compiler:

[PATCH v3 2/2]: perf record: enable asynchronous trace writing

2018-08-27 Thread Alexey Budankov
Trace file offset are linearly calculated by perf_mmap__push() code for the next possible write operation, but file position is updated by the kernel only in the second lseek() syscall after the loop. The first lseek() syscall reads that file position for the next loop iterations.

[PATCH v3 2/2]: perf record: enable asynchronous trace writing

2018-08-27 Thread Alexey Budankov
Trace file offset are linearly calculated by perf_mmap__push() code for the next possible write operation, but file position is updated by the kernel only in the second lseek() syscall after the loop. The first lseek() syscall reads that file position for the next loop iterations.

[PATCH v3 1/2]: perf util: map data buffer for preserving collected data

2018-08-27 Thread Alexey Budankov
The data buffer and accompanying AIO control block are allocated at perf_mmap object and the mapped data buffer size is equal to the kernel one. The buffer is then used to preserve profiling data ready for dumping and queue it for asynchronous writing into perf trace thru implemented

[PATCH v3 1/2]: perf util: map data buffer for preserving collected data

2018-08-27 Thread Alexey Budankov
The data buffer and accompanying AIO control block are allocated at perf_mmap object and the mapped data buffer size is equal to the kernel one. The buffer is then used to preserve profiling data ready for dumping and queue it for asynchronous writing into perf trace thru implemented

Re: Linux 4.19-rc1

2018-08-27 Thread Christoph Hellwig
On Mon, Aug 27, 2018 at 10:11:52AM -0700, Guenter Roeck wrote: > When building sparc32 images, this results in the following > error. > > drivers/base/platform.c: In function 'setup_pdev_archdata': > drivers/base/platform.c:235:22: error: assignment from incompatible pointer > type

Re: Linux 4.19-rc1

2018-08-27 Thread Christoph Hellwig
On Mon, Aug 27, 2018 at 10:11:52AM -0700, Guenter Roeck wrote: > When building sparc32 images, this results in the following > error. > > drivers/base/platform.c: In function 'setup_pdev_archdata': > drivers/base/platform.c:235:22: error: assignment from incompatible pointer > type

Re: [PATCH] Staging: One Laptop Per Child: add function argument names

2018-08-27 Thread Greg KH
On Thu, Aug 09, 2018 at 06:23:59PM +0200, Arkadiusz Lis wrote: > Add function argument names to pointers to functions > in struct dcon_platform_data: init, set_dconload and read_status > This commit removes checkpatch.pl warning. > > Signed-off-by: Arkadiusz Lis > --- >

Re: [PATCH] Staging: fsl-dpaa2: ethsw: dpsw: Use correct SPDX-License-Identifier comment

2018-08-27 Thread Greg KH
On Sun, Aug 19, 2018 at 06:21:36PM +0200, Jannis Nawroth wrote: > Use correct comment for SPDX-License-Identifier > > Signed-off-by: Jannis Nawroth > --- > drivers/staging/fsl-dpaa2/ethsw/dpsw.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

Re: [PATCH v2] staging: netlogic: Fixed comments to include SPDX-License-Identifier

2018-08-27 Thread Greg KH
On Sat, Aug 11, 2018 at 06:36:43PM +0200, Michael Anckaert wrote: > This patch fixes some issues with missing SPDX-License-Identifier comments. Never add SPDX identifiers unless you REALLY know what you are doing. It is VERY dangerous to add incorrect identifiers, which is what you did here :(

Re: [PATCH] Staging: One Laptop Per Child: add function argument names

2018-08-27 Thread Greg KH
On Thu, Aug 09, 2018 at 06:23:59PM +0200, Arkadiusz Lis wrote: > Add function argument names to pointers to functions > in struct dcon_platform_data: init, set_dconload and read_status > This commit removes checkpatch.pl warning. > > Signed-off-by: Arkadiusz Lis > --- >

Re: [PATCH] Staging: fsl-dpaa2: ethsw: dpsw: Use correct SPDX-License-Identifier comment

2018-08-27 Thread Greg KH
On Sun, Aug 19, 2018 at 06:21:36PM +0200, Jannis Nawroth wrote: > Use correct comment for SPDX-License-Identifier > > Signed-off-by: Jannis Nawroth > --- > drivers/staging/fsl-dpaa2/ethsw/dpsw.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

Re: [PATCH v2] staging: netlogic: Fixed comments to include SPDX-License-Identifier

2018-08-27 Thread Greg KH
On Sat, Aug 11, 2018 at 06:36:43PM +0200, Michael Anckaert wrote: > This patch fixes some issues with missing SPDX-License-Identifier comments. Never add SPDX identifiers unless you REALLY know what you are doing. It is VERY dangerous to add incorrect identifiers, which is what you did here :(

Re: [PATCH] Staging: rtlwifi: efuse: fixed a line length coding style issue

2018-08-27 Thread Greg KH
On Mon, Aug 13, 2018 at 10:11:21PM +0100, Tom Todd wrote: > Fixed a code style issue. Line length over 80 characters. > > Signed-off-by: Tom Todd > --- > drivers/staging/rtlwifi/efuse.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtlwifi/efuse.c

Re: [PATCH] ddk750_mode.c: Wraps line to 80 charecters

2018-08-27 Thread Greg KH
On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote: > Splits definition of function programModeRegisters into two lines such > that each line is less than 80 characters. > > Signed-off-by: Abishek V Ashok > --- > drivers/staging/sm750fb/ddk750_mode.c | 4 ++-- > 1 file changed, 2

Re: [PATCH] ddk750_mode.c: Wraps line to 80 charecters

2018-08-27 Thread Greg KH
On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote: > Splits definition of function programModeRegisters into two lines such > that each line is less than 80 characters. > > Signed-off-by: Abishek V Ashok > --- > drivers/staging/sm750fb/ddk750_mode.c | 4 ++-- > 1 file changed, 2

Re: [PATCH] Staging: rtlwifi: efuse: fixed a line length coding style issue

2018-08-27 Thread Greg KH
On Mon, Aug 13, 2018 at 10:11:21PM +0100, Tom Todd wrote: > Fixed a code style issue. Line length over 80 characters. > > Signed-off-by: Tom Todd > --- > drivers/staging/rtlwifi/efuse.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtlwifi/efuse.c

Re: [PATCH] ddk750_mode.c: Wraps line to 80 charecters

2018-08-27 Thread Greg KH
On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote: > Splits definition of function programModeRegisters into two lines such > that each line is less than 80 characters. > > Signed-off-by: Abishek V Ashok > --- > drivers/staging/sm750fb/ddk750_mode.c | 4 ++-- > 1 file changed, 2

Re: [PATCH] ddk750_mode.c: Wraps line to 80 charecters

2018-08-27 Thread Greg KH
On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote: > Splits definition of function programModeRegisters into two lines such > that each line is less than 80 characters. > > Signed-off-by: Abishek V Ashok > --- > drivers/staging/sm750fb/ddk750_mode.c | 4 ++-- > 1 file changed, 2

Re: [PATCH 2/3] x86: Convert vdso to use vm_fault_t

2018-08-27 Thread Matthew Wilcox
On Mon, Aug 27, 2018 at 09:01:48PM +0530, Souptick Joarder wrote: > On Fri, Aug 3, 2018 at 6:44 PM Thomas Gleixner wrote: > > > > On Fri, 3 Aug 2018, Souptick Joarder wrote: > > > On Mon, Jul 16, 2018 at 2:47 PM, Thomas Gleixner > > > wrote: > > > > On Tue, 3 Jul 2018, Matthew Wilcox wrote: > >

Re: [PATCH 2/3] x86: Convert vdso to use vm_fault_t

2018-08-27 Thread Matthew Wilcox
On Mon, Aug 27, 2018 at 09:01:48PM +0530, Souptick Joarder wrote: > On Fri, Aug 3, 2018 at 6:44 PM Thomas Gleixner wrote: > > > > On Fri, 3 Aug 2018, Souptick Joarder wrote: > > > On Mon, Jul 16, 2018 at 2:47 PM, Thomas Gleixner > > > wrote: > > > > On Tue, 3 Jul 2018, Matthew Wilcox wrote: > >

Re: [PATCH v5 1/4] staging: mt7621-mmc: Remove commented code for N_MSG

2018-08-27 Thread Greg Kroah-Hartman
On Thu, Aug 23, 2018 at 10:58:09PM +0530, Nishad Kamdar wrote: > This patch removes the dead code for N_MSG(). > > Signed-off-by: Nishad Kamdar > --- > Changes in v5: > - Remove commented code for N_MSG() > --- > drivers/staging/mt7621-mmc/dbg.h | 8 > 1 file changed, 8 deletions(-)

Re: [PATCH v5 1/4] staging: mt7621-mmc: Remove commented code for N_MSG

2018-08-27 Thread Greg Kroah-Hartman
On Thu, Aug 23, 2018 at 10:58:09PM +0530, Nishad Kamdar wrote: > This patch removes the dead code for N_MSG(). > > Signed-off-by: Nishad Kamdar > --- > Changes in v5: > - Remove commented code for N_MSG() > --- > drivers/staging/mt7621-mmc/dbg.h | 8 > 1 file changed, 8 deletions(-)

Re: [PATCH 01/17] staging:rtl8192u: Remove unused defines - Style

2018-08-27 Thread Greg KH
On Tue, Aug 21, 2018 at 06:15:21PM +0100, John Whitmore wrote: > Remove a number of unused constant definitions. > > This is a coding style change which should have no impact on runtime > code execution. > > Signed-off-by: John Whitmore > --- > drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h |

Re: [PATCH 01/17] staging:rtl8192u: Remove unused defines - Style

2018-08-27 Thread Greg KH
On Tue, Aug 21, 2018 at 06:15:21PM +0100, John Whitmore wrote: > Remove a number of unused constant definitions. > > This is a coding style change which should have no impact on runtime > code execution. > > Signed-off-by: John Whitmore > --- > drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h |

Re: WARNING: kernel stack frame pointer has bad value (2)

2018-08-27 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:2ad0d5269970 Merge git://git.kernel.org/pub/scm/linux/kern.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=14f7f36a40 kernel config:

Re: WARNING: kernel stack frame pointer has bad value (2)

2018-08-27 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:2ad0d5269970 Merge git://git.kernel.org/pub/scm/linux/kern.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=14f7f36a40 kernel config:

[PATCH v2] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-27 Thread Kim Phillips
Starting with binutils 2.28, aarch64 objdump adds comments to the disassembly output to show the alternative names of a condition code [1]. It is assumed that commas in objdump comments could occur in other arches now or in the future, so this fix is arch-independent. The fix could have been

[PATCH v2] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-27 Thread Kim Phillips
Starting with binutils 2.28, aarch64 objdump adds comments to the disassembly output to show the alternative names of a condition code [1]. It is assumed that commas in objdump comments could occur in other arches now or in the future, so this fix is arch-independent. The fix could have been

Re: [PATCH] include/linux/compiler*.h: Use feature checking instead of version checks for attributes

2018-08-27 Thread Nick Desaulniers
On Mon, Aug 27, 2018 at 10:43 AM Nick Desaulniers wrote: > > On Sun, Aug 26, 2018 at 10:58 AM Miguel Ojeda > wrote: > > > > Instead of using version checks per-compiler to define (or not) each > > attribute, > > use __has_attribute to test for them, following the cleanup started with > > commit

Re: [PATCH] include/linux/compiler*.h: Use feature checking instead of version checks for attributes

2018-08-27 Thread Nick Desaulniers
On Mon, Aug 27, 2018 at 10:43 AM Nick Desaulniers wrote: > > On Sun, Aug 26, 2018 at 10:58 AM Miguel Ojeda > wrote: > > > > Instead of using version checks per-compiler to define (or not) each > > attribute, > > use __has_attribute to test for them, following the cleanup started with > > commit

[RFC PATCH 1/3] exec: separate thread_count for files_struct

2018-08-27 Thread Jeff Layton
Currently, we have a single refcount variable inside the files_struct. When we go to unshare the files_struct, we check this counter and if it's elevated, then we allocate a new files_struct instead of just repurposing the old one, under the assumption that that indicates that it's shared between

[RFC PATCH 3/3] exec: do unshare_files after de_thread

2018-08-27 Thread Jeff Layton
POSIX mandates that open fds and their associated file locks should be preserved across an execve. This works, unless the process is multithreaded at the time that execve is called. In that case, we'll end up unsharing the files_struct but the locks will still have their fl_owner set to the

[RFC PATCH 0/3] exec: fix passing of file locks across execve in multithreaded processes

2018-08-27 Thread Jeff Layton
A few months ago, Dan reported that when you call execve in process that is multithreaded, any traditional POSIX locks are silently dropped. The problem is that we end up unsharing the files_struct from the process very early during exec, when it looks like it's shared between tasks. Eventually,

[RFC PATCH 1/3] exec: separate thread_count for files_struct

2018-08-27 Thread Jeff Layton
Currently, we have a single refcount variable inside the files_struct. When we go to unshare the files_struct, we check this counter and if it's elevated, then we allocate a new files_struct instead of just repurposing the old one, under the assumption that that indicates that it's shared between

[RFC PATCH 3/3] exec: do unshare_files after de_thread

2018-08-27 Thread Jeff Layton
POSIX mandates that open fds and their associated file locks should be preserved across an execve. This works, unless the process is multithreaded at the time that execve is called. In that case, we'll end up unsharing the files_struct but the locks will still have their fl_owner set to the

[RFC PATCH 0/3] exec: fix passing of file locks across execve in multithreaded processes

2018-08-27 Thread Jeff Layton
A few months ago, Dan reported that when you call execve in process that is multithreaded, any traditional POSIX locks are silently dropped. The problem is that we end up unsharing the files_struct from the process very early during exec, when it looks like it's shared between tasks. Eventually,

[RFC PATCH 2/3] exec: delay clone(CLONE_FILES) if task associated with current files_struct is exec'ing

2018-08-27 Thread Jeff Layton
In a later patch, we're going to move the unshare_files call in __do_execve_file to later in the process, but this opens up a potential race with clone(CLONE_FILES). We could end up bumping the refcount on the files_struct after we've checked to see if it was shared. What we really want to do in

[RFC PATCH 2/3] exec: delay clone(CLONE_FILES) if task associated with current files_struct is exec'ing

2018-08-27 Thread Jeff Layton
In a later patch, we're going to move the unshare_files call in __do_execve_file to later in the process, but this opens up a potential race with clone(CLONE_FILES). We could end up bumping the refcount on the files_struct after we've checked to see if it was shared. What we really want to do in

Re: [PATCH] cpupower: remove stringop-truncation waring

2018-08-27 Thread Shuah Khan
On 08/21/2018 06:02 AM, Anders Roxell wrote: > The strncpy doesn't null terminate the string because the size is too > short by one byte. > > parse.c: In function ‘prepare_default_config’: > parse.c:148:2: warning: ‘strncpy’ output truncated before terminating > nul copying 8 bytes from a

Re: [PATCH] cpupower: remove stringop-truncation waring

2018-08-27 Thread Shuah Khan
On 08/21/2018 06:02 AM, Anders Roxell wrote: > The strncpy doesn't null terminate the string because the size is too > short by one byte. > > parse.c: In function ‘prepare_default_config’: > parse.c:148:2: warning: ‘strncpy’ output truncated before terminating > nul copying 8 bytes from a

Re: [PATCH] include/linux/compiler*.h: Use feature checking instead of version checks for attributes

2018-08-27 Thread Nick Desaulniers
On Sun, Aug 26, 2018 at 10:58 AM Miguel Ojeda wrote: > > Instead of using version checks per-compiler to define (or not) each > attribute, > use __has_attribute to test for them, following the cleanup started with > commit 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually >

Re: [PATCH] include/linux/compiler*.h: Use feature checking instead of version checks for attributes

2018-08-27 Thread Nick Desaulniers
On Sun, Aug 26, 2018 at 10:58 AM Miguel Ojeda wrote: > > Instead of using version checks per-compiler to define (or not) each > attribute, > use __has_attribute to test for them, following the cleanup started with > commit 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually >

Re: TLB flushes on fixmap changes

2018-08-27 Thread Nadav Amit
at 1:05 AM, Masami Hiramatsu wrote: > On Sun, 26 Aug 2018 20:26:09 -0700 > Nadav Amit wrote: > >> at 8:03 PM, Masami Hiramatsu wrote: >> >>> On Sun, 26 Aug 2018 11:09:58 +0200 >>> Peter Zijlstra wrote: >>> On Sat, Aug 25, 2018 at 09:21:22PM -0700, Andy Lutomirski wrote: > I just

Re: TLB flushes on fixmap changes

2018-08-27 Thread Nadav Amit
at 1:05 AM, Masami Hiramatsu wrote: > On Sun, 26 Aug 2018 20:26:09 -0700 > Nadav Amit wrote: > >> at 8:03 PM, Masami Hiramatsu wrote: >> >>> On Sun, 26 Aug 2018 11:09:58 +0200 >>> Peter Zijlstra wrote: >>> On Sat, Aug 25, 2018 at 09:21:22PM -0700, Andy Lutomirski wrote: > I just

Re: [PATCH 3/4] iio: fxas21002c: add ODR/Scale support

2018-08-27 Thread Jonathan Cameron
On Sat, 25 Aug 2018 22:19:09 +0100 Afonso Bordado wrote: > This patch adds support for reading/writing ODR/Scale > > We don't support the scale boost modes. > > Signed-off-by: Afonso Bordado A few trivial bits in here. Jonathan > --- > drivers/iio/gyro/fxas21002c.c | 162

Re: [PATCH 3/4] iio: fxas21002c: add ODR/Scale support

2018-08-27 Thread Jonathan Cameron
On Sat, 25 Aug 2018 22:19:09 +0100 Afonso Bordado wrote: > This patch adds support for reading/writing ODR/Scale > > We don't support the scale boost modes. > > Signed-off-by: Afonso Bordado A few trivial bits in here. Jonathan > --- > drivers/iio/gyro/fxas21002c.c | 162

[PATCH] fs: iomap: Change return type to vm_fault_t

2018-08-27 Thread Souptick Joarder
Return type has been changed to vm_fault_t type for iomap_page_mkwrite(). see commit 1c8f422059ae ("mm: change return type to vm_fault_t") for reference. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- fs/iomap.c| 2 +- include/linux/iomap.h | 4 +++- 2 files

[PATCH] fs: iomap: Change return type to vm_fault_t

2018-08-27 Thread Souptick Joarder
Return type has been changed to vm_fault_t type for iomap_page_mkwrite(). see commit 1c8f422059ae ("mm: change return type to vm_fault_t") for reference. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- fs/iomap.c| 2 +- include/linux/iomap.h | 4 +++- 2 files

Re: [PATCH 2/4] iio: gyro: add device tree support for fxas21002c

2018-08-27 Thread Jonathan Cameron
On Sat, 25 Aug 2018 22:19:08 +0100 Afonso Bordado wrote: > This patch adds device tree support for the fxas21002c driver, including > bindings. > > Signed-off-by: Afonso Bordado Now, the devicetree bindings should not reflect just what the driver uses right now, but rather describe the

Re: [PATCH 2/4] iio: gyro: add device tree support for fxas21002c

2018-08-27 Thread Jonathan Cameron
On Sat, 25 Aug 2018 22:19:08 +0100 Afonso Bordado wrote: > This patch adds device tree support for the fxas21002c driver, including > bindings. > > Signed-off-by: Afonso Bordado Now, the devicetree bindings should not reflect just what the driver uses right now, but rather describe the

Re: [GIT PULL] (xen) stable/for-jens-4.19 for 4.19..

2018-08-27 Thread Jens Axboe
On 8/27/18 10:19 AM, Konrad Rzeszutek Wilk wrote: > Hey Jens, > > Would you be OK pulling the following branch: > git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git > stable/for-jens-4.19 > > which has a fix for flushing out persistent pages at a deterministic rate. > > Thanks to

Re: [GIT PULL] (xen) stable/for-jens-4.19 for 4.19..

2018-08-27 Thread Jens Axboe
On 8/27/18 10:19 AM, Konrad Rzeszutek Wilk wrote: > Hey Jens, > > Would you be OK pulling the following branch: > git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git > stable/for-jens-4.19 > > which has a fix for flushing out persistent pages at a deterministic rate. > > Thanks to

Re: Linux 4.19-rc1

2018-08-27 Thread Guenter Roeck
On Mon, Aug 27, 2018 at 08:46:41AM -0700, Christoph Hellwig wrote: > > sparc: > > > > WARNING: CPU: 0 PID: 1 at ./include/linux/dma-mapping.h:516 > > esp_sbus_probe+0x408/0x6e8 > > WARNING: CPU: 0 PID: 1 at ./include/linux/dma-mapping.h:516 > > sparc_lance_probe_one+0x428/0x4f > > > > Missing

Re: Linux 4.19-rc1

2018-08-27 Thread Guenter Roeck
On Mon, Aug 27, 2018 at 08:46:41AM -0700, Christoph Hellwig wrote: > > sparc: > > > > WARNING: CPU: 0 PID: 1 at ./include/linux/dma-mapping.h:516 > > esp_sbus_probe+0x408/0x6e8 > > WARNING: CPU: 0 PID: 1 at ./include/linux/dma-mapping.h:516 > > sparc_lance_probe_one+0x428/0x4f > > > > Missing

Re: [PATCH 2/3] arm64: dts: qcom: pm8998: Add adc node

2018-08-27 Thread Matthias Kaehlcke
On Fri, Aug 10, 2018 at 05:09:17PM -0700, Doug Anderson wrote: > Hi, > > On Wed, Aug 8, 2018 at 12:13 PM, Matthias Kaehlcke wrote: > > This adds the adc node to pm8998 based on the examples in the > > bindings. It also fixes the order of the included headers. > > > > Signed-off-by: Matthias

Re: [PATCH 2/3] arm64: dts: qcom: pm8998: Add adc node

2018-08-27 Thread Matthias Kaehlcke
On Fri, Aug 10, 2018 at 05:09:17PM -0700, Doug Anderson wrote: > Hi, > > On Wed, Aug 8, 2018 at 12:13 PM, Matthias Kaehlcke wrote: > > This adds the adc node to pm8998 based on the examples in the > > bindings. It also fixes the order of the included headers. > > > > Signed-off-by: Matthias

WARNING in format_decode (2)

2018-08-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:2ad0d5269970 Merge git://git.kernel.org/pub/scm/linux/kern.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=15b8efba40 kernel config: https://syzkaller.appspot.com/x/.config?x=79e695838ce7a210

INFO: rcu detected stall in snd_seq_write

2018-08-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:e27bc174c9c6 Add linux-next specific files for 20180824 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=16e0823e40 kernel config: https://syzkaller.appspot.com/x/.config?x=28446088176757ea

WARNING in format_decode (2)

2018-08-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:2ad0d5269970 Merge git://git.kernel.org/pub/scm/linux/kern.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=15b8efba40 kernel config: https://syzkaller.appspot.com/x/.config?x=79e695838ce7a210

INFO: rcu detected stall in snd_seq_write

2018-08-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:e27bc174c9c6 Add linux-next specific files for 20180824 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=16e0823e40 kernel config: https://syzkaller.appspot.com/x/.config?x=28446088176757ea

Re: [PATCH 1/4] iio: gyro: add support for fxas21002c

2018-08-27 Thread Jonathan Cameron
On Sat, 25 Aug 2018 22:19:07 +0100 Afonso Bordado wrote: > FXAS21002C is a 3 axis gyroscope with integrated temperature sensor > > Signed-off-by: Afonso Bordado Hi, Driver is pretty clean so only a few minor comments inline. If we were late in a cycle I'd probably just have taken it and

Re: [PATCH 1/4] iio: gyro: add support for fxas21002c

2018-08-27 Thread Jonathan Cameron
On Sat, 25 Aug 2018 22:19:07 +0100 Afonso Bordado wrote: > FXAS21002C is a 3 axis gyroscope with integrated temperature sensor > > Signed-off-by: Afonso Bordado Hi, Driver is pretty clean so only a few minor comments inline. If we were late in a cycle I'd probably just have taken it and

[PATCHv3] perf tools: Add struct ordered_events_buffer layer

2018-08-27 Thread Jiri Olsa
On Mon, Aug 27, 2018 at 08:24:56AM -0700, Stephane Eranian wrote: SNIP > > - /* First entry is abused to maintain the to_free list. */ > > - oe->buffer_idx = 2; > > - new = oe->buffer + 1; > > + oe->buffer_idx = 1; > > + new =

[PATCHv3] perf tools: Add struct ordered_events_buffer layer

2018-08-27 Thread Jiri Olsa
On Mon, Aug 27, 2018 at 08:24:56AM -0700, Stephane Eranian wrote: SNIP > > - /* First entry is abused to maintain the to_free list. */ > > - oe->buffer_idx = 2; > > - new = oe->buffer + 1; > > + oe->buffer_idx = 1; > > + new =

<    2   3   4   5   6   7   8   9   10   11   >