Re: [PATCH 2/2 -mm] mm: brk: dwongrade mmap_sem to read when shrinking

2018-09-26 Thread Michal Hocko
On Wed 26-09-18 08:46:56, Yang Shi wrote: > brk might be used to shinrk memory mapping too. Use __do_munmap() to > shrink mapping with downgrading mmap_sem to read. same comment wrt the changelog as for the previous patch. -- Michal Hocko SUSE Labs

Re: [PATCH 1/2 -mm] mm: mremap: dwongrade mmap_sem to read when shrinking

2018-09-26 Thread Michal Hocko
On Wed 26-09-18 08:46:55, Yang Shi wrote: > Other than munmap, mremap might be used to shrink memory mapping too. > Use __do_munmap() to shrink mapping with downgrading mmap_sem to read. Please be more explicit about _why_ this is OK. It wouldn't hurt to call out benefits explicitly as well. You w

Re: [PATCH] mmc: pwrseq_simple: Fix incorrect handling of GPIO bitmap

2018-09-26 Thread Marek Szyprowski
Hi Janusz, On 2018-09-25 21:24, Janusz Krzysztofik wrote: > Commit b9762bebc633 ("gpiolib: Pass bitmaps, not integer arrays, to > get/set array") changed the way GPIO values are passed to > gpiod_get/set_array_value() and friends. The updated code of > mmc_pwrseq_simple_set_gpios_value() incorrec

Re: [PATCH RESEND] mm: don't raise MEMCG_OOM event due to failed high-order allocation

2018-09-26 Thread Roman Gushchin
On Tue, Sep 25, 2018 at 08:58:45PM +0200, Michal Hocko wrote: > On Mon 17-09-18 23:10:59, Roman Gushchin wrote: > > The memcg OOM killer is never invoked due to a failed high-order > > allocation, however the MEMCG_OOM event can be raised. > > > > As shown below, it can happen under conditions, wh

Re: [PATCH] sched/fair: Don't increase sd->balance_interval on newidle balance

2018-09-26 Thread Vincent Guittot
On Tue, 25 Sep 2018 at 19:38, Valentin Schneider wrote: > > When load_balance() fails to move some load because of task affinity, > we end up increasing sd->balance_interval to delay the next periodic > balance in the hopes that next time we look, that annoying pinned > task(s) will be gone. It's

Re: [PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-26 Thread Song Qiang
On Wed, Sep 26, 2018 at 10:30:34AM +0800, Phil Reid wrote: > On 26/09/2018 9:49 AM, Song Qiang wrote: > > On Tue, Sep 25, 2018 at 10:36:54PM +0800, Phil Reid wrote: > > > On 25/09/2018 9:30 PM, Jonathan Cameron wrote: > > > > > +static irqreturn_t rm3100_trigger_handler(int irq, void *p) > > > > >

Re: [PATCH v2 4/4] power: supply: Add Spreadtrum SC27XX fuel gauge unit driver

2018-09-26 Thread Linus Walleij
On Wed, Sep 26, 2018 at 5:00 AM Baolin Wang wrote: > This patch adds the Spreadtrum SC27XX serial PMICs fuel gauge support, > which is used to calculate the battery capacity. > > Original-by: Yuanjiang Yu > Signed-off-by: Baolin Wang > --- > Changes from v1: > - Use battery standard properties

Re: [PATCH v2 3/4] dt-bindings: power: Add Spreadtrum SC27XX fuel gauge unit documentation

2018-09-26 Thread Linus Walleij
On Wed, Sep 26, 2018 at 5:00 AM Baolin Wang wrote: > This patch adds the binding documentation for Spreadtrum SC27XX series PMICs > fuel gauge unit device, which is used to calculate the battery capacity. > > Signed-off-by: Baolin Wang > --- > Changes from v1: > - Renamed GPIO property. > - Us

Re: [Problem] Cache line starvation

2018-09-26 Thread Thomas Gleixner
On Wed, 26 Sep 2018, Peter Zijlstra wrote: > On Fri, Sep 21, 2018 at 02:02:26PM +0200, Sebastian Andrzej Siewior wrote: > > Instrumentation show always the picture: > > > > CPU0 CPU1 > > => do_syscall_64 => do_syscall_64 > > => S

Re: [PATCH v2] of: unittest: Disable interrupt node tests for old world MAC systems

2018-09-26 Thread Frank Rowand
On 09/25/18 21:06, Guenter Roeck wrote: > On systems with OF_IMAP_OLDWORLD_MAC set in of_irq_workarounds, the > devicetree interrupt parsing code is different, causing unit tests of > devicetree interrupt nodes to fail. Due to a bug in unittest code, which > tries to dereference an uninitialized po

Re: [PATCH v2 2/4] power: supply: core: Introduce properties to present the battery OCV table

2018-09-26 Thread Linus Walleij
On Wed, Sep 26, 2018 at 5:00 AM Baolin Wang wrote: > Some battery driver will use the open circuit voltage (OCV) value to look > up the corresponding battery capacity percent in one certain degree Celsius. > Thus this patch provides some battery properties to present the OCV table > temperatures

Re: [PATCH v2 1/4] power: supply: core: Introduce one property to present the battery internal resistance

2018-09-26 Thread Linus Walleij
On Wed, Sep 26, 2018 at 4:59 AM Baolin Wang wrote: > Introduce one property to present the battery internal resistance for battery > information. > > Signed-off-by: Baolin Wang > --- > Changes from v1: > - New patch in v2. I'm a bit confused by the physics in this patch. The internal resistan

Re: [PATCH v5 04/12] PCI: brcmstb: add dma-range mapping for inbound traffic

2018-09-26 Thread Ard Biesheuvel
On Wed, 26 Sep 2018 at 04:59, Florian Fainelli wrote: > > > > On 9/24/2018 8:01 AM, Jim Quinlan wrote: > > On Mon, Sep 24, 2018 at 4:25 AM Ard Biesheuvel > > wrote: > >> > >> On Fri, 21 Sep 2018 at 19:41, Jim Quinlan wrote: > >>> > >>> On Thu, Sep 20, 2018 at 5:39 PM Florian Fainelli > >>> wro

RE: [PATCH] Raise maximum number of memory controllers

2018-09-26 Thread Zhuo, Qiuxu
Hi Justin, > [ 3401.987556] EDAC MC15: Giving out device to module skx_edac controller > Skylake Socket#1 IMC#1 Just curious, has the system(two memory controllers per socket) got more than 8 sockets? Normally, the number "1" in the above string "Skylake Socekt#1 IMC#1" should be 7 (tha

KASAN: stack-out-of-bounds Read in __aa_lookupn_ns

2018-09-26 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:02214bfc89c7 Merge tag 'media/v4.19-2' of git://git.kernel.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=159b85f140 kernel config: https://syzkaller.appspot.com/x/.config?x=22a62640793a83c9 da

general protection fault in __aa_lookupn_ns

2018-09-26 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:dad486875956 Add linux-next specific files for 20180924 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=15da1fd140 kernel config: https://syzkaller.appspot.com/x/.config?x=3e793f6258a2ee8f dashb

Re: [PATCH] mmc: pwrseq_simple: Fix incorrect handling of GPIO bitmap

2018-09-26 Thread Linus Walleij
On Tue, Sep 25, 2018 at 9:23 PM Janusz Krzysztofik wrote: > Commit b9762bebc633 ("gpiolib: Pass bitmaps, not integer arrays, to > get/set array") changed the way GPIO values are passed to > gpiod_get/set_array_value() and friends. The updated code of > mmc_pwrseq_simple_set_gpios_value() incorre

Re: sdhci driver card-detect is broken because gpiolib can't fallback to _CRS?

2018-09-26 Thread Mika Westerberg
Hi, On Tue, Sep 25, 2018 at 01:54:57PM -0700, Rajat Jain wrote: > * Use con_id=NULL if it is dealing with a legacy BIOS (i.e. no _DSD > properties in the ACPI). > * Use con_id= if it is dealing with a modern BIOS (i.e. > which provides _DSD for the property) Or you can use con_id= everywhere and

Re: [PATCH] scheduler: conditional statement cleanup

2018-09-26 Thread Peter Zijlstra
On Fri, Sep 21, 2018 at 03:22:03PM -0500, PierceGriffiths wrote: > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 625bc9897f62..443a1f235cfd 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -617,12 +617,8 @@ bool sched_can_stop_tick(struct rq *rq) >* If th

possible deadlock in lookup_slow

2018-09-26 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:846e8dd47c26 Merge tag 'scsi-fixes' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16de846e40 kernel config: https://syzkaller.appspot.com/x/.config?x=dfb440e26f0a6f6f da

Re: [PATCH 3/4] dt-bindings: pinctrl: qcom: Add QCS404 pinctrl binding

2018-09-26 Thread Linus Walleij
On Tue, Sep 25, 2018 at 1:24 PM Rob Herring wrote: > On Wed, 19 Sep 2018 18:37:11 -0700, Bjorn Andersson wrote: > > Add the binding for the TLMM pinctrl block found in the QCS404 platform. > > > > Signed-off-by: Bjorn Andersson > > --- > > .../bindings/pinctrl/qcom,qcs404-pinctrl.txt | 200

Re: m68k allmodconfig build errors

2018-09-26 Thread Geert Uytterhoeven
Hi Andreas, On Tue, Jul 24, 2018 at 7:35 PM Andreas Schwab wrote: > On Jul 23 2018, Randy Dunlap wrote: > > I don't see that all of these string compare fields are null-terminated. > > That gcc has converted the strncmp calls to strcmp is a pretty strong > evidence that they are. Isn't gcc-8 ju

RE: [PATCH] platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items

2018-09-26 Thread Vadim Pasternak
> -Original Message- > From: Nathan Chancellor > Sent: Wednesday, September 26, 2018 8:21 AM > To: Vadim Pasternak ; Darren Hart > ; Andy Shevchenko > Cc: platform-driver-...@vger.kernel.org; linux-kernel@vger.kernel.org; Nathan > Chancellor > Subject: [PATCH] platform/x86: mlx-platfo

Re: [PATCH] pinctrl: mediatek: fix check on EINT_NA comparison

2018-09-26 Thread Linus Walleij
On Tue, Sep 25, 2018 at 11:55 AM Colin King wrote: > From: Colin Ian King > > Currently, the check on desc->eint.eint_n == EINT_NA is always false > because this is comparing a u16 to -1 which can never be true. Fix > this by casting EINT_NA to u16. > > Detected by CoverityScan, CID#1473610 ("O

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as maybe unused

2018-09-26 Thread Nathan Chancellor
On Wed, Sep 26, 2018 at 09:13:59AM +0200, Greg Kroah-Hartman wrote: > On Wed, Sep 26, 2018 at 12:02:09AM -0700, Nathan Chancellor wrote: > > Clang emits the following warning: > > > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:25:36: warning: variable > > 'acpi_ids' is not needed and will not be

KASAN: use-after-free Read in relay_switch_subbuf

2018-09-26 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:2dd68cc7fd8c Merge gitolite.kernel.org:/pub/scm/linux/kern.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=105fe67640 kernel config: https://syzkaller.appspot.com/x/.config?x=22a62640793a83c9 da

Re: [PATCH 3/3] rtc: ab8500: remove useless check

2018-09-26 Thread Linus Walleij
On Mon, Sep 24, 2018 at 4:49 PM Alexandre Belloni wrote: > rtc_time_to_tm always rturns a valid tm, there is no need to validate it. > > Signed-off-by: Alexandre Belloni Acked-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 2/3] rtc: ab8500: let the core handle range

2018-09-26 Thread Linus Walleij
On Mon, Sep 24, 2018 at 4:49 PM Alexandre Belloni wrote: > Let the core handle offsetting and windowing the RTC range. > The RTC has a 24 bit counter for minutes plus a seconds counter. > Keep the epoch at the beginning of 2000. > > Signed-off-by: Alexandre Belloni Acked-by: Linus Walleij You

Re: [PATCH 1/3] rtc: ab8500: use rtc_add_group

2018-09-26 Thread Linus Walleij
On Mon, Sep 24, 2018 at 4:49 PM Alexandre Belloni wrote: > Use rtc_add_group to add the sysfs group in a race free manner. > > Signed-off-by: Alexandre Belloni Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v5 2/4] mm: Provide kernel parameter to allow disabling page init poisoning

2018-09-26 Thread Michal Hocko
On Tue 25-09-18 13:20:12, Alexander Duyck wrote: [...] > + vm_debug[=options] [KNL] Available with CONFIG_DEBUG_VM=y. > + May slow down system boot speed, especially when > + enabled on systems with a large amount of memory. > + A

Re: [Problem] Cache line starvation

2018-09-26 Thread Peter Zijlstra
On Fri, Sep 21, 2018 at 02:02:26PM +0200, Sebastian Andrzej Siewior wrote: > Instrumentation show always the picture: > > CPU0 CPU1 > => do_syscall_64 => do_syscall_64 > => SyS_ptrace => syscall_

Re: [PATCH v2 4/4] pinctrl: qcom: Add qcs404 pinctrl driver

2018-09-26 Thread Linus Walleij
On Tue, Sep 25, 2018 at 12:15 AM Bjorn Andersson wrote: > From: Avaneesh Kumar Dwivedi > > Add initial pinctrl driver to support pin configuration with > pinctrl framework for qcs404. > > Signed-off-by: Avaneesh Kumar Dwivedi > Signed-off-by: Chintan Pandya > Signed-off-by: Anu Ramanathan > [

[PATCH -next] ASoC: qcom: qdsp6: remove duplicated include

2018-09-26 Thread YueHaibing
Remove duplicated includes linux/of_platform.h and linux/wait.h Signed-off-by: YueHaibing --- sound/soc/qcom/qdsp6/q6asm.c | 1 - sound/soc/qcom/qdsp6/q6core.c | 1 - 2 files changed, 2 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c index 2b2c723..e1cfa84

Re: [PATCH] x86/boot: Fix kexec booting failure after SEV early boot support

2018-09-26 Thread Baoquan He
On 09/25/18 at 07:26pm, Borislav Petkov wrote: > IINM, the problem can be addressed in a simpler way by getting rid of > enc_bit and thus getting rid of the need to do relative addressing of > anything and simply doing the whole dance of figuring out the C-bit each > time. It probably wouldn't be e

Re: [PATCH v2 3/4] dt-bindings: pinctrl: qcom: Add QCS404 pinctrl binding

2018-09-26 Thread Linus Walleij
On Tue, Sep 25, 2018 at 12:15 AM Bjorn Andersson wrote: > Add the binding for the TLMM pinctrl block found in the QCS404 platform. > > Signed-off-by: Bjorn Andersson > --- > > Changes since v1: > - Dropped leading 0 in node address Patch applied. Non-controversial bindings and minor issue fixed

Re: [PATCH 6/7] drivers: oprofile: Avoids building driver from direct make command

2018-09-26 Thread Rolf Eike Beer
Leonardo Brás wrote: Creates new Makefile to avoid building driver if 'make drivers/oprofile/' is called directly. This driver is usually built from arch/$ARCH and seems to have no meaning building alone. Signed-off-by: Leonardo Brás --- drivers/oprofile/Makefile | 1 + 1 file changed, 1 inse

Re: [PATCH v2 2/4] pinctrl: qcom: Support dispersed tiles

2018-09-26 Thread Linus Walleij
On Tue, Sep 25, 2018 at 12:15 AM Bjorn Andersson wrote: > On some new platforms the tiles have been placed too far apart to be > covered in a single ioremap. Turn "regs" into an array of base addresses > and make the pingroup carry the information about which tile the pin > resides in. > > For ex

Re: [PATCH v2 1/4] pinctrl: qcom: Introduce readl/writel accessors

2018-09-26 Thread Linus Walleij
On Tue, Sep 25, 2018 at 12:15 AM Bjorn Andersson wrote: > In preparation for the support for dispersed tiles move all readl and > writel calls to helper functions. This will allow us to isolate the > added complexity of another indirection. > > Signed-off-by: Bjorn Andersson > --- > > Changes si

Re: [PATCH v2] dt-bindings: pinctrl: qcom-pmic-gpio: Add pms405 support

2018-09-26 Thread Linus Walleij
On Tue, Sep 25, 2018 at 2:04 AM Bjorn Andersson wrote: > From: Vinod Koul > > Add support for the PMS405 GPIO support to the Qualcomm PMIC GPIO > binding. > > Signed-off-by: Vinod Koul > Signed-off-by: Bjorn Andersson > --- > > Changes since v1: > - Dropped unnecessary driver update > - Update

Re: [PATCH v11 25/26] KVM: s390: CPU model support for AP virtualization

2018-09-26 Thread Christian Borntraeger
On 09/26/2018 09:15 AM, David Hildenbrand wrote: > On 26/09/2018 01:16, Tony Krowiak wrote: >> From: Tony Krowiak >> >> Introduces two new CPU model facilities to support >> AP virtualization for KVM guests: >> >> 1. AP Query Configuration Information (QCI) facility is installed. >> >>This

Re: [PATCH v2] ARM: use choice for kernel unwinders

2018-09-26 Thread Arnd Bergmann
On Tue, Sep 25, 2018 at 11:20 PM Stefan Agner wrote: > > While in theory multiple unwinders could be compiled in, it does > not make sense in practise. Use a choice to make the unwinder > selection mutually exclusive and mandatory. > > Already before this commit it has not been possible to deselec

Re: [PATCH v3 2/2] dt-bindings: Document the Synopsys GPIO via CREG bindings

2018-09-26 Thread Linus Walleij
On Tue, Sep 11, 2018 at 5:09 PM Eugeniy Paltsev wrote: > This patch adds documentation of device tree bindings for the Synopsys > GPIO via CREG driver. > > Signed-off-by: Eugeniy Paltsev Reviewed-by: Linus Walleij This is fine, just waiting for the final version of the driver. Yours, Linus W

Re: [PATCH v11 04/26] s390: vfio-ap: base implementation of VFIO AP device driver

2018-09-26 Thread David Hildenbrand
On 26/09/2018 01:16, Tony Krowiak wrote: > From: Tony Krowiak > > Introduces a new AP device driver. This device driver > is built on the VFIO mediated device framework. The framework > provides sysfs interfaces that facilitate passthrough > access by guests to devices installed on the linux host

Re: [patch v3] mm, thp: always specify disabled vmas as nh in smaps

2018-09-26 Thread Michal Hocko
On Wed 26-09-18 08:12:47, Michal Hocko wrote: > On Tue 25-09-18 14:50:52, David Rientjes wrote: > [...] > Let's put my general disagreement with the approach asside for a while. > If this is really the best way forward the is the implementation really > correct? > > > + /* > > +* Disabling t

Re: [PATCH v11 15/26] KVM: s390: Clear Crypto Control Block when using vSIE

2018-09-26 Thread David Hildenbrand
On 26/09/2018 01:16, Tony Krowiak wrote: > From: Pierre Morel > > When we clear the Crypto Control Block (CRYCB) used by a guest > level 2, the vSIE shadow CRYCB for guest level 3 must be updated > before the guest uses it. > > We achieve this by using the KVM_REQ_VSIE_RESTART synchronous > requ

Re: [GIT PULL] ARM: at91: SoC for 4.20

2018-09-26 Thread Ludovic Desroches
On Tue, Sep 25, 2018 at 01:38:12PM -0700, Olof Johansson wrote: > On Tue, Sep 25, 2018 at 12:37:35PM +0200, Alexandre Belloni wrote: > > Arnd, Olof, > > > > Most changes are shuffling around the maintainers entries. There are > > also two PM non urgent fixes. > > > > This one as a trivial conflic

Re: [PATCH v11 25/26] KVM: s390: CPU model support for AP virtualization

2018-09-26 Thread David Hildenbrand
On 26/09/2018 01:16, Tony Krowiak wrote: > From: Tony Krowiak > > Introduces two new CPU model facilities to support > AP virtualization for KVM guests: > > 1. AP Query Configuration Information (QCI) facility is installed. > >This is indicated by setting facilities bit 12 for >the gues

Re: [PATCH v11 24/26] KVM: s390: device attrs to enable/disable AP interpretation

2018-09-26 Thread David Hildenbrand
> ret = -ENXIO; > break; > @@ -2062,6 +2085,7 @@ static u64 kvm_s390_get_initial_cpuid(void) > static void kvm_s390_crypto_init(struct kvm *kvm) > { Only two NITs, > kvm->arch.crypto.crycb = &kvm->arch.sie_page2->crycb; > + kvm->arch.crypto.

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as maybe unused

2018-09-26 Thread Greg Kroah-Hartman
On Wed, Sep 26, 2018 at 12:02:09AM -0700, Nathan Chancellor wrote: > Clang emits the following warning: > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:25:36: warning: variable > 'acpi_ids' is not needed and will not be emitted > [-Wunneeded-internal-declaration] > static const struct acpi_device

Re: [PATCH 3/5] lib: Add umoddi3 and udivmoddi4 of GCC library routines

2018-09-26 Thread Zong Li
Andreas Schwab 於 2018年9月25日 週二 下午3:20寫道: > > On Sep 25 2018, Zong Li wrote: > > > The RV32 need the umoddi3 to do modulo when the operands are long long > > type, like other libraries implementation such as ucmpdi2, lshrdi3 and > > so on. I encounter the undefined reference 'umoddi3' when I use t

Re: [PATCH] arm64: dts: rockchip: Enable SPI NOR flash on Rock64

2018-09-26 Thread Frieder Schrempf
On 26.09.2018 06:53, Chen-Yu Tsai wrote: The Pine64 Rock64 board comes with a GigaDevice GD25Q128CSIG or GD25Q127CSIG chip, which is a 128 Mbit SPI NOR flash chip that supports the JEDEC read-ID command. This patch enables the SPI controller and adds a device node for the flash chip using the ge

Re: [PATCH 0/7] Remove errors building drivers/DRIVERNAME

2018-09-26 Thread Geert Uytterhoeven
Hi Leonardo, Thanks for your patch series! On Wed, Sep 26, 2018 at 3:51 AM Leonardo Brás wrote: > This Patchset changes some driver's Makefile to allow them building > using the command 'make drivers/DRIVERNAME', if compatible. Please note that running "make drivers/DRIVERNAME" assumes that you

Re: [PATCH v4 03/21] tpm: factor out tpm 1.x duration calculation to tpm1-cmd.c

2018-09-26 Thread Nayna Jain
On 09/21/2018 07:28 PM, Tomas Winkler wrote: Factor out TPM 1.x commands calculation into tpm1-cmd.c file. and change the prefix from tpm_ to tpm1_. No functional change is done here. Signed-off-by: Tomas Winkler Tested-by: Jarkko Sakkinen --- V2-V3: Rebase V4: 1. Remove the licence stateme

[PATCH] staging: rtl8723bs: Mark ACPI table declaration as maybe unused

2018-09-26 Thread Nathan Chancellor
Clang emits the following warning: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:25:36: warning: variable 'acpi_ids' is not needed and will not be emitted [-Wunneeded-internal-declaration] static const struct acpi_device_id acpi_ids[] = { ^ 1 warning generated. M

<    4   5   6   7   8   9