[PATCH 1/9] w1: add SPDX identifiers

2018-10-28 Thread Steffen Vogel
This satisfies a checkpatch warning and is the preferred method for notating the license. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. Signed-off-by: Steffen Vogel --- drivers/w1/masters/ds1wm.c | 5 + drivers/w1/masters/d

[PATCH 2/9] w1: improve coding style by following strict 80 column line limit

2018-10-28 Thread Steffen Vogel
This satisfies a checkpatch warning Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 56 + drivers/w1/w1_int.c | 3 ++- drivers/w1/w1_io.c | 29 +++-- drivers/w1/w1_netlink.c | 16 +- 4 files chan

w1: coding style and checkpatch fixes

2018-10-28 Thread Steffen Vogel
Hi, This is my first series of patches for the Linux kernel. I started by familiarizing myself with coding style and satisfying my inner OCD by cleaning the 1-wire subsystem. Steffen

[PATCH 6/9] w1: do not log errors about failed memory allocations

2018-10-28 Thread Steffen Vogel
This fixes a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 7 +-- drivers/w1/w1_int.c | 6 +- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index bad2ee26cd4e..e8ce97e066ec 100644 --- a/dr

[PATCH 3/9] w1: add newlines after declarations

2018-10-28 Thread Steffen Vogel
This satisfies a checkpatch warning Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 23 +++ drivers/w1/w1_netlink.c | 7 +++ 2 files changed, 30 insertions(+) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index bd95dfe4041d..812186ce35d6 100644 --- a/drivers

Re: [PATCH 2/3] i2c: uniphier-f: fix occasional timeout error

2018-10-28 Thread Wolfram Sang
On Tue, Oct 16, 2018 at 12:01:48PM +0900, Masahiro Yamada wrote: > Currently, a timeout error could happen at a repeated START condition. > > For a (non-repeated) START condition, the controller starts sending > data when the UNIPHIER_FI2C_CR_STA bit is set. However, for a repeated > START conditi

Re: [PATCH 3/3] i2c: uniphier-f: fix race condition when IRQ is cleared

2018-10-28 Thread Wolfram Sang
On Tue, Oct 16, 2018 at 12:01:49PM +0900, Masahiro Yamada wrote: > The current IRQ handler clears all the IRQ status bits when it bails > out. This is dangerous because it might clear away the status bits > that have just been set while processing the current handler. If this > happens, the IRQ eve

Re: [PATCH 1/3] i2c: uniphier-f: make driver robust against concurrency

2018-10-28 Thread Wolfram Sang
On Tue, Oct 16, 2018 at 12:01:47PM +0900, Masahiro Yamada wrote: > This is unlikely to happen, but it is possible for a CPU to enter > the interrupt handler just after wait_for_completion_timeout() has > expired. If this happens, the hardware is accessed from multiple > contexts concurrently. > >

CONTACT HIM NOW

2018-10-28 Thread Mr. Larry Johnson
Attn: My Dear I am glad to inform you that i have successfully concluded the transaction which i seek for your family help before, Now the fund has been transferred to Hong Kong through the assistant of Mr.Wong Lee, who is a business man base in Hong Kong.Once again, I have mapped out a compensati

Re: [Ksummit-discuss] Call to Action Re: [PATCH 0/7] Code of Conduct: Fix some wording, and add an interpretation document

2018-10-28 Thread NeilBrown
On Sat, Oct 27 2018, Josh Triplett wrote: > On Fri, Oct 26, 2018 at 08:14:51AM +1100, NeilBrown wrote: >> On Wed, Oct 24 2018, Josh Triplett wrote: >> >> > On Tue, Oct 23, 2018 at 07:26:06AM +1100, NeilBrown wrote: >> >> On Sun, Oct 21 2018, Josh Triplett wrote: >> >> >> >> > On Mon, Oct 22, 201

Re: [PATCH 1/2] mm: thp: relax __GFP_THISNODE for MADV_HUGEPAGE mappings

2018-10-28 Thread David Rientjes
On Mon, 22 Oct 2018, Zi Yan wrote: > Hi David, > Hi! > On 22 Oct 2018, at 17:04, David Rientjes wrote: > > > On Tue, 16 Oct 2018, Mel Gorman wrote: > > > > > I consider this to be an unfortunate outcome. On the one hand, we have a > > > problem that three people can trivially reproduce with k

[PATCH] ubifs: Handle re-linking of inodes correctly while recovery

2018-10-28 Thread Richard Weinberger
UBIFS's recovery code strictly assumes that a deleted inode will never come back, therefore it removes all data which belongs to that inode as soon it faces an inode with link count 0 in the replay list. Before O_TMPFILE this assumption was perfectly fine. With O_TMPFILE it can lead to data loss up

Re: [Ksummit-discuss] The linux devs can rescind their license grant.

2018-10-28 Thread NeilBrown
On Sun, Oct 28 2018, Jiri Kosina wrote: > On Sat, 27 Oct 2018, tim.b...@sony.com wrote: > >> Al, >> >> Can you please, even in the face of comments you find irritating, keep >> your responses more civil? Calling someone a "wankstain" is >> unprofessional > > Tim, > > to be completely honest, co

Re: [PATCH RFC 18/18] staging: vchiq: add more tasks to the TODO list

2018-10-28 Thread Stefan Wahren
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > The more the better. Please try to find a better commit log ;-) > > Signed-off-by: Nicolas Saenz Julienne > --- > .../staging/vc04_services/interface/vchi/TODO | 46 ++- > 1 file changed, 44 in

Re: [GIT PULL] C-SKY(csky) Port for Linux 4.20

2018-10-28 Thread Linus Torvalds
Arnd, I was kind of hoping/expecting to get an explicit ack for this from you, since it's a new architecture. Good to merge? Linus On Fri, Oct 26, 2018 at 9:08 PM Guo Ren wrote: > > This tag contains the Linux port for C-SKY(csky) based on linux-4.19 > Release, which has been thr

Re: [PATCH 11/11] perf tools: Stop fallbacking to kallsyms for vdso symbols lookup

2018-10-28 Thread Jiri Olsa
On Sat, Oct 27, 2018 at 01:09:44PM -0700, Vinicius Costa Gomes wrote: > Hi Jirka, > > Jiri Olsa writes: > > > On Fri, Oct 26, 2018 at 04:19:52PM -0700, Vinicius Costa Gomes wrote: > >> Hi, > >> > >> Adrian Hunter writes: > >> > >> > On 18/10/18 1:55 AM, Arnaldo Carvalho de Melo wrote: > >> >>

Re: Logitech high-resolution scrolling..

2018-10-28 Thread Linus Torvalds
On Sun, Oct 28, 2018 at 12:13 PM Linus Torvalds wrote: > > So the recent change to enable the high-res scrolling really seems a > bit *too* extreme. > > Is there some middle ground that turns the mouse from "look at it > sideways and it starts scrolling" to something slightly more > reasonable? A

Loan Offer

2018-10-28 Thread Global Financial Ltd
We offer all types of loans at 2% interest rate contact us at gylesloan...@gmail.com --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: [PATCH RFC 16/18] staging: vchiq_arm: rework probe and init functions

2018-10-28 Thread Stefan Wahren
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > Some operations performed in the probe function should have been > implemented in the init function. Namely class and dev region creations. > Please explain the why in the commit log

Re: Your Loan Firm

2018-10-28 Thread EMRAH GLOBAL LOAN FIRM
Are you searching for a Genuine Loan? At an affordable interest rate? Get back to us with your Name and Phone Number Best Regards, Emrah Global Loan

Re: [PATCH RFC 11/18] staging: vchiq_arm: use completions instead of semaphores

2018-10-28 Thread Stefan Wahren
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > It is preferred in the kernel to avoid using semaphores to wait for > events, as they are optimised for the opposite situation; where the > common case is that they are available and may block only occasionally. > FY

Re: [PATCH RFC 15/18] stagning: vchiq_core: fix logic redundancy in parse_open

2018-10-28 Thread Stefan Wahren
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > We update sync to reflect that the firmware version is compatible with > that option. We don't need to check both of them again further down the > code. please fix the typo in the subject s/stagning/staging/ for thi

Re: [PATCH v6 3/3] staging: iio: ad2s1210: Add device tree support.

2018-10-28 Thread Nishad Kamdar
On Sun, Oct 28, 2018 at 02:51:08PM +, Jonathan Cameron wrote: > On Sun, 28 Oct 2018 13:23:23 +0530 > Nishad Kamdar wrote: > > > Replace platform data with device tree support. > > > > Signed-off-by: Nishad Kamdar > The whole gpio in or out thing makes less and less sense to > me and seems t

Loan Offer

2018-10-28 Thread Global Financial Ltd
We offer all types of loans at 2% interest rate contact us at gylesloan...@gmail.com --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: [PATCH RFC 09/18] staging: vchiq_core: do not initialize semaphores twice

2018-10-28 Thread Stefan Wahren
Hi Nicolas, > Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > vchiq_init_state() initialises a series of semaphores to then call > remote_event_create() on the same semaphores, which initializes them > again. i would prefer to have all init stuff at one place in v

Re: [PATCH v6 1/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-10-28 Thread Nishad Kamdar
On Sun, Oct 28, 2018 at 02:36:07PM +, Jonathan Cameron wrote: > On Sun, 28 Oct 2018 13:21:25 +0530 > Nishad Kamdar wrote: > > > Use the gpiod interface instead of the deprecated old non-descriptor > > interface. > > > > Signed-off-by: Nishad Kamdar > Hi Nishad, > > Sorry it took me most of

RTL8812au driver source code A little help please?

2018-10-28 Thread Nathaniel Russell
make[1]: Entering directory '/usr/src/linux-4.19' CC [M] /tmp/rtl8812AU_8821AU_linux/os_dep/linux/os_intfs.o /tmp/rtl8812AU_8821AU_linux/os_dep/linux/os_intfs.c:816:22: error: initialization of ‘u16 (*)(struct net_device *, struct sk_buff *, struct net_device *, u16 (*)(struct net_device *, stru

Re: [GIT PULL] Kbuild updates for v4.20

2018-10-28 Thread Linus Torvalds
On Sun, Oct 28, 2018 at 10:12 AM Masahiro Yamada wrote: > > Please pull Kbuild updates for v4.20 Pulled, Linus

Re: drivers by default (was Re: Another HID problem this merge window..)

2018-10-28 Thread Linus Torvalds
On Sun, Oct 28, 2018 at 4:16 AM Adam Borowski wrote: > > Amen to that. But, perhaps you could encourage people to do enable drivers > once they become very popular? For example, I just (72a9c673636) got hit by > USB 3.0 being off in defconfigs, and not having keyboard is not that cool. Yes, tha

Re: [GIT PULL] kselftest update for Linux 4.20-rc1

2018-10-28 Thread Linus Torvalds
On Thu, Oct 25, 2018 at 11:36 AM Shuah Khan wrote: > > Please pull the following kselftest update for Linux 4.20-rc1 Pulled, Linus

Re: Which SPDX Identifier for files without explicit GPL version

2018-10-28 Thread Michael Straube
On 10/28/18 3:13 PM, Greg Kroah-Hartman wrote: On Sun, Oct 28, 2018 at 02:22:40PM +0100, Michael Straube wrote: On 10/28/18 12:27 PM, Greg Kroah-Hartman wrote: On Sun, Oct 28, 2018 at 11:04:06AM +0100, Michael Straube wrote: Hi, which GPL version should be used in SPDX Identifiers for files t

Re: [GIT PULL] XArray for 4.20

2018-10-28 Thread Matthew Wilcox
On Sun, Oct 28, 2018 at 12:21:19PM -0700, Linus Torvalds wrote: > On Sun, Oct 28, 2018 at 12:13 PM Matthew Wilcox wrote: > > > > On Sun, Oct 28, 2018 at 11:50:19AM -0700, Linus Torvalds wrote: > > > > > NOTE! I did get some conflicts with other stuff, and while the > > > conflict resolution all lo

Re: [GIT PULL] XArray for 4.20

2018-10-28 Thread Linus Torvalds
On Sun, Oct 28, 2018 at 12:13 PM Matthew Wilcox wrote: > > On Sun, Oct 28, 2018 at 11:50:19AM -0700, Linus Torvalds wrote: > > > NOTE! I did get some conflicts with other stuff, and while the > > conflict resolution all looked pretty straightforward, this does want > > looking at. > > > > Particul

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-28 Thread Jerome Brunet
On Thu, 2018-10-25 at 22:58 +0200, Martin Blumenstingl wrote: > Hi Jerome, > > On Thu, Oct 25, 2018 at 2:54 PM Jerome Brunet wrote: > [snip] > > > > > +static void clk_regmap_div_init(struct clk_hw *hw) > > > > > +{ > > > > > + struct clk_regmap *clk = to_clk_regmap(hw); > > > > > + struct clk_re

Re: [PATCH 0/2] tracing: Fix synthetic event parser

2018-10-28 Thread Steven Rostedt
On Sun, 28 Oct 2018 12:10:17 -0600 Shuah Khan wrote: > Here it is > > Acked-by: Shuah Khan > Thanks a lot Shuah! -- Steve

Logitech high-resolution scrolling..

2018-10-28 Thread Linus Torvalds
So I use a Logitech MX Anywhere 2S mouse, and really like it. I have the scroll-wheel unlocked, because I like flicking once to scroll a lot. However, the new high-res scroll code means that the scroll wheel action is now much too sensitive. It's not even stable - it will scroll back-and-forth a b

Re: [GIT PULL] XArray for 4.20

2018-10-28 Thread Matthew Wilcox
On Sun, Oct 28, 2018 at 11:50:19AM -0700, Linus Torvalds wrote: > On Tue, Oct 23, 2018 at 1:08 PM Matthew Wilcox wrote: > < > > Please consider pulling the XArray patch set. > > Pulled. Thanks! > I took the more recent version of yours, because by the time I > actually had time to review this t

Re: [regression, bisected] Keyboard not responding after resuming from suspend/hibernate

2018-10-28 Thread Numan Demirdöğen
Thu, 25 Oct 2018 09:49:03 +0200 tarihinde Pavel Machek yazdı: > Hi! > > Here's problem bisected down to: > > commit 9d659ae14b545c4296e812c70493bfdc999b5c1c > Author: Peter Zijlstra > Date: Tue Aug 23 14:40:16 2016 +0200 > > locking/mutex: Add lock handoff to avoid starvation > > I

Re: [PATCH v2 1/2] staging: iio: ad7780: update voltage on read

2018-10-28 Thread Jonathan Cameron
On Sun, 28 Oct 2018 13:52:32 -0300 Renato Lui Geh wrote: > Hi Jonathan, > > Thank you for the review. > > >> + voltage_uv = regulator_get_voltage(st->reg); > >> + if (voltage_uv) > >> + st->int_vref_mv = voltage_uv/1000; > >>*val = st->int_vref_mv

Re: i.MX6 MIPI-CSI2 OV5640 Camera testing on Mainline Linux

2018-10-28 Thread Adam Ford
On Wed, Oct 24, 2018 at 9:17 AM Adam Ford wrote: > > On Wed, Oct 24, 2018 at 9:08 AM jacopo mondi wrote: > > > > Hi Adam, > > > > On Wed, Oct 24, 2018 at 08:53:41AM -0500, Adam Ford wrote: > > > On Tue, Oct 23, 2018 at 6:03 PM jacopo mondi wrote: > > > > > > > > Hi Adam, > > > > > > > > On Tue,

Re: [GIT PULL] XArray for 4.20

2018-10-28 Thread Linus Torvalds
On Tue, Oct 23, 2018 at 1:08 PM Matthew Wilcox wrote: < > Please consider pulling the XArray patch set. Pulled. I took the more recent version of yours, because by the time I actually had time to review this thing for pulling, even the recent version had been in linux-next for a week. Of course

Re: [PATCH 2/2] iio: pressure: Add support for Honeywell HSC SPI sensors

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 18:14:37 + Carlos Iglesias wrote: > Add device driver for the HSC pressure sensors with SPI interface. > In addition to the main measurement -pressure- these sensors also > provide temperature measurement. > > Signed-off-by: Carlos Iglesias Hi Carlos, A few minor thing

Re: [PATCH 0/2] tracing: Fix synthetic event parser

2018-10-28 Thread Shuah Khan
On 10/28/2018 02:09 AM, Steven Rostedt wrote: > On Sun, 28 Oct 2018 04:01:35 -0400 > Steven Rostedt wrote: > >> I'll add them on top of my linux-next code, and include them in the >> pull request I'm hoping to do on Tuesday. > > Bah, I think this is on a different branch, and that will make it g

Re: [PATCH v3 1/4] x86/mm: declare check_la57_support() as inline

2018-10-28 Thread Steven Rostedt
On Sun, 28 Oct 2018 13:09:42 + Changbin Du wrote: > The level4_kernel_pgt is only defined when X86_5LEVEL is enabled. > So declare check_la57_support() as inline to make sure the code > referring to level4_kernel_pgt is optimized out. This is a preparation > for CONFIG_CC_OPTIMIZE_FOR_DEBUGGI

Re: [PATCH 0/2] tracing: Fix synthetic event parser

2018-10-28 Thread Steven Rostedt
On Sun, 28 Oct 2018 11:33:35 -0600 Shuah Khan wrote: > Hi Steve, > > Are there any dependencies on my pull request I sent to Linus? It hasn't > been pulled in yet. If there is one, could please you mention that in your > pull request for this. There's no dependency on the patches you took. But

Re: [GIT PULL] Qualcomm ARM64 DT updates for 4.20

2018-10-28 Thread Amit Kucheria
On Thu, Oct 25, 2018 at 9:38 PM Andy Gross wrote: > > On Thu, Oct 25, 2018 at 10:55:32AM +0530, Amit Kucheria wrote: > > > > > Andy, > > > > While you acked the tsens thermal DT patches[1] so they could go > > through the thermal tree[2] to avoid a dependency, Eduardo would > > prefer the DT chan

XFS: Hang and dmesg flood on mounting invalid FS image

2018-10-28 Thread Anatoly Trosinenko
Hello, When mounting a broken XFS image, the kernel hangs and floods dmesg with stack traces. How to reproduce with kvm-xfstests: 1) Checkout v4.19, copy x86_64-config-4.14 to .config, `make olddefconfig` and compile 2) Unpack the attached image (128 Mb uncompressed) to /tmp/kvm-xfstests-$USER 3)

Re: [PATCH 1/2] dt-bindings: iio: pressure: Add support for Honeywell HSC SPI sensors

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 18:14:36 + Carlos Iglesias wrote: > Add device tree bindings for the HSC pressure sensors. > > Signed-off-by: Carlos Iglesias > --- > .../bindings/iio/pressure/hsc_spi.txt | 85 +++ > 1 file changed, 85 insertions(+) > create mode 100644 Documen

Re: [PATCH] fpga: altera_cvp: restrict registration to CvP enabled devices

2018-10-28 Thread Moritz Fischer
Hi Andreas, On Thu, Oct 25, 2018 at 08:44:06AM +, Andreas Puhm wrote: > >My experience with cvp is with Arria10 and Stratix 10. The PCIe Hard IP > >gets configured when the IOring gets configured at power on. The idea is > >that the load of the IOring is very fast, much before the infamous

Re: [PATCH 0/2] tracing: Fix synthetic event parser

2018-10-28 Thread Shuah Khan
On 10/28/2018 02:01 AM, Steven Rostedt wrote: > On Mon, 22 Oct 2018 00:07:50 +0900 > Masami Hiramatsu wrote: > >> Hi, >> >> I found another bug in synthetic event. This is a small fix, but >> confusingly, there is also a bug in a test case. >> >> Steve, since the testcase bugfix ([2/2]) breaks th

Re: [RFC] rcu: doc: update example about stale data

2018-10-28 Thread Paul E. McKenney
On Sat, Oct 27, 2018 at 09:44:31PM -0700, Joel Fernandes wrote: > On Sat, Oct 27, 2018 at 7:16 PM, Joel Fernandes (Google) > wrote: > > The RCU example for 'rejecting stale data' on system-call auditting > > stops iterating through the rules if a deleted one is found. It makes > > more sense to co

Re: [RFC] rcu: doc: update example about stale data

2018-10-28 Thread Paul E. McKenney
On Sat, Oct 27, 2018 at 07:16:53PM -0700, Joel Fernandes (Google) wrote: > The RCU example for 'rejecting stale data' on system-call auditting > stops iterating through the rules if a deleted one is found. It makes > more sense to continue looking at other rules once a deleted one is > rejected. Al

Good Day

2018-10-28 Thread Maria Dunga
Can we meet in person to discuss?

[GIT PULL] Kbuild updates for v4.20

2018-10-28 Thread Masahiro Yamada
Hi Linus, Please pull Kbuild updates for v4.20 Thanks! The following changes since commit 11da3a7f84f19c26da6f86af878298694ede0804: Linux 4.19-rc3 (2018-09-09 17:26:43 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git

Build regressions/improvements in v4.19

2018-10-28 Thread Geert Uytterhoeven
Below is the list of build error/warning regressions/improvements in v4.19[1] compared to v4.18[2]. Summarized: - build errors: +5/-3 - build warnings: +14715/-247 JFYI, when comparing v4.19[1] to v4.19-rc8[3], the summaries are: - build errors: +0/-0 - build warnings: +158/-166 Note tha

Re: [PATCH v2 01/17] compat_ioctl: add generic_compat_ioctl_ptrarg()

2018-10-28 Thread Al Viro
On Thu, Sep 13, 2018 at 12:29:02PM +0200, Arnd Bergmann wrote: > I was hoping that the _ptrarg suffix gives enough warning here, > but maybe not. I was careful to only use it in cases that I > checked are safe, either using only pointer arguments, or > no arguments. > > What we might do for furth

Re: [PATCH 1/4] Adds -Wshadow=local on KBUILD_HOSTCFLAGS

2018-10-28 Thread Masahiro Yamada
On Fri, Oct 19, 2018 at 8:28 PM David Laight wrote: > > From: Masahiro Yamada > > Sent: 18 October 2018 17:39 > > > > On Thu, Oct 18, 2018 at 6:18 PM Borislav Petkov wrote: > > > > > > On Wed, Oct 17, 2018 at 09:40:53PM -0300, Leonardo Bras wrote: > > > > The idea was to put it as default and fix

Re: [PATCH v2 1/2] staging: iio: ad7780: update voltage on read

2018-10-28 Thread Renato Lui Geh
Hi Jonathan, Thank you for the review. + voltage_uv = regulator_get_voltage(st->reg); + if (voltage_uv) + st->int_vref_mv = voltage_uv/1000; *val = st->int_vref_mv * st->gain; Is there actually a reason (now) to have the stashed

Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 22:59:59 -0300 Matheus Tavares wrote: > This patch set adds scale info to ad2s90's single channel, improve > error handling in it's functions and fix a possible race condition > issue. > > The goal with this patch set is to address the points discussed in the > mailing list i

Re: [PATCH v2 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 23:00:04 -0300 Matheus Tavares wrote: > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and > implements the relative read behavior at ad2s90_read_raw. > > Signed-off-by: Victor Colombo > Signed-off-by: Matheus Tavares Hi, A suggestion inline. This is a commo

[PATCH] Malformatted switch statment

2018-10-28 Thread Joris Gutjahr
I fixed this coding style error I got after running checkpatch --file on this file. The problem was that the whole case block was on one line. Signed-off-by: Joris Gutjahr --- drivers/ide/amd74xx.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/ide/amd74

Re: [PATCH v3 4/5] modpost: Changes parameter name to avoid shadowing.

2018-10-28 Thread Masahiro Yamada
On Wed, Oct 24, 2018 at 1:05 PM Leonardo Bras wrote: > > Changes the parameter name to avoid shadowing a variable. > > Signed-off-by: Leonardo Bras For this one, I'd rather like to see code refactoring than renaming the variable. I will take a closer look. > --- > scripts/mod/modpost.c |

Re: [PATCH v2 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 23:00:01 -0300 Matheus Tavares wrote: > Previously, ad2s90_probe ignored the return code from spi_setup, not > handling its possible failure. This patch makes ad2s90_probe check if > the code is an error code and, if so, do the following: > > - Call dev_err with an appropriat

Re: [PATCH v2 1/6] staging:iio:ad2s90: Make read_raw return spi_read's error code

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 23:00:00 -0300 Matheus Tavares wrote: > Previously, when spi_read returned an error code inside ad2s90_read_raw, > the code was ignored and IIO_VAL_INT was returned. This patch makes the > function return the error code returned by spi_read when it fails. > > Signed-off-by: M

Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-28 Thread Masahiro Yamada
On Tue, Oct 23, 2018 at 10:11 AM Leonardo Brás wrote: > > Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD > macro, allowing usage of a variable name other than the struct element name. > Also, sets DEF_FIELD_ADDR as a specific usage of DEF_FILD_ADDR_VAR in which > the var

Re: [PATCH v3 2/5] kbuild: Removes unnecessary shadowed local variable.

2018-10-28 Thread Masahiro Yamada
On Wed, Oct 24, 2018 at 1:04 PM Leonardo Bras wrote: > > Removes an unnecessary shadowed local variable (start). > It was used only once, with the same value it was started before > the if block. > > Signed-off-by: Leonardo Bras Applied to linux-kbuild with some fixups in the subject. Please

Re: [PATCH v3 1/5] x86/vdso: Renames variable to fix shadow warning.

2018-10-28 Thread Masahiro Yamada
Hi Ingo, On Wed, Oct 24, 2018 at 1:04 PM Leonardo Bras wrote: > > The go32() and go64() functions have an argument and a local variable > called ‘name’. Rename both to clarify the code and to fix a warning > with -Wshadow. > > Signed-off-by: Leonardo Bras Please take care of this in x86 tree

Re: linux-next: Signed-off-by missing for commit in the c6x tree

2018-10-28 Thread Mark Salter
On Sun, 2018-10-28 at 15:53 +1100, Stephen Rothwell wrote: > Hi Mark, > > Commit > > fe381767b94f ("c6x: switch to NO_BOOTMEM") > > is missing a Signed-off-by from its committer. > Oops, fixed.

[PATCH] regulator: bd718x7: Remove double indirection for bd718xx_pmic_inits.rdatas

2018-10-28 Thread Geert Uytterhoeven
With gcc 4.1: drivers/regulator/bd718x7-regulator.c: In function ‘bd718xx_probe’: drivers/regulator/bd718x7-regulator.c:1020: warning: initialization from incompatible pointer type drivers/regulator/bd718x7-regulator.c:1024: warning: initialization from incompatible pointer type App

Re: [PATCH v2] pstore: Avoid duplicate call of persistent_ram_zap()

2018-10-28 Thread Kees Cook
On Sat, Oct 27, 2018 at 2:08 PM, Peng15 Wang 王鹏 wrote: > When initialing prz with invalid data in buffer(no PERSISTENT_RAM_SIG), > function call path is like this: > > ramoops_init_prz -> > | > |-> persistent_ram_new -> persistent_ram_post_init -> persistent_ram_zap > | > |-> persistent_ram_zap >

Re: [PATCH v2 2/2] staging: iio: ad7780: fix offset read value

2018-10-28 Thread Jonathan Cameron
On Thu, 25 Oct 2018 19:30:37 -0300 Renato Lui Geh wrote: > Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET. > This was fixed by assigning the correct value instead. > > Signed-off-by: Renato Lui Geh It obviously doesn't make much difference, but as you are respinning any

Re: [PATCH v2 1/2] staging: iio: ad7780: update voltage on read

2018-10-28 Thread Jonathan Cameron
On Thu, 25 Oct 2018 19:30:04 -0300 Renato Lui Geh wrote: > The ad7780 driver previously did not read the correct device output, as > it read an outdated value set at initialization. It now updates its > voltage on read. > > Signed-off-by: Renato Lui Geh > --- > drivers/staging/iio/adc/ad7780.c

Re: [PATCH] pstore: Remove duplicate invoking of persistent_ram_zap()

2018-10-28 Thread Kees Cook
On Sat, Oct 27, 2018 at 9:52 AM, Peng15 Wang 王鹏 wrote: > > > >>From: Kees Cook >>Sent: Friday, October 26, 2018 17:44 >>To: Peng15 Wang 王鹏 >>Cc: an...@enomsg.org; ccr...@android.com; tony.l...@intel.com; >>linux-kernel@vger.kernel.org >>Subject: Re: [PATC

Re: [PATCH v5 04/11] dt-bindings: iio: adc: add AXP803 ADC bindings

2018-10-28 Thread Jonathan Cameron
On Wed, 24 Oct 2018 08:56:33 -0500 Rob Herring wrote: > On Tue, 23 Oct 2018 21:53:23 +0300, Oskari Lemmela wrote: > > The AXP803 ADC is compatible with AXP813 ADC, but add > > specific compatible for it. > > > > Signed-off-by: Oskari Lemmela > > --- > > Documentation/devicetree/bindings/iio/ad

Re: [PATCH v3 1/3] iio: adc128s052: Add pin-compatible IDs

2018-10-28 Thread Jonathan Cameron
On Thu, 25 Oct 2018 16:35:40 +0100 Dan O'Donovan wrote: > From: Javier Arteaga > > The datasheets for ADC122S021 and ADC124S021 list two more > pin-compatible alternatives for each device. > > Add their IDs as compatible strings. > > Suggested-by: Jonathan Cameron > Signed-off-by: Javier Art

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-28 Thread Jianxin Pan
Hi Jerome, On 2018/10/25 20:54, Jerome Brunet wrote: > On Thu, 2018-10-25 at 19:48 +0800, Jianxin Pan wrote: >> Hi Jerome, >> >> On 2018/10/24 17:01, Jerome Brunet wrote: >>> On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: From: Yixun Lan The patch will add a MMC clock contro

Re: [PATCH] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD

2018-10-28 Thread Hans de Goede
Hi, On 28-10-18 15:34, Diego Viola wrote: med_power_with_dipm still causes freezes after updating the firmware to the latest version (DXT04L5Q). Set model_rev to NULL and blacklist the device. Signed-off-by: Diego Viola Thank you for the patch. Reviewed-by: Hans de Goede Regards, Hans

Re: [PATCH 2/2] staging: iio: ad5933: Remove unnecessary blank line

2018-10-28 Thread Jonathan Cameron
On Mon, 22 Oct 2018 17:41:27 -0300 Victor Colombo wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: Blank lines aren't necessary before a close brace '}' > > Signed-off-by: Victor Colombo Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to

Hello

2018-10-28 Thread Mr Fawaz Al Saleh
Please can you contact me for a transaction.

Re: [PATCH 1/2] staging: iio: ad5933: Remove unnecessary space on casting

2018-10-28 Thread Jonathan Cameron
On Mon, 22 Oct 2018 17:40:25 -0300 Victor Colombo wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: No space is necessary after a cast > > Signed-off-by: Victor Colombo Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it and se

Re: [PATCH v5 2/2] staging: iio: ad2s1210: Add device tree support.

2018-10-28 Thread Jonathan Cameron
On Sat, 27 Oct 2018 17:49:03 +0200 Slawomir Stepien wrote: > Hi > > On paź 26, 2018 18:55, Nishad Kamdar wrote: > > Add device tree table for matching vendor ID > > and support for retrieving platform data > > from device tree. > > So maybe you should make 2 commits? > > > Signed-off-by: Nis

Re: [PATCH v6 3/3] staging: iio: ad2s1210: Add device tree support.

2018-10-28 Thread Jonathan Cameron
On Sun, 28 Oct 2018 13:23:23 +0530 Nishad Kamdar wrote: > Replace platform data with device tree support. > > Signed-off-by: Nishad Kamdar The whole gpio in or out thing makes less and less sense to me and seems to contradict the datasheet. If I'm not missing something I would just get rid of

Re: [PATCH v6 1/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-10-28 Thread Jonathan Cameron
On Sun, 28 Oct 2018 13:21:25 +0530 Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface. > > Signed-off-by: Nishad Kamdar Hi Nishad, Sorry it took me most of the week to get to this. It's a trade off when you want to make fast progress, but I

[PATCH] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD

2018-10-28 Thread Diego Viola
med_power_with_dipm still causes freezes after updating the firmware to the latest version (DXT04L5Q). Set model_rev to NULL and blacklist the device. Signed-off-by: Diego Viola --- drivers/ata/libata-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/libata-

Re: [PATCH v3 3/5] nfc: pn533: add UART phy driver

2018-10-28 Thread Johan Hovold
On Sun, Oct 28, 2018 at 02:46:24PM +0100, Marcel Holtmann wrote: > >> +#define VERSION "0.1" > > > > We don't version kernel drivers individually, so please drop this here > > and below. > > if we don’t then maybe send patches to remove MODULE_VERSION first. > Otherwise this is totally fine to d

Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay

2018-10-28 Thread Mike Brady
> On 25 Oct 2018, at 08:37, Takashi Iwai wrote: > > On Thu, 25 Oct 2018 00:02:34 +0200, > Kirill Marinushkin wrote: >> When you play sound - the pointer increments. >>> >>> Unfortunately, when you play sound, the pointer does not actually >>> increment, for up to about 10 milliseconds.

Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay

2018-10-28 Thread Mike Brady
Hi Kirill. Thanks for the post. Mike > On 25 Oct 2018, at 18:20, Kirill Marinushkin wrote: > > Hello Takashi, Mike, > > @Takashi > > On 10/25/18 09:37, Takashi Iwai wrote: >> Well, in the API POV, it's nothing wrong to keep hwptr sticking while >> updating only delay value. It implies that th

Re: Which SPDX Identifier for files without explicit GPL version

2018-10-28 Thread Greg Kroah-Hartman
On Sun, Oct 28, 2018 at 02:22:40PM +0100, Michael Straube wrote: > On 10/28/18 12:27 PM, Greg Kroah-Hartman wrote: > > On Sun, Oct 28, 2018 at 11:04:06AM +0100, Michael Straube wrote: > > > Hi, > > > > > > which GPL version should be used in SPDX Identifiers for files that > > > are GPL licensed b

[git pull] m68k updates for 4.20

2018-10-28 Thread Geert Uytterhoeven
Hi Linus, The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git tags/m68k-for-v4.20-tag1 for you to fetch ch

Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver

2018-10-28 Thread Marc Zyngier
Hi Lokesh, On Fri, 26 Oct 2018 21:19:41 +0100, Lokesh Vutla wrote: > > Hi Marc, > > [..snip..] > >> [...] > >> > > +/** > > + * ti_sci_inta_register_event() - Register a event to an interrupt > > aggregator > > + * @dev: Device pointer to source generating the event > >>

Re: Which SPDX Identifier for files without explicit GPL version

2018-10-28 Thread Michael Straube
On 10/28/18 12:27 PM, Greg Kroah-Hartman wrote: On Sun, Oct 28, 2018 at 11:04:06AM +0100, Michael Straube wrote: Hi, which GPL version should be used in SPDX Identifiers for files that are GPL licensed but do not mention any version? It is not clear to me after reading license-rules.rst. For e

Re: [PATCH v2 4/4] kernel hacking: new config CC_OPTIMIZE_FOR_DEBUGGING to apply GCC -Og optimization

2018-10-28 Thread Changbin Du
On Sun, Oct 28, 2018 at 10:09:21PM +0900, Masahiro Yamada wrote: > Hi Changbin, > > On Sun, Oct 28, 2018 at 9:52 PM Changbin Du wrote: > > > > > > Thanks for pointing this out and kind suggestions. I have tested with your > > modification. Will update patch serias soon. > > > I have one more r

Re: [PATCH v2 2/4] kernel hacking: new config NO_AUTO_INLINE to disable compiler auto-inline optimizations

2018-10-28 Thread Masahiro Yamada
On Fri, Oct 19, 2018 at 9:50 PM Du Changbin wrote: > > This patch add a new kernel hacking option NO_AUTO_INLINE. Selecting > this option will prevent the compiler from optimizing the kernel by > auto-inlining functions not marked with the inline keyword. > > With this option, only functions expli

[PATCH] arch: x86: Touched up patterns of 'sizeof' functions

2018-10-28 Thread Jordan Borgner
Addded missing parentheses to 'sizeof()' functions in arch/x86/. Like this: Before: 'sizeof x' After: 'sizeof(x)' Done by motivation of Ingo Molnar. Signed-off-by: Jordan Borgner --- linux-4.19/arch/x86/boot/cpucheck.c | 2 +- linux-4.19/arch/x86/boot/early_serial_console.c | 4

Re: [PATCH v2 4/4] kernel hacking: new config CC_OPTIMIZE_FOR_DEBUGGING to apply GCC -Og optimization

2018-10-28 Thread Masahiro Yamada
Hi Changbin, On Sun, Oct 28, 2018 at 9:52 PM Changbin Du wrote: > > > Thanks for pointing this out and kind suggestions. I have tested with your > modification. Will update patch serias soon. I have one more request. The patch subject "kernel hacking: new config CC_OPTIMIZE_FOR_DEBUGGING to a

[PATCH v3 4/4] kernel hacking: new config CC_OPTIMIZE_FOR_DEBUGGING to apply GCC -Og optimization

2018-10-28 Thread Changbin Du
This will apply GCC '-Og' optimization level which is supported since GCC 4.8. This optimization level offers a reasonable level of optimization while maintaining fast compilation and a good debugging experience. It is similar to '-O1' while perferring to keep debug ability over runtime speed. If

[PATCH v3 0/4] kernel hacking: GCC optimization for better debug experience (-Og)

2018-10-28 Thread Changbin Du
Hi all, I have posted this series several months ago but interrupted by personal affairs. Now I get time to complete this task. Thanks for all of the reviewers. I know some kernel developers was searching for a method to dissable GCC optimizations, probably they want to apply GCC '-O0' option. But

[PATCH v3 1/4] x86/mm: declare check_la57_support() as inline

2018-10-28 Thread Changbin Du
The level4_kernel_pgt is only defined when X86_5LEVEL is enabled. So declare check_la57_support() as inline to make sure the code referring to level4_kernel_pgt is optimized out. This is a preparation for CONFIG_CC_OPTIMIZE_FOR_DEBUGGING. Signed-off-by: Changbin Du Cc: Steven Rostedt (VMware) Cc

[PATCH v3 2/4] kernel hacking: new config NO_AUTO_INLINE to disable compiler auto-inline optimizations

2018-10-28 Thread Changbin Du
This patch add a new kernel hacking option NO_AUTO_INLINE. Selecting this option will prevent the compiler from optimizing the kernel by auto-inlining functions not marked with the inline keyword. With this option, only functions explicitly marked with "inline" will be inlined. This will allow the

[PATCH v3 3/4] ARM: mm: fix build error in fix_to_virt with CONFIG_CC_OPTIMIZE_FOR_DEBUGGING

2018-10-28 Thread Changbin Du
With '-Og' optimization level, GCC would not optimize a count for a loop as a constant value. But BUILD_BUG_ON() only accept compile-time constant values. Let's use __fix_to_virt() to avoid the error. arch/arm/mm/mmu.o: In function `fix_to_virt': /home/changbin/work/linux/./include/asm-generic/fix

<    1   2   3   >