Re: [PATCH] remove old GCC version implementation

2018-10-31 Thread Miguel Ojeda
On Wed, Oct 31, 2018 at 12:18 PM Mathieu Malaterre wrote: > > GCC 4.6 is the minimum supported now. > > Signed-off-by: Mathieu Malaterre > --- > scripts/mod/file2alias.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/scripts/mod/file2alias.c

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-31 Thread Hans de Goede
Hi, On 30-10-18 17:15, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: In addition I am not aware of any baytrail device using plt_clk_0, so moving a common machine driver such a

Re: [PATCH] PCI: imx: Add imx6sx suspend/resume support

2018-10-31 Thread Leonard Crestez
On 10/8/2018 8:38 PM, Leonard Crestez wrote: > Enable PCI suspend/resume support on imx6sx socs. This is similar to > imx7d with a few differences: > > * The PM_Turn_Off bit is exposed through an IOMUX GPR, like all other > pcie control bits on 6sx. > * The pcie_inbound_axi clk needs to be turned

insecure W+X mappings on HP DL365 G5

2018-10-31 Thread Meelis Roos
This HP DL365 G5 is the second old server where I see massive W+X mapped pages. Is it some BIOS defect? [0.714956] x86/mm: Found insecure W+X mapping at address 0x8ed98000 [0.715101] WARNING: CPU: 0 PID: 1 at arch/x86/mm/dump_pagetables.c:266 note_page+0x4c7/0x780 [

[PATCH] remove old GCC version implementation

2018-10-31 Thread Mathieu Malaterre
GCC 4.6 is the minimum supported now. Signed-off-by: Mathieu Malaterre --- scripts/mod/file2alias.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c index 28a61665bb9c..4b59564d4706 100644 --- a/scripts/mod/file2alias.c

Re: [RFC 0/2] RISC-V: A proposal to add vendor-specific code

2018-10-31 Thread Anup Patel
On Wed, Oct 31, 2018 at 4:06 PM Vincent Chen wrote: > > RISC-V permits each vendor to develop respective extension ISA based > on RISC-V standard ISA. This means that these vendor-specific features > may be compatible to their compiler and CPU. Therefore, each vendor may > be considered a

Re: [PATCH v1 00/14] Rockchip SPI cleanup and use interrupts

2018-10-31 Thread Heiko Stübner
Am Mittwoch, 31. Oktober 2018, 11:56:57 CET schrieb Emil Renner Berthing: > Emil Renner Berthing (14): > spi: rockchip: make spi_enable_chip take bool > spi: rockchip: use designated init for dma config > spi: rockchip: always use SPI mode > spi: rockchip: use atomic_t state > spi:

Re: [PATCH v13 08/12] KVM: x86: Add Intel PT context switch for each vcpu

2018-10-31 Thread Alexander Shishkin
Paolo Bonzini writes: > On 30/10/2018 12:26, Alexander Shishkin wrote: >> There is a control in the perf event attribute that enables tracing the >> guest. If this control is enabled, the kvm needs to stay away from any >> PT related MSRs. > > This cannot happen once the guest has been told it

Re: [PATCH RFC] hist lookups

2018-10-31 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 30, 2018 at 10:03:28PM -0700, David Miller escreveu: > > So when a cpu is overpowered processing samples, most of the time is > spent in the histogram code. > > It seems we initialize a ~262 byte structure on the stack to do every > histogram entry lookup. > > This is a side effect

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-31 Thread Oleg Nesterov
On 10/30, Kees Cook wrote: > > I'd like to avoid changing the return value of __secure_computing() to > just avoid having to touch all the callers. And I'd prefer not to > change __seccomp_filter() to a bool, since I'd like the return values > to be consistent through the call chain. Sure, please

Re: [PATCH v2] mtd: spi-nor: Add support for SPI boot flash access for AMD Family 16h

2018-10-31 Thread Boris Brezillon
On Wed, 31 Oct 2018 03:18:28 + "Grandbois, Brett" wrote: > On 30/10/18 6:26 pm, Boris Brezillon wrote: > > On Mon, 29 Oct 2018 23:15:42 + > > "Grandbois, Brett" wrote: > > > >> On 28/10/18 1:39 am, Boris Brezillon wrote: > >>> Hi Brett, > >>> > >>> On Tue, 16 Oct 2018 00:57:41 +

Re: [PATCH v3 0/7] Standardize onboard LED support for 96Boards

2018-10-31 Thread Linus Walleij
On Mon, Oct 29, 2018 at 10:43 AM Manivannan Sadhasivam wrote: > This patchset standardizes the onboard LEDs on 96Boards by maintaining > common labels and triggers as below: > > green:user1 default-trigger: heartbeat > green:user2 default-trigger: mmc0/disk-activity (onboard-storage) >

Re: [PATCH 3/3] kprobes/x86: Simplify indirect-jump check in retpoline

2018-10-31 Thread Peter Zijlstra
On Wed, Oct 31, 2018 at 02:53:20PM +0100, Peter Zijlstra wrote: > On Wed, Oct 31, 2018 at 02:01:20PM +0800, Zhenzhong Duan wrote: > > On 2018/10/30 16:36, Peter Zijlstra wrote: > > > On Mon, Oct 29, 2018 at 11:55:06PM -0700, Zhenzhong Duan wrote: > > > > Since CONFIG_RETPOLINE hard depends on

Re: [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Adrian Hunter
On 31/10/18 3:28 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 31, 2018 at 11:10:42AM +0200, Adrian Hunter escreveu: >> In the absence of a fallback, callchains must encode also the callchain >> context. Do that now there is no fallback. > > So, this one is independent of the first 3 patches,

Re: [RFC 0/2] RISC-V: A proposal to add vendor-specific code

2018-10-31 Thread Christoph Hellwig
On Wed, Oct 31, 2018 at 04:46:10PM +0530, Anup Patel wrote: > I agree that we need a place for vendor-specific ISA extensions and > having vendor-specific directories is also good. The only sensible answer is that we should not allow vendor specific extensions in the kernel at all. We need to

[PATCH v2] Implement /proc/pid/kill

2018-10-31 Thread Daniel Colascione
Add a simple proc-based kill interface. To use /proc/pid/kill, just write the signal number in base-10 ASCII to the kill file of the process to be killed: for example, 'echo 9 > /proc/$$/kill'. Semantically, /proc/pid/kill works like kill(2), except that the process ID comes from the proc

Re: [RFC PATCH] Implement /proc/pid/kill

2018-10-31 Thread Oleg Nesterov
On 10/31, Daniel Colascione wrote: > > > perhaps it would be simpler to do > > > > my_cred = override_creds(file->f_cred); > > kill_pid(...); > > revert_creds(my_cred); > > Thanks for the suggestion. That looks neat, but it's not quite enough. > The problem is that

Re: [PATCH] mmc: mmci: add variant property to send stop cmd if a command fail

2018-10-31 Thread Ulf Hansson
On 30 October 2018 at 11:16, Ludovic Barre wrote: > From: Ludovic Barre > > The mmc framework follows the requirement of SD_Specification: > the STOP_TRANSMISSION is sent on multiple write/read commands > and the stop command (alone), not needed on other ADTC commands. Well, there is a bit more

[PATCH] ALSA:hda: fix front speakers on Huawei MBXP.

2018-10-31 Thread ayman . bagabas
From d472c06898cf5a2aebf1a6ef7d5095a672e08901 Mon Sep 17 00:00:00 2001 From: Ayman Bagabas Date: Wed, 31 Oct 2018 11:34:15 -0400 Subject: [PATCH 2/3] ALSA:hda: fix front speakers on Huawei MBXP. This patch enables the front speakers on Huawei Matebook X Pro laptops. These laptops come with

[PATCH 0/5] Fragmentation avoidance improvements

2018-10-31 Thread Mel Gorman
Warning: This is a long intro with long changelogs and this is not a trivial area to either analyse or fix. TLDR -- 95% reduction in fragmentation events, patches 1-3 should be relatively ok. Patch 4 and 5 need scrutiny but they are also independent or dropped. It has been

Re: [PATCH] of/platform: Support dynamic device tree on AMBA bus

2018-10-31 Thread Frank Rowand
On 10/31/18 8:32 AM, Jaewon Kim wrote: > Hi Frank, > > > Thanks to review my patch. > > On 18. 10. 31. 오전 8:04, Frank Rowand wrote: >> Hi Jaewon, >> >> On 10/25/18 9:39 AM, Jaewon Kim wrote: >>> This patch supports dynamic device-tree for AMBA device. >> Add AMBA devices and buses to

[PATCH 2/5] mm: Move zone watermark accesses behind an accessor

2018-10-31 Thread Mel Gorman
This is a preparation patch only, no functional change. Signed-off-by: Mel Gorman --- include/linux/mmzone.h | 9 + mm/compaction.c| 2 +- mm/page_alloc.c| 12 ++-- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/include/linux/mmzone.h

Re: [mm PATCH v4 3/6] mm: Use memblock/zone specific iterator for handling deferred page init

2018-10-31 Thread Pasha Tatashin
On 10/31/18 12:05 PM, Alexander Duyck wrote: > On Wed, 2018-10-31 at 15:40 +, Pasha Tatashin wrote: >> >> On 10/17/18 7:54 PM, Alexander Duyck wrote: >>> This patch introduces a new iterator for_each_free_mem_pfn_range_in_zone. >>> >>> This iterator will take care of making sure a given

Re: [PATCH v2 0/8] OLPC 1.75 Keyboard/Touchpad fixes

2018-10-31 Thread Pavel Machek
Hi! > > https://github.com/hackerspace/olpc-xo175-buildroot/releases > > > > Here's a SD card image that works for me. The topmost commit in the > > same repository is the build configuration that was used to generate > > it: > > > >

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-31 Thread Dean Wallace
On 31-10-18, Hans de Goede wrote: > Thanks, can you give the attached patch a try. This does the same > as the previous one you tested, but then only on the Swanky. > > Note I've added: > > Reported-and-tested-by: Dean Wallace > > To the commit message, I hope that is ok with you, if not let

Re: [RFC PATCH] Minimal non-child process exit notification support

2018-10-31 Thread Daniel Colascione
On Wed, Oct 31, 2018 at 12:27 PM, David Laight wrote: > From: Daniel Colascione >> Sent: 29 October 2018 17:53 >> >> This patch adds a new file under /proc/pid, /proc/pid/exithand. >> Attempting to read from an exithand file will block until the >> corresponding process exits, at which point the

Re: [PATCH 2/4] mm: introduce mm_[p4d|pud|pmd]_folded

2018-10-31 Thread Kirill A. Shutemov
On Wed, Oct 31, 2018 at 01:59:59PM +0100, Martin Schwidefsky wrote: > Add three architecture overrideable functions to test if the > p4d, pud, or pmd layer of a page table is folded or not. > > Signed-off-by: Martin Schwidefsky Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov

Re: [PATCH 0/5] perf tools: Fix for cases where cpumode is incorrect or insufficient

2018-10-31 Thread Jiri Olsa
On Wed, Oct 31, 2018 at 11:10:38AM +0200, Adrian Hunter wrote: > Hi > > These patches probably deal with most cases except the one fixed by David > Miller's "perf callchain: Honour the ordering of > PERF_CONTEXT_{USER,KERNEL,etc}" patch, and also cat_backtrace() which looks > like it has the same

Re: [PATCH 3/3] kobject: fix warnings use pr_* to replace printk

2018-10-31 Thread YU Bo
Hi, On Tue, Oct 30, 2018 at 08:01:50AM -0700, Joe Perches wrote: On Tue, 2018-10-30 at 08:01 -0400, Bo YU wrote: Fix warning from checkpatch.pl use pr_* to replace printk If you look at msg, it can be unterminated with newline. diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c []

Re: [RFC PATCH v2] soc: qcom: rmtfs_mem: Control remoteproc from rmtfs_mem

2018-10-31 Thread Sibi Sankar
Hi Bjorn, Thanks for the review! On 2018-10-22 01:46, Bjorn Andersson wrote: On Sun 30 Sep 08:56 PDT 2018, Sibi Sankar wrote: From: Bjorn Andersson rmtfs_mem provides access to physical storage and is crucial for the operation of the Qualcomm modem subsystem. The rmtfs_mem implementation

Re: [PATCH 0/4] pinctrl: meson: fix pull bits

2018-10-31 Thread Linus Walleij
On Mon, Oct 29, 2018 at 4:13 PM Jerome Brunet wrote: > This patchset fixes the inversion between pull (up/down) and pull enable > bits on the GPIO AO bank of all amlogic when have, except the axg family. > > The problem has been found while testing bias setting on the libretech > aml-s905x-cc on

Re: [PATCH v4 1/3] arm64: implement ftrace with regs

2018-10-31 Thread Mark Rutland
On Wed, Oct 31, 2018 at 02:19:07PM +0100, Jiri Kosina wrote: > On Wed, 31 Oct 2018, Mark Rutland wrote: > > > I guess skipping the original function prologue would simplify the > > implementation of the replacement function (and would mean that the regs > > held the function arguments per the

Re: [PATCH v13 08/12] KVM: x86: Add Intel PT context switch for each vcpu

2018-10-31 Thread Paolo Bonzini
On 31/10/2018 15:21, Alexander Shishkin wrote: > Paolo Bonzini writes: > >> On 31/10/2018 12:38, Alexander Shishkin wrote: There is no standard way to tell the guest that the host overrode its choice to use PT. However, the host will get a PGD/PGE packet around vmentry and

arm64 tools build failure wrt smp_load_{acquire,release} expansion on gcc version 5.4.0 20160609 (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9)

2018-10-31 Thread Arnaldo Carvalho de Melo
So I noticed the following build failure thare point to: commit 09d62154f61316f7e97eae3f31ef8770c7e4b386 Author: Daniel Borkmann Date: Fri Oct 19 15:51:02 2018 +0200 tools, perf: add and use optimized ring_buffer_{read_head, write_tail} helpers - 50

Re: [GIT PULL] nfsd changes for 4.20

2018-10-31 Thread J. Bruce Fields
On Tue, Oct 30, 2018 at 01:06:58PM -0700, Linus Torvalds wrote: > On Tue, Oct 30, 2018 at 12:55 PM Linus Torvalds > wrote: > > > > Pulled, > > Oh, I take that back. Semantic conflict with locking name change > (recv_lock -> queue_lock) and new code in > >

Re: [PATCH RFC] hist lookups

2018-10-31 Thread David Miller
From: Jiri Olsa Date: Wed, 31 Oct 2018 16:39:07 +0100 > it'd be great to make hist processing faster, but is your main target here > to get the load out of the reader thread, so we dont lose events during the > hist processing? > > we could queue events directly from reader thread into another

[PATCH] memory_hotplug: cond_resched in __remove_pages

2018-10-31 Thread Michal Hocko
From: Michal Hocko We have received a bug report that unbinding a large pmem (>1TB) can result in a soft lockup: [ 380.339203] NMI watchdog: BUG: soft lockup - CPU#9 stuck for 23s! [ndctl:4365] [...] [ 380.339316] Supported: Yes [ 380.339318] CPU: 9 PID: 4365 Comm: ndctl Not tainted

Re: [PATCH v2 0/2] pwm-tiecap: Add support for AM654 SoCs

2018-10-31 Thread Vignesh R
Hi Thierry, On 16/10/18 4:45 PM, Thierry Reding wrote: > On Tue, Oct 16, 2018 at 11:34:00AM +0530, Vignesh R wrote: >> Couple of patches to enable pwm-tiecap driver to be used with TI's new >> AM654 platforms. >> >> Vignesh R (2): >> dt-bindings: pwm: tiecap: Add TI AM654 SoC specific

Re: [RFC PATCH v2 0/6] New QuadSPI driver for Atmel SAMA5D2

2018-10-31 Thread Boris Brezillon
Hi Piotr, Tudor, On Wed, 27 Jun 2018 15:16:03 +0200 Piotr Bugalski wrote: > Hello, > > Atmel SAMA5D2 is equipped with two QSPI interfaces. These interfaces can > work as in SPI-compatible mode or use two / four lines to improve > communication speed. At the moment there is QSPI driver strongly

Re: [PATCH 4.18] Revert "mm: slowly shrink slabs with a relatively small number of objects"

2018-10-31 Thread Sasha Levin
On Fri, Oct 26, 2018 at 07:18:59AM -0400, Sasha Levin wrote: This reverts commit 62aad93f09c1952ede86405894df1b22012fd5ab. Which was upstream commit 172b06c32b94 ("mm: slowly shrink slabs with a relatively small number of objects"). The upstream commit was found to cause regressions. While

Re: [PATCH 3/3] kprobes/x86: Simplify indirect-jump check in retpoline

2018-10-31 Thread Peter Zijlstra
On Wed, Oct 31, 2018 at 02:01:20PM +0800, Zhenzhong Duan wrote: > On 2018/10/30 16:36, Peter Zijlstra wrote: > > On Mon, Oct 29, 2018 at 11:55:06PM -0700, Zhenzhong Duan wrote: > > > Since CONFIG_RETPOLINE hard depends on compiler support now, so > > > replacing indirect-jump check with the range

Herzlichen Glückwunsch, haben Sie als unsere Begünstigten gewählt worden...

2018-10-31 Thread Mavis
Sehr geehrter Herr/Frau, Wir freuen uns, Ihnen mitzuteilen, dass Sie ausgewählt wurden, um die Summe zu erhalten €2,000,000.00 Euro aus Mitteln der Mavis Wanczyk Hilfe. Mein Name ist Mavis Wanczyk der Gewinner des 758,7 Millionen US-Dollar in der Power Ball Lotterie Jackpot als der größte

Re: [PATCH v1 2/2] x86/hyperv: make HvNotifyLongSpinWait hypercall

2018-10-31 Thread Waiman Long
On 10/31/2018 10:10 AM, Peter Zijlstra wrote: > On Wed, Oct 31, 2018 at 09:54:17AM +0800, Yi Sun wrote: >> On 18-10-23 17:33:28, Yi Sun wrote: >>> On 18-10-23 10:51:27, Peter Zijlstra wrote: Can you try and explain why vcpu_is_preempted() doesn't work for you? >>> I thought HvSpinWaitInfo is

Re: [RFC PATCH] Implement /proc/pid/kill

2018-10-31 Thread Oleg Nesterov
On 10/31, Daniel Colascione wrote: > > > Confused... why? kill_ok_by_cred() should fail? > > Not if we don't run it. :-) I thought you were proposing that we do > *all* access checks in open() and let write() succeed unconditionally, Ah, no ;) > Anyway, I sent a v2 patch that I think closes the

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-31 Thread Lina Iyer
On Wed, Oct 31 2018 at 01:05 -0600, Stephen Boyd wrote: Hi Lina, Quoting Lina Iyer (2018-10-10 17:29:58) QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on domain can wakeup the SoC, when interrupts and GPIOs are routed to its interrupt controller. Only select GPIOs that

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-10-31 Thread Petr Mladek
On Thu 2018-10-25 19:10:36, Sergey Senozhatsky wrote: > >From printk()/serial console point of view panic() is special, because > it may force CPU to re-enter printk() or/and serial console driver. > Therefore, some of serial consoles drivers are re-entrant. E.g. 8250: > >

Re: [PATCH v2 04/17] thermal: separate sensor registration and enable+check operations

2018-10-31 Thread Amit Kucheria
> --- a/drivers/hwmon/hwmon.c > +++ b/drivers/hwmon/hwmon.c > @@ -161,6 +161,11 @@ static int hwmon_thermal_add_sensor(struct device *dev, > if (IS_ERR(tzd) && (PTR_ERR(tzd) != -ENODEV)) > return PTR_ERR(tzd); > > + if (!IS_ERR(tzd)) { > +

Re: [RFC PATCH] Implement /proc/pid/kill

2018-10-31 Thread Daniel Colascione
On Wed, Oct 31, 2018 at 12:44 PM, Oleg Nesterov wrote: > On 10/30, Eric W. Biederman wrote: >> >> At a bare minimum you need to perform the permission check using the >> credentials of the opener of the file.Which means refactoring >> kill_pid so that you can perform the permission check for

Re: [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 31, 2018 at 11:10:42AM +0200, Adrian Hunter escreveu: > In the absence of a fallback, callchains must encode also the callchain > context. Do that now there is no fallback. So, this one is independent of the first 3 patches, right? Ok, applying it first, I'll relook the first ones

Re: [PATCH] mtd: change len type from signed to unsigned type

2018-10-31 Thread Boris Brezillon
Hi Huijin, On Thu, 23 Aug 2018 04:43:39 -0400 Huijin Park wrote: > From: "huijin.park" > > assign of a signed value which has type 'int' to a variable of > a bigger unsigned integer type 'uint64_t'. Why are you mentioning u64? AFAICT, the len passed to erase_write() is always an unsigned

Re: [PATCH v1 2/2] x86/hyperv: make HvNotifyLongSpinWait hypercall

2018-10-31 Thread Peter Zijlstra
On Wed, Oct 31, 2018 at 09:54:17AM +0800, Yi Sun wrote: > On 18-10-23 17:33:28, Yi Sun wrote: > > On 18-10-23 10:51:27, Peter Zijlstra wrote: > > > Can you try and explain why vcpu_is_preempted() doesn't work for you? > > > > I thought HvSpinWaitInfo is used to notify hypervisor the spin number

Re: [PATCH v13 08/12] KVM: x86: Add Intel PT context switch for each vcpu

2018-10-31 Thread Alexander Shishkin
Paolo Bonzini writes: > On 31/10/2018 12:38, Alexander Shishkin wrote: >>> There is no standard way to tell the guest that the host overrode its >>> choice to use PT. However, the host will get a PGD/PGE packet around >>> vmentry and vmexit, so there _will_ be an indication that the guest >>>

Re: [PATCH] gpio: sch311x: clean an indentation issue, remove extraneous space

2018-10-31 Thread Linus Walleij
On Tue, Oct 30, 2018 at 3:07 PM Colin King wrote: > From: Colin Ian King > > Trivial fix to clean up an indentation issue, remove space > > Signed-off-by: Colin Ian King Patch applied. Yours, Linus Walleij

Re: [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Adrian Hunter
On 31/10/18 4:15 PM, Adrian Hunter wrote: > On 31/10/18 3:28 PM, Arnaldo Carvalho de Melo wrote: >> Em Wed, Oct 31, 2018 at 11:10:42AM +0200, Adrian Hunter escreveu: >>> In the absence of a fallback, callchains must encode also the callchain >>> context. Do that now there is no fallback. >> >> So,

Re: [RFC PATCH v2] soc: qcom: rmtfs_mem: Control remoteproc from rmtfs_mem

2018-10-31 Thread Sibi Sankar
Hi Brian, Thanks for the review! On 2018-10-18 06:24, Brian Norris wrote: Hi Sibi, On Sun, Sep 30, 2018 at 09:26:46PM +0530, Sibi Sankar wrote: From: Bjorn Andersson rmtfs_mem provides access to physical storage and is crucial for the operation of the Qualcomm modem subsystem. The

Re: [PATCH 14/16] nvme: utilize two queue maps, one for reads and one for writes

2018-10-31 Thread Jens Axboe
On 10/30/18 7:57 PM, Sagi Grimberg wrote: > >> +static int queue_irq_offset(struct nvme_dev *dev) >> +{ >> +/* if we have more than 1 vec, admin queue offsets us 1 */ > > offsets us by 1? Fixed >> @@ -1934,13 +2048,48 @@ static int nvme_setup_io_queues(struct nvme_dev *dev) >> *

Re: [RFC] sunrpc: Fix flood of warnings from iov_iter_kvec in linux-next

2018-10-31 Thread David Howells
re ] > WARNING: CPU: 0 PID: 110 at ../lib/iov_iter.c:1082 iov_iter_kvec+0x4c/0x5c > Modules linked in: > CPU: 0 PID: 110 Comm: kworker/u3:2 Tainted: GW > 4.19.0-next-20181031 #157 > Hardware name: Freescale i.MX6 SoloLite (Device Tree) > Workqueue: xprtiod xs

[PATCH] of: Fix cpu node iterator to not ignore disabled cpu nodes

2018-10-31 Thread Rob Herring
In most cases, nodes with 'status = "disabled";' are treated as if the node is not present though it is a common bug to forget to check that. However, cpu nodes are different in that "disabled" simply means offline and the OS can bring the CPU core online. Commit f1f207e43b8a ("of: Add cpu node

Re: [RFC PATCH] Minimal non-child process exit notification support

2018-10-31 Thread Joel Fernandes
On Wed, Oct 31, 2018 at 7:25 AM, David Laight wrote: > From: Daniel Colascione >> Sent: 31 October 2018 12:56 >> On Wed, Oct 31, 2018 at 12:27 PM, David Laight >> wrote: >> > From: Daniel Colascione >> >> Sent: 29 October 2018 17:53 >> >> >> >> This patch adds a new file under /proc/pid,

[PATCH v3] staging: vboxvideo: Remove unnecessary parentheses

2018-10-31 Thread Shayenne da Luz Moura
Remove unneeded parentheses around the arguments of ||. This reduces clutter and code behave in the same way. Change suggested by checkpatch.pl. vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 < crtc->x' Signed-off-by: Shayenne da Luz Moura --- Changes in v2: - Make the

Re: [RFC PATCH] Implement /proc/pid/kill

2018-10-31 Thread Daniel Colascione
On Wed, Oct 31, 2018 at 3:10 PM, Oleg Nesterov wrote: > On 10/31, Daniel Colascione wrote: >> >> > perhaps it would be simpler to do >> > >> > my_cred = override_creds(file->f_cred); >> > kill_pid(...); >> > revert_creds(my_cred); >> >> Thanks for the suggestion. That

Re: [PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-10-31 Thread Jessica Yu
+++ Vincent Whitchurch [31/10/18 09:42 +0100]: Thumb-2 functions have the lowest bit set in the symbol value in the symtab. When kallsyms are generated for the vmlinux, the kallsyms are generated from the output of nm, and nm clears the lowest bit. $ arm-linux-gnueabihf-readelf -a vmlinux |

Re: [GIT PULL] nfsd changes for 4.20

2018-10-31 Thread Trond Myklebust
On Wed, 2018-10-31 at 11:44 -0400, J. Bruce Fields wrote: > Stephen also sent a warning about a merge conflict with the vfs tree > (not merged yet, I think) but I assume that's not as big a deal since > it > should actually show up at merge time, not build time: > > >

[PATCH v7 2/3] staging: iio: ad2s1210: Drop the gpioin flag.

2018-10-31 Thread Nishad Kamdar
Drop gpioin flag which decides how the GPIOs are controlled as the GPIOs must be outputs for the host as per the datasheet. Signed-off-by: Nishad Kamdar --- drivers/staging/iio/resolver/ad2s1210.c | 45 - drivers/staging/iio/resolver/ad2s1210.h | 17 -- 2 files

[PATCH v7 3/3] staging: iio: ad2s1210: Add device tree table.

2018-10-31 Thread Nishad Kamdar
Add device tree table for matching vendor ID. Signed-off-by: Nishad Kamdar --- drivers/staging/iio/resolver/ad2s1210.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index d3e7d5aad2c8..7c50def91a2b

Re: [mm PATCH v4 3/6] mm: Use memblock/zone specific iterator for handling deferred page init

2018-10-31 Thread Alexander Duyck
On Wed, 2018-10-31 at 15:40 +, Pasha Tatashin wrote: > > On 10/17/18 7:54 PM, Alexander Duyck wrote: > > This patch introduces a new iterator for_each_free_mem_pfn_range_in_zone. > > > > This iterator will take care of making sure a given memory range provided > > is in fact contained within

Re: [PATCH] perf: Don't clone maps from parent when synthesizing forks

2018-10-31 Thread Jiri Olsa
On Tue, Oct 30, 2018 at 10:24:04PM -0700, David Miller wrote: SNIP > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index 111ae858cbcb..214b7979c4e7 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -1708,6 +1708,7 @@ int

Re: [PATCH v1] Bluetooth: hci_qca: Add helper to set device address.

2018-10-31 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-10-27 00:23, Matthias Kaehlcke wrote: On Fri, Oct 26, 2018 at 07:34:50PM +0530, Balakrishna Godavarthi wrote: This patch add qca_set_device_bdaddr() to set the device address for latest Qualcomm Bluetooth chipset wcn3990 and above. Signed-off-by: Balakrishna Godavarthi

Re: NXP P50XX/e5500 secondary CPUs not onlined with current mainline (was [PATCH 20/21] of: use for_each_of_cpu_node iterator)

2018-10-31 Thread Rob Herring
On Wed, Oct 31, 2018 at 7:46 AM Michael Ellerman wrote: > > Hi Rob, > > This change is breaking some powerpc machines, ... > > Rob Herring writes: > > Use the for_each_of_cpu_node iterator to iterate over cpu nodes. This > > has the side effect of defaulting to iterating using "cpu" node names

Re: [PATCH] gpiolib: fix possible use after free on label

2018-10-31 Thread Muchun Song
Hi Linus, Thanks for your review. Linus Walleij 于2018年10月31日周三 下午6:32写道: > > Hi Muchun, > > thanks for your patch! > > On Wed, Oct 24, 2018 at 3:41 PM Muchun Song wrote: > > > gpiod_request_commit() copies the pointer to the label > > passed as an argument only to be used later. But there's a

RE: [RFC PATCH] Minimal non-child process exit notification support

2018-10-31 Thread David Laight
From: Daniel Colascione > Sent: 31 October 2018 12:56 > On Wed, Oct 31, 2018 at 12:27 PM, David Laight > wrote: > > From: Daniel Colascione > >> Sent: 29 October 2018 17:53 > >> > >> This patch adds a new file under /proc/pid, /proc/pid/exithand. > >> Attempting to read from an exithand file

Re: [RFC PATCH] Minimal non-child process exit notification support

2018-10-31 Thread Joel Fernandes
On Wed, Oct 31, 2018 at 7:41 AM, Joel Fernandes wrote: [...] >>> > Indeed, to avoid killing the wrong process you need to have opened >>> > some node of /proc/pid/* (maybe cmdline) before sending the kill >>> > signal. >>> >>> The kernel really needs better documentation of the semantics of >>>

Re: [PATCH v3 1/5] tpm: change the end marker of the active_banks array to zero

2018-10-31 Thread Mimi Zohar
On Tue, 2018-10-30 at 16:47 +0100, Roberto Sassu wrote: > This patch changes the end marker of the active_banks array from > TPM2_ALG_ERROR to zero. The patch description is a bit off. TPM2_ALG_ERROR is defined as zero.  Since tpm_chip_alloc() calls kzalloc to allocate the structure, there is no

Re: [RFC PATCH] Minimal non-child process exit notification support

2018-10-31 Thread Daniel Colascione
On Wed, Oct 31, 2018 at 2:25 PM, David Laight wrote: > From: Daniel Colascione >> Sent: 31 October 2018 12:56 >> On Wed, Oct 31, 2018 at 12:27 PM, David Laight >> wrote: >> > From: Daniel Colascione >> >> Sent: 29 October 2018 17:53 >> >> >> >> This patch adds a new file under /proc/pid,

Re: [PATCH] mfd: arizona: Correct link for sound binding document

2018-10-31 Thread Rob Herring
On Tue, Oct 9, 2018 at 1:55 AM Lee Jones wrote: > > On Fri, 28 Sep 2018, Rob Herring wrote: > > > On Fri, Sep 28, 2018 at 12:46 AM Lee Jones wrote: > > > > > > On Wed, 26 Sep 2018, Rob Herring wrote: > > > > > > > On Mon, Sep 17, 2018 at 04:33:22PM +0100, Charles Keepax wrote: > > > > >

Re: [git pull] mount API series

2018-10-31 Thread Eric W. Biederman
Al Viro writes: > mount API series from David Howells. Last cycle's objections > had been of the "I'd do it differently" variety and with no such > differently done variants having ever materialized over several > cycles... Absolutely not. My objections fundamentally is that I can find

Re: [mm PATCH v4 3/6] mm: Use memblock/zone specific iterator for handling deferred page init

2018-10-31 Thread Pasha Tatashin
On 10/17/18 7:54 PM, Alexander Duyck wrote: > This patch introduces a new iterator for_each_free_mem_pfn_range_in_zone. > > This iterator will take care of making sure a given memory range provided > is in fact contained within a zone. It takes are of all the bounds checking > we were doing in

[PATCH v3] Implement /proc/pid/kill

2018-10-31 Thread Daniel Colascione
Add a simple proc-based kill interface. To use /proc/pid/kill, just write the signal number in base-10 ASCII to the kill file of the process to be killed: for example, 'echo 9 > /proc/$$/kill'. Semantically, /proc/pid/kill works like kill(2), except that the process ID comes from the proc

[PATCH v7 1/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-10-31 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface. Signed-off-by: Nishad Kamdar --- drivers/staging/iio/resolver/ad2s1210.c | 106 ++-- drivers/staging/iio/resolver/ad2s1210.h | 3 - 2 files changed, 62 insertions(+), 47 deletions(-) diff

[PATCH 3/3] ALSA:hda: add support for Huawei WMI MicMute LED

2018-10-31 Thread ab24580
From e7291d296d748b4bdeb3c906b654bf5838c6f8dd Mon Sep 17 00:00:00 2001 From: Ayman Bagabas Date: Wed, 31 Oct 2018 11:51:09 -0400 Subject: [PATCH 3/3] ALSA:hda: add support for Huawei WMI MicMute LED Some of Huawei laptops come with a LED in the mic mute key. This patch enables and disable this

[PATCH 4/5] mm: Stall movable allocations until kswapd progresses during serious external fragmentation event

2018-10-31 Thread Mel Gorman
An external fragmentation causing events as already been described. A serious external fragmentation causing event is described as one that steals a contiguous range of pages of an order lower than fragment_stall_order (PAGE_ALLOC_COSTLY_ORDER by default). If fragmentation would steal a block

[PATCH 3/5] mm: Reclaim small amounts of memory when an external fragmentation event occurs

2018-10-31 Thread Mel Gorman
An external fragmentation event was previously described as When the page allocator fragments memory, it records the event using the mm_page_alloc_extfrag event. If the fallback_order is smaller than a pageblock order (order-9 on 64-bit x86) then it's considered an event that will

[PATCH 5/5] mm: Target compaction on pageblocks that were recently fragmented

2018-10-31 Thread Mel Gorman
Despite the earlier patches, external fragmentation events are still inevitable as not all callers can stall or are appropriate to stall (e.g. unmovable allocations that kswapd reclaim will not necessarily help). In the event there is a mixed pageblock, it's desirable to move all movable pages

[PATCH 3/3] ALSA:hda: add support for Huawei WMI MicMute LED

2018-10-31 Thread ayman . bagabas
From e7291d296d748b4bdeb3c906b654bf5838c6f8dd Mon Sep 17 00:00:00 2001 From: Ayman Bagabas Date: Wed, 31 Oct 2018 11:51:09 -0400 Subject: [PATCH 3/3] ALSA:hda: add support for Huawei WMI MicMute LED Some of Huawei laptops come with a LED in the mic mute key. This patch enables and disable this

[PATCH 1/5] mm, page_alloc: Spread allocations across zones before introducing fragmentation

2018-10-31 Thread Mel Gorman
The page allocator zone lists are iterated based on the watermarks of each zone which does not take anti-fragmentation into account. On x86, node 0 may have multiple zones while other nodes have one zone. A consequence is that tasks running on node 0 may fragment ZONE_NORMAL even though ZONE_DMA32

RE: [RFC PATCH] Minimal non-child process exit notification support

2018-10-31 Thread David Laight
From: Daniel Colascione > Sent: 29 October 2018 17:53 > > This patch adds a new file under /proc/pid, /proc/pid/exithand. > Attempting to read from an exithand file will block until the > corresponding process exits, at which point the read will successfully > complete with EOF. The file

Re: [PATCH v2 0/8] OLPC 1.75 Keyboard/Touchpad fixes

2018-10-31 Thread Pavel Machek
Hi! > > But I don't get kernel messages during boot: > > > > OLPC 1B1, 512 MiB memory... > > OpenFirmware Q4C02 EC Frimware 0.3.02 > > > > Type any key to interrupt... > > (but keys do not interrupt anything, ouch). > > Warning... partition type is 0xb... > > Boot device:

Re: [RFC PATCH] Implement /proc/pid/kill

2018-10-31 Thread Oleg Nesterov
On 10/30, Eric W. Biederman wrote: > > At a bare minimum you need to perform the permission check using the > credentials of the opener of the file.Which means refactoring > kill_pid so that you can perform the permission check for killing the > application during open. perhaps it would be

Re: [PATCH] kretprobe: produce sane stack traces

2018-10-31 Thread Steven Rostedt
On Tue, 30 Oct 2018 10:12:06 +0900 Masami Hiramatsu wrote: > Anyway, until that merge happens, this patch looks good to avoid > this issue for generic solution (e.g. for the arch which doesn't > supports retstack). I think its time to come up with an algorithm that makes function graph work

Re: [PATCH v4 1/3] arm64: implement ftrace with regs

2018-10-31 Thread Jiri Kosina
On Wed, 31 Oct 2018, Mark Rutland wrote: > I guess skipping the original function prologue would simplify the > implementation of the replacement function (and would mean that the regs > held the function arguments per the procedure call standard), but AFAICT > other architectures aren't relying

Re: [PATCH] mtd: cast to u64 to avoid unexpected error

2018-10-31 Thread Boris Brezillon
Hi Huijin, Subject prefix should be "mtd: spi-nor: ...", and please replace "unexpected error" by "unsigned int overflows". On Thu, 23 Aug 2018 03:28:02 -0400 Huijin Park wrote: > From: "huijin.park" > > the params->size is defined as "u64" > and, "info->sector_size" and "info->n_sectors" is

Re: linux-next: Tree for Oct 31 (vboxguest)

2018-10-31 Thread Randy Dunlap
On 10/30/18 8:59 PM, Stephen Rothwell wrote: > Hi all, > > Please do not add any v4.21/v5.1 code to your linux-next included trees > until after the merge window closes. > > Changes since 20181030: > on i386: ld: drivers/virt/vboxguest/vboxguest_core.o: in function `vbg_ioctl_hgcm_call':

[RFC] sunrpc: Fix flood of warnings from iov_iter_kvec in linux-next

2018-10-31 Thread Leonard Crestez
/0x5c Modules linked in: CPU: 0 PID: 110 Comm: kworker/u3:2 Tainted: GW 4.19.0-next-20181031 #157 Hardware name: Freescale i.MX6 SoloLite (Device Tree) Workqueue: xprtiod xs_stream_data_receive_workfn [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (

[PATCH 3/4] mm: add mm_pxd_folded checks to pgtable_bytes accounting functions

2018-10-31 Thread Martin Schwidefsky
The common mm code calls mm_dec_nr_pmds() and mm_dec_nr_puds() in free_pgtables() if the address range spans a full pud or pmd. If mm_dec_nr_puds/mm_dec_nr_pmds are non-empty due to configuration settings they blindly subtract the size of the pmd or pud table from pgtable_bytes even if the pud or

[PATCH 4/4] s390/mm: fix mis-accounting of pgtable_bytes

2018-10-31 Thread Martin Schwidefsky
In case a fork or a clone system fails in copy_process and the error handling does the mmput() at the bad_fork_cleanup_mm label, the following warning messages will appear on the console: BUG: non-zero pgtables_bytes on freeing mm: 16384 The reason for that is the tricks we play with

[PATCH 1/4] mm: make the __PAGETABLE_PxD_FOLDED defines non-empty

2018-10-31 Thread Martin Schwidefsky
Change the currently empty defines for __PAGETABLE_PMD_FOLDED, __PAGETABLE_PUD_FOLDED and __PAGETABLE_P4D_FOLDED to return 1. This makes it possible to use __is_defined() to test if the preprocessor define exists. Signed-off-by: Martin Schwidefsky --- arch/arm/include/asm/pgtable-2level.h|

[PATCH 0/4] pgtable bytes mis-accounting v3

2018-10-31 Thread Martin Schwidefsky
Greetings, version #3 of the fix for the pgtable_bytes mis-accounting problem on s390. Three times is a charm.. Changes v2 -> v3: - Add a fourth patch to redefine __PAGETABLE_PxD_FOLDED as non-empty - Move mm_pxd_folded() to include/asm-generic/pgtable.h and use __is_defined() again with

Re: [PATCH] perf: Don't clone maps from parent when synthesizing forks

2018-10-31 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 30, 2018 at 10:24:04PM -0700, David Miller escreveu: > > When synthesizing FORK events, we are trying to create thread objects > for the already running tasks on the machine. > > Normally, for a kernel FORK event, we want to clone the parent's maps > because that is what the kernel

[PATCH 2/4] mm: introduce mm_[p4d|pud|pmd]_folded

2018-10-31 Thread Martin Schwidefsky
Add three architecture overrideable functions to test if the p4d, pud, or pmd layer of a page table is folded or not. Signed-off-by: Martin Schwidefsky --- include/asm-generic/pgtable.h | 16 1 file changed, 16 insertions(+) diff --git a/include/asm-generic/pgtable.h

Re: [PATCH] kretprobe: produce sane stack traces

2018-10-31 Thread Aleksa Sarai
On 2018-10-31, Steven Rostedt wrote: > > Anyway, until that merge happens, this patch looks good to avoid > > this issue for generic solution (e.g. for the arch which doesn't > > supports retstack). > > I think its time to come up with an algorithm that makes function graph > work with multiple

  1   2   3   4   5   6   7   8   9   10   >