Re: [PATCH v4 1/6] tpm: dynamically allocate active_banks array

2018-11-07 Thread Mimi Zohar
On Wed, 2018-11-07 at 11:44 +0530, Nayna Jain wrote: > On 11/06/2018 08:31 PM, Roberto Sassu wrote: > > @@ -878,11 +877,14 @@ static ssize_t tpm2_get_pcr_allocation(struct > > tpm_chip *chip) > > if (rc) > > goto out; > > > > - count = be32_to_cpup( > > +

Re: [RFC 0/2] Add RISC-V cpu topology

2018-11-07 Thread Mark Rutland
On Wed, Nov 07, 2018 at 04:31:34AM +0200, Nick Kossifidis wrote: > Mark and Sundeep thanks a lot for your feedback, I guess you convinced > me that having a device tree binding for the scheduler is not a > correct approach. It's not a device after all and I agree that the > device tree shouldn't

Re: [PATCH v3] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-11-07 Thread Greg Kroah-Hartman
On Tue, Nov 06, 2018 at 01:13:19PM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface in olpc_dcon_xo_1.c. > --- > Changes in v3: > - Resolve a few compilation errors. > Changes in v2: > - Resolve a few compilation errors. > - Add a

Re: fs/ubifs/auth.c:249:2: error: implicit declaration of function 'request_key'

2018-11-07 Thread Sascha Hauer
On Wed, Nov 07, 2018 at 02:25:10AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 8053e5b93eca9b011f7b79bb019bf1eeaaf96c4b > commit: d8a22773a12c6d78ee758c9e530f3a488bb7cb29 ubifs: Enable authentication > support >

Re: [PATCH v2 1/4] mm: Fix multiple evaluvations of totalram_pages and managed_pages

2018-11-07 Thread Michal Hocko
On Tue 06-11-18 21:51:47, Arun KS wrote: > This patch is in preparation to a later patch which converts totalram_pages > and zone->managed_pages to atomic variables. This patch does not introduce > any functional changes. I forgot to comment on this one. The patch makes a lot of sense. But I

Re: [PATCH RFC] hist lookups

2018-11-07 Thread Jiri Olsa
On Tue, Nov 06, 2018 at 10:13:49PM -0800, David Miller wrote: > From: Jiri Olsa > Date: Tue, 6 Nov 2018 21:42:55 +0100 > > > I pushed that fix in perf/fixes branch, but I'm still occasionaly > > hitting the namespace crash.. working on it ;-) > > Jiri, how can this new scheme work without

Re: [PATCH] mmc: core: Remove timeout when enabling cache

2018-11-07 Thread Wolfram Sang
> That also happens to be one of the cards we deploy; However i did > wonder about adding a quirk but decided against it as it was not clear > to me from the specification that CACHE ON really is meant to complete > within GENERIC_CMD6_TIMEOUT. That and i fret about ending up in hit-a- > mole

Re: [PATCH v3 0/7] PBLK Bugfixes and cleanups

2018-11-07 Thread Matias Bjørling
On 11/06/2018 02:33 PM, Hans Holmberg wrote: From: Hans Holmberg This series is a slew of bugfixes and cleanups for PBLK, mostly fixing issues found during corner-case testing in QEMU. Changes since v1: Messed up from:, now the patches apply with the correct author Pardon the

Re: [PATCH] pinctrl: zynq: Use define directive for PIN_CONFIG_IO_STANDARD

2018-11-07 Thread Michal Simek
On 01. 11. 18 1:57, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another: > > drivers/pinctrl/pinctrl-zynq.c:985:18: warning: implicit conversion from > enumeration type 'enum zynq_pin_config_param' to different enumeration > type 'enum

Re: [PATCH] pinctrl: zynq: Use define directive for PIN_CONFIG_IO_STANDARD

2018-11-07 Thread Michal Simek
On 07. 11. 18 9:55, Nathan Chancellor wrote: > On Wed, Nov 07, 2018 at 09:46:12AM +0100, Michal Simek wrote: >> On 01. 11. 18 1:57, Nathan Chancellor wrote: >>> Clang warns when one enumerated type is implicitly converted to another: >>> >>> drivers/pinctrl/pinctrl-zynq.c:985:18: warning: implicit

Re: [PATCH] mm, memory_hotplug: check zone_movable in has_unmovable_pages

2018-11-07 Thread Michal Hocko
On Wed 07-11-18 08:55:26, osalvador wrote: > On Wed, 2018-11-07 at 08:35 +0100, Michal Hocko wrote: > > On Wed 07-11-18 07:35:18, Balbir Singh wrote: > > > The check seems to be quite aggressive and in a loop that iterates > > > pages, but has nothing to do with the page, did you mean to make > >

Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions

2018-11-07 Thread Vokáč Michal
On 6.11.2018 23:07, Jacek Anaszewski wrote: > Add common LED function definitions for use in Device Tree. > The function names were extracted from existing dts files > after eliminating oddities. > > Signed-off-by: Jacek Anaszewski > Cc: Baolin Wang > Cc: Daniel Mack > Cc: Dan Murphy > Cc:

[PATCH 0/3] x86/cpu: fix some prototype warning

2018-11-07 Thread Yi Wang
This series of patch fix some prototype warning because of missing include file. Yi Wang (3): x86/cpu: fix prototype warning in cacheinfo.c x86/cpu: fix prototype warning in scattered.c x86/cpu: fix prototype warning in topology.c arch/x86/kernel/cpu/cacheinfo.c | 1 +

Re: [PATCH] pinctrl: zynq: Use define directive for PIN_CONFIG_IO_STANDARD

2018-11-07 Thread Nathan Chancellor
On Wed, Nov 07, 2018 at 09:46:12AM +0100, Michal Simek wrote: > On 01. 11. 18 1:57, Nathan Chancellor wrote: > > Clang warns when one enumerated type is implicitly converted to another: > > > > drivers/pinctrl/pinctrl-zynq.c:985:18: warning: implicit conversion from > > enumeration type 'enum

Re: [PATCH v2] pinctrl: zynq: Use define directive for PIN_CONFIG_IO_STANDARD

2018-11-07 Thread Michal Simek
On 07. 11. 18 9:56, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another: > > drivers/pinctrl/pinctrl-zynq.c:985:18: warning: implicit conversion from > enumeration type 'enum zynq_pin_config_param' to different enumeration > type 'enum

Re: [PATCH] arm64: fix commit style in the comments

2018-11-07 Thread Catalin Marinas
On Wed, Nov 07, 2018 at 11:39:11PM +0800, Peng Hao wrote: > Use git commit description style 'commit <12+ chars of sha1> > ("")' in the comments. > > Signed-off-by: Peng Hao > --- > arch/arm64/kernel/sys32.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Borislav Petkov
On Tue, Nov 06, 2018 at 05:20:41PM -0600, Bjorn Helgaas wrote: > Or maybe even drivers/acpi/thermal.c, which claims every Thermal Zone > (ACPI 6.2, sec 11), would be sufficient. I don't know what the > relationship between hwmon and other thermal stuff, e.g., > Documentation/thermal/sysfs-api.txt

Re: [PATCH v2 1/4] mm: Fix multiple evaluvations of totalram_pages and managed_pages

2018-11-07 Thread Vlastimil Babka
On 11/7/18 9:20 AM, Michal Hocko wrote: > On Tue 06-11-18 21:51:47, Arun KS wrote: Hi, there's typo in subject: evaluvations -> evaluations. However, "fix" is also misleading (more below), so I'd suggest something like: mm: reference totalram_pages and managed_pages once per function >> This

Re: [PATCH v3] x86/vsmp_64.c: Remove dependency on pv_irq_ops

2018-11-07 Thread Eial Czerwacki
Greetings Ingo, On 11/05/2018 07:59 PM, Ingo Molnar wrote: > > * Eial Czerwacki wrote: > >> +#if defined(CONFIG_PCI) > > This is shorter: > >#ifdef CONFIG_PCI > > Thanks, > > Ingo > you are absolutely right, looks like Thomas have handled it already. Eial.

Greetings From Mrs.Elodie Antoine,

2018-11-07 Thread Mrs Elodie Antoine
Greetings From Mrs.Elodie Antoine, May be this letter will definitely come to you as a huge surprise, but I implore you to take the time to go through it carefully as the decision you make will go off a long way to determine my future and continued existence. I am Mrs.Elodie Antoine aging

[tip:x86/boot] x86/boot: Simplify the detect_memory*() control flow

2018-11-07 Thread tip-bot for Jordan Borgner
Commit-ID: e8eeb3c8aab044ee8faf5e0389db8518629a9324 Gitweb: https://git.kernel.org/tip/e8eeb3c8aab044ee8faf5e0389db8518629a9324 Author: Jordan Borgner AuthorDate: Fri, 2 Nov 2018 14:56:22 + Committer: Ingo Molnar CommitDate: Tue, 6 Nov 2018 21:05:01 +0100 x86/boot: Simplify the

Re: [PATCH] ubifs: CONFIG_UBIFS_FS_AUTHENTICATION should depend on UBIFS_FS

2018-11-07 Thread Sascha Hauer
On Mon, Nov 05, 2018 at 09:25:40AM +0100, Geert Uytterhoeven wrote: > Instead of adding yet another dependency on UBIFS_FS, wrap the whole > block of ubifs config options in a single "if UBIFS_FS". > > Fixes: d8a22773a12c6d78 ("ubifs: Enable authentication support") > Signed-off-by: Geert

Re: [PATCH] i2c: at91: switched to resume/suspend callbacks.

2018-11-07 Thread Ludovic Desroches
On Mon, Oct 22, 2018 at 12:17:47PM +0200, Andrei Stefanescu - M50506 wrote: > In the previous version of the driver resume/suspend_noirq callbacks > were used. Because of this, when resuming from suspend-to-ram, > an I2C (belonging to a FLEXCOM) would resume before FLEXCOM. > The first read on the

Re: [PATCH 0/2] pinctrl: sh-pfc: r8a77965: Add VIN4 and VIN5

2018-11-07 Thread Geert Uytterhoeven
Hi Jacopo, (sorry, seems I prepared a reply, but forgot to press "Send") On Tue, Nov 6, 2018 at 10:31 AM jacopo mondi wrote: > On Tue, Nov 06, 2018 at 10:24:30AM +0100, Geert Uytterhoeven wrote: > > On Tue, Nov 6, 2018 at 10:08 AM jacopo mondi wrote: > > > On Mon, Nov 05, 2018 at 06:19:22PM

Re: [PATCH v2 2/4] mm: Convert zone->managed_pages to atomic variable

2018-11-07 Thread Vlastimil Babka
On 11/6/18 5:21 PM, Arun KS wrote: > totalram_pages, zone->managed_pages and totalhigh_pages updates > are protected by managed_page_count_lock, but readers never care > about it. Convert these variables to atomic to avoid readers > potentially seeing a store tear. > > This patch converts

[PATCH v2] pinctrl: zynq: Use define directive for PIN_CONFIG_IO_STANDARD

2018-11-07 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another: drivers/pinctrl/pinctrl-zynq.c:985:18: warning: implicit conversion from enumeration type 'enum zynq_pin_config_param' to different enumeration type 'enum pin_config_param' [-Wenum-conversion] {"io-standard",

[PATCH 3/3] x86/cpu: fix prototype warning in topology.c

2018-11-07 Thread Yi Wang
Missing include file causes warning: arch/x86/kernel/cpu/topology.c:25:5: warning: no previous prototype for ‘detect_extended_topology_early’ [-Wmissing-prototypes] arch/x86/kernel/cpu/topology.c:57:5: warning: no previous prototype for ‘detect_extended_topology’ [-Wmissing-prototypes]

[PATCH 1/3] x86/cpu: fix prototype warning in cacheinfo.c

2018-11-07 Thread Yi Wang
Missing include file causes warning: arch/x86/kernel/cpu/cacheinfo.c:647:6: warning: no previous prototype for ‘cacheinfo_amd_init_llc_id’ [-Wmissing-prototypes] arch/x86/kernel/cpu/cacheinfo.c:686:6: warning: no previous prototype for ‘cacheinfo_hygon_init_llc_id’ [-Wmissing-prototypes]

[PATCH 2/3] x86/cpu: fix prototype warning in scattered.c

2018-11-07 Thread Yi Wang
Missing include file causes warning: arch/x86/kernel/cpu/scattered.c:37:6: warning: no previous prototype for ‘init_scattered_cpuid_features’ [-Wmissing-prototypes] arch/x86/kernel/cpu/scattered.c:60:5: warning: no previous prototype for ‘get_scattered_cpuid_leaf’ [-Wmissing-prototypes]

Re: [RFC/RFT][PATCH v3] cpuidle: New timer events oriented governor for tickless systems

2018-11-07 Thread Peter Zijlstra
On Wed, Nov 07, 2018 at 12:39:31AM +0100, Rafael J. Wysocki wrote: > On Tue, Nov 6, 2018 at 8:51 PM Peter Zijlstra wrote: > > > > On Tue, Nov 06, 2018 at 07:19:24PM +0100, Rafael J. Wysocki wrote: > > > On Tue, Nov 6, 2018 at 6:04 PM Peter Zijlstra > > > wrote: > > > > > > Instead of this

Re: [PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions.

2018-11-07 Thread Greg Kroah-Hartman
On Wed, Nov 07, 2018 at 10:30:43AM +0800, Jerry Lin wrote: > Add a attribute called permissions under vsoc device node for examining > current granted permissions in vsoc_device. > > This file will display permissions in following format: > begin_offset end_offset owner_offset owned_value >

Re: [PATCH 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-07 Thread Christoph Hellwig
On Tue, Nov 06, 2018 at 06:11:31PM +0800, AceLan Kao wrote: > Agree, this is not a good fix for Sk hynix nvme, so Dell is still pushing > Sk hynix to fix it from firmware. > But before the firmware is ready, this is still a issue that need to be fixed > in > kernel side, and the new firmware may

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-07 Thread Vlastimil Babka
On 11/7/18 8:02 AM, Konstantin Khlebnikov wrote: > On 06.11.2018 11:43, Arun KS wrote: >> On 2018-11-06 14:07, Konstantin Khlebnikov wrote: >>> On 06.11.2018 11:30, Arun KS wrote: On 2018-11-06 13:47, Konstantin Khlebnikov wrote: > On 06.11.2018 8:38, Arun KS wrote: >> Any comments?

[PATCH] ARM: dts: imx6sx: specify proper clock for nodes with dummy clock

2018-11-07 Thread Anson Huang
>From i.MX6SX reference manual CCM chapter, KPP and WDOGn use IPG clock as their clock, specify IPG clock for KPP and WDOGn instead of DUMMY clock. Signed-off-by: Anson Huang --- arch/arm/boot/dts/imx6sx.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v2 3/4] mm: convert totalram_pages and totalhigh_pages variables to atomic

2018-11-07 Thread Vlastimil Babka
On 11/6/18 5:21 PM, Arun KS wrote: > totalram_pages and totalhigh_pages are made static inline function. > > Suggested-by: Michal Hocko > Suggested-by: Vlastimil Babka > Signed-off-by: Arun KS > Reviewed-by: Konstantin Khlebnikov > Acked-by: Michal Hocko Acked-by: Vlastimil Babka One bug

Re: [PATCH] jffs2: implement mount option to configure endianness

2018-11-07 Thread David Woodhouse
On Tue, 2018-11-06 at 13:49 -0800, Nikunj Kela wrote: > This patch allows the endianness of the JFSS2 filesystem to be > specified by mount option 'force_endian=big|little|native'. If > endianness is not specified, it defaults to 'native' endianness > thus retaining the existing behavior. > >

[PATCH] utimensat: AT_EMPTY_PATH support

2018-11-07 Thread Miklos Szeredi
This makes it possible to use utimensat on an O_PATH file (including symlinks). It supersedes the nonstandard utimensat(fd, NULL, ...) form. Signed-off-by: Miklos Szeredi --- fs/utimes.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/utimes.c b/fs/utimes.c index

Re: [PATCH] jffs2: implement mount option to configure endianness

2018-11-07 Thread Joakim Tjernlund
On Wed, 2018-11-07 at 10:05 +0100, David Woodhouse wrote: > > On Tue, 2018-11-06 at 13:49 -0800, Nikunj Kela wrote: > > This patch allows the endianness of the JFSS2 filesystem to be > > specified by mount option 'force_endian=big|little|native'. If > > endianness is not specified, it defaults to

Re: [PATCH v2 1/4] dt-bindings: pinctrl: Add devicetree bindings for MT6797 SoC Pinctrl

2018-11-07 Thread Sean Wang
On Wed, Oct 31, 2018 at 11:28 PM Manivannan Sadhasivam wrote: > > Add devicetree bindings for Mediatek MT6797 SoC Pin Controller. > > Signed-off-by: Manivannan Sadhasivam > --- > .../bindings/pinctrl/pinctrl-mt6797.txt | 74 + > include/dt-bindings/pinctrl/mt6797-pinfunc.h | 1368

Re: RFC: staging: gasket: re-implement using UIO

2018-11-07 Thread Greg KH
On Tue, Nov 06, 2018 at 04:20:49PM -0800, Todd Poynor wrote: > On Mon, Sep 10, 2018 at 8:28 AM Ahmed S. Darwish wrote: > > > > The gasket in-kernel framework, recently introduced under staging, > > re-implements what is already long-time provided by the UIO > > subsystem, with extra PCI BAR

Re: [PATCH 4/6] drivers: base: Introducing software nodes to the firmware node framework

2018-11-07 Thread Heikki Krogerus
On Wed, Nov 07, 2018 at 07:39:33AM +0300, Dan Carpenter wrote: > Hi Heikki, > > url: > https://github.com/0day-ci/linux/commits/Heikki-Krogerus/device-property-Introducing-software-nodes/20181106-031310 > > smatch warnings: > drivers/base/swnode.c:391 fwnode_create_software_node() error:

Re: KMSAN: kernel-infoleak in kvm_vcpu_write_guest_page

2018-11-07 Thread Paolo Bonzini
On 07/11/2018 13:10, Alexander Potapenko wrote: > This appears to be a real bug in KVM. > Please see a simplified reproducer attached. Thanks, I agree it's a reael bug. The basic issue is that the kvm_state->size member is too small (1040) in the KVM_SET_NESTED_STATE ioctl, aka 0x4080aebf. One

Re: [PATCH] mm, memory_hotplug: check zone_movable in has_unmovable_pages

2018-11-07 Thread Michal Hocko
On Wed 07-11-18 23:53:24, Balbir Singh wrote: > On Wed, Nov 07, 2018 at 08:35:48AM +0100, Michal Hocko wrote: > > On Wed 07-11-18 07:35:18, Balbir Singh wrote: [...] > > > The check seems to be quite aggressive and in a loop that iterates > > > pages, but has nothing to do with the page, did you

Re: [RCF PATCH,v2,2/2] pwm: imx: Configure output to GPIO in disabled state

2018-11-07 Thread Vokáč Michal
Hi Uwe, On 7.11.2018 10:33, Uwe Kleine-König wrote: > Hello Michal, > > just to state it more explicitly, I think the following patch (not even > compile tested) is much preferable over your approach: Interesting idea. I just wonder why nobody else did not come up with such a simple solution

[PATCH v1 0/1] pinctrl: nuvoton: modify NPCM7xx pin configuration

2018-11-07 Thread Tomer Maimon
This patch Modify GPIO direction setting in pin configuration function. please refer patch: Kun Yi https://patchwork.ozlabs.org/patch/985540/ Tomer Maimon (1): pinctrl: nuvoton: modify NPCM7xx pin configuration function drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 13 +++-- 1 file

[PATCH trivial] Documentation: ABI: led-trigger-pattern: Fix typos

2018-11-07 Thread Geert Uytterhoeven
- Spelling s/brigntess/brightness/, - Double "use". Signed-off-by: Geert Uytterhoeven --- Documentation/ABI/testing/sysfs-class-led-trigger-pattern | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-class-led-trigger-pattern

[PATCH v1 1/1] pinctrl: nuvoton: modify NPCM7xx pin configuration function

2018-11-07 Thread Tomer Maimon
Modify GPIO direction setting in pin configuration function by using generic GPIO functions to set the GPIO direction instead of direct access to the GPIO direction register. Signed-off-by: Tomer Maimon --- drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 13 +++-- 1 file changed, 3

Re: [PATCH 6/7] ext4: lost brelse in ext4_xattr_move_to_block()

2018-11-07 Thread Jan Kara
On Wed 31-10-18 22:13:00, Vasily Averin wrote: > Fixes 3f2571c1f91f ("ext4: factor out xattr moving") > cc: Jan Kara > however issue was present in original ext4_expand_extra_isize_ea() > Fixes 6dd4ee7cab7e ("ext4: Expand extra_inodes space per ...") # 2.6.23 > cc: Kalpak Shah > >

Re: [PATCH v5 02/15] sched/core: make sched_setattr able to tune the current policy

2018-11-07 Thread Patrick Bellasi
On 07-Nov 13:11, Peter Zijlstra wrote: > On Mon, Oct 29, 2018 at 06:32:56PM +, Patrick Bellasi wrote: > > > @@ -50,11 +52,13 @@ > > #define SCHED_FLAG_RESET_ON_FORK 0x01 > > #define SCHED_FLAG_RECLAIM 0x02 > > #define SCHED_FLAG_DL_OVERRUN 0x04 > > -#define

Re: [PATCH v5 02/15] sched/core: make sched_setattr able to tune the current policy

2018-11-07 Thread Peter Zijlstra
On Wed, Nov 07, 2018 at 01:50:39PM +, Patrick Bellasi wrote: > On 07-Nov 13:11, Peter Zijlstra wrote: > > On Mon, Oct 29, 2018 at 06:32:56PM +, Patrick Bellasi wrote: > > > > > @@ -50,11 +52,13 @@ > > > #define SCHED_FLAG_RESET_ON_FORK 0x01 > > > #define SCHED_FLAG_RECLAIM

Re: [PATCH v5 03/15] sched/core: uclamp: map TASK's clamp values into CPU's clamp groups

2018-11-07 Thread Patrick Bellasi
On 07-Nov 14:16, Peter Zijlstra wrote: > On Mon, Oct 29, 2018 at 06:32:57PM +, Patrick Bellasi wrote: > > > +static void uclamp_group_put(unsigned int clamp_id, unsigned int group_id) > > { > > + union uclamp_map *uc_maps = _maps[clamp_id][0]; > > + union uclamp_map uc_map_old,

[PATCH v12 2/5] clk: imx: add fractional PLL output clock

2018-11-07 Thread Abel Vesa
From: Lucas Stach This is a new fractional clock type introduced on i.MX8. The description of this fractional clock can be found here: https://www.nxp.com/docs/en/reference-manual/IMX8MDQLQRM.pdf#page=834 Signed-off-by: Lucas Stach Signed-off-by: Abel Vesa Reviewed-by: Sascha Hauer ---

[PATCH v12 4/5] clk: imx: Add imx composite clock

2018-11-07 Thread Abel Vesa
Since a lot of clocks on imx8m are formed by a mux, gate, predivider and divider, the idea here is to combine all of those into one composite clock, but we need to deal with both predivider and divider at the same time and therefore we add the imx8m_clk_composite_divider_ops and register the

Re: [PATCH v5 2/2] sched/fair: update scale invariance of PELT

2018-11-07 Thread Vincent Guittot
On Wed, 7 Nov 2018 at 11:47, Dietmar Eggemann wrote: > > On 11/5/18 10:10 AM, Vincent Guittot wrote: > > On Fri, 2 Nov 2018 at 16:36, Dietmar Eggemann > > wrote: > >> > >> On 10/26/18 6:11 PM, Vincent Guittot wrote: > > [...] > > >> Thinking about this new approach on a big.LITTLE platform: >

Re: KMSAN: kernel-infoleak in kvm_vcpu_write_guest_page

2018-11-07 Thread Liran Alon
> On 7 Nov 2018, at 14:47, Paolo Bonzini wrote: > > On 07/11/2018 13:10, Alexander Potapenko wrote: >> This appears to be a real bug in KVM. >> Please see a simplified reproducer attached. > > Thanks, I agree it's a reael bug. The basic issue is that the > kvm_state->size member is too

Re: [PATCH] irq/timings: Fix model validity

2018-11-07 Thread Peter Zijlstra
On Wed, Nov 07, 2018 at 11:52:31AM +0100, Daniel Lezcano wrote: > > @@ -146,11 +152,38 @@ static void irqs_update(struct irqt_stat *irqs, u64 > > ts) > > */ > > diff = interval - irqs->avg; > > > > + /* > > +* Online average algorithm: > > +* > > +* new_average = average

Re: [PATCH v5 03/15] sched/core: uclamp: map TASK's clamp values into CPU's clamp groups

2018-11-07 Thread Peter Zijlstra
On Mon, Oct 29, 2018 at 06:32:57PM +, Patrick Bellasi wrote: > +/** > + * uclamp_group_get: increase the reference count for a clamp group > + * @uc_se: the utilization clamp data for the task > + * @clamp_id: the clamp index affected by the task > + * @clamp_value: the new clamp value for the

[PATCH trivial] microblaze: Typo s/use use/use/

2018-11-07 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- arch/microblaze/include/asm/pgtable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/microblaze/include/asm/pgtable.h b/arch/microblaze/include/asm/pgtable.h index f64ebb9c9a413535..bdfb2b3182b04c3b 100644 ---

Re: [PATCH 6/6] fuse: Verify userspace asks to requeue interrupt that we really sent

2018-11-07 Thread Miklos Szeredi
On Tue, Nov 6, 2018 at 10:31 AM, Kirill Tkhai wrote: > When queue_interrupt() is called from fuse_dev_do_write(), > it came from userspace directly. Userspace may pass any > request id, even the request's we have not interrupted > (or even background's request). This patch adds sanity > check to

[PATCH] objtool: fix .cold. functions parent symbols search

2018-11-07 Thread Artem Savkov
The way it is currently done it is possible for read_symbols() to find the same symbol as parent for ".cold" functions. This leads to a bunch of complications such as func length being set to 0 and a segfault in add_switch_table(). Fix by copying the search string instead of modifying it in place.

Re: [RFC PATCH] ptrace: add PTRACE_GET_SYSCALL_INFO request

2018-11-07 Thread Andy Lutomirski
> On Nov 7, 2018, at 3:21 AM, Oleg Nesterov wrote: > >> On 11/07, Elvira Khabirova wrote: >> >> In short, if a 64-bit task performs a syscall through int 0x80, its tracer >> has no reliable means to find out that the syscall was, in fact, >> a compat syscall, and misidentifies it. >> *

Re: [PATCH v6 1/3] printk: Add line-buffered printk() API.

2018-11-07 Thread Petr Mladek
On Fri 2018-11-02 22:31:55, Tetsuo Handa wrote: > How to use this API: > > (1) Call get_printk_buffer() and acquire "struct printk_buffer *". > > (2) Rewrite printk() calls in the following way. The "ptr" is > "struct printk_buffer *" obtained in step (1). > > printk(fmt, ...)

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-07 Thread Hans de Goede
Hi, On 07-11-18 13:22, Rafael J. Wysocki wrote: On Fri, Nov 2, 2018 at 12:07 PM Arnd Bergmann wrote: We still get a link failure with IOSF_MBI=m when the xpower driver is built-in: drivers/acpi/pmic/intel_pmic_xpower.o: In function `intel_xpower_pmic_update_power':

Re: [PATCH 1/6] fuse: Kill fasync only if interrupt is queued in queue_interrupt()

2018-11-07 Thread Miklos Szeredi
On Tue, Nov 6, 2018 at 10:30 AM, Kirill Tkhai wrote: > We should sent signal only in case of interrupt is really queued. > Not a real problem, but this makes the code clearer and intuitive. > > Signed-off-by: Kirill Tkhai > --- > fs/fuse/dev.c |6 +- > 1 file changed, 5 insertions(+), 1

Re: [PATCH] arm64: dts: meson-gx: Add hdmi_5v regulator as hdmi tx supply

2018-11-07 Thread Neil Armstrong
On 05/11/2018 17:21, Neil Armstrong wrote: > The hdmi_5v regulator must be enabled to provide power to the physical HDMI > PHY and enables the HDMI 5V presence loopback for the monitor. > > Fixes: b409f625a6d5 ("ARM64: dts: meson-gx: Add HDMI_5V regulator on selected > boards") > Signed-off-by:

Re: [PATCH v3] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-11-07 Thread Nishad Kamdar
On Wed, Nov 07, 2018 at 12:36:52PM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 06, 2018 at 01:13:19PM +0530, Nishad Kamdar wrote: > > Use the gpiod interface instead of the deprecated old non-descriptor > > interface in olpc_dcon_xo_1.c. > > --- > > Changes in v3: > > - Resolve a few

[PATCH v4] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-11-07 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface in olpc_dcon_xo_1.c. Signed-off-by: Nishad Kamdar --- Changes in v4: - Move changelog after signed-off line. Changes in v3: - Resolve a few compilation errors. Changes in v2: - Resolve a few compilation errors. -

Re: [PATCH v6 1/3] printk: Add line-buffered printk() API.

2018-11-07 Thread Tetsuo Handa
On 2018/11/07 19:21, Petr Mladek wrote: > On Tue 2018-11-06 23:35:02, Sergey Senozhatsky wrote: >>> Since we want to remove "struct cont" eventually, we will try to remove >>> both "implicit printk() users who are expecting KERN_CONT behavior" and >>> "explicit pr_cont()/printk(KERN_CONT) users".

[PATCH] regulator: bd718x7: Change next state after poweroff to ready

2018-11-07 Thread Matti Vaittinen
BD71837 and BD71847 have a HW functionality which leave power rails OFF after powerof state: - if they have been controlled by SW. - if state transition from poweroff is done to SNVS BD71837 can after reset transition from power-off to SNVS or READY state depending on reset reason. By default

Re: [PATCH v6 1/3] printk: Add line-buffered printk() API.

2018-11-07 Thread Petr Mladek
On Fri 2018-11-02 22:31:55, Tetsuo Handa wrote: > Sometimes we want to print a whole line without being disturbed by > concurrent printk() from interrupts and/or other threads, for printk() > which does not end with '\n' can be disturbed. > > Since mixed printk() output makes it hard to

[PATCH v2] PCI: imx: Add imx6sx suspend/resume support

2018-11-07 Thread Leonard Crestez
Enable PCI suspend/resume support on imx6sx socs. This is similar to imx7d with a few differences: * The PM_Turn_Off bit is exposed through an IOMUX GPR, like all other pcie control bits on 6sx. * The pcie_inbound_axi clk needs to be turned off in suspend. On resume it is restored via resume ->

Re: [PATCH 2/3] mm: Use line-buffered printk() for show_free_areas().

2018-11-07 Thread Petr Mladek
On Fri 2018-11-02 22:31:56, Tetsuo Handa wrote: > syzbot is sometimes getting mixed output like below due to concurrent > printk(). Mitigate such output by using line-buffered printk() API. > > Node 0 DMA: 1*4kB (U) 0*8kB 0*16kB 1*32kB > syz-executor0: page allocation failure: order:0, >

Re: [PATCH trivial] Documentation: ABI: led-trigger-pattern: Fix typos

2018-11-07 Thread Pavel Machek
On Wed 2018-11-07 14:45:24, Geert Uytterhoeven wrote: > - Spelling s/brigntess/brightness/, > - Double "use". > > Signed-off-by: Geert Uytterhoeven Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures)

Re: [PATCH 4/6] fuse: Implement fuse_attr_version_inc()

2018-11-07 Thread Miklos Szeredi
On Tue, Nov 6, 2018 at 10:43 AM, Kirill Tkhai wrote: > For cleanup purpose archive repeating pattern: > > spin_lock(>lock); > fi->attr_version = ++fc->attr_version; > spin_unlock(>lock); > > into separate function. > > Signed-off-by: Kirill Tkhai > --- > fs/fuse/dir.c

Re: [PATCH v5 03/15] sched/core: uclamp: map TASK's clamp values into CPU's clamp groups

2018-11-07 Thread Peter Zijlstra
On Wed, Nov 07, 2018 at 01:57:38PM +, Patrick Bellasi wrote: > On 07-Nov 14:16, Peter Zijlstra wrote: > > Please write cmpxchg loops in the form: > > > > atomic_long_t *ptr = _maps[clamp_id][group_id].adata; > > union uclamp_map old, new; > > > > old.data =

Re: [PATCH v2] slimbus: ngd: QCOM_QMI_HELPERS has to be selected

2018-11-07 Thread Srinivas Kandagatla
On 07/11/18 13:59, Greg KH wrote: Really? I do this and then I get this build error on x86: drivers/slimbus/qcom-ngd-ctrl.c: In function ‘of_qcom_slim_ngd_register’: drivers/slimbus/qcom-ngd-ctrl.c:1333:63: warning: dereferencing ‘void *’ pointer data =

Re: [PATCH RFC 1/3] mmc: sdhci: add support for using external DMA devices

2018-11-07 Thread Adrian Hunter
On 5/11/18 5:16 AM, Chunyan Zhang wrote: > Some standard SD host controller can support both external dma > controllers as well as ADMA in which the controller acts as > DMA master. > > Currently the generic SDHCI code supports ADMA/SDMA integrated into > the host controller but does not have any

Re: [PATCH trivial] microblaze: Typo s/use use/use/

2018-11-07 Thread Michal Simek
On 07. 11. 18 14:47, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > arch/microblaze/include/asm/pgtable.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/microblaze/include/asm/pgtable.h > b/arch/microblaze/include/asm/pgtable.h > index

Re: Target bindeb-pkg no longer install DTBs

2018-11-07 Thread Rob Herring
On Wed, Nov 7, 2018 at 12:10 AM Nuno Gonçalves wrote: > > Hi, > > Since 37c8a5fafa3bb7dcdd51774be353be6cb2912b86 [kbuild: consolidate > Devicetree dtb build rules], the target bindeb-pkg no longer installs > DTBs in the .deb package. I see the problem and am testing a fix. Will post it soon.

Re: [PATCH 6/6] device property: Remove struct property_set

2018-11-07 Thread Heikki Krogerus
On Tue, Nov 06, 2018 at 04:46:41PM +0200, Andy Shevchenko wrote: > On Mon, Nov 05, 2018 at 05:59:28PM +0300, Heikki Krogerus wrote: > > Replacing struct property_set with the software nodes that > > were just introduced. > > > > The API and functionality for adding properties to devices > >

Re: [PATCH 3/4] of/property: Introduce of_fwnode_name()

2018-11-07 Thread Heikki Krogerus
On Tue, Nov 06, 2018 at 12:13:30PM -0600, Rob Herring wrote: > On Tue, Nov 6, 2018 at 9:53 AM Andy Shevchenko > wrote: > > > > On Tue, Nov 06, 2018 at 05:05:03PM +0200, Heikki Krogerus wrote: > > > > > Maybe it would be best to just read the "name" device property in > > > fwnode_name() and not

[PATCH v12 5/5] clk: imx: Add clock driver for i.MX8MQ CCM

2018-11-07 Thread Abel Vesa
Add driver for the Clock Control Module found on i.MX8MQ. Signed-off-by: Anson Huang Signed-off-by: Bai Ping Signed-off-by: Lucas Stach Signed-off-by: Abel Vesa Reviewed-by: Sascha Hauer --- drivers/clk/imx/Makefile | 1 + drivers/clk/imx/clk-imx8mq.c | 589

[PATCH v12 1/5] dt-bindings: add binding for i.MX8MQ CCM

2018-11-07 Thread Abel Vesa
From: Lucas Stach This adds the binding for the i.MX8MQ Clock Controller Module. Signed-off-by: Lucas Stach Signed-off-by: Abel Vesa Reviewed-by: Rob Herring --- .../devicetree/bindings/clock/imx8mq-clock.txt | 20 ++ include/dt-bindings/clock/imx8mq-clock.h | 395

[PATCH v12 0/5] Add i.MX8MQ clock driver

2018-11-07 Thread Abel Vesa
So this is all cleaned up now. The switch from clk to clk_hw registration is done only for the newly added clock types because changing the older ones will imply a bigger change. I will spend some time on that, but this can't be delayed by that since this is needed in order to boot up. Here is a

[PATCH v12 3/5] clk: imx: Add SCCG PLL type

2018-11-07 Thread Abel Vesa
From: Lucas Stach The SCCG is a new PLL type introduced on i.MX8. The description of this SCCG clock can be found here: https://www.nxp.com/docs/en/reference-manual/IMX8MDQLQRM.pdf#page=834 Signed-off-by: Lucas Stach Signed-off-by: Abel Vesa Reviewed-by: Sascha Hauer ---

Re: KMSAN: kernel-infoleak in kvm_vcpu_write_guest_page

2018-11-07 Thread Liran Alon
> On 7 Nov 2018, at 14:10, Alexander Potapenko wrote: > > On Wed, Nov 7, 2018 at 2:38 AM syzbot > wrote: >> >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:88b95ef4c780 kmsan: use MSan assembly instrumentation >> git tree: >>

Re: [PATCH] mm, memory_hotplug: check zone_movable in has_unmovable_pages

2018-11-07 Thread Balbir Singh
On Wed, Nov 07, 2018 at 08:35:48AM +0100, Michal Hocko wrote: > On Wed 07-11-18 07:35:18, Balbir Singh wrote: > > On Tue, Nov 06, 2018 at 10:55:24AM +0100, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > Page state checks are racy. Under a heavy memory workload (e.g. stress > > > -m 200

Re: [PATCH v1 1/2] bus: mc-bus: Add support for mapping shareable portals

2018-11-07 Thread Laurentiu Tudor
Hi Roy, On 30.10.2018 22:30, Roy Pledge wrote: > Starting with v5 of NXP QBMan devices the hardware supports using > regular cacheable/shareable memory as the backing store for the > portals. > > This patch adds support for the new portal mode by switching to > use the DPRC get object region v2

Re: [PATCH 2/6] fuse: Optimize request_end() by not taking fiq->waitq.lock

2018-11-07 Thread Miklos Szeredi
On Tue, Nov 6, 2018 at 10:30 AM, Kirill Tkhai wrote: > We take global fiq->waitq.lock every time, when we are > in this function, but interrupted requests are just small > subset of all requests. This patch optimizes request_end() > and makes it to take the lock when it's really needed. > >

Re: [PATCH v5 03/15] sched/core: uclamp: map TASK's clamp values into CPU's clamp groups

2018-11-07 Thread Peter Zijlstra
On Mon, Oct 29, 2018 at 06:32:57PM +, Patrick Bellasi wrote: > +static void uclamp_group_put(unsigned int clamp_id, unsigned int group_id) > { > + union uclamp_map *uc_maps = _maps[clamp_id][0]; > + union uclamp_map uc_map_old, uc_map_new; > + long res; > + > +retry: > + > +

Re: [PATCH 4/6] fuse: Check for FR_SENT bit in fuse_dev_do_write()

2018-11-07 Thread Miklos Szeredi
On Tue, Nov 6, 2018 at 10:30 AM, Kirill Tkhai wrote: > It's not possible to have answer to a request, > before the request is actually sent. Add sanity > check for that. It's checking for the impossible. That sometimes makes sense as a WARN_ON() or in special cases a BUG_ON(). > >

Re: KMSAN: kernel-infoleak in kvm_vcpu_write_guest_page

2018-11-07 Thread Paolo Bonzini
On 07/11/2018 13:58, Liran Alon wrote: > > >> On 7 Nov 2018, at 14:47, Paolo Bonzini wrote: >> >> On 07/11/2018 13:10, Alexander Potapenko wrote: >>> This appears to be a real bug in KVM. >>> Please see a simplified reproducer attached. >> >> Thanks, I agree it's a reael bug. The basic issue

Re: [PATCH v5 03/15] sched/core: uclamp: map TASK's clamp values into CPU's clamp groups

2018-11-07 Thread Peter Zijlstra
On Mon, Oct 29, 2018 at 06:32:57PM +, Patrick Bellasi wrote: > +/** > + * uclamp_group_get: increase the reference count for a clamp group > + * @uc_se: the utilization clamp data for the task > + * @clamp_id: the clamp index affected by the task > + * @clamp_value: the new clamp value for the

Re: [PATCH 1/6] fuse: Change argument of fuse_flush_writepages()

2018-11-07 Thread Miklos Szeredi
On Tue, Nov 6, 2018 at 10:43 AM, Kirill Tkhai wrote: > Next patches introduce fuse_inode::lock, which will be used > in __releases() and __acquires() instead of fc->lock. > This patch makes this function to use argument fuse_inode > instead of inode as preparation for that. This patch seems like

Re: [PATCH v2] slimbus: ngd: QCOM_QMI_HELPERS has to be selected

2018-11-07 Thread Greg KH
On Mon, Oct 15, 2018 at 09:44:41PM +0200, Niklas Cassel wrote: > QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is > to select it, not depend upon it. > > Because of this change, we now also need to depend on the same > Kconfigs as QCOM_QMI_HELPERS depends on. > > Signed-off-by:

Re: Question: perf dso support for /proc/kallsyms

2018-11-07 Thread Jiri Olsa
On Fri, Nov 02, 2018 at 10:55:16AM +0800, leo@linaro.org wrote: > Hi all, > > Now I found that if use the command 'perf script' for Arm CoreSight trace > data, it fails to parse kernel symbols if we don't specify kernel vmlinux > file. So when we don't specify kernel symbol files then perf

Re: [PATCH v5 03/15] sched/core: uclamp: map TASK's clamp values into CPU's clamp groups

2018-11-07 Thread Patrick Bellasi
On 07-Nov 13:19, Peter Zijlstra wrote: > On Mon, Oct 29, 2018 at 06:32:57PM +, Patrick Bellasi wrote: > > +struct uclamp_se { > > + unsigned int value : SCHED_CAPACITY_SHIFT + 1; > > + unsigned int group_id : order_base_2(UCLAMP_GROUPS); > > Are you sure about ob2()

Re: [PATCH 5/6] fuse: Protect fuse_inode::nlookup with fuse_inode::lock

2018-11-07 Thread Miklos Szeredi
On Tue, Nov 6, 2018 at 10:44 AM, Kirill Tkhai wrote: > This continues previous patch and introduces the same > protection for nlookup field. It goes as separate patch > since it's separate logic change (sadly, but it looks > impossible to split previous patch more then in this way). Well, the

Re: [PATCH 6/6] fuse: Verify userspace asks to requeue interrupt that we really sent

2018-11-07 Thread Kirill Tkhai
On 07.11.2018 16:55, Miklos Szeredi wrote: > On Tue, Nov 6, 2018 at 10:31 AM, Kirill Tkhai wrote: >> When queue_interrupt() is called from fuse_dev_do_write(), >> it came from userspace directly. Userspace may pass any >> request id, even the request's we have not interrupted >> (or even

Re: [PATCH] perf script: add newline after uregs output

2018-11-07 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 07, 2018 at 10:37:05AM +0100, Milian Wolff escreveu: > This change makes it much easier to easily distinguish > between consecutive samples by keeping the empty line > between them, like we see when we do not enable uregs > output. Thanks, applied. - Arnaldo

<    1   2   3   4   5   6   7   8   9   10   >