Re: [PATCH v3] string.h: Add str_has_prefix() helper

2018-12-21 Thread Steven Rostedt
On Fri, 21 Dec 2018 16:32:58 -0800 Linus Torvalds wrote: > On Fri, Dec 21, 2018, 16:06 Steven Rostedt > > On Fri, 21 Dec 2018 18:13:16 > > > > And I'll make a separate patch that adds: > > > > static __always_inline bool > > str_has_prefix_len(const char *str, const char *prefix, unsigned int

Re: [PATCH 09/21] PCI: imx6: Drop imx6_pcie_link_up()

2018-12-21 Thread Andrey Smirnov
On Fri, Dec 21, 2018 at 10:55 AM Trent Piepho wrote: > > On Thu, 2018-12-20 at 23:27 -0800, Andrey Smirnov wrote: > > Until commit 4d107d3b5a68 ("PCI: imx6: Move link up check into > > imx6_pcie_wait_for_link()") the driver relied on both LINK_UP and > > LINK_IN_TRAINING to determine if PCIE link

Re: [PATCH] ASoC: Intel: fix unmet dependencies in Kconfig

2018-12-21 Thread Randy Dunlap
On 12/21/18 12:49 PM, Pierre-Louis Bossart wrote: > Remove warnings by selecting SND_HDA_INTEL_DSP_DETECTION_XYZ only when > SND_HDA_INTEL is part of the config. > > Fixes: c337104b1a16 ('ALSA: HD-Audio: SKL+: abort probe if DSP is present and > Skylake driver selected') > Reported-by: Randy

Re: [PATCH] input: drv2667: fix indentation issues, remove extra tabs

2018-12-21 Thread Dmitry Torokhov
On Fri, Dec 21, 2018 at 11:12:41PM +, Colin King wrote: > From: Colin Ian King > > There are some statements that are indented incorrectly, fix this by > removinf the extra tabs. > > Signed-off-by: Colin Ian King Applied, thank you. > --- > drivers/input/misc/drv2667.c | 6 +++--- > 1

Re: [PATCH] touchscreen: elants: fix a missing check of return values

2018-12-21 Thread Dmitry Torokhov
On Fri, Dec 21, 2018 at 03:05:29PM -0600, Kangjie Lu wrote: > Hi Dmitry, > > Thanks for the feedback. > > On Fri, Dec 21, 2018 at 2:27 AM Dmitry Torokhov > wrote: > > > Hi Kangjie, > > > > On Fri, Dec 21, 2018 at 12:59:16AM -0600, Kangjie Lu wrote: > > > elants_i2c_send() may fail, let's check

Re: [v3 PATCH 1/2] mm: swap: check if swap backing device is congested or not

2018-12-21 Thread Yang Shi
On 12/21/18 2:42 PM, Tim Chen wrote: On 12/21/18 1:40 PM, Yang Shi wrote: Swap readahead would read in a few pages regardless if the underlying device is busy or not. It may incur long waiting time if the device is congested, and it may also exacerbate the congestion. Use

Re: [PATCH] x86/speculation: Add document to describe Spectre and its mitigations

2018-12-21 Thread Tim Chen
On 12/21/18 1:59 PM, Ben Greear wrote: > On 12/21/18 9:44 AM, Tim Chen wrote: >> Thomas, >> >> Andi and I have made an update to our draft of the Spectre admin guide. >> We may be out on Christmas vacation for a while.  But we want to >> send it out for everyone to take a look. > > Can you add a

Re: [PATCH v5 1/5] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2018-12-21 Thread Matthias Kaehlcke
On Thu, Dec 20, 2018 at 08:16:35PM +0530, Balakrishna Godavarthi wrote: > wcn3990 requires a power pulse to turn ON/OFF along with > regulators. Sometimes we are observing the power pulses are sent > out with some time delay, due to queuing these commands. This is > causing synchronization issues

Re: [PATH v7 1/2] mailbox: ZynqMP IPI mailbox controller

2018-12-21 Thread Jassi Brar
On Thu, Dec 20, 2018 at 11:32 AM Wendy Liang wrote: > diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c > b/drivers/mailbox/zynqmp-ipi-mailbox.c > new file mode 100644 > index 000..bbddfd5 > --- /dev/null > +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c > @@ -0,0 +1,764 @@ .. > + > +/*

Re: [PATCH] arch/powerpc: Use dma_zalloc_coherent

2018-12-21 Thread Scott Wood
On Thu, 2018-11-15 at 23:26 +0530, Sabyasachi Gupta wrote: > On Mon, Nov 5, 2018 at 7:52 AM Sabyasachi Gupta > wrote: > > > > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent > > > > Signed-off-by: Sabyasachi Gupta > > Any comment on this patch? Just that FSL patches should be

[PATCH] proc: sysctl: fix double drop_sysctl_table()

2018-12-21 Thread Yafang Shao
The callers of insert_header() will drop sysctl table whatever insert_header() successes or fails. So we can't call drop_sysctl_table() in insert_header(). The call sites of insert_header() are all in fs/proc/proc_sysctl.c. Signed-off-by: Yafang Shao --- fs/proc/proc_sysctl.c | 1 - 1 file

[PATCH] x86/efi: Don't unmap EFI boot services code/data regions for EFI_OLD_MEMMAP and EFI_MIXED_MODE

2018-12-21 Thread Sai Praneeth Prakhya
Commit d5052a7130a6 ("x86/efi: Unmap EFI boot services code/data regions from efi_pgd") forgets to take two EFI modes into consideration namely EFI_OLD_MEMMAP and EFI_MIXED_MODE. EFI_OLD_MEMMAP is a legacy way of mapping EFI regions into swapper_pg_dir using ioremap() and init_memory_mapping().

Re: [PATCH 1/1] f2fs: fix validation of the block count in sanity_check_raw_super

2018-12-21 Thread Chao Yu
On 2018/12/22 3:28, Martin Blumenstingl wrote: > Treat "block_count" from struct f2fs_super_block as 64-bit little endian > value in sanity_check_raw_super() because struct f2fs_super_block > declares "block_count" as "__le64". > > This fixes a bug where the superblock validation fails on big

Re: [PATCH] soc: fsl: guts: us devm_kstrdup_const() for RO data

2018-12-21 Thread Scott Wood
On Fri, 2018-12-07 at 09:22 +0100, Nicholas Mc Guire wrote: > devm_kstrdup() may return NULL if internal allocation failed, but > as machine is from the device tree, and thus RO, devm_kstrdup_const() > can be used here, which will only copy the reference. Is it really going to only copy the

Re: [PATCH 1/3] pinctrl: armada-37xx: Correct mpp definitions

2018-12-21 Thread Marek Behun
On Fri, 21 Dec 2018 18:32:57 +0100 Gregory CLEMENT wrote: > + PIN_GRP_GPIO("pcie1", 3, 1, BIT(5), "pcie"), > + PIN_GRP_GPIO("pcie1_clkreq", 4, 1, BIT(9), "pcie"), If the pair is split to clkreq and reset, shouldn't the first be called pcie1_reset? Marek

Re: [PATCH 00/14] Add support for FM radio in hcill and kill TI_ST

2018-12-21 Thread Sebastian Reichel
Hi, On Fri, Dec 21, 2018 at 10:02:05AM -0800, Tony Lindgren wrote: > * Sebastian Reichel [181221 01:18]: > > The new code has been tested on the Motorola Droid 4. For testing the audio > > should be configured to route Ext to Speaker or Headphone. Then you need to > > plug headphone, since its

[GIT PULL] SCSI fixes for 4.20-rc7

2018-12-21 Thread James Bottomley
This is two simple target fixes and one discard related I/O starvation problem in sd. The discard problem occurs because the discard page doesn't have a mempool backing so if the allocation fails due to memory pressure, we then lose the forward progress we require if the writeout is on the same

Re: [PATCH] tty: fix race between flush_to_ldisc and tty_open

2018-12-21 Thread kbuild test robot
Hi Li, Thank you for the patch! Yet something to improve: [auto build test ERROR on tty/tty-testing] [also build test ERROR on v4.20-rc7 next-20181221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH 14/14] misc: ti-st: Drop superseded driver

2018-12-21 Thread Sebastian Reichel
Hi, On Fri, Dec 21, 2018 at 03:10:52PM -0600, Adam Ford wrote: > On Fri, Dec 21, 2018 at 2:13 AM Sebastian Reichel wrote: > > > > From: Sebastian Reichel > > > > This driver has been superseded by the serdev based Bluetooth > > hci_ll driver, which is initialized from DT. All mainline users > >

[PATCH] m68k/mac: Clean up unused timer definitions

2018-12-21 Thread Finn Thain
Signed-off-by: Finn Thain --- arch/m68k/include/asm/macints.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/m68k/include/asm/macints.h b/arch/m68k/include/asm/macints.h index cddb2d3ea49b..4da172bd048c 100644 --- a/arch/m68k/include/asm/macints.h +++

[PATCH] m68k/mac: Skip VIA port setup unless RTC is connected

2018-12-21 Thread Finn Thain
Those Mac models which don't connect their RTC to VIA1 port B probably have something else connected to those pins. Just leave them the way we found them. Make the port B setup conditional on via_type, to match the RTC accessors in arch/m68k/mac/misc.c. Signed-off-by: Finn Thain ---

[PATCH] m68k/mac: Use '030 reset method on SE/30

2018-12-21 Thread Finn Thain
The comment says that calling the ROM routine doesn't work. But testing shows that the 68030 fall-back reset method does work, so just use that. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m68k/mac/misc.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-)

[PATCH] m68k/mac: Remove obsolete comment

2018-12-21 Thread Finn Thain
According to The Guide To Mac Family Hardware, this is the correct way to disable the VBL interrupt. The confusing comment here doesn't add any value so remove it. Signed-off-by: Finn Thain --- arch/m68k/mac/via.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/m68k/mac/via.c

Re: [PATCH] proc: sysctl: fix double drop_sysctl_table()

2018-12-21 Thread Al Viro
On Sat, Dec 22, 2018 at 10:12:21AM +0800, Yafang Shao wrote: > The callers of insert_header() will drop sysctl table whatever > insert_header() successes or fails. > So we can't call drop_sysctl_table() in insert_header(). > > The call sites of insert_header() are all in fs/proc/proc_sysctl.c.

Re: [PATCH v1 08/11] ASoC: Intel: Make PCI dependency explicit

2018-12-21 Thread Randy Dunlap
On 12/21/18 4:14 PM, Sinan Kaya wrote: > IOSF_MBI driver depends on CONFIG_PCI set but this is not specified > anywhere. wrong patch description...? > Signed-off-by: Sinan Kaya > --- > sound/soc/intel/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH] debugfs: remove no need inc_nlink

2018-12-21 Thread yangerkun
Remove inc_nlink in debugfs_create_automount, or this inode will never be free. Signed-off-by: yangerkun --- fs/debugfs/inode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index 13b0135..9e6e225 100644 --- a/fs/debugfs/inode.c +++

Re: [PATCH v4 03/18] memory: mtk-smi: Use a general config_port interface

2018-12-21 Thread Yong Wu
On Fri, 2018-12-21 at 18:47 +0100, Matthias Brugger wrote: > > On 08/12/2018 09:39, Yong Wu wrote: > > The config_port of mt2712 and mt8183 are the same. Use a general > > config_port interface instead. > > > > In addition, in mt2712, larb8 and larb9 are the bdpsys larbs which > > are not the

Re: [PATCH v4 10/18] iommu/mediatek: Add mt8183 IOMMU support

2018-12-21 Thread Yong Wu
On Sat, 2018-12-22 at 08:31 +0800, Nicolas Boichat wrote: > On Fri, Dec 21, 2018 at 4:02 PM Yong Wu wrote: > > > > On Fri, 2018-12-21 at 12:43 +0800, Nicolas Boichat wrote: > > > On Sat, Dec 8, 2018 at 4:42 PM Yong Wu wrote: > > > > > > > > The M4U IP blocks in mt8183 is MediaTek's generation2

Re: [PATCH v4 10/18] iommu/mediatek: Add mt8183 IOMMU support

2018-12-21 Thread Yong Wu
On Fri, 2018-12-21 at 19:31 +0100, Matthias Brugger wrote: > > On 08/12/2018 09:39, Yong Wu wrote: > > The M4U IP blocks in mt8183 is MediaTek's generation2 M4U which use > > the ARM Short-descriptor like mt8173, and most of the HW registers > > are the same. > > > > Here list main differences

<    3   4   5   6   7   8