Re: [PATCH v4 4/6] arm64/kvm: enable pointer authentication cpufeature conditionally

2019-01-04 Thread James Morse
Hi Amit, On 18/12/2018 07:56, Amit Daniel Kachhap wrote: > According to userspace settings, pointer authentication cpufeature > is enabled/disabled from guests. This reads like the guest is changing something in the host. Isn't this hiding the id-register values from the guest? > diff --git a/a

Re: [PATCH v4 6/6] arm/kvm: arm64: Add a vcpu feature for pointer authentication

2019-01-04 Thread James Morse
Hi Amit, On 18/12/2018 07:56, Amit Daniel Kachhap wrote: > This is a runtime feature and can be enabled by --ptrauth option. It took me a little while to realise this was a kvmtool patch. could you put something in the patch-subject to make this obvious? e.g: https://lists.cs.columbia.edu/piperma

[PATCH] USB: musb: fix indentation issue on a return statement

2019-01-04 Thread Colin King
From: Colin Ian King A return statement is indented one level too far, fix this by removing a tab. Signed-off-by: Colin Ian King --- drivers/usb/musb/musb_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c inde

Re: [PATCH v6 07/13] arm64: add basic pointer authentication support

2019-01-04 Thread Mark Rutland
On Fri, Jan 04, 2019 at 10:33:40AM +0100, Pavel Machek wrote: > On Fri 2019-01-04 09:21:30, Marc Zyngier wrote: > > On 03/01/2019 20:29, Pavel Machek wrote: > > > On Fri 2018-12-07 18:39:25, Kristina Martsenko wrote: > > >> From: Mark Rutland > > >> > > >> This patch adds basic support for pointe

Re: [PATCH] mm: Expose lazy vfree pages to control via sysctl

2019-01-04 Thread Matthew Wilcox
On Fri, Jan 04, 2019 at 09:05:41PM +0530, Ashish Mhetre wrote: > From: Hiroshi Doyu > > The purpose of lazy_max_pages is to gather virtual address space till it > reaches the lazy_max_pages limit and then purge with a TLB flush and hence > reduce the number of global TLB flushes. > The default va

Re: [PATCH] Remove 'type' argument from access_ok() function

2019-01-04 Thread Linus Torvalds
On Fri, Jan 4, 2019 at 9:42 AM Guenter Roeck wrote: > > ... and this is just the very first build I happened to try this morning. It will fail for all sparc32 builds. And unlike the powerpc case, I hadn't even noticed this one. Trivial fix for powerpc/sparc32 pushed out. Hopefully that was all o

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-04 Thread Stefano Brivio
On Fri, 4 Jan 2019 18:26:16 +0100 Dmitry Vyukov wrote: > On Fri, Jan 4, 2019 at 6:14 PM Stefano Brivio wrote: > > > > On Fri, 4 Jan 2019 12:05:04 +0100 > > Dmitry Vyukov wrote: > > > > > I've added these as tests: > > > > > > https://github.com/google/syzkaller/blob/master/pkg/report/testdata/l

Re: [PATCH] i2c: mux: demux-pinctrl: use struct_size() in devm_kzalloc()

2019-01-04 Thread Wolfram Sang
> Instead of leaving these open-coded and prone to type mistakes, we can > now use the new struct_size() helper: I am okay with this patch in general. However, I think the name of the helper 'struct_size' is a bit unfortunate. I really wondered on the first read why it needs 3 arguments to find o

Re: [PATCH v6] arm64: implement ftrace with regs

2019-01-04 Thread Steven Rostedt
On Fri, 4 Jan 2019 17:50:18 + Mark Rutland wrote: > At Linux Plumbers, I had a conversation with Steve Rostedt, and we came > to the conclusion that (withut heavyweight synchronization) patching two > NOPs at runtime isn't safe, since a CPU might have executed the first > NOP as a NOP before

Re: [PATCH v2] nvme-pci: fix dbbuf_sq_db point to freed memory

2019-01-04 Thread Christoph Hellwig
On Fri, Dec 21, 2018 at 01:07:25AM +, Lulina (A) wrote: > The case is that nvme device support NVME_CTRL_OACS_DBBUF_SUPP, and > return failed when the driver sent nvme_admin_dbbuf. The nvmeq->dbbuf_sq_db > point to freed memory, as nvme_dbbuf_set is called after nvme_dbbuf_init. But we never u

Re: [PATCH] nvme-pci: fix the wrong setting of nr_maps

2019-01-04 Thread Christoph Hellwig
Thanks, this looks like some sort of merge error. Applied to nvme-4.21.

Re: [PATCH] nvme: pci: Use the same attributes when freeing host_mem_desc_bufs.

2019-01-04 Thread Christoph Hellwig
Thanks, applied to nvme-4.21.

Re: [PATCH] mtd: rawnand: sunxi: Use struct_size() in devm_kzalloc()

2019-01-04 Thread Boris Brezillon
Hi Gustavo, On Fri, 4 Jan 2019 11:26:37 -0600 "Gustavo A. R. Silva" wrote: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > >

[PATCH] IB/core: Use struct_size() in kzalloc()

2019-01-04 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = kzalloc(sizeof(struct foo

[PATCH] mtd: rawnand: marvell: use struct_size() in devm_kzalloc()

2019-01-04 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = devm_kzalloc(dev, sizeof(

Re: [PATCH] mtd: rawnand: sunxi: Use struct_size() in devm_kzalloc()

2019-01-04 Thread Gustavo A. R. Silva
Hey Boris, On 1/4/19 12:14 PM, Boris Brezillon wrote: I posted the same patch a few days back [1]. [1]http://patchwork.ozlabs.org/patch/1013855/ Oh, that's great. It's good to see people adopting the struct_size helper. :) Happy new year. Thanks -- Gustavo

[GIT PULL] arm64: fixes for -rc1

2019-01-04 Thread Will Deacon
Hi Linus, I'm safely chained back up to my desk, so please pull these arm64 fixes for -rc1 that address some issues that cropped up during the merge window. Details in the tag. Cheers, Will --->8 The following changes since commit 12f799c8c739518e12248bbd000eb0a246e8e5f8: arm64: kaslr: pri

Re: tpm_tis TPM2.0 not detected on cold boot

2019-01-04 Thread Michael Niewöhner
On Fri, 2019-01-04 at 16:28 +0100, Michael Niewöhner wrote: > On Fri, 2019-01-04 at 12:58 +0100, Michael Niewöhner wrote: > > On Thu, 2019-01-03 at 16:47 +0100, Michael Niewöhner wrote: > > > On Thu, 2019-01-03 at 17:04 +0200, Jarkko Sakkinen wrote: > > > > On Thu, Jan 03, 2019 at 02:38:11PM +0100,

Re: [PATCH] mm: Expose lazy vfree pages to control via sysctl

2019-01-04 Thread kbuild test robot
Hi Hiroshi, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.20 next-20190103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/comm

Re: [PATCH] mm: Expose lazy vfree pages to control via sysctl

2019-01-04 Thread kbuild test robot
Hi Hiroshi, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.20 next-20190103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/comm

[PATCH] i2c: mux: demux-pinctrl: use struct_size() in devm_kzalloc()

2019-01-04 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = devm_kzalloc(dev, sizeof(

[PATCH 01/16] perf stat: Fix endless wait for child process

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Jin Yao We hit a 'perf stat' issue by using following script: #!/bin/bash sleep 1000 & exec perf stat -a -e cycles -I1000 -- sleep 5 Since "perf stat" is launched by exec, the "sleep 1000" would be the child process of "perf stat". The wait4() call will not return because it's wait

[GIT PULL 00/16] perf/core improvements and fixes

2019-01-04 Thread Arnaldo Carvalho de Melo
kernel/git/acme/linux into perf/urgent (2019-01-03 14:05:16 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.21-20190104 for you to fetch changes up to 03fa483821c0b4db7c2b1453d3332f397d82313f: perf test

[PATCH 04/16] tools beauty: Make the prctl option table generator catch all PR_ options

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo In ba8308856564 ("arm64: add prctl control for resetting ptrauth keys") the PR_PAC_RESET_KEYS prctl option was introduced, get that into the regex in addition to PR_GET_* and PR_SET_*: So just get everything that matches '^#define PR_\w+' this ends up adding these

[PATCH 02/16] tools headers x86: Sync disabled-features.h

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To silence the following tools/perf build warning: Warning: Kernel ABI header at 'tools/arch/x86/include/asm/disabled-features.h' differs from latest version at 'arch/x86/include/asm/disabled-features.h' diff -u tools/arch/x86/include/asm/disabled-features.h

[PATCH 12/16] perf report: Fix wrong iteration count in --branch-history

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Jin Yao By calculating the removed loops, we can get the iteration count. But the iteration count could be reported incorrectly, reporting impossibly high counts. That's because previous code uses the number of removed LBR entries for the iteration count. That's not good. Fix this by incr

[PATCH 07/16] tools headers uapi: Update i915_drm.h

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To get the changes in these csets: fe841686470d Revert "drm/i915/perf: add a parameter to control the size of OA buffer" cd956bfcd0f5 drm/i915/perf: add a parameter to control the size of OA buffer 4bdafb9ddfa4 drm/i915: Remove i915.enable_ppgtt override No

[PATCH 13/16] perf annotate: Pass filename to objdump via execl

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Ivan Krylov The symbol__disassemble() function uses shell to launch objdump and filter its output via grep. Passing filenames by interpolating them into the command line via "%s" may lead to problems if said filenames contain special characters. Instead, pass the filename as a command line

[PATCH 08/16] tools headers uapi: Sync linux/in.h copy from the kernel sources

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To get the changes in this cset: 65cab850f0ee ("net: Allow class-e address assignment via ifconfig ioctl") The macros changed in this cset are not used in tools/, so this is just to silence this perf tools build warning: Warning: Kernel ABI header at 'tools/i

[PATCH 15/16] perf python: Make sure the python binding output directory is in place

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Instead of doing an unconditional mkdir, use a dummy Makefile variable to check if the directory is there and if not, create it. This is better than what we had and will help with other python bindings that are in development, like one involved with python backtrac

[PATCH 14/16] perf strbuf: Remove redundant va_end() in strbuf_addv()

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Mattias Jacobsson <2...@mok.nu> Each call to va_copy() should have one, and only one, corresponding call to va_end(). In strbuf_addv() some code paths result in va_end() getting called multiple times. Remove the superfluous va_end(). Signed-off-by: Mattias Jacobsson <2...@mok.nu> Cc: Jiri O

[PATCH 11/16] tools headers x86: Sync asm/cpufeatures.h copy with the kernel sources

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To get the changes from: a0aea130afeb ("KVM: x86: Add CPUID support for new instruction WBNOINVD") 20c3a2c33e9f ("x86/speculation: Add support for STIBP always-on preferred mode") Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Cc: Paolo Bonzini Cc: Robe

Re: [RFC PATCH 3/3] selftests/vm: add script helper for CONFIG_TEST_VMALLOC_MODULE

2019-01-04 Thread shuah
On 1/3/19 7:21 AM, Uladzislau Rezki (Sony) wrote: Add the test script for the kernel test driver to analyse vmalloc allocator for benchmarking and stressing purposes. It is just a kernel module loader. You can specify and pass different parameters in order to investigate allocations behaviour. Se

[PATCH 16/16] perf test shell: Use a fallback to get the pathname in vfs_getname

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Some kernels, like 4.19.13-300.fc29.x86_64 in fedora 29, fail with the existing probe definition asking for the contents of result->name, working when we ask for the 'filename' variable instead, so add a fallback to that. Now those tests are back working on fedora

[PATCH 09/16] tools headers uapi: Sync linux/kvm.h with the kernel sources

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To get the changes from these csets: 2bc39970e932 ("x86/kvm/hyper-v: Introduce KVM_GET_SUPPORTED_HV_CPUID") 2a31b9db1535 ("kvm: introduce manual dirty log reprotect") That results in these new KVM IOCTLs being supported in 'perf trace' when beautifying the cmd

[PATCH 05/16] tools thermal tmon: Use -O3 instead of -O1 if available

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Using -O3 instead of -O1 if it's supported by compiler. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Brian Norris Cc: Markus Mayer Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Zhang Rui Link: http://lkml.kernel.org/r/20190103161350.11446-2-jo...@kernel.org Signed-off-by:

[PATCH 10/16] tools headers uapi: Sync copy of asm-generic/unistd.h with the kernel sources

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To get the changes in: b7d624ab4312 asm-generic: unistd.h: fixup broken macro include. 4e21565b7fd4 asm-generic: add kexec_file_load system call to unistd.h With this the 'kexec_file_load' syscall will be added to arm64's syscall table and will appear on the o

[PATCH 03/16] tools headers uapi: Sync prctl.h with the kernel sources

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To get the changes in ba8308856564 ("arm64: add prctl control for resetting ptrauth keys"), that introduce a prctl with a name that needs to be catch by the prctl cmd table generator, which will be done in the next cset. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Kristi

[PATCH 06/16] tools iio: Override CFLAGS assignments

2019-01-04 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa So user could specify outside CFLAGS values. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Andy Shevchenko Cc: Hartmut Knaack Cc: Jonathan Cameron Cc: Lars-Peter Clausen Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20190103161350.11446-3-jo...@

Re: [PATCH] mm: kmemleak: Turn kmemleak_lock to spin lock and RCU primitives

2019-01-04 Thread Catalin Marinas
On Fri, Jan 04, 2019 at 10:29:13PM +0800, zhe...@windriver.com wrote: > It's not necessary to keep consistency between readers and writers of > kmemleak_lock. RCU is more proper for this case. And in order to gain better > performance, we turn the reader locks to RCU read locks and writer locks to

Re: [PATCH 07/21] PCI: designware: Make use of IS_ALIGNED()

2019-01-04 Thread Joe Perches
On Wed, 2019-01-02 at 09:33 +, Gustavo Pimentel wrote: > On 21/12/2018 07:27, Andrey Smirnov wrote: > > Make the intent a bit more clear as well as get rid of explicit > > arithmetic by using IS_ALIGNED() to determine if "addr" is aligned to > > "size". No functional change intended. [] > > dif

[PATCH] mm: memcontrol: use struct_size() in kmalloc()

2019-01-04 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = kmalloc(sizeof(struct foo

RE: [PATCH -next] IB/qib: Add missing err handle for qib_user_sdma_rb_insert

2019-01-04 Thread Marciniszyn, Mike
> diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c > b/drivers/infiniband/hw/qib/qib_user_sdma.c > index 31c523b..e87c0a7 100644 > --- a/drivers/infiniband/hw/qib/qib_user_sdma.c > +++ b/drivers/infiniband/hw/qib/qib_user_sdma.c > @@ -237,6 +237,8 @@ qib_user_sdma_queue_create(struct device *

[PATCH] dmaengine: st_fdma: use struct_size() in kzalloc()

2019-01-04 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = kzalloc(sizeof(struct foo

Re: [PATCH] mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush timeout issue

2019-01-04 Thread Ray Jui
On 1/3/2019 7:50 PM, Rayagonda Kokatanur wrote: > RING_CONTROL reg was not written due to wrong address, hence all > the subsequent ring flush was timing out. > > Fixes: a371c10ea4b3 ("mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush > sequence") > > Signed-off-by: Rayagonda Kokatanur > Te

Re: [PATCH] mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush timeout issue

2019-01-04 Thread Florian Fainelli
On 1/3/19 7:50 PM, Rayagonda Kokatanur wrote: > RING_CONTROL reg was not written due to wrong address, hence all > the subsequent ring flush was timing out. > > Fixes: a371c10ea4b3 ("mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush > sequence") > > Signed-off-by: Rayagonda Kokatanur > Tested-

[PATCH] dmaengine: bcm2835: Use struct_size() in kzalloc()

2019-01-04 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = kzalloc(sizeof(struct foo

Re: [PATCH 07/21] PCI: designware: Make use of IS_ALIGNED()

2019-01-04 Thread Andrey Smirnov
On Fri, Jan 4, 2019 at 10:38 AM Joe Perches wrote: > > On Wed, 2019-01-02 at 09:33 +, Gustavo Pimentel wrote: > > On 21/12/2018 07:27, Andrey Smirnov wrote: > > > Make the intent a bit more clear as well as get rid of explicit > > > arithmetic by using IS_ALIGNED() to determine if "addr" is al

Re: [PATCH 1/4] tty: serial: qcom_geni_serial: Remove use of *_relaxed() and mb()

2019-01-04 Thread Evan Green
On Wed, Jan 2, 2019 at 1:37 PM Ryan Case wrote: > > A frequent side comment has been to remove the use of writel_relaxed, > readl_relaxed, and mb. To provide a bit more motivation, you could add something to the effect of "using the _relaxed variant introduces a significant amount of complexity w

Re: [PATCH 2/4] tty: serial: qcom_geni_serial: Remove set_rfr_wm() and related variables

2019-01-04 Thread Evan Green
On Wed, Jan 2, 2019 at 1:37 PM Ryan Case wrote: > > The variables of tx_wm and rx_wm were set to the same define value in > all cases, never updated, and the define was sometimes used > interchangably. Remove the variables/function and use the fixed value. > > Signed-off-by: Ryan Case > --- > >

Re: [PATCH 3/4] tty: serial: qcom_geni_serial: Remove xfer_mode variable

2019-01-04 Thread Evan Green
On Wed, Jan 2, 2019 at 1:37 PM Ryan Case wrote: > > The driver only supports FIFO mode so setting and checking this variable > is unnecessary. If DMA support is ever addedd then such checks can be s/addedd/added/ > introduced. > > Signed-off-by: Ryan Case > --- > > drivers/tty/serial/qcom_geni

Re: [PATCH 4/4] tty: serial: qcom_geni_serial: Use u32 for register variables

2019-01-04 Thread Evan Green
On Wed, Jan 2, 2019 at 1:37 PM Ryan Case wrote: > > Signed-off-by: Ryan Case > --- > > drivers/tty/serial/qcom_geni_serial.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/tty/serial/qcom_geni_serial.c > b/drivers/tty/serial/qcom_geni_s

Re: selftests/bpf doesn't compile

2019-01-04 Thread shuah
Hi Geert, On 1/4/19 10:16 AM, Geert Uytterhoeven wrote: Hi Shuah, CC kbuild, gpio On Thu, Sep 14, 2017 at 5:34 PM Shuah Khan wrote: bpf test depends on clang and fails to compile when -- make -C tools/testing/selftests/bpf run_tests make

[git pull] drm next fixes for rc1

2019-01-04 Thread Dave Airlie
Hi Linus, Happy New Year, just decloaking from leave to get this stuff in before rc1. Some stuff from the last week: core: two regression fixes for damage blob and atomic i915 gvt: Some missed GVT fixes from the original pull amdgpu: new PCI IDs SR-IOV fixes DC fixes Vega20 fixes Dave. drm-ne

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-04 Thread Jacek Anaszewski
Hi Vesa, On 1/4/19 12:19 AM, Vesa Jääskeläinen wrote: Hi Jacek, Comments below. On 04/01/2019 0.05, Jacek Anaszewski wrote: Hi Vesa, Thank you for sharing your ideas. Please find my comment below. On 1/1/19 2:45 PM, Vesa Jääskeläinen wrote: Hi All, On 20/12/2018 14.40, Vesa Jääskeläinen

[PATCH] fs/dax: Convert to use vmf_error()

2019-01-04 Thread Souptick Joarder
This code is converted to use vmf_error(). Signed-off-by: Souptick Joarder --- fs/dax.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/dax.c b/fs/dax.c index 48132ec..ed39161 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(

[PATCH] arm64: dts: stratix10: Add Stratix10 SMMU support

2019-01-04 Thread thor . thayer
From: Thor Thayer Now there are device tree clocks for the ARM64 SMMU, add SMMU support to the Stratix10 Device Tree which includes adding the SMMU node and adding IOMMU stream ids to the SMMU peripherals. Signed-off-by: Thor Thayer --- arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 29 ++

[PATCH] fs/ceph/addr.c: Convert to use vmf_error()

2019-01-04 Thread Souptick Joarder
This code is converted to use vmf_error(). Signed-off-by: Souptick Joarder --- fs/ceph/addr.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 8eade7a..fa2a85d 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -1495,10 +1495,7 @@ sta

[git pull] vfs.git mount.part1

2019-01-04 Thread Al Viro
mount API prereqs. Mostly that's LSM mount options cleanups. One trivial conflict in security/selinux/hooks.c, resolved by taking the variant from this branch - the method has been split, leaving only the part that used to be conditional upon "it's not an internal mount" and check has been

[PATCH v1 3/4] [media] usb: pulse8-cec: Switch to use %ptT

2019-01-04 Thread Andy Shevchenko
Use %ptT instead of open coded variant to print content of time64_t type in human readable format. Cc: Hans Verkuil Signed-off-by: Andy Shevchenko --- drivers/media/usb/pulse8-cec/pulse8-cec.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/media/usb/pulse8-cec/

[PATCH v1 2/4] ARM: bcm2835: Switch to use %ptT

2019-01-04 Thread Andy Shevchenko
Use %ptT instead of open coded variant to print content of time64_t type in human readable format. Signed-off-by: Andy Shevchenko --- drivers/firmware/raspberrypi.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/

[PATCH v1 1/4] lib/vsprintf: Print time64_t in human readable format

2019-01-04 Thread Andy Shevchenko
There are users which print time and date represented by content of time64_t type in human readable format. Instead of open coding that each time introduce %ptT[dt][r] specifier. Few test cases for %ptT specifier has been added as well. Cc: Hans Verkuil Cc: Mathias Nyman Cc: Jonathan Corbet C

[PATCH v1 4/4] usb: host: xhci-tegra: Switch to use %ptT

2019-01-04 Thread Andy Shevchenko
Use %ptT instead of open coded variant to print content of time64_t type in human readable format. Cc: Mathias Nyman Cc: Thierry Reding Cc: Jonathan Hunter Signed-off-by: Andy Shevchenko --- drivers/usb/host/xhci-tegra.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a

Re: [PATCH fieldbus v6 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2019-01-04 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Sven-Van-Asbroeck/Add-Fieldbus-subsystem-support-HMS-Profinet-card/20190104-123600 config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All

Re: [PATCH v4 3/3] i2c: at91: added slave mode support

2019-01-04 Thread kbuild test robot
Hi Juergen, Thank you for the patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v4.20 next-20190103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/

Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent

2019-01-04 Thread Souptick Joarder
On Fri, Jan 4, 2019 at 9:34 PM John Garry wrote: > > On 04/01/2019 15:11, Sabyasachi Gupta wrote: > > On Fri, Jan 4, 2019 at 6:43 PM John Garry wrote: > >> > >> On 04/01/2019 12:48, Sabyasachi Gupta wrote: > >>> On Wed, Dec 19, 2018 at 6:49 PM Sabyasachi Gupta > >>> wrote: > > On Sat,

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-04 Thread Vesa Jääskeläinen
Hi Pavel, On 04/01/2019 1.34, Pavel Machek wrote: Hi! Regarding led_scale_color_elements() - I checked it in GIMP and the results are not satisfactory when increasing brightness. Even if we managed to fix it, the result would not be guaranteed to be the same across all devices. No and they w

[PATCH] vfio_pci: Add local source directory as include

2019-01-04 Thread Laura Abbott
Commit 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] subdriver") introduced a trace.h file in the local directory but missed adding the local include path, resulting in compilation failures with tracepoints: In file included from drivers/vfio/pci/trace.h:102, from

Re: [Letux-kernel] [PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree

2019-01-04 Thread Andreas Kemnade
Hi Marcel, On Fri, 4 Jan 2019 10:07:34 +0100 Marcel Holtmann wrote: > Hi Andreas, > > Btw. I see nothing standing in the way of merging btuart.c driver and > then go from there. Either I dig this out and submit or someone else > does. > > >>> Do you mean this? > >>> htt

Re: [RFC PATCH 0/3] mm: memcontrol: delayed force empty

2019-01-04 Thread Greg Thelen
Yang Shi wrote: > On 1/3/19 11:23 AM, Michal Hocko wrote: >> On Thu 03-01-19 11:10:00, Yang Shi wrote: >>> >>> On 1/3/19 10:53 AM, Michal Hocko wrote: On Thu 03-01-19 10:40:54, Yang Shi wrote: > On 1/3/19 10:13 AM, Michal Hocko wrote: >> [...] >> Is there any reason for your scripts

RE: [PATCH 2/4] arm64: hyperv: Add support for Hyper-V as a hypervisor

2019-01-04 Thread Michael Kelley
From: Marc Zyngier Sent: Thursday, December 13, 2018 3:23 AM > >> As Will said, this isn't a viable option. Please follow SMCCC 1.1. > > > > I'll have to start a conversation with the Hyper-V team about this. > > I don't know why they chose to use HVC #1 or this register scheme > > for output va

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-04 Thread Pavel Machek
Hi! > >I suppose if one would just make it an array of values (separated by > >space) and then one file with string array of color element names and on > >file with maximum value array it could be within those words. > > > >The it would be something like: > > > >$ echo "23 54 32" > color > > Go a

Re: [PATCH] fork, memcg: fix cached_stacks case

2019-01-04 Thread Rik van Riel
On Wed, 2019-01-02 at 10:01 -0800, Shakeel Butt wrote: > Commit 5eed6f1dff87 ("fork,memcg: fix crash in free_thread_stack on > memcg charge fail") fixes a crash caused due to failed memcg charge > of > the kernel stack. However the fix misses the cached_stacks case which > this patch fixes. So, the

Re: [PATCH v3] mm/page_owner: fix for deferred struct page init

2019-01-04 Thread Qian Cai
On 1/4/19 10:32 AM, Michal Hocko wrote: > On Fri 04-01-19 10:25:12, Qian Cai wrote: >> On 1/4/19 10:17 AM, Michal Hocko wrote: >>> On Fri 04-01-19 10:01:40, Qian Cai wrote: On 1/4/19 8:09 AM, Michal Hocko wrote: >> Here is the number without DEFERRED_STRUCT_PAGE_INIT. >> >> == page

[PATCH RT] rtmutex: Flush block plug on __down_read()

2019-01-04 Thread Scott Wood
__down_read() bypasses the rtmutex frontend to call rt_mutex_slowlock_locked() directly, and thus it needs to call blk_schedule_flush_flug() itself. Signed-off-by: Scott Wood --- kernel/locking/rwsem-rt.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/kernel/locking/rwsem-rt.c b

Re: [f2fs-dev] [PATCH] f2fs: export pin_file flag to user

2019-01-04 Thread Jaegeuk Kim
On 01/04, Chao Yu wrote: > On 2019/1/4 12:19, Jaegeuk Kim wrote: > > This exports pin_file status to user. > > Semantics of pin_file flag is the same as nocow flag which is more widely > used in lsattr/chattr and vfs now. > > #define FS_NOCOW_FL 0x0080 /* Do not cow file *

Re: [PATCH v2] f2fs: fix sbi->extent_list corruption issue

2019-01-04 Thread Jaegeuk Kim
On 01/04, Sahitya Tummala wrote: > On Mon, Nov 26, 2018 at 10:17:20AM +0530, Sahitya Tummala wrote: > > When there is a failure in f2fs_fill_super() after/during > > the recovery of fsync'd nodes, it frees the current sbi and > > retries again. This time the mount is successful, but the files > > t

Re: [alsa-devel] ALSA:usb audio Higher sample rates on usb audio no longer working.

2019-01-04 Thread Con Kolivas
Hi Saranya. On Sat, 5 Jan 2019 at 03:52, Gopal, Saranya wrote: > And since I was not part of the initial mail thread, I might have missed some > information. > Could someone give me lsusb -v output for this USB audio device. These outputs are with the UAC3 patch backed out: dmesg: [50384.8594

Re: [f2fs-dev] [PATCH 1/2] f2fs: wait on atomic writes to count F2FS_CP_WB_DATA

2019-01-04 Thread Jaegeuk Kim
On 01/04, Chao Yu wrote: > On 2019/1/4 12:20, Jaegeuk Kim wrote: > > Otherwise, we can get wrong counts incurring checkpoint hang. > > > > IO_W (CP: -24, Data: 24, Flush: ( 001), Discard: ( 00)) > > > > Cc: > > Signed-off-by: Jaegeuk Kim > > Good catch! ;) > > I can underst

Re: [PATCH v2 01/12] fs-verity: add a documentation file

2019-01-04 Thread Daniel Colascione
On Sat, Dec 22, 2018 at 8:46 PM Theodore Y. Ts'o wrote: > > On Sat, Dec 22, 2018 at 08:10:07PM -0800, Matthew Wilcox wrote: > > Pretty much every file format has the ability to put arbitrary blocks > > of information into a file somewhere the tools which don't know about > > it will skip it. For

[PATCH] ASoC: rt274: Variable "buf" in function rt274_jack_detect() could be uninitialized

2019-01-04 Thread Yizhuo
In function rt274_jack_detect(), local variable "buf" could be uninitialized if function regmap_read() returns -EINVAL. However, it will be used to calculate "hp" and "mic" and make their value unpredictable while those value are used in the caller. This is potentially unsafe. Signed-off-by: Yizhu

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-04 Thread Pavel Machek
Hi! > >And... LEDs are linear-enough as it is. That is not a problem. But RGB > >does _not_ expect linear response. That's why colors are _way_ off currently. > > Example what I was given was some LEDs are off for let's say 20% of PWM > linearity and then there is non-linear curve for PWM value v

Re: [PATCH v2] f2fs: export FS_NOCOW_FL flag to user

2019-01-04 Thread Jaegeuk Kim
This exports pin_file status to user. Signed-off-by: Jaegeuk Kim --- v2: - use F2FS_NOCOW_FL (aka FS_NOCOW_FL) fs/f2fs/f2fs.h | 3 ++- fs/f2fs/file.c | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 12fabd6735dd..9286ec381453 100644 --

Re: [PATCH] octeontx2-af: Fix a resource leak in an error handling path in 'cgx_probe()'

2019-01-04 Thread David Miller
From: Christophe JAILLET Date: Sat, 29 Dec 2018 17:42:22 +0100 > If an error occurs after the call to 'pci_alloc_irq_vectors()', we must > call 'pci_free_irq_vectors()' in order to avoid a resource leak. > > The same sequence is already in place in the corresponding 'cgx_remove()' > function

Re: [PATCH] r8169: Add support for new Realtek Ethernet

2019-01-04 Thread David Miller
From: Kai-Heng Feng Date: Wed, 2 Jan 2019 14:45:07 +0800 > There are two new Realtek Ethernet devices which are re-branded r8168h. > Add the IDs to to support them. > > Signed-off-by: Kai-Heng Feng Applied.

Re: [RESEND PATCH v5] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

2019-01-04 Thread David Miller
From: Peng Hao Date: Thu, 3 Jan 2019 01:09:53 +0800 > From: Wen Yang > > Currently there are some issues with the ucc_of_parse_tdm function: > 1, a possible null pointer dereference in ucc_of_parse_tdm, > detected by the semantic patch deref_null.cocci, > with the following warning: > drivers/s

Re: [PATCH] ASoC: rt5677: use more of the volume range from DACs

2019-01-04 Thread Ross Zwisler
On Thu, Dec 20, 2018 at 04:25:55PM -0700, Ross Zwisler wrote: > From: Dylan Reid > > The DACs volume can go over 0, both according to the data sheet and > real world testing. The control can go up to +30dB. > > This was tested by playing audio at full volume on a samus chromebook. > > Signed-o

Re: [patch] net, skbuff: do not prefer skb allocation fails early

2019-01-04 Thread David Miller
From: David Rientjes Date: Wed, 2 Jan 2019 13:01:43 -0800 (PST) > Commit dcda9b04713c ("mm, tree wide: replace __GFP_REPEAT by > __GFP_RETRY_MAYFAIL with more useful semantic") replaced __GFP_REPEAT in > alloc_skb_with_frags() with __GFP_RETRY_MAYFAIL when the allocation may > directly reclaim.

Re: [PATCH net 0/4] net: bpfilter: fix two bugs in bpfilter

2019-01-04 Thread David Miller
From: Taehee Yoo Date: Mon, 31 Dec 2018 01:30:45 +0900 > This patches fix two bugs in the bpfilter_umh which are related in > iptables command. ... I am still thinking about these patches, sorry for taking so long to give a response. Thank you.

Re: [PATCH v3 3/3] arm64: Early boot time stamps

2019-01-04 Thread Pavel Tatashin
> > sched_clock() will still be strictly monotonic. During switch over we > > will guarantee to continue from where the early clock left. > > Not quite. There is at least one broken integration that results in > large, spurious jumps ahead. If one of these jumps happens during the > "unstable" phas

[PATCH 0/8 v2] k3dma patches to add support for hi3660/HiKey960

2019-01-04 Thread John Stultz
This patch series is based on recent work by Tanglei Han, and adds support for hi3660 SoCs as found on the HiKey960 board, along with a few patches I've been carrying. Review and feedback would be greatly appreciated! thanks -john Cc: Tanglei Han Cc: Zhuangluan Su Cc: Dan Williams Cc: Vinod K

[PATCH 4/8 v2] dma: k3dma: Delete axi_config

2019-01-04 Thread John Stultz
From: Li Yu Axi_config controls whether DMA resources can be accessed in non-secure mode, such as linux kernel. The register should be set by the bootloader stage and depends on the device. Thus, this patch removes axi_config from k3dma driver. Cc: Dan Williams Cc: Vinod Koul Cc: Tanglei Han

[PATCH 7/8 v2] arm64: dts: hi3660: Add hisi asp dma device

2019-01-04 Thread John Stultz
From: Youlin Wang Add asp-dma device to hi3660 dts Cc: Tanglei Han Cc: Zhuangluan Su Cc: Ryan Grachek Cc: Manivannan Sadhasivam Cc: Wei Xu Cc: Rob Herring Cc: Mark Rutland Cc: linux-arm-ker...@lists.infradead.org Cc: devicet...@vger.kernel.org Signed-off-by: Youlin Wang Signed-off-by: Ta

[PATCH 6/8 v2] arm64: dts: hi3660: Add dma to uart nodes

2019-01-04 Thread John Stultz
Try to add DMA support to the uart nodes following the assignments made in the dts from the victoria vendor kernel here: https://consumer.huawei.com/en/opensource/detail/?siteCode=worldwide&keywords=p10&fileType=openSourceSoftware&pageSize=10&curPage=1 Cc: Tanglei Han Cc: Zhuangluan Su Cc: Ryan

[PATCH 5/8 v2] dma: k3dma: Add support to dma_avail_chan

2019-01-04 Thread John Stultz
From: Li Yu dma_avail_chan as a property for k3dma, it defines available dma channels which a non-secure mode driver can use. One sample usage of this is in Hi3660 SoC. DMA channel 0 is reserved to lpm3, which is a coprocessor for power management. So as a result, any request in kernel (which ru

[PATCH 3/8 v2] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware

2019-01-04 Thread John Stultz
From: Youlin Wang There is an new "hisi-pcm-asp-dma-1.0" device added in "arch/arm64/boot/dts/hisilicon/hi3660.dtsi". So we have to add a matching id in the driver file: .compatible = "hisilicon,hisi-pcm-asp-dma-1.0" And also hisi-pcm-asp dma device needs no setting to the clock. So we skip thi

[PATCH 2/8 v2] Documentation: bindings: k3dma: Add binding for dma-avail-chan

2019-01-04 Thread John Stultz
Some dma channels can be reserved for secure mode or other hardware on the SoC, so provide a binding for a bitmask listing the available channels for the kernel to use. Cc: Vinod Koul Cc: Rob Herring Cc: Mark Rutland Cc: Tanglei Han Cc: Zhuangluan Su Cc: Ryan Grachek Cc: Manivannan Sadhasiva

[PATCH 8/8 v2] arm64: dts: hi3660: Fixup unofficial dma-min-chan to dma-avail-chan

2019-01-04 Thread John Stultz
A undocumented and unimplemented binding got into the hi3660 dtsi, and this switches that binding to the now documented one. Cc: Tanglei Han Cc: Zhuangluan Su Cc: Ryan Grachek Cc: Manivannan Sadhasivam Cc: Wei Xu Cc: Rob Herring Cc: Mark Rutland Cc: linux-arm-ker...@lists.infradead.org Cc:

[PATCH 1/8 v2] Documentation: bindings: k3dma: Extend the k3dma driver binding to support hisi-asp

2019-01-04 Thread John Stultz
From: Youlin Wang Extend the k3dma driver binding to support hisi-asp hardware variants. Cc: Vinod Koul Cc: Rob Herring Cc: Mark Rutland Cc: Zhuangluan Su Cc: Tanglei Han Cc: Ryan Grachek Cc: Manivannan Sadhasivam Cc: dmaeng...@vger.kernel.org Cc: devicet...@vger.kernel.org Signed-off-by:

Re: [PATCH] net: macb: remove unnecessary code

2019-01-04 Thread David Miller
From: Date: Thu, 3 Jan 2019 14:59:35 + > From: Claudiu Beznea > > Commit 653e92a9175e ("net: macb: add support for padding and fcs > computation") introduced a bug fixed by commit 899ecaedd155 ("net: > ethernet: cadence: fix socket buffer corruption problem"). Code removed > in this patch i

  1   2   3   4   5   6   7   >