Re: [PATCH v1] dmaengine: imx-sdma: refine to load context only once

2019-01-04 Thread Vinod Koul
On 06-12-18, 06:36, Robin Gong wrote: > The context loaded only one time before channel running,but ^^ space after comma please > currently sdma_config_channel() and dma_prep_* duplicated with > sdma_load_context(), so refine it to load

Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent

2019-01-04 Thread Sabyasachi Gupta
On Fri, Jan 4, 2019 at 6:43 PM John Garry wrote: > > On 04/01/2019 12:48, Sabyasachi Gupta wrote: > > On Wed, Dec 19, 2018 at 6:49 PM Sabyasachi Gupta > > wrote: > >> > >> On Sat, Dec 1, 2018 at 6:40 PM Sabyasachi Gupta > >> wrote: > >>> > >>> On Wed, Nov 21, 2018 at 7:18 PM Sabyasachi Gupta >

Re: [PATCHv3 1/2] mm/memblock: extend the limit inferior of bottom-up after parsing hotplug attr

2019-01-04 Thread Mike Rapoport
On Thu, Jan 03, 2019 at 10:47:06AM -0800, Tejun Heo wrote: > Hello, > > On Wed, Jan 02, 2019 at 07:05:38PM +0200, Mike Rapoport wrote: > > I agree that currently the bottom-up allocation after the kernel text has > > issues with KASLR. But this issues are not necessarily related to the > > memory

Re: [PATCH v5 05/11] platform/x86: intel_pmc: Make PCI dependency explicit

2019-01-04 Thread Sinan Kaya
On 1/4/2019 9:20 AM, Andy Shevchenko wrote: Unfortunately, this is not how it should be fixed. First of all, we (Heikki, Sathya, me — all in Cc list) that this driver should be refactored and unified with intel_scu_ipc. Then, it has two drivers inside and PCI is just a glue for it which is

Re: [PATCH] riscv: remove redundant kernel-space generic-y

2019-01-04 Thread Masahiro Yamada
On Fri, Jan 4, 2019 at 11:16 AM Palmer Dabbelt wrote: > > On Sun, 16 Dec 2018 06:11:11 PST (-0800), yamada.masah...@socionext.com wrote: > > This commit removes redundant generic-y defines in > > arch/riscv/include/asm/Kbuild. > > > > [1] It is redundant to define the same generic-y in both > >

Re: [PATCH v3] mm/page_owner: fix for deferred struct page init

2019-01-04 Thread Qian Cai
On 1/4/19 8:09 AM, Michal Hocko wrote: >> Here is the number without DEFERRED_STRUCT_PAGE_INIT. >> >> == page_ext_init() after page_alloc_init_late() == >> Node 0, zone DMA: page owner found early allocated 0 pages >> Node 0, zone DMA32: page owner found early allocated 7009 pages >> Node 0, zone

Re: [PATCH v6 1/7] dmaengine: xilinx_dma: commonize DMA copy size calculation

2019-01-04 Thread Vinod Koul
On 20-11-18, 16:31, Andrea Merello wrote: > This patch removes a bit of duplicated code by introducing a new > function that implements calculations for DMA copy size, and > prepares for changes to the copy size calculation that will > happen in following patches. Applied all, thanks -- ~Vinod

Re: [PATCH ghak90 (was ghak32) V4 01/10] audit: collect audit task parameters

2019-01-04 Thread Richard Guy Briggs
On 2019-01-03 18:50, Guenter Roeck wrote: > Hi Richard, > > On Tue, Jul 31, 2018 at 04:07:36PM -0400, Richard Guy Briggs wrote: > > The audit-related parameters in struct task_struct should ideally be > > collected together and accessed through a standard audit API. > > > > Collect the existing

Re: [PATCH v2 1/7] sysfs/cpu: Add "Unknown" vulnerability state

2019-01-04 Thread Will Deacon
On Fri, Jan 04, 2019 at 03:18:05PM +0100, Greg Kroah-Hartman wrote: > On Fri, Jan 04, 2019 at 02:08:32PM +, Dave Martin wrote: > > On Thu, Jan 03, 2019 at 05:48:31PM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Jan 03, 2019 at 10:38:16AM -0600, Jeremy Linton wrote: > > > > On 01/03/2019

Re: [PATCH 1/4] pmbus: associate PMBUS_SKIP_STATUS_CHECK with driver_data

2019-01-04 Thread Guenter Roeck
On 1/4/19 12:55 AM, Xiaoting Liu wrote: Current code compares device name with name in i2c_device_id to decide whether PMBUS_SKIP_STATUS_CHECK should be set in pmbus_platform_data, which makes adding new devices with PMBUS_SKIP_STATUS_CHECK should also modify code in pmbus_probe(). This patch

[GIT PULL] chrome-platform updates for v4.21

2019-01-04 Thread Benson Leung
Hi Linus, Happy new year. Sorry for the late in the window pull request, but here are the updates for chrome-platform. Mainly a maintainership change, and a pair of patches from Brian to fixup wakeup handling for one kind of EC event. The following changes since commit

Re: [PATCH] dmaengine: fix dmaengine_desc_callback_valid() doesn't check for callback_result

2019-01-04 Thread Vinod Koul
On 16-11-18, 14:56, Andrea Merello wrote: > There are two flavors of DMA completion callbacks: callback() and > callback_result(); the latter takes an additional parameter that carries > result information. > > Most dmaengine helper functions that work with callbacks take care of both > flavors

Re: (Audio/Video): The Truth about Linux GPLv2 and license recission (revocation).

2019-01-04 Thread Ivan Ivanov
Sadly your informative videos deleted (by NSA?), could you please reupload? This could be useful for removing your source code if you disagree with Cock of Conduct пт, 4 янв. 2019 г. в 16:04, : > > Information regarding the rights of the linux programmers, regarding > rescission (revocation) of

[PATCH] regulator: act8945a: Use rdev_get_id() to access id of regulator

2019-01-04 Thread Axel Lin
Use rdev_get_id() instead of directly access rdev->desc->id. Signed-off-by: Axel Lin --- drivers/regulator/act8945a-regulator.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/act8945a-regulator.c b/drivers/regulator/act8945a-regulator.c index

Re: [PATCH 4/4] pmbus (dps650ab): add power supply driver

2019-01-04 Thread Guenter Roeck
On 1/4/19 1:05 AM, Xiaoting Liu wrote: The Delta dps650ab provides main power and standby power to server. dps650ab can be detected by MFR_ID and MFR_MODEL referring to manufacturer's feedback. This patch adds driver to moniter power supply status. Signed-off-by: Xiaoting Liu ---

Re: [PATCH] dmaengine: qcom_hidma: Check for driver register failure

2019-01-04 Thread Vinod Koul
On 28-12-18, 14:11, Aditya Pakki wrote: > While initializing the driver, the function platform_driver_register can > fail and return an error. Consistent with other invocations, this patch > returns the error upstream. Applied, thanks -- ~Vinod

Re: [PATCH] dma/mv_xor: Fix a missing check in mv_xor_channel_add

2019-01-04 Thread Vinod Koul
On 24-12-18, 11:41, Aditya Pakki wrote: > dma_async_device_register() may fail and return an error. The capabilities > checked in mv_xor_channel_add() are not complete. The fix handles the > error by freeing the resources. Applied after fixing subsystem tag, thanks -- ~Vinod

Re: [PATCH] dmaengine: stm32-mdma: Add a check on read_u32_array

2019-01-04 Thread Vinod Koul
On 28-12-18, 13:26, Aditya Pakki wrote: > In stm32_mdma_probe, after reading the property "st,ahb-addr-masks", the > second call is not checked for failure. This time of check to time of use > case of "count" error is sent upstream. Applied, thanks -- ~Vinod

[PATCH] mm: kmemleak: Turn kmemleak_lock to spin lock and RCU primitives

2019-01-04 Thread zhe.he
From: He Zhe It's not necessary to keep consistency between readers and writers of kmemleak_lock. RCU is more proper for this case. And in order to gain better performance, we turn the reader locks to RCU read locks and writer locks to normal spin locks. "time echo scan >

Re: [PATCH v5 06/11] platform/x86: apple-gmux: Make PCI dependency explicit

2019-01-04 Thread Andy Shevchenko
On Fri, Jan 4, 2019 at 4:12 PM Andy Shevchenko wrote: > > On Wed, Jan 2, 2019 at 8:10 PM Sinan Kaya wrote: > > > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > > satisfied implicitly through

Re: [PATCH v5 05/11] platform/x86: intel_pmc: Make PCI dependency explicit

2019-01-04 Thread Andy Shevchenko
On Wed, Jan 2, 2019 at 8:10 PM Sinan Kaya wrote: > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. Code relies on

[PATCH] hv_balloon: avoid touching uninitialized struct page during tail onlining

2019-01-04 Thread Vitaly Kuznetsov
Hyper-V memory hotplug protocol has 2M granularity and in Linux x86 we use 128M. To deal with it we implement partial section onlining by registering custom page onlining callback (hv_online_page()). Later, when more memory arrives we try to online the 'tail' (see hv_bring_pgs_online()). It was

Re: [PATCH v2 1/7] sysfs/cpu: Add "Unknown" vulnerability state

2019-01-04 Thread Greg Kroah-Hartman
On Fri, Jan 04, 2019 at 02:08:32PM +, Dave Martin wrote: > On Thu, Jan 03, 2019 at 05:48:31PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Jan 03, 2019 at 10:38:16AM -0600, Jeremy Linton wrote: > > > On 01/03/2019 03:38 AM, Greg Kroah-Hartman wrote: > > > > On Wed, Jan 02, 2019 at 06:49:15PM

RE: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2019-01-04 Thread Anurag Kumar Vulisha
Hi Felipe, Resending... Since I am waiting on your suggestion, thought of giving remainder. Thanks, Anurag Kumar Vulisha >-Original Message- >From: Anurag Kumar Vulisha >Sent: Wednesday, December 12, 2018 8:41 PM >To: 'Alan Stern' ; Felipe Balbi >Cc: Greg Kroah-Hartman ; Shuah Khan

Re: [PATCH v5 04/11] platform/x86: intel_ips: make PCI dependency explicit

2019-01-04 Thread Andy Shevchenko
On Wed, Jan 2, 2019 at 8:10 PM Sinan Kaya wrote: > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. Ipss driver is

Re: [PATCH v5] arm64: implement ftrace with regs

2019-01-04 Thread Torsten Duwe
On Mon, Dec 17, 2018 at 09:52:04AM +0530, Amit Daniel Kachhap wrote: > There is no error message or crash but no useful output like below, > > /sys/kernel/tracing # echo wake_up_process > set_graph_function > /sys/kernel/tracing # echo function_graph > current_tracer > /sys/kernel/tracing # cat

Re: [PATCH v5 06/11] platform/x86: apple-gmux: Make PCI dependency explicit

2019-01-04 Thread Andy Shevchenko
On Wed, Jan 2, 2019 at 8:10 PM Sinan Kaya wrote: > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. This driver

[PATCH v6] arm64: implement ftrace with regs

2019-01-04 Thread Torsten Duwe
Use -fpatchable-function-entry (gcc8) to add 2 NOPs at the beginning of each function. Replace the first NOP thus generated with a quick LR saver (move it to scratch reg x9), so the 2nd replacement insn, the call to ftrace, does not clobber the value. Ftrace will then generate the standard stack

Re: [PATCH v2 1/7] sysfs/cpu: Add "Unknown" vulnerability state

2019-01-04 Thread Dave Martin
On Thu, Jan 03, 2019 at 05:48:31PM +0100, Greg Kroah-Hartman wrote: > On Thu, Jan 03, 2019 at 10:38:16AM -0600, Jeremy Linton wrote: > > On 01/03/2019 03:38 AM, Greg Kroah-Hartman wrote: > > > On Wed, Jan 02, 2019 at 06:49:15PM -0600, Jeremy Linton wrote: > > > > There is a lot of variation in the

Applied "ASoC: xlnx: add pcm formatter platform driver" to the asoc tree

2019-01-04 Thread Mark Brown
The patch ASoC: xlnx: add pcm formatter platform driver has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent

Applied "ASoC: rockchip: fix platform_no_drv_owner.cocci warnings" to the asoc tree

2019-01-04 Thread Mark Brown
The patch ASoC: rockchip: fix platform_no_drv_owner.cocci warnings has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours)

Applied "ASoC: rockchip: support ACODEC for rk3328" to the asoc tree

2019-01-04 Thread Mark Brown
The patch ASoC: rockchip: support ACODEC for rk3328 has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to

Applied "ASoC: rockchip: add workaround for silence of rk3288 ACODEC" to the asoc tree

2019-01-04 Thread Mark Brown
The patch ASoC: rockchip: add workaround for silence of rk3288 ACODEC has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24

Re: [PATCH] tty/n_hdlc: fix sleep in !TASK_RUNNING state warning

2019-01-04 Thread Paul Fulghum
> On Jan 4, 2019, at 2:23 AM, Tetsuo Handa > wrote: > > But why not to clarify what are appropriate sanity checks? > ... > want a cleanup for scripts/checkpatch.pl . These are good goals. I avoid purely cosmetic patches. I do not object to cosmetic patches from others that do not change

Re: [PATCH] Variable "val" in function rt274_i2c_probe() could be uninitialized

2019-01-04 Thread Mark Brown
On Thu, Jan 03, 2019 at 01:59:12PM -0800, Yizhuo wrote: > Inside function rt274_i2c_probe(), if regmap_read() function > returns -EINVAL, then local variable "val" leaves uninitialized > but used in if statement. This is potentially unsafe. Please use subject lines matching the style for the

[PATCH 1/2] mailbox: mailbox-test: fix debugfs in multi-instances

2019-01-04 Thread Fabien Dessenne
Create one debug entry directory per instance to support the multi instantiation. Signed-off-by: Ludovic Barre Signed-off-by: Fabien Dessenne --- drivers/mailbox/mailbox-test.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mailbox/mailbox-test.c

[PATCH 2/2] mailbox: stm32-ipcc: remove useless device_init_wakeup call

2019-01-04 Thread Fabien Dessenne
If the "wakeup-source" property does not exist there is no need to call device_init_wakeup("false") at probe. Signed-off-by: Fabien Dessenne --- drivers/mailbox/stm32-ipcc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mailbox/stm32-ipcc.c b/drivers/mailbox/stm32-ipcc.c index

[PATCH 1/2] mailbox: stm32-ipcc: do not enable wakeup source by default

2019-01-04 Thread Fabien Dessenne
By default do not enable the wakeup source. This lets the userspace application decide whether the wakeup source shall be enabled or not. Signed-off-by: Fabien Dessenne --- drivers/mailbox/stm32-ipcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: NULL pointer dereference when writing fuzzed data to /dev/uhid

2019-01-04 Thread Anatoly Trosinenko
> I wanted to tell you that I started investigating the other private > report you sent us, but couldn't find the time to properly come with a > fix as the fuzzed data is hard to discriminate from valid data. Oops, I thought I was "over securing" these issues and everyone ignored them since I

[PATCH 2/2] mailbox: mailbox-test: fix null pointer if no mmio

2019-01-04 Thread Fabien Dessenne
Fix null pointer issue if resource_size is called with no ioresource. Signed-off-by: Ludovic Barre Signed-off-by: Fabien Dessenne --- drivers/mailbox/mailbox-test.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/mailbox/mailbox-test.c

Re: [PATCH v4 00/10] steal tasks to improve CPU utilization

2019-01-04 Thread Shijith Thotton
On 07-Dec-18 3:09 AM, Steve Sistare wrote: > > When a CPU has no more CFS tasks to run, and idle_balance() fails to > find a task, then attempt to steal a task from an overloaded CPU in the > same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently > identify candidates. To minimize

Re: [PATCH v4 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2019-01-04 Thread Sergei Shtylyov
Hello! On 01/03/2019 09:35 AM, masonccy...@mxic.com.tw wrote: [...] >> >> > +#define RPC_CMNCR_MOIIO3(val) (((val) & 0x3) << 22) >> >> > +#define RPC_CMNCR_MOIIO2(val) (((val) & 0x3) << 20) >> >> > +#define RPC_CMNCR_MOIIO1(val) (((val) & 0x3) << 18) >> >> > +#define RPC_CMNCR_MOIIO0(val)

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2019-01-04 Thread Shijith Thotton
On 22-Oct-18 8:40 PM, Steve Sistare wrote: > > When a CPU has no more CFS tasks to run, and idle_balance() fails to > find a task, then attempt to steal a task from an overloaded CPU in the > same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently > identify candidates. To minimize

Re: [PATCH] irqchip: madera: Drop GPIO includes

2019-01-04 Thread Richard Fitzgerald
On 03/01/19 10:26, Linus Walleij wrote: This irqchip does not use anything GPIO-related so drop the GPIO includes. An older version did some stuff with GPIOs but when that code was removed this include obviously was forgotten. Cc: Richard Fitzgerald Signed-off-by: Linus Walleij ---

Re: [PATCH] ARM: mach-s3c24xx: Fix boolean expressions in osiris_dvs_notify

2019-01-04 Thread Krzysztof Kozlowski
On Thu, 3 Jan 2019 at 21:46, Gustavo A. R. Silva wrote: > > Fix boolean expressions by using logical AND operator '&&' > instead of bitwise operator '&'. > > This issue was detected with the help of Coccinelle. > > Fixes: 4fa084af28ca ("ARM: OSIRIS: DVS (Dynamic Voltage Scaling) supoort.") > Cc:

Re: Column for keywords?

2019-01-04 Thread Dmitry Vyukov
On Fri, Jan 4, 2019 at 2:01 PM Dmitry Vyukov wrote: > > On Wed, May 16, 2018 at 6:50 PM Tetsuo Handa > wrote: > > > > Dmitry Vyukov wrote: > > > On Tue, May 15, 2018 at 10:59 PM, Tetsuo Handa > > > wrote: > > > > Dmitry Vyukov wrote: > > > >> I've filed

Re: NULL pointer dereference when writing fuzzed data to /dev/uhid

2019-01-04 Thread Benjamin Tissoires
Hi Anatoly, On Fri, Jan 4, 2019 at 1:32 PM Anatoly Trosinenko wrote: > > Hello, > > When writing the attached file to /dev/uhid, a NULL dereference occurs > in kernel. As I understand, the problem is not UHID-specific, but is > related to HID subsystem. Thanks for the report. I wanted to tell

Re: [PATCH] netfilter: account ebt_table_info to kmemcg

2019-01-04 Thread Michal Hocko
On Thu 03-01-19 12:52:54, Shakeel Butt wrote: > On Mon, Dec 31, 2018 at 2:12 AM Michal Hocko wrote: > > > > On Sun 30-12-18 19:59:53, Shakeel Butt wrote: > > > On Sun, Dec 30, 2018 at 12:00 AM Michal Hocko wrote: > > > > > > > > On Sun 30-12-18 08:45:13, Michal Hocko wrote: > > > > > On Sat

Re: [PATCH v5 10/15] KVM: s390: add functions to (un)register GISC with GISA

2019-01-04 Thread Cornelia Huck
On Wed, 2 Jan 2019 18:29:00 +0100 Pierre Morel wrote: > On 19/12/2018 20:17, Michael Mueller wrote: > > Add the IAM (Interruption Alert Mask) to the architecture specific > > kvm struct. This mask in the GISA is used to define for which ISC > > a GIB alert can be issued. > > > > The functions

Re: [PATCH v4] selftests: add headers_install to lib.mk

2019-01-04 Thread Geert Uytterhoeven
Hi Anders, On Wed, Aug 8, 2018 at 12:46 PM Anders Roxell wrote: > On Tue, 7 Aug 2018 at 04:33, Masahiro Yamada > wrote: > > 2018-08-07 2:03 GMT+09:00 Shuah Khan : > > > On 07/25/2018 10:08 AM, Anders Roxell wrote: > > >> On Tue, 24 Jul 2018 at 19:11, Shuah Khan wrote: > > >>> On 07/23/2018

Re: [PATCH] drm/tegra: hdmi: Fix audio to work with any pixel clock rate

2019-01-04 Thread Thierry Reding
On Wed, Dec 14, 2016 at 06:20:39PM +0100, Alban Bedel wrote: > The audio setting implementation was limited to a few specific pixel > clocks. This prevented HDMI audio from working on several test devices > as they need a pixel clock that is not supported by this implementation. > > Fix this by

Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent

2019-01-04 Thread John Garry
On 04/01/2019 12:48, Sabyasachi Gupta wrote: On Wed, Dec 19, 2018 at 6:49 PM Sabyasachi Gupta wrote: On Sat, Dec 1, 2018 at 6:40 PM Sabyasachi Gupta wrote: On Wed, Nov 21, 2018 at 7:18 PM Sabyasachi Gupta wrote: Replace dma_alloc_coherent + memset with dma_zalloc_coherent If you're

[PATCH v2 2/2] arm64/sve: Disentangle from

2019-01-04 Thread Dave Martin
Currently, provides common definitions for describing SVE context structures that are also used by the ptrace definitions in . For this reason, a #include of was added in ptrace.h, but it this turns out that this can interact badly with userspace code that tries to include ptrace.h on top of

[PATCH v2 1/2] arm64/sve: ptrace: Fix SVE_PT_REGS_OFFSET definition

2019-01-04 Thread Dave Martin
SVE_PT_REGS_OFFSET is supposed to indicate the offset for skipping over the ptrace NT_ARM_SVE header (struct user_sve_header) to the start of the SVE register data proper. However, currently SVE_PT_REGS_OFFSET is defined in terms of struct sve_context, which is wrong: that structure describes the

[PATCH v2 0/2] arm64/sve: UAPI: Disentangle ptrace.h from sigcontext.h

2019-01-04 Thread Dave Martin
This patch refactors the UAPI header definitions for the Arm SVE extension to avoid multiple-definition problems when userspace mixes its own sigcontext.h definitions with the kernel's ptrace.h (which is apparently routine). A common backend header is created to hold common definitions, suitably

Re: [PATCH v3] mm/page_owner: fix for deferred struct page init

2019-01-04 Thread Michal Hocko
On Thu 03-01-19 17:22:29, Qian Cai wrote: > On 1/3/19 3:22 PM, Michal Hocko wrote: > > On Thu 03-01-19 14:53:47, Qian Cai wrote: > >> On 1/3/19 2:07 PM, Michal Hocko wrote> So can we make the revert with an > >> explanation that the patch was wrong? > >>> If we want to make hacks to catch more

(Audio/Video): The Truth about Linux GPLv2 and license recission (revocation).

2019-01-04 Thread vsnsdualce
Information regarding the rights of the linux programmers, regarding rescission (revocation) of their granted license to use their code. Video: http://www.liveleak.com/view?t=9O5vz_1546606404 ( Audio Only: ) (Part1: http://www.liveleak.com/view?t=s3Sr9_1546605652 ) (Part2:

Re: Column for keywords?

2019-01-04 Thread Dmitry Vyukov
On Wed, May 16, 2018 at 6:50 PM Tetsuo Handa wrote: > > Dmitry Vyukov wrote: > > On Tue, May 15, 2018 at 10:59 PM, Tetsuo Handa > > wrote: > > > Dmitry Vyukov wrote: > > >> I've filed https://github.com/google/syzkaller/issues/608 to not lose > > >> track of this. > > > > > > Thanks. Since the

direct.c:undefined reference to `arch_dma_alloc'

2019-01-04 Thread kbuild test robot
Hi Christoph, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 645ff1e8e704c4f33ab1fcd3c87f95cb9b6d7144 commit: 68c608345cc569bcfa1c1b2add4c00c343ecf933 swiotlb: remove dma_mark_clean date: 3 weeks ago config:

[GIT PULL] Please pull powerpc/linux.git powerpc-4.21-2 tag

2019-01-04 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Linus, Please pull some powerpc fixes for 4.21: The following changes since commit 96d4f267e40f9509e8a66e2b39e8b95655617693: Remove 'type' argument from access_ok() function (2019-01-03 18:57:57 -0800) are available in the git repository at:

Re: Remove 'type' argument from access_ok() function

2019-01-04 Thread Michael Ellerman
On Fri, 2019-01-04 at 09:27:58 UTC, Mathieu Malaterre wrote: > In commit 05a4ab823983 ("powerpc/uaccess: fix warning/error with > access_ok()") an attempt was made to remove a warning by referencing the > variable `type`, however in commit 96d4f267e40f ("Remove 'type' argument > from access_ok()

[REGRESSION, BISECTED] pci: nvme device with HMB fails on arm64

2019-01-04 Thread Liviu Dudau
Hello Christoph, As I have mentioned to you after Xmas, I think your dma-mapping series breaks NVMe drivers that use HMB on arm64 (RK3399 NanoPC T4 board with Toshiba RC100 SSD in this case). The observed behaviour is that the modprobe of the nvme module will hang due to a kernel crash, which

Re: [PATCH] perf stat: Poll for monitored tasks being alive in fork mode

2019-01-04 Thread Jiri Olsa
On Fri, Jan 04, 2019 at 10:28:17AM +0800, Jin Yao wrote: > Following test shows the stat keeps running even if no longer > task to monitor (mgen exits at ~5s). > > perf stat -e cycles -p `pgrep mgen` -I1000 -- sleep 10 > time counts unit events > 1.000148916

[PATCH 25/25] mm, compaction: Do not direct compact remote memory

2019-01-04 Thread Mel Gorman
Remote compaction is expensive and possibly counter-productive. Locality is expected to often have better performance characteristics than remote high-order pages. For small allocations, it's expected that locality is generally required or fallbacks are possible. For larger allocations such as

[PATCH 21/25] mm, compaction: Round-robin the order while searching the free lists for a target

2019-01-04 Thread Mel Gorman
As compaction proceeds and creates high-order blocks, the free list search gets less efficient as the larger blocks are used as compaction targets. Eventually, the larger blocks will be behind the migration scanner for partially migrated pageblocks and the search fails. This patch round-robins

[PATCH 24/25] mm, compaction: Capture a page under direct compaction

2019-01-04 Thread Mel Gorman
Compaction is inherently race-prone as a suitable page freed during compaction can be allocated by any parallel task. This patch uses a capture_control structure to isolate a page immediately when it is freed by a direct compactor in the slow path of the page allocator. The intent is to avoid

[PATCH 23/25] mm, compaction: Be selective about what pageblocks to clear skip hints

2019-01-04 Thread Mel Gorman
Pageblock hints are cleared when compaction restarts or kswapd makes enough progress that it can sleep but it's over-eager in that the bit is cleared for migration sources with no LRU pages and migration targets with no free pages. As pageblock skip hint flushes are relatively rare and out-of-band

[PATCH 22/25] mm, compaction: Sample pageblocks for free pages

2019-01-04 Thread Mel Gorman
Once fast searching finishes, there is a possibility that the linear scanner is scanning full blocks found by the fast scanner earlier. This patch uses an adaptive stride to sample pageblocks for free pages. The more consecutive full pageblocks encountered, the larger the stride until a pageblock

[PATCH 20/25] mm, compaction: Reduce unnecessary skipping of migration target scanner

2019-01-04 Thread Mel Gorman
The fast isolation of pages can move the scanner faster than is necessary depending on the contents of the free list. This patch will only allow the fast isolation to initialise the scanner and advance it slowly. The primary means of moving the scanner forward is via the linear scanner to reduce

[PATCH 19/25] mm, compaction: Do not consider a need to reschedule as contention

2019-01-04 Thread Mel Gorman
Scanning on large machines can take a considerable length of time and eventually need to be rescheduled. This is treated as an abort event but that's not appropriate as the attempt is likely to be retried after making numerous checks and taking another cycle through the page allocator. This patch

[PATCH 18/25] mm, compaction: Rework compact_should_abort as compact_check_resched

2019-01-04 Thread Mel Gorman
With incremental changes, compact_should_abort no longer makes any documented sense. Rename to compact_check_resched and update the associated comments. There is no benefit other than reducing redundant code and making the intent slightly clearer. It could potentially be merged with earlier

[PATCH 17/25] mm, compaction: Keep cached migration PFNs synced for unusable pageblocks

2019-01-04 Thread Mel Gorman
Migrate has separate cached PFNs for ASYNC and SYNC* migration on the basis that some migrations will fail in ASYNC mode. However, if the cached PFNs match at the start of scanning and pageblocks are skipped due to having no isolation candidates, then the sync state does not matter. This patch

RE: [PATCH] fsl/fman: avoid sleeping in atomic context while adding an address

2019-01-04 Thread Madalin-cristian Bucur
Hi, this is a duplicate of this other patch addressing the issue: commit 0d9c9a238faf925823bde866182c663b6d734f2e Author: Scott Wood Date: Thu Dec 27 18:29:09 2018 -0600 fsl/fman: Use GFP_ATOMIC in {memac,tgec}_add_hash_mac_address() Thank you, Madalin >

[PATCH 16/25] mm, compaction: Check early for huge pages encountered by the migration scanner

2019-01-04 Thread Mel Gorman
When scanning for sources or targets, PageCompound is checked for huge pages as they can be skipped quickly but it happens relatively late after a lot of setup and checking. This patch short-cuts the check to make it earlier. It might still change when the lock is acquired but this has less

[PATCH 14/25] mm, compaction: Avoid rescanning the same pageblock multiple times

2019-01-04 Thread Mel Gorman
Pageblocks are marked for skip when no pages are isolated after a scan. However, it's possible to hit corner cases where the migration scanner gets stuck near the boundary between the source and target scanner. Due to pages being migrated in blocks of COMPACT_CLUSTER_MAX, pages that are migrated

[PATCH 15/25] mm, compaction: Finish pageblock scanning on contention

2019-01-04 Thread Mel Gorman
Async migration aborts on spinlock contention but contention can be high when there are multiple compaction attempts and kswapd is active. The consequence is that the migration scanners move forward uselessly while still contending on locks for longer while leaving suitable migration sources

[PATCH 13/25] mm, compaction: Use free lists to quickly locate a migration target

2019-01-04 Thread Mel Gorman
Similar to the migration scanner, this patch uses the free lists to quickly locate a migration target. The search is different in that lower orders will be searched for a suitable high PFN if necessary but the search is still bound. This is justified on the grounds that the free scanner typically

[PATCH 11/25] mm, compaction: Use free lists to quickly locate a migration source

2019-01-04 Thread Mel Gorman
The migration scanner is a linear scan of a zone with a potentiall large search space. Furthermore, many pageblocks are unusable such as those filled with reserved pages or partially filled with pages that cannot migrate. These still get scanned in the common case of allocating a THP and the cost

[PATCH 12/25] mm, compaction: Keep migration source private to a single compaction instance

2019-01-04 Thread Mel Gorman
Due to either a fast search of the free list or a linear scan, it is possible for multiple compaction instances to pick the same pageblock for migration. This is lucky for one scanner and increased scanning for all the others. It also allows a race between requests on which first allocates the

[PATCH 06/25] mm, compaction: Skip pageblocks with reserved pages

2019-01-04 Thread Mel Gorman
Reserved pages are set at boot time, tend to be clustered and almost never become unreserved. When isolating pages for either migration sources or target, skip the entire pageblock is one PageReserved page is encountered on the grounds that it is highly probable the entire pageblock is reserved.

[PATCH 10/25] mm, compaction: Ignore the fragmentation avoidance boost for isolation and compaction

2019-01-04 Thread Mel Gorman
When pageblocks get fragmented, watermarks are artifically boosted to reclaim pages to avoid further fragmentation events. However, compaction is often either fragmentation-neutral or moving movable pages away from unmovable/reclaimable pages. As the true watermarks are preserved, allow compaction

[PATCH 08/25] mm, compaction: Always finish scanning of a full pageblock

2019-01-04 Thread Mel Gorman
When compaction is finishing, it uses a flag to ensure the pageblock is complete but it makes sense to always complete migration of a pageblock. Minimally, skip information is based on a pageblock and partially scanned pageblocks may incur more scanning in the future. The pageblock skip handling

[PATCH 09/25] mm, compaction: Use the page allocator bulk-free helper for lists of pages

2019-01-04 Thread Mel Gorman
release_pages() is a simpler version of free_unref_page_list() but it tracks the highest PFN for caching the restart point of the compaction free scanner. This patch optionally tracks the highest PFN in the core helper and converts compaction to use it. The performance impact is limited but it

[PATCH 07/25] mm, migrate: Immediately fail migration of a page with no migration handler

2019-01-04 Thread Mel Gorman
Pages with no migration handler use a fallback handler which sometimes works and sometimes persistently retries. A historical example was blockdev pages but there are others such as odd refcounting when page->private is used. These are retried multiple times which is wasteful during compaction so

[PATCH 04/25] mm, compaction: Remove unnecessary zone parameter in some instances

2019-01-04 Thread Mel Gorman
A zone parameter is passed into a number of top-level compaction functions despite the fact that it's already in cache_control. This is harmless but it did need an audit to check if zone actually ever changes meaningfully. This patches removes the parameter in a number of top-level functions. The

[PATCH 05/25] mm, compaction: Rename map_pages to split_map_pages

2019-01-04 Thread Mel Gorman
It's non-obvious that high-order free pages are split into order-0 pages from the function name. Fix it. Signed-off-by: Mel Gorman --- mm/compaction.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 7acb43f07303..3afa4e9188b6

[PATCH 02/25] mm, compaction: Rearrange compact_control

2019-01-04 Thread Mel Gorman
compact_control spans two cache lines with write-intensive lines on both. Rearrange so the most write-intensive fields are in the same cache line. This has a negligible impact on the overall performance of compaction and is more a tidying exercise than anything. Signed-off-by: Mel Gorman

[PATCH 00/25] Increase success rates and reduce latency of compaction v2

2019-01-04 Thread Mel Gorman
This series reduces scan rates and success rates of compaction, primarily by using the free lists to shorten scans, better controlling of skip information and whether multiple scanners can target the same block and capturing pageblocks before being stolen by parallel requests. The series is based

[PATCH 01/25] mm, compaction: Shrink compact_control

2019-01-04 Thread Mel Gorman
The isolate and migrate scanners should never isolate more than a pageblock of pages so unsigned int is sufficient saving 8 bytes on a 64-bit build. Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka --- mm/internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 03/25] mm, compaction: Remove last_migrated_pfn from compact_control

2019-01-04 Thread Mel Gorman
The last_migrated_pfn field is a bit dubious as to whether it really helps but either way, the information from it can be inferred without increasing the size of compact_control so remove the field. Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka --- mm/compaction.c | 25

[PATCH 1/4] rtlwifi: rtl8723ae: Take the FW LPS mode handling out

2019-01-04 Thread Bernd Edlinger
This appears to trigger a firmware bug and causes severe problems with rtl8723ae PCI devices. When the power save mode is activated for longer periods of time the firmware stops to receive any packets. This problem was exposed by commit 873ffe154ae0 ("rtlwifi: Fix logic error in enter/exit

Re: [PATCH] scsi/dpt_i2o.c: Use dma_zalloc_coherent

2019-01-04 Thread Sabyasachi Gupta
On Wed, Dec 19, 2018 at 6:41 PM Sabyasachi Gupta wrote: > > On Sat, Dec 1, 2018 at 6:45 PM Sabyasachi Gupta > wrote: > > > > On Sat, Nov 17, 2018 at 6:17 PM Sabyasachi Gupta > > wrote: > > > > > > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent > > > > > > Signed-off-by:

[PATCH 2/4] rtlwifi: rtl8723ae: Don't use dm.undec_sm_pwdb for input

2019-01-04 Thread Bernd Edlinger
gain control when no beacon was received in the connected state. This avoids sporadic "Connection to AP ... lost" errors. Signed-off-by: Bernd Edlinger --- drivers/net/wireless/realtek/rtlwifi/core.c | 2 ++ drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c | 8 2 files

[PATCH 4/4] rtlwifi: Move the clearing of

2019-01-04 Thread Bernd Edlinger
rtlpriv->link_info.num_rx_inperiod in rtl_watchdog_wq_callback a few lines down. This is necessary since it is still used in the "AP off" detection code block. Moved clearing of rtlpriv->link_info.num_rx_inperiod as well for consistency. Signed-off-by: Bernd Edlinger ---

Re: [PATCH 2/2] virtio: document virtio_config_ops restrictions

2019-01-04 Thread Cornelia Huck
On Thu, 3 Jan 2019 18:28:49 +0100 Halil Pasic wrote: > On Thu, 3 Jan 2019 17:08:04 +0100 > Cornelia Huck wrote: > > > Some transports (e.g. virtio-ccw) implement virtio operations that > > seem to be a simple read/write as something more involved that > > cannot be done from an atomic

[PATCH 0/4] rtlwifi: Fix issues with rtl8723ae

2019-01-04 Thread Bernd Edlinger
Currently the rtl8723ae driver is broken (since v4.7). Connection to AP is lost very often, especially when the signal level is not very good. The main issue is the power save mode is basically not working, and seems to trigger a firmware bug. So I had to remove that code. While debugging the

Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent

2019-01-04 Thread Sabyasachi Gupta
On Wed, Dec 19, 2018 at 6:49 PM Sabyasachi Gupta wrote: > > On Sat, Dec 1, 2018 at 6:40 PM Sabyasachi Gupta > wrote: > > > > On Wed, Nov 21, 2018 at 7:18 PM Sabyasachi Gupta > > wrote: > > > > > > Replace dma_alloc_coherent + memset with dma_zalloc_coherent > > > > > > Signed-off-by: Sabyasachi

[PATCH 3/4] rtlwifi: rtl8723ae: Re-introduce

2019-01-04 Thread Bernd Edlinger
rtl8723e_dm_refresh_rate_adaptive_mask This function was present in a previous version of the code base, it works just fine for me -- as long as it is not using stale data. Fixed a style nit in rtl8723e_dm_init_rate_adaptive_mask. Signed-off-by: Bernd Edlinger ---

Re: [PATCH RFC lora-next 2/4] net: lora: sx1301: add minimal to get AGC working prior to tx work

2019-01-04 Thread Ben Whitten
On 29/12/2018 09:58, Andreas Färber wrote: Hi Ben, Am 19.12.18 um 16:56 schrieb Ben Whitten: As part of initialisation when opening the lora device after loading the AGC firmware we need to satisfy its startup procedure which involves a few steps; Loading a 16 entry lookup table. For this

CFS scheduler: spin_lock usage causes dead lock when smp_apic_timer_interrupt occurs

2019-01-04 Thread Tom Putzeys
Dear Ingo and Peter, I would like to report a possible bug in the CFS scheduler causing a dead lock.  We suspect this bug to have caused intermittent yet highly-persistent system freezes on our quad-core SMP systems. We noticed the problem on 4.1.17 preempt-rt but we suspect the problematic

<    1   2   3   4   5   6   7   >