Re: bcache on XFS: metadata I/O (dirent I/O?) not getting cached at all?

2019-02-07 Thread Coly Li
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2019/2/7 5:41 下午, Andre Noll wrote: > On Thu, Feb 07, 16:16, Coly Li wrote >> From: Coly Li Date: Thu, 7 Feb 2019 15:54:24 >> +0800 Subject: [PATCH] bcache: use (REQ_META|REQ_PRIO) to >> indicate bio for metadata >> >> In 'commit 752f66a75aba

Re: [PATCH] aout: incorrct use of strncpy fixed.

2019-02-07 Thread Borislav Petkov
On Sat, Feb 02, 2019 at 01:55:12PM +1300, Derek Robson wrote: > Found a bug with the source / dest length > updated to have size limit as the size of dest not size or source. > > Signed-off-by: Derek Robson > --- > arch/x86/ia32/ia32_aout.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v2] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-07 Thread Sebastian Ott
On Wed, 6 Feb 2019, Tony Krowiak wrote: > diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c > +void ap_bus_cfg_chg(void) > +{ > + AP_DBF(DBF_INFO, "%s config change, forcing bus rescan\n", __func__); > + > + ap_bus_force_rescan(); > +} >

Re: [PATCH v3 1/2] mm: add probe_user_read()

2019-02-07 Thread Jann Horn
On Thu, Feb 7, 2019 at 10:22 AM Christophe Leroy wrote: > In powerpc code, there are several places implementing safe > access to user data. This is sometimes implemented using > probe_kernel_address() with additional access_ok() verification, > sometimes with get_user() enclosed in a

Re: [PATCH 1/2] Revert "mm: don't reclaim inodes with many attached pages"

2019-02-07 Thread Jan Kara
On Fri 01-02-19 09:19:04, Dave Chinner wrote: > Maybe for memcgs, but that's exactly the oppose of what we want to > do for global caches (e.g. filesystem metadata caches). We need to > make sure that a single, heavily pressured cache doesn't evict small > caches that lower pressure but are

Re: [PATCH net-next v2 01/10] net: phy: Update PHY linkmodes after config_init

2019-02-07 Thread Maxime Chevallier
Hello everyone, On Thu, 7 Feb 2019 10:49:30 +0100 Maxime Chevallier wrote: >We want to be able to update a PHY's supported list in the config_init >callback, so move the Pause parameters settings from phydrv->features >after calling config_init to make sure these parameters aren't

Re: [PATCH v7 2/3] arm64: implement ftrace with regs

2019-02-07 Thread Julien Thierry
On 06/02/2019 15:05, Torsten Duwe wrote: > On Wed, Feb 06, 2019 at 08:59:44AM +, Julien Thierry wrote: >> Hi Torsten, >> >> On 18/01/2019 16:39, Torsten Duwe wrote: >> >>> --- a/arch/arm64/kernel/ftrace.c >>> +++ b/arch/arm64/kernel/ftrace.c >>> @@ -133,17 +163,45 @@ int

Re: [PATCH v3] dt-bindings: reset: meson: add g12a bindings

2019-02-07 Thread Philipp Zabel
Hi Jerome, is there any public documentation for the G12A reset controller? On Fri, 2019-02-01 at 13:50 +0100, Jerome Brunet wrote: > Add device tree bindings for the reset controller of g12a SoC family. > > Acked-by: Neil Armstrong > Signed-off-by: Jerome Brunet > --- > > Changes since v2

Re: [PATCH v2] mfd: cros_ec_dev: Return number of bytes read with CROS_EC_DEV_IOCRDMEM

2019-02-07 Thread Lee Jones
On Wed, 06 Feb 2019, Enric Balletbo i Serra wrote: > From: Guenter Roeck > > While ioctls normally return a negative error or 0 on success, this is not > the case for CROS_EC_DEV_IOCXCMD in the cros_ec driver, which returns the > number of bytes read instead. However, CROS_EC_DEV_IOCRDMEM in

Re: [PATCH] drivers: base: add support to skip power management in device/driver model

2019-02-07 Thread Sudeep Holla
On Thu, Feb 07, 2019 at 10:53:56AM +0100, Ulf Hansson wrote: > On Wed, 6 Feb 2019 at 16:09, Sudeep Holla wrote: > > > > All device objects in the driver model contain fields that control the > > handling of various power management activities. However, it's not > > always useful. There are few

Re: [PATCH 07/22] x86/fpu: Remove fpu->initialized

2019-02-07 Thread Borislav Petkov
On Thu, Feb 07, 2019 at 11:13:01AM +0100, Sebastian Andrzej Siewior wrote: > and I *think* that this is enough. This *what* we do and not *why*. I > don't have an answer towards *why*. Well, it is a start. You now have everything in your L1 and it is all clear but I'm sure all the details will

Re: [PATCH 2/3] arm64: dts: hisilicon: hi3670: Add reset controller support

2019-02-07 Thread Philipp Zabel
On Fri, 2019-02-01 at 21:08 +0530, Manivannan Sadhasivam wrote: > Add reset controller support for HiSilicon HI3670 SoC. > > Signed-off-by: Manivannan Sadhasivam > --- > arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [PATCH] xhci: Use ffs() to find page size in xhci_mem_init()

2019-02-07 Thread Mathias Nyman
On 07.02.2019 11:06, Felipe Balbi wrote: Hi, Mathias Nyman writes: On 07.02.2019 02:03, Andrey Smirnov wrote: Get page size order using ffs() instead of open coding it with a loop. Signed-off-by: Andrey Smirnov Cc: Mathias Nyman Cc: Greg Kroah-Hartman Cc: linux-...@vger.kernel.org Cc:

Re: [PATCH 3/3] reset: hisilicon: Add HiSilicon HI3670 reset support

2019-02-07 Thread Philipp Zabel
On Fri, 2019-02-01 at 21:08 +0530, Manivannan Sadhasivam wrote: > HI3670 SoC is architecturally same as the HI3660 SoC. Hence, add the > HI3670 compatible to HI3660 reset driver in order to reuse it. > > Signed-off-by: Manivannan Sadhasivam > --- > drivers/reset/hisilicon/reset-hi3660.c | 1 + >

Re: [PATCH 1/3] dt-bindings: reset: Add HI3670 reset controller binding

2019-02-07 Thread Philipp Zabel
Hi Manivannan, On Fri, 2019-02-01 at 21:08 +0530, Manivannan Sadhasivam wrote: > HI3670 SoC is architecturally same as the HI3660 SoC. Hence, the same > driver is reused for HI3670 SoC and the binding is documented here. > > Signed-off-by: Manivannan Sadhasivam > --- >

[PATCH] x86/kvm/nVMX: read from MSR_IA32_VMX_PROCBASED_CTLS2 only when it is available

2019-02-07 Thread Vitaly Kuznetsov
SDM says MSR_IA32_VMX_PROCBASED_CTLS2 is only available "If (CPUID.01H:ECX.[5] && IA32_VMX_PROCBASED_CTLS[63])". It was found that some old cpus (namely "Intel(R) Core(TM)2 CPU 6600 @ 2.40GHz (family: 0x6, model: 0xf, stepping: 0x6") don't have it. Add the missing check. Reported-by: Zdenek

Re: [PATCH 09/22] x86/fpu: Add (__)make_fpregs_active helpers

2019-02-07 Thread Sebastian Andrzej Siewior
On 2019-01-28 19:23:49 [+0100], Borislav Petkov wrote: > > diff --git a/arch/x86/include/asm/fpu/api.h b/arch/x86/include/asm/fpu/api.h > > index b56d504af6545..31b66af8eb914 100644 > > --- a/arch/x86/include/asm/fpu/api.h > > +++ b/arch/x86/include/asm/fpu/api.h > > @@ -10,6 +10,7 @@ > > > >

[PATCH 1/2] sched/fair: Don't pass sd to select_idle_smt()

2019-02-07 Thread Viresh Kumar
The parameter sd isn't getting used in select_idle_smt(), drop it. Signed-off-by: Viresh Kumar --- kernel/sched/fair.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 38d4669aa2ef..8d5c82342a36 100644 ---

[PATCH 2/2] sched/fair: Improve the for loop in select_idle_core()

2019-02-07 Thread Viresh Kumar
Once a non-idle thread is found for a core, there is no point in traversing rest of the threads of that core. We continue traversal currently to clear those threads from "cpus" mask. Clear all the threads with a single call to cpumask_andnot(), which will also let us exit the loop earlier.

Re: [PATCH] mtd: rawnand: call onfi_fill_data_interface() once again after nand_detect

2019-02-07 Thread Masahiro Yamada
On Thu, Feb 7, 2019 at 7:16 PM Miquel Raynal wrote: > > Hi Masahiro, > > Masahiro Yamada wrote on Thu, 7 Feb > 2019 18:57:56 +0900: > > > nand_scan_ident() calls onfi_fill_data_interface() at its entry > > to set up the initial timing parameters. > > > > The timing parameters are needed not

Re: [PATCH 1/2] mtd: spi-nor: Add support for EN25Q80A

2019-02-07 Thread Boris Brezillon
On Thu, 7 Feb 2019 10:16:05 + wrote: > Hi, Frieder, > > On 02/07/2019 12:06 PM, Schrempf Frieder wrote: > > Hi Tudor, > > > > On 03.02.19 14:33, tudor.amba...@microchip.com wrote: > >> Hi, Frieder, > >> > >> On 01/23/2019 09:56 AM, Schrempf Frieder wrote: > >>> From: Frieder Schrempf

[PATCH v1 00/24] thermal: tsens: Refactor to use regmap_field

2019-02-07 Thread Amit Kucheria
Short term bandaid fixes to add support for more versions of the TSENS IP is not proving to be very scalable. Here is a series to finally convert the driver's core to use regmap_fields so that register addresses and bitfields can be abstracted away from the code. This series is posted as one to

[PATCH v1 01/24] drivers: thermal: tsens: Document the data structures

2019-02-07 Thread Amit Kucheria
Describe how the TSENS device and the various sensors connected to it are described in the driver Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens.h | 31 --- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/qcom/tsens.h

[PATCH v1 02/24] drivers: thermal: tsens: Rename tsens_data

2019-02-07 Thread Amit Kucheria
Rename to tsens_plat_data to denote that it is platform-data passed in at compile-time. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-8916.c | 2 +- drivers/thermal/qcom/tsens-8960.c | 2 +- drivers/thermal/qcom/tsens-8974.c | 2 +- drivers/thermal/qcom/tsens-v2.c | 4 ++--

[PATCH v1 03/24] drivers: thermal: tsens: Rename tsens_device

2019-02-07 Thread Amit Kucheria
Rename to tsens_priv to denote that it is private data for each tsens instance. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-8916.c | 2 +- drivers/thermal/qcom/tsens-8960.c | 14 +++--- drivers/thermal/qcom/tsens-8974.c | 2 +- drivers/thermal/qcom/tsens-common.c

[PATCH v1 04/24] drivers: thermal: tsens: Rename variable tmdev

2019-02-07 Thread Amit Kucheria
tmdev seems to imply that this is a device pointer when in fact it is just private platform data for each tsens device. Rename it to priv improve code readability. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-8916.c | 16 +++--- drivers/thermal/qcom/tsens-8960.c | 82

[PATCH v1 05/24] drivers: thermal: tsens: Use consistent names for variables

2019-02-07 Thread Amit Kucheria
tsens_get_temp() uses the name 'data' for the void pointer, use the same in tsens_get_trend() for consistency. Remove a stray space while we're at it. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] mtd: rawnand: call onfi_fill_data_interface() once again after nand_detect

2019-02-07 Thread Masahiro Yamada
On Thu, Feb 7, 2019 at 7:46 PM Masahiro Yamada wrote: > > On Thu, Feb 7, 2019 at 7:16 PM Miquel Raynal > wrote: > > > > Hi Masahiro, > > > > Masahiro Yamada wrote on Thu, 7 Feb > > 2019 18:57:56 +0900: > > > > > nand_scan_ident() calls onfi_fill_data_interface() at its entry > > > to set up

Re: [PATCH v4] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template

2019-02-07 Thread Marc Gonzalez
On 26/01/2019 08:52, Nathan Chancellor wrote: > Clang warns several times in the scsi subsystem (trimmed for brevity): > > drivers/scsi/hpsa.c:6209:7: warning: overflow converting case value to > switch condition type (2147762695 to 18446744071562347015) [-Wswitch] > case

Re: [PATCH v2] include/linux/module.h: mark init/cleanup_module aliases as __init/exit

2019-02-07 Thread Jessica Yu
+++ Miguel Ojeda [06/02/19 22:19 +0100]: On Wed, Feb 6, 2019 at 6:56 PM Miguel Ojeda wrote: diff --git a/include/linux/module.h b/include/linux/module.h index 8fa38d3e7538..1b5e370f1bc0 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -129,13 +129,13 @@ extern void

Re: [PATCH v2 1/4] phy: core: Add *release* phy_ops invoked when the consumer relinquishes PHY

2019-02-07 Thread Roger Quadros
Kishon, On 06/02/19 13:07, Kishon Vijay Abraham I wrote: > Add a new phy_ops *release* invoked when the consumer relinquishes the > PHY using phy_put/devm_phy_put. The initializations done by the PHY > driver in of_xlate call back can be can be cleaned up here. > > Signed-off-by: Kishon Vijay

Re: [PATCH v10 0/6] tpm: retrieve digest size of unknown algorithms from TPM

2019-02-07 Thread Roberto Sassu
On 2/6/2019 6:10 PM, Jarkko Sakkinen wrote: On Wed, Feb 06, 2019 at 05:07:49PM +0100, Roberto Sassu wrote: Seems ok to me. I'll send patch 3/6 and 4/6. Your series has been applied to master and next. Thank you. Thanks. Roberto /Jarkko -- HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB

Re: [PATCH] xhci: Use ffs() to find page size in xhci_mem_init()

2019-02-07 Thread Felipe Balbi
Hi, Mathias Nyman writes: Get page size order using ffs() instead of open coding it with a loop. Signed-off-by: Andrey Smirnov Cc: Mathias Nyman Cc: Greg Kroah-Hartman Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org ---

Re: [PATCH V14 3/5] i2c: tegra: Add DMA support

2019-02-07 Thread Thierry Reding
On Wed, Feb 06, 2019 at 11:16:07AM -0800, Sowjanya Komatineni wrote: > This patch adds DMA support for Tegra I2C. > > Tegra I2C TX and RX FIFO depth is 8 words. PIO mode is used for > transfer size of the max FIFO depth and DMA mode is used for > transfer size higher than max FIFO depth to save

Re: [RFT PATCH 7/9] mfd: axp20x: add USB power supply mfd cell to AXP813

2019-02-07 Thread Lee Jones
On Thu, 07 Feb 2019, Chen-Yu Tsai wrote: > From: Quentin Schulz > > The AXP813 has a VBUS power input. Now that the axp20x_usb_power driver > supports this variant, we can add an mfd cell for it to use it. > > Signed-off-by: Quentin Schulz > [w...@csie.org: add commit message] >

Re: [PATCH 4/5] phy: tegra: xusb: Add support for power supplies

2019-02-07 Thread Thierry Reding
On Tue, Feb 05, 2019 at 06:25:04PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On 28/01/19 1:30 PM, Thierry Reding wrote: > > On Mon, Jan 28, 2019 at 03:22:09PM +0800, jckuo wrote: > >> Hi Thierry, > >> > >> I think any non-zero return value of > >>

Re: [PATCH 11/22] x86/fpu: Make get_xsave_field_ptr() and get_xsave_addr() use feature number instead of mask

2019-02-07 Thread Sebastian Andrzej Siewior
On 2019-01-28 19:49:59 [+0100], Borislav Petkov wrote: > > --- a/arch/x86/kernel/fpu/xstate.c > > +++ b/arch/x86/kernel/fpu/xstate.c > > @@ -830,15 +830,15 @@ static void *__raw_xsave_addr(struct xregs_state > > *xsave, int xfeature_nr) … > > -void *get_xsave_addr(struct xregs_state *xsave, int

Re: [PATCH 1/6] dt-bindings: usb: xhci-tegra: Add Tegra186 support

2019-02-07 Thread Thierry Reding
On Fri, Jan 25, 2019 at 12:30:08PM +0100, Thierry Reding wrote: > From: Thierry Reding > > Extend the bindings to cover the set of features found in Tegra186. > > Signed-off-by: Thierry Reding > --- > .../devicetree/bindings/usb/nvidia,tegra124-xusb.txt | 4 > 1 file changed, 4

Re: [PATCH v2 4/4] phy: ti: Add a new SERDES driver for TI's AM654x SoC

2019-02-07 Thread Roger Quadros
Hi, On 06/02/19 13:07, Kishon Vijay Abraham I wrote: > Add a new SERDES driver for TI's AM654x SoC which configures > the SERDES only for PCIe. Support fo USB3 will be added later. > > SERDES in am654x has three input clocks (left input, externel reference > clock and right input) and two output

Re: [PATCH 1/3] dt-bindings: reset: Add HI3670 reset controller binding

2019-02-07 Thread Manivannan Sadhasivam
Hi Philipp, On Thu, Feb 07, 2019 at 11:41:34AM +0100, Philipp Zabel wrote: > Hi Manivannan, > > On Fri, 2019-02-01 at 21:08 +0530, Manivannan Sadhasivam wrote: > > HI3670 SoC is architecturally same as the HI3660 SoC. Hence, the same > > driver is reused for HI3670 SoC and the binding is

[PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings

2019-02-07 Thread Jorge Ramirez-Ortiz
Binding description for Qualcomm's Synopsys 1.0.0 SuperSpeed phy controller embedded in QCS404. Based on Sriharsha Allenki's original definitions. Signed-off-by: Jorge Ramirez-Ortiz --- .../bindings/phy/qcom,snps-usb-ssphy.txt | 79 +++ 1 file changed, 79 insertions(+)

[PATCH v4 1/4] dt-bindings: phy: remove qcom-dwc3-usb-phy

2019-02-07 Thread Jorge Ramirez-Ortiz
This binding is not used by any driver. Signed-off-by: Jorge Ramirez-Ortiz --- .../bindings/phy/qcom-dwc3-usb-phy.txt| 37 --- 1 file changed, 37 deletions(-) delete mode 100644 Documentation/devicetree/bindings/phy/qcom-dwc3-usb-phy.txt diff --git

[PATCH v4 2/4] dt-bindings: connector: Add vbus-supply property

2019-02-07 Thread Jorge Ramirez-Ortiz
Some phys might need to control their VBUS regulators while not being supplied by them. If such support is required, use the vbus-supply property in the connector to retrieve the regulator. Signed-off-by: Jorge Ramirez-Ortiz --- Documentation/devicetree/bindings/connector/usb-connector.txt | 4

[PATCH v4 4/4] phy: qualcomm: usb: Add SuperSpeed PHY driver

2019-02-07 Thread Jorge Ramirez-Ortiz
Controls Qualcomm's SS phy 1.0.0 implemented in the QCS404 and some other Qualcomm platforms. Based on Sriharsha Allenki's original code. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/phy/qualcomm/Kconfig | 11 + drivers/phy/qualcomm/Makefile | 1 +

[PATCH v4 0/4] USB SS PHY for Qualcomm's QCS404

2019-02-07 Thread Jorge Ramirez-Ortiz
This set adds USB SS PHY support to Qualcomm's QCS404 SoC The PHY is implemented using Synopsys' SS PHY IP The code is losely based on Sriharsha Allenki's original implementation. v2: enable OTG mode detection move vdd voltage levels to driver use bulk_ control interfaces

[RFC PATCH] perf, bpf: Retain kernel executable code in memory to aid Intel PT tracing

2019-02-07 Thread Adrian Hunter
Subject to memory pressure and other limits, retain executable code, such as JIT-compiled bpf, in memory instead of freeing it immediately it is no longer needed for execution. While perf is primarily aimed at statistical analysis, tools like Intel PT can aim to provide a trace of exactly what

[PATCH 1/2] tty: serial: meson_uart: Add support for kernel debugger

2019-02-07 Thread Julien Masson
The kgdb invokes the poll_put_char and poll_get_char when communicating with the host. This patch implement the serial polling hooks for the meson_uart to be used for KGDB debugging over serial line. Signed-off-by: Julien Masson --- drivers/tty/serial/meson_uart.c | 46

Re: Kernel 4.9: strange behavior with fifo scheduler

2019-02-07 Thread Dietmar Eggemann
On 2/6/19 2:25 PM, Frédéric Mathieu wrote: Hi Dietmar, Attention !, these tests were executed on a kernel with the patch RT and the option CONFIG_PREEMPT_RT_FULL = y. I confirm the truth of my priority settings On a vanilla kernel, I get the same results as you. After talking with mike

Re: 4.4 "rcu: Force boolean subscript for expedited stall warnings"

2019-02-07 Thread Greg KH
On Wed, Feb 06, 2019 at 11:51:50AM +, Rantala, Tommi T. (Nokia - FI/Espoo) wrote: > Hi, > > Can you pick this tiny one-liner patch to 4.4.y? > Fixes unexpected null byte in RCU "expedited stall" message. > > > commit ec3833ed02ae6ef2a933ece9de7cbab0c64c699e > Author: Paul E. McKenney >

Re: [PATCH v2 3/4] dt-bindings: phy: ti: Add dt binding documentation for SERDES in AM654x SoC

2019-02-07 Thread Roger Quadros
On 06/02/19 13:07, Kishon Vijay Abraham I wrote: > AM654x has two SERDES instances. Each instance has three input clocks > (left input, externel reference clock and right input) and two output > clocks (left output and right output) in addition to a PLL mux clock > which the SERDES uses for

Re: [PATCH 12/22] x86/fpu: Only write PKRU if it is different from current

2019-02-07 Thread Sebastian Andrzej Siewior
On 2019-01-23 10:09:24 [-0800], Dave Hansen wrote: > On 1/9/19 3:47 AM, Sebastian Andrzej Siewior wrote: > > +static inline void __write_pkru(u32 pkru) > > +{ > > + /* > > +* Writting PKRU is expensive. Only write the PKRU value if it is > > +* different from the current one. > > +*/

Re: 4.14 "random: add a config option to trust the CPU's hwrng"

2019-02-07 Thread Greg KH
On Wed, Feb 06, 2019 at 02:26:13PM -0500, Sasha Levin wrote: > On Wed, Feb 06, 2019 at 11:44:36AM +, Rantala, Tommi T. (Nokia - > FI/Espoo) wrote: > > Hi stable maintainers, > > > > Can you consider including these "random" patches in 4.14.y? > > > > These are very useful in fixing esp.

Re: [PATCH 5/5] sched/fair: Skip LLC nohz logic for asymmetric systems

2019-02-07 Thread Valentin Schneider
On 07/02/2019 09:56, Peter Zijlstra wrote: [...] >> I'm afraid I don't follow - we don't lose a balance opportunity with the >> below change (compared to the original patch), do we? > > What if each big/little cluster would have multiple cache domains? Would > we not want to spread the cache

[PATCH v2 2/9] PCI: keystone: Modify legacy_irq_handler to check the IRQ_STATUS of INTA/B/C/D

2019-02-07 Thread Kishon Vijay Abraham I
The legacy interrupt handler directly checks the IRQ_STATUS register corresponding to a interrupt line inorder to invoke generic_handle_irq. While this is okay for K2G platform which has separate interrupt line for each of the 4 legacy interrupts, AM654 which uses the same PCIe wrapper has a

[PATCH v2 3/9] PCI: keystone: Add separate functions for configuring MSI and legacy interrupt

2019-02-07 Thread Kishon Vijay Abraham I
ks_pcie_get_irq_controller_info() was used to configure both MSI and legacy interrupt. This will prevent MSI or legacy interrupt specific intializations. Add separate functions to configure MSI and legacy interrupts. Signed-off-by: Kishon Vijay Abraham I ---

[PATCH v2 0/9] PCI: DWC/Keystone: MSI configuration cleanup

2019-02-07 Thread Kishon Vijay Abraham I
This series tries to address the comments discussed in [1] w.r.t removing Keystone specific callbacks defined in dw_pcie_host_ops. This series also tries to cleanup the Keystone interrupt handling part. Changes from v1: *) Removed "PCI: keystone: Use "dummy_irq_chip" instead of new irqchip for

[PATCH v2 5/9] PCI: keystone: Cleanup ks_pcie_msi_irq_handler and ks_pcie_legacy_irq_handler

2019-02-07 Thread Kishon Vijay Abraham I
Both ks_pcie_msi_irq_handler() and ks_pcie_legacy_irq_handler() invokes ks_pcie_handle_msi_irq() and ks_pcie_handle_legacy_irq() respectively for handling the interrupts. Having two functions for handling the interrupt was used when keystone PCIe driver was implemented using two files. But with

[PATCH v2 4/9] PCI: keystone: Use hwirq to get the IRQ number offset

2019-02-07 Thread Kishon Vijay Abraham I
ks_pcie_msi_irq_handler() uses 'virq' to get the IRQ number offset. This offset is used to get the correct MSI_IRQ_STATUS register corresponding to the IRQ line that raised the interrupt. There is no guarantee that 'virq' assigned for consecutive hardware IRQ will be contiguous. And this might get

[PATCH v2 6/9] PCI: dwc: Add support to use non default msi_irq_chip

2019-02-07 Thread Kishon Vijay Abraham I
Platforms using Designware IP uses dw_pci_msi_bottom_irq_chip for configuring the MSI controller logic within the Designware IP. However certain platforms like Keystone (K2G) which uses Desingware IP has it's own MSI controller logic. For handling such platforms, the irqchip ops uses msi_irq_ack,

[PATCH v2 8/9] PCI: dwc: Remove Keystone specific dw_pcie_host_ops

2019-02-07 Thread Kishon Vijay Abraham I
Now that Keystone started using it's own msi_irq_chip, remove Keystone specific callback function defined in dw_pcie_host_ops. Signed-off-by: Kishon Vijay Abraham I Acked-by: Gustavo Pimentel --- .../pci/controller/dwc/pcie-designware-host.c | 45 ++-

[PATCH v2 9/9] PCI: dwc: Do not write to MSI control registers if the platform doesn't use it

2019-02-07 Thread Kishon Vijay Abraham I
Platforms which populate msi_host_init, has it's own MSI controller logic. Writing to MSI control registers on platforms which doesn't use Designware's MSI controller logic might have side effects. To be safe, do not write to MSI control registers if the platform uses it's own MSI controller logic

[PATCH v2 7/9] PCI: keystone: Use Keystone specific msi_irq_chip

2019-02-07 Thread Kishon Vijay Abraham I
Use Keystone specific msi_irq_chip to configure the MSI controller logic in the PCIe keystone wrapper instead of using the default Designware msi_irq chip (dw_pci_msi_bottom_irq_chip) with callback functions for configuring the Keystone MSI controller. This will help to remove Keystone specific

[PATCH v2 1/9] PCI: keystone: Cleanup interrupt related macros

2019-02-07 Thread Kishon Vijay Abraham I
No functional change. Change both MSI interrupt and legacy interrupt related macros to take an additional argument in order to return the correct register offset. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 26 +++ 1 file changed, 13

Re: [PATCHv5 04/10] node: Link memory nodes to their compute nodes

2019-02-07 Thread Rafael J. Wysocki
On Fri, Jan 25, 2019 at 12:08 AM Keith Busch wrote: > > Systems may be constructed with various specialized nodes. Some nodes > may provide memory, some provide compute devices that access and use > that memory, and others may provide both. Nodes that provide memory are > referred to as memory

Re: [PATCH v8 1/8] mfd: regulator: clk: split rohm-bd718x7.h

2019-02-07 Thread Lee Jones
On Thu, 07 Feb 2019, Matti Vaittinen wrote: > Split the bd718x7.h to ROHM common and bd718x7 specific parts > so that we do not need to add same things in every new ROHM > PMIC header. Please note that this change requires changes also > in bd718x7 sub-device drivers for regulators and clk. > >

[PATCH 4.4 21/34] inet: frags: fix ip6frag_low_thresh boundary

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 3d23401283e80ceb03f765842787e0e79ff598b7 upstream. Giving an integer to proc_doulongvec_minmax() is dangerous on 64bit arches, since linker might place next to it a non

[PATCH 4.4 07/34] rhashtable: Add rhashtable_lookup()

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Ben Hutchings Extracted from commit ca26893f05e8 "rhashtable: Add rhlist interface". Cc: Herbert Xu Signed-off-by: Ben Hutchings Signed-off-by: Greg Kroah-Hartman ---

[PATCH 4.4 20/34] inet: frags: get rid of ipfrag_skb_cb/FRAG_CB

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit bf66337140c64c27fa37222b7abca7e49d63fb57 upstream. ip_defrag uses skb->cb[] to store the fragment offset, and unfortunately this integer is currently in a different cache

[PATCH 4.4 18/34] rhashtable: reorganize struct rhashtable layout

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit e5d672a0780d9e7118caad4c171ec88b8299398d upstream. While under frags DDOS I noticed unfortunate false sharing between @nelems and @params.automatic_shrinking Move @nelems

[PATCH 4.4 01/34] inet: frags: change inet_frags_init_net() return value

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 787bea7748a76130566f881c2342a0be4127d182 upstream. We will soon initialize one rhashtable per struct netns_frags in inet_frags_init_net(). This patch changes the return

[PATCH 4.4 00/34] 4.4.174-stable review

2019-02-07 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.4.174 release. There are 34 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat Feb 9 11:30:10 UTC 2019. Anything

[PATCH 4.4 02/34] inet: frags: add a pointer to struct netns_frags

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 093ba72914b696521e4885756a68a3332782c8de upstream. In order to simplify the API, add a pointer to struct inet_frags. This will allow us to make things less complex. These

[PATCH 4.4 03/34] inet: frags: refactor ipfrag_init()

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 483a6e4fa055123142d8956866fe2aa9c98d546d upstream. We need to call inet_frags_init() before register_pernet_subsys(), as a prereq for following patch ("inet: frags: use

[PATCH 4.4 05/34] inet: frags: refactor lowpan_net_frag_init()

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 807f1844df4ac23594268fa9f41902d0549e92aa upstream. We want to call lowpan_net_frag_init() earlier. Similar to commit "inet: frags: refactor ipv6_frag_init()" This is a

[PATCH 4.4 11/34] ipfrag: really prevent allocation on netns exit

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Paolo Abeni commit f6f2a4a2eb92bc73671204198bb2f8ab53ff59fb upstream. Setting the low threshold to 0 has no effect on frags allocation, we need to clear high_thresh instead. The code was

[PATCH 4.4 23/34] net: modify skb_rbtree_purge to return the truesize of all purged skbs.

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Peter Oskolkov commit 385114dec8a49b5e5945e77ba7de6356106713f4 upstream. Tested: see the next patch is the series. Suggested-by: Eric Dumazet Signed-off-by: Peter Oskolkov Signed-off-by:

[PATCH 4.4 14/34] inet: frags: remove inet_frag_maybe_warn_overflow()

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 2d44ed22e607f9a285b049de2263e3840673a260 upstream. This function is obsolete, after rhashtable addition to inet defrag. Signed-off-by: Eric Dumazet Signed-off-by: David

[PATCH 4.4 12/34] inet: frags: remove some helpers

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 6befe4a78b1553edb6eed3a78b4bcd9748526672 upstream. Remove sum_frag_mem_limit(), ip_frag_mem() & ip6_frag_mem() Also since we use rhashtable we can bring back the number of

[PATCH 4.4 15/34] inet: frags: break the 2GB limit for frags storage

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 3e67f106f619dcfaf6f4e2039599bdb69848c714 upstream. Some users are willing to provision huge amounts of memory to be able to perform reassembly reasonnably well under

[PATCH 4.4 10/34] net: ieee802154: 6lowpan: fix frag reassembly

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Alexander Aring commit f18fa5de5ba7f1d6650951502bb96a6e4715a948 upstream. This patch initialize stack variables which are used in frag_lowpan_compare_key to zero. In my case there are padding

[PATCH 4.4 04/34] inet: frags: refactor ipv6_frag_init()

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 5b975bab23615cd0fdf67af6c9298eb01c4b9f61 upstream. We want to call inet_frags_init() earlier. This is a prereq to "inet: frags: use rhashtables for reassembly units"

[PATCH 4.4 06/34] rhashtable: add rhashtable_lookup_get_insert_key()

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Pablo Neira Ayuso commit 5ca8cc5bf11faed257c762018aea9106d529232f upstream. This patch modifies __rhashtable_insert_fast() so it returns the existing object that clashes with the one that you

[PATCH 4.4 16/34] inet: frags: do not clone skb in ip_expire()

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 1eec5d5670084ee644597bd26c25e22c69b9f748 upstream. An skb_clone() was added in commit ec4fbd64751d ("inet: frag: release spinlock before calling icmp_send()") While fixing

[PATCH 4.4 26/34] ip: use rb trees for IP frag queue.

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Peter Oskolkov commit fa0f527358bd900ef92f925878ed6bfbd51305cc upstream. Similar to TCP OOO RX queue, it makes sense to use rb trees to store IP fragments, so that OOO fragments are inserted

[PATCH 4.4 29/34] ip: frags: fix crash in ip_do_fragment()

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Taehee Yoo commit 5d407b071dc369c26a38398326ee2be53651cfe4 upstream. A kernel crash occurrs when defragmented packet is fragmented in ip_do_fragment(). In defragment routine, skb_orphan() is

[PATCH 4.4 08/34] rhashtable: add schedule points

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit ae6da1f503abb5a5081f9f6c4a6881de97830f3e upstream. Rehashing and destroying large hash table takes a lot of time, and happens in process context. It is safe to add

[PATCH 4.4 33/34] net: ipv4: do not handle duplicate fragments as overlapping

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Michal Kubecek commit ade446403bfb79d3528d56071a84b15351a139ad upstream. Since commit 7969e5c40dfd ("ip: discard IPv4 datagrams with overlapping segments.") IPv4 reassembly code drops the

[PATCH 4.4 32/34] net: fix pskb_trim_rcsum_slow() with odd trim offset

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Dimitris Michailidis commit d55bef5059dd057bd077155375c581b49d25be7e upstream. We've been getting checksum errors involving small UDP packets, usually 59B packets with 1 extra non-zero padding

[PATCH 4.4 27/34] ip: add helpers to process in-order fragments faster.

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Peter Oskolkov commit 353c9cb360874e737fb000545f783df756c06f9a upstream. This patch introduces several helper functions/macros that will be used in the follow-up patch. No runtime changes yet.

[PATCH 4.4 13/34] inet: frags: get rif of inet_frag_evicting()

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 399d1404be660d355192ff4df5ccc3f4159ec1e4 upstream. This refactors ip_expire() since one indentation level is removed. Note: in the future, we should try hard to avoid the

[PATCH 4.4 25/34] net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 88078d98d1bb085d72af8437707279e203524fa5 upstream. After working on IP defragmentation lately, I found that some large packets defeat CHECKSUM_COMPLETE optimization because

[PATCH 4.4 34/34] rcu: Force boolean subscript for expedited stall warnings

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Paul E. McKenney commit ec3833ed02ae6ef2a933ece9de7cbab0c64c699e upstream. The cpu_online() function can return values other than 0 and 1, which can result in subscript overflow when applied

[PATCH 4.4 31/34] inet: frags: better deal with smp races

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 0d5b9311baf27bb545f187f12ecfd558220c607d upstream. Multiple cpus might attempt to insert a new fragment in rhashtable, if for example RPS is buggy, as reported by 배석진 in

[PATCH 4.4 24/34] ipv6: defrag: drop non-last frags smaller than min mtu

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Florian Westphal commit 0ed4229b08c13c84a3c301a08defdc9e7f4467e6 upstream. don't bother with pathological cases, they only waste cycles. IPv6 requires a minimum MTU of 1280 so we should never

[PATCH 4.4 17/34] ipv6: frags: rewrite ip6_expire_frag_queue()

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 05c0b86b9696802fd0ce5676a92a63f1b455bdf3 upstream. Make it similar to IPv4 ip_expire(), and release the lock before calling icmp functions. Signed-off-by: Eric Dumazet

[PATCH 4.4 28/34] ip: process in-order fragments efficiently

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Peter Oskolkov commit a4fd284a1f8fd4b6c59aa59db2185b1e17c5c11c upstream. This patch changes the runtime behavior of IP defrag queue: incoming in-order fragments are added to the end of the

[PATCH 4.4 30/34] ipv4: frags: precedence bug in ip_expire()

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Dan Carpenter commit 70837ffe3085c9a91488b52ca13ac84424da1042 upstream. We accidentally removed the parentheses here, but they are required because '!' has higher precedence than '&'. Fixes:

[PATCH 4.4 22/34] ip: discard IPv4 datagrams with overlapping segments.

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Peter Oskolkov commit 7969e5c40dfd04799d4341f1b7cd266b6e47f227 upstream. This behavior is required in IPv6, and there is little need to tolerate overlapping fragments in IPv4. This change

[PATCH 4.4 19/34] inet: frags: reorganize struct netns_frags

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit c2615cf5a761b32bf74e85bddc223dfff3d9b9f0 upstream. Put the read-mostly fields in a separate cache line at the beginning of struct netns_frags, to reduce false sharing

[PATCH 4.4 09/34] inet: frags: use rhashtables for reassembly units

2019-02-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit 648700f76b03b7e8149d13cc2bdb3355035258a9 upstream. Some applications still rely on IP fragmentation, and to be fair linux reassembly unit is not working under any serious

<    1   2   3   4   5   6   7   8   9   10   >