The mm-of-the-moment snapshot 2019-02-08-16-17 has been uploaded to
http://www.ozlabs.org/~akpm/mmotm/
mmotm-readme.txt says
README for mm-of-the-moment:
http://www.ozlabs.org/~akpm/mmotm/
This is a snapshot of my -mm patch queue. Uploaded at random hopefully
more than once a week.
You
Hi Eric,
On Thu, Feb 07, 2019 at 11:13:59PM -0600, Eric W. Biederman wrote:
> I just noticed this. From my patch queue that I intend to send to
> Linus tomorrow. I think this change fixes your issue of getting
> the SIGSEGV instead of the already pending fatal signal.
>
> So I think this fixes
On module unload/remove, we need to ensure that work does not run
after we have freed resources. Concretely, cancel_delayed_work()
may return while the callback function is still running.
>From kernel/workqueue.c:
The work callback function may still be running on return,
unless it
Hi,
On Wed, Feb 6, 2019 at 11:31 PM Alexandre Belloni
wrote:
>
> Hi,
>
> On 19/01/2019 15:43:31+0100, Martin Blumenstingl wrote:
> > The 32-bit Amlogic Meson SoCs (Meson6, Meson8, Meson8b and Meson8m2)
> > have a built-in RTC block.
> > It has the following inputs:
> > - an 32.768kHz crystal
On Fri, Feb 8, 2019 at 12:31 PM Waiman Long wrote:
>
> > (b) what's the new fastpath case
>
> The only change in the fastpath is the use of cmpxchg for writer lock.
.. since a big deal here was about using the generic atomic accessor
functions, I really was looking forward to seeing the
The upcoming GCC 9 release extends the -Wmissing-attributes warnings
(enabled by -Wall) to C and aliases: it warns when particular function
attributes are missing in the aliases but not in their target, e.g.:
void __cold f(void) {}
void __alias("f") g(void);
diagnoses:
warning: 'g'
The upcoming GCC 9 release extends the -Wmissing-attributes warnings
(enabled by -Wall) to C and aliases: it warns when particular function
attributes are missing in the aliases but not in their target.
In particular, it triggers for all the init/cleanup_module
aliases in the kernel (defined by
The upcoming GCC 9 release extends the -Wmissing-attributes warnings
(enabled by -Wall) to C and aliases: it warns when particular function
attributes are missing in the aliases but not in their target.
In particular, it triggers here because crc32_le_base/__crc32c_le_base
aren't __pure while
>From the GCC manual:
copy
copy(function)
The copy attribute applies the set of attributes with which function
has been declared to the declaration of the function to which
the attribute is applied. The attribute is designed for libraries
that define aliases or function
Fix NULL pointer exception on device unbind when device tree does not
contain "has-touchscreen" property. In such case the input device is
not registered so it should not be unregistered.
$ echo "12d1.adc" > /sys/bus/platform/drivers/exynos-adc/unbind
Unable to handle kernel NULL
t;
> The barriers were removed after adding xmit_more handling. Therefore it would
> be good to
> test also with only
> bd7153bd83b806bfcc2e79b7a6f43aa653d06ef3 r8169: remove unneeded mmiowb
> barriers
> removed.
*arghh* *grmbl*
with both:
bd7153bd83b806bfcc2e79b7a6f43aa
On Thu, Feb 7, 2019 at 11:54 AM Jessica Yu wrote:
>
> My order of preference would be 2, 1, striving for 3 eventually.
For reference, for 3), we would need to tweak the following ~130
modules [1]. Quite a lot of them are the simple kind. Also, if we end
up with 3), we could potentially remove a
On Thu, Feb 07, 2019 at 01:19:01PM +0200, Adrian Hunter wrote:
> Subject to memory pressure and other limits, retain executable code, such
> as JIT-compiled bpf, in memory instead of freeing it immediately it is no
> longer needed for execution.
>
> While perf is primarily aimed at statistical
The following changes since commit f17b5f06cb92ef2250513a1e154c47b78df07d40:
Linux 5.0-rc4 (2019-01-27 15:18:05 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git armsoc-fixes-5.0
for you to fetch changes up to
From: Nicolas Ferre
Date: Wed, 6 Feb 2019 18:56:08 +0100
> This removes a line left while adding the correct compatibility string for
> sama5d3 10/100 interface. Now use the "atmel,sama5d3-macb" string.
>
> Signed-off-by: Nicolas Ferre
> Reviewed-by: Rob Herring
Applied to net-next.
On Fri, 8 Feb 2019 17:46:39 -0500 Waiman Long wrote:
> On 02/08/2019 05:32 PM, Andrew Morton wrote:
> > On Fri, 08 Feb 2019 14:48:03 +0100 Thomas Gleixner
> > wrote:
> >
> >> Waiman reported that on large systems with a large amount of interrupts the
> >> readout of /proc/stat takes a long
From: Nicolas Ferre
Date: Wed, 6 Feb 2019 18:56:09 +0100
> Add the compatibility sting documentation for sam9x60 10/100 interface.
>
> Signed-off-by: Nicolas Ferre
Applied to net-next.
From: Nicolas Ferre
Date: Wed, 6 Feb 2019 18:56:10 +0100
> Add a new compatibility string for this product. It's using
> at91sam9260-macb layout but has a newer hardware revision: it's safer
> to use its own string.
>
> Signed-off-by: Nicolas Ferre
Applied to net-next.
Hi Maxime,
On Wed, Feb 06, 2019 at 10:16:05PM +0100, Maxime Ripard wrote:
> Hi Sakari,
>
> Thanks for your review, I have a few questions though, and the rest
> will be addressed in the next version.
>
> On Tue, Jan 29, 2019 at 02:39:49PM +0200, Sakari Ailus wrote:
> > > +static int
John,
Just noticed this while inspecting the resulting complete diff:
> static u32 get_prot_chk_msk_v3_hw(struct scsi_cmnd *scsi_cmnd)
> {
> unsigned char prot_flags = scsi_cmnd->prot_flags;
>
> - if (prot_flags & SCSI_PROT_TRANSFER_PI) {
> - if (prot_flags &
John,
> This patchset introduces the following:
> - DIX support for v3 hw
Applied to 5.1/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
On 02/08/2019 01:50 PM, Heiner Kallweit wrote:
> On 08.02.2019 22:45, Sander Eikelenboom wrote:
>> On 08/02/2019 22:22, Heiner Kallweit wrote:
>>> On 08.02.2019 21:55, Sander Eikelenboom wrote:
On 08/02/2019 19:52, Heiner Kallweit wrote:
> On 08.02.2019 19:29, Sander Eikelenboom wrote:
I messed up the $SUBJECT line on this one, new subject for reference
On Sat, Feb 9, 2019 at 12:05 AM Arnd Bergmann wrote:
>
> The following changes since commit 1c7fc5cbc33980acd13d668f1c8f0313d6ae9fd8:
>
> Linux 5.0-rc2 (2019-01-14 10:41:12 +1200)
>
> are available in the Git repository at:
>
The QMX86 is a PLD present on some TQ-Systems ComExpress modules. It
provides 1 or 2 I2C bus masters, 8 GPIOs and a watchdog timer. Add an
MFD which will instantiate the individual drivers.
Signed-off-by: Andrew Lunn
---
v2:
Drop setting i2c bus speed, which removes the build dependencies on
tty_set_termios() has the following WARN_ON which can be triggered with a
syscall to invoke TIOCSETD __NR_ioctl.
WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY &&
tty->driver->subtype == PTY_TYPE_MASTER);
Reference:
Odroid HC1 uses the exynos5422-odroid-core.dtsi file as a base. All
other Exynos5422 Odroids use the "common". The ADC node was defined
only in the latter.
Signed-off-by: Krzysztof Kozlowski
---
arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 5 +
The following changes since commit 1c7fc5cbc33980acd13d668f1c8f0313d6ae9fd8:
Linux 5.0-rc2 (2019-01-14 10:41:12 +1200)
are available in the Git repository at:
git://git.kernel.org:/pub/scm/linux/kernel/git/arnd/playground.git
tags/y2038-new-syscalls
for you to fetch changes up to
The following changes since commit 1c7fc5cbc33980acd13d668f1c8f0313d6ae9fd8:
Linux 5.0-rc2 (2019-01-14 10:41:12 +1200)
are available in the Git repository at:
git://git.kernel.org:/pub/scm/linux/kernel/git/arnd/playground.git
tags/y2038-syscall-cleanup
for you to fetch changes up to
On 2/8/19 1:11 AM, Christoph Hellwig wrote:
+* We don't support running Linux on hertergenous ISA systems.
+* But first "okay" processor might not be the boot cpu.
+* Check the ISA of boot cpu.
Please use up your available 80 characters per line in comments.
I will
On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote:
> From: Jonas Rabenstein
>
> Check whether the shadow mbr does fit in the provided space on the
> target. Also a proper firmware should handle this case and return an
> error we may prevent problems or even damage with crappy firmwares.
>
>
Looks good
Reviewed-by: Jon Derrick
On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote:
> As the function is responsible for executing the individual steps supplied
> in the steps argument, execute_steps is a more descriptive name than the
> rather generic next.
>
> Signed-off-by: David
On Mon, 2019-02-04 at 23:44 +0100, David Kozub wrote:
> On Mon, 4 Feb 2019, Christoph Hellwig wrote:
>
> > > + /* first do a discovery0 */
> > > + error = opal_discovery0_step(dev);
> > >
> > > + for (state = 0; !error && state < n_steps; state++)
> > > + error = execute_step(dev,
Looks good
Reviewed-by: Jon Derrick
On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote:
> From: Jonas Rabenstein
>
> Instead of having multiple places defining the same argument list to get
> a specific column of a sed-opal table, provide a generic version and
> call it from those
Looks good otherwise
Reviewed-by: Jon Derrick
On Mon, 2019-02-04 at 21:28 +0100, David Kozub wrote:
> On Mon, 4 Feb 2019, Christoph Hellwig wrote:
>
> > On Fri, Feb 01, 2019 at 09:50:08PM +0100, David Kozub wrote:
> > > This should make no change in functionality.
> > > The formatting changes
Looks good
Reviewed-by Jon Derrick
On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote:
> From: Jonas Rabenstein
>
> Split the header generation from the (normal) memcpy part if a
> bytestring is copied into the command buffer. This allows in-place
> generation of the bytestring content. For
On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote:
> From: Jonas Rabenstein
>
> Allow modification of the shadow mbr. If the shadow mbr is not marked as
> done, this data will be presented read only as the device content. Only
> after marking the shadow mbr as done and unlocking a locking
Looks good
Reviewed-by: Jon Derrick
On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote:
> From: Jonas Rabenstein
>
> Also the values of OPAL_UID_LENGTH and OPAL_METHOD_LENGTH are the same,
> it is weird to use OPAL_UID_LENGTH for the definition of the methods.
>
> Signed-off-by: Jonas
Looks fine with 4/16
Acked-by: Jon Derrick
On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote:
> Every step starts with resetting the cmd buffer as well as the comid and
> constructs the appropriate OPAL_CALL command. Consequently, those
> actions may be combined into one generic function. On
Looks good
Reviewed-by: Jon Derrick
On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote:
> response_get_token had already been in place, its functionality had
> been duplicated within response_get_{u64,bytestring} with the same error
> handling. Unify the handling by reusing response_get_token
Normally I wouldn't like decreasing the readability (having a STARTLIST
without an ENDLIST in the same function), but this makes a lot of sense
with 5/16
Acked-by: Jon Derrick
On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote:
> Every step ends by calling cmd_finalize (via finalize_and_send)
On Mon, 2019-02-04 at 22:07 +0100, David Kozub wrote:
> On Mon, 4 Feb 2019, Christoph Hellwig wrote:
>
> > On Fri, Feb 01, 2019 at 09:50:10PM +0100, David Kozub wrote:
> > > From: Jonas Rabenstein
> > >
> > > All add_token_* functions have a common set of conditions that have to
> > > be
On 2/8/19 1:03 AM, Christoph Hellwig wrote:
On Thu, Feb 07, 2019 at 05:51:15PM -0800, Atish Patra wrote:
Currently, logical CPU id to physical hartid mapping is
defined for both smp and non-smp configurations. This
is not required as we need this only for smp configuration.
The mapping function
On 2/8/19 1:04 AM, Christoph Hellwig wrote:
On Thu, Feb 07, 2019 at 05:51:19PM -0800, Atish Patra wrote:
Currently, clocksource registration happens for an invalid cpu
for non-smp kernels. This lead to kernel panic as cpu hotplug
registration will fail for those cpus. Moreover,
On February 8, 2019 17:35, Jeff King wrote:
> On Fri, Feb 08, 2019 at 05:12:43PM -0500, Randall S. Becker wrote:
> > On February 8, 2019 17:07, brian m. carlson wrote:
> > > On Fri, Feb 08, 2019 at 02:31:57PM -0500, Jeff King wrote:
> > > > > It is available AFAIK on Linux, POSIX, and Windows
On Fri, 8 Feb 2019 13:50:49 +0100 Jan Kara wrote:
> > > Has anyone done significant testing with Rik's maybe-fix?
> >
> > I will give it a spin with bonnie++ today. We'll see what comes out.
>
> OK, I did a bonnie++ run with Rik's patch (on top of 4.20 to rule out other
> differences). This
On 02/08/2019 05:32 PM, Andrew Morton wrote:
> On Fri, 08 Feb 2019 14:48:03 +0100 Thomas Gleixner wrote:
>
>> Waiman reported that on large systems with a large amount of interrupts the
>> readout of /proc/stat takes a long time to sum up the interrupt
>> statistics. In principle this is not a
memory.stat and other files already consider subtrees in their output,
and we should too in order to not present an inconsistent interface.
The current situation is fairly confusing, because people interacting
with cgroups expect hierarchical behaviour in the vein of memory.stat,
cgroup.events,
I spent literally an hour trying to work out why an earlier version of
my memory.events aggregation code doesn't work properly, only to find
out I was calling memcg->events instead of memcg->memory_events, which
is fairly confusing.
This naming seems in need of reworking, so make it harder to do
On Fri, 8 Feb 2019 13:45:47 +0200 Mike Rapoport wrote:
> * Remove comments mentioning bootmem
> * Extend "DOC: memblock overview"
> * Add kernel-doc comments for several more functions
>
> ...
>
> @@ -1400,6 +1413,19 @@ phys_addr_t __init
> memblock_phys_alloc_range(phys_addr_t size,
>
Marc,
>> - compatible: must contain "jedec,ufs-1.1" or "jedec,ufs-2.0", may
>> also list one or more of the following:
>> "qcom,msm8994-ufshc"
>> "qcom,msm8996-ufshc"
>> "qcom,ufshc"
Applied to 5.1/scsi-queue, thanks!
--
Martin
On February 8, 2019 17:19, brian m. carlson wrote:
> On Fri, Feb 08, 2019 at 05:12:43PM -0500, Randall S. Becker wrote:
> > I'm happy to modify the test (it is in one spot), to make a decision based
> on:
> > a) whether /dev/zero exists
> > b) whether the system is a NonStop
> > c) something else
After 'commit e22c1c751140 ("perf thread: Don't include symbol.h,
symbol_conf.h is enough")'
Compilation of the perf tools is broken when using the functionality
provided by the openCSD library:
[...]
... timerfd: [ on ]
... sched_getcpu: [ on ]
...
On Fri, Feb 08, 2019 at 05:12:43PM -0500, Randall S. Becker wrote:
> On February 8, 2019 17:07, brian m. carlson wrote:
> > On Fri, Feb 08, 2019 at 02:31:57PM -0500, Jeff King wrote:
> > > > It is available AFAIK on Linux, POSIX, and Windows under Cygwin.
> > > > That's more than /dev/zero has
Nathan,
> Clang warns several times in the scsi subsystem (trimmed for brevity):
Applied to 5.1/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
On Fri, 08 Feb 2019 14:48:03 +0100 Thomas Gleixner wrote:
> Waiman reported that on large systems with a large amount of interrupts the
> readout of /proc/stat takes a long time to sum up the interrupt
> statistics. In principle this is not a problem. but for unknown reasons
> some enterprise
On Fri, 8 Feb 2019 05:01:12 -0500
Kimberly Brown wrote:
You are right, the current behavior is broken.
It would be good to add a description of under what conditions
monitor is not used. Is this some part of a project emulating
Hyper-V?
> +
> + if
On Fri, Feb 08, 2019 at 04:31:39PM +, David Howells wrote:
> Mike Kravetz wrote:
>
> > Thanks for fixing this. Looks like a simple oversight when 2284cf59cbce
> > was added.
>
> I've already pushed a fix for this which Al should have folded in already.
It has been in -next since Tuesday.
On Fri, 8 Feb 2019 04:58:52 -0500
Kimberly Brown wrote:
> Change the monitor_pages index in server_monitor_pending_show() to '0'.
> '0' is the correct monitor_pages index for the server. A comment for the
> monitor_pages field in the vmbus_connection struct definition indicates
> that the 1st
Add "qcom,msm8998-ufshc" compatible string.
Signed-off-by: Marc Gonzalez
---
Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
On Fri, Feb 08, 2019 at 02:00:15PM -0800, a...@linux-foundation.org wrote:
> +#define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
Major ACK. Stating invariants is why userspace assert() was always
better.
Use same init sequence as sdm845.
Reviewed-by: Jeffrey Hugo
Signed-off-by: Marc Gonzalez
---
drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c
b/drivers/phy/qualcomm/phy-qcom-qmp.c
index daf751500232..08d6f6f7f039
Add compatible string for QMP UFS phy on msm8998.
Signed-off-by: Marc Gonzalez
---
Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
From: Douglas Anderson
If you look at the bindings for the UFS Host Controller it says:
- compatible: must contain "jedec,ufs-1.1" or "jedec,ufs-2.0", may
also list one or more of the following:
"qcom,msm8994-ufshc"
"qcom,msm8996-ufshc"
Hello,
This series adds support for the UFS host controller on
APQ8098/MSM8998-based boards.
I CCed the regulator maintainers to discuss the revert in
patch 6. Basically, the original patch added a quirk which
forcefully disables vccq when the UFSHC is connected to a
Samsung or Hynix Flash chip.
On Thu, Jan 17, 2019 at 03:34:44PM -0500, Richard Guy Briggs wrote:
> On 2019-01-09 15:40, Dmitry V. Levin wrote:
> > syscall_get_arch() is required to be implemented on all architectures in
> > order
> > to extend the generic ptrace API with PTRACE_GET_SYSCALL_INFO request:
> >
FROM MR.DABIRE BASSOLE
AUDIT& ACCOUNT MANAGER
BANK OF AFRICA (B.O.A)
OUAGADOUGOU BURKINA FASO
WEST AFRICA.
Dear Friend,
With due respect, I have decided to contact you on a business
transaction that will be beneficial to both of us. At the bank last
account and auditing evaluation, my staffs
On Fri, Feb 08, 2019 at 05:12:43PM -0500, Randall S. Becker wrote:
> I'm happy to modify the test (it is in one spot), to make a decision based on:
> a) whether /dev/zero exists
> b) whether the system is a NonStop
> c) something else
>
> What would you all prefer? It doesn't matter to me one way
Hi Daniel/Stephen
Thanks for the report and the hints how to move forward to fix it.
> Sam, can you pls take a look at what komeda needs? you need to
> manually merge together drm-misc-next and drm-next first I think.
Merged the two tree and fixed build.
Undid the merge and checked that the
On Fri, Feb 08, 2019 at 02:31:57PM -0500, Jeff King wrote:
> > It is available AFAIK on Linux, POSIX, and Windows under Cygwin.
> > That's more than /dev/zero has anyway. I have the patch ready if you
> > want it.
>
> Is it POSIX? Certainly truncate() is, but I didn't think the
> command-line
On February 8, 2019 17:07, brian m. carlson wrote:
> On Fri, Feb 08, 2019 at 02:31:57PM -0500, Jeff King wrote:
> > > It is available AFAIK on Linux, POSIX, and Windows under Cygwin.
> > > That's more than /dev/zero has anyway. I have the patch ready if you
> > > want it.
> >
> > Is it POSIX?
Hi Joe,
Joe Perches wrote on Fri, 08 Feb 2019 01:23:37 -0800:
> On Fri, 2019-02-08 at 17:08 +0900, Masahiro Yamada wrote:
> > Use 'bool' type for some function arguments.
> >
> > - write (write or read?)
> > - raw (the raw access mode or not?)
> >
> > It is true that
On 2/8/19 5:00 PM, Jarkko Sakkinen wrote:
On Fri, Feb 08, 2019 at 04:21:02PM -0500, Stefan Berger wrote:
I still think that in 5/5 branching could be better but is not a biggie
for me (does not make the implementation as whole any kind of mess) and
since it is now peer tested I rather would not
From: Bjorn Helgaas
domain_remove_dev_info() takes a struct dmar_domain * argument, but doesn't
use it. Remove it. No functional change intended.
The last use of this argument was removed by 127c761598f7 ("iommu/vt-d:
Pass device_domain_info to __dmar_remove_one_dev_info").
Signed-off-by:
From: Bjorn Helgaas
Use dev_printk() when possible so the IOMMU messages are more consistent
with other messages related to the device.
Signed-off-by: Bjorn Helgaas
---
drivers/iommu/amd_iommu.c | 25 +++--
drivers/iommu/amd_iommu_init.c | 20 ++--
On Sun, Feb 3, 2019 at 10:35 PM Oded Gabbay wrote:
>
> On Sun, Feb 3, 2019 at 1:50 PM Mike Rapoport wrote:
> >
> > Hi Oded,
> >
> > On Thu, Jan 31, 2019 at 12:06:02AM +0200, Oded Gabbay wrote:
> > > Hello,
> > > This is v2 of the Habana Labs kernel driver patch-set. It contains fixes
> > > for
On Fri, Feb 8, 2019 at 1:38 PM Michael S. Tsirkin wrote:
>
> On Fri, Feb 08, 2019 at 03:41:55PM -0500, Nitesh Narayan Lal wrote:
> > >> I am also planning to try Michael's suggestion of using MAX_ORDER - 1.
> > >> However I am still thinking about a workload which I can use to test its
> > >>
Hi Masahiro,
Masahiro Yamada wrote on Fri, 8 Feb
2019 17:08:50 +0900:
> Currently, wait_for_completion_timeout() is always passed in the
> hard-coded msec_to_jiffies(1000). There is no specific reason for
> 1000 msec, but I just chose it long enough.
>
> With the exec_op() conversion,
On Fri, 8 Feb 2019 21:45:21 +0200 Andy Shevchenko
wrote:
> On Tue, Oct 30, 2018 at 5:22 PM David Engraf wrote:
> >
> > Unpacking an external initrd may fail e.g. not enough memory. This leads
> > to an incomplete rootfs because some files might be extracted already.
> > Fixed by cleaning the
From: Bjorn Helgaas
Simplify control flow by returning immediately when we know the result.
No functional change intended.
Signed-off-by: Bjorn Helgaas
---
drivers/iommu/intel-iommu.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git
From: Bjorn Helgaas
Use dev_printk() when possible so the IOMMU messages are more consistent
with other messages related to the device.
Signed-off-by: Bjorn Helgaas
---
drivers/iommu/intel-iommu.c | 54 +++
1 file changed, 24 insertions(+), 30
From: Bjorn Helgaas
The "Domain 0 is reserved, so dont process it" comment suggests that a NULL
pointer corresponds to domain 0. I don't think that's true, and in any
case, every caller supplies a non-NULL domain pointer that has already been
dereferenced, so the test is unnecessary.
Remove
From: Bjorn Helgaas
A local variable initialization is a hint that the variable will be used in
an unusual way. If the initialization is unnecessary, that hint becomes a
distraction.
Remove unnecessary initializations. No functional change intended.
Signed-off-by: Bjorn Helgaas
---
From: Bjorn Helgaas
Use dev_printk() when possible so the IOMMU messages are more consistent
with other messages related to the device.
E.g., I think these messages related to surprise hotplug:
pciehp :80:10.0:pcie004: Slot(36): Link Down
iommu: Removing device :87:00.0 from group
I've had these minor iommu cleanups lying around for a while, but the ugly
dmesg logs from [1] prompted me to finally post them. Take what you like,
ignore the rest, and tell me so I can clear out my queue of old stuff.
These fix no actual bugs.
[1]
On Fri, Feb 08, 2019 at 04:21:02PM -0500, Stefan Berger wrote:
> On 1/18/19 10:00 AM, Jarkko Sakkinen wrote:
> > On Fri, Jan 11, 2019 at 08:28:00PM +, Safford, David (GE Global
> > Research) wrote:
> > > You might mention that this is an important feature, as on at least some
> > > systems,
Hi Masahiro,
Masahiro Yamada wrote on Fri, 8 Feb
2019 17:08:49 +0900:
> I will add the third argument to denali_wait_for_irq() in the
> following commit. Then, some lines will exceed 80 columns.
>
> Rename 'irq_status' to 'irq_stat'. Saving two characters will avoid
> line-wrapping in some
On Thu, 7 Feb 2019, Eric W. Biederman wrote:
> The usb support for asyncio encoded one of it's values in the wrong
> field. It should have used si_value but instead used si_addr which is
> not present in the _rt union member of struct siginfo.
>
> The result is a POSIX and glibc incompatible
On Fri, Feb 08, 2019 at 12:44:51PM -0800, Guenter Roeck wrote:
> Yes, the kernel boots if I comment out that function and have it return 0.
Thanks, this localizes the issue significantly.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
Hi Masahiro,
Masahiro Yamada wrote on Fri, 8 Feb
2019 17:08:44 +0900:
> I took time for the Denali driver to catch up with the latest framework.
>
> - switch over to exec_op() and remove legacy hooks
>
> - separate controller/chips
>
> - various cleanups
>
What you do is very much
On Fri, Feb 08, 2019 at 04:43:37PM -0500, Michael S. Tsirkin wrote:
> Coding style violation: if a linux/foo.h exists then it must
> be included in preference to asm/foo.h
>
> And the specific issue is that a follow-up patch moves code from
> asm/mman.h to linux/mman.h so if any one was
On 2/8/19 1:43 PM, Michael S. Tsirkin wrote:
> On Fri, Feb 08, 2019 at 04:42:39PM +0100, Borislav Petkov wrote:
>> On Fri, Feb 08, 2019 at 01:02:53AM -0500, Michael S. Tsirkin wrote:
>>> Use linux/mman.h to make sure we get all mmap flags we need.
>> Why, asm/mman.h is not enough or is this fixing
it would be good to test with only the barrier-removal
removed.
> --
> Sander
>
Heiner
>
>>
>>> would be candidates, which were merged in 5.0.
>>>
>>> I have reverted the first two, see how that works out.
>>>
>>> --
>>> San
On Fri, Feb 08, 2019 at 04:18:40PM -0500, Stefan Berger wrote:
> On 2/8/19 3:46 PM, Jarkko Sakkinen wrote:
> > On Fri, Feb 08, 2019 at 03:32:32PM -0500, Stefan Berger wrote:
> > >
> > > tpm_del_char_device also needs the start/stop!
> > Done and updated the commit message to have all the call
On Fri, Feb 8, 2019 at 2:52 AM Tetsuo Handa
wrote:
>
> On 2019/02/08 1:24, Casey Schaufler wrote:
> Then, I think that it is straightforward (and easier to manage) to
> ignore security= parameter
> when lsm= parameter is specified.
> >>> That reduces flexibility somewhat. If I am
On Wed, Jan 16, 2019 at 11:39:58AM -0800, Jae Hyun Yoo wrote:
> In multi-master environment, this driver's master cannot know
> exactly when a peer master sends data to this driver's slave so
> cases can be happened that this master tries sending data through
> the master_xfer function but slave
Hi Masahiro,
Masahiro Yamada wrote on Fri, 8 Feb
2019 17:35:32 +0900:
> HI Miquel,
>
> On Thu, Feb 7, 2019 at 10:02 PM Miquel Raynal
> wrote:
> >
> > Hi Masahiro,
> >
> > Masahiro Yamada wrote on Thu, 7 Feb
> > 2019 19:46:54 +0900:
> >
> > > On Thu, Feb 7, 2019 at 7:16 PM Miquel Raynal
On Fri, Feb 8, 2019 at 11:43 PM Joe Perches wrote:
>
> On Fri, 2019-02-08 at 23:33 +0200, Oded Gabbay wrote:
> > On Wed, Feb 6, 2019 at 1:52 PM Mike Rapoport wrote:
> > > On Mon, Feb 04, 2019 at 10:32:39PM +0200, Oded Gabbay wrote:
> > > > Hello,
> > > > This is v3 of the Habana Labs kernel
be considered at
this point in the RC's
to revert them for 5.0 and try again for 5.1 ?
--
Sander
>
>> would be candidates, which were merged in 5.0.
>>
>> I have reverted the first two, see how that works out.
>>
>> --
>> Sander
>>
> Heiner
>
&g
On Fri, Feb 08, 2019 at 04:42:39PM +0100, Borislav Petkov wrote:
> On Fri, Feb 08, 2019 at 01:02:53AM -0500, Michael S. Tsirkin wrote:
> > Use linux/mman.h to make sure we get all mmap flags we need.
>
> Why, asm/mman.h is not enough or is this fixing a build issue or what is that
> patch
On Fri, 2019-02-08 at 23:33 +0200, Oded Gabbay wrote:
> On Wed, Feb 6, 2019 at 1:52 PM Mike Rapoport wrote:
> > On Mon, Feb 04, 2019 at 10:32:39PM +0200, Oded Gabbay wrote:
> > > Hello,
> > > This is v3 of the Habana Labs kernel driver patch-set. It contains minor
> > > fixes
> > > according to
101 - 200 of 1100 matches
Mail list logo
