Re: [PATCH 3/3] imx8mq.dtsi: add the sdma nodes

2019-02-22 Thread Daniel Baluta
Hi Angus, What is the status of this patch? Most likely this should go through Shwan's tree. I noticed that I have also sent a similar patch to Shawn: https://www.spinics.net/lists/arm-kernel/msg708424.html So, lets coordinate and work better on this. I am now preparing another series where I

Re: [PATCH V3 2/2] dt-bindings: imx: add new resources to scu resource table

2019-02-22 Thread Rob Herring
On Wed, 20 Feb 2019 14:35:06 +, Anson Huang wrote: > Add new resources as below according to latest system > controller firmware for new features: > > IMX_SC_R_PERF > IMX_SC_R_OCRAM > IMX_SC_R_DMA_5_CH0 > IMX_SC_R_DMA_5_CH1 > IMX_SC_R_DMA_5_CH2 >

Re: [PATCH v3 0/8] nic: thunderx: fix communication races between VF & PF

2019-02-22 Thread David Miller
From: Vadim Lomovtsev Date: Wed, 20 Feb 2019 11:02:42 + > The ThunderX CN88XX NIC Virtual Function driver uses mailbox interface > to communicate to physical function driver. Each of VF has it's own pair > of mailbox registers to read from and write to. The mailbox registers > has no

Re: [PATCH 6/6] perf thread-stack: Hide x86 retpolines

2019-02-22 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 09, 2019 at 11:18:35AM +0200, Adrian Hunter escreveu: > x86 retpoline functions pollute the call graph by showing up everywhere > there is an indirect branch, but they do not really mean anything. Make > changes so that the default retpoline functions will no longer appear in > the

[v6 PATCH 3/6] RISC-V: Remove NR_CPUs check during hartid search from DT

2019-02-22 Thread Atish Patra
In non-smp configuration, hartid can be higher that NR_CPUS. riscv_of_processor_hartid should not be compared to hartid to NR_CPUS in that case. Moreover, this function checks all the DT properties of a hart node. NR_CPUS comparison seems out of place. Signed-off-by: Atish Patra Reviewed-by:

[v6 PATCH 0/6] Various SMP related fixes

2019-02-22 Thread Atish Patra
The existing upstream kernel doesn't boot for non-smp configuration. This patch series address various issues with non-smp configurations. The patch series is based on 5.0-rc7 + Johan's below mentioned patch series. Tested on both QEMU and HiFive Unleashed board using both OpenSBI & BBL.

[v6 PATCH 4/6] RISC-V: Allow hartid-to-cpuid function to fail.

2019-02-22 Thread Atish Patra
It is perfectly okay to call riscv_hartid_to_cpuid for a hartid that is not mapped with an CPU id. It can happen if the calling functions retrieves the hartid from DT. However, that hartid was never brought online by the firmware or kernel for any reasons. No need to BUG() in the above case. A

[v6 PATCH 2/6] RISC-V: Move cpuid to hartid mapping to SMP.

2019-02-22 Thread Atish Patra
Currently, logical CPU id to physical hartid mapping is defined for both smp and non-smp configurations. This is not required as we need this only for smp configuration. The mapping function can define directly boot_cpu_hartid for non-smp use case. The reverse mapping function i.e. hartid to

[v6 PATCH 1/6] RISC-V: Do not wait indefinitely in __cpu_up

2019-02-22 Thread Atish Patra
In SMP path, __cpu_up waits for other CPU to come online indefinitely. This is wrong as other CPU might be disabled in machine mode and possible CPU is set to the cpus present in DT. Introduce a completion variable and waits only for a second. Signed-off-by: Atish Patra Reviewed-by: Anup Patel

[v6 PATCH 5/6] RISC-V: Compare cpuid with NR_CPUS before mapping.

2019-02-22 Thread Atish Patra
We should never have a cpuid greater that NR_CPUS. Compare with NR_CPUS before creating the mapping between logical and physical CPU ids. This is also mandatory as NR_CPUS check is removed from riscv_of_processor_hartid. Signed-off-by: Atish Patra Reviewed-by: Anup Patel Reviewed-by: Christoph

[v6 PATCH 6/6] RISC-V: Assign hwcap as per comman capabilities.

2019-02-22 Thread Atish Patra
Currently, we set hwcap based on first valid hart from DT. This may not be correct always as that hart might not be current booting cpu or may have a different capability. Set hwcap as the capabilities supported by all possible harts with "okay" status. Signed-off-by: Atish Patra ---

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-22 Thread Steven Rostedt
On Fri, 22 Feb 2019 11:34:58 -0800 Alexei Starovoitov wrote: > so you're saying you will break existing kprobe scripts? Yes we may. > I don't think it's a good idea. > It's not acceptable to break bpf_probe_read uapi. Then you may need to add more code to determine if the address is user

Re: [PATCH] r8152: Fix an error on RTL8153-BD MAC Address Passthrough support

2019-02-22 Thread David Miller
From: David Chen Date: Wed, 20 Feb 2019 13:47:19 +0800 > From: David Chen > > RTL8153-BD is used in Dell DA300 type-C dongle. > Added RTL8153-BD support to activate MAC address pass through on DA300. > Apply correction on previously submitted patch in net.git tree. > > Signed-off-by: David

[PATCH v6 7/7] ARM: tegra: Add firmware calls required for suspend-resume on Tegra30

2019-02-22 Thread Dmitry Osipenko
In order to suspend-resume CPU with Trusted Foundations firmware being present on Tegra30, the LP1/LP2 boot vectors and CPU caches need to be set up using the firmware calls and then suspend code shall avoid re-disabling parts that were disabled by the firmware. Signed-off-by: Dmitry Osipenko

Re: [PATCH] rpmsg: virtio_rpmsg_bus: acknowledge the received creation message

2019-02-22 Thread xiang xiao
Thanks for review. On Fri, Feb 22, 2019 at 6:44 PM Arnaud Pouliquen wrote: > > Hello Xiang, > > > > On 2/12/19 8:13 AM, Xiang Xiao wrote: > > From: QianWenfa > > > > the two phase handsake make the client could initiate the transfer > > immediately without the server side send any dummy message

[PATCH v6 6/7] ARM: tegra: Always boot CPU in ARM-mode

2019-02-22 Thread Dmitry Osipenko
CPU always jumps into reset handler in ARM-mode from the Trusted Foundations firmware, hence let's make CPU to always jump into kernel in ARM-mode regardless of the firmware presence. This is required to make Thumb-2 kernel working with the Trusted Foundations firmware on Tegra30. Signed-off-by:

[PATCH v6 5/7] ARM: tegra: Don't apply CPU erratas in insecure mode

2019-02-22 Thread Dmitry Osipenko
CPU isn't allowed to touch secure registers while running under secure monitor. Hence skip applying of CPU erratas in the reset handler if Trusted Foundations firmware presents. Partially based on work done by Michał Mirosław [1]. [1] https://www.spinics.net/lists/arm-kernel/msg594768.html

[PATCH v6 3/7] ARM: trusted_foundations: Provide information about whether firmware is registered

2019-02-22 Thread Dmitry Osipenko
Add a helper that provides information about whether Trusted Foundations firmware operations have been registered. Signed-off-by: Dmitry Osipenko --- arch/arm/firmware/trusted_foundations.c| 5 + arch/arm/include/asm/trusted_foundations.h | 7 +++ 2 files changed, 12 insertions(+)

[PATCH v6 4/7] ARM: tegra: Set up L2 cache using Trusted Foundations firmware

2019-02-22 Thread Dmitry Osipenko
On Tegra30 L2 cache should be initialized using firmware call if CPU is running in insecure mode. Set up the required outer-cache write_sec() callback early during boot using the firmware API, it is always a NO-OP on T114+ and is NO-OP on T20/30 if Trusted Foundations firmware node isn't present

[PATCH v6 1/7] ARM: trusted_foundations: Implement L2 cache initialization callback

2019-02-22 Thread Dmitry Osipenko
Implement L2 cache initialization firmware callback that should be invoked early during boot in order to set up the required outer cache driver's callbacks. Partially based on work done by Michał Mirosław [1]. [1] https://www.spinics.net/lists/arm-kernel/msg594765.html Signed-off-by: Dmitry

[PATCH v6 2/7] ARM: trusted_foundations: Make prepare_idle call to take mode argument

2019-02-22 Thread Dmitry Osipenko
The Trusted Foundations firmware call varies depending on the required suspend-mode. Make the firmware API to take the mode argument in order to expose all of the modes to firmware user. Signed-off-by: Dmitry Osipenko --- arch/arm/firmware/trusted_foundations.c| 29 --

[PATCH v6 0/7] Support Trusted Foundations firmware on Tegra30

2019-02-22 Thread Dmitry Osipenko
Hello, This patchset adds support for the Trusted Foundations firmware on NVIDIA Tegra30. Pretty much all of Tegra30 consumer devices have that firmware and upstream kernel can't boot on those devices without the firmware support. Changelog: v6: - One patch got messed up accidentally in v5,

Re: [PATCH v4 1/3] dt-bindings: phy: Add Stingray USB PHY binding document

2019-02-22 Thread Rob Herring
On Fri, Feb 22, 2019 at 11:29 AM Srinath Mannam wrote: > > Hi Rob, > > Thanks for the review, Please find my comments below in line. > > On Fri, Feb 22, 2019 at 10:50 PM Rob Herring wrote: > > > > On Wed, Feb 20, 2019 at 04:04:00PM +0530, Srinath Mannam wrote: > > > Add DT binding document for

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-22 Thread Alexei Starovoitov
On Fri, Feb 22, 2019 at 02:30:26PM -0500, Steven Rostedt wrote: > On Fri, 22 Feb 2019 11:27:05 -0800 > Alexei Starovoitov wrote: > > > On Fri, Feb 22, 2019 at 09:43:14AM -0800, Linus Torvalds wrote: > > > > > > Then we should still probably fix up "__probe_kernel_read()" to not > > > allow user

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-22 Thread Steven Rostedt
On Fri, 22 Feb 2019 11:27:05 -0800 Alexei Starovoitov wrote: > On Fri, Feb 22, 2019 at 09:43:14AM -0800, Linus Torvalds wrote: > > > > Then we should still probably fix up "__probe_kernel_read()" to not > > allow user accesses. The easiest way to do that is actually likely to > > use the

[PATCH 1/2] habanalabs: don't print result when rc indicates error

2019-02-22 Thread Oded Gabbay
send_cpu_message() doesn't update the result parameter when an error occurs in its code. Therefore, callers of send_cpu_message() shouldn't use the result value when the return code indicates error. This patch fixes a static checker warning in goya_test_cpu_queue(), where that function did print

[PATCH 2/2] habanalabs: driver's Kconfig must select DMA_SHARED_BUFFER

2019-02-22 Thread Oded Gabbay
The driver uses the DMA_BUF module which is built only if DMA_SHARED_BUFFER is selected. DMA_SHARED_BUFFER doesn't have any dependencies so it is ok to select it (as done by many other components). Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/Kconfig | 1 + 1 file changed, 1

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-22 Thread Alexei Starovoitov
On Fri, Feb 22, 2019 at 09:43:14AM -0800, Linus Torvalds wrote: > > Then we should still probably fix up "__probe_kernel_read()" to not > allow user accesses. The easiest way to do that is actually likely to > use the "unsafe_get_user()" functions *without* doing a > uaccess_begin(), which will

Re: [PATCH v2] dt-bindings: Add vendor prefix for techstar

2019-02-22 Thread Jagan Teki
Rob, On Tue, Feb 12, 2019 at 4:57 PM Jagan Teki wrote: > > Add vendor prefix for techstar, known as > Shenzhen Techstar Electronics Co., Ltd. a known producer for LCD modules. > > Signed-off-by: Jagan Teki > --- > Changes for v2: > - rebase for master > >

Re: [RFC][PATCH 00/16] sched: Core scheduling

2019-02-22 Thread Tim Chen
On 2/22/19 6:20 AM, Peter Zijlstra wrote: > On Fri, Feb 22, 2019 at 01:17:01PM +0100, Paolo Bonzini wrote: >> On 18/02/19 21:40, Peter Zijlstra wrote: >>> On Mon, Feb 18, 2019 at 09:49:10AM -0800, Linus Torvalds wrote: On Mon, Feb 18, 2019 at 9:40 AM Peter Zijlstra wrote: > >

Re: [PATCH v5 4/9] mm/mmu_notifier: contextual information for event enums

2019-02-22 Thread Ralph Campbell
On 2/19/19 12:04 PM, jgli...@redhat.com wrote: From: Jérôme Glisse CPU page table update can happens for many reasons, not only as a result s/update/updates s/happens/happen of a syscall (munmap(), mprotect(), mremap(), madvise(), ...) but also as a result of kernel activities (memory

Re: [PATCH v2] kcm: remove any offset before parsing messages

2019-02-22 Thread Tom Herbert
On Thu, Feb 21, 2019 at 12:22 AM Dominique Martinet wrote: > > Tom Herbert wrote on Wed, Feb 20, 2019: > > > When the client closes the socket, some messages are obviously still "in > > > flight", and the server will recv a POLLERR notification on the csock at > > > some point with many messages

Re: [PATCHv6 07/10] acpi/hmat: Register processor domain to its memory

2019-02-22 Thread Dan Williams
On Fri, Feb 22, 2019 at 10:48 AM Keith Busch wrote: > > On Wed, Feb 20, 2019 at 11:02:01PM +0100, Rafael J. Wysocki wrote: > > On Thu, Feb 14, 2019 at 6:10 PM Keith Busch wrote: > > > config ACPI_HMAT > > > bool "ACPI Heterogeneous Memory Attribute Table Support" > > > depends

Re: [v4 PATCH 8/8] RISC-V: Assign hwcap as per comman capabilities.

2019-02-22 Thread Atish Patra
On 2/14/19 3:49 PM, Atish Patra wrote: On 2/13/19 4:38 PM, Palmer Dabbelt wrote: On Wed, 13 Feb 2019 00:44:42 PST (-0800), jo...@kernel.org wrote: On Tue, Feb 12, 2019 at 11:58:10AM -0800, Atish Patra wrote: On 2/12/19 3:25 AM, Johan Hovold wrote: On Tue, Feb 12, 2019 at 03:10:12AM -0800,

Re: [PATCH] arm64: dts: rockchip: Add support for the Orange Pi RK3399 board.

2019-02-22 Thread Rob Herring
On Fri, Feb 22, 2019 at 12:46 PM Alexis Ballier wrote: > > This adds basic support for the Orange Pi RK3399 board. > What works: > - SD card / emmc. > - Debug UART > - Ethernet > - USB: Type C, internal USB3 for SATA, 4 USB 2.0 ports > - Sensors: All of them but the Hall sensor. > - Buttons > -

Re: [PATCH RFC v2 4/4] PCI: hotplug: Add quirk For Dell nvme pcie switches

2019-02-22 Thread Alex_Gagniuc
On 2/21/19 8:05 PM, Oliver wrote: > On Fri, Feb 22, 2019 at 5:38 AM wrote: >> On 2/21/19 1:57 AM, Lukas Wunner wrote: [snip] >>> If the quirk is x86-specific, please enclose it in "#ifdef CONFIG_X86" >>> to reduce kernel footprint on other arches. >> >> That's a tricky one. If you look at p. 185

Re: [PATCH RFC] mm/vmscan: try to protect active working set of cgroup from reclaim.

2019-02-22 Thread Johannes Weiner
On Fri, Feb 22, 2019 at 08:58:25PM +0300, Andrey Ryabinin wrote: > In a presence of more than 1 memory cgroup in the system our reclaim > logic is just suck. When we hit memory limit (global or a limit on > cgroup with subgroups) we reclaim some memory from all cgroups. > This is sucks because,

Re: [PATCH net] net: socket: set sock->sk to NULL after calling proto_ops::release()

2019-02-22 Thread Al Viro
On Fri, Feb 22, 2019 at 10:25:09AM -0800, Eric Dumazet wrote: > > > On 02/22/2019 09:57 AM, Eric Biggers wrote: > > > ->setattr() is called under inode_lock(), which __sock_release() also > > takes. So > > the uses of sock->sk are serialized. See commit 6d8c50dcb029 ("socket: > > close > >

Re: [PATCH RESEND V6 2/2] clk: imx: scu: add cpu frequency scaling support

2019-02-22 Thread Stephen Boyd
Quoting Anson Huang (2019-02-21 18:32:10) > On NXP's i.MX SoCs with system controller inside, CPU frequency > scaling can ONLY be done by system controller firmware, and it > can ONLY be requested from secure mode, so Linux kernel has to > call ARM SMC to trap to ARM-Trusted-Firmware to request

Re: [PATCH v5 3/9] mm/mmu_notifier: convert mmu_notifier_range->blockable to a flags

2019-02-22 Thread Ralph Campbell
On 2/19/19 12:04 PM, jgli...@redhat.com wrote: From: Jérôme Glisse Use an unsigned field for flags other than blockable and convert the blockable field to be one of those flags. Signed-off-by: Jérôme Glisse Cc: Christian König Cc: Joonas Lahtinen Cc: Jani Nikula Cc: Rodrigo Vivi Cc:

Re: [PATCH RESEND V6 2/2] clk: imx: scu: add cpu frequency scaling support

2019-02-22 Thread Stephen Boyd
Quoting Anson Huang (2019-02-21 18:32:10) > On NXP's i.MX SoCs with system controller inside, CPU frequency > scaling can ONLY be done by system controller firmware, and it > can ONLY be requested from secure mode, so Linux kernel has to > call ARM SMC to trap to ARM-Trusted-Firmware to request

Re: [PATCH v2 2/2] selftests/ftrace: Replace \e with \033

2019-02-22 Thread Steven Rostedt
On Fri, 22 Feb 2019 08:59:42 -0700 shuah wrote: > On 2/22/19 7:59 AM, Masami Hiramatsu wrote: > > On Fri, 22 Feb 2019 10:10:21 +0100 > > Juerg Haefliger wrote: > > > >> The \e sequence character is not POSIX. Fix that by using \033 instead. > >> > >> Signed-off-by: Juerg Haefliger > > >

Re: [PATCH 1/5] mm/workingset: remove unused @mapping argument in workingset_eviction()

2019-02-22 Thread Rik van Riel
On Fri, 2019-02-22 at 20:43 +0300, Andrey Ryabinin wrote: > workingset_eviction() doesn't use and never did use the @mapping > argument. > Remove it. > > Signed-off-by: Andrey Ryabinin > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Vlastimil Babka > Cc: Rik van Riel > Cc: Mel Gorman

Re: [PATCH 3/5] mm/compaction: pass pgdat to too_many_isolated() instead of zone

2019-02-22 Thread Rik van Riel
On Fri, 2019-02-22 at 20:43 +0300, Andrey Ryabinin wrote: > too_many_isolated() in mm/compaction.c looks only at node state, > so it makes more sense to change argument to pgdat instead of zone. > > Signed-off-by: Andrey Ryabinin > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Vlastimil Babka

[PATCH] null_blk: fix checking for REQ_FUA

2019-02-22 Thread Heinz Mauelshagen
null_handle_bio() erroneously uses the bio_op macro which masks respective request flag bits including REQ_FUA out thus failing the check. Fix by checking bio->bi_opf directly. Signed-off-by: Heinz Mauelshagen --- drivers/block/null_blk_main.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v5 2/9] mm/mmu_notifier: convert user range->blockable to helper function

2019-02-22 Thread Ralph Campbell
On 2/19/19 12:04 PM, jgli...@redhat.com wrote: From: Jérôme Glisse Use the mmu_notifier_range_blockable() helper function instead of directly dereferencing the range->blockable field. This is done to make it easier to change the mmu_notifier range field. This patch is the outcome of the

Re: [PATCH v5 1/9] mm/mmu_notifier: helper to test if a range invalidation is blockable

2019-02-22 Thread Ralph Campbell
On 2/19/19 12:04 PM, jgli...@redhat.com wrote: From: Jérôme Glisse Simple helpers to test if range invalidation is blockable. Latter patches use cocinnelle to convert all direct dereference of range-> blockable to use this function instead so that we can convert the blockable field to an

Re: [PATCH RFC] mm/vmscan: try to protect active working set of cgroup from reclaim.

2019-02-22 Thread Rik van Riel
On Fri, 2019-02-22 at 20:58 +0300, Andrey Ryabinin wrote: > In a presence of more than 1 memory cgroup in the system our reclaim > logic is just suck. When we hit memory limit (global or a limit on > cgroup with subgroups) we reclaim some memory from all cgroups. > This is sucks because, the

Re: [PATCH v3] mm/hugetlb: Fix unsigned overflow in __nr_hugepages_store_common()

2019-02-22 Thread Mike Kravetz
On 2/22/19 6:01 AM, Jing Xiangfeng wrote: Thanks, just a couple small changes. > User can change a node specific hugetlb count. i.e. > /sys/devices/system/node/node1/hugepages/hugepages-2048kB Please make that, /sys/devices/system/node/node1/hugepages/hugepages-2048kB/nr_hugepages > the

Re: [PATCH] x86/kvm/mmu: fix switch between root and guest MMUs

2019-02-22 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 22/02/19 17:45, Vitaly Kuznetsov wrote: >> Commit 14c07ad89f4d ("x86/kvm/mmu: introduce guest_mmu") brought one subtle >> change: previously, when switching back from L2 to L1, we were resetting >> MMU hooks (like mmu->get_cr3()) in kvm_init_mmu() called from >>

[RFC PATCH 19/20] net: silan: sc92031: Remove stale comment about mmiowb()

2019-02-22 Thread Will Deacon
mmiowb() is no more. It has ceased to be. It is an ex-barrier. So remove all references to it from comments. Signed-off-by: Will Deacon --- drivers/net/ethernet/silan/sc92031.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/silan/sc92031.c

[RFC PATCH 17/20] scsi: qla1280: Remove stale comment about mmiowb()

2019-02-22 Thread Will Deacon
All mmiowb() invocations have been removed, so there's no need to keep banging on about it. Signed-off-by: Will Deacon --- drivers/scsi/qla1280.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c index 93acbc5094f0..327eff67a1ee

[RFC PATCH 20/20] arch: Remove dummy mmiowb() definitions from arch code

2019-02-22 Thread Will Deacon
Now that no driver code is using mmiowb() directly, we can remove the dummy definitions from the architectures that don't make use of asm-generic/io.h Signed-off-by: Will Deacon --- arch/alpha/include/asm/io.h| 2 -- arch/hexagon/include/asm/io.h | 2 -- arch/parisc/include/asm/io.h | 2

[RFC PATCH 16/20] drivers: Remove explicit invocations of mmiowb()

2019-02-22 Thread Will Deacon
mmiowb() is now implied by spin_unlock() on architectures that require it, so there is no reason to call it from driver code. This patch was generated using coccinelle: @mmiowb@ @@ - mmiowb(); and invoked as: $ for d in drivers include/linux/qed sound; do \ spatch

[RFC PATCH 03/20] mmiowb: Hook up mmiowb helpers to spinlocks and generic I/O accessors

2019-02-22 Thread Will Deacon
Removing explicit calls to mmiowb() from driver code means that we must now call into the generic mmiowb_spin_{lock,unlock}() functions from the core spinlock code. In order to elide barriers following critical sections without any I/O writes, we also hook into the asm-generic I/O routines.

[RFC PATCH 04/20] ARM: io: Remove useless definition of mmiowb()

2019-02-22 Thread Will Deacon
ARM includes asm-generic/io.h, which provides a dummy definition of mmiowb() if one isn't already provided by the architecture. Remove the useless definition. Signed-off-by: Will Deacon --- arch/arm/include/asm/io.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/include/asm/io.h

[RFC PATCH 18/20] i40iw: Redefine i40iw_mmiowb() to do nothing

2019-02-22 Thread Will Deacon
mmiowb() is now implicit in spin_unlock(), so there's no reason to call it from driver code. Redefine i40iw_mmiowb() to do nothing instead. Signed-off-by: Will Deacon --- drivers/infiniband/hw/i40iw/i40iw_osdep.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[RFC PATCH 15/20] drivers: Remove useless trailing comments from mmiowb() invocations

2019-02-22 Thread Will Deacon
In preparation for removing mmiowb() from driver code altogether using coccinelle, remove all trailing comments since they won't be picked up by spatch later on and will end up being preserved in the code. Signed-off-by: Will Deacon --- drivers/infiniband/hw/hfi1/chip.c| 2 +-

[RFC PATCH 14/20] Documentation: Kill all references to mmiowb()

2019-02-22 Thread Will Deacon
The guarantees provided by mmiowb() are now provided implicitly by spin_unlock(), so we can remove all references from this most confusing of barriers from our Documentation. Good riddance. Signed-off-by: Will Deacon --- Documentation/driver-api/device-io.rst | 45 --

[RFC PATCH 12/20] powerpc: mmiowb: Hook up mmwiob() implementation to asm-generic code

2019-02-22 Thread Will Deacon
In a bid to kill off explicit mmiowb() usage in driver code, hook up the asm-generic mmiowb() tracking code but override all of the functions so that the existing (flawed) implementation is preserved on Power. Future work should either use the asm-generic implementation entirely, or implement a

[RFC PATCH 07/20] nds32: io: Remove useless definition of mmiowb()

2019-02-22 Thread Will Deacon
mmiowb() only makes sense for SMP platforms, so we can remove it entirely for nds32. Signed-off-by: Will Deacon --- arch/nds32/include/asm/io.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/nds32/include/asm/io.h b/arch/nds32/include/asm/io.h index 71cd226d6863..5ef8ae5ba833 100644

[RFC PATCH 13/20] riscv: mmiowb: Hook up mmwiob() implementation to asm-generic code

2019-02-22 Thread Will Deacon
In a bid to kill off explicit mmiowb() usage in driver code, hook up the asm-generic mmiowb() tracking code for riscv, so that an mmiowb() is automatically issued from spin_unlock() if an I/O write was performed in the critical section. Signed-off-by: Will Deacon --- arch/riscv/Kconfig

[RFC PATCH 08/20] m68k: io: Remove useless definition of mmiowb()

2019-02-22 Thread Will Deacon
m68k includes asm-generic/io.h, which provides a dummy definition of mmiowb() if one isn't already provided by the architecture. Remove the useless definition. Cc: Geert Uytterhoeven Signed-off-by: Will Deacon --- arch/m68k/include/asm/io_mm.h | 2 -- 1 file changed, 2 deletions(-) diff

[RFC PATCH 00/20] Remove Mysterious Macro Intended to Obscure Weird Behaviours (mmiowb())

2019-02-22 Thread Will Deacon
Hi all, This series attempts to remove explicit mmiowb() calls from driver code, instead adding it to spin_unlock() for architectures that require it. The infamous "PowerPC trick" was found to be flawed, so a correct but probably slower version is made generic for architectures wishing to use

[RFC PATCH 02/20] arch: Use asm-generic header for asm/mmiowb.h

2019-02-22 Thread Will Deacon
Hook up asm-generic/mmiowb.h to Kbuild for all architectures so that we can subsequently include asm/mmiowb.h from core code. Cc: Masahiro Yamada Cc: Arnd Bergmann Signed-off-by: Will Deacon --- arch/alpha/include/asm/Kbuild | 1 + arch/arc/include/asm/Kbuild| 1 +

[RFC PATCH 06/20] x86: io: Remove useless definition of mmiowb()

2019-02-22 Thread Will Deacon
x86 maps mmiowb() to barrier(), but this is superfluous because a compiler barrier is already implied by spin_unlock(). Since x86 also includes asm-generic/io.h in its asm/io.h file, we can remove the definition entirely and pick up the dummy definition from core code. Signed-off-by: Will Deacon

Re: [PATCH] x86/kvm/mmu: make mmu->prev_roots cache work for NPT case

2019-02-22 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 22/02/19 17:46, Vitaly Kuznetsov wrote: >> I noticed that fast_cr3_switch() always fails when we switch back from L2 >> to L1 as it is not able to find a cached root. This is odd: host's CR3 >> usually stays the same, we expect to always follow the fast path. Turns >>

[RFC PATCH 09/20] sh: Add unconditional mmiowb() to arch_spin_unlock()

2019-02-22 Thread Will Deacon
The mmiowb() macro is horribly difficult to use and drivers will continue to work most of the time if they omit a call when it is required. Rather than rely on driver authors getting this right, push mmiowb() into arch_spin_unlock() for sh. If this is deemed to be a performance issue, a

[RFC PATCH 11/20] ia64: Add unconditional mmiowb() to arch_spin_unlock()

2019-02-22 Thread Will Deacon
The mmiowb() macro is horribly difficult to use and drivers will continue to work most of the time if they omit a call when it is required. Rather than rely on driver authors getting this right, push mmiowb() into arch_spin_unlock() for ia64. If this is deemed to be a performance issue, a

[RFC PATCH 10/20] mips: Add unconditional mmiowb() to arch_spin_unlock()

2019-02-22 Thread Will Deacon
The mmiowb() macro is horribly difficult to use and drivers will continue to work most of the time if they omit a call when it is required. Rather than rely on driver authors getting this right, push mmiowb() into arch_spin_unlock() for mips. If this is deemed to be a performance issue, a

[RFC PATCH 05/20] arm64: io: Remove useless definition of mmiowb()

2019-02-22 Thread Will Deacon
arm64 includes asm-generic/io.h, which provides a dummy definition of mmiowb() if one isn't already provided by the architecture. Remove the useless definition. Signed-off-by: Will Deacon --- arch/arm64/include/asm/io.h | 2 -- 1 file changed, 2 deletions(-) diff --git

[RFC PATCH 01/20] asm-generic/mmiowb: Add generic implementation of mmiowb() tracking

2019-02-22 Thread Will Deacon
In preparation for removing all explicit mmiowb() calls from driver code, implement a tracking system in asm-generic based on the PowerPC implementation. This allows architectures with a non-empty mmiowb() definition to automatically have the barrier inserted in spin_unlock() following a critical

Re: [PATCH] i2c: Allow recovery of the initial IRQ by an I2C client device.

2019-02-22 Thread Jim Broadus
On Fri, Feb 22, 2019 at 3:32 AM Wolfram Sang wrote: > > > > > > But I still have the feeling that the problem is not solved at the > > > > right place. In i2c_new_device() we are storing parts of the fields of > > > > struct i2c_board_info, and when resetting the irq we are losing > > > >

Re: [PATCHv6 07/10] acpi/hmat: Register processor domain to its memory

2019-02-22 Thread Keith Busch
On Wed, Feb 20, 2019 at 11:02:01PM +0100, Rafael J. Wysocki wrote: > On Thu, Feb 14, 2019 at 6:10 PM Keith Busch wrote: > > config ACPI_HMAT > > bool "ACPI Heterogeneous Memory Attribute Table Support" > > depends on ACPI_NUMA > > + select HMEM_REPORTING > > If you want to

[PATCH] arm64: dts: rockchip: Add support for the Orange Pi RK3399 board.

2019-02-22 Thread Alexis Ballier
This adds basic support for the Orange Pi RK3399 board. What works: - SD card / emmc. - Debug UART - Ethernet - USB: Type C, internal USB3 for SATA, 4 USB 2.0 ports - Sensors: All of them but the Hall sensor. - Buttons - Wifi, Bluetooth - HDMI out Signed-off-by: Alexis Ballier Cc:

Re: [PATCH net-next 1/7] net: phy: marvell10g: Use get_features to get the PHY abilities

2019-02-22 Thread Heiner Kallweit
On 21.02.2019 10:51, Maxime Chevallier wrote: > The Alaska family of 10G PHYs has more abilities than the ones listed in > PHY_10GBIT_FULL_FEATURES, the exact list depending on the model. > > Make use of the newly introduced .get_features call to build this list, > using

Re: [GIT PULL] clk fixes for v5.0-rc7

2019-02-22 Thread pr-tracker-bot
The pull request you sent on Thu, 21 Feb 2019 13:57:21 -0800: > https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git > tags/clk-fixes-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a3504f7a38233030def726fcfe692e786ab162df Thank you! --

Re: [GIT PULL] Please pull RDMA subsystem changes

2019-02-22 Thread pr-tracker-bot
The pull request you sent on Thu, 21 Feb 2019 23:07:20 +: > git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git tags/for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/168bd29830e8ebbffcd70d2af50249dca088e1a8 Thank you! -- Deet-doot-dot, I am a

Re: [git pull] drm fixes for 5.0-rc8 (or final)

2019-02-22 Thread pr-tracker-bot
The pull request you sent on Fri, 22 Feb 2019 10:13:42 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2019-02-22 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6ee2846cb4e7c6e8acdcb265299ad1c6de42b437 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v3 7/9] dt-bindings: serial: Add Milbeaut serial driver description

2019-02-22 Thread Rob Herring
On Wed, 20 Feb 2019 16:44:37 +0900, Sugaya Taichi wrote: > Add DT bindings document for Milbeaut serial driver. > > Signed-off-by: Sugaya Taichi > --- > .../devicetree/bindings/serial/milbeaut-uart.txt| 21 > + > 1 file changed, 21 insertions(+) > create mode 100644

Re: [PATCH] Bluetooth: btusb: request wake pin with NOAUTOEN

2019-02-22 Thread Matthias Kaehlcke
On Thu, Feb 21, 2019 at 04:30:51PM -0800, Brian Norris wrote: > Badly-designed systems might have (for example) active-high wake pins > that default to high (e.g., because of external pull ups) until they > have an active firmware which starts driving it low. This can cause an > interrupt storm in

Re: [PATCH v3 00/20] Merge text_poke fixes and executable lockdowns

2019-02-22 Thread Edgecombe, Rick P
On Fri, 2019-02-22 at 17:14 +0100, Borislav Petkov wrote: > On Thu, Feb 21, 2019 at 03:44:31PM -0800, Rick Edgecombe wrote: > > Changes v2 to v3: > > - Fix commit messages and comments [Boris] > > - Rename VM_HAS_SPECIAL_PERMS [Boris] > > - Remove unnecessary local variables [Boris] > > -

Re: [PATCH 3/3] arm64: dts: rockchip: move QCA6174A wakeup pin into its USB node

2019-02-22 Thread Matthias Kaehlcke
On Thu, Feb 21, 2019 at 04:34:03PM -0800, Brian Norris wrote: > Currently, we don't coordinate BT USB activity with our handling of the > BT out-of-band wake pin, and instead just use gpio-keys. That causes > problems because we have no way of distinguishing wake activity due to a > BT device

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-22 Thread Linus Torvalds
On Fri, Feb 22, 2019 at 9:48 AM Andy Lutomirski wrote: > > > On Feb 22, 2019, at 9:43 AM, Linus Torvalds > > wrote: > > > > Then we should still probably fix up "__probe_kernel_read()" to not > > allow user accesses. The easiest way to do that is actually likely to > > use the

[PATCH] kasan: prevent recursive instrumentation

2019-02-22 Thread Mark Rutland
When CONFIG_KASAN is selected, defines the prototypes for kasan_check_{read,write}(), rather than inline stubs. This is the case even when it is included by files which are not instrumented by KASAN. Where helpers (e.g. the atomics) are instrumented with explicit calls to

Re: [PATCH v5 8/8] ARM: tegra: Add firmware calls required for suspend-resume

2019-02-22 Thread Dmitry Osipenko
22.02.2019 20:59, Dmitry Osipenko пишет: > In order to resume CPU from suspend via trusted Foundations firmware, > the LP1/LP2 boot vectors and CPU caches need to be set up using the > firmware calls. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/mach-tegra/pm.c| 53

Re: [PATCH V3 00/10] X86/KVM/Hyper-V: Add HV ept tlb range list flush support in KVM

2019-02-22 Thread Paolo Bonzini
On 22/02/19 16:06, lantianyu1...@gmail.com wrote: > From: Lan Tianyu > > This patchset is to introduce hv ept tlb range list flush function > support in the KVM MMU component. Flushing ept tlbs of several address > range can be done via single hypercall and new list flush function is > used in

[PATCH hyperv-fixes] hv_netvsc: Fix IP header checksum for coalesced packets

2019-02-22 Thread Haiyang Zhang
From: Haiyang Zhang Incoming packets may have IP header checksum verified by the host. They may not have IP header checksum computed after coalescing. This patch re-compute the checksum when necessary, otherwise the packets may be dropped, because Linux network stack always checks it.

Re: [PATCH net] net: socket: set sock->sk to NULL after calling proto_ops::release()

2019-02-22 Thread Eric Dumazet
On 02/22/2019 09:57 AM, Eric Biggers wrote: > ->setattr() is called under inode_lock(), which __sock_release() also takes. > So > the uses of sock->sk are serialized. See commit 6d8c50dcb029 ("socket: close > race condition between sock_close() and sockfs_setattr()"). Oh right, we added

Re: general protection fault in rose_send_frame

2019-02-22 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:7a25c6c0aac8 rocker: Add missing break for PRE_BRIDGE_FLAGS git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=104002d8c0 kernel config:

Re: [PATCH] KVM: MMU: record maximum physical address width in kvm_mmu_extended_role

2019-02-22 Thread Paolo Bonzini
On 20/02/19 08:06, Yu Zhang wrote: > Hi Paolo, any comments on this patch? And the other one(kvm: x86: Return > LA57 feature based on hardware capability )? :-) Queued both, thanks. Paolo > On Fri, Feb 01, 2019 at 12:09:23AM +0800, Yu Zhang wrote: >> Previously, commit 7dcd57552008

Re: [PATCH 5/5] mm/vmscan: don't forcely shrink active anon lru list

2019-02-22 Thread Johannes Weiner
On Fri, Feb 22, 2019 at 08:43:37PM +0300, Andrey Ryabinin wrote: > shrink_node_memcg() always forcely shrink active anon list. > This doesn't seem like correct behavior. If system/memcg has no swap, it's > absolutely pointless to rebalance anon lru lists. > And in case we did scan the active anon

Re: [PATCHv6 06/10] node: Add memory-side caching attributes

2019-02-22 Thread Dan Williams
On Fri, Feb 22, 2019 at 10:09 AM Keith Busch wrote: > > On Fri, Feb 22, 2019 at 11:12:38AM +0100, Brice Goglin wrote: > > Le 14/02/2019 à 18:10, Keith Busch a écrit : > > > +What: > > > /sys/devices/system/node/nodeX/memory_side_cache/indexY/size > > > +Date: December

Re: [PATCH v2] IB/mlx4: Increase the timeout for CM cache

2019-02-22 Thread Jason Gunthorpe
On Sun, Feb 17, 2019 at 03:45:12PM +0100, Håkon Bugge wrote: > Using CX-3 virtual functions, either from a bare-metal machine or > pass-through from a VM, MAD packets are proxied through the PF driver. > > Since the VF drivers have separate name spaces for MAD Transaction Ids > (TIDs), the PF

Re: [PATCH v8 0/7] freezer for cgroup v2

2019-02-22 Thread Tejun Heo
Hey, Oleg. On Fri, Feb 22, 2019 at 05:34:42PM +0100, Oleg Nesterov wrote: > > ptrace support is a lot less important than kill for sure but if at > > all possible I think it'd be better to have it > > Tejun, I agree it would be better. I did not argue with that. > > The question is how this can

hello dear

2019-02-22 Thread Aysha Gadafi
Assalamu Alaikum Wa Rahmatullahi Wa Barakatuh, hello dear I came across your contact during my private search. Mrs Aisha Al- Qaddafi is my name, the only daughter of late Libyan president, am a single Mother and a Widow with three Children.I have funds the sum of $27.5 million USD for,

Re: [PATCH 2/2] clk: ingenic: Fix doc of ingenic_cgu_div_info

2019-02-22 Thread Stephen Boyd
Quoting Paul Cercueil (2019-01-27 18:09:21) > The 'div' field does not represent a number of bits used to divide > (understand: right-shift) the divider, but a number itself used to > divide the divider. > > Signed-off-by: Paul Cercueil > Signed-off-by: Maarten ter Huurne > Cc: > --- Applied

Re: [PATCH 1/2] clk: ingenic: Fix round_rate misbehaving with non-integer dividers

2019-02-22 Thread Stephen Boyd
Quoting Paul Cercueil (2019-01-27 18:09:20) > Take a parent rate of 180 MHz, and a requested rate of 4.285715 MHz. > This results in a theorical divider of 41.93 which is then rounded > up to 42. The .round_rate function would then return (180 MHz / 42) as > the clock, rounded down, so

Re: [PATCHv6 06/10] node: Add memory-side caching attributes

2019-02-22 Thread Keith Busch
On Fri, Feb 22, 2019 at 11:22:12AM +0100, Brice Goglin wrote: > Le 14/02/2019 à 18:10, Keith Busch a écrit : > > +What: > > /sys/devices/system/node/nodeX/memory_side_cache/indexY/associativity > > +Date: December 2018 > > +Contact: Keith Busch > > +Description: > > +

Re: [PATCH v2 08/14] clk: qcom: hfpll: CLK_IGNORE_UNUSED

2019-02-22 Thread Stephen Boyd
Quoting Jorge Ramirez-Ortiz (2019-01-28 10:32:55) > When COMMON_CLK_DISABLED_UNUSED is set, in an effort to save power and > to keep the software model of the clock in line with reality, the > framework transverses the clock tree and disables those clocks that > were enabled by the firmware but

<    1   2   3   4   5   6   7   8   9   >