Re: [PATCH v2] posix-cpu-timers: Avoid undefined behaviour in timespec64_to_ns()

2019-02-28 Thread Arnd Bergmann
On Thu, Feb 28, 2019 at 11:35 AM Thomas Gleixner wrote: > On Thu, 28 Feb 2019, Arnd Bergmann wrote: > > On Thu, Feb 28, 2019 at 5:25 AM Deepa Dinamani > > wrote: > > > > > > On Tue, Feb 26, 2019 at 11:52 PM Xiongfeng Wang > > > wrote: > > I think returning EINVAL here is better than silently

Re: [PATCH v2 2/4] mm: remove zone_lru_lock() function access ->lru_lock directly

2019-02-28 Thread Mel Gorman
On Thu, Feb 28, 2019 at 11:33:27AM +0300, Andrey Ryabinin wrote: > We have common pattern to access lru_lock from a page pointer: > zone_lru_lock(page_zone(page)) > > Which is silly, because it unfolds to this: > >

Re: [PATCH v2 3/4] mm/compaction: pass pgdat to too_many_isolated() instead of zone

2019-02-28 Thread Mel Gorman
On Thu, Feb 28, 2019 at 11:33:28AM +0300, Andrey Ryabinin wrote: > too_many_isolated() in mm/compaction.c looks only at node state, > so it makes more sense to change argument to pgdat instead of zone. > > Signed-off-by: Andrey Ryabinin > Acked-by: Vlastimil Babka > Acked-by: Rik van Riel >

Re: [PATCH v2 4/4] mm/vmscan: remove unused lru_pages argument

2019-02-28 Thread Mel Gorman
On Thu, Feb 28, 2019 at 11:33:29AM +0300, Andrey Ryabinin wrote: > Since commit 9092c71bb724 ("mm: use sc->priority for slab shrink targets") > the argument 'unsigned long *lru_pages' passed around with no purpose. > Remove it. > > Signed-off-by: Andrey Ryabinin > Acked-by: Johannes Weiner >

Re: [PATCH v3 09/34] m68k: mm: Add p?d_large() definitions

2019-02-28 Thread Mike Rapoport
Hi, On Wed, Feb 27, 2019 at 08:27:40PM +0100, Geert Uytterhoeven wrote: > Hi Steven, > > On Wed, Feb 27, 2019 at 6:07 PM Steven Price wrote: > > walk_page_range() is going to be allowed to walk page tables other than > > those of user space. For this it needs to know when it has reached a > >

[PATCH] sctp: chunk.c: correct format string for size_t in printk

2019-02-28 Thread Matthias Maennich
According to Documentation/core-api/printk-formats.rst, size_t should be printed with %zu, rather than %Zu. In addition, using %Zu triggers a warning on clang (-Wformat-extra-args): net/sctp/chunk.c:196:25: warning: data argument not used by format string [-Wformat-extra-args]

Re: [PATCH v10 0/9] support ROHM BD70528 PMIC

2019-02-28 Thread Mark Brown
On Thu, Feb 28, 2019 at 09:04:50AM +0200, Matti Vaittinen wrote: > On Thu, Feb 14, 2019 at 03:02:37PM +0200, Matti Vaittinen wrote: >> Patch series introducing support for ROHM BD70528 PMIC > > I was wondering if there is anything that could be done to allow the MFD > part of this series to end

[PATCH v4 0/3] i2c: mux: pca954x: allow management of device idle state via sysfs

2019-02-28 Thread Robert Shearman
From: Robert Shearman The behaviour, by default, to not deselect after each transfer is unsafe when there is a device with an address that conflicts with another device on another pca954x mux on the same parent bus, and it may not be convenient to use devicetree to set the deselect mux, e.g.

Re: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Igor Druzhinin
On 28/02/2019 11:21, Paul Durrant wrote: >>> @@ -1153,6 +1152,10 @@ static int xenvif_tx_submit(struct xenvif_queue >>> *queue) >>> kfree_skb(skb); >>> continue; >>> } >>> + >>> + /*

[PATCH v4 2/3] i2c: mux: pca9541: remove support for unused platform data

2019-02-28 Thread Robert Shearman
From: Robert Shearman There are no in-tree users of the platform data, so remove it to simplify the code slightly. Remove the now unused pca954x.h platform data header. Signed-off-by: Robert Shearman --- drivers/i2c/muxes/i2c-mux-pca9541.c | 8 + include/linux/platform_data/pca954x.h

Re: [PATCH v3 18/34] s390: mm: Add p?d_large() definitions

2019-02-28 Thread Steven Price
On 27/02/2019 17:40, Martin Schwidefsky wrote: > On Wed, 27 Feb 2019 17:05:52 + > Steven Price wrote: > >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page tables. This

[PATCH v4 3/3] i2c: mux: pca954x: allow management of device idle state via sysfs

2019-02-28 Thread Robert Shearman
From: Robert Shearman The behaviour, by default, to not deselect after each transfer is unsafe when there is a device with an address that conflicts with another device on another mux on the same parent bus, and it may not be convenient to use devicetree to set the deselect mux, e.g. when

[PATCH v4 1/3] i2c: mux: pca954x: remove support for unused platform data

2019-02-28 Thread Robert Shearman
From: Robert Shearman There are no in-tree users of the pca954x platform data and the per-channel deselect configuration complicates efforts to export the configuration to user-space in a way that could be applied to other muxes. Therefore, remove support for the pca954x platform data.

Re: [PATCH resend] lib/vsprintf: Remove %pCr remnant in comment

2019-02-28 Thread Petr Mladek
On Thu 2019-02-28 11:53:15, Geert Uytterhoeven wrote: > Support for "%pCr" was removed, but a reference in a comment was > forgotten. > > Fixes: 666902e42fd8344b ("lib/vsprintf: Remove atomic-unsafe support for > %pCr") > Signed-off-by: Geert Uytterhoeven I have commited it into printk.git,

RE: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 28 February 2019 11:44 > To: Paul Durrant ; Wei Liu > Cc: xen-de...@lists.xenproject.org; net...@vger.kernel.org; > linux-kernel@vger.kernel.org; > da...@davemloft.net > Subject: Re: [PATCH]

Re: [PATCH v3 20/34] sparc: mm: Add p?d_large() definitions

2019-02-28 Thread Steven Price
On 27/02/2019 18:38, David Miller wrote: > From: Steven Price > Date: Wed, 27 Feb 2019 17:05:54 + > >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page tables. This

Re: [PATCH] xen, fbfront: mark expected switch fall-through

2019-02-28 Thread Oleksandr Andrushchenko
+Xen-devel list On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:

Re: [PATCH v3 09/34] m68k: mm: Add p?d_large() definitions

2019-02-28 Thread Geert Uytterhoeven
Hi Mike, On Thu, Feb 28, 2019 at 12:37 PM Mike Rapoport wrote: > On Wed, Feb 27, 2019 at 08:27:40PM +0100, Geert Uytterhoeven wrote: > > On Wed, Feb 27, 2019 at 6:07 PM Steven Price wrote: > > > walk_page_range() is going to be allowed to walk page tables other than > > > those of user space.

[PATCH] include/linux/types.h: use "unsigned int" instead of "unsigned"

2019-02-28 Thread WangBo
Use "unsigned int" instead of "unsigned" ,it make code more clear. Signed-off-by: WangBo --- include/linux/types.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/types.h b/include/linux/types.h index c2615d6..cc0dbbe 100644 --- a/include/linux/types.h

[PATCH] wusb: use correct format characters

2019-02-28 Thread Louis Taylor
When compiling with -Wformat, clang warns: ./include/linux/usb/wusb.h:245:5: warning: format specifies type 'unsigned short' but the argument has type 'u8' (aka 'unsigned char') [-Wformat] ckhdid->data[0], ckhdid->data[1], ^~~ ckhdid->data is unconditionally defined as `u8

Re: [PATCH] memcg: fix a bad line

2019-02-28 Thread Souptick Joarder
On Thu, Feb 28, 2019 at 2:22 AM Qian Cai wrote: > > Miss a star. > > Signed-off-by: Qian Cai I think, the change log is too short and could be little more. Otherwise, Acked-by: Souptick Joarder > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] wusb: use correct format characters

2019-02-28 Thread Greg KH
On Thu, Feb 28, 2019 at 11:52:56AM +, Louis Taylor wrote: > When compiling with -Wformat, clang warns: > > ./include/linux/usb/wusb.h:245:5: warning: format specifies type > 'unsigned short' but the argument has type 'u8' (aka 'unsigned char') > [-Wformat] > ckhdid->data[0],

Re: [PATCH v5 00/10] arm64: add system vulnerability sysfs entries

2019-02-28 Thread Catalin Marinas
Hi Jeremy, On Tue, Feb 26, 2019 at 07:05:34PM -0600, Jeremy Linton wrote: > Jeremy Linton (6): > arm64: Provide a command line to disable spectre_v2 mitigation > arm64: add sysfs vulnerability show for meltdown > arm64: Always enable spectrev2 vulnerability detection > arm64: add sysfs

Re: [PATCH 11/15] habanalabs: print pointer using %p

2019-02-28 Thread Greg KH
On Thu, Feb 28, 2019 at 11:55:45AM +0200, Oded Gabbay wrote: > Don't cast pointer to u64 to print it. Instead, print the pointer using > %p. > > Signed-off-by: Oded Gabbay > --- > Changes in v2: > - Add changelog in the commit message This isn't marked "v2" :( Anyway, I'll try to piece this

Re: [PATCH] lib/scatterlist: introduce sg_nents_for_dma() helper

2019-02-28 Thread Ardelean, Alexandru
On Wed, 2019-02-27 at 16:15 +0200, Andy Shevchenko wrote: > [External] > > > On Wed, Feb 27, 2019 at 2:26 PM Ardelean, Alexandru > wrote: > > > > On Wed, 2019-02-27 at 11:46 +0200, Andy Shevchenko wrote: > > > [External] > > > > > > > > > +Cc Vinod > > > > > > On Wed, Feb 27, 2019 at 11:45

VERY IMPORTANT /TREAT AND REPLY URGENT

2019-02-28 Thread Salisu Dikima
Hello My Dear Friend, With due respect to your person and much sincerity of purpose, It’s my pleasure to write you today, I am Mr Salisu Dikima, I work in a bank. and I get your contact from internet search I hope that you will not expose or betray this trust and confident that am about to

Re: [PATCH v3 09/34] m68k: mm: Add p?d_large() definitions

2019-02-28 Thread Steven Price
On 28/02/2019 11:53, Geert Uytterhoeven wrote: > Hi Mike, > > On Thu, Feb 28, 2019 at 12:37 PM Mike Rapoport wrote: >> On Wed, Feb 27, 2019 at 08:27:40PM +0100, Geert Uytterhoeven wrote: >>> On Wed, Feb 27, 2019 at 6:07 PM Steven Price wrote: walk_page_range() is going to be allowed to

RE: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf Of > Paul Durrant > Sent: 28 February 2019 11:22 > To: Wei Liu > Cc: Igor Druzhinin ; Wei Liu > ; net...@vger.kernel.org; > linux-kernel@vger.kernel.org; xen-de...@lists.xenproject.org; >

Re: [RFC PATCH] mm,memory_hotplug: Unlock 1GB-hugetlb on x86_64

2019-02-28 Thread Michal Hocko
On Thu 28-02-19 11:19:52, Oscar Salvador wrote: > On Thu, Feb 28, 2019 at 10:55:35AM +0100, Michal Hocko wrote: > > You seemed to miss my point or I am wrong here. If scan_movable_pages > > skips over a hugetlb page then there is nothing to migrate it and it > > will stay in the pfn range and the

Re: [PATCH v3 11/34] mips: mm: Add p?d_large() definitions

2019-02-28 Thread Steven Price
On 28/02/2019 02:15, Paul Burton wrote: > Hi Steven, > > On Wed, Feb 27, 2019 at 05:05:45PM +, Steven Price wrote: >> For mips, we don't support large pages on 32 bit so add stubs returning 0. > > So far so good :) > >> For 64 bit look for _PAGE_HUGE flag being set. This means exposing the

RE: [PATCH] sched/cputime: Remove unnecessary assignment statement

2019-02-28 Thread Sachin Nikam
Ketan, What is the Coverity Impact Level for this defect? If it is Low then we can whitelist this defect and change. Peter, This isn't a security fix. However, I see this is kind of code cleanup. -Original Message- From: Peter Zijlstra Sent: Thursday, February 28, 2019 3:18 PM To:

hdmi-codec: modifying params in hw_params() callback

2019-02-28 Thread Russell King - ARM Linux admin
Hi all, While looking at hdmi-codec issues, I spotted this code: static int hdmi_codec_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params, struct snd_soc_dai *dai) { ... if (params_width(params)

Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-28 Thread Enric Balletbo Serra
Hi Andy, Missatge de Andy Shevchenko del dia dj., 28 de febr. 2019 a les 8:57: > > On Thu, Feb 28, 2019 at 12:05:35AM +0100, Enric Balletbo Serra wrote: > > Missatge de Gwendal Grignou del dia dc., 27 de > > febr. 2019 a les 19:37: > > > On Wed, Feb 27, 2019 at 10:08 AM Enric Balletbo i Serra >

Re: [PATCH 1/1] iommu: Bind process address spaces to devices

2019-02-28 Thread Jean-Philippe Brucker
On 27/02/2019 21:41, Jacob Pan wrote: > On Tue, 26 Feb 2019 12:17:43 +0100 > Joerg Roedel wrote: > >> Hi Jean-Philippe, >> >> Thanks for the patch! I think this is getting close to be applied >> after the next merge window. >> >> On Wed, Feb 20, 2019 at 02:27:59PM +, Jean-Philippe Brucker

Re: MT76x2U crashes XHCI driver on AMD Ryzen system

2019-02-28 Thread Stanislaw Gruszka
On Thu, Feb 28, 2019 at 11:42:24AM +0100, Stanislaw Gruszka wrote: > On Thu, Feb 28, 2019 at 10:04:12AM +0100, Stanislaw Gruszka wrote: > > On Tue, Feb 26, 2019 at 12:24:08PM +0100, Stanislaw Gruszka wrote: > > > On Tue, Feb 26, 2019 at 11:44:13AM +0100, Joerg Roedel wrote: > > > > On Tue, Feb 26,

Re: [PATCH v8 1/4] mm/cma: Add PF flag to force non cma alloc

2019-02-28 Thread Vlastimil Babka
On 2/27/19 3:47 PM, Aneesh Kumar K.V wrote: > This patch adds PF_MEMALLOC_NOCMA which make sure any allocation in that > context > is marked non-movable and hence cannot be satisfied by CMA region. > > This is useful with get_user_pages_longterm where we want to take a page pin > by > migrating

[PATCH v2 00/24] thermal: tsens: Refactor to use regmap_field

2019-02-28 Thread Amit Kucheria
Changes since v1: - Anything not being throttled in the kernel converted to a hot trip point (no cooling-maps) - Don't print version number of the IP at boot Changes pending from review of v1: - Using macros from bits.h as suggested by Eduardo. I'd like to defer this change to a separate

[PATCH v2 02/24] drivers: thermal: tsens: Rename tsens_data

2019-02-28 Thread Amit Kucheria
Rename to tsens_plat_data to denote that it is platform-data passed in at compile-time. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-8916.c | 2 +- drivers/thermal/qcom/tsens-8960.c | 2 +- drivers/thermal/qcom/tsens-8974.c | 2 +- drivers/thermal/qcom/tsens-v2.c | 4 ++--

[PATCH v2 01/24] drivers: thermal: tsens: Document the data structures

2019-02-28 Thread Amit Kucheria
Describe how the TSENS device and the various sensors connected to it are described in the driver Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens.h | 31 --- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/qcom/tsens.h

[PATCH v2 07/24] drivers: thermal: tsens: Rename tsens-8916 to prepare to merge with tsens-8974

2019-02-28 Thread Amit Kucheria
8916 and 8974 use v0.1.0 of the TSENS IP. Rename tsens-8916 to prepare it for merging with tsens-8974 in a later commit. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/Makefile | 2 +- drivers/thermal/qcom/{tsens-8916.c => tsens-v0_1.c} | 0 2 files changed, 1

[PATCH v2 04/24] drivers: thermal: tsens: Rename variable tmdev

2019-02-28 Thread Amit Kucheria
tmdev seems to imply that this is a device pointer when in fact it is just private platform data for each tsens device. Rename it to priv improve code readability. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-8916.c | 16 +++--- drivers/thermal/qcom/tsens-8960.c | 82

[PATCH v2 05/24] drivers: thermal: tsens: Use consistent names for variables

2019-02-28 Thread Amit Kucheria
tsens_get_temp() uses the name 'data' for the void pointer, use the same in tsens_get_trend() for consistency. Remove a stray space while we're at it. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v2 03/24] drivers: thermal: tsens: Rename tsens_device

2019-02-28 Thread Amit Kucheria
Rename to tsens_priv to denote that it is private data for each tsens instance. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-8916.c | 2 +- drivers/thermal/qcom/tsens-8960.c | 14 +++--- drivers/thermal/qcom/tsens-8974.c | 2 +- drivers/thermal/qcom/tsens-common.c

[PATCH v2 06/24] drivers: thermal: tsens: Function prototypes should have argument names

2019-02-28 Thread Amit Kucheria
check_patch complains a lot as follows: WARNING: function definition argument 'struct tsens_priv *' should also have an identifier name + int (*init)(struct tsens_priv *); Fix it. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens.h | 24 1 file

[PATCH v2 08/24] drivers: thermal: tsens: Rename constants to prepare to merge with tsens-8974

2019-02-28 Thread Amit Kucheria
Some #defines in tsens-v_0_1.c clash with those in tsens-8974.c. Prefix them with 8916 to avoid the clash so we can merge the two files. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-v0_1.c | 88 +++ 1 file changed, 44 insertions(+), 44 deletions(-)

[PATCH] drm/nouveau/debugfs: Fix check of pm_runtime_get_sync failure

2019-02-28 Thread Yue Haibing
From: YueHaibing pm_runtime_get_sync returns negative on failure. Fixes: eaeb9010bb4b ("drm/nouveau/debugfs: Wake up GPU before doing any reclocking") Signed-off-by: YueHaibing --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 09/24] drivers: thermal: tsens: Merge tsens-8974 into tsens-v0_1

2019-02-28 Thread Amit Kucheria
8974 and 8916 have the same version of the TSENS IP. Merge the files to allow for better code reuse. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/Makefile | 2 +- drivers/thermal/qcom/tsens-8974.c | 236 -- drivers/thermal/qcom/tsens-v0_1.c | 229

[PATCH v2 11/24] drivers: thermal: tsens: Save reference to the device pointer and use it

2019-02-28 Thread Amit Kucheria
Code cleanup making it easier to read Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c index

[PATCH v2 10/24] drivers: thermal: tsens: Introduce reg_fields to deal with register description

2019-02-28 Thread Amit Kucheria
As we add support for newer versions of the TSENS IP, the current approach isn't scaling because registers and bitfields get moved around, requiring platform-specific hacks in the code. By moving to regmap, we can hide the register level differences away from the code. Define a common set of

[PATCH v2 12/24] drivers: thermal: tsens: Don't print error message on -EPROBE_DEFER

2019-02-28 Thread Amit Kucheria
We print a calibration failure message on -EPROBE_DEFER from nvmem/qfprom as follows: [3.003090] qcom-tsens 4a9000.thermal-sensor: version: 1.4 [3.005376] qcom-tsens 4a9000.thermal-sensor: tsens calibration failed [3.113248] qcom-tsens 4a9000.thermal-sensor: version: 1.4 This confuses

[PATCH v2 13/24] drivers: thermal: tsens: Track IP version

2019-02-28 Thread Amit Kucheria
Version information is available on some TSENS IP. Allow reading it by allocating memory for the regmap_field. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/thermal/qcom/tsens-common.c

[PATCH v2 14/24] drivers: thermal: tsens: Add new operation to check if a sensor is enabled

2019-02-28 Thread Amit Kucheria
is_sensor_enabled() checks if the sensors are enabled on this platform. It is possible that the SoC might choose not to enable all the sensors that the IP block is capable of supporting. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 14 ++

[PATCH v2 15/24] drivers: thermal: tsens: change data type for sensor IDs

2019-02-28 Thread Amit Kucheria
The IDs cannot be negative, fix the data type. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h index 023fed3352e3..a20725b1cc67 100644 ---

[PATCH v2 22/24] arm64: dts: qcom: qcs404: Add tsens controller

2019-02-28 Thread Amit Kucheria
qcs404 has a single TSENS IP block with 10 sensors. The calibration data is stored in an eeprom (qfprom) that is accessed through the nvmem framework. We add the qfprom node to allow the tsens sensors to be calibrated correctly. Signed-off-by: Amit Kucheria ---

[PATCH v2 20/24] dt: thermal: tsens: Add bindings for qcs404

2019-02-28 Thread Amit Kucheria
qcs404 uses v1 of the TSENS IP block. Create a fallback DT property "qcom,tsens-v1" to gather common code Signed-off-by: Amit Kucheria Reviewed-by: Rob Herring --- .../devicetree/bindings/thermal/qcom-tsens.txt | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH v2 17/24] drivers: thermal: tsens: simplify get_temp_tsens_v2 routine

2019-02-28 Thread Amit Kucheria
The current implementation is based on an algorithm published in the docs. Instead of reading the temperature thrice w/o any explanation, improve the algorithm. This will become the basis for a common get_temp routine in the future. Signed-off-by: Amit Kucheria ---

[PATCH v2] wusb: use correct format characters

2019-02-28 Thread Louis Taylor
When compiling with -Wformat, clang warns: ./include/linux/usb/wusb.h:245:5: warning: format specifies type 'unsigned short' but the argument has type 'u8' (aka 'unsigned char') [-Wformat] ckhdid->data[0], ckhdid->data[1], ^~~ ckhdid->data is unconditionally defined as `u8

[PATCH v2 18/24] drivers: thermal: tsens: Move get_temp_tsens_v2 to allow sharing

2019-02-28 Thread Amit Kucheria
Just rename the function and move it to allow code sharing with future versions of TSENS IP Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 35 +++ drivers/thermal/qcom/tsens-v2.c | 37 + drivers/thermal/qcom/tsens.h

[PATCH v2 19/24] drivers: thermal: tsens: Common get_temp() learns to do ADC conversion

2019-02-28 Thread Amit Kucheria
get_temp() learns to return temperature regardless of whether it is returned as ADC code or direct temperature. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

[PATCH v2 21/24] drivers: thermal: tsens: Add generic support for TSENS v1 IP

2019-02-28 Thread Amit Kucheria
qcs404 has a single TSENS IP block with 10 sensors. It uses version 1.4 of the TSENS IP, functionality for which is encapsulated inside the qcom,tsens-v1 compatible. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/Makefile | 4 +- drivers/thermal/qcom/tsens-v1.c | 194

[PATCH v2 16/24] drivers: thermal: tsens: Introduce IP-specific max_sensor count

2019-02-28 Thread Amit Kucheria
The IP can support 'm' sensors while the platform can enable 'n' sensors of the 'm' where n <= m. Track maximum sensors supported by the IP so that we can correctly track what subset of the sensors are supported on the platform. Signed-off-by: Amit Kucheria ---

[PATCH v2 23/24] arm64: dts: qcom: qcs404: Add thermal zones for each sensor

2019-02-28 Thread Amit Kucheria
qcs404 has 10 sensors connected to the single TSENS IP. Define a thermal zone for each of those sensors to expose the temperature of each zone. Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 252 +++ 1 file changed, 252 insertions(+) diff --git

[PATCH v2 24/24] drivers: thermal: tsens: Move calibration constants to header file

2019-02-28 Thread Amit Kucheria
This will allow calibration routines to correctly include the constants from anywhere and allow more code sharing. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 5 - drivers/thermal/qcom/tsens.h| 5 + 2 files changed, 5 insertions(+), 5 deletions(-)

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-28 Thread Masami Hiramatsu
On Tue, 26 Feb 2019 10:24:47 -0500 Joel Fernandes wrote: > On Fri, Feb 22, 2019 at 11:27:05AM -0800, Alexei Starovoitov wrote: > > On Fri, Feb 22, 2019 at 09:43:14AM -0800, Linus Torvalds wrote: > > > > > > Then we should still probably fix up "__probe_kernel_read()" to not > > > allow user

[PATCH v4 0/6] tracing/probes: uaccess: Add support user-space access

2019-02-28 Thread Masami Hiramatsu
Hi, Here is the v4 series of probe-event to support user-space access. This version I fixed some issues pointed out by Steve (Thanks!) and add a ftrace testcase for this feature. - [4/6]: Add Steve's Ack - [5/6]: Fix a bug and documentation - [6/6]: New: add a new testcase Kprobe event

[PATCH v4 2/6] uaccess: Use user_access_ok() in user_access_begin()

2019-02-28 Thread Masami Hiramatsu
Use user_access_ok() instead of access_ok() in user_access_begin() to validate the access context is user. This also allow us to use (generic) strncpy_from_user() and strnlen_user() in atomic state with setting USER_DS and disable pagefaults. Signed-off-by: Masami Hiramatsu ---

[PATCH v4 1/6] uaccess: Add user_access_ok()

2019-02-28 Thread Masami Hiramatsu
From: Peter Zijlstra Add user_access_ok() macro which ensures current context is user context, or explicitly do set_fs(USER_DS). This function is very much like access_ok(), except it (may) have different context validation. In general we must be very careful when using this. Signed-off-by:

Re: [PATCH] sched/cputime: Remove unnecessary assignment statement

2019-02-28 Thread Peter Zijlstra
Clearly, because reading comprehension isn't your strong point: A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? On Thu, Feb 28, 2019 at 12:14:09PM +, Sachin Nikam

Re: kernel panic: MAC Initialization failed.

2019-02-28 Thread Tetsuo Handa
On 2019/02/28 19:58, Tetsuo Handa wrote: > But the problem is that since syzbot is automated, there is no chance to > edit the content of security/tomoyo/policy/ directory when building the > kernels. Thinking again, I realized that it would be possible to automatically generate the content of

[PATCH v4 3/6] uaccess: Add non-pagefault user-space read functions

2019-02-28 Thread Masami Hiramatsu
Add probe_user_read() and strncpy_from_unsafe_user() which allows caller to access user-space in IRQ context. Current probe_kernel_read() and strncpy_from_unsafe() are not available for user-space memory, because it sets KERNEL_DS while accessing data. On some arch, user address space and kernel

[PATCH v4 4/6] tracing/probe: Add ustring type for user-space string

2019-02-28 Thread Masami Hiramatsu
Add "ustring" type for fetching user-space string from kprobe event. User can specify ustring type at uprobe event, and it is same as "string" for uprobe. Note that probe-event provides this option but it doesn't choose the correct type automatically since we have not way to decide the address is

Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-28 Thread Enric Balletbo Serra
Hi, Based on the discussion we had, only some few comments. Missatge de Rushikesh S Kadam del dia dg., 24 de febr. 2019 a les 10:15: > > Intel Integrated Sensor Hub (ISH) is also a MCU running EC > having feature bit EC_FEATURE_ISH. Instantiate it as a special > CrOS EC device with device name

[PATCH v4 6/6] selftests/ftrace: Add user-memory access syntax testcase

2019-02-28 Thread Masami Hiramatsu
Add a user-memory access syntax testcase which checks new user-memory access syntax and ustring type. Signed-off-by: Masami Hiramatsu --- .../ftrace/test.d/kprobe/kprobe_args_user.tc | 31 1 file changed, 31 insertions(+) create mode 100644

Re: [PATCH 2/2] mm/dax: Don't enable huge dax mapping by default

2019-02-28 Thread Aneesh Kumar K.V
On 2/28/19 3:10 PM, Jan Kara wrote: On Thu 28-02-19 14:05:22, Aneesh Kumar K.V wrote: Add a flag to indicate the ability to do huge page dax mapping. On architecture like ppc64, the hypervisor can disable huge page support in the guest. In such a case, we should not enable huge page dax

[GIT PULL] tee subsys fixes for v5.0

2019-02-28 Thread Jens Wiklander
Hello arm-soc maintainers, Please pull this last minute fix for the OP-TEE driver. Thanks, Jens The following changes since commit 49a57857aeea06ca831043acbb0fa5e0f50602fd: Linux 5.0-rc3 (2019-01-21 13:14:44 +1300) are available in the Git repository at:

[PATCH v4 5/6] tracing/probe: Support user-space dereference

2019-02-28 Thread Masami Hiramatsu
Support user-space dereference syntax for probe event arguments to dereference the data-structure or array in user-space. The syntax is just adding 'u' before an offset value. +|-u() e.g. +u8(%ax), +u0(+0(%si)) For example, if you probe do_sched_setscheduler(pid, policy, param) and record

Re: [PATCH 1/2] fs/dax: deposit pagetable even when installing zero page

2019-02-28 Thread Aneesh Kumar K.V
On 2/28/19 2:51 PM, Jan Kara wrote: On Thu 28-02-19 14:05:21, Aneesh Kumar K.V wrote: Architectures like ppc64 use the deposited page table to store hardware page table slot information. Make sure we deposit a page table when using zero page at the pmd level for hash. Without this we hit

Re: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Wei Liu
On Thu, Feb 28, 2019 at 12:07:07PM +, Paul Durrant wrote: > Yes, I meant kfree_skb(nskb). > In that case I think your patch looks fine. Wei.

Re: [PATCH v2] appletalk: Fix use-after-free in atalk_proc_exit

2019-02-28 Thread kbuild test robot
Hi YueHaibing, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on v5.0-rc8 next-20190228] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH V4 2/4] tpm: Reserve the TPM final events table

2019-02-28 Thread Jarkko Sakkinen
On Wed, Feb 27, 2019 at 11:57:09AM -0800, Matthew Garrett wrote: > On Wed, Feb 27, 2019 at 6:03 AM Jarkko Sakkinen > wrote: > > My guess is that your patches are based a later 5.0-rcX. Unfortunately I > > cannot update my master at this point because my 5.1 PR was taken to > > security tree and

Re: [PATCH v4 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-02-28 Thread Halil Pasic
On Thu, 28 Feb 2019 10:42:23 +0100 Christian Borntraeger wrote: > > > On 27.02.2019 19:00, Tony Krowiak wrote: > > On 2/27/19 3:09 AM, Pierre Morel wrote: > >> On 26/02/2019 16:47, Tony Krowiak wrote: > >>> On 2/26/19 6:47 AM, Pierre Morel wrote: > On 25/02/2019 19:36, Tony Krowiak wrote:

Re: [PATCH V15 14/18] block: enable multipage bvecs

2019-02-28 Thread Jon Hunter
On 28/02/2019 07:51, Marek Szyprowski wrote: > Hi Ming, > > On 2019-02-28 00:29, Ming Lei wrote: >> On Wed, Feb 27, 2019 at 08:47:09PM +, Jon Hunter wrote: >>> On 21/02/2019 08:42, Marek Szyprowski wrote: On 2019-02-15 12:13, Ming Lei wrote: > This patch pulls the trigger for

Re: [PATCH 2/2] mm/dax: Don't enable huge dax mapping by default

2019-02-28 Thread Aneesh Kumar K.V
On 2/28/19 3:10 PM, Oliver wrote: On Thu, Feb 28, 2019 at 7:35 PM Aneesh Kumar K.V wrote: Add a flag to indicate the ability to do huge page dax mapping. On architecture like ppc64, the hypervisor can disable huge page support in the guest. In such a case, we should not enable huge page dax

[PATCH v2] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Igor Druzhinin
Zero-copy callback flag is not yet set on frag list skb at the moment xenvif_handle_frag_list() returns -ENOMEM. This eventually results in leaking grant ref mappings since xenvif_zerocopy_callback() is never called for these fragments. Those eventually build up and cause Xen to kill Dom0 as the

Re: [PATCH] mm, memcg: Handle cgroup_disable=memory when getting memcg protection

2019-02-28 Thread Chris Down
Andrew Morton writes: Things settled down. Here's the rolled-up patch. Please review? Looks correct to me as patch author, thanks!

Re: [PATCH 2/2] seccomp.2: document userspace notification

2019-02-28 Thread Michael Kerrisk (man-pages)
[widening CC to the same scope as the code patches] Hello Tycho, Sorry for the late response on this. Could you amend/rebase your patches in light of the below please. And anyone's comment on my "big picture" text at the foot of this mail would be very welcome. On 12/13/18 1:11 AM, Tycho

Re: [PATCH v2] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Wei Liu
On Thu, Feb 28, 2019 at 12:48:03PM +, Igor Druzhinin wrote: > Zero-copy callback flag is not yet set on frag list skb at the moment > xenvif_handle_frag_list() returns -ENOMEM. This eventually results in > leaking grant ref mappings since xenvif_zerocopy_callback() is never > called for these

Re: [PATCH v2 2/4] mm: remove zone_lru_lock() function access ->lru_lock directly

2019-02-28 Thread William Kucharski
> On Feb 28, 2019, at 1:33 AM, Andrey Ryabinin wrote: > diff --git a/mm/vmscan.c b/mm/vmscan.c > index a9852ed7b97f..2d081a32c6a8 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1614,8 +1614,8 @@ static __always_inline void update_lru_sizes(struct > lruvec *lruvec, > > } > > -/* > - *

Re: [tip:x86/build] x86, retpolines: Raise limit for generating indirect calls from switch-case

2019-02-28 Thread H.J. Lu
On Thu, Feb 28, 2019 at 3:27 AM David Woodhouse wrote: > > On Thu, 2019-02-28 at 03:12 -0800, tip-bot for Daniel Borkmann wrote: > > Commit-ID: ce02ef06fcf7a399a6276adb83f37373d10cbbe1 > > Gitweb: > > https://git.kernel.org/tip/ce02ef06fcf7a399a6276adb83f37373d10cbbe1 > > Author: Daniel

Re: hdmi-codec: modifying params in hw_params() callback

2019-02-28 Thread Jyri Sarha
On 28/02/2019 14:15, Russell King - ARM Linux admin wrote: > Hi all, > > While looking at hdmi-codec issues, I spotted this code: > > static int hdmi_codec_hw_params(struct snd_pcm_substream *substream, > struct snd_pcm_hw_params *params, >

Re: missing stack trace entry on NULL pointer call [was: Re: BUG: unable to handle kernel NULL pointer dereference in __generic_file_write_iter]

2019-02-28 Thread Thomas Gleixner
On Thu, 28 Feb 2019, Jann Horn wrote: > +Josh for unwinding, +x86 folks > On Wed, Feb 27, 2019 at 11:43 PM Andrew Morton > wrote: > > On Thu, 21 Feb 2019 06:52:04 -0800 syzbot > > wrote: > > > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:4aa9fc2a435a

Re: [PATCH 11/15] habanalabs: print pointer using %p

2019-02-28 Thread Oded Gabbay
On Thu, Feb 28, 2019 at 2:02 PM Greg KH wrote: > > On Thu, Feb 28, 2019 at 11:55:45AM +0200, Oded Gabbay wrote: > > Don't cast pointer to u64 to print it. Instead, print the pointer using > > %p. > > > > Signed-off-by: Oded Gabbay > > --- > > Changes in v2: > > - Add changelog in the commit

Re: [PATCH v2 0/2] x86/mm/KASLR: Change the granularity of randomization to PUD size in 5-level

2019-02-28 Thread Baoquan He
On 02/28/19 at 01:30pm, Kirill A. Shutemov wrote: > > diff --git a/arch/x86/mm/kaslr.c b/arch/x86/mm/kaslr.c > > index 754b5da91d43..131e08a10a68 100644 > > --- a/arch/x86/mm/kaslr.c > > +++ b/arch/x86/mm/kaslr.c > > @@ -226,74 +226,68 @@ void __init kernel_randomize_memory(void) > > > > static

Re: [PATCH v2 07/10] PCI: call add_bus method also for root bus

2019-02-28 Thread Thomas Bogendoerfer
On Thu, Feb 21, 2019 at 05:37:08PM -0600, Bjorn Helgaas wrote: > I haven't researched the details of how other platforms do it, but if > it would be possible for pci-xtalk to do it the same way, that would > be ideal. I don't need this patch any longer. So you could just ignore it. Thomas. --

Re: [PATCH] scsi: smartpqi_init: Reporting 'logical unit failure'

2019-02-28 Thread Erwan Velu
Hey, That makes me wonder why the 0x3e / 0x2 isn't handled here aka 3E/02 DZTPROMAEBKVF TIMEOUT ON LOGICAL UNIT Is it possible the controller send to the kernel this kind of message, if so shouldn't we handle it here ? Erwan, Le 27/02/2019 à 17:31, Erwan Velu a écrit : > When this

Re: [PATCH v4 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-02-28 Thread Pierre Morel
On 28/02/2019 12:03, Christian Borntraeger wrote: On 28.02.2019 10:42, Christian Borntraeger wrote: [...] Okay, let's go back to the genesis of this discussion; namely, my suggestion about moving the fc == 0x03 check into the hook code. If the vfio_ap module is not loaded, there will be no

Re: hdmi-codec: modifying params in hw_params() callback

2019-02-28 Thread Russell King - ARM Linux admin
On Thu, Feb 28, 2019 at 02:54:29PM +0200, Jyri Sarha wrote: > On 28/02/2019 14:15, Russell King - ARM Linux admin wrote: > > Hi all, > > > > While looking at hdmi-codec issues, I spotted this code: > > > > static int hdmi_codec_hw_params(struct snd_pcm_substream *substream, > >

[GIT PULL] tee subsys for v5.1

2019-02-28 Thread Jens Wiklander
Hello arm-soc maintainers, Please pull these small TEE subsystem updates. The license for two .h files in OP-TEE driver is clarified with a dual license. The kernel space tee client interface is complemented with cancellation support. I've based this pull request on the last pull request I did

Re: [PATCH] arm64: dts: qcom: Add Dragonboard 845c

2019-02-28 Thread kbuild test robot
Hi Bjorn, I love your patch! Yet something to improve: [auto build test ERROR on agross/for-next] [also build test ERROR on v5.0-rc8 next-20190228] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v4 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-02-28 Thread Pierre Morel
On 28/02/2019 12:22, Cornelia Huck wrote: On Thu, 28 Feb 2019 12:03:38 +0100 Christian Borntraeger wrote: On 28.02.2019 10:42, Christian Borntraeger wrote: [...] Okay, let's go back to the genesis of this discussion; namely, my suggestion about moving the fc == 0x03 check into the hook code.

<    1   2   3   4   5   6   7   8   9   10   >