[PATCH] perf tools: return errcode in cs_etm__process_auxtrace_info

2019-03-14 Thread Yue Haibing
From: YueHaibing 'err' is set in err path, but it's not returned to callers. Also fix a pass zero to PTR_ERR issue. Fixes: cd8bfd8c973e ("perf tools: Add processing of coresight metadata") Signed-off-by: YueHaibing --- tools/perf/util/cs-etm.c | 4 ++-- 1 file changed, 2 insertions(+), 2

RE: [RFC PATCH 0/3] Add support of busfreq

2019-03-14 Thread Aisheng Dong
+Jacky and Leonard, Ranjani Hi Alexandre, > From: Alexandre Bailon [mailto:abai...@baylibre.com] > > This series implements busfreq, a framework used in MXP's tree to scale the > interconnect and dram frequencies. > In the vendor tree, device's driver request for a performance level, which is >

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-14 Thread Joel Fernandes
On Thu, Mar 14, 2019 at 01:49:11PM -0700, Sultan Alsawaf wrote: > On Thu, Mar 14, 2019 at 10:47:17AM -0700, Joel Fernandes wrote: > > About the 100ms latency, I wonder whether it is that high because of > > the way Android's lmkd is observing that a process has died. There is > > a gap between

Re: [PATCH] scripts/spelling.txt: add more typos to spelling.txt and sort

2019-03-14 Thread Finn Thain
Does it makes sense to list every typo that is simply a transposition of characters or a character omitted? This file will become very large very quickly if we do that. Such errors can be found algorithmically where the correct spelling is known. E.g. the file contains 'algorithm' so

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-14 Thread Steven Rostedt
On Thu, 14 Mar 2019 13:49:11 -0700 Sultan Alsawaf wrote: > Perhaps I'm missing something, but if you want to know when a process has died > after sending a SIGKILL to it, then why not just make the SIGKILL optionally > block until the process has died completely? It'd be rather trivial to just >

Re: [PATCH 1/5] lib/sort: Make swap functions more generic

2019-03-14 Thread George Spelvin
>> swap_bytes / swap_4byte_words / swap_8byte_words >> swap_bytes / swap_ints / swap_longs >> swap_1 / swap_4 / swap_8 >> Pistols at dawn? On Thu, 14 Mar 2019 at 22:59:55 +0300, Andrey Abramov wrote: > Yes, in my opinion, swap_bytes / swap_ints / swap_longs are the > most readable because we have

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-14 Thread Sultan Alsawaf
On Thu, Mar 14, 2019 at 10:54:48PM -0400, Joel Fernandes wrote: > I'm not sure if that makes much semantic sense for how the signal handling is > supposed to work. Imagine a parent sends SIGKILL to its child, and then does > a wait(2). Because the SIGKILL blocks in your idea, then the wait cannot

[PATCH] sound: soc-pcm: add a check to avoid NULL pointer dereference

2019-03-14 Thread Kangjie Lu
In case debugfs_create_u32 fails, the fix frees memory and returns an error to notify callers. Signed-off-by: Kangjie Lu --- sound/soc/soc-pcm.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-14 Thread Sultan Alsawaf
On Thu, Mar 14, 2019 at 11:16:41PM -0400, Steven Rostedt wrote: > How would you implement such a method in userspace? kill() doesn't take > any parameters but the pid of the process you want to send a signal to, > and the signal to send. This would require a new system call, and be > quite a bit

[PATCH] sound: rt5645: fix a NULL pointer dereference

2019-03-14 Thread Kangjie Lu
devm_kcalloc() may fail and return NULL. The fix returns ENOMEM in case it fails to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- sound/soc/codecs/rt5645.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index

[PATCH] sound: cs43130: fix a NULL pointer dereference

2019-03-14 Thread Kangjie Lu
In case create_singlethread_workqueue fails, the fix returns -ENOMEM to avoid potential NULL pointer dereference. Signed-off-by: Kangjie Lu --- sound/soc/codecs/cs43130.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/cs43130.c b/sound/soc/codecs/cs43130.c index

[PATCH] futex:fix robust futex alignment exception

2019-03-14 Thread chenjie6
From: chen jie trinity test bug fix: /tmp/trinity --children 4 --quiet -N 1000 --logging=off -X -x perf_event_open --enable-fds=testfile [1542.195981] Task track: trinity-c3(6911)>trinity-main(28313)>sh(839)>bash(824)>sshd(820)>sshd(662)>init(1) [11542.214694] Alignment trap: not handling

[PATCH] sound: echoaudio: add a check for ioremap_nocache

2019-03-14 Thread Kangjie Lu
In case ioremap_nocache fails, the fix releases chip and returns an error code upstream to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- sound/pci/echoaudio/echoaudio.c | 5 + 1 file changed, 5 insertions(+) diff --git a/sound/pci/echoaudio/echoaudio.c

[PATCH] sound: sb8: add a check for request_region

2019-03-14 Thread Kangjie Lu
In case request_region fails, the fix returns an error code to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- sound/isa/sb/sb8.c | 4 1 file changed, 4 insertions(+) diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c index aa2a83eb81a9..dc27a480c2d9 100644 ---

[PATCH] security: inode: fix a missing check for securityfs_create_file

2019-03-14 Thread Kangjie Lu
securityfs_create_file may fail. The fix checks its status and returns EFAULT upstream if it fails. Signed-off-by: Kangjie Lu --- security/inode.c | 5 + 1 file changed, 5 insertions(+) diff --git a/security/inode.c b/security/inode.c index b7772a9b315e..11d9a6bc2161 100644 ---

Re: [PATCH] perf annotate: Remove hist__account_cycles from callback

2019-03-14 Thread Jin, Yao
On 3/14/2019 10:17 PM, Jin, Yao wrote: On 3/14/2019 8:04 PM, Jiri Olsa wrote: On Wed, Mar 13, 2019 at 04:22:54AM +0800, Jin Yao wrote: The hist__account_cycles is executed when the hist_iter__branch_callback is called. But it looks it's not necessary. In hist__account_cycles, it already

Re: [PATCH 4/5] lib/list_sort: Simplify and remove MAX_LIST_LENGTH_BITS

2019-03-14 Thread George Spelvin
On Thu, 14 Mar 2019 at 11:10:41 +0200, Andy Shevchenko wrote: > On Tue, Mar 05, 2019 at 03:06:44AM +, George Spelvin wrote: >> +for (bit = 1; count & bit; bit <<= 1) { >> +cur = merge(priv, (cmp_func)cmp, pending, cur); >> +pending =

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-14 Thread Daniel Colascione
On Thu, Mar 14, 2019 at 8:16 PM Steven Rostedt wrote: > > On Thu, 14 Mar 2019 13:49:11 -0700 > Sultan Alsawaf wrote: > > > Perhaps I'm missing something, but if you want to know when a process has > > died > > after sending a SIGKILL to it, then why not just make the SIGKILL optionally > >

tty: uartlite: GP fault when calling tty_unregister_driver()

2019-03-14 Thread Randy Dunlap
This is on v5.0-11053-gebc551f2b8f9 on x86_64. (March 12, 2019) Just load uartlite module and then unload it. [ 75.334373] calling ulite_init+0x0/0x1000 [uartlite] @ 1655 [ 75.334634] initcall ulite_init+0x0/0x1000 [uartlite] returned 0 after 223 usecs [ 80.145544] kasan:

Re: [PATCH 5/5] ocxl: Remove some unused exported symbols

2019-03-14 Thread Andrew Donnellan
On 13/3/19 3:07 pm, Alastair D'Silva wrote: From: Alastair D'Silva Remove some unused exported symbols. Signed-off-by: Alastair D'Silva See comments on v1 --- drivers/misc/ocxl/config.c| 2 -- drivers/misc/ocxl/ocxl_internal.h | 23 +++

[PATCH] tty: 8250: fix a missing check for pci_ioremap_bar

2019-03-14 Thread Kangjie Lu
pci_ioremap_bar could fail. The fix captures the failure and pass an error code upstream. This can avoid potential NULL pointer dereferences in the future. Signed-off-by: Kangjie Lu --- drivers/tty/serial/8250/8250_lpss.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff

[PATCH] pci: endpoint: fix a potential NULL pointer dereference

2019-03-14 Thread Kangjie Lu
In case alloc_workqueue, the fix returns -ENOMEM to avoid potential NULL pointer dereferences. Signed-off-by: Kangjie Lu --- drivers/pci/endpoint/functions/pci-epf-test.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c

Re: [PATCH 5/5] ocxl: Remove some unused exported symbols

2019-03-14 Thread Andrew Donnellan
On 15/3/19 3:49 pm, Andrew Donnellan wrote: On 13/3/19 3:07 pm, Alastair D'Silva wrote: From: Alastair D'Silva Remove some unused exported symbols. Signed-off-by: Alastair D'Silva See comments on v1 Also a couple of sparse warnings at

Re: [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get

2019-03-14 Thread Vaibhav Agarwal
On Thu, Mar 14, 2019 at 12:15 PM Kangjie Lu wrote: > > ida_simple_get could fail. The fix inserts a check for its > return value. > > Signed-off-by: Kangjie Lu > --- > drivers/staging/greybus/audio_manager.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [PATCH] tty: 8250: fix a missing check for pci_ioremap_bar

2019-03-14 Thread Jiri Slaby
On 15. 03. 19, 5:56, Kangjie Lu wrote: > pci_ioremap_bar could fail. The fix captures the failure and > pass an error code upstream. This can avoid potential NULL > pointer dereferences in the future. > > Signed-off-by: Kangjie Lu > --- > drivers/tty/serial/8250/8250_lpss.c | 13 - >

Re: [PATCH] scripts/spelling.txt: add more typos to spelling.txt and sort

2019-03-14 Thread Like Xu
On 2019/3/15 11:07, Finn Thain wrote: Does it makes sense to list every typo that is simply a transposition of characters or a character omitted? This file will become very large very quickly if we do that. We are consistent in one thing: typo hurt eyes. Those typos are exactly generated

[PATCH v2] perf annotate/report: Remove hist__account_cycles from callback

2019-03-14 Thread Jin Yao
The hist__account_cycles is executed when the hist_iter__branch_callback is called. But it looks it's not necessary. In hist__account_cycles, it already walks on all branch entries. This patch moves the hist__account_cycles out of callback, now the data processing is much faster than before.

[PATCH] power: charger-manager: fix a potential NULL pointer dereference

2019-03-14 Thread Kangjie Lu
In case create_freezable_workqueue fails, the fix return -ENOMEM to avoid a potential NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/power/supply/charger-manager.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/power/supply/charger-manager.c

Re: [RFC][PATCH 00/16] sched: Core scheduling

2019-03-14 Thread Li, Aubrey
The original patch seems missing the following change for 32bit. Thanks, -Aubrey diff --git a/kernel/sched/cpuacct.c b/kernel/sched/cpuacct.c index 9fbb10383434..78de28ebc45d 100644 --- a/kernel/sched/cpuacct.c +++ b/kernel/sched/cpuacct.c @@ -111,7 +111,7 @@ static u64

[PATCH] rapidio: fix a NULL pointer derefenrece when create_workqueue fails

2019-03-14 Thread Kangjie Lu
In case create_workqueue fails, the fix releases resources and returns -ENOMEM to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/rapidio/rio_cm.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c index

[PATCH 1/2] cifs: remove unused status severity defines

2019-03-14 Thread Sergey Senozhatsky
STATUS_SEVERITY_* do not appear to be used by anyone, so drop them. Besides, the name of __constant_cpu_to_le32() is misspelled there: __constanst_cpu_to_le32(). Signed-off-by: Sergey Senozhatsky --- fs/cifs/smb2status.h | 5 - 1 file changed, 5 deletions(-) diff --git

Re: [PATCH 1/4] dt-bindings: opp: Introduce opp-bw-MBs bindings

2019-03-14 Thread Viresh Kumar
On 13-03-19, 11:00, Georgi Djakov wrote: > In addition to frequency and voltage, some devices may have bandwidth > requirements for their interconnect throughput - for example a CPU > or GPU may also need to increase or decrease their bandwidth to DDR > memory based on the current operating

[PATCH V3 0/5] Add i.MX7ULP EVK PWM backlight support

2019-03-14 Thread Anson Huang
i.MX7ULP EVK board has MIPI-DSI display, its backlight is supplied by TPM PWM module, this patch set enables i.MX7ULP TPM PWM driver support and also add backlight support for MIPI-DSI display. Anson Huang (5): dt-bindings: pwm: Add i.MX TPM PWM binding pwm: Add i.MX TPM PWM driver support

Re: [PATCH] mm: fix a wrong flag in set_migratetype_isolate()

2019-03-14 Thread Michal Hocko
On Wed 13-03-19 17:25:07, Qian Cai wrote: > Due to has_unmovable_pages() takes an incorrect irqsave flag instead of > the isolation flag in set_migratetype_isolate(), it causes issues with > HWPOSION and error reporting where dump_page() is not called when there > is an unmoveable page. > >

[PATCH V3 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding

2019-03-14 Thread Anson Huang
Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM binding. Signed-off-by: Anson Huang --- No changes since V2. --- Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt | 19 +++ 1 file changed, 19 insertions(+) create mode 100644

[PATCH V3 5/5] ARM: dts: imx7ulp-evk: Add backlight support

2019-03-14 Thread Anson Huang
This patch adds i.MX7ULP EVK board MIPI-DSI backlight support. Signed-off-by: Anson Huang --- No changes since V2. --- arch/arm/boot/dts/imx7ulp-evk.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/imx7ulp-evk.dts b/arch/arm/boot/dts/imx7ulp-evk.dts index

[PATCH V3 3/5] ARM: imx_v6_v7_defconfig: Add TPM PWM support by default

2019-03-14 Thread Anson Huang
Select CONFIG_PWM_IMX_TPM by default to support i.MX7ULP TPM PWM. Signed-off-by: Anson Huang --- No changes since V2. --- arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index

[PATCH V3 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-14 Thread Anson Huang
i.MX7ULP has TPM(Low Power Timer/Pulse Width Modulation Module) inside, add TPM PWM driver support. Signed-off-by: Anson Huang --- Changes since V2: - Add "IMX_" as prefix to macro define as TPM is already used; - Use macro define for channel registers address instead of

[PATCH V3 4/5] ARM: dts: imx7ulp: Add pwm0 support

2019-03-14 Thread Anson Huang
Add i.MX7ULP EVK board PWM0 support. Signed-off-by: Anson Huang --- No changes since V2. --- arch/arm/boot/dts/imx7ulp-evk.dts | 12 arch/arm/boot/dts/imx7ulp.dtsi| 10 ++ 2 files changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/imx7ulp-evk.dts

Re: [Qestion] Hit a WARN_ON_ONCE in try_to_unmap_one when runing syzkaller

2019-03-14 Thread Naoya Horiguchi
Hi, On Wed, Mar 13, 2019 at 12:03:20AM +0800, zhong jiang wrote: ... > > Minchan has changed the conditon check from BUG_ON to WARN_ON_ONCE in > try_to_unmap_one. > However, It is still an abnormal condition when PageSwapBacked is not equal > to PageSwapCache. > > But Is there any case it

Re: [PATCH 2/4] OPP: Add support for parsing the interconnect bandwidth

2019-03-14 Thread Viresh Kumar
On 13-03-19, 11:00, Georgi Djakov wrote: > The OPP bindings now support bandwidth values, so add support to parse it > from device tree and store it into the new dev_pm_opp_icc_bw struct, which > is part of the dev_pm_opp. > > Also add and export the dev_pm_opp_set_path() and

Re: [PATCH] mm/hotplug: fix notification in offline error path

2019-03-14 Thread Michal Hocko
On Wed 13-03-19 17:09:39, Qian Cai wrote: > When start_isolate_page_range() returned -EBUSY in __offline_pages(), it > calls memory_notify(MEM_CANCEL_OFFLINE, ) with an uninitialized > "arg". As the result, it triggers warnings below. Also, it is only > necessary to notify MEM_CANCEL_OFFLINE after

[PATCH] spi: fix NULL pointer dereferences by checking dmaengine_prep_slave_sg

2019-03-14 Thread Kangjie Lu
In case dmaengine_prep_slave_sg fails, the fix returns to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/spi/spi-s3c64xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 7b7151ec14c8..3a5f161ce558 100644

[PATCH 0/7] cpufreq: Call transition notifier only once for each policy

2019-03-14 Thread Viresh Kumar
Currently we call the cpufreq transition notifiers once for each CPU of the policy->cpus cpumask, which isn't that efficient. This patchset tries to simplify that by adding another field in struct cpufreq_freqs, cpus, so the callback has all the information available with a single call for each

[PATCH 1/7] cpufreq: Pass policy->related_cpus to transition notifiers

2019-03-14 Thread Viresh Kumar
Currently we call these notifiers once for each CPU of the policy->cpus cpumask, which isn't that efficient. This patch adds a cpumask pointer to struct cpufreq_freqs and copies policy->related_cpus to it. The notifiers will have information about all the affected CPUs now with the first call

[PATCH 3/7] ARM: twd: Update cpufreq transition notifier to handle multiple CPUs

2019-03-14 Thread Viresh Kumar
The cpufreq core currently calls the cpufreq transition notifier callback once for each affected CPU. This is going to change soon and the cpufreq core will call the callback only once for each cpufreq policy. The callback must look at the newly added field in struct cpufreq_freqs, "cpus", which

[PATCH 4/7] sparc64: Update cpufreq transition notifier to handle multiple CPUs

2019-03-14 Thread Viresh Kumar
The cpufreq core currently calls the cpufreq transition notifier callback once for each affected CPU. This is going to change soon and the cpufreq core will call the callback only once for each cpufreq policy. The callback must look at the newly added field in struct cpufreq_freqs, "cpus", which

[PATCH 7/7] cpufreq: Call transition notifiers only once for each policy

2019-03-14 Thread Viresh Kumar
Now that all the transition notifier callbacks are updated to not rely on freqs->cpu and perform actions for all CPUs in the freqs->cpus field, it is time to get rid of freqs->cpu field and call the notifiers only once for each cpufreq policy. Signed-off-by: Viresh Kumar ---

[PATCH 6/7] KVM: x86: Update cpufreq transition notifier to handle multiple CPUs

2019-03-14 Thread Viresh Kumar
The cpufreq core currently calls the cpufreq transition notifier callback once for each affected CPU. This is going to change soon and the cpufreq core will call the callback only once for each cpufreq policy. The callback must look at the newly added field in struct cpufreq_freqs, "cpus", which

[PATCH 5/7] x86/tsc: Update cpufreq transition notifier to handle multiple CPUs

2019-03-14 Thread Viresh Kumar
The cpufreq core currently calls the cpufreq transition notifier callback once for each affected CPU. This is going to change soon and the cpufreq core will call the callback only once for each cpufreq policy. The callback must look at the newly added field in struct cpufreq_freqs, "cpus", which

[PATCH 2/7] ARM: smp: Update cpufreq transition notifier to handle multiple CPUs

2019-03-14 Thread Viresh Kumar
The cpufreq core currently calls the cpufreq transition notifier callback once for each affected CPU. This is going to change soon and the cpufreq core will call the callback only once for each cpufreq policy. The callback must look at the newly added field in struct cpufreq_freqs, "cpus", which

[PATCH] greybus: audio_manager: fix a missing check of ida_simple_get

2019-03-14 Thread Kangjie Lu
ida_simple_get could fail. The fix inserts a check for its return value. Signed-off-by: Kangjie Lu --- drivers/staging/greybus/audio_manager.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c index

[PATCH] kvm/x86/vmx: switch MSR_MISC_FEATURES_ENABLES between host and guest

2019-03-14 Thread Xiaoyao Li
CPUID Faulting is a feature about CPUID instruction. When CPUID Faulting is enabled, all execution of the CPUID instruction outside system-management mode (SMM) cause a general-protection (#GP) if the CPL > 0. About this feature, detailed information can be found at

Re: [PATCH 3/3] RISC-V: Allow booting kernel from any 4KB aligned address

2019-03-14 Thread Mike Rapoport
On Thu, Mar 14, 2019 at 02:36:01AM +0530, Anup Patel wrote: > On Thu, Mar 14, 2019 at 12:01 AM Mike Rapoport wrote: > > > > On Tue, Mar 12, 2019 at 10:08:22PM +, Anup Patel wrote: > > > Currently, we have to boot RISCV64 kernel from a 2MB aligned physical > > > address and RISCV32 kernel from

Re: [PATCH 1/2] cifs: remove unused status severity defines

2019-03-14 Thread Steve French
Since this file (smb2status.h) is intended to track the official protocol documentation (albeit smb2status.h probably needs to be updated), in this case the protocol document MS-ERREF. I would prefer to keep it closer to MS-ERREF and leave definitions in even if unused (if nothing else it helps

[PATCH] thunderbolt: fix a missing check of kmemdup

2019-03-14 Thread Kangjie Lu
kmemdup may fail and return NULL. The fix adds a check and returns NULL in case it fails to avoid NULL pointer dereferecen. Signed-off-by: Kangjie Lu --- drivers/thunderbolt/property.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/thunderbolt/property.c

Re: [PATCH v3] lib/siphash.c: annotate implicit fall throughs

2019-03-14 Thread Jason A. Donenfeld
Hi Mathieu, Thanks for getting this v3 into shape. On Wed, Mar 13, 2019 at 3:12 PM Mathieu Malaterre wrote: > There is a plan to build the kernel with -Wimplicit-fallthrough and > these places in the code produced warnings (W=1). Fix them up. > > This commit remove the following warnings: > >

Re: [PATCH 1/2] cifs: remove unused status severity defines

2019-03-14 Thread Steve French
updated it to fix the spelling mistake On Thu, Mar 14, 2019 at 1:54 AM Steve French wrote: > > Since this file (smb2status.h) is intended to track the official > protocol documentation (albeit smb2status.h probably needs to be > updated), in this case the protocol document MS-ERREF. I would

[PATCH] tty: ipwireless: fix missing checks for ioremap

2019-03-14 Thread Kangjie Lu
ipw->attr_memory and ipw->common_memory are assigned with the return value of ioremap. ioremap may fail, but not checks are enforced. The fix insertss the checks. Signed-off-by: Kangjie Lu --- drivers/tty/ipwireless/main.c | 8 1 file changed, 8 insertions(+) diff --git

Re: [PATCH 1/2] cifs: remove unused status severity defines

2019-03-14 Thread Sergey Senozhatsky
On (03/14/19 01:54), Steve French wrote: > Since this file (smb2status.h) is intended to track the official > protocol documentation (albeit smb2status.h probably needs to be > updated), in this case the protocol document MS-ERREF. I would prefer > to keep it closer to MS-ERREF and leave

Re: [PATCH] EDAC, {skx|i10nm}_edac: Fix randconfig build error

2019-03-14 Thread Arnd Bergmann
On Thu, Mar 14, 2019 at 12:01 AM Luck, Tony wrote: > > On Wed, Mar 06, 2019 at 09:15:13PM +0100, Arnd Bergmann wrote: > > On Wed, Mar 6, 2019 at 6:58 PM Luck, Tony wrote: > > > From: Qiuxu Zhuo > > > > > > This seems cleaner than adding all the EXPORTs to skx_common.c > > > I also tried a build

Re: [RFC PATCH RT] x86/tsc: Add option to disable tsc clocksource watchdog

2019-03-14 Thread Juri Lelli
Hi, On 07/03/19 13:09, Juri Lelli wrote: > Clocksource watchdog has been found responsible for generating latency > spikes (in the 10-20 us range) when woken up to check for TSC stability. > > Add an option to disable it at boot. Gentle ping. Does this make any sense? Thanks, - Juri

Re: [PATCH] kvm/x86/vmx: switch MSR_MISC_FEATURES_ENABLES between host and guest

2019-03-14 Thread Xiaoyao Li
Besides, Peter's this patch https://patchwork.kernel.org/patch/10850143/ adds the handling of cpuid faulting in #GP handler. What's more, it enalbes cpuid fauting once function *clear_cpu_cap()* called successfully. From my tests, during kernel booting, there always are some features cleared,

Re: [PATCH 1/2] cifs: remove unused status severity defines

2019-03-14 Thread Sergey Senozhatsky
On (03/14/19 02:04), Steve French wrote: [..] > #define STATUS_SEVERITY_SUCCESS __constant_cpu_to_le32(0x) Does STATUS_SEVERITY_SUCCESS still use __constant_cpu_to_le32? > -#define STATUS_SEVERITY_INFORMATIONAL __constanst_cpu_to_le32(0x0001) > -#define STATUS_SEVERITY_WARNING

drivers/iio/chemical/sps30.c:122:30: sparse: cast truncates bits from constant value (8004 becomes 4)

2019-03-14 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: fa3d493f7a573b4e4e2538486e912093a0161c1b commit: 62129a0849d27cc94ced832bcf9dcde283dcbe08 iio: chemical: sps30: allow changing self cleaning period date: 8 weeks ago reproduce: # apt-get install

[PATCH] tty: atmel_serial: fix a NULL pointer dereference

2019-03-14 Thread Kangjie Lu
In case dmaengine_prep_dma_cyclic fails, the fix return a proper error code to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/tty/serial/atmel_serial.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/atmel_serial.c

Re: [PATCH 1/2] cifs: remove unused status severity defines

2019-03-14 Thread Steve French
All of those uses of __constant_cpu_to_le32 apparently (at least according to checkpatch) should be changed (someday) to cpu_to_le32 but I didn't research why the change from __constant_cpu_to_le32 ---> cpu_to_le32 If it has benefit - and checkpatch is right (it warned about

[PATCH] tty: mxs-auart: fix a NULL pointer dereference

2019-03-14 Thread Kangjie Lu
In case ioremap fails, the fix returns -ENOMEM to avoid NULL pointer dereferences. Multiple places use port.membase. Signed-off-by: Kangjie Lu --- drivers/tty/serial/mxs-auart.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/tty/serial/mxs-auart.c

Re: [PATCH 0/2] add gpu node support on rock960 and rockpi4

2019-03-14 Thread Manivannan Sadhasivam
Hi, On Thu, Mar 14, 2019 at 12:48:40PM +0530, Akash Gajjar wrote: > add gpu node support on both rockchip-rk3399 board. > performance tested with freedesktop.org panfrost mali driver. > > Akash Gajjar (2): > arm64: dts: rockchip: add mali gpu support on rockpi4 > arm64: dts: rockchip: add

Re: overlayfs vs. fscrypt

2019-03-14 Thread Miklos Szeredi
On Wed, Mar 13, 2019 at 11:42 PM Richard Weinberger wrote: > > Am Mittwoch, 13. März 2019, 23:26:11 CET schrieb Eric Biggers: > > What specifically is wrong with supporting the ciphertext "view" of > > encrypted > > directories, and why do you want to opt UBIFS out of it specifically but not >

Re: [PATCH 1/2] cifs: remove unused status severity defines

2019-03-14 Thread Sergey Senozhatsky
On (03/14/19 02:19), Steve French wrote: > All of those uses of __constant_cpu_to_le32 apparently (at least > according to checkpatch) should be changed (someday) to cpu_to_le32 > but I didn't research why the change from __constant_cpu_to_le32 > ---> cpu_to_le32 Probably historic reasons.

[PATCH] fs: affs: fix a NULL pointer dereference

2019-03-14 Thread Kangjie Lu
If affs_bread fails, do not use ext_bh to avoid NULL pointer dereference Signed-off-by: Kangjie Lu --- fs/affs/file.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/fs/affs/file.c b/fs/affs/file.c index a85817f54483..45b96faa40f1 100644 --- a/fs/affs/file.c +++

Re: [PATCH 07/34] vfs: Add configuration parser helpers [ver #12]

2019-03-14 Thread Geert Uytterhoeven
Hi David, On Fri, Sep 21, 2018 at 6:33 PM David Howells wrote: > Because the new API passes in key,value parameters, match_token() cannot be > used with it. Instead, provide three new helpers to aid with parsing: > --- a/fs/Kconfig > +++ b/fs/Kconfig > @@ -8,6 +8,13 @@ menu "File systems" >

RE: [RESEND PATCH] PM / devfreq: Fix static checker warning in try_then_request_governor

2019-03-14 Thread MyungJoo Ham
>The patch 23c7b54ca1cd: "PM / devfreq: Fix devfreq_add_device() when >drivers are built as modules." leads to the following static checker >warning: > >drivers/devfreq/devfreq.c:1043 governor_store() >warn: 'governor' can also be NULL > >The reason is that the try_then_request_governor()

Re: [Qestion] Hit a WARN_ON_ONCE in try_to_unmap_one when runing syzkaller

2019-03-14 Thread zhong jiang
On 2019/3/14 14:27, Naoya Horiguchi wrote: > Hi, > > On Wed, Mar 13, 2019 at 12:03:20AM +0800, zhong jiang wrote: > ... >> Minchan has changed the conditon check from BUG_ON to WARN_ON_ONCE in >> try_to_unmap_one. >> However, It is still an abnormal condition when PageSwapBacked is not equal

vmscan: Reclaim unevictable pages

2019-03-14 Thread Pankaj Suryawanshi
Hello , shrink_page_list() returns , number of pages reclaimed, when pages is unevictable it returns VM_BUG_ON_PAGE(PageLRU(page) || PageUnevicatble(page),page); We can add the unevictable pages in reclaim list in shrink_page_list(), return total number of reclaim pages including

Re: [PATCH] mm: fix a wrong flag in set_migratetype_isolate()

2019-03-14 Thread Oscar Salvador
On Wed, Mar 13, 2019 at 05:25:07PM -0400, Qian Cai wrote: > Due to has_unmovable_pages() takes an incorrect irqsave flag instead of > the isolation flag in set_migratetype_isolate(), it causes issues with > HWPOSION and error reporting where dump_page() is not called when there > is an unmoveable

Re: [PATCH] mm/hotplug: fix notification in offline error path

2019-03-14 Thread Oscar Salvador
On Wed, Mar 13, 2019 at 05:09:39PM -0400, Qian Cai wrote: > Fixes: 7960509329c2 ("mm, memory_hotplug: print reason for the offlining > failure") > Signed-off-by: Qian Cai Reviewed-by: Oscar Salvador > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[PATCH v2] btrfs: raid56: properly unmap parity page in finish_parity_scrub()

2019-03-14 Thread Andrea Righi
Parity page is incorrectly unmapped in finish_parity_scrub(), triggering a reference counter bug on i386, i.e.: [ 157.662401] kernel BUG at mm/highmem.c:349! [ 157.666725] invalid opcode: [#1] SMP PTI The reason is that kunmap(p_page) was completely left out, so we never did an unmap for

[PATCH 0/2] add gpu node support on rock960 and rockpi4

2019-03-14 Thread Akash Gajjar
add gpu node support on both rockchip-rk3399 board. performance tested with freedesktop.org panfrost mali driver. Akash Gajjar (2): arm64: dts: rockchip: add mali gpu support on rockpi4 arm64: dts: rockchip: add mali gpu support on rock960 arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts |

Re: [PATCH] arch: arm: Kconfig: pedantic formatting

2019-03-14 Thread Krzysztof Hałasa
"Enrico Weigelt, metux IT consult" writes: > Formatting of Kconfig files doesn't look so pretty, so let the > Great White Handkerchief come around and clean it up. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- > arch/arm/mach-ixp4xx/Kconfig | 32 ++---

Re: [PATCH 1/2] cifs: remove unused status severity defines

2019-03-14 Thread Steve French
I am fine with taking a patch to get rid of __constant_cpu_to_XXX (and converting to the same cpu_to_XXX with the "__constant") in fs/cifs (assuming that that is still recommended). On Thu, Mar 14, 2019 at 2:39 AM Sergey Senozhatsky wrote: > > On (03/14/19 02:19), Steve French wrote: > > All

Re: [PATCH v2] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-14 Thread Michal Hocko
On Wed 13-03-19 10:31:33, Qian Cai wrote: > The commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded > memory to zones until online") introduced move_pfn_range_to_zone() which > calls memmap_init_zone() during onlining a memory block. > memmap_init_zone() will reset pagetype flags

Re: [PATCH v2] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-14 Thread Oscar Salvador
On Wed, Mar 13, 2019 at 10:31:33AM -0400, Qian Cai wrote: > Also, after calling the "useless" undo_isolate_page_range() here, it > reaches the point of no returning by notifying MEM_OFFLINE. Those pages > will be marked as MIGRATE_MOVABLE again once onlining. The only thing > left to do is to

Re: [PATCH v2] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-14 Thread Oscar Salvador
On Wed, Mar 13, 2019 at 10:31:33AM -0400, Qian Cai wrote: > The commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded > memory to zones until online") introduced move_pfn_range_to_zone() which > calls memmap_init_zone() during onlining a memory block. > memmap_init_zone() will reset

[PATCH 1/2] arm64: dts: rockchip: add mali gpu support on rockpi4

2019-03-14 Thread Akash Gajjar
add gpu node support on board and add the supplying regulator Signed-off-by: Akash Gajjar Signed-off-by: Andrius Štikonas --- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts

[GIT PULL] arch/microblaze patches for 5.1-rc1

2019-03-14 Thread Michal Simek
Hi, please pull the following patch to your tree. Thanks, Michal The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c: Linux 5.0-rc1 (2019-01-06 17:08:20 -0800) are available in the git repository at: git://git.monstr.eu/linux-2.6-microblaze.git

Re: [PATCH] spi: fix NULL pointer dereferences by checking dmaengine_prep_slave_sg

2019-03-14 Thread Krzysztof Kozlowski
On Thu, 14 Mar 2019 at 07:42, Kangjie Lu wrote: > > In case dmaengine_prep_slave_sg fails, the fix returns to avoid > NULL pointer dereference. > > Signed-off-by: Kangjie Lu Hi, Thanks for the patch, but the fix is the same as here:

Re: [PATCH v2] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-14 Thread Michal Hocko
On Thu 14-03-19 09:09:22, Oscar Salvador wrote: > On Wed, Mar 13, 2019 at 10:31:33AM -0400, Qian Cai wrote: > > Also, after calling the "useless" undo_isolate_page_range() here, it > > reaches the point of no returning by notifying MEM_OFFLINE. Those pages > > will be marked as MIGRATE_MOVABLE

Re: vmscan: Reclaim unevictable pages

2019-03-14 Thread Pankaj Suryawanshi
Below is the Error Msg : [ 24.718792] page dumped because: VM_BUG_ON_PAGE(PageLRU(page) || PageUnevictable(page)) [ 24.726949] page->mem_cgroup:bd008c00 [ 24.730693] [ cut here ] [ 24.735304] kernel BUG at mm/vmscan.c:1350! [ 24.739478] Internal error: Oops -

Re: [RESEND PATCH] mm/compaction: fix an undefined behaviour

2019-03-14 Thread Vlastimil Babka
On 3/13/19 7:06 PM, Qian Cai wrote: > In a low-memory situation, cc->fast_search_fail can keep increasing as > it is unable to find an available page to isolate in > fast_isolate_freepages(). As the result, it could trigger an error > below, so just compare with the maximum bits can be shifted

Re: [PATCH v3 2/9] mtd: rawnand: denali: refactor syndrome layout handling for raw access

2019-03-14 Thread Masahiro Yamada
Hi Miquel, On Tue, Mar 12, 2019 at 10:13 PM Miquel Raynal wrote: > > Hi Masahiro, > > Masahiro Yamada wrote on Tue, 12 Mar > 2019 20:07:27 +0900: > > > Hi Miquel, > > > > > > On Tue, Mar 12, 2019 at 7:54 PM Miquel Raynal > > wrote: > > > > > > Hi Masahiro, > > > > > > Masahiro Yamada wrote

Re: [PATCH] mm: compaction: show gfp flag names in try_to_compact_pages tracepoint

2019-03-14 Thread Vlastimil Babka
On 3/2/19 5:38 AM, Yafang Shao wrote: > show the gfp flag names instead of the gfp_mask could make the trace > more convenient. > > Signed-off-by: Yafang Shao Acked-by: Vlastimil Babka > --- > include/trace/events/compaction.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

[PATCH] staging: rtl8723bs: do not use __constant_cpu_to_le16

2019-03-14 Thread Sergey Senozhatsky
A trivial patch. cpu_to_le16() is capable enough to detect __builtin_constant_p() and to use an appropriate compile time ___constant_swahbXX() function. So we can use cpu_to_le16() instead of __constant_cpu_to_le16(). Signed-off-by: Sergey Senozhatsky ---

Re: [PATCH] tty: atmel_serial: fix a NULL pointer dereference

2019-03-14 Thread Richard Genoud
Hi, Good catch ! Le 14/03/2019 à 08:17, Kangjie Lu a écrit : > In case dmaengine_prep_dma_cyclic fails, the fix return a proper > error code to avoid NULL pointer dereference. > you could add: Fixes: 34df42f59a60 ("serial: at91: add rx dma support") So that -stable branches get this. >

Re: [PATCH v4] lib/string.c: implement a basic bcmp

2019-03-14 Thread Andy Shevchenko
On Wed, Mar 13, 2019 at 02:13:31PM -0700, Nick Desaulniers wrote: > A recent optimization in Clang (r355672) lowers comparisons of the > return value of memcmp against zero to comparisons of the return value > of bcmp against zero. This helps some platforms that implement bcmp > more efficiently

Re: fs/notify/fanotify/fanotify.c:198:2: note: in expansion of macro 'pr_warn_ratelimited'

2019-03-14 Thread Jan Kara
AFAICS this is the known problem with weird mips definitions of __kernel_fsid_t which uses long whereas all other architectures use int, right? Seeing that mips can actually have 8-byte longs, I guess this bogosity is just wired in the kernel API and we cannot easily fix it in mips (mips guys,

[PATCH] jffs2: do not use __constant_cpu_to_xx

2019-03-14 Thread Sergey Senozhatsky
A trivial patch. cpu_to_XX() functions are smart enough to detect and handle __builtin_constant_p() at compile time. So we can use cpu_to_XX() instead of __constant_cpu_to_XX(). Signed-off-by: Sergey Senozhatsky --- fs/jffs2/nodelist.h | 8 1 file changed, 4 insertions(+), 4

Re: [LKP] [x86, retpolines] ce02ef06fc: will-it-scale.per_thread_ops 3.1% improvement

2019-03-14 Thread Daniel Borkmann
On 03/13/2019 06:27 AM, kernel test robot wrote: > Greeting, > > FYI, we noticed a 3.1% improvement of will-it-scale.per_thread_ops due to > commit: > > > commit: ce02ef06fcf7a399a6276adb83f37373d10cbbe1 ("x86, retpolines: Raise > limit for generating indirect calls from switch-case") >

Re: vmscan: Reclaim unevictable pages

2019-03-14 Thread Michal Hocko
On Thu 14-03-19 08:23:10, Pankaj Suryawanshi wrote: > > Below is the Error Msg : > > [ 24.718792] page dumped because: VM_BUG_ON_PAGE(PageLRU(page) || > PageUnevictable(page)) > [ 24.726949] page->mem_cgroup:bd008c00 > [ 24.730693] [ cut here ] > [ 24.735304]

<    1   2   3   4   5   6   >