[PATCH V2 12/16] arm64: tegra: Add P2U and PCIe controller nodes to Tegra194 DT

2019-04-04 Thread Vidya Sagar
Add P2U (PIPE to UPHY) and PCIe controller nodes to device tree. The Tegra194 SoC contains six PCIe controllers and twenty P2U instances grouped into two different PHY bricks namely High-Speed IO (HSIO-12 P2Us) and NVIDIA High Speed (NVHS-8 P2Us) respectively. Signed-off-by: Vidya Sagar ---

[PATCH V2 13/16] arm64: tegra: Enable PCIe slots in P2972-0000 board

2019-04-04 Thread Vidya Sagar
Enable PCIe controller nodes to enable respective PCIe slots on P2972- board. Following is the ownership of slots by different PCIe controllers. Controller-0 : M.2 Key-M slot Controller-1 : On-board Marvell eSATA controller Controller-3 : M.2 Key-E slot Signed-off-by: Vidya Sagar --- Changes

[PATCH V2 14/16] phy: tegra: Add PCIe PIPE2UPHY support

2019-04-04 Thread Vidya Sagar
Synopsys DesignWare core based PCIe controllers in Tegra 194 SoC interface with Universal PHY (UPHY) module through a PIPE2UPHY (P2U) module. For each PCIe lane of a controller, there is a P2U unit instantiated at hardware level. This driver provides support for the programming required for each

[PATCH V2 10/16] dt-bindings: PCI: tegra: Add device tree support for T194

2019-04-04 Thread Vidya Sagar
Add support for Tegra194 PCIe controllers. These controllers are based on Synopsys DesignWare core IP. Signed-off-by: Vidya Sagar --- Changes since [v1]: * Added documentation for 'power-domains' property * Removed 'window1' and 'window2' properties * Removed '_clk' and '_rst' from clock and

[PATCH V2 11/16] dt-bindings: PHY: P2U: Add Tegra 194 P2U block

2019-04-04 Thread Vidya Sagar
Add support for Tegra194 P2U (PIPE to UPHY) module block which is a glue module instantiated one for each PCIe lane between Synopsys Designware core based PCIe IP and Universal PHY block. --- Changes since [v1]: * This is a new patch in v2 series .../devicetree/bindings/phy/phy-tegra194-p2u.txt

Re: [PATCH v2] Staging: rtlwifi: Remove unwanted parentheses

2019-04-04 Thread Madhumthia Prabakaran
On Thu, Apr 04, 2019 at 12:09:00PM +0300, Dan Carpenter wrote: > You should probably update the subject line because now it's not just > about parentheses any more. > > [PATCH v2] Staging: rtlwifi: clean up crc16_ccitt() > > So the one thing per patch rule is a little bit about selling your >

[PATCH V2 09/16] Documentation/devicetree: Add PCIe supports-clkreq property

2019-04-04 Thread Vidya Sagar
Some host controllers need to know the existence of clkreq signal routing to downstream devices to be able to advertise low power features like ASPM L1 substates. Without clkreq signal routing being present, enabling ASPM L1 sub states might lead to downstream devices falling off the bus. Hence a

[PATCH V2 08/16] PCI: dwc: Add support to enable CDM register check

2019-04-04 Thread Vidya Sagar
Add support to enable CDM (Configuration Dependent Module) register check for any data corruption based on the device-tree flag 'cdm-check'. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1554407755; bh=2r+BgN7djIZIxyR3cmeJ0J62WCNAe33ly16bcMnz9q8=;

[PATCH V2 07/16] dt-bindings: PCI: designware: Add binding for CDM register check

2019-04-04 Thread Vidya Sagar
Add support to enable CDM (Configuration Dependent Module) registers check for any data corruption. CDM registers include standard PCIe configuration space registers, Port Logic registers and iATU and DMA registers. Refer Section S.4 of Synopsys DesignWare Cores PCI Express Controller Databook

[PATCH V2 06/16] PCI: dwc: Add ext config space capability search API

2019-04-04 Thread Vidya Sagar
Add extended configuration space capability search API using struct dw_pcie * pointer Signed-off-by: Vidya Sagar --- Changes from [v1]: * This is a new patch in v2 series drivers/pci/controller/dwc/pcie-designware.c | 41

[PATCH V2 04/16] PCI: dwc: Perform dbi regs write lock towards the end

2019-04-04 Thread Vidya Sagar
Remove multiple write enable and disable sequences of dbi registers as Tegra194 implements writes to BAR-0 register (offset: 0x10) controlled by DBI write-lock enable bit thereby not allowing any further writes to BAR-0 register in config space to take place. Hence disabling write permission only

[PATCH V2 03/16] PCI: Export pcie_bus_config symbol

2019-04-04 Thread Vidya Sagar
Export pcie_bus_config to enable host controller drivers setting it to a specific configuration be able to build as loadable modules Signed-off-by: Vidya Sagar --- Changes since [v1]: * This is a new patch in v2 series drivers/pci/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH V2 05/16] PCI: dwc: Move config space capability search API

2019-04-04 Thread Vidya Sagar
move PCIe config space capability search API to common designware file as this can be used by both host and ep mode codes. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1554407724; bh=jQR9nFs/LVuU16O+4g9VUt8D0FYqHU7ch/l131xrbHM=;

[PATCH V2 01/16] PCI: Add #defines for PCIe spec r4.0 features

2019-04-04 Thread Vidya Sagar
Add #defines for the Data Link Feature and Physical Layer 16.0 GT/s features. Signed-off-by: Vidya Sagar --- Changes from [v1]: * None include/uapi/linux/pci_regs.h | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/pci_regs.h

[PATCH V2 02/16] PCI/PME: Export pcie_pme_disable_msi() API

2019-04-04 Thread Vidya Sagar
Export pcie_pme_disable_msi() API to enable drivers using this API be able to build as loadable modules Signed-off-by: Vidya Sagar --- Changes from [v1]: * This is a new patch in v2 series drivers/pci/pcie/pme.c | 6 ++ drivers/pci/pcie/portdrv.h | 5 + 2 files changed, 7

[PATCH V2 00/16] Add Tegra194 PCIe support

2019-04-04 Thread Vidya Sagar
Tegra194 has six PCIe controllers based on Synopsys DesignWare core. There are two Universal PHY (UPHY) blocks with each supporting 12(HSIO: Hisg Speed IO) and 8(NVHS: NVIDIA High Speed) lanes respectively. Controllers:0~4 use UPHY lanes from HSIO brick whereas Controller:5 uses UPHY lanes from

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-04 Thread Vidya Sagar
On 4/3/2019 11:06 PM, Bjorn Helgaas wrote: On Wed, Apr 03, 2019 at 03:13:09PM +0530, Vidya Sagar wrote: On 4/3/2019 12:01 AM, Bjorn Helgaas wrote: On Tue, Apr 02, 2019 at 12:47:48PM +0530, Vidya Sagar wrote: On 3/30/2019 2:22 AM, Bjorn Helgaas wrote: On Tue, Mar 26, 2019 at 08:43:26PM +0530,

Its Very Urgent!

2019-04-04 Thread Ms. Dalya
I have a proposal with a profit of Thirteen Million US Dollars, kindly contact me via Email for more details immediately.

Re: [PATCH v5 2/3] platform/chrome: Add Wilco EC keyboard backlight LEDs support

2019-04-04 Thread Pavel Machek
On Thu 2019-04-04 11:10:08, Nick Crews wrote: > The EC is in charge of controlling the keyboard backlight on > the Wilco platform. We expose a standard LED class device at > /sys/class/leds/platform::kbd_backlight. This driver is modeled > after the standard Chrome OS keyboard backlight driver at

[PATCH v3] Staging: rtlwifi: Cleanup crc16_ccitt()

2019-04-04 Thread Madhumitha Prabakaran
crc16_ccitt() function does "BIT(0) << i" instead of "BIT(i)". Using !! is slightly shorter than "foo ? 1: 0" and remove unnecessary parentheses to make the code simple. Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- Changes in v3: - Changed subject line and commit log

Re: [PATCH tip/core/rcu 2/2] rcu: Check for wakeup-safe conditions in rcu_read_unlock_special()

2019-04-04 Thread Paul E. McKenney
On Wed, Apr 03, 2019 at 09:25:50AM -0700, Paul E. McKenney wrote: > On Wed, Apr 03, 2019 at 11:50:46AM +0200, Peter Zijlstra wrote: > > On Tue, Apr 02, 2019 at 06:18:53AM -0700, Paul E. McKenney wrote: > > > On Tue, Apr 02, 2019 at 09:09:53AM +0200, Peter Zijlstra wrote: > > > > On Mon, Apr 01,

[PATCH 1/2] vt: selection: allow functions to be called from inside kernel

2019-04-04 Thread Okash Khawaja
This patch breaks set_selection() into two functions so that when called from kernel, copy_from_user() can be avoided. It also exports set_selection() and paste_selection(). These changes are used the following patch where speakup's selection functionality calls into the above functions, thereby

[PATCH 2/2] staging: speakup: refactor to use existing code in vt

2019-04-04 Thread Okash Khawaja
This patch replaces speakup's implementations with calls to functions in tty/vt/selection.c. Those functions are: cancel_selection() do_set_selection() paste_selection() Currently setting selection is done in interrupt context. However, do_set_selection() can sleep - for instance, it requires

[PATCH 0/2] staging: speakup: factor out selection code

2019-04-04 Thread Okash Khawaja
Hi, Speakup's selection functionality parallels that of drivers/tty/vt/selection.c. This patch set replaces speakup's implementation with calls to vt's selection code. This is one of the remaining items in our TODO file and it's needed for moving speakup out of staging. Please note that in

Re: [PATCH v3 18/36] thunderbolt: Add helper function to iterate from one port to another

2019-04-04 Thread Lukas Wunner
On Thu, Mar 28, 2019 at 03:36:15PM +0300, Mika Westerberg wrote: > We need to be able to walk from one port to another when we are creating > paths where there are multiple switches between two ports. For this > reason introduce a new function tb_next_port_on_path(). > > Signed-off-by: Mika

Re: [alsa-devel] [PATCH 1/3] soundwire: fix style issues

2019-04-04 Thread Pierre-Louis Bossart
Thanks for the review Joe, @@ -458,13 +458,13 @@ static int sdw_assign_device_num(struct sdw_slave *slave) mutex_unlock(>bus->bus_lock); if (dev_num < 0) { dev_err(slave->bus->dev, "Get dev_num failed: %d", -

[PATCH v13] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-04-04 Thread Liming Sun
This commit adds the TmFifo platform driver for Mellanox BlueField Soc. TmFifo is a shared FIFO which enables external host machine to exchange data with the SoC via USB or PCIe. The driver is based on virtio framework and has console and network access enabled. Reviewed-by: Vadim Pasternak

Re: [PATCH 3/5] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2019-04-04 Thread Dan Murphy
Jacek On 4/4/19 2:27 PM, Dan Murphy wrote: >>> >>> Actually I was thinking this property could move to common.txt >>> LM3697 would use it and it is also defined in leds-pwm.txt leds-netxbig.txt >> >> It was considered back in 2014 when I was working on LED flash >> class framework. It was

Re: [PATCH v2] acct: fix possible deadlock in acct_pin_kill

2019-04-04 Thread Amir Goldstein
On Thu, Apr 4, 2019 at 10:05 PM Al Viro wrote: > ... > OK, so... My first reaction had been complete BS. However, the > same goes for your analysis - it's not an ordering problem at all. > What happens is that we are replacing file->path.mnt with a clone > and we want the write count

Re: [PATCH 3/5] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2019-04-04 Thread Jacek Anaszewski
On 4/4/19 9:27 PM, Dan Murphy wrote: [...] Maybe I should rename this to ti,brightness-resolution with the same values. or ti,brightness-res for short hand. Or I could try to figure out the max-microamp but it really does not describe the hardware or the configuration.

Re: [PATCH 1/3] soundwire: fix style issues

2019-04-04 Thread Joe Perches
On Thu, 2019-04-04 at 13:22 -0500, Pierre-Louis Bossart wrote: > Visual inspections confirmed by checkpatch.pl --strict expose a number > of style issues, specifically parameter alignment is inconsistent as > if different contributors used different styles. Before we restart > support for

Re: [PATCH v3 17/36] thunderbolt: Assign remote for both ports in case of dual link

2019-04-04 Thread Lukas Wunner
On Thu, Mar 28, 2019 at 03:36:14PM +0300, Mika Westerberg wrote: > +/** > + * tb_port_has_remote() - Does the port have switch connected downstream > + * @port: Port to check > + * > + * Returns true only when the port is primary port and that it has > + * remote set. > + */ Just a nit: s/that

Re: [PATCH 3/5] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2019-04-04 Thread Dan Murphy
On 4/4/19 1:39 PM, Jacek Anaszewski wrote: > Dan, > > On 4/3/19 10:23 PM, Dan Murphy wrote: >> Jacek >> >> On 4/3/19 3:10 PM, Jacek Anaszewski wrote: >>> Hi Dan, >>> >>> Thank you for the patch. >>> >>> You need Lee Jones on CC for this series. >>> >> >> Yes I saw I missed Lee. >> >>> One more

Re: [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support

2019-04-04 Thread Pavel Machek
; suitable for that. "platform" is. > > > > > > Pavel, who exactly wants this and why? Looking at today's -next I see: > > > > > > dtor@dtor-ws:~/kernel/linux-next ((next-20190404))$ git grep > > > "::kbd_backlight" | wc -l > > >

Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver

2019-04-04 Thread Dan Murphy
Tony On 4/4/19 1:48 PM, Jacek Anaszewski wrote: > Hi Tony, > > Thanks for the feedback. > > On 4/4/19 2:09 AM, Tony Lindgren wrote: >> * Dan Murphy [190321 14:29]: >>> Introduce the Texas Instruments LM3532 White LED driver. >>> The driver supports ALS configurability or manual brightness >>>

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Pavel Machek
On Thu 2019-04-04 12:05:39, Dmitry Torokhov wrote: > On Thu, Apr 4, 2019 at 11:59 AM Pavel Machek wrote: > > > > On Thu 2019-04-04 11:55:27, Dmitry Torokhov wrote: > > > On Thu, Apr 4, 2019 at 11:41 AM Nick Crews wrote: > > > > > > > > On Thu, Apr 4, 2019 at 11:43 AM Dmitry Torokhov wrote: > >

Re: [PATCH v3 00/25] Add generic support for composing LED class device name

2019-04-04 Thread Jacek Anaszewski
Hi Pavel, On 4/4/19 3:21 PM, Pavel Machek wrote: Hi! I have not yet gone through the series in great detail. This will change the userland ABI, right? Now, I understand that old ABI is bad, but will it break someone's code? It will not break anyone since the generic support for composing

Re: [PATCH v2] acct: fix possible deadlock in acct_pin_kill

2019-04-04 Thread Al Viro
On Thu, Apr 04, 2019 at 01:52:55PM +0300, Amir Goldstein wrote: > If new file is on the same fs as old file, acct_pin_kill(old) fail to > file_start_write_trylock() and skip writing the old file, because > sb_writers (of new) is already taken by acct_on(). The above is BS, BTW.

Re: [PATCH 1/2] fsl_hypervisor: dereferencing error pointers in ioctl

2019-04-04 Thread Dan Carpenter
On Thu, Apr 04, 2019 at 12:10:44PM -0700, Andrew Morton wrote: > On Tue, 18 Dec 2018 11:20:03 +0300 Dan Carpenter > wrote: > > > The strndup_user() function returns error pointers on error, and then > > in the error handling we pass the error pointers to kfree(). It will > > cause an Oops. > >

Re: [PATCH 1/2] fsl_hypervisor: dereferencing error pointers in ioctl

2019-04-04 Thread Andrew Morton
On Tue, 18 Dec 2018 11:20:03 +0300 Dan Carpenter wrote: > The strndup_user() function returns error pointers on error, and then > in the error handling we pass the error pointers to kfree(). It will > cause an Oops. > Looks good to me. I guess we should fix this too? From: Andrew Morton

Re: [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support

2019-04-04 Thread Dmitry Torokhov
g > > > > are you saying "platform" would be consistent with? > > > > > > Yeah, well, we not let the cros_kbd_led_backlight.c use chromeos:: in > > > the first place. But it happened. We want all backlights for the > > > system keyboard to u

Re: [PATCH] Convert struct pid count to refcount_t

2019-04-04 Thread Alan Stern
On Thu, 4 Apr 2019, Joel Fernandes wrote: > FWIW, thought to mention (feel free ignore the suggestion if its > meaningless): If there is any chance that the outcome can be better > outputted, like r1=X; x=1; Where X stands for the result of a data race, that > would be lovely. I don't know much

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Dmitry Torokhov
On Thu, Apr 4, 2019 at 11:59 AM Pavel Machek wrote: > > On Thu 2019-04-04 11:55:27, Dmitry Torokhov wrote: > > On Thu, Apr 4, 2019 at 11:41 AM Nick Crews wrote: > > > > > > On Thu, Apr 4, 2019 at 11:43 AM Dmitry Torokhov wrote: > > > > > > > > On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck

Re: [PATCH v2] acct: fix possible deadlock in acct_pin_kill

2019-04-04 Thread Al Viro
On Thu, Apr 04, 2019 at 07:49:44PM +0100, Al Viro wrote: > On Thu, Apr 04, 2019 at 07:44:48PM +0100, Al Viro wrote: > > > Huh? sb_writers is taken when we *open* the new file. Then we replace > > its ->path.mnt with a clone and transfer the write count from the original > > to new one. And

Linux 3.16.65

2019-04-04 Thread Ben Hutchings
I'm announcing the release of the 3.16.65 kernel. All users of the 3.16 kernel series should upgrade. The updated 3.16.y git tree can be found at: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-3.16.y and can be browsed at the normal kernel.org git web

Re: [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support

2019-04-04 Thread Pavel Machek
gt; > > substitute for "chromeos" than "platform" would be. What other thing > > > are you saying "platform" would be consistent with? > > > > Yeah, well, we not let the cros_kbd_led_backlight.c use chromeos:: in > > the first place. Bu

Re: perf: perf_fuzzer crashes on Pentium 4 systems

2019-04-04 Thread Vince Weaver
On Thu, 4 Apr 2019, Cyrill Gorcunov wrote: > On Thu, Apr 04, 2019 at 12:37:18PM -0400, Vince Weaver wrote: > > Oh, Vince, I suspect such kind of bisection might consume a lot of your > time :( Maybe we could update perf fuzzer so that it would send events > to some net-storage first then write

[PATCH 3/3] habanalabs: split mmu/no-mmu code paths in memory ioctl

2019-04-04 Thread Oded Gabbay
To make the memory ioctl code more readable, this patch moves the legacy/debug code path of mmu-disabled to a separate function, which is called (if necessary) from the main memory ioctl function. Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/memory.c | 177

[PATCH 1/3] habanalabs: refactoring in goya.c

2019-04-04 Thread Oded Gabbay
This patch does some refactoring in goya.c to make code more reusable between goya code and the goya simulator code (which is not upstreamed). In addition, the patch removes some dead functions from goya.c which are not used by the current upstream code Signed-off-by: Oded Gabbay ---

[PATCH 2/3] habanalabs: ASIC_AUTO_DETECT enum value is redundant

2019-04-04 Thread Oded Gabbay
This patch removes the enum value of ASIC_AUTO_DETECT because we can use the validity of the pdev variable to know whether we have a real device or a simulator. For a real device, we detect the asic type from the device ID while for a simulator, the simulator code calls create_hdev() with the

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Pavel Machek
On Thu 2019-04-04 11:55:27, Dmitry Torokhov wrote: > On Thu, Apr 4, 2019 at 11:41 AM Nick Crews wrote: > > > > On Thu, Apr 4, 2019 at 11:43 AM Dmitry Torokhov wrote: > > > > > > On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck wrote: > > > > > > > > On Thu, Apr 4, 2019 at 10:11 AM Nick Crews

Re: [PATCH v3 3/4] lib: logic_pio: Reject accesses to unregistered CPU MMIO regions

2019-04-04 Thread Bjorn Helgaas
On Thu, Apr 04, 2019 at 10:43:36AM -0700, Guenter Roeck wrote: > On Thu, Apr 04, 2019 at 05:52:35PM +0100, John Garry wrote: > > >>Note that the f71805f driver does not call > > >>request_{muxed_}region(), as it should. > > > > >... which is the real problem, one that is not solved by this > >

Re: [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses

2019-04-04 Thread Lawrence Brakmo
On 4/4/19, 11:39 AM, "Tilmans, Olivier (Nokia - BE/Antwerp)" wrote: > DCTCP is meant to be used in environments where the switches/routers do > ECN marking, so it is not surprising that it performs badly when used in > environments where it was not meant to be used. Has anyone

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Pavel Machek
Hi! > You're right, I should have been more precise. > I was referring to Pavel, Enric, and myself. Pavel had this opinion here: > https://lkml.org/lkml/2019/4/4/1040. I don't know what Pavel meant by "we" > in that comment, but I would guess that could mean the other LED maintainers > as well? I

Re: [PATCH v9 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-04-04 Thread Sergei Shtylyov
Hello! On 04/03/2019 12:20 PM, masonccy...@mxic.com.tw wrote: >> >> > +static void rpc_spi_mem_set_prep_op_cfg(struct spi_device *spi, >> >> > + const struct spi_mem_op *op, >> >> > + u64 *offs, size_t *len) >> >> > +{ >> >> > + struct rpc_spi *rpc =

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Dmitry Torokhov
On Thu, Apr 4, 2019 at 11:41 AM Nick Crews wrote: > > On Thu, Apr 4, 2019 at 11:43 AM Dmitry Torokhov wrote: > > > > On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck wrote: > > > > > > On Thu, Apr 4, 2019 at 10:11 AM Nick Crews wrote: > > > > > > > > We want all backlights for the system keyboard

Re: [PATCH 6/6 v3] syscalls: Remove start and number from syscall_set_arguments() args

2019-04-04 Thread Max Filippov
On Mon, Apr 1, 2019 at 6:45 AM Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > After removing the start and count arguments of syscall_get_arguments() it > seems reasonable to remove them from syscall_set_arguments(). Note, as of > today, there are no users of

[PATCH] MT7621-SPI: spi-mt7621: Fix alignment and style problems Fixed Coding function and style issues

2019-04-04 Thread Nilesh Hase
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Nilesh Hase --- drivers/staging/mt7621-spi/spi-mt7621.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-spi/spi-mt7621.c b/drivers/staging/mt7621-spi/spi-mt7621.c

Re: [PATCH v2] acct: fix possible deadlock in acct_pin_kill

2019-04-04 Thread Al Viro
On Thu, Apr 04, 2019 at 07:44:48PM +0100, Al Viro wrote: > Huh? sb_writers is taken when we *open* the new file. Then we replace > its ->path.mnt with a clone and transfer the write count from the original > to new one. And close the old file while we are at it. > > >From sb_writers POV

Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver

2019-04-04 Thread Jacek Anaszewski
Hi Tony, Thanks for the feedback. On 4/4/19 2:09 AM, Tony Lindgren wrote: * Dan Murphy [190321 14:29]: Introduce the Texas Instruments LM3532 White LED driver. The driver supports ALS configurability or manual brightness control. The driver also supports associating LED strings with

Re: [PATCH v2] acct: fix possible deadlock in acct_pin_kill

2019-04-04 Thread Al Viro
On Thu, Apr 04, 2019 at 01:52:55PM +0300, Amir Goldstein wrote: > This looks like an old bug, pre-dating the "Fixes" commit, but the > "Fixes" commit did not handle it properly. > > The bug recently surfaced as a lockdep possible deadlock warning > with commit d1d04ef8572b ("ovl: stack file

[PATCH v2] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled

2019-04-04 Thread Miroslav Benes
GCC 9 introduces a new option, -flive-patching. It disables certain optimizations which could make a compilation unsafe for later live patching of the running kernel. The option is used only if CONFIG_LIVEPATCH is enabled and $(CC) supports it. Performance impact of the option was measured on

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Nick Crews
On Thu, Apr 4, 2019 at 11:43 AM Dmitry Torokhov wrote: > > On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck wrote: > > > > On Thu, Apr 4, 2019 at 10:11 AM Nick Crews wrote: > > > > > > We want all backlights for the system keyboard to > > > use a common name, so the name "platform::kbd_backlight"

Re: [PATCH v3 1/2] mfd: cros_ec: Add host_sleep_event_v1 command

2019-04-04 Thread Rajat Jain
On Wed, Apr 3, 2019 at 2:34 PM Evan Green wrote: > > Introduce the command and response structures for the second revision > of the host sleep event. These structures are part of a new EC change > that enables detection of failure to enter S0ix. The EC waits a > kernel-specified timeout (or a

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

2019-04-04 Thread Keerthy
On 04/04/19 7:47 PM, Tony Lindgren wrote: * Ladislav Michl [190327 08:12]: Hello Nathan, On Tue, Mar 26, 2019 at 10:01:27PM -0700, Nathan Chancellor wrote: Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start

RE: [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses

2019-04-04 Thread Tilmans, Olivier (Nokia - BE/Antwerp)
> DCTCP is meant to be used in environments where the switches/routers do > ECN marking, so it is not surprising that it performs badly when used in > environments where it was not meant to be used. Has anyone measured the > effect of this changed when DCTCP is used in environments where all the >

Re: [PATCH 3/5] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2019-04-04 Thread Jacek Anaszewski
Dan, On 4/3/19 10:23 PM, Dan Murphy wrote: Jacek On 4/3/19 3:10 PM, Jacek Anaszewski wrote: Hi Dan, Thank you for the patch. You need Lee Jones on CC for this series. Yes I saw I missed Lee. One more comment below. On 3/25/19 3:24 PM, Dan Murphy wrote: The LM3697 is a single function

Re: [PATCH v3 2/2] platform/chrome: Add support for v1 of host sleep event

2019-04-04 Thread Rajat Jain
On Wed, Apr 3, 2019 at 2:34 PM Evan Green wrote: > > Add support in code for the new forms of the host sleep event. > Detects the presence of this version of the command at runtime, > and use whichever form the EC supports. At this time, always > request the default timeout, and only report the

[PATCH 3/3] perf/x86/intel: force resched when TFA sysctl is modified

2019-04-04 Thread Stephane Eranian
This patch provides guarantee to the sysadmin that when TFA is disabled, no PMU event is using PMC3 when the echo command returns. Vice-Versa, when TFA is enabled, PMU can use PMC3 immediately (to eliminate possible multiplexing). $ perf stat -a -I 1000 --no-merge -e

[PATCH 2/3] perf/core: make ctx_resched() a global function

2019-04-04 Thread Stephane Eranian
This patch renames ctx_resched() to perf_ctx_resched() and makes the function globally accessible. This is to prepare for the next patch which needs to call this function from arch specific code. Signed-off-by: Stephane Eranian --- include/linux/perf_event.h | 12

[PATCH 0/3] perf/x86/intel: force reschedule on TFA changes

2019-04-04 Thread Stephane Eranian
This short patch series improves the TFA patch series by adding a guarantee to users each time the allow_force_tsx_abort (TFA) sysctl control knob is modified. The current TFA support in perf_events operates as follow: - TFA=1 The PMU has priority over TSX, if PMC3 is needed, then TSX

[PATCH 1/3] perf/core: make perf_ctx_*lock() global inline functions

2019-04-04 Thread Stephane Eranian
This patch makes the perf_ctx_lock()/perf_ctx_unlock() inlined functions available throughout the perf_events code and not just in kernel/events/core.c This will help with the next patch. Signed-off-by: Stephane Eranian --- include/linux/perf_event.h | 16 kernel/events/core.c

Re: [PATCH] cgroup: remove extra cgroup_migrate_finish() call

2019-04-04 Thread Daniel Jordan
On Wed, Apr 03, 2019 at 04:03:54PM -0700, Shakeel Butt wrote: > The callers of cgroup_migrate_prepare_dst() correctly call > cgroup_migrate_finish() for success and failure cases both. No need to > call it in cgroup_migrate_prepare_dst() in failure case. Calling cgroup_migrate_finish multiple

Re: [PATCH v2] MIPS: generic: Add switchdev, pinctrl and fit to ocelot_defconfig

2019-04-04 Thread Paul Burton
Hello, Horatiu Vultur wrote: > Some of the configuration were not selected by default anymore, therefore > enable them again. Also remove some configs which are used for MSCC Ocelot. > > Signed-off-by: Horatiu Vultur Applied to mips-fixes. Thanks, Paul [ This message was auto-generated;

Re: [PATCH v2] MIPS: ralink: fix cpu clock of mt7621 and add dt clk devices

2019-04-04 Thread Paul Burton
Hello, Chuanhong Guo wrote: > For a long time the mt7621 uses a fixed cpu clock which causes a problem > if the cpu frequency is not 880MHz. > > This patch fixes the cpu clock calculation and adds the cpu/bus clkdev > which will be used in dts. > > Signed-off-by: Weijie Gao > > Ported from

Re: [PATCH 2/2] mm, memory_hotplug: provide a more generic restrictions for memory hotplug

2019-04-04 Thread David Hildenbrand
On 04.04.19 20:01, Oscar Salvador wrote: > On Thu, Apr 04, 2019 at 04:57:03PM +0200, David Hildenbrand wrote: > >>> #ifdef CONFIG_MEMORY_HOTPLUG >>> -int arch_add_memory(int nid, u64 start, u64 size, struct vmem_altmap >>> *altmap, >>> - bool want_memblock) >>> +int

[PATCH 1/3] soundwire: fix style issues

2019-04-04 Thread Pierre-Louis Bossart
Visual inspections confirmed by checkpatch.pl --strict expose a number of style issues, specifically parameter alignment is inconsistent as if different contributors used different styles. Before we restart support for SoundWire with Sound Open Firmware on Intel platforms, let's clean all this.

[PATCH 2/3] soundwire: bus: remove useless initializations

2019-04-04 Thread Pierre-Louis Bossart
No need for explicit initialization of page and ssp fields, they are already zeroed with a memset. Detected with cppcheck: [drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is reassigned a value before the old one has been used. Signed-off-by: Pierre-Louis Bossart ---

[PATCH 3/3] soundwire: stream: remove useless initialization of local variable

2019-04-04 Thread Pierre-Louis Bossart
no need to reset return value. Detected with cppcheck: [drivers/soundwire/stream.c:332]: (style) Variable 'ret' is assigned a value that is never used. Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/3] soundwire: code cleanup

2019-04-04 Thread Pierre-Louis Bossart
SoundWire support will be provided in Linux with the Sound Open Firmware (SOF) on Intel platforms. Before we start adding the missing pieces, there are a number of warnings and style issues reported by checkpatch, cppcheck and Coccinelle that need to be cleaned-up. While I am at it, I could use

RE: [PATCH] soc: fsl: add DPAA2 console support

2019-04-04 Thread Leo Li
> -Original Message- > From: Ioana Ciornei > Sent: Thursday, April 4, 2019 5:48 AM > To: Leo Li > Cc: linux-kernel@vger.kernel.org; Roy Pledge > Subject: Re: [PATCH] soc: fsl: add DPAA2 console support > > On 4/3/19 10:55 PM, Li Yang wrote: > > On Tue, Mar 26, 2019 at 2:17 PM Ioana

Re: [PATCH] Convert struct pid count to refcount_t

2019-04-04 Thread Paul E. McKenney
On Thu, Apr 04, 2019 at 02:08:42PM -0400, Joel Fernandes wrote: > Thanks a lot Paul and Allen, I replied below. > > On Thu, Apr 04, 2019 at 12:01:32PM -0400, Alan Stern wrote: > > On Thu, 4 Apr 2019, Paul E. McKenney wrote: > > > > > On Mon, Apr 01, 2019 at 05:11:39PM -0400, Joel Fernandes

Re: [PATCH v1] ARM: dts: aspeed: Add lenovo hr630 BMC machine

2019-04-04 Thread Benjamin Fair
On Thu, Apr 4, 2019 at 1:05 AM Andrew MS1 Peng wrote: > > The Hr630 platform use ASPEED ast2500 based BMC, add the device tree for this > initial commit. Hi Andrew, Thanks for sending this patch! Unfortunately, this format makes it difficult to review, so please resend it in plaintext rather

Re: [PATCH] Convert struct pid count to refcount_t

2019-04-04 Thread Joel Fernandes
Thanks a lot Paul and Allen, I replied below. On Thu, Apr 04, 2019 at 12:01:32PM -0400, Alan Stern wrote: > On Thu, 4 Apr 2019, Paul E. McKenney wrote: > > > On Mon, Apr 01, 2019 at 05:11:39PM -0400, Joel Fernandes wrote: > > > > > > So I would have expected the following litmus to result in

Re: [PATCH v2] Add i2c recovery handling for bcm-iproc based devices.

2019-04-04 Thread Ray Jui
On 3/25/2019 1:59 PM, Richard Laing wrote: > It is possible for the i2c bus to become locked up preventing > communication with devices on the bus. This can occur when > another i2c device fails to be reset correctly. In this case > the SDA line will be held low preventing further communication

Re: [PATCH 1/4] drivers: base: regmap: add proper SPDX identifiers on files that did not have them.

2019-04-04 Thread Greg Kroah-Hartman
On Wed, Apr 03, 2019 at 10:32:27AM +0700, Mark Brown wrote: > On Tue, Apr 02, 2019 at 03:32:00PM +0200, Greg Kroah-Hartman wrote: > > > --- a/drivers/base/regmap/regcache-flat.c > > +++ b/drivers/base/regmap/regcache-flat.c > > @@ -1,13 +1,10 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > /* >

Re: [PATCH v2 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock

2019-04-04 Thread Waiman Long
On 04/04/2019 05:38 AM, Peter Zijlstra wrote: > On Thu, Apr 04, 2019 at 07:05:24AM +0200, Juergen Gross wrote: > >> Without PARAVIRT_SPINLOCK this would be just an alternative() then? > That could maybe work yes. This is all early enough. Yes, alternative() should work as it is done before SMP

Re: [PATCH] sched/core: expand sched_getaffinity(2) to return number of CPUs

2019-04-04 Thread Alexey Dobriyan
On Thu, Apr 04, 2019 at 10:42:49AM +0200, Peter Zijlstra wrote: > On Wed, Apr 03, 2019 at 11:08:09PM +0300, Alexey Dobriyan wrote: > > Currently there is no easy way to get the number of CPUs on the system. > > And this patch doesn't change that :-) It does! Application or a library could do one

Re: [PATCH 2/2] mm, memory_hotplug: provide a more generic restrictions for memory hotplug

2019-04-04 Thread Oscar Salvador
On Thu, Apr 04, 2019 at 04:57:03PM +0200, David Hildenbrand wrote: > > #ifdef CONFIG_MEMORY_HOTPLUG > > -int arch_add_memory(int nid, u64 start, u64 size, struct vmem_altmap > > *altmap, > > - bool want_memblock) > > +int arch_add_memory(int nid, u64 start, u64 size, > > +

[PATCH] [PATCH] staging: vt6655: upc: remove double blank lines

2019-04-04 Thread Cesar Santos
Fix checkpatch warning "CHECK: Please don't use multiple blank lines" on upc.h Signed-off-by: Cesar Santos --- drivers/staging/vt6655/upc.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h index d028ad2ba0d4..e086ec6e77f7 100644

Re: [PATCH net] net: vrf: Fix ping failed when vrf mtu is set to 0

2019-04-04 Thread David Miller
From: linmiaohe Date: Thu, 4 Apr 2019 20:01:13 +0800 > When the mtu of a vrf device is set to 0, it would cause ping > failed.So I think we should limit dev->min_mtu to ETH_MIN_MTU > to solve this problem. And if dev->max_mtu still be 0 can be > confusing, so I limit dev->max_mtu to ETH_MAX_MTU.

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-04 Thread Ray Jui
Hi Lorenzo, On 4/3/2019 4:31 AM, Lorenzo Pieralisi wrote: > On Wed, Apr 03, 2019 at 08:41:44AM +0530, Srinath Mannam wrote: >> Hi Lorenzo, >> >> Please see my reply below, >> >> On Tue, Apr 2, 2019 at 7:08 PM Lorenzo Pieralisi >> wrote: >>> >>> On Tue, Apr 02, 2019 at 04:16:13PM +0530, Srinath

[PATCH-tip v4 09/11] locking/lock_events: Don't show pvqspinlock events on bare metal

2019-04-04 Thread Waiman Long
On bare metail, the pvqspinlock event counts will always be 0. So there is no point in showing their corresponding debugfs files. So they are skipped in this case. Signed-off-by: Waiman Long Acked-by: Davidlohr Bueso --- kernel/locking/lock_events.c | 28 +++- 1 file

[PATCH-tip v4 08/11] locking/lock_events: Make lock_events available for all archs & other locks

2019-04-04 Thread Waiman Long
The QUEUED_LOCK_STAT option to report queued spinlocks event counts was previously allowed only on x86 architecture. To make the locking event counting code more useful, it is now renamed to a more generic LOCK_EVENT_COUNTS config option. This new option will be available to all the architectures

[PATCH-tip v4 00/11] locking/rwsem: Rwsem rearchitecture part 1

2019-04-04 Thread Waiman Long
v4: - Update the DEBUG_RWSEMS_WARN_ON() macro in patch 6 to call debug_locks_off(). - Update commit log of patch 11 to include benchmark data. v3: - Add patch 11 to move count and owner together as suggested by Linus. - Reword the commit log of patch 2 to clarify the intent of that

Re: [PATCH v3 3/4] lib: logic_pio: Reject accesses to unregistered CPU MMIO regions

2019-04-04 Thread Guenter Roeck
On Thu, Apr 04, 2019 at 05:52:35PM +0100, John Garry wrote: [ ... ] > >> > >>Note that the f71805f driver does not call request_{muxed_}region(), as it > >>should. > >> > > Hi Guenter, > > >... which is the real problem, one that is not solved by this patch. This may > >result in parallel and

[PATCH-tip v4 02/11] locking/rwsem: Move owner setting code from rwsem.c to rwsem.h

2019-04-04 Thread Waiman Long
Moves all the owner setting code closer to the rwsem-xadd fast paths directly within rwsem.h file as well as in the slowpaths where owner setting is done after acquring the lock. This will enable us to add DEBUG_RWSEMS check in a later patch to make sure that read lock is really acquired when

[PATCH-tip v4 07/11] locking/qspinlock_stat: Introduce a generic lockevent counting APIs

2019-04-04 Thread Waiman Long
The percpu event counts used by qspinlock code can be useful for other locking code as well. So a new set of lockevent_* counting APIs is introduced with the lock event names extracted out into the new lock_events_list.h header file for easier addition in the future. The existing qstat_inc()

[PATCH-tip v4 05/11] locking/rwsem: Add debug check for __down_read*()

2019-04-04 Thread Waiman Long
When rwsem_down_read_failed*() return, the read lock is acquired indirectly by others. So debug checks are added in __down_read() and __down_read_killable() to make sure the rwsem is really reader-owned. The other debug check calls in kernel/locking/rwsem.c except the one in up_read_non_owner()

[PATCH-tip v4 11/11] locking/rwsem: Optimize rwsem structure for uncontended lock acquisition

2019-04-04 Thread Waiman Long
For an uncontended rwsem, count and owner are the only fields a task needs to touch when acquiring the rwsem. So they are put next to each other to increase the chance that they will share the same cacheline. On a ThunderX2 99xx (arm64) system with 32K L1 cache and 256K L2 cache, a rwsem locking

<    1   2   3   4   5   6   7   8   9   10   >