Re: [PATCH v2 0/6] hwspinlock: allow sharing of hwspinlocks

Hi I Got Rob's Reviewed-by. Any further comments? Fabien On 25/04/2019 11:17 AM, Fabien Dessenne wrote: > The current implementation does not allow two different devices to use > a common hwspinlock. This patch set proposes to have, as an option, some > hwspinlocks shared between several

Re: [PATCH v3 02/16] iommu: Introduce cache_invalidate API

Hi Jacob, Jean-Philippe, On 5/4/19 12:32 AM, Jacob Pan wrote: > From: "Liu, Yi L" > > In any virtualization use case, when the first translation stage > is "owned" by the guest OS, the host IOMMU driver has no knowledge > of caching structure updates unless the guest invalidation activities >

[PATCH v2] ALSA: hda: Fix race between creating and refreshing sysfs entries

hda_widget_sysfs_reinit() can free underlying codec->widgets structure on which widget_tree_create() operates. Add locking to prevent such issues from happening. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110382 Signed-off-by: Amadeusz Sławiński --- Changes since v1: - Moved

[PATCH 17/17] locking/lockdep: Remove irq-safe to irq-unsafe read check

We have a lockdep warning: WARNING: possible irq lock inversion dependency detected 5.1.0-rc7+ #141 Not tainted kworker/8:2/328 just changed the state of lock:

[PATCH 16/17] locking/lockdep: Add more lockdep selftest cases

Lets make sure our 8 cases can be correctly handled. In contrast, before this patchset, these 8 cases have 24 failures: | spin |wlock |rlock |mutex | wsem | rsem |

[PATCH 14/17] locking/lockdep: Support recursive read locks

Now we are good to finally support recursive read locks. This is done simply by adding the dependency that has recursive locks to the graph, which previously is skipped. The reason is plainly simple: (a). Recursive read lock differs from read lock only inside a task. (b).

[PATCH 12/17] locking/lockdep: Remove useless lock type assignment

Next lock to acquire has the lock type set already. There is no need to reassign it when it is recursive read. No functional change. Signed-off-by: Yuyang Du --- kernel/locking/lockdep.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/kernel/locking/lockdep.c

[PATCH 13/17] locking/lockdep: Add nest lock type

Add a macro LOCK_TYPE_NEST for nest lock type and mark the nested lock in check_deadlock_current(). Unlike the other LOCK_TYPE_* enums, this lock type is used only in lockdep. No functional change. Signed-off-by: Yuyang Du --- kernel/locking/lockdep.c | 7 +--

[PATCH 15/17] locking/lockdep: Adjust selftest case for recursive read lock

Now that we support recursive read locks, a previously failed case: | spin |wlock |rlock |mutex | wsem | rsem |

[PATCH 02/17] locking/lockdep: Add read-write type for dependency

Direct dependency needs to keep track of its locks' read-write types. A union field is added to lock_list struct so the type is stored there as this: lock_type[1] (u16), lock_type[0] (u16) or: dep_type (int) where value: 0: exclusive / write 1: read

Re: [PATCH] vsprintf: Do not break early boot with probing addresses

On Mon, May 13, 2019 at 08:52:41AM +, David Laight wrote: > From: christophe leroy > > Sent: 10 May 2019 18:35 > > Le 10/05/2019 à 18:24, Steven Rostedt a écrit : > > > On Fri, 10 May 2019 10:42:13 +0200 > > > Petr Mladek wrote: > > >> -if (probe_kernel_address(ptr, byte)) > > >> +

Re: [PATCH v2 0/3] initramfs: add support for xattrs in the initial ram disk

On 5/13/19 2:49 AM, Roberto Sassu wrote: > On 5/12/2019 9:43 PM, Arvind Sankar wrote: >> On Sun, May 12, 2019 at 05:05:48PM +, Rob Landley wrote: >>> On 5/12/19 7:52 AM, Mimi Zohar wrote: On Sun, 2019-05-12 at 11:17 +0200, Dominik Brodowski wrote: > On Thu, May 09, 2019 at

Re: [PATCH v2] hwspinlock: ignore disabled device

Hi Gentle reminder Fabien On 08/03/2019 5:53 PM, Fabien Dessenne wrote: > Do not wait for hwspinlock device registration if it is not available > for use. > > Signed-off-by: Fabien Dessenne > --- > V2: use 'goto out' instead of 'return' > > drivers/hwspinlock/hwspinlock_core.c | 5 + >

[PATCH 10/17] locking/lockdep: Support read-write lock's deadlock detection

A read-write lock is different from an exclusive lock only in that there can be concurrent read locks, while a write lock is essentially the same as an exclusive lock. Read-write lock has not been well supported for deadlock detection so far. This patch series designs and implements an algorithm

[PATCH 09/17] locking/lockdep: Hash held lock's read-write type into chain key

When computing a chain's hash key, we need to consider a held lock's type, so the additional data to use Jenkins hash algorithm is a composite of the new held lock's lock class index (lower 16 bits) and its read-write type (higher 16 bits) as opposed to just class index before: held lock

[PATCH 06/17] locking/lockdep: Adjust BFS algorithm to support multiple matches

With read locks, circle is not sufficient condition for a deadlock. As a result, we need to continue the search after a match but the match is not wanted. __bfs() is adjusted to that end. The basic idea is to enqueue a node's children before matching the node. No functional change.

[PATCH 00/17] Support for read-write lock deadlock detection

Hi Peter and Ingo, Historically, the read-write locks (recursive-read locks included) are not well supported in lockdep. This patchset attempts to solve this problem sound and complete. The bulk of the algorithm is in patch #10, which is actually not complex at all. Hopefully, it simply works.

[PATCH 07/17] locking/lockdep: Introduce mark_lock_unaccessed()

Since in graph search, multiple matches may be needed, a matched lock needs to rejoin the search for another match, thereby introduce mark_lock_unaccessed(). Signed-off-by: Yuyang Du --- kernel/locking/lockdep.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH 05/17] locking/lockdep: Rename deadlock check functions

Deadlock checks are performed at two places: - Within current's held lock stack, check for lock recursion deadlock. - Within dependency graph, check for lock inversion deadlock. Rename the two relevant functions for later use. Plus, with read locks, dependency circle in graph is not a

[PATCH 04/17] locking/lockdep: Update direct dependency's read-write type if it exists

When adding a dependency, if the dependency exists - be it direct or indirect - the dependency's read-write type may be updated. We can keep all different-typed dependencies, but for simplicity we just "upgrade" lock types if possible, making them more exlusive (in the order: recursive read ->

[PATCH 01/17] locking/lockdep: Add lock type enum to explicitly specify read or write locks

Add an enum to formalize lock types, as those type values now matter. No functional change. Signed-off-by: Yuyang Du --- include/linux/lockdep.h | 28 ++-- kernel/locking/lockdep.c | 23 +-- 2 files changed, 35 insertions(+), 16 deletions(-) diff

[PATCH 08/17] locking/lockdep: Introduce chain_hlocks_type for held lock's read-write type

Lock chain needs to include information about the read-write lock type. To that end, introduce: chain_hlocks_type[MAX_LOCKDEP_CHAIN_HLOCKS] in addition to: chain_hlocks[MAX_LOCKDEP_CHAIN_HLOCKS] Signed-off-by: Yuyang Du --- kernel/locking/lockdep.c | 9 + 1 file

RE: FYI -ffreestanding shrinks kernel by 2% on x86_64

From: Ingo Molnar > Sent: 12 May 2019 10:32 ... > Has anyone investigated by any chance where the -ffreestanding space > savings come from mostly - is it mostly in cold paths, or does it make or > hot codepaths more efficient as well? > > If it's the latter then the kernel would be directly

Re: [PATCH] mm: mmu_gather: remove __tlb_reset_range() for force flush

On Mon, May 13, 2019 at 10:36:06AM +0200, Peter Zijlstra wrote: > On Thu, May 09, 2019 at 09:21:35PM +, Nadav Amit wrote: > > It may be possible to avoid false-positive nesting indications (when the > > flushes do not overlap) by creating a new struct mmu_gather_pending, with > > something

Re: [PATCH] mm: mmu_gather: remove __tlb_reset_range() for force flush

> On May 13, 2019, at 1:36 AM, Peter Zijlstra wrote: > > On Thu, May 09, 2019 at 09:21:35PM +, Nadav Amit wrote: > > And we can fix that by having tlb_finish_mmu() sync up. Never let a > concurrent tlb_finish_mmu() complete until all concurrenct mmu_gathers > have completed.

[tip:x86/urgent] x86/kconfig: Disable CONFIG_GENERIC_HWEIGHT and remove __HAVE_ARCH_SW_HWEIGHT

Commit-ID: 409ca45526a428620d8efb362ccfd4b1e6b80642 Gitweb: https://git.kernel.org/tip/409ca45526a428620d8efb362ccfd4b1e6b80642 Author: Masahiro Yamada AuthorDate: Sun, 12 May 2019 21:52:01 +0900 Committer: Ingo Molnar CommitDate: Mon, 13 May 2019 11:07:33 +0200 x86/kconfig: Disable

Re: [PATCH] hwspinlock: stm32: implement the relax() ops

Hi Any further comments? Fabien On 08/03/2019 1:42 PM, Benjamin Gaignard wrote: > Le jeu. 7 mars 2019 à 16:42, Fabien Dessenne a écrit > : >> Implement this optional ops, called by hwspinlock core while spinning on >> a lock, between two successive invocations of trylock(). >> >>

A lot of your incoming messages has been suspended

MICROSOFT VERIFICATION NEEDED A lot of your incoming messages has been suspended because your email box account is not verify by Microsoft verification team. In order to receive your messages do verify now, We apologise for any inconvenience and

Många av dina inkommande meddelanden har avbrutits

MICROSOFT VERIFIKATION BEHÖVER Många av dina inkommande meddelanden har avbrutits eftersom ditt e-postkonto inte är verifierat av verifieringsteamet från Microsoft. För att få dina meddelanden verifiera nu, Vi ber om ursäkt för eventuella

Re: [PATCH] pinctrl: stmfx: Fix comparison of unsigned expression warnings

On Mon, 13 May 2019, Amelie Delaunay wrote: > This patch fixes the following warnings: > > drivers/pinctrl/pinctrl-stmfx.c:225:5-8: WARNING: Unsigned expression > compared with zero: dir < 0 > drivers/pinctrl/pinctrl-stmfx.c:231:5-9: WARNING: Unsigned expression > compared with zero: pupd < 0

RE: [PATCH v3] usb: core: verify devicetree nodes for USB devices

> > On 2019-05-10 05:10, Peter Chen wrote: > > > >> Marek Szyprowski writes: > >>> Commit 69bec7259853 ("USB: core: let USB device know device node") > >>> added support for attaching devicetree node for USB devices. The > >>> mentioned commit however identifies the given USB device node only

Re: [PATCH 1/2] perf ioctl: Add check for the sample_period value

On Mon, May 13, 2019 at 09:42:13AM +0200, Peter Zijlstra wrote: > On Sat, May 11, 2019 at 08:12:16AM +0530, Ravi Bangoria wrote: > > Add a check for sample_period value sent from userspace. Negative > > value does not make sense. And in powerpc arch code this could cause > > a recursive PMI

RE: [PATCH] vsprintf: Do not break early boot with probing addresses

From: christophe leroy > Sent: 10 May 2019 18:35 > Le 10/05/2019 à 18:24, Steven Rostedt a écrit : > > On Fri, 10 May 2019 10:42:13 +0200 > > Petr Mladek wrote: > > > >> static const char *check_pointer_msg(const void *ptr) > >> { > >> - char byte; > >> - > >>if (!ptr) > >>

Re: [RESEND PATCH v2 2/2] memcg, fsnotify: no oom-kill for remote memcg charging

On Sun 12-05-19 09:09:27, Shakeel Butt wrote: [...] > diff --git a/fs/notify/fanotify/fanotify.c b/fs/notify/fanotify/fanotify.c > index 6b9c27548997..f78fd4c8f12d 100644 > --- a/fs/notify/fanotify/fanotify.c > +++ b/fs/notify/fanotify/fanotify.c > @@ -288,10 +288,13 @@ struct fanotify_event

Re: [PATCH] staging: rtl8723bs: core fix warning Comparison to bool

On Sun, May 12, 2019 at 05:54:49PM +0530, Hariprasad Kelam wrote: > fix below issue reported by coccicheck > > drivers/staging/rtl8723bs/core/rtw_mlme.c:1675:6-10: WARNING: Comparison > to bool > > Signed-off-by: Hariprasad Kelam > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- > 1

Re: [PATCH v2 2/8] Staging: kpc2000: kpc_dma: Resolve coding style errors reported by checkpatch.

On Mon, May 13, 2019 at 05:09:54AM +0530, Vandana BN wrote: > This patch resolves below errors reported by checkpatch > ERROR: "(foo*)" should be "(foo *)" > ERROR: "foo * bar" should be "foo *bar" > ERROR: "foo __init bar" should be "foo __init bar" > ERROR: "foo __exit bar" should be "foo

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

Hi Robert, On 09-05-19 20:09, Robert R. Howell wrote: Hi Hans On 5/9/19 2:50 AM, Hans de Goede wrote: Hi, On 09-05-19 06:24, Robert R. Howell wrote: On 4/30/19 8:39 AM, Hans de Goede wrote: I've just tried to reproduce the "Error i2c_dw_xfer call while suspended" error on

Re: [RFC PATCH] irqchip/gic-v3: Correct the usage of GICD_CTLR's RWP field

On Mon, 13 May 2019 04:15:54 + Zenghui Yu wrote: Hi, > As per ARM IHI 0069D, GICD_CTLR's RWP field tracks updates to: > > GICD_CTLR's Group Enable bits, for transitions from 1 to 0 only > GICD_CTLR's ARE bits, E1NWF bit and DS bit (if we have) > GICD_ICENABLER > > We

Re: [PATCH V2 0/2] arm64/mm: Enable memory hot remove

On 05/13/2019 01:52 PM, David Hildenbrand wrote: > On 14.04.19 07:59, Anshuman Khandual wrote: >> This series enables memory hot remove on arm64 after fixing a memblock >> removal ordering problem in generic __remove_memory(). This is based >> on the following arm64 working tree. >> >>

Re: [PATCH] mm: mmu_gather: remove __tlb_reset_range() for force flush

On Thu, May 09, 2019 at 09:21:35PM +, Nadav Amit wrote: > >>> And we can fix that by having tlb_finish_mmu() sync up. Never let a > >>> concurrent tlb_finish_mmu() complete until all concurrenct mmu_gathers > >>> have completed. > >>> > >>> This should not be too hard to make happen. > >> >

[PATCH v2] clk: ti: Remove unused functions

They are not used any more since commit 7558562a70fb ("clk: ti: Drop legacy clk-3xxx-legacy code") Reported-by: Hulk Robot Suggested-by: Tero Kristo Signed-off-by: YueHaibing --- v2: also remove mux/div unused functions --- drivers/clk/ti/divider.c | 36

[PATCH RESEND] mfd: rk808: Fix RK818 ID template

From: Daniel Schultz The Rockchip PMIC driver can automatically detect connected component versions by reading the ID_MSB and ID_LSB registers. The probe function will always fail with RK818 PMICs because the ID_MSK is 0xFFF0 and the RK818 template ID is 0x8181. This patch changes this value to

Re: [PATCH 1/3] arm64: Add pseudo NMI support of GICv3 SGIs

Hi Wei, On 06/05/2019 09:25, Wei Li wrote: > Currently, only PPIs and SPIs can be set as NMIs. IPIs being currently > hardcoded IRQ numbers, there isn't a generic interface to set SGIs as NMI > for now. > > In this patch, we do: > 1. Add an interface for setting priority of SGIs. > 2. Export

Re: [PATCH v3] drivers: staging : wlan-ng : collect return status without variable

Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter

Re: [PATCH V2 0/2] arm64/mm: Enable memory hot remove

On 14.04.19 07:59, Anshuman Khandual wrote: > This series enables memory hot remove on arm64 after fixing a memblock > removal ordering problem in generic __remove_memory(). This is based > on the following arm64 working tree. > > git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git

[PATCH] ASoC: hdmi-codec: re-introduce mutex locking

Replace the bit atomic operations by a mutex to ensure only one dai at a time is active on the hdmi codec. This is a follow up on change: 3fcf94ef4d41 ("ASoC: hdmi-codec: remove reference to the current substream") Suggested-by: Mark Brown Signed-off-by: Jerome Brunet ---

Re: [PATCH 2/2] pinctrl: stmfx: Fix 'warn: bitwise AND condition is false here'

On Mon, May 13, 2019 at 9:34 AM Lee Jones wrote: > drivers/pinctrl/pinctrl-stmfx.c:441 stmfx_pinctrl_irq_set_type() warn: > bitwise AND condition is false here > > Reported-by: kbuild test robot > Signed-off-by: Lee Jones Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 1/2] pinctrl: stmfx: Fix 'warn: unsigned is never less than zero'

On Mon, May 13, 2019 at 9:34 AM Lee Jones wrote: > smatch warnings: > drivers/pinctrl/pinctrl-stmfx.c:225 stmfx_pinconf_get() warn: unsigned 'dir' > is never less than zero. > drivers/pinctrl/pinctrl-stmfx.c:228 stmfx_pinconf_get() warn: unsigned 'type' > is never less than zero. >

Re: [PATCH v2] mfd: madera: Add missing of table registration

On Sat, May 11, 2019 at 12:03:58PM +0200, Daniel Gomez wrote: > MODULE_DEVICE_TABLE(of, should be called to complete DT > OF mathing mechanism and register it. > > Before this patch: > modinfo ./drivers/mfd/madera.ko | grep alias > > After this patch: > modinfo ./drivers/mfd/madera.ko | grep

Re: [PATCH 3/3] pinctrl: bcm2835: bcm7211: Add support for 7211 pull-up functionality

Hi Florian, On 09.05.19 22:59, Florian Fainelli wrote: > From: Al Cooper > > The 7211 has a new way of selecting the pull-up/pull-down setting > for a GPIO pin. The registers used for the bcm2837, GP_PUD and > GP_PUDCLKn0, are no longer connected. A new set of registers, >

Re: [PATCH 2/4] x86/kprobes: Fix frame pointer annotations

On Sat, May 11, 2019 at 09:56:55AM +0900, Masami Hiramatsu wrote: > On Fri, 10 May 2019 14:40:54 +0200 > Peter Zijlstra wrote: > > > On Fri, May 10, 2019 at 01:58:31PM +0900, Masami Hiramatsu wrote: > > > On Thu, 9 May 2019 19:14:16 +0200 > > > Peter Zijlstra wrote: > > > > > > ---

Re: Question about sched_setaffinity()

On Fri, May 10, 2019 at 04:07:42PM -0700, Paul E. McKenney wrote: > > The below trace explain the issue. Some Paul person did it, see below. > > It's broken per construction :-) > > *facepalm* Hence the very strange ->cpus_allowed mask. I really > should have figured that one out. I guess it's

Re: [v2 PATCH] mm: vmscan: correct nr_reclaimed for THP

On Sat 11-05-19 00:23:40, Yang Shi wrote: > Since commit bd4c82c22c36 ("mm, THP, swap: delay splitting THP after > swapped out"), THP can be swapped out in a whole. But, nr_reclaimed > still gets inc'ed by one even though a whole THP (512 pages) gets > swapped out. > > This doesn't make too much

[PATCH] perf report: Fix OOM error in TUI mode on s390

Debugging a OOM error using the TUI interface revealed this issue on s390: [tmricht@m83lp54 perf]$ cat /proc/kallsyms |sort 0001119b7158 B radix_tree_node_cachep 0001119b8000 B __bss_stop 0001119b8000 B _end 03ff80002850 t autofs_mount [autofs4] 03ff80002868 t

[PATCH] perf docu: Add description for stderr

Perf report displays recorded data on the screen and emits warnings and debug messages in the status line (last one on screen). Perf also supports the possibility to write all debug messages to stderr (instead of writing them to the status line). This is achieved with the following command: #

Re: [PATCH] clk: ti: Remove unused function ti_clk_build_component_gate

On 2019/5/13 15:22, Tero Kristo wrote: > On 12/05/2019 13:03, YueHaibing wrote: >> There is no callers in tree, so can be removed. > > Looks ok to me, basically legacy code that we forgot to remove while doing: > > commit 7558562a70fbd6b3fa746fa33c76c9333aa0bb32 > Author: Tony Lindgren > Date:

Re: [RFC 0/2] clocksource: davinci-timer: new driver

On 13/05/2019 09:54, Bartosz Golaszewski wrote: > śr., 17 kwi 2019 o 16:47 Bartosz Golaszewski napisał(a): >> >> From: Bartosz Golaszewski >> >> Hi Daniel, >> >> as discussed - this is the davinci timer driver split into the clockevent >> and clocksource parts. >> >> Since it won't work without

Re: [PATCH] sched: remove redundant assignment to variable utime

On Sat, May 11, 2019 at 02:18:49PM +0100, Colin King wrote: > From: Colin Ian King > > The variable utime is being assigned a value however this is never > read and later it is being reassigned to a new value. The assignment > is redundant and hence can be removed. > > Addresses-Coverity:

Re: [RFC 0/2] clocksource: davinci-timer: new driver

śr., 17 kwi 2019 o 16:47 Bartosz Golaszewski napisał(a): > > From: Bartosz Golaszewski > > Hi Daniel, > > as discussed - this is the davinci timer driver split into the clockevent > and clocksource parts. > > Since it won't work without all the other (left out for now) changes, I'm > marking it

Re: [PATCH v2 0/3] initramfs: add support for xattrs in the initial ram disk

On 5/12/2019 9:43 PM, Arvind Sankar wrote: On Sun, May 12, 2019 at 05:05:48PM +, Rob Landley wrote: On 5/12/19 7:52 AM, Mimi Zohar wrote: On Sun, 2019-05-12 at 11:17 +0200, Dominik Brodowski wrote: On Thu, May 09, 2019 at 01:24:17PM +0200, Roberto Sassu wrote: This proposal consists in

Re: [PATCH 5/5] iio: stmpe-adc: Reset possible interrupts

On Sat, 2019-05-11 at 11:24 +0100, Jonathan Cameron wrote: > On Tue, 7 May 2019 16:36:15 +0200 > Philippe Schenker wrote: > > > From: Philippe Schenker > > > > Clear any interrupt that still is on the device on every channel > > this driver is activated for in probe and specific channels in >

Re: [GIT PULL v3] Immutable branch between MFD and Pinctrl due for the v5.2 merge window

On Mon, 13 May 2019, Lee Jones wrote: > Enjoy! Should have said: now contains fixes for reported Smatch warnings. > The following changes since commit e93c9c99a629c61837d5a7fc2120cd2b6c70dbdd: > > Linux 5.1 (2019-05-05 17:42:58 -0700) > > are available in the Git repository at: > >

Re: [RFC PATCH v2 RESEND] drivers: ata: ahci_sunxi: Increased SATA/AHCI DMA TX/RX FIFOs

Hi, On 12-05-19 22:59, Uenal Mutlu wrote: Increasing the SATA/AHCI DMA TX/RX FIFOs (P0DMACR.TXTS and .RXTS, ie. TX_TRANSACTION_SIZE and RX_TRANSACTION_SIZE) from default 0x0 each to 0x3 each, gives a write performance boost of 120 MiB/s to 132 MiB/s from lame 36 MiB/s to 45 MiB/s previously.

Re: [PATCH 1/2] perf ioctl: Add check for the sample_period value

On Sat, May 11, 2019 at 08:12:16AM +0530, Ravi Bangoria wrote: > Add a check for sample_period value sent from userspace. Negative > value does not make sense. And in powerpc arch code this could cause > a recursive PMI leading to a hang (reported when running perf-fuzzer). > > Signed-off-by:

Re: [PATCH v3 5/7] nvme-pci: add device coredump infrastructure

> +static int nvme_get_telemetry_log_blocks(struct nvme_ctrl *ctrl, void *buf, > + size_t bytes, loff_t offset) > +{ > + loff_t pos = 0; > + u32 chunk_size; > + > + if (check_mul_overflow(ctrl->max_hw_sectors, 512u, _size)) > +

Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

From: Arnd Bergmann Date: Sat, May 11, 2019 at 2:51 AM To: Dmitry Vyukov Cc: Nick Kossifidis, Christoph Hellwig, Linus Torvalds, Andrew Morton, linux-arch, Linux Kernel Mailing List, linuxppc-dev > On Fri, May 10, 2019 at 6:53 AM Dmitry Vyukov wrote: > > > > > > I think it's good to have a

Re: [PATCH] pinctrl: stmfx: Fix comparison of unsigned expression warnings

On Mon, 13 May 2019, Amelie Delaunay wrote: > This patch fixes the following warnings: > > drivers/pinctrl/pinctrl-stmfx.c:225:5-8: WARNING: Unsigned expression > compared with zero: dir < 0 > drivers/pinctrl/pinctrl-stmfx.c:231:5-9: WARNING: Unsigned expression > compared with zero: pupd < 0 >

[GIT PULL v3] Immutable branch between MFD and Pinctrl due for the v5.2 merge window

Enjoy! The following changes since commit e93c9c99a629c61837d5a7fc2120cd2b6c70dbdd: Linux 5.1 (2019-05-05 17:42:58 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/ib-mfd-pinctrl-v5.2-2 for you to fetch changes up to

Re: [PATCH 1/2] arm64: dts: meson: sei510: consistently order nodes

On 11/05/2019 17:52, Jerome Brunet wrote: > On Fri, 2019-05-10 at 14:43 -0700, Kevin Hilman wrote: >> minor nit: I kind of like "aliases" and "chosen" at the top since they >> are kind of special nodes, but honestly, I can't think of a really good >> reason other than personal preference, so

Re: [PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout

> -static void __maybe_unused nvme_coredump_init(struct nvme_dev *dev); > -static void __maybe_unused nvme_coredump_logs(struct nvme_dev *dev); > -static void __maybe_unused nvme_coredump_complete(struct nvme_dev > *dev); > +static void nvme_coredump_init(struct nvme_dev *dev); > +static void

Re: [PATCH] vt: Fix a missing-check bug in drivers/tty/vt/vt.c file of Linux 5.0.14

On Sun, May 12, 2019 at 04:49:39PM +0800, Gen Zhang wrote: > On Sun, May 12, 2019 at 08:20:09AM +0200, Greg KH wrote: > > Yes, that worked! Now, can you resend it in a proper format that I can > > apply it in? (with changelog text, signed-off-by, etc.) as described in > >

[PATCH 2/2] pinctrl: stmfx: Fix 'warn: bitwise AND condition is false here'

drivers/pinctrl/pinctrl-stmfx.c:441 stmfx_pinctrl_irq_set_type() warn: bitwise AND condition is false here Reported-by: kbuild test robot Signed-off-by: Lee Jones --- drivers/pinctrl/pinctrl-stmfx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 2/5] iio: stmpe-adc: Reinit completion struct on begin conversion

On Sat, 2019-05-11 at 11:08 +0100, Jonathan Cameron wrote: > On Tue, 7 May 2019 16:36:12 +0200 > Philippe Schenker wrote: > > > From: Philippe Schenker > > > > In some cases, the wait_completion got interrupted. This caused the > > error-handling to mutex_unlock the function. The before

Re: [PATCH V6 02/15] PCI/PME: Export pcie_pme_disable_msi() & pcie_pme_no_msi() APIs

On Mon, May 13, 2019 at 10:36:13AM +0530, Vidya Sagar wrote: > Export pcie_pme_disable_msi() & pcie_pme_no_msi() APIs to enable drivers > using these APIs be able to build as loadable modules. But this is a global setting. If you root port is broken you need a per-rootport quirk instead.

[PATCH] pinctrl: stmfx: Fix comparison of unsigned expression warnings

This patch fixes the following warnings: drivers/pinctrl/pinctrl-stmfx.c:225:5-8: WARNING: Unsigned expression compared with zero: dir < 0 drivers/pinctrl/pinctrl-stmfx.c:231:5-9: WARNING: Unsigned expression compared with zero: pupd < 0 drivers/pinctrl/pinctrl-stmfx.c:228:5-9: WARNING: Unsigned

[PATCH 1/2] pinctrl: stmfx: Fix 'warn: unsigned is never less than zero'

smatch warnings: drivers/pinctrl/pinctrl-stmfx.c:225 stmfx_pinconf_get() warn: unsigned 'dir' is never less than zero. drivers/pinctrl/pinctrl-stmfx.c:228 stmfx_pinconf_get() warn: unsigned 'type' is never less than zero. drivers/pinctrl/pinctrl-stmfx.c:231 stmfx_pinconf_get() warn: unsigned

Re: [PATCH] mfd: stmfx: Fix macro definition spelling

On Fri, 10 May 2019, Nathan Chancellor wrote: > Clang warns: > > In file included from drivers/mfd/stmfx.c:13: > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > header guard here, followed by #define of a different macro > [-Wheader-guard] > > Fixes: 06252ade9156 ("mfd: Add

Re: [PATCH 4/5] iio: stmpe-adc: Use wait_for_completion_timeout

On Sat, 2019-05-11 at 11:15 +0100, Jonathan Cameron wrote: > On Tue, 7 May 2019 16:36:14 +0200 > Philippe Schenker wrote: > > > From: Philippe Schenker > > > > Use wait_for_completion_timeout instead of > > wait_for_completion_interuptible_timeout. > > > > The interruptible variant gets

Re: [PATCH] ocfs2: Fix error path kobject memory leak

On 19/5/13 11:34, Tobin C. Harding wrote: > If a call to kobject_init_and_add() fails we should call kobject_put() > otherwise we leak memory. > > Add call to kobject_put() in the error path of call to > kobject_init_and_add(). Please note, this has the side effect that > the release method

Re: [PATCH] cpufreq: Update MAINTAINERS to include schedutil governor

* Viresh Kumar wrote: > List cpufreq maintainers as well for schedutil governor apart from > scheduler maintainers. > > Signed-off-by: Viresh Kumar > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4244dd341eb7..7d4417d862a6

Re: [PATCH] clk: ti: Remove unused function ti_clk_build_component_gate

On 12/05/2019 13:03, YueHaibing wrote: There is no callers in tree, so can be removed. Looks ok to me, basically legacy code that we forgot to remove while doing: commit 7558562a70fbd6b3fa746fa33c76c9333aa0bb32 Author: Tony Lindgren Date: Thu Dec 14 08:32:06 2017 -0800 clk: ti: Drop

Re: [PATCH] ocfs2: Fix error path kobject memory leak

On Mon, May 13, 2019 at 01:34:58PM +1000, Tobin C. Harding wrote: > If a call to kobject_init_and_add() fails we should call kobject_put() > otherwise we leak memory. > > Add call to kobject_put() in the error path of call to > kobject_init_and_add(). Please note, this has the side effect that >

Re: [RFC PATCH 0/7] sched/cpufreq: Make schedutil energy aware

On Wed, May 8, 2019 at 11:57 PM wrote: > > From: Douglas RAILLARD > > Make schedutil cpufreq governor energy-aware. Hi Douglas, I was wondering on why the cpufreq maintainers weren't cc'd for this set and then I noticed that get_maintainers doesn't report us at all for schedutil :( I have

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

Hi Mason, On Fri, May 10, 2019 at 3:09 AM wrote: > > "Sergei Shtylyov" > > 2019/05/10 上午 03:24 > > mark.rutl...@arm.com, "Rob Herring" , > > zhengxu...@mxic.com.tw > > On 05/09/2019 05:06 AM, masonccy...@mxic.com.tw wrote: > > > > [...] > > >> > >> > On 4/24/19 11:23 PM, Rob Herring wrote: > >

Re: [PATCH] mfd: stmfx: Fix macro definition spelling

On 5/11/19 3:23 AM, Nathan Chancellor wrote: > Clang warns: > > In file included from drivers/mfd/stmfx.c:13: > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > header guard here, followed by #define of a different macro > [-Wheader-guard] > > Fixes: 06252ade9156 ("mfd: Add

[PATCH] cpufreq: Update MAINTAINERS to include schedutil governor

List cpufreq maintainers as well for schedutil governor apart from scheduler maintainers. Signed-off-by: Viresh Kumar --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4244dd341eb7..7d4417d862a6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH] media: vim2m: fix two double-free issues

vim2m_device_release() will be called by video_unregister_device() to release various objects. There are two double-free issue, 1. dev->m2m_dev will be freed twice in error_m2m path/vim2m_device_release 2. the error_v4l2 and error_free path in vim2m_probe() will release same objects, since

Re: [PATCH 2/2] fdomain: Add ISA bus support

On Fri, May 10, 2019 at 11:23:35PM +0200, Ondrej Zary wrote: > Add Future Domain 16xx ISA SCSI support card support. > > Tested on IBM 92F0330 card (18C50 chip) with v1.00 BIOS. Where did you find that thing? :) > > Signed-off-by: Ondrej Zary The driver looks fine to me: Reviewed-by:

Re: [PATCH 1/2] fdomain: Remove BIOS-related code from core

On Fri, May 10, 2019 at 11:23:34PM +0200, Ondrej Zary wrote: > Move all BIOS signature and base handling to (currently not merged) ISA bus > driver. > > Signed-off-by: Ondrej Zary Looks good, Reviewed-by: Christoph Hellwig

Re: Applied "dt-bindings: mfd: atmel-usart: add DMA bindings for USART in SPI mode" to the spi tree

Hi Mark, On Sun, May 12, 2019 at 7:05 PM Mark Brown wrote: > On Wed, May 08, 2019 at 11:51:05AM +0100, Lee Jones wrote: > > > Signed-off-by: Mark Brown > > > --- > > > .../devicetree/bindings/mfd/atmel-usart.txt | 20 ++- > > > Interesting! > > For some reason the bindings for

Re: [PATCH v4.4.y] mm, vmstat: make quiet_vmstat lighter

On Mon, May 13, 2019 at 08:12:37AM +0200, Daniel Wagner wrote: > From: Michal Hocko > > [ Upstream commit f01f17d3705bb6081c9e5728078f64067982be36 ] > > Mike has reported a considerable overhead of refresh_cpu_vm_stats from > the idle entry during pipe test: > > 12.89% [kernel] [k]

Re: [PATCH] staging: vc04_services: bcm2835-camera: remove redundant assignment to variable ret

On 11.05.19 15:48, Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized however this is never read and later > it is being reassigned to a new value. The initialization is redundant and > hence can be removed. > > Addresses-Coverity: ("Unused Value") > Signed-off-by:

Re: [RFC PATCH 2/2] mmc: sdhci: Quirk for AMD SDHC Device 0x7906

On 12/05/19 8:04 PM, S-k, Shyam-sundar wrote: > On 5/2/2019 12:02 PM, Adrian Hunter wrote: >> Cc: some AMD people >> >> On 1/05/19 8:54 PM, Raul E Rangel wrote: >>> AMD SDHC 0x7906 requires a hard reset to clear all internal state. >>> Otherwise it can get into a bad state where the DATA lines are

Re: [PATCH] scripts/spdxcheck.py: Fix path to deprecated licenses

For both patches: Reviewed-by: Christoph Hellwig

[PATCH 2/4] media: prefix header search paths with $(srctree)/

Currently, the Kbuild core manipulates header search paths in a crazy way [1]. To fix this mess, I want all Makefiles to add explicit $(srctree)/ to the search paths in the srctree. Some Makefiles are already written in that way, but not all. The goal of this work is to make the notation

[PATCH 1/4] media: remove unneeded header search paths

I was able to build without these extra header search paths. Signed-off-by: Masahiro Yamada --- I split this kind of cleanups per-subsystem, and all of them were merged, except the media subsystem. I sent ping several times to the media subsystem but I could not get response at all.

[PATCH v4.4.y] mm, vmstat: make quiet_vmstat lighter

From: Michal Hocko [ Upstream commit f01f17d3705bb6081c9e5728078f64067982be36 ] Mike has reported a considerable overhead of refresh_cpu_vm_stats from the idle entry during pipe test: 12.89% [kernel] [k] refresh_cpu_vm_stats.isra.12 4.75% [kernel] [k] __schedule

[PATCH 0/4] kbuild: remove 'addtree' and 'flags' magic

The 'addtree' and 'flags' are longstanding PITA. When we discussed this in kbuild ML, (https://patchwork.kernel.org/patch/9632347/) we agreed to get rid of this hack. This required lots of efforts to send many fixups to each subsystem. I did it, all the per-subsystem fixups were merged except

Re: [PATCH] ARM: mm: remove unused variables

On Sun, May 12, 2019 at 1:48 PM YueHaibing wrote: > Fix gcc warnings: > > arch/arm/mm/init.c: In function 'mem_init': > arch/arm/mm/init.c:456:13: warning: unused variable 'itcm_end' > [-Wunused-variable] > extern u32 itcm_end; > ^ > arch/arm/mm/init.c:455:13: warning: unused

<    3   4   5   6   7   8