Re: [PATCH 2/3] KVM: X86: Implement PV sched yield hypercall

2019-05-27 Thread Wanpeng Li
On Mon, 27 May 2019 at 19:54, Paolo Bonzini wrote: > > On 27/05/19 12:34, Wanpeng Li wrote: > > + rcu_read_lock(); > > + map = rcu_dereference(kvm->arch.apic_map); > > + target = map->phys_map[dest_id]->vcpu; > > + rcu_read_unlock(); > > + > > + kvm_vcpu_yield_to(target); > >

[PATCH v2 2/3] KVM: X86: Implement PV sched yield hypercall

2019-05-27 Thread Wanpeng Li
From: Wanpeng Li The target vCPUs are in runnable state after vcpu_kick and suitable as a yield target. This patch implements the sched yield hypercall. 17% performace increase of ebizzy benchmark can be observed in an over-subscribe environment. (w/ kvm-pv-tlb disabled, testing TLB flush

[PATCH v2 3/3] KVM: X86: Expose PV_SCHED_YIELD CPUID feature bit to guest

2019-05-27 Thread Wanpeng Li
From: Wanpeng Li Expose PV_SCHED_YIELD feature bit to guest, the guest can check this feature bit before using paravirtualized sched yield. Cc: Paolo Bonzini Cc: Radim Krčmář Signed-off-by: Wanpeng Li --- Documentation/virtual/kvm/cpuid.txt | 4 arch/x86/kvm/cpuid.c| 3

[PATCH v2 1/3] KVM: X86: Implement PV sched yield in linux guest

2019-05-27 Thread Wanpeng Li
From: Wanpeng Li When sending a call-function IPI-many to vCPUs, yield if any of the IPI target vCPUs was preempted, we just select the first preempted target vCPU which we found since the state of target vCPUs can change underneath and to avoid race conditions. Cc: Paolo Bonzini Cc: Radim

[PATCH v2 0/3] KVM: Yield to IPI target if necessary

2019-05-27 Thread Wanpeng Li
The idea is from Xen, when sending a call-function IPI-many to vCPUs, yield if any of the IPI target vCPUs was preempted. 17% performace increase of ebizzy benchmark can be observed in an over-subscribe environment. (w/ kvm-pv-tlb disabled, testing TLB flush call-function IPI-many since

memory leak in get_device_parent

2019-05-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:35efb51e Merge tag 'ext4_for_linus_stable' of git://git.ke.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16577182a0 kernel config: https://syzkaller.appspot.com/x/.config?x=61dd9e15a761691d

memory leak in nr_create

2019-05-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:54dee406 Merge tag 'arm64-fixes' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1456f282a0 kernel config: https://syzkaller.appspot.com/x/.config?x=61dd9e15a761691d

memory leak in sctp_process_init

2019-05-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:9c7db500 Merge tag 'selinux-pr-20190521' of git://git.kern.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10388530a0 kernel config: https://syzkaller.appspot.com/x/.config?x=61dd9e15a761691d

Re: [PATCH v3 7/9] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

2019-05-27 Thread Dan Murphy
Rob On 5/24/19 3:50 PM, Rob Herring wrote: On Thu, 23 May 2019 14:08:18 -0500, Dan Murphy wrote: Introduce the bindings for the Texas Instruments LP5036, LP5030, LP5024 and LP5018 RGB LED device driver. The LP5036/30/24/18 can control RGB LEDs individually or as part of a control bank group.

[PATCH v3] vt: Fix a missing-check bug in con_init()

2019-05-27 Thread Gen Zhang
In function con_init(), the pointer variable vc_cons[currcons].d, vc and vc->vc_screenbuf is allocated by kzalloc(). And they are used in the following codes. However, kzalloc() returns NULL when fails, and null pointer dereference may happen. And it will cause the kernel to crash. Therefore,

Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

2019-05-27 Thread Dan Murphy
Pavel On 5/27/19 5:33 AM, Pavel Machek wrote: On Thu 2019-05-23 14:08:12, Dan Murphy wrote: Add a documentation of LED Multicolor LED class specific sysfs attributes. Signed-off-by: Dan Murphy --- .../ABI/testing/sysfs-class-led-multicolor| 57 +++ 1 file changed, 57

Re: [PATCH] kconfig: tests: fix recursive inclusion unit test

2019-05-27 Thread Masahiro Yamada
On Sat, May 25, 2019 at 8:49 PM Masahiro Yamada wrote: > > Adding SPDX license identifier is pretty safe; however, here is one > exception. > > Since commit ec8f24b7faaf ("treewide: Add SPDX license identifier - > Makefile/Kconfig"), "make testconfig" would not pass. > > When Kconfig detects a

Re: [PATCH] kbuild: tar-pkg: enable communication with jobserver

2019-05-27 Thread Masahiro Yamada
On Tue, May 28, 2019 at 8:55 AM Trevor Bourget wrote: > > The buildtar script might want to invoke a make, so tell the parent > make to pass the jobserver token pipe to the subcommand by prefixing > the command with a +. > > This addresses the issue seen here: > > /bin/sh

[Question: devm_kfree] When should devm_kfree() be used?

2019-05-27 Thread Gen Zhang
devm_kmalloc() is used to allocate memory for a driver dev. Comments above the definition and doc (https://www.kernel.org/doc/Documentation/driver-model/devres.txt) all imply that allocated the memory is automatically freed on driver attach, no matter allocation fail or not. However, I examined

[RFC] printk/sysrq: Don't play with console_loglevel

2019-05-27 Thread Dmitry Safonov
While handling sysrq the console_loglevel is bumped to default to print sysrq headers. It's done to print sysrq messages with WARNING level for consumers of /proc/kmsg, though it sucks by the following reasons: - changing console_loglevel may produce tons of messages (especially on bloated with

Re: eb9d1bf079 [ 88.881528] EIP: _random_read

2019-05-27 Thread Rong Chen
On 5/23/19 12:24 AM, Theodore Ts'o wrote: Can you check and see if this addresses the issue? I'm not able to easily repro the softlockup. Hi, The patch could fix the issue in our testing environment. Best Regards, Rong Chen Thanks! -

memory leak in process_preds

2019-05-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:cd6c84d8 Linux 5.2-rc2 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14039c36a0 kernel config: https://syzkaller.appspot.com/x/.config?x=64479170dcaf0e11 dashboard link:

[PATCH] kbuild: tar-pkg: enable communication with jobserver

2019-05-27 Thread Trevor Bourget
The buildtar script might want to invoke a make, so tell the parent make to pass the jobserver token pipe to the subcommand by prefixing the command with a +. This addresses the issue seen here: /bin/sh ../scripts/package/buildtar tar-pkg make[3]: warning: jobserver unavailable:

linusw/for-next boot bisection: v5.2-rc1-8-g73a790c68d7e on rk3288-veyron-jaq

2019-05-27 Thread kernelci.org bot
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the

Re: [RFC 5/7] mm: introduce external memory hinting API

2019-05-27 Thread Minchan Kim
On Mon, May 27, 2019 at 05:12:02PM +0200, Oleg Nesterov wrote: > On 05/27, Minchan Kim wrote: > > > > > another problem is that pid_task(pid) can return a zombie leader, in this > > > case > > > mm_access() will fail while it shouldn't. > > > > I'm sorry. I didn't notice that. However, I couldn't

Re: [PATCH v2 0/7] mm: process_vm_mmap() -- syscall for duplication a process mapping

2019-05-27 Thread Kirill A. Shutemov
On Fri, May 24, 2019 at 05:00:32PM +0300, Kirill Tkhai wrote: > On 24.05.2019 14:52, Kirill A. Shutemov wrote: > > On Fri, May 24, 2019 at 01:45:50PM +0300, Kirill Tkhai wrote: > >> On 22.05.2019 18:22, Kirill A. Shutemov wrote: > >>> On Mon, May 20, 2019 at 05:00:01PM +0300, Kirill Tkhai wrote: >

Re: [PATCH v3 5/6] x86/MCE: Save MCA control bits that get set in hardware

2019-05-27 Thread Borislav Petkov
On Thu, May 23, 2019 at 08:00:33PM +, Ghannam, Yazen wrote: > I did a bit more testing and I noticed that writing "0" disables a bank with > no way to reenable it. > > For example: > 1) Read bank10. > a) Succeeds; returns "fff". > 2) Write "0" to bank10. > a)

Re: [PATCH v2] infiniband/mm: convert put_page() to put_user_page*()

2019-05-27 Thread Jason Gunthorpe
On Fri, May 24, 2019 at 06:45:22PM -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > For infiniband code that retains pages via get_user_pages*(), > release those pages via the new put_user_page(), or > put_user_pages*(), instead of put_page() > > This is a tiny part of the second

Re: [PATCH -next] IB/hfi1: remove set but not used variables 'offset' and 'fspsn'

2019-05-27 Thread Jason Gunthorpe
On Sat, May 25, 2019 at 08:57:37PM +0800, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/infiniband/hw/hfi1/tid_rdma.c: In function tid_rdma_rcv_error: > drivers/infiniband/hw/hfi1/tid_rdma.c:2029:7: warning: variable offset set > but not used

Re: [PATCH v2] infiniband/mm: convert put_page() to put_user_page*()

2019-05-27 Thread Jason Gunthorpe
On Sun, May 26, 2019 at 04:06:31AM -0700, Matthew Wilcox wrote: > On Fri, May 24, 2019 at 06:45:22PM -0700, john.hubb...@gmail.com wrote: > > For infiniband code that retains pages via get_user_pages*(), > > release those pages via the new put_user_page(), or > > put_user_pages*(), instead of

Re: [PATCH net 4/4] net/udpgso_bench_tx: audit error queue

2019-05-27 Thread Fred Klassen
> On May 27, 2019, at 2:46 PM, Willem de Bruijn > wrote: >> Also, I my v2 fix in net is still up for debate. In its current state, it >> meets my application’s requirements, but may not meet all of yours. > I gave more specific feedback on issues with it (referencing zerocopy > and IP_TOS,

[RESEND PATCH 1/3] PCI: Introduce pcibios_ignore_alignment_request

2019-05-27 Thread Shawn Anastasio
Introduce a new pcibios function pcibios_ignore_alignment_request which allows the PCI core to defer to platform-specific code to determine whether or not to ignore alignment requests for PCI resources. The existing behavior is to simply ignore alignment requests when PCI_PROBE_ONLY is set. This

[RESEND PATCH 3/3] powerpc/pseries: Allow user-specified PCI resource alignment after init

2019-05-27 Thread Shawn Anastasio
On pseries, custom PCI resource alignment specified with the commandline argument pci=resource_alignment is disabled due to PCI resources being managed by the firmware. However, in the case of PCI hotplug the resources are managed by the kernel, so custom alignments should be honored in these

[RESEND PATCH 2/3] powerpc/64: Enable pcibios_after_init hook on ppc64

2019-05-27 Thread Shawn Anastasio
Enable the pcibios_after_init hook on all powerpc platforms. This hook is executed at the end of pcibios_init and was previously only available on CONFIG_PPC32. Since it is useful and not inherently limited to 32-bit mode, remove the limitation and allow it on all powerpc platforms.

[RESEND PATCH 0/3] Allow custom PCI resource alignment on pseries

2019-05-27 Thread Shawn Anastasio
Hello all, This patch set implements support for user-specified PCI resource alignment on the pseries platform for hotplugged PCI devices. Currently on pseries, PCI resource alignments specified with the pci=resource_alignment commandline argument are ignored, since the firmware is in charge of

Re: [PATCH 05/44] perf data: Fix 'strncat may truncate' build failure with recent gcc

2019-05-27 Thread Shawn Landden
On Mon, May 27, 2019 at 5:38 PM Arnaldo Carvalho de Melo wrote: > > From: Shawn Landden > > This strncat() is safe because the buffer was allocated with zalloc(), > however gcc doesn't know that. Since the string always has 4 non-null > bytes, just use memcpy() here. > > CC

Re: [PATCH v6 4/4] x86/acrn: Add hypercall for ACRN guest

2019-05-27 Thread Borislav Petkov
On Mon, May 27, 2019 at 10:57:09AM +0800, Zhao, Yakui wrote: > I refer to the Xen/KVM hypercall to add the ACRN hypercall in one separate > header. And? > The ACRN hypercall is defined in one separate acrn_hypercall.h and can be > included explicitly by the *.c that needs the hypercall. Sure

Re: [PATCH v6 3/4] x86/acrn: Use HYPERVISOR_CALLBACK_VECTOR for ACRN guest upcall vector

2019-05-27 Thread Borislav Petkov
On Mon, May 27, 2019 at 10:21:20AM +0800, Zhao, Yakui wrote: > Very sorry that this issue is not triggered as the used .config in my test > doesn't enable the check of "-Werror=implict-function-declaration". It is more like, you're not building this particular .config. -- Regards/Gruss,

[PATCH 44/44] tools headers UAPI: Sync kvm.h headers with the kernel sources

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo dd53f6102c30 ("Merge tag 'kvmarm-for-v5.2' of git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm into HEAD") 59c5c58c5b93 ("Merge tag 'kvm-ppc-next-5.2-2' of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc into HEAD") d7547c55cbe7

[PATCH 42/44] perf version: Append 12 git SHA chars to the version string

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Bumping it from just 4: Before: $ perf -v perf version 5.2.rc1.g80978f $ After: $ perf -v perf version 5.2.rc1.g80978fc864c5 $ Requested-by: Ingo Molnar Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Link:

[PATCH 43/44] perf record: Fix s390 missing module symbol and warning for non-root users

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Thomas Richter Command 'perf record' and 'perf report' on a system without kernel debuginfo packages uses /proc/kallsyms and /proc/modules to find addresses for kernel and module symbols. On x86 this works for root and non-root users. On s390, when invoked as non-root user, many of the

[PATCH v4 1/2] ARM: use arch_extension directive instead of arch argument

2019-05-27 Thread Stefan Agner
The LLVM Target parser currently does not allow to specify the security extension as part of -march (see also LLVM Bug 40186 [0]). When trying to use Clang with LLVM's integrated assembler, this leads to build errors such as this: clang-8: error: the clang compiler does not support

[PATCH 41/44] perf script: Remove superfluous BPF event titles

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa There's no need to display "ksymbol event with" text for the PERF_RECORD_KSYMBOL event and "bpf event with" test for the PERF_RECORD_BPF_EVENT event. Remove it so it also goes along with other side-band events display. Before: # perf script --show-bpf-events ... swapper

[PATCH v4 2/2] ARM: OMAP2: drop explicit assembler architecture

2019-05-27 Thread Stefan Agner
OMAP2 depends on ARCH_MULTI_V6, which makes sure that the kernel is compiled with -march=armv6. The compiler frontend will pass the architecture to the assembler. There is no explicit architecture specification necessary. Signed-off-by: Stefan Agner Acked-by: Tony Lindgren --- Changes since v2:

[PATCH 38/44] perf script: Pad DSO name for --call-trace

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Pad the DSO name in --call-trace so we don't have the indent screwed by different DSO name lengths, as now for kernel there's also BPF code displayed. # perf-with-kcore record pt -e intel_pt//ku -- sleep 1 # perf-core/perf-with-kcore script pt --call-trace Before: sleep

[PATCH 40/44] perf script: Add --show-bpf-events to show eBPF related events

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add the --show-bpf-events command line option to show the eBPF related events: PERF_RECORD_KSYMBOL PERF_RECORD_BPF_EVENT Usage: # perf record -a ... # perf script --show-bpf-events ... swapper 0 [000] 0.00: PERF_RECORD_KSYMBOL ksymbol event with addr

[PATCH 39/44] perf tests: Add map_groups__merge_in test

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add map_groups__merge_in test to test the map_groups__merge_in function usage - merging kcore maps into existing eBPF maps. Committer testing: # perf test merge 59: map_groups__merge_in : Ok # perf test -v merge 59: map_groups__merge_in

[PATCH 37/44] perf tools: Preserve eBPF maps when loading kcore

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We need to preserve eBPF maps even if they are covered by kcore, because we need to access eBPF dso for source data. Add the map_groups__merge_in function to do that. It merges a map into map_groups by splitting the new map within the existing map regions. Suggested-by: Adrian

[PATCH 32/44] perf dso: Simplify dso_cache__read function

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa There's no need for the while loop now, also we can connect two (ret > 0) condition legs together. Signed-off-by: Jiri Olsa Acked-by: Song Liu Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Song Liu Cc: Stanislav Fomichev

[PATCH 35/44] perf machine: Read also the end of the kernel

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We mark the end of kernel based on the first module, but that could cover some bpf program maps. Reading _etext symbol if it's present to get precise kernel map end. Signed-off-by: Jiri Olsa Acked-by: Song Liu Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc:

[PATCH 33/44] perf dso: Add BPF DSO read and size hooks

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add BPF related code into DSO reading paths to return size (bpf_size) and read the BPF code (bpf_read). Signed-off-by: Jiri Olsa Acked-by: Song Liu Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stanislav Fomichev Link:

[PATCH 34/44] perf test vmlinux-kallsyms: Ignore aliases to _etext when searching on kallsyms

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo No need to search for aliases for the symbol that marks the end of the kernel text segment, the following patch will make such symbols not to be found when searching in the kallsyms maps causing this test to fail. So as a prep patch to avoid breaking bisection,

[PATCH 36/44] perf machine: Keep zero in pgoff BPF map

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa With pgoff set to zero, the map__map_ip function will return BPF addresses based from 0, which is what we need when we read the data from a BPF DSO. Adding BPF symbols with mapped IP addresses as well. Signed-off-by: Jiri Olsa Acked-by: Song Liu Cc: Adrian Hunter Cc:

[PATCH 29/44] perf tools: Remove const from thread read accessors

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim The namespaces and comm fields of a thread are protected by rwsem and require write access for it. So it ended up using a cast to remove the const qualifier. Let's get rid of the const then. Signed-off-by: Namhyung Kim Suggested-by: Arnaldo Carvalho de Melo Cc: Hari

[PATCH 30/44] perf dso: Separate generic code in dso__data_file_size()

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Moving file specific code in dso__data_file_size function into separate file_size function. I'll add bpf specific code in following patches. Signed-off-by: Jiri Olsa Acked-by: Song Liu Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Namhyung Kim Cc: Peter

[PATCH 31/44] perf dso: Separate generic code in dso_cache__read

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Move the file specific code in the dso_cache__read function to a separate file_read function. I'll add BPF specific code in the following patches. Signed-off-by: Jiri Olsa Acked-by: Song Liu Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Namhyung Kim Cc: Peter

[PATCH 28/44] perf top: Add --namespaces option

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim Since 'perf record' already have this option, let's have it for 'perf top' as well. Signed-off-by: Namhyung Kim Cc: Hari Bathini Cc: Jiri Olsa Cc: Krister Johansen Link: http://lkml.kernel.org/r/20190522053250.207156-4-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho

[PATCH 27/44] perf session: Add missing swap ops for namespace events

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim In case it's recorded in a different arch. Signed-off-by: Namhyung Kim Cc: Hari Bathini Cc: Jiri Olsa Cc: Krister Johansen Fixes: f3b3614a284d ("perf tools: Add PERF_RECORD_NAMESPACES to include namespaces related info") Link:

[PATCH 20/44] perf trace beauty clone: Handle CLONE_PIDFD

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo In addition to the older flags. This will allow something like this to be implemented in 'perf trace" perf trace -e clone/PIDFD in flags/ I.e. ask for strace like tracing, system wide, looking for 'clone' syscalls that have the CLONE_PIDFD bit set in the

[PATCH 19/44] tools headers UAPI: Sync linux/sched.h with the kernel

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To pick up the change in: b3e583825266 ("clone: add CLONE_PIDFD") This requires changes in the 'perf trace' beautification routines for the 'clone' syscall args, which is done in a followup patch. This silences the following perf build warning: Warning:

[PATCH 18/44] tools arch x86: Sync asm/cpufeatures.h with the with the kernel

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To pick up the changes in: ed5194c2732c ("x86/speculation/mds: Add basic bug infrastructure for MDS") e261f209c366 ("x86/speculation/mds: Add BUG_MSBDS_ONLY") That don't affect anything in tools/. This silences this perf build warning: Warning: Kernel ABI

[PATCH 23/44] perf trace: Beautify 'sync_file_range' arguments

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Use existing beautifiers for the first arg, fd, assigned using the heuristic that looks for syscall arg names and associates SCA_FD with 'fd' named argumes, and wire up the recently introduced sync_file_range flags table generator. Now it should be possible to

[PATCH 16/44] perf trace: Introduce syscall_arg__scnprintf_strarray_flags

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo So that one can just define a strarray and process it as a set of flags, similar to syscall_arg__scnprintf_strarray() with plain arrays. Cc: Adrian Hunter Cc: Brendan Gregg Cc: Jiri Olsa Cc: Luis Cláudio Gonçalves Cc: Namhyung Kim Link:

[PATCH 17/44] perf trace: Beautify 'fsmount' arguments

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Use existing beautifiers for the first arg, fd, assigned using the heuristic that looks for syscall arg names and associates SCA_FD with 'fd' named argumes, and wire up the recently introduced fsmount attr_flags table generator. Now it should be possible to just

[PATCH 22/44] perf beauty: Add generator for sync_file_range's 'flags' arg values

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo $ tools/perf/trace/beauty/sync_file_range.sh static const char *sync_file_range_flags[] = { [ilog2(1) + 1] = "WAIT_BEFORE", [ilog2(2) + 1] = "WRITE", [ilog2(4) + 1] = "WAIT_AFTER", }; $ When all are the above are present, then

[PATCH 26/44] perf namespace: Protect reading thread's namespace

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim It seems that the current code lacks holding the namespace lock in thread__namespaces(). Otherwise it can see inconsistent results. Signed-off-by: Namhyung Kim Cc: Hari Bathini Cc: Jiri Olsa Cc: Krister Johansen Link:

[PATCH 25/44] tools headers UAPI: Sync drm/drm.h with the kernel

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To pick up the changes in these csets: 060cebb20cdb ("drm: introduce a capability flag for syncobj timeline support") 50d1ebef79ef ("drm/syncobj: add timeline signal ioctl for syncobj v5") ea569910cbab ("drm/syncobj: add transition iotcls between binary and

[PATCH 21/44] tools headers UAPI: Sync linux/fs.h with the kernel

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To pick up the changes in: c553ea4fdf27 ("fs/sync.c: sync_file_range(2) may use WB_SYNC_ALL writeback") That should be used to beautify the 'sync_file_range' syscall 'flags' arg. This silences this perf build warning: Warning: Kernel ABI header at

[PATCH 24/44] tools headers UAPI: Sync drm/i915_drm.h with the kernel

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To pick up the changes from: d1172ab3d443 ("drm/i915: Introduce struct class_instance for engines across the uAPI") 96fd2c6633b0 ("drm/i915: Drop new chunks of context creation ABI (for now)") ea593dbba4c8 ("drm/i915: Allow contexts to share a single

[PATCH 07/44] tools include UAPI: Update copy of files related to new fspick, fsmount, fsconfig, fsopen, move_mount and open_tree syscalls

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Copy the headers changed by these csets: d8076bdb56af ("uapi: Wire up the mount API syscalls on non-x86 arches [ver #2]") 9c8ad7a2ff0b ("uapi, x86: Fix the syscall numbering of the mount API syscalls [ver #2]") cf3cba4a429b ("vfs: syscall: Add fspick() to

[PATCH 15/44] perf beauty: Add generator for fsmount's 'attr_flags' arg values

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo $ tools/perf/trace/beauty/fsmount.sh static const char *fsmount_attr_flags[] = { [ilog2(0x0001) + 1] = "RDONLY", [ilog2(0x0002) + 1] = "NOSUID", [ilog2(0x0004) + 1] = "NODEV", [ilog2(0x0008) + 1] =

[PATCH 04/44] perf intel-pt: Fix itrace defaults for perf script intel-pt documentation

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Fix intel-pt documentation to reflect the change of itrace defaults for perf script. Signed-off-by: Adrian Hunter Cc: Jiri Olsa Cc: sta...@vger.kernel.org Fixes: 4eb068157121 ("perf script: Make itrace script default to all calls") Link:

[PATCH 12/44] perf trace: Beautify 'fspick' arguments

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Use existing beautifiers for the first 2 args (dfd, path) and wire up the recently introduced fspick flags table generator. Now it should be possible to just use: perf trace -e fspick As root and see all move_mount syscalls with its args beautified, either

[PATCH 10/44] perf trace: Beautify 'move_mount' arguments

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Use existing beautifiers for the first 4 args (to/from fds, pathnames) and wire up the recently introduced move_mount flags table generator. Now it should be possible to just use: perf trace -e move_mount As root and see all move_mount syscalls with its

[PATCH 14/44] perf trace: Beautify 'fsconfig' arguments

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Use existing beautifiers for the first arg, fd, assigned using the heuristic that looks for syscall arg names and associates SCA_FD with 'fd' named argumes, and wire up the recently introduced fsconfig cmd table generator. Now it should be possible to just use:

[PATCH 09/44] perf beauty: Add generator for 'move_mount' flags argument

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo $ tools/perf/trace/beauty/move_mount_flags.sh static const char *move_mount_flags[] = { [ilog2(0x0001) + 1] = "F_SYMLINKS", [ilog2(0x0002) + 1] = "F_AUTOMOUNTS", [ilog2(0x0004) + 1] = "F_EMPTY_PATH",

[PATCH 05/44] perf data: Fix 'strncat may truncate' build failure with recent gcc

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Shawn Landden This strncat() is safe because the buffer was allocated with zalloc(), however gcc doesn't know that. Since the string always has 4 non-null bytes, just use memcpy() here. CC /home/shawn/linux/tools/perf/util/data-convert-bt.o In file included from

[PATCH 13/44] perf beauty: Add generator for fsconfig's 'cmd' arg values

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo $ tools/perf/trace/beauty/fsconfig.sh static const char *fsconfig_cmds[] = { [0] = "SET_FLAG", [1] = "SET_STRING", [2] = "SET_BINARY", [3] = "SET_PATH", [4] = "SET_PATH_EMPTY", [5] = "SET_FD",

[GIT PULL] perf/urgent improvements and fixes

2019-05-27 Thread Arnaldo Carvalho de Melo
nux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-5.2-20190527 for you to fetch changes up to b8e86fe4dfe0a14b7f24277c2864b179557f788c: tools headers UAPI: Sync kvm.h headers with the kernel sources (2019-05-27 11:05:32 -0300) ---

[PATCH 03/44] perf auxtrace: Fix itrace defaults for perf script

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Commit 4eb068157121 ("perf script: Make itrace script default to all calls") does not work for the case when '--itrace' only is used, because default_no_sample is not being passed. Example: Before: $ perf record -e intel_pt/cyc/u ls $ perf script --itrace > cmp1.txt

[PATCH 02/44] perf intel-pt: Fix itrace defaults for perf script

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Commit 4eb068157121 ("perf script: Make itrace script default to all calls") does not work because 'use_browser' is being used to determine whether to default to periodic sampling (i.e. better for perf report). The result is that nothing but CBR events display for perf script

[PATCH 11/44] perf beauty: Add generator for fspick's 'flags' arg values

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo $ tools/perf/trace/beauty/fspick.sh static const char *fspick_flags[] = { [ilog2(0x0001) + 1] = "CLOEXEC", [ilog2(0x0002) + 1] = "SYMLINK_NOFOLLOW", [ilog2(0x0004) + 1] = "NO_AUTOMOUNT", [ilog2(0x0008) +

[PATCH 08/44] perf augmented_raw_syscalls: Fix up comment

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Cut'n'paste error, the second comment is about the syscalls that have as its second arg a string. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Link: https://lkml.kernel.org/n/tip-zo5s6rloy42u41acsf6q3...@git.kernel.org Signed-off-by: Arnaldo Carvalho de

[PATCH 06/44] perf arm64: Fix mksyscalltbl when system kernel headers are ahead of the kernel

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Vitaly Chikunov When a host system has kernel headers that are newer than a compiling kernel, mksyscalltbl fails with errors such as: : In function 'main': :271:44: error: '__NR_kexec_file_load' undeclared (first use in this function) :271:44: note: each undeclared identifier is

[PATCH 01/44] perf-with-kcore.sh: Always allow fix_buildid_cache_permissions

2019-05-27 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter The user's buildid cache may contain entries added by root even if root has its own home directory (e.g. by using perfconfig to specify the same buildid dir), so remove that validation. Signed-off-by: Adrian Hunter Cc: Jiri Olsa Link:

Re: uapi headers userspace build results

2019-05-27 Thread Randy Dunlap
Hi Jayant, What ever happened to this script and subsequent patches? thanks. On 6/19/18 11:17 AM, Randy Dunlap wrote: > On 06/18/2018 06:47 PM, Jayant Chowdhary wrote: >> Hi Randy, >> >> On 06/12/2018 05:07 PM, Randy Dunlap wrote: >>> On 06/12/2018 01:39 PM, Jayant Chowdhary wrote: Hi

Re: [PATCH -next] fpga: dfl: fme: Remove set but not used variable 'fme'

2019-05-27 Thread Ben Widawsky
On 19-05-27 23:34:24, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/fpga/dfl-fme-main.c: In function fme_dev_destroy: > drivers/fpga/dfl-fme-main.c:216:18: warning: variable fme set but not used > [-Wunused-but-set-variable] > > It's never used since

Re: [PATCH -next] fpga: dfl: afu: Remove set but not used variable 'afu'

2019-05-27 Thread Ben Widawsky
On 19-05-27 23:37:55, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/fpga/dfl-afu-main.c: In function afu_dev_destroy: > drivers/fpga/dfl-afu-main.c:529:18: warning: variable afu set but not used > [-Wunused-but-set-variable] > > It is never used since

[PATCH 8/8] perf/x86/rapl: Get quirk state from new probe framework

2019-05-27 Thread Jiri Olsa
Getting the apply_quirk bool from new rapl_model_match array. And because apply_quirk was the last remaining piece of data in rapl_cpu_match, replacing it with rapl_model_match as device table. The switch to new perf_msr_probe detection API is done. Signed-off-by: Jiri Olsa ---

[PATCH 3/8] perf/x86/cstate: Use new probe function

2019-05-27 Thread Jiri Olsa
Using perf_msr_probe function to probe for cstate events. The functionality is the same, with one exception, that perf_msr_probe checks for rdmsr to return value != 0 for given MSR register. Using the new attribute groups and adding the events via pmu::attr_update. Signed-off-by: Jiri Olsa ---

[tip:WIP.x86/core 28/29] arch/x86/kernel/cpu/acrn.c:52:2: error: implicit declaration of function 'entering_ack_irq'; did you mean 'spin_lock_irq'?

2019-05-27 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.x86/core head: 830be9dae84c3a781f6d1594c4038c164bbae52b commit: 6fc278e883365e67dd4a35e25b756d9d0c9d913c [28/29] x86/acrn: Use HYPERVISOR_CALLBACK_VECTOR for ACRN guest upcall vector config: x86_64-randconfig-s505280430

[PATCH 7/8] perf/x86/rapl: Get attributes from new probe framework

2019-05-27 Thread Jiri Olsa
We no longer need model specific attribute arrays, because we get all this detected in rapl_events_attrs. Signed-off-by: Jiri Olsa --- arch/x86/events/intel/rapl.c | 89 1 file changed, 89 deletions(-) diff --git a/arch/x86/events/intel/rapl.c

[PATCH 6/8] perf/x86/rapl: Get msr values from new probe framework

2019-05-27 Thread Jiri Olsa
There's no need to have special code for getting the bit and msr value for given event. We can now easily get it from rapl_msrs array. Also getting rid of RAPL_IDX_*, which is no longer needed and replacing INTEL_RAPL* with PERF_RAPL* enums. Signed-off-by: Jiri Olsa ---

[PATCH 4/8] perf/x86/rapl: Use new msr detection interface

2019-05-27 Thread Jiri Olsa
Using perf_msr_probe function to probe for rapl msrs. Adding new rapl_model_match device table, that gathers events info for given model, following the msr and cstate module design. It will replace the current rapl_cpu_match device table and detection code in following patches. Signed-off-by:

[PATCH 5/8] perf/x86/rapl: Get rapl_cntr_mask from new probe framework

2019-05-27 Thread Jiri Olsa
We get rapl_cntr_mask from perf_msr_probe call, as a replacement for current intel_rapl_init_fun::cntr_mask value for each model. Signed-off-by: Jiri Olsa --- arch/x86/events/intel/rapl.c | 38 ++-- 1 file changed, 2 insertions(+), 36 deletions(-) diff --git

[PATCH 2/8] perf/x86/msr: Use new probe function

2019-05-27 Thread Jiri Olsa
Using perf_msr_probe function to probe for msr events. The functionality is the same, with one exception, that perf_msr_probe checks for rdmsr to return value != 0 for given MSR register. Using the new attribute groups and adding the events via pmu::attr_update. Signed-off-by: Jiri Olsa ---

[PATCH 1/8] perf/x86: Add msr probe interface

2019-05-27 Thread Jiri Olsa
Adding perf_msr_probe function to provide interface for checking up on MSR register and set the related attribute group visibility. User defines following struct for each MSR register: struct perf_msr { u64 msr; struct attribute_group *grp; bool

[PATCH 0/8] perf/x86: Rework msr probe interface

2019-05-27 Thread Jiri Olsa
hi, following up on [1], [2] and [3], this patchset adds update attribute groups to pmu, factors out the MSR probe code and use it in msr,cstate* and rapl PMUs. The functionality stays the same with one exception: the event is not exported if the rdmsr return zero on event's msr. And also: ;-) >

linux-next: Fixes tag needs some work in the wireless-drivers-next tree

2019-05-27 Thread Stephen Rothwell
Hi all, In commit 9280f4fc06f4 ("ath10k: Fix the wrong value of enums for wmi tlv stats id") Fixes tag Fixes: f40a307eb92c ("ath10k: Fill rx duration for each peer in fw_stats for WCN3990) has these problem(s): - Subject has leading but no trailing quotes In commit 93ee3d108fc7

Re: [PATCH net 4/4] net/udpgso_bench_tx: audit error queue

2019-05-27 Thread Willem de Bruijn
On Mon, May 27, 2019 at 5:30 PM Fred Klassen wrote: > > Willem, > > Thanks for spending so much time with me on this patch. I’m pretty > new to this, so I know I am making lots of mistakes. I have been > working on a v2 of the selftests in net-next, but want to review the > layout of the report

Re: 5.1.0-next-20190520 -- emacs segfaults on 32-bit machine Re: 5.2-rc0.8: emacs segfaults?! x220, with 32-bit userland

2019-05-27 Thread Pavel Machek
On Mon 2019-05-27 15:08:48, Sebastian Andrzej Siewior wrote: > On 2019-05-27 15:03:17 [+0200], Pavel Machek wrote: > > > could you please send me (offlist) your .config? Also, what kind of > > > userland do you run? Something like Debian stable? > > > > Yep, debian stable. > > Since we had a

Re: [PATCH net-next] macvlan: Replace strncpy() by strscpy()

2019-05-27 Thread Stephen Hemminger
On Mon, 27 May 2019 16:28:05 -0500 "Gustavo A. R. Silva" wrote: > On 5/27/19 4:20 PM, Stephen Hemminger wrote: > > On Mon, 27 May 2019 13:38:55 -0500 > > "Gustavo A. R. Silva" wrote: > > > >> The strncpy() function is being deprecated. Replace it by the safer > >> strscpy() and fix the

Re: [PATCH net 4/4] net/udpgso_bench_tx: audit error queue

2019-05-27 Thread Fred Klassen
Willem, Thanks for spending so much time with me on this patch. I’m pretty new to this, so I know I am making lots of mistakes. I have been working on a v2 of the selftests in net-next, but want to review the layout of the report before I submit (see below). Also, I my v2 fix in net is still up

Re: [PATCH net-next] macvlan: Replace strncpy() by strscpy()

2019-05-27 Thread Gustavo A. R. Silva
On 5/27/19 4:20 PM, Stephen Hemminger wrote: > On Mon, 27 May 2019 13:38:55 -0500 > "Gustavo A. R. Silva" wrote: > >> The strncpy() function is being deprecated. Replace it by the safer >> strscpy() and fix the following Coverity warning: >> >> "Calling strncpy with a maximum size argument of

Re: [PATCH net-next] macvlan: Replace strncpy() by strscpy()

2019-05-27 Thread Stephen Hemminger
On Mon, 27 May 2019 13:38:55 -0500 "Gustavo A. R. Silva" wrote: > The strncpy() function is being deprecated. Replace it by the safer > strscpy() and fix the following Coverity warning: > > "Calling strncpy with a maximum size argument of 16 bytes on destination > array ifrr.ifr_ifrn.ifrn_name

<    1   2   3   4   5   6   7   8   9   >