Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

2019-05-31 Thread David Rientjes
On Fri, 31 May 2019, Michal Hocko wrote: > > The problem which this patch addresses has apparently gone unreported for > > 4+ years since > > Can we finaly stop considering the time and focus on the what is the > most reasonable behavior in general case please? Conserving mistakes > based on an

Re: [net-next v2] hinic: add LRO support

2019-05-31 Thread David Miller
From: Xue Chaojing Date: Fri, 31 May 2019 05:47:30 + > + if ((err) || (out_param)) { Too many parenthesis, just "if (err || out_param)" is fine. > @@ -51,6 +51,22 @@ static unsigned int rx_weight = 64; > module_param(rx_weight, uint, 0644); > MODULE_PARM_DESC(rx_weight, "Number Rx

Re: [PATCH v2 03/17] soc: qcom: ipa: main code

2019-05-31 Thread David Miller
From: Alex Elder Date: Thu, 30 May 2019 22:53:34 -0500 > + void *route_virt; ... > + void *filter_virt; ... If these are arrays of u64's, please declare them as "u64 *" instead of the opaque "void *".

Re: [PATCH 4.19 079/276] x86/modules: Avoid breaking W^X while loading modules

2019-05-31 Thread Nadav Amit
> On May 31, 2019, at 3:37 AM, Pavel Machek wrote: > > Hi! > >> [ Upstream commit f2c65fb3221adc6b73b0549fc7ba892022db9797 ] >> >> When modules and BPF filters are loaded, there is a time window in >> which some memory is both writable and executable. An attacker that has >> already found

Re: [RFC PATCH v2 11/12] x86/mm/tlb: Use async and inline messages for flushing

2019-05-31 Thread Andy Lutomirski
On May 31, 2019, at 2:33 PM, Nadav Amit wrote: >> On May 31, 2019, at 2:14 PM, Andy Lutomirski wrote: >> >>> On Thu, May 30, 2019 at 11:37 PM Nadav Amit wrote: >>> When we flush userspace mappings, we can defer the TLB flushes, as long >>> the following conditions are met: >>> >>> 1. No

Re: [PATCH] ext4: remove unnecessary gotos in ext4_xattr_set_entry

2019-05-31 Thread Andreas Dilger
On May 31, 2019, at 6:10 AM, Pavel Tikhomirov wrote: > > In the "out" label we only iput old/new_ea_inode-s, in all these places > these variables are always NULL so there is no point in goto to "out". > > Signed-off-by: Pavel Tikhomirov I'm not a fan of changes like this, since it adds

Re: [PATCH v2 2/5] net: qrtr: Implement outgoing flow control

2019-05-31 Thread David Miller
From: Bjorn Andersson Date: Thu, 30 May 2019 18:17:50 -0700 > + flow = radix_tree_lookup(>qrtr_tx_flow, key); > + if (flow) > + atomic_set(>pending, 0); You can't just zero out an atomic counter without extra synchronization which protects you from the increment paths. And

[PATCH -next] x86/mm: fix an unused variable "tsk" warning

2019-05-31 Thread Qian Cai
Since the commit "signal: Remove the task parameter from force_sig_fault", "tsk" is only used when MEMORY_FAILURE=y and generates a compilation warning without it. arch/x86/mm/fault.c: In function 'do_sigbus': arch/x86/mm/fault.c:1017:22: warning: unused variable 'tsk' [-Wunused-variable] Also,

Re: [PATCH] xen-netback: remove redundant assignment to err

2019-05-31 Thread David Miller
From: Colin King Date: Thu, 30 May 2019 20:04:38 +0100 > From: Colin Ian King > > The variable err is assigned with the value -ENOMEM that is never > read and it is re-assigned a new value later on. The assignment is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") >

Re: [PATCH][next] nexthop: remove redundant assignment to err

2019-05-31 Thread David Miller
From: Colin King Date: Thu, 30 May 2019 16:57:54 +0100 > From: Colin Ian King > > The variable err is initialized with a value that is never read > and err is reassigned a few statements later. This initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") >

Re: [RFC PATCH v2 11/12] x86/mm/tlb: Use async and inline messages for flushing

2019-05-31 Thread Nadav Amit
> On May 31, 2019, at 2:14 PM, Andy Lutomirski wrote: > > On Thu, May 30, 2019 at 11:37 PM Nadav Amit wrote: >> When we flush userspace mappings, we can defer the TLB flushes, as long >> the following conditions are met: >> >> 1. No tables are freed, since otherwise speculative page walks

Re: linux kernel page allocation failure and tuning of page cache

2019-05-31 Thread Alexander Duyck
On Fri, May 31, 2019 at 8:07 AM Nagal, Amit UTC CCS wrote: > > Hi > > We are using Renesas RZ/A1 processor based custom target board . linux kernel > version is 4.9.123. > > 1) the platform is low memory platform having memory 64MB. > > 2) we are doing around 45MB TCP data transfer from PC to

Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-31 Thread Andy Lutomirski
> On May 31, 2019, at 2:05 PM, Jiri Kosina wrote: > >> On Fri, 31 May 2019, Andy Lutomirski wrote: >> >> The Intel SDM Vol 3 34.10 says: >> >> If the HLT instruction is restarted, the processor will generate a >> memory access to fetch the HLT instruction (if it is >> not in the internal

Re: memory leak in sctp_send_reset_streams

2019-05-31 Thread Marcelo Ricardo Leitner
On Fri, May 31, 2019 at 02:18:06PM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: syzbot++

possible deadlock in __do_page_fault (2)

2019-05-31 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:3c09c195 Add linux-next specific files for 20190531 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=100a5f26a0 kernel config: https://syzkaller.appspot.com/x/.config?x=6cfb24468280cd5c

memory leak in sctp_send_reset_streams

2019-05-31 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:036e3431 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=153cff12a0 kernel config: https://syzkaller.appspot.com/x/.config?x=8f0f63a62bb5b13c

Re: [PATCH] PCI: PM: Avoid resuming devices in D3hot during system suspend

2019-05-31 Thread Bjorn Helgaas
On Fri, May 31, 2019 at 11:49:30AM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The current code resumes devices in D3hot during system suspend if > the target power state for them is D3cold, but that is not necessary > in general. It only is necessary to do that if the

Re: [RFC PATCH v2 11/12] x86/mm/tlb: Use async and inline messages for flushing

2019-05-31 Thread Andy Lutomirski
On Thu, May 30, 2019 at 11:37 PM Nadav Amit wrote: > > When we flush userspace mappings, we can defer the TLB flushes, as long > the following conditions are met: > > 1. No tables are freed, since otherwise speculative page walks might >cause machine-checks. > > 2. No one would access

Re: [PATCH v2 00/17] net: introduce Qualcomm IPA driver

2019-05-31 Thread Arnd Bergmann
On Fri, May 31, 2019 at 10:47 PM Alex Elder wrote: > On 5/31/19 2:19 PM, Arnd Bergmann wrote: > > On Fri, May 31, 2019 at 6:36 PM Alex Elder wrote: > >> On 5/31/19 9:58 AM, Dan Williams wrote: > >>> On Thu, 2019-05-30 at 22:53 -0500, Alex Elder wrote: > > > > Does this mean that IPA can only be

Re: [PATCH] block: fix a crash in do_task_dead()

2019-05-31 Thread Jens Axboe
On 5/30/19 2:03 AM, Peter Zijlstra wrote: > On Wed, May 29, 2019 at 04:25:26PM -0400, Qian Cai wrote: > >> Fixes: 0619317ff8ba ("block: add polled wakeup task helper") > > What is the purpose of that patch ?! The Changelog doesn't mention any > benefit or performance gain. So why not revert

Re: [PATCH] block: fix a crash in do_task_dead()

2019-05-31 Thread Jens Axboe
On 5/30/19 5:15 AM, Oleg Nesterov wrote: > On 05/29, Qian Cai wrote: >> >> The commit 0619317ff8ba ("block: add polled wakeup task helper") >> replaced wake_up_process() with blk_wake_io_task() in >> end_swap_bio_read() which triggers a crash when running heavy swapping >> workloads. >> >>

Re: [PATCH v3 00/13] epoll: support pollable epoll from userspace

2019-05-31 Thread Jens Axboe
On 5/31/19 1:45 PM, Roman Penyaev wrote: > On 2019-05-31 18:54, Jens Axboe wrote: >> On 5/31/19 10:02 AM, Roman Penyaev wrote: >>> On 2019-05-31 16:48, Jens Axboe wrote: On 5/16/19 2:57 AM, Roman Penyaev wrote: > Hi all, > > This is v3 which introduces pollable epoll from

Re: [RFC PATCH v3 00/16] Core scheduling v3

2019-05-31 Thread Julien Desfossez
> My first reaction is: when shell wakes up from sleep, it will > fork date. If the script is untagged and those workloads are > tagged and all available cores are already running workload > threads, the forked date can lose to the running workload > threads due to __prio_less() can't properly do

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-31 Thread Dan Murphy
Hello On 5/31/19 2:44 PM, Jacek Anaszewski wrote: On 5/31/19 8:23 AM, Lee Jones wrote: On Thu, 30 May 2019, Jacek Anaszewski wrote: On 5/30/19 9:38 AM, Lee Jones wrote: On Wed, 29 May 2019, Jacek Anaszewski wrote: On 5/29/19 3:58 PM, Lee Jones wrote: On Fri, 24 May 2019, Jacek Anaszewski

Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-31 Thread Jiri Kosina
On Fri, 31 May 2019, Andy Lutomirski wrote: > The Intel SDM Vol 3 34.10 says: > > If the HLT instruction is restarted, the processor will generate a > memory access to fetch the HLT instruction (if it is > not in the internal cache), and execute a HLT bus transaction. This > behavior results in

Re: [RFC PATCH v2 11/12] x86/mm/tlb: Use async and inline messages for flushing

2019-05-31 Thread Dave Hansen
On 5/31/19 1:37 PM, Andy Lutomirski wrote: >> Modulo bugs^Werrata... No. What actually happens is that a >> try-to-set-dirty-bit page table walk acts just like a TLB miss. The old >> contents of the TLB are discarded and only the in-memory contents matter >> for forward progress. If Present=0

Re: [PATCH] ARM: xor-neon: Replace __GNUC__ checks with CONFIG_CC_IS_GCC

2019-05-31 Thread Arnd Bergmann
On Fri, May 31, 2019 at 10:06 PM 'Nick Desaulniers' via Clang Built Linux wrote: > > On Fri, May 31, 2019 at 12:21 PM Arnd Bergmann wrote: > > clang, I would suggest dropping your patch then, and instead adding > > I disagree. The minimum version of gcc required to build the kernel > is 4.6, so

Re: [PATCH v5] mfd: cros_ec_dev: Register cros_ec_accel_legacy driver as a subdevice

2019-05-31 Thread Gwendal Grignou
On Fri, May 31, 2019 at 1:13 AM Lee Jones wrote: > > On Thu, 30 May 2019, Gwendal Grignou wrote: > > > On Thu, May 30, 2019 at 12:48 AM Lee Jones wrote: > > > > > > On Wed, 29 May 2019, Gwendal Grignou wrote: > > > > > > > On Wed, May 29, 2019 at 4:44 AM Lee Jones wrote: > > > > > > > > > > On

Re: [PATCH] scripts/decode_stacktrace: Accept dash/underscore in modules

2019-05-31 Thread Doug Anderson
Hi, On Fri, May 31, 2019 at 1:59 PM Evan Green wrote: > > The manpage for modprobe mentions that dashes and underscores are > treated interchangeably in module names. The stack trace dumps seem > to print module names with underscores. Use bash to replace _ with > the pattern [-_] so that file

[PATCH] scripts/decode_stacktrace: Accept dash/underscore in modules

2019-05-31 Thread Evan Green
The manpage for modprobe mentions that dashes and underscores are treated interchangeably in module names. The stack trace dumps seem to print module names with underscores. Use bash to replace _ with the pattern [-_] so that file names with dashes or underscores can be found. For example, this

Re: [GIT PULL] SMB3 Fixes

2019-05-31 Thread pr-tracker-bot
The pull request you sent on Fri, 31 May 2019 12:55:21 -0500: > git://git.samba.org/sfrench/cifs-2.6.git tags/v5.2-rc2-smb3-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/41e7231fab9d76e906b6d8abe09c44c7b9656d33 Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] nfsd bugfix for 5.2

2019-05-31 Thread pr-tracker-bot
The pull request you sent on Fri, 31 May 2019 16:39:44 -0400: > git://linux-nfs.org/~bfields/linux.git tags/nfsd-5.2-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/3ab4436f688c2d2f221793953cd05435ca84261c Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH] x86/mm: fix an unused variable "tsk" warning

2019-05-31 Thread Dave Hansen
On 5/31/19 1:38 PM, Qian Cai wrote: > --- a/arch/x86/mm/fault.c > +++ b/arch/x86/mm/fault.c > @@ -1015,7 +1015,9 @@ static inline bool bad_area_access_from_pkeys(unsigned > long error_code, > do_sigbus(struct pt_regs *regs, unsigned long error_code, unsigned long > address, > vm_fault_t

Re: [PATCH v2 00/17] net: introduce Qualcomm IPA driver

2019-05-31 Thread Alex Elder
On 5/31/19 2:19 PM, Arnd Bergmann wrote: > On Fri, May 31, 2019 at 6:36 PM Alex Elder wrote: >> On 5/31/19 9:58 AM, Dan Williams wrote: >>> On Thu, 2019-05-30 at 22:53 -0500, Alex Elder wrote: >>> >>> My question from the Nov 2018 IPA rmnet driver still stands; how does >>> this relate to

Re: [RFC PATCH v2 11/12] x86/mm/tlb: Use async and inline messages for flushing

2019-05-31 Thread Nadav Amit
> On May 31, 2019, at 1:37 PM, Andy Lutomirski wrote: > > On Fri, May 31, 2019 at 1:13 PM Dave Hansen wrote: >> On 5/31/19 12:31 PM, Nadav Amit wrote: On May 31, 2019, at 11:44 AM, Andy Lutomirski wrote: > On May 31, 2019, at 3:57 AM, Peter Zijlstra wrote: >

Re: [PATCH bpf v2] bpf, riscv: clear high 32 bits for ALU32 add/sub/neg/lsh/rsh/arsh

2019-05-31 Thread Palmer Dabbelt
On Thu, 30 May 2019 15:29:22 PDT (-0700), luke.r.n...@gmail.com wrote: In BPF, 32-bit ALU operations should zero-extend their results into the 64-bit registers. The current BPF JIT on RISC-V emits incorrect instructions that perform sign extension only (e.g., addw, subw) on 32-bit add, sub,

Re: [PATCH 2/2] PCI: Create device link for NVIDIA GPU

2019-05-31 Thread Bjorn Helgaas
[+cc Lukas, author of 07f4f97d7b4b ("vga_switcheroo: Use device link for HDA controller")] On Fri, May 31, 2019 at 10:31:09AM +0530, Abhishek Sahu wrote: > NVIDIA Turing GPUs include hardware support for USB Type-C and > VirtualLink. It helps in delivering the power, display, and data > required

[GIT PULL] nfsd bugfix for 5.2

2019-05-31 Thread J. Bruce Fields
Please pull: git://linux-nfs.org/~bfields/linux.git tags/nfsd-5.2-1 This reverts a minor fix which could cause us to treat conflicting NLM locks as nonconflicting. We have proper fix queued up for 5.3. In the meantime, a quick revert seems best for 5.2 and stable. --b. Benjamin Coddington

[PATCH] x86/mm: fix an unused variable "tsk" warning

2019-05-31 Thread Qian Cai
"tsk" is only used when MEMORY_FAILURE=y. arch/x86/mm/fault.c: In function 'do_sigbus': arch/x86/mm/fault.c:1017:22: warning: unused variable 'tsk' [-Wunused-variable] Signed-off-by: Qian Cai --- arch/x86/mm/fault.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/mm/fault.c

Re: [PATCH v1 1/2] fork: add clone3

2019-05-31 Thread Linus Torvalds
On Wed, May 29, 2019 at 3:24 PM Andrei Vagin wrote: > > Thank you for thinking about time namespaces. I looked at this patch > quickly and I would suggest to move a termination signal out of flags. I > think we can add a separate field (exit_signal) into clone_args. Does it > make sense? For me,

Re: [RFC PATCH v2 11/12] x86/mm/tlb: Use async and inline messages for flushing

2019-05-31 Thread Jann Horn
On Fri, May 31, 2019 at 10:04 PM Nadav Amit wrote: > > On May 31, 2019, at 12:20 PM, Jann Horn wrote: > > On Fri, May 31, 2019 at 8:29 PM Nadav Amit wrote: > >> [ +Jann Horn ] > >> > >>> On May 31, 2019, at 3:57 AM, Peter Zijlstra wrote: > >>> > >>> On Thu, May 30, 2019 at 11:36:44PM -0700,

Re: [RFC PATCH v2 11/12] x86/mm/tlb: Use async and inline messages for flushing

2019-05-31 Thread Andy Lutomirski
On Fri, May 31, 2019 at 1:13 PM Dave Hansen wrote: > > On 5/31/19 12:31 PM, Nadav Amit wrote: > >> On May 31, 2019, at 11:44 AM, Andy Lutomirski wrote: > >> > >> > >> > >>> On May 31, 2019, at 3:57 AM, Peter Zijlstra wrote: > >>> > On Thu, May 30, 2019 at 11:36:44PM -0700, Nadav Amit

Re: [PATCH] RISC-V: defconfig: Enable NO_HZ_IDLE and HIGH_RES_TIMERS

2019-05-31 Thread Palmer Dabbelt
On Wed, 29 May 2019 01:00:35 PDT (-0700), sch...@suse.de wrote: On Mai 28 2019, Palmer Dabbelt wrote: My only issue here is testing: IIRC last time we tried this it ended up causing trouble. I've been running kernels with these settings since the beginning, and never seen any trouble. OK,

Re: security/loadpin: Allow to exclude specific file types

2019-05-31 Thread Kees Cook
On Fri, May 31, 2019 at 11:03:17AM -0700, Ke Wu wrote: > I think Coverity is correct. Note that it's the size of > kernel_read_file_str (rather than exclude_read_files) doesn't equal to > ignore_read_file_id. > > This is because READING_MAX_ID is also an element in > kernel_read_file_str, which

Re: [PATCH v3 0/8] NVIDIA Tegra clocksource driver improvements

2019-05-31 Thread Daniel Lezcano
On 31/05/2019 14:33, Dmitry Osipenko wrote: > 31.05.2019 11:26, Peter De Schrijver пишет: >> On Fri, May 24, 2019 at 06:32:45PM +0300, Dmitry Osipenko wrote: >>> Hello, >>> >>> This series primarily unifies the driver code across all Tegra SoC >>> generations. In a result the clocksources are

Re: [PATCH] ARM: xor-neon: Replace __GNUC__ checks with CONFIG_CC_IS_GCC

2019-05-31 Thread Nathan Chancellor
On Fri, May 31, 2019 at 01:06:13PM -0700, Nick Desaulniers wrote: > On Fri, May 31, 2019 at 12:21 PM Arnd Bergmann wrote: > > clang, I would suggest dropping your patch then, and instead adding > > I disagree. The minimum version of gcc required to build the kernel > is 4.6, so the comment

[PATCH v2] arm64: dts: rockchip: Add missing configuration pwr amd rst for PCIe

2019-05-31 Thread Anand Moon
This patch add missing PCIe gpio pin (#PCIE_PWR) for vcc3v3_pcie power regulator node also add missing reset pinctrl (#PCIE_PERST_L) for PCIe node. Signed-off-by: Anand Moon --- using schematics: thanks for suggested by Manivannan [1]

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Vivien Didelot
On Fri, 31 May 2019 10:35:14 +0300, Nikita Yushchenko wrote: > When non-bridged, non-vlan'ed mv88e6xxx port is moving down, error > message is logged: > > failed to kill vid 0081/0 for device eth_cu_1000_4 > > This is caused by call from __vlan_vid_del() with vin set to zero, over > call chain

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Vivien Didelot
Hi Florian, On Fri, 31 May 2019 09:34:03 -0700, Florian Fainelli wrote: > On 5/31/19 7:37 AM, Andrew Lunn wrote: > >> I'm not sure that I like the semantic of it, because the driver can > >> actually > >> support VID 0 per-se, only the kernel does not use VLAN 0. Thus I would > >> avoid > >>

Re: [PATCH v5 2/3] thermal: cpu_cooling: Make the power-related code depend on IPA

2019-05-31 Thread Daniel Lezcano
On 30/05/2019 11:20, Quentin Perret wrote: > The core CPU cooling infrastructure has power-related functions > that have only one client: IPA. Since there can be no user of those > functions if IPA is not compiled in, make sure to guard them with > checks on CONFIG_THERMAL_GOV_POWER_ALLOCATOR to

Re: [RFC PATCH v2 11/12] x86/mm/tlb: Use async and inline messages for flushing

2019-05-31 Thread Dave Hansen
On 5/31/19 12:31 PM, Nadav Amit wrote: >> On May 31, 2019, at 11:44 AM, Andy Lutomirski wrote: >> >> >> >>> On May 31, 2019, at 3:57 AM, Peter Zijlstra wrote: >>> On Thu, May 30, 2019 at 11:36:44PM -0700, Nadav Amit wrote: When we flush userspace mappings, we can defer the TLB flushes,

[PATCH v2] dt-bindings: iio: accel: adxl372: switch to YAML bindings

2019-05-31 Thread Lucas Oshiro
Convert the old device tree documentation to yaml format. Signed-off-by: Lucas Oshiro Signed-off-by: Rodrigo Ribeiro Co-developed-by: Rodrigo Ribeiro Reviewed-by: Matheus Tavares Reviewed-by: Marcelo Schmitt --- V2: - Update MAINTAINERS file - Remove description field for reg and

Re: [PATCH] dt-bindings: iio: accel: adxl372: switch to YAML bindings

2019-05-31 Thread Lucas Oshiro
Thanks, Alexandru. We're going to send a new version for this patch. On 20/05/2019 07:46, Alexandru Ardelean wrote: On Sun, May 19, 2019 at 8:27 PM Jonathan Cameron wrote: On Sat, 18 May 2019 18:55:42 -0300 Lucas Oshiro wrote: Convert the old device tree documentation to yaml format.

Re: [PATCH] ARM: xor-neon: Replace __GNUC__ checks with CONFIG_CC_IS_GCC

2019-05-31 Thread Nick Desaulniers
On Fri, May 31, 2019 at 12:21 PM Arnd Bergmann wrote: > clang, I would suggest dropping your patch then, and instead adding I disagree. The minimum version of gcc required to build the kernel is 4.6, so the comment about older versions of gcc is irrelevant and should be removed. Nathan's

[PATCH] usb: dwc2: host: Fix wMaxPacketSize handling (fix webcam regression)

2019-05-31 Thread Douglas Anderson
In commit abb621844f6a ("usb: ch9: make usb_endpoint_maxp() return only packet size") the API to usb_endpoint_maxp() changed. It used to just return wMaxPacketSize but after that commit it returned wMaxPacketSize with the high bits (the multiplier) masked off. If you wanted to get the multiplier

Re: [RFC PATCH v2 11/12] x86/mm/tlb: Use async and inline messages for flushing

2019-05-31 Thread Nadav Amit
> On May 31, 2019, at 12:20 PM, Jann Horn wrote: > > On Fri, May 31, 2019 at 8:29 PM Nadav Amit wrote: >> [ +Jann Horn ] >> >>> On May 31, 2019, at 3:57 AM, Peter Zijlstra wrote: >>> >>> On Thu, May 30, 2019 at 11:36:44PM -0700, Nadav Amit wrote: When we flush userspace mappings, we can

Re: [PATCH v1] KVM: x86: PMU Whitelist

2019-05-31 Thread Eric Hankland
On Thu, May 30, 2019 at 5:57 PM Wei Wang wrote: > > On 05/30/2019 01:11 AM, Eric Hankland wrote: > > On Wed, May 29, 2019 at 12:49 AM Wei Wang wrote: > >> On 05/29/2019 02:14 AM, Eric Hankland wrote: > >>> On Mon, May 27, 2019 at 6:56 PM Wei Wang wrote: > On 05/23/2019 06:23 AM, Eric

Re: [PATCH 3/5] asm-generic: Register fchmodat4 as syscall 428

2019-05-31 Thread Arnd Bergmann
On Fri, May 31, 2019 at 9:23 PM Palmer Dabbelt wrote: > > Signed-off-by: Palmer Dabbelt As usual, each patch needs a changelog text. I would prefer having a single patch here that changes /all/ system call tables at once, rather than doing one at a time like we used to. In linux-next, we are

Re: [PATCH V2 04/12] clk: tegra: add support for peripheral clock suspend and resume

2019-05-31 Thread Sowjanya Komatineni
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1559332560; bh=fyUgksf15TgB7D/+ZMOAO7M7CVG31MW/WSQCDBy4pVQ=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:

Re: [PATCH V2 03/12] clk: tegra: save and restore PLLs state for system

2019-05-31 Thread Sowjanya Komatineni
On 5/29/19 4:28 PM, Stephen Boyd wrote: Quoting Sowjanya Komatineni (2019-05-28 16:08:47) This patch has implementation of saving and restoring PLL's state to support system suspend and resume operations. Can you provide some more background on _why_ this patch should exist? That's typically

Re: [PATCH] x86/kgdb: return 0 from kgdb_arch_set_breakpoint

2019-05-31 Thread Nadav Amit
> On May 31, 2019, at 12:47 PM, Matt Mullins wrote: > > err must be nonzero in order to reach text_poke(), which caused kgdb to > fail to set breakpoints: > > (gdb) break __x64_sys_sync > Breakpoint 1 at 0x81288910: file ../fs/sync.c, line 124. > (gdb) c >

Re: [PATCH 2/5] Add fchmodat4(), a new syscall

2019-05-31 Thread Arnd Bergmann
On Fri, May 31, 2019 at 9:23 PM Palmer Dabbelt wrote: > > man 3p says that fchmodat() takes a flags argument, but the Linux > syscall does not. There doesn't appear to be a good userspace > workaround for this issue but the implementation in the kernel is pretty > straight-forward. The specific

[PATCH] x86/kgdb: return 0 from kgdb_arch_set_breakpoint

2019-05-31 Thread Matt Mullins
err must be nonzero in order to reach text_poke(), which caused kgdb to fail to set breakpoints: (gdb) break __x64_sys_sync Breakpoint 1 at 0x81288910: file ../fs/sync.c, line 124. (gdb) c Continuing. Warning: Cannot insert breakpoint 1.

Re: [RFC PATCH v2 04/12] x86/mm/tlb: Flush remote and local TLBs concurrently

2019-05-31 Thread Nadav Amit
> On May 31, 2019, at 4:48 AM, Juergen Gross wrote: > > On 31/05/2019 08:36, Nadav Amit wrote: >> >> --- a/arch/x86/include/asm/paravirt_types.h >> +++ b/arch/x86/include/asm/paravirt_types.h >> @@ -211,6 +211,12 @@ struct pv_mmu_ops { >> void (*flush_tlb_user)(void); >> void

Re: [PATCH v3 00/13] epoll: support pollable epoll from userspace

2019-05-31 Thread Roman Penyaev
On 2019-05-31 18:54, Jens Axboe wrote: On 5/31/19 10:02 AM, Roman Penyaev wrote: On 2019-05-31 16:48, Jens Axboe wrote: On 5/16/19 2:57 AM, Roman Penyaev wrote: Hi all, This is v3 which introduces pollable epoll from userspace. v3: - Measurements made, represented below. - Fix

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-31 Thread Jacek Anaszewski
On 5/31/19 8:23 AM, Lee Jones wrote: On Thu, 30 May 2019, Jacek Anaszewski wrote: On 5/30/19 9:38 AM, Lee Jones wrote: On Wed, 29 May 2019, Jacek Anaszewski wrote: On 5/29/19 3:58 PM, Lee Jones wrote: On Fri, 24 May 2019, Jacek Anaszewski wrote: Hi, On 5/23/19 9:09 PM, Dan Murphy wrote:

[PATCH] dmaengine: dmatest: timeout value of -1 should specify infinite wait

2019-05-31 Thread Hook, Gary
The dmatest module parameter 'timeout' is documented as accepting a -1 to mean "infinite timeout". Change the parameter to to signed integer, and check the value to call the appropriate wait_event() function. Signed-off-by: Gary R Hook --- drivers/dma/dmatest.c | 11 --- 1 file

Re: [RFC PATCH v2 08/12] x86/tlb: Privatize cpu_tlbstate

2019-05-31 Thread Nadav Amit
> On May 31, 2019, at 11:48 AM, Andy Lutomirski wrote: > > >> On May 30, 2019, at 11:36 PM, Nadav Amit wrote: >> >> cpu_tlbstate is mostly private and only the variable is_lazy is shared. >> This causes some false-sharing when TLB flushes are performed. >> >> Break cpu_tlbstate intro

Re: [PATCH] rtlwifi: remove redundant assignment to variable k

2019-05-31 Thread Joe Perches
On Fri, 2019-05-31 at 12:29 -0500, Larry Finger wrote: > On 5/31/19 9:14 AM, Colin King wrote: > > From: Colin Ian King > > > > The assignment of 0 to variable k is never read once we break out of > > the loop, so the assignment is redundant and can be removed. > > > > Addresses-Coverity:

Re: [PATCH 3/3] livepatch: Use static buffer for debugging messages under rq lock

2019-05-31 Thread Josh Poimboeuf
On Fri, May 31, 2019 at 09:41:47AM +0200, Petr Mladek wrote: > The err_buf array uses 128 bytes of stack space. Move it off the stack > by making it static. It's safe to use a shared buffer because > klp_try_switch_task() is called under klp_mutex. > > Signed-off-by: Petr Mladek > Acked-by:

Re: [PATCH] ptrace: restore smp_rmb() in __ptrace_may_access()

2019-05-31 Thread Jann Horn
On Fri, May 31, 2019 at 3:35 PM Oleg Nesterov wrote: > On 05/31, Jann Horn wrote: > > > > So I guess I should make a v2 that still adds the smp_rmb() in > > __ptrace_may_access(), but gets rid of the smp_wmb() in > > commit_creds()? (With a comment above the rcu_assign_pointer() that > > explains

Re: [PATCH 2/3] livepatch: Remove duplicate warning about missing reliable stacktrace support

2019-05-31 Thread Josh Poimboeuf
On Fri, May 31, 2019 at 02:32:34PM +0200, Miroslav Benes wrote: > On Fri, 31 May 2019, Petr Mladek wrote: > > > WARN_ON_ONCE() could not be called safely under rq lock because > > of console deadlock issues. > > > > It can be simply removed. A better descriptive message is written > > in

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Florian Fainelli
On 5/31/19 11:19 AM, Vivien Didelot wrote: > Hi Florian, > > On Fri, 31 May 2019 09:36:13 -0700, Florian Fainelli > wrote: >>> But VID 0 has a special meaning for the kernel, it means the port's private >>> database (when it is isolated, non-bridged), it is not meant to be >>> programmed >>>

Re: [RFC PATCH v2 11/12] x86/mm/tlb: Use async and inline messages for flushing

2019-05-31 Thread Nadav Amit
> On May 31, 2019, at 11:44 AM, Andy Lutomirski wrote: > > > >> On May 31, 2019, at 3:57 AM, Peter Zijlstra wrote: >> >>> On Thu, May 30, 2019 at 11:36:44PM -0700, Nadav Amit wrote: >>> When we flush userspace mappings, we can defer the TLB flushes, as long >>> the following conditions are

Re: [ANNOUNCE] v5.0.19-rt11

2019-05-31 Thread Sebastian Andrzej Siewior
On 2019-05-29 23:26:38 [+0200], To Thomas Gleixner wrote: > Dear RT folks! > > I'm pleased to announce the v5.0.19-rt11 patch set. > > Changes since v5.0.19-rt10: > > - Ignore a warning from lockdep when lockdep is disabled for different > lock types. > > - Make the cpuidle an imx6

Re: linux kernel page allocation failure and tuning of page cache

2019-05-31 Thread Matthew Wilcox
> 1) the platform is low memory platform having memory 64MB. > > 2) we are doing around 45MB TCP data transfer from PC to target using netcat > utility .On Target , a process receives data over socket and writes the data > to flash disk . I think your network is faster than your disk ... >

Re: [PATCH REBASED] mm, memcg: Make scan aggression always exclude protection

2019-05-31 Thread Chris Down
Michal Hocko writes: On Thu 30-05-19 13:52:10, Chris Down wrote: Michal Hocko writes: > On Wed 29-05-19 23:44:53, Chris Down wrote: > > Michal Hocko writes: > > > Maybe I am missing something so correct me if I am wrong but the new > > > calculation actually means that we always allow to scan

Re: [PATCH 1/3] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()

2019-05-31 Thread Josh Poimboeuf
On Fri, May 31, 2019 at 02:25:15PM +0200, Miroslav Benes wrote: > On Fri, 31 May 2019, Petr Mladek wrote: > > > WARN_ONCE() in the generic save_stack_trace_tsk_reliable() is superfluous. > > > > The information is passed also via the return value. The only current > > user klp_check_stack()

[PATCH] KVM: irqchip: Use struct_size() in kzalloc()

2019-05-31 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; struct boo entry[]; }; instance = kzalloc(sizeof(struct

[PATCH 2/5] Add fchmodat4(), a new syscall

2019-05-31 Thread Palmer Dabbelt
man 3p says that fchmodat() takes a flags argument, but the Linux syscall does not. There doesn't appear to be a good userspace workaround for this issue but the implementation in the kernel is pretty straight-forward. The specific use case where the missing flags came up was WRT a fuse

[PATCH 3/5] asm-generic: Register fchmodat4 as syscall 428

2019-05-31 Thread Palmer Dabbelt
Signed-off-by: Palmer Dabbelt --- include/uapi/asm-generic/unistd.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h index dee7292e1df6..f0f4cad4c416 100644 --- a/include/uapi/asm-generic/unistd.h +++

Add a new fchmodat4() syscall

2019-05-31 Thread Palmer Dabbelt
I spent half of dinner last night being complained to by one of our hardware engineers about Linux's lack of support for the flags argument to fchmodat(). This all came about because of a FUSE filesystem implementation, and while there are some application-specific workarounds for the issue it

[PATCH 1/5] Non-functional cleanup of a "__user * filename"

2019-05-31 Thread Palmer Dabbelt
The next patch defines a very similar interface, which I copied from this definition. Since I'm touching it anyway I don't see any reason not to just go fix this one up. Signed-off-by: Palmer Dabbelt --- include/linux/syscalls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 5/5] x86: Add fchmod4 to syscall_32.tbl

2019-05-31 Thread Palmer Dabbelt
Signed-off-by: Palmer Dabbelt --- arch/x86/entry/syscalls/syscall_32.tbl | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl index 1f9607ed087c..319c7a6d3f02 100644 --- a/arch/x86/entry/syscalls/syscall_32.tbl +++

[PATCH 4/5] x86: Add fchmodat4 to syscall_64.tbl

2019-05-31 Thread Palmer Dabbelt
Signed-off-by: Palmer Dabbelt --- arch/x86/entry/syscalls/syscall_64.tbl | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/entry/syscalls/syscall_64.tbl b/arch/x86/entry/syscalls/syscall_64.tbl index 92ee0b4378d4..998aa3eb09e2 100644 --- a/arch/x86/entry/syscalls/syscall_64.tbl +++

Re: [PATCH] ARM: xor-neon: Replace __GNUC__ checks with CONFIG_CC_IS_GCC

2019-05-31 Thread Arnd Bergmann
On Fri, May 31, 2019 at 8:32 PM Nathan Chancellor wrote: > > On Fri, May 31, 2019 at 10:05:22AM +0200, Arnd Bergmann wrote: > > If I remember correctly, we also had the same issue with older versions > > of clang, possibly even newer ones. Shouldn't we check for a minimum > > compiler version

Re: [RFC PATCH v2 11/12] x86/mm/tlb: Use async and inline messages for flushing

2019-05-31 Thread Jann Horn
On Fri, May 31, 2019 at 8:29 PM Nadav Amit wrote: > > [ +Jann Horn ] > > > On May 31, 2019, at 3:57 AM, Peter Zijlstra wrote: > > > > On Thu, May 30, 2019 at 11:36:44PM -0700, Nadav Amit wrote: > >> When we flush userspace mappings, we can defer the TLB flushes, as long > >> the following

Re: [PATCH v2 00/17] net: introduce Qualcomm IPA driver

2019-05-31 Thread Arnd Bergmann
On Fri, May 31, 2019 at 6:36 PM Alex Elder wrote: > On 5/31/19 9:58 AM, Dan Williams wrote: > > On Thu, 2019-05-30 at 22:53 -0500, Alex Elder wrote: > > > > My question from the Nov 2018 IPA rmnet driver still stands; how does > > this relate to net/ethernet/qualcomm/rmnet/ if at all? And if this

Re: [PATCH -mm] mm, swap: Fix bad swap file entry warning

2019-05-31 Thread Qian Cai
On Fri, 2019-05-31 at 11:27 -0700, Dexuan-Linux Cui wrote: > Hi, > Did you know about the panic reported here: > https://marc.info/?t=15593077303=1=2 > > "Kernel panic - not syncing: stack-protector: Kernel stack is > corrupted in: write_irq_affinity.isra" > > This panic is reported on

Re: [PATCH] livepatch: Fix ftrace module text permissions race

2019-05-31 Thread Josh Poimboeuf
On Thu, May 30, 2019 at 03:54:14PM +0200, Petr Mladek wrote: > On Wed 2019-05-29 14:02:24, Josh Poimboeuf wrote: > > The above panic occurs when loading two modules at the same time with > > ftrace enabled, where at least one of the modules is a livepatch module: > > > > CPU0

Re: [PATCH 2/3] arm64: dts: freescale: Add i.MX8MN dtsi support

2019-05-31 Thread Andrey Smirnov
On Thu, May 30, 2019 at 2:45 AM wrote: > > From: Anson Huang > > The i.MX8M Nano Media Applications Processor is a new SoC of the i.MX8M > family, it is a 14nm FinFET product of the growing mScale family targeting > the consumer market. It is built in Samsung 14LPP to achieve both high >

Re: [PATCH v3 06/13] epoll: introduce helpers for adding/removing events to uring

2019-05-31 Thread Roman Penyaev
On 2019-05-31 18:51, Peter Zijlstra wrote: On Fri, May 31, 2019 at 04:21:30PM +0200, Roman Penyaev wrote: The ep_add_event_to_uring() is lockless, thus I can't increase tail after, I need to reserve the index slot, where to write to. I can use shadow tail, which is not seen by userspace, but

Re: [PATCH v2 2/2] KVM: LAPIC: remove the trailing newline used in the fmt parameter of TP_printk

2019-05-31 Thread Joe Perches
On Fri, 2019-05-31 at 14:40 +0800, Wanpeng Li wrote: > The trailing newlines will lead to extra newlines in the trace file [] > diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h [] > @@ -1365,7 +1365,7 @@ TRACE_EVENT(kvm_hv_timer_state, > __entry->vcpu_id = vcpu_id; >

[PATCH] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-05-31 Thread Nathan Chancellor
clang warns: drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case IBMVSCSI_HOST_ACTION_NONE: ^ drivers/scsi/ibmvscsi/ibmvscsi.c:2151:6: note: uninitialized

Re: [PATCH REPOST v8 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC.

2019-05-31 Thread Andrew Lunn
On Sat, Jun 01, 2019 at 12:00:23AM +0530, Sagar Shrikant Kadam wrote: > The i2c-ocore driver already has a polling mode interface.But it needs > a workaround for FU540 Chipset on HiFive unleashed board (RevA00). > There is an erratum in FU540 chip that prevents interrupt driven i2c > transfers

Re: [PATCH v3 00/13] epoll: support pollable epoll from userspace

2019-05-31 Thread Roman Penyaev
On 2019-05-31 18:33, Peter Zijlstra wrote: On Thu, May 16, 2019 at 10:57:57AM +0200, Roman Penyaev wrote: When new event comes for some epoll item kernel does the following: struct epoll_uitem *uitem; /* Each item has a bit (index in user items array), discussed later */ uitem =

Re: [RFC PATCH v2 08/12] x86/tlb: Privatize cpu_tlbstate

2019-05-31 Thread Andy Lutomirski
> On May 30, 2019, at 11:36 PM, Nadav Amit wrote: > > cpu_tlbstate is mostly private and only the variable is_lazy is shared. > This causes some false-sharing when TLB flushes are performed. > > Break cpu_tlbstate intro cpu_tlbstate and cpu_tlbstate_shared, and mark > each one accordingly. >

Re: [alsa-devel] [PATCH] ASoC: SOF: Intel: hda: Fix COMPILE_TEST build error

2019-05-31 Thread Pierre-Louis Bossart
On 5/31/19 9:34 AM, Takashi Iwai wrote: On Fri, 31 May 2019 16:25:26 +0200, YueHaibing wrote: while building without PCI: sound/soc/sof/intel/hda.o: In function `hda_dsp_probe': hda.c:(.text+0x79c): undefined reference to `pci_ioremap_bar' hda.c:(.text+0x79c): relocation truncated to fit:

Re: [RFC PATCH v2 11/12] x86/mm/tlb: Use async and inline messages for flushing

2019-05-31 Thread Andy Lutomirski
> On May 31, 2019, at 3:57 AM, Peter Zijlstra wrote: > >> On Thu, May 30, 2019 at 11:36:44PM -0700, Nadav Amit wrote: >> When we flush userspace mappings, we can defer the TLB flushes, as long >> the following conditions are met: >> >> 1. No tables are freed, since otherwise speculative page

Re: [PATCH][next] nexthop: remove redundant assignment to err

2019-05-31 Thread David Ahern
On 5/30/19 9:57 AM, Colin King wrote: > From: Colin Ian King > > The variable err is initialized with a value that is never read > and err is reassigned a few statements later. This initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin

<    1   2   3   4   5   6   7   8   9   >