RE: [PATCH v2] let proc net directory inodes reflect to active net namespace

2019-07-05 Thread Hallsmark, Per
Hello Alexey, Sounds excellent! Could you please drop a notifier of such? For our usecase, the ipv6 is statically linked (=y) and then this happens way before userland starts (thus no access to procfs) so I believe we should be able to continue as is until we can replace with your proper

[PATCH] net: hisilicon: Add an tx_desc to adapt HI13X1_GMAC

2019-07-05 Thread Jiangfeng Xiao
HI13X1 changed the offsets and bitmaps for tx_desc registers in the same peripheral device on different models of the hip04_eth. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-)

[PATCH 01/10] net: hisilicon: Add support for HI13X1 to hip04_eth

2019-07-05 Thread Jiangfeng Xiao
Extend the hip04_eth driver to support HI13X1_GMAC. Enable it with CONFIG_HI13X1_GMAC option. HI13X1 changed the offsets and bitmaps for registers in the same peripheral device on different models of the hip04_eth. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/Kconfig |

[PATCH 02/10] net: hisilicon: Cleanup for got restricted __be32

2019-07-05 Thread Jiangfeng Xiao
This patch fixes the following warning from sparse: hip04_eth.c:468:25: warning: incorrect type in assignment hip04_eth.c:468:25:expected unsigned int [usertype] send_addr hip04_eth.c:468:25:got restricted __be32 [usertype] hip04_eth.c:469:25: warning: incorrect type in assignment

[PATCH 03/10] net: hisilicon: Cleanup for cast to restricted __be32

2019-07-05 Thread Jiangfeng Xiao
This patch fixes the following warning from sparse: hip04_eth.c:533:23: warning: cast to restricted __be16 hip04_eth.c:533:23: warning: cast to restricted __be16 hip04_eth.c:533:23: warning: cast to restricted __be16 hip04_eth.c:533:23: warning: cast to restricted __be16 hip04_eth.c:534:23:

[PATCH 04/10] net: hisilicon: HI13X1_GMAX skip write LOCAL_PAGE_REG

2019-07-05 Thread Jiangfeng Xiao
HI13X1_GMAC changed the offsets and bitmaps for GE_TX_LOCAL_PAGE_REG registers in the same peripheral device on different models of the hip04_eth. With the default configuration, HI13X1_GMAC can also work without any writes to the GE_TX_LOCAL_PAGE_REG register. Signed-off-by: Jiangfeng Xiao ---

[PATCH 05/10] net: hisilicon: HI13X1_GMAX need dreq reset at first

2019-07-05 Thread Jiangfeng Xiao
HI13X1_GMAC delete request for soft reset at first, otherwise, the subsequent initialization will not take effect. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 24 1 file changed, 24 insertions(+) diff --git

[PATCH 06/10] net: hisilicon: dt-bindings: Add an field of port-handle

2019-07-05 Thread Jiangfeng Xiao
In general, group is the same as the port, but some boards specify a special group for better load balancing of each processing unit. Signed-off-by: Jiangfeng Xiao --- Documentation/devicetree/bindings/net/hisilicon-hip04-net.txt | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[PATCH 07/10] net: hisilicon: Add group field to adapt HI13X1_GMAC

2019-07-05 Thread Jiangfeng Xiao
In general, group is the same as the port, but some boards specify a special group for better load balancing of each processing unit. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH] mm/isolate: Drop pre-validating migrate type in undo_isolate_page_range()

2019-07-05 Thread Anshuman Khandual
unset_migratetype_isolate() already validates under zone lock that a given page has already been isolated as MIGRATE_ISOLATE. There is no need for another check before. Hence just drop this redundant validation. Cc: Oscar Salvador Cc: Michal Hocko Cc: Qian Cai Cc: Andrew Morton Cc:

[PATCH 10/10] net: hisilicon: Add an tx_desc to adapt HI13X1_GMAC

2019-07-05 Thread Jiangfeng Xiao
HI13X1 changed the offsets and bitmaps for tx_desc registers in the same peripheral device on different models of the hip04_eth. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-)

[PATCH 08/10] net: hisilicon: Offset buf address to adapt HI13X1_GMAC

2019-07-05 Thread Jiangfeng Xiao
The buf unit size of HI13X1_GMAC is cache_line_size, which is 64, so the address we write to the buf register needs to be shifted right by 6 bits. The 31st bit of the PPE_CFG_CPU_ADD_ADDR register of HI13X1_GMAC indicates whether to release the buffer of the message, and the low indicates that it

[PATCH 09/10] net: hisilicon: Add an rx_desc to adapt HI13X1_GMAC

2019-07-05 Thread Jiangfeng Xiao
HI13X1 changed the offsets and bitmaps for rx_desc registers in the same peripheral device on different models of the hip04_eth. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-07-05 Thread Sameer Pujar
Hi Vinod, What are your final thoughts regarding this? Thanks, Sameer. Where does ADMAIF driver reside in kernel, who configures it for normal dma txns..? Not yet, we are in the process of upstreaming ADMAIF driver. To describe briefly, audio subsystem is using ALSA SoC(ASoC) layer. ADMAIF

Re: [PATCH] sound: pci: asihpi: Remove unneeded variable change

2019-07-05 Thread Takashi Iwai
On Fri, 05 Jul 2019 04:57:33 +0200, Hariprasad Kelam wrote: > > this patch fixes below issue reported by coccicheck > sound/pci/asihpi/asihpi.c:1558:5-11: Unneeded variable: "change". Return > "1" on line 1564 > > Signed-off-by: Hariprasad Kelam Applied, thanks. Takashi

Re: [PATCH bpf-next] Enable zext optimization for more RV64G ALU ops

2019-07-05 Thread Björn Töpel
On Fri, 5 Jul 2019 at 02:18, Luke Nelson wrote: > > commit 66d0d5a854a6 ("riscv: bpf: eliminate zero extension code-gen") > added the new zero-extension optimization for some BPF ALU operations. > > Since then, bugs in the JIT that have been fixed in the bpf tree require > this optimization to be

Re: [PATCH] dmaengine: tegra210-adma: remove PM_CLK dependency

2019-07-05 Thread Vinod Koul
On 20-06-19, 17:02, Jon Hunter wrote: > > On 20/06/2019 16:54, Sameer Pujar wrote: > > Tegra ADMA does not use pm-clk interface now and hence the dependency > > is removed from Kconfig. Applied, thanks -- ~Vinod

RE: [PATCH v1 net-next] net: stmmac: enable clause 45 mdio support

2019-07-05 Thread Voon, Weifeng
> > If the community prefers readability > > Readability nearly always comes first. There is nothing performance > critical here, MDIO is a slow bus. So the code should be readable, > simple to understand. > Noted and thanks for the comments. > > , I will suggest to do the c45 setup in > >

Re: [PATCH bpf] xdp: fix possible cq entry leak

2019-07-05 Thread Björn Töpel
On Thu, 4 Jul 2019 at 16:25, Ilya Maximets wrote: > > Completion queue address reservation could not be undone. > In case of bad 'queue_id' or skb allocation failure, reserved entry > will be leaked reducing the total capacity of completion queue. > > Fix that by moving reservation to the point

Re: [PATCH v2 1/2] Bluetooth: Disable LE Advertising in hci_suspend_dev()

2019-07-05 Thread Kai-Heng Feng
at 11:00, Kai Heng Feng wrote: Hi Marcel, at 5:25 PM, Kai-Heng Feng wrote: LE Advertising may wake up system during system-wide sleep, disable it to prevent this issue from happening. Do the reverse in hci_resume_dev(). Do you have any suggestion for this patch? Please let me know

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-05 Thread Abel Vesa
On 19-07-05 12:56:11, anson.hu...@nxp.com wrote: > From: Anson Huang > > IMX8MQ_CLK_TMU_ROOT is ONLY used for thermal module, the driver > should manage this clock, so no need to have CLK_IS_CRITICAL flag > set. > > Signed-off-by: Anson Huang Reviewed-by: Abel Vesa > --- >

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-07-05 Thread Kai-Heng Feng
at 19:57, Bjorn Helgaas wrote: On Mon, May 27, 2019 at 11:57:47AM -0500, Bjorn Helgaas wrote: On Thu, May 23, 2019 at 12:39:23PM +0800, Kai-Heng Feng wrote: at 04:52, Bjorn Helgaas wrote: On Wed, May 22, 2019 at 02:39:56PM -0400, Alan Stern wrote: On Wed, 22 May 2019, Bjorn Helgaas wrote:

Re: [PATCH V2 2/2] ASoC: fsl_esai: recover the channel swap after xrun

2019-07-05 Thread S.j. Wang
> > > + > > + /* restore registers by regcache_sync */ > > + fsl_esai_register_restore(esai_priv); > > + > > + regmap_update_bits(esai_priv->regmap, REG_ESAI_TCR, > > +ESAI_xCR_xPR_MASK, 0); > > + regmap_update_bits(esai_priv->regmap, REG_ESAI_RCR, > > +

Re: [PATCH 1/2] scsi_host: add support for request batching

2019-07-05 Thread Hannes Reinecke
On 7/4/19 3:19 PM, Paolo Bonzini wrote: > On 19/06/19 12:31, Paolo Bonzini wrote: >>> I'm a bit unsure if 'bd->last' is always set; it's quite obvious that >>> it's present if set, but what about requests with 'bd->last == false' ? >>> Is there a guarantee that they will _always_ be followed with

Re: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: correct the fuse word index

2019-07-05 Thread Lothar Waßmann
Hi, On Fri, 5 Jul 2019 02:46:32 + Andy Duan wrote: > From: Andy Duan Sent: Friday, July 5, 2019 12:08 AM > > From: Lothar Waßmann Sent: Thursday, July 4, > > 2019 11:46 PM > > > Hi, > > > > > > On Thu, 4 Jul 2019 22:20:15 +0800 fugang.d...@nxp.com wrote: > > > > From: Fugang Duan > > >

Re: [PATCH 0/2] scsi: add support for request batching

2019-07-05 Thread Hannes Reinecke
On 6/27/19 10:17 AM, Paolo Bonzini wrote: > On 27/06/19 05:37, Martin K. Petersen wrote: >>> Ping? Are there any more objections? >> It's a core change so we'll need some more reviews. I suggest you >> resubmit. > > Resubmit exactly the same patches? > Where is the ->commit_rqs() callback

Re: [PATCH][next][V2] btrfs: fix memory leak of path on error return path

2019-07-05 Thread Colin Ian King
On 05/07/2019 02:30, Anand Jain wrote: > On 5/7/19 7:03 AM, Colin King wrote: >> From: Colin Ian King >> >> Currently if the allocation of roots or tmp_ulist fails the error >> handling >> does not free up the allocation of path causing a memory leak. Fix >> this and >> other similar leaks by

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-07-05 Thread Hannes Reinecke
On 6/18/19 5:28 AM, Bart Van Assche wrote: > On 6/17/19 5:35 PM, Douglas Gilbert wrote: >> For sg3_utils: >> >> $ find . -name '*.c' -exec grep "/proc/scsi" {} \; -print >> static const char * proc_allow_dio = "/proc/scsi/sg/allow_dio"; >> ./src/sg_read.c >> static const char * proc_allow_dio =

linux-next: build failure after merge of the nvdimm tree

2019-07-05 Thread Stephen Rothwell
Hi all, After merging the nvdimm tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from :32: ./usr/include/linux/virtio_pmem.h:19:2: error: unknown type name 'uint64_t' uint64_t start; ^~~~ ./usr/include/linux/virtio_pmem.h:20:2: error: unknown type

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-07-05 Thread Hannes Reinecke
On 6/18/19 7:43 PM, Elliott, Robert (Servers) wrote: > > >> -Original Message- >> From: linux-kernel-ow...@vger.kernel.org >> [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Bart >> Van Assche >> Sent: Monday, June 17, 2019 10:28 PM >> To: dgilb...@interlog.com; Marc Gonzalez ;

[PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool

2019-07-05 Thread Jose Abreu
Mapping and unmapping DMA region is an high bottleneck in stmmac driver, specially in the RX path. This commit introduces support for Page Pool API and uses it in all RX queues. With this change, we get more stable troughput and some increase of banwidth with iperf: - MAC1000 - 950 Mbps

[PATCH net-next v3 1/3] net: stmmac: Implement RX Coalesce Frames setting

2019-07-05 Thread Jose Abreu
Add support for coalescing RX path by specifying number of frames which don't need to have interrupt on completion bit set. This is only available when RX Watchdog is enabled. Acked-by: Jakub Kicinski Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc:

[PATCH net-next v3 2/3] net: stmmac: Fix descriptors address being in > 32 bits address space

2019-07-05 Thread Jose Abreu
Commit a993db88d17d ("net: stmmac: Enable support for > 32 Bits addressing in XGMAC"), introduced support for > 32 bits addressing in XGMAC but the conversion of descriptors to dma_addr_t was left out. As some devices assing coherent memory in regions > 32 bits we need to set lower and upper

Re: [PATCH] drm/komeda: Adds VRR support

2019-07-05 Thread Daniel Vetter
On Thu, Jul 4, 2019 at 5:41 PM Brian Starkey wrote: > > Hi, > > On Thu, Jul 04, 2019 at 11:57:00AM +0100, james qian wang (Arm Technology > China) wrote: > > On Wed, Jul 03, 2019 at 12:01:49PM +0200, Daniel Vetter wrote: > > > > > > Uh, what exactly are you doing reinventing uapi properties that

[PATCH net-next v3 0/3] net: stmmac: Some improvements and a fix

2019-07-05 Thread Jose Abreu
Some performace improvements (01/03 and 03/03) and a fix (02/03), all for -next. Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Jose Abreu (3): net: stmmac: Implement RX Coalesce Frames setting net: stmmac: Fix descriptors address being in > 32 bits

Re: [PATCH] dmaengine: imx-sdma: fix use-after-free on probe error path

2019-07-05 Thread Vinod Koul
On 24-06-19, 10:07, Sven Van Asbroeck wrote: > If probe() fails anywhere beyond the point where > sdma_get_firmware() is called, then a kernel oops may occur. > > Problematic sequence of events: > 1. probe() calls sdma_get_firmware(), which schedules the >firmware callback to run when

RE: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: correct the fuse word index

2019-07-05 Thread Andy Duan
From: Lothar Waßmann Sent: Friday, July 5, 2019 3:13 PM > Hi, > > On Fri, 5 Jul 2019 02:46:32 + Andy Duan wrote: > > From: Andy Duan Sent: Friday, July 5, 2019 12:08 AM > > > From: Lothar Waßmann Sent: Thursday, July > > > 4, > > > 2019 11:46 PM > > > > Hi, > > > > > > > > On Thu, 4 Jul

Re: [PATCH 2/8] leds: as3645a: Fix misuse of strlcpy

2019-07-05 Thread Sakari Ailus
On Thu, Jul 04, 2019 at 04:57:42PM -0700, Joe Perches wrote: > Probable cut typo - use the correct field size. > > Signed-off-by: Joe Perches Thanks, Joe! Acked-by: Sakari Ailus > --- > drivers/leds/leds-as3645a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v7 net-next 1/5] net: core: page_pool: add user refcnt and reintroduce page_pool_destroy

2019-07-05 Thread Jesper Dangaard Brouer
CC: Tariq + Saeed, could you please review the mlx5 part. On Fri, 5 Jul 2019 02:14:02 +0300 Ivan Khoronzhuk wrote: > Jesper recently removed page_pool_destroy() (from driver invocation) > and moved shutdown and free of page_pool into xdp_rxq_info_unreg(), > in-order to handle in-flight

Re: [PATCH 1/2] scsi_host: add support for request batching

2019-07-05 Thread Stefan Hajnoczi
On Fri, Jul 05, 2019 at 09:12:37AM +0200, Hannes Reinecke wrote: > On 7/4/19 3:19 PM, Paolo Bonzini wrote: > > On 19/06/19 12:31, Paolo Bonzini wrote: > >>> I'm a bit unsure if 'bd->last' is always set; it's quite obvious that > >>> it's present if set, but what about requests with 'bd->last ==

Re: [PATCH 1/2] scsi_host: add support for request batching

2019-07-05 Thread Hannes Reinecke
On 7/5/19 9:44 AM, Stefan Hajnoczi wrote: > On Fri, Jul 05, 2019 at 09:12:37AM +0200, Hannes Reinecke wrote: >> On 7/4/19 3:19 PM, Paolo Bonzini wrote: >>> On 19/06/19 12:31, Paolo Bonzini wrote: > I'm a bit unsure if 'bd->last' is always set; it's quite obvious that > it's present if set,

Re: [PATCH] dmaengine: qcom: bam_dma: Fix completed descriptors count

2019-07-05 Thread Vinod Koul
On 28-06-19, 17:39, Sricharan R wrote: > One space is left unused in circular FIFO to differentiate > 'full' and 'empty' cases. So take that in to account while > counting for the descriptors completed. > > Fixes the issue reported here, > https://lkml.org/lkml/2019/6/18/669 Applied,

Re: [PATCH 2/2] virtio_scsi: implement request batching

2019-07-05 Thread Hannes Reinecke
On 5/30/19 1:28 PM, Paolo Bonzini wrote: > Adding the command and kicking the virtqueue so far was done one after > another. Make the kick optional, so that we can take into account SCMD_LAST. > We also need a commit_rqs callback to kick the device if blk-mq aborts > the submission before the

[PATCH] ASoC: rt5665: remove redundant assignment to variable idx

2019-07-05 Thread Colin King
From: Colin Ian King The variable idx is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- sound/soc/codecs/rt5665.c | 2

Re: [PATCH v2 0/3] DCMI bridge support

2019-07-05 Thread Sakari Ailus
Hi Laurent, On Thu, Jun 27, 2019 at 04:38:24PM +0300, Laurent Pinchart wrote: > Hi Hugues, > > On Thu, Jun 27, 2019 at 12:38:40PM +, Hugues FRUCHET wrote: > > On 6/26/19 7:25 PM, Laurent Pinchart wrote: > > > On Mon, Jun 24, 2019 at 10:10:05AM +, Hugues FRUCHET wrote: > > >> Hi Sakari, >

[PATCH v2] genirq: update irq stats from NMI handlers

2019-07-05 Thread Shijith Thotton
The NMI handlers handle_percpu_devid_fasteoi_nmi() and handle_fasteoi_nmi() added by commit 2dcf1fbcad35 ("genirq: Provide NMI handlers") do not update the interrupt counts. Due to that the NMI interrupt count does not show up correctly in /proc/interrupts. Update the functions to fix this. With

Re: [PATCH] mm/isolate: Drop pre-validating migrate type in undo_isolate_page_range()

2019-07-05 Thread Oscar Salvador
On Fri, Jul 05, 2019 at 11:42:41AM +0530, Anshuman Khandual wrote: > unset_migratetype_isolate() already validates under zone lock that a given > page has already been isolated as MIGRATE_ISOLATE. There is no need for > another check before. Hence just drop this redundant validation. > > Cc:

Re: [PATCH V3 1/2] dt-bindings: reset: imx7: Add support for i.MX8MM

2019-07-05 Thread Philipp Zabel
Hi Anson, On Fri, 2019-07-05 at 00:26 +, Anson Huang wrote: > Hi, Philipp > > > On Thu, 2019-07-04 at 17:44 +0800, anson.hu...@nxp.com wrote: > > > From: Anson Huang > > > > > > i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible > > > property and related info to support

Re: [PATCH v2 0/3] DCMI bridge support

2019-07-05 Thread Laurent Pinchart
Hi Sakari, On Fri, Jul 05, 2019 at 10:55:22AM +0300, Sakari Ailus wrote: > On Thu, Jun 27, 2019 at 04:38:24PM +0300, Laurent Pinchart wrote: > > On Thu, Jun 27, 2019 at 12:38:40PM +, Hugues FRUCHET wrote: > >> On 6/26/19 7:25 PM, Laurent Pinchart wrote: > >>> On Mon, Jun 24, 2019 at

[PATCH -next] ASoC: SOF: debug: fix possible memory leak in sof_dfsentry_write()

2019-07-05 Thread Wei Yongjun
'string' is malloced in sof_dfsentry_write() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Fixes: 091c12e1f50c ("ASoC: SOF: debug: add new debugfs entries for IPC flood test") Signed-off-by: Wei Yongjun --- sound/soc/sof/debug.c | 4 ++--

[PATCH v2] misc: fastrpc: fix memory leak

2019-07-05 Thread Jorge Ramirez-Ortiz
Do the necessary house-keeping if the allocated memory wont be used Signed-off-by: Jorge Ramirez-Ortiz --- drivers/misc/fastrpc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 98603e235cf0..c790585da14c 100644 ---

[PATCH] libertas: remove redundant assignment to variable ret

2019-07-05 Thread Colin King
From: Colin Ian King The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [PATCH][next] ubifs: remove redundant assignment to pointer fname

2019-07-05 Thread Sergei Shtylyov
Hello! On 05.07.2019 1:28, Colin King wrote: From: Colin Ian King The pointer fname rc is being assigned with a value that is never rc? read because the function returns after the assignment. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value")

[PATCH] staging: rtl8712: remove redundant assignment to variable res

2019-07-05 Thread Colin King
From: Colin Ian King The variable res is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [PATCH] mm/isolate: Drop pre-validating migrate type in undo_isolate_page_range()

2019-07-05 Thread Anshuman Khandual
On 07/05/2019 01:29 PM, Oscar Salvador wrote: > On Fri, Jul 05, 2019 at 11:42:41AM +0530, Anshuman Khandual wrote: >> unset_migratetype_isolate() already validates under zone lock that a given >> page has already been isolated as MIGRATE_ISOLATE. There is no need for >> another check before.

Re: [PATCH][next] ubifs: remove redundant assignment to pointer fname

2019-07-05 Thread Colin Ian King
On 05/07/2019 09:24, Sergei Shtylyov wrote: > Hello! > > On 05.07.2019 1:28, Colin King wrote: > >> From: Colin Ian King >> >> The pointer fname rc is being assigned with a value that is never > >    rc? Oops, cut'n'paste error. Do you want me to resend to can this be fixed when it's applied?

linux-next: build failure after merge of the kbuild tree

2019-07-05 Thread Stephen Rothwell
Hi all, After merging the kbuild tree, today's linux-next build (powerpc allyesconfig) failed like this: In file included from : include/clocksource/hyperv_timer.h:18:10: fatal error: asm/mshyperv.h: No such file or directory #include ^~~~ Caused by commit

[PATCH] [media] saa7134: remove redundant assignment to variable value

2019-07-05 Thread Colin King
From: Colin Ian King The variable value is being assigned with a value that is never read and it is being updated later with a new value. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [PATCH v7 net-next 5/5] net: ethernet: ti: cpsw: add XDP support

2019-07-05 Thread Jesper Dangaard Brouer
On Fri, 5 Jul 2019 02:14:06 +0300 Ivan Khoronzhuk wrote: > Add XDP support based on rx page_pool allocator, one frame per page. > Page pool allocator is used with assumption that only one rx_handler > is running simultaneously. DMA map/unmap is reused from page pool > despite there is no need

RE: [PATCH net-next 4/6] arm64: dts: fsl: ls1028a: Add Felix switch port DT node

2019-07-05 Thread Claudiu Manoil
>-Original Message- >From: Andrew Lunn >Sent: Friday, July 5, 2019 7:50 AM >To: Vladimir Oltean >Cc: Alexandre Belloni ; Allan W. Nielsen >; Claudiu Manoil ; >David S . Miller ; devicet...@vger.kernel.org; >net...@vger.kernel.org; Alexandru Marginean >; linux-kernel@vger.kernel.org;

Re: linux-next: build failure after merge of the nvdimm tree

2019-07-05 Thread Pankaj Gupta
Hi Stephen, > > Hi all, > > After merging the nvdimm tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from :32: > ./usr/include/linux/virtio_pmem.h:19:2: error: unknown type name 'uint64_t' > uint64_t start; > ^~~~ >

RE: [PATCH V3 1/2] dt-bindings: reset: imx7: Add support for i.MX8MM

2019-07-05 Thread Anson Huang
Hi, Philipp > On Fri, 2019-07-05 at 00:26 +, Anson Huang wrote: > > Hi, Philipp > > > > > On Thu, 2019-07-04 at 17:44 +0800, anson.hu...@nxp.com wrote: > > > > From: Anson Huang > > > > > > > > i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible > > > > property and related info

Re: [linux-sunxi] [PATCH v3] drivers: ata: ahci_sunxi: Increased SATA/AHCI DMA TX/RX FIFOs

2019-07-05 Thread Chen-Yu Tsai
On Mon, May 13, 2019 at 10:24 PM Uenal Mutlu wrote: > > Increasing the SATA/AHCI DMA TX/RX FIFOs (P0DMACR.TXTS and .RXTS, ie. > TX_TRANSACTION_SIZE and RX_TRANSACTION_SIZE) from default 0x0 each > to 0x3 each, gives a write performance boost of 120 MiB/s to 132 MiB/s > from lame 36 MiB/s to 45

Re: [PATCH] cpu/hotplug: Cache number of online CPUs

2019-07-05 Thread Ingo Molnar
* Mathieu Desnoyers wrote: > - On Jul 4, 2019, at 6:33 PM, Thomas Gleixner t...@linutronix.de wrote: > > > On Thu, 4 Jul 2019, Mathieu Desnoyers wrote: > >> - On Jul 4, 2019, at 5:10 PM, Thomas Gleixner t...@linutronix.de wrote: > >> > > >> > num_online_cpus() is racy today vs. CPU

[PATCH] PCI: tegra: Fix support for GPIO based PERST#

2019-07-05 Thread Jon Hunter
Commit 5e5e9c23f82a ("PCI: tegra: Add support for GPIO based PERST#") calls the function devm_gpiod_get_from_of_node() to request a GPIO. Unfortunately, around the same time this was merged, commit 025bf37725f1 ("gpio: Fix return value mismatch of function gpiod_get_from_of_node()") was also

linux-next: build failure after merge of the akpm-current tree

2019-07-05 Thread Stephen Rothwell
Hi all, After merging the akpm-current tree, today's linux-next build (arm multi_v7_defconfig) failed like this: In file included from include/linux/compiler.h:257, from arch/arm/kernel/asm-offsets.c:10: include/linux/kasan-checks.h:14:15: error: unknown type name 'bool' static

[PATCH] [media] stv0900_core: remove redundant assignment to variables mclk, div and ad_div

2019-07-05 Thread Colin King
From: Colin Ian King The variables mclk, div and ad_div are being assigned with a values that are never read and are being updated later with a new values. The assignments are redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [PATCH] clk: imx8mq: Mark AHB clock as critical

2019-07-05 Thread Abel Vesa
On 19-06-25 15:32:22, Stephen Boyd wrote: > Quoting Abel Vesa (2019-06-25 02:01:56) > > Keep the AHB clock always on since there is no driver to control it and > > all the other clocks that use it as parent rely on it being always enabled. > > > > Signed-off-by: Abel Vesa > > --- > >

[PATCH v2 1/5] perf: arm64: Add test to check userspace access to hardware counters.

2019-07-05 Thread Raphael Gault
This test relies on the fact that the PMU registers are accessible from userspace. It then uses the perf_event_mmap_page to retrieve the counter index and access the underlying register. This test uses sched_setaffinity(2) in order to run on all CPU and thus check the behaviour of the PMU of all

[PATCH v2 4/5] arm64: perf: Enable pmu counter direct access for perf event on armv8

2019-07-05 Thread Raphael Gault
Keep track of event opened with direct access to the hardware counters and modify permissions while they are open. The strategy used here is the same which x86 uses: everytime an event is mapped, the permissions are set if required. The atomic field added in the mm_context helps keep track of the

[PATCH] Sched: Change type of 'overrun' from int to u64

2019-07-05 Thread Puranjay Mohan
Callers of hrtimer_forward_now() should save the return value in u64. function sched_rt_period_timer() stores it in variable 'overrun' of type int change type of overrun from int to u64 to solve the issue. Signed-off-by: Puranjay Mohan --- kernel/sched/rt.c | 2 +- 1 file changed, 1

[PATCH v2 3/5] arm64: pmu: Add function implementation to update event index in userpage.

2019-07-05 Thread Raphael Gault
In order to be able to access the counter directly for userspace, we need to provide the index of the counter using the userpage. We thus need to override the event_idx function to retrieve and convert the perf_event index to armv8 hardware index. Since the arm_pmu driver can be used by any

[PATCH v2 5/5] Documentation: arm64: Document PMU counters access from userspace

2019-07-05 Thread Raphael Gault
Add a documentation file to describe the access to the pmu hardware counters from userspace Signed-off-by: Raphael Gault --- .../arm64/pmu_counter_user_access.txt | 42 +++ 1 file changed, 42 insertions(+) create mode 100644

[PATCH v2 0/5] arm64: Enable access to pmu registers by user-space

2019-07-05 Thread Raphael Gault
The perf user-space tool relies on the PMU to monitor events. It offers an abstraction layer over the hardware counters since the underlying implementation is cpu-dependent. We want to allow userspace tools to have access to the registers storing the hardware counters' values directly. This

[PATCH v2 2/5] arm64: cpufeature: Add feature to detect heterogeneous systems

2019-07-05 Thread Raphael Gault
This feature is required in order to enable PMU counters direct access from userspace only when the system is homogeneous. This feature checks the model of each CPU brought online and compares it to the boot CPU. If it differs then it is heterogeneous. Cc: suzuki.poul...@arm.com Signed-off-by:

Re: [tip:irq/core] gpio: mb86s7x: Enable ACPI support

2019-07-05 Thread Linus Walleij
On Thu, Jul 4, 2019 at 8:18 PM Ard Biesheuvel wrote: > On Thu, 4 Jul 2019 at 09:52, Linus Walleij wrote: > > > > On Wed, Jul 3, 2019 at 3:50 PM Marc Zyngier wrote: > > > On 03/07/2019 13:26, Linus Walleij wrote: > > > > On Wed, Jul 3, 2019 at 11:24 AM tip-bot for Ard Biesheuvel > > > > wrote:

Re: linux-next: Tree for Jul 4 -> conflict between s390 and driver-core tree

2019-07-05 Thread Christian Borntraeger
Linus, Vasily, for your attention in the next merge window. (I would suggest to apply belows fixup during the merge of whatever tree is merged 2nd). There is now a build conflict between the s390/features branch and the driver-core/driver-core-next especially between commit 92ce7e83b4e5

move_mount.2

2019-07-05 Thread David Howells
Eric Biggers wrote: > Also, since the case of a fd with an internal mount was overlooked, probably > the man page needs to be updated clarify that move_mount(2) fails with > EINVAL in this case. Where is the man page? See below. I'm in the middle of updating the manpages I need to push.

[PATCH] powerpc/83xx: fix use-after-free on mpc831x_usb_cfg()

2019-07-05 Thread Wen Yang
The np variable is still being used after the of_node_put() call, which may result in use-after-free. We fix this issue by calling of_node_put() after the last usage. This patatch also do some cleanup. Fixes: fd066e850351 ("powerpc/mpc8308: fix USB DR controller initialization") Signed-off-by:

[PATCH V4 2/2] arm64: dts: imx8mm: Add "fsl,imx8mq-src" as src's fallback compatible

2019-07-05 Thread Anson . Huang
From: Anson Huang i.MX8MM can reuse i.MX8MQ's src driver, add "fsl,imx8mq-src" as src's fallback compatible to enable it. Signed-off-by: Anson Huang Reviewed-by: Philipp Zabel --- No changes. --- arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH V4 1/2] dt-bindings: reset: imx7: Add support for i.MX8MM

2019-07-05 Thread Anson . Huang
From: Anson Huang i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible property and related info to support i.MX8MM. Signed-off-by: Anson Huang --- Changes since V3: - Add comments to those reset indices to indicate which are NOT supported on i.MX8MM. ---

Re: [PATCH v2] RDMA/core: Fix race when resolving IP address

2019-07-05 Thread Dag Moxnes
Den 05.07.2019 04:19, skrev Parav Pandit: On Fri, Jun 28, 2019 at 2:20 PM Dag Moxnes wrote: Use neighbour lock when copying MAC address from neighbour data struct in dst_fetch_ha. When not using the lock, it is possible for the function to race with neigh_update, causing it to copy an

[PATCH] powerpc: fix use-after-free on fixup_port_irq()

2019-07-05 Thread Wen Yang
There is a possible use-after-free issue in the fixup_port_irq(): 460 static void __init fixup_port_irq(int index, 461 struct device_node *np, 462 struct plat_serial8250_port *port) 463 { ... 469 if (!virq &&

Re: [PATCH v3] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices

2019-07-05 Thread Greg KH
On Fri, Jul 05, 2019 at 01:33:49AM -0700, jeyentam wrote: > Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices. > > Signed-off-by: Je Yen Tam > --- > drivers/tty/serial/8250/8250_pci.c | 298 - > 1 file changed, 294 insertions(+), 4 deletions(-)

[PATCH] powerpc/prom: fix use-after-free on cpu_to_chip_id()

2019-07-05 Thread Wen Yang
The np variable is still being used after the of_node_put() call, which may result in use-after-free. We fix this issue by calling of_node_put() after the last usage. Fixes: 3eb906c6b6c1 ("powerpc: Make cpu_to_chip_id() available when SMP=n") Signed-off-by: Wen Yang Cc: Benjamin Herrenschmidt

Re: [PATCH 2/2] usbip: Implement SG support to vhci

2019-07-05 Thread Suwan Kim
On Thu, Jul 04, 2019 at 09:41:04PM -0400, Alan Stern wrote: > On Fri, 5 Jul 2019, Suwan Kim wrote: > > > On Mon, Jun 24, 2019 at 01:24:15PM -0400, Alan Stern wrote: > > > On Mon, 24 Jun 2019, Suwan Kim wrote: > > > > > > > > > + hcd->self.sg_tablesize = ~0; > > > > > > +

Re: [PATCH net-next 4/6] arm64: dts: fsl: ls1028a: Add Felix switch port DT node

2019-07-05 Thread Vladimir Oltean
Hi Andrew, On Fri, 5 Jul 2019 at 07:49, Andrew Lunn wrote: > > Hi Vladimir > > > - DSA is typically used for discrete switches, switchdev is typically > > used for embedded ones. > > Typically DSA is for discrete switches, but not exclusively. The > b53/SF2 is embedded in a number of Broadcom

[PATCH] time: compat settimeofday: Validate the values of tv from user

2019-07-05 Thread zhengbin
Similar to commit 6ada1fc0e1c4 ("time: settimeofday: Validate the values of tv from user"), an unvalidated user input is multiplied by a constant, which can result in an undefined behaviour for large values. While this is validated later, we should avoid triggering undefined behaviour.

Re: [PATCH] mm/isolate: Drop pre-validating migrate type in undo_isolate_page_range()

2019-07-05 Thread Michal Hocko
On Fri 05-07-19 11:42:41, Anshuman Khandual wrote: > unset_migratetype_isolate() already validates under zone lock that a given > page has already been isolated as MIGRATE_ISOLATE. There is no need for > another check before. Hence just drop this redundant validation. unset_migratetype_isolate

Re: [PATCH v2 0/3] DCMI bridge support

2019-07-05 Thread Sakari Ailus
Hi Laurent, On Fri, Jul 05, 2019 at 11:04:24AM +0300, Laurent Pinchart wrote: ... > > A reasonable compromise would be to add a Kconfig option that allows > > enabling MC. This way you can provide backwards compatibility and allow > > making use of the full potential of the hardware. That's

Re: [PATCH bpf-next] Enable zext optimization for more RV64G ALU ops

2019-07-05 Thread Jiong Wang
Luke Nelson writes: > commit 66d0d5a854a6 ("riscv: bpf: eliminate zero extension code-gen") > added the new zero-extension optimization for some BPF ALU operations. > > Since then, bugs in the JIT that have been fixed in the bpf tree require > this optimization to be added to other operations:

Re: linux-next boot error: WARNING in corrupted

2019-07-05 Thread Rafael J. Wysocki
On Thursday, July 4, 2019 7:27:04 PM CEST syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:16c474c9 Add linux-next specific files for 20190704 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=17f8b463a0 > kernel

RE: Re: [PATCH v3] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices

2019-07-05 Thread Je Yen Tam
> On Fri, Jul 05, 2019 at 01:33:49AM -0700, jeyentam wrote: > > Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices. > > > > Signed-off-by: Je Yen Tam > > --- > > drivers/tty/serial/8250/8250_pci.c | 298 - > > 1 file changed, 294 insertions(+), 4

Re: linux-next: build failure after merge of the akpm-current tree

2019-07-05 Thread Marco Elver
On Fri, 5 Jul 2019 at 10:49, Stephen Rothwell wrote: > > Hi all, > > After merging the akpm-current tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > In file included from include/linux/compiler.h:257, > from arch/arm/kernel/asm-offsets.c:10: >

Re: [PATCH] gpiolib: fix incorrect IRQ requesting of an active-low lineevent

2019-07-05 Thread Bartosz Golaszewski
pt., 5 lip 2019 o 11:30 Michael Wu napisał(a): > > When a pin is active-low, logical trigger edge should be inverted > to match the same interrupt opportunity. > > For example, a button pushed trigger falling edge in ACTIVE_HIGH > case; in ACTIVE_LOW case, the button pushed trigger rising edge. >

[PATCH v2 net-next] net: stmmac: enable clause 45 mdio support

2019-07-05 Thread Voon Weifeng
From: Kweh Hock Leong DWMAC4 is capable to support clause 45 mdio communication. This patch enable the feature on stmmac_mdio_write() and stmmac_mdio_read() by following phy_write_mmd() and phy_read_mmd() mdiobus read write implementation format. Reviewed-by: Li, Yifan Signed-off-by: Kweh Hock

Re: [PATCH 7/7] gpiolib: Use spinlock_t instead of struct spinlock

2019-07-05 Thread Bartosz Golaszewski
czw., 4 lip 2019 o 17:38 Sebastian Andrzej Siewior napisał(a): > > For spinlocks the type spinlock_t should be used instead of "struct > spinlock". > > Use spinlock_t for spinlock's definition. > > Cc: Linus Walleij > Cc: Bartosz Golaszewski > Cc: linux-g...@vger.kernel.org > Signed-off-by:

Re: linux-next boot error: WARNING in corrupted

2019-07-05 Thread Dmitry Vyukov
On Fri, Jul 5, 2019 at 11:23 AM Rafael J. Wysocki wrote: > > On Thursday, July 4, 2019 7:27:04 PM CEST syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:16c474c9 Add linux-next specific files for 20190704 > > git tree: linux-next > > console

[PATCH] power: supply: isp1704: remove redundant assignment to variable ret

2019-07-05 Thread Colin King
From: Colin Ian King The variable ret is being assigned with a value that is never read and it is being updated later with a new value. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/power/supply/isp1704_charger.c

[PATCH] gpiolib: fix incorrect IRQ requesting of an active-low lineevent

2019-07-05 Thread Michael Wu
When a pin is active-low, logical trigger edge should be inverted to match the same interrupt opportunity. For example, a button pushed trigger falling edge in ACTIVE_HIGH case; in ACTIVE_LOW case, the button pushed trigger rising edge. For user space the IRQ requesting doesn't need to do any

  1   2   3   4   5   6   >