Re: [PATCH v2] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-23 Thread Bjorn Helgaas
On Tue, Jul 23, 2019 at 1:59 PM Kelsey Skunberg wrote: > > acpi_evaluate_object will already return an error if the needed method > does not exist. Remove unnecessary acpi_has_method() calls and check the > returned acpi_status for failure instead. > diff --git

Re: [5.2 REGRESSION] Generic vDSO breaks seccomp-enabled userspace on i386

2019-07-23 Thread Andy Lutomirski
On Tue, Jul 23, 2019 at 2:55 PM Kees Cook wrote: > > On Mon, Jul 22, 2019 at 04:47:36PM -0700, Andy Lutomirski wrote: > > On Mon, Jul 22, 2019 at 4:28 PM Kees Cook wrote: > > > I've built a straw-man for this idea... but I have to say I don't > > > like it. This can lead to really unexpected

[PATCH] ARM: dts: rockchip: Limit WiFi TX power on rk3288-veyron-jerry

2019-07-23 Thread Matthias Kaehlcke
The downstream Chrome OS 3.14 kernel for jerry limits WiFi TX power through calibration data in the device tree [1]. Add a DT node for the WiFi chip and use the downstream calibration data. Not all calibration data entries have the length specified in the binding

Re: [PATCH] cgroup: minor tweak for logic to get cgroup css

2019-07-23 Thread Tejun Heo
On Wed, Jul 03, 2019 at 10:07:49AM +0800, Peng Wang wrote: > We could only handle the case that css exists > and css_try_get_online() fails. > > Signed-off-by: Peng Wang Applied to cgroup/for-5.4. Thanks. -- tejun

Re: [PATCH] cgroup: Replace a seq_printf() call by seq_puts() in cgroup_print_ss_mask()

2019-07-23 Thread Tejun Heo
On Tue, Jul 02, 2019 at 07:33:08PM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 2 Jul 2019 19:26:59 +0200 > > A string which did not contain a data format specification should be put > into a sequence. Thus use the corresponding function “seq_puts”. > > This issue was

Re: [GIT PULL] parisc architecture fixes for kernel v5.3-rc2

2019-07-23 Thread pr-tracker-bot
The pull request you sent on Tue, 23 Jul 2019 23:43:44 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git > parisc-5.3-3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ad5e427e0f6b702e52c11d1f7b2b7be3bac7de82 Thank you! --

[PATCH v6 3/5] soc: qcom: Add socinfo driver

2019-07-23 Thread Vaishali Thakkar
From: Imran Khan The Qualcomm socinfo driver exposes information about the SoC, its version and its serial number to user space. Signed-off-by: Imran Khan [Bjorn: Extract code to platform_driver, split patch in multiple] Signed-off-by: Bjorn Andersson [Vaishali: Simplify declarations,

[PATCH v6 5/5] soc: qcom: socinfo: Expose image information

2019-07-23 Thread Vaishali Thakkar
The socinfo driver provides information about version of the various images loaded in the system. Expose this to user space for debugging purpose. Signed-off-by: Vaishali Thakkar --- Changes since v5: - No code changes, fix diff.context setting for formatting patches. Version 5

[PATCH v6 2/5] base: soc: Export soc_device_register/unregister APIs

2019-07-23 Thread Vaishali Thakkar
From: Vinod Koul Qcom Socinfo driver can be built as a module, so export these two APIs. Signed-off-by: Vinod Koul Signed-off-by: Vaishali Thakkar Reviewed-by: Greg Kroah-Hartman Reviewed-by: Stephen Boyd Reviewed-by: Bjorn Andersson --- Changes since v5: - No code changes, fix

Re: [PATCH] mm/backing-dev: show state of all bdi_writeback in debugfs

2019-07-23 Thread Tejun Heo
On Wed, Jul 24, 2019 at 12:24:41AM +0300, Konstantin Khlebnikov wrote: > Debugging such dynamic structure with gdb is a pain. Use drgn. It's a lot better than hard coding these debug features into the kernel. https://github.com/osandov/drgn Thanks. -- tejun

[PATCH v6 4/5] soc: qcom: socinfo: Expose custom attributes

2019-07-23 Thread Vaishali Thakkar
The Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality. Signed-off-by: Vaishali Thakkar --- Changes since v5: - No code changes, fix my diff.context setting for formatting patches. Version 5 was

[PATCH v6 1/5] base: soc: Add serial_number attribute to soc

2019-07-23 Thread Vaishali Thakkar
From: Bjorn Andersson Add new attribute named "serial_number" as a standard interface for user space to acquire the serial number of the device. For ST-Ericsson SoCs this is exposed by the cryptically named "soc_id" attribute, but this provides a human readable standardized name for this

[PATCH v6 0/5] soc: qcom: Add SoC info driver

2019-07-23 Thread Vaishali Thakkar
This patchset adds SoC info driver which can provide information such as Chip ID, Chip family and serial number about Qualcomm SoCs to user space via sysfs. Furthermore, it allows userspace to get information about custom attributes and various image version information via debugfs. The patchset

Re: [PATCH v2 5/5] dt-bindings: dsp: fsl: Add DSP core binding support

2019-07-23 Thread Rob Herring
On Tue, Jul 23, 2019 at 2:41 AM Daniel Baluta wrote: > > This describes the DSP device tree node. > > Signed-off-by: Daniel Baluta > --- > .../devicetree/bindings/dsp/fsl,dsp.yaml | 87 +++ > 1 file changed, 87 insertions(+) > create mode 100644

[PATCH] stmmac_dt_phy: null check the allocation

2019-07-23 Thread Navid Emamdoost
devm_kzalloc may fail and return NULL. So the null check is needed. Signed-off-by: Navid Emamdoost --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

Re: [PATCH v3 6/7] drivers: Add generic helper to match any device

2019-07-23 Thread Bjorn Helgaas
On Tue, Jul 23, 2019 at 5:19 PM Suzuki K Poulose wrote: > > Add a generic helper to match any/all devices. Using this > introduce new wrappers {bus/driver/class}_find_next_device(). > > Cc: Bjorn Helgaas > Cc: Elie Morisse > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Cc: Nehal

Re: [PATCH v4 2/3] treewide: Remove dev_err() usage after platform_get_irq()

2019-07-23 Thread Stephen Boyd
Quoting Rob Herring (2019-07-23 12:30:48) > On Tue, Jul 23, 2019 at 12:16 PM Stephen Boyd wrote: > > > > We don't need dev_err() messages when platform_get_irq() fails now that > > platform_get_irq() prints an error message itself when something goes > > wrong. Let's remove these prints with a

Re: [PATCH net-next 1/3] enetc: Add mdio bus driver for the PCIe MDIO endpoint

2019-07-23 Thread Andrew Lunn
> + bus = mdiobus_alloc_size(sizeof(u32 *)); > + if (!bus) > + return -ENOMEM; > + > + bus->priv = pci_iomap_range(pdev, 0, ENETC_MDIO_REG_OFFSET, 0); This got me confused for a while. You allocate space for a u32 pointer. bus->priv will point to this space. However, you

Re: [PATCH] kmemleak: Increase maximum early log entries to 1000000

2019-07-23 Thread Doug Anderson
Hi, On Tue, Jul 23, 2019 at 1:21 AM Dmitry Vyukov wrote: > > On Tue, Jul 23, 2019 at 10:13 AM Nicolas Boichat > wrote: > > > > On Tue, Jul 23, 2019 at 3:46 PM Dmitry Vyukov wrote: > > > > > > On Tue, Jul 23, 2019 at 9:26 AM Nicolas Boichat > > > wrote: > > > > > > > > When KASan is enabled,

Re: memory leak in rds_send_probe

2019-07-23 Thread Andrew Morton
On Tue, 23 Jul 2019 15:17:00 -0700 syzbot wrote: > syzbot has bisected this bug to: > > commit af49a63e101eb62376cc1d6bd25b97eb8c691d54 > Author: Matthew Wilcox > Date: Sat May 21 00:03:33 2016 + > > radix-tree: change naming conventions in radix_tree_shrink > > bisection log:

Re: [PATCH v4 2/3] treewide: Remove dev_err() usage after platform_get_irq()

2019-07-23 Thread Stephen Boyd
Quoting Andy Shevchenko (2019-07-23 11:31:54) > On Tue, Jul 23, 2019 at 9:16 PM Stephen Boyd wrote: > > > > We don't need dev_err() messages when platform_get_irq() fails now that > > platform_get_irq() prints an error message itself when something goes > > wrong. Let's remove these prints with a

[PATCH v3 4/7] drivers: Introduce device lookup variants by device type

2019-07-23 Thread Suzuki K Poulose
Add a helper to match a device by its type and provide wrappers for {bus/class/driver}_find_device() APIs. Cc: Alexander Shishkin Cc: Arnd Bergmann Cc: Harald Freudenberger Cc: Heiko Carstens Cc: linux-...@vger.kernel.org Cc: Oliver Neukum Cc: Sebastian Andrzej Siewior Cc: Tomas Winkler

[PATCH] mt76_init_sband_2g: null check the allocation

2019-07-23 Thread Navid Emamdoost
devm_kzalloc may fail and return NULL. So the null check is needed. Signed-off-by: Navid Emamdoost --- drivers/net/wireless/mediatek/mt7601u/init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt7601u/init.c b/drivers/net/wireless/mediatek/mt7601u/init.c

[PATCH v3 6/7] drivers: Add generic helper to match any device

2019-07-23 Thread Suzuki K Poulose
Add a generic helper to match any/all devices. Using this introduce new wrappers {bus/driver/class}_find_next_device(). Cc: Bjorn Helgaas Cc: Elie Morisse Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Nehal Shah Cc: "Rafael J. Wysocki" Cc: Shyam Sundar S K Cc: Greg Kroah-Hartman

[PATCH v3 3/7] drivers: Introduce device lookup variants by fwnode

2019-07-23 Thread Suzuki K Poulose
Add a helper to match the firmware node handle of a device and provide wrappers for {bus/class/driver}_find_device() APIs to avoid proliferation of duplicate custom match functions. Cc: "David S. Miller" Cc: Doug Ledford Cc: Greg Kroah-Hartman Cc: Heikki Krogerus Cc: Jason Gunthorpe Cc:

[PATCH v3 2/7] drivers: Introduce device lookup variants by of_node

2019-07-23 Thread Suzuki K Poulose
Introduce wrappers for {bus/driver/class}_find_device() to locate devices by its of_node. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: dri-de...@lists.freedesktop.org Cc: David Airlie Cc: Daniel Vetter Cc: devicet...@vger.kernel.org Cc: Florian Fainelli Cc: Frank Rowand Cc: Heiko Stuebner

[PATCH v3 7/7] platform: Add platform_find_device_by_driver() helper

2019-07-23 Thread Suzuki K Poulose
Provide a helper to lookup platform devices by matching device driver in order to avoid drivers trying to use platform bus internals. Cc: Eric Anholt Cc: Greg Kroah-Hartman Cc: "Heiko Stübner" Cc: Inki Dae Cc: "Rafael J. Wysocki" Cc: Sandy Huang Cc: Seung-Woo Kim Tested-by: Heiko Stuebner

[PATCH v3 5/7] drivers: Introduce device lookup variants by ACPI_COMPANION device

2019-07-23 Thread Suzuki K Poulose
Add a generic helper to match a device by the ACPI_COMPANION device and provide wrappers for the device lookup APIs. Cc: Len Brown Cc: linux-a...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: Mark Brown Cc: Mika Westerberg Cc: Wolfram Sang Cc: linux-...@vger.kernel.org Cc: Mark Brown Cc:

Re: [PATCH] selinux: convert struct sidtab count to refcount_t

2019-07-23 Thread Kees Cook
On Tue, Jul 23, 2019 at 04:53:47PM +0200, Jann Horn wrote: > On Mon, Jul 22, 2019 at 3:44 PM Ondrej Mosnacek wrote: > > On Mon, Jul 22, 2019 at 1:35 PM NitinGote wrote: > > > refcount_t type and corresponding API should be > > > used instead of atomic_t when the variable is used as > > > a

Re: memory leak in rds_send_probe

2019-07-23 Thread syzbot
syzbot has bisected this bug to: commit af49a63e101eb62376cc1d6bd25b97eb8c691d54 Author: Matthew Wilcox Date: Sat May 21 00:03:33 2016 + radix-tree: change naming conventions in radix_tree_shrink bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=176528c860 start

[PATCH] st_nci_hci_connectivity_event_received: null check the allocation

2019-07-23 Thread Navid Emamdoost
devm_kzalloc may fail and return NULL. So the null check is needed. Signed-off-by: Navid Emamdoost --- drivers/nfc/st-nci/se.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nfc/st-nci/se.c b/drivers/nfc/st-nci/se.c index c3e10b6ab3a4..f25f1ec5f9e9 100644 ---

Re: [PATCH RFC 0/4] Add support to directly attach BPF program to ftrace

2019-07-23 Thread Alexei Starovoitov
On Wed, Jul 17, 2019 at 10:51:43PM -0400, Joel Fernandes wrote: > Hi Alexei, > > On Wed, Jul 17, 2019 at 02:40:42PM -0700, Alexei Starovoitov wrote: > > On Wed, Jul 17, 2019 at 6:01 AM Joel Fernandes > > wrote: > > > > I trimmed cc. some emails were bouncing. > > Ok, thanks. > > > > > I

Re: [PATCH net-next] [net-next] mlx4: avoid large stack usage in mlx4_init_hca()

2019-07-23 Thread Saeed Mahameed
On Mon, 2019-07-22 at 17:01 +0200, Arnd Bergmann wrote: > The mlx4_dev_cap and mlx4_init_hca_param are really too large > to be put on the kernel stack, as shown by this clang warning: > > drivers/net/ethernet/mellanox/mlx4/main.c:3304:12: error: stack frame > size of 1088 bytes in function

Re: [PATCH 0/5] Add support for WD MyCloud EX2 Ultra (+ versatile UART-based restart/poweroff drivers)

2019-07-23 Thread Andrew Lunn
On Tue, Jul 23, 2019 at 07:48:49PM +0200, Evgeny Kolesnikov wrote: > On 23/07/2019 03:56, Andrew Lunn wrote: > >On Mon, Jul 22, 2019 at 09:53:00PM +0200, Evgeny Kolesnikov wrote: > >> > >>The difference between uart-poweroff and qnap-poweroff is small, but > >>important: > >>uart-poweroff is able

[PATCH] st21nfca_connectivity_event_received: null check the allocation

2019-07-23 Thread Navid Emamdoost
devm_kzalloc may fail and return null. So the null check is needed. Signed-off-by: Navid Emamdoost --- drivers/nfc/st21nfca/se.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nfc/st21nfca/se.c b/drivers/nfc/st21nfca/se.c index 06fc542fd198..6586378cacb0 100644 ---

drivers/gpu/drm/exynos/exynos_drm_fbdev.c:244:26: sparse: sparse: incorrect type in argument 1 (different address spaces)

2019-07-23 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git master head: 7b5cf701ea9c395c792e2a7e3b7caf4c68b87721 commit: 156bdac99061b4013c8e47799c6e574f7f84e9f4 drm/exynos: trigger build of all modules date: 4 weeks ago reproduce: # apt-get install sparse

Re: [PATCH 6/8] ARM: dts: Fix flags for gpio7

2019-07-23 Thread Suman Anna
Hi Tony, On 7/23/19 6:28 AM, Tony Lindgren wrote: > The ti,no-idle-on-init and ti,no-reset-on-init flags need to be at > the interconnect target module level for the modules that have it > defined. Otherwise we get the following warnings: > > dts flag should be at module level for

Re: [5.2 REGRESSION] Generic vDSO breaks seccomp-enabled userspace on i386

2019-07-23 Thread Kees Cook
On Mon, Jul 22, 2019 at 04:47:36PM -0700, Andy Lutomirski wrote: > On Mon, Jul 22, 2019 at 4:28 PM Kees Cook wrote: > > I've built a straw-man for this idea... but I have to say I don't > > like it. This can lead to really unexpected behaviors if someone > > were to have differing filters for the

[tip:perf/urgent] perf build: Do not use -Wshadow on gcc < 4.8

2019-07-23 Thread tip-bot for Arnaldo Carvalho de Melo
Commit-ID: 39e7317e37f7f0be366d1201c283f968c17268da Gitweb: https://git.kernel.org/tip/39e7317e37f7f0be366d1201c283f968c17268da Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 19 Jul 2019 15:34:30 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 23 Jul 2019 09:04:54 -0300

[tip:perf/urgent] perf probe: Avoid calling freeing routine multiple times for same pointer

2019-07-23 Thread tip-bot for Arnaldo Carvalho de Melo
Commit-ID: d95daf5accf4a72005daa13fbb1d1bd8709f2861 Gitweb: https://git.kernel.org/tip/d95daf5accf4a72005daa13fbb1d1bd8709f2861 Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 18 Jul 2019 11:28:37 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 23 Jul 2019 09:04:41 -0300

Warning seen when removing a module using irqdomain framework

2019-07-23 Thread pheragu
Hi, I have been working on a interrupt controller driver that uses tree based mapping for its domain (irq_domain_add_tree(..)). If I understand correctly, the clients get a mapping when they call platform_get_irq(..). However, after these clients are removed (rmmod), when I try to remove the

[tip:perf/urgent] perf probe: Set pev->nargs to zero after freeing pev->args entries

2019-07-23 Thread tip-bot for Arnaldo Carvalho de Melo
Commit-ID: df8350ed56a26f502a9636f37faf699a12ee906e Gitweb: https://git.kernel.org/tip/df8350ed56a26f502a9636f37faf699a12ee906e Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 18 Jul 2019 11:22:58 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 23 Jul 2019 09:04:25 -0300

[tip:perf/urgent] perf stat: Always separate stalled cycles per insn

2019-07-23 Thread tip-bot for Cong Wang
Commit-ID: 146540fb545b8464ba1be298e3392daca0d183a2 Gitweb: https://git.kernel.org/tip/146540fb545b8464ba1be298e3392daca0d183a2 Author: Cong Wang AuthorDate: Fri, 17 May 2019 15:10:39 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 23 Jul 2019 09:03:46 -0300 perf stat:

[tip:perf/urgent] perf session: Fix loading of compressed data split across adjacent records

2019-07-23 Thread tip-bot for Alexey Budankov
Commit-ID: 872c8ee8f0f47222f7b10da96eea84d0486540a3 Gitweb: https://git.kernel.org/tip/872c8ee8f0f47222f7b10da96eea84d0486540a3 Author: Alexey Budankov AuthorDate: Tue, 9 Jul 2019 17:48:14 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 23 Jul 2019 09:04:03 -0300 perf

[tip:perf/urgent] perf stat: Fix segfault for event group in repeat mode

2019-07-23 Thread tip-bot for Jiri Olsa
Commit-ID: 08ef3af1579d0446db1c1bd08e2c42565addf10f Gitweb: https://git.kernel.org/tip/08ef3af1579d0446db1c1bd08e2c42565addf10f Author: Jiri Olsa AuthorDate: Mon, 15 Jul 2019 16:21:21 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 23 Jul 2019 09:00:05 -0300 perf stat: Fix

[tip:perf/urgent] perf tools: Fix proper buffer size for feature processing

2019-07-23 Thread tip-bot for Jiri Olsa
Commit-ID: 79b2fe5e756163897175a8f57d66b26cd9befd59 Gitweb: https://git.kernel.org/tip/79b2fe5e756163897175a8f57d66b26cd9befd59 Author: Jiri Olsa AuthorDate: Mon, 15 Jul 2019 16:04:26 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 23 Jul 2019 08:59:49 -0300 perf tools: Fix

Re: [PATCH 1/2] dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings

2019-07-23 Thread David Dai
Thanks for the feedback Stephen, much appreciated! On 7/23/2019 7:42 AM, Stephen Boyd wrote: Quoting David Dai (2019-07-19 13:32:23) Redefine the Network-on-Chip devices to more accurately describe the interconnect topology on Qualcomm's SDM845 platform. Each interconnect device can

[tip:perf/urgent] perf script: Fix off by one in brstackinsn IPC computation

2019-07-23 Thread tip-bot for Andi Kleen
Commit-ID: dde4e732a5b02fa5599c2c0e6c48a0c11789afc4 Gitweb: https://git.kernel.org/tip/dde4e732a5b02fa5599c2c0e6c48a0c11789afc4 Author: Andi Kleen AuthorDate: Thu, 11 Jul 2019 11:19:21 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 23 Jul 2019 08:59:37 -0300 perf script:

[tip:perf/urgent] perf script: Improve man page description of metrics

2019-07-23 Thread tip-bot for Andi Kleen
Commit-ID: 7db7218a7ea577f04c2df92453d47ab5ebfc8863 Gitweb: https://git.kernel.org/tip/7db7218a7ea577f04c2df92453d47ab5ebfc8863 Author: Andi Kleen AuthorDate: Thu, 11 Jul 2019 11:19:22 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 23 Jul 2019 08:58:11 -0300 perf script:

[tip:perf/urgent] perf script: Fix --max-blocks man page description

2019-07-23 Thread tip-bot for Andi Kleen
Commit-ID: 5f8eec3225ff7b86763b060164e9ce47b1a71406 Gitweb: https://git.kernel.org/tip/5f8eec3225ff7b86763b060164e9ce47b1a71406 Author: Andi Kleen AuthorDate: Thu, 11 Jul 2019 11:19:20 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 23 Jul 2019 08:57:54 -0300 perf script:

[GIT PULL] parisc architecture fixes for kernel v5.3-rc2

2019-07-23 Thread Helge Deller
Hi Linus, please pull two patches for the parisc architecture for kernel 5.3-rc2 from: git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git parisc-5.3-3 Changes: - Fix build issues when kprobes are enabled - Speed up ITLB/DTLB cache flushes when running on machines with

Re: [GIT PULL] perf/urgent fixes

2019-07-23 Thread Ingo Molnar
t; Merge tag 'perf-core-for-mingo-5.3-20190715' of > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent > (2019-07-18 00:32:52 +0200) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > t

linux-next: Fixes tag needs some work in the s390-fixes tree

2019-07-23 Thread Stephen Rothwell
Hi all, In commit 8b515be512a2 ("vfio-ccw: Fix memory leak and don't call cp_free in cp_init") Fixes tag Fixes: 812271b910 ("s390/cio: Squash cp_free() and cp_unpin_free()") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or

RE: [PATCH v2 1/3] mm: document zone device struct page field usage

2019-07-23 Thread Weiny, Ira
> > On 7/22/19 4:08 AM, Matthew Wilcox wrote: > > On Sun, Jul 21, 2019 at 10:13:45PM -0700, Ira Weiny wrote: > >> On Sun, Jul 21, 2019 at 09:02:04AM -0700, Matthew Wilcox wrote: > >>> On Fri, Jul 19, 2019 at 12:29:53PM -0700, Ralph Campbell wrote: > Struct page for ZONE_DEVICE private pages

Re: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool

2019-07-23 Thread Jon Hunter
On 23/07/2019 14:19, Robin Murphy wrote: ... >>> Do you know if the SMMU interrupts are working correctly? If not, it's >>> possible that an incorrect address or mapping direction could lead to >>> the DMA transaction just being silently terminated without any fault >>> indication, which

Re: [PATCH V2 1/1] can: sja1000: f81601: add Fintek F81601 support

2019-07-23 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:22 +0800, Ji-Ze Hong (Peter Hong) wrote: > This patch add support for Fintek PCIE to 2 CAN controller support > > Signed-off-by: Ji-Ze Hong (Peter Hong) > > --- > Changelog: > v2: > 1: Fix comment on the spinlock with write access. > 2: Use ARRAY_SIZE instead

Re: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms

2019-07-23 Thread Kees Cook
On Mon, Jul 22, 2019 at 05:38:15PM -0700, Joe Perches wrote: > Several uses of strlcpy and strscpy have had defects because the > last argument of each function is misused or typoed. > > Add macro mechanisms to avoid this defect. > > stracpy (copy a string to a string array) must have a string >

Re: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms

2019-07-23 Thread Kees Cook
On Tue, Jul 23, 2019 at 03:41:27PM +, David Laight wrote: > From: Rasmus Villemoes > > Sent: 23 July 2019 07:56 > ... > > > +/** > > > + * stracpy - Copy a C-string into an array of char > > > + * @to: Where to copy the string, must be an array of char and not a > > > pointer > > > + * @from:

Re: [PATCH v4 7/7] arm64: defconfig: enable cpufreq support for RPi3

2019-07-23 Thread Stefan Wahren
Am 12.06.19 um 20:24 schrieb Nicolas Saenz Julienne: > This enables both the new firmware clock driver and cpufreq driver > available for the RPi3 family of boards. > > Signed-off-by: Nicolas Saenz Julienne > Acked-by: Stefan Wahren > --- > > Changes since v2: > - Build both drivers as modules

Re: [PATCH v4 6/7] ARM: defconfig: enable cpufreq driver for RPi

2019-07-23 Thread Stefan Wahren
Am 12.06.19 um 20:24 schrieb Nicolas Saenz Julienne: > This enables on both multi_v7_defconfig and bcm2835_defconfig the new > firmware based clock and cpufreq drivers for the Raspberry Pi platform. > > In the case of bcm2835_defconfig, as the cpufreq subsystem was disabled, > the conservative

Re: Build regressions/improvements in v5.3-rc1

2019-07-23 Thread Helge Deller
On 23.07.19 17:39, Geert Uytterhoeven wrote: On Tue, Jul 23, 2019 at 5:22 PM Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v5.3-rc1[1] compared to v5.2[2]. [1]

Re: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms

2019-07-23 Thread Kees Cook
On Mon, Jul 22, 2019 at 09:42:51PM -0700, Joe Perches wrote: > On Mon, 2019-07-22 at 21:35 -0700, Andrew Morton wrote: > > On Mon, 22 Jul 2019 17:38:15 -0700 Joe Perches wrote: > > > > > Several uses of strlcpy and strscpy have had defects because the > > > last argument of each function is

Re: [PATCH 2/2] kernel-doc: core-api: Include string.h into core-api

2019-07-23 Thread Kees Cook
On Mon, Jul 22, 2019 at 05:38:16PM -0700, Joe Perches wrote: > core-api should show all the various string functions including the > newly added stracpy and stracpy_pad. > > Miscellanea: > > o Update the Returns: value for strscpy > o fix a defect with %NUL) > > Signed-off-by: Joe Perches

Re: [PATCH] KVM: x86: init x2apic_enabled() once

2019-07-23 Thread Krish Sadhukhan
On 07/23/2019 06:06 AM, lufe...@163.com wrote: From: luferry x2apic_eanbled() costs about 200 cycles when guest trigger halt pretty high, pi ops in hotpath Signed-off-by: luferry --- arch/x86/kvm/vmx/vmx.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v2 2/2] x86/purgatory: use CFLAGS_REMOVE rather than reset KBUILD_CFLAGS

2019-07-23 Thread Nick Desaulniers
On Mon, Jul 22, 2019 at 3:59 PM Vaibhav Rustagi wrote: > The changes suggested will cause undefined symbols while loading the new > kernel. > On doing 'nm purgatory.ro', I found below undefined symbols: > > U bmcp > U __stack_chk_fail Thanks for the report, a v3:

Re: [PATCH] asm-generic: fix -Wtype-limits compiler warnings

2019-07-23 Thread Andrew Morton
On Tue, 23 Jul 2019 16:49:46 -0400 Qian Cai wrote: > The commit d66acc39c7ce ("bitops: Optimise get_order()") introduced a > compilation warning because "rx_frag_size" is an "ushort" while > PAGE_SHIFT here is 16. The commit changed the get_order() to be a > multi-line macro where compilers

Re: [PATCH v2 1/3] mm: document zone device struct page field usage

2019-07-23 Thread Ralph Campbell
On 7/22/19 4:08 AM, Matthew Wilcox wrote: On Sun, Jul 21, 2019 at 10:13:45PM -0700, Ira Weiny wrote: On Sun, Jul 21, 2019 at 09:02:04AM -0700, Matthew Wilcox wrote: On Fri, Jul 19, 2019 at 12:29:53PM -0700, Ralph Campbell wrote: Struct page for ZONE_DEVICE private pages uses the

[PATCH v3 1/2] x86/purgatory: do not use __builtin_memcpy and __builtin_memset

2019-07-23 Thread Nick Desaulniers
Implementing memcpy and memset in terms of __builtin_memcpy and __builtin_memset is problematic. GCC at -O2 will replace calls to the builtins with calls to memcpy and memset (but will generate an inline implementation at -Os). Clang will replace the builtins with these calls regardless of

[PATCH v3 2/2] x86/purgatory: use CFLAGS_REMOVE rather than reset KBUILD_CFLAGS

2019-07-23 Thread Nick Desaulniers
KBUILD_CFLAGS is very carefully built up in the top level Makefile, particularly when cross compiling or using different build tools. Resetting KBUILD_CFLAGS via := assignment is an antipattern. The comment above the reset mentions that -pg is problematic. Other Makefiles use

[PATCH v3 0/2] Support kexec/kdump for clang built kernel

2019-07-23 Thread Nick Desaulniers
1. Reuse the implementation of memcpy and memset instead of relying on __builtin_memcpy and __builtin_memset as it causes infinite recursion in Clang (at any opt level) or GCC at -O2. 2. Don't reset KBUILD_CFLAGS, rather filter CONFIG_FUNCTION_TRACER, CONFIG_STACKPROTECTOR, and

Re: [PATCH] mm/backing-dev: show state of all bdi_writeback in debugfs

2019-07-23 Thread Konstantin Khlebnikov
On Tue, Jul 23, 2019 at 11:07 PM Andrew Morton wrote: > > On Tue, 23 Jul 2019 15:49:32 +0300 Konstantin Khlebnikov > wrote: > > > Currently /sys/kernel/debug/bdi/$maj:$min/stats shows only root bdi wb. > > With CONFIG_CGROUP_WRITEBACK=y there is one for each memory cgroup. > > > > This patch

Re: [PATCH] PCI: pci-hyperv: fix build errors on non-SYSFS config

2019-07-23 Thread Bjorn Helgaas
On Sat, Jul 13, 2019 at 11:03:53AM -0400, Sasha Levin wrote: > On Fri, Jul 12, 2019 at 04:04:17PM +, Haiyang Zhang wrote: > > > -Original Message- > > > From: Randy Dunlap > > > Sent: Friday, July 12, 2019 11:53 AM > > > To: linux-pci ; LKML > > ker...@vger.kernel.org> > > > Cc:

[RFC,v2 6/6] media: ds90ub953: new driver for TI DS90UB953-Q1 video serializer

2019-07-23 Thread Luca Ceresoli
Add a driver for the TI DS90UB953-Q1, a MIPI CSI-2 video serializer that forwards a MIPI CSI-2 input video stream over an FPD Link 3 connection to a remote deserializer. It also allows access to I2C and GPIO from the deserializer. Signed-off-by: Luca Ceresoli --- Changes RFCv1 -> RFCv2: none,

[PATCH] cgroup: kselftest: Relax fs_spec checks

2019-07-23 Thread Chris Down
On my laptop most memcg kselftests were being skipped because it claimed cgroup v2 hierarchy wasn't mounted, but this isn't correct. Instead, it seems current systemd HEAD mounts it with the name "cgroup2" instead of "cgroup": % grep cgroup /proc/mounts cgroup2 /sys/fs/cgroup cgroup2

Re: [PATCH v2] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-23 Thread David Miller
From: David Miller Date: Tue, 23 Jul 2019 14:06:46 -0700 (PDT) > From: Kelsey Skunberg > Date: Tue, 23 Jul 2019 12:58:11 -0600 > >> acpi_evaluate_object will already return an error if the needed method >> does not exist. Remove unnecessary acpi_has_method() calls and check the >> returned

Re: [PATCH v2] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-23 Thread David Miller
From: Kelsey Skunberg Date: Tue, 23 Jul 2019 12:58:11 -0600 > acpi_evaluate_object will already return an error if the needed method > does not exist. Remove unnecessary acpi_has_method() calls and check the > returned acpi_status for failure instead. > > Signed-off-by: Kelsey Skunberg > --- >

Re: [PATCH 5/8] ARM: dts: Drop bogus ahclkr clocks for dra7 mcasp 3 to 8

2019-07-23 Thread Suman Anna
Hi Tony, On 7/23/19 6:28 AM, Tony Lindgren wrote: > The ahclkr clkctrl clock bit 28 only exists for mcasp 1 and 2 on dra7. > Otherwise we get the following warning on beagle-x15: > > ti-sysc 48468000.target-module: could not add child clock ahclkr: -19 > > Fixes: 5241ccbf2819 ("ARM: dts: Add

Re: [PATCH] [v2] waitqueue: shut up clang -Wuninitialized warnings

2019-07-23 Thread Nick Desaulniers
On Tue, Jul 23, 2019 at 1:22 PM Nathan Chancellor wrote: > > On Tue, Jul 23, 2019 at 01:03:05PM +0200, Arnd Bergmann wrote: > > On Tue, Jul 23, 2019 at 12:50 PM Peter Zijlstra > > wrote: > > > On Fri, Jul 19, 2019 at 01:36:00PM +0200, Arnd Bergmann wrote: > > > > --- a/include/linux/wait.h > >

Re: [PATCH v4] mm: Throttle allocators when failing reclaim over memory.high

2019-07-23 Thread Johannes Weiner
On Tue, Jul 23, 2019 at 02:07:00PM -0400, Chris Down wrote: > We're trying to use memory.high to limit workloads, but have found that > containment can frequently fail completely and cause OOM situations > outside of the cgroup. This happens especially with swap space -- either > when none is

[PATCH] asm-generic: fix -Wtype-limits compiler warnings

2019-07-23 Thread Qian Cai
The commit d66acc39c7ce ("bitops: Optimise get_order()") introduced a compilation warning because "rx_frag_size" is an "ushort" while PAGE_SHIFT here is 16. The commit changed the get_order() to be a multi-line macro where compilers insist to check all statements in the macro even when

RE: [PATCH] acpica: fix -Wnull-pointer-arithmetic warnings

2019-07-23 Thread Moore, Robert
-Original Message- From: Qian Cai [mailto:c...@lca.pw] Sent: Wednesday, July 17, 2019 5:50 PM To: Nick Desaulniers Cc: Wysocki, Rafael J ; Moore, Robert ; Schmauss, Erik ; j...@freebsd.org; Len Brown ; linux-a...@vger.kernel.org; de...@acpica.org; clang-built-linux ; LKML

Re: [PATCH net-next 1/3] enetc: Add mdio bus driver for the PCIe MDIO endpoint

2019-07-23 Thread Saeed Mahameed
On Tue, 2019-07-23 at 18:15 +0300, Claudiu Manoil wrote: > ENETC ports can manage the MDIO bus via local register > interface. However there's also a centralized way > to manage the MDIO bus, via the MDIO PCIe endpoint > device integrated by the same root complex that also > integrates the ENETC

Re: [PATCH v2 3/6] pwm: jz4740: Apply configuration atomically

2019-07-23 Thread Paul Cercueil
Hi Uwe, Le lun. 22 juil. 2019 à 15:34, Uwe =?iso-8859-1?q?Kleine-K=F6nig?= a écrit : Hello Paul, On Fri, Jun 07, 2019 at 05:44:07PM +0200, Paul Cercueil wrote: -static int jz4740_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, - int duty_ns, int

[patch] perf tool buffer overflow in perf_header__read_build_ids

2019-07-23 Thread Vince Weaver
Hello my perf_tool_fuzzer has found another issue, this one a buffer overflow in perf_header__read_build_ids. The build id filename is read in with a filename length read from the perf.data file, but this can be longer than PATH_MAX which will smash the stack. This might not be the right fix,

[PATCH 2/2] habanalabs: fix host memory polling in BE architecture

2019-07-23 Thread Oded Gabbay
From: Ben Segal This patch fix a bug in the host memory polling macro. The bug is that the memory being polled can be written by the device, which always writes it in LE. However, if the host is running Linux in BE mode, we need to convert the value that was written by the device before matching

[PATCH 1/2] habanalabs: fix F/W download in BE architecture

2019-07-23 Thread Oded Gabbay
From: Ben Segal writeX macros might perform byte-swapping in BE architectures. As our F/W is in LE format, we need to make sure no byte-swapping will occur. There is a standard kernel function (called memcpy_toio) for copying data to I/O area which is used in a lot of drivers to download F/W to

Re: [PATCH] net: dsa: sja1105: sja1105_main: Add of_node_put()

2019-07-23 Thread David Miller
From: Nishka Dasgupta Date: Tue, 23 Jul 2019 16:14:48 +0530 > Each iteration of for_each_child_of_node puts the previous node, but in > the case of a return from the middle of the loop, there is no put, thus > causing a memory leak. Hence add an of_node_put before the return. > Issue found with

[RFC,v2 5/6] media: ds90ub954: new driver for TI DS90UB954-Q1 video deserializer

2019-07-23 Thread Luca Ceresoli
Add a driver for the TI DS90UB954-Q1, a MIPI CSI-2 video deserializer that forwards video streams from up to two FPD-Link 3 connections to a MIPI CSI-2 output. It also allows access to remote I2C and GPIO. Signed-off-by: Luca Ceresoli --- Changes RFCv1 -> RFCv2: - i2c - add one i2c client

[RFC,v2 3/6] media: dt-bindings: add DS90UB954-Q1 video deserializer

2019-07-23 Thread Luca Ceresoli
Describe the Texas Instruments DS90UB954-Q1, a 2-input video deserializer with I2C Address Translator and remote GPIOs. Signed-off-by: Luca Ceresoli --- Changes RFCv1 -> RFCv2: - add explicit aliases for the FPD-link RX ports (optional) - add proper remote GPIO description ---

[RFC,v2 2/6] i2c: add I2C Address Translator (ATR) support

2019-07-23 Thread Luca Ceresoli
An ATR is a device that looks similar to an i2c-mux: it has an I2C slave "upstream" port and N master "downstream" ports, and forwards transactions from upstream to the appropriate downstream port. But is is different in that the forwarded transaction has a different slave address. The address

[RFC,v2 4/6] media: dt-bindings: add DS90UB953-Q1 video serializer

2019-07-23 Thread Luca Ceresoli
Describe the Texas Instruments DS90UB953-Q1, a video serializer with remote access to I2C and GPIOs. Signed-off-by: Luca Ceresoli --- Changes RFCv1 -> RFCv2: none, this patch is new in RFCv2 --- .../bindings/media/i2c/ti,ds90ub953-q1.txt| 42 +++

[RFC,v2 0/6] TI camera serdes and I2C address translation

2019-07-23 Thread Luca Ceresoli
Hi, this is a second round of RFC patches to move forward on discussion about proper kernel support for the TI DS90UB9xx serializer/deserializer chipsets with I2C address translation. RFCv2 is a major improvement over RFCv1, with several parts rewritten from scratch. I2C address translationis

[RFC,v2 1/6] i2c: core: let adapters be notified of client attach/detach

2019-07-23 Thread Luca Ceresoli
An adapter might need to know when a new device is about to be added. This will soon bee needed to implement an "I2C address translator" (ATR for short), a device that propagates I2C transactions with a different slave address (an "alias" address). An ATR driver needs to know when a slave is being

Re: Question about vmsplice + SPLICE_F_GIFT

2019-07-23 Thread Leonardo Bras
On Tue, 2019-07-23 at 17:33 -0300, Leonardo Bras wrote: > I have seen the SPLICE_F_MOVE being used on steal ops from the > 'pipebuffer', but I couldn't find a way to call it from splice. Sorry, typo here. I meant: > I have seen the SPLICE_F_GIFT being used on steal ops [...] signature.asc

Re: [PATCH v3 3/5] OPP: Improve require-opps linking

2019-07-23 Thread Saravana Kannan
Resending again due to accidental HTML (minor rewording/typo fixes too). On Tue, Jul 23, 2019 at 3:28 AM Viresh Kumar wrote: > > $subject doesn't have correct property name. > > On 17-07-19, 15:23, Saravana Kannan wrote: > > Currently, the linking of required-opps fails silently if the > >

[PATCH v1] platform/x86: acer-wmi: Switch to acpi_dev_get_first_match_dev()

2019-07-23 Thread Andy Shevchenko
The acpi_dev_get_first_match_dev() helper will find and return an ACPI device pointer of the first registered device in the system by its HID. Use it instead of open coded variant. Cc: Chun-Yi Lee Signed-off-by: Andy Shevchenko --- - Chun-Yi, please, test it if possible

Question about vmsplice + SPLICE_F_GIFT

2019-07-23 Thread Leonardo Bras
Hello everybody, I am not sure if this is the right place to be asking this. If is not, I apologize for the inconvenience. Also, please tell me where is a better way to as these questions. I am trying to create a basic C code to test vmsplice + SPLICE_F_GIFT for moving memory pages between two

[PATCH v5 7/9] PCI/AER: Allow clearing Error Status Register in FF mode

2019-07-23 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan As per PCI firmware specification r3.2 Downstream Port Containment Related Enhancements ECN, sec 4.5.1, table 4-6, Error Disconnect Recover (EDR) support allows OS to handle error recovery and clearing Error Registers even in FF mode. So remove FF mode checks in

[PATCH v5 5/9] PCI/DPC: Add dpc_process_error() wrapper function

2019-07-23 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan With Error Disconnect Recover (EDR) support, we need to support processing DPC event either from DPC IRQ or ACPI EDR event. So create a wrapper function dpc_process_error() and move common error handling code in to it. It will be used to process the DPC event in

[PATCH v5 4/9] PCI/DPC: Allow dpc_probe() even if firmware first mode is enabled

2019-07-23 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan As per ACPI specification v6.3, sec 5.6.6, Error Disconnect Recover (EDR) notification used by firmware to let OS know about the DPC event and permit OS to perform error recovery when processing the EDR notification. Also, as per PCI firmware specification r3.2

<    1   2   3   4   5   6   7   8   9   >