RE: [PATCH 2/2] dt-bindings: IDU-intc: Add support for edge-triggered interrupts

2019-07-24 Thread Alexey Brodkin
Hi Mischa, > -Original Message- > From: Mischa Jonker > Sent: Tuesday, July 23, 2019 1:26 PM > To: Vineet Gupta ; Alexey Brodkin > ; > kstew...@linuxfoundation.org; t...@linutronix.de; robh...@kernel.org; > linux-snps- > a...@lists.infradead.org; linux-kernel@vger.kernel.org; >

Re: [RFC/RFT 1/5] phy: exynos5-usbdrd: read from correct offset of xhci linksystem

2019-07-24 Thread Krzysztof Kozlowski
On Mon, 22 Jul 2019 at 20:59, Anand Moon wrote: > > Read from linksystem offset to update the xhci version. But why? As many times before, you do not specify why you are doing things. What problem are you solving? What feature are you adding? Best regards, Krzysztof > > Signed-off-by: Anand

Re: [BUG] Linux 5.3-rc1: timer problem on x86-64 (Pentium D)

2019-07-24 Thread Thomas Gleixner
Rui, On Wed, 24 Jul 2019, Rui Salvaterra wrote: > I don't know if this has been reported before, but from a cursory > search it doesn't seem to be the case. > I have a x86-64 Pentium (4) D machine which always worked perfectly > with Linux 5.2 using the TSC as the clock source. With Linux 5.3-rc1

Re: [PATCH v1 5/6] mt76: fix some checkpatch warnings

2019-07-24 Thread Joe Perches
On Wed, 2019-07-24 at 16:58 +0800, Ryder Lee wrote: > This fixes the following checkpatch warnings: [] > diff --git a/drivers/net/wireless/mediatek/mt76/agg-rx.c > b/drivers/net/wireless/mediatek/mt76/agg-rx.c [] > @@ -74,15 +75,14 @@ mt76_rx_aggr_check_release(struct mt76_rx_tid *tid, > struct

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread Greg KH
On Wed, Jul 24, 2019 at 05:17:15PM +0800, Mao Wenan wrote: > There is one report about tcp_write_xmit use-after-free with version 4.4.136: > > BUG: KASAN: use-after-free in tcp_skb_pcount include/net/tcp.h:796 [inline] > BUG: KASAN: use-after-free in tcp_init_tso_segs net/ipv4/tcp_output.c:1619

Re: [RFC/RFT 2/5] phy: exynos5-usbdrd: add missing tuning of the phyutmi signal

2019-07-24 Thread Krzysztof Kozlowski
On Mon, 22 Jul 2019 at 20:59, Anand Moon wrote: > > Add missing tuning of phyutmi controls to enter suspend and > resume state. > > Signed-off-by: Anand Moon > --- > drivers/phy/samsung/phy-exynos5-usbdrd.c | 32 ++-- > 1 file changed, 30 insertions(+), 2 deletions(-) > >

Re: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool

2019-07-24 Thread Jon Hunter
On 24/07/2019 11:04, Jose Abreu wrote: ... > Jon, I was able to replicate (at some level) your setup: > > # dmesg | grep -i arm-smmu > [1.337322] arm-smmu 7004.iommu: probing hardware > configuration... > [1.337330] arm-smmu 7004.iommu: SMMUv2 with: > [1.337338] arm-smmu

Re: [RFC/RFT 3/5] phy: exynos5-usbdrd: UTMI tune signal

2019-07-24 Thread Krzysztof Kozlowski
On Mon, 22 Jul 2019 at 20:59, Anand Moon wrote: > > Tune USB2.0 (UTMI+) TX signal for high speed data transfer. What is the visible effect? What does this tuning bring? > > Signed-off-by: Anand Moon > --- > drivers/phy/samsung/phy-exynos5-usbdrd.c | 42 +--- > 1 file

Re: [PATCH 6/7] clocksource/drivers/sh_cmt: r8a7740 and sh73a0 SoC-specific match

2019-07-24 Thread Simon Horman
On Thu, Jul 18, 2019 at 08:45:24PM +0900, Magnus Damm wrote: > From: Magnus Damm > > Add SoC-specific matching for CMT1 on r8a7740 and sh73a0. > > This allows us to move away from the old DT bindings such as > - "renesas,cmt-48-sh73a0" > - "renesas,cmt-48-r8a7740" > - "renesas,cmt-48" > in

Re: [PATCH 1/7] dt-bindings: timer: renesas, cmt: Add CMT0234 to sh73a0 and r8a7740

2019-07-24 Thread Simon Horman
On Thu, Jul 18, 2019 at 08:44:12PM +0900, Magnus Damm wrote: > From: Magnus Damm > > Document the on-chip CMT devices included in r8a7740 and sh73a0. > > Included in this patch is DT binding documentation for 32-bit CMTs > CMT0, CMT2, CMT3 and CMT4. They all contain a single channel and are >

Re: [PATCH 2/7] dt-bindings: timer: renesas, cmt: Update CMT1 on sh73a0 and r8a7740

2019-07-24 Thread Simon Horman
On Thu, Jul 18, 2019 at 08:44:25PM +0900, Magnus Damm wrote: > From: Magnus Damm > > This patch reworks the DT binding documentation for the 6-channel > 48-bit CMTs known as CMT1 on r8a7740 and sh73a0. > > After the update the same style of DT binding as the rest of the upstream > SoCs will now

Re: [PATCH 3/7] dt-bindings: timer: renesas, cmt: Add CMT0 and CMT1 to r8a7792

2019-07-24 Thread Simon Horman
On Thu, Jul 18, 2019 at 08:44:39PM +0900, Magnus Damm wrote: > From: Magnus Damm > > This patch adds DT binding documentation for the CMT devices on > the R-Car Gen2 V2H (r8a7792) SoC. > > Signed-off-by: Magnus Damm > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Rob Herring Reviewed-by:

Re: [PATCH 5/7] dt-bindings: timer: renesas, cmt: Update R-Car Gen3 CMT1 usage

2019-07-24 Thread Simon Horman
On Thu, Jul 18, 2019 at 08:45:11PM +0900, Magnus Damm wrote: > From: Magnus Damm > > The R-Car Gen3 SoCs so far come with a total for 4 on-chip CMT devices: > - CMT0 > - CMT1 > - CMT2 > - CMT3 > > CMT0 includes two rather basic 32-bit timer channels. The rest of the on-chip > CMT devices

Re: [PATCH 4/7] dt-bindings: timer: renesas, cmt: Add CMT0 and CMT1 to r8a77995

2019-07-24 Thread Simon Horman
On Thu, Jul 18, 2019 at 08:44:53PM +0900, Magnus Damm wrote: > From: Magnus Damm > > This patch adds DT binding documentation for the CMT devices on > the R-Car Gen3 D3 (r8a77995) SoC. > > Signed-off-by: Magnus Damm > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Rob Herring Reviewed-by:

Re: [PATCH v3 5/7] backlight: gpio: remove dev from struct gpio_backlight

2019-07-24 Thread Daniel Thompson
On Wed, Jul 24, 2019 at 10:25:06AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This field is unused. Remove it. > > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Andy Shevchenko Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/gpio_backlight.c | 4

Re: [RFC/RFT 4/5] phy: exynos5-usbdrd: PIPE3 tune signal

2019-07-24 Thread Krzysztof Kozlowski
On Mon, 22 Jul 2019 at 20:59, Anand Moon wrote: > > Tune USB3.0 (PIPE3) PHY TX signal for high and supper > speed data transfer. > > Signed-off-by: Anand Moon > --- > drivers/phy/samsung/phy-exynos5-usbdrd.c | 18 +- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff

Re: [PATCH 7/7] clocksource/drivers/sh_cmt: Document "cmt-48" as deprecated

2019-07-24 Thread Simon Horman
On Thu, Jul 18, 2019 at 08:45:38PM +0900, Magnus Damm wrote: > From: Magnus Damm > > Update the CMT driver to mark "renesas,cmt-48" as deprecated. > > Instead of documenting a theoretical hardware device based on current software > support level, define DT bindings top-down based on available

Re: [PATCH v3 6/7] backlight: gpio: remove def_value from struct gpio_backlight

2019-07-24 Thread Daniel Thompson
On Wed, Jul 24, 2019 at 10:25:07AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This field is unused outside of probe(). There's no need to store it. > We can make it into a local variable. > > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Andy Shevchenko

Re: [PATCH v3 4/7] backlight: gpio: remove unused fields from platform data

2019-07-24 Thread Daniel Thompson
On Wed, Jul 24, 2019 at 10:25:05AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Remove the platform data fields that nobody uses. > > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Andy Shevchenko Reviewed-by: Daniel Thompson > --- >

Re: [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

2019-07-24 Thread Kalle Valo
Eugeniu Rosca wrote: > The wl1837mod datasheet [1] says about the WL_IRQ pin: > > ---8<--- > SDIO available, interrupt out. Active high. [..] > Set to rising edge (active high) on powerup. > ---8<--- > > That's the reason of seeing the interrupt configured as: > - IRQ_TYPE_EDGE_RISING on

Re: [PATCH v3 7/7] backlight: gpio: use a helper variable for >dev

2019-07-24 Thread Daniel Thompson
On Wed, Jul 24, 2019 at 10:25:08AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Instead of dereferencing pdev each time, use a helper variable for > the associated device pointer. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Daniel Thompson > --- >

Re: [RFC/RFT 5/5] phy: exynos5-usbdrd: drop duplicate setting PIPE3 tune signal

2019-07-24 Thread Krzysztof Kozlowski
On Mon, 22 Jul 2019 at 21:00, Anand Moon wrote: > > Drop duplicate configuration setting of PIPE tune signal. There is no duplicate set. This is either completely wrong or put in wrong order of entire patchset... Best regards, Krzysztof

Re: [PATCH v4 20/24] PM / devfreq: tegra30: Optimize upper average watermark selection

2019-07-24 Thread Chanwoo Choi
On 19. 7. 20. 오전 2:52, Dmitry Osipenko wrote: > 19.07.2019 9:11, Chanwoo Choi пишет: >> On 19. 7. 19. 오후 3:09, Chanwoo Choi wrote: >>> On 19. 7. 19. 오전 11:21, Dmitry Osipenko wrote: В Fri, 19 Jul 2019 11:06:05 +0900 Chanwoo Choi пишет: > On 19. 7. 19. 오전 10:59, Dmitry Osipenko

Re: [PATCH v4 20/24] PM / devfreq: tegra30: Optimize upper average watermark selection

2019-07-24 Thread Chanwoo Choi
On 19. 7. 24. 오후 8:17, Chanwoo Choi wrote: > On 19. 7. 20. 오전 2:52, Dmitry Osipenko wrote: >> 19.07.2019 9:11, Chanwoo Choi пишет: >>> On 19. 7. 19. 오후 3:09, Chanwoo Choi wrote: On 19. 7. 19. 오전 11:21, Dmitry Osipenko wrote: > В Fri, 19 Jul 2019 11:06:05 +0900 > Chanwoo Choi пишет:

Re: [PATCH] arm64: dts: qcom: msm8998: Node ordering, address cleanups

2019-07-24 Thread Marc Gonzalez
On 22/07/2019 18:58, Jeffrey Hugo wrote: > DT nodes should be ordered by address, then node name, and finally label. > The msm8998 dtsi does not follow this, so clean it up by reordering the > nodes. While we are at it, extend the addresses to be fully 32-bits wide > so that ordering is easy to

Re: [PATCH] x86: Fix possible null-pointer dereferences in untrack_pfn()

2019-07-24 Thread Thomas Gleixner
On Tue, 23 Jul 2019, Jia-Ju Bai wrote: > In untrack_pfn(), there is an if statement on line 1058 to check whether > vma is NULL: > if (vma && !(vma->vm_flags & VM_PAT)) > > When vma is NULL, vma is used on line 1064: > if (follow_phys(vma, vma->vm_start, 0, , )) > and line 1069: >

Re: [PATCH 1/2] kernel/fork: Add support for stack-end guard page

2019-07-24 Thread Mark Rutland
On Wed, Jul 24, 2019 at 11:11:49AM +0200, Dmitry Vyukov wrote: > On Tue, Jul 23, 2019 at 6:41 PM Mark Rutland wrote: > > > > On Fri, Jul 19, 2019 at 03:28:17PM +0200, Marco Elver wrote: > > > Enabling STACK_GUARD_PAGE helps catching kernel stack overflows > > > immediately > > > rather than

Re: [PATCH 2/2] lib/test_kasan: Add stack overflow test

2019-07-24 Thread Mark Rutland
On Tue, Jul 23, 2019 at 06:49:03PM +0200, Marco Elver wrote: > On Tue, 23 Jul 2019 at 18:24, Mark Rutland wrote: > > > > On Fri, Jul 19, 2019 at 03:28:18PM +0200, Marco Elver wrote: > > > Adds a simple stack overflow test, to check the error being reported on > > > an overflow. Without

[PATCH net-next 00/10] Use dev_get_drvdata where possible

2019-07-24 Thread Chuhong Yuan
These patches use dev_get_drvdata instead of using to_pci_dev + pci_get_drvdata to make code simpler. Chuhong Yuan (10): net: marvell: Use dev_get_drvdata where possible forcedeth: Use dev_get_drvdata where possible sfc: Use dev_get_drvdata where possible sfc-falcon: Use dev_get_drvdata

[PATCH net-next 01/10] net: marvell: Use dev_get_drvdata where possible

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/net/ethernet/marvell/skge.c | 6 ++ drivers/net/ethernet/marvell/sky2.c | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git

[PATCH net-next 02/10] forcedeth: Use dev_get_drvdata where possible

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/net/ethernet/nvidia/forcedeth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/nvidia/forcedeth.c

[PATCH net-next 03/10] sfc: Use dev_get_drvdata where possible

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/net/ethernet/sfc/ef10.c | 4 ++-- drivers/net/ethernet/sfc/efx.c | 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH net-next 04/10] sfc-falcon: Use dev_get_drvdata where possible

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/net/ethernet/sfc/falcon/efx.c | 6 +++--- drivers/net/ethernet/sfc/falcon/falcon_boards.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff

[PATCH net-next 05/10] ath: Use dev_get_drvdata where possible

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/net/wireless/ath/ath5k/pci.c| 3 +-- drivers/net/wireless/ath/ath9k/pci.c| 5 ++--- drivers/net/wireless/ath/wil6210/pcie_bus.c | 6 ++ 3 files

[PATCH net-next 06/10] iwlegacy: Use dev_get_drvdata where possible

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/net/wireless/intel/iwlegacy/common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlegacy/common.c

[PATCH net-next 07/10] iwlwifi: Use dev_get_drvdata where possible

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c

[PATCH net-next 08/10] mwifiex: pcie: Use dev_get_drvdata

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/net/wireless/marvell/mwifiex/pcie.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c

[PATCH net-next 10/10] rtlwifi: rtl_pci: Use dev_get_drvdata

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/net/wireless/realtek/rtlwifi/pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c

[PATCH net-next 09/10] qtnfmac_pcie: Use dev_get_drvdata

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c

Re: [PATCH v12 3/9] drivers: memory: extend of_memory by LPDDR3 support

2019-07-24 Thread Krzysztof Kozlowski
On Mon, 22 Jul 2019 at 11:47, Lukasz Luba wrote: > > The patch adds AC timings information needed to support LPDDR3 and memory > controllers. The structure is used in of_memory and currently in Exynos > 5422 DMC. Add parsing data needed for LPDDR3 support. > It is currently used in Exynos5422

Re: [PATCH] RDMA/hns: Fix build error

2019-07-24 Thread Jason Gunthorpe
On Wed, Jul 24, 2019 at 02:54:43PM +0800, YueHaibing wrote: > If INFINIBAND_HNS_HIP08 is selected and HNS3 is m, > but INFINIBAND_HNS is y, building fails: > > drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_exit': > hns_roce_hw_v2.c:(.exit.text+0xd): undefined reference

Re: [RFC PATCH] fbcon: fix ypos over boundary issue

2019-07-24 Thread Daniel Vetter
On Fri, Jul 12, 2019 at 03:13:36AM +, Zenghui Yu wrote: > From: Feng Tiantian > > While using "top" on a CentOS guest's VNC-client, then continuously press > "Shift+PgUp", the guest kernel will get panic! Backtrace is attached below. > We tested it on 5.2.0, and the issue remains. > > [

Re: [PATCH v2 2/2] mwifiex: Make use of the new sdio_trigger_replug() API to reset

2019-07-24 Thread Kalle Valo
Douglas Anderson wrote: > As described in the patch ("mmc: core: Add sdio_trigger_replug() > API"), the current mwifiex_sdio_card_reset() is broken in the cases > where we're running Bluetooth on a second SDIO func on the same card > as WiFi. The problem goes away if we just use the >

RE: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool

2019-07-24 Thread Jose Abreu
From: Jon Hunter Date: Jul/24/2019, 12:10:47 (UTC+00:00) > > On 24/07/2019 11:04, Jose Abreu wrote: > > ... > > > Jon, I was able to replicate (at some level) your setup: > > > > # dmesg | grep -i arm-smmu > > [1.337322] arm-smmu 7004.iommu: probing hardware > > configuration... > >

Re: [PATCH] x86: Fix possible null-pointer dereferences in untrack_pfn()

2019-07-24 Thread Thomas Gleixner
On Wed, 24 Jul 2019, Thomas Gleixner wrote: > On Tue, 23 Jul 2019, Jia-Ju Bai wrote: > > > In untrack_pfn(), there is an if statement on line 1058 to check whether > > vma is NULL: > > if (vma && !(vma->vm_flags & VM_PAT)) > > > > When vma is NULL, vma is used on line 1064: > > if

Re: [PATCH] drivers: net: wireless: rsi: return explicit error values

2019-07-24 Thread Kalle Valo
"Enrico Weigelt, metux IT consult" wrote: > From: Enrico Weigelt > > Explicitly return constants instead of variable (and rely on > it to be explicitly initialized), if the value is supposed > to be fixed anyways. Align it with the rest of the driver, > which does it the same way. > >

Re: [PATCH v8 2/4] uprobe: use original page when all uprobes are removed

2019-07-24 Thread Oleg Nesterov
On 07/24, Song Liu wrote: > > lock_page(old_page); > @@ -177,15 +180,24 @@ static int __replace_page(struct vm_area_struct *vma, > unsigned long addr, > mmu_notifier_invalidate_range_start(); > err = -EAGAIN; > if (!page_vma_mapped_walk()) { > -

Re: [PATCH] marvell wireless: cleanup -- make error values consistent

2019-07-24 Thread Kalle Valo
Pavel Machek wrote: > Surrounding code uses -ERRNO as a result, so don't pass plain -1. > > Signed-off-by: Pavel Machek The title prefix should be "mwifiex:", I'll fix that. -- https://patchwork.kernel.org/patch/11056525/

Re: [PATCH v12 3/9] drivers: memory: extend of_memory by LPDDR3 support

2019-07-24 Thread Krzysztof Kozlowski
On Mon, 22 Jul 2019 at 11:47, Lukasz Luba wrote: > > The patch adds AC timings information needed to support LPDDR3 and memory > controllers. The structure is used in of_memory and currently in Exynos > 5422 DMC. Add parsing data needed for LPDDR3 support. > It is currently used in Exynos5422

Re: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms

2019-07-24 Thread Joe Perches
On Tue, 2019-07-23 at 14:36 -0700, Kees Cook wrote: > On Mon, Jul 22, 2019 at 05:38:15PM -0700, Joe Perches wrote: > > Several uses of strlcpy and strscpy have had defects because the > > last argument of each function is misused or typoed. > > > > Add macro mechanisms to avoid this defect. > >

[PATCH v2 2/3] sgi-gru: Remove CONFIG_HUGETLB_PAGE ifdef

2019-07-24 Thread Bharath Vedartham
is_vm_hugetlb_page has checks for whether CONFIG_HUGETLB_PAGE is defined or not. If CONFIG_HUGETLB_PAGE is not defined is_vm_hugetlb_page will always return false. There is no need to have an uneccessary CONFIG_HUGETLB_PAGE check in the code. Cc: Ira Weiny Cc: John Hubbard Cc: Jérôme Glisse

[PATCH v2 1/3] sgi-gru: Convert put_page() to get_user_page*()

2019-07-24 Thread Bharath Vedartham
For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions"). Cc: Ira Weiny Cc: John

[PATCH v2 0/3] sgi-gru: get_user_page changes

2019-07-24 Thread Bharath Vedartham
This is version 2 of the patch series with a few non-functional changes. Changes are described in the individual changelog. This patch series incorporates a few changes in the get_user_page usage of sgi-gru. The main change is the first patch, which is a trivial one line change to convert

Re: [PATCH] checkpatch: Added warnings in favor of strscpy().

2019-07-24 Thread Joe Perches
On Mon, 2019-07-22 at 16:28 -0600, Jonathan Corbet wrote: > On Mon, 22 Jul 2019 15:24:33 -0700 > Joe Perches wrote: > > > > If the functions themselves are fully defined in the .h file, I'd just add > > > the kerneldoc there as well. That's how it's usually done, and you want > > > to keep the

[PATCH v2 3/3] sgi-gru: Use __get_user_pages_fast in atomic_pte_lookup

2019-07-24 Thread Bharath Vedartham
*pte_lookup functions get the physical address for a given virtual address by getting a physical page using gup and use page_to_phys to get the physical address. Currently, atomic_pte_lookup manually walks the page tables. If this function fails to get a physical page, it will fall back too

Re: [PATCH v3 7/7] backlight: gpio: use a helper variable for >dev

2019-07-24 Thread Andy Shevchenko
On Wed, Jul 24, 2019 at 10:25:08AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Instead of dereferencing pdev each time, use a helper variable for > the associated device pointer. Reviewed-by: Andy Shevchenko > > Signed-off-by: Bartosz Golaszewski > --- >

Re: [PATCH] rsi: return explicit error values

2019-07-24 Thread Kalle Valo
"Enrico Weigelt, metux IT consult" wrote: > From: Enrico Weigelt > > Explicitly return constants instead of variable (and rely on > it to be explicitly initialized), if the value is supposed > to be fixed anyways. Align it with the rest of the driver, > which does it the same way. > >

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-24 Thread Viresh Kumar
On 23-07-19, 12:27, Rafael J. Wysocki wrote: > On Tue, Jul 23, 2019 at 11:15 AM Viresh Kumar wrote: > > Though there is one difference between intel_cpufreq and acpi_cpufreq, > > intel_cpufreq has fast_switch_possible=true and so it uses slightly > > different path in schedutil. I tried to look

Re: [PATCH v2 2/2] rt2x00usb: remove unnecessary rx flag checks

2019-07-24 Thread Kalle Valo
Soeren Moch wrote: > In contrast to the TX path, there is no need to separately read the transfer > status from the device after receiving RX data. Consequently, there is no > real STATUS_PENDING RX processing queue entry state. > Remove the unnecessary ENTRY_DATA_STATUS_PENDING flag checks from

Re: [PATCH v2] rtl8xxxu: Fix wifi low signal strength issue of RTL8723BU

2019-07-24 Thread Kalle Valo
Chris Chiu wrote: > The WiFi tx power of RTL8723BU is extremely low after booting. So > the WiFi scan gives very limited AP list and it always fails to > connect to the selected AP. This module only supports 1x1 antenna > and the antenna is switched to bluetooth due to some incorrect > register

Re: [PATCH] libertas: remove redundant assignment to variable ret

2019-07-24 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized with a value that is never > read and it is being updated later with a new value. The > initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King

Re: [PATCH] wl3501_cs: remove redundant variable rc

2019-07-24 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > The variable rc is being initialized with a value that is never > read and it is being updated later with a new value that is returned. > The variable is redundant and can be replaced with a return 0 as > there are no other return points in this

Re: [PATCH] coresight: fix typos

2019-07-24 Thread Pavel Machek
On Wed 2019-07-24 11:36:23, Suzuki K Poulose wrote: > > > On 24/07/2019 11:03, Pavel Machek wrote: > > > >Fix typos in comments. > > > >Signed-off-by: Pavel Machek > > > >diff --git a/drivers/hwtracing/coresight/coresight.c > >b/drivers/hwtracing/coresight/coresight.c > >index

Re: [PATCH v2 3/4] arm64: Make debug exception handlers visible from RCU

2019-07-24 Thread Masami Hiramatsu
On Tue, 23 Jul 2019 18:07:56 +0100 James Morse wrote: > Hi, > > On 22/07/2019 08:48, Masami Hiramatsu wrote: > > Make debug exceptions visible from RCU so that synchronize_rcu() > > correctly track the debug exception handler. > > > > This also introduces sanity checks for user-mode exceptions

Re: [PATCH] RDMA/hns: Fix build error

2019-07-24 Thread Yuehaibing
On 2019/7/24 19:32, Jason Gunthorpe wrote: > On Wed, Jul 24, 2019 at 02:54:43PM +0800, YueHaibing wrote: >> If INFINIBAND_HNS_HIP08 is selected and HNS3 is m, >> but INFINIBAND_HNS is y, building fails: >> >> drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function >> `hns_roce_hw_v2_exit': >>

Re: [PATCH 09/12] rtw88: Fix misuse of GENMASK macro

2019-07-24 Thread Kalle Valo
Joe Perches wrote: > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches > Acked-by: Yan-Hsuan Chuang Patch applied to wireless-drivers-next.git, thanks. 5ff29d836d1b rtw88: Fix misuse of GENMASK macro -- https://patchwork.kernel.org/patch/11037805/

Re: [PATCH 1/2] block: drbd: Fix a possible null-pointer dereference in receive_protocol()

2019-07-24 Thread Roland Kammerer
On Wed, Jul 24, 2019 at 11:49:16AM +0800, Jia-Ju Bai wrote: > In receive_protocol(), when crypto_alloc_shash() on line 3754 fails, > peer_integrity_tfm is NULL, and error handling code is executed. > In this code, crypto_free_shash() is called with NULL, which can cause a > null-pointer

Re: [PATCH] libertas: Add missing sentinel at end of if_usb.c fw_table

2019-07-24 Thread Kalle Valo
Kevin Easton wrote: > This sentinel tells the firmware loading process when to stop. > > Reported-and-tested-by: syzbot+98156c174c5a2cad9...@syzkaller.appspotmail.com > Signed-off-by: Kevin Easton Patch applied to wireless-drivers-next.git, thanks. 764f3f1ecffc libertas: Add missing sentinel

Re: [PATCH v4 1/2] rtw88: pci: Rearrange the memory usage for skb in RX ISR

2019-07-24 Thread Kalle Valo
Jian-Hong Pan wrote: > Testing with RTL8822BE hardware, when available memory is low, we > frequently see a kernel panic and system freeze. > > First, rtw_pci_rx_isr encounters a memory allocation failure (trimmed): > > rx routine starvation > WARNING: CPU: 7 PID: 9871 at

Re: [RFC PATCH] ceph: fix directories inode i_blkbits initialization

2019-07-24 Thread Jeff Layton
On Wed, 2019-07-24 at 11:04 +0100, Luis Henriques wrote: > Luis Henriques writes: > > > "Jeff Layton" writes: > > > > > On Tue, 2019-07-23 at 16:50 +0100, Luis Henriques wrote: > > > > When filling an inode with info from the MDS, i_blkbits is being > > > > initialized using fl_stripe_unit,

Hello Dear Friend

2019-07-24 Thread Nicole Marois
HELLO DEAR. I’m Mrs. Nicole Maoris a manager in HSBC BANK in Spain Madrid, I am sending this brief letter to seek for your partnership and long term relationship, I have an important and urgent issue I want to discuss with you privately about transaction fund worth the sum of $9.5m

Re: [PATCH] rtlwifi: btcoex: fix issue possible condition with no effect (if == else)

2019-07-24 Thread Kalle Valo
Hariprasad Kelam wrote: > fix below issue reported by coccicheck > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:514:1-3: > WARNING: possible condition with no effect (if == else) > > Signed-off-by: Hariprasad Kelam > Acked-by: Ping-Ke Shih Patch applied to

Re: [PATCH v2] libertas_tf: Use correct channel range in lbtf_geo_init

2019-07-24 Thread Kalle Valo
YueHaibing wrote: > It seems we should use 'range' instead of 'priv->range' > in lbtf_geo_init(), because 'range' is the corret one > related to current regioncode. > > Reported-by: Hulk Robot > Fixes: 691cdb49388b ("libertas_tf: command helper functions for libertas_tf") > Signed-off-by:

Re: [PATCH 2/2] mm/hmm: make full use of walk_page_range()

2019-07-24 Thread Jason Gunthorpe
On Wed, Jul 24, 2019 at 08:51:46AM +0200, Christoph Hellwig wrote: > On Tue, Jul 23, 2019 at 04:30:16PM -0700, Ralph Campbell wrote: > > hmm_range_snapshot() and hmm_range_fault() both call find_vma() and > > walk_page_range() in a loop. This is unnecessary duplication since > > walk_page_range()

How to turn scheduler tick on for current nohz_full CPU?

2019-07-24 Thread Paul E. McKenney
Hello! One of the callback-invocation forward-progress issues turns out to be nohz_full CPUs not turning their scheduling-clock interrupt back on when running in kernel mode. Given that callback floods can cause RCU's callback-invocation loop to run for some time, it would be good for this loop

Re: [PATCH net-next 00/10] Use dev_get_drvdata where possible

2019-07-24 Thread Kalle Valo
Chuhong Yuan writes: > These patches use dev_get_drvdata instead of > using to_pci_dev + pci_get_drvdata to make > code simpler. > > Chuhong Yuan (10): > net: marvell: Use dev_get_drvdata where possible > forcedeth: Use dev_get_drvdata where possible > sfc: Use dev_get_drvdata where

Re: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool

2019-07-24 Thread Jon Hunter
On 24/07/2019 12:34, Jose Abreu wrote: > From: Jon Hunter > Date: Jul/24/2019, 12:10:47 (UTC+00:00) > >> >> On 24/07/2019 11:04, Jose Abreu wrote: >> >> ... >> >>> Jon, I was able to replicate (at some level) your setup: >>> >>> # dmesg | grep -i arm-smmu >>> [1.337322] arm-smmu

[PATCH] ip6_gre: reload ipv6h in prepare_ip6gre_xmit_ipv6

2019-07-24 Thread Haishuang Yan
Since ip6_tnl_parse_tlv_enc_lim() can call pskb_may_pull() which may change skb->data, so we need to re-load ipv6h at the right place. Fixes: 898b29798e36 ("ip6_gre: Refactor ip6gre xmit codes") Cc: William Tu Signed-off-by: Haishuang Yan --- net/ipv6/ip6_gre.c | 3 ++- 1 file changed, 2

Re: [PATCH 0/8] Backported fixes for 4.4 stable tree

2019-07-24 Thread Greg KH
On Tue, Jul 23, 2019 at 04:38:23PM +0530, Ajay Kaher wrote: > These patches include few backported fixes for the 4.4 stable > tree. > I would appreciate if you could kindly consider including them in the > next release. Why are these needed? From what I remember, the last patch here is only

[PATCH v2 2/3] dt-bindings: IDU-intc: Clean up documentation

2019-07-24 Thread Mischa Jonker
* Some lines exceeded 80 characters. * Clarified statement about AUX register interface Signed-off-by: Mischa Jonker --- .../bindings/interrupt-controller/snps,archs-idu-intc.txt| 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH v2 3/3] dt-bindings: IDU-intc: Add support for edge-triggered interrupts

2019-07-24 Thread Mischa Jonker
This updates the documentation for supporting an optional extra interrupt cell to specify edge vs level triggered. Signed-off-by: Mischa Jonker --- .../interrupt-controller/snps,archs-idu-intc.txt | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git

[PATCH v2 1/3] ARCv2: IDU-intc: Add support for edge-triggered interrupts

2019-07-24 Thread Mischa Jonker
This adds support for an optional extra interrupt cell to specify edge vs level triggered. It is backward compatible with dts files with only one cell, and will default to level-triggered in such a case. Note that I had to make a change to idu_irq_set_affinity as well, as this function was

memory leak in v9fs_session_init

2019-07-24 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:abdfd52a Merge tag 'armsoc-defconfig' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=163046afa0 kernel config: https://syzkaller.appspot.com/x/.config?x=d31de3d88059b7fa

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread maowenan
On 2019/7/24 19:05, Greg KH wrote: > On Wed, Jul 24, 2019 at 05:17:15PM +0800, Mao Wenan wrote: >> There is one report about tcp_write_xmit use-after-free with version 4.4.136: >> >> BUG: KASAN: use-after-free in tcp_skb_pcount include/net/tcp.h:796 [inline] >> BUG: KASAN: use-after-free in

[PATCH] ALSA: core: Fix possible null-pointer dereferences in snd_timer_proc_read()

2019-07-24 Thread Jia-Ju Bai
In snd_timer_proc_read(), there is an if statement on line 1204 to check whether timer->card is NULL: if (timer->card && timer->card->shutdown) When timer->card is NULL, it is used on lines 1212 and 1215: timer->card->number Thus, possible null-pointer dereferences may occur. To fix

[GIT PULL] KVM fixes for Linux 5.3-rc2

2019-07-24 Thread Paolo Bonzini
Linus, The following changes since commit 30cd8604323dbaf20a80e797fe7057f5b02e394d: KVM: x86: Add fixed counters to PMU filter (2019-07-20 09:00:48 +0200) are available in the git repository at: https://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus for you to fetch changes up to

Re: [PATCH] KVM: X86: Boost queue head vCPU to mitigate lock waiter preemption

2019-07-24 Thread Paolo Bonzini
On 24/07/19 11:43, Wanpeng Li wrote: > From: Wanpeng Li > > Commit 11752adb (locking/pvqspinlock: Implement hybrid PV queued/unfair locks) > introduces hybrid PV queued/unfair locks > - queued mode (no starvation) > - unfair mode (good performance on not heavily contended lock) > The lock

[PATCH] parport: parport_serial: Use dev_get_drvdata

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/parport/parport_serial.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/parport/parport_serial.c b/drivers/parport/parport_serial.c

[PATCH] nvme-pci: Use dev_get_drvdata where possible

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/nvme/host/pci.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index

[PATCH] media: staging/intel-ipu3: Use dev_get_drvdata where possible

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/staging/media/ipu3/ipu3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/ipu3/ipu3.c b/drivers/staging/media/ipu3/ipu3.c

[PATCH] pcmcia: Use dev_get_drvdata where possible

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/pcmcia/yenta_socket.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c index

[PATCH] platform/x86: ISST: Use dev_get_drvdata

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

[PATCH] thermal: intel: Use dev_get_drvdata

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/thermal/intel/intel_pch_thermal.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/intel/intel_pch_thermal.c

[PATCH] spi: dw-pci: Use dev_get_drvdata

2019-07-24 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/spi/spi-dw-pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-dw-pci.c b/drivers/spi/spi-dw-pci.c index

Re: [PATCH 1/2] printk/panic: Access the main printk log in panic() only when safe

2019-07-24 Thread Petr Mladek
On Tue 2019-07-23 12:13:40, Sergey Senozhatsky wrote: > On (07/19/19 14:57), Petr Mladek wrote: > > But there is one more scenario 3: > > Yes! > > > - we have CPUB which loops or is deadlocked in IRQ context > > > > - we have CPUA which panic()-s the system, but can't bring CPUB down, > >

[PATCH 1/2] perf/record: Fix module size on s390

2019-07-24 Thread Thomas Richter
On s390 the modules loaded in memory have the text segment located after the GOT and Relocation table. This can be seen with this output: [root@m35lp76 perf]# fgrep qeth /proc/modules qeth 151552 1 qeth_l2, Live 0x03ff800b2000 ... [root@m35lp76 perf]# cat

[PATCH 2/2] perf/top: Fix s390 gap between kernel end and module start

2019-07-24 Thread Thomas Richter
During execution of command 'perf top' the error message: Not enough memory for annotating '__irf_end' symbol!) is emitted from this call sequence: __cmd_top perf_top__mmap_read perf_top__mmap_read_idx perf_event__process_sample hist_entry_iter__add

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread maowenan
On 2019/7/24 18:38, maowenan wrote: > > > On 2019/7/24 18:13, Eric Dumazet wrote: >> >> >> On 7/24/19 12:01 PM, Eric Dumazet wrote: >>> >>> >>> On 7/24/19 11:17 AM, Mao Wenan wrote: There is one report about tcp_write_xmit use-after-free with version 4.4.136: >>> >>> Current stable

[PATCH 1/1] ARM: dts: am335x: Fix UARTs length

2019-07-24 Thread Emmanuel Vadot
As seen on the AM335x TRM all the UARTs controller only are 0x1000 in size. Fix this in the DTS. Signed-off-by: Emmanuel Vadot --- arch/arm/boot/dts/am33xx-l4.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi

[PATCH 0/1] ARM: dts: am335x: Fix UARTs length

2019-07-24 Thread Emmanuel Vadot
For some reason the uart region size were set to 0x2000 while the TRM clearly specify that the size is 0x1000. I guess this is not a problem on Linux but for FreeBSD the resource manager will not allow the mapping when the region declared in the parents is less that the one declared in the child.

<    1   2   3   4   5   6   7   8   9   10   >