Re: WARNING in ovl_real_fdget_meta

2019-07-26 Thread Amir Goldstein
On Fri, Jul 26, 2019 at 11:11 AM Amir Goldstein wrote: > > On Thu, Jul 25, 2019 at 7:24 AM syzbot > wrote: > > > > syzbot has bisected this bug to: > > > > commit 387e3746d01c34457d6a73688acd90428725070b > > Author: Amir Goldstein > > Date: Fri Jun 7 14:24:38 2019 + > > > > locks:

Re: [PATCH 7/9] media: hantro: Add core bits to support H264 decoding

2019-07-26 Thread Boris Brezillon
On Thu, 25 Jul 2019 15:31:41 +0200 Rasmus Villemoes wrote: > On 19/06/2019 14.15, Boris Brezillon wrote: > > From: Hertz Wong > > > > Add helpers and patch hantro_{drv,v4l2}.c to prepare addition of H264 > > decoding support. > > > > Signed-off-by: Hertz Wong > > Signed-off-by: Boris

Re: [PATCH v2 1/2] dt-bindings: vendor-prefixes: Add Admatec AG

2019-07-26 Thread Schrempf Frieder
On 26.07.19 12:02, Krzysztof Kozlowski wrote: > On Fri, 26 Jul 2019 at 11:48, Schrempf Frieder > wrote: >> >> On 26.07.19 08:17, Krzysztof Kozlowski wrote: >>> Add vendor prefix for Admatec AG. >> >> We get the displays used with the Kontron eval kits from "admatec GmbH" >> in Hamburg, not

Re: [PATCH 1/2] ipmr: Make cache queue length configurable

2019-07-26 Thread Stephen Suryaputra
On Fri, Jul 26, 2019 at 08:42:29AM +1200, Brodie Greenfield wrote: > We want to be able to keep more spaces available in our queue for > processing incoming multicast traffic (adding (S,G) entries) - this lets > us learn more groups faster, rather than dropping them at this stage. > >

Re: [PATCH 2/2] ip6mr: Make cache queue length configurable

2019-07-26 Thread Stephen Suryaputra
On Fri, Jul 26, 2019 at 08:42:30AM +1200, Brodie Greenfield wrote: > We want to be able to keep more spaces available in our queue for > processing incoming IPv6 multicast traffic (adding (S,G) entries) - this > lets us learn more groups faster, rather than dropping them at this stage. > >

Re: [PATCH 1/5] sched/deadline: Fix double accounting of rq/running bw in push_dl_task()

2019-07-26 Thread luca abeni
Hi Dietmar, On Fri, 26 Jul 2019 09:27:52 +0100 Dietmar Eggemann wrote: > push_dl_task() always calls deactivate_task() with flags=0 which sets > p->on_rq=TASK_ON_RQ_MIGRATING. Uhm... This is a recent change in the deactivate_task() behaviour, right? Because I tested SCHED_DEADLINE a lot, but

Re: [PATCH v3 2/5] mm: Introduce a new Vmemmap page-type

2019-07-26 Thread Oscar Salvador
On Fri, Jul 26, 2019 at 11:41:46AM +0200, David Hildenbrand wrote: > > static void __meminit __init_single_page(struct page *page, unsigned long > > pfn, > > unsigned long zone, int nid) > > { > > if (PageVmemmap(page)) > > /* > >

Re: [RFC PATCH 23/40] soundwire: stream: fix disable sequence

2019-07-26 Thread Cezary Rojewski
On 2019-07-26 01:40, Pierre-Louis Bossart wrote: - return do_bank_switch(stream); + ret = do_bank_switch(stream); + if (ret < 0) { + dev_err(bus->dev, "Bank switch failed: %d\n", ret); + return ret; + } + + /* make sure alternate bank

Re: [Regression] Missing device nodes for ETR, ETF and STM after CONFIG_UEVENT_HELPER=n

2019-07-26 Thread Sai Prakash Ranjan
On 7/26/2019 3:14 PM, Sai Prakash Ranjan wrote: On 7/26/2019 2:11 PM, Greg Kroah-Hartman wrote: On Fri, Jul 26, 2019 at 01:50:27PM +0530, Sai Prakash Ranjan wrote: On 7/26/2019 12:34 PM, Greg Kroah-Hartman wrote: On Fri, Jul 26, 2019 at 11:49:19AM +0530, Sai Prakash Ranjan wrote: Hi, When

[PATCH 1/3 v2] fs: ocfs2: Fix possible null-pointer dereferences in ocfs2_xa_prepare_entry()

2019-07-26 Thread Jia-Ju Bai
In ocfs2_xa_prepare_entry(), there is an if statement on line 2136 to check whether loc->xl_entry is NULL: if (loc->xl_entry) When loc->xl_entry is NULL, it is used on line 2158: ocfs2_xa_add_entry(loc, name_hash); loc->xl_entry->xe_name_hash = cpu_to_le32(name_hash);

Re: [PATCH 2/3] drm/panel: jh057n00900: Move mipi_dsi_dcs_set_display_off to disable()

2019-07-26 Thread Sam Ravnborg
Hi Guido. On Fri, Jul 26, 2019 at 11:21:42AM +0200, Guido Günther wrote: > This makes it symmetric with the panel init happening in enable(). > > Signed-off-by: Guido Günther > --- > drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 10 +++--- > 1 file changed, 7 insertions(+), 3

[PATCH] of: Fix typo in kerneldoc

2019-07-26 Thread Thierry Reding
From: Thierry Reding "Findfrom" is not a word. Replace the function synopsis by something that makes sense. Signed-off-by: Thierry Reding --- include/linux/of.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/of.h b/include/linux/of.h index

Re: [PATCH 5/5] sched/deadline: Use return value of SCHED_WARN_ON() in bw accounting

2019-07-26 Thread luca abeni
Hi Dietmar, On Fri, 26 Jul 2019 09:27:56 +0100 Dietmar Eggemann wrote: > To make the decision whether to set rq or running bw to 0 in underflow > case use the return value of SCHED_WARN_ON() rather than an extra if > condition. I think I tried this at some point, but if I remember well this

Re: [Regression] Missing device nodes for ETR, ETF and STM after CONFIG_UEVENT_HELPER=n

2019-07-26 Thread Greg Kroah-Hartman
On Fri, Jul 26, 2019 at 03:44:40PM +0530, Sai Prakash Ranjan wrote: > On 7/26/2019 3:14 PM, Sai Prakash Ranjan wrote: > > On 7/26/2019 2:11 PM, Greg Kroah-Hartman wrote: > > > On Fri, Jul 26, 2019 at 01:50:27PM +0530, Sai Prakash Ranjan wrote: > > > > On 7/26/2019 12:34 PM, Greg Kroah-Hartman

Re: [RFC PATCH 24/40] soundwire: cadence_master: use BIOS defaults for frame shape

2019-07-26 Thread Cezary Rojewski
On 2019-07-26 01:40, Pierre-Louis Bossart wrote: +static u32 cdns_set_default_frame_shape(int n_rows, int n_cols) +{ + u32 val; + int c; + int r; + + r = sdw_find_row_index(n_rows); + c = sdw_find_col_index(n_cols); + + val = (r << 3) | c; + + return

Re: [PATCH v2] mm: memcontrol: fix use after free in mem_cgroup_iter()

2019-07-26 Thread Miles Chen
Hi Johannes, I post patch v2 with proper comment you mentioned. (I am not sure if I can copy your acked-by to patch v2 directly) Miles On Fri, 2019-07-26 at 10:12 +0800, Miles Chen wrote: > This patch is sent to report an use after free in mem_cgroup_iter() > after merging commit: be2657752e9e

[PATCH v3] input: touchscreen: wm97xx-core: Fix possible null-pointer dereferences in wm97xx_ts_input_open()

2019-07-26 Thread Jia-Ju Bai
In wm97xx_ts_input_open(), there is an if statement on line 507 to check whether wm->mach_ops is NULL: if (wm->mach_ops && wm->mach_ops->acc_enabled) When wm->mach_ops is NULL, it is used on line 521: wm97xx_init_pen_irq(wm); BUG_ON(!wm->mach_ops->irq_enable);

Re: [Regression] Missing device nodes for ETR, ETF and STM after CONFIG_UEVENT_HELPER=n

2019-07-26 Thread Sai Prakash Ranjan
On 7/26/2019 3:49 PM, Greg Kroah-Hartman wrote: On Fri, Jul 26, 2019 at 03:44:40PM +0530, Sai Prakash Ranjan wrote: On 7/26/2019 3:14 PM, Sai Prakash Ranjan wrote: On 7/26/2019 2:11 PM, Greg Kroah-Hartman wrote: On Fri, Jul 26, 2019 at 01:50:27PM +0530, Sai Prakash Ranjan wrote: On 7/26/2019

RE: [PATCH] platform: release resource itself instead of resource tree

2019-07-26 Thread Chang, Junxiao
Hi Greg, Thank you for looking at it. Below example is simplified description. Our detail problem is: 1. ACPI driver registers a MEM resource during bootup; 2. Our PUNIT(Intel CPU power management module) platform device reads ACPI driver's resource, and registers same MEM resource; 3.

Re: [PATCH 4.19 079/271] x86/atomic: Fix smp_mb__{before,after}_atomic()

2019-07-26 Thread Jari Ruusu
Greg Kroah-Hartman wrote: > [ Upstream commit 69d927bba39517d0980462efc051875b7f4db185 ] > > Recent probing at the Linux Kernel Memory Model uncovered a > 'surprise'. Strongly ordered architectures where the atomic RmW > primitive implies full memory ordering and > smp_mb__{before,after}_atomic()

Re: [PATCH 3/8] clk: meson: gxbb: migrate to the new parent description method

2019-07-26 Thread Alexandre Mergnat
Le jeu. 25 juil. 2019 à 19:09, Chen-Yu Tsai a écrit : > > On Thu, Jul 25, 2019 at 10:50 PM Jerome Brunet wrote: > > > > On Mon 22 Jul 2019 at 11:54, Alexandre Mergnat > > wrote: > > > > > > > @@ -1592,13 +1737,29 @@ static struct clk_regmap gxbb_vid_pll_div = { > > > .hw.init = &(struct

Re: [RFC PATCH 29/40] soundwire: intel_init: add kernel module parameter to filter out links

2019-07-26 Thread Cezary Rojewski
On 2019-07-26 01:40, Pierre-Louis Bossart wrote: @@ -83,6 +87,9 @@ static struct sdw_intel_ctx caps = ioread32(res->mmio_base + SDW_SHIM_BASE + SDW_SHIM_LCAP); caps &= GENMASK(2, 0); + dev_dbg(>dev, "SoundWire links: BIOS count %d hardware caps %d\n", + count,

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-26 Thread Michal Hocko
On Fri 26-07-19 10:57:52, David Hildenbrand wrote: > On 26.07.19 10:44, Michal Hocko wrote: > > On Fri 26-07-19 10:36:42, David Hildenbrand wrote: > >> On 26.07.19 10:31, Michal Hocko wrote: > > [...] > >>> Anyway, my dislike of the device_hotplug_lock persists. I would really > >>> love to see it

Re: [PATCH] pata_ali: check the pci_get_device failure

2019-07-26 Thread Bartlomiej Zolnierkiewicz
Hi, On 7/25/19 3:25 AM, Navid Emamdoost wrote: > pci_get_device may fail and return NULL. This eventually will be > dereferenced in __pci_register_driver. So null check is necessary. I'm sorry to say this but the patch is incorrect and should not be applied. ALI M1533 ISA bridge presence is

Re: [PATCH v3] input: touchscreen: wm97xx-core: Fix possible null-pointer dereferences in wm97xx_ts_input_open()

2019-07-26 Thread Charles Keepax
On Fri, Jul 26, 2019 at 06:23:26PM +0800, Jia-Ju Bai wrote: > In wm97xx_ts_input_open(), there is an if statement on line 507 to check > whether wm->mach_ops is NULL: > if (wm->mach_ops && wm->mach_ops->acc_enabled) > > When wm->mach_ops is NULL, it is used on line 521: >

Re: [PATCH] ARM: dts: add device tree for Mecer Xtreme Mini S6

2019-07-26 Thread Justin Swartz
Hi Heiko, On 2019-07-26 00:19, Heiko Stuebner wrote: please add an entry to Documentation/devicetree/bindings/arm/rockchip.yaml for your board and if necessary also a vendor-prefix to Documentation/devicetree/bindings/vendor-prefixes.(yaml?) OK please sort the alphabetically. OK + {

Re: [PATCH 00/15] thermal: qcom: tsens: Add interrupt support

2019-07-26 Thread Brian Masney
Hi Amit, On Fri, Jul 26, 2019 at 03:48:35AM +0530, Amit Kucheria wrote: > Add interrupt support to TSENS. The first 6 patches are general fixes and > cleanups to the driver before interrupt support is introduced. > > This series has been developed against qcs404 and sdm845 and then tested on >

Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()

2019-07-26 Thread David Hildenbrand
On 26.07.19 12:31, Michal Hocko wrote: > On Fri 26-07-19 10:57:52, David Hildenbrand wrote: >> On 26.07.19 10:44, Michal Hocko wrote: >>> On Fri 26-07-19 10:36:42, David Hildenbrand wrote: On 26.07.19 10:31, Michal Hocko wrote: >>> [...] > Anyway, my dislike of the device_hotplug_lock

Re: [RFC PATCH 31/40] soundwire: intel: move shutdown() callback and don't export symbol

2019-07-26 Thread Cezary Rojewski
On 2019-07-26 01:40, Pierre-Louis Bossart wrote: +void intel_shutdown(struct snd_pcm_substream *substream, + struct snd_soc_dai *dai) +{ + struct sdw_cdns_dma_data *dma; + + dma = snd_soc_dai_get_dma_data(dai, substream); + if (!dma) + return; +

Re: [PATCH 1/4] ACPI: PM: Set up EC GPE for system wakeup from drivers that need it

2019-07-26 Thread Andy Shevchenko
On Fri, Jul 26, 2019 at 1:57 AM Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > The EC GPE needs to be set up for system wakeup only if there is a > driver depending on it, either intel-hid or intel-vbtn, bound to a > button device that is expected to wake up the system from sleep (such

Re: [PATCH 3/5] sched/fair: rework load_balance

2019-07-26 Thread Valentin Schneider
On 26/07/2019 10:01, Vincent Guittot wrote: >> Huh, interesting. Why go for utilization? > > Mainly because that's what is used to detect a misfit task and not the load > >> >> Right now we store the load of the task and use it to pick the "biggest" >> misfit (in terms of load) when there are

Re: bpf: test_verifier: sanitation: alu with different scalars

2019-07-26 Thread Yauheni Kaliuta
Hi, Daniel, On Tue, Jun 25, 2019 at 12:39 PM Daniel Borkmann wrote: > > On 06/25/2019 10:29 AM, Yauheni Kaliuta wrote: > > Hi! > > > > I'm wondering, how the sanitaion tests (#903 5.2-rc6 for example) > > are supposed to work on BE arches: > > > > { > > "sanitation: alu with different

Re: [RFC PATCH 32/40] soundwire: intel: add helper for initialization

2019-07-26 Thread Cezary Rojewski
On 2019-07-26 01:40, Pierre-Louis Bossart wrote: Move code to helper for reuse in power management routines Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/intel.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/soundwire/intel.c

Re: [PATCH] regulator: of: Add of_node_put() before return in function

2019-07-26 Thread Mark Brown
On Fri, Jul 26, 2019 at 01:02:52PM +0530, Nishka Dasgupta wrote: > On 24/07/19 9:17 PM, Mark Brown wrote: > > On Wed, Jul 24, 2019 at 02:02:31PM +0530, Nishka Dasgupta wrote: > > > The local variable search in regulator_of_get_init_node takes the value > > > returned by either

[PATCH] iio: maxim_thermocouple: Use device-managed APIs

2019-07-26 Thread Chuhong Yuan
Use device-managed APIs to simplify the code. The remove functions are redundant now and can be deleted. Signed-off-by: Chuhong Yuan --- drivers/iio/temperature/maxim_thermocouple.c | 23 1 file changed, 4 insertions(+), 19 deletions(-) diff --git

Re: [PATCH v2 1/1] platform/x86/pcengines-apuv2: add mpcie reset gpio export

2019-07-26 Thread Enrico Weigelt, metux IT consult
On 26.07.19 08:21, Florian Eckert wrote: On APUx we have also mpcie2/mpcie3 reset pins. To make it possible to reset the ports from the userspace, add the definition to this platform device. The gpio can then be exported by the legancy gpio subsystem to toggle the mpcie reset pin.

Re: [RFC PATCH 33/40] soundwire: intel: Add basic power management support

2019-07-26 Thread Cezary Rojewski
On 2019-07-26 01:40, Pierre-Louis Bossart wrote: +static int intel_resume(struct device *dev) +{ + struct sdw_intel *sdw; + int ret; + + sdw = dev_get_drvdata(dev); + + ret = intel_init(sdw); + if (ret) { + dev_err(dev, "%s failed: %d", __func__, ret);

BUG: soft lockup in tcp_write_timer

2019-07-26 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:13bf6d6a Add linux-next specific files for 20190725 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=12b1c1f060 kernel config: https://syzkaller.appspot.com/x/.config?x=8ae987d803395886

Re: [PATCH v2 1/3] dt-bindings: switch Exynos EHCI/OHCI bindings to use array of generic PHYs

2019-07-26 Thread Krzysztof Kozlowski
On Fri, 26 Jul 2019 at 10:15, Marek Szyprowski wrote: > > Commit 69bec7259853 ("USB: core: let USB device know device node") added > support for attaching devicetree node for USB devices. Those nodes are > children of their USB host controller. However Exynos EHCI and OHCI > driver bindings

KASAN: use-after-free Read in bpf_get_prog_name

2019-07-26 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:192f0f8e Merge tag 'powerpc-5.3-1' of git://git.kernel.org.. git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=170afe6460 kernel config: https://syzkaller.appspot.com/x/.config?x=87305c3ca9c25c70

Re: possible deadlock in rxrpc_put_peer

2019-07-26 Thread Dmitry Vyukov
On Fri, Jul 26, 2019 at 11:38 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:6d21a41b Add linux-next specific files for 20190718 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=174e3af060 > kernel config:

[PATCH] dmaengine: pl330: use the same attributes when freeing pl330->mcode_cpu

2019-07-26 Thread Fuqian Huang
In function dmac_alloc_resources(), pl330->mcode_cpu is allocated using dma_alloc_attrs() but freed with dma_free_coherent(). Use the correct dma_free_attrs() function to free pl330->mcode_cpu. Signed-off-by: Fuqian Huang --- drivers/dma/pl330.c | 9 + 1 file changed, 5 insertions(+), 4

Re: [PATCH 4.19 079/271] x86/atomic: Fix smp_mb__{before,after}_atomic()

2019-07-26 Thread Peter Zijlstra
On Fri, Jul 26, 2019 at 01:18:06PM +0300, Jari Ruusu wrote: > Greg Kroah-Hartman wrote: > > [ Upstream commit 69d927bba39517d0980462efc051875b7f4db185 ] > > > > Recent probing at the Linux Kernel Memory Model uncovered a > > 'surprise'. Strongly ordered architectures where the atomic RmW > >

Re: [PATCH 1/2] ipmr: Make cache queue length configurable

2019-07-26 Thread Nikolay Aleksandrov
On 25/07/2019 23:42, Brodie Greenfield wrote: > We want to be able to keep more spaces available in our queue for > processing incoming multicast traffic (adding (S,G) entries) - this lets > us learn more groups faster, rather than dropping them at this stage. > > Signed-off-by: Brodie Greenfield

[PATCH] staging: iio: ad2s1210: Use device-managed API

2019-07-26 Thread Chuhong Yuan
Use device-managed API to simplify the code. The remove function is redundant now and can be deleted. Signed-off-by: Chuhong Yuan --- drivers/staging/iio/resolver/ad2s1210.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1210.c

Re: [RFC PATCH 27/40] soundwire: Add Intel resource management algorithm

2019-07-26 Thread Cezary Rojewski
On 2019-07-26 01:40, Pierre-Louis Bossart wrote: This algorithm computes bus parameters like clock frequency, frame shape and port transport parameters based on active stream(s) running on the bus. This implementation is optimal for Intel platforms. Developers can also implement their own

Re: [PATCH v1] mm/memory_hotplug: Remove move_pfn_range()

2019-07-26 Thread Oscar Salvador
On Wed, Jul 24, 2019 at 04:23:24PM +0200, David Hildenbrand wrote: > Let's remove this indirection. We need the zone in the caller either > way, so let's just detect it there. Add some documentation for > move_pfn_range_to_zone() instead. > > Cc: Andrew Morton > Cc: Oscar Salvador > Cc: Michal

Re: [PATCH 00/15] thermal: qcom: tsens: Add interrupt support

2019-07-26 Thread Amit Kucheria
(Resending from a desktop client because mobile gmail apparently sends html that gets rejected by all lists) On Fri, Jul 26, 2019 at 4:06 PM Brian Masney wrote: > > Hi Amit, > > On Fri, Jul 26, 2019 at 03:48:35AM +0530, Amit Kucheria wrote: > > Add interrupt support to TSENS. The first 6 patches

Re: [v4 1/6] dt-bindings: media: Document bindings for DW MIPI CSI-2 Host

2019-07-26 Thread Eugen.Hristev
On 26.07.2019 12:50, Luis de Oliveira wrote: > Hi Sakari, > > Thank you for the review, my answers inline. > >> From: Sakari Ailus >> Date: Thu, Jul 25, 2019 at 21:02:11 >> >> Hi Luis, >> >> On Wed, Jul 10, 2019 at 10:20:55AM +, Luis de Oliveira wrote: >>> Hi Sakari, >>> >>> From: Sakari

[PATCH] nvme: allow 64-bit results in passthru commands

2019-07-26 Thread Marta Rybczynska
It is not possible to get 64-bit results from the passthru commands, what prevents from getting for the Capabilities (CAP) property value. This issue has been already discussed [1], but without a solution. This patch solves the problem by adding new ioctls with a new passthru structure,

Re: [RFC PATCH 00/40] soundwire: updates for 5.4

2019-07-26 Thread Cezary Rojewski
On 2019-07-26 01:39, Pierre-Louis Bossart wrote: The existing upstream code allows for SoundWire devices to be enumerated and managed by the bus, but streaming is not currently supported. Bard Liao, Rander Wang and I did quite a bit of integration/validation work to close this gap and we now

Re: [PATCH 1/2] ipmr: Make cache queue length configurable

2019-07-26 Thread Nikolay Aleksandrov
On 26/07/2019 14:05, Nikolay Aleksandrov wrote: > On 25/07/2019 23:42, Brodie Greenfield wrote: >> We want to be able to keep more spaces available in our queue for >> processing incoming multicast traffic (adding (S,G) entries) - this lets >> us learn more groups faster, rather than dropping them

Re: [PATCH] Revert "ASoC: rockchip: i2s: Support mono capture"

2019-07-26 Thread Mark Brown
On Fri, Jul 26, 2019 at 12:42:02PM +0800, Cheng-Yi Chiang wrote: > This reverts commit db51707b9c9aeedd310ebce60f15d5bb006567e0. > > Previous discussion in Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches. Please

[PATCH v3] seqlock: mark raw_read_seqcount and read_seqcount_retry as __always_inline

2019-07-26 Thread Anders Roxell
With the function graph tracer, each traced function calls sched_clock() to take a timestamp. As sched_clock() uses raw_read_seqcount()/read_seqcount_retry(), we must ensure that these do not in turn trigger the graph tracer. Both functions is marked as inline. However, if CONFIG_OPTIMIZE_INLINING

[PATCH v2] staging: most: Use DEFINE_SPINLOCK() instead of struct spinlock

2019-07-26 Thread Thomas Gleixner
From: Sebastian Andrzej Siewior For spinlocks the type spinlock_t should be used instead of "struct spinlock". Use DEFINE_SPINLOCK() and spare the run time initialization Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Link:

[PATCH] arm_pmu: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default the following warning was starting to show up: ../drivers/perf/arm_pmu.c: In function ‘cpu_pm_pmu_notify’: ../drivers/perf/arm_pmu.c:726:3: warning: this statement may fall through [-Wimplicit-fallthrough=] cpu_pm_pmu_setup(armpmu, cmd);

[PATCH 1/3] arm64: perf: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default, commit d93512ef0f0e ("Makefile: Globally enable fall-through warning"), the following warnings was starting to show up: ../arch/arm64/kernel/hw_breakpoint.c: In function ‘hw_breakpoint_arch_parse’: ../arch/arm64/kernel/hw_breakpoint.c:540:7:

[PATCH 1/2] arm64: KVM: regmap: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default, commit d93512ef0f0e ("Makefile: Globally enable fall-through warning"), the following warnings was starting to show up: In file included from ../arch/arm64/include/asm/kvm_emulate.h:19, from ../arch/arm64/kvm/regmap.c:13:

[PATCH 2/3] arm64: module: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default the following warnings was starting to show up: ../arch/arm64/kernel/module.c: In function ‘apply_relocate_add’: ../arch/arm64/kernel/module.c:316:19: warning: this statement may fall through [-Wimplicit-fallthrough=] overflow_check = false;

[PATCH 3/3] arm64: smp: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default the following warning was starting to show up: In file included from ../include/linux/kernel.h:15, from ../include/linux/list.h:9, from ../include/linux/kobject.h:19, from

[PATCH] drm: mali-dp: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default, commit d93512ef0f0e ("Makefile: Globally enable fall-through warning"), the following warnings was starting to show up: ../drivers/gpu/drm/arm/malidp_hw.c: In function ‘malidp_format_get_bpp’: ../drivers/gpu/drm/arm/malidp_hw.c:387:8: warning:

[PATCH] arm: perf: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default, d93512ef0f0e ("Makefile: Globally enable fall-through warning"), we could see the following warnings was starting to show up. However, this was originally introduced in commit 6ee33c2712fc ("ARM: hw_breakpoint: correct and simplify alignment fixup

[PATCH 1/3] drm: msm: a6xx: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default the following warning was starting to show up: ../drivers/gpu/drm/msm/adreno/a6xx_gpu.c: In function ‘a6xx_submit’: ../drivers/gpu/drm/msm/adreno/a6xx_gpu.c:116:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if

[PATCH 2/3] drm: msm: a5xx: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default the following warning was starting to show up: ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c: In function ‘a5xx_submit’: ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:150:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if

[PATCH 2/2] pinctrl: qcom: spmi-gpio: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default the following warnings was starting to show up: ../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c: In function ‘pmic_gpio_populate’: ../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:815:20: warning: this statement may fall through [-Wimplicit-fallthrough=]

[PATCH] irqchip: gic-v3: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default the following warning was starting to show up: In file included from ../arch/arm64/include/asm/cputype.h:132, from ../arch/arm64/include/asm/cache.h:8, from ../include/linux/cache.h:6, from

[PATCH 1/2] pinctrl: rockchip: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default the following warning was starting to show up: ../drivers/pinctrl/pinctrl-rockchip.c: In function ‘rockchip_gpio_set_config’: ../drivers/pinctrl/pinctrl-rockchip.c:2783:3: warning: this statement may fall through [-Wimplicit-fallthrough=]

[PATCH] KVM: arm: vgic-v3: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default the following warnings was starting to show up: ../virt/kvm/arm/hyp/vgic-v3-sr.c: In function ‘__vgic_v3_save_aprs’: ../virt/kvm/arm/hyp/vgic-v3-sr.c:351:24: warning: this statement may fall through [-Wimplicit-fallthrough=]

[PATCH] iommu: arm-smmu-v3: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default, commit d93512ef0f0e ("Makefile: Globally enable fall-through warning"), the following warning was starting to show up: ../drivers/iommu/arm-smmu-v3.c: In function ‘arm_smmu_write_strtab_ent’: ../drivers/iommu/arm-smmu-v3.c:1189:7: warning: this

[PATCH 3/3] drm: msm: a3xx: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default the following warning was starting to show up: ../drivers/gpu/drm/msm/adreno/adreno_gpu.c: In function ‘adreno_submit’: ../drivers/gpu/drm/msm/adreno/adreno_gpu.c:429:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if

Re: [PATCH 6/6] dt-bindings: spi: sprd: Change the hwlock support to be optional

2019-07-26 Thread Mark Brown
On Fri, Jul 26, 2019 at 03:20:53PM +0800, Baolin Wang wrote: > No need to add hardware spinlock proctection due to add multiple > msater channel, so change it to be optional in documentation. Please use subject lines matching the style for the subsystem. This makes it easier for people to

Re: [PATCH 00/15] thermal: qcom: tsens: Add interrupt support

2019-07-26 Thread Brian Masney
Hi Amit, On Fri, Jul 26, 2019 at 04:40:16PM +0530, Amit Kucheria wrote: > > The device tree nodes appear in sysfs: > > > > / # ls -1 /sys/class/thermal/ > > cooling_device0 > > cooling_device1 > > thermal_zone0 > > thermal_zone1 > > thermal_zone2 > > thermal_zone3 > > thermal_zone4 > >

[PATCH][next] intel_th: msu: fix overflow in shift of an unsigned int

2019-07-26 Thread Colin King
From: Colin Ian King The shift of the unsigned int win->nr_blocks by PAGE_SHIFT may potentially overflow. Note that the intended return of this shift is expected to be a size_t however the shift is being performed as an unsigned int. Fix this by casting win->nr_blocks to a size_t before

Re: [RFC PATCH v2 0/4] Input: mpr121-polled: Add polled driver for MPR121

2019-07-26 Thread Michal Vokáč
On 25. 07. 19 16:40, Dmitry Torokhov wrote: On Thu, Jul 25, 2019 at 02:58:02PM +0200, Michal Vokáč wrote: On 25. 07. 19 10:57, Dmitry Torokhov wrote: Hi Michal, On Tue, May 21, 2019 at 08:51:17AM +0200, Michal Vokáč wrote: On 21. 05. 19 7:37, Dmitry Torokhov wrote: Hi Michal, On Fri, May

Re: [PATCH v2] 8250_lpss: check null return when calling pci_ioremap_bar

2019-07-26 Thread Bartlomiej Zolnierkiewicz
Hi, On 7/19/19 7:48 PM, Navid Emamdoost wrote: > pci_ioremap_bar may return null. This is eventually de-referenced at > drivers/dma/dw/core.c:1154 and drivers/dma/dw/core.c:1168. A null check > is needed to prevent null de-reference. I am adding the check and in case > of failure. Thanks to

Re: [Regression] Missing device nodes for ETR, ETF and STM after CONFIG_UEVENT_HELPER=n

2019-07-26 Thread Thomas Petazzoni
Hello, On Fri, 26 Jul 2019 12:19:25 +0200 Greg Kroah-Hartman wrote: > > This somehow is not mounting etr, etf, stm devices when uevent-helper is > > disabled. Anyways as Suzuki mentioned, using devtmpfs does fix the issue. > > Last I looked (many years ago) mdev requires uevent-helper in

Re: [Regression] Missing device nodes for ETR, ETF and STM after CONFIG_UEVENT_HELPER=n

2019-07-26 Thread Greg Kroah-Hartman
On Fri, Jul 26, 2019 at 01:33:16PM +0200, Thomas Petazzoni wrote: > Hello, > > On Fri, 26 Jul 2019 12:19:25 +0200 > Greg Kroah-Hartman wrote: > > > > This somehow is not mounting etr, etf, stm devices when uevent-helper is > > > disabled. Anyways as Suzuki mentioned, using devtmpfs does fix the

Re: [PATCH 1/2] net: ipv6: Fix a possible null-pointer dereference in ip6_xmit()

2019-07-26 Thread Willem de Bruijn
On Fri, Jul 26, 2019 at 4:03 AM Jia-Ju Bai wrote: > > In ip6_xmit(), there is an if statement on line 245 to check whether > np is NULL: > if (np) > > When np is NULL, it is used on line 251: > ip6_autoflowlabel(net, np) > if (!np->autoflowlabel_set) > > Thus, a possible

Re: Limits for ION Memory Allocator

2019-07-26 Thread Joel Fernandes
On Wed, Jul 24, 2019 at 4:24 PM John Stultz wrote: > > On Wed, Jul 24, 2019 at 1:18 PM John Stultz wrote: > > > > On Wed, Jul 24, 2019 at 12:36 PM Laura Abbott wrote: > > > > > > On 7/17/19 12:31 PM, Alexander Popov wrote: > > > > Hello! > > > > > > > > The syzkaller [1] has a trouble with

Re: [PATCH REBASE v4 14/14] riscv: Make mmap allocation top-down by default

2019-07-26 Thread Alexandre Ghiti
On 7/26/19 2:20 AM, Paul Walmsley wrote: Hi Alexandre, I have a few questions about this patch. Sorry to be dense here ... On Wed, 24 Jul 2019, Alexandre Ghiti wrote: In order to avoid wasting user address space by using bottom-up mmap allocation scheme, prefer top-down scheme when

Re: [PATCH] can: ti_hecc: use timestamp based rx-offloading

2019-07-26 Thread Marc Kleine-Budde
On 4/29/19 2:03 PM, Jeroen Hofstee wrote: > As already mentioned in [1] and included in [2], there is an off by one > issue since the high bank is already enabled when the _next_ mailbox to > be read has index 12, so the mailbox being read was 13. The message can > therefore go into mailbox 31 and

Re: WARNING in __mmdrop

2019-07-26 Thread Michael S. Tsirkin
On Thu, Jul 25, 2019 at 10:25:25PM +0800, Jason Wang wrote: > > On 2019/7/25 下午9:26, Michael S. Tsirkin wrote: > > > Exactly, and that's the reason actually I use synchronize_rcu() there. > > > > > > So the concern is still the possible synchronize_expedited()? > > I think

[PATCH] vhost: disable metadata prefetch optimization

2019-07-26 Thread Michael S. Tsirkin
This seems to cause guest and host memory corruption. Disable for now until we get a better handle on that. Signed-off-by: Michael S. Tsirkin --- I put this in linux-next, we'll re-enable if we can fix the outstanding issues in a short order. drivers/vhost/vhost.h | 2 +- 1 file changed, 1

[PATCH] Bluetooth: btusb: Fix suspend issue for Realtek

2019-07-26 Thread Alex Lu
From: Alex Lu >From the perspective of controller, global suspend means there is no SET_FEATURE (DEVICE_REMOTE_WAKEUP) and controller would drop the firmware. It would consume less power. So we should not send this kind of SET_FEATURE when host goes to suspend state. Otherwise, when making

Re: [PATCH] vhost: disable metadata prefetch optimization

2019-07-26 Thread Jason Wang
On 2019/7/26 下午7:51, Michael S. Tsirkin wrote: This seems to cause guest and host memory corruption. Disable for now until we get a better handle on that. Signed-off-by: Michael S. Tsirkin --- I put this in linux-next, we'll re-enable if we can fix the outstanding issues in a short order.

Re: [PATCH v2] 8250_lpss: check null return when calling pci_ioremap_bar

2019-07-26 Thread Andy Shevchenko
On Fri, Jul 26, 2019 at 01:32:21PM +0200, Bartlomiej Zolnierkiewicz wrote: > On 7/19/19 7:48 PM, Navid Emamdoost wrote: > > pci_ioremap_bar may return null. This is eventually de-referenced at > > drivers/dma/dw/core.c:1154 and drivers/dma/dw/core.c:1168. A null check > > is needed to prevent

Re: [RFC][PATCH 1/5] exit: kill struct waitid_info

2019-07-26 Thread Eric W. Biederman
Christian Brauner writes: > On Thu, Jul 25, 2019 at 07:46:50AM -0500, Eric W. Biederman wrote: >> Linus Torvalds writes: >> >> > On Wed, Jul 24, 2019 at 7:47 AM Christian Brauner >> > wrote: >> >> >> >> The code here uses a struct waitid_info to catch basic information about >> >> process

Regression in 5.3 for some FS_USERNS_MOUNT (aka user-namespace-mountable) filesystems

2019-07-26 Thread Christian Brauner
Hey everyone, We have another mount api regression. With current 5.3-rc1 it is not possible anymore to mount filesystems that have FS_USERNS_MOUNT set and their fs_context's global member set to true. At least sysfs is affected, likely also cgroup{2}fs. The commit that introduced the regression

Re: [PATCH v3] kasan: add memory corruption identification for software tag-based mode

2019-07-26 Thread Andrey Ryabinin
On 7/22/19 12:52 PM, Walter Wu wrote: > On Thu, 2019-07-18 at 19:11 +0300, Andrey Ryabinin wrote: >> >> On 7/15/19 6:06 AM, Walter Wu wrote: >>> On Fri, 2019-07-12 at 13:52 +0300, Andrey Ryabinin wrote: On 7/11/19 1:06 PM, Walter Wu wrote: > On Wed, 2019-07-10 at 21:24 +0300,

Re: WARNING in __mmdrop

2019-07-26 Thread Jason Wang
On 2019/7/26 下午7:49, Michael S. Tsirkin wrote: On Thu, Jul 25, 2019 at 10:25:25PM +0800, Jason Wang wrote: On 2019/7/25 下午9:26, Michael S. Tsirkin wrote: Exactly, and that's the reason actually I use synchronize_rcu() there. So the concern is still the possible synchronize_expedited()? I

[PATCH] intel_th: msu: fix missing allocation failure check on a kstrndup

2019-07-26 Thread Colin King
From: Colin Ian King kstrndup can potentially return NULL, so add a null memory check to avoid a null pointer reference later on. Addresses-Coverity: ("Dereference null return") Fixes: 615c164da0eb ("intel_th: msu: Introduce buffer interface") Signed-off-by: Colin Ian King ---

[PATCH v2] ASoC: rockchip: i2s: Revert "ASoC: rockchip: i2s: Support mono capture"

2019-07-26 Thread Cheng-Yi Chiang
This reverts commit db51707b9c9aeedd310ebce60f15d5bb006567e0. Commit db51707b9c9a ("ASoC: rockchip: i2s: Support mono capture") adds support of mono capture to rockchip_i2s_dai. However, I2S controller is still generating a 2-channel stream because it only supports even number of channels. When

Re: [PATCH 2/7] vmpressure: Use spinlock_t instead of struct spinlock

2019-07-26 Thread Thomas Gleixner
On Thu, 4 Jul 2019, Sebastian Andrzej Siewior wrote: Polite reminder ... > For spinlocks the type spinlock_t should be used instead of "struct > spinlock". > > Use spinlock_t for spinlock's definition. > > Cc: linux...@kvack.org > Cc: Andrew Morton > Signed-off-by: Sebastian Andrzej Siewior

Re: [PATCH 6/6] dt-bindings: spi: sprd: Change the hwlock support to be optional

2019-07-26 Thread Baolin Wang
Hi Mark, On Fri, 26 Jul 2019 at 19:29, Mark Brown wrote: > > On Fri, Jul 26, 2019 at 03:20:53PM +0800, Baolin Wang wrote: > > No need to add hardware spinlock proctection due to add multiple > > msater channel, so change it to be optional in documentation. > > Please use subject lines matching

Re: [PATCH 1/3] arm64: perf: Mark expected switch fall-through

2019-07-26 Thread Mark Rutland
On Fri, Jul 26, 2019 at 01:27:16PM +0200, Anders Roxell wrote: > When fall-through warnings was enabled by default, commit d93512ef0f0e > ("Makefile: Globally enable fall-through warning"), the following > warnings was starting to show up: > > ../arch/arm64/kernel/hw_breakpoint.c: In function

Re: [PATCH] Revert "ASoC: rockchip: i2s: Support mono capture"

2019-07-26 Thread Cheng-yi Chiang
On Fri, Jul 26, 2019 at 7:17 PM Mark Brown wrote: > > On Fri, Jul 26, 2019 at 12:42:02PM +0800, Cheng-Yi Chiang wrote: > > This reverts commit db51707b9c9aeedd310ebce60f15d5bb006567e0. > > > > Previous discussion in > > Please use subject lines matching the style for the subsystem. This > makes

Re: linux-next: Fixes tag needs some work in the sound-asoc tree

2019-07-26 Thread Mark Brown
On Fri, Jul 26, 2019 at 09:04:37AM +0300, Peter Ujfalusi wrote: > Mark: can you either drop the patch and I'll send a new one with fixed > SHA1 or can you fix the commit message in place? Both of which involve rebasing :( Against my better judgement I rebased. signature.asc Description: PGP

Re: [PATCH v1 1/2] extcon: axp288: Add missed error check

2019-07-26 Thread Andy Shevchenko
On Fri, Jul 26, 2019 at 10:15:30AM +0900, Chanwoo Choi wrote: > On 19. 7. 26. 오전 5:34, Andy Shevchenko wrote: > > It seems from the very beginning the error check has been missed > > in axp288_extcon_log_rsi(). Add it here. > > ret = regmap_read(info->regmap, AXP288_PS_BOOT_REASON_REG, ); > >

Applied "spi: sprd: adi: Add a reset reason for watchdog mode" to the spi tree

2019-07-26 Thread Mark Brown
The patch spi: sprd: adi: Add a reset reason for watchdog mode has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours)

Applied "spi: sprd: adi: Add a reset reason for TOS panic" to the spi tree

2019-07-26 Thread Mark Brown
The patch spi: sprd: adi: Add a reset reason for TOS panic has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and

<    1   2   3   4   5   6   7   8   9   10   >